language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
1b3fd9edfffd78a90da820d04455acbdbc3d4661.json
Ensure one time logging for request details Closes gh-26969
spring-test/src/main/java/org/springframework/test/web/reactive/server/ExchangeResult.java
@@ -79,6 +79,9 @@ public class ExchangeResult { @Nullable private final Object mockServerResult; + /** Ensure single logging, e.g. for expectAll. */ + private boolean diagnosticsLogged; + /** * Create an instance with an HTTP request and response along with promises @@ -121,6 +124,7 @@ public class Exchang...
true
Other
spring-projects
spring-framework
1b3fd9edfffd78a90da820d04455acbdbc3d4661.json
Ensure one time logging for request details Closes gh-26969
spring-test/src/test/java/org/springframework/test/web/reactive/server/samples/SoftAssertionTests.java
@@ -46,15 +46,19 @@ void expectAll() { } @Test - void expectAllWithMultipleFailures() throws Exception { - assertThatExceptionOfType(AssertionError.class).isThrownBy(() -> - this.webTestClient.get().uri("/test").exchange() - .expectAll( - responseSpec -> responseSpec.expectStatus().isBadRequest(), - ...
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/StubMvcResult.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/DelegatingWebConnectionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/UrlRegexRequestMatcherTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/result/HeaderResultMatchersTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/context/PersonController.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/context/PersonDao.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resulthandlers/PrintingResultHandlerSmokeTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/FlashAttributeAssertionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/ModelAssertionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/RequestAttributeAssertionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
434cbab6a7147ebb7f51078cb14422fe26f1798a.json
Update copyright date in tests in spring-test Closes gh-27354
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/SessionAttributeAssertionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
true
Other
spring-projects
spring-framework
310bdbb1b204bcb1e4b241d73b81df9bc153e9ac.json
Fix error in ApplicationEvents example
src/docs/asciidoc/testing.adoc
@@ -2613,7 +2613,7 @@ published while invoking a method in a Spring-managed component: // Invoke method in OrderService that publishes an event orderService.submitOrder(new Order(/* ... */)); // Verify that an OrderSubmitted event was published - int numEvents = events.stream(OrderSubmitted.class).count()...
false
Other
spring-projects
spring-framework
88af24c1cb5cb0325c2322e0efdc109e4eceb487.json
Update copyright date
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactory.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2021 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
false
Other
spring-projects
spring-framework
e5a5f8b20b00a896bb1edad5fbc13f982cd0e6ca.json
Remove unnecessary brace in websocket documenation Closes gh-#27339
src/docs/asciidoc/web/websocket.adoc
@@ -1177,7 +1177,7 @@ We can trace the flow through a simple example. Consider the following example, @Controller public class GreetingController { - @MessageMapping("/greeting") { + @MessageMapping("/greeting") public String handle(String greeting) { return "[" + getTimestamp() + ": " + greeting; }
false
Other
spring-projects
spring-framework
8d3e8ca3a2d534f6ee872bb6a65a89c44e987cf6.json
Optimize allocation in StringUtils#cleanPath This commit applies several optimizations to StringUtils#cleanPath and related methods: * pre-size pathElements deque in StringUtils#cleanPath with pathElements.length elements, since this this is the maximum size and the most likely case. * optimize StringUtils#collec...
spring-core/src/main/java/org/springframework/util/StringUtils.java
@@ -667,7 +667,9 @@ public static String cleanPath(String path) { if (!hasLength(path)) { return path; } - String pathToUse = replace(path, WINDOWS_FOLDER_SEPARATOR, FOLDER_SEPARATOR); + + String normalizedPath = replace(path, WINDOWS_FOLDER_SEPARATOR, FOLDER_SEPARATOR); + String pathToUse = normalizedPath...
true
Other
spring-projects
spring-framework
8d3e8ca3a2d534f6ee872bb6a65a89c44e987cf6.json
Optimize allocation in StringUtils#cleanPath This commit applies several optimizations to StringUtils#cleanPath and related methods: * pre-size pathElements deque in StringUtils#cleanPath with pathElements.length elements, since this this is the maximum size and the most likely case. * optimize StringUtils#collec...
spring-core/src/test/java/org/springframework/util/StringUtilsTests.java
@@ -402,6 +402,8 @@ void cleanPath() { assertThat(StringUtils.cleanPath("file:.././")).isEqualTo("file:../"); assertThat(StringUtils.cleanPath("file:/mypath/spring.factories")).isEqualTo("file:/mypath/spring.factories"); assertThat(StringUtils.cleanPath("file:///c:/some/../path/the%20file.txt")).isEqualTo("fil...
true
Other
spring-projects
spring-framework
debf61b948fd44a8757c4a8c286202ca3b6762b5.json
Remove unused private loggers Closes gh-27336
spring-context/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java
@@ -20,8 +20,6 @@ import java.lang.annotation.RetentionPolicy; import java.lang.reflect.Method; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.aspectj.lang.JoinPoint; import org.aspectj.lang.ProceedingJoinPoint; import org.aspectj.lang.annotation.Around; @@ -40,...
true
Other
spring-projects
spring-framework
debf61b948fd44a8757c4a8c286202ca3b6762b5.json
Remove unused private loggers Closes gh-27336
spring-context/src/test/java/org/springframework/context/expression/ApplicationContextExpressionTests.java
@@ -28,8 +28,6 @@ import java.util.Optional; import java.util.Properties; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.ObjectFactory; @@ -40,7 +38,6 @@ import org.springframework.beans.factory....
true
Other
spring-projects
spring-framework
debf61b948fd44a8757c4a8c286202ca3b6762b5.json
Remove unused private loggers Closes gh-27336
spring-tx/src/main/java/org/springframework/transaction/support/TransactionSynchronizationManager.java
@@ -24,9 +24,6 @@ import java.util.Map; import java.util.Set; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; - import org.springframework.core.NamedThreadLocal; import org.springframework.core.OrderComparator; import org.springframework.lang.Nullable; @@ -76,8 +73,6 @@ *...
true
Other
spring-projects
spring-framework
debf61b948fd44a8757c4a8c286202ca3b6762b5.json
Remove unused private loggers Closes gh-27336
spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java
@@ -55,13 +55,11 @@ import com.fasterxml.jackson.dataformat.xml.JacksonXmlModule; import com.fasterxml.jackson.dataformat.xml.XmlFactory; import com.fasterxml.jackson.dataformat.xml.XmlMapper; -import org.apache.commons.logging.Log; import org.springframework.beans.BeanUtils; import org.springframework.beans.Fat...
true
Other
spring-projects
spring-framework
9a7fb7022dd5b7d2d8d5514ab2fb827b3e32854a.json
Fix typo in @Scheduled See gh-27309
spring-context/src/main/java/org/springframework/scheduling/annotation/Scheduled.java
@@ -166,7 +166,7 @@ * The {@link TimeUnit} to use for {@link #fixedDelay}, {@link #fixedDelayString}, * {@link #fixedRate}, {@link #fixedRateString}, {@link #initialDelay}, and * {@link #initialDelayString}. - * <p>Defaults to {@link TimeUnit#MICROSECONDS}. + * <p>Defaults to {@link TimeUnit#MILLISECONDS}. ...
false
Other
spring-projects
spring-framework
25dca404138e85e8864e4bfa4b37c88f236a559e.json
Introduce soft assertions for WebTestClient It happens very often that WebTestClient is used in heavyweight integration tests, and it's a hindrance to developer productivity to fix one failed assertion after another. Soft assertions help a lot by checking all conditions at once even if one of them fails. This commit ...
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java
@@ -21,6 +21,7 @@ import java.nio.charset.StandardCharsets; import java.time.Duration; import java.time.ZonedDateTime; +import java.util.ArrayList; import java.util.Arrays; import java.util.LinkedHashMap; import java.util.List; @@ -507,6 +508,24 @@ public <T> FluxExchangeResult<T> returnResult(ParameterizedTypeRe...
true
Other
spring-projects
spring-framework
25dca404138e85e8864e4bfa4b37c88f236a559e.json
Introduce soft assertions for WebTestClient It happens very often that WebTestClient is used in heavyweight integration tests, and it's a hindrance to developer productivity to fix one failed assertion after another. Soft assertions help a lot by checking all conditions at once even if one of them fails. This commit ...
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -845,6 +845,11 @@ interface ResponseSpec { * about a target type with generics. */ <T> FluxExchangeResult<T> returnResult(ParameterizedTypeReference<T> elementTypeRef); + + /** + * Array of assertions to test together a.k.a. soft assertions. + */ + ResponseSpec expectAllSoftly(ResponseSpecMatcher......
true
Other
spring-projects
spring-framework
25dca404138e85e8864e4bfa4b37c88f236a559e.json
Introduce soft assertions for WebTestClient It happens very often that WebTestClient is used in heavyweight integration tests, and it's a hindrance to developer productivity to fix one failed assertion after another. Soft assertions help a lot by checking all conditions at once even if one of them fails. This commit ...
spring-test/src/test/java/org/springframework/test/web/reactive/server/samples/SoftAssertionTests.java
@@ -0,0 +1,75 @@ +/* + * Copyright 2002-2021 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
35bec8102b014feac18c5b096b39c3592c27b76e.json
Introduce soft assertions for MockMvc It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See gh-26917 Co-authored-by: Sach ...
spring-test/src/main/java/org/springframework/test/web/servlet/ResultActions.java
@@ -42,7 +42,7 @@ public interface ResultActions { * .andExpect(jsonPath("$.person.name").value("Jason")); * </pre> * - * <p>Or alternatively provide all matchers as a vararg: + * <p>Either provide all matchers as a vararg: * <pre class="code"> * static imports: MockMvcRequestBuilders.*, MockMvcResul...
true
Other
spring-projects
spring-framework
35bec8102b014feac18c5b096b39c3592c27b76e.json
Introduce soft assertions for MockMvc It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See gh-26917 Co-authored-by: Sach ...
spring-test/src/main/java/org/springframework/test/web/servlet/ResultMatcher.java
@@ -16,6 +16,9 @@ package org.springframework.test.web.servlet; +import java.util.ArrayList; +import java.util.List; + /** * A {@code ResultMatcher} matches the result of an executed request against * some expectation. @@ -70,4 +73,30 @@ static ResultMatcher matchAll(ResultMatcher... matchers) { }; } +...
true
Other
spring-projects
spring-framework
35bec8102b014feac18c5b096b39c3592c27b76e.json
Introduce soft assertions for MockMvc It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertions help a lot by checking all conditions at once even if one of them fails. See gh-26917 Co-authored-by: Sach ...
spring-test/src/test/java/org/springframework/test/web/servlet/ResultMatcherTests.java
@@ -0,0 +1,66 @@ +/* + * Copyright 2002-2021 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4c153b80eef662af0d5ae3b316aa4f9f3d874e8a.json
Make ExceptionCollector.Executable public See gh-27316
spring-test/src/main/java/org/springframework/test/util/ExceptionCollector.java
@@ -118,7 +118,7 @@ public void assertEmpty() throws Exception { * except that an {@code Executable} can throw any kind of exception. */ @FunctionalInterface - interface Executable { + public interface Executable { void execute() throws Throwable;
false
Other
spring-projects
spring-framework
2899652d8ea1b68b92f94ba1f13e028f76c251cb.json
Fix checkstyle violation
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java
@@ -505,7 +505,7 @@ private static class DefaultResponseSpec implements ResponseSpec { this.statusHandlers.add(DEFAULT_STATUS_HANDLER); } - + @Override public ResponseSpec onStatus(Predicate<HttpStatus> statusPredicate, Function<ClientResponse, Mono<? extends Throwable>> exceptionFunction) {
false
Other
spring-projects
spring-framework
1f13516528a5884a1182649566a33f6dd0cc4e68.json
Fix @Transactional support on suspending function With this commit, @Transactional on suspending functions returning a value now commits the transaction properly. Closes gh-25998
spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java
@@ -875,8 +875,8 @@ public Object invokeWithinTransaction(Method method, @Nullable Class<?> targetCl String joinpointIdentification = methodIdentification(method, targetClass, txAttr); - // Optimize for Mono - if (Mono.class.isAssignableFrom(method.getReturnType())) { + // For Mono and suspending function...
true
Other
spring-projects
spring-framework
1f13516528a5884a1182649566a33f6dd0cc4e68.json
Fix @Transactional support on suspending function With this commit, @Transactional on suspending functions returning a value now commits the transaction properly. Closes gh-25998
spring-tx/src/test/kotlin/org/springframework/transaction/annotation/CoroutinesAnnotationTransactionInterceptorTests.kt
@@ -19,7 +19,6 @@ package org.springframework.transaction.annotation import kotlinx.coroutines.delay import kotlinx.coroutines.runBlocking import org.assertj.core.api.Assertions -import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test import org.springframework.aop.framework.ProxyFactory import or...
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketSession.java
@@ -80,6 +80,12 @@ public interface WebSocketSession { */ Mono<Void> send(Publisher<WebSocketMessage> messages); + /** + * Whether the underlying connection is open. + * @since 5.3.1 + */ + boolean isOpen(); + /** * Close the WebSocket session with {@link CloseStatus#NORMAL}. */
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketSession.java
@@ -113,6 +113,11 @@ else if (WebSocketMessage.Type.PONG.equals(message.getType())) { return true; } + @Override + public boolean isOpen() { + return getDelegate().isOpen(); + } + @Override public Mono<Void> close(CloseStatus status) { getDelegate().close(status.getCode(), status.getReason());
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/ReactorNettyWebSocketSession.java
@@ -15,10 +15,13 @@ */ package org.springframework.web.reactive.socket.adapter; +import java.util.function.Consumer; + import io.netty.handler.codec.http.websocketx.WebSocketFrame; import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; +import reactor.nett...
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/StandardWebSocketSession.java
@@ -103,6 +103,11 @@ else if (WebSocketMessage.Type.PONG.equals(message.getType())) { return true; } + @Override + public boolean isOpen() { + return getDelegate().isOpen(); + } + @Override public Mono<Void> close(CloseStatus status) { try {
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/UndertowWebSocketSession.java
@@ -108,6 +108,11 @@ else if (WebSocketMessage.Type.PONG.equals(message.getType())) { return true; } + @Override + public boolean isOpen() { + return getDelegate().isOpen(); + } + @Override public Mono<Void> close(CloseStatus status) { CloseMessage cm = new CloseMessage(status.getCode(), status.getReason...
true
Other
spring-projects
spring-framework
6bb3ad793eedd2f5eda98d5897ab207f081c87ec.json
Add isOpen to WebSocketSession in WebFlux Closes gh-26043
spring-websocket/src/main/java/org/springframework/web/socket/WebSocketSession.java
@@ -130,7 +130,7 @@ public interface WebSocketSession extends Closeable { void sendMessage(WebSocketMessage<?> message) throws IOException; /** - * Return whether the connection is still open. + * Whether the underlying connection is open. */ boolean isOpen();
true
Other
spring-projects
spring-framework
411539ffef01ab5559cf43db0f8118b7e4d10060.json
Update copyright date See gh-26044
spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/ViewResolverRegistry.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
false
Other
spring-projects
spring-framework
990a9c74b93b3124dae554e6246b9b75504a5d23.json
Restore removal of trailing semicolon content See gh-26012
spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java
@@ -618,10 +618,11 @@ private static String removeSemicolonContentInternal(String requestUri) { } StringBuilder sb = new StringBuilder(requestUri); while (semicolonIndex != -1) { - int slashIndex = requestUri.indexOf('/', semicolonIndex); - if (slashIndex >= 0) { - sb.delete(semicolonIndex, slashIndex);...
false
Other
spring-projects
spring-framework
7c9ad6dd08ccd613c4c9828d908de260ab2fb2aa.json
Add deprecation notes to the WebMvc config schema Closes gh-23915
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerMapping.java
@@ -63,7 +63,8 @@ * {@link #setUseRegisteredSuffixPatternMatch(boolean) useRegisteredSuffixPatternMatch} * are deprecated in order to discourage use of path extensions for request * mapping and for content negotiation (with similar deprecations in - * {@link ContentNegotiationManager}). For further context, pleas...
true
Other
spring-projects
spring-framework
7c9ad6dd08ccd613c4c9828d908de260ab2fb2aa.json
Add deprecation notes to the WebMvc config schema Closes gh-23915
spring-webmvc/src/main/resources/org/springframework/web/servlet/config/spring-mvc.xsd
@@ -36,7 +36,14 @@ <xsd:documentation><![CDATA[ Whether to use suffix pattern match (".*") when matching patterns to requests. If enabled a method mapped to "/users" also matches to "/users.*". - The default value is true. + + In 5.2.4, suffix pattern matching was deprecated in order to discourage use of p...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webflux/src/main/java/org/springframework/web/reactive/resource/VersionResourceResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -317,7 +317,7 @@ public InputStream getInput...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webflux/src/test/java/org/springframework/web/reactive/resource/ResourceWebHandlerTests.java
@@ -165,7 +165,7 @@ public void getVersionedResource() throws Exception { setPathWithinHandlerMapping(exchange, "versionString/foo.css"); this.handler.handle(exchange).block(TIMEOUT); - assertThat(exchange.getResponse().getHeaders().getETag()).isEqualTo("\"versionString\""); + assertThat(exchange.getResponse(...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webflux/src/test/java/org/springframework/web/reactive/resource/VersionResourceResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -175,7 +175,7 @@ public void resolveResource...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/VersionResourceResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -313,7 +313,7 @@ public InputStream getInput...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java
@@ -152,7 +152,7 @@ public void getVersionedResource() throws Exception { this.request.setAttribute(HandlerMapping.PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE, "versionString/foo.css"); this.handler.handleRequest(this.request, this.response); - assertThat(this.response.getHeader("ETag")).isEqualTo("\"versionString\"...
true
Other
spring-projects
spring-framework
b883aad1f1541b07971f3f2e5da7ed9a9db8baf6.json
Use weak ETags in VersionResourceResolver Prior to this commit, the `VersionResourceResolver` implementations would write a strong ETag HTTP response header with the resolved version of the resource (the actual value depending on the chosen strategy). This approach doesn't work well when combined with HTTP compressio...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/VersionResourceResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -153,7 +153,7 @@ public void resolveResource...
true
Other
spring-projects
spring-framework
7bcda3a29bce4568aad89939987402320946bc5a.json
Update Javadoc for TestContextTransactionUtils See gh-24869
spring-test/src/main/java/org/springframework/test/context/transaction/TestContextTransactionUtils.java
@@ -144,9 +144,9 @@ public static DataSource retrieveDataSource(TestContext testContext, @Nullable S * <li>Look up the transaction manager by type and explicit name, if the supplied * {@code name} is non-empty, throwing a {@link BeansException} if the named * transaction manager does not exist. - * <li>Attemp...
false
Other
spring-projects
spring-framework
0e9ecb6c99471a1efa4deb40149e4ddc48e33b92.json
Shortcut handling of bodyToFlux(DataBuffer.class) Given that the body is a Flux<DataBuffer> there probably could be a Flux<DataBuffer> body(); At least bodyToFlux(DataBuffer.class) which is used when mutating and is a common case should not incur overhead. See gh-24680
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientResponse.java
@@ -30,6 +30,7 @@ import org.springframework.core.ParameterizedTypeReference; import org.springframework.core.codec.Hints; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core.io.buffer.DataBufferUtils; import org.springframework.http.HttpHeaders; import org.springframework.http...
true
Other
spring-projects
spring-framework
0e9ecb6c99471a1efa4deb40149e4ddc48e33b92.json
Shortcut handling of bodyToFlux(DataBuffer.class) Given that the body is a Flux<DataBuffer> there probably could be a Flux<DataBuffer> body(); At least bodyToFlux(DataBuffer.class) which is used when mutating and is a common case should not incur overhead. See gh-24680
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java
@@ -36,6 +36,7 @@ import org.springframework.core.ParameterizedTypeReference; import org.springframework.core.codec.DecodingException; import org.springframework.core.codec.Hints; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.http.HttpCookie; import org.springframework.http.Http...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/HttpEntity.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -99,11 +99,7 @@ public HttpEntity(MultiValue...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/AbstractServerHttpRequest.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -76,7 +76,7 @@ public abstract class Abstrac...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/JettyHttpHandlerAdapter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -36,6 +36,7 @@ import org.springframework.h...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java
@@ -33,7 +33,6 @@ import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core.io.buffer.NettyDataBufferFactory; import org.springframework.http.HttpCookie; -import org.springframework.http.HttpHeaders; import org.springframework.lang.Nullable; import org.springframework.util.Assert; impo...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,6 +23,7 @@ import java.nio.charset.Char...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/TomcatHttpHandlerAdapter.java
@@ -44,6 +44,7 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.MediaType; import org.springframework.util.Assert; +import org.springframework.util.MultiValueMap; import org.springframework.util.ReflectionUtils; /** @@ -105,14 +106,13 @@ private static final class TomcatServerHttpR...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpRequest.java
@@ -38,7 +38,6 @@ import org.springframework.core.io.buffer.DataBufferWrapper; import org.springframework.core.io.buffer.PooledDataBuffer; import org.springframework.http.HttpCookie; -import org.springframework.http.HttpHeaders; import org.springframework.lang.Nullable; import org.springframework.util.Assert; imp...
true
Other
spring-projects
spring-framework
3276f818519f9bde187c4ccb83653c21c2e0e7fb.json
Avoid one layer of HttpHeaders wrapping See gh-24680
spring-webflux/src/main/java/org/springframework/web/reactive/result/view/DefaultRendering.java
@@ -32,7 +32,7 @@ */ class DefaultRendering implements Rendering { - private static final HttpHeaders EMPTY_HEADERS = HttpHeaders.readOnlyHttpHeaders(new HttpHeaders()); + private static final HttpHeaders EMPTY_HEADERS = HttpHeaders.EMPTY; private final Object view;
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
build.gradle
@@ -58,6 +58,7 @@ configure(allprojects) { project -> dependency "io.reactivex:rxjava:1.3.8" dependency "io.reactivex:rxjava-reactive-streams:1.2.1" dependency "io.reactivex.rxjava2:rxjava:2.2.19" + dependency "io.reactivex.rxjava3:rxjava:3.0.3" dependency "io.projectreactor.tools:blockhound:1.0.2.REL...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-core/spring-core.gradle
@@ -52,6 +52,7 @@ dependencies { optional("io.reactivex:rxjava") optional("io.reactivex:rxjava-reactive-streams") optional("io.reactivex.rxjava2:rxjava") + optional("io.reactivex.rxjava3:rxjava") optional("io.netty:netty-buffer") testCompile("io.projectreactor:reactor-test") testCompile("javax.annotation:ja...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-core/src/main/java/org/springframework/core/ReactiveAdapterRegistry.java
@@ -24,8 +24,6 @@ import java.util.concurrent.CompletionStage; import java.util.function.Function; -import io.reactivex.BackpressureStrategy; -import io.reactivex.Flowable; import kotlinx.coroutines.CompletableDeferredKt; import kotlinx.coroutines.Deferred; import org.reactivestreams.Publisher; @@ -46,8 +44,9 @@...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-core/src/test/java/org/springframework/core/ConventionsTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,8 +23,8 @@ import java.util.List; impo...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-core/src/test/java/org/springframework/core/ReactiveAdapterRegistryTests.java
@@ -21,17 +21,13 @@ import java.util.List; import java.util.concurrent.CompletableFuture; -import io.reactivex.Flowable; -import io.reactivex.Maybe; import kotlinx.coroutines.Deferred; +import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; import org.reactivestreams.Publisher; import reactor.c...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-messaging/spring-messaging.gradle
@@ -26,7 +26,7 @@ dependencies { testCompile("org.apache.activemq:activemq-kahadb-store") testCompile("org.apache.activemq:activemq-stomp") testCompile("io.projectreactor:reactor-test") - testCompile "io.reactivex.rxjava2:rxjava" + testCompile "io.reactivex.rxjava3:rxjava" testCompile("org.jetbrains.kotlin:kotl...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-messaging/src/test/java/org/springframework/messaging/handler/invocation/reactive/EncoderMethodReturnValueHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,7 +17,7 @@ import java.util.Collectio...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-messaging/src/test/java/org/springframework/messaging/rsocket/DefaultRSocketRequesterTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,9 +24,9 @@ import java.util.concurrent....
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-web/spring-web.gradle
@@ -18,9 +18,7 @@ dependencies { optional("javax.xml.bind:jaxb-api") optional("javax.xml.ws:jaxws-api") optional("org.glassfish.main:javax.jws") - optional("io.reactivex:rxjava") - optional("io.reactivex:rxjava-reactive-streams") - optional("io.reactivex.rxjava2:rxjava") + optional("io.reactivex.rxjava3:rxjava") ...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/spring-webflux.gradle
@@ -16,8 +16,6 @@ dependencies { optional("org.freemarker:freemarker") optional("com.fasterxml.jackson.core:jackson-databind") optional("com.fasterxml.jackson.dataformat:jackson-dataformat-smile") - optional("io.reactivex:rxjava") - optional("io.reactivex:rxjava-reactive-streams") optional("io.projectreactor.ne...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/function/BodyInsertersTests.java
@@ -30,7 +30,7 @@ import java.util.Optional; import com.fasterxml.jackson.annotation.JsonView; -import io.reactivex.Single; +import io.reactivex.rxjava3.core.Single; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import reactor.core.publisher.Flux;
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,7 +24,7 @@ import java.util.List; impo...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/HttpEntityMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,16 +21,15 @@ import java.util.List; im...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/MessageReaderArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -29,15 +29,15 @@ import javax.xml.bind.an...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/MessageWriterResultHandlerTests.java
@@ -27,13 +27,13 @@ import com.fasterxml.jackson.annotation.JsonTypeInfo; import com.fasterxml.jackson.annotation.JsonTypeName; -import io.reactivex.Flowable; +import io.reactivex.rxjava3.core.Completable; +import io.reactivex.rxjava3.core.Flowable; +import io.reactivex.rxjava3.core.Observable; import org.junit.ju...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ModelAttributeMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,12 +21,11 @@ import java.util.Map; imp...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ModelInitializerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,10 +23,10 @@ import java.util.Map; imp...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/PrincipalMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,7 +18,7 @@ import java.security.Princ...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestAttributeMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,7 +19,7 @@ import java.time.Duration; ...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestBodyMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,15 +22,15 @@ import java.util.Map; imp...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingMessageConversionIntegrationTests.java
@@ -26,14 +26,14 @@ import javax.xml.bind.annotation.XmlElement; import javax.xml.bind.annotation.XmlRootElement; -import io.reactivex.Flowable; -import io.reactivex.Maybe; +import io.reactivex.rxjava3.core.Completable; +import io.reactivex.rxjava3.core.Flowable; +import io.reactivex.rxjava3.core.Maybe; +import io....
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseBodyResultHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,11 +20,11 @@ import java.util.ArrayList...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java
@@ -28,13 +28,13 @@ import java.util.Set; import java.util.concurrent.CompletableFuture; +import io.reactivex.rxjava3.core.Completable; +import io.reactivex.rxjava3.core.Single; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import reactor.core.publisher.Flux; import reactor.core.pu...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/WebSessionMethodArgumentResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -15,7 +15,7 @@ */ package org.springframe...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/view/AbstractViewTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,8 +21,8 @@ import java.util.HashMap; i...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/java/org/springframework/web/reactive/result/view/ViewResolutionResultHandlerTests.java
@@ -26,11 +26,11 @@ import java.util.Map; import java.util.TreeMap; +import io.reactivex.rxjava3.core.Completable; import org.junit.jupiter.api.Test; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; import reactor.test.StepVerifier; -import rx.Completable; import org.springframework.co...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/ServerResponseExtensionsTests.kt
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,7 +19,7 @@ package org.springframework.w...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webmvc/spring-webmvc.gradle
@@ -59,9 +59,7 @@ dependencies { testCompile("org.hibernate:hibernate-validator") testCompile("javax.validation:validation-api") testCompile("io.projectreactor:reactor-core") - testCompile("io.reactivex:rxjava") - testCompile("io.reactivex:rxjava-reactive-streams") - testCompile("io.reactivex.rxjava2:rxjava") + t...
true
Other
spring-projects
spring-framework
7f59381c7df4641fae44e2cfc342acebd4b1ffff.json
Add support for RxJava 3 Closes gh-24170
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -26,14 +26,14 @@ import java.util.function....
true
Other
spring-projects
spring-framework
745cfcb1617cda2763e6e58d88889885883b7822.json
Upgrade tests to TestNG 7.1 See gh-24298
spring-test/src/test/java/org/springframework/test/context/cache/ClassLevelDirtiesContextTestNGTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,7 +21,6 @@ import org.junit.jupiter.api...
true
Other
spring-projects
spring-framework
745cfcb1617cda2763e6e58d88889885883b7822.json
Upgrade tests to TestNG 7.1 See gh-24298
spring-test/src/test/java/org/springframework/test/context/junit4/FailingBeforeAndAfterMethodsTestNGTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,7 +21,6 @@ import org.junit.runner.RunW...
true
Other
spring-projects
spring-framework
73e3df5df5f9b06f8b99840cdaf3affaa759324e.json
Fix typo in core-beans.adoc Closes gh-25040
src/docs/asciidoc/core/core-beans.adoc
@@ -2125,7 +2125,7 @@ startup, because it must satisfy the singleton's dependencies. The lazy-initiali is injected into a singleton bean elsewhere that is not lazy-initialized. You can also control lazy-initialization at the container level by using the -`default-lazy-init` attribute on the `<beans/>` element, a th...
false
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
spring-tx/src/main/java/org/springframework/transaction/PlatformTransactionManager.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,8 +19,8 @@ import org.springframework.l...
true
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
spring-tx/src/main/java/org/springframework/transaction/ReactiveTransactionManager.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,7 +22,7 @@ /** * This is the centra...
true
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
spring-tx/src/main/java/org/springframework/transaction/annotation/EnableTransactionManagement.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -30,7 +30,14 @@ * Enables Spring's annotat...
true
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
spring-tx/src/main/java/org/springframework/transaction/annotation/Transactional.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -71,12 +71,14 @@ /** * A <em>qualifie...
true
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java
@@ -70,8 +70,8 @@ * management, and a {@link TransactionAttributeSource} (e.g. annotation-based) is used * for determining transaction definitions for a particular class or method. * - * <p>A transaction aspect is serializable if its {@code PlatformTransactionManager} - * and {@code TransactionAttributeSource} ar...
true
Other
spring-projects
spring-framework
0f22a5e4099ccd990c523df45c050a8dc4e6e435.json
Update Javadoc regarding reactive tx mgmt support See gh-25030
src/docs/asciidoc/data-access.adoc
@@ -1160,7 +1160,7 @@ the default transactional configuration, you could write the following: </tx:attributes> </tx:advice> - <!-- other transaction infrastructure beans such as a PlatformTransactionManager omitted... --> + <!-- other transaction infrastructure beans such as a TransactionManager omitted... -...
true
Other
spring-projects
spring-framework
706446a66018a2042bc1ba572f3f6b53dbfa253c.json
Deprecate unused method
spring-websocket/src/main/java/org/springframework/web/socket/WebSocketHttpHeaders.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -26,6 +26,7 @@ import org.springframework.h...
false
Other
spring-projects
spring-framework
5af3223e7621004992fa6410d2e6a82be238fd8b.json
Add Release pipeline for Milestone versions This commit finishes the first step for migrating our complete build and release pipeline to Concourse CI. We're creating here a new "Release" jobs group in our pipeline. We can now release Milestones from our pipeline with: * the "stage-milestone" job, which creates and t...
ci/images/setup.sh
@@ -11,6 +11,7 @@ rm -rf /var/lib/apt/lists/* curl https://raw.githubusercontent.com/spring-io/concourse-java-scripts/v0.0.3/concourse-java.sh > /opt/concourse-java.sh +curl --output /opt/concourse-release-scripts.jar https://repo.spring.io/release/io/spring/concourse/releasescripts/concourse-release-scripts/0.1.0...
true