language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-jms/src/test/java/org/springframework/jms/support/JmsMessageHeaderAccessorTests.java | @@ -17,6 +17,7 @@
package org.springframework.jms.support;
import java.util.Map;
+
import javax.jms.Destination;
import javax.jms.JMSException;
| true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-jms/src/test/java/org/springframework/jms/support/SimpleJmsHeaderMapperTests.java | @@ -18,6 +18,7 @@
import java.util.Date;
import java.util.Map;
+
import javax.jms.DeliveryMode;
import javax.jms.Destination;
import javax.jms.JMSException; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-jms/src/test/java/org/springframework/jms/support/SimpleMessageConverterTests.java | @@ -20,6 +20,7 @@
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
+
import javax.jms.BytesMessage;
import javax.jms.JMSException;
import javax.jms.MapMessage; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-jms/src/test/java/org/springframework/jms/support/converter/MappingJackson2MessageConverterTests.java | @@ -22,6 +22,7 @@
import java.util.Date;
import java.util.HashMap;
import java.util.Map;
+
import javax.jms.BytesMessage;
import javax.jms.JMSException;
import javax.jms.Session; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-jms/src/test/java/org/springframework/jms/support/converter/MessagingMessageConverterTests.java | @@ -17,6 +17,7 @@
package org.springframework.jms.support.converter;
import java.io.Serializable;
+
import javax.jms.JMSException;
import javax.jms.ObjectMessage;
import javax.jms.Session; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-messaging/src/main/java/org/springframework/messaging/converter/MarshallingMessageConverter.java | @@ -22,6 +22,7 @@
import java.io.StringWriter;
import java.io.Writer;
import java.util.Arrays;
+
import javax.xml.transform.Result;
import javax.xml.transform.Source;
import javax.xml.transform.stream.StreamResult; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandlerTests.java | @@ -23,6 +23,7 @@
import java.security.Principal;
import java.util.LinkedHashMap;
import java.util.Map;
+
import javax.security.auth.Subject;
import com.fasterxml.jackson.annotation.JsonView; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/hibernate5/HibernateTemplate.java | @@ -24,6 +24,7 @@
import java.util.Collection;
import java.util.Iterator;
import java.util.List;
+
import javax.persistence.PersistenceException;
import org.apache.commons.logging.Log; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/hibernate5/HibernateTransactionManager.java | @@ -18,6 +18,7 @@
import java.sql.Connection;
import java.sql.ResultSet;
+
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
| true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/hibernate5/LocalSessionFactoryBean.java | @@ -19,6 +19,7 @@
import java.io.File;
import java.io.IOException;
import java.util.Properties;
+
import javax.sql.DataSource;
import org.hibernate.Interceptor; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/hibernate5/LocalSessionFactoryBuilder.java | @@ -27,6 +27,7 @@
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
+
import javax.persistence.AttributeConverter;
import javax.persistence.Converter;
import javax.persistence.Embeddable; | true |
Other | spring-projects | spring-framework | d945ae919140b4f7436ffb8c4b6bc1843c264bad.json | Add blank line between java and javax imports
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/hibernate5/SessionFactoryUtils.java | @@ -18,6 +18,7 @@
import java.lang.reflect.Method;
import java.util.Map;
+
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
| true |
Other | spring-projects | spring-framework | aa69703f3b0f92b1c7eaaf62b34ef8c7b251fc5c.json | Fix LinkedCaseInsensitiveMap collection methods
Ensure that results returned from keySet, entrySet & values are tracked
to remove case insensitive keys from the source map.
Closes gh-22821 | spring-core/src/main/java/org/springframework/util/LinkedCaseInsensitiveMap.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,12 +17,17 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | aa69703f3b0f92b1c7eaaf62b34ef8c7b251fc5c.json | Fix LinkedCaseInsensitiveMap collection methods
Ensure that results returned from keySet, entrySet & values are tracked
to remove case insensitive keys from the source map.
Closes gh-22821 | spring-core/src/test/java/org/springframework/util/LinkedCaseInsensitiveMapTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,12 +16,17 @@
package org.springframew... | true |
Other | spring-projects | spring-framework | aa69703f3b0f92b1c7eaaf62b34ef8c7b251fc5c.json | Fix LinkedCaseInsensitiveMap collection methods
Ensure that results returned from keySet, entrySet & values are tracked
to remove case insensitive keys from the source map.
Closes gh-22821 | spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java | @@ -36,7 +36,6 @@
import java.util.TimeZone;
import org.hamcrest.Matchers;
-import org.junit.Ignore;
import org.junit.Test;
import static org.hamcrest.Matchers.*;
@@ -561,7 +560,6 @@ public void bearerAuth() {
}
@Test
- @Ignore("Disabled until gh-22821 is resolved")
public void removalFromKeySetRemovesE... | true |
Other | spring-projects | spring-framework | a871f609ea2621934ed4b13e06e912a3cb98c124.json | Introduce failing tests for HttpHeaders
See gh-22821 | spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java | @@ -36,6 +36,7 @@
import java.util.TimeZone;
import org.hamcrest.Matchers;
+import org.junit.Ignore;
import org.junit.Test;
import static org.hamcrest.Matchers.*;
@@ -559,6 +560,36 @@ public void bearerAuth() {
assertEquals("Bearer foo", authorization);
}
+ @Test
+ @Ignore("Disabled until gh-22821 is res... | false |
Other | spring-projects | spring-framework | 5d785390eb4fae08922d2d98f61a31e617cd0115.json | Add `ClientHttpRequestInitializer` support
Add `ClientHttpRequestInitializer` interface that can be used with any
`HttpAccessor` to initialize each `ClientHttpRequest` before it's used.
This provides a useful alternative to `ClientHttpRequestInterceptor`
when users need to configure things like `HttpHeaders`.
Closes... | spring-web/src/main/java/org/springframework/http/client/ClientHttpRequestInitializer.java | @@ -0,0 +1,45 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 5d785390eb4fae08922d2d98f61a31e617cd0115.json | Add `ClientHttpRequestInitializer` support
Add `ClientHttpRequestInitializer` interface that can be used with any
`HttpAccessor` to initialize each `ClientHttpRequest` before it's used.
This provides a useful alternative to `ClientHttpRequestInterceptor`
when users need to configure things like `HttpHeaders`.
Closes... | spring-web/src/main/java/org/springframework/http/client/support/HttpAccessor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,13 +18,17 @@
import java.io.IOExcepti... | true |
Other | spring-projects | spring-framework | 5d785390eb4fae08922d2d98f61a31e617cd0115.json | Add `ClientHttpRequestInitializer` support
Add `ClientHttpRequestInitializer` interface that can be used with any
`HttpAccessor` to initialize each `ClientHttpRequest` before it's used.
This provides a useful alternative to `ClientHttpRequestInterceptor`
when users need to configure things like `HttpHeaders`.
Closes... | spring-web/src/test/java/org/springframework/web/client/RestTemplateTests.java | @@ -40,6 +40,7 @@
import org.springframework.http.ResponseEntity;
import org.springframework.http.client.ClientHttpRequest;
import org.springframework.http.client.ClientHttpRequestFactory;
+import org.springframework.http.client.ClientHttpRequestInitializer;
import org.springframework.http.client.ClientHttpRequestI... | true |
Other | spring-projects | spring-framework | f259fda8eb69355a6153467388fd00576c820ee1.json | Fix checkstyle violations | spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/JettyRequestUpgradeStrategy.java | @@ -18,7 +18,6 @@
import java.io.IOException;
import java.util.function.Supplier;
-
import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; | true |
Other | spring-projects | spring-framework | f259fda8eb69355a6153467388fd00576c820ee1.json | Fix checkstyle violations | spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/TomcatRequestUpgradeStrategy.java | @@ -19,7 +19,6 @@
import java.io.IOException;
import java.util.Collections;
import java.util.function.Supplier;
-
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; | true |
Other | spring-projects | spring-framework | f259fda8eb69355a6153467388fd00576c820ee1.json | Fix checkstyle violations | spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/UndertowRequestUpgradeStrategy.java | @@ -35,7 +35,6 @@
import org.springframework.http.server.reactive.ServerHttpRequest;
import org.springframework.http.server.reactive.ServerHttpRequestDecorator;
import org.springframework.lang.Nullable;
-import org.springframework.util.Assert;
import org.springframework.web.reactive.socket.HandshakeInfo;
import or... | true |
Other | spring-projects | spring-framework | 23be5dfb0ea52ac08854aad2a5ed0caf696877c3.json | Handle invalid MediaType in Jetty/Tomcat adapters
See: gh-23553 | spring-web/src/main/java/org/springframework/http/server/reactive/AbstractServerHttpResponse.java | @@ -262,8 +262,13 @@ protected Mono<Void> doCommit(@Nullable Supplier<? extends Mono<Void>> writeActi
protected abstract void applyStatusCode();
/**
- * Apply header changes from {@link #getHeaders()} to the underlying response.
- * This method is called once only.
+ * Invoked when the response is getting comm... | true |
Other | spring-projects | spring-framework | 23be5dfb0ea52ac08854aad2a5ed0caf696877c3.json | Handle invalid MediaType in Jetty/Tomcat adapters
See: gh-23553 | spring-web/src/main/java/org/springframework/http/server/reactive/JettyHttpHandlerAdapter.java | @@ -101,8 +101,15 @@ private static HttpHeaders createHeaders(HttpServletResponse response) {
@Override
protected void applyHeaders() {
- MediaType contentType = getHeaders().getContentType();
HttpServletResponse response = getNativeResponse();
+ MediaType contentType = null;
+ try {
+ contentType ... | true |
Other | spring-projects | spring-framework | 23be5dfb0ea52ac08854aad2a5ed0caf696877c3.json | Handle invalid MediaType in Jetty/Tomcat adapters
See: gh-23553 | spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpResponse.java | @@ -118,14 +118,25 @@ protected void applyHeaders() {
this.response.addHeader(headerName, headerValue);
}
});
- MediaType contentType = getHeaders().getContentType();
+ MediaType contentType = null;
+ try {
+ contentType = getHeaders().getContentType();
+ }
+ catch (Exception ex) {
+ String rawCont... | true |
Other | spring-projects | spring-framework | 23be5dfb0ea52ac08854aad2a5ed0caf696877c3.json | Handle invalid MediaType in Jetty/Tomcat adapters
See: gh-23553 | spring-web/src/main/java/org/springframework/http/server/reactive/TomcatHttpHandlerAdapter.java | @@ -204,7 +204,14 @@ else if (response instanceof HttpServletResponseWrapper) {
@Override
protected void applyHeaders() {
HttpServletResponse response = getNativeResponse();
- MediaType contentType = getHeaders().getContentType();
+ MediaType contentType = null;
+ try {
+ contentType = getHeaders().g... | true |
Other | spring-projects | spring-framework | fc6480631e1b7e3be105a058583d84a17b6d92a7.json | Improve Coroutines transaction API
As a follow-up of gh-22915, the purpose of this commit is to improve
Coroutines programmatic transaction API to make it more consistent with
the Java one and more idiomatic.
For suspending functions, this commit changes the
TransactionalOperator.transactional extension with a suspen... | spring-tx/src/main/kotlin/org/springframework/transaction/reactive/TransactionalOperatorExtensions.kt | @@ -7,23 +7,24 @@ import kotlinx.coroutines.reactive.asFlow
import kotlinx.coroutines.reactive.awaitFirstOrNull
import kotlinx.coroutines.reactor.asFlux
import kotlinx.coroutines.reactor.mono
+import org.springframework.transaction.ReactiveTransaction
/**
- * Coroutines variant of [TransactionalOperator.transacti... | true |
Other | spring-projects | spring-framework | fc6480631e1b7e3be105a058583d84a17b6d92a7.json | Improve Coroutines transaction API
As a follow-up of gh-22915, the purpose of this commit is to improve
Coroutines programmatic transaction API to make it more consistent with
the Java one and more idiomatic.
For suspending functions, this commit changes the
TransactionalOperator.transactional extension with a suspen... | spring-tx/src/test/kotlin/org/springframework/transaction/reactive/TransactionalOperatorExtensionsTests.kt | @@ -34,7 +34,7 @@ class TransactionalOperatorExtensionsTests {
fun commitWithSuspendingFunction() {
val operator = TransactionalOperator.create(tm, DefaultTransactionDefinition())
runBlocking {
- operator.transactional {
+ operator.executeAndAwait {
delay(1)
true
}
@@ -48,7 +48,7 @@ class Tran... | true |
Other | spring-projects | spring-framework | fc6480631e1b7e3be105a058583d84a17b6d92a7.json | Improve Coroutines transaction API
As a follow-up of gh-22915, the purpose of this commit is to improve
Coroutines programmatic transaction API to make it more consistent with
the Java one and more idiomatic.
For suspending functions, this commit changes the
TransactionalOperator.transactional extension with a suspen... | src/docs/asciidoc/languages/kotlin.adoc | @@ -577,8 +577,51 @@ class UserHandler(builder: WebClient.Builder) {
=== Transactions
Transactions on Coroutines are supported via the programmatic variant of the Reactive
-transaction management provided as of Spring Framework 5.2. `TransactionalOperator.transactional`
-extensions with suspending lambda and Kotlin... | true |
Other | spring-projects | spring-framework | 75fd391fc716456bbd2448f60e691b8f588c70de.json | Remove quality parameter from selected media type
Prior to this commit, WebFlux application would keep the quality
parameter from the "Accept" request header when selecting a media type
for the response. It would then echo it back to the client.
While strictly not wrong, this is unnecessary and can confuse HTTP
clien... | spring-webflux/src/main/java/org/springframework/web/reactive/result/HandlerResultHandlerSupport.java | @@ -156,6 +156,7 @@ else if (mediaType.isPresentIn(ALL_APPLICATION_MEDIA_TYPES)) {
}
if (selected != null) {
+ selected = selected.removeQualityValue();
if (logger.isDebugEnabled()) {
logger.debug("Using '" + selected + "' given " + acceptableTypes +
" and supported " + producibleTypes); | true |
Other | spring-projects | spring-framework | 75fd391fc716456bbd2448f60e691b8f588c70de.json | Remove quality parameter from selected media type
Prior to this commit, WebFlux application would keep the quality
parameter from the "Accept" request header when selecting a media type
for the response. It would then echo it back to the client.
While strictly not wrong, this is unnecessary and can confuse HTTP
clien... | spring-webflux/src/test/java/org/springframework/web/reactive/result/HandlerResultHandlerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -51,7 +51,7 @@ public class HandlerResultHan... | true |
Other | spring-projects | spring-framework | e7d489667c06b76a8fdb248259eba6f1b7f31062.json | Add missing space in AopConfigException message
See gh-24266 | spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java | @@ -600,7 +600,7 @@ private Advisor namedBeanToAdvisor(Object next) {
// We expected this to be an Advisor or Advice,
// but it wasn't. This is a configuration error.
throw new AopConfigException("Unknown advisor type " + next.getClass() +
- "; Can only include Advisor or Advice type beans in intercepto... | false |
Other | spring-projects | spring-framework | 0b5ad093948fe5f2eb5727ad63248e164fdd3437.json | Fix example in RSocket docs
Closes gh-24245 | src/docs/asciidoc/rsocket.adoc | @@ -690,8 +690,8 @@ you need to share configuration between a client and a server in the same proces
@Bean
public RSocketStrategies rsocketStrategies() {
return RSocketStrategies.builder()
- .encoders(encoders -> encoders.add(new Jackson2CborEncoder))
- .decoders(decoders -> decoders.add(new Jackson2Cbo... | false |
Other | spring-projects | spring-framework | 261956fd08fec9f35abbd2a1667e4acbbacdfc31.json | Improve UriBuilder Javadoc on query params
Add a note on encoding for query parameters specifically mentioning the
"+" sign and a link to the reference docs.
Also remove duplicate Javadoc in UriComponentsBuilder which is already
inherited from UriBuilder. | spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java | @@ -588,7 +588,7 @@ public int hashCode() {
/**
* Enumeration used to identify the allowed characters per URI component.
* <p>Contains methods to indicate whether a given character is valid in a specific URI component.
- * @see <a href="https://www.ietf.org/rfc/rfc3986.txt">RFC 3986</a>
+ * @see <a href="http... | true |
Other | spring-projects | spring-framework | 261956fd08fec9f35abbd2a1667e4acbbacdfc31.json | Improve UriBuilder Javadoc on query params
Add a note on encoding for query parameters specifically mentioning the
"+" sign and a link to the reference docs.
Also remove duplicate Javadoc in UriComponentsBuilder which is already
inherited from UriBuilder. | spring-web/src/main/java/org/springframework/web/util/UriBuilder.java | @@ -98,42 +98,51 @@ public interface UriBuilder {
UriBuilder pathSegment(String... pathSegments) throws IllegalArgumentException;
/**
- * Append the given query to the existing query of this builder.
- * The given query may contain URI template variables.
- * <p><strong>Note:</strong> The presence of reserved ... | true |
Other | spring-projects | spring-framework | 261956fd08fec9f35abbd2a1667e4acbbacdfc31.json | Improve UriBuilder Javadoc on query params
Add a note on encoding for query parameters specifically mentioning the
"+" sign and a link to the reference docs.
Also remove duplicate Javadoc in UriComponentsBuilder which is already
inherited from UriBuilder. | spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java | @@ -521,12 +521,6 @@ public UriComponentsBuilder uriComponents(UriComponents uriComponents) {
return this;
}
- /**
- * Set the URI scheme. The given scheme may contain URI template variables,
- * and may also be {@code null} to clear the scheme of this builder.
- * @param scheme the URI scheme
- * @return th... | true |
Other | spring-projects | spring-framework | 7456fb9c65f5b21c9aa825a01df1c02360d176f5.json | Add failing test to be fixed
See gh-23791 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingMessageConversionIntegrationTests.java | @@ -28,6 +28,7 @@
import io.reactivex.Flowable;
import io.reactivex.Maybe;
+import org.junit.jupiter.api.Disabled;
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
@@ -522,6 +523,16 @@ public void personCreateWithFlowableXml(HttpServer httpServer) thro... | false |
Other | spring-projects | spring-framework | ea4f1ca5d5c45db40da47684ceb522fec8fd294c.json | Update ContentDisposition to RFC 6266
Close gh-24231 | spring-web/src/main/java/org/springframework/http/ContentDisposition.java | @@ -33,18 +33,20 @@
import static java.time.format.DateTimeFormatter.RFC_1123_DATE_TIME;
/**
- * Represent the Content-Disposition type and parameters as defined in RFC 2183.
+ * Represent the Content-Disposition type and parameters as defined in RFC 6266.
*
* @author Sebastien Deleuze
* @author Juergen Hoell... | false |
Other | spring-projects | spring-framework | 15321a31633c7a9d0f838783640e7148472e4d9a.json | Fix checkstyle violations | spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java | @@ -107,11 +107,10 @@ public void parseEncodedFilenameWithInvalidName() {
@Test // gh-23077
public void parseWithEscapedQuote() {
- BiConsumer<String, String> tester = (description, filename) -> {
+ BiConsumer<String, String> tester = (description, filename) ->
assertThat(parse("form-data; name=\"file\"; fi... | false |
Other | spring-projects | spring-framework | 41f40c6c229d3b4f768718f1ec229d8f0ad76d76.json | Escape quotes in filename
Closes gh-24220 | spring-web/src/main/java/org/springframework/http/ContentDisposition.java | @@ -458,7 +458,11 @@ public interface Builder {
Builder name(String name);
/**
- * Set the value of the {@literal filename} parameter.
+ * Set the value of the {@literal filename} parameter. The given
+ * filename will be formatted as quoted-string, as defined in RFC 2616,
+ * section 2.2, and any quote... | true |
Other | spring-projects | spring-framework | 41f40c6c229d3b4f768718f1ec229d8f0ad76d76.json | Escape quotes in filename
Closes gh-24220 | spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java | @@ -19,11 +19,13 @@
import java.nio.charset.StandardCharsets;
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
+import java.util.function.BiConsumer;
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assert... | true |
Other | spring-projects | spring-framework | f8d6896e40a5d2f6f36b51a0b29bcca8cc53e9ef.json | Replace context object with "it" argument
Closes gh-23482 | spring-test/src/main/kotlin/org/springframework/test/web/servlet/MockHttpServletRequestDsl.kt | @@ -185,25 +185,25 @@ open class MockHttpServletRequestDsl internal constructor (private val builder:
}
internal fun perform(mockMvc: MockMvc): ResultActionsDsl {
- contextPath?.also { builder.contextPath(contextPath!!) }
- servletPath?.also { builder.servletPath(servletPath!!) }
- pathInfo?.also { builder.pat... | false |
Other | spring-projects | spring-framework | bee2b7cd736a7f59e3c1e35b3fe471cbcfbe1349.json | Add missing test cases in XmlBeanFactoryTests
Closes gh-24189 | spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java | @@ -536,6 +536,46 @@ public void testCircularReferences() {
assertThat(complexEgo.getSpouse().getSpouse() == complexEgo).as("Correct circular reference").isTrue();
}
+ @Test
+ public void testCircularReferencesWithConstructor() {
+ DefaultListableBeanFactory xbf = new DefaultListableBeanFactory();
+ XmlBeanDef... | true |
Other | spring-projects | spring-framework | bee2b7cd736a7f59e3c1e35b3fe471cbcfbe1349.json | Add missing test cases in XmlBeanFactoryTests
Closes gh-24189 | spring-context/src/test/resources/org/springframework/beans/factory/xml/XmlBeanFactoryTests-reftypes.xml | @@ -14,6 +14,28 @@
<property name="spouse" ref="jenny"/>
</bean>
+ <bean id="jenny_constructor" class="org.springframework.tests.sample.beans.TestBean">
+ <constructor-arg index="1"><ref bean="david_constructor"/></constructor-arg>
+ </bean>
+
+ <bean id="david_constructor" class="org.springframework.tests.sam... | true |
Other | spring-projects | spring-framework | 09b6730f3d89b55819ea9bea66314269b7cc4fd9.json | Expose logPrefix in ClientResponse
This commit exposes the logPrefix field in the ClientResponse interface.
Closes gh-24146 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientResponse.java | @@ -204,6 +204,19 @@ public interface ClientResponse {
*/
Mono<WebClientResponseException> createException();
+ /**
+ * Return a log message prefix to use to correlate messages for this response.
+ * The prefix is based on the {@linkplain ClientRequest#logPrefix() client
+ * log prefix}, which itself is based... | true |
Other | spring-projects | spring-framework | 09b6730f3d89b55819ea9bea66314269b7cc4fd9.json | Expose logPrefix in ClientResponse
This commit exposes the logPrefix field in the ClientResponse interface.
Closes gh-24146 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientResponse.java | @@ -225,6 +225,11 @@ public Mono<WebClientResponseException> createException() {
});
}
+ @Override
+ public String logPrefix() {
+ return this.logPrefix;
+ }
+
// Used by DefaultClientResponseBuilder
HttpRequest request() {
return this.requestSupplier.get(); | true |
Other | spring-projects | spring-framework | 09b6730f3d89b55819ea9bea66314269b7cc4fd9.json | Expose logPrefix in ClientResponse
This commit exposes the logPrefix field in the ClientResponse interface.
Closes gh-24146 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/support/ClientResponseWrapper.java | @@ -153,6 +153,11 @@ public Mono<WebClientResponseException> createException() {
return this.delegate.createException();
}
+ @Override
+ public String logPrefix() {
+ return this.delegate.logPrefix();
+ }
+
/**
* Implementation of the {@code Headers} interface that can be subclassed
* to adapt the head... | true |
Other | spring-projects | spring-framework | 63844c6d743544339fe001545409c3929a8e11ed.json | MappingJackson2MessageConverter: fix javadoc typo
`getJavaTypeForMessage()` - wrong parameter description. | spring-jms/src/main/java/org/springframework/jms/support/converter/MappingJackson2MessageConverter.java | @@ -340,7 +340,7 @@ protected Message mapToMessage(Object object, Session session, ObjectWriter obje
* sets the resulting value (either a mapped id or the raw Java class name)
* into the configured type id message property.
* @param object the payload object to set a type id for
- * @param message the JMS Mes... | false |
Other | spring-projects | spring-framework | dd9b6287b4c3b507f963c655144ed06dd8f5ff21.json | Expose ClientCodecConfigurer in WebClient.Builder
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.
Closes gh-24124 | spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClientBuilder.java | @@ -23,6 +23,7 @@
import org.springframework.http.HttpHeaders;
import org.springframework.http.client.reactive.ClientHttpConnector;
import org.springframework.http.client.reactive.ReactorClientHttpConnector;
+import org.springframework.http.codec.ClientCodecConfigurer;
import org.springframework.lang.Nullable;
imp... | true |
Other | spring-projects | spring-framework | dd9b6287b4c3b507f963c655144ed06dd8f5ff21.json | Expose ClientCodecConfigurer in WebClient.Builder
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.
Closes gh-24124 | spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java | @@ -37,6 +37,7 @@
import org.springframework.http.MediaType;
import org.springframework.http.client.reactive.ClientHttpConnector;
import org.springframework.http.client.reactive.ClientHttpRequest;
+import org.springframework.http.codec.ClientCodecConfigurer;
import org.springframework.http.codec.ServerCodecConfigur... | true |
Other | spring-projects | spring-framework | dd9b6287b4c3b507f963c655144ed06dd8f5ff21.json | Expose ClientCodecConfigurer in WebClient.Builder
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.
Closes gh-24124 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClientBuilder.java | @@ -27,6 +27,7 @@
import org.springframework.http.client.reactive.ClientHttpConnector;
import org.springframework.http.client.reactive.JettyClientHttpConnector;
import org.springframework.http.client.reactive.ReactorClientHttpConnector;
+import org.springframework.http.codec.ClientCodecConfigurer;
import org.spring... | true |
Other | spring-projects | spring-framework | dd9b6287b4c3b507f963c655144ed06dd8f5ff21.json | Expose ClientCodecConfigurer in WebClient.Builder
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.
Closes gh-24124 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -39,6 +39,7 @@
import org.springframework.http.ResponseEntity;
import org.springframework.http.client.reactive.ClientHttpConnector;
import org.springframework.http.client.reactive.ClientHttpRequest;
+import org.springframework.http.codec.ClientCodecConfigurer;
import org.springframework.util.MultiValueMap;
impo... | true |
Other | spring-projects | spring-framework | dd9b6287b4c3b507f963c655144ed06dd8f5ff21.json | Expose ClientCodecConfigurer in WebClient.Builder
Using Consumer<ClientCodecConfigurer> instead of
Consumer<ExchangeStrategies> eliminates one level of nesting that is
also unnecessary since codecs are the only strategy at present.
Closes gh-24124 | src/docs/asciidoc/web/webflux.adoc | @@ -979,31 +979,21 @@ The following example shows how to do so for client-side requests:
[source,java,indent=0,subs="verbatim,quotes",role="primary"]
.Java
----
- Consumer<ClientCodecConfigurer> consumer = configurer -> {
- CustomDecoder customDecoder = new CustomDecoder();
- configurer.customCodecs(... | true |
Other | spring-projects | spring-framework | d757f739028c7608b0d870bf0e9f23b91e57298b.json | Handle exceptions in annotation searches again
Prior to Spring Framework 5.2, most annotation search algorithms made
use of AnnotationUtils.handleIntrospectionFailure() to handle exceptions
thrown while attempting to introspect annotation metadata. With the
introduction of the new MergedAnnotation API in Spring Framew... | spring-core/src/main/java/org/springframework/core/annotation/AnnotationsScanner.java | @@ -136,51 +136,56 @@ private static <C, R> R processClass(C context, Class<?> source,
private static <C, R> R processClassInheritedAnnotations(C context, Class<?> source,
SearchStrategy searchStrategy, AnnotationsProcessor<C, R> processor, @Nullable BiPredicate<C, Class<?>> classFilter) {
- if (isWithoutHiera... | false |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerHttpRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -61,6 +61,9 @@ public final class MockServer... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-test/src/main/java/org/springframework/mock/web/reactive/function/server/MockServerRequest.java | @@ -93,6 +93,9 @@ public final class MockServerRequest implements ServerRequest {
@Nullable
private final InetSocketAddress remoteAddress;
+ @Nullable
+ private final InetSocketAddress localAddress;
+
private final List<HttpMessageReader<?>> messageReaders;
@Nullable
@@ -103,8 +106,8 @@ private MockServerRe... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/DefaultServerHttpRequestBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -181,9 +181,6 @@ private static class Mutate... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -151,6 +151,11 @@ public InetSocketAddress g... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/ServerHttpRequest.java | @@ -72,6 +72,15 @@ default InetSocketAddress getRemoteAddress() {
return null;
}
+ /**
+ * Return the local address the request was accepted on, if available.
+ * 5.2.3
+ */
+ @Nullable
+ default InetSocketAddress getLocalAddress() {
+ return null;
+ }
+
/**
* Return the SSL session information if the r... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/ServerHttpRequestDecorator.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -101,6 +101,11 @@ public InetSocketAddress g... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -178,6 +178,11 @@ public InetSocketAddress g... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpRequest.java | @@ -102,6 +102,11 @@ public InetSocketAddress getRemoteAddress() {
return this.exchange.getSourceAddress();
}
+ @Override
+ public InetSocketAddress getLocalAddress() {
+ return this.exchange.getDestinationAddress();
+ }
+
@Nullable
@Override
protected SslInfo initSslInfo() { | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerHttpRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -52,7 +52,7 @@
* @author Rossen Stoyanchev... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java | @@ -122,6 +122,11 @@ public Optional<InetSocketAddress> remoteAddress() {
return Optional.ofNullable(request().getRemoteAddress());
}
+ @Override
+ public Optional<InetSocketAddress> localAddress() {
+ return Optional.ofNullable(request().getLocalAddress());
+ }
+
@Override
public List<HttpMessageReader<?>>... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java | @@ -947,6 +947,11 @@ public Optional<InetSocketAddress> remoteAddress() {
return this.request.remoteAddress();
}
+ @Override
+ public Optional<InetSocketAddress> localAddress() {
+ return this.request.localAddress();
+ }
+
@Override
public List<HttpMessageReader<?>> messageReaders() {
return thi... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java | @@ -124,6 +124,12 @@ default PathContainer pathContainer() {
*/
Optional<InetSocketAddress> remoteAddress();
+ /**
+ * Get the remote address to which this request is connected, if available.
+ * @since 5.2.3
+ */
+ Optional<InetSocketAddress> localAddress();
+
/**
* Get the readers used to convert the b... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -123,6 +123,11 @@ public Optional<InetSocketAddress> remoteAddress() {
return this.delegate.remoteAddress();
}
+ @Override
+ public Optional<InetSocketAddress> localAddress() {
+ return this.delegate.localAddress();
+ }
+
@Override
public List<HttpMessageReader<?>> messageReaders() {
return this.deleg... | true |
Other | spring-projects | spring-framework | 1b172c1d20ecf96839abc02a67ae2a763af2815e.json | Expose localAddress in WebFlux server
Closes gh-24174 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java | @@ -61,7 +61,7 @@
* @author Arjen Poutsma
* @since 5.0
*/
-public class MockServerRequest implements ServerRequest {
+public final class MockServerRequest implements ServerRequest {
private final HttpMethod method;
@@ -91,6 +91,9 @@ public class MockServerRequest implements ServerRequest {
@Nullable
pri... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-context/src/test/java/org/springframework/context/annotation/AnnotationConfigApplicationContextTests.java | @@ -56,7 +56,7 @@ void scanAndRefresh() {
context.getBean(uncapitalize(ComponentForScanning.class.getSimpleName()));
context.getBean(uncapitalize(Jsr330NamedForScanning.class.getSimpleName()));
Map<String, Object> beans = context.getBeansWithAnnotation(Configuration.class);
- assertThat(beans).size().isEqualT... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-context/src/test/java/org/springframework/scheduling/config/ScheduledTaskRegistrarTests.java | @@ -79,7 +79,7 @@ void getFixedDelayTasks() {
@Test
void addCronTaskWithValidExpression() {
this.taskRegistrar.addCronTask(no_op, "* * * * * ?");
- assertThat(this.taskRegistrar.getCronTaskList()).size().isEqualTo(1);
+ assertThat(this.taskRegistrar.getCronTaskList()).hasSize(1);
}
@Test | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-test/src/test/java/org/springframework/test/context/event/CustomTestEventTests.java | @@ -57,7 +57,7 @@ public void clearEvents() {
@Test
public void customTestEventPublished() {
- assertThat(events).size().isEqualTo(1);
+ assertThat(events).hasSize(1);
CustomEvent customEvent = events.get(0);
assertThat(customEvent.getSource()).isEqualTo(getClass());
assertThat(customEvent.getTestName(... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/SpringExtensionParameterizedTests.java | @@ -50,7 +50,7 @@ class SpringExtensionParameterizedTests {
@ParameterizedTest
@ValueSource(strings = { "Dilbert", "Wally" })
void people(String name, @Autowired List<Person> people) {
- assertThat(people.stream().map(Person::getName).filter(name::equals)).size().isEqualTo(1);
+ assertThat(people.stream().map(P... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/defaultmethods/GenericComicCharactersInterfaceDefaultMethodsTests.java | @@ -45,7 +45,7 @@
@Test
default void autowiredParameterWithParameterizedList(@Autowired List<C> characters) {
- assertThat(characters).as("Number of characters in context").size().isEqualTo(getExpectedNumCharacters());
+ assertThat(characters).as("Number of characters in context").hasSize(getExpectedNumCharacte... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/generics/GenericComicCharactersTests.java | @@ -53,7 +53,7 @@
void autowiredFields() {
assertThat(this.character).as("Character should have been @Autowired by Spring").isNotNull();
assertThat(this.character).as("character's name").extracting(Character::getName).isEqualTo(getExpectedName());
- assertThat(this.characters).as("Number of characters in conte... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-web/src/test/java/org/springframework/web/accept/MappingMediaTypeFileExtensionResolverTests.java | @@ -41,7 +41,7 @@ public class MappingMediaTypeFileExtensionResolverTests {
public void resolveExtensions() {
List<String> extensions = this.resolver.resolveFileExtensions(MediaType.APPLICATION_JSON);
- assertThat(extensions).size().isEqualTo(1);
+ assertThat(extensions).hasSize(1);
assertThat(extensions.ge... | true |
Other | spring-projects | spring-framework | 1e83e889aa227d9f84c8c212fe6d8772afe33614.json | Use hasSize() where possible
See gh-24172 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestScopedControllerAdviceIntegrationTests.java | @@ -51,7 +51,7 @@ void loadContextWithRequestScopedControllerAdvice() {
assertThatCode(context::refresh).doesNotThrowAnyException();
List<ControllerAdviceBean> adviceBeans = ControllerAdviceBean.findAnnotatedBeans(context);
- assertThat(adviceBeans).size().isEqualTo(1);
+ assertThat(adviceBeans).hasSize(1);
... | true |
Other | spring-projects | spring-framework | 821a8eebdda514e1c6e4602509a8dc1e69d1849c.json | Improve Javadoc in Configuration | spring-context/src/main/java/org/springframework/context/annotation/Configuration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -446,11 +446,11 @@
* requires method inte... | false |
Other | spring-projects | spring-framework | 0e5f27c94e5fa33a294d342dbc9ed61e6c032468.json | Introduce NonNull to package-info | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/JettyRequestUpgradeStrategy.java | @@ -39,6 +39,7 @@
import org.springframework.http.server.ServerHttpResponse;
import org.springframework.http.server.ServletServerHttpRequest;
import org.springframework.http.server.ServletServerHttpResponse;
+import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
import org.springframewo... | true |
Other | spring-projects | spring-framework | 0e5f27c94e5fa33a294d342dbc9ed61e6c032468.json | Introduce NonNull to package-info | spring-websocket/src/main/java/org/springframework/web/socket/server/jetty/package-info.java | @@ -1,4 +1,9 @@
/**
* Server-side support for the Jetty 9+ WebSocket API.
*/
+@NonNullApi
+@NonNullFields
package org.springframework.web.socket.server.jetty;
+
+import org.springframework.lang.NonNullApi;
+import org.springframework.lang.NonNullFields; | true |
Other | spring-projects | spring-framework | 713a112812fd9ca1e6b64f3f8105374743d677bc.json | Improve ConcurrentLruCache performance
- manage collection size manually
- check cache hit first before size check
- reduce read-lock scope
- use `map.get` to test cache instead of `queue.remove`
Closes gh-24469
See gh-24671 | spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java | @@ -30,6 +30,7 @@
import java.util.Random;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import java.util.function... | false |
Other | spring-projects | spring-framework | 1f72ab4816bc2b09244616f628f9f1137855a05e.json | Add Javadoc to ManagedAttribute
Closes: gh-24742 | spring-context/src/main/java/org/springframework/jmx/export/annotation/ManagedAttribute.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -22,6 +22,8 @@
import java.lang.annotation.... | false |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-context/src/test/java/org/springframework/aop/aspectj/generic/GenericParameterMatchingTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,7 +28,7 @@
import static org.assertj.co... | true |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationBackCompatibiltyTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -84,11 +84,11 @@ static class WithMetaMetaTe... | true |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationTypeMappingsTests.java | @@ -382,26 +382,28 @@ void resolveMirrorsWhenHasDifferentValuesThrowsException() {
}
@Test
- void resolveMirrorsWhenHasWithMulipleRoutesToAliasReturnsMirrors() {
- AnnotationTypeMappings mappings = AnnotationTypeMappings.forAnnotationType(MulipleRoutesToAliasA.class);
- AnnotationTypeMapping mappingsA = getMapp... | true |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-messaging/src/main/java/org/springframework/messaging/handler/invocation/reactive/AbstractMethodMessageHandler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -157,7 +157,7 @@ public ArgumentResolverConf... | true |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-test/src/test/java/org/springframework/test/context/support/ActiveProfilesUtilsTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -169,7 +169,7 @@ void resolveActiveProfilesW... | true |
Other | spring-projects | spring-framework | 09b36380cd42da53f8a6da2e49969b1c6619d109.json | Fix typos in source files
Closes gh-24746 | spring-test/src/test/java/org/springframework/test/context/support/DirtiesContextTestExecutionListenerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -282,7 +282,7 @@ void beforeAndAfterTestClas... | true |
Other | spring-projects | spring-framework | 331b14bb0b3f76e9554c739969ffa531563cce74.json | Fix NoHttp violation | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -664,7 +664,7 @@ interface ResponseSpec {
* downstream, for example:
* <pre class="code">
* webClient.get()
- * .uri("http://abc.com/account/123")
+ * .uri("https://abc.com/account/123")
* .retrieve()
* .bodyToMono(Account.class)
* .onErrorResume(WebClientResponseExcep... | false |
Other | spring-projects | spring-framework | 2ca93cbe1c761dac8c61290513571f6c403a233c.json | Update Javadoc for WebClient onStatus handlers
Closes gh-24736 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -197,9 +197,9 @@ public interface ClientResp... | true |
Other | spring-projects | spring-framework | 2ca93cbe1c761dac8c61290513571f6c403a233c.json | Update Javadoc for WebClient onStatus handlers
Closes gh-24736 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -650,38 +650,39 @@ <T, P extends Publisher<T>> RequestHeadersSpec<?> body(P publisher,
interface ResponseSpec {
/**
- * Register a custom error function that gets invoked when the given {@link HttpStatus}
- * predicate applies. Whatever exception is returned from the function (possibly using
- * {@link ... | true |
Other | spring-projects | spring-framework | 116a256e817624db819c256ab086db6c1bb4a21c.json | Fix typos in AnnotationsScannerTests | spring-core/src/test/java/org/springframework/core/annotation/AnnotationsScannerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -86,7 +86,7 @@ void directStrategyOnClassHie... | false |
Other | spring-projects | spring-framework | 2c5781473c25a80d48a4d7517b0e1b95636c5777.json | Improve Javadoc in AnnotatedElementUtils
Closes gh-24740 | spring-core/src/main/java/org/springframework/core/annotation/AnnotatedElementUtils.java | @@ -111,7 +111,7 @@ public static AnnotatedElement forAnnotations(Annotation... annotations) {
* @param element the annotated element
* @param annotationType the annotation type on which to find meta-annotations
* @return the names of all meta-annotations present on the annotation,
- * or {@code null} if not ... | false |
Other | spring-projects | spring-framework | 0d42a1bd7fdd44b000873edd6cbbb35697fddc4a.json | Add retry for flaky test (suspected Tomcat issue) | spring-webflux/src/test/java/org/springframework/web/reactive/socket/AbstractWebSocketIntegrationTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,7 +23,6 @@
import java.lang.annotation.... | true |
Other | spring-projects | spring-framework | 0d42a1bd7fdd44b000873edd6cbbb35697fddc4a.json | Add retry for flaky test (suspected Tomcat issue) | spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java | @@ -29,6 +29,7 @@
import reactor.core.publisher.Mono;
import reactor.core.publisher.MonoProcessor;
import reactor.core.publisher.ReplayProcessor;
+import reactor.util.retry.Retry;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@@ -39,6 +40,7 @@
i... | true |
Other | spring-projects | spring-framework | a7fe6b8f5c74dd6ea0e531b3ba1e90a455ee15dd.json | Avoid NPE in ResponseCookie on null domain
See gh-24663 | spring-web/src/main/java/org/springframework/http/ResponseCookie.java | @@ -245,7 +245,7 @@ public ResponseCookieBuilder domain(String domain) {
@Nullable
private String initDomain(String domain) {
- if (lenient) {
+ if (lenient && !StringUtils.isEmpty(domain)) {
String s = domain.trim();
if (s.startsWith("\"") && s.endsWith("\"")) {
if (s.substring(1, do... | false |
Other | spring-projects | spring-framework | 7b94112ec66aa0e896a0a8573a2539900e94d054.json | Update documentation for custom-java-home.gradle
See gh-24719 | gradle/custom-java-home.gradle | @@ -5,10 +5,9 @@
// the one used to launch the Gradle process).
//
// - customJavaHome: absolute path to the alternate JDK installation to
-// use to compile Java code and execute tests. Setting this system
-// property causes Groovy 3.0 RC3 to be used instead of 2.5.x. This
-// system property is also u... | false |
Other | spring-projects | spring-framework | a8feb792da01128223c44c4b945c4d94f0eec241.json | Fix broken Javadoc links | spring-messaging/src/main/java/org/springframework/messaging/converter/ProtobufJsonFormatMessageConverter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -13,6 +13,7 @@
* See the License for the s... | true |
Other | spring-projects | spring-framework | a8feb792da01128223c44c4b945c4d94f0eec241.json | Fix broken Javadoc links | spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -658,8 +658,8 @@ interface RequestBodySpec e... | true |
Other | spring-projects | spring-framework | a8feb792da01128223c44c4b945c4d94f0eec241.json | Fix broken Javadoc links | spring-web/src/main/java/org/springframework/http/converter/protobuf/ProtobufJsonFormatHttpMessageConverter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,31 +37,37 @@
* @since 5.0
* @see Jso... | true |
Other | spring-projects | spring-framework | e500456f1cc5bffef9bec3782001ed1fec78679d.json | Publish distribution zip files again
A change in `docs.gradle` in 5.2.4 resulted in distribution zip files
no longer being published to
https://repo.spring.io/release/org/springframework/spring/.
This commit fixes this by updating the `mavenContent` configuration as
suggested by @wilkinsona.
Closes gh-24605 | gradle/docs.gradle | @@ -10,7 +10,7 @@ repositories {
maven {
url "https://repo.spring.io/release"
mavenContent {
- group "io.spring.asciidoctor"
+ includeGroup "io.spring.asciidoctor"
}
}
} | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.