language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
d85a6c0bea2b1f2a33809475df0674479ea7f424.json
Fix typos in MergedAnnotationsCollectionTests Closes gh-24701
spring-core/src/test/java/org/springframework/core/annotation/MergedAnnotationsCollectionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -71,7 +71,7 @@ void createWhenAnnotationAggr...
false
Other
spring-projects
spring-framework
fac1b94623f13a79182a57cf772760cd69cc2414.json
Fix typo in buildSrc/README.md See gh-24697
buildSrc/README.md
@@ -7,7 +7,7 @@ They are declared in the `build.gradle` file in this folder. ### Compiler conventions -The `org.springframework.build.compile` plubin applies the Java compiler conventions to the build. +The `org.springframework.build.compile` plugin applies the Java compiler conventions to the build. By default, ...
false
Other
spring-projects
spring-framework
7c4f0318bb32938105335099956eccd2807ce4fb.json
Improve efficiency of built RouterFunction This commit changes the way RouterFunctions registered to the builder are composed in both WebFlux.fn and WebMvc.fn. Prior to this commit, all routes added to the build were composed with `reduce`. After this commit, all routes are stored in a special router function, allowin...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctionBuilder.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,6 +24,7 @@ import java.util.function.Pr...
true
Other
spring-projects
spring-framework
7c4f0318bb32938105335099956eccd2807ce4fb.json
Improve efficiency of built RouterFunction This commit changes the way RouterFunctions registered to the builder are composed in both WebFlux.fn and WebMvc.fn. Prior to this commit, all routes added to the build were composed with `reduce`. After this commit, all routes are stored in a special router function, allowin...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -749,7 +749,7 @@ public interface Visitor { } - private abstract static class AbstractRouterFunction<T extends ServerResponse> implements RouterFunction<T> { + abstract static class AbstractRouterFunction<T extends ServerResponse> implements RouterFunction<T> { @Override public String toString() {
true
Other
spring-projects
spring-framework
7c4f0318bb32938105335099956eccd2807ce4fb.json
Improve efficiency of built RouterFunction This commit changes the way RouterFunctions registered to the builder are composed in both WebFlux.fn and WebMvc.fn. Prior to this commit, all routes added to the build were composed with `reduce`. After this commit, all routes are stored in a special router function, allowin...
spring-webmvc/src/main/java/org/springframework/web/servlet/function/RouterFunctionBuilder.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -237,9 +237,10 @@ public RouterFunctions.Bui...
true
Other
spring-projects
spring-framework
7c4f0318bb32938105335099956eccd2807ce4fb.json
Improve efficiency of built RouterFunction This commit changes the way RouterFunctions registered to the builder are composed in both WebFlux.fn and WebMvc.fn. Prior to this commit, all routes added to the build were composed with `reduce`. After this commit, all routes are stored in a special router function, allowin...
spring-webmvc/src/main/java/org/springframework/web/servlet/function/RouterFunctions.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -660,7 +660,7 @@ public interface Visitor { ...
true
Other
spring-projects
spring-framework
54e2df2e0e0ea9b727b9bf222a1852568433629e.json
Improve RouterFunction composition This commit changes the way two RouterFunctions are composed in WebFlux.fn. Prior to this commit, two were composed with `switchIfEmpty()`, switching from the first to the second route if the first did not provide an element. After this commit, two router functions are compose using ...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -26,6 +26,7 @@ import org.apache.commons....
false
Other
spring-projects
spring-framework
c5b8406def18c1b0f5791e5892643fd0b1937a04.json
Add some test cases in StringUtilsTests
spring-core/src/test/java/org/springframework/util/StringUtilsTests.java
@@ -56,6 +56,8 @@ void containsWhitespace() { assertThat(StringUtils.containsWhitespace("a")).isFalse(); assertThat(StringUtils.containsWhitespace("abc")).isFalse(); assertThat(StringUtils.containsWhitespace(" ")).isTrue(); + assertThat(StringUtils.containsWhitespace("\t")).isTrue(); + assertThat(StringUtils...
false
Other
spring-projects
spring-framework
c8c1e61c0ab1d164b182dc9b6abe1f6f91070d8b.json
Improve Javadoc in AutoProxyRegistrar Closes gh-24688 Co-authored-by: Sam Brannen <sbrannen@pivotal.io>
spring-context/src/main/java/org/springframework/context/annotation/AutoProxyRegistrar.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -33,7 +33,8 @@ * * @author Chris Beams ...
false
Other
spring-projects
spring-framework
201827cb0ba3a853e34b824845ddfe0b7f41d0c7.json
Fix exception message in getMergedBeanDefinition Closes gh-24686 Co-authored-by: Sam Brannen <sbrannen@pivotal.io>
spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java
@@ -1343,7 +1343,7 @@ protected RootBeanDefinition getMergedBeanDefinition( else { throw new NoSuchBeanDefinitionException(parentBeanName, "Parent name '" + parentBeanName + "' is equal to bean name '" + beanName + - "': cannot be resolved without an AbstractBeanFactory parent"); + ...
false
Other
spring-projects
spring-framework
74ddf1bee5105981e699ab25e8b01cc6a5c43676.json
Improve documentation for @Autowired constructors Prior to this commit, there was some ambiguity surrounding semantics for @Autowired constructors and `required = true`, especially for multiple @Autowired constructors. This commit improves the documentation in the Javadoc for @Autowired as well as in the reference ma...
spring-beans/src/main/java/org/springframework/beans/factory/annotation/Autowired.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,19 +23,21 @@ import java.lang.annotatio...
true
Other
spring-projects
spring-framework
74ddf1bee5105981e699ab25e8b01cc6a5c43676.json
Improve documentation for @Autowired constructors Prior to this commit, there was some ambiguity surrounding semantics for @Autowired constructors and `required = true`, especially for multiple @Autowired constructors. This commit improves the documentation in the Javadoc for @Autowired as well as in the reference ma...
src/docs/asciidoc/core/core-beans.adoc
@@ -4811,15 +4811,19 @@ e.g. declared as a single public constructor without an `@Autowired` annotation. [NOTE] ==== -Only one annotated constructor per class can be marked as required, but multiple -non-required constructors can be annotated. In that case, each is considered among -the candidates and Spring uses t...
true
Other
spring-projects
spring-framework
17914fc44b1388ab755db28d7c6e47eb2f047d3c.json
Add multi-prefix comment support for SQL scripts Update `ResourceDatabasePopulator` and `ScriptUtils` so that more than one comment prefix can be used when processing SQL scripts. This feature is particularly useful when dealing with scripts provided by Quartz since they often use a mix `--` and `#`. Closes gh-23289
spring-jdbc/src/main/java/org/springframework/jdbc/datasource/init/ResourceDatabasePopulator.java
@@ -60,7 +60,7 @@ public class ResourceDatabasePopulator implements DatabasePopulator { private String separator = ScriptUtils.DEFAULT_STATEMENT_SEPARATOR; - private String commentPrefix = ScriptUtils.DEFAULT_COMMENT_PREFIX; + private String[] commentPrefixes = ScriptUtils.DEFAULT_COMMENT_PREFIXES; private St...
true
Other
spring-projects
spring-framework
17914fc44b1388ab755db28d7c6e47eb2f047d3c.json
Add multi-prefix comment support for SQL scripts Update `ResourceDatabasePopulator` and `ScriptUtils` so that more than one comment prefix can be used when processing SQL scripts. This feature is particularly useful when dealing with scripts provided by Quartz since they often use a mix `--` and `#`. Closes gh-23289
spring-jdbc/src/main/java/org/springframework/jdbc/datasource/init/ScriptUtils.java
@@ -80,6 +80,12 @@ public abstract class ScriptUtils { */ public static final String DEFAULT_COMMENT_PREFIX = "--"; + /** + * Default prefixes for single-line comments within SQL scripts: {@code ["--"]}. + * @since 5.2 + */ + public static final String[] DEFAULT_COMMENT_PREFIXES = { DEFAULT_COMMENT_PREFIX }; ...
true
Other
spring-projects
spring-framework
17914fc44b1388ab755db28d7c6e47eb2f047d3c.json
Add multi-prefix comment support for SQL scripts Update `ResourceDatabasePopulator` and `ScriptUtils` so that more than one comment prefix can be used when processing SQL scripts. This feature is particularly useful when dealing with scripts provided by Quartz since they often use a mix `--` and `#`. Closes gh-23289
spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/ScriptUtilsUnitTests.java
@@ -25,6 +25,9 @@ import org.springframework.core.io.support.EncodedResource; import static org.assertj.core.api.Assertions.assertThat; +import static org.springframework.jdbc.datasource.init.ScriptUtils.DEFAULT_BLOCK_COMMENT_END_DELIMITER; +import static org.springframework.jdbc.datasource.init.ScriptUtils.DEFAULT...
true
Other
spring-projects
spring-framework
17914fc44b1388ab755db28d7c6e47eb2f047d3c.json
Add multi-prefix comment support for SQL scripts Update `ResourceDatabasePopulator` and `ScriptUtils` so that more than one comment prefix can be used when processing SQL scripts. This feature is particularly useful when dealing with scripts provided by Quartz since they often use a mix `--` and `#`. Closes gh-23289
spring-jdbc/src/test/resources/org/springframework/jdbc/datasource/init/test-data-with-multi-prefix-comments.sql
@@ -0,0 +1,18 @@ +-- The next comment line has no text after the '--' prefix. +-- +-- The next comment line starts with a space. + -- x, y, z... + +insert into customer (id, name) +values (1, 'Rod; Johnson'), (2, 'Adrian Collier'); +-- This is also a comment. +insert into orders(id, order_date, customer_id) +values (1,...
true
Other
spring-projects
spring-framework
c32299f734521e907585de50d70a46dcd8018f13.json
Use HttpMessageNotWritableException instead of ISE As a follow-up to the recent commit #37f9ce, this change replaces the raised IllegalStateException with HttpMessageNotWritableException. See gh-23205
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractMessageWriterResultHandler.java
@@ -33,6 +33,7 @@ import org.springframework.core.codec.Hints; import org.springframework.http.MediaType; import org.springframework.http.codec.HttpMessageWriter; +import org.springframework.http.converter.HttpMessageNotWritableException; import org.springframework.lang.Nullable; import org.springframework.util.As...
true
Other
spring-projects
spring-framework
c32299f734521e907585de50d70a46dcd8018f13.json
Use HttpMessageNotWritableException instead of ISE As a follow-up to the recent commit #37f9ce, this change replaces the raised IllegalStateException with HttpMessageNotWritableException. See gh-23205
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandlerTests.java
@@ -51,6 +51,7 @@ import org.springframework.http.codec.ResourceHttpMessageWriter; import org.springframework.http.codec.json.Jackson2JsonEncoder; import org.springframework.http.codec.xml.Jaxb2XmlEncoder; +import org.springframework.http.converter.HttpMessageNotWritableException; import org.springframework.mock.we...
true
Other
spring-projects
spring-framework
c32299f734521e907585de50d70a46dcd8018f13.json
Use HttpMessageNotWritableException instead of ISE As a follow-up to the recent commit #37f9ce, this change replaces the raised IllegalStateException with HttpMessageNotWritableException. See gh-23205
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java
@@ -176,6 +176,9 @@ protected <T> void writeWithMessageConverters(T value, MethodParameter returnTyp * @throws IOException thrown in case of I/O errors * @throws HttpMediaTypeNotAcceptableException thrown when the conditions indicated * by the {@code Accept} header on the request cannot be met by the message c...
true
Other
spring-projects
spring-framework
c32299f734521e907585de50d70a46dcd8018f13.json
Use HttpMessageNotWritableException instead of ISE As a follow-up to the recent commit #37f9ce, this change replaces the raised IllegalStateException with HttpMessageNotWritableException. See gh-23205
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessorMockTests.java
@@ -47,6 +47,7 @@ import org.springframework.http.RequestEntity; import org.springframework.http.ResponseEntity; import org.springframework.http.converter.HttpMessageConverter; +import org.springframework.http.converter.HttpMessageNotWritableException; import org.springframework.mock.web.test.MockHttpServletRequest...
true
Other
spring-projects
spring-framework
9a71a8d357caf94ba71236a01ecc786c0a7f308d.json
Fix checkstyle violation Closes gh-23276
spring-tx/src/test/java/org/springframework/transaction/event/TransactionalEventListenerTests.java
@@ -48,8 +48,12 @@ import org.springframework.util.LinkedMultiValueMap; import org.springframework.util.MultiValueMap; -import static org.assertj.core.api.Assertions.*; -import static org.springframework.transaction.event.TransactionPhase.*; +import static org.assertj.core.api.Assertions.assertThat; +import static ...
false
Other
spring-projects
spring-framework
5e9a22d118778487255a1e1d87c2368f69f2e329.json
Add nohttp to build See gh-22839
src/nohttp/whitelist.lines
@@ -1,17 +1,25 @@ +^http://aopalliance.sourceforge.net.* ^http://[^/]*caucho.com.* +^http://cglib.sourceforge.net.* +^http://classdoc.sourceforge.net.* +^http://easymock.org.* +^http://forum.thymeleaf.org.* ^http://[^/]*gebish.org.* ^http://[^/]*groovy-lang.org.* ^http://[^/]*hsqldb.org.* -^http://[^/]*sourceforge....
false
Other
spring-projects
spring-framework
4fa11a5061c1628b1cb60285544bb69aa42bc4c3.json
Add nohttp to build See gh-22839
build.gradle
@@ -4,6 +4,7 @@ buildscript { } dependencies { classpath("io.spring.gradle:propdeps-plugin:0.0.9.RELEASE") + classpath("io.spring.nohttp:nohttp-gradle:0.0.2.RELEASE") classpath("org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16") } } @@ -252,9 +253,21 @@ configure(rootProject) { description = "Spring Fram...
true
Other
spring-projects
spring-framework
4fa11a5061c1628b1cb60285544bb69aa42bc4c3.json
Add nohttp to build See gh-22839
src/nohttp/whitelist.lines
@@ -0,0 +1,17 @@ +^http://[^/]*caucho.com.* +^http://[^/]*gebish.org.* +^http://[^/]*groovy-lang.org.* +^http://[^/]*hsqldb.org.* +^http://[^/]*sourceforge.net.* +^http://easymock.org.* +^http://forum.thymeleaf.org.* +^http://jotm.objectweb.org.* +^http://json-b.net/.* +^http://objenesis.org.* +^http://reactivex.io.* +...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/HostRequestMatcher.java
@@ -41,11 +41,11 @@ * <p>Alternatively, one can also specify the port. For example, the following would match * any request to the host {@code "code.jquery.com"} with the port of {@code 80}. * - * <pre class="code">WebRequestMatcher cdnMatcher = new HostMatcher("code.jquery.com:80");</pre> + * <pre class="code">W...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/test/java/org/springframework/test/web/client/match/MockRestRequestMatchersTests.java
@@ -42,30 +42,30 @@ public class MockRestRequestMatchersTests { @Test public void requestTo() throws Exception { - this.request.setURI(new URI("http://www.foo.com/bar")); + this.request.setURI(new URI("http://www.foo.example/bar")); - MockRestRequestMatchers.requestTo("http://www.foo.com/bar").match(this.req...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/HostRequestMatcherTests.java
@@ -31,14 +31,14 @@ public class HostRequestMatcherTests extends AbstractWebRequestMatcherTests { public void localhost() throws Exception { WebRequestMatcher matcher = new HostRequestMatcher("localhost"); assertMatches(matcher, "http://localhost/jquery-1.11.0.min.js"); - assertDoesNotMatch(matcher, "http://ex...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/HtmlUnitRequestBuilderTests.java
@@ -71,7 +71,7 @@ public class HtmlUnitRequestBuilderTests { @Before public void setup() throws Exception { - webRequest = new WebRequest(new URL("http://example.com:80/test/this/here")); + webRequest = new WebRequest(new URL("https://example.com/test/this/here")); webRequest.setHttpMethod(HttpMethod.GET); ...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockMvcConnectionBuilderSupportTests.java
@@ -108,13 +108,13 @@ public void mockMvcExampleDotCom() throws Exception { assertMockMvcUsed(conn, "http://localhost/"); assertMockMvcUsed(conn, "https://example.com/"); - assertMockMvcNotUsed(conn, "http://other.com/"); + assertMockMvcNotUsed(conn, "http://other.example/"); } @Test public void mockM...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockWebResponseBuilderTests.java
@@ -50,7 +50,7 @@ public class MockWebResponseBuilderTests { @Before public void setup() throws Exception { - this.webRequest = new WebRequest(new URL("http://example.com:80/test/this/here")); + this.webRequest = new WebRequest(new URL("http://company.example:80/test/this/here")); this.responseBuilder = new ...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/http/server/ServletServerHttpRequestTests.java
@@ -81,18 +81,22 @@ public void getUriWithQueryString() throws URISyntaxException { @Test // SPR-16414 public void getUriWithQueryParam() throws URISyntaxException { + mockRequest.setScheme("https"); + mockRequest.setServerPort(443); mockRequest.setServerName("example.com"); mockRequest.setRequestURI("/p...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/cors/DefaultCorsProcessorTests.java
@@ -50,7 +50,7 @@ public class DefaultCorsProcessorTests { public void setup() { this.request = new MockHttpServletRequest(); this.request.setRequestURI("/test.html"); - this.request.setServerName("domain1.com"); + this.request.setServerName("domain1.example"); this.conf = new CorsConfiguration(); this....
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/cors/reactive/CorsUtilsTests.java
@@ -39,7 +39,7 @@ public class CorsUtilsTests { @Test public void isCorsRequest() { - ServerHttpRequest request = get("http://domain.com/").header(HttpHeaders.ORIGIN, "https://domain.com").build(); + ServerHttpRequest request = get("http://domain.example/").header(HttpHeaders.ORIGIN, "https://domain.com").build...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/cors/reactive/DefaultCorsProcessorTests.java
@@ -58,7 +58,7 @@ public void setup() { @Test public void requestWithoutOriginHeader() throws Exception { MockServerHttpRequest request = MockServerHttpRequest - .method(HttpMethod.GET, "http://domain1.com/test.html") + .method(HttpMethod.GET, "http://domain1.example/test.html") .build(); ServerWeb...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/filter/ForwardedHeaderFilterTests.java
@@ -313,7 +313,7 @@ public void forwardedRequestWithSsl() throws Exception { public void forwardedRequestWithServletForward() throws Exception { this.request.setRequestURI("/foo"); this.request.addHeader(X_FORWARDED_PROTO, "https"); - this.request.addHeader(X_FORWARDED_HOST, "www.mycompany.com"); + this.reque...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/util/DefaultUriBuilderFactoryTests.java
@@ -49,31 +49,31 @@ public void defaultSettingsWithBuilder() { @Test public void baseUri() { - DefaultUriBuilderFactory factory = new DefaultUriBuilderFactory("https://foo.com/v1?id=123"); + DefaultUriBuilderFactory factory = new DefaultUriBuilderFactory("https://foo.example/v1?id=123"); URI uri = factory.ur...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-web/src/test/java/org/springframework/web/util/WebUtilsTests.java
@@ -92,41 +92,41 @@ public void parseMatrixVariablesString() { @Test public void isValidOrigin() { List<String> allowed = Collections.emptyList(); - assertThat(checkValidOrigin("mydomain1.com", -1, "http://mydomain1.com", allowed)).isTrue(); - assertThat(checkValidOrigin("mydomain1.com", -1, "http://mydomain2....
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webflux/src/test/java/org/springframework/web/reactive/resource/AppCacheManifestTransformerTests.java
@@ -107,13 +107,13 @@ public void transformManifest() throws Exception { assertThat(content).as("not rewrite external resources") .contains("//example.org/style.css") - .contains("http://example.org/image.png"); + .contains("https://example.org/image.png"); // Not the same hash as Spring MVC // ...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webflux/src/test/java/org/springframework/web/reactive/result/view/RedirectViewTests.java
@@ -97,13 +97,13 @@ public void remoteHost() { assertThat(view.isRemoteHost("https://url.somewhere.com")).isFalse(); assertThat(view.isRemoteHost("/path")).isFalse(); - assertThat(view.isRemoteHost("http://url.somewhereelse.com")).isFalse(); + assertThat(view.isRemoteHost("http://somewhereelse.example")).isFa...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webflux/src/test/resources/org/springframework/web/reactive/resource/test/test.appcache
@@ -11,7 +11,7 @@ NETWORK: CACHE: js/bar.js -http://example.org/image.png +https://example.org/image.png FALLBACK: /main /static.html \ No newline at end of file
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webmvc/src/main/java/org/springframework/web/servlet/support/ServletUriComponentsBuilder.java
@@ -191,12 +191,12 @@ private void initPath(String path) { * requestURI}. This method must be invoked before any calls to {@link #path(String)} * or {@link #pathSegment(String...)}. * <pre> - * GET http://www.foo.com/rest/books/6.json + * GET http://www.foo.example/rest/books/6.json * * ServletUriCompo...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/CrossOriginTests.java
@@ -211,7 +211,7 @@ public void classLevelComposedAnnotation() throws Exception { CorsConfiguration config = getCorsConfiguration(chain, false); assertThat(config).isNotNull(); assertThat(config.getAllowedMethods().toArray()).isEqualTo(new String[] {"GET"}); - assertThat(config.getAllowedOrigins().toArray())....
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/AppCacheManifestTransformerTests.java
@@ -109,10 +109,10 @@ public void transformManifest() throws Exception { assertThat(content).as("not rewrite external resources") .contains("//example.org/style.css") - .contains("http://example.org/image.png"); + .contains("https://example.org/image.png"); assertThat(content).as("generate fingerpr...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webmvc/src/test/java/org/springframework/web/servlet/view/RedirectViewTests.java
@@ -208,13 +208,13 @@ public void remoteHost() throws Exception { assertThat(rv.isRemoteHost("https://url.somewhere.com")).isFalse(); assertThat(rv.isRemoteHost("/path")).isFalse(); - assertThat(rv.isRemoteHost("http://url.somewhereelse.com")).isFalse(); + assertThat(rv.isRemoteHost("http://somewhereelse.exam...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-webmvc/src/test/resources/org/springframework/web/servlet/resource/test/test.appcache
@@ -11,7 +11,7 @@ NETWORK: CACHE: js/bar.js -http://example.org/image.png +https://example.org/image.png FALLBACK: /main /static.html \ No newline at end of file
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/java/org/springframework/web/socket/config/HandlersBeanDefinitionParserTests.java
@@ -226,8 +226,8 @@ public void sockJsAttributes() { List<HandshakeInterceptor> interceptors = transportService.getHandshakeInterceptors(); assertThat(interceptors).extracting("class").containsExactly(OriginHandshakeInterceptor.class); assertThat(transportService.shouldSuppressCors()).isTrue(); - assertThat(t...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/java/org/springframework/web/socket/config/annotation/WebSocketHandlerRegistrationTests.java
@@ -115,7 +115,7 @@ public void interceptorsWithAllowedOrigins() { WebSocketHandler handler = new TextWebSocketHandler(); HttpSessionHandshakeInterceptor interceptor = new HttpSessionHandshakeInterceptor(); - this.registration.addHandler(handler, "/foo").addInterceptors(interceptor).setAllowedOrigins("https://...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/java/org/springframework/web/socket/server/support/OriginHandshakeInterceptorTests.java
@@ -53,54 +53,54 @@ public void invalidInput() { @Test public void originValueMatch() throws Exception { - this.servletRequest.addHeader(HttpHeaders.ORIGIN, "https://mydomain1.com"); - List<String> allowed = Collections.singletonList("https://mydomain1.com"); + this.servletRequest.addHeader(HttpHeaders.ORIGIN,...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/java/org/springframework/web/socket/sockjs/support/SockJsServiceTests.java
@@ -105,7 +105,7 @@ public void handleInfoGet() throws IOException { body = this.servletResponse.getContentAsString(); assertThat(body.substring(body.indexOf(','))).isEqualTo(",\"origins\":[\"*:*\"],\"cookie_needed\":false,\"websocket\":false}"); - this.service.setAllowedOrigins(Collections.singletonList("http...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/java/org/springframework/web/socket/sockjs/transport/handler/DefaultSockJsServiceTests.java
@@ -164,8 +164,8 @@ public void handleTransportRequestXhr() throws Exception { public void handleTransportRequestXhrAllowedOriginsMatch() throws Exception { String sockJsPath = sessionUrlPrefix + "xhr"; setRequest("POST", sockJsPrefix + sockJsPath); - this.service.setAllowedOrigins(Arrays.asList("https://mydom...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-broker-simple.xml
@@ -17,7 +17,7 @@ </websocket:decorator-factories> </websocket:transport> - <websocket:stomp-endpoint path=" /foo,/bar" allowed-origins="https://mydomain1.com,https://mydomain2.com"> + <websocket:stomp-endpoint path=" /foo,/bar" allowed-origins="https://mydomain1.example,https://mydomain2.example"> <webs...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-handlers-attributes.xml
@@ -5,7 +5,7 @@ http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd http://www.springframework.org/schema/websocket https://www.springframework.org/schema/websocket/spring-websocket.xsd"> - <websocket:handlers order="2" allowed-origins="https://mydomai...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
spring-websocket/src/test/resources/org/springframework/web/socket/config/websocket-config-handlers-sockjs-attributes.xml
@@ -5,7 +5,7 @@ http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd http://www.springframework.org/schema/websocket https://www.springframework.org/schema/websocket/spring-websocket.xsd"> - <websocket:handlers allowed-origins="https://mydomain1.com, ht...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/docs/asciidoc/core/core-appendix.adoc
@@ -714,10 +714,10 @@ to configure `SimpleDateFormat` objects: <!-- myns.xsd (inside package org/springframework/samples/xml) --> <?xml version="1.0" encoding="UTF-8"?> - <xsd:schema xmlns="http://www.mycompany.com/schema/myns" + <xsd:schema xmlns="http://www.mycompany.example/schema/myns" xmlns:xsd="http://w...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/docs/asciidoc/integration.adoc
@@ -5650,12 +5650,12 @@ The following example shows the bean definitions for the preceding code: [subs="verbatim,quotes"] ---- <bean id="mailSender" class="org.springframework.mail.javamail.JavaMailSenderImpl"> - <property name="host" value="mail.mycompany.com"/> + <property name="host" value="mail.mycompany.exam...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/eclipse/org.eclipse.jdt.ui.prefs
@@ -63,4 +63,4 @@ org.eclipse.jdt.ui.keywordthis=false org.eclipse.jdt.ui.ondemandthreshold=9999 org.eclipse.jdt.ui.overrideannotation=true org.eclipse.jdt.ui.staticondemandthreshold=9999 -org.eclipse.jdt.ui.text.custom_code_templates=<?xml version\="1.0" encoding\="UTF-8" standalone\="no"?><templates><template auto...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/test/resources/META-INF/spring.handlers
@@ -1 +1 @@ -http\://www.foo.com/schema/component=com.foo.ComponentNamespaceHandler \ No newline at end of file +http\://www.foo.example/schema/component=com.foo.ComponentNamespaceHandler \ No newline at end of file
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/test/resources/META-INF/spring.schemas
@@ -1 +1 @@ -http\://www.foo.com/schema/component/component.xsd=com/foo/component.xsd \ No newline at end of file +http\://www.foo.example/schema/component/component.xsd=com/foo/component.xsd \ No newline at end of file
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/test/resources/com/foo/component-config.xml
@@ -1,10 +1,10 @@ <?xml version="1.0" encoding="UTF-8"?> <beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" - xmlns:foo="http://www.foo.com/schema/component" + xmlns:foo="http://www.foo.example/schema/component" xsi:schemaLocation="...
true
Other
spring-projects
spring-framework
fde92793b53796b6905531b5c05e36be9b388f4a.json
Fix http URLs See gh-22839
src/test/resources/com/foo/component.xsd
@@ -1,8 +1,8 @@ <?xml version="1.0" encoding="UTF-8" standalone="no"?> -<xsd:schema xmlns="http://www.foo.com/schema/component" +<xsd:schema xmlns="http://www.foo.example/schema/component" xmlns:xsd="http://www.w3.org/2001/XMLSchema" - targetNamespace="http://www.foo.com/schema/component" + ...
true
Other
spring-projects
spring-framework
b5fba14ab8396fb50b9ec3e6b19dea9f1c74b350.json
Fix Checkstyle violation Eclipse apparently sorts static imports differently.
spring-test/src/test/java/org/springframework/test/context/support/TestConstructorUtilsTests.java
@@ -26,7 +26,6 @@ import org.springframework.test.context.TestConstructor; import static org.assertj.core.api.Assertions.assertThat; -import static org.springframework.test.context.TestConstructor.TEST_CONSTRUCTOR_AUTOWIRE_MODE_PROPERTY_NAME; import static org.springframework.test.context.TestConstructor.AutowireM...
false
Other
spring-projects
spring-framework
c08035b674a8df18de59c3a9375681359baaf6a0.json
Remove unused Coroutines extension parameter
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
@@ -119,7 +119,7 @@ inline fun <reified T : Any> WebClient.ResponseSpec.bodyToFlux(): Flux<T> = * @since 5.2 */ @ExperimentalCoroutinesApi -inline fun <reified T : Any> WebClient.ResponseSpec.bodyToFlow(batchSize: Int = 1): Flow<T> = +inline fun <reified T : Any> WebClient.ResponseSpec.bodyToFlow(): Flow<T> = b...
false
Other
spring-projects
spring-framework
81eb911c09378058d185c2def8273cbbdc2665b2.json
Fix typo in UrlPathHelper See gh-23274
spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java
@@ -256,7 +256,7 @@ public String getPathWithinApplication(HttpServletRequest request) { * Match the given "mapping" to the start of the "requestUri" and if there * is a match return the extra part. This method is needed because the * context path and the servlet path returned by the HttpServletRequest are - ...
false
Other
spring-projects
spring-framework
827ec5d5a2f383b97ffd06c2687e2b4b3308b23d.json
Add unit tests for PropertyAccessorUtils Closes gh-23251
spring-beans/src/test/java/org/springframework/beans/PropertyAccessorUtilsTests.java
@@ -28,8 +28,60 @@ */ public class PropertyAccessorUtilsTests { + @Test + public void testGetPropertyName() { + assertThat(PropertyAccessorUtils.getPropertyName("foo")) + .isEqualTo("foo"); + assertThat(PropertyAccessorUtils.getPropertyName("[foo]")) + .isEqualTo(""); + } + + @Test + public void testIsNest...
false
Other
spring-projects
spring-framework
e124cbb310721041731421c41030e6a1d2d06286.json
Fix Checkstyle violation
spring-expression/src/test/java/org/springframework/expression/spel/MethodInvocationTests.java
@@ -27,7 +27,6 @@ import org.springframework.core.convert.TypeDescriptor; import org.springframework.expression.AccessException; -import org.springframework.expression.BeanResolver; import org.springframework.expression.EvaluationContext; import org.springframework.expression.Expression; import org.springframewo...
false
Other
spring-projects
spring-framework
9de4c4aefb30aeb66eb79fef824fce851f154f27.json
Enable parallel builds by default Previously, all tasks in the build were run sequentially. This commit updates Gradle's properties to build them in parallel where possible. When using the daemon (recommended) its default max heap is not sufficient for the demands on a parallel build, therefore this commit also increa...
gradle.properties
@@ -1,2 +1,4 @@ version=5.2.0.BUILD-SNAPSHOT -org.gradle.caching=false \ No newline at end of file +org.gradle.caching=false +org.gradle.parallel=true +org.gradle.jvmargs=-Xmx1536M
false
Other
spring-projects
spring-framework
5d5f9aceca7e953fa8c783e9730478205f7d3e2a.json
Avoid accidental usage of JUnit 4 assumptions This commit also avoids starting a server if an assumption fails.
spring-web/src/test/java/org/springframework/http/server/reactive/AbstractHttpHandlerIntegrationTests.java
@@ -90,8 +90,10 @@ protected void startServer(HttpServer httpServer) throws Exception { @AfterEach void stopServer() { - this.server.stop(); - this.port = 0; + if (this.server != null) { + this.server.stop(); + this.port = 0; + } }
true
Other
spring-projects
spring-framework
5d5f9aceca7e953fa8c783e9730478205f7d3e2a.json
Avoid accidental usage of JUnit 4 assumptions This commit also avoids starting a server if an assumption fails.
spring-web/src/test/java/org/springframework/http/server/reactive/ZeroCopyIntegrationTests.java
@@ -33,7 +33,7 @@ import org.springframework.web.client.RestTemplate; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assume.assumeTrue; +import static org.junit.jupiter.api.Assumptions.assumeTrue; /** * @author Arjen Poutsma @@ -51,10 +51,10 @@ protected HttpHandler createHt...
true
Other
spring-projects
spring-framework
5d5f9aceca7e953fa8c783e9730478205f7d3e2a.json
Avoid accidental usage of JUnit 4 assumptions This commit also avoids starting a server if an assumption fails.
spring-web/src/test/java/org/springframework/web/client/RestTemplateIntegrationTests.java
@@ -57,7 +57,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatExceptionOfType; -import static org.junit.Assume.assumeFalse; +import static org.junit.jupiter.api.Assumptions.assumeFalse; import static org.springframework.http.HttpMethod.POST; im...
true
Other
spring-projects
spring-framework
5d5f9aceca7e953fa8c783e9730478205f7d3e2a.json
Avoid accidental usage of JUnit 4 assumptions This commit also avoids starting a server if an assumption fails.
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SseIntegrationTests.java
@@ -141,9 +141,9 @@ void sseAsPerson(HttpServer httpServer, ClientHttpConnector connector) throws Ex @ParameterizedSseTest void sseAsEvent(HttpServer httpServer, ClientHttpConnector connector) throws Exception { - startServer(httpServer, connector); + assumeTrue(httpServer instanceof JettyHttpServer); - assu...
true
Other
spring-projects
spring-framework
d9e3b8b9a5526b5ca31b5a974c684f808adffb6b.json
Introduce default constructor in TomcatHttpServer
spring-web/src/test/java/org/springframework/http/server/reactive/AbstractHttpHandlerIntegrationTests.java
@@ -16,7 +16,6 @@ package org.springframework.http.server.reactive; -import java.io.File; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; @@ -125,11 +124,10 @@ public static Flux<Long> testInterval(Duration period, int count) { } ...
true
Other
spring-projects
spring-framework
d9e3b8b9a5526b5ca31b5a974c684f808adffb6b.json
Introduce default constructor in TomcatHttpServer
spring-web/src/test/java/org/springframework/http/server/reactive/bootstrap/TomcatHttpServer.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -42,6 +42,15 @@ public class TomcatHttpServe...
true
Other
spring-projects
spring-framework
d9e3b8b9a5526b5ca31b5a974c684f808adffb6b.json
Introduce default constructor in TomcatHttpServer
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ContextPathIntegrationTests.java
@@ -15,7 +15,6 @@ */ package org.springframework.web.reactive.result.method.annotation; -import java.io.File; import org.junit.jupiter.api.Test; @@ -84,8 +83,7 @@ public void servletPathMapping() throws Exception { context.register(WebAppConfig.class); context.refresh(); - File base = new File(System...
true
Other
spring-projects
spring-framework
d9e3b8b9a5526b5ca31b5a974c684f808adffb6b.json
Introduce default constructor in TomcatHttpServer
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SseIntegrationTests.java
@@ -16,7 +16,6 @@ package org.springframework.web.reactive.result.method.annotation; -import java.io.File; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; @@ -71,14 +70,13 @@ class SseIntegrationTests extends AbstractHttpHandlerIntegra...
true
Other
spring-projects
spring-framework
facdbdb7b62f6b62011934a758e29c5481af4a0b.json
Fix checkstyle violation
spring-websocket/src/test/java/org/springframework/web/socket/server/support/WebSocketHttpRequestHandlerTests.java
@@ -40,7 +40,6 @@ import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verifyNoMoreInteractions; -import static org.mockito.Mockito.when; /** * Unit tests for {@link WebSocketHttpRequestHandler}.
false
Other
spring-projects
spring-framework
6fbd4841ec4a20cfd8c5338c6bcf0171839c2326.json
Update checkstyle import rule Update the checkstyle rule to enforce the blank line between `java` and `javax`. Closes gh-23539
src/checkstyle/checkstyle.xml
@@ -90,7 +90,7 @@ <property name="processJavadoc" value="true" /> </module> <module name="com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck"> - <property name="groups" value="/javax?/,/[^org\.springframework]/,org.springframework" /> + <property name="groups" value="java,/^javax?\./,*,org.sp...
false
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
integration-tests/src/test/java/org/springframework/aop/framework/autoproxy/AdvisorAutoProxyCreatorIntegrationTests.java
@@ -19,6 +19,7 @@ import java.io.IOException; import java.lang.reflect.Method; import java.util.List; + import javax.servlet.ServletException; import org.junit.jupiter.api.Test;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
integration-tests/src/test/java/org/springframework/context/annotation/jsr330/ClassPathBeanDefinitionScannerJsr330ScopeIntegrationTests.java
@@ -20,6 +20,7 @@ import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; + import javax.inject.Named; import javax.inject.Singleton;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
integration-tests/src/test/java/org/springframework/transaction/annotation/EnableTransactionManagementIntegrationTests.java
@@ -20,6 +20,7 @@ import java.util.Arrays; import java.util.Collections; import java.util.List; + import javax.sql.DataSource; import org.junit.jupiter.api.Test;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-aop/src/test/java/org/springframework/aop/framework/ProxyFactoryTests.java
@@ -18,6 +18,7 @@ import java.util.ArrayList; import java.util.List; + import javax.accessibility.Accessible; import javax.swing.JFrame; import javax.swing.RootPaneContainer;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-aspects/src/test/java/org/springframework/cache/config/AnnotatedJCacheableService.java
@@ -19,6 +19,7 @@ import java.io.IOException; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.atomic.AtomicLong; + import javax.cache.annotation.CacheDefaults; import javax.cache.annotation.CacheKey; import javax.cache.annotation.CachePut;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-aspects/src/test/java/org/springframework/transaction/aspectj/JtaTransactionAspectsTests.java
@@ -17,6 +17,7 @@ package org.springframework.transaction.aspectj; import java.io.IOException; + import javax.transaction.Transactional; import org.junit.jupiter.api.BeforeEach;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/main/java/org/springframework/beans/factory/config/ProviderCreatingFactoryBean.java
@@ -17,6 +17,7 @@ package org.springframework.beans.factory.config; import java.io.Serializable; + import javax.inject.Provider; import org.springframework.beans.BeansException;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java
@@ -43,6 +43,7 @@ import java.util.function.Consumer; import java.util.function.Predicate; import java.util.stream.Stream; + import javax.inject.Provider; import org.springframework.beans.BeanUtils;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/main/java/org/springframework/beans/factory/xml/XmlBeanDefinitionReader.java
@@ -20,6 +20,7 @@ import java.io.InputStream; import java.util.HashSet; import java.util.Set; + import javax.xml.parsers.ParserConfigurationException; import org.w3c.dom.Document;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java
@@ -38,6 +38,7 @@ import java.util.Set; import java.util.concurrent.Callable; import java.util.stream.Collectors; + import javax.annotation.Priority; import javax.security.auth.Subject;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java
@@ -22,6 +22,7 @@ import java.util.List; import java.util.Map; import java.util.Optional; + import javax.inject.Inject; import javax.inject.Named; import javax.inject.Provider;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/test/java/org/springframework/beans/factory/config/ObjectFactoryCreatingFactoryBeanTests.java
@@ -17,6 +17,7 @@ package org.springframework.beans.factory.config; import java.util.Date; + import javax.inject.Provider; import org.junit.jupiter.api.AfterEach;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/test/java/org/springframework/beans/factory/serviceloader/ServiceLoaderTests.java
@@ -18,6 +18,7 @@ import java.util.List; import java.util.ServiceLoader; + import javax.xml.parsers.DocumentBuilderFactory; import org.junit.jupiter.api.Test;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-beans/src/test/java/org/springframework/beans/factory/support/security/CallbacksSecurityTests.java
@@ -29,6 +29,7 @@ import java.util.PropertyPermission; import java.util.Set; import java.util.function.Consumer; + import javax.security.auth.AuthPermission; import javax.security.auth.Subject;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/CandidateComponentsIndexer.java
@@ -23,6 +23,7 @@ import java.util.LinkedHashSet; import java.util.List; import java.util.Set; + import javax.annotation.processing.Completion; import javax.annotation.processing.ProcessingEnvironment; import javax.annotation.processing.Processor;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/IndexedStereotypesProvider.java
@@ -19,6 +19,7 @@ import java.util.HashSet; import java.util.LinkedHashSet; import java.util.Set; + import javax.lang.model.element.AnnotationMirror; import javax.lang.model.element.Element; import javax.lang.model.element.ElementKind;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/MetadataCollector.java
@@ -20,6 +20,7 @@ import java.util.HashSet; import java.util.List; import java.util.Set; + import javax.annotation.processing.ProcessingEnvironment; import javax.annotation.processing.RoundEnvironment; import javax.lang.model.element.Element;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/MetadataStore.java
@@ -19,6 +19,7 @@ import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; + import javax.annotation.processing.ProcessingEnvironment; import javax.tools.FileObject; import javax.tools.StandardLocation;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/PackageInfoStereotypesProvider.java
@@ -18,6 +18,7 @@ import java.util.HashSet; import java.util.Set; + import javax.lang.model.element.Element; import javax.lang.model.element.ElementKind;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/StandardStereotypesProvider.java
@@ -18,6 +18,7 @@ import java.util.LinkedHashSet; import java.util.Set; + import javax.lang.model.element.AnnotationMirror; import javax.lang.model.element.Element; import javax.lang.model.element.ElementKind;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/StereotypesProvider.java
@@ -17,6 +17,7 @@ package org.springframework.context.index.processor; import java.util.Set; + import javax.lang.model.element.Element; /**
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/main/java/org/springframework/context/index/processor/TypeHelper.java
@@ -19,6 +19,7 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; + import javax.annotation.processing.ProcessingEnvironment; import javax.lang.model.element.AnnotationMirror; import javax.lang.model.element.Element;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/test/java/org/springframework/context/index/processor/CandidateComponentsIndexerTests.java
@@ -20,6 +20,7 @@ import java.io.FileInputStream; import java.io.IOException; import java.nio.file.Path; + import javax.annotation.ManagedBean; import javax.inject.Named; import javax.persistence.Converter;
true
Other
spring-projects
spring-framework
deba2ed1b3d422bbdd86b8573402e5a1cb1eb699.json
Add blank line between java and javax imports See gh-23539
spring-context-indexer/src/test/java/org/springframework/context/index/test/TestCompiler.java
@@ -23,6 +23,7 @@ import java.util.Collections; import java.util.List; import java.util.stream.Collectors; + import javax.annotation.processing.Processor; import javax.tools.JavaCompiler; import javax.tools.JavaFileObject;
true