language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | e9065402f2868e36353042acbc7d52abd7ea2cd9.json | Update CI pipeline to release RCs | ci/pipeline.yml | @@ -358,10 +358,51 @@ jobs:
ARTIFACTORY_SERVER: ((artifactory-server))
ARTIFACTORY_USERNAME: ((artifactory-username))
ARTIFACTORY_PASSWORD: ((artifactory-password))
+- name: stage-rc
+ serial: true
+ plan:
+ - get: spring-framework-ci-image
+ - get: git-repo
+ trigger: false
+ ... | false |
Other | spring-projects | spring-framework | 0556fdecaa3b228880e7322529a385c5ebbfe5c1.json | Delete unused code in DataClassRowMapper | spring-jdbc/src/main/java/org/springframework/jdbc/core/DataClassRowMapper.java | @@ -22,8 +22,6 @@
import org.springframework.beans.BeanUtils;
import org.springframework.beans.TypeConverter;
-import org.springframework.core.DefaultParameterNameDiscoverer;
-import org.springframework.core.ParameterNameDiscoverer;
import org.springframework.core.convert.ConversionService;
import org.springframe... | false |
Other | spring-projects | spring-framework | dccc78146a281208874b76e5bb69bb8bc3af608d.json | Expose defaultCharset in StringDecoder
Closes gh-25762 | spring-core/src/main/java/org/springframework/core/codec/StringDecoder.java | @@ -72,6 +72,8 @@ public final class StringDecoder extends AbstractDataBufferDecoder<String> {
private final boolean stripDelimiter;
+ private Charset defaultCharset = DEFAULT_CHARSET;
+
private final ConcurrentMap<Charset, byte[][]> delimitersCache = new ConcurrentHashMap<>();
@@ -83,6 +85,24 @@ private St... | false |
Other | spring-projects | spring-framework | 4dfecde69426aa3e644441250a1be5a68ced2250.json | fix core doc English regarding @AspectJ | src/docs/asciidoc/core/core-aop.adoc | @@ -2918,7 +2918,7 @@ an aspect weaving phase to your build script.
If you have chosen to use Spring AOP, you have a choice of @AspectJ or XML style.
There are various tradeoffs to consider.
-The XML style may most familiar to existing Spring users, and it is backed by genuine
+The XML style may be most familiar to... | false |
Other | spring-projects | spring-framework | 0db3f2b4de4bdd723b65e718c67635fdce8d13fd.json | Publish documentation under reference/html folder
This is done:
- For consistency with other Spring projects
- Because it is probably a better option to use reference instead of
spring-framework-reference (spring-framework is already present in
the URL)
- To improve PDF documentation discoverability
As a con... | gradle/docs.gradle | @@ -188,10 +188,10 @@ task docsZip(type: Zip, dependsOn: ['api', 'asciidoctor', 'dokka']) {
into "javadoc-api"
}
from ("$asciidoctor.outputDir/html5") {
- into "spring-framework-reference"
+ into "reference/html"
}
from ("$asciidoctor.outputDir/pdf") {
- into "spring-framework-reference/pdf"
+ into "refe... | false |
Other | spring-projects | spring-framework | f7a014d7dc577ad5327a11c71169f3be122d5ae7.json | Improve MIME type subtype suffix handling
Prior to this commit, the subtype suffix of a MIME type (see RFC 6839)
was not properly taken into account when checking compatibility between
MIME types.
For example, `"application/*"` was not considered as compatible with
`"application/vnd.io.spring+json"`.
This commit add... | spring-core/src/main/java/org/springframework/util/MimeType.java | @@ -284,6 +284,19 @@ public String getSubtype() {
return this.subtype;
}
+ /**
+ * Return the subtype suffix as defined in RFC 6839.
+ * @since 5.3
+ */
+ @Nullable
+ public String getSubtypeSuffix() {
+ int suffixIndex = this.subtype.lastIndexOf('+');
+ if (suffixIndex != -1 && this.subtype.length() > suff... | true |
Other | spring-projects | spring-framework | f7a014d7dc577ad5327a11c71169f3be122d5ae7.json | Improve MIME type subtype suffix handling
Prior to this commit, the subtype suffix of a MIME type (see RFC 6839)
was not properly taken into account when checking compatibility between
MIME types.
For example, `"application/*"` was not considered as compatible with
`"application/vnd.io.spring+json"`.
This commit add... | spring-core/src/test/java/org/springframework/util/MimeTypeTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -320,6 +320,25 @@ void parseMimeTypesWithQuo... | true |
Other | spring-projects | spring-framework | b92515bdee5a3f153183e2f86ee5e378c28b0d1e.json | Add logger.isInfoEnabled check before logger.info
Closes gh-24667 | spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java | @@ -254,7 +254,7 @@ public Object getObject() throws BeansException {
return getSingletonInstance();
}
else {
- if (this.targetName == null) {
+ if (this.targetName == null && logger.isInfoEnabled()) {
logger.info("Using non-singleton proxies with singleton targets is often undesirable. " +
"E... | false |
Other | spring-projects | spring-framework | f5195887c94c5a75864f76038f86a90941a47381.json | Fix ampersands in AOP examples in documentation | src/docs/asciidoc/core/core-aop.adoc | @@ -2069,7 +2069,7 @@ collects the `this` object as the join point context and passes it to the advice
<aop:aspect id="myAspect" ref="aBean">
<aop:pointcut id="businessService"
- expression="execution(* com.xyz.myapp.service.*.*(..)) && this(service)"/>
+ expression="execution(* com.xyz.myapp.ser... | false |
Other | spring-projects | spring-framework | cc1f57823ba6e29d861817df23d71106dcd3277e.json | Remove charset from content-type in SseEmitter
See gh-24632 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java | @@ -41,9 +41,6 @@ public class SseEmitter extends ResponseBodyEmitter {
static final MediaType TEXT_PLAIN = new MediaType("text", "plain", StandardCharsets.UTF_8);
- static final MediaType TEXT_EVENTSTREAM = new MediaType("text", "event-stream", StandardCharsets.UTF_8);
-
-
/**
* Create a new SseEmitter inst... | true |
Other | spring-projects | spring-framework | cc1f57823ba6e29d861817df23d71106dcd3277e.json | Remove charset from content-type in SseEmitter
See gh-24632 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterReturnValueHandlerTests.java | @@ -211,7 +211,7 @@ public void sseEmitter() throws Exception {
emitter.send(SseEmitter.event().
comment("a test").name("update").id("1").reconnectTime(5000L).data(bean1).data(bean2));
- assertThat(this.response.getContentType()).isEqualTo("text/event-stream;charset=UTF-8");
+ assertThat(this.response.getCo... | true |
Other | spring-projects | spring-framework | c7e037da39d2c0d57e0b895504c7a296fe77e43a.json | Remove unnecessary calls to disableContentCaching
These calls were added in error when trying to fix #22797 and #23775.
They are not needed in 304 scenarios. Those have no response content and
are skipped by ShallowETagHeaderFilter based on the status.
This leaves disableContentCaching invoked only in streaming scena... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessor.java | @@ -47,7 +47,6 @@
import org.springframework.web.bind.support.WebDataBinderFactory;
import org.springframework.web.context.request.NativeWebRequest;
import org.springframework.web.context.request.ServletWebRequest;
-import org.springframework.web.filter.ShallowEtagHeaderFilter;
import org.springframework.web.method... | true |
Other | spring-projects | spring-framework | c7e037da39d2c0d57e0b895504c7a296fe77e43a.json | Remove unnecessary calls to disableContentCaching
These calls were added in error when trying to fix #22797 and #23775.
They are not needed in 304 scenarios. Those have no response content and
are skipped by ShallowETagHeaderFilter based on the status.
This leaves disableContentCaching invoked only in streaming scena... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ServletInvocableHandlerMethod.java | @@ -36,7 +36,6 @@
import org.springframework.web.bind.annotation.ResponseBody;
import org.springframework.web.bind.annotation.ResponseStatus;
import org.springframework.web.context.request.ServletWebRequest;
-import org.springframework.web.filter.ShallowEtagHeaderFilter;
import org.springframework.web.method.Handle... | true |
Other | spring-projects | spring-framework | c7e037da39d2c0d57e0b895504c7a296fe77e43a.json | Remove unnecessary calls to disableContentCaching
These calls were added in error when trying to fix #22797 and #23775.
They are not needed in 304 scenarios. Those have no response content and
are skipped by ShallowETagHeaderFilter based on the status.
This leaves disableContentCaching invoked only in streaming scena... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessorMockTests.java | @@ -30,6 +30,8 @@
import java.util.Date;
import java.util.Set;
+import javax.servlet.FilterChain;
+
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
@@ -53,6 +55,7 @@
import org.springframework.web.HttpMediaTypeNotSupportedException;
import org.spri... | true |
Other | spring-projects | spring-framework | c7e037da39d2c0d57e0b895504c7a296fe77e43a.json | Remove unnecessary calls to disableContentCaching
These calls were added in error when trying to fix #22797 and #23775.
They are not needed in 304 scenarios. Those have no response content and
are skipped by ShallowETagHeaderFilter based on the status.
This leaves disableContentCaching invoked only in streaming scena... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletInvocableHandlerMethodTests.java | @@ -23,6 +23,7 @@
import java.util.Collections;
import java.util.List;
+import javax.servlet.FilterChain;
import javax.servlet.http.HttpServletResponse;
import org.junit.jupiter.api.Test;
@@ -143,21 +144,29 @@ public void invokeAndHandle_VoidRequestNotModified() throws Exception {
.isTrue();
}
- @Test ... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/ReflectiveAspectJAdvisorFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -154,7 +154,9 @@ private List<Method> getAdv... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -398,6 +398,9 @@ public Stream<T> stream() {... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ConsumesRequestCondition.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -76,7 +76,9 @@ public ConsumesRequestConditi... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ProducesRequestCondition.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -93,7 +93,9 @@ public ProducesRequestConditi... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/ConsumesRequestCondition.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -77,7 +77,9 @@ public ConsumesRequestConditi... | true |
Other | spring-projects | spring-framework | 2093e35f27cf742e6b447c87a8e2c37df5256a16.json | Avoid unnecessary sorting | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/ProducesRequestCondition.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -97,7 +97,9 @@ public ProducesRequestConditi... | true |
Other | spring-projects | spring-framework | 771fbde951173d334ab87ee313d91f4eb2e51418.json | Fix URL to Spring Tool Suite
See gh-24589 | src/docs/asciidoc/core/core-beans.adoc | @@ -74,7 +74,7 @@ In most application scenarios, explicit user code is not required to instantiate
more instances of a Spring IoC container. For example, in a web application scenario, a
simple eight (or so) lines of boilerplate web descriptor XML in the `web.xml` file
of the application typically suffices (see <<co... | false |
Other | spring-projects | spring-framework | e706fcba1f2d0eefc17e349f472f7c6e3be5ca8d.json | Fix typo in testing.adoc
Closes gh-24627 | src/docs/asciidoc/testing.adoc | @@ -1726,8 +1726,8 @@ a configuration class:
<1> Specify the configuration class.
-The following example shows how to use the `@SpringJUnitWebConfig` annotation to specify a
-the location of a configuration file:
+The following example shows how to use the `@SpringJUnitWebConfig` annotation to specify the
+locatio... | false |
Other | spring-projects | spring-framework | 7f5395a21685a490755850e4b767ed534c4abbfe.json | Fix typos in AbstractClientHttpRequest
Closes gh-24623 | spring-web/src/main/java/org/springframework/http/client/reactive/AbstractClientHttpRequest.java | @@ -137,13 +137,13 @@ protected Mono<Void> doCommit(@Nullable Supplier<? extends Publisher<Void>> writ
/**
- * Apply header changes from {@link #getHeaders()} to the underlying response.
+ * Apply header changes from {@link #getHeaders()} to the underlying request.
* This method is called once only.
*/
... | false |
Other | spring-projects | spring-framework | 8a7bb494362e7a081e18e40726591656551f9922.json | Improve WebClient.Builder Javadoc | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -201,7 +201,7 @@ interface Builder {
* </pre>
* <p><strong>Note:</strong> this method is mutually exclusive with
* {@link #uriBuilderFactory(UriBuilderFactory)}. If both are used, the
- * baseUrl value provided here will be ignored.
+ * defaultUriVariables value provided here will be ignored.
* @... | false |
Other | spring-projects | spring-framework | 89560777e4cea7a6e92f2ce49ac8d735a018fc49.json | Upgrade Guava for API Diff plugin
Fixes gh-24606 | buildSrc/build.gradle | @@ -9,7 +9,7 @@ repositories {
dependencies {
implementation "me.champeau.gradle:japicmp-gradle-plugin:0.2.8"
- implementation "com.google.guava:guava:18.0" // required by japicmp-gradle-plugin
+ implementation "com.google.guava:guava:28.2-jre" // required by japicmp-gradle-plugin
}
gradlePlugin { | false |
Other | spring-projects | spring-framework | b30f9a13083aa1a95c92dd4d7916eeb7474c9a1c.json | Fix typo in core-aop.adoc
Closes gh-24602 | src/docs/asciidoc/core/core-aop.adoc | @@ -1273,7 +1273,7 @@ The following example shows how to use around advice:
// start stopwatch
val retVal = pjp.proceed()
// stop stopwatch
- return pjp.proceed()
+ return retVal
}
} | false |
Other | spring-projects | spring-framework | d4de3396f732773237dc1560f415c6631bf82ed9.json | Fix typo about URI Encoding in docs
Closes gh-24603 | src/docs/asciidoc/web/web-uris.adoc | @@ -134,7 +134,7 @@ The following example shows how to configure a `RestTemplate`:
.Kotlin
----
// import org.springframework.web.util.DefaultUriBuilderFactory.EncodingMode
-
+
val baseUrl = "https://example.org"
val factory = DefaultUriBuilderFactory(baseUrl)
factory.encodingMode = EncodingMode.TEMPLATE_AND... | false |
Other | spring-projects | spring-framework | 5c2d65b8efcd5c55be59481df97d6cc4a63a14a6.json | Fix typo in reference manual
Closes gh-24597 | src/docs/asciidoc/languages/kotlin.adoc | @@ -856,14 +856,14 @@ https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#boot-featu
As described in the <<testing#testcontext-junit-jupiter-di#spring-web-reactive, dedicated section>>,
JUnit 5 allows constructor injection of beans which is pretty useful with Kotlin
in order to use `val` instead of... | false |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-expression/src/test/java/org/springframework/expression/spel/ConstructorInvocationTests.java | @@ -162,8 +162,7 @@ public void testAddingConstructorResolvers() {
ctx.addConstructorResolver(dummy);
assertThat(ctx.getConstructorResolvers().size()).isEqualTo(2);
- List<ConstructorResolver> copy = new ArrayList<>();
- copy.addAll(ctx.getConstructorResolvers());
+ List<ConstructorResolver> copy = new Array... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-expression/src/test/java/org/springframework/expression/spel/ExpressionLanguageScenarioTests.java | @@ -96,8 +96,7 @@ public void testScenario_DefiningVariablesThatWillBeAccessibleInExpressions() th
// Use the standard evaluation context
StandardEvaluationContext ctx = new StandardEvaluationContext();
ctx.setVariable("favouriteColour","blue");
- List<Integer> primes = new ArrayList<>();
- primes.addAll(Arr... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-expression/src/test/java/org/springframework/expression/spel/MethodInvocationTests.java | @@ -221,8 +221,7 @@ public void testAddingMethodResolvers() {
ctx.addMethodResolver(dummy);
assertThat(ctx.getMethodResolvers().size()).isEqualTo(2);
- List<MethodResolver> copy = new ArrayList<>();
- copy.addAll(ctx.getMethodResolvers());
+ List<MethodResolver> copy = new ArrayList<>(ctx.getMethodResolvers(... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-expression/src/test/java/org/springframework/expression/spel/PropertyAccessTests.java | @@ -135,8 +135,7 @@ public void testAddingRemovingAccessors() {
ctx.addPropertyAccessor(spa);
assertThat(ctx.getPropertyAccessors().size()).isEqualTo(2);
- List<PropertyAccessor> copy = new ArrayList<>();
- copy.addAll(ctx.getPropertyAccessors());
+ List<PropertyAccessor> copy = new ArrayList<>(ctx.getProper... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-expression/src/test/java/org/springframework/expression/spel/SpelDocumentationTests.java | @@ -420,8 +420,7 @@ public void testVariables() throws Exception {
@Test
public void testSpecialVariables() throws Exception {
// create an array of integers
- List<Integer> primes = new ArrayList<>();
- primes.addAll(Arrays.asList(2,3,5,7,11,13,17));
+ List<Integer> primes = Arrays.asList(2, 3, 5, 7, 11, 13,... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-messaging/src/test/java/org/springframework/messaging/handler/invocation/MethodMessageHandlerTests.java | @@ -205,8 +205,7 @@ protected List<? extends HandlerMethodArgumentResolver> initArgumentResolvers()
@Override
protected List<? extends HandlerMethodReturnValueHandler> initReturnValueHandlers() {
- List<HandlerMethodReturnValueHandler> handlers = new ArrayList<>();
- handlers.addAll(getCustomReturnValueHand... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-orm/src/main/java/org/springframework/orm/jpa/ExtendedEntityManagerCreator.java | @@ -240,8 +240,7 @@ private static EntityManager createProxy(
}
else {
interfaces = cachedEntityManagerInterfaces.computeIfAbsent(rawEm.getClass(), key -> {
- Set<Class<?>> ifcs = new LinkedHashSet<>();
- ifcs.addAll(ClassUtils
+ Set<Class<?>> ifcs = new LinkedHashSet<>(ClassUtils
.getAllInter... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-web/src/main/java/org/springframework/http/codec/protobuf/ProtobufDecoder.java | @@ -227,8 +227,7 @@ public Iterable<? extends Message> apply(DataBuffer input) {
this.output = input.factory().allocateBuffer(this.messageBytesToRead);
}
- chunkBytesToRead = this.messageBytesToRead >= input.readableByteCount() ?
- input.readableByteCount() : this.messageBytesToRead;
+ chun... | true |
Other | spring-projects | spring-framework | c5fb7b9fb70d0a711a963b2a160c3af5cc4be3a7.json | Simplify some redundant code
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io> | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java | @@ -320,8 +320,7 @@ public void methodNotAllowed() throws Exception {
assertThat(response.getStatus()).as("Invalid response status").isEqualTo(HttpServletResponse.SC_METHOD_NOT_ALLOWED);
String allowHeader = response.getHeader("Allow");
assertThat(allowHeader).as("No Allow header").isNotNull();
- Set<String> ... | true |
Other | spring-projects | spring-framework | 6db20eb77346c6420eef48883e89cfeb6eb1d13a.json | Avoid package import cycles | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/AbstractEmbeddedDatabaseConfigurer.java | @@ -25,8 +25,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.springframework.jdbc.support.JdbcUtils;
-
/**
* Base class for {@link EmbeddedDatabaseConfigurer} implementations
* providing common shutdown behavior through a "SHUTDOWN" statement.
@@ -55,7 +53,... | true |
Other | spring-projects | spring-framework | 6db20eb77346c6420eef48883e89cfeb6eb1d13a.json | Avoid package import cycles | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/PatternsRequestCondition.java | @@ -33,7 +33,6 @@
import org.springframework.util.PathMatcher;
import org.springframework.util.StringUtils;
import org.springframework.web.servlet.HandlerMapping;
-import org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping;
import org.springframework.web.util.UrlPathHelper;
/**
@@ ... | true |
Other | spring-projects | spring-framework | 2f12351292564fb2090707ee117620e2a51be640.json | Refine BlockHound support
- disable for Java 14/15 for now until BlockHound support
- targeted installation of required integrations only | spring-core/src/test/java/org/springframework/core/SpringCoreBlockHoundIntegrationTests.java | @@ -21,27 +21,34 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledForJreRange;
import reactor.blockhound.BlockHound;
+import reactor.core.scheduler.ReactorBlockHoundIntegration;
import reactor.core.scheduler.Schedulers;
import org.spr... | false |
Other | spring-projects | spring-framework | 7e402ba4fe4dd91eac97786cb2598cd7097f9782.json | Improve docs on date and time formatting
Closes gh-24370 | src/docs/asciidoc/core/core-validation.adoc | @@ -1693,18 +1693,18 @@ See <<web.adoc#mvc-config-conversion, Conversion and Formatting>> in the Spring
[[format-configuring-formatting-globaldatetimeformat]]
== Configuring a Global Date and Time Format
-By default, date and time fields that are not annotated with `@DateTimeFormat` are
-converted from strings by u... | true |
Other | spring-projects | spring-framework | 7e402ba4fe4dd91eac97786cb2598cd7097f9782.json | Improve docs on date and time formatting
Closes gh-24370 | src/docs/asciidoc/web/webflux.adoc | @@ -3691,11 +3691,10 @@ class WebConfig : WebFluxConfigurer {
=== Conversion, formatting
[.small]#<<web.adoc#mvc-config-conversion, Web MVC>>#
-By default, formatters for `Number` and `Date` types are installed, including support for
-the `@NumberFormat` and `@DateTimeFormat` annotations. Full support for the Joda-... | true |
Other | spring-projects | spring-framework | 7e402ba4fe4dd91eac97786cb2598cd7097f9782.json | Improve docs on date and time formatting
Closes gh-24370 | src/docs/asciidoc/web/webmvc.adoc | @@ -4977,12 +4977,10 @@ sub-elements are available.
=== Type Conversion
[.small]#<<web-reactive.adoc#webflux-config-conversion, WebFlux>>#
-By default formatters, for `Number` and `Date` types are installed, including support for
-the `@NumberFormat` and `@DateTimeFormat` annotations. Full support for the Joda-Time... | true |
Other | spring-projects | spring-framework | 7778508e69f5bb09e58779fd4cdb347bdebe13bb.json | Fix typos in ResolvableTypeTests
See gh-24529
Co-authored-by: Qimiao Chen <chenqimiao1994@126.com> | spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -308,7 +308,7 @@ void classType() throws Exc... | false |
Other | spring-projects | spring-framework | ede2a1d4b26ada78250389c0dda908212713dbad.json | Remove unnecessary semicolon in some enum classes | spring-context/src/main/java/org/springframework/context/annotation/ScopedProxyMode.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -53,6 +53,6 @@ public enum ScopedProxyMode {... | true |
Other | spring-projects | spring-framework | ede2a1d4b26ada78250389c0dda908212713dbad.json | Remove unnecessary semicolon in some enum classes | spring-context/src/main/java/org/springframework/jmx/support/RegistrationPolicy.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -42,6 +42,6 @@ public enum RegistrationPolic... | true |
Other | spring-projects | spring-framework | ede2a1d4b26ada78250389c0dda908212713dbad.json | Remove unnecessary semicolon in some enum classes | spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessageType.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -41,6 +41,6 @@ public enum SimpMessageType {... | true |
Other | spring-projects | spring-framework | ede2a1d4b26ada78250389c0dda908212713dbad.json | Remove unnecessary semicolon in some enum classes | spring-orm/src/test/java/org/springframework/orm/jpa/hibernate/beans/BeanSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,5 +18,5 @@
public enum BeanSource {
... | true |
Other | spring-projects | spring-framework | ede2a1d4b26ada78250389c0dda908212713dbad.json | Remove unnecessary semicolon in some enum classes | spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketMessage.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -159,7 +159,7 @@ public enum Type {
/**
... | true |
Other | spring-projects | spring-framework | d1a6e494750a3ec39a79f047601c279de96ff99f.json | Reset SecurityManager in finally-block and polish | spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,6 +38,7 @@
*
* @author Chris Beams
... | false |
Other | spring-projects | spring-framework | f78c21e40b99707827e815efd06de7f92cfc5f70.json | Fix typos in tests
Closes gh-24566 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationsScannerTests.java | @@ -45,7 +45,7 @@
class AnnotationsScannerTests {
@Test
- void directStrategyOnClassWhenNotAnnoatedScansNone() {
+ void directStrategyOnClassWhenNotAnnotatedScansNone() {
Class<?> source = WithNoAnnotations.class;
assertThat(scan(source, SearchStrategy.DIRECT)).isEmpty();
}
@@ -423,7 +423,7 @@ void dirextS... | true |
Other | spring-projects | spring-framework | f78c21e40b99707827e815efd06de7f92cfc5f70.json | Fix typos in tests
Closes gh-24566 | spring-core/src/test/java/org/springframework/core/annotation/MergedAnnotationsTests.java | @@ -338,8 +338,8 @@ void getWithInheritedAnnotationsAttributesWithConventionBasedComposedAnnotation(
@Test
void getWithInheritedAnnotationsFromHalfConventionBasedAndHalfAliasedComposedAnnotation1() {
- // SPR-13554: convention mapping mixed with AlaisFor annotations
- // xmlConfigFiles can be used because it ha... | true |
Other | spring-projects | spring-framework | 97ba00eff263a63d302bb72b83f444275ddc4e9c.json | Use try-with-resource in XmlBeanDefinitionReader
Closes gh-24492 | spring-beans/src/main/java/org/springframework/beans/factory/xml/XmlBeanDefinitionReader.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -327,18 +327,13 @@ public int loadBeanDefini... | false |
Other | spring-projects | spring-framework | 4882eb278d3ed71a75f0183c790228847b5bc08b.json | Convert non-UTF-8 JSON
Jackson's asynchronous parser does not support any encoding except UTF-8
(or ASCII). This commit converts non-UTF-8/ASCII encoded JSON to UTF-8.
Closes gh-24489 | spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Decoder.java | @@ -116,7 +116,8 @@ public Flux<Object> decode(Publisher<DataBuffer> input, ResolvableType elementTy
forceUseOfBigDecimal = true;
}
- Flux<TokenBuffer> tokens = Jackson2Tokenizer.tokenize(Flux.from(input), mapper.getFactory(), mapper,
+ Flux<DataBuffer> processed = processInput(input, elementType, mimeType, ... | true |
Other | spring-projects | spring-framework | 4882eb278d3ed71a75f0183c790228847b5bc08b.json | Convert non-UTF-8 JSON
Jackson's asynchronous parser does not support any encoding except UTF-8
(or ASCII). This commit converts non-UTF-8/ASCII encoded JSON to UTF-8.
Closes gh-24489 | spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonDecoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,10 +16,24 @@
package org.springframew... | true |
Other | spring-projects | spring-framework | 4882eb278d3ed71a75f0183c790228847b5bc08b.json | Convert non-UTF-8 JSON
Jackson's asynchronous parser does not support any encoding except UTF-8
(or ASCII). This commit converts non-UTF-8/ASCII encoded JSON to UTF-8.
Closes gh-24489 | spring-web/src/test/java/org/springframework/http/codec/json/Jackson2JsonDecoderTests.java | @@ -18,6 +18,7 @@
import java.io.IOException;
import java.math.BigDecimal;
+import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.util.Collections;
import java.util.List;
@@ -34,6 +35,7 @@
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;
+import org.sprin... | true |
Other | spring-projects | spring-framework | acae174f8f0a9013b10b10a65e63c0caf2a28337.json | Fix javadoc in DependencyDescriptor
Closes gh-24551 | spring-beans/src/main/java/org/springframework/beans/factory/config/DependencyDescriptor.java | @@ -371,7 +371,7 @@ public void initParameterNameDiscovery(@Nullable ParameterNameDiscoverer paramet
/**
* Determine the name of the wrapped parameter/field.
- * @return the declared name (never {@code null})
+ * @return the declared name (may be {@code null})
*/
@Nullable
public String getDependencyNam... | false |
Other | spring-projects | spring-framework | 9036cc689912b9a3dea8707fc5de5eb78ef4344b.json | Remove unnecessary dependency on spring-orm
Prior to this commit, spring-aspects would consider spring-orm as a
module providing aspects, which is not the case (anymore).
This commit removes that dependency as a result.
Fixes gh-24491 | spring-aspects/spring-aspects.gradle | @@ -11,7 +11,6 @@ sourceSets.test.java.srcDirs = files()
aspectj.version = dependencyManagement.managedVersions['org.aspectj:aspectjweaver']
dependencies {
- aspect(project(":spring-orm"))
compile("org.aspectj:aspectjweaver")
compileOnly("org.aspectj:aspectjrt")
optional(project(":spring-aop")) // for @Async... | false |
Other | spring-projects | spring-framework | de7bed2ab28d0804dcfa1879a75f65c96f7bd4f7.json | Simplify custom_java_home.gradle script
Setting `options.fork = true` causes the classpath in the forked
compiler process to include Class-Path entries from MANIFEST.MF files
in JARs in the classpath, which results in warnings about missing
classpath entries.
This commit removes the `options.fork = true` declaration ... | gradle/custom-java-home.gradle | @@ -34,53 +34,42 @@ import org.gradle.internal.os.OperatingSystem
def customJavaHome = System.getProperty("customJavaHome")
if (customJavaHome) {
- def javacExecutable = customJavaHome + "/bin/javac"
- def javaExecutable = customJavaHome + "/bin/java"
- if (OperatingSystem.current().isWindows()) {
- javacExecutabl... | false |
Other | spring-projects | spring-framework | 9277b470404ce1dce790fa82e684c9d8220940e7.json | Polishing: remove use of cast where avoidable | spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,7 +95,7 @@ public Mono<Void> handle(Serv... | true |
Other | spring-projects | spring-framework | 9277b470404ce1dce790fa82e684c9d8220940e7.json | Polishing: remove use of cast where avoidable | spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java | @@ -117,9 +117,8 @@ public Mono<WebSession> createWebSession() {
Instant now = this.clock.instant();
this.expiredSessionChecker.checkIfNecessary(now);
- return Mono.fromSupplier(() -> new InMemoryWebSession(now))
- .subscribeOn(Schedulers.boundedElastic())
- .cast(WebSession.class);
+ return Mono.<WebSe... | true |
Other | spring-projects | spring-framework | d55210551612e7ded3a068818ebc76a1e151bab3.json | Eliminate windowUntil from StringDecoder
This is a follow-up on the earlier commit
28a95e89f35600199ee1254dee9e8ed53f958bcc eliminating windowUntil
entirely which generates a BubblingException wrapper. This also keeps
the chain a little simpler.
See gh-24355 | spring-core/src/main/java/org/springframework/core/codec/StringDecoder.java | @@ -32,6 +32,7 @@
import org.springframework.core.ResolvableType;
import org.springframework.core.io.buffer.DataBuffer;
+import org.springframework.core.io.buffer.DataBufferLimitException;
import org.springframework.core.io.buffer.DataBufferUtils;
import org.springframework.core.io.buffer.DataBufferWrapper;
impo... | true |
Other | spring-projects | spring-framework | d55210551612e7ded3a068818ebc76a1e151bab3.json | Eliminate windowUntil from StringDecoder
This is a follow-up on the earlier commit
28a95e89f35600199ee1254dee9e8ed53f958bcc eliminating windowUntil
entirely which generates a BubblingException wrapper. This also keeps
the chain a little simpler.
See gh-24355 | spring-core/src/main/java/org/springframework/core/io/buffer/DataBufferUtils.java | @@ -547,13 +547,10 @@ public static Mono<DataBuffer> join(Publisher<? extends DataBuffer> buffers, int
return (Mono<DataBuffer>) buffers;
}
- // TODO: Drop doOnDiscard(LimitedDataBufferList.class, ...) (reactor-core#1924)
-
return Flux.from(buffers)
.collect(() -> new LimitedDataBufferList(maxByteCoun... | true |
Other | spring-projects | spring-framework | d55210551612e7ded3a068818ebc76a1e151bab3.json | Eliminate windowUntil from StringDecoder
This is a follow-up on the earlier commit
28a95e89f35600199ee1254dee9e8ed53f958bcc eliminating windowUntil
entirely which generates a BubblingException wrapper. This also keeps
the chain a little simpler.
See gh-24355 | spring-core/src/test/java/org/springframework/core/codec/StringDecoderTests.java | @@ -78,11 +78,11 @@ public void decode() {
// TODO: temporarily replace testDecodeAll with explicit decode/cancel/empty
// see https://github.com/reactor/reactor-core/issues/2041
- testDecode(input, TYPE, step -> step.expectNext(u, e, o).verifyComplete(), null, null);
- testDecodeCancel(input, TYPE, null, nul... | true |
Other | spring-projects | spring-framework | 0a974511bd4826136f0a6e8be3d326587314a229.json | Expose awaitTerminationMillis presion
Closes gh-24496 | spring-context/src/main/java/org/springframework/scheduling/concurrent/ExecutorConfigurationSupport.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -59,7 +59,7 @@ public abstract class Executo... | false |
Other | spring-projects | spring-framework | df706f4c7cc2c577f44ddf02019dca98fccf5a72.json | Restore use of Flux-based encode method in HTTP
Closes gh-24441 | spring-core/src/main/java/org/springframework/core/codec/Decoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -78,9 +78,9 @@ Mono<T> decodeToMono(Publishe... | true |
Other | spring-projects | spring-framework | df706f4c7cc2c577f44ddf02019dca98fccf5a72.json | Restore use of Flux-based encode method in HTTP
Closes gh-24441 | spring-core/src/main/java/org/springframework/core/codec/Encoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -68,9 +68,9 @@ Flux<DataBuffer> encode(Publi... | true |
Other | spring-projects | spring-framework | df706f4c7cc2c577f44ddf02019dca98fccf5a72.json | Restore use of Flux-based encode method in HTTP
Closes gh-24441 | spring-web/src/main/java/org/springframework/http/codec/EncoderHttpMessageWriter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,7 +29,6 @@
import org.springframework.c... | true |
Other | spring-projects | spring-framework | df706f4c7cc2c577f44ddf02019dca98fccf5a72.json | Restore use of Flux-based encode method in HTTP
Closes gh-24441 | spring-web/src/main/java/org/springframework/http/codec/ServerSentEventHttpMessageWriter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,7 +18,7 @@
import java.nio.charset.St... | true |
Other | spring-projects | spring-framework | df706f4c7cc2c577f44ddf02019dca98fccf5a72.json | Restore use of Flux-based encode method in HTTP
Closes gh-24441 | spring-web/src/test/java/org/springframework/http/codec/EncoderHttpMessageWriterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -157,7 +157,7 @@ void useHttpOutputMessageMe... | true |
Other | spring-projects | spring-framework | 51fa98a1b2a1e63ce3d0bbfe72db187b727437cb.json | Apply compiler conventions to test fixtures | buildSrc/src/main/java/org/springframework/build/compile/CompilerConventionsPlugin.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -33,20 +33,21 @@
* with a dedicated proper... | true |
Other | spring-projects | spring-framework | 51fa98a1b2a1e63ce3d0bbfe72db187b727437cb.json | Apply compiler conventions to test fixtures | spring-aop/src/testFixtures/java/org/springframework/aop/testfixture/advice/MethodCounter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
*
* @author Rod Johnson
... | true |
Other | spring-projects | spring-framework | 51fa98a1b2a1e63ce3d0bbfe72db187b727437cb.json | Apply compiler conventions to test fixtures | spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/beans/TestBean.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -75,7 +75,7 @@ public class TestBean impleme... | true |
Other | spring-projects | spring-framework | 1acf5a742436d2e8460a880c11dd4946d2ca3555.json | Use dedicated catch block for ScriptException
Closes gh-24383 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/init/DatabasePopulatorUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -52,10 +52,10 @@ public static void execute(... | false |
Other | spring-projects | spring-framework | 7575616d268997b40758ccb57815d57afceb9ab5.json | Update copyright date
See gh-24385 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/init/ScriptUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | b4cf88499c36c5120da9596e2785895a3d2a512d.json | Use try-with-resource in ScriptUtils
Closes gh-24385 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/init/ScriptUtils.java | @@ -325,13 +325,9 @@ static String readScript(EncodedResource resource) throws IOException {
private static String readScript(EncodedResource resource, @Nullable String[] commentPrefixes,
@Nullable String separator, @Nullable String blockCommentEndDelimiter) throws IOException {
- LineNumberReader lnr = new Li... | false |
Other | spring-projects | spring-framework | 2b6117c0c2e6ec841116b5a21f4b98bc8a08ad47.json | Fix Checkstyle violation
See gh-24393 | spring-core/src/main/java/org/springframework/util/FileCopyUtils.java | @@ -231,7 +231,8 @@ public static String copyToString(@Nullable Reader in) throws IOException {
private static void close(Closeable closeable) {
try {
closeable.close();
- } catch (IOException ex) {
+ }
+ catch (IOException ex) {
// ignore
}
} | false |
Other | spring-projects | spring-framework | e7d40f930f8e85d67b3d235ca26c7f2f076d6a58.json | Remove synchronized block
As per the Javadoc of ConcurrentHashMap its computeIfAbsent
implementation is atomic and hence already synchronized internally,
so we can remove the surrounding synchronization block.
See gh-24470 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java | @@ -821,14 +821,9 @@ protected long getLastModifiedInternal(HttpServletRequest request, HandlerMethod
* (never {@code null}).
*/
private SessionAttributesHandler getSessionAttributesHandler(HandlerMethod handlerMethod) {
- Class<?> handlerType = handlerMethod.getBeanType();
- SessionAttributesHandler sessionA... | false |
Other | spring-projects | spring-framework | 6f4fb08bf8c1bf6f783e380f2c604f415fc0dfe6.json | Invoke WebMvc.fn error handlers for async errors
This commit makes sure that any error handlers registered on the route
are also applied when an error occurs asynchronously. This commit
applies to asynchronous bodies with both CompletableFuture and Reactive
Streams, as well as completely asynchronous responses.
Close... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultAsyncServerResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -118,7 +118,7 @@ private <R> R delegate(Func... | true |
Other | spring-projects | spring-framework | 6f4fb08bf8c1bf6f783e380f2c604f415fc0dfe6.json | Invoke WebMvc.fn error handlers for async errors
This commit makes sure that any error handlers registered on the route
are also applied when an error occurs asynchronously. This commit
applies to asynchronous bodies with both CompletableFuture and Reactive
Streams, as well as completely asynchronous responses.
Close... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java | @@ -361,21 +361,27 @@ public CompletionStageEntityResponse(int statusCode, HttpHeaders headers,
protected ModelAndView writeToInternal(HttpServletRequest servletRequest, HttpServletResponse servletResponse,
Context context) throws ServletException, IOException {
- DeferredResult<?> deferredResult = createDe... | true |
Other | spring-projects | spring-framework | 6f4fb08bf8c1bf6f783e380f2c604f415fc0dfe6.json | Invoke WebMvc.fn error handlers for async errors
This commit makes sure that any error handlers registered on the route
are also applied when an error occurs asynchronously. This commit
applies to asynchronous bodies with both CompletableFuture and Reactive
Streams, as well as completely asynchronous responses.
Close... | spring-webmvc/src/main/java/org/springframework/web/servlet/function/ErrorHandlingServerResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -35,7 +35,6 @@
/**
* Base class for {@l... | true |
Other | spring-projects | spring-framework | ff9b68c1b6b668e9da90dfff126149a53a052979.json | Update copyright date for StaxEventXMLReader
See gh-26875 | spring-core/src/main/java/org/springframework/util/xml/StaxEventXMLReader.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 59015344a7b6ff55cfddd63157c4438fe2a89166.json | Fix SpEL selection description in ref docs
Closes gh-26852 | src/docs/asciidoc/core/core-expressions.adoc | @@ -1820,8 +1820,8 @@ selection lets us easily get a list of Serbian inventors, as the following examp
"members.?[nationality == 'Serbian']").getValue(societyContext) as List<Inventor>
----
-Selection is possible upon both lists and maps. For a list, the selection
-criteria is evaluated against each individual l... | false |
Other | spring-projects | spring-framework | 35196d3c623199823c837bb08570202184ea0f25.json | Fix aspect autodetection description
Closes gh-26862 | src/docs/asciidoc/core/core-aop.adoc | @@ -316,7 +316,7 @@ other class. They can also contain pointcut, advice, and introduction (inter-typ
declarations.
.Autodetecting aspects through component scanning
-NOTE: You can register aspect classes as regular beans in your Spring XML configuration or
+NOTE: You can register aspect classes as regular beans in ... | false |
Other | spring-projects | spring-framework | 719e7394d6eeace4357fb2aae04600ed4c5b76cb.json | Fix MessageSource doc description | src/docs/asciidoc/core/core-beans.adoc | @@ -10218,8 +10218,8 @@ bean with the same name. If it does, it uses that bean as the `MessageSource`. I
`DelegatingMessageSource` is instantiated in order to be able to accept calls to the
methods defined above.
-Spring provides two `MessageSource` implementations, `ResourceBundleMessageSource` and
-`StaticMessage... | false |
Other | spring-projects | spring-framework | ab6460742094c4b1a562e534060d537d33cf8c24.json | Update CI to use main as default branch name
Closes gh-26863 | ci/parameters.yml | @@ -5,7 +5,7 @@ github-repo: "https://github.com/spring-projects/spring-framework.git"
github-repo-name: "spring-projects/spring-framework"
docker-hub-organization: "springci"
artifactory-server: "https://repo.spring.io"
-branch: "master"
+branch: "main"
milestone: "5.3.x"
build-name: "spring-framework"
pipeline-... | false |
Other | spring-projects | spring-framework | b595dc1dfad9db534ca7b9e8f46bb9926b88ab5a.json | Add advice on Spring MVC path matching for 5.3+
Closes gh-26750 | src/docs/asciidoc/web/webmvc.adoc | @@ -573,6 +573,56 @@ initialization parameters (`init-param` elements) to the Servlet declaration in
+[[mvc-handlermapping-path]]
+=== Path Matching
+
+The Servlet API exposes the full request path as `requestURI` and further sub-divides it
+into `contextPath`, `servletPath`, and `pathInfo` whose values vary depe... | false |
Other | spring-projects | spring-framework | 3bded7659af9f6ecf377ccb0f8a32b31f051b7d1.json | Improve documentation for SpEL constructor support
Closes gh-26846 | src/docs/asciidoc/core/core-expressions.adoc | @@ -1366,7 +1366,7 @@ to use the `T` operator:
=== Constructors
You can invoke constructors by using the `new` operator. You should use the fully qualified class name
-for all but the primitive types (`int`, `float`, and so on) and String. The following
+for all but the types located in the core package `java.lang`... | false |
Other | spring-projects | spring-framework | e7cbe23771a18f959d351c56018ece490320796f.json | Avoid exceptions when evaluating validation hints
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cos... | spring-context/src/main/java/org/springframework/validation/annotation/ValidationAnnotationUtils.java | @@ -0,0 +1,69 @@
+/*
+ * Copyright 2002-2021 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | e7cbe23771a18f959d351c56018ece490320796f.json | Avoid exceptions when evaluating validation hints
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cos... | spring-web/src/main/java/org/springframework/web/method/annotation/ModelAttributeMethodProcessor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,7 +37,6 @@
import org.springframework.b... | true |
Other | spring-projects | spring-framework | e7cbe23771a18f959d351c56018ece490320796f.json | Avoid exceptions when evaluating validation hints
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cos... | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractMessageReaderArgumentResolver.java | @@ -31,7 +31,6 @@
import org.springframework.core.ReactiveAdapter;
import org.springframework.core.ReactiveAdapterRegistry;
import org.springframework.core.ResolvableType;
-import org.springframework.core.annotation.AnnotationUtils;
import org.springframework.core.codec.DecodingException;
import org.springframewor... | true |
Other | spring-projects | spring-framework | e7cbe23771a18f959d351c56018ece490320796f.json | Avoid exceptions when evaluating validation hints
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cos... | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ModelAttributeMethodArgumentResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,14 +30,13 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | e7cbe23771a18f959d351c56018ece490320796f.json | Avoid exceptions when evaluating validation hints
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cos... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodArgumentResolver.java | @@ -36,7 +36,6 @@
import org.springframework.core.MethodParameter;
import org.springframework.core.ResolvableType;
-import org.springframework.core.annotation.AnnotationUtils;
import org.springframework.core.log.LogFormatUtils;
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpInpu... | true |
Other | spring-projects | spring-framework | 80d46ba80e8c813a32180196b87d2f81d50f0d14.json | Update FactoryBean generic description in ref docs
Closes gh-26758 | src/docs/asciidoc/core/core-beans.adoc | @@ -4539,14 +4539,14 @@ Java as opposed to a (potentially) verbose amount of XML, you can create your ow
`FactoryBean`, write the complex initialization inside that class, and then plug your
custom `FactoryBean` into the container.
-The `FactoryBean` interface provides three methods:
+The `FactoryBean<T>` interface... | false |
Other | spring-projects | spring-framework | bf05da1f8c153264af07be59d680be39ffbfe48d.json | Remove unnecessary semicolon in BeanInfo example
Closes gh-26806 | src/docs/asciidoc/core/core-validation.adoc | @@ -567,9 +567,10 @@ associates a `CustomNumberEditor` with the `age` property of the `Something` cla
try {
final PropertyEditor numberPE = new CustomNumberEditor(Integer.class, true);
PropertyDescriptor ageDescriptor = new PropertyDescriptor("age", Something.class) {
+ @Override
public Prope... | false |
Other | spring-projects | spring-framework | 5226a67161c99fc47098aa03da69846242819a9d.json | Update copyright year of changed file
See gh-26807 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 1694274e32c12f6ed66974bd2ef77c305bbb5cda.json | Remove leftover Javadoc from WebClient
See gh-26807 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java | @@ -186,13 +186,6 @@ interface Builder {
*/
Builder baseUrl(String baseUrl);
- /**
- * Configure default URI variable values that will be used when expanding
- * URI templates using a {@link Map}.
- * @param defaultUriVariables the default values to use
- * @see #baseUrl(String)
- * @see #uriBuilder... | false |
Other | spring-projects | spring-framework | f03ccd5cc98e94cf528c9b46cea687af8f59487a.json | Fix Javadoc in AcceptHeaderLocaleResolver
Closes gh-26793 | spring-webmvc/src/main/java/org/springframework/web/servlet/i18n/AcceptHeaderLocaleResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -72,7 +72,7 @@ public List<Locale> getSuppor... | false |
Other | spring-projects | spring-framework | e0b9ed6d72f36dc9c5fbc9ee11f67abc0c898fa6.json | Fix typo in reference
Closes gh-22975 | src/docs/asciidoc/web/webmvc.adoc | @@ -4735,8 +4735,7 @@ The following example shows how to achieve the same configuration in XML:
[subs="verbatim"]
----
<mvc:resources mapping="/resources/**" location="/public/">
- <mvc:resource-chain>
- <mvc:resource-cache/>
+ <mvc:resource-chain resource-cache="true">
<mvc:resolvers>
<mvc:version-resolver>... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.