language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | a30a134c2397a7482bfd8c895f7ec1dc633e2067.json | Make StringDecoder use DataBufferUtils.split
* Added DataBufferUtils.split variant that takes multiple delimiters
as argument (instead of 1).
* Use this new split() variant from within StringDecoder, replacing
its inefficient algorithm with the Knuth-Morris-Pratt algorithm. | spring-core/src/main/java/org/springframework/core/codec/StringDecoder.java | @@ -32,8 +32,6 @@
import org.springframework.core.ResolvableType;
import org.springframework.core.io.buffer.DataBuffer;
import org.springframework.core.io.buffer.DataBufferUtils;
-import org.springframework.core.io.buffer.DefaultDataBufferFactory;
-import org.springframework.core.io.buffer.PooledDataBuffer;
import ... | true |
Other | spring-projects | spring-framework | a30a134c2397a7482bfd8c895f7ec1dc633e2067.json | Make StringDecoder use DataBufferUtils.split
* Added DataBufferUtils.split variant that takes multiple delimiters
as argument (instead of 1).
* Use this new split() variant from within StringDecoder, replacing
its inefficient algorithm with the Knuth-Morris-Pratt algorithm. | spring-core/src/main/java/org/springframework/core/io/buffer/DataBufferUtils.java | @@ -27,6 +27,7 @@
import java.nio.channels.CompletionHandler;
import java.nio.channels.ReadableByteChannel;
import java.nio.channels.WritableByteChannel;
+import java.nio.charset.Charset;
import java.nio.file.StandardOpenOption;
import java.util.ArrayList;
import java.util.Arrays;
@@ -36,6 +37,7 @@
import java.u... | true |
Other | spring-projects | spring-framework | a30a134c2397a7482bfd8c895f7ec1dc633e2067.json | Make StringDecoder use DataBufferUtils.split
* Added DataBufferUtils.split variant that takes multiple delimiters
as argument (instead of 1).
* Use this new split() variant from within StringDecoder, replacing
its inefficient algorithm with the Knuth-Morris-Pratt algorithm. | spring-core/src/test/java/org/springframework/core/io/buffer/DataBufferUtilsTests.java | @@ -820,6 +820,25 @@ public void splitIncludeDelimiter() {
.verifyComplete();
}
+ @Test
+ public void splitMultipleDelimiters() {
+ Mono<DataBuffer> source =
+ deferStringBuffer("foobar␍baz");
+
+ byte[][] delimiters = new byte[][]{
+ "".getBytes(StandardCharsets.UTF_8),
+ "␍".getBytes(Standard... | true |
Other | spring-projects | spring-framework | b1912f6accf12235836f4524368b6c5264e6f42e.json | Fix checkstyle error | spring-core/src/main/java/org/springframework/util/SimpleRouteMatcher.java | @@ -98,4 +98,4 @@ public String value() {
}
}
-}
\ No newline at end of file
+} | false |
Other | spring-projects | spring-framework | afc0ae3752ae29a6fd724cfc79cdc428ea1bfa83.json | Add hasPatternSyntax method to PathPattern | spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java | @@ -175,6 +175,17 @@ public String getPatternString() {
return this.patternString;
}
+
+ /**
+ * Whether the pattern string contains pattern syntax that would require
+ * use of {@link #matches(PathContainer)}, or if it is a regular String that
+ * could be compared directly to others.
+ * @since 5.2
+ */
+... | true |
Other | spring-projects | spring-framework | afc0ae3752ae29a6fd724cfc79cdc428ea1bfa83.json | Add hasPatternSyntax method to PathPattern | spring-web/src/test/java/org/springframework/web/util/pattern/PathPatternTests.java | @@ -57,6 +57,16 @@ public void pathContainer() {
assertEquals("[/][/][/]",elementsToString(toPathContainer("///").elements()));
}
+ @Test
+ public void hasPatternSyntax() {
+ PathPatternParser parser = new PathPatternParser();
+ assertTrue(parser.parse("/foo/*").hasPatternSyntax());
+ assertTrue(parser.parse(... | true |
Other | spring-projects | spring-framework | 9a6ce66bd919a36e851989d9b18c8d8c61b9aeee.json | Add a missing single quote in assertion message | spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilter.java | @@ -98,7 +98,7 @@ private void initLookupPath(ResourceUrlProvider urlProvider) {
String lookupPath = pathHelper.getLookupPathForRequest(this);
this.indexLookupPath = requestUri.lastIndexOf(lookupPath);
Assert.isTrue(this.indexLookupPath != -1, () ->
- "Failed to find lookupPath '" + lookupPath + "' ... | false |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-aspects/src/test/java/org/springframework/scheduling/aspectj/AnnotationAsyncExecutionAspectTests.java | @@ -39,10 +39,10 @@
import org.springframework.util.concurrent.ListenableFuture;
import static org.hamcrest.CoreMatchers.startsWith;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFal... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-beans/src/test/java/org/springframework/beans/factory/config/PropertyPlaceholderConfigurerTests.java | @@ -31,7 +31,7 @@
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.nullValue;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.springframework.beans.factory.support.... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-context/src/test/java/org/springframework/context/expression/EnvironmentAccessorIntegrationTests.java | @@ -25,7 +25,7 @@
import org.springframework.tests.sample.beans.TestBean;
import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.springframework.beans.factory.support.BeanDefinitionBuilder.genericBeanDefin... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-context/src/test/java/org/springframework/format/datetime/DateFormattingTests.java | @@ -36,10 +36,10 @@
import org.springframework.format.support.FormattingConversionService;
import org.springframework.validation.DataBinder;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.assertEquals;
import static org.junit.Asse... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-context/src/test/java/org/springframework/format/datetime/joda/JodaTimeFormattingTests.java | @@ -46,10 +46,10 @@
import org.springframework.format.support.FormattingConversionService;
import org.springframework.validation.DataBinder;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.assertEquals;
import static org.junit.Asse... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java | @@ -45,14 +45,14 @@
import static java.util.stream.Collectors.toList;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.i... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java | @@ -28,6 +28,7 @@
import org.springframework.core.SpringProperties;
import org.springframework.mock.env.MockPropertySource;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.arrayContaining;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.h... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-core/src/test/java/org/springframework/core/io/PathResourceTests.java | @@ -37,10 +37,10 @@
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matche... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-core/src/test/java/org/springframework/util/comparator/InvertibleComparatorTests.java | @@ -21,7 +21,7 @@
import org.junit.Test;
import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
/**
* Tests for {@link InvertibleComparator}. | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-oxm/src/test/java/org/springframework/oxm/jibx/JibxMarshallerTests.java | @@ -25,8 +25,8 @@
import org.springframework.oxm.AbstractMarshallerTests;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.xmlunit.matchers.CompareMatcher.isS... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java | @@ -83,14 +83,14 @@
import org.springframework.beans.FatalBeanException;
import org.springframework.util.StringUtils;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertEquals;
im... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java | @@ -64,13 +64,13 @@
import org.springframework.beans.FatalBeanException;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsString;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNul... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-webmvc/src/test/java/org/springframework/web/context/XmlWebApplicationContextTests.java | @@ -36,8 +36,8 @@
import org.springframework.web.context.support.XmlWebApplicationContext;
import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertThat;
import static org.junit.Assert.assert... | true |
Other | spring-projects | spring-framework | deecab63114699abfe43e55489300ce0515d2188.json | Use assertThat from Hamcrest instead of JUnit 4
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894 | spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java | @@ -42,9 +42,9 @@
import org.springframework.web.accept.ContentNegotiationManagerFactoryBean;
import org.springframework.web.servlet.HandlerMapping;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertSame;
-import static org.juni... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-context/src/test/java/org/springframework/context/annotation/jsr330/SpringAtInjectTckTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2009 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,8 +38,9 @@
* @author Juergen Hoeller
... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/http/server/reactive/ContextPathCompositeHandlerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,8 +30,8 @@
import org.springframework.m... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/http/server/reactive/ListenerWriteProcessorTests.java | @@ -13,6 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.springframework.http.server.reactive;
import java.io.IOException;
@@ -26,9 +27,9 @@
import org.springframework.core.io.buffer.DataBuffer;
-import static junit.framewor... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/http/server/reactive/ServerHttpResponseTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -32,18 +32,17 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/web/bind/support/WebExchangeDataBinderTests.java | @@ -41,9 +41,9 @@
import org.springframework.util.MultiValueMap;
import org.springframework.web.server.ServerWebExchange;
-import static junit.framework.TestCase.assertFalse;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/web/server/session/InMemoryWebSessionStoreTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -13,6 +13,7 @@
* See the License for the s... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-web/src/test/java/org/springframework/web/util/DefaultUriBuilderFactoryTests.java | @@ -13,6 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.springframework.web.util;
import java.net.URI;
@@ -24,7 +25,7 @@
import org.springframework.web.util.DefaultUriBuilderFactory.EncodingMode;
import static java.util.Coll... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-webflux/src/test/java/org/springframework/web/reactive/result/view/HttpMessageWriterViewTests.java | @@ -38,11 +38,10 @@
import org.springframework.ui.ExtendedModelMap;
import org.springframework.ui.ModelMap;
-import static junit.framework.TestCase.assertTrue;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-
/**
* Unit tests for ... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ReactiveTypeHandlerTests.java | @@ -54,9 +54,9 @@
import org.springframework.web.method.support.ModelAndViewContainer;
import org.springframework.web.servlet.HandlerMapping;
-import static junit.framework.TestCase.assertNull;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert... | true |
Other | spring-projects | spring-framework | 724c805211e26f9ad1ae5c74385a8df4fa0d18ee.json | Discontinue use of JUnit 3 APIs
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894 | src/checkstyle/checkstyle-suppressions.xml | @@ -14,6 +14,9 @@
<suppress files="GenericBeanDefinition" checks="EqualsHashCode" />
<suppress files="RootBeanDefinition" checks="EqualsHashCode" />
+ <!-- spring-context -->
+ <suppress files="SpringAtInjectTckTests" checks="IllegalImportCheck" />
+
<!-- spring-core -->
<suppress files="[\\/]src[\\/]main[\\/... | true |
Other | spring-projects | spring-framework | 5685e9dfa37ef30a30ccc8fbe4c5d5424d33e7b9.json | Add Checkstyle rules for deprecated JUnit APIs
This commit adds Checkstyle rules to disallow imports of the following.
- junit.framework.*
- org.junit.Assert.assertThat
- org.junit.Assume.assumeThat
See gh-22894 | src/checkstyle/checkstyle.xml | @@ -97,7 +97,7 @@
<module name="com.puppycrawl.tools.checkstyle.checks.imports.IllegalImportCheck">
<property name="regexp" value="true" />
<property name="illegalClasses"
- value="^reactor\.core\.support\.Assert,^org\.junit\.rules\.ExpectedException,^org\.slf4j\.LoggerFactory" />
+ value="^reactor\.co... | false |
Other | spring-projects | spring-framework | 233b225b4fcb628e0a15c18f94941e2bdd5c6af2.json | Remove JUnit dependency from HeaderResultMatchers
Prior to this commit, HeaderResultMatchers had a direct dependency on
org.junit.Assert which forces JUnit 4 to be present on the classpath.
This commit fixes this by introducing assertNotNull() in
org.springframework.test.util.AssertionErrors and delegating to that
in... | spring-test/src/main/java/org/springframework/test/util/AssertionErrors.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,24 +20,25 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | 233b225b4fcb628e0a15c18f94941e2bdd5c6af2.json | Remove JUnit dependency from HeaderResultMatchers
Prior to this commit, HeaderResultMatchers had a direct dependency on
org.junit.Assert which forces JUnit 4 to be present on the classpath.
This commit fixes this by introducing assertNotNull() in
org.springframework.test.util.AssertionErrors and delegating to that
in... | spring-test/src/main/java/org/springframework/test/web/servlet/result/HeaderResultMatchers.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,8 +26,8 @@
import org.springframework.t... | true |
Other | spring-projects | spring-framework | 0cff7eb32cb4123f72a8dfdccbccf7d4a3cf9a7e.json | Fix Javadoc links | spring-messaging/src/main/java/org/springframework/messaging/rsocket/RSocketRequester.java | @@ -56,16 +56,16 @@ public interface RSocketRequester {
* <p>For requestChannel interactions, i.e. Flux-to-Flux the metadata is
* attached to the first request payload.
* @param route the routing destination
- * @return a spec for further defining and executing the reuqest
+ * @return a spec for further defi... | true |
Other | spring-projects | spring-framework | 0cff7eb32cb4123f72a8dfdccbccf7d4a3cf9a7e.json | Fix Javadoc links | spring-test/src/main/java/org/springframework/test/context/TestConstructor.java | @@ -31,7 +31,7 @@
*
* <p>If {@code @TestConstructor} is not <em>present</em> or <em>meta-present</em>
* on a test class, the default <em>test constructor autowire</em> mode will be used.
- * See {@link #AUTOWIRE_TEST_CONSTRUCTOR_PROPERTY_NAME} for details on how to change
+ * See {@link #TEST_CONSTRUCTOR_AUTOWIRE... | true |
Other | spring-projects | spring-framework | e3137f11dfc90743a13202ff1b4e12871761636f.json | Fix typo in package-info.java
Closes gh-22941 | spring-messaging/src/main/java/org/springframework/messaging/simp/package-info.java | @@ -1,5 +1,5 @@
/**
- * Generic support for SImple Messaging Protocols including protocols such as STOMP.
+ * Generic support for Simple Messaging Protocols including protocols such as STOMP.
*/
@NonNullApi
@NonNullFields | false |
Other | spring-projects | spring-framework | d8f1d561001372f1aadcfab62d5f7187073f9dcb.json | Fix broken test | spring-web/src/test/java/org/springframework/http/codec/EncoderHttpMessageWriterTests.java | @@ -183,7 +183,7 @@ public void emptyBodyWritten() {
public void isStreamingMediaType() throws InvocationTargetException, IllegalAccessException {
HttpMessageWriter<String> writer = getWriter(TEXT_HTML);
MediaType streamingMediaType = new MediaType(TEXT_PLAIN, Collections.singletonMap("streaming", "true"));
- ... | false |
Other | spring-projects | spring-framework | c80028b71edf5b205d8ad95ee6f7d68c40c208a6.json | Fix trivial errors in `integration.adoc` | src/docs/asciidoc/integration.adoc | @@ -6209,7 +6209,7 @@ number of milliseconds to wait before the first execution of the method, as the
}
----
-If simple periodic scheduling is not expressive enough, you ca provide a cron expression.
+If simple periodic scheduling is not expressive enough, you can provide a cron expression.
For example, the follo... | false |
Other | spring-projects | spring-framework | 1b985fb3da3c0802a410264d13ffdebaebea9986.json | Update static import limit in eclipse prefs
Update eclipse preferences so that static imports no longer use
`.*`. | src/eclipse/org.eclipse.jdt.ui.prefs | @@ -62,5 +62,5 @@ org.eclipse.jdt.ui.javadoc=true
org.eclipse.jdt.ui.keywordthis=false
org.eclipse.jdt.ui.ondemandthreshold=9999
org.eclipse.jdt.ui.overrideannotation=true
-org.eclipse.jdt.ui.staticondemandthreshold=1
+org.eclipse.jdt.ui.staticondemandthreshold=9999
org.eclipse.jdt.ui.text.custom_code_templates=<?x... | false |
Other | spring-projects | spring-framework | 66eb86f0552b80b03b338c69ac83cd5f70c799e4.json | Delete unused Matchers class
Delete the `Matches` class since it's no longer being used. | spring-core/src/test/java/org/springframework/tests/Matchers.java | @@ -1,66 +0,0 @@
-/*
- * Copyright 2002-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | false |
Other | spring-projects | spring-framework | 82d32f08758e14a39830a7e6bb0d0a6be1b9648c.json | Remove unused import | spring-web/src/test/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,9 +23,7 @@
import java.util.List;
impo... | false |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-web/src/main/java/org/springframework/http/converter/FormHttpMessageConverter.java | @@ -117,11 +117,8 @@ public FormHttpMessageConverter() {
this.supportedMediaTypes.add(MediaType.APPLICATION_FORM_URLENCODED);
this.supportedMediaTypes.add(MediaType.MULTIPART_FORM_DATA);
- StringHttpMessageConverter stringHttpMessageConverter = new StringHttpMessageConverter();
- stringHttpMessageConverter.se... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-web/src/main/java/org/springframework/http/converter/ObjectToStringHttpMessageConverter.java | @@ -81,8 +81,7 @@ public ObjectToStringHttpMessageConverter(ConversionService conversionService, C
/**
- * Indicates whether the {@code Accept-Charset} should be written to any outgoing request.
- * <p>Default is {@code true}.
+ * Delegates to {@link StringHttpMessageConverter#setWriteAcceptCharset(boolean)}.
... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java | @@ -52,7 +52,7 @@ public class StringHttpMessageConverter extends AbstractHttpMessageConverter<Str
@Nullable
private volatile List<Charset> availableCharsets;
- private boolean writeAcceptCharset = true;
+ private boolean writeAcceptCharset = false;
/**
@@ -76,7 +76,7 @@ public StringHttpMessageConverter(Ch... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-web/src/test/java/org/springframework/http/converter/ObjectToStringHttpMessageConverterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -107,6 +107,7 @@ public void defaultCharsetM... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-web/src/test/java/org/springframework/http/converter/StringHttpMessageConverterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -79,7 +79,7 @@ public void writeDefaultChars... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupport.java | @@ -831,11 +831,8 @@ protected void extendMessageConverters(List<HttpMessageConverter<?>> converters)
* @param messageConverters the list to add the default message converters to
*/
protected final void addDefaultHttpMessageConverters(List<HttpMessageConverter<?>> messageConverters) {
- StringHttpMessageConver... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/support/RouterFunctionMapping.java | @@ -149,12 +149,8 @@ private void initRouterFunction() {
*/
private void initMessageConverters() {
List<HttpMessageConverter<?>> messageConverters = new ArrayList<>(4);
-
messageConverters.add(new ByteArrayHttpMessageConverter());
-
- StringHttpMessageConverter stringHttpMessageConverter = new StringHttpMes... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ExceptionHandlerExceptionResolver.java | @@ -105,12 +105,9 @@ public class ExceptionHandlerExceptionResolver extends AbstractHandlerMethodExce
public ExceptionHandlerExceptionResolver() {
- StringHttpMessageConverter stringHttpMessageConverter = new StringHttpMessageConverter();
- stringHttpMessageConverter.setWriteAcceptCharset(false); // see SPR-73... | true |
Other | spring-projects | spring-framework | 7e6e3d7027eae5a9792c9a6e9b2c9f85e4ec9fc3.json | Switch writeAcceptCharset to false by default
Closes gh-22506 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java | @@ -193,12 +193,9 @@ public class RequestMappingHandlerAdapter extends AbstractHandlerMethodAdapter
public RequestMappingHandlerAdapter() {
- StringHttpMessageConverter stringHttpMessageConverter = new StringHttpMessageConverter();
- stringHttpMessageConverter.setWriteAcceptCharset(false); // see SPR-7316
-
... | true |
Other | spring-projects | spring-framework | 0d2bfc926f425c1c1219e38e5f06a5a9dca04e13.json | Apply consistent ordering in hierarchical contexts
Previously, if `@Order` is specified on a `@Bean` method, and the
candidate bean is defined in a parent context, its order wasn't taken
into account when retrieving the bean from a child context.
This commit makes sure the metadata of a bean is taken into
considerati... | spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java | @@ -2167,20 +2167,25 @@ public FactoryAwareOrderSourceProvider(Map<Object, String> instancesToBeanNames)
@Nullable
public Object getOrderSource(Object obj) {
String beanName = this.instancesToBeanNames.get(obj);
- if (beanName == null || !containsBeanDefinition(beanName)) {
+ if (beanName == null) {
... | true |
Other | spring-projects | spring-framework | 0d2bfc926f425c1c1219e38e5f06a5a9dca04e13.json | Apply consistent ordering in hierarchical contexts
Previously, if `@Order` is specified on a `@Bean` method, and the
candidate bean is defined in a parent context, its order wasn't taken
into account when retrieving the bean from a child context.
This commit makes sure the metadata of a bean is taken into
considerati... | spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java | @@ -1982,6 +1982,21 @@ void autowireBeanByTypePrimaryTakesPrecedenceOverPriority() {
assertThat(bean.getSpouse()).isEqualTo(lbf.getBean("spouse"));
}
+ @Test
+ void beanProviderWithParentBeanFactoryReuseOrder() {
+ DefaultListableBeanFactory parentBf = new DefaultListableBeanFactory();
+ parentBf.setDependency... | true |
Other | spring-projects | spring-framework | 0d2bfc926f425c1c1219e38e5f06a5a9dca04e13.json | Apply consistent ordering in hierarchical contexts
Previously, if `@Order` is specified on a `@Bean` method, and the
candidate bean is defined in a parent context, its order wasn't taken
into account when retrieving the bean from a child context.
This commit makes sure the metadata of a bean is taken into
considerati... | spring-context/src/test/java/org/springframework/context/annotation/Gh29105Tests.java | @@ -0,0 +1,81 @@
+/*
+ * Copyright 2002-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-beans/src/main/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessor.java | @@ -1007,7 +1007,7 @@ private CodeBlock generateMethodStatementForMethod(Method method,
AccessVisibility visibility = AccessVisibility.forMember(method);
if (visibility == AccessVisibility.PRIVATE
|| visibility == AccessVisibility.PROTECTED) {
- hints.reflection().registerMethod(method);
+ hints.ref... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-beans/src/main/java/org/springframework/beans/factory/aot/BeanDefinitionPropertiesCodeGenerator.java | @@ -145,7 +145,7 @@ private void addInitDestroyMethods(Builder code,
private void addInitDestroyHint(Class<?> beanUserClass, String methodName) {
Method method = ReflectionUtils.findMethod(beanUserClass, methodName);
if (method != null) {
- this.hints.reflection().registerMethod(method);
+ this.hints.reflec... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-beans/src/main/java/org/springframework/beans/factory/aot/InstanceSupplierCodeGenerator.java | @@ -147,7 +147,7 @@ private CodeBlock generateCodeForInaccessibleConstructor(String beanName,
Class<?> beanClass, Constructor<?> constructor, boolean dependsOnBean) {
this.generationContext.getRuntimeHints().reflection()
- .registerConstructor(constructor);
+ .registerConstructor(constructor, ExecutableM... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core-test/src/test/java/org/springframework/aot/agent/InstrumentedMethodTests.java | @@ -194,7 +194,7 @@ void classGetConstructorsShouldNotMatchTypeReflectionHint() {
@Test
void classGetConstructorsShouldMatchConstructorReflectionHint() throws Exception {
- hints.reflection().registerConstructor(String.class.getConstructor());
+ hints.reflection().registerConstructor(String.class.getConstru... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/main/java/org/springframework/aot/hint/BindingReflectionHintsRegistrar.java | @@ -145,7 +145,7 @@ private void registerKotlinSerializationHints(ReflectionHints hints, Class<?> cl
Class<?> companionClass = ClassUtils.resolveClassName(companionClassName, null);
Method serializerMethod = ClassUtils.getMethodIfAvailable(companionClass, "serializer");
if (serializerMethod != null) {
- ... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/main/java/org/springframework/aot/hint/ReflectionHints.java | @@ -36,6 +36,8 @@
* Gather the need for reflection at runtime.
*
* @author Stephane Nicoll
+ * @author Phillip Webb
+ * @author Andy Wilkinson
* @since 6.0
*/
public class ReflectionHints {
@@ -79,6 +81,7 @@ public TypeHint getTypeHint(Class<?> type) {
* @param type the type to customize
* @param typeH... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/main/java/org/springframework/aot/hint/TypeHint.java | @@ -35,6 +35,8 @@
* A hint that describes the need for reflection on a type.
*
* @author Stephane Nicoll
+ * @author Phillip Webb
+ * @author Andy Wilkinson
* @since 6.0
*/
public final class TypeHint implements ConditionalHint {
@@ -199,7 +201,9 @@ public Builder withField(String name) {
* parameter typ... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/main/java/org/springframework/aot/hint/annotation/SimpleReflectiveProcessor.java | @@ -21,6 +21,7 @@
import java.lang.reflect.Field;
import java.lang.reflect.Method;
+import org.springframework.aot.hint.ExecutableMode;
import org.springframework.aot.hint.ReflectionHints;
/**
@@ -64,7 +65,7 @@ protected void registerTypeHint(ReflectionHints hints, Class<?> type) {
* @param constructor the c... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/test/java/org/springframework/aot/hint/ReflectionHintsTests.java | @@ -16,6 +16,7 @@
package org.springframework.aot.hint;
+import java.lang.reflect.Constructor;
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.util.function.Consumer;
@@ -48,8 +49,7 @@ void registerType() {
@Test
void registerTypeIfPresentRegistersExistingClass() {
- this.ref... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/test/java/org/springframework/aot/hint/TypeHintTests.java | @@ -70,16 +70,6 @@ void assertFieldHint(Builder builder, Consumer<FieldHint> fieldHint) {
@Test
void createWithConstructor() {
- List<TypeReference> parameterTypes = TypeReference.listOf(byte[].class, int.class);
- assertConstructorHint(TypeHint.of(TypeReference.of(String.class))
- .withConstructor(parameter... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/test/java/org/springframework/aot/hint/predicate/ReflectionHintsPredicatesTests.java | @@ -303,7 +303,7 @@ void reflectionOnAnyConstructorDoesNotMatchTypeReflection() {
@Test
void reflectionOnAnyConstructorMatchesConstructorReflection() {
- runtimeHints.reflection().registerConstructor(publicConstructor);
+ runtimeHints.reflection().registerConstructor(publicConstructor, ExecutableMode.INVOKE... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/test/java/org/springframework/aot/nativex/FileNativeConfigurationWriterTests.java | @@ -109,7 +109,7 @@ void reflectionConfig() throws IOException, JSONException {
.withField("DEFAULT_CHARSET")
.withField("defaultCharset")
.withConstructor(TypeReference.listOf(List.class, boolean.class, MimeType.class), ExecutableMode.INTROSPECT)
- .withMethod("setDefaultCharset", TypeReference.listO... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-core/src/test/java/org/springframework/aot/nativex/ReflectionHintsWriterTests.java | @@ -60,7 +60,7 @@ void one() throws JSONException {
.withField("DEFAULT_CHARSET")
.withField("defaultCharset")
.withConstructor(TypeReference.listOf(List.class, boolean.class, MimeType.class), ExecutableMode.INTROSPECT)
- .withMethod("setDefaultCharset", List.of(TypeReference.of(Charset.class)))
+ ... | true |
Other | spring-projects | spring-framework | 58a2b7969901fbd703bc8ffed905b5d8a3c6d8d3.json | Harmonize hint registration
Previously, a shortcut method for the default ExecutableMode was
provided, but we found out that the shortcut makes it harder to
determine the intent.
This commit harmonizes hints registration for types, methods, and
fields. An ExecutableMode is now mandatory to register a method or
constr... | spring-orm/src/main/java/org/springframework/orm/jpa/support/InjectionCodeGenerator.java | @@ -21,6 +21,7 @@
import java.lang.reflect.Method;
import org.springframework.aot.generate.AccessVisibility;
+import org.springframework.aot.hint.ExecutableMode;
import org.springframework.aot.hint.RuntimeHints;
import org.springframework.javapoet.CodeBlock;
import org.springframework.util.Assert;
@@ -97,7 +98,7... | true |
Other | spring-projects | spring-framework | 1cb5f0072335cc215e3c6ebc9cde325b5b0f24c1.json | Adapt FieldHint to recent GraalVM versions
In recent GraalVM versions, allowWrite and allowUnsafeAccess have been
deprecated and are no longer use. This commit updates FieldHint to
remove the irrelevant properties.
See gh-29130 | spring-core/src/main/java/org/springframework/aot/hint/FieldHint.java | @@ -1,144 +0,0 @@
-/*
- * Copyright 2002-2022 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 1cb5f0072335cc215e3c6ebc9cde325b5b0f24c1.json | Adapt FieldHint to recent GraalVM versions
In recent GraalVM versions, allowWrite and allowUnsafeAccess have been
deprecated and are no longer use. This commit updates FieldHint to
remove the irrelevant properties.
See gh-29130 | spring-core/src/main/java/org/springframework/aot/hint/TypeHint.java | @@ -44,7 +44,7 @@ public final class TypeHint implements ConditionalHint {
@Nullable
private final TypeReference reachableType;
- private final Set<FieldHint> fields;
+ private final Set<String> fields;
private final Set<ExecutableHint> constructors;
@@ -57,7 +57,7 @@ private TypeHint(Builder builder) {
... | true |
Other | spring-projects | spring-framework | d42f950a366d82aae3d72728853bdc1e0dbe71d2.json | Pass headers to STOMP receipt callbacks
See gh-28715 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/DefaultStompSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@
import java.util.concurrent.... | true |
Other | spring-projects | spring-framework | d42f950a366d82aae3d72728853bdc1e0dbe71d2.json | Pass headers to STOMP receipt callbacks
See gh-28715 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,8 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | d42f950a366d82aae3d72728853bdc1e0dbe71d2.json | Pass headers to STOMP receipt callbacks
See gh-28715 | spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/DefaultStompSessionTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -576,22 +576,30 @@ public void receiptReceiv... | true |
Other | spring-projects | spring-framework | d42f950a366d82aae3d72728853bdc1e0dbe71d2.json | Pass headers to STOMP receipt callbacks
See gh-28715 | src/docs/asciidoc/web/websocket.adoc | @@ -1347,7 +1347,7 @@ receipt if the server supports it (simple broker does not). For example, with th
headers.setDestination("/topic/...");
headers.setReceipt("r1");
FrameHandler handler = ...;
- stompSession.subscribe(headers, handler).addReceiptTask(() -> {
+ stompSession.subscribe(headers, handler).addReceipt... | true |
Other | spring-projects | spring-framework | 597c687da8888ef9c0cca774aeeefae615c6ffbe.json | Fix indentation in ref docs for RestTemplate
Closes gh-29014 | src/docs/asciidoc/integration.adoc | @@ -306,7 +306,7 @@ to serialize only a subset of the object properties, as the following example sh
----
[[rest-template-multipart]]
-===== Multipart
+==== Multipart
To send multipart data, you need to provide a `MultiValueMap<String, Object>` whose values
may be an `Object` for part content, a `Resource` for ... | false |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClientBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,6 +28,7 @@
import org.springframework.h... | true |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-web/src/main/java/org/springframework/http/client/reactive/ReactorNetty2ClientHttpResponse.java | @@ -37,7 +37,6 @@
import org.springframework.http.HttpStatusCode;
import org.springframework.http.ResponseCookie;
import org.springframework.lang.Nullable;
-import org.springframework.util.ClassUtils;
import org.springframework.util.CollectionUtils;
import org.springframework.util.LinkedMultiValueMap;
import org.... | true |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-web/src/main/java/org/springframework/http/server/reactive/ReactorNetty2ServerHttpRequest.java | @@ -39,7 +39,6 @@
import org.springframework.http.HttpMethod;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
-import org.springframework.util.ClassUtils;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
@@ -53,10 +52,6 @@
*/
... | true |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-web/src/main/java/org/springframework/http/server/reactive/ReactorNetty2ServerHttpResponse.java | @@ -128,10 +128,8 @@ private Publisher<Buffer> toByteBufs(Publisher<? extends DataBuffer> dataBuffers
@Override
protected void touchDataBuffer(DataBuffer buffer) {
if (logger.isDebugEnabled()) {
- if (ReactorNetty2ServerHttpRequest.reactorNettyRequestChannelOperationsIdPresent) {
- if (ChannelOperationsIdHe... | true |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClientBuilder.java | @@ -34,6 +34,7 @@
import org.springframework.http.client.reactive.JdkClientHttpConnector;
import org.springframework.http.client.reactive.JettyClientHttpConnector;
import org.springframework.http.client.reactive.ReactorClientHttpConnector;
+import org.springframework.http.client.reactive.ReactorNetty2ClientHttpConne... | true |
Other | spring-projects | spring-framework | 2f4c39ba2a01a0d17806aea71d2b391124adc022.json | Add classpath detection for Reactor Netty 2
See gh-28847 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/support/HandshakeWebSocketService.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -74,12 +74,15 @@ public class HandshakeWebSo... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java | @@ -16,11 +16,8 @@
package org.springframework.context.annotation;
-import java.io.FileNotFoundException;
import java.io.IOException;
import java.lang.annotation.Annotation;
-import java.net.SocketException;
-import java.net.UnknownHostException;
import java.util.ArrayDeque;
import java.util.ArrayList;
import... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java | @@ -16,6 +16,8 @@
package org.springframework.context.annotation;
+import java.io.IOException;
+import java.io.UncheckedIOException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
@@ -24,6 +26,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
+import jav... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-context/src/main/java/org/springframework/context/annotation/PropertySourceRegistry.java | @@ -0,0 +1,81 @@
+/*
+ * Copyright 2002-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-context/src/test/java/org/springframework/context/annotation/ConfigurationClassPostProcessorAotContributionTests.java | @@ -24,6 +24,7 @@
import javax.lang.model.element.Modifier;
import org.assertj.core.api.InstanceOfAssertFactories;
+import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.springframework.aot.generate.MethodReference;
@@ -46,6 +47,8 @@
import org.springframework.context.testfixture.c... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-core/src/main/java/org/springframework/core/io/support/PropertySourceDescriptor.java | @@ -0,0 +1,49 @@
+/*
+ * Copyright 2002-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 7642ac82f69ac23196a44b0412859464d299c925.json | Apply @PropertySource in AOT-generated context
This commit records `@PropertySource` declarations defined on
configuration classes so that these are contributed to the environment
of a context that is initialized by generated code.
Closes gh-28976 | spring-core/src/main/java/org/springframework/core/io/support/PropertySourceProcessor.java | @@ -0,0 +1,151 @@
+/*
+ * Copyright 2002-2022 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | cdb38e8482bc7307163e2e87d029565bf07aeaa6.json | Increase StreamUtils.BUFFER_SIZE to 8192
This aligns the buffer size used in StreamUtils with the buffer sizes
used throughout the JDK (see InputStream, BufferedInputStream, Files).
Closes gh-28965 | spring-core/src/main/java/org/springframework/util/StreamUtils.java | @@ -33,7 +33,7 @@
/**
* Simple utility methods for dealing with streams. The copy methods of this class are
* similar to those defined in {@link FileCopyUtils} except that all affected streams are
- * left open when done. All copy methods use a block size of 4096 bytes.
+ * left open when done. All copy methods us... | false |
Other | spring-projects | spring-framework | c8ef2b2202789ca32d31695f0f6b042c3552cbf7.json | Upgrade Java versions in CI image | ci/images/get-jdk-url.sh | @@ -3,10 +3,10 @@ set -e
case "$1" in
java17)
- echo "https://github.com/bell-sw/Liberica/releases/download/17.0.4+8/bellsoft-jdk17.0.4+8-linux-amd64.tar.gz"
+ echo "https://github.com/bell-sw/Liberica/releases/download/17.0.4.1+1/bellsoft-jdk17.0.4.1+1-linux-amd64.tar.gz"
;;
java18)
- echo "https://github.... | false |
Other | spring-projects | spring-framework | 1051fe7bee67f17e284d4f8cb144242bdaf27b31.json | Improve InvocableHandlerMethod error handling
This commit improves the fix for gh-18491 for Java 18 as in this case
the exception message might not be null. | spring-messaging/src/main/java/org/springframework/messaging/handler/invocation/InvocableHandlerMethod.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2021 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -170,7 +170,8 @@ protected Object doInvoke(O... | true |
Other | spring-projects | spring-framework | 1051fe7bee67f17e284d4f8cb144242bdaf27b31.json | Improve InvocableHandlerMethod error handling
This commit improves the fix for gh-18491 for Java 18 as in this case
the exception message might not be null. | spring-web/src/main/java/org/springframework/web/method/support/InvocableHandlerMethod.java | @@ -206,7 +206,8 @@ protected Object doInvoke(Object... args) throws Exception {
}
catch (IllegalArgumentException ex) {
assertTargetBean(method, getBean(), args);
- String text = (ex.getMessage() != null ? ex.getMessage() : "Illegal argument");
+ String text = (ex.getMessage() == null || ex.getCause() in... | true |
Other | spring-projects | spring-framework | 4e9fad7514479cdbd762635f6f70bdaf796e8981.json | Revise TestAotProcessorTests to rely on Path APIs
Instead of String comparisons, assertions are now based on Path
comparisons.
See gh-29103 | spring-test/src/test/java/org/springframework/test/context/aot/TestAotProcessorTests.java | @@ -20,6 +20,8 @@
import java.io.UncheckedIOException;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
import java.util.stream.Stream;
import org.junit.jupiter.api.Test;
@@ -64,11 +66,11 @@ void process(@TempDir(cleanup = CleanupMode.ON_SUCCESS) Path tempD... | false |
Other | spring-projects | spring-framework | ab8e388412858339099e299f7db34dffcbde8460.json | Fix duplicate invoke method of transformedBeanName | spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java | @@ -1648,7 +1648,7 @@ protected Object getObjectForBeanInstance(
return beanInstance;
}
if (!(beanInstance instanceof FactoryBean)) {
- throw new BeanIsNotAFactoryException(transformedBeanName(name), beanInstance.getClass());
+ throw new BeanIsNotAFactoryException(beanName, beanInstance.g... | false |
Other | spring-projects | spring-framework | 9ce5a18d96deb1207889ade128210acfb6adaeaa.json | Ignore null attributes in AbstractView
Consistent with ConcurrentModel and also with treatment of empty values
from async attributes.
Closes gh-23038 | spring-webflux/src/main/java/org/springframework/web/reactive/result/view/AbstractView.java | @@ -215,11 +215,19 @@ public Mono<Void> render(@Nullable Map<String, ?> model, @Nullable MediaType con
protected Mono<Map<String, Object>> getModelAttributes(
@Nullable Map<String, ?> model, ServerWebExchange exchange) {
- int size = (model != null ? model.size() : 0);
- Map<String, Object> attributes = new C... | false |
Other | spring-projects | spring-framework | e352e9ddaae1726a95c4ecc5d09cbea5d5bf90ff.json | Simplify comparison of primitives
Closes gh-23098 | spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectiveConstructorResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -62,7 +62,7 @@ public ConstructorExecutor re... | true |
Other | spring-projects | spring-framework | e352e9ddaae1726a95c4ecc5d09cbea5d5bf90ff.json | Simplify comparison of primitives
Closes gh-23098 | spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -83,20 +83,16 @@ else if (leftNumber instanc... | true |
Other | spring-projects | spring-framework | 33becd8258583f17741c8615bcd2d2dc0378c7fc.json | Allow separator configuration in PathPatternParser
This commit allows to configure a custom path separator when parsing and
matching path patterns with `PathPatternParser`, but also when parsing
incoming paths as `PathContainer` instances.
Closes gh-23092 | spring-web/src/main/java/org/springframework/http/server/DefaultPathContainer.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -89,11 +89,13 @@ public String toString() {
... | true |
Other | spring-projects | spring-framework | 33becd8258583f17741c8615bcd2d2dc0378c7fc.json | Allow separator configuration in PathPatternParser
This commit allows to configure a custom path separator when parsing and
matching path patterns with `PathPatternParser`, but also when parsing
incoming paths as `PathContainer` instances.
Closes gh-23092 | spring-web/src/main/java/org/springframework/http/server/PathContainer.java | @@ -65,14 +65,26 @@ default PathContainer subPath(int startIndex, int endIndex) {
}
+ /**
+ * Parse the path value into a sequence of {@code "/"} {@link Separator Separator}
+ * and {@link PathSegment PathSegment} elements.
+ * @param path the encoded, raw path value to parse
+ * @return the parsed path
+ */... | true |
Other | spring-projects | spring-framework | 33becd8258583f17741c8615bcd2d2dc0378c7fc.json | Allow separator configuration in PathPatternParser
This commit allows to configure a custom path separator when parsing and
matching path patterns with `PathPatternParser`, but also when parsing
incoming paths as `PathContainer` instances.
Closes gh-23092 | spring-web/src/main/java/org/springframework/web/util/pattern/PathPatternParser.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,6 +36,8 @@ public class PathPatternParse... | true |
Other | spring-projects | spring-framework | 33becd8258583f17741c8615bcd2d2dc0378c7fc.json | Allow separator configuration in PathPatternParser
This commit allows to configure a custom path separator when parsing and
matching path patterns with `PathPatternParser`, but also when parsing
incoming paths as `PathContainer` instances.
Closes gh-23092 | spring-web/src/test/java/org/springframework/http/server/DefaultPathContainerTests.java | @@ -27,6 +27,7 @@
import org.springframework.util.MultiValueMap;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
/**
* Unit tests for {@link DefaultPathContainer}.
@@ -111,15 +112,18 @@ public void path() throws Except... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.