language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/BeanNameViewResolver.java | @@ -77,16 +77,12 @@ public int getOrder() {
public View resolveViewName(String viewName, Locale locale) throws BeansException {
ApplicationContext context = obtainApplicationContext();
if (!context.containsBean(viewName)) {
- if (logger.isDebugEnabled()) {
- logger.debug("No matching bean found for view na... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/ContentNegotiatingViewResolver.java | @@ -202,10 +202,6 @@ protected void initServletContext(ServletContext servletContext) {
}
}
- if (this.viewResolvers.isEmpty()) {
- logger.warn("Did not find any ViewResolvers to delegate to; please configure them using the " +
- "'viewResolvers' property on the ContentNegotiatingViewResolver");
- }
... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/InternalResourceView.java | @@ -157,15 +157,15 @@ protected void renderMergedOutputModel(
if (useInclude(request, response)) {
response.setContentType(getContentType());
if (logger.isDebugEnabled()) {
- logger.debug("Including resource [" + getUrl() + "] in InternalResourceView '" + getBeanName() + "'");
+ logger.debug("Including... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/freemarker/FreeMarkerConfigurer.java | @@ -128,7 +128,7 @@ public void afterPropertiesSet() throws IOException, TemplateException {
@Override
protected void postProcessTemplateLoaders(List<TemplateLoader> templateLoaders) {
templateLoaders.add(new ClassTemplateLoader(FreeMarkerConfigurer.class, ""));
- logger.info("ClassTemplateLoader for Spring mac... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/freemarker/FreeMarkerView.java | @@ -228,18 +228,14 @@ public boolean checkResource(Locale locale) throws Exception {
return true;
}
catch (FileNotFoundException ex) {
- if (logger.isDebugEnabled()) {
- logger.debug("No FreeMarker view found for URL: " + url);
- }
+ // Allow for ViewResolver chaining...
return false;
}
cat... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/xslt/XsltView.java | @@ -428,9 +428,6 @@ private Templates loadTemplates() throws ApplicationContextException {
Source stylesheetSource = getStylesheetSource();
try {
Templates templates = getTransformerFactory().newTemplates(stylesheetSource);
- if (logger.isDebugEnabled()) {
- logger.debug("Loading templates '" + templates... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/annotation/CglibProxyControllerTests.java | @@ -22,9 +22,11 @@
import org.junit.Test;
+import org.springframework.aop.Pointcut;
import org.springframework.aop.framework.autoproxy.DefaultAdvisorAutoProxyCreator;
import org.springframework.aop.interceptor.SimpleTraceInterceptor;
import org.springframework.aop.support.DefaultPointcutAdvisor;
+import org.spr... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | spring-webmvc/src/test/java/org/springframework/web/servlet/view/ContentNegotiatingViewResolverTests.java | @@ -134,7 +134,10 @@ public void resolveViewNameWithAcceptHeader() throws Exception {
public void resolveViewNameWithInvalidAcceptHeader() throws Exception {
request.addHeader("Accept", "application");
+ ViewResolver viewResolverMock = mock(ViewResolver.class);
+ viewResolver.setViewResolvers(Collections.singl... | true |
Other | spring-projects | spring-framework | 28a5c3009ea0c31f879c0bb8b9e6cfd33faa81e5.json | Improve DEBUG/TRACE logging for Spring MVC
Issue: SPR-16898 | src/docs/asciidoc/web/webmvc.adoc | @@ -3272,26 +3272,8 @@ such headers.
[[mvc-links-to-controllers-from-views]]
=== Links in views
-You can also build links to annotated controllers from views such as JSP, Thymeleaf,
-FreeMarker. This can be done using the `fromMappingName` method in `MvcUriComponentsBuilder`
-which refers to mappings by name.
-
-Ev... | true |
Other | spring-projects | spring-framework | e6fef9555da4f887eb1cfa37428c97e6d2d430d2.json | Check all HandlerMapping beans for named mappings
Related to (but not required by) SPR-16336. | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilder.java | @@ -444,9 +444,15 @@ public static MethodArgumentBuilder fromMappingName(String mappingName) {
*/
public static MethodArgumentBuilder fromMappingName(@Nullable UriComponentsBuilder builder, String name) {
WebApplicationContext wac = getWebApplicationContext();
- Assert.notNull(wac, "Cannot lookup handler metho... | false |
Other | spring-projects | spring-framework | 802763d26f4aa263df2d474746f3963912f8660b.json | Reintroduce suppression of deprecation warning | spring-test/src/main/java/org/springframework/test/context/junit4/SpringJUnit4ClassRunner.java | @@ -365,6 +365,10 @@ protected Class<? extends Throwable> getExpectedException(FrameworkMethod framew
* @see #getJUnitTimeout(FrameworkMethod)
*/
@Override
+ // Retain the following warning suppression for deprecation (even if Eclipse
+ // states it is unnecessary) since withPotentialTimeout(FrameworkMethod,Obj... | false |
Other | spring-projects | spring-framework | 8027e1f1090e01ed0eeafcea4699c86def37edbf.json | Remove obsolete suppression of deprecation warning | spring-test/src/main/java/org/springframework/test/context/junit4/SpringJUnit4ClassRunner.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -365,7 +365,6 @@ protected Class<? extends T... | false |
Other | spring-projects | spring-framework | 09d9450154be796349dabdc606ade57beae08724.json | Add SameSite support in WebFlux SESSION cookies
This commit adds support for the "SameSite" attribute in response
cookies. As explained in rfc6265bis, this attribute can be used to limit
the scope of a cookie so that it can't be attached to a request unless
it is sent from the "same-site".
This feature is currently s... | spring-web/src/main/java/org/springframework/http/ResponseCookie.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@
* static method.
*
* @a... | true |
Other | spring-projects | spring-framework | 09d9450154be796349dabdc606ade57beae08724.json | Add SameSite support in WebFlux SESSION cookies
This commit adds support for the "SameSite" attribute in response
cookies. As explained in rfc6265bis, this attribute can be used to limit
the scope of a cookie so that it can't be attached to a request unless
it is sent from the "same-site".
This feature is currently s... | spring-web/src/main/java/org/springframework/web/server/session/CookieWebSessionIdResolver.java | @@ -31,6 +31,7 @@
* Cookie-based {@link WebSessionIdResolver}.
*
* @author Rossen Stoyanchev
+ * @author Brian Clozel
* @since 5.0
*/
public class CookieWebSessionIdResolver implements WebSessionIdResolver {
@@ -39,6 +40,8 @@ public class CookieWebSessionIdResolver implements WebSessionIdResolver {
priva... | true |
Other | spring-projects | spring-framework | 09d9450154be796349dabdc606ade57beae08724.json | Add SameSite support in WebFlux SESSION cookies
This commit adds support for the "SameSite" attribute in response
cookies. As explained in rfc6265bis, this attribute can be used to limit
the scope of a cookie so that it can't be attached to a request unless
it is sent from the "same-site".
This feature is currently s... | spring-web/src/test/java/org/springframework/web/server/session/CookieWebSessionIdResolverTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -44,6 +44,6 @@ public void setSessionId() th... | true |
Other | spring-projects | spring-framework | 0078f4677957a3d0c582cf19a145a390cd33ea9a.json | Use reflection for JdkFlowAdapter
To avoid compiler issues on Eclipse. | spring-core/src/main/java/org/springframework/core/ReactiveAdapterRegistry.java | @@ -280,22 +280,25 @@ void registerAdapters(ReactiveAdapterRegistry registry) {
private static class ReactorJdkFlowAdapterRegistrar {
void registerAdapter(ReactiveAdapterRegistry registry) throws Exception {
+
// TODO: remove reflection when build requires JDK 9+
- Class<?> type = ClassUtils.forName("java.... | false |
Other | spring-projects | spring-framework | ef41dcf6878d4063f10cfa946bcf079b2bf71eb4.json | Add HTTP caching to WebFlux section
Issue: SPR-16395 | src/docs/asciidoc/web/webflux.adoc | @@ -2540,6 +2540,124 @@ include::webflux-view.adoc[leveloffset=+1]
+[[webflux-caching]]
+== HTTP Caching
+[.small]#<<web.adoc#mvc-caching,Same in Spring MVC>>#
+
+HTTP caching can significantly improve the performance of a web application. HTTP caching
+revolves around the "Cache-Control" response header and subs... | true |
Other | spring-projects | spring-framework | ef41dcf6878d4063f10cfa946bcf079b2bf71eb4.json | Add HTTP caching to WebFlux section
Issue: SPR-16395 | src/docs/asciidoc/web/webmvc.adoc | @@ -3708,6 +3708,7 @@ http://hdiv.org/[HDIV] is another web security framework that integrates with Sp
[[mvc-caching]]
== HTTP Caching
+[.small]#<<web-reactive.adoc#webflux-caching,Same in Spring WebFlux>>#
HTTP caching can significantly improve the performance of a web application. HTTP caching
revolves around... | true |
Other | spring-projects | spring-framework | d196cdc5cde22308d60fb3eae1bc3e54ccf6bb0a.json | Update docs on @SendTo and @SendToUser
1. Explain that both can be used on the same method
2. Better describe semantics for class vs method level
3. General improvements
Issue: SPR-16336 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/SendTo.java | @@ -32,9 +32,8 @@
* convey the destination to use for the reply. In that case, that destination
* should take precedence.
*
- * <p>The annotation may also be placed at class-level if the provider supports
- * it to indicate that all related methods should use this destination if none
- * is specified otherwise.
+... | true |
Other | spring-projects | spring-framework | d196cdc5cde22308d60fb3eae1bc3e54ccf6bb0a.json | Update docs on @SendTo and @SendToUser
1. Explain that both can be used on the same method
2. Better describe semantics for class vs method level
3. General improvements
Issue: SPR-16336 | spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/SendToUser.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,13 +25,17 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | d196cdc5cde22308d60fb3eae1bc3e54ccf6bb0a.json | Update docs on @SendTo and @SendToUser
1. Explain that both can be used on the same method
2. Better describe semantics for class vs method level
3. General improvements
Issue: SPR-16336 | spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/support/SimpAnnotationMethodMessageHandler.java | @@ -330,15 +330,14 @@ protected List<? extends HandlerMethodReturnValueHandler> initReturnValueHandler
List<HandlerMethodReturnValueHandler> handlers = new ArrayList<>();
// Single-purpose return value types
+
handlers.add(new ListenableFutureReturnValueHandler());
handlers.add(new CompletableFutureReturn... | true |
Other | spring-projects | spring-framework | d196cdc5cde22308d60fb3eae1bc3e54ccf6bb0a.json | Update docs on @SendTo and @SendToUser
1. Explain that both can be used on the same method
2. Better describe semantics for class vs method level
3. General improvements
Issue: SPR-16336 | src/docs/asciidoc/web/websocket.adoc | @@ -1214,22 +1214,17 @@ methods as described next.
[[websocket-stomp-message-mapping]]
==== `@MessageMapping`
-The `@MessageMapping` annotation can be used on methods to route messages based on their
+`@MessageMapping` can be used to annotate methods to route messages based on their
destination. It is supported at... | true |
Other | spring-projects | spring-framework | 7a70f7c5d8ab8542cf1666110c58b71b528030ac.json | Polish @SendTo test | spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandlerTests.java | @@ -81,21 +81,34 @@ public class SendToMethodReturnValueHandlerTests {
@Captor private ArgumentCaptor<Message<?>> messageCaptor;
- private MethodParameter noAnnotationsReturnType;
- private MethodParameter sendToReturnType;
- private MethodParameter sendToDefaultDestReturnType;
- private MethodParameter sendToWit... | false |
Other | spring-projects | spring-framework | 4454ffd2b103b939a890ea7330bf192a32eec622.json | Replace remaining use of block operator | spring-web/src/test/java/org/springframework/http/server/reactive/MultipartIntegrationTests.java | @@ -20,9 +20,9 @@
import org.junit.Test;
import reactor.core.publisher.Mono;
+import reactor.test.StepVerifier;
import org.springframework.core.io.ClassPathResource;
-import org.springframework.core.io.buffer.DataBuffer;
import org.springframework.core.io.buffer.DataBufferUtils;
import org.springframework.http... | true |
Other | spring-projects | spring-framework | 4454ffd2b103b939a890ea7330bf192a32eec622.json | Replace remaining use of block operator | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/SyncInvocableHandlerMethod.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,6 +21,8 @@
import java.util.List;
impo... | true |
Other | spring-projects | spring-framework | 4454ffd2b103b939a890ea7330bf192a32eec622.json | Replace remaining use of block operator | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/MultipartIntegrationTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -52,7 +52,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | spring-beans/src/main/java/org/springframework/beans/factory/annotation/Lookup.java | @@ -46,7 +46,7 @@
* beans, provide stub implementations of your lookup methods to be able to declare
* them as concrete classes. And please remember that lookup methods won't work on
* beans returned from {@code @Bean} methods in configuration classes; you'll have
- * to resort to {@code @Inject Provider<Targe... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | src/docs/asciidoc/core/core-beans.adoc | @@ -5624,7 +5624,7 @@ support for autowiring of `@Bean` methods:
}
----
-The example autowires the `String` method parameter `country` to the value of the `Age`
+The example autowires the `String` method parameter `country` to the value of the `age`
property on another bean named `privateInstance`. A Spring Expre... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | src/docs/asciidoc/core/core-expressions.adoc | @@ -778,11 +778,11 @@ expression based `matches` operator.
// evaluates to true
boolean trueValue = parser.parseExpression(
- "'5.00' matches '\^-?\\d+(\\.\\d{2})?$'").getValue(Boolean.class);
+ "'5.00' matches '^-?\\d+(\\.\\d{2})?$'").getValue(Boolean.class);
//evaluates to false
boolean falseValue = p... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | src/docs/asciidoc/core/core-resources.adoc | @@ -494,9 +494,9 @@ When the path location contains an Ant-style pattern, for example:
[subs="verbatim"]
----
/WEB-INF/*-context.xml
- com/mycompany/**/applicationContext.xml
- file:C:/some/path/*-context.xml
- classpath:com/mycompany/**/applicationContext.xml
+com/mycompany/**/applicationContext.xml
+file:C:/som... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | src/docs/asciidoc/web/webmvc-view.adoc | @@ -209,7 +209,7 @@ generation (including validation error display). It is never necessary to use th
macros to generate form input fields, and they can be mixed and matched with simple HTML
or calls direct to the spring bind macros highlighted previously.
-The following table of available macros show the VTL and FT... | true |
Other | spring-projects | spring-framework | 8f525f07e9dd6a34463d43546c22cb95afd0429b.json | Fix typos, formatting and escaping in reference
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.
http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement | src/docs/asciidoc/web/webmvc.adoc | @@ -479,7 +479,7 @@ initialization parameters ( `init-param` elements) to the Servlet declaration in
All `HandlerMapping` implementations supports handler interceptors that are useful when
you want to apply specific functionality to certain requests, for example, checking for
a principal. Interceptors must implement... | true |
Other | spring-projects | spring-framework | ab96bb54280544fb060ecad6d80bf39617b28dc7.json | Remove redundant check | spring-webflux/src/main/java/org/springframework/web/reactive/result/view/AbstractView.java | @@ -86,9 +86,7 @@ public AbstractView(ReactiveAdapterRegistry registry) {
public void setSupportedMediaTypes(@Nullable List<MediaType> supportedMediaTypes) {
Assert.notEmpty(supportedMediaTypes, "MediaType List must not be empty");
this.mediaTypes.clear();
- if (supportedMediaTypes != null) {
- this.mediaTyp... | true |
Other | spring-projects | spring-framework | ab96bb54280544fb060ecad6d80bf39617b28dc7.json | Remove redundant check | spring-webflux/src/main/java/org/springframework/web/reactive/result/view/ViewResolverSupport.java | @@ -57,9 +57,7 @@ public ViewResolverSupport() {
public void setSupportedMediaTypes(@Nullable List<MediaType> supportedMediaTypes) {
Assert.notEmpty(supportedMediaTypes, "MediaType List must not be empty");
this.mediaTypes.clear();
- if (supportedMediaTypes != null) {
- this.mediaTypes.addAll(supportedMediaT... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-web/src/main/java/org/springframework/web/bind/annotation/CrossOrigin.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -81,6 +81,13 @@
* <p>A matched origin is ... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -145,6 +145,13 @@ else if (this.allowedOrigi... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-web/src/main/java/org/springframework/web/cors/reactive/CorsUtils.java | @@ -54,6 +54,13 @@ public static boolean isPreFlightRequest(ServerHttpRequest request) {
* @code X-Forwarded-Port} headers.
* @return {@code true} if the request is a same-origin one, {@code false} in case
* of a cross-origin request
+ * <p><strong>Note:</strong> this method uses values from "Forwarded"
+ * ... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-web/src/main/java/org/springframework/web/util/WebUtils.java | @@ -677,6 +677,13 @@ public static MultiValueMap<String, String> parseMatrixVariables(String matrixVa
* Check the given request origin against a list of allowed origins.
* A list containing "*" means that all origins are allowed.
* An empty list means only same origin is allowed.
+ * <p><strong>Note:</strong>... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-webflux/src/main/java/org/springframework/web/reactive/config/CorsRegistration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -49,6 +49,13 @@ public CorsRegistration(Stri... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/CorsRegistration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -51,6 +51,13 @@ public CorsRegistration(Stri... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -83,14 +83,13 @@
* {@link #relativeTo(org.... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-webmvc/src/main/java/org/springframework/web/servlet/support/ServletUriComponentsBuilder.java | @@ -36,14 +36,13 @@
* UriComponentsBuilder with additional static factory methods to create links
* based on the current HttpServletRequest.
*
- * <p><strong>Note:</strong> This class extracts and uses values from the headers
- * "Forwarded" (<a href="http://tools.ietf.org/html/rfc7239">RFC 7239</a>),
- * or "X-F... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | spring-webmvc/src/main/resources/org/springframework/web/servlet/config/spring-mvc.xsd | @@ -1331,6 +1331,12 @@
<xsd:documentation><![CDATA[
Comma-separated list of origins to allow, e.g. "http://domain1.com, http://domain2.com".
The special value "*" allows all domains (default).
+
+ Note that CORS checks use values from "Forwarded" (RFC 7239), "X-Forwarded-Host",
+ "X-Forwarded-Port", and "X... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | src/docs/asciidoc/web/webflux.adoc | @@ -854,6 +854,44 @@ views through the <<webflux-config-view-resolvers,WebFlux Config>>. Default view
always selected and used if they match the requested media type.
+[[webflux-filters]]
+== Filters
+[.small]#<<web.adoc#filters,Same in Spring MVC>>#
+
+As part of the <<webflux-web-handler-api>>, the `spring-web` ... | true |
Other | spring-projects | spring-framework | dd96c873e392a8afc31f0762d90edef914aadf04.json | Improve docs on forwarded headers
Issue: SPR-16660 | src/docs/asciidoc/web/webmvc.adoc | @@ -1029,6 +1029,7 @@ Once the Servlet 3.0 configuration is in place, simply add a bean of type
[[filters]]
== Filters
+[.small]#<<web-reactive.adoc#webflux-filters,Same in Spring WebFlux>>#
The `spring-web` module provides some useful filters.
@@ -1048,8 +1049,9 @@ available through the `ServletRequest.getPar... | true |
Other | spring-projects | spring-framework | a546cf0a3bf1ef29407da5083ce24882a46dd1d7.json | Reject invalid forwarded headers
Issue: SPR-16660 | spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java | @@ -729,36 +729,43 @@ public UriComponentsBuilder fragment(@Nullable String fragment) {
* @since 4.2.7
*/
UriComponentsBuilder adaptFromForwardedHeaders(HttpHeaders headers) {
- String forwardedHeader = headers.getFirst("Forwarded");
- if (StringUtils.hasText(forwardedHeader)) {
- String forwardedToUse = St... | false |
Other | spring-projects | spring-framework | 5fb4c8254f2c7ddf29c531d34960b3c2e0dcbb78.json | Fix inclusion of license in jar | build.gradle | @@ -195,7 +195,7 @@ configure(subprojects - project(":spring-build-src")) { subproject ->
manifest.attributes["Created-By"] =
"${System.getProperty("java.version")} (${System.getProperty("java.specification.vendor")})"
- from("${rootProject.projectDir}/src/dist") {
+ from("${rootProject.projectDir}/src/docs... | false |
Other | spring-projects | spring-framework | 7c28152c1337a6f08f170df587441cc8e0a729d5.json | Introduce ClassUtils.isInnerClass() utility method | spring-core/src/main/java/org/springframework/core/MethodParameter.java | @@ -22,7 +22,6 @@
import java.lang.reflect.Executable;
import java.lang.reflect.Member;
import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
import java.lang.reflect.Parameter;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
@@ -38,6 +37,7 @@
import org.springframewor... | true |
Other | spring-projects | spring-framework | 7c28152c1337a6f08f170df587441cc8e0a729d5.json | Introduce ClassUtils.isInnerClass() utility method | spring-core/src/main/java/org/springframework/util/ClassUtils.java | @@ -209,6 +209,14 @@ public static ClassLoader overrideThreadContextClassLoader(@Nullable ClassLoader
}
}
+ /**
+ * Determine if the supplied class is an <em>inner class</em>.
+ * @return {@code true} if the supplied class is an inner class
+ */
+ public static boolean isInnerClass(Class<?> clazz) {
+ return... | true |
Other | spring-projects | spring-framework | e6020ed3777fe5d99e0c9333185f7f5ad143b9c9.json | avoid unnecessary autoboxing | spring-aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java | @@ -82,11 +82,11 @@ public static void registerAspectJAnnotationAutoProxyCreatorIfNecessary(
private static void useClassProxyingIfNecessary(BeanDefinitionRegistry registry, @Nullable Element sourceElement) {
if (sourceElement != null) {
- boolean proxyTargetClass = Boolean.valueOf(sourceElement.getAttribute(P... | true |
Other | spring-projects | spring-framework | e6020ed3777fe5d99e0c9333185f7f5ad143b9c9.json | avoid unnecessary autoboxing | spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java | @@ -352,7 +352,7 @@ private void setNumberHits(BitSet bits, String value, int min, int max) {
if (!split[0].contains("-")) {
range[1] = max - 1;
}
- int delta = Integer.valueOf(split[1]);
+ int delta = Integer.parseInt(split[1]);
if (delta <= 0) {
throw new IllegalArgumentException("Inc... | true |
Other | spring-projects | spring-framework | e6020ed3777fe5d99e0c9333185f7f5ad143b9c9.json | avoid unnecessary autoboxing | spring-webmvc/src/main/java/org/springframework/web/servlet/config/ViewControllerBeanDefinitionParser.java | @@ -76,7 +76,7 @@ public BeanDefinition parse(Element element, ParserContext parserContext) {
HttpStatus statusCode = null;
if (element.hasAttribute("status-code")) {
- int statusValue = Integer.valueOf(element.getAttribute("status-code"));
+ int statusValue = Integer.parseInt(element.getAttribute("status-c... | true |
Other | spring-projects | spring-framework | e6020ed3777fe5d99e0c9333185f7f5ad143b9c9.json | avoid unnecessary autoboxing | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/WebContentInterceptor.java | @@ -121,7 +121,7 @@ public void setCacheMappings(Properties cacheMappings) {
Enumeration<?> propNames = cacheMappings.propertyNames();
while (propNames.hasMoreElements()) {
String path = (String) propNames.nextElement();
- int cacheSeconds = Integer.valueOf(cacheMappings.getProperty(path));
+ int cacheSec... | true |
Other | spring-projects | spring-framework | 4b9e3a9211b9c81148b2c2ebd54091a1fa037483.json | Introduce failing test for SPR-16652
This commit introduces tests for looking up annotations on parameters
in constructors for nested and inner classes via Spring's
MethodParameter abstraction.
The test for an inner class is currently disabled since it fails on
JDK 8. See JIRA issue for details.
Issue: SPR-16652 | spring-core/src/test/java/org/springframework/core/MethodParameterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,16 +16,23 @@
package org.springframew... | false |
Other | spring-projects | spring-framework | d1a0b8d53f92ec410d51bdd89aee979107541bd4.json | Clarify the format supported by @PropertySource
Issue: SPR-16563 | spring-context/src/main/java/org/springframework/context/annotation/PropertySource.java | @@ -173,8 +173,9 @@
/**
* Indicate the resource location(s) of the properties file to be loaded.
- * For example, {@code "classpath:/com/myco/app.properties"} or
- * {@code "file:/path/to/file"}.
+ * <p>Both traditional and XML-based properties file formats are supported
+ * — for example, {@code "clas... | false |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/main/java/org/springframework/web/accept/AbstractMappingContentNegotiationStrategy.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -122,7 +122,7 @@ public List<MediaType> reso... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/main/java/org/springframework/web/accept/ContentNegotiationManager.java | @@ -45,9 +45,6 @@
*/
public class ContentNegotiationManager implements ContentNegotiationStrategy, MediaTypeFileExtensionResolver {
- private static final List<MediaType> MEDIA_TYPE_ALL = Collections.singletonList(MediaType.ALL);
-
-
private final List<ContentNegotiationStrategy> strategies = new ArrayList<>();
... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/main/java/org/springframework/web/accept/ContentNegotiationStrategy.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/main/java/org/springframework/web/accept/HeaderContentNegotiationStrategy.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,12 +17,12 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/test/java/org/springframework/web/accept/ContentNegotiationManagerFactoryBeanTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
import org.junit.Before;
... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/test/java/org/springframework/web/accept/MappingContentNegotiationStrategyTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -53,7 +53,7 @@ public void resolveMediaTypes... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-web/src/test/java/org/springframework/web/accept/PathExtensionContentNegotiationStrategyTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,8 +29,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/ProducesRequestCondition.java | @@ -259,8 +259,7 @@ public int compareTo(ProducesRequestCondition other, HttpServletRequest request)
}
private List<MediaType> getAcceptedMediaTypes(HttpServletRequest request) throws HttpMediaTypeNotAcceptableException {
- List<MediaType> mediaTypes = this.contentNegotiationManager.resolveMediaTypes(new Servlet... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -365,8 +365,7 @@ else if (converter.canWrite... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/ContentNegotiatingViewResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -253,11 +253,7 @@ protected List<MediaType> ... | true |
Other | spring-projects | spring-framework | f3994467c4e1094f5229d05c5679550f956cba8e.json | Refine ContentNegotiationStrategy contract
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624 | spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/ContentNegotiationConfigurerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
import org.springframework.h... | true |
Other | spring-projects | spring-framework | 75f70b269ed89294330758eb61ee8d7f218c9af6.json | Introduce @Nested tests with constructor injection
This commit introduces @Nested tests to verify support for constructor
injection when using the SpringExtension.
One of the tests is disabled on Java 8 due to a bug in javac that was
first fixed in JDK 9.
See https://github.com/junit-team/junit5/issues/1345 for deta... | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/nested/NestedTestsWithConstructorInjectionWithSpringAndJUnitJupiterTestCase.java | @@ -0,0 +1,124 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 75f70b269ed89294330758eb61ee8d7f218c9af6.json | Introduce @Nested tests with constructor injection
This commit introduces @Nested tests to verify support for constructor
injection when using the SpringExtension.
One of the tests is disabled on Java 8 due to a bug in javac that was
first fixed in JDK 9.
See https://github.com/junit-team/junit5/issues/1345 for deta... | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/nested/NestedTestsWithSpringAndJUnitJupiterTestCase.java | @@ -38,6 +38,7 @@
*
* @author Sam Brannen
* @since 5.0
+ * @see NestedTestsWithConstructorInjectionWithSpringAndJUnitJupiterTestCase
* @see org.springframework.test.context.junit4.nested.NestedTestsWithSpringRulesTests
*/
@SpringJUnitConfig(TopLevelConfig.class) | true |
Other | spring-projects | spring-framework | b6e9d1c9ad02ab7501de61881d3edfbc276fa305.json | Publish SpEL content in Reference Manual | src/docs/asciidoc/core/core-expressions.adoc | @@ -7,17 +7,17 @@
[[expressions-intro]]
== Introduction
-The Spring Expression Language (SpEL for short) is a powerful expression language that
+The Spring Expression Language (_SpEL_ for short) is a powerful expression language that
supports querying and manipulating an object graph at runtime. The language synta... | false |
Other | spring-projects | spring-framework | 6b6384a09ed643252e46551d2cf58dbf5b485c88.json | Improve WebFlux Protobuf support
- Update javadoc for decoding default instances
- Refactor and simplify tests
- Add missing tests
- Refactor decoding with flatMapIterable instead of
concatMap and avoid recursive call
Issue: SPR-15776 | spring-web/src/main/java/org/springframework/http/codec/protobuf/ProtobufDecoder.java | @@ -18,6 +18,7 @@
import java.io.IOException;
import java.lang.reflect.Method;
+import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentMap;
@@ -44,13 +45,17 @@
* A {@code Decoder} that reads {@link com.google.protobuf.Message}s
* using <a href="https://... | true |
Other | spring-projects | spring-framework | 6b6384a09ed643252e46551d2cf58dbf5b485c88.json | Improve WebFlux Protobuf support
- Update javadoc for decoding default instances
- Refactor and simplify tests
- Add missing tests
- Refactor decoding with flatMapIterable instead of
concatMap and avoid recursive call
Issue: SPR-15776 | spring-web/src/main/java/org/springframework/http/codec/protobuf/ProtobufEncoder.java | @@ -40,7 +40,7 @@
* An {@code Encoder} that writes {@link com.google.protobuf.Message}s
* using <a href="https://developers.google.com/protocol-buffers/">Google Protocol Buffers</a>.
*
- * Flux are serialized using
+ * <p>Flux are serialized using
* <a href="https://developers.google.com/protocol-buffers/docs/t... | true |
Other | spring-projects | spring-framework | 6b6384a09ed643252e46551d2cf58dbf5b485c88.json | Improve WebFlux Protobuf support
- Update javadoc for decoding default instances
- Refactor and simplify tests
- Add missing tests
- Refactor decoding with flatMapIterable instead of
concatMap and avoid recursive call
Issue: SPR-15776 | spring-web/src/test/java/org/springframework/http/codec/protobuf/ProtobufDecoderTests.java | @@ -16,12 +16,7 @@
package org.springframework.http.codec.protobuf;
-import java.io.ByteArrayOutputStream;
import java.io.IOException;
-import java.io.OutputStream;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
import com.google.protobuf.Message;
import org.junit.Before;
@@ -4... | true |
Other | spring-projects | spring-framework | 6b6384a09ed643252e46551d2cf58dbf5b485c88.json | Improve WebFlux Protobuf support
- Update javadoc for decoding default instances
- Refactor and simplify tests
- Add missing tests
- Refactor decoding with flatMapIterable instead of
concatMap and avoid recursive call
Issue: SPR-15776 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/ProtobufIntegrationTests.java | @@ -129,6 +129,17 @@ public void empty() {
.verifyComplete();
}
+ @Test
+ public void defaultInstance() {
+ Mono<Msg> result = this.webClient.get()
+ .uri("/default-instance")
+ .retrieve()
+ .bodyToMono(Msg.class);
+
+ StepVerifier.create(result)
+ .verifyComplete();
+ }
+
@RestController
@S... | true |
Other | spring-projects | spring-framework | 1c628293a2eda10ab07d77f4d2ae832d134c578c.json | Add doc & tests to Jaxb2XmlEncoder for collections
Issue: SPR-16363 | spring-web/src/main/java/org/springframework/http/codec/xml/Jaxb2XmlEncoder.java | @@ -40,7 +40,11 @@
import org.springframework.util.MimeTypeUtils;
/**
- * Encode from {@code Object} stream to a byte stream containing XML elements.
+ * Encode from single value to a byte stream containing XML elements.
+ *
+ * <p>{@link javax.xml.bind.annotation.XmlElements @XmlElements} and
+ * {@link javax.xml.... | true |
Other | spring-projects | spring-framework | 1c628293a2eda10ab07d77f4d2ae832d134c578c.json | Add doc & tests to Jaxb2XmlEncoder for collections
Issue: SPR-16363 | spring-web/src/test/java/org/springframework/http/codec/xml/Jaxb2XmlEncoderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,10 +17,13 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-aop/src/main/java/org/springframework/aop/support/DynamicMethodMatcherPointcut.java | @@ -24,7 +24,7 @@
* Convenient superclass when we want to force subclasses to
* implement MethodMatcher interface, but subclasses
* will want to be pointcuts. The getClassFilter() method can
- * be overriden to customize ClassFilter behaviour as well.
+ * be overridden to customize ClassFilter behaviour as well.
... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-aop/src/test/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPointTests.java | @@ -218,7 +218,7 @@ public void before(Method method, Object[] args, @Nullable Object target) throws
itb.unreliableFileOperation();
}
catch (IOException ex) {
- // we don't realy care...
+ // we don't really care...
}
}
| true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-beans/src/main/java/org/springframework/beans/factory/parsing/ComponentDefinition.java | @@ -52,7 +52,7 @@
* all {@link BeanReference BeanReferences} that are required to validate the configuration of the
* overall logical entity as well as those required to provide full user visualisation of the configuration.
* It is expected that certain {@link BeanReference BeanReferences} will not be important t... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-beans/src/main/java/org/springframework/beans/support/PagedListHolder.java | @@ -29,7 +29,7 @@
* PagedListHolder is a simple state holder for handling lists of objects,
* separating them into pages. Page numbering starts with 0.
*
- * <p>This is mainly targetted at usage in web UIs. Typically, an instance will be
+ * <p>This is mainly targeted at usage in web UIs. Typically, an instance w... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context-support/src/main/java/org/springframework/scheduling/commonj/ScheduledTimerListener.java | @@ -177,7 +177,7 @@ public long getDelay() {
* Set the period between repeated task executions, in milliseconds.
* <p>Default is -1, leading to one-time execution. In case of zero or a
* positive value, the task will be executed repeatedly, with the given
- * interval inbetween executions.
+ * interval in-be... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context-support/src/test/java/org/springframework/validation/beanvalidation2/SpringValidatorAdapterTests.java | @@ -168,7 +168,7 @@ public void testWithList() {
@Test // SPR-16177
public void testWithSet() {
Parent parent = new Parent();
- parent.setName("Parent whith set");
+ parent.setName("Parent with set");
parent.getChildSet().addAll(createChildren(parent));
BeanPropertyBindingResult errors = new BeanPrope... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context-support/src/test/resources/org/springframework/scheduling/quartz/quartz-hsql.sql | @@ -2,7 +2,7 @@
-- In your Quartz properties file, you'll need to set
-- org.quartz.jobStore.driverDelegateClass = org.quartz.impl.jdbcjobstore.HSQLDBDelegate
--
--- Column lenghts are only suggestions. For names, groups, use at least 40 chars.
+-- Column lengths are only suggestions. For names, groups, use at le... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/main/java/org/springframework/context/ConfigurableApplicationContext.java | @@ -197,7 +197,7 @@ public interface ConfigurableApplicationContext extends ApplicationContext, Life
* will already have been instantiated before. Use a BeanFactoryPostProcessor
* to intercept the BeanFactory setup process before beans get touched.
* <p>Generally, this internal factory will only be accessible ... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/main/java/org/springframework/jmx/export/assembler/AbstractReflectiveMBeanInfoAssembler.java | @@ -339,7 +339,7 @@ protected ModelMBeanAttributeInfo[] getAttributeInfo(Object managedBean, String
/**
* Iterate through all methods on the MBean class and gives subclasses the chance
* to vote on their inclusion. If a particular method corresponds to the accessor
- * or mutator of an attribute that is inclue... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/main/java/org/springframework/scheduling/concurrent/ScheduledExecutorTask.java | @@ -132,7 +132,7 @@ public long getDelay() {
/**
* Set the period between repeated task executions, in milliseconds.
* <p>Default is -1, leading to one-time execution. In case of a positive value,
- * the task will be executed repeatedly, with the given interval inbetween executions.
+ * the task will be exec... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/test/java/org/springframework/aop/framework/ProxyFactoryBeanTests.java | @@ -398,7 +398,7 @@ public void testCanAddAndRemoveAspectInterfacesOnPrototype() {
config.removeAdvice(debugInterceptor);
it.getSpouse();
- // Still invoked wiht old reference
+ // Still invoked with old reference
assertEquals(2, debugInterceptor.getCount());
// not invoked with new object | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/test/java/org/springframework/context/index/CandidateComponentsTestClassLoader.java | @@ -48,7 +48,7 @@ public static ClassLoader disableIndex(ClassLoader classLoader) {
/**
* Create a test {@link ClassLoader} that creates an index with the
- * specifed {@link Resource} instances
+ * specified {@link Resource} instances
* @param classLoader the classloader to use for all other operations
... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/test/java/org/springframework/validation/beanvalidation/SpringValidatorAdapterTests.java | @@ -185,7 +185,7 @@ public void testWithList() {
@Test // SPR-16177
public void testWithSet() {
Parent parent = new Parent();
- parent.setName("Parent whith set");
+ parent.setName("Parent with set");
parent.getChildSet().addAll(createChildren(parent));
BeanPropertyBindingResult errors = new BeanPrope... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-context/src/test/resources/org/springframework/context/access/ContextSingletonBeanFactoryLocatorTests-context.xml | @@ -3,7 +3,7 @@
<!-- We are only using one definition file for the purposes of this test, since we do not have multiple
classloaders available in the environment to allow combining multiple files of the same name, but
- of course the contents within could be spread out across multiple files of the same name within... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-core/src/main/java/org/springframework/core/io/buffer/DataBuffer.java | @@ -192,7 +192,7 @@ public interface DataBuffer {
* Write at most {@code length} bytes of the given source into this buffer, starting
* at the current writing position of this buffer.
* @param source the bytes to be written into this buffer
- * @param offset the index withing {@code source} to start writing f... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-core/src/main/java/org/springframework/core/io/support/LocalizedResourceHelper.java | @@ -33,7 +33,7 @@
*/
public class LocalizedResourceHelper {
- /** The default separator to use inbetween file name parts: an underscore. */
+ /** The default separator to use in-between file name parts: an underscore. */
public static final String DEFAULT_SEPARATOR = "_";
@@ -60,7 +60,7 @@ public LocalizedRe... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-jdbc/src/main/java/org/springframework/jdbc/object/BatchSqlUpdate.java | @@ -47,7 +47,7 @@
public class BatchSqlUpdate extends SqlUpdate {
/**
- * Default number of inserts to accumulate before commiting a batch (5000).
+ * Default number of inserts to accumulate before committing a batch (5000).
*/
public static final int DEFAULT_BATCH_SIZE = 5000;
| true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-jms/src/main/java/org/springframework/jms/listener/AbstractPollingMessageListenerContainer.java | @@ -59,7 +59,7 @@
* {@link org.springframework.transaction.PlatformTransactionManager} into the
* {@link #setTransactionManager "transactionManager"} property. This will usually
* be a {@link org.springframework.transaction.jta.JtaTransactionManager} in a
- * Java EE enviroment, in combination with a JTA-aware JM... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-jms/src/main/java/org/springframework/jms/support/destination/BeanFactoryDestinationResolver.java | @@ -81,7 +81,7 @@ public Destination resolveDestinationName(@Nullable Session session, String dest
}
catch (BeansException ex) {
throw new DestinationResolutionException(
- "Failed to look up Destinaton bean with name '" + destinationName + "'", ex);
+ "Failed to look up Destination bean with name '" ... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-oxm/src/main/java/org/springframework/oxm/support/package-info.java | @@ -1,7 +1,7 @@
/**
* Provides generic support classes for using Spring's O/X Mapping integration
* within various scenario's. Includes the MarshallingSource for compatibility
- * with TrAX, MarshallingView for use withing Spring Web MVC, and the
+ * with TrAX, MarshallingView for use within Spring Web MVC, and th... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java | @@ -199,7 +199,7 @@ static RouterFunctionSpec bindToRouterFunction(RouterFunction<?> routerFunction)
* without an HTTP server using a mock request and response.
* <p>Consider using the TestContext framework and
* {@link org.springframework.test.context.ContextConfiguration @ContextConfiguration}
- * in order ... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-tx/src/main/java/org/springframework/dao/CannotAcquireLockException.java | @@ -17,7 +17,7 @@
package org.springframework.dao;
/**
- * Exception thrown on failure to aquire a lock during an update,
+ * Exception thrown on failure to acquire a lock during an update,
* for example during a "select for update" statement.
*
* @author Rod Johnson | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/http/codec/xml/JaxbContextContainer.java | @@ -26,7 +26,7 @@
import org.springframework.util.Assert;
/**
- * Holder for {@link JAXBContext} isntances.
+ * Holder for {@link JAXBContext} instances.
*
* @author Arjen Poutsma
* @since 5.0 | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/http/converter/protobuf/ExtensionRegistryInitializer.java | @@ -29,7 +29,7 @@
* @since 4.1
* @see <a href="https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/ExtensionRegistry">
* com.google.protobuf.ExtensionRegistry</a>
- * @deprecated as of Spring Framework 5.1, use {@link ExtensionRegistry} based contructors instead
+ * @deprecated ... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/web/cors/CorsProcessor.java | @@ -34,7 +34,7 @@
* @author Sebastien Deleuze
* @author Rossen Stoyanchev
* @since 4.2
- * @see <a href="http://www.w3.org/TR/cors/">CORS W3C recommandation</a>
+ * @see <a href="http://www.w3.org/TR/cors/">CORS W3C recommendation</a>
* @see org.springframework.web.servlet.handler.AbstractHandlerMapping#setCors... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.