language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/web/cors/CorsUtils.java | @@ -23,7 +23,7 @@
/**
* Utility class for CORS request handling based on the
- * <a href="http://www.w3.org/TR/cors/">CORS W3C recommandation</a>.
+ * <a href="http://www.w3.org/TR/cors/">CORS W3C recommendation</a>.
*
* @author Sebastien Deleuze
* @since 4.2 | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/web/cors/reactive/CorsProcessor.java | @@ -28,7 +28,7 @@
* @author Sebastien Deleuze
* @author Rossen Stoyanchev
* @since 5.0
- * @see <a href="http://www.w3.org/TR/cors/">CORS W3C recommandation</a>
+ * @see <a href="http://www.w3.org/TR/cors/">CORS W3C recommendation</a>
*/
public interface CorsProcessor {
| true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/main/java/org/springframework/web/util/pattern/PatternParseException.java | @@ -95,7 +95,7 @@ public Object[] getInserts() {
public enum PatternMessage {
MISSING_CLOSE_CAPTURE("Expected close capture character after variable name '}'"),
- MISSING_OPEN_CAPTURE("Missing preceeding open capture character before variable name'{'"),
+ MISSING_OPEN_CAPTURE("Missing preceding open capture ch... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/test/java/org/springframework/web/bind/ServletRequestDataBinderTests.java | @@ -204,7 +204,7 @@ public void testPrefix() throws Exception {
request.addParameter("test_age", "" + 50);
ServletRequestParameterPropertyValues pvs = new ServletRequestParameterPropertyValues(request);
- assertTrue("Didn't fidn normal when given prefix", !pvs.contains("forname"));
+ assertTrue("Didn't find n... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java | @@ -301,7 +301,7 @@ public void testPrefix() throws Exception {
request.addParameter("test_age", "" + 50);
ServletRequestParameterPropertyValues pvs = new ServletRequestParameterPropertyValues(request);
- assertTrue("Didn't fidn normal when given prefix", !pvs.contains("forname"));
+ assertTrue("Didn't find n... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-web/src/test/java/org/springframework/web/util/HtmlCharacterEntityReferencesTests.java | @@ -156,7 +156,7 @@ private boolean readNextEntity() {
return false;
}
catch (IOException ex) {
- throw new IllegalStateException("Could not parse defintion resource: " + ex.getMessage());
+ throw new IllegalStateException("Could not parse definition resource: " + ex.getMessage());
}
}
| true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-webmvc/src/main/resources/org/springframework/web/servlet/config/spring-mvc.xsd | @@ -1119,7 +1119,7 @@
<xsd:annotation>
<xsd:documentation><![CDATA[
The location of a file containing Tiles definitions (or a Spring resource pattern).
- If no Tiles definitions are registerd, then "/WEB-INF/tiles.xml" is expected to exists.
+ If no Tiles definitions are registered, then "/WEB-INF/ti... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-webmvc/src/test/resources/org/springframework/web/context/ref1.xml | @@ -3,7 +3,7 @@
<!-- We are only using one definition file for the purposes of this test, since we do not have multiple
classloaders available in the environment to allow combining multiple files of the same name, but
- of course the contents within could be spread out across multiple files of the same name within... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/AbstractTransportHandler.java | @@ -25,7 +25,7 @@
import org.springframework.web.socket.sockjs.transport.TransportHandler;
/**
- * Common base class for {@link TransportHandler} inplementations.
+ * Common base class for {@link TransportHandler} implementations.
*
* @author Rossen Stoyanchev
* @since 4.0 | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | src/docs/asciidoc/core/core-databuffer-codec.adoc | @@ -96,7 +96,7 @@ In practice, this means that the reserved memory captured by the buffer will be
the memory pool, ready to be used for future allocations.
In general, _the last component to access a `DataBuffer` is responsible for releasing it_.
-Withing Spring, there are two sorts of components that release buffe... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | src/docs/asciidoc/web/webmvc-view.adoc | @@ -461,7 +461,7 @@ integration for using Spring MVC with Groovy Markup.
[TIP]
====
-The Groovy Markup Tempalte engine requires Groovy 2.3.1+.
+The Groovy Markup Template engine requires Groovy 2.3.1+.
====
@@ -2211,4 +2211,4 @@ This is rendered as:
</ul>
</body>
</html>
-----
\ No newline at end of file... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | src/docs/asciidoc/web/webmvc.adoc | @@ -3911,7 +3911,7 @@ for optimal performance. See section on configuring <<mvc-config-static-resource
=== ETag Filter
The `ShallowEtagHeaderFilter` can be used to add "shallow" eTag values, computed from the
-response content and thus saving bandwith but not CPU time. See <<filters-shallow-etag>>.
+response conten... | true |
Other | spring-projects | spring-framework | be211ceeadcc5b524e1835348f38ea0c22053bd1.json | Fix typos detected by github.com/client9/misspell | src/test/java/org/springframework/aop/framework/autoproxy/AdvisorAutoProxyCreatorIntegrationTests.java | @@ -43,7 +43,7 @@
/**
* Integration tests for auto proxy creation by advisor recognition working in
- * conjunction with transaction managment resources.
+ * conjunction with transaction management resources.
*
* @see org.springframework.aop.framework.autoproxy.AdvisorAutoProxyCreatorTests
* | true |
Other | spring-projects | spring-framework | 896eb5687ab2a0b8bddce46ab9ec766c9987f26e.json | Check scheme in (WebUtils|CorsUtils)#isSameOrigin
Issue: SPR-16362 | spring-web/src/main/java/org/springframework/web/cors/reactive/CorsUtils.java | @@ -69,13 +69,16 @@ public static boolean isSameOrigin(ServerHttpRequest request) {
}
URI uri = request.getURI();
+ String actualScheme = uri.getScheme();
String actualHost = uri.getHost();
int actualPort = getPort(uri.getScheme(), uri.getPort());
+ Assert.notNull(actualScheme, "Actual request scheme mu... | true |
Other | spring-projects | spring-framework | 896eb5687ab2a0b8bddce46ab9ec766c9987f26e.json | Check scheme in (WebUtils|CorsUtils)#isSameOrigin
Issue: SPR-16362 | spring-web/src/main/java/org/springframework/web/util/WebUtils.java | @@ -813,7 +813,8 @@ public static boolean isSameOrigin(HttpRequest request) {
}
UriComponents originUrl = UriComponentsBuilder.fromOriginHeader(origin).build();
- return (ObjectUtils.nullSafeEquals(host, originUrl.getHost()) &&
+ return (ObjectUtils.nullSafeEquals(scheme, originUrl.getScheme()) &&
+ Object... | true |
Other | spring-projects | spring-framework | 896eb5687ab2a0b8bddce46ab9ec766c9987f26e.json | Check scheme in (WebUtils|CorsUtils)#isSameOrigin
Issue: SPR-16362 | spring-web/src/test/java/org/springframework/web/cors/reactive/CorsUtilsTests.java | @@ -92,6 +92,15 @@ public void isSameOriginWithForwardedHeader() {
testWithForwardedHeader(server, 123, "proto=https; host=mydomain2.com:456", "https://mydomain2.com:456");
}
+ @Test // SPR-16362
+ public void isSameOriginWithDifferentSchemes() {
+ MockServerHttpRequest request = MockServerHttpRequest
+ .ge... | true |
Other | spring-projects | spring-framework | 896eb5687ab2a0b8bddce46ab9ec766c9987f26e.json | Check scheme in (WebUtils|CorsUtils)#isSameOrigin
Issue: SPR-16362 | spring-web/src/test/java/org/springframework/web/util/WebUtilsTests.java | @@ -105,39 +105,40 @@ public void isValidOrigin() {
@Test
public void isSameOrigin() {
- assertTrue(checkSameOrigin("mydomain1.com", -1, "http://mydomain1.com"));
- assertTrue(checkSameOrigin("mydomain1.com", -1, "http://mydomain1.com:80"));
- assertTrue(checkSameOrigin("mydomain1.com", 443, "https://mydomain1... | true |
Other | spring-projects | spring-framework | 29ce6685cad0f6caf829c49024b1885ab31d62e0.json | Add handleFailure property to FrameworkServlet
Issue: SPR-17100 | spring-webmvc/src/main/java/org/springframework/web/servlet/FrameworkServlet.java | @@ -209,6 +209,9 @@ public abstract class FrameworkServlet extends HttpServletBean implements Applic
/** Should we dispatch an HTTP TRACE request to {@link #doService}?. */
private boolean dispatchTraceRequest = false;
+ /** Should we set the status to 500 for unhandled failures? */
+ private boolean shouldHandle... | true |
Other | spring-projects | spring-framework | 29ce6685cad0f6caf829c49024b1885ab31d62e0.json | Add handleFailure property to FrameworkServlet
Issue: SPR-17100 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java | @@ -281,8 +281,7 @@ else if (mediaType.equals(MediaType.ALL) || mediaType.equals(MEDIA_TYPE_APPLICAT
inputMessage, outputMessage);
if (body != null) {
if (logger.isDebugEnabled()) {
- Object formatted = (body instanceof CharSequence ? "\"" + body + "\"" : body);
- logger.debug("Writing ... | true |
Other | spring-projects | spring-framework | 29ce6685cad0f6caf829c49024b1885ab31d62e0.json | Add handleFailure property to FrameworkServlet
Issue: SPR-17100 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java | @@ -871,8 +871,8 @@ protected ModelAndView invokeHandlerMethod(HttpServletRequest request,
mavContainer = (ModelAndViewContainer) asyncManager.getConcurrentResultContext()[0];
asyncManager.clearConcurrentResult();
if (logger.isDebugEnabled()) {
- logger.debug("Resume with async result [" +
- (r... | true |
Other | spring-projects | spring-framework | 29ce6685cad0f6caf829c49024b1885ab31d62e0.json | Add handleFailure property to FrameworkServlet
Issue: SPR-17100 | spring-webmvc/src/test/java/org/springframework/web/servlet/DispatcherServletTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -614,6 +614,32 @@ public void noHandlerFound... | true |
Other | spring-projects | spring-framework | 10d5de7d630587bfa96f4f6998ab141693d55386.json | Handle special headers in Tomcat and Jetty
This commit adds special processing of some HTTP response headers in
Jetty and Tomcat; they both consider some headers like "Content-Length"
as specific and require explicit calls on the `HttpServletResponse`
itself on top of setting the HTTP response header.
Issue: SPR-172... | spring-web/src/main/java/org/springframework/http/server/reactive/JettyHttpHandlerAdapter.java | @@ -19,6 +19,7 @@
import java.io.IOException;
import java.net.URISyntaxException;
import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
import javax.servlet.AsyncContext;
import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
@@ -32,6 +33,7 @@
import org.springframework.core.... | true |
Other | spring-projects | spring-framework | 10d5de7d630587bfa96f4f6998ab141693d55386.json | Handle special headers in Tomcat and Jetty
This commit adds special processing of some HTTP response headers in
Jetty and Tomcat; they both consider some headers like "Content-Length"
as specific and require explicit calls on the `HttpServletResponse`
itself on top of setting the HTTP response header.
Issue: SPR-172... | spring-web/src/main/java/org/springframework/http/server/reactive/TomcatHttpHandlerAdapter.java | @@ -20,6 +20,7 @@
import java.lang.reflect.Field;
import java.net.URISyntaxException;
import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
import javax.servlet.AsyncContext;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
@@ -37,6 +38,7 @@
import org.springframework.core.io.bu... | true |
Other | spring-projects | spring-framework | 82a211fa966767bc1ac78fbaa79f210a5a99f5b1.json | Fix checkstyle violation | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java | @@ -778,7 +778,7 @@ public void process() {
this.deferredImportSelectors = new ArrayList<>();
}
}
-
+
}
| false |
Other | spring-projects | spring-framework | bb5c8ed4e8061eaf8ba990f1d54c3a6f761cf868.json | Correct Javadoc in ServletUriComponentsBuilder
Replace all method level comments related to forwaded headers, some
current and some outdated, with a single class-level comment.
Issue: SPR-17317 | spring-webmvc/src/main/java/org/springframework/web/servlet/support/ServletUriComponentsBuilder.java | @@ -32,13 +32,12 @@
* UriComponentsBuilder with additional static factory methods to create links
* based on the current HttpServletRequest.
*
- * <p><strong>Note:</strong> This class uses values from "Forwarded"
- * (<a href="http://tools.ietf.org/html/rfc7239">RFC 7239</a>),
- * "X-Forwarded-Host", "X-Forwarded... | false |
Other | spring-projects | spring-framework | 963044525350a84d20a5ea0b5e21cdff4cd609c6.json | Add sections on form and multipart codecs
Explain the need for consistent use of ServerWebExchange for access to
the parsed (and cached) form data or multipart data.
Issue: SPR-17291 | src/docs/asciidoc/web/webflux.adoc | @@ -674,9 +674,9 @@ readers and writers for form data, multipart requests, and server-sent events.
==== Jackson JSON
JSON and binary JSON (https://github.com/FasterXML/smile-format-specification[Smile]) data
-formats are both supported.
+formats are both supported with the Jackson library.
-The `Jackson2Decoder` ... | false |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webflux-cors.adoc | @@ -73,7 +73,7 @@ To learn more from the source or to make advanced customizations, see:
[[webflux-cors-controller]]
-== Using `@CrossOrigin`
+== `@CrossOrigin`
[.small]#<<web.adoc#mvc-cors-controller,Same as in Spring MVC>>#
The {api-spring-framework}/web/bind/annotation/CrossOrigin.html[`@CrossOrigin`] | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webflux-functional.adoc | @@ -85,7 +85,7 @@ and `Mono`. For more on that, see
[[webflux-fn-request]]
-=== Using `ServerRequest`
+=== `ServerRequest`
`ServerRequest` provides access to the HTTP method, URI, headers, and query parameters,
while access to the body is provided through the `body` methods.
@@ -152,7 +152,7 @@ Flux<Part> part... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webflux-webclient.adoc | @@ -242,7 +242,7 @@ shows:
[[webflux-client-retrieve]]
-== Using `retrieve()`
+== `retrieve()`
The `retrieve()` method is the easiest way to get a response body and decode it.
The following example shows how to do so:
@@ -295,7 +295,7 @@ as the following example shows:
[[webflux-client-exchange]]
-== Usin... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webflux-websocket.adoc | @@ -75,7 +75,7 @@ Then you can map it to a URL and add a `WebSocketHandlerAdapter`, as the followi
[[webflux-websockethandler]]
-=== Using `WebSocketHandler`
+=== `WebSocketHandler`
The `handle` method of `WebSocketHandler` takes `WebSocketSession` and returns `Mono<Void>`
to indicate when application handling... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webflux.adoc | @@ -309,7 +309,7 @@ The reactive core also includes <<webflux-codecs>> for client and server side us
[[webflux-httphandler]]
-=== Using `HttpHandler`
+=== `HttpHandler`
{api-spring-framework}/http/server/reactive/HttpHandler.html[HttpHandler]
is a simple contract with a single method to handle a request and re... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webmvc-client.adoc | @@ -6,7 +6,7 @@ This section describes options for client-side access to REST endpoints.
[[webmvc-resttemplate]]
-== Using `RestTemplate`
+== `RestTemplate`
`RestTemplate` is a synchronous client to perform HTTP requests. It is the original
Spring REST client and exposes a simple, template-method API over unde... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webmvc-cors.adoc | @@ -73,7 +73,7 @@ To learn more from the source or make advanced customizations, check the code be
[[mvc-cors-controller]]
-== Using `@CrossOrigin`
+== `@CrossOrigin`
[.small]#<<web-reactive.adoc#webflux-cors-controller,Same as in Spring WebFlux>>#
The {api-spring-framework}/web/bind/annotation/CrossOrigin.htm... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webmvc-view.adoc | @@ -1777,7 +1777,7 @@ them otherwise in the file names for Tiles definitions.
[[mvc-view-tiles-url]]
-==== Using `UrlBasedViewResolver`
+==== `UrlBasedViewResolver`
The `UrlBasedViewResolver` instantiates the given `viewClass` for each view it has to
resolve. The following bean defines a `UrlBasedViewResolver`... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/webmvc.adoc | @@ -284,7 +284,7 @@ provides many extra convenient options.
[[mvc-container-config]]
-=== Servlet Configuration
+=== Servlet Config
In a Servlet 3.0+ environment, you have the option of configuring the Servlet container
programmatically as an alternative or in combination with a `web.xml` file. The following
@... | true |
Other | spring-projects | spring-framework | 4d245033174be5a4067d86ef25f2768736227bad.json | Restore sub-section headings in web content
Headings are optimized for how they appear in the left-hand side
navitation menu, with context provided by parent headings, and not
necessarily for how they read on their own.
At 2nd and 3rd level of nesting, which is where most headings are,
the wrapping becomes too distra... | src/docs/asciidoc/web/websocket.adoc | @@ -23,7 +23,7 @@ server-side applications that handle WebSocket messages.
[[websocket-server-handler]]
-=== Using `WebSocketHandler`
+=== `WebSocketHandler`
[.small]#<<web-reactive.adoc#webflux-websocket-server-handler,Same as in Spring WebFlux>>#
Creating a WebSocket server is as simple as implementing `WebS... | true |
Other | spring-projects | spring-framework | 80e7819d6f253c3c51013f717f1dbdbe3ea23cbc.json | Fix construction of NullSafeComparator in nullsLow
Previously, both nullsLow(Comparator<T>) and
nullsHigh(Comparator<T>) returned a
NullSafeComparator which treated nulls as being
high. This commit corrects this typo. | spring-core/src/main/java/org/springframework/util/comparator/Comparators.java | @@ -52,7 +52,7 @@ public static <T> Comparator<T> nullsLow() {
* @see NullSafeComparator#NullSafeComparator(boolean)
*/
public static <T> Comparator<T> nullsLow(Comparator<T> comparator) {
- return new NullSafeComparator<>(comparator, false);
+ return new NullSafeComparator<>(comparator, true);
}
/** | false |
Other | spring-projects | spring-framework | 9975646ffb2eea135a9094fb65a65f617325e242.json | Add more RequestPredicate tests for attributes
This commit adds test for delegating request predicates that verify
whether the request attributes are properly restored when a delegate
fails. | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/RequestPredicateAttributesTests.java | @@ -0,0 +1,206 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | false |
Other | spring-projects | spring-framework | 18c9e3e81292156976fc343c02c34f48ba58eb37.json | Fix trivial errors in core-beans documentation
Closes gh-1967 | src/docs/asciidoc/core/core-beans.adoc | @@ -5894,7 +5894,7 @@ in effect, disables automatic detection of classes annotated with `@Component`,
Spring components can also contribute bean definition metadata to the container. You can do
this with the same `@Bean` annotation used to define bean metadata within `@Configuration`
-annotated classes. The followi... | false |
Other | spring-projects | spring-framework | 7ca6b9f7d2196153307b93ea7df6fc52abb06902.json | Fix copyright header | spring-web/src/test/java/org/springframework/mock/web/test/MockBodyContent.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | 551505bd93003e983fb97bbf30221a45de138178.json | Restore handling of 0 bytes read
Issue: SPR-16728 | spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerReadPublisher.java | @@ -320,7 +320,8 @@ <T> void request(AbstractListenerReadPublisher<T> publisher, long n) {
<T> void onDataAvailable(AbstractListenerReadPublisher<T> publisher) {
if (publisher.changeState(this, READING)) {
try {
- boolean demandAvailable = publisher.readAndPublish();
+ boolean demandAvailable =... | true |
Other | spring-projects | spring-framework | 551505bd93003e983fb97bbf30221a45de138178.json | Restore handling of 0 bytes read
Issue: SPR-16728 | spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java | @@ -198,6 +198,8 @@ public Flux<DataBuffer> getBody() {
/**
* Read from the request body InputStream and return a DataBuffer.
* Invoked only when {@link ServletInputStream#isReady()} returns "true".
+ * @return a DataBuffer with data read, or {@link #EOF_BUFFER} if the input
+ * stream returned -1, or null if... | true |
Other | spring-projects | spring-framework | 961c6419733926d6dfa2ca75af1edf7a886b2f66.json | Fix typo in javadoc
Closes gh-1791 | spring-webflux/src/main/java/org/springframework/web/reactive/DispatcherHandler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -51,7 +51,7 @@
* <li>{@link HandlerResultH... | false |
Other | spring-projects | spring-framework | 97ee94f4ca7e1d0c6f7e218e0ba8448940b7ba24.json | Expose env and context in Kotlin beans DSL
This commit introduces a deferred initialization of the declared beans
in order to make it possible to access to the environment (and even
to the context for advanced use-cases) in the beans { } Kotlin DSL.
Issues: SPR-16269, SPR-16412 | spring-context/src/main/kotlin/org/springframework/context/support/BeanDefinitionDsl.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -63,7 +63,7 @@ import java.util.function.Sup... | true |
Other | spring-projects | spring-framework | 97ee94f4ca7e1d0c6f7e218e0ba8448940b7ba24.json | Expose env and context in Kotlin beans DSL
This commit introduces a deferred initialization of the declared beans
in order to make it possible to access to the environment (and even
to the context for advanced use-cases) in the beans { } Kotlin DSL.
Issues: SPR-16269, SPR-16412 | spring-context/src/test/kotlin/org/springframework/context/support/BeanDefinitionDslTests.kt | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,16 +20,18 @@ import org.junit.Assert.*
... | true |
Other | spring-projects | spring-framework | 4f3a7dd9b4b4b95ccebf276185163cbdd815cb8d.json | Expand scope of SpringFailOnTimeoutTests
Issue: SPR-16716 | spring-test/src/main/java/org/springframework/test/context/junit4/statements/SpringFailOnTimeout.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | true |
Other | spring-projects | spring-framework | 4f3a7dd9b4b4b95ccebf276185163cbdd815cb8d.json | Expand scope of SpringFailOnTimeoutTests
Issue: SPR-16716 | spring-test/src/test/java/org/springframework/test/context/junit4/spr16716/SpringFailOnTimeoutExceptionTest.java | @@ -1,45 +0,0 @@
-package org.springframework.test.context.junit4.spr16716;
-
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.model.Statement;
-import org.mockito.Mock;
-import org.mockito.junit.MockitoJUnitRunner;
-import org.mockito.stubbing.Answer;
-import org.springframework.test... | true |
Other | spring-projects | spring-framework | 4f3a7dd9b4b4b95ccebf276185163cbdd815cb8d.json | Expand scope of SpringFailOnTimeoutTests
Issue: SPR-16716 | spring-test/src/test/java/org/springframework/test/context/junit4/spr16716/SpringFailOnTimeoutTests.java | @@ -0,0 +1,90 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 224589ea74a2bfd4230e67331c109944df7260b4.json | Remove write pausing in Undertow response
Using the simple example shown in the ticket but switching from
Mono<String> to Flux<String> (and 5,000,000 onNext calls) shows that
constant pausing causes significant overhead and is not worth the
trouble vs ignoring the onWritePossible in REQUESTED state.
Issue: SPR-16702 | spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java | @@ -162,7 +162,11 @@ protected void dataReceived(T data) {
* Invoked after the current data has been written and before requesting
* the next item from the upstream, write Publisher.
* <p>The default implementation is a no-op.
+ * @deprecated originally introduced for Undertow to stop write notifications
+ *... | true |
Other | spring-projects | spring-framework | 224589ea74a2bfd4230e67331c109944df7260b4.json | Remove write pausing in Undertow response
Using the simple example shown in the ticket but switching from
Mono<String> to Flux<String> (and 5,000,000 onNext calls) shows that
constant pausing causes significant overhead and is not worth the
trouble vs ignoring the onWritePossible in REQUESTED state.
Issue: SPR-16702 | spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpResponse.java | @@ -217,11 +217,6 @@ protected boolean isDataEmpty(DataBuffer dataBuffer) {
return (dataBuffer.readableByteCount() == 0);
}
- @Override
- protected void writingPaused() {
- this.channel.suspendWrites();
- }
-
@Override
protected void writingComplete() {
this.channel.getWriteSetter().set(null); | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-aspects/spring-aspects.gradle | @@ -90,7 +90,7 @@ dependencies {
optional(project(":spring-orm")) // for JPA exception translation support
optional(project(":spring-tx")) // for JPA, @Transactional support
optional("javax.cache:cache-api:1.1.0") // for JCache aspect
- optional("javax.transaction:javax.transaction-api:1.2") // for @javax.tran... | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-context-indexer/spring-context-indexer.gradle | @@ -4,5 +4,5 @@ dependencies {
testCompile(project(":spring-context"))
testCompile("javax.inject:javax.inject:1")
testCompile("javax.annotation:javax.annotation-api:1.3.2")
- testCompile("org.eclipse.persistence:javax.persistence:2.1.1")
+ testCompile("org.eclipse.persistence:javax.persistence:2.2.0")
} | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-jdbc/spring-jdbc.gradle | @@ -5,7 +5,7 @@ dependencies {
compile(project(":spring-core"))
compile(project(":spring-tx"))
optional(project(":spring-context")) // for JndiDataSourceLookup
- optional("javax.transaction:javax.transaction-api:1.2")
+ optional("javax.transaction:javax.transaction-api:1.3")
optional("org.hsqldb:hsqldb:${hsqld... | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-jms/spring-jms.gradle | @@ -10,6 +10,6 @@ dependencies {
optional(project(":spring-context"))
optional(project(":spring-oxm"))
optional("javax.resource:javax.resource-api:1.7")
- optional("javax.transaction:javax.transaction-api:1.2")
+ optional("javax.transaction:javax.transaction-api:1.3")
optional("com.fasterxml.jackson.core:jackso... | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-orm/spring-orm.gradle | @@ -9,7 +9,7 @@ dependencies {
optional(project(":spring-context"))
optional(project(":spring-web"))
optional("org.eclipse.persistence:org.eclipse.persistence.jpa:2.7.1")
- optional("org.hibernate:hibernate-core:5.2.16.Final")
+ optional("org.hibernate:hibernate-core:5.3.0.CR1")
optional("javax.servlet:javax.se... | true |
Other | spring-projects | spring-framework | e170cb0f79fef17d43e769a23e66adaba9dc2c19.json | Upgrade framework build to JPA 2.2 and JTA 1.3
Issue: SPR-16685 | spring-tx/spring-tx.gradle | @@ -8,9 +8,9 @@ dependencies {
optional("javax.ejb:javax.ejb-api:3.2")
optional("javax.interceptor:javax.interceptor-api:1.2.1")
optional("javax.resource:javax.resource-api:1.7")
- optional("javax.transaction:javax.transaction-api:1.2")
+ optional("javax.transaction:javax.transaction-api:1.3")
optional("com.ibm... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-test/src/main/java/org/springframework/mock/web/reactive/function/server/MockServerRequest.java | @@ -88,11 +88,15 @@ public class MockServerRequest implements ServerRequest {
@Nullable
private Principal principal;
+ @Nullable
+ private final InetSocketAddress remoteAddress;
+
private MockServerRequest(HttpMethod method, URI uri, String contextPath, MockHeaders headers,
MultiValueMap<String, HttpCooki... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java | @@ -116,6 +116,11 @@ public MultiValueMap<String, HttpCookie> cookies() {
return request().getCookies();
}
+ @Override
+ public Optional<InetSocketAddress> remoteAddress() {
+ return Optional.ofNullable(request().getRemoteAddress());
+ }
+
@Override
public <T> T body(BodyExtractor<T, ? super ServerHttpReque... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java | @@ -16,6 +16,7 @@
package org.springframework.web.reactive.function.server;
+import java.net.InetSocketAddress;
import java.net.URI;
import java.security.Principal;
import java.util.ArrayList;
@@ -513,6 +514,11 @@ public MultiValueMap<String, HttpCookie> cookies() {
return this.request.cookies();
}
+ ... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java | @@ -114,6 +114,12 @@ default PathContainer pathContainer() {
*/
MultiValueMap<String, HttpCookie> cookies();
+ /**
+ * Return the remote address where this request is connected to, if available.
+ * @since 5.1
+ */
+ Optional<InetSocketAddress> remoteAddress();
+
/**
* Extract the body with the given {@c... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java | @@ -116,6 +116,11 @@ public MultiValueMap<String, HttpCookie> cookies() {
return this.delegate.cookies();
}
+ @Override
+ public Optional<InetSocketAddress> remoteAddress() {
+ return this.delegate.remoteAddress();
+ }
+
@Override
public <T> T body(BodyExtractor<T, ? super ServerHttpRequest> extractor) {
... | true |
Other | spring-projects | spring-framework | 7e2726f40018ad83be9ae1d9d5b59f59e981d66a.json | Add remoteAddress() to ServerRequest
Issue: SPR-16681 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java | @@ -87,11 +87,15 @@ public class MockServerRequest implements ServerRequest {
@Nullable
private Principal principal;
+ @Nullable
+ private final InetSocketAddress remoteAddress;
+
private MockServerRequest(HttpMethod method, URI uri, String contextPath, MockHeaders headers,
MultiValueMap<String, HttpCooki... | true |
Other | spring-projects | spring-framework | 967ea152b7eba861ff17950d2475cd6fd18bde02.json | Fix Java 9 link in the reference documentation | src/docs/asciidoc/web/webflux.adoc | @@ -63,7 +63,7 @@ overwhelm its destination.
Reactive Streams is a
https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.1/README.md#specification[small spec],
-also http://download.java.net/java/jdk9/docs/api/java/util/concurrent/Flow.html[adopted] in Java 9,
+also https://docs.oracle.com/javase/9/doc... | false |
Other | spring-projects | spring-framework | 2c648379abc56f5ce5ad83f2522d63b24ad72ffb.json | Delete dead code in spring-webmvc | spring-webmvc/src/main/java/org/springframework/web/servlet/config/AnnotationDrivenBeanDefinitionParser.java | @@ -27,7 +27,6 @@
import org.springframework.beans.factory.InitializingBean;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.beans.factory.config.BeanDefinitionHolder;
-import org.springframework.beans.factory.config.BeanReference;
import org.springframework.beans.factory.... | false |
Other | spring-projects | spring-framework | c7c743872aa7ee9143f95fc74d654914df4938fa.json | Fix Dokka reference to Spring Framework's Javadoc
This commit specifies a local packageListUrl and defines that dokka task
must be executed after the api task in order to be able to build KDoc
during the release process when the Spring Framework's Javadoc is not
published yet.
Issue: SPR-16687 | gradle/docs.gradle | @@ -49,12 +49,9 @@ task api(type: Javadoc) {
}
}
-// Need https://github.com/Kotlin/dokka/issues/184 to be fixed to avoid "Can't find node by signature" log spam
dokka {
dependsOn {
- subprojects.collect {
- it.tasks.getByName("jar")
- }
+ tasks.getByName("api")
}
doFirst {
classpath = subprojects.c... | false |
Other | spring-projects | spring-framework | cc12afdea2c4b2c3073c1c2bbc88091a4e7db74e.json | Add support for deferred import selector group
This commit allows several DeferredImportSelector instances to be
grouped and managed in a centralized fashion. This typically allows
different instances to provide a consistent ordered set of imports to
apply.
Issue: SPR-16589 | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java | @@ -51,6 +51,7 @@
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.beans.factory.support.BeanNameGenerator;
import org.springframework.context.annotation.ConfigurationCondition.ConfigurationPhase;
+import org.springframework.context.annotation.DeferredImportSelector... | true |
Other | spring-projects | spring-framework | cc12afdea2c4b2c3073c1c2bbc88091a4e7db74e.json | Add support for deferred import selector group
This commit allows several DeferredImportSelector instances to be
grouped and managed in a centralized fashion. This typically allows
different instances to provide a consistent ordered set of imports to
apply.
Issue: SPR-16589 | spring-context/src/main/java/org/springframework/context/annotation/DeferredImportSelector.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,6 +16,11 @@
package org.springframewo... | true |
Other | spring-projects | spring-framework | cc12afdea2c4b2c3073c1c2bbc88091a4e7db74e.json | Add support for deferred import selector group
This commit allows several DeferredImportSelector instances to be
grouped and managed in a centralized fashion. This typically allows
different instances to provide a consistent ordered set of imports to
apply.
Issue: SPR-16589 | spring-context/src/test/java/org/springframework/context/annotation/DeferredImportSelectorTests.java | @@ -0,0 +1,61 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | cc12afdea2c4b2c3073c1c2bbc88091a4e7db74e.json | Add support for deferred import selector group
This commit allows several DeferredImportSelector instances to be
grouped and managed in a centralized fashion. This typically allows
different instances to provide a consistent ordered set of imports to
apply.
Issue: SPR-16589 | spring-context/src/test/java/org/springframework/context/annotation/ImportSelectorTests.java | @@ -20,13 +20,19 @@
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
+import java.util.Arrays;
+import java.util.Collections;
import java.util.HashMap;
+import java.util.Iterator;
+import java.util.LinkedList;
import java.util.Map;
+import java... | true |
Other | spring-projects | spring-framework | d64f2eb03862dcef657fe1a37755184b1ecfda25.json | Add JSON matcher to assert on request body
Support asserting JSON regardless of order and formatting.
Based on same JsonExpectationHelper used in ContentResultMatchers.
Issue: SPR-13919 | spring-test/src/main/java/org/springframework/test/web/client/match/ContentRequestMatchers.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@
import javax.xml.transform.d... | true |
Other | spring-projects | spring-framework | d64f2eb03862dcef657fe1a37755184b1ecfda25.json | Add JSON matcher to assert on request body
Support asserting JSON regardless of order and formatting.
Based on same JsonExpectationHelper used in ContentResultMatchers.
Issue: SPR-13919 | spring-test/src/test/java/org/springframework/test/web/client/match/ContentRequestMatchersTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -142,4 +142,52 @@ public void testNodeMatche... | true |
Other | spring-projects | spring-framework | 58a5138f26fd4a2f9a769ea34a0b3017909e4723.json | simplify lambda expression | spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpResponse.java | @@ -76,16 +76,14 @@ public HttpStatus getStatusCode() {
public MultiValueMap<String, ResponseCookie> getCookies() {
MultiValueMap<String, ResponseCookie> result = new LinkedMultiValueMap<>();
this.response.cookies().values().stream().flatMap(Collection::stream)
- .forEach(cookie -> {
- ResponseCookie res... | false |
Other | spring-projects | spring-framework | 2f9d0a7de8e2f1247dd4a34811220106f7359aa5.json | simplify boolean NOT operation | spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterUtils.java | @@ -119,7 +119,7 @@ public static ParsedSql parseSqlStatement(final String sql) {
String parameter = null;
if (j < statement.length && c == ':' && statement[j] == '{') {
// :{x} style parameter
- while (j < statement.length && !('}' == statement[j])) {
+ while (j < statement.length && '}' != sta... | false |
Other | spring-projects | spring-framework | 6163f2d32f3f1541a7032f8888bd79395e927140.json | use more modern java API for empty collections | spring-context/src/main/java/org/springframework/context/annotation/ContextAnnotationAutowireCandidateResolver.java | @@ -91,13 +91,13 @@ public Object getTarget() {
if (target == null) {
Class<?> type = getTargetClass();
if (Map.class == type) {
- return Collections.EMPTY_MAP;
+ return Collections.emptyMap();
}
else if (List.class == type) {
- return Collections.EMPTY_LIST;
+ return Co... | false |
Other | spring-projects | spring-framework | 32b689a9947823427a01899d5a310c9435ee78d2.json | use StringBuilder for complex string concatenation | spring-beans/src/main/java/org/springframework/beans/AbstractNestablePropertyAccessor.java | @@ -634,7 +634,7 @@ protected Object getPropertyValue(PropertyTokenHolder tokens) throws BeansExcept
"property path '" + propertyName + "': returned null");
}
}
- String indexedPropertyName = tokens.actualName;
+ StringBuilder indexedPropertyName = new StringBuilder(tokens.actualName);
... | true |
Other | spring-projects | spring-framework | 32b689a9947823427a01899d5a310c9435ee78d2.json | use StringBuilder for complex string concatenation | spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataContext.java | @@ -618,7 +618,7 @@ public Map<String, Object> matchInParameterValuesWithCallParameters(SqlParameter
public String createCallString() {
Assert.state(this.metaDataProvider != null, "No CallMetaDataProvider available");
- String callString;
+ StringBuilder callString;
int parameterCount = 0;
String catalog... | true |
Other | spring-projects | spring-framework | e20652009dca44363e7296c7bf7510def391885f.json | Improve docs on SseEmitter onComplete/onError
Issue: SPR-16548 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitter.java | @@ -66,13 +66,16 @@ public class ResponseBodyEmitter {
@Nullable
private final Long timeout;
- private final Set<DataWithMediaType> earlySendAttempts = new LinkedHashSet<>(8);
-
@Nullable
private Handler handler;
+ /** Store send data before handler is initialized */
+ private final Set<DataWithMediaType> e... | true |
Other | spring-projects | spring-framework | e20652009dca44363e7296c7bf7510def391885f.json | Improve docs on SseEmitter onComplete/onError
Issue: SPR-16548 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java | @@ -82,6 +82,10 @@ protected void extendResponse(ServerHttpResponse outputMessage) {
* SseEmitter emitter = new SseEmitter();
* emitter.send(event().data(myObject));
* </pre>
+ *
+ * <p>Please, see {@link ResponseBodyEmitter#send(Object) parent Javadoc}
+ * for important notes on exception handling.
+ *
... | true |
Other | spring-projects | spring-framework | e20652009dca44363e7296c7bf7510def391885f.json | Improve docs on SseEmitter onComplete/onError
Issue: SPR-16548 | src/docs/asciidoc/web/webmvc.adoc | @@ -3304,6 +3304,13 @@ response. For example:
`ResponseBodyEmitter` can also be used as the body in a `ResponseEntity` allowing you to
customize the status and headers of the response.
+When an `emitter` throws an `IOException` (e.g. if the remote client went away) applications
+are not responsible for cleaning up ... | true |
Other | spring-projects | spring-framework | 030bc224e30699a91e33e27a6d9782803afbd0d4.json | Invert the check for ServletInputStream.isReady()
When checking whether there is still request body the first method
that should be checked is ServletInputStream.isReady() and then
ServletInputStream.isFinished(). ServletInputStream.isReady() is the active
method whereas the ServletInputStream.isFinished() is not.
It ... | spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java | @@ -263,7 +263,7 @@ public void registerReadListener() throws IOException {
@Override
protected void checkOnDataAvailable() {
- if (!this.inputStream.isFinished() && this.inputStream.isReady()) {
+ if (this.inputStream.isReady() && !this.inputStream.isFinished()) {
onDataAvailable();
}
} | false |
Other | spring-projects | spring-framework | df0b39e8acd8566f9b0e79989a9897b251390687.json | Add missing packages to Groovy scripts | spring-context/src/test/resources/org/springframework/scripting/groovy/ScriptBean.groovy | @@ -1,3 +1,5 @@
+package org.springframework.scripting.groovy;
+
import org.springframework.context.ApplicationContext
import org.springframework.context.ApplicationContextAware
import org.springframework.scripting.ContextScriptBean
@@ -10,7 +12,7 @@ class GroovyScriptBean implements ContextScriptBean, ApplicationCo... | true |
Other | spring-projects | spring-framework | df0b39e8acd8566f9b0e79989a9897b251390687.json | Add missing packages to Groovy scripts | spring-context/src/test/resources/org/springframework/scripting/groovy/TestFactoryBean.groovy | @@ -1,3 +1,5 @@
+package org.springframework.scripting.groovy;
+
import org.springframework.beans.factory.FactoryBean
class TestFactoryBean implements FactoryBean {
@@ -13,5 +15,4 @@ class TestFactoryBean implements FactoryBean {
public Object getObject() {
"test"
}
-
} | true |
Other | spring-projects | spring-framework | df0b39e8acd8566f9b0e79989a9897b251390687.json | Add missing packages to Groovy scripts | spring-context/src/test/resources/org/springframework/scripting/groovy/simple.groovy | @@ -1 +1,3 @@
+package org.springframework.scripting.groovy;
+
return 3 * 2 | true |
Other | spring-projects | spring-framework | 28e402bc762369cdbea7accf0eb2c5e16818fe14.json | Prevent instantiation of AnnotatedElementUtils
Closes gh-1848 | spring-core/src/main/java/org/springframework/core/annotation/AnnotatedElementUtils.java | @@ -94,7 +94,7 @@
* @see AnnotationUtils
* @see BridgeMethodResolver
*/
-public class AnnotatedElementUtils {
+public abstract class AnnotatedElementUtils {
/**
* {@code null} constant used to denote that the search algorithm should continue. | false |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-web/src/main/java/org/springframework/web/method/HandlerTypePredicate.java | @@ -29,19 +29,24 @@
import org.springframework.util.StringUtils;
/**
- * A {@code Predicate} to match request handling component types based on the
- * following selectors:
+ * A {@code Predicate} to match request handling component types if
+ * <strong>any</strong> of the following selectors match:
* <ul>
* <l... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-web/src/test/java/org/springframework/web/method/HandlerTypePredicateTests.java | @@ -0,0 +1,66 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webflux/src/main/java/org/springframework/web/reactive/config/PathMatchConfigurer.java | @@ -18,9 +18,9 @@
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.function.Predicate;
import org.springframework.lang.Nullable;
-import org.springframework.web.method.HandlerTypePredicate;
/**
* Assist with configuring {@code HandlerMapping}'s with path matching options.
@@ -39,7 +39... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webflux/src/main/java/org/springframework/web/reactive/config/WebFluxConfigurationSupport.java | @@ -18,6 +18,7 @@
import java.util.List;
import java.util.Map;
+import java.util.function.Predicate;
import reactor.core.publisher.Mono;
@@ -44,7 +45,6 @@
import org.springframework.web.bind.WebDataBinder;
import org.springframework.web.bind.support.ConfigurableWebBindingInitializer;
import org.springframew... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerMapping.java | @@ -21,6 +21,7 @@
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.function.Predicate;
import org.springframework.context.EmbeddedValueResolverAware;
import org.springframework.core.annotation.AnnotatedElementUtils;
@@ -34,7 +35,6 @@
import org.springframewor... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/PathMatchConfigurer.java | @@ -18,10 +18,10 @@
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.function.Predicate;
import org.springframework.lang.Nullable;
import org.springframework.util.PathMatcher;
-import org.springframework.web.method.HandlerTypePredicate;
import org.springframework.web.util.UrlPathHelper;
... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupport.java | @@ -22,6 +22,7 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
+import java.util.function.Predicate;
import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest;
@@ -70,7 +71,6 @@
import org.springframework.web.bind.support.ConfigurableWebBindingInitializer;
impor... | true |
Other | spring-projects | spring-framework | 86c861516d55c69bae0150271c1a10d40afa726e.json | Accept Predicate instead of HandlerTypePredicate
Issue: SPR-16336 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerMapping.java | @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.function.Predicate;
import javax.servlet.http.HttpServletRequest;
import org.springframework.context.EmbeddedValueResolverAware;
@@ -38,7 +39,6 @@
import org.springframework.web.bind.annotation.RequestMapping;... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-web/src/main/java/org/springframework/http/converter/json/MappingJackson2HttpMessageConverter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,21 +95,6 @@ protected void writePrefix(J... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-web/src/main/java/org/springframework/http/converter/json/MappingJacksonValue.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -45,9 +45,6 @@ public class MappingJacksonVa... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-web/src/test/java/org/springframework/http/converter/json/MappingJackson2HttpMessageConverterTests.java | @@ -394,39 +394,6 @@ public void filters() throws Exception {
assertThat(result, not(containsString("\"property2\":\"value\"")));
}
- @Test
- public void jsonp() throws Exception {
- MappingJacksonValue jacksonValue = new MappingJacksonValue("foo");
- jacksonValue.setSerializationView(MyJacksonView1.class);
- ... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractJsonpResponseBodyAdvice.java | @@ -1,114 +0,0 @@
-/*
- * Copyright 2002-2015 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/json/MappingJackson2JsonView.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,26 +17,19 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapterTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -255,25 +255,6 @@ public void responseBodyAd... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-webmvc/src/test/java/org/springframework/web/servlet/view/json/MappingJackson2JsonViewTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -322,17 +322,6 @@ public void renderSimpleBe... | true |
Other | spring-projects | spring-framework | ac37b678a3ac9ee541a10e8ad74d612bb9ec5b88.json | Remove JSONP support
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914 | spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/StompWebSocketEndpointRegistration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -48,7 +48,7 @@ public interface StompWebSock... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.