language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
0aaa6528dcb07ef76049cf74a4d6aecb4ee6c610.json
Remove JAF references This commit updates the main code base to conform to the dropped JAF dependency in MediaTypeFactory. Specifically, it - Removes JAF detection (JAF_PRESENT constants) - Deprecated useJaf properties, with no direct replacement. - Updated docs to remove JAF references, in favor of MediaTypeFacto...
spring-web/src/main/java/org/springframework/web/accept/PathExtensionContentNegotiationStrategy.java
@@ -27,7 +27,6 @@ import org.springframework.http.MediaType; import org.springframework.http.MediaTypeFactory; import org.springframework.util.Assert; -import org.springframework.util.ClassUtils; import org.springframework.util.StringUtils; import org.springframework.web.HttpMediaTypeNotAcceptableException; impor...
true
Other
spring-projects
spring-framework
0aaa6528dcb07ef76049cf74a4d6aecb4ee6c610.json
Remove JAF references This commit updates the main code base to conform to the dropped JAF dependency in MediaTypeFactory. Specifically, it - Removes JAF detection (JAF_PRESENT constants) - Deprecated useJaf properties, with no direct replacement. - Updated docs to remove JAF references, in favor of MediaTypeFacto...
spring-web/src/main/java/org/springframework/web/accept/ServletPathExtensionContentNegotiationStrategy.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -52,7 +52,8 @@ public ServletPathExtensionCo...
true
Other
spring-projects
spring-framework
0aaa6528dcb07ef76049cf74a4d6aecb4ee6c610.json
Remove JAF references This commit updates the main code base to conform to the dropped JAF dependency in MediaTypeFactory. Specifically, it - Removes JAF detection (JAF_PRESENT constants) - Deprecated useJaf properties, with no direct replacement. - Updated docs to remove JAF references, in favor of MediaTypeFacto...
spring-webflux/src/main/java/org/springframework/web/reactive/accept/PathExtensionContentTypeResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -33,17 +33,14 @@ * the request path and us...
true
Other
spring-projects
spring-framework
0aaa6528dcb07ef76049cf74a4d6aecb4ee6c610.json
Remove JAF references This commit updates the main code base to conform to the dropped JAF dependency in MediaTypeFactory. Specifically, it - Removes JAF detection (JAF_PRESENT constants) - Deprecated useJaf properties, with no direct replacement. - Updated docs to remove JAF references, in favor of MediaTypeFacto...
spring-webflux/src/main/java/org/springframework/web/reactive/accept/RequestedContentTypeResolverBuilder.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -74,9 +74,9 @@ * {@link #mediaTypes(Map)}....
true
Other
spring-projects
spring-framework
0aaa6528dcb07ef76049cf74a4d6aecb4ee6c610.json
Remove JAF references This commit updates the main code base to conform to the dropped JAF dependency in MediaTypeFactory. Specifically, it - Removes JAF detection (JAF_PRESENT constants) - Deprecated useJaf properties, with no direct replacement. - Updated docs to remove JAF references, in favor of MediaTypeFacto...
spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/ContentNegotiationConfigurer.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,7 @@ import javax.servlet.Servlet...
true
Other
spring-projects
spring-framework
f0a43e5d5c506a2ffec5654dac6886e23d940dda.json
Drop JAF dependency from MediaTypeFactory This commit drops the Java Activation Framework dependency from the MediaTypeFactory, in favor of parsing our own `mime.types` file, which was obtained from Apache HTTPD. Issue: SPR-14908
spring-web/src/main/java/org/springframework/http/MediaTypeFactory.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,62 +16,88 @@ package org.springframew...
true
Other
spring-projects
spring-framework
f0a43e5d5c506a2ffec5654dac6886e23d940dda.json
Drop JAF dependency from MediaTypeFactory This commit drops the Java Activation Framework dependency from the MediaTypeFactory, in favor of parsing our own `mime.types` file, which was obtained from Apache HTTPD. Issue: SPR-14908
spring-web/src/main/resources/org/springframework/http/mime.types
@@ -0,0 +1,1855 @@ +# This file maps Internet media types to unique file extension(s). +# Although created for httpd, this file is used by many software systems +# and has been placed in the public domain for unlimited redistribution. +# +# The table below contains both registered and (common) unregistered types. +# A ...
true
Other
spring-projects
spring-framework
f0a43e5d5c506a2ffec5654dac6886e23d940dda.json
Drop JAF dependency from MediaTypeFactory This commit drops the Java Activation Framework dependency from the MediaTypeFactory, in favor of parsing our own `mime.types` file, which was obtained from Apache HTTPD. Issue: SPR-14908
spring-web/src/test/java/org/springframework/http/MediaTypeFactoryTests.java
@@ -0,0 +1,35 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
7c84266259227467513aff7c6fe1ea84ba55a5d5.json
Remove trailing whitespace in spring-test
spring-test/src/main/java/org/springframework/test/context/junit4/rules/SpringMethodRule.java
@@ -224,7 +224,7 @@ private Statement withProfileValueCheck(Statement next, Method testMethod, Objec * that is annotated with {@code @ClassRule}. */ private static SpringClassRule validateSpringClassRuleConfiguration(Class<?> testClass) { - Field ruleField = findSpringClassRuleField(testClass).orElseThrow(() -...
true
Other
spring-projects
spring-framework
7c84266259227467513aff7c6fe1ea84ba55a5d5.json
Remove trailing whitespace in spring-test
spring-test/src/test/java/org/springframework/test/context/junit/jupiter/nested/NestedTestsWithSpringAndJUnitJupiterTestCase.java
@@ -32,7 +32,7 @@ * Integration tests that verify support for {@code @Nested} test classes * in conjunction with the {@link SpringExtension} in a JUnit 5 (Jupiter) * environment. - * + * * @author Sam Brannen * @since 5.0 * @see org.springframework.test.context.junit4.nested.NestedTestsWithSpringRulesTests
true
Other
spring-projects
spring-framework
7c84266259227467513aff7c6fe1ea84ba55a5d5.json
Remove trailing whitespace in spring-test
spring-test/src/test/java/org/springframework/test/context/junit4/concurrency/SpringJUnit4ConcurrencyTests.java
@@ -55,7 +55,7 @@ * <p>The tests executed by this test class come from a hand-picked collection of test * classes within the test suite that is intended to cover most categories of tests * that are currently supported by the TestContext Framework on JUnit 4. - * + * * <p>The chosen test classes intentionally d...
true
Other
spring-projects
spring-framework
41c413a7489f4e3d612b1133328eb0fe2fe80e92.json
Add MockServerWebExchange and toExchange shortcuts Issue: SPR-15350
spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerHttpRequest.java
@@ -103,6 +103,15 @@ protected MultiValueMap<String, HttpCookie> initCookies() { return this.cookies; } + + /** + * Shortcut to wrap the request with a {@code MockServerWebExchange}. + */ + public MockServerWebExchange toExchange() { + return new MockServerWebExchange(this); + } + + // Static builder method...
true
Other
spring-projects
spring-framework
41c413a7489f4e3d612b1133328eb0fe2fe80e92.json
Add MockServerWebExchange and toExchange shortcuts Issue: SPR-15350
spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerWebExchange.java
@@ -0,0 +1,47 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
41c413a7489f4e3d612b1133328eb0fe2fe80e92.json
Add MockServerWebExchange and toExchange shortcuts Issue: SPR-15350
spring-web/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
@@ -44,7 +44,6 @@ import org.springframework.util.StringUtils; import org.springframework.web.server.ServerWebExchange; import org.springframework.web.server.WebSession; -import org.springframework.web.server.session.DefaultWebSessionManager; import org.springframework.web.server.session.WebSessionManager; /** @...
true
Other
spring-projects
spring-framework
41c413a7489f4e3d612b1133328eb0fe2fe80e92.json
Add MockServerWebExchange and toExchange shortcuts Issue: SPR-15350
spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerHttpRequest.java
@@ -103,6 +103,15 @@ protected MultiValueMap<String, HttpCookie> initCookies() { return this.cookies; } + + /** + * Shortcut to wrap the request with a {@code MockServerWebExchange}. + */ + public MockServerWebExchange toExchange() { + return new MockServerWebExchange(this); + } + + // Static builder method...
true
Other
spring-projects
spring-framework
41c413a7489f4e3d612b1133328eb0fe2fe80e92.json
Add MockServerWebExchange and toExchange shortcuts Issue: SPR-15350
spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerWebExchange.java
@@ -0,0 +1,47 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
45aa1edf871e7e86cbd9523146a94b911d944736.json
Fix Undertow zero-copy-support This commit fixed the exception that occurs when a larger file is transfered using zero-copy on Undertow. Issue: SPR-15343
spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpResponse.java
@@ -30,6 +30,7 @@ import io.undertow.util.HttpString; import org.reactivestreams.Processor; import org.reactivestreams.Publisher; +import org.xnio.channels.Channels; import org.xnio.channels.StreamSinkChannel; import reactor.core.publisher.Mono; @@ -79,24 +80,28 @@ protected void applyStatusCode() { @Overrid...
false
Other
spring-projects
spring-framework
170057005e4960035e2b8fc2d0f11ac63295473b.json
Use .nest() instead of .route() in Kotlin Web DSL The goal is to have better consistency between Java and Kotlin functional Web API.
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/RouterFunctionExtensions.kt
@@ -80,11 +80,11 @@ class RouterDsl { operator fun RequestPredicate.not(): RequestPredicate = this.negate() - fun RequestPredicate.route(r: Routes) { + fun RequestPredicate.nest(r: Routes) { routes += RouterFunctions.nest(this, RouterDsl().apply(r).router()) } - fun String.route(r: Routes) { + fun String.n...
true
Other
spring-projects
spring-framework
170057005e4960035e2b8fc2d0f11ac63295473b.json
Use .nest() instead of .route() in Kotlin Web DSL The goal is to have better consistency between Java and Kotlin functional Web API.
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/RouterFunctionExtensionsTests.kt
@@ -107,15 +107,15 @@ class RouterFunctionExtensionsTests { fun sampleRouter() = router { (GET("/foo/") or GET("/foos/")) { req -> handle(req) } - "/api".route { + "/api".nest { POST("/foo/", ::handleFromClass) PUT("/foo/", :: handleFromClass) "/foo/" { handleFromClass(it) } } accept(APPLICA...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/HandlerMethodArgumentResolver.java
@@ -23,23 +23,26 @@ import org.springframework.web.server.ServerWebExchange; /** - * Strategy interface for resolving method parameters into argument values in - * the context of a given request. + * Strategy to resolve the argument value for a method parameter in the context + * of the current HTTP request. * ...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/InvocableHandlerMethod.java
@@ -29,7 +29,6 @@ import reactor.core.publisher.Mono; import org.springframework.core.DefaultParameterNameDiscoverer; -import org.springframework.core.GenericTypeResolver; import org.springframework.core.MethodParameter; import org.springframework.core.ParameterNameDiscoverer; import org.springframework.core.ann...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/SyncHandlerMethodArgumentResolver.java
@@ -33,20 +33,25 @@ */ public interface SyncHandlerMethodArgumentResolver extends HandlerMethodArgumentResolver { + + /** + * {@inheritDoc} + * <p>By default this simply delegates to {@link #resolveArgumentValue} for + * synchronous resolution. + */ @Override - default Mono<Object> resolveArgument(MethodPara...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/SyncInvocableHandlerMethod.java
@@ -27,16 +27,17 @@ import org.springframework.web.server.ServerWebExchange; /** - * An extension of {@code InvocableHandlerMethod} for synchronous, non-blocking - * method invocation via {@link #invokeForHandlerResult}. By allowing only - * {@link SyncHandlerMethodArgumentResolver}s to be configured, the invocatio...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractNamedValueArgumentResolver.java
@@ -171,6 +171,9 @@ private Object resolveStringValue(String value) { protected abstract Mono<Object> resolveName(String name, MethodParameter parameter, ServerWebExchange exchange); + /** + * Apply type conversion if necessary. + */ private Object applyConversion(Object value, NamedValueInfo namedValueInfo...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractNamedValueSyncArgumentResolver.java
@@ -38,35 +38,45 @@ public abstract class AbstractNamedValueSyncArgumentResolver extends AbstractNamedValueArgumentResolver implements SyncHandlerMethodArgumentResolver { - public AbstractNamedValueSyncArgumentResolver(ConfigurableBeanFactory beanFactory) { + + protected AbstractNamedValueSyncArgumentResolver(Con...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/InitBinderBindingContext.java
@@ -29,8 +29,7 @@ import org.springframework.web.server.ServerWebExchange; /** - * Variant of {@link BindingContext} that further initializes {@code DataBinder} - * instances through {@code @InitBinder} methods. + * Extends {@link BindingContext} with {@code @InitBinder} method initialization. * * @author Rosse...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ModelArgumentResolver.java
@@ -32,16 +32,17 @@ */ public class ModelArgumentResolver implements SyncHandlerMethodArgumentResolver { + @Override public boolean supportsParameter(MethodParameter parameter) { return Model.class.isAssignableFrom(parameter.getParameterType()); } @Override - public Optional<Object> resolveArgumentVal...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/PathVariableMapMethodArgumentResolver.java
@@ -40,19 +40,17 @@ */ public class PathVariableMapMethodArgumentResolver implements SyncHandlerMethodArgumentResolver { + @Override public boolean supportsParameter(MethodParameter parameter) { PathVariable ann = parameter.getParameterAnnotation(PathVariable.class); return (ann != null && (Map.class.isA...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMapMethodArgumentResolver.java
@@ -42,24 +42,22 @@ */ public class RequestHeaderMapMethodArgumentResolver implements SyncHandlerMethodArgumentResolver { + @Override public boolean supportsParameter(MethodParameter parameter) { return (parameter.hasParameterAnnotation(RequestHeader.class) && Map.class.isAssignableFrom(parameter.getPa...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestParamMapMethodArgumentResolver.java
@@ -45,35 +45,29 @@ */ public class RequestParamMapMethodArgumentResolver implements SyncHandlerMethodArgumentResolver { + @Override - public boolean supportsParameter(MethodParameter parameter) { - RequestParam requestParam = parameter.getParameterAnnotation(RequestParam.class); + public boolean supportsParame...
true
Other
spring-projects
spring-framework
f490f3ca63a56a6e31a271b513f89f2926b491fa.json
Polish SyncHandlerMethodArgumentResolver hiearchy
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ServerWebExchangeArgumentResolver.java
@@ -45,6 +45,7 @@ */ public class ServerWebExchangeArgumentResolver implements SyncHandlerMethodArgumentResolver { + @Override public boolean supportsParameter(MethodParameter parameter) { Class<?> paramType = parameter.getParameterType(); @@ -55,10 +56,10 @@ public boolean supportsParameter(MethodParameter...
true
Other
spring-projects
spring-framework
fba2633e6e20d083bf13cb545827b04ba4ff71aa.json
Fix doc format Closes gh-1549
CONTRIBUTING-DOCUMENTATION.adoc
@@ -55,6 +55,7 @@ Some notes on the documentation. * Follow the existing style when inserting `source` blocks. Here are some useful resources for working with Asciidoctor: + * http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/[Asciidoctor Quick Reference] * http://asciidoctor.org/docs/user-manual/[Ascii...
false
Other
spring-projects
spring-framework
3533db78d24117d11a598b38a06422a9360faedf.json
Fix broken link to overview
src/docs/asciidoc/index.adoc
@@ -4,7 +4,7 @@ Welcome to the Spring Framework reference documentation! -Please read the <<overview.adoc,*Overview*>> for a quick introduction including brief history, +Please read the <<overview.adoc#overview,*Overview*>> for a quick introduction including brief history, design philosophy, where to ask question...
true
Other
spring-projects
spring-framework
3533db78d24117d11a598b38a06422a9360faedf.json
Fix broken link to overview
src/docs/asciidoc/overview.adoc
@@ -2,6 +2,7 @@ :toclevels: 1 :docinfo1: +[[overview]] = Spring Framework Overview Spring makes it easy to create Java enterprise applications. It provides everything you
true
Other
spring-projects
spring-framework
b11caeb3ea763bf26680ffedba9bde9e740fdf4e.json
Fix headings in WebFlux section
src/docs/asciidoc/web-reactive.adoc
@@ -7,9 +7,62 @@ :docinfo1: This part of the documentation covers support for reactive stack, web applications built on a -http://www.reactive-streams.org/[Reactive Streams] API to run on top of non-blocking +http://www.reactive-streams.org/[Reactive Streams] API to run on non-blocking servers such as Netty, Under...
true
Other
spring-projects
spring-framework
b11caeb3ea763bf26680ffedba9bde9e740fdf4e.json
Fix headings in WebFlux section
src/docs/asciidoc/web/webflux.adoc
@@ -16,11 +16,6 @@ and co-exist side by side in the Spring Framework. Each module is optional. Applications may use one or the other module, or in some cases both -- e.g. Spring MVC controllers with the reactive `WebClient`. -The `spring-webflux` module also provides a reactive <<webflux-client,WebClient>> for -per...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
gradle/docs.gradle
@@ -83,6 +83,11 @@ asciidoctor { sources { include '*.adoc' } + resources { + from(sourceDir) { + include 'images/**', 'tocbot-3.0.2/**' + } + } logDocuments = true backends = ["html5"] // only ouput PDF documentation for non-SNAPSHOT builds
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/core.adoc
@@ -3,7 +3,7 @@ :doc-root: https://docs.spring.io :api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: This part of the reference documentation covers all of those technologies that are
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/data-access.adoc
@@ -3,7 +3,7 @@ :doc-root: https://docs.spring.io :api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: This part of the reference documentation is concerned with data access and the
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/docinfo-footer.html
@@ -1,10 +1,46 @@ +<script src="tocbot-3.0.2/tocbot.js"></script> <script> - var rootLink = document.createElement("a"); - rootLink.setAttribute("href", "index.html"); - rootLink.innerHTML = "<i class=\"fa fa-chevron-left\" aria-hidden=\"true\"></i>&nbsp;&nbsp;Back to index"; + + // Tocbot dynamic TOC, wor...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/integration.adoc
@@ -5,7 +5,7 @@ :doc-spring-amqp: {doc-root}/spring-amqp/docs/current/reference :doc-spring-gemfire: {doc-root}/spring-gemfire/docs/current/reference :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: This part of the reference documentation covers the Spring Framework's integration with
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/kotlin.adoc
@@ -3,7 +3,7 @@ :doc-root: https://docs.spring.io :api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: [[introduction]]
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/stylesheets/spring.css
@@ -1,4 +1,23 @@ @import url(https://fonts.googleapis.com/css?family=Varela+Round|Montserrat:400,700); +@import url('../tocbot-3.0.2/tocbot.css'); + +/* See https://github.com/asciidoctor/asciidoctor/issues/699#issuecomment-321066006 */ +/* ==============================================================================...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/testing.adoc
@@ -4,7 +4,7 @@ :api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework :doc-spring-boot: {doc-root}/spring-boot/docs/current/reference :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: The adoption of the test-driven-development (TDD) approach to software
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/tocbot-3.0.2/styles.css
@@ -0,0 +1 @@ +.transition--300{transition:all 300ms ease-in-out}.toc{height:100%;width:280px;transform:translateX(0)}.content h1:first-child,.content h2:first-child{padding-top:0;margin-top:0}.title{font-size:3em}.content{margin-bottom:95vh}.content ul,.content ol{list-style:inherit}.content a{color:#0977c3;text-decor...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/tocbot-3.0.2/tocbot.css
@@ -0,0 +1 @@ +.toc{overflow-y:auto}.toc>ul{overflow:hidden;position:relative}.toc>ul li{list-style:none}.toc-list{margin:0;padding-left:10px}a.toc-link{color:currentColor;height:100%}.is-collapsible{max-height:1000px;overflow:hidden;transition:all 300ms ease-in-out}.is-collapsed{max-height:0}.is-position-fixed{positio...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/tocbot-3.0.2/tocbot.js
@@ -0,0 +1,136 @@ +/******/ (function(modules) { // webpackBootstrap +/******/ // The module cache +/******/ var installedModules = {}; +/******/ +/******/ // The require function +/******/ function __webpack_require__(moduleId) { +/******/ +/******/ // Check if module is in cache +/******/ if(installedModules[...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/tocbot-3.0.2/tocbot.min.js
@@ -0,0 +1 @@ +!function(e){function t(o){if(n[o])return n[o].exports;var i=n[o]={i:o,l:!1,exports:{}};return e[o].call(i.exports,i,i.exports,t),i.l=!0,i.exports}var n={};t.m=e,t.c=n,t.i=function(e){return e},t.d=function(e,n,o){t.o(e,n)||Object.defineProperty(e,n,{configurable:!1,enumerable:!0,get:o})},t.n=function(e)...
true
Other
spring-projects
spring-framework
ee3913c6d0e092ba798fb9fb4fc1d758b8692e36.json
Use Tocbot for Table of Contents
src/docs/asciidoc/web.adoc
@@ -3,7 +3,7 @@ :doc-root: https://docs.spring.io :api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework :toc: left -:toclevels: 2 +:toclevels: 4 :docinfo1: This part of the documentation covers support for Servlet stack, web applications built on the
true
Other
spring-projects
spring-framework
7a8c8c062e7c8767fc1fbaae442f568685ffe83e.json
Add reactive mocks to testing section
src/docs/asciidoc/testing.adoc
@@ -77,14 +77,28 @@ The `org.springframework.mock.web` package contains a comprehensive set of Servl mock objects, which are useful for testing web contexts, controllers, and filters. These mock objects are targeted at usage with Spring's Web MVC framework and are generally more convenient to use than dynamic mock o...
false
Other
spring-projects
spring-framework
b11d1f5f9b5ee8e0af908f58d7c48e2aba4e9d67.json
Fix typos in spring-mvc.xsd Closes gh-1535
spring-webmvc/src/main/resources/org/springframework/web/servlet/config/spring-mvc.xsd
@@ -959,7 +959,7 @@ <xsd:attribute name="cache-views" type="xsd:boolean"> <xsd:annotation> <xsd:documentation><![CDATA[ - Enable or disable thew caching of resolved views. + Enable or disable the caching of resolved views. Default is "true": caching is enabled. Disable this only for debugging and develo...
false
Other
spring-projects
spring-framework
b7708d989bb426055839fa38b3e65249fb962a65.json
Improve Kotlin documentation readability
src/docs/asciidoc/kotlin.adoc
@@ -10,7 +10,7 @@ == Introduction https://kotlinlang.org[Kotlin] is a statically-typed language targeting the JVM (and other platforms) -which allows writing concise and elegant code while providing a very good +which allows writing concise and elegant code while providing very good https://kotlinlang.org/docs/ref...
false
Other
spring-projects
spring-framework
1440026fb49200f632cfeb6c1dd38968adf3c1ad.json
Change bean registration to use initialize This commit changes the reference documentation to conform with the updated API defined in https://github.com/spring-projects/spring-framework/commit/8b8a6766de01467c8b45b1b9664f0ab2d58f7c69
src/docs/asciidoc/kotlin.adoc
@@ -227,7 +227,7 @@ This `beans()` function can then be used to register beans on the application co [source,kotlin] ---- val context = GenericApplicationContext().apply { - beans().invoke(this) + beans().initialize(this) refresh() } ----
false
Other
spring-projects
spring-framework
255ccf58e0f78320badb96ba1a08004c88c1ff0a.json
Remove snapshot repository from build setup
build.gradle
@@ -126,7 +126,6 @@ configure(allprojects) { project -> repositories { maven { url "https://repo.spring.io/libs-release" } maven { url "https://repo.spring.io/milestone" } - maven { url "https://repo.spring.io/snapshot" } } dependencies {
false
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-test/src/main/java/org/springframework/mock/http/client/reactive/MockClientHttpResponse.java
@@ -55,8 +55,6 @@ public class MockClientHttpResponse implements ClientHttpResponse { private final DataBufferFactory bufferFactory = new DefaultDataBufferFactory(); - private boolean closed = false; - public MockClientHttpResponse(HttpStatus status) { Assert.notNull(status, "HttpStatus is required"); @@ -...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-web/src/main/java/org/springframework/http/client/reactive/ClientHttpResponse.java
@@ -16,8 +16,6 @@ package org.springframework.http.client.reactive; -import java.io.Closeable; - import org.springframework.http.HttpStatus; import org.springframework.http.ReactiveHttpInputMessage; import org.springframework.http.ResponseCookie; @@ -30,7 +28,7 @@ * @author Brian Clozel * @since 5.0 */ -p...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-web/src/main/java/org/springframework/http/client/reactive/ClientHttpResponseDecorator.java
@@ -70,11 +70,6 @@ public Flux<DataBuffer> getBody() { return this.delegate.getBody(); } - @Override - public void close() { - this.delegate.close(); - } - @Override public String toString() { return getClass().getSimpleName() + " [delegate=" + getDelegate() + "]";
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpResponse.java
@@ -89,11 +89,6 @@ public MultiValueMap<String, ResponseCookie> getCookies() { return CollectionUtils.unmodifiableMultiValueMap(result); } - @Override - public void close() { - this.response.dispose(); - } - @Override public String toString() { return "ReactorClientHttpResponse{" +
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-web/src/test/java/org/springframework/mock/http/client/reactive/test/MockClientHttpResponse.java
@@ -55,7 +55,6 @@ public class MockClientHttpResponse implements ClientHttpResponse { private final DataBufferFactory bufferFactory = new DefaultDataBufferFactory(); - private boolean closed = false; public MockClientHttpResponse(HttpStatus status) { Assert.notNull(status, "HttpStatus is required"); @@ -99...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientResponse.java
@@ -16,7 +16,6 @@ package org.springframework.web.reactive.function.client; -import java.io.Closeable; import java.util.List; import java.util.Optional; import java.util.OptionalLong; @@ -44,7 +43,7 @@ * @author Arjen Poutsma * @since 5.0 */ -public interface ClientResponse extends Closeable { +public int...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultClientResponse.java
@@ -26,6 +26,7 @@ import reactor.core.publisher.Mono; import org.springframework.core.ParameterizedTypeReference; +import org.springframework.core.io.buffer.DataBufferUtils; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpStatus; import org.springframework.http.MediaType; @@ -98,...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -461,17 +461,11 @@ interface Builder { * .exchange() * .flatMapMany(response -> response.bodyToFlux(Pojo.class)); * </pre> - * <p>If the response body is not consumed with {@code bodyTo*} - * or {@code toEntity*} methods, it is your responsibility - * to release the HTTP resources with {@li...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultClientResponseTests.java
@@ -28,6 +28,8 @@ import org.junit.Test; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; +import reactor.test.StepVerifier; +import reactor.test.publisher.TestPublisher; import org.springframework.core.ParameterizedTypeReference; import org.springframework.core.codec.StringDecoder; @@ -46...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java
@@ -541,15 +541,15 @@ public void shouldApplyErrorHandlingFilter() throws Exception { @Test public void shouldReceiveEmptyResponse() throws Exception { - prepareResponse(response -> response.setHeader("Content-Length", "0")); + prepareResponse(response -> response.setHeader("Content-Length", "0").setBody("")); ...
true
Other
spring-projects
spring-framework
126ac849e5592f65d742d1f23bf891e1a115af01.json
Fix behavior of ClientResponse#bodyTo** with Void Prior to this commit, asking for a `Void` type using any of the `ClientResponse#bodyTo*` methods would immediately return an empty `Publisher` without consuming the response body. Not doing so can lead to HTTP connection pool inconsistencies and/or memory leaks, since...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientMockTests.java
@@ -1,53 +0,0 @@ -package org.springframework.web.reactive.function.client; - -import org.junit.Before; -import org.junit.Test; -import reactor.core.publisher.Mono; -import reactor.test.StepVerifier; - -import org.springframework.http.HttpHeaders; -import org.springframework.http.HttpStatus; -import org.springframework...
true
Other
spring-projects
spring-framework
95b83fe1ba774e5e54b3ac9ab05ef811aa0b4ec0.json
Add zero copy support in reactor-based WebClient This commit makes Reactor Netty `WebClient` instances support zero-copy requests by implementing `ZeroCopyHttpOutputMessage`. The implementation leverages the optimized `sendFile` mechanism if available.
spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpRequest.java
@@ -16,6 +16,7 @@ package org.springframework.http.client.reactive; +import java.io.File; import java.net.URI; import java.util.Collection; @@ -30,6 +31,7 @@ import org.springframework.core.io.buffer.DataBufferFactory; import org.springframework.core.io.buffer.NettyDataBufferFactory; import org.springframew...
false
Other
spring-projects
spring-framework
d742fc198abc8fee8477cea2d5761649b8ac40e3.json
Add consumeWith to FluxExchangeResult Issue: SPR-15959
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java
@@ -34,6 +34,7 @@ import org.springframework.core.ParameterizedTypeReference; import org.springframework.core.io.ByteArrayResource; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.http.Media...
true
Other
spring-projects
spring-framework
d742fc198abc8fee8477cea2d5761649b8ac40e3.json
Add consumeWith to FluxExchangeResult Issue: SPR-15959
spring-test/src/main/java/org/springframework/test/web/reactive/server/FluxExchangeResult.java
@@ -17,6 +17,7 @@ package org.springframework.test.web.reactive.server; import java.time.Duration; +import java.util.function.Consumer; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; @@ -97,4 +98,23 @@ public byte[] getResponseBodyContent() { .block(); } + /** + * Invoke the g...
true
Other
spring-projects
spring-framework
d742fc198abc8fee8477cea2d5761649b8ac40e3.json
Add consumeWith to FluxExchangeResult Issue: SPR-15959
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -29,6 +29,7 @@ import org.springframework.context.ApplicationContext; import org.springframework.core.ParameterizedTypeReference; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.format.FormatterRegistry; import org.springframework.http.HttpHeaders; import org.springframework....
true
Other
spring-projects
spring-framework
132022861e635736e2d4ab0f95247ad10cc39cc0.json
Remove ResourceServlet deprecated in 4.3.x Issue: SPR-15984
spring-webmvc/src/main/java/org/springframework/web/servlet/ResourceServlet.java
@@ -1,346 +0,0 @@ -/* - * Copyright 2002-2017 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
false
Other
spring-projects
spring-framework
60f47f44894ea405e9425a34f5a4a53c8ca1cacc.json
Fix memory leak in reactive multipart parser
spring-web/src/main/java/org/springframework/http/codec/multipart/SynchronossPartHttpMessageReader.java
@@ -139,6 +139,9 @@ public void accept(FluxSink<Part> emitter) { catch (IOException ex) { listener.onError("Exception thrown providing input to the parser", ex); } + finally { + DataBufferUtils.release(buffer); + } }, (ex) -> { try { listener.onError("Request body input error", ...
false
Other
spring-projects
spring-framework
2841ef5d05a1070e517c5c2b03f6e9ee60983b0f.json
Introduce RouterFunction visitor This commit introduces a visitor for router functions (RouterFunctions.Visitor), allowing to iterate over all the components that make up a router function. This commit also introduces a ToStringVisitor, which creates a nicely formatted string for use with toString(). Issue: SPR-1571...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/PathResourceLookupFunction.java
@@ -155,4 +155,8 @@ else if (resource instanceof ClassPathResource) { return true; } + @Override + public String toString() { + return String.format("%s -> %s", this.pattern, this.location); + } }
true
Other
spring-projects
spring-framework
2841ef5d05a1070e517c5c2b03f6e9ee60983b0f.json
Introduce RouterFunction visitor This commit introduces a visitor for router functions (RouterFunctions.Visitor), allowing to iterate over all the components that make up a router function. This commit also introduces a ToStringVisitor, which creates a nicely formatted string for use with toString(). Issue: SPR-1571...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunction.java
@@ -47,8 +47,7 @@ * @see #andOther(RouterFunction) */ default RouterFunction<T> and(RouterFunction<T> other) { - return request -> this.route(request) - .switchIfEmpty(Mono.defer(() -> other.route(request))); + return new RouterFunctions.SameComposedRouterFunction<>(this, other); } /** @@ -61,10 +60,...
true
Other
spring-projects
spring-framework
2841ef5d05a1070e517c5c2b03f6e9ee60983b0f.json
Introduce RouterFunction visitor This commit introduces a visitor for router functions (RouterFunctions.Visitor), allowing to iterate over all the components that make up a router function. This commit also introduces a ToStringVisitor, which creates a nicely formatted string for use with toString(). Issue: SPR-1571...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -150,7 +150,7 @@ public static RouterFunction<ServerResponse> resources(String pattern, Resource */ public static RouterFunction<ServerResponse> resources(Function<ServerRequest, Mono<Resource>> lookupFunction) { Assert.notNull(lookupFunction, "'lookupFunction' must not be null"); - return request -> lookup...
true
Other
spring-projects
spring-framework
2841ef5d05a1070e517c5c2b03f6e9ee60983b0f.json
Introduce RouterFunction visitor This commit introduces a visitor for router functions (RouterFunctions.Visitor), allowing to iterate over all the components that make up a router function. This commit also introduces a ToStringVisitor, which creates a nicely formatted string for use with toString(). Issue: SPR-1571...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ToStringVisitor.java
@@ -0,0 +1,91 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
2841ef5d05a1070e517c5c2b03f6e9ee60983b0f.json
Introduce RouterFunction visitor This commit introduces a visitor for router functions (RouterFunctions.Visitor), allowing to iterate over all the components that make up a router function. This commit also introduces a ToStringVisitor, which creates a nicely formatted string for use with toString(). Issue: SPR-1571...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/RouterFunctionMapping.java
@@ -102,8 +102,8 @@ protected void initRouterFunctions() { List<RouterFunction<?>> routerFunctions = routerFunctions(); if (!CollectionUtils.isEmpty(routerFunctions) && logger.isInfoEnabled()) { - routerFunctions.forEach(routerFunction1 -> { - logger.info("Mapped " + routerFunction1); + routerFunctions.f...
true
Other
spring-projects
spring-framework
d8e52c04135474821d5d063d75a37ef1ea4f56b0.json
Refine BeanUtils#findPrimaryConstructor behavior Issue: SPR-15673
spring-beans/src/main/java/org/springframework/beans/BeanUtils.java
@@ -332,9 +332,12 @@ else if (!method.isBridge() && targetMethod.getParameterCount() == numParams) { } /** - * Return the primary constructor of the provided class (single or default constructor - * for Java classes and primary constructor for Kotlin classes), if any. - * @param clazz the {@link Class} of the ...
true
Other
spring-projects
spring-framework
d8e52c04135474821d5d063d75a37ef1ea4f56b0.json
Refine BeanUtils#findPrimaryConstructor behavior Issue: SPR-15673
spring-beans/src/test/kotlin/org/springframework/beans/BeanUtilsKotlinTests.kt
@@ -24,6 +24,7 @@ import org.junit.Test * * @author Sebastien Deleuze */ +@Suppress("unused", "UNUSED_PARAMETER") class BeanUtilsKotlinTests { @Test @@ -65,10 +66,54 @@ class BeanUtilsKotlinTests { assertEquals(12, baz.param2) } + @Test + fun `2 constructors with default one`() { + assertEquals(TwoC...
true
Other
spring-projects
spring-framework
78434c8e2043e18040ea8a57868b2cee46fbd8a5.json
Release DataBuffers in FreeMarkerView When template processing throws an exception, we must ensure that `DataBuffers` are properly released to avoid memory leaks. Issue: SPR-15966
spring-webflux/src/main/java/org/springframework/web/reactive/result/view/freemarker/FreeMarkerView.java
@@ -41,6 +41,7 @@ import org.springframework.context.ApplicationContextException; import org.springframework.context.i18n.LocaleContextHolder; import org.springframework.core.io.buffer.DataBuffer; +import org.springframework.core.io.buffer.DataBufferUtils; import org.springframework.http.MediaType; import org.spri...
false
Other
spring-projects
spring-framework
6c4a103f70e4b79856aacb6f6c0cd9a4b9e5d2c1.json
Remove support for generics nullability for now See https://github.com/Kotlin/KEEP/issues/79
spring-core/src/main/java/org/springframework/lang/NonNull.java
@@ -30,15 +30,13 @@ * Leverages JSR 305 meta-annotations to indicate nullability in Java to common tools with * JSR 305 support and used by Kotlin to infer nullability of Spring API. * - * <p>Should be used at generic type argument, parameter, return value, and field level. + * <p>Should be used at parameter, ret...
true
Other
spring-projects
spring-framework
6c4a103f70e4b79856aacb6f6c0cd9a4b9e5d2c1.json
Remove support for generics nullability for now See https://github.com/Kotlin/KEEP/issues/79
spring-core/src/main/java/org/springframework/lang/NonNullApi.java
@@ -30,15 +30,9 @@ * Leverages JSR 305 meta-annotations to indicate nullability in Java to common tools with * JSR 305 support and used by Kotlin to infer nullability of Spring API. * - * * <p>Should be used at package level in association with {@link Nullable} * annotations at parameter and return value leve...
true
Other
spring-projects
spring-framework
6c4a103f70e4b79856aacb6f6c0cd9a4b9e5d2c1.json
Remove support for generics nullability for now See https://github.com/Kotlin/KEEP/issues/79
spring-core/src/main/java/org/springframework/lang/NonNullFields.java
@@ -34,11 +34,6 @@ * <p>Should be used at package level in association with {@link Nullable} * annotations at field level. * - * <p>This annotation does not define nullability of generic type arguments, because - * {@code @TypeQualifierDefault(ElementType.TYPE_USE)} scope would be too broad. - * As a consequence,...
true
Other
spring-projects
spring-framework
6c4a103f70e4b79856aacb6f6c0cd9a4b9e5d2c1.json
Remove support for generics nullability for now See https://github.com/Kotlin/KEEP/issues/79
spring-core/src/main/java/org/springframework/lang/Nullable.java
@@ -30,7 +30,7 @@ * some circumstance. Leverages JSR 305 meta-annotations to indicate nullability in Java * to common tools with JSR 305 support and used by Kotlin to infer nullability of Spring API. * - * <p>Should be used at generic type argument, parameter, return value, and field level. + * <p>Should be used ...
true
Other
spring-projects
spring-framework
6c4a103f70e4b79856aacb6f6c0cd9a4b9e5d2c1.json
Remove support for generics nullability for now See https://github.com/Kotlin/KEEP/issues/79
src/docs/asciidoc/kotlin.adoc
@@ -111,12 +111,8 @@ the default behavior in an upcoming release of Kotlin. [NOTE] ==== -Make sure to https://github.com/sdeleuze/spring-kotlin-functional/blob/2d6ac07adfc2b8f25e91681dbb2b58a1c6cdf9a7/build.gradle.kts#L57[include JSR-305 JAR] -until Kotlin 1.1.5 is released (it will fix https://youtrack.jetbrains.c...
true
Other
spring-projects
spring-framework
819ca0dbd40cccd4eae0353ff0b9aeaf248d3ab6.json
Expose getters for the configured HandlerMapping's Issue: SPR-15934
spring-webflux/src/main/java/org/springframework/web/reactive/DispatcherHandler.java
@@ -91,17 +91,29 @@ public DispatcherHandler(ApplicationContext applicationContext) { } + /** + * Return all {@link HandlerMapping} beans detected by type in the + * {@link #setApplicationContext injected context} and also + * {@link AnnotationAwareOrderComparator#sort(List) sorted}. + * @return immutable lis...
true
Other
spring-projects
spring-framework
819ca0dbd40cccd4eae0353ff0b9aeaf248d3ab6.json
Expose getters for the configured HandlerMapping's Issue: SPR-15934
spring-webmvc/src/main/java/org/springframework/web/servlet/DispatcherServlet.java
@@ -770,6 +770,19 @@ private void initFlashMapManager(ApplicationContext context) { } } + /** + * Return the configured {@link HandlerMapping} beans that were detected by + * type in the {@link WebApplicationContext} or initialized based on the + * default set of strategies from {@literal DispatcherServlet.pr...
true
Other
spring-projects
spring-framework
dba1ef0b264c0251078f0558d09fff261c18d348.json
Fix Javadoc typo Closes gh-1531
spring-context/src/main/java/org/springframework/validation/Errors.java
@@ -172,7 +172,7 @@ void rejectValue(@Nullable String field, String errorCode, /** * Add all errors from the given {@code Errors} instance to this * {@code Errors} instance. - * <p>This is a onvenience method to avoid repeated {@code reject(..)} + * <p>This is a convenience method to avoid repeated {@code rej...
false
Other
spring-projects
spring-framework
cf812ba8313f905f42752342fc9a64b177bc87dc.json
Reference docs: improve async request content
src/docs/asciidoc/web/webflux.adoc
@@ -1096,9 +1096,9 @@ or as an `@ModelAttribute` otherwise. ==== Return values [.small]#<<web.adoc#mvc-ann-return-types,Same in Spring MVC>># -The table below shows supported controller method return values. Reactive types -- -Reactor, RxJava, <<webflux-reactive-libraries,or other>> are supported for all return -va...
true
Other
spring-projects
spring-framework
cf812ba8313f905f42752342fc9a64b177bc87dc.json
Reference docs: improve async request content
src/docs/asciidoc/web/webmvc.adoc
@@ -1592,12 +1592,14 @@ ETag or lastModified timestamp check (see <<mvc-caching-etag-lastmodified>> for If none of the above is true, a `void` return type may also indicate "no response body" for REST controllers, or default view name selection for HTML controllers. -|`Callable<V>` -|Produce any of the above return...
true
Other
spring-projects
spring-framework
826db885093360e8dd27f3ef566c392af1e01aa9.json
Remove an unnecessary intermediate variable See gh-1650
spring-web/src/main/java/org/springframework/web/filter/AbstractRequestLoggingFilter.java
@@ -327,20 +327,19 @@ protected String createMessage(HttpServletRequest request, String prefix, String protected String getMessagePayload(HttpServletRequest request) { ContentCachingRequestWrapper wrapper = WebUtils.getNativeRequest(request, ContentCachingRequestWrapper.class); - String payload = null; if...
false
Other
spring-projects
spring-framework
3f3141cddaf878d635318750b49f54147012a137.json
Add additional test for SPR-16210 Issue: SPR-16210
spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java
@@ -64,6 +64,7 @@ * * @author Phillip Webb * @author Juergen Hoeller + * @author Sebastien Deleuze */ @SuppressWarnings("rawtypes") @RunWith(MockitoJUnitRunner.class) @@ -261,6 +262,19 @@ public void forMethodParameterMustNotBeNull() throws Exception { ResolvableType.forMethodParameter(null); } + @Test...
false
Other
spring-projects
spring-framework
646fcc5c2faf3df5905f7b1b5a62b4abd97a5d34.json
Support Custom Headers for Multipart Async Data This commit makes sure there is no custom Content-Disposition header before setting one automatically. This commit also adds a headers(Consumer<HttpHeaders>) method, so that one can user the nicer methods of HttpHeaders, as opposed to basic strings. Issue: SPR-16376
spring-web/src/main/java/org/springframework/http/client/MultipartBodyBuilder.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,6 +19,7 @@ import java.util.Arrays; im...
true
Other
spring-projects
spring-framework
646fcc5c2faf3df5905f7b1b5a62b4abd97a5d34.json
Support Custom Headers for Multipart Async Data This commit makes sure there is no custom Content-Disposition header before setting one automatically. This commit also adds a headers(Consumer<HttpHeaders>) method, so that one can user the nicer methods of HttpHeaders, as opposed to basic strings. Issue: SPR-16376
spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -229,12 +229,13 @@ private Flux<DataBuffer> ...
true
Other
spring-projects
spring-framework
646fcc5c2faf3df5905f7b1b5a62b4abd97a5d34.json
Support Custom Headers for Multipart Async Data This commit makes sure there is no custom Content-Disposition header before setting one automatically. This commit also adds a headers(Consumer<HttpHeaders>) method, so that one can user the nicer methods of HttpHeaders, as opposed to basic strings. Issue: SPR-16376
spring-web/src/test/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriterTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -32,6 +32,9 @@ import org.springframework.c...
true
Other
spring-projects
spring-framework
283811b16b3b568230ace382f9d16c1c6b662b7a.json
Ensure filename is written Now that SPR-16307 makes it possible to write a part with a Publisher we need to ensure we get the filename correctly when writing with Publisher<Resource>. Issue: SPR-16376
spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriter.java
@@ -252,8 +252,17 @@ private <T> Flux<DataBuffer> encodePart(byte[] boundary, String name, T value) { resolvableType = ResolvableType.forClass(body.getClass()); } - String filename = (body instanceof Resource ? ((Resource) body).getFilename() : null); - outputMessage.getHeaders().setContentDispositionFormDat...
true
Other
spring-projects
spring-framework
283811b16b3b568230ace382f9d16c1c6b662b7a.json
Ensure filename is written Now that SPR-16307 makes it possible to write a part with a Publisher we need to ensure we get the filename correctly when writing with Publisher<Resource>. Issue: SPR-16376
spring-web/src/test/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriterTests.java
@@ -170,9 +170,8 @@ public void singleSubscriberWithResource() throws IOException { Part part = requestParts.getFirst("logo"); assertEquals("logo", part.name()); -// TODO: a Resource written as an async part doesn't have a file name in the contentDisposition -// assertTrue(part instanceof FilePart); -// asser...
true
Other
spring-projects
spring-framework
aea6bb635720fef98659162c447ce27679714d67.json
Update STOMP docs on using dot as separator Issue: SPR-16275
src/docs/asciidoc/web/websocket.adoc
@@ -1470,10 +1470,10 @@ cloud-based STOMP service. [[websocket-stomp-destination-separator]] === Dot as Separator -Although slash-separated path patterns are familiar to web developers, in messaging -it is common to use a "." as the separator, for example in the names of topics, queues, -exchanges, etc. Application...
false
Other
spring-projects
spring-framework
357fb48d1373ade92814cc46a95db89c7902ce91.json
Update docs on stomp.js library Issue: SPR-15624
src/docs/asciidoc/web/websocket.adoc
@@ -1043,16 +1043,20 @@ check the STOMP page of the broker to understand what kind of STOMP destinations prefixes it supports. ==== - -On the browser side, a client might connect as follows using -https://github.com/jmesnil/stomp-websocket[stomp.js] and the -https://github.com/sockjs/sockjs-client[sockjs-client]: +...
false
Other
spring-projects
spring-framework
513461d4f1d324b69697c88054a6cb3979f6431f.json
Update STOMP overview Issue: SPR-15624
src/docs/asciidoc/web/websocket.adoc
@@ -850,23 +850,23 @@ Consider also customizing these server-side SockJS related properties (see Javad == STOMP The WebSocket protocol defines two types of messages, text and binary, but their -content is undefined. It's expected that the client and server may agree on using -a sub-protocol (i.e. a higher-level pro...
false
Other
spring-projects
spring-framework
fed81c6f83c0b24538371fd092a71e128d86ccbc.json
Fix doc typo Closes gh-1646
src/docs/asciidoc/web/webflux.adoc
@@ -994,7 +994,7 @@ request and session attributes, `checkNotModified` methods, and others. |Access to the HTTP request or response. |`WebSession` -|Access to the session; this does not forcing the start of a new session unless attributes +|Access to the session; this does not force the start of a new session unles...
false