language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
df9761cb3f2e4a3bf47ca3aee67ce8fc2b64fd3a.json
Fix doc typo Closes gh-1645
src/docs/asciidoc/web/webflux.adoc
@@ -868,7 +868,7 @@ content type other than "text/plain". You can declare a shared consumes attribute at the class level. Unlike most other request mapping attributes however when used at the class level, a method-level consumes attribute -will overrides rather than extend the class level declaration. +overrides ra...
false
Other
spring-projects
spring-framework
09b0364ad7773dc8b541e9daa0c9e7ec9cd2037c.json
Upgrade Kotlin to 1.1.2-eap-73
build.gradle
@@ -1,5 +1,5 @@ buildscript { - ext.kotlinVersion = '1.1.2-eap-69' + ext.kotlinVersion = '1.1.2-eap-73' repositories { maven { url "https://repo.spring.io/plugins-release" } maven { url "https://dl.bintray.com/kotlin/kotlin-eap-1.1" }
false
Other
spring-projects
spring-framework
4ffdb50681a9e4c81ccb1d1eb46ace804a3af0ad.json
Reuse QosSettings in JmsTemplate See SPR-15408
spring-jms/src/main/java/org/springframework/jms/core/JmsTemplate.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -34,6 +34,7 @@ import org.springframework.j...
true
Other
spring-projects
spring-framework
4ffdb50681a9e4c81ccb1d1eb46ace804a3af0ad.json
Reuse QosSettings in JmsTemplate See SPR-15408
spring-jms/src/test/java/org/springframework/jms/core/JmsTemplateTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -53,6 +53,7 @@ import org.springframework.j...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/config/AbstractJmsListenerContainerFactory.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,6 +22,7 @@ import org.apache.commons.lo...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/config/MethodJmsListenerEndpoint.java
@@ -28,6 +28,7 @@ import org.springframework.core.annotation.AnnotatedElementUtils; import org.springframework.jms.listener.MessageListenerContainer; import org.springframework.jms.listener.adapter.MessagingMessageListenerAdapter; +import org.springframework.jms.support.QosSettings; import org.springframework.jms.s...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/listener/AbstractMessageListenerContainer.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -30,6 +30,7 @@ import javax.jms.Topic; i...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/listener/MessageListenerContainer.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,6 +17,7 @@ package org.springframework....
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/listener/adapter/AbstractAdaptableMessageListener.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -31,6 +31,7 @@ import org.springframework.j...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/listener/endpoint/JmsActivationSpecConfig.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,6 +19,7 @@ import javax.jms.Session; ...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/listener/endpoint/JmsMessageEndpointManager.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,6 +22,7 @@ import org.springframework.b...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/main/java/org/springframework/jms/support/QosSettings.java
@@ -0,0 +1,135 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/test/java/org/springframework/jms/config/JmsListenerContainerFactoryTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -34,6 +34,7 @@ import org.springframework.j...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/test/java/org/springframework/jms/config/MessageListenerTestContainer.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,7 @@ import org.springframework.b...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/test/java/org/springframework/jms/config/MethodJmsListenerEndpointTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -47,6 +47,7 @@ import org.springframework.j...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/test/java/org/springframework/jms/listener/adapter/MessagingMessageListenerAdapterTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,6 +19,7 @@ import java.lang.reflect.Met...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
spring-jms/src/test/java/org/springframework/jms/listener/endpoint/JmsMessageEndpointManagerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,8 @@ import org.junit.Test; impo...
true
Other
spring-projects
spring-framework
1c0b3be6e60af5704a0d0ac6e119d620fe84b0f4.json
Customize QosSettings for JMS replies This commit introduces QosSettings that gather the Qualify of Service settings one can use when sending a message. Such object can now be associated to any JMS endpoint that allows to send a reply as part of the processing of an incoming message. Issue: SPR-15408
src/docs/asciidoc/integration.adoc
@@ -2793,6 +2793,29 @@ example can be rewritten as follows: } ---- +Finally if you need to specify some QoS values for the response such as the priority or +the time to live, you can configure the `JmsListenerContainerFactory` accordingly: + +[source,java,indent=0] +[subs="verbatim,quotes"] +---- + @Configuration ...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
build.gradle
@@ -712,9 +712,6 @@ project("spring-web") { optional("org.reactivestreams:reactive-streams") optional("io.projectreactor:reactor-core") optional("io.projectreactor.ipc:reactor-netty") - optional("io.reactivex:rxnetty-http:${rxnettyVersion}") { - exclude group: 'io.reactivex', module: 'rxjava' - } option...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-web/src/main/java/org/springframework/http/server/reactive/package-info.java
@@ -5,6 +5,6 @@ * {@link org.springframework.http.server.reactive.HttpHandler} for processing. * * <p>Also provides implementations adapting to different runtimes - * including Servlet 3.1 containers, Netty + Reactor IO or RxNetty, and Undertow. + * including Servlet 3.1 containers, Netty + Reactor IO, and Undert...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-web/src/test/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java
@@ -36,6 +36,7 @@ /** * Adapt {@link HttpHandler} to the RxNetty {@link RequestHandler}. + * For internal use within the framework. * * @author Rossen Stoyanchev * @since 5.0
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-web/src/test/java/org/springframework/http/server/reactive/RxNettyServerHttpRequest.java
@@ -39,6 +39,7 @@ /** * Adapt {@link ServerHttpRequest} to the RxNetty {@link HttpServerRequest}. + * For internal use within the framework. * * @author Rossen Stoyanchev * @author Stephane Maldini
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-web/src/test/java/org/springframework/http/server/reactive/RxNettyServerHttpResponse.java
@@ -38,7 +38,8 @@ /** * Adapt {@link ServerHttpResponse} to the RxNetty {@link HttpServerResponse}. - * + * For internal use within the framework. + * * @author Rossen Stoyanchev * @author Stephane Maldini * @author Sebastien Deleuze
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/main/java/org/springframework/web/reactive/DispatcherHandler.java
@@ -183,7 +183,6 @@ public static WebHandler toWebHandler(ApplicationContext applicationContext) { * @see HttpWebHandlerAdapter * @see org.springframework.http.server.reactive.ServletHttpHandlerAdapter * @see org.springframework.http.server.reactive.ReactorHttpHandlerAdapter - * @see org.springframework.http....
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -46,7 +46,7 @@ * * <p>Additionally, this class can {@linkplain #toHttpHandler(RouterFunction) transform} a * {@code RouterFunction} into an {@code HttpHandler}, which can be run in Servlet 3.1+, - * Reactor, RxNetty, or Undertow. + * Reactor, or Undertow. * And it can {@linkplain #toHandlerMapping(RouterFunc...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/support/HandshakeWebSocketService.java
@@ -67,10 +67,6 @@ public class HandshakeWebSocketService implements WebSocketService, Lifecycle { "reactor.ipc.netty.http.server.HttpServerResponse", HandshakeWebSocketService.class.getClassLoader()); - private static final boolean rxNettyPresent = ClassUtils.isPresent( - "io.reactivex.netty.protocol.http....
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/test/java/org/springframework/web/reactive/socket/adapter/RxNettyWebSocketSession.java
@@ -39,7 +39,8 @@ /** * Spring {@link WebSocketSession} implementation that adapts to the RxNetty * {@link io.reactivex.netty.protocol.http.ws.WebSocketConnection}. - * + * For internal use within the framework. + * * @author Rossen Stoyanchev * @since 5.0 */
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/test/java/org/springframework/web/reactive/socket/client/RxNettyWebSocketClient.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -47,7 +47,8 @@ /** * {@link WebSocketCl...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
spring-webflux/src/test/java/org/springframework/web/reactive/socket/server/upgrade/RxNettyRequestUpgradeStrategy.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -35,6 +35,7 @@ /** * A {@link RequestUp...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
src/docs/asciidoc/web/web-flux-functional.adoc
@@ -177,7 +177,7 @@ Now there is just one piece of the puzzle missing: running a router function in You can convert a router function into a `HttpHandler` by using `RouterFunctions.toHttpHandler(RouterFunction)`. The `HttpHandler` allows you to run on a wide variety of reactive runtimes: Reactor Netty, -RxNetty, Ser...
true
Other
spring-projects
spring-framework
a8d785b87fb2e662c0ad931a11dbf37489565f39.json
Move RxNetty support to test scope The RxNetty runtime support is not meant to be officially supported and should be restricted to testing purposes only. Issue: SPR-15444
src/docs/asciidoc/web/web-flux.adoc
@@ -223,7 +223,7 @@ default as following: WebFlux includes reactive WebSocket client and server support. Both client and server are supported on the Java WebSocket API -(JSR-356), Jetty, Undertow, Reactor Netty, and RxNetty. +(JSR-356), Jetty, Undertow, and Reactor Netty. On the server side, declare a `WebSocket...
true
Other
spring-projects
spring-framework
fce8ed62cef7df6aaffe5699dc64bf1a0c4faf3a.json
Update @ControllerAdvice Javadoc Issue: SPR-15432
spring-web/src/main/java/org/springframework/web/bind/annotation/ControllerAdvice.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -26,28 +26,32 @@ import org.springframework...
false
Other
spring-projects
spring-framework
987421c880585c244d19bebea56bf26779ce97da.json
Add dependency on JUnit Platform Launcher for IDEA This commit introduces an explicit dependency on the latest JUnit Platform Launcher API so that it overrides whatever is bundled by default in IntelliJ IDEA. This allows a more seamless upgrade to newer versions of JUnit 5 and the JUnit Platform before IDEA has been ...
build.gradle
@@ -1084,6 +1084,9 @@ project("spring-test") { testCompile('de.bechte.junit:junit-hierarchicalcontextrunner:4.12.1') testCompile('io.projectreactor.ipc:reactor-netty') testRuntime("org.junit.jupiter:junit-jupiter-engine:${junitJupiterVersion}") + // Pull in the latest Launcher API so that it overrides whateve...
false
Other
spring-projects
spring-framework
9a501fac46a9e4879ba8d72360ad1713169f2d8e.json
Fix failing tests Issue: SPR-14925
spring-web/src/test/java/org/springframework/http/codec/json/Jackson2JsonDecoderTests.java
@@ -21,6 +21,8 @@ import static java.util.Arrays.asList; import static java.util.Collections.*; + +import com.fasterxml.jackson.databind.ObjectMapper; import org.junit.Test; import static org.springframework.core.ResolvableType.forClass; @@ -163,10 +165,10 @@ public void decodeEmptyBodyToMono() throws Exception...
false
Other
spring-projects
spring-framework
b6490419764525fa427368d4068eb1e1de676060.json
Add ServerHttpResponse.addCookie method This commit adds a `addCookie(ResponseCookie)` method to the reactive `ServerHttpResponse` interface. Issue: SPR-15523
spring-test/src/test/java/org/springframework/test/web/reactive/server/HttpHandlerConnectorTests.java
@@ -84,7 +84,7 @@ public void adaptResponse() throws Exception { TestHttpHandler handler = new TestHttpHandler(response -> { response.setStatusCode(HttpStatus.OK); response.getHeaders().put("custom-header", Arrays.asList("h0", "h1")); - response.getCookies().add(cookie.getName(), cookie); + response.addC...
true
Other
spring-projects
spring-framework
b6490419764525fa427368d4068eb1e1de676060.json
Add ServerHttpResponse.addCookie method This commit adds a `addCookie(ResponseCookie)` method to the reactive `ServerHttpResponse` interface. Issue: SPR-15523
spring-web/src/main/java/org/springframework/http/server/reactive/AbstractServerHttpResponse.java
@@ -120,6 +120,19 @@ public MultiValueMap<String, ResponseCookie> getCookies() { CollectionUtils.unmodifiableMultiValueMap(this.cookies) : this.cookies); } + @Override + public void addCookie(ResponseCookie cookie) { + Assert.notNull(cookie, "'cookie' must not be null"); + + if (this.state.get() == State.COM...
true
Other
spring-projects
spring-framework
b6490419764525fa427368d4068eb1e1de676060.json
Add ServerHttpResponse.addCookie method This commit adds a `addCookie(ResponseCookie)` method to the reactive `ServerHttpResponse` interface. Issue: SPR-15523
spring-web/src/main/java/org/springframework/http/server/reactive/ServerHttpResponse.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -50,6 +50,13 @@ public interface ServerHttpR...
true
Other
spring-projects
spring-framework
b6490419764525fa427368d4068eb1e1de676060.json
Add ServerHttpResponse.addCookie method This commit adds a `addCookie(ResponseCookie)` method to the reactive `ServerHttpResponse` interface. Issue: SPR-15523
spring-web/src/main/java/org/springframework/http/server/reactive/ServerHttpResponseDecorator.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -74,6 +74,11 @@ public MultiValueMap<String,...
true
Other
spring-projects
spring-framework
1c4babd410b88ab7543797d63c7f92fe719dbe00.json
Fix minor issue in ExchangeResult
spring-test/src/main/java/org/springframework/test/web/reactive/server/ExchangeResult.java
@@ -128,7 +128,7 @@ public HttpHeaders getResponseHeaders() { * Return response cookies received from the server. */ public MultiValueMap<String, ResponseCookie> getResponseCookies() { - return this.getResponseCookies(); + return this.response.getCookies(); } /**
false
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-core/src/main/java/org/springframework/core/codec/CodecException.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,18 +19,29 @@ import org.springframework...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-core/src/main/java/org/springframework/core/codec/DecodingException.java
@@ -0,0 +1,52 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-core/src/main/java/org/springframework/core/codec/EncodingException.java
@@ -13,24 +13,35 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.springframework.core.codec; /** - * Codec exception suitable for internal errors, like those not related to invalid data. It can be used to make sure - * such error will ...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/DecoderHttpMessageReader.java
@@ -21,9 +21,6 @@ import java.util.List; import java.util.Map; -import org.springframework.core.codec.InternalCodecException; -import org.springframework.http.HttpStatus; -import org.springframework.web.server.ResponseStatusException; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; @@ -8...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/EncoderHttpMessageWriter.java
@@ -22,14 +22,13 @@ import java.util.Map; import org.reactivestreams.Publisher; -import org.springframework.http.HttpStatus; -import org.springframework.web.server.ResponseStatusException; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; import org.springframework.core.ResolvableType; i...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonDecoder.java
@@ -21,6 +21,7 @@ import java.util.List; import java.util.Map; +import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.JavaType; import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectReader; @@ -32,10 +33,10 @@ import org.spring...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonEncoder.java
@@ -24,6 +24,7 @@ import java.util.List; import java.util.Map; +import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.core.PrettyPrinter; import com.fasterxml.jackson.core.util.DefaultIndenter; import com.fasterxml.jackson.core.util.DefaultPrettyPrinter; @@ -39,6 +40,7 @@ impor...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/xml/Jaxb2XmlDecoder.java
@@ -37,7 +37,7 @@ import org.springframework.core.ResolvableType; import org.springframework.core.codec.AbstractDecoder; -import org.springframework.core.codec.CodecException; +import org.springframework.core.codec.DecodingException; import org.springframework.core.io.buffer.DataBuffer; import org.springframework...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/main/java/org/springframework/http/codec/xml/Jaxb2XmlEncoder.java
@@ -21,13 +21,16 @@ import java.util.Map; import javax.xml.bind.JAXBException; import javax.xml.bind.Marshaller; +import javax.xml.bind.UnmarshalException; import javax.xml.bind.annotation.XmlRootElement; import javax.xml.bind.annotation.XmlType; import reactor.core.publisher.Flux; import org.springframework...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-web/src/test/java/org/springframework/http/codec/json/Jackson2JsonDecoderTests.java
@@ -19,30 +19,31 @@ import java.util.List; import java.util.Map; -import static java.util.Arrays.asList; -import static java.util.Collections.*; - import com.fasterxml.jackson.databind.ObjectMapper; import org.junit.Test; - -import static org.springframework.core.ResolvableType.forClass; -import static org.spring...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractMessageReaderArgumentResolver.java
@@ -17,19 +17,22 @@ package org.springframework.web.reactive.result.method.annotation; import java.lang.annotation.Annotation; +import java.lang.reflect.Method; import java.util.Collections; import java.util.List; import java.util.Map; import java.util.stream.Collectors; -import org.springframework.core.*; -i...
true
Other
spring-projects
spring-framework
83e0e1604a98b20a5fec3754a52101ac3cd3de60.json
Refine encoding/decoding exception handling Starting with removing a package cycle on the use of ResponseStatusException in the codec package, this commit generally refines codec exception handling. The new [Encoding|Decoding]Exception mirror the existing HttpMessageNot[Readable|Writable]Exception and are used simila...
spring-webflux/src/test/java/org/springframework/web/reactive/DispatcherHandlerErrorTests.java
@@ -44,16 +44,17 @@ import org.springframework.web.server.NotAcceptableStatusException; import org.springframework.web.server.ResponseStatusException; import org.springframework.web.server.ServerWebExchange; -import org.springframework.web.server.ServerWebInputException; import org.springframework.web.server.WebExc...
true
Other
spring-projects
spring-framework
afa1c9358594d9701b9f478e9d3aa1a5dc6b06eb.json
Fix error in mock server test code
spring-web/src/test/java/org/springframework/web/client/AbstractMockWebServerTestCase.java
@@ -121,9 +121,9 @@ private MockResponse jsonPostRequest(RecordedRequest request, String location, S } private MockResponse multipartRequest(RecordedRequest request) { - String contentType = request.getHeader("Content-Type"); - assertTrue(contentType.startsWith("multipart/form-data")); - String boundary = cont...
true
Other
spring-projects
spring-framework
afa1c9358594d9701b9f478e9d3aa1a5dc6b06eb.json
Fix error in mock server test code
spring-web/src/test/resources/log4j2-test.xml
@@ -6,7 +6,7 @@ </Console> </Appenders> <Loggers> - <Logger name="org.springframework.web" level="warn" /> + <Logger name="org.springframework.web" level="debug" /> <Logger name="org.springframework.beans" level="warn" /> <Logger name="org.springframework.binding" level="warn" /> <Logger name="org.spr...
true
Other
spring-projects
spring-framework
75117f42b827397890060d2297b79bbc1b0c528c.json
Use the configured charset for part headers This comment extends the use of the charset property in FormHttpMessageConverter to also include multipart headers with a default of UTF-8. We now also set the charset parameter of the "Content-Type" header to indicate to the server side how to decode correctly. Issue: SPR...
spring-web/src/main/java/org/springframework/http/converter/FormHttpMessageConverter.java
@@ -25,6 +25,7 @@ import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.Collections; +import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; @@ -148,10 +149,17 @@ public void addPartConverter(HttpMessageConverter<?> partConverter) { /**...
true
Other
spring-projects
spring-framework
75117f42b827397890060d2297b79bbc1b0c528c.json
Use the configured charset for part headers This comment extends the use of the charset property in FormHttpMessageConverter to also include multipart headers with a default of UTF-8. We now also set the charset parameter of the "Content-Type" header to indicate to the server side how to decode correctly. Issue: SPR...
spring-web/src/test/java/org/springframework/http/converter/FormHttpMessageConverterTests.java
@@ -43,11 +43,17 @@ import org.springframework.util.LinkedMultiValueMap; import org.springframework.util.MultiValueMap; -import static org.hamcrest.CoreMatchers.*; +import static org.hamcrest.CoreMatchers.allOf; import static org.hamcrest.CoreMatchers.endsWith; import static org.hamcrest.CoreMatchers.startsWith; ...
true
Other
spring-projects
spring-framework
bb744574e5fbc5aef1956d35c0f18bb2f4049895.json
Remove optional javax.mail dependency from WebFlux The MultipartHttpMessageWriter now directly encodes part header values defaulting to UTF-8 and also specifies the charset in the Content-Type header for the entire request. This should work with something commonly used like Apache Commons FileUpload which checks requ...
build.gradle
@@ -838,7 +838,6 @@ project("spring-webflux") { testRuntime("org.python:jython-standalone:2.5.3") testRuntime("org.webjars:underscorejs:1.8.3") testRuntime("org.glassfish:javax.el:3.0.1-b08") - testRuntime("com.sun.mail:javax.mail:${javamailVersion}") testRuntime("com.sun.xml.bind:jaxb-core:${jaxbVersion}"...
true
Other
spring-projects
spring-framework
bb744574e5fbc5aef1956d35c0f18bb2f4049895.json
Remove optional javax.mail dependency from WebFlux The MultipartHttpMessageWriter now directly encodes part header values defaulting to UTF-8 and also specifies the charset in the Content-Type header for the entire request. This should work with something commonly used like Apache Commons FileUpload which checks requ...
spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriter.java
@@ -16,18 +16,17 @@ package org.springframework.http.codec.multipart; -import java.io.UnsupportedEncodingException; import java.nio.charset.Charset; import java.nio.charset.StandardCharsets; import java.util.Arrays; import java.util.Collections; +import java.util.HashMap; import java.util.List; import java.u...
true
Other
spring-projects
spring-framework
bb744574e5fbc5aef1956d35c0f18bb2f4049895.json
Remove optional javax.mail dependency from WebFlux The MultipartHttpMessageWriter now directly encodes part header values defaulting to UTF-8 and also specifies the charset in the Content-Type header for the entire request. This should work with something commonly used like Apache Commons FileUpload which checks requ...
spring-web/src/main/java/org/springframework/http/codec/multipart/SynchronossPartHttpMessageReader.java
@@ -282,7 +282,9 @@ protected StreamStorage getStorage() { private static class SynchronossFilePart extends DefaultSynchronossPart implements FilePart { - public SynchronossFilePart(HttpHeaders headers, StreamStorage storage, String fileName, DataBufferFactory factory) { + public SynchronossFilePart(HttpHeaders...
true
Other
spring-projects
spring-framework
bb744574e5fbc5aef1956d35c0f18bb2f4049895.json
Remove optional javax.mail dependency from WebFlux The MultipartHttpMessageWriter now directly encodes part header values defaulting to UTF-8 and also specifies the charset in the Content-Type header for the entire request. This should work with something commonly used like Apache Commons FileUpload which checks requ...
spring-web/src/test/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriterTests.java
@@ -101,15 +101,15 @@ public String getFilename() { Map<String, Object> hints = Collections.emptyMap(); this.writer.write(Mono.just(map), null, MediaType.MULTIPART_FORM_DATA, response, hints).block(); - final MediaType contentType = response.getHeaders().getContentType(); + MediaType contentType = response.ge...
true
Other
spring-projects
spring-framework
4525c6a5371dbae3a618b54d2b0393d97a1529b7.json
Add support for Flux<Part> in BodyExtractors This commit adds a `toParts` method in `BodyExtractors`, returning a BodyExtractor<Part>.
spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyExtractors.java
@@ -48,12 +48,14 @@ */ public abstract class BodyExtractors { - private static final ResolvableType FORM_TYPE = + private static final ResolvableType FORM_MAP_TYPE = ResolvableType.forClassWithGenerics(MultiValueMap.class, String.class, String.class); - private static final ResolvableType MULTIPART_TYPE = Re...
true
Other
spring-projects
spring-framework
4525c6a5371dbae3a618b54d2b0393d97a1529b7.json
Add support for Flux<Part> in BodyExtractors This commit adds a `toParts` method in `BodyExtractors`, returning a BodyExtractor<Part>.
spring-webflux/src/test/java/org/springframework/web/reactive/function/BodyExtractorsTests.java
@@ -36,6 +36,8 @@ import org.springframework.core.codec.ByteBufferDecoder; import org.springframework.core.codec.StringDecoder; +import org.springframework.core.io.ClassPathResource; +import org.springframework.core.io.Resource; import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core...
true
Other
spring-projects
spring-framework
4525c6a5371dbae3a618b54d2b0393d97a1529b7.json
Add support for Flux<Part> in BodyExtractors This commit adds a `toParts` method in `BodyExtractors`, returning a BodyExtractor<Part>.
spring-webflux/src/test/java/org/springframework/web/reactive/function/MultipartIntegrationTests.java
@@ -16,6 +16,7 @@ package org.springframework.web.reactive.function; +import java.util.List; import java.util.Map; import org.junit.Test; @@ -48,10 +49,25 @@ public class MultipartIntegrationTests extends AbstractRouterFunctionIntegration private final WebClient webClient = WebClient.create(); @Test - pu...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/main/java/org/springframework/http/codec/DefaultServerCodecConfigurer.java
@@ -21,7 +21,8 @@ import org.springframework.core.codec.Encoder; import org.springframework.core.codec.StringDecoder; import org.springframework.http.codec.json.Jackson2JsonEncoder; -import org.springframework.http.codec.multipart.SynchronossMultipartHttpMessageReader; +import org.springframework.http.codec.multipar...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartHttpMessageReader.java
@@ -0,0 +1,100 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/main/java/org/springframework/http/codec/multipart/SynchronossPartHttpMessageReader.java
@@ -25,15 +25,12 @@ import java.nio.channels.ReadableByteChannel; import java.nio.charset.Charset; import java.nio.charset.StandardCharsets; -import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.List; import java.util.Map; import java.util.Optional; import jav...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/test/java/org/springframework/http/codec/ServerCodecConfigurerTests.java
@@ -41,7 +41,8 @@ import org.springframework.http.MediaType; import org.springframework.http.codec.json.Jackson2JsonDecoder; import org.springframework.http.codec.json.Jackson2JsonEncoder; -import org.springframework.http.codec.multipart.SynchronossMultipartHttpMessageReader; +import org.springframework.http.codec.m...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/test/java/org/springframework/http/codec/multipart/MultipartHttpMessageWriterTests.java
@@ -102,7 +102,9 @@ public String getFilename() { assertNotNull("No boundary found", contentType.getParameter("boundary")); // see if Synchronoss NIO Multipart can read what we wrote - SynchronossMultipartHttpMessageReader reader = new SynchronossMultipartHttpMessageReader(); + SynchronossPartHttpMessageReade...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-web/src/test/java/org/springframework/http/codec/multipart/SynchronossPartHttpMessageReaderTests.java
@@ -32,53 +32,57 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.MediaType; import org.springframework.http.MockHttpOutputMessage; -import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.converter.FormHttpMessageConverter; import org.springframework...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-webflux/src/test/java/org/springframework/web/reactive/config/DelegatingWebFluxConfigurationTests.java
@@ -103,7 +103,7 @@ public void requestMappingHandlerAdapter() throws Exception { verify(webFluxConfigurer).configureArgumentResolvers(any()); assertSame(formatterRegistry.getValue(), initializerConversionService); - assertEquals(10, codecsConfigurer.getValue().getReaders().size()); + assertEquals(11, codecsC...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-webflux/src/test/java/org/springframework/web/reactive/config/WebFluxConfigurationSupportTests.java
@@ -127,7 +127,7 @@ public void requestMappingHandlerAdapter() throws Exception { assertNotNull(adapter); List<HttpMessageReader<?>> readers = adapter.getMessageCodecConfigurer().getReaders(); - assertEquals(10, readers.size()); + assertEquals(11, readers.size()); assertHasMessageReader(readers, forClass...
true
Other
spring-projects
spring-framework
b5089ac09208daa12b19b06924eff95b670eb764.json
Support @RequestBody Flux<Part> in WebFlux This commit turns the Synchronoss NIO Multipart HttpMessageReader into a reader of Flux<Part> and creates a separate reader that aggregates the parts into a MultiValueMap<String, Part>. Issue: SPR-14546
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/MultipartIntegrationTests.java
@@ -16,8 +16,12 @@ package org.springframework.web.reactive.result.method.annotation; +import java.util.Map; +import java.util.stream.Collectors; + import org.junit.Before; import org.junit.Test; +import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; import reactor.test.StepVerifier; @@ -35...
true
Other
spring-projects
spring-framework
ed4bd43cacebf2d001a1d0b66b67ad5141499be1.json
Add writableChannel to WritableResource This commit introduces a `writableChannel()` method to `WritableResource`, defaulting to `Channels.newChannel`, but with overrides for file-based resources.
spring-core/src/main/java/org/springframework/core/io/FileSystemResource.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -25,6 +25,7 @@ import java.net.URI; import...
true
Other
spring-projects
spring-framework
ed4bd43cacebf2d001a1d0b66b67ad5141499be1.json
Add writableChannel to WritableResource This commit introduces a `writableChannel()` method to `WritableResource`, defaulting to `Channels.newChannel`, but with overrides for file-based resources.
spring-core/src/main/java/org/springframework/core/io/PathResource.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,6 +24,7 @@ import java.net.URI; import...
true
Other
spring-projects
spring-framework
ed4bd43cacebf2d001a1d0b66b67ad5141499be1.json
Add writableChannel to WritableResource This commit introduces a `writableChannel()` method to `WritableResource`, defaulting to `Channels.newChannel`, but with overrides for file-based resources.
spring-core/src/main/java/org/springframework/core/io/WritableResource.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,6 +18,8 @@ import java.io.IOException...
true
Other
spring-projects
spring-framework
ed4bd43cacebf2d001a1d0b66b67ad5141499be1.json
Add writableChannel to WritableResource This commit introduces a `writableChannel()` method to `WritableResource`, defaulting to `Channels.newChannel`, but with overrides for file-based resources.
spring-core/src/test/java/org/springframework/core/io/PathResourceTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,6 +21,8 @@ import java.net.URI; import...
true
Other
spring-projects
spring-framework
16901b14975273034194b9c8a109ab749a90f0bc.json
Add bindToHttpHandler to WebTestClient Issue: SPR-15499
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java
@@ -77,13 +77,13 @@ class DefaultWebTestClient implements WebTestClient { DefaultWebTestClient(WebClient.Builder webClientBuilder, ClientHttpConnector connector, - ExchangeMutatingWebFilter exchangeMutatingWebFilter, Duration timeout) { + ExchangeMutatingWebFilter filter, Duration timeout) { Assert.notNu...
true
Other
spring-projects
spring-framework
16901b14975273034194b9c8a109ab749a90f0bc.json
Add bindToHttpHandler to WebTestClient Issue: SPR-15499
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -35,6 +35,7 @@ import org.springframework.http.MediaType; import org.springframework.http.client.reactive.ClientHttpRequest; import org.springframework.http.codec.ServerCodecConfigurer; +import org.springframework.http.server.reactive.HttpHandler; import org.springframework.util.MultiValueMap; import org.spring...
true
Other
spring-projects
spring-framework
16901b14975273034194b9c8a109ab749a90f0bc.json
Add bindToHttpHandler to WebTestClient Issue: SPR-15499
spring-test/src/test/java/org/springframework/test/web/reactive/server/samples/bind/HttpHandlerTests.java
@@ -0,0 +1,58 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
3b8b3502a84714bd01594fca10e0afabcd2e48e4.json
Update copyright header
spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.
false
Other
spring-projects
spring-framework
90477b40a4b92c357184cc182f546ce742b1ffa1.json
Defer Charset.availableCharsets() call Change the `StringHttpMessageConverter` to defer calling Charset.availableCharsets() until absolutely necessary to help improve startup times. Issue: SPR-15502
spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java
@@ -43,7 +43,7 @@ public class StringHttpMessageConverter extends AbstractHttpMessageConverter<Str public static final Charset DEFAULT_CHARSET = StandardCharsets.ISO_8859_1; - private final List<Charset> availableCharsets; + private volatile List<Charset> availableCharsets; private boolean writeAcceptCharset ...
false
Other
spring-projects
spring-framework
ea85431ac55acf9e3b8dfca51879727c99c2d5f7.json
Add error filter to WebClient integration test This commit adds a `WebClient` integration test that shows how to use `ExchangeFilterFunction`s for error handling purposes. Issue: SPR-15403
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java
@@ -393,7 +393,7 @@ public void retrieveToEntityNotFound() throws Exception { } @Test - public void buildFilter() throws Exception { + public void filter() throws Exception { this.server.enqueue(new MockResponse().setHeader("Content-Type", "text/plain").setBody("Hello Spring!")); WebClient filteredClient ...
false
Other
spring-projects
spring-framework
4bfd04b3c54000f6e2e17127cd4a11b70f4e8571.json
Add multipart support to ServerWebExchange Issue: SPR-14546
spring-web/src/main/java/org/springframework/web/server/ServerWebExchange.java
@@ -24,6 +24,7 @@ import reactor.core.publisher.Mono; +import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; import org.springframework.util.MultiValueMap; @@ -82,6 +83,12 @@ pu...
true
Other
spring-projects
spring-framework
4bfd04b3c54000f6e2e17127cd4a11b70f4e8571.json
Add multipart support to ServerWebExchange Issue: SPR-14546
spring-web/src/main/java/org/springframework/web/server/ServerWebExchangeDecorator.java
@@ -22,6 +22,7 @@ import reactor.core.publisher.Mono; +import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; import org.springframework.util.Assert; @@ -93,6 +94,11 @@ public Mo...
true
Other
spring-projects
spring-framework
4bfd04b3c54000f6e2e17127cd4a11b70f4e8571.json
Add multipart support to ServerWebExchange Issue: SPR-14546
spring-web/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
@@ -36,6 +36,7 @@ import org.springframework.http.MediaType; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.ServerCodecConfigurer; +import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.spr...
true
Other
spring-projects
spring-framework
4bfd04b3c54000f6e2e17127cd4a11b70f4e8571.json
Add multipart support to ServerWebExchange Issue: SPR-14546
spring-web/src/test/java/org/springframework/http/server/reactive/MultipartIntegrationTests.java
@@ -0,0 +1,120 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
f5c54f90b309957b16ebebdeba0d57e8e59d7f37.json
Add shortcut to mutate + apply to WebTestClient Issue: SPR-15770
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java
@@ -141,6 +141,11 @@ public Builder mutate() { return this.builder; } + @Override + public WebTestClient mutateWith(WebTestClientConfigurer configurer) { + return mutate().apply(configurer).build(); + } + private class DefaultRequestBodyUriSpec implements RequestBodyUriSpec {
true
Other
spring-projects
spring-framework
f5c54f90b309957b16ebebdeba0d57e8e59d7f37.json
Add shortcut to mutate + apply to WebTestClient Issue: SPR-15770
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -135,12 +135,23 @@ public interface WebTestClient { RequestBodyUriSpec method(HttpMethod method); - /** * Return a builder to mutate properties of this web test client. */ Builder mutate(); + /** + * Mutate the {@link WebTestClient}, apply the given configurer, and build + * a new instance. Essen...
true
Other
spring-projects
spring-framework
f5c54f90b309957b16ebebdeba0d57e8e59d7f37.json
Add shortcut to mutate + apply to WebTestClient Issue: SPR-15770
spring-test/src/test/java/org/springframework/test/web/reactive/server/samples/ExchangeMutatorTests.java
@@ -47,7 +47,7 @@ public class ExchangeMutatorTests { public void setUp() throws Exception { this.webTestClient = WebTestClient.bindToController(new TestController()) - .apply(globalIdentity("Pablo")) + .apply(identity("Pablo")) .build(); } @@ -62,22 +62,19 @@ public void useGloballyConfiguredIden...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
build.gradle
@@ -952,6 +952,7 @@ project("spring-webflux") { optional "javax.servlet:javax.servlet-api:${servletVersion}" optional("javax.xml.bind:jaxb-api:${jaxbVersion}") optional("com.fasterxml.jackson.core:jackson-databind:${jackson2Version}") + optional("com.fasterxml.jackson.dataformat:jackson-dataformat-smile:${jac...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/AbstractCodecConfigurer.java
@@ -34,6 +34,8 @@ import org.springframework.core.codec.StringDecoder; import org.springframework.http.codec.json.Jackson2JsonDecoder; import org.springframework.http.codec.json.Jackson2JsonEncoder; +import org.springframework.http.codec.json.Jackson2SmileDecoder; +import org.springframework.http.codec.json.Jackson2...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/ClientCodecConfigurer.java
@@ -64,7 +64,7 @@ interface ClientDefaultCodecs extends DefaultCodecs { /** * Configure the {@code Decoder} to use for Server-Sent Events. * <p>By default if this is not set, and Jackson is available, the - * {@link #jackson2Decoder} override is used instead. Use this property + * {@link #jackson2JsonDec...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/CodecConfigurer.java
@@ -74,13 +74,13 @@ interface DefaultCodecs { * Override the default Jackson JSON {@code Decoder}. * @param decoder the decoder instance to use */ - void jackson2Decoder(Jackson2JsonDecoder decoder); + void jackson2JsonDecoder(Jackson2JsonDecoder decoder); /** * Override the default Jackson JSON ...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/DefaultClientCodecConfigurer.java
@@ -83,7 +83,7 @@ private Decoder<?> getSseDecoder() { if (this.sseDecoder != null) { return this.sseDecoder; } - return (jackson2Present ? jackson2Decoder() : null); + return (jackson2Present ? jackson2JsonDecoder() : null); } @Override
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/DefaultServerCodecConfigurer.java
@@ -95,7 +95,7 @@ private Encoder<?> getSseEncoder() { if (this.sseEncoder != null) { return this.sseEncoder; } - return jackson2Present ? jackson2Encoder() : null; + return jackson2Present ? jackson2JsonEncoder() : null; } }
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/ServerCodecConfigurer.java
@@ -55,7 +55,7 @@ interface ServerDefaultCodecs extends DefaultCodecs { /** * Configure the {@code Encoder} to use for Server-Sent Events. * <p>By default if this is not set, and Jackson is available, the - * {@link #jackson2Encoder} override is used instead. Use this property + * {@link #jackson2JsonEnc...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Decoder.java
@@ -0,0 +1,149 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Encoder.java
@@ -0,0 +1,170 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonDecoder.java
@@ -16,35 +16,10 @@ package org.springframework.http.codec.json; -import java.io.IOException; -import java.io.UncheckedIOException; -import java.lang.annotation.Annotation; import java.util.List; -import java.util.Map; -import com.fasterxml.jackson.core.JsonFactory; -import com.fasterxml.jackson.core.JsonParser...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonEncoder.java
@@ -16,40 +16,20 @@ package org.springframework.http.codec.json; -import java.io.IOException; -import java.io.OutputStream; -import java.lang.annotation.Annotation; -import java.util.ArrayList; -import java.util.Collections; import java.util.List; import java.util.Map; -import com.fasterxml.jackson.core.JsonPr...
true
Other
spring-projects
spring-framework
f46520e6e8e70e59ad46bc31debdfd155cf943bc.json
Add Jackson Smile support to WebFlux This binary format more efficient than JSON should be useful for server to server communication, for example in micro-services use cases. Issue: SPR-15424
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2SmileDecoder.java
@@ -0,0 +1,56 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true