language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/method/annotation/ResponseBodyResultHandler.java
@@ -0,0 +1,99 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/rxnetty/RxNettyServerHttpResponse.java
@@ -65,7 +65,9 @@ public Publisher<Void> writeWith(Publisher<byte[]> contentPublisher) { private void writeHeaders() { if (!this.headersWritten) { for (String name : this.headers.keySet()) { - this.response.setHeader(name, this.headers.get(name)); + for (String value : this.headers.get(name)) { + thi...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/servlet/HttpHandlerServlet.java
@@ -29,6 +29,7 @@ import org.reactivestreams.Subscriber; import org.reactivestreams.Subscription; +import org.springframework.http.HttpStatus; import org.springframework.reactive.web.http.HttpHandler; /** @@ -66,7 +67,7 @@ protected void service(HttpServletRequest request, HttpServletResponse response) respo...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/main/resources/log4j.properties
@@ -1,6 +1,8 @@ -log4j.rootCategory=INFO, stdout -log4j.logger.org.springframework.rx=DEBUG +log4j.rootCategory=WARN, stdout + +log4j.logger.org.springframework.reactive=DEBUG +log4j.logger.org.springframework.web=DEBUG log4j.appender.stdout=org.apache.log4j.ConsoleAppender log4j.appender.stdout.layout=org.apache.l...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/test/java/org/springframework/reactive/util/BlockingByteBufQueuePublisherTests.java
@@ -26,7 +26,10 @@ import org.reactivestreams.Subscriber; import org.reactivestreams.Subscription; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertSame; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; /** *...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/test/java/org/springframework/reactive/util/BlockingByteBufQueueTests.java
@@ -19,7 +19,9 @@ import org.junit.Before; import org.junit.Test; -import static org.junit.Assert.*; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertSame; +import static org.junit.Assert.assertTrue; /** * @author Arjen Poutsma
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/DispatcherApp.java
@@ -1,118 +0,0 @@ -/* - * Copyright 2002-2015 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/handler/SimpleUrlHandlerMappingIntegrationTests.java
@@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.springframework.reactive.web.dispatch; +package org.springframework.reactive.web.dispatch.handler; import java.net.URI; import java.nio.charset.Charset; @@ -26,8 +26,7 @@ ...
true
Other
spring-projects
spring-framework
202825554c022e4262fe3bd20a34faf01ab9d620.json
Add basic support for @RequestMapping Just enough for a test with an @ResponseBody method that accepts an @RequestParam String arg and returning Publisher<String> or String. See RequestMappingIntegrationTests.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/method/annotation/RequestMappingIntegrationTests.java
@@ -0,0 +1,87 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
0b9c3de320df81acd06dcfd927faadf72fb66409.json
Sanitize request URL in ResourceUrlEncodingFilter Prior to this change, ResourceUrlEncodingFilter and ResourceUrlProvider would try to resolve the resource path using the full request URL (i.e. request path and request parameters), whereas the request path is the only information to consider. This would lead to String...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilter.java
@@ -74,10 +74,12 @@ public String encodeURL(String url) { initIndexLookupPath(resourceUrlProvider); if (url.length() >= this.indexLookupPath) { String prefix = url.substring(0, this.indexLookupPath); - String lookupPath = url.substring(this.indexLookupPath); + int suffixIndex = getQueryParamsIndex(ur...
true
Other
spring-projects
spring-framework
0b9c3de320df81acd06dcfd927faadf72fb66409.json
Sanitize request URL in ResourceUrlEncodingFilter Prior to this change, ResourceUrlEncodingFilter and ResourceUrlProvider would try to resolve the resource path using the full request URL (i.e. request path and request parameters), whereas the request path is the only information to consider. This would lead to String...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlProvider.java
@@ -172,11 +172,13 @@ public final String getForRequestUrl(HttpServletRequest request, String requestU if (logger.isTraceEnabled()) { logger.trace("Getting resource URL for requestURL=" + requestUrl); } - int index = getLookupPathIndex(request); - String prefix = requestUrl.substring(0, index); - String lo...
true
Other
spring-projects
spring-framework
0b9c3de320df81acd06dcfd927faadf72fb66409.json
Sanitize request URL in ResourceUrlEncodingFilter Prior to this change, ResourceUrlEncodingFilter and ResourceUrlProvider would try to resolve the resource path using the full request URL (i.e. request path and request parameters), whereas the request path is the only information to consider. This would lead to String...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceUrlEncodingFilterTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -106,6 +106,23 @@ public void doFilter(Servl...
true
Other
spring-projects
spring-framework
0b9c3de320df81acd06dcfd927faadf72fb66409.json
Sanitize request URL in ResourceUrlEncodingFilter Prior to this change, ResourceUrlEncodingFilter and ResourceUrlProvider would try to resolve the resource path using the full request URL (i.e. request path and request parameters), whereas the request path is the only information to consider. This would lead to String...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceUrlProviderTests.java
@@ -29,6 +29,7 @@ import org.springframework.context.annotation.Configuration; import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.Resource; +import org.springframework.mock.web.test.MockHttpServletRequest; import org.springframework.mock.web.test.MockServletContext; import org...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/DispatcherHandler.java
@@ -19,21 +19,19 @@ import java.util.List; import org.reactivestreams.Publisher; -import reactor.core.reactivestreams.PublisherFactory; -import reactor.core.reactivestreams.SubscriberWithContext; import reactor.rx.Streams; import org.springframework.beans.factory.BeanFactoryUtils; import org.springframework.co...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/handler/HttpHandlerAdapter.java
@@ -0,0 +1,53 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/handler/SimpleUrlHandlerMapping.java
@@ -0,0 +1,46 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/HttpHandler.java
@@ -18,14 +18,12 @@ import org.reactivestreams.Publisher; -import org.springframework.reactive.web.http.ServerHttpRequest; -import org.springframework.reactive.web.http.ServerHttpResponse; /** * @author Arjen Poutsma * @author Rossen Stoyanchev */ -public interface ServerHttpHandler { +public interface Ht...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/HttpMessage.java
@@ -15,10 +15,7 @@ */ package org.springframework.reactive.web.http; -import java.net.URI; - import org.springframework.http.HttpHeaders; -import org.springframework.http.HttpMethod; /** * @author Rossen Stoyanchev
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/rxnetty/RequestHandlerAdapter.java
@@ -23,18 +23,18 @@ import rx.Observable; import rx.RxReactiveStreams; -import org.springframework.reactive.web.http.ServerHttpHandler; +import org.springframework.reactive.web.http.HttpHandler; import org.springframework.util.Assert; /** * @author Rossen Stoyanchev */ public class RequestHandlerAdapter im...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/servlet/HttpHandlerServlet.java
@@ -29,7 +29,7 @@ import org.reactivestreams.Subscriber; import org.reactivestreams.Subscription; -import org.springframework.reactive.web.http.ServerHttpHandler; +import org.springframework.reactive.web.http.HttpHandler; /** * @author Arjen Poutsma @@ -43,10 +43,10 @@ public class HttpHandlerServlet extends H...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/servlet/RequestBodyPublisher.java
@@ -55,7 +55,6 @@ public RequestBodyPublisher(AsyncContextSynchronizer synchronizer, int bufferSiz @Override public void subscribe(Subscriber<? super byte[]> s) { this.subscriber = s; - this.subscriber.onSubscribe(new RequestBodySubscription()); } @@ -99,13 +98,17 @@ else if (read > 0) { public void onA...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/main/java/org/springframework/reactive/web/http/servlet/ServletServerHttpRequest.java
@@ -20,7 +20,6 @@ import java.nio.charset.Charset; import java.util.Enumeration; import java.util.Map; - import javax.servlet.http.HttpServletRequest; import org.reactivestreams.Publisher;
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/SimpleUrlHandlerMappingIntegrationTests.java
@@ -0,0 +1,113 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/AbstractHttpHandlerIntegrationTests.java
@@ -0,0 +1,61 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/EchoHandler.java
@@ -18,14 +18,10 @@ import org.reactivestreams.Publisher; -import org.springframework.reactive.web.http.ServerHttpHandler; -import org.springframework.reactive.web.http.ServerHttpRequest; -import org.springframework.reactive.web.http.ServerHttpResponse; - /** * @author Arjen Poutsma */ -public class EchoHandl...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/EchoHandlerIntegrationTests.java
@@ -19,56 +19,26 @@ import java.net.URI; import java.util.Random; -import org.junit.After; -import org.junit.Before; import org.junit.Test; -import org.junit.runner.RunWith; -import org.junit.runners.Parameterized; import org.springframework.http.RequestEntity; import org.springframework.http.ResponseEntity; -...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/HttpServer.java
@@ -26,6 +26,6 @@ public interface HttpServer extends InitializingBean, Lifecycle { void setPort(int port); - void setHandler(ServerHttpHandler handler); + void setHandler(HttpHandler handler); }
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/HttpServerSupport.java
@@ -23,7 +23,7 @@ public class HttpServerSupport { private int port = -1; - private ServerHttpHandler httpHandler; + private HttpHandler httpHandler; public void setPort(int port) { @@ -34,11 +34,11 @@ public int getPort() { return this.port; } - public void setHandler(ServerHttpHandler handler) { + ...
true
Other
spring-projects
spring-framework
bc7a5acd509f1d66039bac742a71d9b1b8474127.json
Add simple URL mapping and handling This commit adds support for simple URL handler mapping (exact path match) and an adapter for the HttpHandler interface to be used to handle the request. The SimpleUrlHandlerMappingIntegrationTests then maps the URLs "/foo" and "/bar" to two different handlers.
spring-web-reactive/src/test/java/org/springframework/reactive/web/http/JettyHttpServer.java
@@ -22,6 +22,7 @@ import org.springframework.beans.factory.InitializingBean; import org.springframework.reactive.web.http.servlet.HttpHandlerServlet; +import org.springframework.util.Assert; import org.springframework.util.SocketUtils; /** @@ -48,8 +49,9 @@ public void afterPropertiesSet() throws Exception { ...
true
Other
spring-projects
spring-framework
27899abcb6c1651b0b25e196ae9768a264474b70.json
Publish events only after successful channel send The StompSubProtcolHandler now checks the outcome of the send to the inbound client channel. If the message was prevented from being sent, e.g. as part of authorization, events are not published Issue: SPR-13339
spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java
@@ -277,7 +277,9 @@ else if (StompCommand.DISCONNECT.equals(headerAccessor.getCommand())) { try { SimpAttributesContextHolder.setAttributesFromMessage(message); - if (this.eventPublisher != null) { + boolean sent = outputChannel.send(message); + + if (sent && this.eventPublisher != null) { ...
true
Other
spring-projects
spring-framework
27899abcb6c1651b0b25e196ae9768a264474b70.json
Publish events only after successful channel send The StompSubProtcolHandler now checks the outcome of the send to the inbound client channel. If the message was prevented from being sent, e.g. as part of authorization, events are not published Issue: SPR-13339
spring-websocket/src/test/java/org/springframework/web/socket/messaging/StompSubProtocolHandlerTests.java
@@ -16,11 +16,6 @@ package org.springframework.web.socket.messaging; -import static org.hamcrest.Matchers.*; -import static org.junit.Assert.*; -import static org.mockito.Matchers.any; -import static org.mockito.Mockito.*; - import java.io.IOException; import java.util.ArrayList; import java.util.Arrays; @@ -61...
true
Other
spring-projects
spring-framework
0cd21aa55f79d6b36890172f0cf28b880c0f1f34.json
Fix typo in Javadoc for TestContextBootstrapper
spring-test/src/main/java/org/springframework/test/context/TestContextBootstrapper.java
@@ -99,7 +99,7 @@ public interface TestContextBootstrapper { * <li>If a {@code ContextLoader} class has been explicitly declared via * {@link ContextConfiguration#loader}, use it.</li> * <li>Otherwise, concrete implementations are free to determine which - * {@code ContextLoader} class to use as as default.</...
false
Other
spring-projects
spring-framework
ddd6c9bea06387b3cd713f2ba16423f3ec8d11bf.json
Fix typos in Web MVC documentation
src/asciidoc/web-mvc.adoc
@@ -1194,7 +1194,7 @@ multiple requests are allowed to access a session concurrently. part of the servlet mapping. The `Errors` or `BindingResult` parameters have to follow the model object that is being -bound immediately as the method signature might have more that one model object and +bound immediately as the...
false
Other
spring-projects
spring-framework
6634d1f536cf1421a7bcc766285d6177276181ec.json
Use Streams from reactor-streams
spring-web-reactive/build.gradle
@@ -23,6 +23,7 @@ dependencies { compile "org.springframework:spring-web:4.2.0.RELEASE" compile "org.reactivestreams:reactive-streams:1.0.0" compile "io.projectreactor:reactor-core:2.0.5.RELEASE" + compile "io.projectreactor:reactor-net:2.0.5.RELEASE" compile "org.slf4j:slf4j-api:1.7.6" compile "ch.qos.logbac...
true
Other
spring-projects
spring-framework
6634d1f536cf1421a7bcc766285d6177276181ec.json
Use Streams from reactor-streams
spring-web-reactive/src/main/java/org/springframework/reactive/web/DispatcherHttpHandler.java
@@ -19,10 +19,10 @@ import java.util.List; import org.reactivestreams.Publisher; -import org.reactivestreams.Subscriber; -import org.reactivestreams.Subscription; import reactor.core.reactivestreams.PublisherFactory; import reactor.core.reactivestreams.SubscriberWithContext; +import reactor.rx.Promises; +import r...
true
Other
spring-projects
spring-framework
6634d1f536cf1421a7bcc766285d6177276181ec.json
Use Streams from reactor-streams
spring-web-reactive/src/test/java/org/springframework/reactive/web/DispatcherApp.java
@@ -22,9 +22,8 @@ import io.netty.buffer.ByteBuf; import io.reactivex.netty.protocol.http.server.HttpServer; import org.reactivestreams.Publisher; -import org.reactivestreams.Subscriber; -import org.reactivestreams.Subscription; -import reactor.core.reactivestreams.PublisherFactory; +import reactor.rx.Stream; +impor...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-context/src/main/java/org/springframework/scripting/groovy/package-info.java
@@ -1,6 +1,6 @@ /** * Package providing integration of - * <a href="http://groovy.codehaus.org">Groovy</a> + * <a href="http://www.groovy-lang.org/">Groovy</a> * into Spring's scripting infrastructure. */ package org.springframework.scripting.groovy;
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-oxm/src/main/java/org/springframework/oxm/castor/package-info.java
@@ -1,5 +1,5 @@ /** - * Package providing integration of <a href="http://castor.codehaus.org/xml-mapping.html">Castor</a> + * Package providing integration of <a href="http://castor-data-binding.github.io/castor/reference-guides/1.3.3/html-single/index.html#xml.mapping">Castor</a> * within Spring's O/X Mapping suppo...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-oxm/src/main/java/org/springframework/oxm/xstream/package-info.java
@@ -1,5 +1,5 @@ /** - * Package providing integration of <a href="http://xstream.codehaus.org/">XStream</a> + * Package providing integration of <a href="http://x-stream.github.io/">XStream</a> * with Spring's O/X Mapping support. */ package org.springframework.oxm.xstream;
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-oxm/src/test/resources/org/springframework/oxm/castor/mapping.xml
@@ -1,5 +1,5 @@ <?xml version="1.0"?> -<!DOCTYPE mapping PUBLIC "-//EXOLAB/Castor Mapping DTD Version 1.0//EN" "http://castor.codehaus.org/mapping.dtd"> +<!DOCTYPE mapping PUBLIC "-//EXOLAB/Castor Mapping DTD Version 1.0//EN" "http://castor.org/mapping.dtd"> <mapping> <description>Castor generated mapping file</...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-web/src/main/java/org/springframework/http/converter/json/MappingJackson2HttpMessageConverter.java
@@ -25,7 +25,7 @@ /** * Implementation of {@link org.springframework.http.converter.HttpMessageConverter HttpMessageConverter} that - * can read and write JSON using <a href="http://jackson.codehaus.org/">Jackson 2.x's</a> {@link ObjectMapper}. + * can read and write JSON using <a href="http://wiki.fasterxml.com/J...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-webmvc/src/main/java/org/springframework/web/servlet/view/json/MappingJackson2JsonView.java
@@ -40,7 +40,7 @@ /** * Spring MVC {@link View} that renders JSON content by serializing the model for the current request - * using <a href="http://jackson.codehaus.org/">Jackson 2's</a> {@link ObjectMapper}. + * using <a href="http://wiki.fasterxml.com/JacksonHome">Jackson 2's</a> {@link ObjectMapper}. * * <...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
spring-webmvc/src/main/java/org/springframework/web/servlet/view/xml/MappingJackson2XmlView.java
@@ -28,7 +28,7 @@ /** * Spring MVC {@link View} that renders XML content by serializing the model for the current request - * using <a href="http://jackson.codehaus.org/">Jackson 2's</a> {@link XmlMapper}. + * using <a href="http://wiki.fasterxml.com/JacksonHome">Jackson 2's</a> {@link XmlMapper}. * * <p>The O...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
src/asciidoc/core-expressions.adoc
@@ -1095,7 +1095,7 @@ ternary operator. [[expressions-operator-elvis]] === The Elvis Operator The Elvis operator is a shortening of the ternary operator syntax and is used in the -http://groovy.codehaus.org/Operators#Operators-ElvisOperator(%3F%3A)[Groovy] language. +http://www.groovy-lang.org/operators.html#_elvis_...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
src/asciidoc/data-access.adoc
@@ -7046,7 +7046,7 @@ Available attributes are: XStream is a simple library to serialize objects to XML and back again. It does not require any mapping, and generates clean XML. -For more information on XStream, refer to the http://xstream.codehaus.org/[__XStream +For more information on XStream, refer to the http:...
true
Other
spring-projects
spring-framework
95acf8c989b0741195f993da40a39c07a500d59f.json
Remove references to codehaus.org Issue: SPR-13129
src/asciidoc/integration.adoc
@@ -876,13 +876,6 @@ proxy will take care of forwarding the call to the server-side object via JMS. } ---- -You may also wish to investigate the support provided by the -http://lingo.codehaus.org/[Lingo] project, which (to quote the homepage blurb) "__... is -a lightweight POJO based remoting and messaging library...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/main/java/org/springframework/test/context/MergedContextConfiguration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,9 +19,8 @@ import java.io.Serializable;...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/main/java/org/springframework/test/context/support/ActiveProfilesUtils.java
@@ -16,7 +16,10 @@ package org.springframework.test.context.support; -import java.util.HashSet; +import java.util.ArrayList; +import java.util.Collections; +import java.util.LinkedHashSet; +import java.util.List; import java.util.Set; import org.apache.commons.logging.Log; @@ -72,7 +75,7 @@ private ActiveProfi...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/main/java/org/springframework/test/context/support/DefaultActiveProfilesResolver.java
@@ -16,7 +16,7 @@ package org.springframework.test.context.support; -import java.util.HashSet; +import java.util.LinkedHashSet; import java.util.Set; import org.apache.commons.logging.Log; @@ -59,7 +59,7 @@ public class DefaultActiveProfilesResolver implements ActiveProfilesResolver { public String[] resolve...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/test/java/org/springframework/test/context/MergedContextConfigurationTests.java
@@ -141,7 +141,7 @@ public void hashCodeWithSameProfilesReversed() { EMPTY_STRING_ARRAY, EMPTY_CLASS_ARRAY, activeProfiles1, loader); MergedContextConfiguration mergedConfig2 = new MergedContextConfiguration(getClass(), EMPTY_STRING_ARRAY, EMPTY_CLASS_ARRAY, activeProfiles2, loader); - assertEquals(merged...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/test/java/org/springframework/test/context/cache/ContextCacheTests.java
@@ -86,14 +86,15 @@ public void verifyCacheKeyIsBasedOnContextLoader() { @Test public void verifyCacheKeyIsBasedOnActiveProfiles() { - loadCtxAndAssertStats(FooBarProfilesTestCase.class, 1, 0, 1); - loadCtxAndAssertStats(FooBarProfilesTestCase.class, 1, 1, 1); - // Profiles {foo, bar} should hash to the same a...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/test/java/org/springframework/test/context/support/AbstractContextConfigurationUtilsTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -164,12 +164,12 @@ static class MetaLocation...
true
Other
spring-projects
spring-framework
68a704373dfcc3438eabb98f0767aed9cec4f95b.json
Retain order of active profiles in the TCF Ever since @ActiveProfiles was introduced, the declared active profiles for integration tests have been sorted in order to support unique cache key generation; however, there are use cases for which the original ordering should be retained. For example, Spring Boot's ConfigF...
spring-test/src/test/java/org/springframework/test/context/support/ActiveProfilesUtilsTests.java
@@ -22,9 +22,7 @@ import java.lang.annotation.Target; import java.util.ArrayList; import java.util.Arrays; -import java.util.HashSet; import java.util.List; -import java.util.Set; import org.junit.Test; @@ -47,34 +45,34 @@ public class ActiveProfilesUtilsTests extends AbstractContextConfigurationUtilsTests { ...
true
Other
spring-projects
spring-framework
aed523c112e6f5fbcf4b2127f3d35c5fa15cad3e.json
Upgrade reference to castor website Issue: SPR-12991
src/asciidoc/data-access.adoc
@@ -6816,7 +6816,7 @@ not require any further configuration, though a mapping file can be used to have control over the behavior of Castor. For more information on Castor, refer to the -http://castor.codehaus.org/xml-framework.html[__Castor web site__]. The Spring +http://castor-data-binding.github.io/castor[__Cast...
false
Other
spring-projects
spring-framework
c111ea89cf767ca83835f3cc1302c220343b0a35.json
Add reference to AutoCloseable and Closeable Issue: SPR-13041
src/asciidoc/core-beans.adoc
@@ -2957,9 +2957,10 @@ but does not couple the code to Spring. ==== The `destroy-method` attribute of a `<bean>` element can be assigned a special `(inferred)` value which instructs Spring to automatically detect a public `close` or -`shutdown` method on the specific bean class. This special `(inferred)` value can a...
false
Other
spring-projects
spring-framework
06a0dfa6823e3c70249ec4a0dd96a3f18d5c6158.json
Update ApplicationEvent doc for generics event Issue: SPR-13069
src/asciidoc/core-beans.adoc
@@ -7851,6 +7851,58 @@ This new method will publish a new `ListUpdateEvent` for every `BlackListEvent` by the method above. If you need to publish several events, just return a `Collection` of events instead. +[[context-functionality-events-generics]] +==== Generic Events + +You may also use generics to further def...
false
Other
spring-projects
spring-framework
2d23f42609c2e6a2ee6b0507f4b800870a63ca26.json
Introduce alias for 'value' attribute in @Scope Issue: SPR-11393
spring-context/src/main/java/org/springframework/context/annotation/AnnotationScopeMetadataResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -25,13 +25,14 @@ /** * A {@link ScopeMe...
true
Other
spring-projects
spring-framework
2d23f42609c2e6a2ee6b0507f4b800870a63ca26.json
Introduce alias for 'value' attribute in @Scope Issue: SPR-11393
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -65,6 +65,7 @@ * @author Chris Beams * @author Juergen Hoeller * @author Phillip Webb + * @author Sam Brannen * @since 3.0 * @see ConfigurationClassParser */ @@ -242,10 +243,12 @@ private void loadBeanDefinitionsForBeanMethod(BeanMethod beanMethod) { // Consider scoping ScopedProxyMode proxyMode ...
true
Other
spring-projects
spring-framework
2d23f42609c2e6a2ee6b0507f4b800870a63ca26.json
Introduce alias for 'value' attribute in @Scope Issue: SPR-11393
spring-context/src/main/java/org/springframework/context/annotation/Scope.java
@@ -23,6 +23,7 @@ import java.lang.annotation.Target; import org.springframework.beans.factory.config.ConfigurableBeanFactory; +import org.springframework.core.annotation.AliasFor; /** * When used as a type-level annotation in conjunction with @@ -57,14 +58,25 @@ public @interface Scope { /** - * Specifi...
true
Other
spring-projects
spring-framework
2d23f42609c2e6a2ee6b0507f4b800870a63ca26.json
Introduce alias for 'value' attribute in @Scope Issue: SPR-11393
spring-context/src/test/java/org/springframework/context/annotation/AnnotationScopeMetadataResolverTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,12 +17,9 @@ package org.springframework...
true
Other
spring-projects
spring-framework
2d23f42609c2e6a2ee6b0507f4b800870a63ca26.json
Introduce alias for 'value' attribute in @Scope Issue: SPR-11393
spring-context/src/test/java/org/springframework/context/annotation/ConfigurationClassPostProcessorTests.java
@@ -787,7 +787,7 @@ public String toString() { public static class ScopedProxyRepositoryConfiguration { @Bean - @Scope(value = "prototype", proxyMode = ScopedProxyMode.TARGET_CLASS) + @Scope(name = "prototype", proxyMode = ScopedProxyMode.TARGET_CLASS) public Repository<String> stringRepo() { return new...
true
Other
spring-projects
spring-framework
e2c8d3762fb1739193858553966474b82ec94791.json
Fix tests for SPR-13090
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/HeaderAssertionTests.java
@@ -34,6 +34,10 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*; import static org.springframework.test.web.servlet.setup.MockMvcBuilders.*; +import java.text.SimpleDateFormat; +import java.util.Locale; +import java.util.TimeZone; + /** * Examples of expectations on response ...
false
Other
spring-projects
spring-framework
e8441edcb7d0c59dbedc3f6994b989d02a9970bf.json
Remove commons pool 2.x workaround While working on SPR-12532, an extra IdentityWrapper was added to work around a backward compatible issue between commons pool 1.x and 2.x. This issue (POOL-283) has actually been fixed in 2.4 and their IdentityWrapper is using object equality so our wrapper is in the way. Looking r...
spring-aop/src/main/java/org/springframework/aop/target/CommonsPool2TargetSource.java
@@ -43,14 +43,7 @@ * meaningful validation. All exposed Commons Pool properties use the * corresponding Commons Pool defaults. * - * <p>Commons Pool 2.x uses object equality while Commons Pool 1.x used identity - * equality. This clearly means that Commons Pool 2 behaves differently if several - * instances havin...
true
Other
spring-projects
spring-framework
e8441edcb7d0c59dbedc3f6994b989d02a9970bf.json
Remove commons pool 2.x workaround While working on SPR-12532, an extra IdentityWrapper was added to work around a backward compatible issue between commons pool 1.x and 2.x. This issue (POOL-283) has actually been fixed in 2.4 and their IdentityWrapper is using object equality so our wrapper is in the way. Looking r...
spring-context/src/test/java/org/springframework/aop/target/CommonsPool2TargetSourceTests.java
@@ -228,25 +228,6 @@ public void referenceIdentityByDefault() throws Exception { targetSource.releaseTarget(second); } - @Test - public void objectIdentityReleaseWithSeveralEqualInstances() throws Exception{ - CommonsPool2TargetSource targetSource = new CommonsPool2TargetSource(); - targetSource.setUseObjectEq...
true
Other
spring-projects
spring-framework
e8441edcb7d0c59dbedc3f6994b989d02a9970bf.json
Remove commons pool 2.x workaround While working on SPR-12532, an extra IdentityWrapper was added to work around a backward compatible issue between commons pool 1.x and 2.x. This issue (POOL-283) has actually been fixed in 2.4 and their IdentityWrapper is using object equality so our wrapper is in the way. Looking r...
spring-context/src/test/java/org/springframework/aop/target/CommonsPoolTargetSourceTests.java
@@ -0,0 +1,219 @@ +/* + * Copyright 2002-2013 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e8441edcb7d0c59dbedc3f6994b989d02a9970bf.json
Remove commons pool 2.x workaround While working on SPR-12532, an extra IdentityWrapper was added to work around a backward compatible issue between commons pool 1.x and 2.x. This issue (POOL-283) has actually been fixed in 2.4 and their IdentityWrapper is using object equality so our wrapper is in the way. Looking r...
spring-context/src/test/resources/org/springframework/aop/target/CommonsPoolTargetSourceTests-context.xml
@@ -0,0 +1,69 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN 2.0//EN" "http://www.springframework.org/dtd/spring-beans-2.0.dtd"> + +<beans> + + <bean id="prototypeTest" class="org.springframework.tests.sample.beans.SideEffectBean" scope="prototype"> + <property name="count"><va...
true
Other
spring-projects
spring-framework
d4ee75ddf041835e229d5a7857206030e8c5be65.json
Log correct class name for introspection failure Issue: SPR-13091
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassUtils.java
@@ -175,7 +175,7 @@ public static boolean isLiteConfigurationCandidate(AnnotationMetadata metadata) } catch (Throwable ex) { if (logger.isDebugEnabled()) { - logger.debug("Failed to introspect @Bean methods on class [" + metadata.getClass() + "]: " + ex); + logger.debug("Failed to introspect @Bean metho...
false
Other
spring-projects
spring-framework
89c1674b899de475181604f8a48f907742261698.json
Fix missing space in assertion message
spring-test/src/main/java/org/springframework/test/util/JsonPathExpectationsHelper.java
@@ -89,7 +89,7 @@ public JsonPathExpectationsHelper(String expression, Object... args) { @SuppressWarnings("unchecked") public <T> void assertValue(String content, Matcher<T> matcher) throws ParseException { T value = (T) evaluateJsonPath(content); - assertThat("JSON path" + this.expression, value, matcher); + ...
false
Other
spring-projects
spring-framework
c90ca15addf048ce1ea17b1149052d97a7655ea7.json
Fix caching tests Update assertion to validate the proper exception type is thrown.
spring-context/src/test/java/org/springframework/cache/config/AbstractAnnotationTests.java
@@ -16,6 +16,7 @@ package org.springframework.cache.config; +import java.io.IOException; import java.util.Collection; import java.util.UUID; @@ -290,6 +291,7 @@ public void testCheckedThrowable(CacheableService<?> service) throws Exception { service.throwChecked(arg); fail("Excepted exception"); } c...
true
Other
spring-projects
spring-framework
c90ca15addf048ce1ea17b1149052d97a7655ea7.json
Fix caching tests Update assertion to validate the proper exception type is thrown.
spring-context/src/test/java/org/springframework/cache/config/AnnotatedClassCacheableService.java
@@ -16,6 +16,7 @@ package org.springframework.cache.config; +import java.io.IOException; import java.util.concurrent.atomic.AtomicLong; import org.springframework.cache.annotation.CacheEvict; @@ -162,12 +163,12 @@ public Number nullInvocations() { @Override public Long throwChecked(Object arg1) throws Ex...
true
Other
spring-projects
spring-framework
c90ca15addf048ce1ea17b1149052d97a7655ea7.json
Fix caching tests Update assertion to validate the proper exception type is thrown.
spring-context/src/test/java/org/springframework/cache/config/CustomInterceptorTests.java
@@ -16,6 +16,7 @@ package org.springframework.cache.config; +import java.io.IOException; import java.util.Map; import org.junit.After; @@ -78,7 +79,7 @@ public void customInterceptorAppliesWithCheckedException() { } catch (RuntimeException e) { assertNotNull("missing original exception", e.getCause()...
true
Other
spring-projects
spring-framework
c90ca15addf048ce1ea17b1149052d97a7655ea7.json
Fix caching tests Update assertion to validate the proper exception type is thrown.
spring-context/src/test/java/org/springframework/cache/config/DefaultCacheableService.java
@@ -16,6 +16,7 @@ package org.springframework.cache.config; +import java.io.IOException; import java.util.concurrent.atomic.AtomicLong; import org.springframework.cache.annotation.CacheEvict; @@ -167,7 +168,7 @@ public Number nullInvocations() { @Override @Cacheable("testCache") public Long throwChecked(...
true
Other
spring-projects
spring-framework
b35d44bd4c4f2f12d6c337bc96f53f246df3c4c0.json
Fix inputstream reading for HTTP range requests Prior to this commit, range requests would be served by ResourceHttpRequestHandler by partially reading the inputstream of static resources. In case of resources contained in ZIP/JAR containers, InputStreams may not fill the entire read buffer when calling `inputStream.r...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java
@@ -574,7 +574,7 @@ private void copyRange(InputStream in, OutputStream out, long start, long end) t out.write(buffer, 0, (int) bytesToCopy); bytesToCopy = 0; } - if (bytesRead < buffer.length) { + if (bytesRead == -1) { break; } }
false
Other
spring-projects
spring-framework
bf1afdfdc9d4c65391a1dcd198d6b9700a6b0593.json
Add cache tests for JCache
spring-context-support/src/test/java/org/springframework/cache/AbstractCacheTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,6 +16,8 @@ package org.springframewor...
true
Other
spring-projects
spring-framework
bf1afdfdc9d4c65391a1dcd198d6b9700a6b0593.json
Add cache tests for JCache
spring-context-support/src/test/java/org/springframework/cache/jcache/JCacheEhCacheTests.java
@@ -0,0 +1,68 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
bf1afdfdc9d4c65391a1dcd198d6b9700a6b0593.json
Add cache tests for JCache
spring-test/src/test/java/org/springframework/cache/jcache/JCacheEhcache3Tests.java
@@ -0,0 +1,35 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
8dea3c5ade47af23b098e49a5f6ddd44e40820c0.json
Remove test duplication
spring-context-support/src/test/java/org/springframework/cache/ehcache/EhCacheCacheTests.java
@@ -66,27 +66,6 @@ protected EhCacheCache getCache() { protected Ehcache getNativeCache() { return nativeCache; } - @Test - public void testCachePut() throws Exception { - Object key = "enescu"; - Object value = "george"; - - assertNull(cache.get(key)); - assertNull(cache.get(key, String.class)); - assertNu...
false
Other
spring-projects
spring-framework
66d99f05aa048552d718010d416f890b57c85dde.json
Add link in jsp tag library Closes gh-926
src/asciidoc/appx-spring-form-tld.adoc
@@ -15,6 +15,7 @@ http://www.w3.org/TR/xhtml1/dtds.html#a_dtd_XHTML-1.0-Strict[DTD]. This appendix describes the `spring-form.tld` tag library. +* <<spring-form.tld.button>> * <<spring-form.tld.checkbox>> * <<spring-form.tld.checkboxes>> * <<spring-form.tld.errors>>
true
Other
spring-projects
spring-framework
66d99f05aa048552d718010d416f890b57c85dde.json
Add link in jsp tag library Closes gh-926
src/asciidoc/appx-spring-tld.adoc
@@ -15,12 +15,14 @@ http://www.w3.org/TR/xhtml1/dtds.html#a_dtd_XHTML-1.0-Strict[DTD]. This appendix describes the `spring.tld` tag library. +* <<spring.tld.argument>> * <<spring.tld.bind>> * <<spring.tld.escapeBody>> * <<spring.tld.hasBindErrors>> * <<spring.tld.htmlEscape>> * <<spring.tld.message>> * <<spr...
true
Other
spring-projects
spring-framework
b2c132633f0fda2265978cc70317cfb26e7e198c.json
Remove invalid underscore Closes gh-923
src/asciidoc/core-beans.adoc
@@ -4625,7 +4625,7 @@ demonstrated in the following example. </bean> <bean class="example.SimpleMovieCatalog"> - **_<qualifier type="example.Genre" value="Comedy"/>** + **<qualifier type="example.Genre" value="Comedy"/>** <!-- inject any dependencies required by this bean --> </bean>
false
Other
spring-projects
spring-framework
a834639ac8a55878886866579a48a760636baa74.json
Add quotes around attribute value Closes gh-922
src/asciidoc/core-beans.adoc
@@ -4427,7 +4427,7 @@ The corresponding bean definitions appear as follows. <context:annotation-config/> - <bean class="example.SimpleMovieCatalog" **primary=true**> + <bean class="example.SimpleMovieCatalog" **primary="true"**> <!-- inject any dependencies required by this bean --> </bean>
false
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/HandlerResult.java
@@ -16,6 +16,7 @@ package org.springframework.reactive.web.dispatch; +import org.springframework.core.ResolvableType; /** * Represent the result of the invocation of an handler. @@ -28,10 +29,13 @@ public class HandlerResult { private final Object value; + private final ResolvableType type; - public H...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/SimpleHandlerResultHandler.java
@@ -22,6 +22,7 @@ import reactor.Publishers; import org.springframework.core.Ordered; +import org.springframework.core.ResolvableType; import org.springframework.http.server.ReactiveServerHttpRequest; import org.springframework.http.server.ReactiveServerHttpResponse; @@ -32,6 +33,8 @@ */ public class SimpleH...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/handler/HttpHandlerAdapter.java
@@ -19,6 +19,7 @@ import org.reactivestreams.Publisher; import reactor.Publishers; +import org.springframework.core.ResolvableType; import org.springframework.http.server.ReactiveServerHttpRequest; import org.springframework.http.server.ReactiveServerHttpResponse; import org.springframework.reactive.web.dispatch...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/method/annotation/RequestMappingHandlerAdapter.java
@@ -24,6 +24,7 @@ import reactor.Publishers; import org.springframework.beans.factory.InitializingBean; +import org.springframework.core.ResolvableType; import org.springframework.core.convert.ConversionService; import org.springframework.http.server.ReactiveServerHttpRequest; import org.springframework.http.ser...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/main/java/org/springframework/reactive/web/dispatch/method/annotation/ResponseBodyResultHandler.java
@@ -114,8 +114,7 @@ public Publisher<Void> handleResult(ReactiveServerHttpRequest request, return Publishers.empty(); } - HandlerMethod hm = (HandlerMethod) result.getHandler(); - ResolvableType returnType = ResolvableType.forMethodParameter(hm.getReturnValueType(value)); + ResolvableType returnType = resul...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/SimpleHandlerResultHandlerTests.java
@@ -0,0 +1,68 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
c6713c23e327961d021706e5b1e4d5ebe8e2f458.json
Add a ResolvableType field to HandlerResult This change allows to be able to check generic type on the return value at HandlerAdapter and ResultHandler level. For example, it allows to do a Publisher<Void> check in SimpleHandlerResultHandler.
spring-web-reactive/src/test/java/org/springframework/reactive/web/dispatch/method/annotation/ResponseBodyResultHandlerTests.java
@@ -21,6 +21,7 @@ import org.junit.Test; import org.reactivestreams.Publisher; +import org.springframework.core.ResolvableType; import org.springframework.core.convert.support.DefaultConversionService; import org.springframework.reactive.codec.encoder.StringEncoder; import org.springframework.reactive.web.dispat...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
build.gradle
@@ -44,6 +44,7 @@ configure(allprojects) { project -> ext.httpclientVersion = "4.5" ext.httpasyncVersion = "4.1" ext.jackson2Version = "2.6.0" + ext.htmlunitVersion = "2.17" ext.jasperreportsVersion = "6.1.0" ext.javamailVersion = "1.5.4" ext.jettyVersion = "9.3.1.v20150714" @@...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/DelegatingWebConnection.java
@@ -0,0 +1,93 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/ForwardRequestPostProcessor.java
@@ -0,0 +1,39 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/HostRequestMatcher.java
@@ -0,0 +1,92 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/HtmlUnitRequestBuilder.java
@@ -0,0 +1,523 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/MockMvcWebClientBuilder.java
@@ -0,0 +1,97 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/MockMvcWebConnection.java
@@ -0,0 +1,150 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/MockMvcWebConnectionBuilderSupport.java
@@ -0,0 +1,156 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/MockWebResponseBuilder.java
@@ -0,0 +1,93 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/UrlRegexRequestMatcher.java
@@ -0,0 +1,50 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/WebRequestMatcher.java
@@ -0,0 +1,34 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
b73e39423c6b44f4cc30a38528bbf5d162754f51.json
Introduce support for HtmlUnit in Spring MVC Test This commit introduces integration between MockMvc and HtmlUnit, thus simplifying end-to-end testing when using HTML-based views and enabling developers to do the following. - Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb without the need t...
spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/package-info.java
@@ -0,0 +1,7 @@ +/** + * Support for MockMvc and HtmlUnit integration + * + * @author Rob Winch + * @since 4.2 + */ +package org.springframework.test.web.servlet.htmlunit; \ No newline at end of file
true