language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/webdriver/MockMvcHtmlUnitDriverBuilder.java | @@ -0,0 +1,114 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ ... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/webdriver/WebConnectionHtmlUnitDriver.java | @@ -0,0 +1,96 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/main/java/org/springframework/test/web/servlet/htmlunit/webdriver/package-info.java | @@ -0,0 +1,7 @@
+/**
+ * Support for MockMvc and HtmlUnitDriver
+ *
+ * @author Rob Winch
+ * @since 4.2
+ */
+package org.springframework.test.web.servlet.htmlunit.webdriver;
\ No newline at end of file | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/DelegatingWebConnectionTests.java | @@ -0,0 +1,137 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ ... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/ForwardController.java | @@ -0,0 +1,31 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/HelloController.java | @@ -0,0 +1,34 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/HostRequestMatcherTests.java | @@ -0,0 +1,79 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/HtmlUnitRequestBuilderTests.java | @@ -0,0 +1,782 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockMvcConnectionBuilderSupportTests.java | @@ -0,0 +1,155 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockMvcWebClientBuilderTests.java | @@ -0,0 +1,117 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ ... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockMvcWebConnectionTests.java | @@ -0,0 +1,92 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/MockWebResponseBuilderTests.java | @@ -0,0 +1,135 @@
+/*
+ * Copyright 2012 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless ... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/UrlRegexRequestMatcherTests.java | @@ -0,0 +1,43 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/webdriver/MockMvcHtmlUnitDriverBuilderTests.java | @@ -0,0 +1,136 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ ... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/webdriver/WebConnectionHtmlUnitDriverTests.java | @@ -0,0 +1,55 @@
+package org.springframework.test.web.servlet.htmlunit.webdriver;
+
+import com.gargoylesoftware.htmlunit.WebConnection;
+import com.gargoylesoftware.htmlunit.WebRequest;
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.... | true |
Other | spring-projects | spring-framework | b73e39423c6b44f4cc30a38528bbf5d162754f51.json | Introduce support for HtmlUnit in Spring MVC Test
This commit introduces integration between MockMvc and HtmlUnit, thus
simplifying end-to-end testing when using HTML-based views and enabling
developers to do the following.
- Easily test HTML pages using tools such as HtmlUnit, WebDriver, & Geb
without the need t... | src/asciidoc/testing.adoc | @@ -4154,6 +4154,778 @@ https://github.com/spring-projects/spring-mvc-showcase[spring-mvc-showcase] has
coverage based on Spring MVC Test.
+[[spring-mvc-test-server-htmlunit]]
+==== HtmlUnit Integration
+
+Spring provides integration between <<spring-mvc-test-server,MockMvc>> and
+http://htmlunit.sourceforge.net/[... | true |
Other | spring-projects | spring-framework | aae0bd2fb43092bd3e1bc5c3296265e760b4fc43.json | Update TODO for SPR-13280 | spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java | @@ -243,7 +243,7 @@ private void loadBeanDefinitionsForBeanMethod(BeanMethod beanMethod) {
// Consider scoping
ScopedProxyMode proxyMode = ScopedProxyMode.NO;
- // TODO Determine why type is hard coded to org.springframework.context.annotation.Scope,
+ // TODO [SPR-13280] Determine why type is hard coded to o... | false |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/annotation/Commit.java | @@ -0,0 +1,57 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/annotation/Rollback.java | @@ -24,8 +24,9 @@
import static java.lang.annotation.RetentionPolicy.*;
/**
- * Test annotation used to indicate whether a <em>test-managed transaction</em>
- * should be <em>rolled back</em> after the test method has completed.
+ * {@code @Rollback} is a test annotation that is used to indicate whether
+ * a <em>t... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/context/junit4/AbstractTransactionalJUnit4SpringContextTests.java | @@ -85,6 +85,7 @@
* @see org.springframework.test.context.jdbc.SqlScriptsTestExecutionListener
* @see org.springframework.test.context.transaction.TransactionConfiguration
* @see org.springframework.transaction.annotation.Transactional
+ * @see org.springframework.test.annotation.Commit
* @see org.springframewo... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/context/testng/AbstractTransactionalTestNGSpringContextTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -69,6 +69,7 @@
* @see org.springframework.... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionConfiguration.java | @@ -34,6 +34,7 @@
* @since 2.5
* @see TransactionalTestExecutionListener
* @see org.springframework.transaction.annotation.Transactional
+ * @see org.springframework.test.annotation.Commit
* @see org.springframework.test.annotation.Rollback
* @see org.springframework.test.context.jdbc.Sql
* @see org.springf... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionalTestExecutionListener.java | @@ -120,6 +120,7 @@
* @since 2.5
* @see org.springframework.transaction.annotation.TransactionManagementConfigurer
* @see org.springframework.transaction.annotation.Transactional
+ * @see org.springframework.test.annotation.Commit
* @see org.springframework.test.annotation.Rollback
* @see BeforeTransaction
... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/testng/transaction/ejb/CommitForRequiredEjbTxDaoTestNGTests.java | @@ -16,8 +16,8 @@
package org.springframework.test.context.testng.transaction.ejb;
+import org.springframework.test.annotation.Commit;
import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.transaction.Commit;
import org.springframework.test.context.transaction.Tra... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/testng/transaction/ejb/CommitForRequiresNewEjbTxDaoTestNGTests.java | @@ -16,8 +16,8 @@
package org.springframework.test.context.testng.transaction.ejb;
+import org.springframework.test.annotation.Commit;
import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.transaction.Commit;
import org.springframework.test.context.transaction.Tra... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/testng/transaction/programmatic/ProgrammaticTxMgmtTestNGTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,7 +26,7 @@
import org.springframework.c... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/transaction/Commit.java | @@ -1,37 +0,0 @@
-/*
- * Copyright 2002-2015 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- ... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/transaction/TransactionalTestExecutionListenerTests.java | @@ -27,6 +27,7 @@
import org.mockito.BDDMockito;
import org.springframework.core.annotation.AliasFor;
+import org.springframework.test.annotation.Commit;
import org.springframework.test.annotation.Rollback;
import org.springframework.test.context.TestContext;
import org.springframework.transaction.PlatformTransa... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/transaction/ejb/CommitForRequiredEjbTxDaoTests.java | @@ -16,8 +16,8 @@
package org.springframework.test.context.transaction.ejb;
+import org.springframework.test.annotation.Commit;
import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.transaction.Commit;
import org.springframework.test.context.transaction.Transactio... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/transaction/ejb/CommitForRequiresNewEjbTxDaoTests.java | @@ -16,8 +16,8 @@
package org.springframework.test.context.transaction.ejb;
+import org.springframework.test.annotation.Commit;
import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.transaction.Commit;
import org.springframework.test.context.transaction.Transactio... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | spring-test/src/test/java/org/springframework/test/context/transaction/programmatic/ProgrammaticTxMgmtTests.java | @@ -37,7 +37,7 @@
import org.springframework.jdbc.datasource.DataSourceTransactionManager;
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
import org.springframework.jdbc.datasource.init.ResourceDatabasePopulator;
-import org.springframework.test.annotation.Rollback;
+import org.springfr... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | src/asciidoc/testing.adoc | @@ -799,13 +799,36 @@ for an example and further details.
+
+* `@Commit`
+
++
+
+Indicates that the transaction for a transactional test method should be __committed__
+after the test method has completed. `@Commit` can be used as a direct replacement for
+`@Rollback(false)` in order to more explicitly convey the ... | true |
Other | spring-projects | spring-framework | d6bdfcaa6e29ef40ead5dbbfd3e2bf6d6373f026.json | Introduce @Commit alias for @Rollback(false)
Due to common usage of @Rollback(false), this commit introduces a new
@Commit annotation that more clearly conveys the intent of the code
while retaining the run-time semantics.
@Commit is in fact meta-annotated with @Rollback(false).
Issue: SPR-13279 | src/asciidoc/whats-new.adoc | @@ -577,6 +577,8 @@ public @interface MyTestConfig {
_before_ a test -- for example, if some rogue (i.e., yet to be
determined) test within a large test suite has corrupted the original
configuration for the `ApplicationContext`.
+* `@Commit` is a new annotation that may be used as a direct replacement for
+ ... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/main/java/org/springframework/test/annotation/Rollback.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,25 +24,36 @@
import static java.lang.an... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/main/java/org/springframework/test/context/transaction/TestContextTransactionUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,8 +36,8 @@
/**
* Utility methods fo... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionConfiguration.java | @@ -39,7 +39,10 @@
* @see org.springframework.test.context.jdbc.SqlConfig
* @see org.springframework.test.context.jdbc.SqlConfig#transactionManager
* @see org.springframework.test.context.ContextConfiguration
+ * @deprecated As of Spring Framework 4.2, use {@code @Rollback} at the class
+ * level and the {@code t... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionConfigurationAttributes.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2008 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,29 +36,42 @@ public class TransactionCon... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionalTestExecutionListener.java | @@ -30,7 +30,6 @@
import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.annotation.BeanFactoryAnnotationUtils;
import org.springframework.core.annotation.AnnotatedElementUtils;
-import org.springframework.core.annotation.AnnotationUtils;
import org.springframework.test.annot... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/DefaultRollbackFalseRollbackAnnotationTransactionalTests.java | @@ -0,0 +1,110 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/DefaultRollbackFalseTransactionalTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,7 +23,6 @@
import org.junit.Before;
im... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/DefaultRollbackTrueRollbackAnnotationTransactionalTests.java | @@ -0,0 +1,111 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/DefaultRollbackTrueTransactionalTests.java | @@ -23,7 +23,6 @@
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
-
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.transaction.TransactionConfiguration;
@@ -43,19 +42,15 @@
... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackFalseRollbackAnnotationTransactionalTests.java | @@ -0,0 +1,82 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackFalseTransactionalTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -31,7 +31,7 @@
import static org.springfram... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackTrueRollbackAnnotationTransactionalTests.java | @@ -0,0 +1,80 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackTrueTransactionalTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,13 +26,12 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/junit4/SpringJUnit4TestSuite.java | @@ -55,7 +55,7 @@
*
* <p>Note that tests included in this suite will be executed at least twice if
* run from an automated build process, test runner, etc. that is not configured
- * to exclude tests based on a "*TestSuite.class" pattern match.
+ * to exclude tests based on a {@code "*TestSuite.class"} ... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/java/org/springframework/test/context/transaction/TransactionalTestExecutionListenerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,9 +20,13 @@
import java.lang.annotation... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/resources/org/springframework/test/context/junit4/DefaultRollbackFalseTransactionalTests-context.xml | @@ -10,6 +10,6 @@
p:data-source-ref="dataSource" />
<bean id="databaseSetup"
- class="org.springframework.test.context.junit4.DefaultRollbackFalseTransactionalSpringRunnerTests$DatabaseSetup" />
+ class="org.springframework.test.context.junit4.DefaultRollbackFalseTransactionalTests$DatabaseSetup" />
</beans... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/resources/org/springframework/test/context/junit4/DefaultRollbackTrueTransactionalTests-context.xml | @@ -3,6 +3,6 @@
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">
<bean id="databaseSetup"
- class="org.springframework.test.context.junit4.DefaultRollbackTrueTransactionalSpringRunnerTests$DatabaseSetup" />
+ class="org.springfram... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/resources/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackFalseTransactionalTests-context.xml | @@ -10,6 +10,6 @@
p:data-source-ref="dataSource" />
<bean id="databaseSetup"
- class="org.springframework.test.context.junit4.RollbackOverrideDefaultRollbackFalseTransactionalSpringRunnerTests$DatabaseSetup" />
+ class="org.springframework.test.context.junit4.RollbackOverrideDefaultRollbackFalseTransactionalTe... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/resources/org/springframework/test/context/junit4/RollbackOverrideDefaultRollbackTrueTransactionalTests-context.xml | @@ -3,6 +3,6 @@
xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">
<bean id="databaseSetup"
- class="org.springframework.test.context.junit4.RollbackOverrideDefaultRollbackTrueTransactionalSpringRunnerTests$DatabaseSetup" />
+ class... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | spring-test/src/test/resources/org/springframework/test/context/junit4/person-schema.sql | @@ -0,0 +1 @@
+CREATE TABLE person (name VARCHAR(20) NOT NULL, PRIMARY KEY(name))
\ No newline at end of file | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | src/asciidoc/testing.adoc | @@ -264,8 +264,7 @@ application context.
If you want a transaction to commit -- unusual, but occasionally useful when you want a
particular test to populate or modify the database -- the TestContext framework can be
instructed to cause the transaction to commit instead of roll back via the
-<<integration-testing-ann... | true |
Other | spring-projects | spring-framework | 3f8b51283e8c5a6e07bc3b5cc62659e831e19093.json | Support @Rollback on classes & deprecate @TxConfig
Since Spring Framework 2.5, @Rollback has been supported on test
methods, with class-level rollback settings configured via
@TransactionConfiguration; however, allowing @Rollback to be declared
on test classes with method-level declarations overriding class-level
decl... | src/asciidoc/whats-new.adoc | @@ -577,6 +577,9 @@ public @interface MyTestConfig {
_before_ a test -- for example, if some rogue (i.e., yet to be
determined) test within a large test suite has corrupted the original
configuration for the `ApplicationContext`.
+* `@Rollback` may now be used to configure class-level _default rollback_ semant... | true |
Other | spring-projects | spring-framework | 43e36e2dee8e2c7be54ba3715cc355c8a35f9efc.json | Improve DateHeaders in MockServletRequest/Response
Prior to this change, calling the `setDateHeader` method on a
Spring Test MockHttpServletResponse instance would just store the given
long value in a Map, not writing it as a formatted date String.
Also, calling `getDateHeader` on a MockHttpServletRequest would not
su... | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletRequest.java | @@ -24,6 +24,8 @@
import java.io.Reader;
import java.io.UnsupportedEncodingException;
import java.security.Principal;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
@@ -36,6 +38,8 @@
import java.util.Locale;
... | true |
Other | spring-projects | spring-framework | 43e36e2dee8e2c7be54ba3715cc355c8a35f9efc.json | Improve DateHeaders in MockServletRequest/Response
Prior to this change, calling the `setDateHeader` method on a
Spring Test MockHttpServletResponse instance would just store the given
long value in a Map, not writing it as a formatted date String.
Also, calling `getDateHeader` on a MockHttpServletRequest would not
su... | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletResponse.java | @@ -23,12 +23,16 @@
import java.io.PrintWriter;
import java.io.UnsupportedEncodingException;
import java.io.Writer;
+import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
+import java.util.Date;
import java.util.List;
import java.util.Locale;
... | true |
Other | spring-projects | spring-framework | 43e36e2dee8e2c7be54ba3715cc355c8a35f9efc.json | Improve DateHeaders in MockServletRequest/Response
Prior to this change, calling the `setDateHeader` method on a
Spring Test MockHttpServletResponse instance would just store the given
long value in a Map, not writing it as a formatted date String.
Also, calling `getDateHeader` on a MockHttpServletRequest would not
su... | spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
import java.util.ArrayList;
... | true |
Other | spring-projects | spring-framework | 43e36e2dee8e2c7be54ba3715cc355c8a35f9efc.json | Improve DateHeaders in MockServletRequest/Response
Prior to this change, calling the `setDateHeader` method on a
Spring Test MockHttpServletResponse instance would just store the given
long value in a Map, not writing it as a formatted date String.
Also, calling `getDateHeader` on a MockHttpServletRequest would not
su... | spring-test/src/test/java/org/springframework/mock/web/MockHttpServletResponseTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
import java.io.IOException;
... | true |
Other | spring-projects | spring-framework | 43e36e2dee8e2c7be54ba3715cc355c8a35f9efc.json | Improve DateHeaders in MockServletRequest/Response
Prior to this change, calling the `setDateHeader` method on a
Spring Test MockHttpServletResponse instance would just store the given
long value in a Map, not writing it as a formatted date String.
Also, calling `getDateHeader` on a MockHttpServletRequest would not
su... | spring-web/src/test/java/org/springframework/mock/web/test/MockHttpServletRequest.java | @@ -24,6 +24,8 @@
import java.io.Reader;
import java.io.UnsupportedEncodingException;
import java.security.Principal;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
@@ -36,6 +38,8 @@
import java.util.Locale;
... | true |
Other | spring-projects | spring-framework | bb51447860113f2c17d5e8d4df22c0ca1817b8f3.json | Fix typos in RequestResultMatchers | spring-test/src/main/java/org/springframework/test/web/servlet/result/RequestResultMatchers.java | @@ -36,23 +36,23 @@
* {@link MockMvcResultMatchers#request}.
*
* @author Rossen Stoyanchev
+ * @author Sam Brannen
* @since 3.2
*/
public class RequestResultMatchers {
/**
* Protected constructor.
- * Use {@link MockMvcResultMatchers#request()}.
+ * <p>Use {@link MockMvcResultMatchers#request()}.
... | false |
Other | spring-projects | spring-framework | cf2aed9d005686a7955c2ccfd42c07526b24fbd3.json | Add a dateValue HeaderResultMatcher
HTTP headers such as "Expires", "Last-Modified" all use date
strings like "Tue, 21 Jul 2015 10:00:00 GMT". Prior to this commit,
there was no way to match those header values, besides formatting dates
manually.
This commit introduces a new HeaderResultMatcher to test those date
hea... | spring-test/src/main/java/org/springframework/test/web/servlet/result/HeaderResultMatchers.java | @@ -24,13 +24,19 @@
import static org.hamcrest.MatcherAssert.*;
import static org.springframework.test.util.AssertionErrors.*;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.Locale;
+import java.util.TimeZone;
+
/**
* Factory for response header assertions.
* <p>An instance of th... | true |
Other | spring-projects | spring-framework | cf2aed9d005686a7955c2ccfd42c07526b24fbd3.json | Add a dateValue HeaderResultMatcher
HTTP headers such as "Expires", "Last-Modified" all use date
strings like "Tue, 21 Jul 2015 10:00:00 GMT". Prior to this commit,
there was no way to match those header values, besides formatting dates
manually.
This commit introduces a new HeaderResultMatcher to test those date
hea... | spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/HeaderAssertionTests.java | @@ -19,13 +19,13 @@
import org.junit.Before;
import org.junit.Test;
+import org.springframework.http.ResponseEntity;
import org.springframework.stereotype.Controller;
import org.springframework.test.web.Person;
import org.springframework.test.web.servlet.MockMvc;
import org.springframework.test.web.servlet.Resu... | true |
Other | spring-projects | spring-framework | 088a50c1fbd4fd4d0cc89fb8733c90bff796b611.json | Improve setDateHeader impl in MockServletResponse
Prior to this change, calling the `setDateHeader` method on a
MockHttpServletResponse instance (internal implementation for testing
the spring-web module) would just store the given long value in a Map,
not writing it as a formatted date String.
This can be problemati... | spring-web/src/test/java/org/springframework/mock/web/test/MockHttpServletResponse.java | @@ -23,12 +23,16 @@
import java.io.PrintWriter;
import java.io.UnsupportedEncodingException;
import java.io.Writer;
+import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
+import java.util.Date;
import java.util.List;
import java.util.Locale;
... | true |
Other | spring-projects | spring-framework | 088a50c1fbd4fd4d0cc89fb8733c90bff796b611.json | Improve setDateHeader impl in MockServletResponse
Prior to this change, calling the `setDateHeader` method on a
MockHttpServletResponse instance (internal implementation for testing
the spring-web module) would just store the given long value in a Map,
not writing it as a formatted date String.
This can be problemati... | spring-web/src/test/java/org/springframework/web/context/request/ServletWebRequestHttpMethodsTests.java | @@ -107,7 +107,7 @@ public void checkNotModifiedTimestamp() throws Exception {
assertTrue(request.checkNotModified(epochTime));
assertEquals(304, servletResponse.getStatus());
- assertEquals("" + epochTime, servletResponse.getHeader("Last-Modified"));
+ assertEquals(dateFormat.format(epochTime), servletRespon... | true |
Other | spring-projects | spring-framework | 088a50c1fbd4fd4d0cc89fb8733c90bff796b611.json | Improve setDateHeader impl in MockServletResponse
Prior to this change, calling the `setDateHeader` method on a
MockHttpServletResponse instance (internal implementation for testing
the spring-web module) would just store the given long value in a Map,
not writing it as a formatted date String.
This can be problemati... | spring-webmvc/src/test/java/org/springframework/web/servlet/DispatcherServletTests.java | @@ -177,7 +177,7 @@ public void testLocaleRequest() throws Exception {
MockHttpServletResponse response = new MockHttpServletResponse();
simpleDispatcherServlet.service(request, response);
assertTrue("Not forwarded", response.getForwardedUrl() == null);
- assertEquals("1427846400000", response.getHeader("Last... | true |
Other | spring-projects | spring-framework | 088a50c1fbd4fd4d0cc89fb8733c90bff796b611.json | Improve setDateHeader impl in MockServletResponse
Prior to this change, calling the `setDateHeader` method on a
MockHttpServletResponse instance (internal implementation for testing
the spring-web module) would just store the given long value in a Map,
not writing it as a formatted date String.
This can be problemati... | spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java | @@ -26,7 +26,6 @@
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.Date;
import java.util.List;
import java.util.Locale;
import java.util.TimeZone;
@@ -56,6 +55,8 @@
*/
public class ResourceHttpRequestHandlerTests {
+ private SimpleDateFormat dateForma... | true |
Other | spring-projects | spring-framework | 327785d19ebcf56163d173fac54b4c9c729b20b3.json | Fix typo in resource handling reference doc | src/asciidoc/web-mvc.adoc | @@ -5162,9 +5162,9 @@ use directly the `ResourceUrlProvider` bean, which is automatically declared wit
Java config and the MVC namespace.
Webjars are also supported with `WebJarsResourceResolver`, which is automatically registered
-when the ``"org.webjars:webjars-locator"` library is on classpath. This resolver all... | false |
Other | spring-projects | spring-framework | 09e3fc40e5c24a9e10e807f892e1158ba16680d1.json | Reset Pragma header in WebContentGenerator
As filter-based libraries and projects (such as Spring Security) may
use the "Pragma" header in HTTP responses, WebContentGenerator should
make sure that such headers are overwritten to avoid clashes with
the HTTP caching headers set by the HTTP caching configuration.
Issue:... | spring-webmvc/src/main/java/org/springframework/web/servlet/support/WebContentGenerator.java | @@ -394,6 +394,9 @@ else if (cacheControl != null) {
String ccValue = cacheControl.getHeaderValue();
if (ccValue != null) {
response.setHeader(HEADER_CACHE_CONTROL, ccValue);
+ if (response.containsHeader(HEADER_PRAGMA)) {
+ response.setHeader(HEADER_PRAGMA, "");
+ }
}
}
}
@@ -430,6 +433... | true |
Other | spring-projects | spring-framework | 09e3fc40e5c24a9e10e807f892e1158ba16680d1.json | Reset Pragma header in WebContentGenerator
As filter-based libraries and projects (such as Spring Security) may
use the "Pragma" header in HTTP responses, WebContentGenerator should
make sure that such headers are overwritten to avoid clashes with
the HTTP caching headers set by the HTTP caching configuration.
Issue:... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/WebContentInterceptorTests.java | @@ -105,6 +105,34 @@ public void emptyCacheConfiguration() throws Exception {
assertThat(cacheControlHeaders, Matchers.emptyIterable());
}
+ // SPR-13252
+ @Test
+ public void cachingConfigAndPragmaHeader() throws Exception {
+ WebContentInterceptor interceptor = new WebContentInterceptor();
+ interceptor.setC... | true |
Other | spring-projects | spring-framework | d8fb6c557d890c2404c6bbc42790be469af55fe2.json | Delete unused imports in HeaderAssertionTests | spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/HeaderAssertionTests.java | @@ -34,10 +34,6 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
import static org.springframework.test.web.servlet.setup.MockMvcBuilders.*;
-import java.text.SimpleDateFormat;
-import java.util.Locale;
-import java.util.TimeZone;
-
/**
* Examples of expectations on response ... | false |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/main/java/org/springframework/test/context/web/ServletTestExecutionListener.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -35,6 +35,7 @@
import org.springframework.t... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/main/java/org/springframework/test/web/servlet/MockMvc.java | @@ -26,6 +26,7 @@
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.util.Assert;
+import org.springframework.web.context.request.RequestAttributes;
import org.springframework.web.context.request.RequestContextHolder;
... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@
import javax.servlet.Servlet... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMultipartHttpServletRequestBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -105,6 +105,12 @@ public Object merge(Object... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMvcRequestBuilders.java | @@ -13,26 +13,39 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.springframework.test.web.servlet.request;
import java.net.URI;
import javax.servlet.ServletContext;
import org.springframework.http.HttpMethod;
import org.springfram... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/test/java/org/springframework/test/web/servlet/samples/spr/CustomRequestAttributesRequestContextHolderTests.java | @@ -0,0 +1,141 @@
+/*
+ * Copyright 2002-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | bf06bf33abbf0d3169ae6465757808cf3bc9e4ab.json | Reuse mock request from the TCF in Spring MVC Test
Prior to this commit, the Spring MVC Test Framework always created a
new MockHttpServletRequest, disregarding any mock request already
present in Spring Web's RequestContextHolder -- for example, one
created by the ServletTestExecutionListener in the Spring TestContex... | spring-test/src/test/java/org/springframework/test/web/servlet/samples/spr/RequestContextHolderTests.java | @@ -23,6 +23,7 @@
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
+import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -56,12 +57,16 @@
import static org.springframework.test.web.servlet.setup.MockMvcBuilders.*;
/**
- * Tests ... | true |
Other | spring-projects | spring-framework | 48b965ad333da1b4b8fb67dd5a08ad985b5ad135.json | Improve performance of NumberUtils
This commit aims to improve the space and time performance of
NumberUtils by invoking valueOf() factory methods instead of the
corresponding constructors when converting a number to a target class. | spring-core/src/main/java/org/springframework/util/NumberUtils.java | @@ -91,21 +91,21 @@ else if (Byte.class == targetClass) {
if (value < Byte.MIN_VALUE || value > Byte.MAX_VALUE) {
raiseOverflowException(number, targetClass);
}
- return (T) new Byte(number.byteValue());
+ return (T) Byte.valueOf(number.byteValue());
}
else if (Short.class == targetClass) {
l... | false |
Other | spring-projects | spring-framework | 1ef0015eb26303e51727a59a0bbb70cae1c9146b.json | Remove type parameter of ResponseBodyEmitter
Closes gh-851 | src/asciidoc/web-mvc.adoc | @@ -2196,8 +2196,8 @@ Here is an example of that:
[subs="verbatim,quotes"]
----
@RequestMapping("/events")
- public ResponseBodyEmitter<String> handle() {
- ResponseBodyEmitter<String> emitter = new ResponseBodyEmitter<String>();
+ public ResponseBodyEmitter handle() {
+ ResponseBodyEmitter emitter = new Response... | false |
Other | spring-projects | spring-framework | 80767ff6e9963761aa7e5516090fcda2c5a3bf74.json | Use sendError in ResponseStatusExceptionResolver
Prior to this commit, the `ResponseStatusExceptionResolver` would use:
* `HttpServletResponse.sendError` if both a status and a reason are set
on the `@ResponseStatus` annotation
* `HttpServletResponse.setStatus` if only a status is set on the
`@ResponseStatus` annotati... | spring-web/src/main/java/org/springframework/web/bind/annotation/ResponseStatus.java | @@ -30,11 +30,23 @@
* {@link #reason} that should be returned.
*
* <p>The status code is applied to the HTTP response when the handler
- * method is invoked, or whenever said exception is thrown.
+ * method is invoked.
+ *
+ * <p><strong>Note:</strong> when using this annotation on an exception class,
+ * or when... | true |
Other | spring-projects | spring-framework | 80767ff6e9963761aa7e5516090fcda2c5a3bf74.json | Use sendError in ResponseStatusExceptionResolver
Prior to this commit, the `ResponseStatusExceptionResolver` would use:
* `HttpServletResponse.sendError` if both a status and a reason are set
on the `@ResponseStatus` annotation
* `HttpServletResponse.setStatus` if only a status is set on the
`@ResponseStatus` annotati... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/annotation/ResponseStatusExceptionResolver.java | @@ -100,7 +100,7 @@ protected ModelAndView resolveResponseStatus(ResponseStatus responseStatus, Http
reason = this.messageSource.getMessage(reason, null, reason, LocaleContextHolder.getLocale());
}
if (!StringUtils.hasLength(reason)) {
- response.setStatus(statusCode);
+ response.sendError(statusCode);
... | true |
Other | spring-projects | spring-framework | 80767ff6e9963761aa7e5516090fcda2c5a3bf74.json | Use sendError in ResponseStatusExceptionResolver
Prior to this commit, the `ResponseStatusExceptionResolver` would use:
* `HttpServletResponse.sendError` if both a status and a reason are set
on the `@ResponseStatus` annotation
* `HttpServletResponse.setStatus` if only a status is set on the
`@ResponseStatus` annotati... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/annotation/ResponseStatusExceptionResolverTests.java | @@ -57,6 +57,7 @@ public void statusCode() {
assertNotNull("No ModelAndView returned", mav);
assertTrue("No Empty ModelAndView returned", mav.isEmpty());
assertEquals("Invalid status code", 400, response.getStatus());
+ assertTrue("Response has not been committed", response.isCommitted());
}
@Test
@@ -6... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/AbstractXhrTransport.java | @@ -26,7 +26,6 @@
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus;
-import org.springframework.http.MediaType;
import org.springframework.http.ResponseEntity;
import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.util.concurrent.SettableLi... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/DefaultTransportRequest.java | @@ -52,6 +52,8 @@ class DefaultTransportRequest implements TransportRequest {
private final HttpHeaders handshakeHeaders;
+ private final HttpHeaders httpRequestHeaders;
+
private final Transport transport;
private final TransportType serverTransportType;
@@ -69,7 +71,8 @@ class DefaultTransportRequest impl... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/InfoReceiver.java | @@ -17,6 +17,8 @@
import java.net.URI;
+import org.springframework.http.HttpHeaders;
+
/**
* A component that can execute the SockJS "Info" request that needs to be
* performed before the SockJS session starts in order to check server endpoint
@@ -34,10 +36,11 @@ public interface InfoReceiver {
/**
* Per... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/JettyXhrTransport.java | @@ -106,11 +106,12 @@ public boolean isRunning() {
@Override
- protected void connectInternal(TransportRequest request, WebSocketHandler handler,
+ protected void connectInternal(TransportRequest transportRequest, WebSocketHandler handler,
URI url, HttpHeaders handshakeHeaders, XhrClientSockJsSession session,... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/RestTemplateXhrTransport.java | @@ -94,15 +94,16 @@ public TaskExecutor getTaskExecutor() {
@Override
- protected void connectInternal(final TransportRequest request, final WebSocketHandler handler,
+ protected void connectInternal(final TransportRequest transportRequest, final WebSocketHandler handler,
final URI receiveUrl, final HttpHeade... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/SockJsClient.java | @@ -78,6 +78,8 @@ public class SockJsClient implements WebSocketClient, Lifecycle {
private final List<Transport> transports;
+ private String[] httpHeaderNames;
+
private InfoReceiver infoReceiver;
private SockJsMessageCodec messageCodec;
@@ -116,6 +118,30 @@ private static InfoReceiver initInfoReceiver(Li... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/TransportRequest.java | @@ -47,6 +47,13 @@ public interface TransportRequest {
*/
HttpHeaders getHandshakeHeaders();
+ /**
+ * Return the headers to add to all other HTTP requests besides the handshake
+ * request such XHR receive and send requests.
+ * @since 4.2
+ */
+ HttpHeaders getHttpRequestHeaders();
+
/**
* Return the ... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/UndertowXhrTransport.java | @@ -134,11 +134,11 @@ protected void connectInternal(TransportRequest request, WebSocketHandler handle
HttpHeaders handshakeHeaders, XhrClientSockJsSession session,
SettableListenableFuture<WebSocketSession> connectFuture) {
- executeReceiveRequest(receiveUrl, handshakeHeaders, session, connectFuture);
+ ex... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/XhrClientSockJsSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,8 @@
import java.net.URI;
import... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/XhrTransport.java | @@ -17,14 +17,14 @@
import java.net.URI;
+import org.springframework.http.HttpHeaders;
import org.springframework.web.socket.TextMessage;
/**
* A SockJS {@link Transport} that uses HTTP requests to simulate a WebSocket
* interaction. The {@code connect} method of the base {@code Transport} interface
* is... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/AbstractSockJsIntegrationTests.java | @@ -49,6 +49,8 @@
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.server.ServletServerHttpRequest;
import org... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/ClientSockJsSessionTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -64,7 +64,7 @@ public class ClientSockJsSess... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/DefaultTransportRequestTests.java | @@ -127,7 +127,7 @@ public void fallbackAfterTimeout() throws Exception {
protected DefaultTransportRequest createTransportRequest(Transport transport, TransportType type) throws Exception {
SockJsUrlInfo urlInfo = new SockJsUrlInfo(new URI("http://example.com"));
- return new DefaultTransportRequest(urlInfo, n... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/RestTemplateXhrTransportTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -182,7 +182,8 @@ private ListenableFuture<We... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/SockJsClientTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,22 +16,34 @@
package org.springframew... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/TestTransport.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -18,17 +18,21 @@
import java.net.URI;
im... | true |
Other | spring-projects | spring-framework | b7bdd724b2eab6959eade7868cfb1ecf21aa118b.json | Simplify use of headers for SockJsClient requests
Before this change, XhrTransport implementations had to be configured
with the headers to use for HTTP requests other than the initial
handshake.
After this change the handshake headers passed to SockJsClient by
default are used for all other HTTP requests related to ... | spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/XhrTransportTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -46,25 +46,25 @@ public class XhrTransportTe... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.