language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/mail/javamail/ConfigurableMimeFileTypeMap.java
@@ -101,6 +101,7 @@ public void setMappings(String[] mappings) { /** * Creates the final merged mapping set. */ + @Override public void afterPropertiesSet() { getFileTypeMap(); }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/mail/javamail/JavaMailSenderImpl.java
@@ -292,10 +292,12 @@ public FileTypeMap getDefaultFileTypeMap() { // Implementation of MailSender //--------------------------------------------------------------------- + @Override public void send(SimpleMailMessage simpleMessage) throws MailException { send(new SimpleMailMessage[] { simpleMessage }); } ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/mail/javamail/MimeMailMessage.java
@@ -73,6 +73,7 @@ public final MimeMessage getMimeMessage() { } + @Override public void setFrom(String from) throws MailParseException { try { this.helper.setFrom(from); @@ -82,6 +83,7 @@ public void setFrom(String from) throws MailParseException { } } + @Override public void setReplyTo(String r...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/mail/javamail/MimeMessageHelper.java
@@ -1088,15 +1088,19 @@ protected DataSource createDataSource( final InputStreamSource inputStreamSource, final String contentType, final String name) { return new DataSource() { + @Override public InputStream getInputStream() throws IOException { return inputStreamSource.getInputStream(); } + ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/DelegatingTimerListener.java
@@ -47,6 +47,7 @@ public DelegatingTimerListener(Runnable runnable) { /** * Delegates execution to the underlying Runnable. */ + @Override public void timerExpired(Timer timer) { this.runnable.run(); }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/DelegatingWork.java
@@ -57,6 +57,7 @@ public final Runnable getDelegate() { /** * Delegates execution to the underlying Runnable. */ + @Override public void run() { this.delegate.run(); } @@ -66,6 +67,7 @@ public void run() { * {@link org.springframework.scheduling.SchedulingAwareRunnable#isLongLived()}, * if availabl...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/TimerManagerAccessor.java
@@ -95,6 +95,7 @@ public void setShared(boolean shared) { } + @Override public void afterPropertiesSet() throws NamingException { if (this.timerManager == null) { if (this.timerManagerName == null) { @@ -117,6 +118,7 @@ protected final TimerManager getTimerManager() { * Resumes the underlying TimerMan...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/TimerManagerFactoryBean.java
@@ -76,6 +76,7 @@ public void setScheduledTimerListeners(ScheduledTimerListener[] scheduledTimerLi // Implementation of InitializingBean interface //--------------------------------------------------------------------- + @Override public void afterPropertiesSet() throws NamingException { super.afterPropertie...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/TimerManagerTaskScheduler.java
@@ -52,38 +52,44 @@ public void setErrorHandler(ErrorHandler errorHandler) { } + @Override public ScheduledFuture schedule(Runnable task, Trigger trigger) { return new ReschedulingTimerListener(errorHandlingTask(task, true), trigger).schedule(); } + @Override public ScheduledFuture schedule(Runnable ta...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/commonj/WorkManagerTaskExecutor.java
@@ -109,6 +109,7 @@ public void setWorkListener(WorkListener workListener) { this.workListener = workListener; } + @Override public void afterPropertiesSet() throws NamingException { if (this.workManager == null) { if (this.workManagerName == null) { @@ -123,6 +124,7 @@ public void afterPropertiesSet() ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/AdaptableJobFactory.java
@@ -50,6 +50,7 @@ public Job newJob(TriggerFiredBundle bundle, Scheduler scheduler) throws Schedul /** * Quartz 1.x version of newJob: contains actual implementation code. */ + @Override public Job newJob(TriggerFiredBundle bundle) throws SchedulerException { try { Object jobObject = createJobInstance(...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/CronTriggerBean.java
@@ -139,15 +139,18 @@ public void setJobDetail(JobDetail jobDetail) { this.jobDetail = jobDetail; } + @Override public JobDetail getJobDetail() { return this.jobDetail; } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void afterProperti...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/CronTriggerFactoryBean.java
@@ -191,11 +191,13 @@ public void setMisfireInstructionName(String constantName) { this.misfireInstruction = constants.asNumber(constantName).intValue(); } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void afterPropertiesSet() { if (this.na...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/DelegatingJob.java
@@ -60,6 +60,7 @@ public final Runnable getDelegate() { /** * Delegates execution to the underlying Runnable. */ + @Override public void execute(JobExecutionContext context) throws JobExecutionException { this.delegate.run(); }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/JobDetailBean.java
@@ -115,10 +115,12 @@ public void setJobListenerNames(String[] names) { } } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void setApplicationContext(ApplicationContext applicationContext) { this.applicationContext = applicationContext; } @@ ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/JobDetailFactoryBean.java
@@ -139,10 +139,12 @@ public void setDescription(String description) { this.description = description; } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void setApplicationContext(ApplicationContext applicationContext) { this.applicationContext ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/LocalDataSourceJobStore.java
@@ -101,10 +101,12 @@ public void initialize(ClassLoadHelper loadHelper, SchedulerSignaler signaler) DBConnectionManager.getInstance().addConnectionProvider( TX_DATA_SOURCE_PREFIX + getInstanceName(), new ConnectionProvider() { + @Override public Connection getConnection() throws SQLException { ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/LocalTaskExecutorThreadPool.java
@@ -40,13 +40,16 @@ public class LocalTaskExecutorThreadPool implements ThreadPool { private Executor taskExecutor; + @Override public void setInstanceId(String schedInstId) { } + @Override public void setInstanceName(String schedName) { } + @Override public void initialize() throws SchedulerConfi...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/MethodInvokingJobDetailFactoryBean.java
@@ -176,14 +176,17 @@ public void setJobListenerNames(String[] names) { this.jobListenerNames = names; } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void setBeanClassLoader(ClassLoader classLoader) { this.beanClassLoader = classLoader; } ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/QuartzJobBean.java
@@ -92,6 +92,7 @@ public abstract class QuartzJobBean implements Job { * values, and delegates to {@code executeInternal} afterwards. * @see #executeInternal */ + @Override public final void execute(JobExecutionContext context) throws JobExecutionException { try { // Reflectively adapting to differenc...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/ResourceLoaderClassLoadHelper.java
@@ -62,6 +62,7 @@ public ResourceLoaderClassLoadHelper(ResourceLoader resourceLoader) { } + @Override public void initialize() { if (this.resourceLoader == null) { this.resourceLoader = SchedulerFactoryBean.getConfigTimeResourceLoader(); @@ -71,6 +72,7 @@ public void initialize() { } } + @Override...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SchedulerAccessor.java
@@ -239,6 +239,7 @@ public void setTransactionManager(PlatformTransactionManager transactionManager) this.transactionManager = transactionManager; } + @Override public void setResourceLoader(ResourceLoader resourceLoader) { this.resourceLoader = resourceLoader; }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SchedulerAccessorBean.java
@@ -73,11 +73,13 @@ public Scheduler getScheduler() { return this.scheduler; } + @Override public void setBeanFactory(BeanFactory beanFactory) { this.beanFactory = beanFactory; } + @Override public void afterPropertiesSet() throws SchedulerException { if (this.scheduler == null) { if (this.sc...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SchedulerFactoryBean.java
@@ -369,6 +369,7 @@ public void setAutoStartup(boolean autoStartup) { * the scheduler will start after the context is refreshed and after the * start delay, if any. */ + @Override public boolean isAutoStartup() { return this.autoStartup; } @@ -387,6 +388,7 @@ public void setPhase(int phase) { /** *...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SimpleThreadPoolTaskExecutor.java
@@ -59,28 +59,33 @@ public void setWaitForJobsToCompleteOnShutdown(boolean waitForJobsToCompleteOnSh this.waitForJobsToCompleteOnShutdown = waitForJobsToCompleteOnShutdown; } + @Override public void afterPropertiesSet() throws SchedulerConfigException { initialize(); } + @Override public void execut...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SimpleTriggerBean.java
@@ -144,15 +144,18 @@ public void setJobDetail(JobDetail jobDetail) { this.jobDetail = jobDetail; } + @Override public JobDetail getJobDetail() { return this.jobDetail; } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void afterProperti...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SimpleTriggerFactoryBean.java
@@ -195,11 +195,13 @@ public void setMisfireInstructionName(String constantName) { this.misfireInstruction = constants.asNumber(constantName).intValue(); } + @Override public void setBeanName(String beanName) { this.beanName = beanName; } + @Override public void afterPropertiesSet() throws ParseExce...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/scheduling/quartz/SpringBeanJobFactory.java
@@ -63,6 +63,7 @@ public void setIgnoredUnknownProperties(String[] ignoredUnknownProperties) { this.ignoredUnknownProperties = ignoredUnknownProperties; } + @Override public void setSchedulerContext(SchedulerContext schedulerContext) { this.schedulerContext = schedulerContext; }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/ui/freemarker/FreeMarkerConfigurationFactoryBean.java
@@ -56,19 +56,23 @@ public class FreeMarkerConfigurationFactoryBean extends FreeMarkerConfigurationF private Configuration configuration; + @Override public void afterPropertiesSet() throws IOException, TemplateException { this.configuration = createConfiguration(); } + @Override public Configuration...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/ui/freemarker/SpringTemplateLoader.java
@@ -63,6 +63,7 @@ public SpringTemplateLoader(ResourceLoader resourceLoader, String templateLoader } } + @Override public Object findTemplateSource(String name) throws IOException { if (logger.isDebugEnabled()) { logger.debug("Looking for FreeMarker template with name [" + name + "]"); @@ -71,6 +72,7 @@...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context-support/src/main/java/org/springframework/ui/velocity/VelocityEngineFactoryBean.java
@@ -53,19 +53,23 @@ public class VelocityEngineFactoryBean extends VelocityEngineFactory private VelocityEngine velocityEngine; + @Override public void afterPropertiesSet() throws IOException, VelocityException { this.velocityEngine = createVelocityEngine(); } + @Override public VelocityEngine getObj...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/annotation/AbstractCachingConfiguration.java
@@ -50,6 +50,7 @@ public abstract class AbstractCachingConfiguration implements ImportAware { @Autowired(required=false) private Collection<CachingConfigurer> cachingConfigurers; + @Override public void setImportMetadata(AnnotationMetadata importMetadata) { this.enableCaching = AnnotationAttributes.fromMap( ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/annotation/CachingConfigurationSelector.java
@@ -39,6 +39,7 @@ public class CachingConfigurationSelector extends AdviceModeImportSelector<Enabl * @return {@link ProxyCachingConfiguration} or {@code AspectJCacheConfiguration} for * {@code PROXY} and {@code ASPECTJ} values of {@link EnableCaching#mode()}, respectively */ + @Override public String[] selec...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/annotation/SpringCacheAnnotationParser.java
@@ -41,6 +41,7 @@ @SuppressWarnings("serial") public class SpringCacheAnnotationParser implements CacheAnnotationParser, Serializable { + @Override public Collection<CacheOperation> parseCacheAnnotations(AnnotatedElement ae) { Collection<CacheOperation> ops = null;
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/concurrent/ConcurrentMapCache.java
@@ -83,10 +83,12 @@ public ConcurrentMapCache(String name, ConcurrentMap<Object, Object> store, bool } + @Override public String getName() { return this.name; } + @Override public ConcurrentMap getNativeCache() { return this.store; } @@ -95,19 +97,23 @@ public boolean isAllowNullValues() { retu...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/concurrent/ConcurrentMapCacheFactoryBean.java
@@ -74,26 +74,31 @@ public void setAllowNullValues(boolean allowNullValues) { this.allowNullValues = allowNullValues; } + @Override public void setBeanName(String beanName) { if (!StringUtils.hasLength(this.name)) { setName(beanName); } } + @Override public void afterPropertiesSet() { this.c...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/concurrent/ConcurrentMapCacheManager.java
@@ -71,10 +71,12 @@ public void setCacheNames(Collection<String> cacheNames) { } } + @Override public Collection<String> getCacheNames() { return Collections.unmodifiableSet(this.cacheMap.keySet()); } + @Override public Cache getCache(String name) { Cache cache = this.cacheMap.get(name); if (cac...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/config/AnnotationDrivenCacheBeanDefinitionParser.java
@@ -53,6 +53,7 @@ class AnnotationDrivenCacheBeanDefinitionParser implements BeanDefinitionParser * {@link AopNamespaceUtils#registerAutoProxyCreatorIfNecessary * register an AutoProxyCreator} with the container as necessary. */ + @Override public BeanDefinition parse(Element element, ParserContext parserCon...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/config/CacheNamespaceHandler.java
@@ -51,6 +51,7 @@ static BeanDefinition parseKeyGenerator(Element element, BeanDefinition def) { return def; } + @Override public void init() { registerBeanDefinitionParser("annotation-driven", new AnnotationDrivenCacheBeanDefinitionParser()); registerBeanDefinitionParser("advice", new CacheAdviceParser(...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/AbstractFallbackCacheOperationSource.java
@@ -84,6 +84,7 @@ public abstract class AbstractFallbackCacheOperationSource implements CacheOpera * @return {@link CacheOperation} for this method, or {@code null} if the method * is not cacheable */ + @Override public Collection<CacheOperation> getCacheOperations(Method method, Class<?> targetClass) { /...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/BeanFactoryCacheOperationSourceAdvisor.java
@@ -57,6 +57,7 @@ public void setClassFilter(ClassFilter classFilter) { this.pointcut.setClassFilter(classFilter); } + @Override public Pointcut getPointcut() { return this.pointcut; }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/CacheAspectSupport.java
@@ -129,6 +129,7 @@ public KeyGenerator getKeyGenerator() { return this.keyGenerator; } + @Override public void afterPropertiesSet() { if (this.cacheManager == null) { throw new IllegalStateException("'cacheManager' is required");
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/CacheInterceptor.java
@@ -49,10 +49,12 @@ private static class ThrowableWrapper extends RuntimeException { } } + @Override public Object invoke(final MethodInvocation invocation) throws Throwable { Method method = invocation.getMethod(); Invoker aopAllianceInvoker = new Invoker() { + @Override public Object invoke() {...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/CacheOperationSourcePointcut.java
@@ -33,6 +33,7 @@ @SuppressWarnings("serial") abstract class CacheOperationSourcePointcut extends StaticMethodMatcherPointcut implements Serializable { + @Override public boolean matches(Method method, Class<?> targetClass) { CacheOperationSource cas = getCacheOperationSource(); return (cas != null && !Coll...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/CompositeCacheOperationSource.java
@@ -52,6 +52,7 @@ public final CacheOperationSource[] getCacheOperationSources() { return this.cacheOperationSources; } + @Override public Collection<CacheOperation> getCacheOperations(Method method, Class<?> targetClass) { Collection<CacheOperation> ops = null;
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/DefaultKeyGenerator.java
@@ -36,6 +36,7 @@ public class DefaultKeyGenerator implements KeyGenerator { public static final int NO_PARAM_KEY = 0; public static final int NULL_PARAM_KEY = 53; + @Override public Object generate(Object target, Method method, Object... params) { if (params.length == 1) { return (params[0] == null ? NU...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/interceptor/NameMatchCacheOperationSource.java
@@ -71,6 +71,7 @@ public void addCacheMethod(String methodName, Collection<CacheOperation> ops) { this.nameMap.put(methodName, ops); } + @Override public Collection<CacheOperation> getCacheOperations(Method method, Class<?> targetClass) { // look for direct name match String methodName = method.getName()...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/support/AbstractCacheManager.java
@@ -42,6 +42,7 @@ public abstract class AbstractCacheManager implements CacheManager, Initializing private Set<String> cacheNames = new LinkedHashSet<String>(16); + @Override public void afterPropertiesSet() { Collection<? extends Cache> caches = loadCaches(); @@ -70,10 +71,12 @@ protected Cache decorateCa...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/support/CompositeCacheManager.java
@@ -59,13 +59,15 @@ public void setFallbackToNoOpCache(boolean fallbackToNoOpCache) { this.fallbackToNoOpCache = fallbackToNoOpCache; } + @Override public void afterPropertiesSet() { if (this.fallbackToNoOpCache) { this.cacheManagers.add(new NoOpCacheManager()); } } + @Override public Cache g...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/support/NoOpCacheManager.java
@@ -48,6 +48,7 @@ public class NoOpCacheManager implements CacheManager { * This implementation always returns a {@link Cache} implementation that will not store items. * Additionally, the request cache will be remembered by the manager for consistency. */ + @Override public Cache getCache(String name) { ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/cache/support/SimpleValueWrapper.java
@@ -42,6 +42,7 @@ public SimpleValueWrapper(Object value) { /** * Simply returns the value as given at construction time. */ + @Override public Object get() { return this.value; }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/ConfigurableApplicationContext.java
@@ -100,6 +100,7 @@ public interface ConfigurableApplicationContext extends ApplicationContext, Life /** * Return the Environment for this application context in configurable form. */ + @Override ConfigurableEnvironment getEnvironment(); /** @@ -158,6 +159,7 @@ public interface ConfigurableApplicationCont...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/access/ContextBeanFactoryReference.java
@@ -48,6 +48,7 @@ public ContextBeanFactoryReference(ApplicationContext applicationContext) { } + @Override public BeanFactory getFactory() { if (this.applicationContext == null) { throw new IllegalStateException( @@ -56,6 +57,7 @@ public BeanFactory getFactory() { return this.applicationContext; } ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/access/ContextJndiBeanFactoryLocator.java
@@ -57,6 +57,7 @@ public class ContextJndiBeanFactoryLocator extends JndiLocatorSupport implements * will be created from the combined resources. * @see #createBeanFactory */ + @Override public BeanFactoryReference useBeanFactory(String factoryKey) throws BeansException { try { String beanFactoryPath ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AdviceModeImportSelector.java
@@ -65,6 +65,7 @@ protected String getAdviceModeAttributeName() { * on the importing {@code @Configuration} class or if {@link #selectImports(AdviceMode)} * returns {@code null} */ + @Override public final String[] selectImports(AnnotationMetadata importingClassMetadata) { Class<?> annoType = GenericTypeR...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AnnotationBeanNameGenerator.java
@@ -64,6 +64,7 @@ public class AnnotationBeanNameGenerator implements BeanNameGenerator { private static final String COMPONENT_ANNOTATION_CLASSNAME = "org.springframework.stereotype.Component"; + @Override public String generateBeanName(BeanDefinition definition, BeanDefinitionRegistry registry) { if (defin...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AnnotationConfigBeanDefinitionParser.java
@@ -38,6 +38,7 @@ */ public class AnnotationConfigBeanDefinitionParser implements BeanDefinitionParser { + @Override public BeanDefinition parse(Element element, ParserContext parserContext) { Object source = parserContext.extractSource(element);
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AnnotationScopeMetadataResolver.java
@@ -74,6 +74,7 @@ public void setScopeAnnotationType(Class<? extends Annotation> scopeAnnotationTy } + @Override public ScopeMetadata resolveScopeMetadata(BeanDefinition definition) { ScopeMetadata metadata = new ScopeMetadata(); if (definition instanceof AnnotatedBeanDefinition) {
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AspectJAutoProxyRegistrar.java
@@ -39,6 +39,7 @@ class AspectJAutoProxyRegistrar implements ImportBeanDefinitionRegistrar { * of the @{@link EnableAspectJAutoProxy#proxyTargetClass()} attribute on the importing * {@code @Configuration} class. */ + @Override public void registerBeanDefinitions( AnnotationMetadata importingClassMetadata...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/AutoProxyRegistrar.java
@@ -56,6 +56,7 @@ public class AutoProxyRegistrar implements ImportBeanDefinitionRegistrar { * {@code proxyTargetClass} attributes, the APC can be registered and configured all * the same. */ + @Override public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry reg...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ClassPathScanningCandidateComponentProvider.java
@@ -117,6 +117,7 @@ public ClassPathScanningCandidateComponentProvider(boolean useDefaultFilters, En * @see org.springframework.core.io.support.ResourcePatternResolver * @see org.springframework.core.io.support.PathMatchingResourcePatternResolver */ + @Override public void setResourceLoader(ResourceLoader re...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/CommonAnnotationBeanPostProcessor.java
@@ -266,6 +266,7 @@ public void setResourceFactory(BeanFactory resourceFactory) { this.resourceFactory = resourceFactory; } + @Override public void setBeanFactory(BeanFactory beanFactory) throws BeansException { Assert.notNull(beanFactory, "BeanFactory must not be null"); this.beanFactory = beanFactory; ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ComponentScanBeanDefinitionParser.java
@@ -75,6 +75,7 @@ public class ComponentScanBeanDefinitionParser implements BeanDefinitionParser { private static final String FILTER_EXPRESSION_ATTRIBUTE = "expression"; + @Override public BeanDefinition parse(Element element, ParserContext parserContext) { String[] basePackages = StringUtils.tokenizeToStri...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ConditionalAnnotationHelper.java
@@ -183,26 +183,31 @@ private Environment deduceEnvironment(BeanDefinitionRegistry registry) { return null; } + @Override public BeanDefinitionRegistry getRegistry() { return this.registry; } + @Override public Environment getEnvironment() { return this.environment; } + @Override ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -326,6 +326,7 @@ private ConfigurationClassBeanDefinition(ConfigurationClassBeanDefinition origin this.annotationMetadata = original.annotationMetadata; } + @Override public AnnotationMetadata getMetadata() { return this.annotationMetadata; }
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassEnhancer.java
@@ -206,12 +206,14 @@ public Class<?>[] getCallbackTypes() { private static class DisposableBeanMethodInterceptor implements MethodInterceptor, ConditionalCallback { + @Override public boolean isMatch(Method candidateMethod) { return candidateMethod.getName().equals("destroy") && candidateMethod.g...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -90,6 +90,7 @@ class ConfigurationClassParser { private static final Comparator<DeferredImportSelectorHolder> DEFERRED_IMPORT_COMPARATOR = new Comparator<ConfigurationClassParser.DeferredImportSelectorHolder>() { + @Override public int compare(DeferredImportSelectorHolder o1, DeferredImportSelectorH...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java
@@ -184,16 +184,19 @@ public void setBeanNameGenerator(BeanNameGenerator beanNameGenerator) { this.importBeanNameGenerator = beanNameGenerator; } + @Override public void setEnvironment(Environment environment) { Assert.notNull(environment, "Environment must not be null"); this.environment = environment; ...
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/Jsr330ScopeMetadataResolver.java
@@ -81,6 +81,7 @@ protected String resolveScopeName(String annotationType) { } + @Override public ScopeMetadata resolveScopeMetadata(BeanDefinition definition) { ScopeMetadata metadata = new ScopeMetadata(); metadata.setScopeName(BeanDefinition.SCOPE_PROTOTYPE);
true
Other
spring-projects
spring-framework
94685481162a93666fc2f39b66223833a6bcb418.json
Add @Override to remaining source files Issue: SPR-10130
spring-context/src/main/java/org/springframework/context/annotation/LoadTimeWeavingConfiguration.java
@@ -52,13 +52,15 @@ public class LoadTimeWeavingConfiguration implements ImportAware, BeanClassLoade private ClassLoader beanClassLoader; + @Override public void setImportMetadata(AnnotationMetadata importMetadata) { this.enableLTW = MetadataUtils.attributesFor(importMetadata, EnableLoadTimeWeaving.class); ...
true
Other
spring-projects
spring-framework
0634555424a8742bbe95333c49975437af6eacf8.json
Delay check if pattern ends with slash This is a minor fix with no actual impact. Issue: SPR-10504
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/PatternsRequestCondition.java
@@ -168,6 +168,7 @@ protected String getToStringInfix() { * <li>If neither instance has patterns, use an empty String (i.e. ""). * </ul> */ + @Override public PatternsRequestCondition combine(PatternsRequestCondition other) { Set<String> result = new LinkedHashSet<String>(); if (!this.patterns.isEmpty...
false
Other
spring-projects
spring-framework
f35dfd4107ba093de5e0cc9eebe62a7b76a19183.json
Update stale external javadoc links Certain external javadoc links were broken or out of date, namely Hibernate, Java SE and EE 6, Quartz, and Apache Pluto. All resolve properly now. Issue: SPR-8720
build-spring-framework/build.xml
@@ -41,15 +41,15 @@ <presetdef name="javadoc.links"> <javadoc> - <link href="http://java.sun.com/javase/6/docs/api"/> - <link href="http://java.sun.com/j2ee/1.4/docs/api"/> + <link href="http://download.oracle.com/javase/6/docs/api"/> + <link href="http://download.oracle.com/javaee/6/api"/> <l...
false
Other
spring-projects
spring-framework
870d9034174ed9373619c13fcc71f0cf3bc57d30.json
Add INFER_METHOD constant and update @Bean Javadoc In anticipation of 'destroy method inference' feature, introduce ConfigurationClassUtils#INFER_METHOD and update @Bean#destroyMethod to reflect its use. Issue: SPR-8751
org.springframework.context/src/main/java/org/springframework/context/annotation/Bean.java
@@ -168,11 +168,21 @@ * The optional name of a method to call on the bean instance upon closing the * application context, for example a {@code close()} method on a {@code DataSource}. * The method must have no arguments but may throw any exception. + * <p>As a convenience to the user, the container will atte...
true
Other
spring-projects
spring-framework
870d9034174ed9373619c13fcc71f0cf3bc57d30.json
Add INFER_METHOD constant and update @Bean Javadoc In anticipation of 'destroy method inference' feature, introduce ConfigurationClassUtils#INFER_METHOD and update @Bean#destroyMethod to reflect its use. Issue: SPR-8751
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassUtils.java
@@ -46,6 +46,8 @@ abstract class ConfigurationClassUtils { private static final String CONFIGURATION_CLASS_ATTRIBUTE = Conventions.getQualifiedAttributeName(ConfigurationClassPostProcessor.class, "configurationClass"); + static final String INFER_METHOD = ""; // TODO SPR-8751 update to '-' or some such + /**...
true
Other
spring-projects
spring-framework
6b4ef0237c147a3fe02b446bdc831a228c5a8da7.json
Add code examples to and polish @Bean Javadoc
org.springframework.context/src/main/java/org/springframework/context/annotation/Bean.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2009 the original author or authors. + * Copyright 2002-2011 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -27,34 +27,83 @@ /** * Indicates that a m...
false
Other
spring-projects
spring-framework
34956d30b3f628f6a48451eb43911d5665548127.json
Fix doc typo in AbstractAutowireCapableBeanFactory
org.springframework.beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java
@@ -656,7 +656,7 @@ protected Class getTypeForFactoryMethod(String beanName, RootBeanDefinition mbd, /** * This implementation attempts to query the FactoryBean's generic parameter metadata - * if present to determin the object type. If not present, i.e. the FactoryBean is + * if present to determine the objec...
false
Other
spring-projects
spring-framework
faba5941f74ab6967cc712b7c4ce25c026c7fb88.json
Provide ConfigurationClass#toString implementation For ease during debugging; prompted while fixing SPR-8761.
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClass.java
@@ -151,6 +151,11 @@ public int hashCode() { return getMetadata().getClassName().hashCode(); } + @Override + public String toString() { + return String.format("[ConfigurationClass:beanName=%s,resource=%s]", this.beanName, this.resource); + } + /** * Configuration classes must be non-final to accommodate ...
false
Other
spring-projects
spring-framework
91f05c8b9d4e108e744484d808564a95b618e731.json
Avoid creation of unnecessary Environment objects Prior to this change, any instantiation of an AnnotationConfigApplicationContext would trigger the creation of three StandardEnvironment objects: one for the ApplicationContext, one for the AnnotatedBeanDefinitionReader, and one for the ClassPathBeanDefinitionScanner. ...
org.springframework.context/src/main/java/org/springframework/context/annotation/AnnotatedBeanDefinitionReader.java
@@ -45,25 +45,41 @@ public class AnnotatedBeanDefinitionReader { private final BeanDefinitionRegistry registry; - private Environment environment = new StandardEnvironment(); + private Environment environment; private BeanNameGenerator beanNameGenerator = new AnnotationBeanNameGenerator(); private...
true
Other
spring-projects
spring-framework
91f05c8b9d4e108e744484d808564a95b618e731.json
Avoid creation of unnecessary Environment objects Prior to this change, any instantiation of an AnnotationConfigApplicationContext would trigger the creation of three StandardEnvironment objects: one for the ApplicationContext, one for the AnnotatedBeanDefinitionReader, and one for the ClassPathBeanDefinitionScanner. ...
org.springframework.context/src/main/java/org/springframework/context/annotation/AnnotationConfigApplicationContext.java
@@ -47,17 +47,18 @@ */ public class AnnotationConfigApplicationContext extends GenericApplicationContext { - private final AnnotatedBeanDefinitionReader reader = new AnnotatedBeanDefinitionReader(this); + private final AnnotatedBeanDefinitionReader reader; - private final ClassPathBeanDefinitionScanner scanner =...
true
Other
spring-projects
spring-framework
91f05c8b9d4e108e744484d808564a95b618e731.json
Avoid creation of unnecessary Environment objects Prior to this change, any instantiation of an AnnotationConfigApplicationContext would trigger the creation of three StandardEnvironment objects: one for the ApplicationContext, one for the AnnotatedBeanDefinitionReader, and one for the ClassPathBeanDefinitionScanner. ...
org.springframework.context/src/main/java/org/springframework/context/annotation/ClassPathBeanDefinitionScanner.java
@@ -27,15 +27,17 @@ import org.springframework.beans.factory.support.BeanDefinitionReaderUtils; import org.springframework.beans.factory.support.BeanDefinitionRegistry; import org.springframework.beans.factory.support.BeanNameGenerator; +import org.springframework.core.env.Environment; import org.springframework.co...
true
Other
spring-projects
spring-framework
91f05c8b9d4e108e744484d808564a95b618e731.json
Avoid creation of unnecessary Environment objects Prior to this change, any instantiation of an AnnotationConfigApplicationContext would trigger the creation of three StandardEnvironment objects: one for the ApplicationContext, one for the AnnotatedBeanDefinitionReader, and one for the ClassPathBeanDefinitionScanner. ...
org.springframework.context/src/main/java/org/springframework/context/annotation/ClassPathScanningCandidateComponentProvider.java
@@ -73,7 +73,7 @@ public class ClassPathScanningCandidateComponentProvider implements EnvironmentC protected final Log logger = LogFactory.getLog(getClass()); - private Environment environment = new StandardEnvironment(); + private Environment environment; private ResourcePatternResolver resourcePatternResolv...
true
Other
spring-projects
spring-framework
549c663fbaee8fa610ef03ad26aab956fc350206.json
Fix generics warnings in AbstractBeanFactory
org.springframework.beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java
@@ -136,8 +136,8 @@ public abstract class AbstractBeanFactory extends FactoryBeanRegistrySupport imp private TypeConverter typeConverter; /** Custom PropertyEditors to apply to the beans of this factory */ - private final Map<Class, Class<? extends PropertyEditor>> customEditors = - new HashMap<Class, Class<? e...
false
Other
spring-projects
spring-framework
01cc76f8e3b3016677cad5d7be8a45ee1f6bab2c.json
SPR-8697 Flag '*/subtype' as illegal.
org.springframework.web/src/main/java/org/springframework/http/MediaType.java
@@ -575,6 +575,9 @@ public static MediaType parseMediaType(String mediaType) { } String type = fullType.substring(0, subIndex); String subtype = fullType.substring(subIndex + 1, fullType.length()); + if (WILDCARD_TYPE.equals(type) && !WILDCARD_TYPE.equals(subtype)) { + throw new IllegalArgumentException("A ...
true
Other
spring-projects
spring-framework
01cc76f8e3b3016677cad5d7be8a45ee1f6bab2c.json
SPR-8697 Flag '*/subtype' as illegal.
org.springframework.web/src/test/java/org/springframework/http/MediaTypeTests.java
@@ -128,6 +128,11 @@ public void parseMediaTypeNoSubtypeSlash() { MediaType.parseMediaType("audio/"); } + @Test(expected = IllegalArgumentException.class) + public void parseMediaTypeTypeRange() { + MediaType.parseMediaType("*/json"); + } + @Test(expected = IllegalArgumentException.class) public void parseM...
true
Other
spring-projects
spring-framework
56608d6bd6ccae968eafa6840249a205b4f57e9d.json
Fix typo in ResourceHolder#isVoid Javadoc Issue: SPR-8843
org.springframework.transaction/src/main/java/org/springframework/transaction/support/ResourceHolder.java
@@ -39,7 +39,7 @@ public interface ResourceHolder { void unbound(); /** - * Determine whether this holder is considere as 'void', + * Determine whether this holder is considered as 'void', * i.e. as a leftover from a previous thread. */ boolean isVoid();
false
Other
spring-projects
spring-framework
1d5ca80924df154fd51fe9492f66e04a17958382.json
Fix typo in classpath scanning reference doc Issue: SPR-8842
spring-framework-reference/src/beans-classpath-scanning.xml
@@ -4,23 +4,21 @@ <section id="beans-classpath-scanning"> <title>Classpath scanning and managed components</title> - <!-- MLP: Beverly to review paragraph --> - - <para>Most examples foo bar in this chapter use XML to specify the - configuration metadata that produces each - <interfacename>BeanDefinition<...
false
Other
spring-projects
spring-framework
3528637d62bbcc685522714a4a826dca88346ae4.json
Fix JUnit version in spring-parent pom Issue: SPR-8852
org.springframework.spring-parent/pom.xml
@@ -44,7 +44,7 @@ <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> - <version>4.9.0</version> + <version>4.9</version> <scope>test</scope> </dependency> <dependency>
false
Other
spring-projects
spring-framework
06306f91499db610fdef12bbd4ecd7790f5b9370.json
Extract various constants in DefaultKeyGenerator
org.springframework.context/src/main/java/org/springframework/cache/interceptor/DefaultKeyGenerator.java
@@ -21,25 +21,30 @@ import org.springframework.cache.interceptor.KeyGenerator; /** - * Default key generator. Returns 0 if no param is given, the param itself if - * only one is given or a hash code computed from all given params hash code. - * Uses a constant (53) for <code>null</code> objects. + * Default k...
false
Other
spring-projects
spring-framework
42cbee883fb07fdb05da80e5dc9119b8cef8cb8f.json
Add generics to AbstractCacheManager#caches Facilitates type-safe programmatic configuration from @Bean methods: @Bean public CacheManager cacheManager() { SimpleCacheManager cm = new SimpleCacheManager(); cm.setCaches(Arrays.asList( new ConcurrentMapCache("default"), n...
org.springframework.context/src/main/java/org/springframework/cache/support/AbstractCacheManager.java
@@ -44,7 +44,7 @@ public abstract class AbstractCacheManager implements CacheManager, Initializing public void afterPropertiesSet() { - Collection<Cache> caches = loadCaches(); + Collection<? extends Cache> caches = loadCaches(); Assert.notEmpty(caches, "loadCaches must not return an empty Collection");...
true
Other
spring-projects
spring-framework
42cbee883fb07fdb05da80e5dc9119b8cef8cb8f.json
Add generics to AbstractCacheManager#caches Facilitates type-safe programmatic configuration from @Bean methods: @Bean public CacheManager cacheManager() { SimpleCacheManager cm = new SimpleCacheManager(); cm.setCaches(Arrays.asList( new ConcurrentMapCache("default"), n...
org.springframework.context/src/main/java/org/springframework/cache/support/SimpleCacheManager.java
@@ -29,17 +29,17 @@ */ public class SimpleCacheManager extends AbstractCacheManager { - private Collection<Cache> caches; + private Collection<? extends Cache> caches; /** * Specify the collection of Cache instances to use for this CacheManager. */ - public void setCaches(Collection<Cache> cache...
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/AbstractAnnotationTests.java
@@ -31,16 +31,16 @@ /** * Abstract annotation test (containing several reusable methods). - * + * * @author Costin Leau */ public abstract class AbstractAnnotationTests { protected ApplicationContext ctx; - protected CacheableService cs; + protected CacheableService<?> cs; - protected C...
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/AnnotatedClassCacheableService.java
@@ -27,7 +27,7 @@ * @author Costin Leau */ @Cacheable("default") -public class AnnotatedClassCacheableService implements CacheableService { +public class AnnotatedClassCacheableService implements CacheableService<Object> { private final AtomicLong counter = new AtomicLong(); public static final Atomic...
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/AnnotationNamespaceDrivenTests.java
@@ -21,7 +21,6 @@ import org.junit.Test; import org.springframework.cache.interceptor.CacheInterceptor; - /** * @author Costin Leau */
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/AnnotationTests.java
@@ -16,8 +16,6 @@ package org.springframework.cache.config; - - /** * @author Costin Leau */
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/CacheAdviceNamespaceTests.java
@@ -20,13 +20,11 @@ import org.junit.Test; import org.springframework.cache.interceptor.CacheInterceptor; - /** * @author Costin Leau */ public class CacheAdviceNamespaceTests extends AbstractAnnotationTests { - @Override protected String getConfig() { return "/org/springframework/cache/c...
true
Other
spring-projects
spring-framework
8abb3150420d03e7c8cd3f483bf8a411e6fbcc0e.json
Fix cache generics warnings; polish whitespace
org.springframework.context/src/test/java/org/springframework/cache/config/CacheableService.java
@@ -16,7 +16,6 @@ package org.springframework.cache.config; - /** * Basic service interface. *
true
Other
spring-projects
spring-framework
40798bd48f63a8f0d9c6529ca6aaa7203b95cbc3.json
Improve ImportStack#toString output
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -248,14 +248,22 @@ private void processImport(ConfigurationClass configClass, String[] classesToImp // the candidate class is an ImportSelector -> delegate to it to determine imports try { ImportSelector selector = BeanUtils.instantiateClass(Class.forName(candidate), ImportSelector.class); - ...
false
Other
spring-projects
spring-framework
4ededaf11c933f760f741f3dd311dc3e1e418af4.json
Fix typo in DateTimeFormat Javadoc Issue: SPR-8838
org.springframework.context/src/main/java/org/springframework/format/annotation/DateTimeFormat.java
@@ -33,7 +33,7 @@ * <p> * For ISO-based formatting, set the {@link #iso()} attribute to be the desired {@link ISO} format, such as {@link ISO#DATE}. <p> - * For custom formatting, set the {@link #pattern()} attribute to be the DateTime pattern, such as <code>yyyy/mm/dd h:mm:ss a</code>. + * For custom formattin...
false
Other
spring-projects
spring-framework
ccf3732cd8c8ecf3918d610c31e48ee71d45b9ff.json
Create import-into-eclipse.bat for Windows users Port import-into-eclipse.sh to a Windows batch file.
import-into-eclipse.bat
@@ -0,0 +1,117 @@ +@echo off +set STS_TEST_VERSION='2.9.2.RELEASE' + +set CURRENT_DIR=%~dp0 +cd %CURRENT_DIR% + +cls + +echo. +echo ----------------------------------------------------------------------- +echo Spring Framework Eclipse/STS project import guide +echo. +echo This script will guide you through ...
false
Other
spring-projects
spring-framework
38cf91922c0423fa8ffd541e9cc7f1d2cae87529.json
Fix intermittent test failure in AsyncTests
spring-test-mvc/src/main/java/org/springframework/test/web/servlet/DefaultMvcResult.java
@@ -22,8 +22,6 @@ import org.springframework.mock.web.MockHttpServletRequest; import org.springframework.mock.web.MockHttpServletResponse; -import org.springframework.web.context.request.async.WebAsyncManager; -import org.springframework.web.context.request.async.WebAsyncUtils; import org.springframework.web.servl...
true