language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
2afeb08e3c387715374c81a82074bae4235b5082.json
Fix @Autowired+@PostConstruct+@Configuration issue A subtle issue existed with the way we relied on isCurrentlyInCreation to determine whether a @Bean method is being called by the container or by user code. This worked in most cases, but in the particular scenario laid out by SPR-8080, this approach was no longer su...
org.springframework.beans/src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java
@@ -97,6 +97,9 @@ public class DefaultSingletonBeanRegistry extends SimpleAliasRegistry implements /** Names of beans that are currently in creation */ private final Set<String> singletonsCurrentlyInCreation = Collections.synchronizedSet(new HashSet<String>()); + /** Names of beans currently excluded from in crea...
true
Other
spring-projects
spring-framework
2afeb08e3c387715374c81a82074bae4235b5082.json
Fix @Autowired+@PostConstruct+@Configuration issue A subtle issue existed with the way we relied on isCurrentlyInCreation to determine whether a @Bean method is being called by the container or by user code. This worked in most cases, but in the particular scenario laid out by SPR-8080, this approach was no longer su...
org.springframework.beans/src/main/java/org/springframework/beans/factory/support/SimpleInstantiationStrategy.java
@@ -42,6 +42,8 @@ */ public class SimpleInstantiationStrategy implements InstantiationStrategy { + private static final ThreadLocal<Method> currentlyInvokedFactoryMethod = new ThreadLocal<Method>(); + public Object instantiate(RootBeanDefinition beanDefinition, String beanName, BeanFactory owner) { // Don't o...
true
Other
spring-projects
spring-framework
2afeb08e3c387715374c81a82074bae4235b5082.json
Fix @Autowired+@PostConstruct+@Configuration issue A subtle issue existed with the way we relied on isCurrentlyInCreation to determine whether a @Bean method is being called by the container or by user code. This worked in most cases, but in the particular scenario laid out by SPR-8080, this approach was no longer su...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassEnhancer.java
@@ -35,6 +35,7 @@ import org.springframework.beans.factory.FactoryBean; import org.springframework.beans.factory.config.BeanFactoryPostProcessor; import org.springframework.beans.factory.config.ConfigurableBeanFactory; +import org.springframework.beans.factory.support.SimpleInstantiationStrategy; import org.springf...
true
Other
spring-projects
spring-framework
2afeb08e3c387715374c81a82074bae4235b5082.json
Fix @Autowired+@PostConstruct+@Configuration issue A subtle issue existed with the way we relied on isCurrentlyInCreation to determine whether a @Bean method is being called by the container or by user code. This worked in most cases, but in the particular scenario laid out by SPR-8080, this approach was no longer su...
org.springframework.context/src/test/java/org/springframework/context/annotation/ConfigurationClassPostConstructAndAutowiringTests.java
@@ -0,0 +1,112 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
80f0eabbd93c83d00f8e2f02f529b1aba49a381a.json
Add MockEnvironment to .integration-tests
org.springframework.integration-tests/src/test/java/org/springframework/mock/env/MockEnvironment.java
@@ -0,0 +1,60 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
false
Other
spring-projects
spring-framework
52bef0b7b024e794186437dee78945fbb5bd209a.json
Allow static modifier on @Bean methods Declaring @Bean methods as 'static' is now permitted, whereas previously it raised an exception at @Configuration class validation time. A static @Bean method can be called by the container without requiring the instantiation of its declaring @Configuration class. This is partic...
org.springframework.context/src/main/java/org/springframework/context/annotation/Bean.java
@@ -37,8 +37,8 @@ * * <p>While a {@link #name()} attribute is available, the default strategy for determining * the name of a bean is to use the name of the Bean method. This is convenient and - * intuitive, but if explicit naming is desired, the {@link #name()} attribute may be used. - * Also note that {@link #n...
true
Other
spring-projects
spring-framework
52bef0b7b024e794186437dee78945fbb5bd209a.json
Allow static modifier on @Bean methods Declaring @Bean methods as 'static' is now permitted, whereas previously it raised an exception at @Configuration class validation time. A static @Bean method can be called by the container without requiring the instantiation of its declaring @Configuration class. This is partic...
org.springframework.context/src/main/java/org/springframework/context/annotation/BeanMethod.java
@@ -39,39 +39,25 @@ public BeanMethod(MethodMetadata metadata, ConfigurationClass configurationClass @Override public void validate(ProblemReporter problemReporter) { + if (getMetadata().isStatic()) { + // static @Bean methods have no constraints to validate -> return immediately + return; + } + if (this...
true
Other
spring-projects
spring-framework
52bef0b7b024e794186437dee78945fbb5bd209a.json
Allow static modifier on @Bean methods Declaring @Bean methods as 'static' is now permitted, whereas previously it raised an exception at @Configuration class validation time. A static @Bean method can be called by the container without requiring the instantiation of its declaring @Configuration class. This is partic...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -162,8 +162,16 @@ private void loadBeanDefinitionsForBeanMethod(BeanMethod beanMethod) { RootBeanDefinition beanDef = new ConfigurationClassBeanDefinition(configClass); beanDef.setResource(configClass.getResource()); beanDef.setSource(this.sourceExtractor.extractSource(metadata, configClass.getResource()));...
true
Other
spring-projects
spring-framework
52bef0b7b024e794186437dee78945fbb5bd209a.json
Allow static modifier on @Bean methods Declaring @Bean methods as 'static' is now permitted, whereas previously it raised an exception at @Configuration class validation time. A static @Bean method can be called by the container without requiring the instantiation of its declaring @Configuration class. This is partic...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassEnhancer.java
@@ -33,6 +33,7 @@ import org.springframework.beans.factory.BeanFactory; import org.springframework.beans.factory.DisposableBean; import org.springframework.beans.factory.FactoryBean; +import org.springframework.beans.factory.config.BeanFactoryPostProcessor; import org.springframework.beans.factory.config.Configurab...
true
Other
spring-projects
spring-framework
52bef0b7b024e794186437dee78945fbb5bd209a.json
Allow static modifier on @Bean methods Declaring @Bean methods as 'static' is now permitted, whereas previously it raised an exception at @Configuration class validation time. A static @Bean method can be called by the container without requiring the instantiation of its declaring @Configuration class. This is partic...
org.springframework.context/src/test/java/org/springframework/context/annotation/ConfigurationClassAndBFPPTests.java
@@ -0,0 +1,122 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/CircularComponentScanException.java
@@ -0,0 +1,32 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ClassPathBeanDefinitionScanner.java
@@ -269,7 +269,7 @@ protected void registerBeanDefinition(BeanDefinitionHolder definitionHolder, Bea * @return <code>true</code> if the bean can be registered as-is; * <code>false</code> if it should be skipped because there is an * existing, compatible bean definition for the specified name - * @throws Illeg...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanAnnotationParser.java
@@ -20,14 +20,15 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; +import java.util.Set; import org.springframework.beans.BeanUtils; +import org.springframework.beans.factory.config.BeanDefinitionHolder; import org.springframework.beans.factory.support.BeanDefinitionRegistry; import o...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -27,7 +27,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.springframework.beans.BeanUtils; import org.springframework.beans.factory.annotation.AnnotatedBeanDefinition; import org.springframework.beans.factory.annotation.Autowire; import org.springframework...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -28,11 +28,14 @@ import java.util.Stack; import org.springframework.beans.BeanUtils; +import org.springframework.beans.factory.config.BeanDefinitionHolder; import org.springframework.beans.factory.parsing.Location; import org.springframework.beans.factory.parsing.Problem; import org.springframework.beans.fact...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java
@@ -193,15 +193,16 @@ public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) */ private void processConfigurationClasses(BeanDefinitionRegistry registry) { ConfigurationClassBeanDefinitionReader reader = getConfigurationClassBeanDefinitionReader(registry); - ConfigurationClassParser pa...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassUtils.java
@@ -0,0 +1,102 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConflictingBeanDefinitionException.java
@@ -0,0 +1,33 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/AsmCircularImportDetectionTests.java
@@ -16,7 +16,9 @@ package org.springframework.context.annotation; import org.springframework.beans.factory.parsing.FailFastProblemReporter; +import org.springframework.beans.factory.support.DefaultListableBeanFactory; import org.springframework.core.env.DefaultEnvironment; +import org.springframework.core.io.Defau...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/ComponentScanAnnotationRecursionTests.java
@@ -0,0 +1,60 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/componentscan/cycle/left/LeftConfig.java
@@ -0,0 +1,26 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/componentscan/cycle/right/RightConfig.java
@@ -0,0 +1,26 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/componentscan/level1/Level1Config.java
@@ -0,0 +1,31 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/componentscan/level2/Level2Config.java
@@ -0,0 +1,31 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
d0c31ad84cffd7af718a45d679483a1c51f9e552.json
Allow recursive use of @ComponentScan Prior to this change, @ComponentScan annotations were only processed at the first level of depth. Now, the set of bean definitions resulting from each declaration of @ComponentScan is checked for configuration classes that declare @ComponentScan, and recursion is performed as nec...
org.springframework.context/src/test/java/org/springframework/context/annotation/componentscan/level3/Level3Component.java
@@ -0,0 +1,24 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4f7bdbd3de8e1ca91ad84ea41afc4f525e1b4fd8.json
Make ConfigurationClassBeanDefinitionReader public Issue: SPR-8200
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -73,7 +73,7 @@ * @since 3.0 * @see ConfigurationClassParser */ -class ConfigurationClassBeanDefinitionReader { +public class ConfigurationClassBeanDefinitionReader { private static final String CONFIGURATION_CLASS_FULL = "full";
false
Other
spring-projects
spring-framework
6f80578a387098bcf054249c512025ec81ae182b.json
Ignore fragile test dependent on debug symbols Issue: SPR-8078
org.springframework.core/src/test/java/org/springframework/core/LocalVariableTableParameterNameDiscovererTests.java
@@ -25,6 +25,7 @@ import junit.framework.TestCase; +import org.junit.Ignore; import org.springframework.beans.TestBean; /** @@ -192,7 +193,12 @@ public void testGenerifiedClass() throws Exception { //System.in.read(); } - public void testMemUsage() throws Exception { + /** + * Ignored because Ubuntu pa...
false
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.beans/src/main/java/org/springframework/beans/PropertyEditorRegistry.java
@@ -39,7 +39,7 @@ public interface PropertyEditorRegistry { * @param requiredType the type of the property * @param propertyEditor the editor to register */ - void registerCustomEditor(Class requiredType, PropertyEditor propertyEditor); + void registerCustomEditor(Class<?> requiredType, PropertyEditor property...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/AbstractBindingResult.java
@@ -41,6 +41,7 @@ * @since 2.0 * @see Errors */ +@SuppressWarnings("serial") public abstract class AbstractBindingResult extends AbstractErrors implements BindingResult, Serializable { private final String objectName; @@ -131,7 +132,7 @@ public String[] resolveMessageCodes(String errorCode) { } public ...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/AbstractErrors.java
@@ -33,6 +33,7 @@ * @author Juergen Hoeller * @since 2.5.3 */ +@SuppressWarnings("serial") public abstract class AbstractErrors implements Errors, Serializable { private String nestedPath = ""; @@ -146,8 +147,8 @@ public int getGlobalErrorCount() { } public ObjectError getGlobalError() { - List global...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/AbstractPropertyBindingResult.java
@@ -39,6 +39,7 @@ * @see org.springframework.beans.PropertyAccessor * @see org.springframework.beans.ConfigurablePropertyAccessor */ +@SuppressWarnings("serial") public abstract class AbstractPropertyBindingResult extends AbstractBindingResult { private ConversionService conversionService; @@ -85,7 +86,7 @@ ...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/BeanPropertyBindingResult.java
@@ -40,6 +40,7 @@ * @see DataBinder#initBeanPropertyAccess() * @see DirectFieldBindingResult */ +@SuppressWarnings("serial") public class BeanPropertyBindingResult extends AbstractPropertyBindingResult implements Serializable { private final Object target;
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/BindException.java
@@ -40,6 +40,7 @@ * @see DataBinder#getBindingResult() * @see DataBinder#close() */ +@SuppressWarnings("serial") public class BindException extends Exception implements BindingResult { private final BindingResult bindingResult; @@ -134,7 +135,7 @@ public int getErrorCount() { return this.bindingResult.get...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/BindingResult.java
@@ -94,7 +94,7 @@ public interface BindingResult extends Errors { * is given but should be specified in any case for consistency checking) * @return the registered editor, or <code>null</code> if none */ - PropertyEditor findEditor(String field, Class valueType); + PropertyEditor findEditor(String field, Class...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/BindingResultUtils.java
@@ -36,7 +36,7 @@ public abstract class BindingResultUtils { * @return the BindingResult, or <code>null</code> if none found * @throws IllegalStateException if the attribute found is not of type BindingResult */ - public static BindingResult getBindingResult(Map model, String name) { + public static BindingRes...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/DataBinder.java
@@ -509,18 +509,15 @@ public ConversionService getConversionService() { return this.conversionService; } - @SuppressWarnings("unchecked") - public void registerCustomEditor(Class requiredType, PropertyEditor propertyEditor) { + public void registerCustomEditor(Class<?> requiredType, PropertyEditor propertyEditor...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/DefaultMessageCodesResolver.java
@@ -75,6 +75,7 @@ * @author Juergen Hoeller * @since 1.0.1 */ +@SuppressWarnings("serial") public class DefaultMessageCodesResolver implements MessageCodesResolver, Serializable { /** @@ -119,7 +120,7 @@ public String[] resolveMessageCodes(String errorCode, String objectName) { * details on the generated ...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/DirectFieldBindingResult.java
@@ -34,6 +34,7 @@ * @see DataBinder#initDirectFieldAccess() * @see BeanPropertyBindingResult */ +@SuppressWarnings("serial") public class DirectFieldBindingResult extends AbstractPropertyBindingResult { private final Object target;
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/Errors.java
@@ -296,6 +296,6 @@ public interface Errors { * @param field the field name * @return the type of the field, or <code>null</code> if not determinable */ - Class getFieldType(String field); + Class<?> getFieldType(String field); }
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/FieldError.java
@@ -31,6 +31,7 @@ * @since 10.03.2003 * @see DefaultMessageCodesResolver */ +@SuppressWarnings("serial") public class FieldError extends ObjectError { private final String field;
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/MapBindingResult.java
@@ -33,24 +33,25 @@ * @since 2.0 * @see java.util.Map */ +@SuppressWarnings("serial") public class MapBindingResult extends AbstractBindingResult implements Serializable { - private final Map target; + private final Map<?, ?> target; /** * Create a new MapBindingResult instance. * @param target the...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/MessageCodesResolver.java
@@ -50,6 +50,6 @@ public interface MessageCodesResolver { * @param fieldType the field type (may be <code>null</code> if not determinable) * @return the message codes to use */ - String[] resolveMessageCodes(String errorCode, String objectName, String field, Class fieldType); + String[] resolveMessageCodes(Str...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/ObjectError.java
@@ -31,6 +31,7 @@ * @see DefaultMessageCodesResolver * @since 10.03.2003 */ +@SuppressWarnings("serial") public class ObjectError extends DefaultMessageSourceResolvable { private final String objectName;
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java
@@ -62,6 +62,7 @@ public class LocalValidatorFactoryBean extends SpringValidatorAdapter implements ValidatorFactory, ApplicationContextAware, InitializingBean { + @SuppressWarnings("rawtypes") private Class providerClass; private MessageInterpolator messageInterpolator; @@ -85,6 +86,7 @@ public class...
true
Other
spring-projects
spring-framework
f4e1cde33b077b1268cc5cae0c18c4b706653d25.json
Eliminate warnings in .validation package Issue: SPR-8062
org.springframework.context/src/main/java/org/springframework/validation/beanvalidation/package-info.java
@@ -3,8 +3,9 @@ * (such as Hibernate Validator 4.0) into a Spring ApplicationContext * and in particular with Spring's data binding and validation APIs. * - * <p>The central class is {@link LocalValidatorFactoryBean} which - * defines a shared ValidatorFactory/Validator setup for availability + * <p>The cent...
true
Other
spring-projects
spring-framework
150838bfc13a136ef0baf943e378a8ebb5f3549f.json
Remove TODOs related to profile logging Issue: SPR-8031, SPR-7508, SPR-8057
org.springframework.beans/src/main/java/org/springframework/beans/factory/xml/DefaultBeanDefinitionDocumentReader.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2010 the original author or authors. + * Copyright 2002-2011 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -123,7 +123,6 @@ protected void doRegisterBe...
true
Other
spring-projects
spring-framework
150838bfc13a136ef0baf943e378a8ebb5f3549f.json
Remove TODOs related to profile logging Issue: SPR-8031, SPR-7508, SPR-8057
org.springframework.context/src/main/java/org/springframework/context/annotation/AnnotatedBeanDefinitionReader.java
@@ -116,7 +116,6 @@ public void registerBean(Class<?> annotatedClass, String name, Class<? extends A if (ProfileHelper.isProfileAnnotationPresent(metadata)) { if (!this.environment.acceptsProfiles(ProfileHelper.getCandidateProfiles(metadata))) { - // TODO SPR-7508: log that this bean is being rejected on...
true
Other
spring-projects
spring-framework
150838bfc13a136ef0baf943e378a8ebb5f3549f.json
Remove TODOs related to profile logging Issue: SPR-8031, SPR-7508, SPR-8057
org.springframework.context/src/main/java/org/springframework/context/annotation/ClassPathScanningCandidateComponentProvider.java
@@ -300,7 +300,6 @@ protected boolean isCandidateComponent(MetadataReader metadataReader) throws IOE if (!ProfileHelper.isProfileAnnotationPresent(metadata)) { return true; } - // TODO SPR-7508: log that this bean is being rejected on profile mismatch return this.environment.acceptsProfiles(Prof...
true
Other
spring-projects
spring-framework
150838bfc13a136ef0baf943e378a8ebb5f3549f.json
Remove TODOs related to profile logging Issue: SPR-8031, SPR-7508, SPR-8057
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2010 the original author or authors. + * Copyright 2002-2011 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -104,7 +104,6 @@ protected void processConfi...
true
Other
spring-projects
spring-framework
150838bfc13a136ef0baf943e378a8ebb5f3549f.json
Remove TODOs related to profile logging Issue: SPR-8031, SPR-7508, SPR-8057
org.springframework.core/src/main/java/org/springframework/core/env/MutablePropertySources.java
@@ -160,7 +160,6 @@ protected void assertLegalRelativeAddition(String relativePropertySourceName, Pr */ protected void removeIfPresent(PropertySource<?> propertySource) { if (this.propertySourceList.contains(propertySource)) { - // TODO SPR-7508: add logging this.propertySourceList.remove(propertySource);...
true
Other
spring-projects
spring-framework
a2a98efa13d35e30bd879f0ff92182900c805f5d.json
Remove references to 'bold' text in reference docs <emphasis role="bold"> blocks do not render properly, probably due to conflicting CSS used for syntax highlighting. For the moment, any mentions of bold text (e.g. "see bold text in the snippet below") have been removed to avoid confusion as reported in SPR-8520. SPR...
spring-framework-reference/src/oxm.xml
@@ -311,7 +311,7 @@ public class Application { <para> Marshallers could be configured more concisely using tags from the OXM namespace. To make these tags available, the appropriate schema has to be referenced first in the preamble of the XML configuration file. - The emboldened tex...
true
Other
spring-projects
spring-framework
a2a98efa13d35e30bd879f0ff92182900c805f5d.json
Remove references to 'bold' text in reference docs <emphasis role="bold"> blocks do not render properly, probably due to conflicting CSS used for syntax highlighting. For the moment, any mentions of bold text (e.g. "see bold text in the snippet below") have been removed to avoid confusion as reported in SPR-8520. SPR...
spring-framework-reference/src/xsd-configuration.xml
@@ -99,7 +99,7 @@ http://www.springframework.org/schema/beans http://www.springframework.org/schem and suchlike.</para> <para>To use the tags in the <literal>util</literal> schema, you need to have the following preamble at the top of your Spring XML configuration file; - ...
true
Other
spring-projects
spring-framework
5aa24af1269bf0ac9691afc63da6f6051543ad6a.json
Implement SessionFactoryImplementor in SF proxies SessionFactoryBuilderSupport implementations create DisposableBean proxies for SessionFactory objects created using #buildSessionFactory. Prior to this change, these proxies create problems when working agaist SessionFactoryUtils.getDataSource(SessionFactory), because...
org.springframework.integration-tests/src/test/java/org/springframework/orm/hibernate3/HibernateSessionFactoryConfigurationTests.java
@@ -33,6 +33,7 @@ import org.hibernate.Transaction; import org.hibernate.cfg.AnnotationConfiguration; import org.hibernate.classic.Session; +import org.hibernate.engine.SessionFactoryImplementor; import org.junit.Ignore; import org.junit.Test; import org.springframework.beans.factory.BeanCreationException; @@ -13...
true
Other
spring-projects
spring-framework
5aa24af1269bf0ac9691afc63da6f6051543ad6a.json
Implement SessionFactoryImplementor in SF proxies SessionFactoryBuilderSupport implementations create DisposableBean proxies for SessionFactory objects created using #buildSessionFactory. Prior to this change, these proxies create problems when working agaist SessionFactoryUtils.getDataSource(SessionFactory), because...
org.springframework.orm/src/main/java/org/springframework/orm/hibernate3/SessionFactoryBuilderSupport.java
@@ -232,8 +232,9 @@ public SessionFactoryBuilderSupport(DataSource dataSource) { /** * Build the underlying Hibernate SessionFactory. - * @return the raw SessionFactory (potentially to be wrapped with a - * transaction-aware proxy before it is exposed to the application) + * @return the {@code SessionFactory}...
true
Other
spring-projects
spring-framework
807d612978f9d01e446542320c19db68da14b8e1.json
Determine FactoryBean object type via generics For the particular use case detailed in SPR-8514, with this change we now attempt to determine the object type of a FactoryBean through its generic type parameter if possible. For (a contrived) example: @Configuration public MyConfig { @Bean public FactoryBean<S...
org.springframework.beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java
@@ -21,6 +21,9 @@ import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.lang.reflect.Modifier; +import java.lang.reflect.ParameterizedType; +import java.lang.reflect.Type; +import java.lang.reflect.WildcardType; import java.security.AccessController; import java.security....
true
Other
spring-projects
spring-framework
807d612978f9d01e446542320c19db68da14b8e1.json
Determine FactoryBean object type via generics For the particular use case detailed in SPR-8514, with this change we now attempt to determine the object type of a FactoryBean through its generic type parameter if possible. For (a contrived) example: @Configuration public MyConfig { @Bean public FactoryBean<S...
org.springframework.context/src/test/java/org/springframework/context/annotation/ConfigurationWithFactoryBeanAndAutowiringTests.java
@@ -0,0 +1,218 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
ce0a0ff3d4352b3040e7bbc7fe14313a40ac9491.json
Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG constant Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG from JndiPropertySource to StandardServletEnvironment, as this is the only context in which the constant makes sense.
org.springframework.context/src/main/java/org/springframework/jndi/JndiPropertySource.java
@@ -42,12 +42,6 @@ public class JndiPropertySource extends PropertySource<Context> { /** JNDI context property source name: {@value} */ public static final String JNDI_PROPERTY_SOURCE_NAME = "jndiPropertySource"; - /** - * Name of property used to determine if a {@link JndiPropertySource} - * should be register...
true
Other
spring-projects
spring-framework
ce0a0ff3d4352b3040e7bbc7fe14313a40ac9491.json
Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG constant Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG from JndiPropertySource to StandardServletEnvironment, as this is the only context in which the constant makes sense.
org.springframework.web/src/main/java/org/springframework/web/context/support/StandardServletEnvironment.java
@@ -55,6 +55,13 @@ public class StandardServletEnvironment extends StandardEnvironment { /** Servlet config init parameters property source name: {@value} */ public static final String SERVLET_CONFIG_PROPERTY_SOURCE_NAME = "servletConfigInitParams"; + /** + * Name of property used to determine if a {@link JndiPr...
true
Other
spring-projects
spring-framework
ce0a0ff3d4352b3040e7bbc7fe14313a40ac9491.json
Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG constant Move JNDI_PROPERTY_SOURCE_ENABLED_FLAG from JndiPropertySource to StandardServletEnvironment, as this is the only context in which the constant makes sense.
org.springframework.web/src/test/java/org/springframework/web/context/support/StandardServletEnvironmentTests.java
@@ -19,6 +19,7 @@ import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.is; import static org.junit.Assert.assertThat; +import static org.springframework.web.context.support.StandardServletEnvironment.JNDI_PROPERTY_SOURCE_ENABLED_FLAG; import org.junit.Test; import org.springfr...
true
Other
spring-projects
spring-framework
32ebf18429a179e6bf416db42ae2d474802369ea.json
SPR-5937: add param map to freemarker url macro
org.springframework.web.servlet/src/main/java/org/springframework/web/servlet/support/RequestContext.java
@@ -46,21 +46,18 @@ import org.springframework.web.util.WebUtils; /** - * Context holder for request-specific state, like current web application - * context, current locale, current theme, and potential binding errors. - * Provides easy access to localized messages and Errors instances. - * - * <p>Suitable for exp...
true
Other
spring-projects
spring-framework
32ebf18429a179e6bf416db42ae2d474802369ea.json
SPR-5937: add param map to freemarker url macro
org.springframework.web.servlet/src/test/java/org/springframework/web/servlet/support/RequestContextTests.java
@@ -0,0 +1,71 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
.gitignore
@@ -8,6 +8,7 @@ bin build.sh integration-repo ivy-cache +jxl.log jmx.log org.springframework.jdbc/derby.log org.springframework.spring-parent/.classpath
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
org.springframework.web.servlet/src/main/java/org/springframework/web/servlet/support/RequestContext.java
@@ -41,6 +41,7 @@ import org.springframework.web.context.WebApplicationContext; import org.springframework.web.servlet.LocaleResolver; import org.springframework.web.util.HtmlUtils; +import org.springframework.web.util.UriTemplate; import org.springframework.web.util.UrlPathHelper; import org.springframework.web.u...
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
org.springframework.web.servlet/src/main/java/org/springframework/web/servlet/view/freemarker/spring.ftl
@@ -86,7 +86,7 @@ * Takes a relative URL and makes it absolute from the server root by * adding the context root for the web application. --> -<#macro url relativeUrl>${springMacroRequestContext.getContextUrl(relativeUrl)}</#macro> +<#macro url relativeUrl extra...><#if extra?? && extra?size!=0>${springMacroReque...
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
org.springframework.web.servlet/src/test/java/org/springframework/web/servlet/view/DummyMacroRequestContext.java
@@ -22,6 +22,7 @@ import org.springframework.web.servlet.support.BindStatus; import org.springframework.web.servlet.support.RequestContext; +import org.springframework.web.util.UriTemplate; /** * Dummy request context used for VTL and FTL macro tests. @@ -134,6 +135,14 @@ public String getContextUrl(String rel...
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
org.springframework.web.servlet/src/test/java/org/springframework/web/servlet/view/freemarker/FreeMarkerMacroTests.java
@@ -16,23 +16,28 @@ package org.springframework.web.servlet.view.freemarker; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +import java.io.FileWriter; +import java.io.InputStreamReader...
true
Other
spring-projects
spring-framework
c2e62f098ad2ae6e643f56a7429454020ec17294.json
Add ignorable log file to .gitignore
org.springframework.web.servlet/src/test/java/org/springframework/web/servlet/view/freemarker/test.ftl
@@ -36,6 +36,9 @@ THEMEARGSWITHDEFAULTMESSAGE URL <@spring.url "/aftercontext.html"/> +URLPARAMS +<@spring.url relativeUrl="/aftercontext/{foo}?spam={spam}" foo="bar" spam="bucket"/> + FORM1 <@spring.formInput "command.name", ""/>
true
Other
spring-projects
spring-framework
1bf8634db1c025198e7383834079d464cb05162f.json
Fix broken links in ref docs
spring-framework-reference/src/beans.xml
@@ -548,7 +548,7 @@ List userList service.getUsernameList(); or id is supplied explicitly, the container generates a unique name for that bean. However, if you want to refer to that bean by name, through the use of the <literal>ref</literal> element or <link lang="" - linkend="beans-se...
true
Other
spring-projects
spring-framework
1bf8634db1c025198e7383834079d464cb05162f.json
Fix broken links in ref docs
spring-framework-reference/src/cache.xml
@@ -98,7 +98,7 @@ public Book findBook(ISBN isbn) {...}]]></programlisting> In fact, depending on the JVM implementation or running conditions, the same hashCode can be reused for different objects, in the same VM instance.</para> <para>To provide a different <emphasis>default</emphasis> key generator, o...
true
Other
spring-projects
spring-framework
1bf8634db1c025198e7383834079d464cb05162f.json
Fix broken links in ref docs
spring-framework-reference/src/validation.xml
@@ -1101,7 +1101,7 @@ public interface ConversionService { </bean>]]></programlisting> <para>It is also common to use a ConversionService within a Spring MVC - application. See <xref linkend="format-configuring-FormatterRegistry"/> + application. See <xref linkend="format-configuring-FormattingC...
true
Other
spring-projects
spring-framework
16fc083310d5414f2fbca205f8de8a2c25082961.json
SPR-8391 Minor documentation fixes
spring-framework-reference/src/mvc.xml
@@ -237,7 +237,7 @@ <imagedata align="center" fileref="images/mvc.png" format="PNG" /> </imageobject> - <caption><para>The requesting processing workflow in Spring Web MVC + <caption><para>The request processing workflow in Spring Web MVC (high level)</para></caption> ...
false
Other
spring-projects
spring-framework
2bc3527f76247a3b8fd81ba5373b4b155e3a48b8.json
Consolidate annotation processing constants Consolidating internal bean name and aspect class name constats within AnnotationConfigUtils to allow access from both the context.config and context.annotation packages without creating a relationship between the two of them (they are unrelated leaf nodes in the packaging c...
org.springframework.context/src/main/java/org/springframework/cache/config/AnnotationDrivenCacheBeanDefinitionParser.java
@@ -16,6 +16,10 @@ package org.springframework.cache.config; +import static org.springframework.context.annotation.AnnotationConfigUtils.CACHE_ADVISOR_BEAN_NAME; +import static org.springframework.context.annotation.AnnotationConfigUtils.CACHE_ASPECT_BEAN_NAME; +import static org.springframework.context.annot...
true
Other
spring-projects
spring-framework
2bc3527f76247a3b8fd81ba5373b4b155e3a48b8.json
Consolidate annotation processing constants Consolidating internal bean name and aspect class name constats within AnnotationConfigUtils to allow access from both the context.config and context.annotation packages without creating a relationship between the two of them (they are unrelated leaf nodes in the packaging c...
org.springframework.context/src/main/java/org/springframework/context/annotation/AnnotationConfigUtils.java
@@ -70,6 +70,48 @@ public class AnnotationConfigUtils { public static final String COMMON_ANNOTATION_PROCESSOR_BEAN_NAME = "org.springframework.context.annotation.internalCommonAnnotationProcessor"; + /** + * The bean name of the internally managed Scheduled annotation processor. + */ + public static final St...
true
Other
spring-projects
spring-framework
2bc3527f76247a3b8fd81ba5373b4b155e3a48b8.json
Consolidate annotation processing constants Consolidating internal bean name and aspect class name constats within AnnotationConfigUtils to allow access from both the context.config and context.annotation packages without creating a relationship between the two of them (they are unrelated leaf nodes in the packaging c...
org.springframework.context/src/main/java/org/springframework/scheduling/config/AnnotationDrivenBeanDefinitionParser.java
@@ -27,6 +27,7 @@ import org.springframework.beans.factory.support.BeanDefinitionRegistry; import org.springframework.beans.factory.xml.BeanDefinitionParser; import org.springframework.beans.factory.xml.ParserContext; +import org.springframework.context.annotation.AnnotationConfigUtils; import org.springframework.u...
true
Other
spring-projects
spring-framework
2bc3527f76247a3b8fd81ba5373b4b155e3a48b8.json
Consolidate annotation processing constants Consolidating internal bean name and aspect class name constats within AnnotationConfigUtils to allow access from both the context.config and context.annotation packages without creating a relationship between the two of them (they are unrelated leaf nodes in the packaging c...
org.springframework.context/src/test/java/org/springframework/scheduling/config/AnnotationDrivenBeanDefinitionParserTests.java
@@ -24,6 +24,7 @@ import org.springframework.beans.DirectFieldAccessor; import org.springframework.context.ApplicationContext; +import org.springframework.context.annotation.AnnotationConfigUtils; import org.springframework.context.support.ClassPathXmlApplicationContext; /** @@ -42,27 +43,26 @@ public void setu...
true
Other
spring-projects
spring-framework
2bc3527f76247a3b8fd81ba5373b4b155e3a48b8.json
Consolidate annotation processing constants Consolidating internal bean name and aspect class name constats within AnnotationConfigUtils to allow access from both the context.config and context.annotation packages without creating a relationship between the two of them (they are unrelated leaf nodes in the packaging c...
org.springframework.transaction/src/main/java/org/springframework/transaction/config/AnnotationDrivenBeanDefinitionParser.java
@@ -28,6 +28,7 @@ import org.springframework.beans.factory.xml.ParserContext; import org.springframework.context.config.AbstractSpecificationBeanDefinitionParser; import org.springframework.context.config.FeatureSpecification; +import org.springframework.transaction.annotation.TransactionManagementCapability; impor...
true
Other
spring-projects
spring-framework
9a271ce6c92695b9421aa603c9aa56e805c7920c.json
Introduce ImportSelector interface Allows @Enable* a layer of indirection for deciding which @Configuration class(es) to @Import. The @Import annotation may now accept @Configuration class literals and/or ImportSelector class literals.
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -27,6 +27,7 @@ import java.util.Set; import java.util.Stack; +import org.springframework.beans.BeanUtils; import org.springframework.beans.factory.parsing.Location; import org.springframework.beans.factory.parsing.Problem; import org.springframework.beans.factory.parsing.ProblemReporter; @@ -37,6 +38,7 @@ im...
true
Other
spring-projects
spring-framework
9a271ce6c92695b9421aa603c9aa56e805c7920c.json
Introduce ImportSelector interface Allows @Enable* a layer of indirection for deciding which @Configuration class(es) to @Import. The @Import annotation may now accept @Configuration class literals and/or ImportSelector class literals.
org.springframework.context/src/main/java/org/springframework/context/annotation/ImportSelector.java
@@ -0,0 +1,40 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
cdb01cbd3795f273b751d0f0a45caa22d07c62da.json
Introduce ImportAware interface @Configuration classes may implement ImportAware in order to be injected with the AnnotationMetadata of their @Import'ing class. Includes the introduction of a new PriorityOrdered ImportAwareBeanPostProcessor that handles injection of the importing class metadata.
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassParser.java
@@ -19,6 +19,7 @@ import java.io.IOException; import java.util.Collections; import java.util.Comparator; +import java.util.HashMap; import java.util.Iterator; import java.util.LinkedHashSet; import java.util.List; @@ -62,7 +63,7 @@ class ConfigurationClassParser { private final ProblemReporter problemReporter...
true
Other
spring-projects
spring-framework
cdb01cbd3795f273b751d0f0a45caa22d07c62da.json
Introduce ImportAware interface @Configuration classes may implement ImportAware in order to be injected with the AnnotationMetadata of their @Import'ing class. Includes the introduction of a new PriorityOrdered ImportAwareBeanPostProcessor that handles injection of the importing class metadata.
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java
@@ -24,27 +24,38 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.springframework.beans.BeansException; import org.springframework.beans.factory.BeanClassLoaderAware; import org.springframework.beans.factory.BeanDefinitionStoreException; +import org.springframewo...
true
Other
spring-projects
spring-framework
cdb01cbd3795f273b751d0f0a45caa22d07c62da.json
Introduce ImportAware interface @Configuration classes may implement ImportAware in order to be injected with the AnnotationMetadata of their @Import'ing class. Includes the introduction of a new PriorityOrdered ImportAwareBeanPostProcessor that handles injection of the importing class metadata.
org.springframework.context/src/main/java/org/springframework/context/annotation/ImportAware.java
@@ -0,0 +1,38 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
cdb01cbd3795f273b751d0f0a45caa22d07c62da.json
Introduce ImportAware interface @Configuration classes may implement ImportAware in order to be injected with the AnnotationMetadata of their @Import'ing class. Includes the introduction of a new PriorityOrdered ImportAwareBeanPostProcessor that handles injection of the importing class metadata.
org.springframework.context/src/test/java/org/springframework/context/annotation/ImportAwareTests.java
@@ -0,0 +1,137 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
cdb01cbd3795f273b751d0f0a45caa22d07c62da.json
Introduce ImportAware interface @Configuration classes may implement ImportAware in order to be injected with the AnnotationMetadata of their @Import'ing class. Includes the introduction of a new PriorityOrdered ImportAwareBeanPostProcessor that handles injection of the importing class metadata.
org.springframework.context/src/test/java/org/springframework/context/annotation/configuration/ScopingTests.java
@@ -193,8 +193,8 @@ public void testScopedProxyConfigurationWithClasses() throws Exception { @Test public void testScopedConfigurationBeanDefinitionCount() throws Exception { // count the beans - // 6 @Beans + 1 Configuration + 2 scoped proxy - assertEquals(9, ctx.getBeanDefinitionCount()); + // 6 @Beans + 1 ...
true
Other
spring-projects
spring-framework
856da7edb984cd8ad5643a376e536f40e06d8faa.json
Provide dedicated @ComponentScan processing @ComponentScan is now checked for explicitly and handled immediately when parsing @Configuration classes.
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanAnnotationParser.java
@@ -0,0 +1,132 @@ +/* + * Copyright 2002-2011 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
856da7edb984cd8ad5643a376e536f40e06d8faa.json
Provide dedicated @ComponentScan processing @ComponentScan is now checked for explicitly and handled immediately when parsing @Configuration classes.
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -95,6 +95,8 @@ public class ConfigurationClassBeanDefinitionReader { private Environment environment; + private final ComponentScanAnnotationParser componentScanParser; + /** * Create a new {@link ConfigurationClassBeanDefinitionReader} instance that will be used * to populate the given {@link BeanDefi...
true
Other
spring-projects
spring-framework
856da7edb984cd8ad5643a376e536f40e06d8faa.json
Provide dedicated @ComponentScan processing @ComponentScan is now checked for explicitly and handled immediately when parsing @Configuration classes.
org.springframework.context/src/test/java/org/springframework/context/annotation/ComponentScanAnnotationIntegrationTests.java
@@ -34,7 +34,6 @@ import org.springframework.beans.factory.annotation.CustomAutowireConfigurer; import org.springframework.beans.factory.config.BeanDefinition; import org.springframework.beans.factory.config.SimpleMapScope; -import org.springframework.beans.factory.parsing.BeanDefinitionParsingException; import org...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
build-spring-framework/resources/changelog.txt
@@ -7,6 +7,8 @@ Changes in version 3.1 M2 (2011-??-??) -------------------------------------- * deprecated AbstractJUnit38SpringContextTests and AbstractTransactionalJUnit38SpringContextTests +* eliminated @Feature support in favor of @Enable* and framework-provided @Configuration classes +* introduced @EnableTrans...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java
@@ -16,13 +16,12 @@ package org.springframework.aop.config; +import org.w3c.dom.Element; + import org.springframework.beans.factory.config.BeanDefinition; import org.springframework.beans.factory.parsing.BeanComponentDefinition; -import org.springframework.beans.factory.parsing.ComponentRegistrar; -import org.sp...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.beans/src/main/java/org/springframework/beans/factory/parsing/ComponentRegistrar.java
@@ -1,35 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.beans/src/main/java/org/springframework/beans/factory/parsing/ComponentRegistrarAdapter.java
@@ -1,55 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.beans/src/main/java/org/springframework/beans/factory/parsing/ProblemCollector.java
@@ -1,35 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.beans/src/main/java/org/springframework/beans/factory/parsing/SimpleProblemCollector.java
@@ -1,59 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.beans/src/main/java/org/springframework/beans/factory/xml/BeanDefinitionParser.java
@@ -22,27 +22,18 @@ /** * Interface used by the {@link DefaultBeanDefinitionDocumentReader} to handle custom, - * top-level (directly under {@code <beans>}) tags. + * top-level (directly under {@code <beans/>}) tags. * * <p>Implementations are free to turn the metadata in the custom tag into as many * {@link...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/.springBeans
@@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> <beansProjectDescription> <version>1</version> - <pluginVersion><![CDATA[2.5.0.201008272200-CI-R3822-B852]]></pluginVersion> + <pluginVersion><![CDATA[2.6.0.201103160035-RELEASE]]></pluginVersion> <configSuffixes> <configSuffix><![CDATA[xml]]></configSuffi...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/BeanMethod.java
@@ -16,13 +16,13 @@ package org.springframework.context.annotation; -import org.springframework.beans.factory.parsing.Location; import org.springframework.beans.factory.parsing.Problem; import org.springframework.beans.factory.parsing.ProblemReporter; import org.springframework.core.type.MethodMetadata; /** ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanAnnotationParser.java
@@ -1,97 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanBeanDefinitionParser.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2011 the original author or authors. + * Copyright 2002-2009 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,60 +16,263 @@ package org.springframe...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanExecutor.java
@@ -1,110 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/ComponentScanSpec.java
@@ -1,460 +0,0 @@ -/* - * Copyright 2002-2011 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
111fb71fe1ccb8d3a5e06e61461edd87d6d025f4.json
Remove "Feature" support introduced in 3.1 M1 Feature-related support such as @Feature, @FeatureConfiguration, and FeatureSpecification types will be replaced by framework-provided @Configuration classes and convenience annotations such as @ComponentScan (already exists), @EnableAsync, @EnableScheduling, @EnableTransa...
org.springframework.context/src/main/java/org/springframework/context/annotation/ConfigurationClassBeanDefinitionReader.java
@@ -33,7 +33,6 @@ import org.springframework.beans.factory.annotation.RequiredAnnotationBeanPostProcessor; import org.springframework.beans.factory.config.BeanDefinition; import org.springframework.beans.factory.config.BeanDefinitionHolder; -import org.springframework.beans.factory.parsing.BeanDefinitionParsingExcep...
true