language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | laravel | framework | 1a0930650601cbcbbaf4b4ede904bd147e0f461f.json | Use bootstrappers instead of events | src/Illuminate/Foundation/Console/Kernel.php | @@ -8,7 +8,6 @@
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Console\Scheduling\Schedule;
use Illuminate\Console\Application as Artisan;
-use Illuminate\Console\Events\ArtisanStarting;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Contracts\Console\Kernel as KernelContract;
use Sym... | true |
Other | laravel | framework | 1a0930650601cbcbbaf4b4ede904bd147e0f461f.json | Use bootstrappers instead of events | src/Illuminate/Support/ServiceProvider.php | @@ -2,7 +2,7 @@
namespace Illuminate\Support;
-use Illuminate\Console\Events\ArtisanStarting;
+use Illuminate\Console\Application as Artisan;
abstract class ServiceProvider
{
@@ -176,13 +176,8 @@ public function commands($commands)
{
$commands = is_array($commands) ? $commands : func_get_args();
... | true |
Other | laravel | framework | baa8a094fe61294e12913d8973fd06b09dd0b404.json | remove blank line | src/Illuminate/Routing/Console/stubs/controller.plain.stub | @@ -3,7 +3,6 @@
namespace DummyNamespace;
use Illuminate\Http\Request;
-
use DummyRootNamespaceHttp\Controllers\Controller;
class DummyClass extends Controller | true |
Other | laravel | framework | baa8a094fe61294e12913d8973fd06b09dd0b404.json | remove blank line | src/Illuminate/Routing/Console/stubs/controller.stub | @@ -3,7 +3,6 @@
namespace DummyNamespace;
use Illuminate\Http\Request;
-
use DummyRootNamespaceHttp\Controllers\Controller;
class DummyClass extends Controller | true |
Other | laravel | framework | fca954dd807e93d8e734c36357b9ee46617f77b0.json | Fix invalid @return types in dockblocks (#16006) | src/Illuminate/Foundation/Auth/AuthenticatesUsers.php | @@ -109,7 +109,7 @@ protected function authenticated(Request $request, $user)
* Get the failed login response instance.
*
* @param \Illuminate\Http\Request $request
- * @return \Illuminate\Http\Response
+ * @return \Illuminate\Http\RedirectResponse
*/
protected function sendFailedL... | true |
Other | laravel | framework | fca954dd807e93d8e734c36357b9ee46617f77b0.json | Fix invalid @return types in dockblocks (#16006) | src/Illuminate/Foundation/Auth/ResetsPasswords.php | @@ -18,7 +18,7 @@ trait ResetsPasswords
*
* @param \Illuminate\Http\Request $request
* @param string|null $token
- * @return \Illuminate\Http\Response
+ * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*/
public function showResetForm(Request $request, $token =... | true |
Other | laravel | framework | 07ab16fdfe4db427b4518ceda5693dbd3911b663.json | Simplify conditional (#16007) | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -36,24 +36,26 @@ class ModelMakeCommand extends GeneratorCommand
*/
public function fire()
{
- if (parent::fire() !== false) {
- if ($this->option('migration')) {
- $table = Str::plural(Str::snake(class_basename($this->argument('name'))));
+ if (parent::fire() ... | false |
Other | laravel | framework | 6440dac54b9786f3b273e6c60f3040ae4d2749a1.json | Keep the Composer Cache (#15997) | .travis.yml | @@ -21,6 +21,10 @@ matrix:
sudo: false
+cache:
+ directories:
+ - $HOME/.composer/cache
+
services:
- memcached
- redis-server | false |
Other | laravel | framework | 7971ecc1dd607f4b1ca16c2a4eb08ba05e64c0c6.json | Add flag for select type of create controller
Add flag for select type of create controller (resource controller or no). | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -45,8 +45,14 @@ public function fire()
if ($this->option('controller')) {
$controller = Str::studly(class_basename($this->argument('name')));
-
- $this->call('make:controller', ['name' => "{$controller}Controller", '--resource' => true]);
+
+ ... | false |
Other | laravel | framework | 8fb3cfe5a44ea2fbc9d5961f5afe33c23e108c7c.json | Use studly case for controller names (#15988) | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -44,7 +44,7 @@ public function fire()
}
if ($this->option('controller')) {
- $controller = Str::camel(class_basename($this->argument('name')));
+ $controller = Str::studly(class_basename($this->argument('name')));
$this->call('make:controll... | false |
Other | laravel | framework | 778350e5d6a59c4670251ca6b6e0419f801368ba.json | Fix a method naming error | src/Illuminate/Database/Migrations/Migrator.php | @@ -159,7 +159,7 @@ protected function runUp($file, $batch, $pretend)
return $this->pretendToRun($migration, 'up');
}
- $this->migrate($migration, 'up');
+ $this->runMigration($migration, 'up');
// Once we have run a migrations class, we will log that it was run in this
... | false |
Other | laravel | framework | 5aa9a6d5151ca983e3a2c6b638e46e240c14be1f.json | Remove an unused import | src/Illuminate/Database/Migrations/Migrator.php | @@ -2,7 +2,6 @@
namespace Illuminate\Database\Migrations;
-use Closure;
use Illuminate\Support\Arr;
use Illuminate\Support\Str;
use Illuminate\Support\Collection; | false |
Other | laravel | framework | 4e9c9fd98b4dff71f449764e87c52577e2634587.json | break constructor line | src/Illuminate/Validation/Validator.php | @@ -197,7 +197,8 @@ class Validator implements ValidatorContract
* @param array $customAttributes
* @return void
*/
- public function __construct(TranslatorInterface $translator, array $data, array $rules, array $messages = [], array $customAttributes = [])
+ public function __construct(Transl... | false |
Other | laravel | framework | 7322343923b5d6f963ee5ea03cc64a3d33361b6d.json | fix doc block | src/Illuminate/Foundation/Console/stubs/policy.stub | @@ -13,8 +13,8 @@ class DummyClass
/**
* Determine whether the user can view the dummyModelName.
*
- * @param DummyRootNamespaceUser $user
- * @param DummyRootNamespaceDummyModel $dummyModelName
+ * @param \DummyRootNamespaceUser $user
+ * @param \DummyRootNamespaceDummyModel $d... | false |
Other | laravel | framework | a8a55657a588291693b1faa93d1e6ebdb556b113.json | Fix some typos | CHANGELOG-5.2.md | @@ -259,7 +259,7 @@
- Simplified calling `Model::replicate()` with `$except` argument ([#13676](https://github.com/laravel/framework/pull/13676))
- Allow auth events to be serialized ([#13704](https://github.com/laravel/framework/pull/13704))
- Added `for` and `id` attributes to auth scaffold ([#13689](https://githu... | true |
Other | laravel | framework | a8a55657a588291693b1faa93d1e6ebdb556b113.json | Fix some typos | src/Illuminate/Database/Events/QueryExecuted.php | @@ -26,7 +26,7 @@ class QueryExecuted
public $time;
/**
- * The databse connection instance.
+ * The database connection instance.
*
* @var \Illuminate\Database\Connection
*/ | true |
Other | laravel | framework | a8a55657a588291693b1faa93d1e6ebdb556b113.json | Fix some typos | src/Illuminate/Queue/SyncQueue.php | @@ -52,7 +52,7 @@ public function push($job, $data = '', $queue = null)
}
/**
- * Handle an exception that occured while processing a job.
+ * Handle an exception that occurred while processing a job.
*
* @param \Illuminate\Queue\Jobs\Job $queueJob
* @param \Exception $e | true |
Other | laravel | framework | e3bd359d52cee0ba8db9673e45a8221c1c1d95d6.json | add retry helper | src/Illuminate/Support/helpers.php | @@ -606,6 +606,33 @@ function preg_replace_array($pattern, array $replacements, $subject)
}
}
+if (! function_exists('retry')) {
+ /**
+ * Retry an operation a given number of times.
+ *
+ * @param int $times
+ * @param callable $callback
+ * @return mixed
+ */
+ function retry... | false |
Other | laravel | framework | 7a0832bb44057f1060c96c2e01652aae7c583323.json | add tests and update transaction logic | src/Illuminate/Database/Connection.php | @@ -601,22 +601,25 @@ public function transaction(Closure $callback, $attempts = 1)
*/
public function beginTransaction()
{
- ++$this->transactions;
-
- if ($this->transactions == 1) {
+ if ($this->transactions == 0) {
try {
- $this->getPdo()->beginTransa... | true |
Other | laravel | framework | 7a0832bb44057f1060c96c2e01652aae7c583323.json | add tests and update transaction logic | tests/Database/DatabaseConnectionTest.php | @@ -114,15 +114,46 @@ public function testAffectingStatementProperlyCallsPDO()
$this->assertTrue(is_numeric($log[0]['time']));
}
- public function testTransactionsDecrementedOnTransactionException()
+ public function testTransactionLevelNotIncrementedOnTransactionException()
{
$pdo =... | true |
Other | laravel | framework | d0d1596464794a37a81b894869b3c23047a61ee5.json | Setup additional configuration for Slack Client. | src/Illuminate/Notifications/Channels/SlackWebhookChannel.php | @@ -59,12 +59,19 @@ protected function buildJsonPayload(SlackMessage $message)
'channel' => data_get($message, 'channel'),
]);
- return [
+ $payload = [
'json' => array_merge([
'text' => $message->content,
'attachments' => $this->attac... | true |
Other | laravel | framework | d0d1596464794a37a81b894869b3c23047a61ee5.json | Setup additional configuration for Slack Client. | src/Illuminate/Notifications/Messages/SlackMessage.php | @@ -48,6 +48,13 @@ class SlackMessage
*/
public $attachments = [];
+ /**
+ * Additional settings for Slack HTTP Client.
+ *
+ * @var array
+ */
+ public $options = [];
+
/**
* Indicate that the notification gives information about a successful operation.
*
@@ -145,4 +... | true |
Other | laravel | framework | 394ec059c3968a534434028b5040176b830d943b.json | fix notification fake for arrays | src/Illuminate/Support/Testing/Fakes/NotificationFake.php | @@ -26,6 +26,14 @@ class NotificationFake implements NotificationFactory
*/
public function assertSentTo($notifiable, $notification, $callback = null)
{
+ if (is_array($notifiable) || $notifiable instanceof Collection) {
+ foreach ($notifiable as $singleNotifiable) {
+ $... | false |
Other | laravel | framework | 057492d31c569e96a3ba2f99722112a9762c6071.json | fix various things | src/Illuminate/Cache/ArrayStore.php | @@ -100,6 +100,7 @@ public function forget($key)
public function flush()
{
$this->storage = [];
+
return true;
}
| true |
Other | laravel | framework | 057492d31c569e96a3ba2f99722112a9762c6071.json | fix various things | src/Illuminate/Cache/FileStore.php | @@ -188,12 +188,14 @@ public function flush()
{
if ($this->files->isDirectory($this->directory)) {
foreach ($this->files->directories($this->directory) as $directory) {
- if(!$this->files->deleteDirectory($directory)){
+ if (! $this->files->deleteDirectory($direc... | true |
Other | laravel | framework | 057492d31c569e96a3ba2f99722112a9762c6071.json | fix various things | src/Illuminate/Cache/NullStore.php | @@ -93,7 +93,7 @@ public function forget($key)
*/
public function flush()
{
- //
+ return true;
}
/** | true |
Other | laravel | framework | 057492d31c569e96a3ba2f99722112a9762c6071.json | fix various things | src/Illuminate/Cache/RedisStore.php | @@ -170,7 +170,9 @@ public function forget($key)
*/
public function flush()
{
- return (bool) $this->connection()->flushdb();
+ $this->connection()->flushdb();
+
+ return true;
}
/** | true |
Other | laravel | framework | 67128a4cdbb2d40c34b878cb28f58d59d63c9877.json | Add success message to clear-compiled command | src/Illuminate/Foundation/Console/ClearCompiledCommand.php | @@ -37,5 +37,7 @@ public function fire()
if (file_exists($servicesPath)) {
@unlink($servicesPath);
}
+
+ $this->info('Compiled class file removed!');
}
} | false |
Other | laravel | framework | 1526178f4e1ad7f02d751a822b8fac5bfb301500.json | Add fluent interface for the dimensions rule | src/Illuminate/Validation/Rule.php | @@ -27,4 +27,15 @@ public static function unique($table, $column = 'NULL')
{
return new Rules\Unique($table, $column);
}
+
+ /**
+ * Get a dimensions constraint builder instance.
+ *
+ * @param array $constraints
+ * @return \Illuminate\Validation\Rules\Dimensions
+ */
+ p... | true |
Other | laravel | framework | 1526178f4e1ad7f02d751a822b8fac5bfb301500.json | Add fluent interface for the dimensions rule | src/Illuminate/Validation/Rules/Dimensions.php | @@ -0,0 +1,131 @@
+<?php
+
+namespace Illuminate\Validation\Rules;
+
+class Dimensions
+{
+ /**
+ * The constraints for the dimensions rule.
+ *
+ * @var array
+ */
+ protected $constraints = [];
+
+ /**
+ * Create a new dimensions rule instance.
+ *
+ * @param array $constraints;... | true |
Other | laravel | framework | 1526178f4e1ad7f02d751a822b8fac5bfb301500.json | Add fluent interface for the dimensions rule | tests/Validation/ValidationDimensionsRuleTest.php | @@ -0,0 +1,22 @@
+<?php
+
+use Illuminate\Validation\Rule;
+use Illuminate\Validation\Rules\Dimensions;
+
+class ValidationDimensionsRuleTest extends PHPUnit_Framework_TestCase
+{
+ public function testItCorrectlyFormatsAStringVersionOfTheRule()
+ {
+ $rule = new Dimensions(['min_width' => 100, 'min_height... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | CHANGELOG-5.4.md | @@ -6,6 +6,7 @@
- Support wildcards in `MessageBag::first()` ([#15217](https://github.com/laravel/framework/pull/15217))
### Changed
+- Cache flush method returns bool ([#15578](https://github.com/laravel/framework/issues/15578))
### Fixed
| true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/ApcStore.php | @@ -113,11 +113,11 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
- $this->apc->flush();
+ return $this->apc->flush();
}
/** | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/ApcWrapper.php | @@ -83,10 +83,10 @@ public function delete($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
- $this->apcu ? apcu_clear_cache() : apc_clear_cache('user');
+ return $this->apcu ? apcu_clear_cache() : apc_cl... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/ArrayStore.php | @@ -95,11 +95,12 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
$this->storage = [];
+ return true;
}
/** | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/DatabaseStore.php | @@ -218,11 +218,11 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
- $this->table()->delete();
+ return (bool) $this->table()->delete();
}
/** | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/FileStore.php | @@ -182,15 +182,19 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
if ($this->files->isDirectory($this->directory)) {
foreach ($this->files->directories($this->directory... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/MemcachedStore.php | @@ -184,11 +184,11 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
- $this->memcached->flush();
+ return $this->memcached->flush();
}
/** | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/NullStore.php | @@ -89,7 +89,7 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{ | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Cache/RedisStore.php | @@ -166,11 +166,11 @@ public function forget($key)
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush()
{
- $this->connection()->flushdb();
+ return (bool) $this->connection()->flushdb();
}
/** | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | src/Illuminate/Contracts/Cache/Store.php | @@ -79,7 +79,7 @@ public function forget($key);
/**
* Remove all items from the cache.
*
- * @return void
+ * @return bool
*/
public function flush();
| true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheApcStoreTest.php | @@ -91,4 +91,13 @@ public function testForgetMethodProperlyCallsAPC()
$store = new Illuminate\Cache\ApcStore($apc);
$store->forget('foo');
}
+
+ public function testFlushesCached()
+ {
+ $apc = $this->getMockBuilder('Illuminate\Cache\ApcWrapper')->setMethods(['flush'])->getMock();
+ ... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheArrayStoreTest.php | @@ -63,7 +63,8 @@ public function testItemsCanBeFlushed()
$store = new ArrayStore;
$store->put('foo', 'bar', 10);
$store->put('baz', 'boom', 10);
- $store->flush();
+ $result = $store->flush();
+ $this->assertTrue($result);
$this->assertNull($store->get('foo'));
... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheDatabaseStoreTest.php | @@ -96,9 +96,10 @@ public function testItemsMayBeFlushedFromCache()
$store = $this->getStore();
$table = m::mock('StdClass');
$store->getConnection()->shouldReceive('table')->once()->with('table')->andReturn($table);
- $table->shouldReceive('delete')->once();
+ $table->shouldRec... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheFileStoreTest.php | @@ -120,10 +120,23 @@ public function testFlushCleansDirectory()
$files = $this->mockFilesystem();
$files->expects($this->once())->method('isDirectory')->with($this->equalTo(__DIR__))->will($this->returnValue(true));
$files->expects($this->once())->method('directories')->with($this->equalTo(_... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheMemcachedStoreTest.php | @@ -105,6 +105,19 @@ public function testForgetMethodProperlyCallsMemcache()
$store->forget('foo');
}
+ public function testFlushesCached()
+ {
+ if (! class_exists('Memcached')) {
+ $this->markTestSkipped('Memcached module not installed');
+ }
+
+ $memcache = $this... | true |
Other | laravel | framework | 4543caa9a45adbc2e127e8c92a70158bd191d83b.json | Change cache flush return type
Change flush return type
If a flush operation fails, then you now have chance of knowing about it.
Change flush method, return false on failure
Change flush test
Ensuring that flush method does return false, should the delete
directories return false.
Change wrapper flush return typ... | tests/Cache/CacheRedisStoreTest.php | @@ -119,6 +119,15 @@ public function testForgetMethodProperlyCallsRedis()
$redis->forget('foo');
}
+ public function testFlushesCached()
+ {
+ $redis = $this->getRedis();
+ $redis->getRedis()->shouldReceive('connection')->once()->with('default')->andReturn($redis->getRedis());
+ ... | true |
Other | laravel | framework | cb2eb7963b29aafe63c87e1d2b1e633ecd0c25b0.json | use a collection | src/Illuminate/Foundation/Console/RouteListCommand.php | @@ -138,15 +138,9 @@ protected function displayRoutes(array $routes)
*/
protected function getMiddleware($route)
{
- $middlewares = $route->gatherMiddleware();
-
- foreach ($middlewares as $i => $middleware) {
- if ($middleware instanceof Closure) {
- $middlewares... | false |
Other | laravel | framework | 3562235233d159e8adbc6c22507339dc1dc2af51.json | create a resource controller along with the model
it's incredibly common for me to make a resource controller for most of my models, so it'd be nice do it in one line.
while this would be a nicety, I can also see someone arguing that this adds unnecessary complexity, when it's already easy enough to just run the co... | src/Illuminate/Foundation/Console/ModelMakeCommand.php | @@ -42,6 +42,11 @@ public function fire()
$this->call('make:migration', ['name' => "create_{$table}_table", '--create' => $table]);
}
+ if ($this->option('controller')) {
+ $controller = Str::camel(class_basename($this->argument('name')));
+
+ $th... | false |
Other | laravel | framework | 1c78e00ef3815e7b0bf710037b52faefb464e97d.json | send eloquent collection for proper serializationg | src/Illuminate/Notifications/ChannelManager.php | @@ -114,7 +114,7 @@ protected function queueNotification($notifiables, $notification)
foreach ($notifiables as $notifiable) {
foreach ($notification->via($notifiable) as $channel) {
$bus->dispatch(
- (new SendQueuedNotifications([$notifiable], $notification, [$c... | false |
Other | laravel | framework | 34ad9726ad9de2069f3761bf3c75d00f9771f563.json | Hide developer hints in html (#15786)
Turn html comments into blade comments so that the resulting html is cleaner. | src/Illuminate/Pagination/resources/views/bootstrap-4.blade.php | @@ -1,20 +1,20 @@
@if ($paginator->hasPages())
<ul class="pagination">
- <!-- Previous Page Link -->
+ {{-- Previous Page Link --}}
@if ($paginator->onFirstPage())
<li class="page-item disabled"><span class="page-link">«</span></li>
@else
<li class="... | true |
Other | laravel | framework | 34ad9726ad9de2069f3761bf3c75d00f9771f563.json | Hide developer hints in html (#15786)
Turn html comments into blade comments so that the resulting html is cleaner. | src/Illuminate/Pagination/resources/views/default.blade.php | @@ -1,20 +1,20 @@
@if ($paginator->hasPages())
<ul class="pagination">
- <!-- Previous Page Link -->
+ {{-- Previous Page Link --}}
@if ($paginator->onFirstPage())
<li class="disabled"><span>«</span></li>
@else
<li><a href="{{ $paginator->previousPag... | true |
Other | laravel | framework | 34ad9726ad9de2069f3761bf3c75d00f9771f563.json | Hide developer hints in html (#15786)
Turn html comments into blade comments so that the resulting html is cleaner. | src/Illuminate/Pagination/resources/views/simple-bootstrap-4.blade.php | @@ -1,13 +1,13 @@
@if ($paginator->hasPages())
<ul class="pagination">
- <!-- Previous Page Link -->
+ {{-- Previous Page Link --}}
@if ($paginator->onFirstPage())
<li class="page-item disabled"><span class="page-link">«</span></li>
@else
<li class="... | true |
Other | laravel | framework | 34ad9726ad9de2069f3761bf3c75d00f9771f563.json | Hide developer hints in html (#15786)
Turn html comments into blade comments so that the resulting html is cleaner. | src/Illuminate/Pagination/resources/views/simple-default.blade.php | @@ -1,13 +1,13 @@
@if ($paginator->hasPages())
<ul class="pagination">
- <!-- Previous Page Link -->
+ {{-- Previous Page Link --}}
@if ($paginator->onFirstPage())
<li class="disabled"><span>«</span></li>
@else
<li><a href="{{ $paginator->previousPag... | true |
Other | laravel | framework | 242f52f83567ae0d3351744cc98e5a2fbab68592.json | fix a few bugs | src/Illuminate/Database/Eloquent/Factory.php | @@ -90,7 +90,7 @@ public function define($class, callable $attributes, $name = 'default')
*/
public function state($class, $state, callable $attributes)
{
- $this->modifiers[$class][$state] = $attributes;
+ $this->states[$class][$state] = $attributes;
}
/**
@@ -199,7 +199,7 @@ ... | false |
Other | laravel | framework | 4ef6fd76d5bcf3590f930ec262f1f0756eeaed3b.json | Fix a typo | src/Illuminate/Database/Migrations/Migrator.php | @@ -365,7 +365,7 @@ protected function getQueries($migration, $method)
* Run a migration, inside a transaction if the database supports it.
*
* @param \Closure $callback
- * @retrun void
+ * @return void
*/
protected function runMigration(Closure $callback)
{ | false |
Other | laravel | framework | f67e081cb48ef1bdbe7821a03f850442b501461f.json | fix various formatting issues | src/Illuminate/Validation/Validator.php | @@ -247,18 +247,19 @@ protected function hydrateFiles(array $data, $arrayKey = null)
}
foreach ($data as $key => $value) {
- $new_key = ($arrayKey) ? "$arrayKey.$key" : $key;
+ $newKey = ($arrayKey) ? "$arrayKey.$key" : $key;
// If this value is an instance of th... | false |
Other | laravel | framework | 061f54e319c72e320e9759860ef5a44fc37bda2b.json | fix import order | src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php | @@ -9,8 +9,8 @@
use Illuminate\Contracts\View\View;
use PHPUnit_Framework_Assert as PHPUnit;
use PHPUnit_Framework_ExpectationFailedException;
-use Symfony\Component\HttpFoundation\File\UploadedFile as SymfonyUploadedFile;
use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
+use Symfony\Component\HttpFo... | false |
Other | laravel | framework | 08bcbdbe70b69330943cc45625b160877b37341a.json | Add a top level #app id. | src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub | @@ -21,63 +21,65 @@
</script>
</head>
<body>
- <nav class="navbar navbar-default navbar-static-top">
- <div class="container">
- <div class="navbar-header">
+ <div id="app">
+ <nav class="navbar navbar-default navbar-static-top">
+ <div class="container">
+ ... | false |
Other | laravel | framework | 6b1075e479eacda7d131ccb0da525be2dfe33eb3.json | Add Seneca quote to Inspire command (#15747) | src/Illuminate/Foundation/Inspiring.php | @@ -26,6 +26,7 @@ public static function quote()
'Well begun is half done. - Aristotle',
'He who is contented is rich. - Laozi',
'Very little is needed to make a happy life. - Marcus Antoninus',
+ 'It is quality rather than quantity that matters. - Lucius Annaeus Seneca... | false |
Other | laravel | framework | cc9e1f09683fd23cf8e973e84bf310f7ce1304a2.json | register timeout handlers on php 7.1 | src/Illuminate/Queue/Worker.php | @@ -70,6 +70,8 @@ public function daemon($connectionName, $queue, WorkerOptions $options)
$lastRestart = $this->getTimestampOfLastQueueRestart();
while (true) {
+ $this->registerTimeoutHandler($options);
+
if ($this->daemonShouldRun()) {
$this->runNextJob($co... | false |
Other | laravel | framework | 45455d798ab3099815004ab0cc136d027dbb735f.json | fix minor document mistakes. (#15711) | src/Illuminate/Mail/Message.php | @@ -86,7 +86,7 @@ public function to($address, $name = null, $override = false)
/**
* Add a carbon copy to the message.
*
- * @param string $address
+ * @param string|array $address
* @param string|null $name
* @return $this
*/
@@ -98,7 +98,7 @@ public function cc($addre... | false |
Other | laravel | framework | 769ccaebc520a84f59ba62d8639b75f5081c03cf.json | Update Pluralizer.php (#15703)
Added some more words that I come across. | src/Illuminate/Support/Pluralizer.php | @@ -23,6 +23,7 @@ class Pluralizer
'emoji',
'equipment',
'fish',
+ 'furniture',
'gold',
'information',
'knowledge',
@@ -41,6 +42,7 @@ class Pluralizer
'species',
'swine',
'traffic',
+ 'wheat',
];
/** | false |
Other | laravel | framework | e6a81b6d3617b6de3baa87afbc1bd68ae91ea1ba.json | Add missing property. (#15664) | src/Illuminate/Session/CookieSessionHandler.php | @@ -23,6 +23,13 @@ class CookieSessionHandler implements SessionHandlerInterface
*/
protected $request;
+ /*
+ * The number of minutes the session should be valid.
+ *
+ * @var int
+ */
+ protected $minutes;
+
/**
* Create a new cookie driven handler instance.
* | false |
Other | laravel | framework | 38684f94871e66a599644b605b02c4bcac3ea088.json | Allow array of strings/arrays, optional name attr
This works in 5.3:
Mail::to('name1@example.com')->send(new OrderShipped($order));
And this works too:
$user1 = User::find(1);
$user2 = User::find(2);
Mail::to([$user1, $user2])->send(new OrderShipped($order));
However this does not work in 5.3:
Mail::to(['name1@examp... | src/Illuminate/Mail/Mailable.php | @@ -374,7 +374,12 @@ protected function setAddress($address, $name = null, $property = 'to')
if ($address instanceof Collection || is_array($address)) {
foreach ($address as $user) {
- $this->{$property}($user->email, $user->name);
+ if (is_array($user)){
+ ... | false |
Other | laravel | framework | ab0801cf08df7d448b1047892eabec07407739f6.json | change method order | src/Illuminate/Contracts/Translation/Translator.php | @@ -26,17 +26,17 @@ public function trans($key, array $replace = [], $locale = null);
public function transChoice($key, $number, array $replace = [], $locale = null);
/**
- * Set the default locale.
+ * Get the default locale being used.
*
- * @param string $locale
- * @return void
+... | false |
Other | laravel | framework | 33c6f9a19e0e19d8d1610e26c00d8acad58a5d71.json | Add tests for beginTransaction() retrying | src/Illuminate/Database/Connection.php | @@ -505,11 +505,11 @@ public function beginTransaction()
{
if ($this->transactions == 0) {
try {
- $this->getPdo()->beginTransaction();
+ $this->pdo->beginTransaction();
} catch (Exception $e) {
if ($this->causedByLostConnection($e))... | true |
Other | laravel | framework | 33c6f9a19e0e19d8d1610e26c00d8acad58a5d71.json | Add tests for beginTransaction() retrying | tests/Database/DatabaseConnectionTest.php | @@ -123,6 +123,36 @@ public function testTransactionLevelNotIncrementedOnTransactionException()
}
}
+ public function testBeginTransactionMethodRetriesOnFailure()
+ {
+ $pdo = $this->getMock('DatabaseConnectionTestMockPDO');
+ $pdo->expects($this->exactly(2))->method('beginTransactio... | true |
Other | laravel | framework | 7c9d04e27ff699ae9ff537d4dacac4f96ab7181e.json | use carbon addMinutes() function (#15545) | src/Illuminate/Cache/MemcachedStore.php | @@ -182,7 +182,7 @@ public function flush()
*/
protected function toTimestamp($minutes)
{
- return $minutes > 0 ? Carbon::now()->timestamp + ((int) $minutes * 60) : 0;
+ return $minutes > 0 ? Carbon::now()->addMinutes($minutes)->timestamp : 0;
}
/** | false |
Other | laravel | framework | c5984af3757e492c6e79cef161169ea09b5b9c7a.json | send unix timestamp to memcached | src/Illuminate/Cache/MemcachedStore.php | @@ -3,6 +3,7 @@
namespace Illuminate\Cache;
use Memcached;
+use Carbon\Carbon;
use Illuminate\Contracts\Cache\Store;
class MemcachedStore extends TaggableStore implements Store
@@ -82,7 +83,7 @@ public function many(array $keys)
*/
public function put($key, $value, $minutes)
{
- $this->me... | true |
Other | laravel | framework | c5984af3757e492c6e79cef161169ea09b5b9c7a.json | send unix timestamp to memcached | tests/Cache/CacheMemcachedStoreTest.php | @@ -49,10 +49,12 @@ public function testSetMethodProperlyCallsMemcache()
$this->markTestSkipped('Memcached module not installed');
}
+ Carbon\Carbon::setTestNow($now = Carbon\Carbon::now());
$memcache = $this->getMockBuilder('Memcached')->setMethods(['set'])->getMock();
- ... | true |
Other | laravel | framework | 2fb90f4c66ecc5bee876e701bbef1879dbb8b2be.json | fix Collection import on NotificationFake (#15506) | src/Illuminate/Support/Testing/Fakes/NotificationFake.php | @@ -3,6 +3,7 @@
namespace Illuminate\Support\Testing\Fakes;
use Ramsey\Uuid\Uuid;
+use Illuminate\Support\Collection;
use PHPUnit_Framework_Assert as PHPUnit;
use Illuminate\Contracts\Notifications\Factory as NotificationFactory;
| false |
Other | laravel | framework | 2ef1a22e911b2df978960fcff17873e7420c7c15.json | Add connection method to QueueFake | src/Illuminate/Support/Testing/Fakes/QueueFake.php | @@ -191,4 +191,15 @@ public function pop($queue = null)
{
//
}
+
+ /**
+ * Return fake queue.
+ *
+ * @param string $value
+ * @return \Illuminate\Contracts\Queue\Queue
+ */
+ public function connection($value = null)
+ {
+ return $this;
+ }
} | false |
Other | laravel | framework | 92b34069c1c36aef1e298174b2c3fbbe8511f28d.json | Remove uninstantiable seeder class (#15450) | src/Illuminate/Database/SeedServiceProvider.php | @@ -21,10 +21,6 @@ class SeedServiceProvider extends ServiceProvider
*/
public function register()
{
- $this->app->singleton('seeder', function () {
- return new Seeder;
- });
-
$this->registerSeedCommand();
$this->commands('command.seed'); | false |
Other | laravel | framework | 9ae949ffdc3cde39f91dcc0b7db7452586bd6c79.json | Remove unused method (#15446) | src/Illuminate/Foundation/Auth/SendsPasswordResetEmails.php | @@ -31,7 +31,7 @@ public function sendResetLinkEmail(Request $request)
// to send the link, we will examine the response then see the message we
// need to show to the user. Finally, we'll send out a proper response.
$response = $this->broker()->sendResetLink(
- $request->only('ema... | false |
Other | laravel | framework | 4df539c76353ff1931b0441f0d8f3f07bbf7b342.json | Add missing parameter to toMail (#15448) | src/Illuminate/Auth/Notifications/ResetPassword.php | @@ -39,9 +39,10 @@ public function via($notifiable)
/**
* Build the mail representation of the notification.
*
+ * @param mixed $notifiable
* @return \Illuminate\Notifications\Messages\MailMessage
*/
- public function toMail()
+ public function toMail($notifiable)
{
... | false |
Other | laravel | framework | 40438b3b88d7164f3c18f463ee1587bde9ad8ef4.json | Fix pcntl extension error for queue (#15393) | src/Illuminate/Queue/Console/ListenCommand.php | @@ -2,6 +2,7 @@
namespace Illuminate\Queue\Console;
+use RuntimeException;
use Illuminate\Queue\Listener;
use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;
@@ -47,6 +48,8 @@ public function __construct(Listener $listener)
* Execute the console command.
*
* @retur... | false |
Other | laravel | framework | 3130be90548f1c4e986138ce2bb224f29ab73f92.json | Add SSL options for Postgres DSN (#15371)
* Add SSL options for Postgres DSN
There is already the SSLMODE option available, but if you set it to verify-full, you would need to also set the sslrootcert with the full path of the server certificate. This way, the client will be able to check the certificate of the ser... | src/Illuminate/Database/Connectors/PostgresConnector.php | @@ -97,6 +97,18 @@ protected function getDsn(array $config)
$dsn .= ";sslmode={$sslmode}";
}
+ if (isset($config['sslcert'])) {
+ $dsn .= ";sslcert={$sslcert}";
+ }
+
+ if (isset($config['sslkey'])) {
+ $dsn .= ";sslkey={$sslkey}";
+ }
+
+ ... | false |
Other | laravel | framework | eb6e0fd3d77193f392181a12bef51a1c721652e7.json | Fix fatal error on file uploads (#15350)
PR #15250 broke file uploads in Laravel 5.3.7. | src/Illuminate/Http/Request.php | @@ -880,7 +880,7 @@ protected function filterFiles($files)
$files[$key] = $this->filterFiles($files[$key]);
}
- if (! $files[$key]) {
+ if (empty($files[$key])) {
unset($files[$key]);
}
} | false |
Other | laravel | framework | 91d25ee41d354925c1b2c60b15b9bbc69b360bf1.json | fix #10501 by fixing morph to naming (#15334) | src/Illuminate/Database/Eloquent/Model.php | @@ -805,10 +805,10 @@ public function morphTo($name = null, $type = null, $id = null)
if (is_null($name)) {
list($current, $caller) = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2);
- $name = Str::snake($caller['function']);
+ $name = $caller['function'];
}
- ... | true |
Other | laravel | framework | 91d25ee41d354925c1b2c60b15b9bbc69b360bf1.json | fix #10501 by fixing morph to naming (#15334) | src/Illuminate/Database/Eloquent/Relations/BelongsTo.php | @@ -305,6 +305,16 @@ public function getOtherKey()
return $this->otherKey;
}
+ /**
+ * Get the name of the relationship.
+ *
+ * @return string
+ */
+ public function getRelation()
+ {
+ return $this->relation;
+ }
+
/**
* Get the fully qualified associated ... | true |
Other | laravel | framework | 91d25ee41d354925c1b2c60b15b9bbc69b360bf1.json | fix #10501 by fixing morph to naming (#15334) | tests/Database/DatabaseEloquentModelTest.php | @@ -956,10 +956,32 @@ public function testMorphToCreatesProperRelation()
{
$model = new EloquentModelStub;
$this->addMockConnection($model);
+
+ // $this->morphTo();
$relation = $model->morphToStub();
$this->assertEquals('morph_to_stub_id', $relation->getForeignKey());
+ ... | true |
Other | laravel | framework | b4e6777ce18b2372d19569ca1314ef3d14a76cdf.json | remove unnecessary code | src/Illuminate/Support/Testing/Fakes/BusFake.php | @@ -61,10 +61,6 @@ public function dispatched($command, $callback = null)
return true;
};
- if (is_null($callback)) {
- return collect($this->commands[$command]);
- }
-
return collect($this->commands[$command])->filter(function ($command) use ($callback) {
... | true |
Other | laravel | framework | b4e6777ce18b2372d19569ca1314ef3d14a76cdf.json | remove unnecessary code | src/Illuminate/Support/Testing/Fakes/EventFake.php | @@ -61,10 +61,6 @@ public function fired($event, $callback = null)
return true;
};
- if (is_null($callback)) {
- return collect($this->events[$event]);
- }
-
return collect($this->events[$event])->filter(function ($arguments) use ($callback) {
retur... | true |
Other | laravel | framework | b4e6777ce18b2372d19569ca1314ef3d14a76cdf.json | remove unnecessary code | src/Illuminate/Support/Testing/Fakes/MailFake.php | @@ -120,10 +120,6 @@ public function sent($mailable, $callback = null)
return true;
};
- if (is_null($callback)) {
- return collect($this->mailables[$mailable]);
- }
-
return $this->mailablesOf($mailable)->filter(function ($mailable) use ($callback) {
... | true |
Other | laravel | framework | b4e6777ce18b2372d19569ca1314ef3d14a76cdf.json | remove unnecessary code | src/Illuminate/Support/Testing/Fakes/NotificationFake.php | @@ -68,10 +68,6 @@ public function sent($notifiable, $notification, $callback = null)
$notifications = collect($this->notificationsFor($notifiable, $notification));
- if (is_null($callback)) {
- return $notifications;
- }
-
return $notifications->filter(function ($argument... | true |
Other | laravel | framework | b4e6777ce18b2372d19569ca1314ef3d14a76cdf.json | remove unnecessary code | src/Illuminate/Support/Testing/Fakes/QueueFake.php | @@ -84,10 +84,6 @@ public function pushed($job, $callback = null)
return true;
};
- if (is_null($callback)) {
- return collect($this->jobs[$job]);
- }
-
return collect($this->jobs[$job])->filter(function ($data) use ($callback) {
return $callback($d... | true |
Other | laravel | framework | 7e7013222f98ff31db89fb732d047ce910c8753a.json | fix code styling | src/Illuminate/View/Compilers/BladeCompiler.php | @@ -513,7 +513,7 @@ protected function compileOverwrite($expression)
*/
protected function compileUnless($expression)
{
- return "<?php if ( ! $expression): ?>";
+ return "<?php if (! $expression): ?>";
}
/** | true |
Other | laravel | framework | 7e7013222f98ff31db89fb732d047ce910c8753a.json | fix code styling | tests/View/ViewBladeCompilerTest.php | @@ -309,7 +309,7 @@ public function testUnlessStatementsAreCompiled()
$string = '@unless (name(foo(bar)))
breeze
@endunless';
- $expected = '<?php if ( ! (name(foo(bar)))): ?>
+ $expected = '<?php if (! (name(foo(bar)))): ?>
breeze
<?php endif; ?>';
$this->assertEquals($expected, $co... | true |
Other | laravel | framework | 54d2c6b8e38e90da7466fb5f306e1dbbe08a28e9.json | Remove extra line | tests/Queue/QueueWorkerTest.php | @@ -91,7 +91,6 @@ public function test_job_is_not_released_if_it_has_exceeded_max_attempts()
$e = new RuntimeException;
$job = new WorkerFakeJob(function ($job) use ($e) {
-
// In normal use this would be incremented by being popped off the queue
$job->attempts++;
| false |
Other | laravel | framework | 6cac4df0f66a8624eb553169291c2f09842120e1.json | remove leading slash and extra brackets | tests/Notifications/NotificationMailChannelTest.php | @@ -294,7 +294,7 @@ public function toMail($notifiable)
$mock = Mockery::mock(Illuminate\Contracts\Mail\Mailable::class);
$mock->shouldReceive('send')->once()->with(Mockery::on(function ($mailer) {
- if (! ($mailer instanceof \Illuminate\Contracts\Mail\Mailer)) {
+ if (! $maile... | false |
Other | laravel | framework | 7b1916e1708b5a7fb31f5b42a4d6cd2f290998fc.json | add unit test for Mailable Notification | tests/Notifications/NotificationMailChannelTest.php | @@ -210,6 +210,20 @@ public function testMessageWithToAddress()
$channel->send($notifiable, $notification);
}
+
+ public function testMessageWithMailableContract()
+ {
+ $notification = new NotificationMailChannelTestNotificationWithMailableContract;
+ $notifiable = new NotificationM... | false |
Other | laravel | framework | dd29bbcb9cdeba47286d22666692d00dd9a3a35d.json | support aliases on withcount | src/Illuminate/Database/Eloquent/Builder.php | @@ -1056,20 +1056,20 @@ public function withCount($relations)
$relations = is_array($relations) ? $relations : func_get_args();
foreach ($this->parseWithRelations($relations) as $name => $constraints) {
- // If relation string matches "relation as newname" extract first part as the relati... | false |
Other | laravel | framework | 0730ec587dc7a4071966a1c65f3c978ccc4ad467.json | fix method order | src/Illuminate/Filesystem/Filesystem.php | @@ -306,25 +306,25 @@ public function isDirectory($directory)
}
/**
- * Determine if the given path is writable.
+ * Determine if the given path is readable.
*
* @param string $path
* @return bool
*/
- public function isWritable($path)
+ public function isReadable($pa... | false |
Other | laravel | framework | b05f46a0500349dadda6886178c043d3b72fc392.json | Fix some phpdoc inconsistencies | src/Illuminate/Database/Query/Builder.php | @@ -582,7 +582,7 @@ protected function invalidOperatorAndValue($operator, $value)
/**
* Add an "or where" clause to the query.
*
- * @param string|\Closure $column
+ * @param \Closure|string $column
* @param string $operator
* @param mixed $value
* @return \Illuminate... | true |
Other | laravel | framework | b05f46a0500349dadda6886178c043d3b72fc392.json | Fix some phpdoc inconsistencies | src/Illuminate/View/Factory.php | @@ -792,7 +792,7 @@ public function doneRendering()
/**
* Add new loop to the stack.
*
- * @param array|\Countable $data
+ * @param \Countable|array $data
* @return void
*/
public function addLoop($data) | true |
Other | laravel | framework | e509b3958dde4fbe8454edc79c6870f60a1082e9.json | fix a bunch of things | src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php | @@ -56,17 +56,28 @@ public function auth($request)
public function validAuthenticationResponse($request, $result)
{
if (Str::startsWith($request->channel_name, 'private')) {
- return $this->decodedPusherResponse(
+ return $this->decodePusherResponse(
$this->push... | false |
Other | laravel | framework | 6c3ecdc5cf02c19ae28218201152ef34cd1ff9b5.json | Fix regression in save(touch) option (#15264) | src/Illuminate/Database/Eloquent/Model.php | @@ -1462,7 +1462,7 @@ public function save(array $options = [])
// clause to only update this model. Otherwise, we'll just insert them.
if ($this->exists) {
$saved = $this->isDirty() ?
- $this->performUpdate($query) : true;
+ $this->performUpd... | true |
Other | laravel | framework | 6c3ecdc5cf02c19ae28218201152ef34cd1ff9b5.json | Fix regression in save(touch) option (#15264) | tests/Database/DatabaseEloquentModelTest.php | @@ -195,6 +195,23 @@ public function testUpdateProcessDoesntOverrideTimestamps()
$this->assertTrue($model->save());
}
+ public function testSaveDoesntUpateTimestampsIfTouchOptionDisabled()
+ {
+ $model = $this->getMockBuilder('EloquentModelStub')->setMethods(['newQueryWithoutScopes', 'updat... | true |
Other | laravel | framework | 5d062ad0b93350b757f151bc9dbe5fe7239c19cc.json | Add line below document block summary. | src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php | @@ -94,6 +94,7 @@ public function getPusher()
/**
* Decoded PusherResponse.
+ *
* @param mixed $response
* @return array
*/ | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.