language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Contracts/Cookie/QueueingFactory.php
@@ -7,7 +7,6 @@ interface QueueingFactory extends Factory /** * Queue a cookie to send with the next response. * - * @param mixed * @return void */ public function queue();
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Contracts/Foundation/Application.php
@@ -23,7 +23,6 @@ public function basePath(); /** * Get or check the current application environment. * - * @param mixed * @return string */ public function environment();
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Cookie/CookieJar.php
@@ -112,7 +112,6 @@ public function queued($key, $default = null) /** * Queue a cookie to send with the next response. * - * @param mixed * @return void */ public function queue()
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Database/Eloquent/Builder.php
@@ -388,7 +388,7 @@ public function chunk($count, callable $callback) * * @param int $count * @param callable $callback - * @param string $alias + * @param string $column * @return bool */ public function chunkById($count, callable $callback, $column = 'id')
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Foundation/Application.php
@@ -465,7 +465,6 @@ public function environmentFilePath() /** * Get or check the current application environment. * - * @param mixed * @return string|bool */ public function environment()
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Http/RedirectResponse.php
@@ -101,7 +101,6 @@ protected function removeFilesFromInput(array $input) /** * Flash an array of input to the session. * - * @param mixed string * @return $this */ public function onlyInput() @@ -112,7 +111,6 @@ public function onlyInput() /** * Flash an array of inpu...
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Http/Request.php
@@ -177,7 +177,6 @@ public function segments() /** * Determine if the current request URI matches a pattern. * - * @param mixed string * @return bool */ public function is() @@ -194,7 +193,6 @@ public function is() /** * Determine if the current request URL and query s...
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Queue/Worker.php
@@ -189,7 +189,7 @@ protected function getNextJob($connection, $queue) /** * Process a given job from the queue. * - * @param string $connection + * @param string $connectionName * @param \Illuminate\Contracts\Queue\Job $job * @param \Illuminate\Queue\WorkerOptions $options ...
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Routing/Router.php
@@ -1121,7 +1121,6 @@ public function currentRouteName() /** * Alias for the "currentRouteNamed" method. * - * @param mixed string * @return bool */ public function is() @@ -1165,7 +1164,6 @@ public function currentRouteAction() /** * Alias for the "currentRouteUses" m...
true
Other
laravel
framework
29923153f049bd1006953a74388511eda729318d.json
Fix possible errors on DocBlocks (#15239) Generating documentation using Sami, it reported some errors. I'm not sure if the tags in the comments are wrong or we should just ignore the error output of Sami. Anyway this is not a big issue at all, just a minor detail.
src/Illuminate/Support/Facades/Facade.php
@@ -62,7 +62,6 @@ public static function spy() /** * Initiate a mock expectation on the facade. * - * @param mixed * @return \Mockery\Expectation */ public static function shouldReceive()
true
Other
laravel
framework
4495d0cfb8632e3c59d0a80a8da03595b4dfb3ab.json
Fix return type of Model update() (#15243)
src/Illuminate/Database/Eloquent/Model.php
@@ -1401,7 +1401,7 @@ protected function incrementOrDecrementAttributeValue($column, $amount, $method) * * @param array $attributes * @param array $options - * @return bool|int + * @return bool */ public function update(array $attributes = [], array $options = []) {
false
Other
laravel
framework
1315f897bc4cd18a69c449cd64b01d6f9c46d815.json
Fix some docblocks. (#15187)
src/Illuminate/Http/JsonResponse.php
@@ -32,8 +32,6 @@ public function __construct($data = null, $status = 200, $headers = [], $options * * @param string|null $callback * @return $this - * - * @throws \InvalidArgumentException */ public function withCallback($callback = null) {
true
Other
laravel
framework
1315f897bc4cd18a69c449cd64b01d6f9c46d815.json
Fix some docblocks. (#15187)
src/Illuminate/Notifications/Messages/NexmoMessage.php
@@ -21,7 +21,7 @@ class NexmoMessage /** * Create a new message instance. * - * @param string $message + * @param string $content * @return void */ public function __construct($content = '') @@ -45,7 +45,7 @@ public function content($content) /** * Set the phone ...
true
Other
laravel
framework
2b7cc0e010303a2d0f0336952da90651a046a009.json
fix broken crap
src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php
@@ -5,7 +5,6 @@ use Pusher; use Illuminate\Support\Arr; use Illuminate\Support\Str; -use Symfony\Component\HttpFoundation\JsonResponse; use Symfony\Component\HttpKernel\Exception\HttpException; class PusherBroadcaster extends Broadcaster @@ -57,14 +56,11 @@ public function auth($request) public function val...
true
Other
laravel
framework
2b7cc0e010303a2d0f0336952da90651a046a009.json
fix broken crap
src/Illuminate/Broadcasting/Broadcasters/RedisBroadcaster.php
@@ -4,7 +4,6 @@ use Illuminate\Support\Arr; use Illuminate\Support\Str; -use Symfony\Component\HttpFoundation\JsonResponse; use Illuminate\Contracts\Redis\Database as RedisDatabase; use Symfony\Component\HttpKernel\Exception\HttpException; @@ -65,10 +64,10 @@ public function auth($request) public function ...
true
Other
laravel
framework
5b258fac3068261c20d40f924928a3a499f89384.json
fix style ci
src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php
@@ -37,7 +37,7 @@ public function __construct(Pusher $pusher) public function auth($request) { if (Str::startsWith($request->channel_name, ['private-', 'presence-']) && - !$request->user() + ! $request->user() ) { throw new HttpException(403); } @@...
false
Other
laravel
framework
e9d5846d5f6a767285bc071c178ee0f5ff4ee2c5.json
Hide empty paginators. (#15125)
src/Illuminate/Pagination/resources/views/bootstrap-4.blade.php
@@ -1,34 +1,36 @@ -<ul class="pagination"> - <!-- Previous Page Link --> - @if ($paginator->onFirstPage()) - <li class="page-item disabled"><span class="page-link">&laquo;</span></li> - @else - <li class="page-item"><a class="page-link" href="{{ $paginator->previousPageUrl() }}" rel="prev">&laquo...
true
Other
laravel
framework
e9d5846d5f6a767285bc071c178ee0f5ff4ee2c5.json
Hide empty paginators. (#15125)
src/Illuminate/Pagination/resources/views/default.blade.php
@@ -1,34 +1,36 @@ -<ul class="pagination"> - <!-- Previous Page Link --> - @if ($paginator->onFirstPage()) - <li class="disabled"><span>&laquo;</span></li> - @else - <li><a href="{{ $paginator->previousPageUrl() }}" rel="prev">&laquo;</a></li> - @endif - - <!-- Pagination Elements --> - ...
true
Other
laravel
framework
e9d5846d5f6a767285bc071c178ee0f5ff4ee2c5.json
Hide empty paginators. (#15125)
src/Illuminate/Pagination/resources/views/simple-bootstrap-4.blade.php
@@ -1,15 +1,17 @@ -<ul class="pagination"> - <!-- Previous Page Link --> - @if ($paginator->onFirstPage()) - <li class="page-item disabled"><span class="page-link">&laquo;</span></li> - @else - <li class="page-item"><a class="page-link" href="{{ $paginator->previousPageUrl() }}" rel="prev">&laquo...
true
Other
laravel
framework
e9d5846d5f6a767285bc071c178ee0f5ff4ee2c5.json
Hide empty paginators. (#15125)
src/Illuminate/Pagination/resources/views/simple-default.blade.php
@@ -1,15 +1,17 @@ -<ul class="pagination"> - <!-- Previous Page Link --> - @if ($paginator->onFirstPage()) - <li class="disabled"><span>&laquo;</span></li> - @else - <li><a href="{{ $paginator->previousPageUrl() }}" rel="prev">&laquo;</a></li> - @endif +@if ($paginator->count() > 1) + <ul c...
true
Other
laravel
framework
ef627f83c3174f28f6c67e012efeac2e00ef89d8.json
Remove duplicate CSRF Token (#15171)
src/Illuminate/Auth/Console/stubs/make/views/auth/passwords/reset.stub
@@ -11,8 +11,6 @@ <form class="form-horizontal" role="form" method="POST" action="{{ url('/password/reset') }}"> {{ csrf_field() }} - <input type="hidden" name="token" value="{{ $token }}"> - <div class="form-group{{ $errors...
false
Other
laravel
framework
b35d4c7bce7d88c10dfecfdde87589fa952a0d93.json
Remove unneeded variable
src/Illuminate/Database/Eloquent/Model.php
@@ -1539,8 +1539,7 @@ protected function performUpdate(Builder $query) $dirty = $this->getDirty(); if (count($dirty) > 0) { - $numRows = $this->setKeysForSaveQuery($query)->update($dirty); - + $this->setKeysForSaveQuery($query)->update($dirty); $this->fireModelEven...
false
Other
laravel
framework
7299d016862c5163570c9c7aa86a95fc26234521.json
Use same condition (#15127)
src/Illuminate/Notifications/resources/views/email.blade.php
@@ -84,7 +84,7 @@ <td style="{{ $fontFamily }} {{ $style['email-body_cell'] }}"> <!-- Greeting --> <h1 style="{{ $style['header-1'] }}"> - @if (! is_null($gre...
false
Other
laravel
framework
6c915b8ba5505d819c949a4b8fac8009d902876d.json
Fix doc block (#15136)
src/Illuminate/Routing/Router.php
@@ -1119,7 +1119,7 @@ public function currentRouteName() } /** - * Alias for the "currentRouteName" method. + * Alias for the "currentRouteNamed" method. * * @param mixed string * @return bool
false
Other
laravel
framework
0066b5da6f009275348ab71904da2376c6c47281.json
add methods to contract
src/Illuminate/Contracts/Notifications/Factory.php
@@ -11,4 +11,22 @@ interface Factory * @return mixed */ public function channel($name = null); + + /** + * Send the given notification to the given notifiable entities. + * + * @param \Illuminate\Support\Collection|array|mixed $notifiables + * @param mixed $notification + * @...
false
Other
laravel
framework
4046a8165a259f4608179fcee4f977b138e68b4e.json
remove long comment
src/Illuminate/Database/Eloquent/Builder.php
@@ -389,7 +389,7 @@ public function chunk($count, callable $callback) * @param int $count * @param callable $callback * @param string $column - * @param string $alias Alias of the ID column if there are multiple columns with the same name. The alias must be defined in a select statement. ...
false
Other
laravel
framework
a208d72f60f829a598bed6a94c89beee9d35b358.json
bind resource path
src/Illuminate/Foundation/Application.php
@@ -277,12 +277,12 @@ protected function bindPathsInContainer() { $this->instance('path', $this->path()); $this->instance('path.base', $this->basePath()); - $this->instance('path.resources', $this->resourcesPath()); $this->instance('path.lang', $this->langPath()); $this->...
false
Other
laravel
framework
f3730e6872ed95d14b89f6e1801cce0aa209f210.json
Adjust password reset notification (#15092)
src/Illuminate/Auth/Notifications/ResetPassword.php
@@ -44,10 +44,7 @@ public function via($notifiable) public function toMail() { return (new MailMessage) - ->line([ - 'You are receiving this email because we received a password reset request for your account.', - 'Click the button below to reset your password...
false
Other
laravel
framework
5c515a8adce4ab2fea0a8b105191f9ccc49cdb66.json
Add extra space
src/Illuminate/Notifications/resources/views/email-plain.blade.php
@@ -1,5 +1,5 @@ <?php -if( $greeting !== null ) { +if ( $greeting !== null ) { echo e($greeting); } else { echo $level == 'error' ? 'Whoops!' : 'Hello!';
false
Other
laravel
framework
8da2c77e926b49423a30b7ccf9003d1afe0d4316.json
Replace tabs with spaces
src/Illuminate/Notifications/resources/views/email-plain.blade.php
@@ -1,8 +1,8 @@ <?php if( $greeting !== null ) { - echo e($greeting); + echo e($greeting); } else { - echo $level == 'error' ? 'Whoops!' : 'Hello!'; + echo $level == 'error' ? 'Whoops!' : 'Hello!'; } ?>
false
Other
laravel
framework
0e193eaa648ae7c7e60eca806551fe9f8627d231.json
Remove nested ternary
src/Illuminate/Notifications/resources/views/email-plain.blade.php
@@ -1,4 +1,11 @@ -{{ ( $greeting !== null ) ? $greeting : ($level == 'error' ? 'Whoops!' : 'Hello!') }} +<?php +if( $greeting !== null ) { + echo e($greeting); +} else { + echo $level == 'error' ? 'Whoops!' : 'Hello!'; +} + +?> <?php
false
Other
laravel
framework
a4090a3ad5af8d87625e013d129c68bd82acaff5.json
Revert new line that casuses styleci failing
src/Illuminate/Notifications/Messages/SimpleMessage.php
@@ -22,7 +22,6 @@ class SimpleMessage /** * Greeting at the beginning of the notification. - * * If null, a greeting depending on the level will be displayed. * * @var string|null
false
Other
laravel
framework
cef70172b02f20b38281b3360069a951df2baedc.json
Add greeting option to SimpleMessage notification By default 'Hello!' or 'Whoops!' is displayed as greeting. You can override this with the `greeting()` method: ``` public function toMail($notifiable) { return (new MailMessage) ->greeting("Hi {$notifiable->name},") ->line('The int...
src/Illuminate/Notifications/Messages/SimpleMessage.php
@@ -20,6 +20,14 @@ class SimpleMessage */ public $subject; + /** + * Greeting at the beginning of the notification. + * If null, a greeting depending on the level will be displayed. + * + * @var string|null + */ + public $greeting = null; + /** * The "intro" lines of th...
true
Other
laravel
framework
cef70172b02f20b38281b3360069a951df2baedc.json
Add greeting option to SimpleMessage notification By default 'Hello!' or 'Whoops!' is displayed as greeting. You can override this with the `greeting()` method: ``` public function toMail($notifiable) { return (new MailMessage) ->greeting("Hi {$notifiable->name},") ->line('The int...
src/Illuminate/Notifications/resources/views/email-plain.blade.php
@@ -1,4 +1,4 @@ -{{ $level == 'error' ? 'Whoops!' : 'Hello!' }} +{{ ( $greeting !== null ) ? $greeting : ($level == 'error' ? 'Whoops!' : 'Hello!') }} <?php
true
Other
laravel
framework
cef70172b02f20b38281b3360069a951df2baedc.json
Add greeting option to SimpleMessage notification By default 'Hello!' or 'Whoops!' is displayed as greeting. You can override this with the `greeting()` method: ``` public function toMail($notifiable) { return (new MailMessage) ->greeting("Hi {$notifiable->name},") ->line('The int...
src/Illuminate/Notifications/resources/views/email.blade.php
@@ -84,10 +84,14 @@ <td style="{{ $fontFamily }} {{ $style['email-body_cell'] }}"> <!-- Greeting --> <h1 style="{{ $style['header-1'] }}"> - @if ($level == 'e...
true
Other
laravel
framework
a7870118c1d15813b47479cc7c7b01e36ee1f667.json
Fix serialization mistake
src/Illuminate/Notifications/ChannelManager.php
@@ -59,17 +59,18 @@ public function sendNow($notifiables, $notification) $original = clone $notification; foreach ($notifiables as $notifiable) { - $notification = clone $original; - - $notification->id = (string) Uuid::uuid4(); - + $notificationId = (string) Uuid::u...
false
Other
laravel
framework
e6063d7df79aa6bbc3829dcc0b3907fe8b49201c.json
Support custom `to` address on `MailMessage`
src/Illuminate/Notifications/Channels/MailChannel.php
@@ -42,7 +42,7 @@ public function send($notifiable, Notification $notification) $message = $notification->toMail($notifiable); $this->mailer->send($message->view, $message->data(), function ($m) use ($notifiable, $notification, $message) { - $recipients = $notifiable->routeNotificationFor...
true
Other
laravel
framework
e6063d7df79aa6bbc3829dcc0b3907fe8b49201c.json
Support custom `to` address on `MailMessage`
src/Illuminate/Notifications/Messages/MailMessage.php
@@ -28,6 +28,13 @@ class MailMessage extends SimpleMessage */ public $from = []; + /** + * The recipient information for the message. + * + * @var array + */ + public $to = []; + /** * The attachments for the message. * @@ -71,6 +78,19 @@ public function from($address...
true
Other
laravel
framework
e6063d7df79aa6bbc3829dcc0b3907fe8b49201c.json
Support custom `to` address on `MailMessage`
tests/Notifications/NotificationMailChannelTest.php
@@ -181,6 +181,35 @@ public function testMessageWithFromAddressAndNoName() $channel->send($notifiable, $notification); } + + public function testMessageWithToAddress() + { + $notification = new NotificationMailChannelTestNotificationWithToAddress; + $notifiable = new NotificationMail...
true
Other
laravel
framework
abd85c916df0cc0a6dc55de943a39db8b7eb4e0d.json
fix route list and kernel
src/Illuminate/Foundation/Console/RouteListCommand.php
@@ -181,9 +181,13 @@ protected function getControllerMiddlewareFromInstance($controller, $method) $results = []; - foreach ($controller->getMiddleware() as $name => $options) { - if (! $method || ! $this->methodExcludedByOptions($method, $options)) { - $results[] = Arr::get...
true
Other
laravel
framework
abd85c916df0cc0a6dc55de943a39db8b7eb4e0d.json
fix route list and kernel
src/Illuminate/Foundation/Http/Kernel.php
@@ -164,6 +164,10 @@ public function terminate($request, $response) ); foreach ($middlewares as $middleware) { + if (! is_string($middleware)) { + continue; + } + list($name, $parameters) = $this->parseMiddleware($middleware); $instanc...
true
Other
laravel
framework
abd85c916df0cc0a6dc55de943a39db8b7eb4e0d.json
fix route list and kernel
src/Illuminate/Routing/Controller.php
@@ -17,15 +17,15 @@ abstract class Controller /** * Register middleware on the controller. * - * @param array|string|\Closure $middlewares + * @param array|string|\Closure $middleware * @param array $options * @return \Illuminate\Routing\ControllerMiddlewareOptions */ -...
true
Other
laravel
framework
abd85c916df0cc0a6dc55de943a39db8b7eb4e0d.json
fix route list and kernel
src/Illuminate/Routing/Router.php
@@ -676,11 +676,13 @@ public function resolveMiddlewareClassName($name) return $name; } elseif (isset($map[$name]) && $map[$name] instanceof Closure) { return $map[$name]; + // If the middleware is the name of a middleware group, we will return the array // of middle...
true
Other
laravel
framework
fcef04958f22fdf8009486ae6b883572f21cf37a.json
Allow direct closure middleware
src/Illuminate/Routing/Router.php
@@ -669,16 +669,18 @@ public function resolveMiddlewareClassName($name) { $map = $this->middleware; - // If the middleware is the name of a middleware group, we will return the array - // of middlewares that belong to the group. This allows developers to group a - // set of middlewa...
true
Other
laravel
framework
fcef04958f22fdf8009486ae6b883572f21cf37a.json
Allow direct closure middleware
tests/Routing/RoutingRouteTest.php
@@ -146,6 +146,18 @@ public function testBasicDispatchingOfRoutes() } public function testClosureMiddleware() + { + $router = $this->getRouter(); + $middleware = function ($request, $next) { + return 'caught'; + }; + $router->get('foo/bar', ['middleware' => $middlew...
true
Other
laravel
framework
ae450475b44d145f5b72fe884d26e250607b37a4.json
replace redis to contracts interface (#15041)
src/Illuminate/Cache/RedisStore.php
@@ -3,7 +3,7 @@ namespace Illuminate\Cache; use Illuminate\Contracts\Cache\Store; -use Illuminate\Redis\Database as Redis; +use Illuminate\Contracts\Redis\Database as Redis; class RedisStore extends TaggableStore implements Store {
false
Other
laravel
framework
5a96ac2a1acb642d7ec9e4e0ab33000772c6718e.json
fix failing test (#15015)
tests/Support/SupportArrTest.php
@@ -215,8 +215,6 @@ public function testHas() { $array = ['products.desk' => ['price' => 100]]; $this->assertTrue(Arr::has($array, 'products.desk')); - $this->assertTrue(Arr::has($array, ['products.desk'])); - $this->assertFalse(Arr::has($array, ['products.desk', 'missing'])); ...
false
Other
laravel
framework
65927fc67b27ddf861ffebdbadc7f87ea48cf934.json
Update BladeCompiler.php (#14986)
src/Illuminate/View/Compilers/BladeCompiler.php
@@ -930,7 +930,7 @@ protected function compileEndpush($expression) * @param string $expression * @return string */ - protected function stripParentheses($expression) + public function stripParentheses($expression) { if (Str::startsWith($expression, '(')) { $expressio...
false
Other
laravel
framework
33f7e420604645831741412b52c8412139f4a3ef.json
Update AuthorizesRequests.php (#14939) Edited the comment to clarify the authorize method is for the current user.
src/Illuminate/Foundation/Auth/Access/AuthorizesRequests.php
@@ -7,7 +7,7 @@ trait AuthorizesRequests { /** - * Authorize a given action against a set of arguments. + * Authorize a given action against a set of arguments for the current user. * * @param mixed $ability * @param mixed|array $arguments
false
Other
laravel
framework
01408ab085348f1f7c09df50c9c67b3c27c3d236.json
Remove unnecessary "else" conditions (#14944)
src/Illuminate/Auth/AuthManager.php
@@ -88,15 +88,15 @@ protected function resolve($name) if (isset($this->customCreators[$config['driver']])) { return $this->callCustomCreator($name, $config); - } else { - $driverMethod = 'create'.ucfirst($config['driver']).'Driver'; - - if (method_exists($this, $driv...
false
Other
laravel
framework
ddbe239f92be1a344142914d397c75eff604a275.json
Allow failures for PHP 7.1
.travis.yml
@@ -30,3 +30,8 @@ install: - if [[ $setup = 'lowest' ]]; then travis_retry composer update --prefer-source --no-interaction --prefer-lowest --prefer-stable; fi script: vendor/bin/phpunit + +matrix: + allow_failures: + - php: 7.1 + fast_finish: true
false
Other
laravel
framework
99cf673faea7ed8c18f534596685492b4fb615e0.json
add file class
src/Illuminate/Filesystem/FilesystemAdapter.php
@@ -3,6 +3,7 @@ namespace Illuminate\Filesystem; use RuntimeException; +use Illuminate\Http\File; use Illuminate\Support\Str; use InvalidArgumentException; use Illuminate\Http\UploadedFile; @@ -74,7 +75,7 @@ public function get($path) */ public function put($path, $contents, $visibility = null) {...
true
Other
laravel
framework
99cf673faea7ed8c18f534596685492b4fb615e0.json
add file class
src/Illuminate/Http/File.php
@@ -0,0 +1,10 @@ +<?php + +namespace Illuminate\Http; + +use Symfony\Component\HttpFoundation\File\File as SymfonyFile; + +class File extends SymfonyFile +{ + use HashesFileNames; +}
true
Other
laravel
framework
99cf673faea7ed8c18f534596685492b4fb615e0.json
add file class
src/Illuminate/Http/HashesFileNames.php
@@ -0,0 +1,21 @@ +<?php + +namespace Illuminate\Http; + +trait HashesFileNames +{ + /** + * Get a filename for the file that is the MD5 hash of the contents. + * + * @param string $path + * @return string + */ + public function hashName($path = null) + { + if ($path) { + ...
true
Other
laravel
framework
99cf673faea7ed8c18f534596685492b4fb615e0.json
add file class
src/Illuminate/Http/UploadedFile.php
@@ -9,7 +9,7 @@ class UploadedFile extends SymfonyUploadedFile { - use Macroable; + use HashesFileNames, Macroable; /** * Get the fully qualified path to the file. @@ -41,21 +41,6 @@ public function clientExtension() return $this->guessClientExtension(); } - /** - * Get a f...
true
Other
laravel
framework
71040ec51e58d96f521ab5d5ccf600ea3c4305be.json
Make getTokenForRequest public (#14927) When calling Auth::guard('api')->user() and receiving null it is not possible to differentiate between guest access and an invalid token. In the case of an invalid token it would be preferable to ask the user to login again and receive a new token rather than assume they are a g...
src/Illuminate/Auth/TokenGuard.php
@@ -78,7 +78,7 @@ public function user() * * @return string */ - protected function getTokenForRequest() + public function getTokenForRequest() { $token = $this->request->input($this->inputKey);
false
Other
laravel
framework
64b2015f3156ad67fbd4b006efc3b629ec41b989.json
revert recent changes to key generate.
src/Illuminate/Foundation/Console/KeyGenerateCommand.php
@@ -51,11 +51,11 @@ public function fire() */ protected function setKeyInEnvironmentFile($key) { - $originalEnvContent = file_get_contents($this->laravel->environmentFilePath()); - - $newEnvContent = preg_replace('/APP_KEY="?[^\'"\s]+"?/', "APP_KEY=\"$key\"", $originalEnvContent); - - ...
false
Other
laravel
framework
9d0487bd04b8799cb7da3898b1277d6ac32969dc.json
Remove empty class content.
tests/Bus/BusDispatcherTest.php
@@ -113,7 +113,6 @@ class BusDispatcherTestSpecificQueueAndDelayCommand implements Illuminate\Contra class StandAloneCommand { - } class StandAloneHandler
false
Other
laravel
framework
73944943476aef81a7c98b9d0615d551cf8226ba.json
Return command from test stub.
tests/Bus/BusDispatcherTest.php
@@ -74,7 +74,7 @@ public function testDispatcherCanDispatchStandAloneHandler() $response = $dispatcher->dispatch(new StandAloneCommand); - $this->assertEquals('stone-alone-handler', $response); + $this->assertInstanceOf(StandAloneCommand::class, $response); } } @@ -118,8 +118,8 @@ cla...
false
Other
laravel
framework
6e77be515a1830ebcae9dce5a504e2b74a089dad.json
bind only true ints as ints
src/Illuminate/Database/Connection.php
@@ -407,7 +407,7 @@ public function bindValues($statement, $bindings) foreach ($bindings as $key => $value) { $statement->bindValue( is_string($key) ? $key : $key + 1, $value, - filter_var($value, FILTER_VALIDATE_INT) !== false ? PDO::PARAM_INT : PDO::PARAM_STR + ...
false
Other
laravel
framework
deeada07e03dc5a48b6d8c0cc7f493d58599d002.json
Create NotificationFailed event (#14874)
src/Illuminate/Notifications/Events/NotificationFailed.php
@@ -0,0 +1,51 @@ +<?php + +namespace Illuminate\Notifications\Events; + +class NotificationFailed +{ + /** + * The notifiable entity who received the notification. + * + * @var mixed + */ + public $notifiable; + + /** + * The notification instance. + * + * @var \Illuminate\Notificat...
false
Other
laravel
framework
afd9c98dc66661b570e26b65b94d60f061a290db.json
allow the disable_asserts config value (#14864)
src/Illuminate/Filesystem/FilesystemManager.php
@@ -239,7 +239,7 @@ protected function getRackspaceContainer(Rackspace $client, array $config) */ protected function createFlysystem(AdapterInterface $adapter, array $config) { - $config = Arr::only($config, ['visibility']); + $config = Arr::only($config, ['visibility', 'disable_asserts'])...
false
Other
laravel
framework
a4247f0c6c0c9c866109bb76ca255f5cf7503f06.json
fix queued mailables
src/Illuminate/Mail/MailableMailer.php
@@ -93,7 +93,7 @@ public function bcc($users) public function send(Mailable $mailable) { if ($mailable instanceof ShouldQueue) { - return $this->queue($this->fill($mailable)); + return $this->queue($mailable); } return $this->mailer->send($this->fill($mailabl...
false
Other
laravel
framework
ab9686ae58f1e89bae4e31fcb70bacc0ab546eb6.json
allow returning array when routing mail
src/Illuminate/Notifications/Channels/MailChannel.php
@@ -42,7 +42,13 @@ public function send($notifiable, Notification $notification) $message = $notification->toMail($notifiable); $this->mailer->send($message->view, $message->toArray(), function ($m) use ($notifiable, $notification, $message) { - $m->to($notifiable->routeNotificationFor('m...
false
Other
laravel
framework
ba60590aa0e62a1c0ee271c0008d73d127cc4feb.json
ignore missing methods
src/Illuminate/Support/Facades/Facade.php
@@ -90,6 +90,8 @@ protected static function createFreshMockInstance($name) $mock->shouldAllowMockingProtectedMethods(); + $mock->shouldIgnoreMissing(); + if (isset(static::$app)) { static::$app->instance($name, $mock); }
false
Other
laravel
framework
180656fba314b28976ba06b44b1d9f03eea3d1dc.json
Add the great macroable to Lang (#14844)
src/Illuminate/Translation/Translator.php
@@ -5,12 +5,15 @@ use Illuminate\Support\Arr; use Illuminate\Support\Str; use Illuminate\Support\Collection; +use Illuminate\Support\Traits\Macroable; use Illuminate\Support\NamespacedItemResolver; use Symfony\Component\Translation\MessageSelector; use Symfony\Component\Translation\TranslatorInterface; class T...
false
Other
laravel
framework
cd0939d35b68db2e0661efac53a7ca3b932430a8.json
fix method order
src/Illuminate/Notifications/Events/NotificationSent.php
@@ -35,8 +35,8 @@ class NotificationSent */ public function __construct($notifiable, $notification, $channel) { + $this->channel = $channel; $this->notifiable = $notifiable; $this->notification = $notification; - $this->channel = $channel; } }
false
Other
laravel
framework
bbc1ba6c6d1f5f9f925e67071427b2aae21731db.json
change method order
src/Illuminate/Database/Eloquent/SoftDeletingScope.php
@@ -9,7 +9,7 @@ class SoftDeletingScope implements Scope * * @var array */ - protected $extensions = ['ForceDelete', 'Restore', 'WithTrashed', 'OnlyTrashed', 'WithoutTrashed']; + protected $extensions = ['ForceDelete', 'Restore', 'WithTrashed', 'WithoutTrashed', 'OnlyTrashed']; /** ...
false
Other
laravel
framework
33aee31523b9fc280aced35a5eb5f6b627263b45.json
add sync without detaching method
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -795,6 +795,17 @@ public function createMany(array $records, array $joinings = []) return $instances; } + /** + * Sync the intermediate tables with a list of IDs without detaching. + * + * @param \Illuminate\Database\Eloquent\Collection|array $ids + * @return array + */ + ...
false
Other
laravel
framework
3c57cf0a0f1962f9da9de8454d11b033226c1c39.json
Remove nitpick (#14821)
.gitattributes
@@ -5,7 +5,6 @@ .editorconfig export-ignore .gitattributes export-ignore .gitignore export-ignore -.nitpick.json export-ignore .php_cs export-ignore .travis.yml export-ignore phpunit.xml.dist export-ignore
true
Other
laravel
framework
3c57cf0a0f1962f9da9de8454d11b033226c1c39.json
Remove nitpick (#14821)
.nitpick.json
@@ -1,5 +0,0 @@ -{ - "ignore": [ - "tests/*" - ] -}
true
Other
laravel
framework
f67a06a7a918e94fbd3c9d6f93e66f2ebd58f790.json
Update author email Update the author email address to taylor@laravel.com instead of gmail.
composer.json
@@ -11,7 +11,7 @@ "authors": [ { "name": "Taylor Otwell", - "email": "taylorotwell@gmail.com" + "email": "taylor@laravel.com" } ], "require": {
false
Other
laravel
framework
58736c8d416dc95901f94a24b143d21089df374d.json
Fix export-ignore for phpunit.xml Export phpunit.xml.dist instead of phpunit.xml.
.gitattributes
@@ -8,6 +8,6 @@ .nitpick.json export-ignore .php_cs export-ignore .travis.yml export-ignore -phpunit.xml export-ignore +phpunit.xml.dist export-ignore CHANGELOG.md export-ignore CONTRIBUTING.md export-ignore
false
Other
laravel
framework
d0bc401b7384ae4b63adcfdaddbd415c4394e3d3.json
fix queue listen
src/Illuminate/Queue/Listener.php
@@ -74,7 +74,7 @@ protected function buildWorkerCommand() $artisan = defined('ARTISAN_BINARY') ? ProcessUtils::escapeArgument(ARTISAN_BINARY) : 'artisan'; - $command = 'queue:work %s --queue=%s --delay=%s --memory=%s --sleep=%s --tries=%s'; + $command = 'queue:work %s --once --queue=%s --dela...
true
Other
laravel
framework
d0bc401b7384ae4b63adcfdaddbd415c4394e3d3.json
fix queue listen
tests/Queue/QueueListenerTest.php
@@ -39,6 +39,6 @@ public function testMakeProcessCorrectlyFormatsCommandLine() $this->assertInstanceOf('Symfony\Component\Process\Process', $process); $this->assertEquals(__DIR__, $process->getWorkingDirectory()); $this->assertEquals(3, $process->getTimeout()); - $this->assertEquals($e...
true
Other
laravel
framework
3771406f049e0bb766152b56af1384e0ec6be574.json
Bind numeric string with PDO::PARAM_STR (#14786)
src/Illuminate/Database/Connection.php
@@ -407,7 +407,7 @@ public function bindValues($statement, $bindings) foreach ($bindings as $key => $value) { $statement->bindValue( is_string($key) ? $key : $key + 1, $value, - filter_var($value, FILTER_VALIDATE_FLOAT) !== false ? PDO::PARAM_INT : PDO::PARAM_STR + ...
false
Other
laravel
framework
0dbd340ebb1a909c00c26d09a81fce93c2cfbffd.json
remove unused imports
src/Illuminate/Mail/Mailer.php
@@ -6,8 +6,6 @@ use Swift_Mailer; use Swift_Message; use Illuminate\Support\Arr; -use Illuminate\Support\Str; -use SuperClosure\Serializer; use InvalidArgumentException; use Illuminate\Contracts\View\Factory; use Illuminate\Contracts\Events\Dispatcher;
false
Other
laravel
framework
a3a80b44f059fd14627916a762694cd74579937f.json
Fix typo for function_exists (#14766)
src/Illuminate/Queue/Console/WorkCommand.php
@@ -107,7 +107,7 @@ protected function gatherWorkerOptions() { $timeout = $this->option('timeout', 60); - if ($timeout && ! function_exist('pcntl_fork')) { + if ($timeout && ! function_exists('pcntl_fork')) { throw new RuntimeException('The pcntl extension is required in order...
false
Other
laravel
framework
b7f7a3f5e21733f48c58d2fbcb6512a3a83a453f.json
Make Mailable@with more flexible (#14764)
src/Illuminate/Mail/Mailable.php
@@ -411,12 +411,17 @@ public function text($textView, array $data = []) /** * Set the view data for the message. * - * @param array $data + * @param string|array $key + * @param mixed $value * @return $this */ - public function with(array $data) + public function wi...
false
Other
laravel
framework
9edd86235328fa805b9ad23eb7f6a61d04562b2e.json
Add missing import at RedisBroadcaster
src/Illuminate/Broadcasting/Broadcasters/RedisBroadcaster.php
@@ -3,6 +3,7 @@ namespace Illuminate\Broadcasting\Broadcasters; use Illuminate\Support\Arr; +use Illuminate\Support\Str; use Illuminate\Contracts\Redis\Database as RedisDatabase; use Symfony\Component\HttpKernel\Exception\HttpException;
false
Other
laravel
framework
3d74b25c9f5c9c340d9d7a776ad878ce333bca5c.json
fix Action reference (#14746)
src/Illuminate/Notifications/Messages/SimpleMessage.php
@@ -2,6 +2,8 @@ namespace Illuminate\Notifications\Messages; +use Illuminate\Notifications\Action; + class SimpleMessage { /**
false
Other
laravel
framework
f6715f4f7514c2bba44c9f80dc452fef078f19de.json
Allow usage of the worker without pcntl
src/Illuminate/Queue/Console/WorkCommand.php
@@ -3,6 +3,7 @@ namespace Illuminate\Queue\Console; use Carbon\Carbon; +use RuntimeException; use Illuminate\Queue\Worker; use Illuminate\Console\Command; use Illuminate\Queue\WorkerOptions; @@ -104,9 +105,15 @@ protected function runWorker($connection, $queue) */ protected function gatherWorkerOption...
true
Other
laravel
framework
f6715f4f7514c2bba44c9f80dc452fef078f19de.json
Allow usage of the worker without pcntl
src/Illuminate/Queue/Worker.php
@@ -103,7 +103,9 @@ protected function daemonShouldRun() */ protected function runNextJobForDaemon($connectionName, $queue, WorkerOptions $options) { - if ($processId = pcntl_fork()) { + if (! $options->timeout) { + $this->runNextJob($connectionName, $queue, $options); + ...
true
Other
laravel
framework
bf6b364c6568893e888d1064a6fccef3e6f91ec2.json
send notification type
src/Illuminate/Notifications/Events/BroadcastNotificationCreated.php
@@ -64,7 +64,10 @@ public function broadcastOn() */ public function broadcastWith() { - return array_merge($this->data, ['id' => $this->notification->id]); + return array_merge($this->data, [ + 'id' => $this->notification->id, + 'type' => get_class($this->notification...
false
Other
laravel
framework
f493e7a0878c9145b9dda1c8854732c80d84eacc.json
Remove undefined parameters from docblocks
src/Illuminate/Contracts/Bus/Dispatcher.php
@@ -8,7 +8,6 @@ interface Dispatcher * Dispatch a command to its appropriate handler. * * @param mixed $command - * @param \Closure|null $afterResolving * @return mixed */ public function dispatch($command); @@ -17,7 +16,6 @@ public function dispatch($command); * Dispatc...
false
Other
laravel
framework
1e4f5b8af243fb95230b39f49a6cf5341d975df9.json
Return new exception
src/Illuminate/Database/Eloquent/RelationNotFoundException.php
@@ -17,6 +17,6 @@ public static function make($model, $relation) { $class = get_class($model); - throw new static("Call to undefined relationship [{$relation}] on model [{$class}]."); + return new static("Call to undefined relationship [{$relation}] on model [{$class}]."); } }
false
Other
laravel
framework
e417a9480220f6cb958747bd922a94b4736698a0.json
Apply patch from StyleCI
tests/Validation/ValidationValidatorTest.php
@@ -249,7 +249,7 @@ public function testDisplayableValuesAreReplaced() $trans->addResource('array', ['validation.in' => ':attribute must be included in :values.'], 'en', 'messages'); $customValues = [ 'type' => [ - '5' => 'Short', + '5' => 'Short', ...
false
Other
laravel
framework
45d6abfe9926aca8610fd65518974a0ceab33716.json
fix bugs in code
src/Illuminate/Database/Eloquent/Model.php
@@ -2150,9 +2150,7 @@ public function makeHidden($attributes) { $this->visible = array_diff($this->visible, (array) $attributes); - if (! empty($this->hidden)) { - $this->addHidden($attributes); - } + $this->hidden = array_unique(array_merge($this->hidden, $attributes)); ...
true
Other
laravel
framework
45d6abfe9926aca8610fd65518974a0ceab33716.json
fix bugs in code
tests/Database/DatabaseEloquentModelTest.php
@@ -698,17 +698,6 @@ public function testVisible() $this->assertArrayNotHasKey('age', $array); } - public function testHiddenAreIgnoringWhenVisibleExists() - { - $model = new EloquentModelStub(['name' => 'foo', 'age' => 'bar', 'id' => 'baz']); - $model->setVisible(['name', 'id']); - ...
true
Other
laravel
framework
3e576e399875a2d2e897334647b8e40fcf34bcd0.json
Use proper assertions (#14672)
tests/Database/DatabaseQueryBuilderTest.php
@@ -1200,7 +1200,7 @@ public function testUpdateOrInsertMethod() $builder->shouldReceive('exists')->once()->andReturn(false); $builder->shouldReceive('insert')->once()->with(['email' => 'foo', 'name' => 'bar'])->andReturn(true); - $this->assertEquals(true, $builder->updateOrInsert(['email' =>...
false
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Foundation/Console/stubs/notification.stub
@@ -34,12 +34,12 @@ class DummyClass extends Notification /** * Get the notification message. * - * @return void + * @return \Illuminate\Notifications\Message */ - public function message() + public function message($notifiable) { - $this->line('The introduction to the n...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/ChannelManager.php
@@ -46,8 +46,6 @@ public function send($notifiables, $notification) */ public function sendNow($notifiables, $notification) { - $notification->message(); - if (! $notification->application) { $notification->application( $this->app['config']['app.name'],
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Channels/DatabaseChannel.php
@@ -29,13 +29,15 @@ public function send($notifiables, Notification $notification) */ protected function createNotification($notifiable, Notification $notification) { + $message = $notification->message($notifiable); + return $notifiable->routeNotificationFor('database')->create([ ...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Channels/MailChannel.php
@@ -5,6 +5,7 @@ use Illuminate\Support\Arr; use Illuminate\Support\Str; use Illuminate\Contracts\Mail\Mailer; +use Illuminate\Notifications\Message; use Illuminate\Notifications\Notification; class MailChannel @@ -36,39 +37,25 @@ public function __construct(Mailer $mailer) */ public function send($not...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Channels/NexmoSmsChannel.php
@@ -52,28 +52,29 @@ public function send($notifiables, Notification $notification) $this->nexmo->message()->send([ 'from' => $this->from, 'to' => $to, - 'text' => $this->formatNotification($notification), + 'text' => $this->formatNotification(...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Channels/SlackWebhookChannel.php
@@ -3,6 +3,7 @@ namespace Illuminate\Notifications\Channels; use GuzzleHttp\Client as HttpClient; +use Illuminate\Notifications\Message; use Illuminate\Notifications\Notification; class SlackWebhookChannel @@ -39,14 +40,16 @@ public function send($notifiables, Notification $notification) contin...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Message.php
@@ -0,0 +1,178 @@ +<?php + +namespace Illuminate\Notifications; + +class Message +{ + /** + * The "level" of the notification (info, success, error). + * + * @var string + */ + public $level = 'info'; + + /** + * The subject of the notification. + * + * @var string + */ + pub...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
src/Illuminate/Notifications/Notification.php
@@ -2,6 +2,7 @@ namespace Illuminate\Notifications; +use BadMethodCallException; use Illuminate\Queue\SerializesModels; class Notification @@ -22,55 +23,6 @@ class Notification */ public $logoUrl; - /** - * The "level" of the notification (info, success, error). - * - * @var string ...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
tests/Notifications/NotificationBroadcastChannelTest.php
@@ -1,5 +1,6 @@ <?php +use Illuminate\Notifications\Message; use Illuminate\Notifications\Notification; use Illuminate\Notifications\Channels\BroadcastChannel; @@ -12,7 +13,7 @@ public function tearDown() public function testBroadcastChannelCreatesDatabaseRecordWithProperData() { - $notificati...
true
Other
laravel
framework
a1a50bd612c71338fb9be6da8445e2ba6838a5b6.json
use message object
tests/Notifications/NotificationChannelManagerTest.php
@@ -23,9 +23,6 @@ public function testNotificationCanBeDispatchedToDriver() $driver->shouldReceive('send')->andReturnUsing(function ($notifiables, $notification) { $this->assertEquals('Name', $notification->application); $this->assertEquals('Logo', $notification->logoUrl); - ...
true