language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | mrdoob | three.js | 516dce8f38107e8585e438dc335e8fb4bdc04b09.json | place holders for test animations. | src/animation/AnimationClip.js | @@ -155,3 +155,27 @@ THREE.AnimationClip.prototype = {
};
+THREE.AnimationClip.CreateMorphAnimation = function( morphTargetNames, duration ) {
+ // TODO
+ // - should create three keys per morphTarget track.
+ // - one track per morphTarget name.
+};
+
+THREE.AnimationClip.CreateRotationAnimation = function( nod... | true |
Other | mrdoob | three.js | 516dce8f38107e8585e438dc335e8fb4bdc04b09.json | place holders for test animations. | src/animation/KeyframeTrack.js | @@ -20,7 +20,7 @@ THREE.KeyframeTrack = function ( name, keys ) {
THREE.KeyframeTrack.prototype = {
- constructor: THREE.Track,
+ constructor: THREE.KeyframeTrack,
getAt: function( time ) {
console.log( 'KeyframeTrack[' + this.name + '].getAt( ' + time + ' )' ); | true |
Other | mrdoob | three.js | 9c8e33510e34d43dcc7c3776f1298ec85bf633ac.json | add css: pointer-events | editor/css/light.css | @@ -39,6 +39,7 @@ input.Number {
#viewport #info {
text-shadow: 1px 1px 0px rgba(0,0,0,0.25);
+ pointer-events: none;
}
#script { | false |
Other | mrdoob | three.js | 360f932f22299d14c32afa5ea8305cba35d03470.json | add css: pointer-events | editor/css/dark.css | @@ -46,6 +46,7 @@ input.Number {
#viewport #info {
text-shadow: 1px 1px 0px rgba(0,0,0,0.25);
+ pointer-events: none;
}
#script { | false |
Other | mrdoob | three.js | cd2e24938f95f2364dd3c117ca80d2bc8310dc6c.json | Fix error in BoxHelper with non-geometric object | src/extras/helpers/BoxHelper.js | @@ -28,6 +28,8 @@ THREE.BoxHelper.prototype.update = ( function () {
box.setFromObject( object );
+ if ( box.empty() ) return;
+
var min = box.min;
var max = box.max;
| false |
Other | mrdoob | three.js | 6a2a28fe34e3ff1ab6b183325ebbc810da2a4195.json | Extract OrbitConstraint from OrbitControls
OrbitControls takes care of the DOM, input binding and event handling.
OrbitConstraint is responsible for keeping the camera on an orbit, maintaining its orientation towards the target and updating the camera and target position.
There is only one insignificant API change. ... | examples/js/controls/OrbitControls.js | @@ -7,700 +7,740 @@
*/
/*global THREE, console */
-// This set of controls performs orbiting, dollying (zooming), and panning. It maintains
-// the "up" direction as +Y, unlike the TrackballControls. Touch on tablet and phones is
-// supported.
-//
-// Orbit - left mouse / touch: one finger move
-// Zoom - m... | false |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/cameras/OrthographicCamera.js | @@ -40,7 +40,7 @@ THREE.OrthographicCamera.prototype.clone = function () {
var camera = new THREE.OrthographicCamera();
- THREE.Camera.prototype.copy.call( camera, this );
+ camera.copy( this );
camera.zoom = this.zoom;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/cameras/PerspectiveCamera.js | @@ -126,7 +126,7 @@ THREE.PerspectiveCamera.prototype.clone = function () {
var camera = new THREE.PerspectiveCamera();
- THREE.Camera.prototype.copy.call( camera, this );
+ camera.copy( this );
camera.zoom = this.zoom;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/CircleBufferGeometry.js | @@ -77,7 +77,7 @@ THREE.CircleBufferGeometry.prototype.clone = function () {
this.parameters.thetaLength
);
- THREE.BufferGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/DodecahedronGeometry.js | @@ -64,7 +64,7 @@ THREE.DodecahedronGeometry.prototype.clone = function () {
this.parameters.detail
);
- THREE.PolyhedronGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/IcosahedronGeometry.js | @@ -39,7 +39,7 @@ THREE.IcosahedronGeometry.prototype.clone = function () {
this.parameters.detail
);
- THREE.PolyhedronGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/OctahedronGeometry.js | @@ -32,7 +32,7 @@ THREE.OctahedronGeometry.prototype.clone = function () {
this.parameters.detail
);
- THREE.PolyhedronGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/PlaneBufferGeometry.js | @@ -104,7 +104,7 @@ THREE.PlaneBufferGeometry.prototype.clone = function () {
this.parameters.heightSegments
);
- THREE.BufferGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/SphereBufferGeometry.js | @@ -112,7 +112,7 @@ THREE.SphereBufferGeometry.prototype.clone = function () {
this.parameters.thetaLength
);
- THREE.BufferGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/extras/geometries/TetrahedronGeometry.js | @@ -33,7 +33,7 @@ THREE.TetrahedronGeometry.prototype.clone = function () {
this.parameters.detail
);
- THREE.PolyhedronGeometry.prototype.copy.call( geometry, this );
+ geometry.copy( this );
return geometry;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/AmbientLight.js | @@ -17,7 +17,7 @@ THREE.AmbientLight.prototype.clone = function () {
var light = new THREE.AmbientLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
return light;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/AreaLight.js | @@ -31,7 +31,7 @@ THREE.AreaLight.prototype.clone = function () {
var light = new THREE.AreaLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
light.normal.copy(this.normal);
light.right.copy(this.right); | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/DirectionalLight.js | @@ -67,7 +67,7 @@ THREE.DirectionalLight.prototype.clone = function () {
var light = new THREE.DirectionalLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
light.target = this.target.clone();
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/HemisphereLight.js | @@ -22,7 +22,7 @@ THREE.HemisphereLight.prototype.clone = function () {
var light = new THREE.HemisphereLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
light.groundColor.copy( this.groundColor );
light.intensity = this.intensity; | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/PointLight.js | @@ -21,7 +21,7 @@ THREE.PointLight.prototype.clone = function () {
var light = new THREE.PointLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
light.intensity = this.intensity;
light.distance = this.distance; | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/lights/SpotLight.js | @@ -50,7 +50,7 @@ THREE.SpotLight.prototype.clone = function () {
var light = new THREE.SpotLight();
- THREE.Light.prototype.copy.call( light, this );
+ light.copy( this );
light.target = this.target.clone();
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/LineBasicMaterial.js | @@ -47,7 +47,7 @@ THREE.LineBasicMaterial.prototype.clone = function () {
var material = new THREE.LineBasicMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/LineDashedMaterial.js | @@ -50,7 +50,7 @@ THREE.LineDashedMaterial.prototype.clone = function () {
var material = new THREE.LineDashedMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/MeshBasicMaterial.js | @@ -83,7 +83,7 @@ THREE.MeshBasicMaterial.prototype.clone = function () {
var material = new THREE.MeshBasicMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/MeshDepthMaterial.js | @@ -35,7 +35,7 @@ THREE.MeshDepthMaterial.prototype.clone = function () {
var material = new THREE.MeshDepthMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.wireframe = this.wireframe;
material.wireframeLinewidth = this.wireframeLinewidth; | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/MeshLambertMaterial.js | @@ -82,7 +82,7 @@ THREE.MeshLambertMaterial.prototype.clone = function () {
var material = new THREE.MeshLambertMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
material.emissive.copy( this.emissive ); | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/MeshNormalMaterial.js | @@ -36,7 +36,7 @@ THREE.MeshNormalMaterial.prototype.clone = function () {
var material = new THREE.MeshNormalMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.wireframe = this.wireframe;
material.wireframeLinewidth = this.wireframeLinewidth; | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/MeshPhongMaterial.js | @@ -116,7 +116,7 @@ THREE.MeshPhongMaterial.prototype.clone = function () {
var material = new THREE.MeshPhongMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
material.emissive.copy( this.emissive ); | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/PointCloudMaterial.js | @@ -48,7 +48,7 @@ THREE.PointCloudMaterial.prototype.clone = function () {
var material = new THREE.PointCloudMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/RawShaderMaterial.js | @@ -17,7 +17,7 @@ THREE.RawShaderMaterial.prototype.clone = function () {
var material = new THREE.RawShaderMaterial();
- THREE.ShaderMaterial.prototype.copy.call( material, this );
+ material.copy( this );
return material;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/materials/SpriteMaterial.js | @@ -43,7 +43,7 @@ THREE.SpriteMaterial.prototype.clone = function () {
var material = new THREE.SpriteMaterial();
- THREE.Material.prototype.copy.call( material, this );
+ material.copy( this );
material.color.copy( this.color );
material.map = this.map; | true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/objects/LineSegments.js | @@ -17,7 +17,7 @@ THREE.LineSegments.prototype.clone = function () {
var line = new THREE.LineSegments( this.geometry, this.material );
- THREE.Line.prototype.copy.call( line, this );
+ line.copy( this );
return line;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/textures/CompressedTexture.js | @@ -28,7 +28,7 @@ THREE.CompressedTexture.prototype.clone = function () {
var texture = new THREE.CompressedTexture();
- THREE.Texture.prototype.copy.call( texture, this );
+ texture.copy( this );
return texture;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/textures/CubeTexture.js | @@ -20,7 +20,7 @@ THREE.CubeTexture.clone = function () {
var texture = new THREE.CubeTexture();
- THREE.Texture.prototype.copy.call( texture, this );
+ texture.copy( this );
texture.images = this.images;
| true |
Other | mrdoob | three.js | 309ef4a72900fae5175d72b605394f0c6972a93b.json | Simplify copy invocation | src/textures/DataTexture.js | @@ -17,7 +17,7 @@ THREE.DataTexture.prototype.clone = function () {
var texture = new THREE.DataTexture();
- THREE.Texture.prototype.copy.call( texture, this );
+ texture.copy( this );
return texture;
| true |
Other | mrdoob | three.js | 2326db968f885471939cb6c1cc0bdbab64074daa.json | Fix typo in webgl_materials_bumpmap_skin | examples/webgl_materials_bumpmap_skin.html | @@ -216,7 +216,7 @@
effectCopy.renderToScreen = true;
- var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBFormat, stencilBufer: false };
+ var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBFormat, stencilBuffer: false };
... | false |
Other | mrdoob | three.js | b4575e143d7438d0c0d00be65a1a76ce0a87db83.json | fix index -> start | src/renderers/WebGLRenderer.js | @@ -1212,13 +1212,13 @@ THREE.WebGLRenderer = function ( parameters ) {
} else {
- _gl.drawArrays( mode, offsets[i].index, offsets[i].count );
+ _gl.drawArrays( mode, offsets[ i ].start, offsets[i].count );
}
_this.info.render.calls++;
- _this.info.render.vertices += offsets[i].c... | false |
Other | mrdoob | three.js | 3c67a38348ff0d9d5c9c6ea939006206e91a6e4b.json | remove unnessary worlk | src/renderers/WebGLRenderer.js | @@ -1195,19 +1195,13 @@ THREE.WebGLRenderer = function ( parameters ) {
// must set attribute pointers to use new offsets for each chunk
// even if geometry and materials didn't change
- updateBuffers = true;
-
- for ( var i = 0, il = offsets.length; i < il; i++ ) {
-
- var startIndex = offsets[i]... | false |
Other | mrdoob | three.js | c2d8c3d5b7400bf5582bff77266321d1e652d236.json | Add draw calls to non-indexed buffers | src/renderers/WebGLRenderer.js | @@ -1068,7 +1068,7 @@ THREE.WebGLRenderer = function ( parameters ) {
if ( extension === null ) {
- THREE.error( 'THREE.WebGLRenderer.setupVertexAttributes: using THREE.InstancedBufferGeometry but hardware does not support extension ANGLE_instanced_arrays.' );
+ THREE.error( 'THREE.WebGLRenderer.ren... | false |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/core/BufferGeometry.js | @@ -316,7 +316,7 @@ THREE.BufferGeometry.prototype = {
var hasFaceVertexUv = faceVertexUvs[ 0 ] && faceVertexUvs[ 0 ].length > 0;
var hasFaceVertexUv2 = faceVertexUvs[ 1 ] && faceVertexUvs[ 1 ].length > 0;
- var hasFaceVertexNormals = faces[ 0 ] && faces[ 0 ].vertexNormals.length == 3;
+ var hasFaceVertexNorm... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/core/Geometry.js | @@ -757,7 +757,7 @@ THREE.Geometry.prototype = {
// if any duplicate vertices are found in a Face3
// we have to remove the face as nothing can be saved
for ( var n = 0; n < 3; n ++ ) {
- if ( indices[ n ] == indices[ ( n + 1 ) % 3 ] ) {
+ if ( indices[ n ] === indices[ ( n + 1 ) % 3 ] ) {
dup... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/animation/MorphAnimation.js | @@ -52,7 +52,7 @@ THREE.MorphAnimation.prototype = {
var influences = this.mesh.morphTargetInfluences;
- if ( frame != this.currentFrame ) {
+ if ( frame !== this.currentFrame ) {
influences[ this.lastFrame ] = 0;
influences[ this.currentFrame ] = 1; | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/core/Curve.js | @@ -110,7 +110,7 @@ THREE.Curve.prototype.getLengths = function ( divisions ) {
if ( ! divisions ) divisions = (this.__arcLengthDivisions) ? (this.__arcLengthDivisions) : 200;
if ( this.cacheArcLengths
- && ( this.cacheArcLengths.length == divisions + 1 )
+ && ( this.cacheArcLengths.length === divisions + 1 )
... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/core/CurvePath.js | @@ -12,7 +12,7 @@ THREE.CurvePath = function () {
this.curves = [];
this.bends = [];
-
+
this.autoClose = false; // Automatically closes the path
};
@@ -37,11 +37,11 @@ THREE.CurvePath.prototype.closePath = function() {
// Add a line curve if start and end of lines are not connected
var startPoint = thi... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/core/Path.js | @@ -376,7 +376,7 @@ THREE.Path.prototype.getPoints = function( divisions, closedPath ) {
//THREE.log(points);
break;
-
+
case THREE.PathActions.ELLIPSE:
var aX = args[ 0 ], aY = args[ 1 ],
@@ -464,9 +464,9 @@ THREE.Path.prototype.toShapes = function( isCCW, noHoles ) {
args = item.args;
a... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/core/Shape.js | @@ -128,7 +128,7 @@ THREE.Shape.Utils = {
function point_in_segment_2D_colin( inSegPt1, inSegPt2, inOtherPt ) {
// inOtherPt needs to be colinear to the inSegment
- if ( inSegPt1.x != inSegPt2.x ) {
+ if ( inSegPt1.x !== inSegPt2.x ) {
if ( inSegPt1.x < inSegPt2.x ) {
return ( ( inSegPt1.x <= in... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/curves/CatmullRomCurve3.js | @@ -100,7 +100,7 @@ THREE.CatmullRomCurve3 = ( function() {
intPoint = Math.floor( point );
weight = point - intPoint;
- if ( weight == 0 && intPoint == l - 1 ) {
+ if ( weight === 0 && intPoint === l - 1 ) {
intPoint = l - 2;
weight = 1;
@@ -109,7 +109,7 @@ THREE.CatmullRomCurve3 = ( function... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/curves/SplineCurve.js | @@ -19,7 +19,7 @@ THREE.SplineCurve.prototype.getPoint = function ( t ) {
var intPoint = Math.floor( point );
var weight = point - intPoint;
- var point0 = points[ intPoint == 0 ? intPoint : intPoint - 1 ];
+ var point0 = points[ intPoint === 0 ? intPoint : intPoint - 1 ];
var point1 = points[ intPoint ];
var... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/geometries/ExtrudeGeometry.js | @@ -250,7 +250,7 @@ THREE.ExtrudeGeometry.prototype.addShape = function ( shape, options ) {
if ( v_prev_x < - EPSILON ) {
if ( v_next_x < - EPSILON ) { direction_eq = true; }
} else {
- if ( Math.sign(v_prev_y) == Math.sign(v_next_y) ) { direction_eq = true; }
+ if ( Math.sign(v_prev_y) === Mat... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/extras/geometries/PolyhedronGeometry.js | @@ -153,7 +153,7 @@ THREE.PolyhedronGeometry = function ( vertices, indices, radius, detail ) {
for ( var j = 0; j <= rows; j ++) {
- if ( j == 0 && i == cols ) {
+ if ( j === 0 && i === cols ) {
v[ i ][ j ] = aj;
@@ -175,7 +175,7 @@ THREE.PolyhedronGeometry = function ( vertices, indices, radiu... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/loaders/CompressedTextureLoader.js | @@ -49,7 +49,7 @@ THREE.CompressedTextureLoader.prototype = {
if ( loaded === 6 ) {
- if (texDatas.mipmapCount == 1)
+ if (texDatas.mipmapCount === 1)
texture.minFilter = THREE.LinearFilter;
texture.format = texDatas.format; | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/materials/Material.js | @@ -91,7 +91,7 @@ THREE.Material.prototype = {
currentValue.copy( newValue );
- } else if ( key == 'overdraw' ) {
+ } else if ( key === 'overdraw' ) {
// ensure overdraw is backwards-compatable with legacy boolean type
this[ key ] = Number( newValue ); | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Math.js | @@ -17,11 +17,11 @@ THREE.Math = {
for ( var i = 0; i < 36; i ++ ) {
- if ( i == 8 || i == 13 || i == 18 || i == 23 ) {
+ if ( i === 8 || i === 13 || i === 18 || i === 23 ) {
uuid[ i ] = '-';
- } else if ( i == 14 ) {
+ } else if ( i === 14 ) {
uuid[ i ] = '4';
@@ -30,7 +30,7 @@ ... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Matrix4.js | @@ -685,7 +685,7 @@ THREE.Matrix4.prototype = {
var det = n11 * te[ 0 ] + n21 * te[ 4 ] + n31 * te[ 8 ] + n41 * te[ 12 ];
- if ( det == 0 ) {
+ if ( det === 0 ) {
var msg = "THREE.Matrix4.getInverse(): can't invert matrix, determinant is 0";
| true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Plane.js | @@ -140,10 +140,10 @@ THREE.Plane.prototype = {
var denominator = this.normal.dot( direction );
- if ( denominator == 0 ) {
+ if ( denominator === 0 ) {
// line is coplanar, return origin
- if ( this.distanceToPoint( line.start ) == 0 ) {
+ if ( this.distanceToPoint( line.start ) === 0 ) {
... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Ray.js | @@ -261,7 +261,7 @@ THREE.Ray.prototype = {
// in order to always return an intersect point that is in front of the ray.
if ( t0 < 0 ) return this.at( t1, optionalTarget );
- // else t0 is in front of the ray, so return the first collision point scaled by t0
+ // else t0 is in front of the ray, so return... | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Spline.js | @@ -104,7 +104,7 @@ THREE.Spline = function ( points ) {
point = ( this.points.length - 1 ) * index;
intPoint = Math.floor( point );
- if ( intPoint != oldIntPoint ) {
+ if ( intPoint !== oldIntPoint ) {
chunkLengths[ intPoint ] = totalLength;
oldIntPoint = intPoint; | true |
Other | mrdoob | three.js | dad328077dfc50ab44bdc9a70634787374d45253.json | use strict (in)equalities | src/math/Triangle.js | @@ -61,7 +61,7 @@ THREE.Triangle.barycoordFromPoint = function () {
var result = optionalTarget || new THREE.Vector3();
// colinear or singular triangle
- if ( denom == 0 ) {
+ if ( denom === 0 ) {
// arbitrary location outside of triangle?
// not sure if this is the best idea, maybe should be returni... | true |
Other | mrdoob | three.js | 669eb6dd6191978e2f6b280bc50f976453f3d654.json | Simplify tracking of EdgesGeometry coordinates | src/extras/geometries/EdgesGeometry.js | @@ -33,7 +33,6 @@ THREE.EdgesGeometry = function ( geometry, thresholdAngle ) {
var vertices = geometry2.vertices;
var faces = geometry2.faces;
- var numEdges = 0;
for ( var i = 0, l = faces.length; i < l; i ++ ) {
@@ -50,7 +49,6 @@ THREE.EdgesGeometry = function ( geometry, thresholdAngle ) {
if ( hash... | false |
Other | mrdoob | three.js | cfa8e9aa0c7c9cb9aec7e3415bc5d3bd549c4da8.json | Add unit tests | test/unit/geometry/EdgesGeometry.js | @@ -0,0 +1,273 @@
+module( "EdgesGeometry" );
+
+var DEBUG = false;
+
+var vertList = [
+ new THREE.Vector3(0, 0, 0),
+ new THREE.Vector3(1, 0, 0),
+ new THREE.Vector3(1, 1, 0),
+ new THREE.Vector3(0, 1, 0),
+ new THREE.Vector3(1, 1, 1),
+];
+
+test( "singularity", function() {
+
+ testEdges( vertList, [1, 1, 1], 0 )... | true |
Other | mrdoob | three.js | cfa8e9aa0c7c9cb9aec7e3415bc5d3bd549c4da8.json | Add unit tests | test/unit/unittests_three.html | @@ -32,5 +32,10 @@
<script src="math/Matrix3.js"></script>
<script src="math/Matrix4.js"></script>
<script src="math/Frustum.js"></script>
+
+ <script src="geometry/EdgesGeometry.js"></script>
+
+ <!-- for debug output -->
+ <script src="../../examples/js/controls/OrbitControls.js"></script>
</body>
... | true |
Other | mrdoob | three.js | 688cde2f6cbed70b2ce0ca74e13d585a22cca15f.json | add blender logging handlers only once | utils/exporters/blender/addons/io_three/logger.py | @@ -32,20 +32,21 @@ def init(filename, level=constants.DEBUG):
LOGGER = logging.getLogger('Three.Export')
LOGGER.setLevel(LEVELS[level])
- stream = logging.StreamHandler()
- stream.setLevel(LEVELS[level])
+ if not LOGGER.handlers:
+ stream = logging.StreamHandler()
+ stream.setLevel(L... | false |
Other | mrdoob | three.js | 65e6cdd6903cefc2c96970adf97f61da411353f2.json | Do lookup directly in sort function | src/renderers/WebGLRenderer.js | @@ -3233,9 +3233,9 @@ THREE.WebGLRenderer = function ( parameters ) {
function painterSortStable ( a, b ) {
- if ( a.renderOrder !== b.renderOrder ) {
+ if ( a.object.renderOrder !== b.object.renderOrder ) {
- return a.renderOrder - b.renderOrder;
+ return a.object.renderOrder - b.object.renderOrder;
... | false |
Other | mrdoob | three.js | 26a2dcb516d8687b2e0b4c1056be95e0b2e517c2.json | Change renderfinish event to complete | examples/js/renderers/RaytracingRenderer.js | @@ -460,7 +460,7 @@ THREE.RaytracingRenderer = function ( parameters ) {
if ( blockY >= canvasHeight ) {
- dispatch( { type: "renderfinish" } );
+ dispatch( { type: "complete" } );
return;
| false |
Other | mrdoob | three.js | 940a60884a0bd76bc085293ee4a3ac616a465124.json | Fix OBJExporter exported file format.
OBJExporter produced invalid OBJ file in case of missing texture coordinates or vertex normals. Now I fixed it, and write dummy texture coordinates if there aren't any, and write face normals if vertex normals are not exist. In addition I created an example to test the code. | examples/js/exporters/OBJExporter.js | @@ -13,7 +13,7 @@ THREE.OBJExporter.prototype = {
var output = '';
var indexVertex = 0;
- var indexVertexUvs = 0
+ var indexVertexUvs = 0;
var indexNormals = 0;
var parseObject = function ( child ) {
@@ -41,21 +41,34 @@ THREE.OBJExporter.prototype = {
// uvs
- for ( var i = 0, l = geometry... | true |
Other | mrdoob | three.js | 940a60884a0bd76bc085293ee4a3ac616a465124.json | Fix OBJExporter exported file format.
OBJExporter produced invalid OBJ file in case of missing texture coordinates or vertex normals. Now I fixed it, and write dummy texture coordinates if there aren't any, and write face normals if vertex normals are not exist. In addition I created an example to test the code. | examples/webgl_exporter_obj.html | @@ -0,0 +1,223 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <title>three.js webgl - exporter - obj</title>
+ <meta charset="utf-8">
+ <style>
+ body {
+ font-family: Monospace;
+ background-color: #000000;
+ margin: 0px;
+ overflow: hidden;
+ }
+
+ #info {
+ color: #fff;
+ position: ab... | true |
Other | mrdoob | three.js | 504bdabe074d89e2c8dbd2dbcc2e020d17af7084.json | Avoid obscure error on certain non-image textures. | utils/exporters/blender/addons/io_three/exporter/api/texture.py | @@ -174,5 +174,6 @@ def textures():
if mat.users == 0:
continue
for slot in mat.texture_slots:
- if slot and slot.use and slot.texture.type == IMAGE:
+ if (slot and slot.use and
+ slot.texture and slot.texture.type == IMAGE):
yield... | false |
Other | mrdoob | three.js | 9e7bf038a500cf78e48985545e3d5ef01dea6ada.json | Read texture info numeric or symbolic (compatible) | src/loaders/ObjectLoader.js | @@ -293,6 +293,12 @@ THREE.ObjectLoader.prototype = {
},
+ parseConstant: function ( json ) {
+
+ return typeof( json ) === 'number' ? json : THREE[json];
+
+ },
+
parseImages: function ( json, onLoad ) {
var scope = this;
@@ -358,15 +364,15 @@ THREE.ObjectLoader.prototype = {
texture.uuid = data.uui... | false |
Other | mrdoob | three.js | 612aa17d75ab4a11f8ea0fe130983edfa4e191f3.json | Serialize complete texture info (numeric). | src/textures/Texture.js | @@ -109,8 +109,19 @@ THREE.Texture.prototype = {
type: 'Texture',
generator: 'Texture.toJSON'
},
+
uuid: this.uuid,
- mapping: this.mapping
+ name: this.name,
+
+ mapping: this.mapping,
+
+ repeat: [ this.repeat.x, this.repeat.y ],
+ offset: [ this.offset.x, this.offset.y ],
+ wrap: [ this... | false |
Other | mrdoob | three.js | 1ce8842c75806521a811a3f2eafcc59ad0453fb2.json | Avoid obscure error on certain non-image textures. | utils/exporters/blender/addons/io_three/exporter/api/material.py | @@ -384,7 +384,10 @@ def _valid_textures(material, strict_use=True):
in_use = texture.use
else:
in_use = True
- if texture.texture.type != IMAGE or not in_use:
+ if not in_use:
+ continue
+ if not texture.texture or texture.texture.type != IMAGE:
+ ... | false |
Other | mrdoob | three.js | f7c695f0d374fcefbec47dd8fff09bf669aee650.json | Fix typo in webgl_animation_cloth | examples/webgl_animation_cloth.html | @@ -187,7 +187,7 @@
clothTexture.wrapS = clothTexture.wrapT = THREE.RepeatWrapping;
clothTexture.anisotropy = 16;
- var clothMaterial = new THREE.MeshPhongMaterial( { alphaTest: 0.5, color: 0xffffff, specular: 0x030303, emissive: 0x111111, shiness: 10, map: clothTexture, side: THREE.DoubleSide } );
+ ... | false |
Other | mrdoob | three.js | 1b4c469ea3f66030f05fa81092fa3ad2e26f7fdb.json | Solve the spaces vs tabs indentation issues. | examples/js/renderers/SoftwareRenderer.js | @@ -38,10 +38,10 @@ THREE.SoftwareRenderer = function ( parameters ) {
var blockShift = 3; // Normally, it should be 3. At line mode, it has to be 0
var blockSize = 1 << blockShift;
var maxZVal = (1 << 24); // Note: You want to size this so you don't get overflows.
- var lineMode = false;
- var lookVector =... | false |
Other | mrdoob | three.js | 83f774cd2bfc925e02c3d566031580de9f578c5f.json | Use Raycaster.setFromCamera() method
Convert two uses of raycaster to using setFromCamera(). One touches
TransformControls but should not affect #6795.
Also fix an error in webgl_interactive_draggablecubes.html when the
cursor is dragged outside of the backing "plane" (which is a large
planar mesh, not an infinite pl... | examples/js/controls/TransformControls.js | @@ -1086,9 +1086,7 @@
var y = ( pointer.clientY - rect.top ) / rect.height;
pointerVector.set( ( x * 2 ) - 1, - ( y * 2 ) + 1, 0.5 );
- pointerVector.unproject( camera );
-
- ray.set( camPosition, pointerVector.sub( camPosition ).normalize() );
+ ray.setFromCamera( pointerVector, camera );
var int... | true |
Other | mrdoob | three.js | 83f774cd2bfc925e02c3d566031580de9f578c5f.json | Use Raycaster.setFromCamera() method
Convert two uses of raycaster to using setFromCamera(). One touches
TransformControls but should not affect #6795.
Also fix an error in webgl_interactive_draggablecubes.html when the
cursor is dragged outside of the backing "plane" (which is a large
planar mesh, not an infinite pl... | examples/webgl_interactive_draggablecubes.html | @@ -162,7 +162,13 @@
if ( SELECTED ) {
var intersects = raycaster.intersectObject( plane );
- SELECTED.position.copy( intersects[ 0 ].point.sub( offset ) );
+
+ if ( intersects.length > 0 ) {
+
+ SELECTED.position.copy( intersects[ 0 ].point.sub( offset ) );
+
+ }
+
return;
}
... | true |
Other | mrdoob | three.js | aaf6a26bc30e73987632115b4326b8c62e90ab62.json | Remove unnecessary copy | src/extras/geometries/WireframeGeometry.js | @@ -70,7 +70,7 @@ THREE.WireframeGeometry = function ( geometry ) {
var vertices = geometry.attributes.position;
var indices = geometry.attributes.index.array;
- var drawcalls = geometry.drawcalls.slice();
+ var drawcalls = geometry.drawcalls;
var numEdges = 0;
if ( drawcalls.length === 0 ) { | false |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | examples/js/renderers/Projector.js | @@ -392,7 +392,7 @@ THREE.Projector = function () {
if ( geometry instanceof THREE.BufferGeometry ) {
var attributes = geometry.attributes;
- var offsets = geometry.offsets;
+ var offsets = geometry.drawcalls;
if ( attributes.position === undefined ) continue;
| true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | examples/js/wip/ProxyGeometry.js | @@ -744,7 +744,7 @@ THREE.ProxyGeometry.prototype.clone = function () {
var buff = THREE.BufferGeometry.prototype.clone.call(this);
var geo = new THREE.ProxyGeometry();
geo.attributes = buff.attributes;
- geo.offsets = buff.offsets;
+ geo.offsets = buff.drawcalls;
return geo;
| true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | examples/webgl_buffergeometry.html | @@ -200,9 +200,9 @@
geometry.addAttribute( 'normal', new THREE.BufferAttribute( normals, 3 ) );
geometry.addAttribute( 'color', new THREE.BufferAttribute( colors, 3 ) );
- var offsets = triangles / chunkSize;
+ var num_offsets = triangles / chunkSize;
- for ( var i = 0; i < offsets; i ++ ) {
+ ... | true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/core/BufferGeometry.js | @@ -110,7 +110,7 @@ THREE.BufferGeometry.prototype = {
// TODO Clear attributes? Clear drawcalls? Copy morphTargets?
var attributes = geometry.attributes;
- var offsets = geometry.offsets;
+ var offsets = geometry.drawcalls;
for ( var name in attributes ) {
@@ -1064,7 +1064,7 @@ THREE.BufferGeometry.pr... | true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/loaders/BufferGeometryLoader.js | @@ -51,7 +51,18 @@ THREE.BufferGeometryLoader.prototype = {
if ( offsets !== undefined ) {
- geometry.offsets = JSON.parse( JSON.stringify( offsets ) );
+ var offsetsArray = JSON.parse( JSON.stringify( offsets ) );
+
+ for ( var i = 0; i < offsetsArray.length; i ++ ) {
+
+ var offset = offsetsAr... | true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/objects/Line.js | @@ -65,7 +65,7 @@ THREE.Line.prototype.raycast = ( function () {
var indices = attributes.index.array;
var positions = attributes.position.array;
- var offsets = geometry.offsets;
+ var offsets = geometry.drawcalls.slice();
if ( offsets.length === 0 ) {
| true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/objects/Mesh.js | @@ -111,7 +111,7 @@ THREE.Mesh.prototype.raycast = ( function () {
var indices = attributes.index.array;
var positions = attributes.position.array;
- var offsets = geometry.offsets;
+ var offsets = geometry.drawcalls.slice();
if ( offsets.length === 0 ) {
| true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/objects/PointCloud.js | @@ -81,13 +81,13 @@ THREE.PointCloud.prototype.raycast = ( function () {
var indices = attributes.index.array;
- if ( geometry.offsets.length === 0 ) {
+ if ( geometry.drawcalls.length === 0 ) {
offsets.addDrawCall( 0, indices.length, 0 );
}
- var offsets = geometry.offsets;
+ var ... | true |
Other | mrdoob | three.js | d0dff857167024492400423eb03991155fdecec6.json | Remove uses of .offsets
Store reading and writing to `.offsets`.
Avoid mutations to `.drawcalls` from outside the `BufferGeometry`. | src/renderers/WebGLRenderer.js | @@ -1072,7 +1072,7 @@ THREE.WebGLRenderer = function ( parameters ) {
}
- var offsets = geometry.offsets;
+ var offsets = geometry.drawcalls;
if ( offsets.length === 0 ) {
@@ -1157,7 +1157,7 @@ THREE.WebGLRenderer = function ( parameters ) {
// non-indexed triangles
- var offsets = geometr... | true |
Other | mrdoob | three.js | 1753badadedeea82ef33200a565e6c62f833a373.json | Add count to InterleavedBuffer | src/core/InterleavedBuffer.js | @@ -26,6 +26,12 @@ THREE.InterleavedBuffer.prototype = {
},
+ get count () {
+
+ return this.array.length / this.stride;
+
+ },
+
copyAt: function ( index1, attribute, index2 ) {
index1 *= this.stride; | true |
Other | mrdoob | three.js | 1753badadedeea82ef33200a565e6c62f833a373.json | Add count to InterleavedBuffer | src/core/InterleavedBufferAttribute.js | @@ -19,8 +19,8 @@ THREE.InterleavedBufferAttribute.prototype = {
get length() {
- console.warn( 'THREE.InterleavedBufferAttribute: .length has been renamed to .count.' );
- return this.count;
+ console.warn( 'THREE.BufferAttribute: .length has been deprecated. Please use .count.' );
+ return this.array.length... | true |
Other | mrdoob | three.js | 1753badadedeea82ef33200a565e6c62f833a373.json | Add count to InterleavedBuffer | src/renderers/WebGLRenderer.js | @@ -929,7 +929,7 @@ THREE.WebGLRenderer = function ( parameters ) {
if ( geometry.maxInstancedCount === undefined ) {
- geometry.maxInstancedCount = data.meshPerAttribute * ( data.array.length / data.stride );
+ geometry.maxInstancedCount = data.meshPerAttribute * data.count;
}
@@ ... | true |
Other | mrdoob | three.js | 85117608653fa3fd65544b6842f789727a4925e4.json | Update license attribute
There are a few new license changes in newer versions of npm.
https://docs.npmjs.com/files/package.json#license
http://npm1k.org/ | utils/npm/three.package.json | @@ -33,10 +33,7 @@
"url" : "git://github.com/mrdoob/three.js.git"
},
- "license" : {
- "type" : "The MIT License",
- "url" : "https://raw.github.com/mrdoob/three.js/master/LICENSE"
- },
+ "license" : "MIT",
"engines" : {
"node" : "*" | false |
Other | mrdoob | three.js | b439904eb935bc4938c3c7d3825d3848f3230ec5.json | add geometry normalization | docs/api/core/Geometry.html | @@ -185,6 +185,11 @@ <h3>[method:null applyMatrix]( [page:Matrix4 matrix] )</h3>
Bakes matrix transform directly into vertex coordinates.
</div>
+ <h3>[method:null center]()</h3>
+ <div>
+ Center the geometry based on the bounding box.
+ </div>
+
<h3>[method:null computeFaceNormals]()</h3>
<div>
Co... | true |
Other | mrdoob | three.js | b439904eb935bc4938c3c7d3825d3848f3230ec5.json | add geometry normalization | src/core/Geometry.js | @@ -224,6 +224,23 @@ THREE.Geometry.prototype = {
},
+ normalize: function() {
+ var COM = this.boundingSphere.center;
+ var R = this.boundingSphere.radius;
+
+ var s = (R === 0 ? 1 : 1.0 / R);
+
+ var m = new THREE.Matrix4().set(
+ s, 0, 0, -s*COM.x,
+ 0, s, 0, -s*COM.y,
+ 0, 0, s, -s*COM.z,
+ 0, 0, ... | true |
Other | mrdoob | three.js | 8b201481846a936986c3d0cc3de3d087b90e6c0e.json | Avoid exception from "new ShaderMaterial()". | src/materials/ShaderMaterial.js | @@ -38,13 +38,6 @@ THREE.ShaderMaterial = function ( parameters ) {
this.uniforms = {};
this.attributes = [];
- if ( parameters.attributes !== undefined && Array.isArray( parameters.attributes ) === false ) {
-
- console.warn( 'THREE.ShaderMaterial: attributes should now be an array of attribute names.' );
- pa... | false |
Other | mrdoob | three.js | 146cd3dfecd13f9eb5063da9e9ee8433470d1402.json | Add doctype and meta charset to example HTML | docs/manual/introduction/Creating-a-scene.html | @@ -21,8 +21,10 @@ <h2>Before we start</h2>
<div>Before you can use Three.js, you need somewhere to display it. Save the following HTML to a file on your computer, along with a copy of <a href="http://threejs.org/build/three.min.js">three.min.js</a> in the js/ directory, and open it in your browser.</div>
<code... | false |
Other | mrdoob | three.js | 0833ca528ecdcd1889bb2e6cb384faa3c32370b5.json | Fix inverted rows and realign destination labels
Fix rows on the blend table being incorrectly inverted on webgl_materials_blending_custom.html example
You can verify the rows are currently inverted by hardcoding blendSrc and blendDist
(insert these lines at line 231):
material.blendSrc = THREE["ZeroFactor"];
m... | examples/webgl_materials_blending_custom.html | @@ -233,7 +233,7 @@
var y = ( i - dst.length / 2 ) * 110 + 50;
var mesh = new THREE.Mesh( geo1, material );
- mesh.position.set( x, y, z );
+ mesh.position.set( x, -y, z );
mesh.matrixAutoUpdate = false;
mesh.updateMatrix();
scene.add( mesh );
@@ -269,7 +269,7 @@
var... | false |
Other | mrdoob | three.js | 53c10bf7e570a8914e4ac49ced614f8bdb1405a5.json | Use keydown instead of keypress for keyboard event | examples/webgl_loader_gltf.html | @@ -132,7 +132,7 @@
function onload() {
window.addEventListener( 'resize', onWindowResize, false );
- document.addEventListener( 'keypress', function(e) { onKeyPress(e); }, false );
+ document.addEventListener( 'keydown', function(e) { onKeyDown(e); }, false );
buildSceneList();
switchScene... | false |
Other | mrdoob | three.js | a48902f7464ef96b6afe4d07bbcb82d462906805.json | Use keydown instead of keypress for keyboard event | examples/webgl_geometry_colors_lookuptable.html | @@ -112,7 +112,7 @@
window.addEventListener( 'resize', onWindowResize, false );
- window.addEventListener( "keypress", onKeyPress, true);
+ window.addEventListener( "keydown", onKeyDown, true);
}
@@ -272,7 +272,7 @@
}
- function onKeyPress ( e ) {
+ function onKeyDown ( e ) {
v... | false |
Other | mrdoob | three.js | dd74de1edfd027eb413cf01b8b5422567489a688.json | Remove console log from PlaneGeometry
Doesn't seem like we need a console log every time PlaneGeometry is used. Is PlaneGeometry really that bad? | src/extras/geometries/PlaneGeometry.js | @@ -5,8 +5,6 @@
THREE.PlaneGeometry = function ( width, height, widthSegments, heightSegments ) {
- console.log( 'THREE.PlaneGeometry: Consider using THREE.PlaneBufferGeometry for lower memory footprint.' );
-
THREE.Geometry.call( this );
this.type = 'PlaneGeometry'; | false |
Other | mrdoob | three.js | 96a5ed509753f9a02e3fae8480a0969f2c667fbe.json | Fix info div blocks config menu. | examples/webgl_postprocessing_ssao.html | @@ -28,12 +28,12 @@
#info {
color:#fff;
- position: absolute;
+ position: relative;
top: 0px;
- width: 100%;
+ width: 40em;
+ margin: 0 auto -1.86em;
padding: 5px;
z-index:100;
- text-align: center;
}
</style>
</head> | false |
Other | mrdoob | three.js | cd5e9888d54e82aea98752601879ba931b77290b.json | Fix EffectComposer memory problem | examples/js/postprocessing/EffectComposer.js | @@ -117,7 +117,9 @@ THREE.EffectComposer.prototype = {
}
+ this.renderTarget1.dispose();
this.renderTarget1 = renderTarget;
+ this.renderTarget2.dispose();
this.renderTarget2 = renderTarget.clone();
this.writeBuffer = this.renderTarget1;
@@ -127,12 +129,8 @@ THREE.EffectComposer.prototype = {
se... | true |
Other | mrdoob | three.js | cd5e9888d54e82aea98752601879ba931b77290b.json | Fix EffectComposer memory problem | src/renderers/WebGLRenderer.js | @@ -697,7 +697,7 @@ THREE.WebGLRenderer = function ( parameters ) {
}
- properties.delete( renderTargetProperties );
+ properties.delete( renderTarget );
}
| true |
Other | mrdoob | three.js | 5456e02a145105374f1fc6365b1f462e407d0301.json | Remove wip / TypedGeometry
Minecraft demo modified to use a mix of Geometry and BufferGeometry. See
#6803. | examples/js/wip/CircleTypedGeometry.js | @@ -1,76 +0,0 @@
-/**
- * @author hughes
- * @author mrdoob / http://mrdoob.com/
- */
-
-THREE.CircleTypedGeometry = function ( radius, segments, thetaStart, thetaLength ) {
-
- this.parameters = {
- radius: radius,
- segments: segments,
- thetaStart: thetaStart,
- thetaLength: thetaLength
- };
-
- radius = radius ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.