before_code stringlengths 30 149k | reviewer_comment stringlengths 16 20.6k | after_code stringlengths 30 163k | diff_context stringlengths 0 22.4k | file_path stringlengths 6 155 | comment_line int64 0 26 | language stringclasses 19
values | quality_score float64 0.07 1 | comment_type stringclasses 9
values | comment_length int64 16 20.6k | before_lines int64 2 4.61k | after_lines int64 2 4.4k | is_negative bool 2
classes | pr_title stringlengths 7 140 | pr_number int64 18 61.2k | repo_name stringclasses 29
values | repo_stars int64 321 56k | repo_language stringclasses 14
values | reviewer_username stringclasses 378
values | author_username stringclasses 739
values | user stringlengths 361 200k | assistant stringlengths 16 20.6k | system stringclasses 1
value |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
isAccessLoading={loadingAccountId === account.id}
onAccess={(e: TPamAccount) => accessAccount(e)}
onUpdate={(e) => handlePopUpOpen("updateAccount", e)}
onDelete={(e) => handlePopUpOpen("deleteAccount", e)}
/>
... | update page options to be the same as card pagination, might be able to just bump this and the empty component out of the ternary to use for both? | key={account.id}
account={account}
search={search}
isAccessLoading={loadingAccountId === account.id}
onAccess={(e: TPamAccount) => accessAccount(e)}
onUpdate={(e) => handlePopUpOpen("updat... | @@ -427,53 +472,39 @@ export const PamAccountsTable = ({ projectId }: Props) => {
onDelete={(e) => handlePopUpOpen("deleteFolder", e)}
/>
))}
- {filteredAccounts.map((account) => (
- <PamAccountRow
- key={a... | frontend/src/pages/pam/PamAccountsPage/components/PamAccountsTable.tsx | 26 | TypeScript | 0.429 | question | 146 | 51 | 51 | false | improvement(pam): cards for flat account view | 5,016 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/pam/PamAccountsPage/components/PamAccountsTable.tsx
PR Title: improvement(pam): cards for flat account view
BEFORE CODE: isAccessLoading={loadingAccountId === account.id}
onAccess={(e: TPamAcco... | update page options to be the same as card pagination, might be able to just bump this and the empty component out of the ternary to use for both? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
base: "/",
server: {
allowedHosts,
host: true,
port: 3000
// proxy: {
// "/api": {
// target: "http://localhost:8080",
// changeOrigin: true,
// secure: false,
// ws: true
// }
// }
},
build: {
rollupOptions: {
... | Instead of this - can we try doing as said in documentation of using a window url to fetch assets.
```
experimental: {
renderBuiltUrl(filename, { hostType }) {
if (hostType === 'js') {
return { runtime: `window.__toCdnUrl(${JSON.stringify(filename)})` }
} else {
return { relative: true }
}
}... | // target: "http://localhost:8080",
// changeOrigin: true,
// secure: false,
// ws: true
// }
// }
},
build: {
rollupOptions: {
output: {
entryFileNames: `assets/[name]-${version}-[hash].js`,
chunkFileNames: `assets/[name]-$... | @@ -52,6 +59,15 @@ export default defineConfig(({ mode }) => {
}
}
},
+ experimental: {
+ // Only apply CDN HOST to files in /assets/* directory
+ renderBuiltUrl(filename) { | frontend/vite.config.ts | 26 | TypeScript | 1 | suggestion | 549 | 50 | 43 | false | feature(cdn): add optional CDN URL configuration for static assets in Vite | 5,037 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | victorvhs017 | Review this pull request change.
Language: TypeScript
File: frontend/vite.config.ts
PR Title: feature(cdn): add optional CDN URL configuration for static assets in Vite
BEFORE CODE: base: "/",
server: {
allowedHosts,
host: true,
port: 3000
// proxy: {
// "/api": {
// ... | Instead of this - can we try doing as said in documentation of using a window url to fetch assets.
```
experimental: {
renderBuiltUrl(filename, { hostType }) {
if (hostType === 'js') {
return { runtime: `window.__toCdnUrl(${JSON.stringify(filename)})` }
} else {
return { relative: true }
}
}... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
<PamAddFolderModal
isOpen={popUp.addFolder.isOpen}
onOpenChange={(isOpen) => handlePopUpToggle("addFolder", isOpen)}
projectId={projectId}
currentFolderId={currentFolderId}
/>
<PamAccessAccountModal
isOpen={popUp.accessAccount.isOpen}
onOpenChange={(isOp... | You don't need a seperate state - you can use `popUp.requestAccount.data` for this | onOpenChange={(isOpen) => handlePopUpToggle("addFolder", isOpen)}
projectId={projectId}
currentFolderId={currentFolderId}
/>
<PamAccessAccountModal
isOpen={popUp.accessAccount.isOpen}
onOpenChange={(isOpen) => handlePopUpToggle("accessAccount", isOpen)}
accoun... | @@ -537,7 +560,13 @@ export const PamAccountsTable = ({ projectId }: Props) => {
/>
<PamRequestAccountAccessModal
isOpen={popUp.requestAccount.isOpen}
- onOpenChange={(isOpen) => handlePopUpToggle("requestAccount", isOpen)}
+ onOpenChange={(isOpen) => {
+ handlePopUpToggle(... | frontend/src/pages/pam/PamAccountsPage/components/PamAccountsTable.tsx | 26 | TypeScript | 0.429 | suggestion | 82 | 47 | 40 | false | feature(pam): auto request access to accounts | 5,050 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/pam/PamAccountsPage/components/PamAccountsTable.tsx
PR Title: feature(pam): auto request access to accounts
BEFORE CODE: <PamAddFolderModal
isOpen={popUp.addFolder.isOpen}
onOpenChange={(isOpen) => handlePopUpToggle... | You don't need a seperate state - you can use `popUp.requestAccount.data` for this | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
const { t } = useTranslation();
const { currentProject } = useProject();
const [selectedTab, setSelectedTab] = useState("rule-based");
const { data: v1AlertsData } = useListWorkspacePkiAlerts({
projectId: currentProject?.id || ""
});
const hasV1Alerts = v1AlertsData?.alerts && v1AlertsData.alerts.leng... | the format of this title got a little messed up; should be inline with icon and maybe add a little margin to the top of the badge (looks a little off center)
<img width="1484" height="316" alt="CleanShot 2025-12-17 at 10 25 32@2x" src="https://github.com/user-attachments/assets/fcab13a8-4b4f-4a13-9450-b647277529ea" />... | const { t } = useTranslation();
const { currentProject } = useProject();
const [selectedTab, setSelectedTab] = useState("rule-based");
const { data: v1AlertsData } = useListWorkspacePkiAlerts({
projectId: currentProject?.id || ""
});
const hasV1Alerts = v1AlertsData?.alerts && v1AlertsData.alerts.leng... | @@ -30,7 +31,12 @@ export const AlertingPage = () => {
<div className="mx-auto mb-6 w-full max-w-8xl">
<PageHeader
scope={ProjectType.CertificateManager}
- title="Alerting"
+ title={
+ <div className="flex items-center gap-x-2">
+ Alerting
+ ... | frontend/src/pages/cert-manager/AlertingPage/AlertingPage.tsx | 26 | TypeScript | 0.5 | suggestion | 322 | 51 | 51 | false | feature: add PKI links to docs | 5,058 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/cert-manager/AlertingPage/AlertingPage.tsx
PR Title: feature: add PKI links to docs
BEFORE CODE: const { t } = useTranslation();
const { currentProject } = useProject();
const [selectedTab, setSelectedTab] = useState("rule-based");... | the format of this title got a little messed up; should be inline with icon and maybe add a little margin to the top of the badge (looks a little off center)
<img width="1484" height="316" alt="CleanShot 2025-12-17 at 10 25 32@2x" src="https://github.com/user-attachments/assets/fcab13a8-4b4f-4a13-9450-b647277529ea" />... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
await logout.mutateAsync();
window.open(`/api/v1/sso/redirect/saml2/organizations/${currentOrg.slug}`);
window.close();
} else if (enforcementTypeInModal === EnforceAuthType.GOOGLE) {
await mutateAsync({
orgId: currentOrg?.id,
googleSsoAuthEnforced: true
... | not sure we need this notification as the mutation creates one on failure
<img width="850" height="540" alt="CleanShot 2025-12-17 at 11 54 14@2x" src="https://github.com/user-attachments/assets/b9a7d122-ee83-41bd-b960-d4b2ae15c86d" />
|
await logout.mutateAsync();
window.open(`/api/v1/sso/redirect/saml2/organizations/${currentOrg.slug}`);
window.close();
} else if (enforcementTypeInModal === EnforceAuthType.GOOGLE) {
await mutateAsync({
orgId: currentOrg?.id,
googleSsoAuthEnforced: true
... | @@ -38,11 +40,75 @@ export const OrgGeneralAuthSection = ({
}) => {
const { currentOrg } = useOrganization();
const { subscription } = useSubscription();
- const { popUp, handlePopUpOpen, handlePopUpToggle } = usePopUp(["upgradePlan"] as const);
+ const { popUp, handlePopUpOpen, handlePopUpToggle } = usePopUp(... | frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx | 26 | TypeScript | 0.5 | bug | 237 | 51 | 51 | false | feature: allow SSO bypass to be enabled before enabling SSO enforcement | 5,062 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx
PR Title: feature: allow SSO bypass to be enabled before enabling SSO enforcement
BEFORE CODE:
await logout.mutateAsync();
window.open(`/api/v1/sso... | not sure we need this notification as the mutation creates one on failure
<img width="850" height="540" alt="CleanShot 2025-12-17 at 11 54 14@2x" src="https://github.com/user-attachments/assets/b9a7d122-ee83-41bd-b960-d4b2ae15c86d" />
| You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
<p className="text-sm text-mineshaft-300">
Enforce users to authenticate via Google OAuth to access this organization.
<br />
When this is enabled your organization members will only be able to login with Google
OAuth (not Google SAML).
</p>
</... | I think the anchor should be `#sso-break-glass`? | OAuth (not Google SAML).
</p>
</div>
</div>
<div className="mt-4 py-4">
<div className="mb-2 flex justify-between">
<div className="flex items-center gap-1">
<span className="text-md text-mineshaft-100">Enable Admin SSO Bypass</span>
<T... | @@ -239,73 +325,143 @@ export const OrgGeneralAuthSection = ({
</p>
</div>
</div>
- {(currentOrg?.authEnforced || currentOrg?.googleSsoAuthEnforced) && (
- <div className="mt-4 py-4">
- <div className="mb-2 flex justify-between">
- <div className="flex items-ce... | frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx | 26 | TypeScript | 0.286 | question | 48 | 51 | 51 | false | feature: allow SSO bypass to be enabled before enabling SSO enforcement | 5,062 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx
PR Title: feature: allow SSO bypass to be enabled before enabling SSO enforcement
BEFORE CODE: <p className="text-sm text-mineshaft-300">
Enfo... | I think the anchor should be `#sso-break-glass`? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
let text = "Permanent";
let toolTipText = "Non-Expiring Access";
if (privilegeDetails.isTemporary) {
if (isExpired) {
text = "Access Expired";
toolTipText = "Timed Access Expired";
... | Hmm I think "Granted" could be reworded. How about we add a small shield badge and call it "Managed"?
I like the color though! | let text = "Permanent";
let toolTipText = "Non-Expiring Access";
if (privilegeDetails.isTemporary) {
if (isExpired) {
text = "Access Expired";
toolTipText = "Timed Access Expired";
... | @@ -152,8 +153,15 @@ export const MemberProjectAdditionalPrivilegeSection = ({ membershipDetails }: P
return (
<UnstableTableRow key={`user-project-privilege-${privilegeDetails?.id}`}>
- <UnstableTableCell className="max-w-0 truncate">
- ... | frontend/src/pages/project/MemberDetailsByIDPage/components/MemberProjectAdditionalPrivilegeSection/MemberProjectAdditionalPrivilegeSection.tsx | 26 | TypeScript | 0.429 | suggestion | 127 | 51 | 51 | false | feat(secrets-management): disallow editing privileges that were granted via access request | 5,113 | Infisical/infisical | 22,351 | TypeScript | varonix0 | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/project/MemberDetailsByIDPage/components/MemberProjectAdditionalPrivilegeSection/MemberProjectAdditionalPrivilegeSection.tsx
PR Title: feat(secrets-management): disallow editing privileges that were granted via access request
BEFORE CODE... | Hmm I think "Granted" could be reworded. How about we add a small shield badge and call it "Managed"?
I like the color though! | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import { Button } from "@app/components/v2";
/**
* This is the page that shows up when a user's invitation
* to join a project/organization on Infisical has expired
* or when the user is already a member of the organization
*/
export const RequestNewInvitePage = () => {
const { reason } = useSearch({ from: "/_re... | I think this currently is a little redundant; how about something like;
You're already a member of this organization
sign in to continue
Go to Login | import { Button } from "@app/components/v2";
/**
* This is the page that shows up when a user's invitation
* to join a project/organization on Infisical has expired
* or when the user is already a member of the organization
*/
export const RequestNewInvitePage = () => {
const { reason } = useSearch({ from: "/_re... | @@ -1,23 +1,42 @@
import { Helmet } from "react-helmet";
+import { Link, useSearch } from "@tanstack/react-router";
+
+import { Button } from "@app/components/v2";
/**
* This is the page that shows up when a user's invitation
* to join a project/organization on Infisical has expired
+ * or when the user is alre... | frontend/src/pages/auth/RequestNewInvitePage/RequestNewInvitePage.tsx | 26 | TypeScript | 0.357 | suggestion | 156 | 41 | 41 | false | feat: warn users when they're already part of an org and are trying to accept an invite | 5,120 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/auth/RequestNewInvitePage/RequestNewInvitePage.tsx
PR Title: feat: warn users when they're already part of an org and are trying to accept an invite
BEFORE CODE: import { Button } from "@app/components/v2";
/**
* This is the page that ... | I think this currently is a little redundant; how about something like;
You're already a member of this organization
sign in to continue
Go to Login | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import { requestContext } from "@fastify/request-context";
import opentelemetry from "@opentelemetry/api";
import { getConfig } from "../config/env";
const infisicalMeter = opentelemetry.metrics.getMeter("Infisical");
export enum AuthAttemptAuthMethod {
EMAIL = "email",
SAML = "saml",
OIDC = "oidc",
GOOGLE =... | Looks like different operation types take different parameters? Instead of making some optional, couldn't we make it a discriminated union as we do for audit log types? |
secretReadCounter.add(1, attributes);
}
};
export enum KmipOperationType {
CREATE = "create",
GET = "get",
GET_ATTRIBUTES = "get_attributes",
ACTIVATE = "activate",
REVOKE = "revoke",
DESTROY = "destroy",
LOCATE = "locate",
REGISTER = "register"
}
export const kmipOperationCounter = infisicalMe... | @@ -98,3 +98,67 @@ export const recordSecretReadMetric = (params: { environment: string; secretPath
secretReadCounter.add(1, attributes);
}
};
+
+export enum KmipOperationType {
+ CREATE = "create",
+ GET = "get",
+ GET_ATTRIBUTES = "get_attributes",
+ ACTIVATE = "activate",
+ REVOKE = "revoke",
+ DESTRO... | backend/src/lib/telemetry/metrics.ts | 26 | TypeScript | 0.571 | question | 168 | 101 | 51 | false | feat: add telemetry for kmip operations | 5,129 | Infisical/infisical | 22,351 | TypeScript | varonix0 | sheensantoscapadngan | Review this pull request change.
Language: TypeScript
File: backend/src/lib/telemetry/metrics.ts
PR Title: feat: add telemetry for kmip operations
BEFORE CODE: import { requestContext } from "@fastify/request-context";
import opentelemetry from "@opentelemetry/api";
import { getConfig } from "../config/env";
cons... | Looks like different operation types take different parameters? Instead of making some optional, couldn't we make it a discriminated union as we do for audit log types? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
await orgDAL.updateMembershipById(
orgMembership.id,
{
status: OrgMembershipStatus.Accepted
},
tx
);
}
});
} else {
userAlias = await userDAL.transaction(async (tx) => {
let newUser: TUsers | undefined;
... | and if we have 2 users with email not verified? 🤔 | await orgDAL.updateMembershipById(
orgMembership.id,
{
status: OrgMembershipStatus.Accepted
},
tx
);
}
});
} else {
userAlias = await userDAL.transaction(async (tx) => {
let newUser: TUsers | undefined;
... | @@ -456,14 +456,23 @@ export const ldapConfigServiceFactory = ({
} else {
userAlias = await userDAL.transaction(async (tx) => {
let newUser: TUsers | undefined;
- newUser = await userDAL.findOne(
+
+ const usersWithSameEmail = await userDAL.find(
{
- email: email... | backend/src/ee/services/ldap-config/ldap-config-service.ts | 26 | TypeScript | 0.143 | suggestion | 50 | 51 | 51 | false | fix: resolved scim service failing when there is already non joined email user | 5,140 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/ldap-config/ldap-config-service.ts
PR Title: fix: resolved scim service failing when there is already non joined email user
BEFORE CODE: await orgDAL.updateMembershipById(
orgMembership.id,
{
... | and if we have 2 users with email not verified? 🤔 | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
membersToRemoveFromGroupNonPending.push(member);
} else {
// remove incomplete member from pending group addition
membersToRemoveFromGroupPending.push(member);
}
});
if (membersToRemoveFromGroupNonPending.length) {
// check which projects the group is part of
con... | Can we please rename these variables `m, t, and p`. Makes it super hard to read whats actually going on | membersToRemoveFromGroupNonPending.push(member);
} else {
// remove incomplete member from pending group addition
membersToRemoveFromGroupPending.push(member);
}
});
if (membersToRemoveFromGroupNonPending.length) {
// check which projects the group is part of
con... | @@ -435,45 +438,42 @@ export const removeUsersFromGroupByUserIds = async ({
)
);
- const promises: Array<Promise<void>> = [];
- for (const userId of userIds) {
- promises.push(
- (async () => {
- const t = await userGroupMembershipDAL.filterProjectsByUserMembership... | backend/src/ee/services/group/group-fns.ts | 26 | TypeScript | 0.571 | suggestion | 103 | 51 | 51 | false | fix: updateScimGroup SCIM logic not handling multiple concurrent requests | 5,145 | Infisical/infisical | 22,351 | TypeScript | varonix0 | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/group/group-fns.ts
PR Title: fix: updateScimGroup SCIM logic not handling multiple concurrent requests
BEFORE CODE: membersToRemoveFromGroupNonPending.push(member);
} else {
// remove incomplete member from pen... | Can we please rename these variables `m, t, and p`. Makes it super hard to read whats actually going on | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import { z } from "zod";
import { getConfig } from "@app/lib/config/env";
import { removeTrailingSlash } from "@app/lib/fn";
import { readLimit } from "@app/server/config/rateLimiter";
const getMcpUrls = (siteUrl: string, endpointId: string) => {
// The MCP resource/connect URL
const resourceUrl = `${siteUrl}/api... | can't we make this so that it's similar to that of `registerMcpEndpointAuthServerMetadataRouter` so that the final path ends up to be:
`GET /.well-known/oauth-protected-resource/mcp-endpoints/:endpointId`? | const siteHost = new URL(siteUrl).host;
const scopeAccess = `https://${siteHost}/mcp:access`;
server.route({
method: "GET",
url: "/api/v1/ai/mcp/endpoints/:endpointId/connect",
config: {
rateLimit: readLimit
},
schema: {
params: z.object({
endpointId: z.string().trim().min... | @@ -102,3 +102,40 @@ export const registerMcpEndpointAuthServerMetadataRouter = async (server: Fastif
}
});
};
+
+// RFC 9728 compliant: Protected Resource metadata at path-appended URL
+// MCP Inspector uses this pattern: /.well-known/oauth-protected-resource + resource path
+// GET /.well-known/oauth-protect... | backend/src/ee/routes/ai/mcp-endpoint-metadata-router.ts | 26 | TypeScript | 0.571 | security | 210 | 142 | 27 | false | fix(agent-sentinel): improve OAuth metadata compatibility for MCP Inspector | 5,192 | Infisical/infisical | 22,351 | TypeScript | sheensantoscapadngan | saifsmailbox98 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/ai/mcp-endpoint-metadata-router.ts
PR Title: fix(agent-sentinel): improve OAuth metadata compatibility for MCP Inspector
BEFORE CODE: import { z } from "zod";
import { getConfig } from "@app/lib/config/env";
import { removeTrailingSl... | can't we make this so that it's similar to that of `registerMcpEndpointAuthServerMetadataRouter` so that the final path ends up to be:
`GET /.well-known/oauth-protected-resource/mcp-endpoints/:endpointId`? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import dns from "node:dns/promises";
import net from "node:net";
import { getConfig } from "@app/lib/config/env";
import { BadRequestError } from "@app/lib/errors";
import { isPrivateIp } from "@app/lib/ip/ipRange";
import { getDbConnectionHost } from "@app/lib/knex";
export const verifyHostInputValidity = async ({
... | Is setting this to `true` by default the best move? I feel like false would be better. | import dns from "node:dns/promises";
import net from "node:net";
import { getConfig } from "@app/lib/config/env";
import { BadRequestError } from "@app/lib/errors";
import { isPrivateIp } from "@app/lib/ip/ipRange";
import { getDbConnectionHost } from "@app/lib/knex";
export const verifyHostInputValidity = async ({
... | @@ -6,9 +6,15 @@ import { BadRequestError } from "@app/lib/errors";
import { isPrivateIp } from "@app/lib/ip/ipRange";
import { getDbConnectionHost } from "@app/lib/knex";
-const ERROR_MESSAGE = "Invalid host";
-
-export const verifyHostInputValidity = async (host: string, isGateway = false) => {
+export const veri... | backend/src/ee/services/dynamic-secret/dynamic-secret-fns.ts | 12 | TypeScript | 0.429 | suggestion | 86 | 37 | 37 | false | feat: better host validation errors | 5,208 | Infisical/infisical | 22,351 | TypeScript | x032205 | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/dynamic-secret/dynamic-secret-fns.ts
PR Title: feat: better host validation errors
BEFORE CODE: import dns from "node:dns/promises";
import net from "node:net";
import { getConfig } from "@app/lib/config/env";
import { BadRequestEr... | Is setting this to `true` by default the best move? I feel like false would be better. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
message: "Self-signed issuer type only supports API enrollment"
});
}
}
};
const validateTemplateByExternalCaType = (
externalCaType: CaType | undefined,
externalConfigs: Record<string, unknown> | null | undefined
) => {
if (!externalCaType) return;
switch (externalCaType) {
case CaTyp... | why is this outside certificateProfileServiceFactory? if we don't need it on other places maybe it can be inside of that main function and we don't pass the DAL as a parameter 🤔 | message: "Self-signed issuer type only supports API enrollment"
});
}
}
};
const validateTemplateByExternalCaType = (
externalCaType: CaType | undefined,
externalConfigs: Record<string, unknown> | null | undefined
) => {
if (!externalCaType) return;
switch (externalCaType) {
case CaTyp... | @@ -88,6 +89,28 @@ const validateTemplateByExternalCaType = (
}
};
+const validateDefaultTtlDaysAgainstPolicy = async ( | backend/src/services/certificate-profile/certificate-profile-service.ts | 26 | TypeScript | 0.357 | question | 178 | 51 | 51 | false | feat(pki): add default TTL setting to certificate profiles | 5,238 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | saifsmailbox98 | Review this pull request change.
Language: TypeScript
File: backend/src/services/certificate-profile/certificate-profile-service.ts
PR Title: feat(pki): add default TTL setting to certificate profiles
BEFORE CODE: message: "Self-signed issuer type only supports API enrollment"
});
}
}
};
const ... | why is this outside certificateProfileServiceFactory? if we don't need it on other places maybe it can be inside of that main function and we don't pass the DAL as a parameter 🤔 | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
}
// Priority 2: Profile's defaultTtlDays
if (profileDefaultTtlDays) {
// Validate against policy's maxValidity (catch config drift)
if (policyMaxValidity) {
const profileTtlMs = profileDefaultTtlDays * 24 * 60 * 60 * 1000;
const policyMaxMs = ms(policyMaxValidity);
if (profileTtlMs > ... | mmm maybe we can rephrase this to be something like certificates can not be issued without a proper TTL? (just feels a bit weird to mention to pass a parameter or set the profile property when this can be used on very different flows 🤔 ) | }
// Priority 2: Profile's defaultTtlDays
if (profileDefaultTtlDays) {
// Validate against policy's maxValidity (catch config drift)
if (policyMaxValidity) {
const profileTtlMs = profileDefaultTtlDays * 24 * 60 * 60 * 1000;
const policyMaxMs = ms(policyMaxValidity);
if (profileTtlMs > ... | @@ -38,3 +39,63 @@ export const calculateRenewalThreshold = (
return profileRenewBeforeDays;
};
+
+/**
+ * Resolves the effective TTL to use for certificate issuance.
+ *
+ * Priority order:
+ * 1. Request TTL (user explicitly passed)
+ * 2. Profile's defaultTtlDays (validates against policy max)
+ * 3. Flow-spec... | backend/src/services/certificate-v3/certificate-v3-fns.ts | 26 | TypeScript | 0.5 | suggestion | 237 | 29 | 29 | false | feat(pki): add default TTL setting to certificate profiles | 5,238 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | saifsmailbox98 | Review this pull request change.
Language: TypeScript
File: backend/src/services/certificate-v3/certificate-v3-fns.ts
PR Title: feat(pki): add default TTL setting to certificate profiles
BEFORE CODE: }
// Priority 2: Profile's defaultTtlDays
if (profileDefaultTtlDays) {
// Validate against policy's maxVa... | mmm maybe we can rephrase this to be something like certificates can not be issued without a proper TTL? (just feels a bit weird to mention to pass a parameter or set the profile property when this can be used on very different flows 🤔 ) | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
recipients: [updatedUser.email],
substitutions: {
token: unlockToken,
callback_url: `${appCfg.SITE_URL}/api/v1/user/${updatedUser.id}/unlock`
}
});
}
}
throw err;
}
const decodedToken = crypto.jwt().verify(mfaJwtToke... | Why do we only log if the lock is not undefined? | });
// Check if an unlock email was already sent recently (within 5 minutes)
const emailAlreadySent = await keyStore.getItem(KeyStorePrefixes.UserMfaUnlockEmailSent(userId));
if (!emailAlreadySent) {
const unlockToken = await tokenService.createTokenForUser... | @@ -899,20 +902,43 @@ export const authLoginServiceFactory = ({
const updatedUser = await processFailedMfaAttempt(userId);
if (updatedUser.isLocked) {
if (updatedUser.email) {
- const unlockToken = await tokenService.createTokenForUser({
- type: TokenType.TOKEN_USER_UNLOCK,
- ... | backend/src/services/auth/auth-login-service.ts | 26 | TypeScript | 0.214 | question | 48 | 51 | 51 | false | improvement(mfa): implement MFA unlock email handling with keystore lockout mechanism | 5,239 | Infisical/infisical | 22,351 | TypeScript | varonix0 | victorvhs017 | Review this pull request change.
Language: TypeScript
File: backend/src/services/auth/auth-login-service.ts
PR Title: improvement(mfa): implement MFA unlock email handling with keystore lockout mechanism
BEFORE CODE: recipients: [updatedUser.email],
substitutions: {
token: unlo... | Why do we only log if the lock is not undefined? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
identityId: "The ID of the machine identity to delete."
},
GET_BY_ID: {
identityId: "The ID of the machine identity to get details.",
orgId: "The ID of the org of the identity"
},
LIST: {
orgId: "The ID of the organization to list identities.",
search: "The text string that identity names wi... | Can we put this at the top? feels a little out of place in the middle of the doc | metadata: "An optional array of key-value pairs to attach to the identity."
},
DELETE: {
identityId: "The ID of the machine identity to delete."
},
GET_BY_ID: {
identityId: "The ID of the machine identity to get details.",
orgId: "The ID of the org of the identity"
},
LIST: {
orgId: "The... | @@ -199,13 +199,14 @@ export const IDENTITIES = {
}
} as const;
-const IDENTITY_AUTH_SUB_ORGANIZATION_NAME = "sub-organization name to scope the token to";
+const IDENTITY_AUTH_SUB_ORGANIZATION_NAME = | backend/src/lib/api-docs/constants.ts | 26 | TypeScript | 0.214 | question | 80 | 51 | 51 | false | feat: updated identity login endpoints suborganization paramater to organizationSlug | 5,281 | Infisical/infisical | 22,351 | TypeScript | varonix0 | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/lib/api-docs/constants.ts
PR Title: feat: updated identity login endpoints suborganization paramater to organizationSlug
BEFORE CODE: identityId: "The ID of the machine identity to delete."
},
GET_BY_ID: {
identityId: "The ID of the... | Can we put this at the top? feels a little out of place in the middle of the doc | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
// eslint-disable-next-line
/* eslint-disable no-console */
import "ts-node/register";
import dotenv from "dotenv";
import type { Knex } from "knex";
import path from "path";
// Update with your config settings. .
dotenv.config({
path: path.join(__dirname, "../../../.env.migration")
});
dotenv.config({
path: path... | nit: I'm not sure we need the comment above the one you added? I don't see a lint warning without it | /* eslint-disable no-console */
import "ts-node/register";
import dotenv from "dotenv";
import type { Knex } from "knex";
import path from "path";
// Update with your config settings. .
dotenv.config({
path: path.join(__dirname, "../../../.env.migration")
});
dotenv.config({
path: path.join(__dirname, "../../../.... | @@ -1,4 +1,5 @@
// eslint-disable-next-line
+/* eslint-disable no-console */ | backend/src/db/auditlog-knexfile.ts | 1 | TypeScript | 0.357 | nitpick | 100 | 26 | 26 | false | fix(api): ensure commits are linted/formatted before commit | 5,282 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/db/auditlog-knexfile.ts
PR Title: fix(api): ensure commits are linted/formatted before commit
BEFORE CODE: // eslint-disable-next-line
/* eslint-disable no-console */
import "ts-node/register";
import dotenv from "dotenv";
import type { Knex }... | nit: I'm not sure we need the comment above the one you added? I don't see a lint warning without it | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
secretPath,
isOverride,
onClose
}: Props) => {
const [isEditing, setIsEditing] = useState(Boolean(!comment));
const { projectId } = useProject();
const { mutateAsync: updateSecretV3, isPending } = useUpdateSecretV3();
const {
handleSubmit,
control,
reset,
formState: { isDirty }
} = useF... | Do we really need the type here? It's not required in the API.
<img width="1910" height="872" alt="Image" src="https://github.com/user-attachments/assets/696e37d4-05b7-4e78-89da-7415ec9e6672" /> | secretPath,
isOverride,
onClose
}: Props) => {
const [isEditing, setIsEditing] = useState(Boolean(!comment));
const { projectId } = useProject();
const { mutateAsync: updateSecretV3, isPending } = useUpdateSecretV3();
const {
handleSubmit,
control,
reset,
formState: { isDirty }
} = useF... | @@ -0,0 +1,162 @@
+import { useState } from "react";
+import { Controller, useForm } from "react-hook-form";
+import { subject } from "@casl/ability";
+import { zodResolver } from "@hookform/resolvers/zod";
+import { z } from "zod";
+
+import { createNotification } from "@app/components/notifications";
+import { Projec... | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretCommentForm.tsx | 26 | TypeScript | 0.571 | question | 195 | 51 | 51 | false | feature: add secret comment support to overview page | 5,319 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretCommentForm.tsx
PR Title: feature: add secret comment support to overview page
BEFORE CODE: secretPath,
isOverride,
onClose
}: Props) => {
const [isEditing, setIsEditing... | Do we really need the type here? It's not required in the API.
<img width="1910" height="872" alt="Image" src="https://github.com/user-attachments/assets/696e37d4-05b7-4e78-89da-7415ec9e6672" /> | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
projectId,
secretPath,
secretKey,
type: isOverride ? SecretType.Personal : SecretType.Shared,
secretComment: data.comment
});
if ("approval" in result) {
createNotification({
type: "info",
text: "Requested change has been sent for review"
... | This will create a duplicated notification:
<img width="1896" height="872" alt="Image" src="https://github.com/user-attachments/assets/14ec363a-93c1-4aae-9bc2-4ebfcb2a9b62" /> | secretPath,
secretKey,
type: isOverride ? SecretType.Personal : SecretType.Shared,
secretComment: data.comment
});
if ("approval" in result) {
createNotification({
type: "info",
text: "Requested change has been sent for review"
});
} else {
createNo... | @@ -0,0 +1,162 @@
+import { useState } from "react";
+import { Controller, useForm } from "react-hook-form";
+import { subject } from "@casl/ability";
+import { zodResolver } from "@hookform/resolvers/zod";
+import { z } from "zod";
+
+import { createNotification } from "@app/components/notifications";
+import { Projec... | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretCommentForm.tsx | 26 | TypeScript | 0.429 | refactor | 176 | 51 | 51 | false | feature: add secret comment support to overview page | 5,319 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretCommentForm.tsx
PR Title: feature: add secret comment support to overview page
BEFORE CODE: projectId,
secretPath,
secretKey,
type: isOverride ? ... | This will create a duplicated notification:
<img width="1896" height="872" alt="Image" src="https://github.com/user-attachments/assets/14ec363a-93c1-4aae-9bc2-4ebfcb2a9b62" /> | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
} catch (e) {
console.error(e);
createNotification({
type: "error",
text: "Failed to fetch secret value."
});
}
};
const handleFormSubmit = async ({ value }: { value?: string | null }) => {
if ((value || value === "") && secretName) {
if (isCreatable) {
a... | nit: guess we might have an enum for approval status ? | try {
const { data } = await refetchSecretValue();
await window.navigator.clipboard.writeText(data?.valueOverride ?? data?.value ?? "");
createNotification({ type: "success", text: "Copied secret to clipboard" });
} catch (e) {
console.error(e);
createNotification({
type: ... | @@ -205,6 +210,37 @@ export const SecretEditTableRow = ({
}
};
+ const handleToggleMultilineEncoding = async () => {
+ try {
+ const result = await updateSecretV3({
+ environment,
+ projectId: currentProject.id,
+ secretPath,
+ secretKey: secretName,
+ type: isOverr... | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx | 26 | TypeScript | 0.214 | question | 54 | 51 | 51 | false | feature(frontend): toggle multi-line encoding from overview page | 5,338 | Infisical/infisical | 22,351 | TypeScript | IgorHorta | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx
PR Title: feature(frontend): toggle multi-line encoding from overview page
BEFORE CODE: } catch (e) {
console.error(e);
createNotification({
... | nit: guess we might have an enum for approval status ? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
| PermissionConditionOperators.$IN
| PermissionConditionOperators.$ELEMENTMATCH
>
] = el.rhs;
}
});
return caslCondition;
};
export const formRolePermission2API = (formVal: TFormSchema["permissions"]) => {
const permissions: TProjectPermission[] = [];
// other than workspa... | just curious, why was this added? | | PermissionConditionOperators.$IN
| PermissionConditionOperators.$ELEMENTMATCH
>
] = el.rhs;
}
});
return caslCondition;
};
export const formRolePermission2API = (formVal: TFormSchema["permissions"]) => {
const permissions: TProjectPermission[] = [];
// other than workspa... | @@ -1529,6 +1544,9 @@ export const formRolePermission2API = (formVal: TFormSchema["permissions"]) => {
? convertFormOperatorToCaslCondition(actions.conditions)
: undefined;
+ // Skip permissions with no actions selected
+ if (caslActions.length === 0) return;
+ | frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx | 26 | TypeScript | 0.071 | question | 34 | 51 | 51 | false | fix(ui): add secret approval request role to allow users view CR other than theirs | 5,345 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | IgorHorta | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx
PR Title: fix(ui): add secret approval request role to allow users view CR other than theirs
BEFORE CODE: | PermissionConditionOperators.$IN
... | just curious, why was this added? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
caslCondition[el.lhs][
el.operator as Exclude<
PermissionConditionOperators,
| PermissionConditionOperators.$ALL
| PermissionConditionOperators.$IN
| PermissionConditionOperators.$ELEMENTMATCH
>
] = el.rhs;
}
});
return caslCondition;
};
expor... | I don't think we should do this; it's modifying a form submission without the users awareness and making the assumption that they were going to remove it - for example if I add this and forgot to check `read`, as a user I'm intending to add this, just made a mistake, but now it disappears and saves with no context - it... | caslCondition[el.lhs][
el.operator as Exclude<
PermissionConditionOperators,
| PermissionConditionOperators.$ALL
| PermissionConditionOperators.$IN
| PermissionConditionOperators.$ELEMENTMATCH
>
] = el.rhs;
}
});
return caslCondition;
};
expor... | @@ -1539,14 +1539,15 @@ export const formRolePermission2API = (formVal: TFormSchema["permissions"]) => {
const caslActions = Object.keys(actions).filter(
(el) => actions?.[el as keyof typeof actions] && el !== "conditions" && el !== "inverted"
);
+ // Skip permissions with no actions selecte... | frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx | 26 | TypeScript | 0.643 | suggestion | 547 | 51 | 51 | false | fix(ui): add secret approval request role to allow users view CR other than theirs | 5,345 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | IgorHorta | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/project/RoleDetailsBySlugPage/components/ProjectRoleModifySection.utils.tsx
PR Title: fix(ui): add secret approval request role to allow users view CR other than theirs
BEFORE CODE: caslCondition[el.lhs][
el.operator as Exc... | I don't think we should do this; it's modifying a form submission without the users awareness and making the assumption that they were going to remove it - for example if I add this and forgot to check `read`, as a user I'm intending to add this, just made a mistake, but now it disappears and saves with no context - it... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
/* eslint-disable jsx-a11y/no-static-element-interactions */
/* eslint-disable jsx-a11y/click-events-have-key-events */
/* eslint-disable no-nested-ternary */
import { useEffect, useRef, useState } from "react";
import {
faCircleCheck,
faCircleXmark,
faExclamationTriangle,
faEye,
faEyeSlash,
faInfoCircle,
... | let's roll back these changes - there's more feedback I have here but it's out of scope for this PR and @victorvhs017 has a PR that may conflict, we can iterate there | /* eslint-disable jsx-a11y/no-static-element-interactions */
/* eslint-disable jsx-a11y/click-events-have-key-events */
/* eslint-disable no-nested-ternary */
import { useEffect, useRef, useState } from "react";
import {
faCircleCheck,
faCircleXmark,
faExclamationTriangle,
faEye,
faEyeSlash,
faInfoCircle,
... | frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChangeItem.tsx | 1 | TypeScript | 0.429 | suggestion | 166 | 26 | 26 | false | fix(ui): add secret approval request role to allow users view CR other than theirs | 5,345 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | IgorHorta | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretApprovalsPage/components/SecretApprovalRequest/components/SecretApprovalRequestChangeItem.tsx
PR Title: fix(ui): add secret approval request role to allow users view CR other than theirs
BEFORE CODE: /* eslint-disabl... | let's roll back these changes - there's more feedback I have here but it's out of scope for this PR and @victorvhs017 has a PR that may conflict, we can iterate there | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
name: true,
slug: true,
createdAt: true,
updatedAt: true,
parentOrgId: true
});
export const registerSubOrgRouter = async (server: FastifyZodProvider) => {
server.route({
method: "POST",
url: "/",
config: {
rateLimit: writeLimit
},
schema: {
hide: false,
tags: [ApiDocs... | The `{ field: "Slug" }` here is redundant, as it's the default field in the `slugSchema` | name: true,
slug: true,
createdAt: true,
updatedAt: true,
parentOrgId: true
});
export const registerSubOrgRouter = async (server: FastifyZodProvider) => {
server.route({
method: "POST",
url: "/",
config: {
rateLimit: writeLimit
},
schema: {
hide: false,
tags: [ApiDocs... | @@ -34,7 +35,8 @@ export const registerSubOrgRouter = async (server: FastifyZodProvider) => {
}
],
body: z.object({
- name: slugSchema().describe(SUB_ORGANIZATIONS.CREATE.name)
+ name: GenericResourceNameSchema.describe(SUB_ORGANIZATIONS.CREATE.name),
+ slug: slugSchema({ fie... | backend/src/ee/routes/v1/sub-org-router.ts | 26 | TypeScript | 0.357 | suggestion | 88 | 51 | 51 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/v1/sub-org-router.ts
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: name: true,
slug: true,
createdAt: true,
updatedAt: true,
parentOrgId: true
});
export const registerSubOrgRouter = as... | The `{ field: "Slug" }` here is redundant, as it's the default field in the `slugSchema` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
scope: OrganizationActionScope.ChildOrganization
});
ForbiddenError.from(permission).throwUnlessCan(OrgPermissionActions.Edit, OrgPermissionSubjects.Settings);
const updateData: { name?: string; slug?: string } = {};
// Backward compatibility: if only name is provided (no slug), update both nam... | nit: beware with some types of comments, for example, this may not be a "new behavior" in a couple of months, and may be confusing.
This is the type of thing highlighted in the PR description already! | scope: OrganizationActionScope.ChildOrganization
});
ForbiddenError.from(permission).throwUnlessCan(OrgPermissionActions.Edit, OrgPermissionSubjects.Settings);
const updateData: { name?: string; slug?: string } = {};
// Backward compatibility: if only name is provided (no slug), update both nam... | @@ -136,16 +140,49 @@ export const subOrgServiceFactory = ({
ForbiddenError.from(permission).throwUnlessCan(OrgPermissionActions.Edit, OrgPermissionSubjects.Settings);
- const existingSubOrg = await orgDAL.findOne({
- parentOrgId: subOrg.parentOrgId,
- slug: name
- });
+ const updateData: { ... | backend/src/ee/services/sub-org/sub-org-service.ts | 26 | TypeScript | 0.571 | nitpick | 201 | 51 | 51 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/sub-org/sub-org-service.ts
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: scope: OrganizationActionScope.ChildOrganization
});
ForbiddenError.from(permission).throwUnlessCan(OrgPer... | nit: beware with some types of comments, for example, this may not be a "new behavior" in a couple of months, and may be confusing.
This is the type of thing highlighted in the PR description already! | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
DELETE_IDENTITY_MEMBERSHIP: {
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th identity membership.",
limit: "The number of identity memberships to return.",
i... | nit: We don't need the backward compatibility part, as it's more internal stuff.
```suggestion
name: "Optional. The display name of the sub-organization. When only the name is provided (no slug), both name and slug are updated.",
``` | DELETE_IDENTITY_MEMBERSHIP: {
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th identity membership.",
limit: "The number of identity memberships to return.",
i... | @@ -831,10 +831,12 @@ export const ORG_IDENTITY_MEMBERSHIP = {
export const SUB_ORGANIZATIONS = {
CREATE: {
- name: "The name of the sub organization to create."
+ name: "The display name of the sub organization (e.g. 'Acme Corp'). Allows alphanumeric characters, spaces, dashes, and underscores.",
+ slug... | backend/src/lib/api-docs/constants.ts | 26 | TypeScript | 0.786 | suggestion | 238 | 51 | 51 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/lib/api-docs/constants.ts
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: DELETE_IDENTITY_MEMBERSHIP: {
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_M... | nit: We don't need the backward compatibility part, as it's more internal stuff.
```suggestion
name: "Optional. The display name of the sub-organization. When only the name is provided (no slug), both name and slug are updated.",
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
temporaryAccessStartTime: "Time to which the temporary access starts."
}
},
DELETE_IDENTITY_MEMBERSHIP: {
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th ... | nit: Let's use "sub-organization" with the hyphen, as we do in the UI
<img width="446" height="190" alt="Image" src="https://github.com/user-attachments/assets/3d7101de-a846-4351-8e7c-dfb060718641" />
```suggestion
name: "The display name of the sub-organization (e.g. 'Acme Corp'). Allows alphanumeric characters... | temporaryAccessStartTime: "Time to which the temporary access starts."
}
},
DELETE_IDENTITY_MEMBERSHIP: {
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th ... | @@ -831,10 +831,12 @@ export const ORG_IDENTITY_MEMBERSHIP = {
export const SUB_ORGANIZATIONS = {
CREATE: {
- name: "The name of the sub organization to create."
+ name: "The display name of the sub organization (e.g. 'Acme Corp'). Allows alphanumeric characters, spaces, dashes, and underscores.",
+ slug... | backend/src/lib/api-docs/constants.ts | 26 | TypeScript | 0.857 | suggestion | 525 | 51 | 51 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/lib/api-docs/constants.ts
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: temporaryAccessStartTime: "Time to which the temporary access starts."
}
},
DELETE_IDENTITY_MEMBERSHIP: {
identityId... | nit: Let's use "sub-organization" with the hyphen, as we do in the UI
<img width="446" height="190" alt="Image" src="https://github.com/user-attachments/assets/3d7101de-a846-4351-8e7c-dfb060718641" />
```suggestion
name: "The display name of the sub-organization (e.g. 'Acme Corp'). Allows alphanumeric characters... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th identity membership.",
limit: "The number of identity memberships to return.",
identityName: "",
roles: "The... | ```suggestion
slug: "Optional. The slug of the sub-organization. Can be updated independently when both name and slug are provided.",
``` | identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The offset to start from. If you enter 10, it will start from the 10th identity membership.",
limit: "The number of identity memberships to return.",
identityName: "",
roles: "The... | @@ -831,10 +831,12 @@ export const ORG_IDENTITY_MEMBERSHIP = {
export const SUB_ORGANIZATIONS = {
CREATE: {
- name: "The name of the sub organization to create."
+ name: "The display name of the sub organization (e.g. 'Acme Corp'). Allows alphanumeric characters, spaces, dashes, and underscores.",
+ slug... | backend/src/lib/api-docs/constants.ts | 26 | TypeScript | 0.714 | suggestion | 141 | 51 | 51 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/lib/api-docs/constants.ts
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: identityId: "The ID of the machine identity to delete the membership from."
},
LIST_IDENTITY_MEMBERSHIPS: {
offset: "The o... | ```suggestion
slug: "Optional. The slug of the sub-organization. Can be updated independently when both name and slug are provided.",
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
import { Controller, useForm } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import slugify from "@sindresorhus/slugify";
import { z } from "zod";
import { createNotification } from "@app/components/notifications";
import SecurityClient from "@app/components/utilities/SecurityClient";
... | nit: comment
```suggestion
// Optional: server auto-generates slug from name when not provided
``` | import { Controller, useForm } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import slugify from "@sindresorhus/slugify";
import { z } from "zod";
import { createNotification } from "@app/components/notifications";
import SecurityClient from "@app/components/utilities/SecurityClient";
... | @@ -8,15 +9,17 @@ import { Button, FormControl, Input } from "@app/components/v2";
import { useOrganization } from "@app/context";
import { useCreateSubOrganization } from "@app/hooks/api";
import { selectOrganization } from "@app/hooks/api/auth/queries";
-import { slugSchema } from "@app/lib/schemas";
+import { Gen... | frontend/src/layouts/OrganizationLayout/components/NavBar/NewSubOrganizationForm.tsx | 21 | TypeScript | 0.714 | suggestion | 101 | 46 | 46 | false | feature(api): add display name support for sub-organizations | 5,362 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | IgorHorta | Review this pull request change.
Language: TypeScript
File: frontend/src/layouts/OrganizationLayout/components/NavBar/NewSubOrganizationForm.tsx
PR Title: feature(api): add display name support for sub-organizations
BEFORE CODE: import { Controller, useForm } from "react-hook-form";
import { zodResolver } from "@ho... | nit: comment
```suggestion
// Optional: server auto-generates slug from name when not provided
``` | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
security: [
{
bearerAuth: []
}
],
params: z.object({
secretName: SecretNameSchema.describe(RAW_SECRETS.CREATE.secretName)
}),
body: z.object({
workspaceId: z.string().trim().optional().describe(RAW_SECRETS.CREATE.projectId),
projectSlug: z.... | do we know if this is still used ? | security: [
{
bearerAuth: []
}
],
params: z.object({
secretName: SecretNameSchema.describe(RAW_SECRETS.CREATE.secretName)
}),
body: z.object({
workspaceId: z.string().trim().optional().describe(RAW_SECRETS.CREATE.projectId),
projectSlug: z.... | @@ -548,7 +548,12 @@ export const registerDeprecatedSecretRouter = async (server: FastifyZodProvider)
secretComment: z.string().trim().optional().default("").describe(RAW_SECRETS.CREATE.secretComment),
secretMetadata: ResourceMetadataWithEncryptionSchema.optional(),
tagIds: z.string().array()... | backend/src/server/routes/v3/deprecated-secret-router.ts | 26 | TypeScript | 0.143 | question | 34 | 51 | 51 | false | fix(secrets): resolve rename validation error for skipMultilineEncoding | 5,379 | Infisical/infisical | 22,351 | TypeScript | IgorHorta | IgorHorta | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/v3/deprecated-secret-router.ts
PR Title: fix(secrets): resolve rename validation error for skipMultilineEncoding
BEFORE CODE: security: [
{
bearerAuth: []
}
],
params: z.object({
... | do we know if this is still used ? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
actorOrgId,
scope,
actorAuthMethod
}) => {
if (actor !== ActorType.USER && actor !== ActorType.IDENTITY) {
throw new BadRequestError({
message: "Invalid actor provided",
name: "Get org permission"
});
}
if (orgId !== actorOrgId) {
throw new ForbiddenRequestEr... | You are not a member of the organization {orgName} (ID: {orgId}). Please assign this identity to the organization with the appropriate permissions, then try again. | actorOrgId,
scope,
actorAuthMethod
}) => {
if (actor !== ActorType.USER && actor !== ActorType.IDENTITY) {
throw new BadRequestError({
message: "Invalid actor provided",
name: "Get org permission"
});
}
if (orgId !== actorOrgId) {
throw new ForbiddenRequestEr... | @@ -208,7 +208,10 @@ export const permissionServiceFactory = ({
actorId,
actorType: actor
});
- if (!permissionData?.length) throw new ForbiddenRequestError({ name: "You are not member of this organization" });
+ if (!permissionData?.length)
+ throw new ForbiddenRequestError({
+ mes... | backend/src/ee/services/permission/permission-service.ts | 26 | TypeScript | 0.357 | security | 163 | 51 | 51 | false | feat: updated permission error message | 5,414 | Infisical/infisical | 22,351 | TypeScript | maidul98 | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/permission/permission-service.ts
PR Title: feat: updated permission error message
BEFORE CODE: actorOrgId,
scope,
actorAuthMethod
}) => {
if (actor !== ActorType.USER && actor !== ActorType.IDENTITY) {
throw ... | You are not a member of the organization {orgName} (ID: {orgId}). Please assign this identity to the organization with the appropriate permissions, then try again. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
? "Cannot Edit Multi-line Encoding on Imported Secret"
: isCreatable
? "Create Secret to Edit Multi-line Encoding"
: !canEditSecretValue
? "Access Denied"
: skipMultilineEncoding
... | might be worth treating errors here ..
unsure if throwing an error on this onClick could break the interface (will test this scenario) | isCreatable || isImportedSecret || !canEditSecretValue || isUpdatingMultiline
}
onClick={handleToggleMultilineEncoding}
className={twMerge(
skipMultilineEncoding && !isImportedSecret
? "w-7 te... | @@ -735,38 +739,46 @@ export const SecretEditTableRow = ({
: "Enable Multi-line Encoding"}
</TooltipContent>
</Tooltip>
- <Modal>
- <Tooltip delayDuration={300} disableHoverableContent>
- <TooltipTrigger>
- ... | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx | 26 | TypeScript | 0.571 | suggestion | 134 | 51 | 51 | false | feat(frontend): add secret share action to overview page | 5,426 | Infisical/infisical | 22,351 | TypeScript | IgorHorta | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx
PR Title: feat(frontend): add secret share action to overview page
BEFORE CODE: ? "Cannot Edit Multi-line Encoding on Imported Secret"
... | might be worth treating errors here ..
unsure if throwing an error on this onClick could break the interface (will test this scenario) | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
(isCreatable && !isImportedSecret)
}
onClick={async () => {
if (sharedValueData) {
handlePopUpOpen("createSharedSecret", {
value: sharedValueData.value
});
... | nit: maybe we could put this in a function ?
something like
```javascript
const getTooltipContentForSecretSharing = () => {
if (!currentProject.secretSharing) {
return "Secret Sharing Disabled"
}
if (secretValueHidden) {
return "Access Denied"
}
if (isCreatable && !importedSecret) {
return "Crea... | ? "Cannot Edit Multi-line Encoding on Imported Secret"
: isCreatable
? "Create Secret to Edit Multi-line Encoding"
: !canEditSecretValue
? "Access Denied"
: skipMultilineEncoding
... | @@ -735,38 +739,46 @@ export const SecretEditTableRow = ({
: "Enable Multi-line Encoding"}
</TooltipContent>
</Tooltip>
- <Modal>
- <Tooltip delayDuration={300} disableHoverableContent>
- <TooltipTrigger>
- ... | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx | 26 | TypeScript | 0.857 | security | 373 | 51 | 51 | false | feat(frontend): add secret share action to overview page | 5,426 | Infisical/infisical | 22,351 | TypeScript | IgorHorta | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx
PR Title: feat(frontend): add secret share action to overview page
BEFORE CODE: (isCreatable && !isImportedSecret)
}
... | nit: maybe we could put this in a function ?
something like
```javascript
const getTooltipContentForSecretSharing = () => {
if (!currentProject.secretSharing) {
return "Secret Sharing Disabled"
}
if (secretValueHidden) {
return "Access Denied"
}
if (isCreatable && !importedSecret) {
return "Crea... | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
...req,
url: `/services/${link.id}/deploys`,
data: {}
})
);
}
break;
}
default:
throw new BadRequestError({ message: "Unknown render sync destination scope" });
}
};
export const RenderSyncFns = {
syncSecrets: async (secretSync: TRend... | praise: great work on readability!
way easier to read now | ...req,
url: `/services/${link.id}/deploys`,
data: {}
})
);
}
break;
}
default:
throw new BadRequestError({ message: "Unknown render sync destination scope" });
}
};
export const RenderSyncFns = {
syncSecrets: async (secretSync: TRend... | @@ -274,38 +274,55 @@ const redeployService = async (secretSync: TRenderSyncWithCredentials) => {
export const RenderSyncFns = {
syncSecrets: async (secretSync: TRenderSyncWithCredentials, secretMap: TSecretMap) => {
const renderSecrets = await getRenderEnvironmentSecrets(secretSync);
+ const environmentSlu... | backend/src/services/secret-sync/render/render-sync-fns.ts | 26 | TypeScript | 0.214 | suggestion | 57 | 51 | 51 | false | fix(secret-sync): fixed Render Secret Sync deletion bugs | 5,448 | Infisical/infisical | 22,351 | TypeScript | IgorHorta | victorvhs017 | Review this pull request change.
Language: TypeScript
File: backend/src/services/secret-sync/render/render-sync-fns.ts
PR Title: fix(secret-sync): fixed Render Secret Sync deletion bugs
BEFORE CODE: ...req,
url: `/services/${link.id}/deploys`,
data: {}
})
);
... | praise: great work on readability!
way easier to read now | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
query_params: params,
format: "JSONEachRow"
});
const rows = await result.json<TClickHouseAuditLogRow>();
// Batch-fetch project names from Postgres for any results that have a projectId
const projectIds = [...new Set(rows.map((r) => r.projectId).filter(Boolean))];
let pr... | nit we don't really need these since in the service you override them | query_params: params,
format: "JSONEachRow"
});
const rows = await result.json<TClickHouseAuditLogRow>();
// Batch-fetch project names from Postgres for any results that have a projectId
const projectIds = [...new Set(rows.map((r) => r.projectId).filter(Boolean))];
let pr... | @@ -0,0 +1,200 @@
+import { type ClickHouseClient } from "@clickhouse/client";
+import RE2 from "re2";
+
+import { TDbClient } from "@app/db";
+import { TableName, TAuditLogs } from "@app/db/schemas";
+import { DatabaseError } from "@app/lib/errors";
+import { logger } from "@app/lib/logger";
+import { ActorType } from... | backend/src/ee/services/audit-log/audit-log-clickhouse-dal.ts | 26 | TypeScript | 0.214 | nitpick | 70 | 40 | 39 | false | improvement(api): query audit logs with clickhouse | 5,463 | Infisical/infisical | 22,351 | TypeScript | maidul98 | fangpenlin | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/audit-log/audit-log-clickhouse-dal.ts
PR Title: improvement(api): query audit logs with clickhouse
BEFORE CODE: query_params: params,
format: "JSONEachRow"
});
const rows = await result.json<TClickHouseA... | nit we don't really need these since in the service you override them | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
export type TRedisConfigKeys = Partial<{
REDIS_URL: string;
REDIS_USERNAME: string;
REDIS_PASSWORD: string;
REDIS_CLUSTER_HOSTS: { host: string; port: number }[];
REDIS_CLUSTER_ENABLE_TLS: boolean;
// ref: https://github.com/redis/ioredis?tab=readme-ov-file#special-note-aws-elasticache-clusters-with-tls
... | should we be sending a 2? https://redis.github.io/ioredis/interfaces/CommonRedisOptions.html#reconnectOnError | export type TRedisConfigKeys = Partial<{
REDIS_URL: string;
REDIS_USERNAME: string;
REDIS_PASSWORD: string;
REDIS_CLUSTER_HOSTS: { host: string; port: number }[];
REDIS_CLUSTER_ENABLE_TLS: boolean;
// ref: https://github.com/redis/ioredis?tab=readme-ov-file#special-note-aws-elasticache-clusters-with-tls
... | @@ -18,17 +18,37 @@ export type TRedisConfigKeys = Partial<{
}>;
export const buildRedisFromConfig = (cfg: TRedisConfigKeys) => {
- if (cfg.REDIS_URL) return new Redis(cfg.REDIS_URL, { maxRetriesPerRequest: null });
+ if (cfg.REDIS_URL) {
+ return new Redis(cfg.REDIS_URL, {
+ maxRetriesPerRequest: null,
+... | backend/src/lib/config/redis.ts | 26 | TypeScript | 0.571 | question | 110 | 51 | 51 | false | chore: added redis reconnect on error | 5,466 | Infisical/infisical | 22,351 | TypeScript | maidul98 | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/lib/config/redis.ts
PR Title: chore: added redis reconnect on error
BEFORE CODE: export type TRedisConfigKeys = Partial<{
REDIS_URL: string;
REDIS_USERNAME: string;
REDIS_PASSWORD: string;
REDIS_CLUSTER_HOSTS: { host: string; port: num... | should we be sending a 2? https://redis.github.io/ioredis/interfaces/CommonRedisOptions.html#reconnectOnError | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
const { gatewayId } = appConnection;
const url = new URL(requestConfig.url as string);
await blockLocalAndPrivateIpAddresses(url.toString(), Boolean(gatewayId));
// If gateway isn't set up, don't proxy request
if (!gatewayId) {
return request.request(requestConfig);
}
const [targetHost] = await ver... | don't we still want to verify these? | gatewayV2Service: Pick<TGatewayV2ServiceFactory, "getPlatformConnectionDetailsByGatewayId">,
requestConfig: AxiosRequestConfig,
gatewayDetails?: TGatewayDetails
): Promise<AxiosResponse<T>> => {
const { gatewayId } = appConnection;
const url = new URL(requestConfig.url as string);
await blockLocalAndPrivat... | @@ -141,19 +145,35 @@ export const requestWithHCVaultGateway = async <T>(
return request.request(requestConfig);
}
- const [targetHost] = await verifyHostInputValidity({ host: url.hostname, isGateway: true, isDynamicSecret: false });
+ let gatewayConnectionDetailsV2: TGatewayV2ConnectionDetails | undefined;... | backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts | 26 | TypeScript | 0.071 | question | 36 | 51 | 51 | false | feat(vault): reusable gateway | 5,481 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts
PR Title: feat(vault): reusable gateway
BEFORE CODE: const { gatewayId } = appConnection;
const url = new URL(requestConfig.url as string);
await blockLocalAndPrivateIpAddresses... | don't we still want to verify these? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
});
stream.on("error", (streamErr: Error) => {
clearTimeout(timeout);
reject(new Error(`Stream error: ${streamErr.message}`));
});
// Initiate passwd command
stream.write("passwd\n");
});
});
};
export const unixLinuxLocalAccountRotationFactory: TRotationFactory<
... | Why is `?? false` needed? shouldn't the Boolean() wrap do the trick? | });
stream.on("error", (streamErr: Error) => {
clearTimeout(timeout);
reject(new Error(`Stream error: ${streamErr.message}`));
});
// Initiate passwd command
stream.write("passwd\n");
});
});
};
export const unixLinuxLocalAccountRotationFactory: TRotationFactory<
... | @@ -161,8 +168,10 @@ export const unixLinuxLocalAccountRotationFactory: TRotationFactory<
const {
username,
passwordRequirements,
- rotationMethod = UnixLinuxLocalAccountRotationMethod.LoginAsRoot
+ rotationMethod = UnixLinuxLocalAccountRotationMethod.LoginAsRoot,
+ useSudo
} = parameters;
+ c... | backend/src/ee/services/secret-rotation-v2/unix-linux-local-account-rotation/unix-linux-local-account-rotation-fns.ts | 26 | TypeScript | 0.429 | question | 68 | 51 | 51 | false | feat: removed the check in rotation and also added useSudo capability in unix linux account rotation | 5,495 | Infisical/infisical | 22,351 | TypeScript | varonix0 | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/secret-rotation-v2/unix-linux-local-account-rotation/unix-linux-local-account-rotation-fns.ts
PR Title: feat: removed the check in rotation and also added useSudo capability in unix linux account rotation
BEFORE CODE: });
... | Why is `?? false` needed? shouldn't the Boolean() wrap do the trick? | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
iamRequestBody: string;
iamRequestHeaders: string;
};
export type TAttachAwsAuthDTO = {
identityId: string;
stsEndpoint: string;
allowedPrincipalArns: string;
allowedAccountIds: string;
accessTokenTTL: number;
accessTokenMaxTTL: number;
accessTokenNumUsesLimit: number;
accessTokenTrustedIps: { ipAd... | No issues found. | iamRequestBody: string;
iamRequestHeaders: string;
};
export type TAttachAwsAuthDTO = {
identityId: string;
stsEndpoint: string;
allowedPrincipalArns: string;
allowedAccountIds: string;
accessTokenTTL: number;
accessTokenMaxTTL: number;
accessTokenNumUsesLimit: number;
accessTokenTrustedIps: { ipAd... | @@ -40,7 +40,8 @@ export type TAwsGetCallerIdentityHeaders = {
"X-Amz-Date": string;
"Content-Length": number;
"x-amz-security-token": string;
- Authorization: string;
+ Authorization?: string;
+ authorization?: string;
};
export type TGetCallerIdentityResponse = { | backend/src/services/identity-aws-auth/identity-aws-auth-types.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | docs(identities/aws-auth): eks pod auth | 3,762 | Infisical/infisical | 22,351 | TypeScript | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/services/identity-aws-auth/identity-aws-auth-types.ts
PR Title: docs(identities/aws-auth): eks pod auth
BEFORE CODE: iamRequestBody: string;
iamRequestHeaders: string;
};
export type TAttachAwsAuthDTO = {
identityId: string;
stsEndpoin... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if (!plan.eventSubscriptions) {
throw new BadRequestError({
message:
"Failed to use event subscriptions due to plan restriction. Upgrade plan to access enterprise event subscriptions."
});
}
const count = await sse.getActiveConnectionsCount(req.bod... | No issues found. |
if (!plan.eventSubscriptions) {
throw new BadRequestError({
message:
"Failed to use event subscriptions due to plan restriction. Upgrade plan to access enterprise event subscriptions."
});
}
const count = await sse.getActiveConnectionsCount(req.bod... | @@ -7,6 +7,7 @@ import { ActionProjectType, ProjectType } from "@app/db/schemas";
import { getServerSentEventsHeaders } from "@app/ee/services/event/event-sse-stream";
import { EventRegisterSchema } from "@app/ee/services/event/types";
import { ProjectPermissionSecretActions, ProjectPermissionSub } from "@app/ee/ser... | backend/src/server/routes/v1/event-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Events system docs | 4,294 | Infisical/infisical | 22,351 | TypeScript | sidwebworks | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/v1/event-router.ts
PR Title: Events system docs
BEFORE CODE:
if (!plan.eventSubscriptions) {
throw new BadRequestError({
message:
"Failed to use event subscriptions due to plan restrict... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
url: "/env-key",
config: {
rateLimit: writeLimit
},
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const data = await req.file({
limits: {
fileSize: MB25_IN_BYTES
}
});
if (!data) {
throw new BadRequestError({ message: "No ... | No issues found. | url: "/env-key",
config: {
rateLimit: writeLimit
},
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const data = await req.file({
limits: {
fileSize: MB25_IN_BYTES
}
});
if (!data) {
throw new BadRequestError({ message: "No ... | @@ -19,7 +19,7 @@ export const registerExternalMigrationRouter = async (server: FastifyZodProvider
config: {
rateLimit: writeLimit
},
- onRequest: verifyAuth([AuthMode.JWT, AuthMode.IDENTITY_ACCESS_TOKEN]),
+ onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const data ... | backend/src/server/routes/v3/external-migration-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: improve vault folders mapping | 4,320 | Infisical/infisical | 22,351 | TypeScript | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/v3/external-migration-router.ts
PR Title: fix: improve vault folders mapping
BEFORE CODE: url: "/env-key",
config: {
rateLimit: writeLimit
},
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) =>... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
url,
bindDN,
bindPass,
uniqueUserAttribute,
searchBase,
searchFilter,
groupSearchBase,
groupSearchFilter,
caCert
}: {
organizationId: string;
isActive?: boolean;
url?: string;
bindDN?: string;
bindPass?: string;
uniqueUserAttr... | No issues found. | url,
bindDN,
bindPass,
uniqueUserAttribute,
searchBase,
searchFilter,
groupSearchBase,
groupSearchFilter,
caCert
}: {
organizationId: string;
isActive?: boolean;
url?: string;
bindDN?: string;
bindPass?: string;
uniqueUserAttr... | @@ -151,10 +151,23 @@ export const useDeleteLDAPGroupMapping = () => {
export const useTestLDAPConnection = () => {
return useMutation({
- mutationFn: async (ldapConfigId: string) => {
- const { data } = await apiRequest.post<boolean>(
- `/api/v1/ldap/config/${ldapConfigId}/test-connection`
- ... | frontend/src/hooks/api/ldapConfig/mutations.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | misc: address LDAP config update and test issues | 4,329 | Infisical/infisical | 22,351 | TypeScript | sheensantoscapadngan | Review this pull request change.
Language: TypeScript
File: frontend/src/hooks/api/ldapConfig/mutations.tsx
PR Title: misc: address LDAP config update and test issues
BEFORE CODE: url,
bindDN,
bindPass,
uniqueUserAttribute,
searchBase,
searchFilter,
groupSearchBase,
g... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
},
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const approvals = await server.services.accessApprovalPolicy.getAccessApprovalPolicyByProjectSlug({
actor: req.permission.type,
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
ac... | No issues found. | },
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const approvals = await server.services.accessApprovalPolicy.getAccessApprovalPolicyByProjectSlug({
actor: req.permission.type,
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
ac... | @@ -3,12 +3,32 @@ import { z } from "zod";
import { ApproverType, BypasserType } from "@app/ee/services/access-approval-policy/access-approval-policy-types";
import { removeTrailingSlash } from "@app/lib/fn";
+import { ms } from "@app/lib/ms";
import { EnforcementLevel } from "@app/lib/types";
import { readLimit,... | backend/src/ee/routes/v1/access-approval-policy-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(access-policies): Allow policy limits on access request times | 4,336 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/v1/access-approval-policy-router.ts
PR Title: feat(access-policies): Allow policy limits on access request times
BEFORE CODE: },
onRequest: verifyAuth([AuthMode.JWT]),
handler: async (req) => {
const approvals = awai... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
await auditLogService.createAuditLog({
actor: {
type: ActorType.PLATFORM,
metadata: {}
},
orgId,
event: {
type: EventType.OIDC_GROUP_MEMBERSHIP_MAPPING_ASSIGN_USER,
metadata: {
userId: user.id,
us... | No issues found. | await auditLogService.createAuditLog({
actor: {
type: ActorType.PLATFORM,
metadata: {}
},
orgId,
event: {
type: EventType.OIDC_GROUP_MEMBERSHIP_MAPPING_ASSIGN_USER,
metadata: {
userId: user.id,
us... | @@ -180,7 +180,7 @@ export const oidcConfigServiceFactory = ({
}
const appCfg = getConfig();
- const userAlias = await userAliasDAL.findOne({
+ let userAlias = await userAliasDAL.findOne({
externalId,
orgId,
aliasType: UserAliasType.OIDC
@@ -231,32 +231,29 @@ export const oidcConf... | backend/src/ee/services/oidc/oidc-config-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Fix SAML duplicate accounts when signing in the first time on an existing account | 4,344 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/oidc/oidc-config-service.ts
PR Title: Fix SAML duplicate accounts when signing in the first time on an existing account
BEFORE CODE: await auditLogService.createAuditLog({
actor: {
type: ActorType.PLATF... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
})
);
};
export const replaceNonChangesWithNewlines = (patch: string) => {
return patch
.split("\n")
.map((line) => {
// Keep added lines (remove the + prefix)
if (line.startsWith("+") && !line.startsWith("+++")) {
return line.substring(1);
}
// Replace everything else ... | No issues found. | })
);
};
export const replaceNonChangesWithNewlines = (patch: string) => {
return patch
.split("\n")
.map((line) => {
// Keep added lines (remove the + prefix)
if (line.startsWith("+") && !line.startsWith("+++")) {
return line.substring(1);
}
// Replace everything else ... | @@ -58,9 +58,9 @@ export function scanDirectory(inputPath: string, outputPath: string, configPath?
});
}
-export function scanFile(inputPath: string): Promise<void> {
+export function scanFile(inputPath: string, configPath?: string): Promise<void> {
return new Promise((resolve, reject) => {
- const command ... | backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | misc: added entropy check for params secret scanning | 4,350 | Infisical/infisical | 22,351 | TypeScript | sheensantoscapadngan | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.ts
PR Title: misc: added entropy check for params secret scanning
BEFORE CODE: })
);
};
export const replaceNonChangesWithNewlines = (patch: string) => {
return patch
.split("\n... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
try {
interface CountResult {
count: string;
}
const count = await db
.replicaNode()(TableName.OrgMembership)
.where(`${TableName.OrgMembership}.orgId`, orgId)
.count("*")
.join(TableName.Users, `${TableName.OrgMembership}.userId`, `${TableName.Users}.id`)
... | No issues found. | try {
interface CountResult {
count: string;
}
const count = await db
.replicaNode()(TableName.OrgMembership)
.where(`${TableName.OrgMembership}.orgId`, orgId)
.count("*")
.join(TableName.Users, `${TableName.OrgMembership}.userId`, `${TableName.Users}.id`)
... | @@ -630,6 +630,25 @@ export const orgDALFactory = (db: TDbClient) => {
}
};
+ const findIdentityOrganization = async (
+ identityId: string
+ ): Promise<{ id: string; name: string; slug: string; role: string }> => {
+ try {
+ const org = await db
+ .replicaNode()(TableName.IdentityOrgMembe... | backend/src/services/org/org-dal.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Add machine identities to /organization endpoint | 4,359 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/org/org-dal.ts
PR Title: Add machine identities to /organization endpoint
BEFORE CODE: try {
interface CountResult {
count: string;
}
const count = await db
.replicaNode()(TableName.OrgMembership)... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const findByProjectId = async (
{ status, limit = 20, offset = 0, projectId, committer, environment, userId, search }: TFindQueryFilter,
tx?: Knex
) => {
try {
// akhilmhdh: If ever u wanted a 1 to so many relationship connected with pagination
// this is the place u wanna look at.
co... | No issues found. |
const findByProjectId = async (
{ status, limit = 20, offset = 0, projectId, committer, environment, userId, search }: TFindQueryFilter,
tx?: Knex
) => {
try {
// akhilmhdh: If ever u wanted a 1 to so many relationship connected with pagination
// this is the place u wanna look at.
co... | @@ -4,6 +4,7 @@ import { TDbClient } from "@app/db";
import {
SecretApprovalRequestsSchema,
TableName,
+ TOrgMemberships,
TSecretApprovalRequests,
TSecretApprovalRequestsSecrets,
TUserGroupMembership,
@@ -107,11 +108,32 @@ export const secretApprovalRequestDALFactory = (db: TDbClient) => {
`${... | backend/src/ee/services/secret-approval-request/secret-approval-request-dal.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(approvals): visualization of deprovisioned scim users | 4,363 | Infisical/infisical | 22,351 | TypeScript | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/secret-approval-request/secret-approval-request-dal.ts
PR Title: feat(approvals): visualization of deprovisioned scim users
BEFORE CODE:
const findByProjectId = async (
{ status, limit = 20, offset = 0, projectId, committer, ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
secretPath
});
};
const handleFolderDelete = async () => {
try {
const folderData = popUp.deleteFolder?.data as TSecretFolder;
if (isBatchMode) {
const pendingFolderDelete: PendingFolderDelete = {
id: folderData.id,
folderName: folderData.name,
folde... | No issues found. | secretPath
});
};
const handleFolderDelete = async () => {
try {
const folderData = popUp.deleteFolder?.data as TSecretFolder;
if (isBatchMode) {
const pendingFolderDelete: PendingFolderDelete = {
id: folderData.id,
folderName: folderData.name,
folde... | @@ -16,7 +16,7 @@ import { ProjectPermissionCan } from "@app/components/permissions";
import { DeleteActionModal, IconButton, Modal, ModalContent } from "@app/components/v2";
import { Tooltip } from "@app/components/v2/Tooltip/Tooltip";
import { ROUTE_PATHS } from "@app/const/routes";
-import { ProjectPermissionActi... | frontend/src/pages/secret-manager/SecretDashboardPage/components/FolderListView/FolderListView.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Improve delete folder message | 4,375 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretDashboardPage/components/FolderListView/FolderListView.tsx
PR Title: Improve delete folder message
BEFORE CODE: secretPath
});
};
const handleFolderDelete = async () => {
try {
const folderDa... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
? getAllNestedSecretReferences(
crypto.encryption().symmetric().decrypt({
ciphertext: el.secretValueCiphertext,
iv: el.secretValueIV,
tag: el.secretValueTag,
key: botKey,
... | No issues found. | ? getAllNestedSecretReferences(
crypto.encryption().symmetric().decrypt({
ciphertext: el.secretValueCiphertext,
iv: el.secretValueIV,
tag: el.secretValueTag,
key: botKey,
... | @@ -280,13 +280,22 @@ export const secretApprovalRequestServiceFactory = ({
) {
throw new ForbiddenRequestError({ message: "User has insufficient privileges" });
}
- const getHasSecretReadAccess = (environment: string, tags: { slug: string }[], secretPath?: string) => {
- const canRead = hasSec... | backend/src/ee/services/secret-approval-request/secret-approval-request-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: allow secret approval reviewers to read secrets | 4,411 | Infisical/infisical | 22,351 | TypeScript | sidwebworks | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/secret-approval-request/secret-approval-request-service.ts
PR Title: feat: allow secret approval reviewers to read secrets
BEFORE CODE: ? getAllNestedSecretReferences(
crypto.encryption().symm... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
config.accountId,
config.groupId,
Object.values(updatedVariables)
);
} catch (error) {
if (error instanceof SecretSyncError) throw error;
throw new SecretSyncError({
error,
secretKey: "group_update"
});
}
} else {
/... | No issues found. | config.accountId,
config.groupId,
Object.values(updatedVariables)
);
} catch (error) {
if (error instanceof SecretSyncError) throw error;
throw new SecretSyncError({
error,
secretKey: "group_update"
});
}
} else {
/... | @@ -23,80 +23,175 @@ export const ChecklySyncFns = {
const config = secretSync.destinationConfig;
- const variables = await ChecklyPublicAPI.getVariables(secretSync.connection, config.accountId);
+ if (config.groupId) {
+ // Handle group environment variables
+ const groupVars = await ChecklyPu... | backend/src/services/secret-sync/checkly/checkly-sync-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: Support Checkly group variables (ENG-3478) | 4,418 | Infisical/infisical | 22,351 | TypeScript | sidwebworks | Review this pull request change.
Language: TypeScript
File: backend/src/services/secret-sync/checkly/checkly-sync-fns.ts
PR Title: feat: Support Checkly group variables (ENG-3478)
BEFORE CODE: config.accountId,
config.groupId,
Object.values(updatedVariables)
);
} catch (e... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// };
export const ProjectsPage = () => {
const { t } = useTranslation();
const [projectListView, setProjectListView] = useState<ProjectListView>(() => {
const storedView = localStorage.getItem("projectListView");
if (
storedView &&
(storedView === ProjectListView.AllProjects || storedView ==... | No issues found. | // };
export const ProjectsPage = () => {
const { t } = useTranslation();
const [projectListView, setProjectListView] = useState<ProjectListView>(() => {
const storedView = localStorage.getItem("projectListView");
if (
storedView &&
(storedView === ProjectListView.AllProjects || storedView ==... | @@ -11,7 +11,7 @@ import { usePopUp } from "@app/hooks/usePopUp";
import { AllProjectView } from "./components/AllProjectView";
import { MyProjectView } from "./components/MyProjectView";
-import { ProjectListToggle, ProjectListView } from "./components/ProjectListToggle";
+import { ProjectListView } from "./compon... | frontend/src/pages/organization/ProjectsPage/ProjectsPage.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | improvement(frontend): Revise Project View Select UI on Project Overview Page | 4,432 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/ProjectsPage/ProjectsPage.tsx
PR Title: improvement(frontend): Revise Project View Select UI on Project Overview Page
BEFORE CODE: // };
export const ProjectsPage = () => {
const { t } = useTranslation();
const [projec... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
destinationConfig: { mount, path },
syncOptions: { disableSecretDeletion, keySchema }
} = secretSync;
const { namespace } = connection.credentials;
const accessToken = await getHCVaultAccessToken(connection, gatewayService);
const instanceUrl = await getHCVaultInstanceUrl(connection);
... | No issues found. | destinationConfig: { mount, path },
syncOptions: { disableSecretDeletion, keySchema }
} = secretSync;
const { namespace } = connection.credentials;
const accessToken = await getHCVaultAccessToken(connection, gatewayService);
const instanceUrl = await getHCVaultInstanceUrl(connection);
... | @@ -1,9 +1,13 @@
import { isAxiosError } from "axios";
-import { request } from "@app/lib/config/request";
+import { TGatewayServiceFactory } from "@app/ee/services/gateway/gateway-service";
import { removeTrailingSlash } from "@app/lib/fn";
-import { blockLocalAndPrivateIpAddresses } from "@app/lib/validator";
-im... | backend/src/services/secret-sync/hc-vault/hc-vault-sync-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(app-connection, secret-sync): HC Vault Gateway Support | 4,455 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/services/secret-sync/hc-vault/hc-vault-sync-fns.ts
PR Title: feat(app-connection, secret-sync): HC Vault Gateway Support
BEFORE CODE: destinationConfig: { mount, path },
syncOptions: { disableSecretDeletion, keySchema }
} = secr... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
isRedisSentinelMode: Boolean(data.REDIS_SENTINEL_HOSTS),
REDIS_SENTINEL_HOSTS: data.REDIS_SENTINEL_HOSTS?.trim()
?.split(",")
.map((el) => {
const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Number(port.trim()) };
}),
REDIS_CLUSTER_HOSTS: data.RED... | No issues found. | isRedisSentinelMode: Boolean(data.REDIS_SENTINEL_HOSTS),
REDIS_SENTINEL_HOSTS: data.REDIS_SENTINEL_HOSTS?.trim()
?.split(",")
.map((el) => {
const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Number(port.trim()) };
}),
REDIS_CLUSTER_HOSTS: data.RED... | @@ -37,6 +37,8 @@ const envSchema = z
.default("false")
.transform((el) => el === "true"),
REDIS_URL: zpStr(z.string().optional()),
+ REDIS_USERNAME: zpStr(z.string().optional()),
+ REDIS_PASSWORD: zpStr(z.string().optional()),
REDIS_SENTINEL_HOSTS: zpStr(
z
.string()
@@ -4... | backend/src/lib/config/env.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Redis cluster support | 4,464 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/lib/config/env.ts
PR Title: Redis cluster support
BEFORE CODE: isRedisSentinelMode: Boolean(data.REDIS_SENTINEL_HOSTS),
REDIS_SENTINEL_HOSTS: data.REDIS_SENTINEL_HOSTS?.trim()
?.split(",")
.map((el) => {
const [host,... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
appConnectionDAL,
licenseService,
gatewayService
});
const secretQueueService = secretQueueFactory({
keyStore,
queueService,
secretDAL,
folderDAL,
integrationAuthService,
projectBotService,
integrationDAL,
secretImportDAL,
projectEnvDAL,
webhookDAL,
auditLogS... | No issues found. | appConnectionDAL,
licenseService,
gatewayService
});
const secretQueueService = secretQueueFactory({
keyStore,
queueService,
secretDAL,
folderDAL,
integrationAuthService,
projectBotService,
integrationDAL,
secretImportDAL,
projectEnvDAL,
webhookDAL,
auditLogS... | @@ -312,6 +312,7 @@ import { injectAssumePrivilege } from "../plugins/auth/inject-assume-privilege";
import { injectIdentity } from "../plugins/auth/inject-identity";
import { injectPermission } from "../plugins/auth/inject-permission";
import { injectRateLimits } from "../plugins/inject-rate-limits";
+import { forw... | backend/src/server/routes/index.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: primary forwarding mode completed | 4,476 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/index.ts
PR Title: feat: primary forwarding mode completed
BEFORE CODE: appConnectionDAL,
licenseService,
gatewayService
});
const secretQueueService = secretQueueFactory({
keyStore,
queueService,
secr... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
password: providerInputs.password,
ssl,
// @ts-expect-error this is because of knexjs type signature issue. This is directly passed to driver
// https://github.com/knex/knex/blob/b6507a7129d2b9fafebf5f831494431e64c6a8a0/lib/dialects/mssql/index.js#L66
// https://github.com/tediou... | No issues found. | password: providerInputs.password,
ssl,
// @ts-expect-error this is because of knexjs type signature issue. This is directly passed to driver
// https://github.com/knex/knex/blob/b6507a7129d2b9fafebf5f831494431e64c6a8a0/lib/dialects/mssql/index.js#L66
// https://github.com/tediou... | @@ -150,16 +150,18 @@ export const SqlDatabaseProvider = ({ gatewayService }: TSqlDatabaseProviderDTO)
return { ...providerInputs, hostIp };
};
- const $getClient = async (providerInputs: z.infer<typeof DynamicSecretSqlDBSchema>) => {
- const ssl = providerInputs.ca ? { rejectUnauthorized: false, ca: prov... | backend/src/ee/services/dynamic-secret/providers/sql-database.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: removed internal ip transformation | 4,479 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/dynamic-secret/providers/sql-database.ts
PR Title: feat: removed internal ip transformation
BEFORE CODE: password: providerInputs.password,
ssl,
// @ts-expect-error this is because of knexjs type signature is... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
provider: LogProvider.Cribl
}
});
const {
handleSubmit,
control,
formState: { isSubmitting, isDirty }
} = form;
return (
<FormProvider {...form}>
<form onSubmit={handleSubmit(onSubmit)}>
<Controller
name="credentials.url"
control={control}
... | No issues found. | provider: LogProvider.Cribl
}
});
const {
handleSubmit,
control,
formState: { isSubmitting, isDirty }
} = form;
return (
<FormProvider {...form}>
<form onSubmit={handleSubmit(onSubmit)}>
<Controller
name="credentials.url"
control={control}
... | @@ -0,0 +1,108 @@
+import { Controller, FormProvider, useForm } from "react-hook-form";
+import { zodResolver } from "@hookform/resolvers/zod";
+import { z } from "zod";
+
+import { Button, FormControl, Input, ModalClose, SecretInput } from "@app/components/v2";
+import { LogProvider } from "@app/hooks/api/auditLogStre... | frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/AuditLogStreamForm/CriblProviderAuditLogStreamForm.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(audit-log-stream): cribl support | 4,500 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/AuditLogStreamForm/CriblProviderAuditLogStreamForm.tsx
PR Title: feat(audit-log-stream): cribl support
BEFORE CODE: provider: LogProvider.Cribl
}
});
const {
handl... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const getActiveSsoLabel = () => {
if (isSamlActive) return "SAML";
if (isOidcActive) return "OIDC";
if (isLdapActive) return "LDAP";
return "";
};
return (
<div className="rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-6">
<div>
<p className="text-xl font-semibold te... | No issues found. |
const getActiveSsoLabel = () => {
if (isSamlActive) return "SAML";
if (isOidcActive) return "OIDC";
if (isLdapActive) return "LDAP";
return "";
};
return (
<div className="rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-6">
<div>
<p className="text-xl font-semibold te... | @@ -24,11 +24,17 @@ enum EnforceAuthType {
export const OrgGeneralAuthSection = ({
isSamlConfigured,
isOidcConfigured,
- isGoogleConfigured
+ isGoogleConfigured,
+ isSamlActive,
+ isOidcActive,
+ isLdapActive
}: {
isSamlConfigured: boolean;
isOidcConfigured: boolean;
isGoogleConfigured: boolean;
+... | frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | improvement(google-oauth-enforcement): prevent conflicting sso enforcement configuration | 4,501 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgGeneralAuthSection.tsx
PR Title: improvement(google-oauth-enforcement): prevent conflicting sso enforcement configuration
BEFORE CODE:
const getActiveSsoLabel = () => {
if (isSaml... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
})),
folderId,
actorId,
tx
);
await Promise.all(
deletedSecrets
.filter(({ reminderRepeatDays }) => Boolean(reminderRepeatDays))
.map(({ id, reminderRepeatDays }) =>
secretQueueService.removeSecretReminder(
{ secretId: id, repeatDays: reminderRepeatDays as number, ... | No issues found. | })),
folderId,
actorId,
tx
);
await Promise.all(
deletedSecrets
.filter(({ reminderRepeatDays }) => Boolean(reminderRepeatDays))
.map(({ id, reminderRepeatDays }) =>
secretQueueService.removeSecretReminder(
{ secretId: id, repeatDays: reminderRepeatDays as number, ... | @@ -597,19 +597,27 @@ export const expandSecretReferencesFactory = ({
return secretCache[cacheKey][secretKey] || { value: "", tags: [] };
}
- const folder = await folderDAL.findBySecretPath(projectId, environment, secretPath);
- if (!folder) return { value: "", tags: [] };
- const secrets = await... | backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Stop blocking secret references with no matching reference and improve UI edit secret behavior to better highlight this | 4,505 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts
PR Title: Stop blocking secret references with no matching reference and improve UI edit secret behavior to better highlight this
BEFORE CODE: })),
folderId,
actorId,
tx
);
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const pickPrimaryOrSecondaryRedis = (primary: Redis | Cluster, secondaries?: Array<Redis | Cluster>) => {
if (!secondaries || !secondaries.length) return primary;
const selectedReplica = secondaries[Math.floor(Math.random() * secondaries.length)];
return selectedReplica;
};
interface TKeyStoreFactoryDTO extends... | No issues found. |
const pickPrimaryOrSecondaryRedis = (primary: Redis | Cluster, secondaries?: Array<Redis | Cluster>) => {
if (!secondaries || !secondaries.length) return primary;
const selectedReplica = secondaries[Math.floor(Math.random() * secondaries.length)];
return selectedReplica;
};
interface TKeyStoreFactoryDTO extends... | @@ -1,11 +1,15 @@
import { Cluster, Redis } from "ioredis";
+import { Knex } from "knex";
import { buildRedisFromConfig, TRedisConfigKeys } from "@app/lib/config/redis";
import { pgAdvisoryLockHashText } from "@app/lib/crypto/hashtext";
import { applyJitter } from "@app/lib/dates";
import { delay as delayMs } fr... | backend/src/keystore/keystore.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Local redis for geo | 4,506 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | Review this pull request change.
Language: TypeScript
File: backend/src/keystore/keystore.ts
PR Title: Local redis for geo
BEFORE CODE:
const pickPrimaryOrSecondaryRedis = (primary: Redis | Cluster, secondaries?: Array<Redis | Cluster>) => {
if (!secondaries || !secondaries.length) return primary;
const select... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
throw new BadRequestError({
message: "Email changes are disabled because SCIM is enabled for one or more of your organizations",
name: "RequestEmailChangeOTP"
});
}
// Silently check if another user already has this email - don't send OTP if email is taken
const ex... | No issues found. | throw new BadRequestError({
message: "Email changes are disabled because SCIM is enabled for one or more of your organizations",
name: "RequestEmailChangeOTP"
});
}
// Silently check if another user already has this email - don't send OTP if email is taken
const ex... | @@ -294,11 +294,18 @@ export const userServiceFactory = ({
// Delete all user aliases since the email is changing
await userAliasDAL.delete({ userId }, tx);
+ // Ensure EMAIL auth method is included if not already present
+ const currentAuthMethods = user.authMethods || [];
+ const update... | backend/src/services/user/user-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Enable email login on change of emails flows to avoid blocked users | 4,539 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/user/user-service.ts
PR Title: Enable email login on change of emails flows to avoid blocked users
BEFORE CODE: throw new BadRequestError({
message: "Email changes are disabled because SCIM is enabled for one or more ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
params: {
projectId
}
});
return null;
}
return {
connectionId,
returnUrl,
appConnectionName: formData.app,
projectId,
connection
};
}, []);
const handleAzureDevOps = useCallback(async () => {
const formData = getFormData(AppConne... | No issues found. | params: {
projectId
}
});
return null;
}
return {
connectionId,
returnUrl,
appConnectionName: formData.app,
projectId,
connection
};
}, []);
const handleAzureDevOps = useCallback(async () => {
const formData = getFormData(AppConne... | @@ -12,6 +12,7 @@ import {
AzureKeyVaultConnectionMethod,
GitHubConnectionMethod,
GitLabConnectionMethod,
+ HerokuConnectionMethod,
TAppConnection,
useCreateAppConnection,
useUpdateAppConnection
@@ -28,7 +29,8 @@ const formDataStorageFieldMap: Partial<Record<AppConnection, string>> = {
[AppConnect... | frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix(app-connections): Migrate Heroku OAuth Connection to new OAuth connection format | 4,559 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/AppConnections/OauthCallbackPage/OauthCallbackPage.tsx
PR Title: fix(app-connections): Migrate Heroku OAuth Connection to new OAuth connection format
BEFORE CODE: params: {
projectId
}
});
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
environment,
projectId,
secretPath,
secretKey: key,
secretValue: value || "",
secretComment: "",
type: SecretType.Shared,
tagIds: tags?.map((el) => el.value)
});
closePopUp(PopUpNames.CreateSecretForm);
reset();
createNotification(... | No issues found. | environment,
projectId,
secretPath,
secretKey: key,
secretValue: value || "",
secretComment: "",
type: SecretType.Shared,
tagIds: tags?.map((el) => el.value)
});
closePopUp(PopUpNames.CreateSecretForm);
reset();
createNotification(... | @@ -1,12 +1,12 @@
import { ClipboardEvent, useRef } from "react";
import { Controller, useForm } from "react-hook-form";
-import { faTriangleExclamation } from "@fortawesome/free-solid-svg-icons";
+import { faTriangleExclamation, faWarning } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "... | frontend/src/pages/secret-manager/SecretDashboardPage/components/CreateSecretForm/CreateSecretForm.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: allow spaces in secret keys | 4,575 | Infisical/infisical | 22,351 | TypeScript | varonix0 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretDashboardPage/components/CreateSecretForm/CreateSecretForm.tsx
PR Title: fix: allow spaces in secret keys
BEFORE CODE: environment,
projectId,
secretPath,
secretKey: key,
secre... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
isDisabled={!secret?.secretValueHidden && currentProject.secretSharing}
>
<Button
isDisabled={secret?.secretValueHidden || !currentProject.secretSharing}
className="px-2 py-[0.43rem] font-... | No issues found. | isDisabled={!secret?.secretValueHidden && currentProject.secretSharing}
>
<Button
isDisabled={secret?.secretValueHidden || !currentProject.secretSharing}
className="px-2 py-[0.43rem] font-... | @@ -47,7 +47,8 @@ import {
ProjectPermissionActions,
ProjectPermissionSub,
useProject,
- useProjectPermission
+ useProjectPermission,
+ useSubscription
} from "@app/context";
import { ProjectPermissionSecretActions } from "@app/context/ProjectPermissionContext/types";
import { getProjectBaseURL } from "@... | frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: fixed broken access-list and update on k8s doc | 4,582 | Infisical/infisical | 22,351 | TypeScript | akhilmhdh | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
PR Title: feat: fixed broken access-list and update on k8s doc
BEFORE CODE: isDisabled={!secret?.secretValueHidden && currentP... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
})
},
preValidation: (req, res) =>
(
passport.authenticate("saml", {
failureRedirect: "/",
additionalParams: {
RelayState: JSON.stringify({
spInitiated: true,
callbackPort: req.query.callback_port ?? ""
})
}
... | No issues found. | })
},
preValidation: (req, res) =>
(
passport.authenticate("saml", {
failureRedirect: "/",
additionalParams: {
RelayState: JSON.stringify({
spInitiated: true,
callbackPort: req.query.callback_port ?? ""
})
}
... | @@ -286,7 +286,8 @@ export const registerSamlRouter = async (server: FastifyZodProvider) => {
entryPoint: z.string(),
issuer: z.string(),
cert: z.string(),
- lastUsed: z.date().nullable().optional()
+ lastUsed: z.date().nullable().optional(),
+ enableGroupSync... | backend/src/ee/routes/v1/saml-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Add SAML group mapping | 4,588 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/v1/saml-router.ts
PR Title: Add SAML group mapping
BEFORE CODE: })
},
preValidation: (req, res) =>
(
passport.authenticate("saml", {
failureRedirect: "/",
additionalParams: {
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
.filter(
({ name, provider }) =>
name.toLowerCase().includes(search.trim().toLowerCase()) ||
provider.toLowerCase().includes(search.trim().toLowerCase())
)
.sort((a, b) => {
if (a.provider === LogProvider.Custom) return 1;
if (b.provider === ... | No issues found. | .filter(
({ name, provider }) =>
name.toLowerCase().includes(search.trim().toLowerCase()) ||
provider.toLowerCase().includes(search.trim().toLowerCase())
)
.sort((a, b) => {
if (a.provider === LogProvider.Custom) return 1;
if (b.provider === ... | @@ -2,9 +2,10 @@ import { useMemo } from "react";
import { faSearch } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
+import { UpgradePlanModal } from "@app/components/license/UpgradePlanModal";
import { EmptyState, Spinner } from "@app/components/v2";
... | frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/components/LogStreamProviderSelect.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | add qradar as a preview option for log streams | 4,620 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/components/LogStreamProviderSelect.tsx
PR Title: add qradar as a preview option for log streams
BEFORE CODE: .filter(
({ name, provider }) =>
name.toLow... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
} else if (overrideAction) {
await handleSecretOperation("create", SecretType.Personal, oldKey, {
value: valueOverride
});
personalAction = true;
}
// shared secret change
if (!isSharedSecUnchanged && !personalAction) {
if (isBatchMode... | No issues found. | } else if (overrideAction) {
await handleSecretOperation("create", SecretType.Personal, oldKey, {
value: valueOverride
});
personalAction = true;
}
// shared secret change
if (!isSharedSecUnchanged && !personalAction) {
if (isBatchMode... | @@ -465,6 +465,22 @@ export const SecretListView = ({
[environment, secretPath, isProtectedBranch, isBatchMode, projectId, addPendingChange]
);
+ // Function to append newly created tag to the current secret
+ const append = useCallback(
+ (newTag: WsTag) => {
+ const currentSecret = popUp.createTag... | frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Fix: tag modal to create and add a tag to the secret. | 4,641 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretListView.tsx
PR Title: Fix: tag modal to create and add a tag to the secret.
BEFORE CODE: } else if (overrideAction) {
await handleSecretOperation("crea... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
secretDAL,
folderDAL,
integrationAuthService,
projectBotService,
integrationDAL,
secretImportDAL,
projectEnvDAL,
webhookDAL,
auditLogService,
userDAL,
projectMembershipDAL,
smtpService,
projectDAL,
projectBotDAL,
secretVersionDAL,
secretBlindIndexDAL,
... | No issues found. | secretDAL,
folderDAL,
integrationAuthService,
projectBotService,
integrationDAL,
secretImportDAL,
projectEnvDAL,
webhookDAL,
auditLogService,
userDAL,
projectMembershipDAL,
smtpService,
projectDAL,
projectBotDAL,
secretVersionDAL,
secretBlindIndexDAL,
... | @@ -186,6 +186,7 @@ import { folderTreeCheckpointDALFactory } from "@app/services/folder-tree-checkp
import { folderTreeCheckpointResourcesDALFactory } from "@app/services/folder-tree-checkpoint-resources/folder-tree-checkpoint-resources-dal";
import { groupProjectDALFactory } from "@app/services/group-project/group-... | backend/src/server/routes/index.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | move health alert to queue | 4,661 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/index.ts
PR Title: move health alert to queue
BEFORE CODE: secretDAL,
folderDAL,
integrationAuthService,
projectBotService,
integrationDAL,
secretImportDAL,
projectEnvDAL,
webhookDAL,
auditLogSe... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Number(port.trim()) };
}),
REDIS_READ_REPLICAS: data.REDIS_READ_REPLICAS?.trim()
?.split(",")
.map((el) => {
const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Num... | No issues found. | const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Number(port.trim()) };
}),
REDIS_READ_REPLICAS: data.REDIS_READ_REPLICAS?.trim()
?.split(",")
.map((el) => {
const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Num... | @@ -3,13 +3,13 @@ import { z } from "zod";
import { THsmServiceFactory } from "@app/ee/services/hsm/hsm-service";
import { crypto } from "@app/lib/crypto/cryptography";
import { QueueWorkerProfile } from "@app/lib/types";
+import { TKmsRootConfigDALFactory } from "@app/services/kms/kms-root-config-dal";
import { TS... | backend/src/lib/config/env.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(pam): ui improvements | 4,691 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/lib/config/env.ts
PR Title: feat(pam): ui improvements
BEFORE CODE: const [host, port] = el.trim().split(":");
return { host: host.trim(), port: Number(port.trim()) };
}),
REDIS_READ_REPLICAS: data.REDIS_READ_REPLICAS?... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
import slugify from "@sindresorhus/slugify";
import { z } from "zod";
import { CharacterType, characterValidator } from "@app/lib/validator/validate-string";
interface SlugSchemaInputs {
min?: number;
max?: number;
field?: string;
}
export const slugSchema = ({ min = 1, max = 64, field = "Slug" }: SlugSchemaIn... | No issues found. | import slugify from "@sindresorhus/slugify";
import { z } from "zod";
import { CharacterType, characterValidator } from "@app/lib/validator/validate-string";
interface SlugSchemaInputs {
min?: number;
max?: number;
field?: string;
}
export const slugSchema = ({ min = 1, max = 64, field = "Slug" }: SlugSchemaIn... | @@ -43,6 +43,6 @@ export const GenericResourceNameSchema = z
export const BaseSecretNameSchema = z.string().trim().min(1);
export const SecretNameSchema = BaseSecretNameSchema.refine(
- (el) => !el.includes(":"),
- "Secret name cannot contain colon."
-).refine((el) => !el.includes("/"), "Secret name cannot contai... | backend/src/server/lib/schemas.ts | 0 | TypeScript | 1 | none | 16 | 49 | 49 | true | fix: validate secret names before import | 4,737 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | Review this pull request change.
Language: TypeScript
File: backend/src/server/lib/schemas.ts
PR Title: fix: validate secret names before import
BEFORE CODE: import slugify from "@sindresorhus/slugify";
import { z } from "zod";
import { CharacterType, characterValidator } from "@app/lib/validator/validate-string";... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const [isLoading, setIsLoading] = useState(false);
const handleToggle = async (state: boolean) => {
setIsLoading(true);
try {
if (!currentOrg?.id) {
setIsLoading(false);
return;
}
await updateOrg({
orgId: currentOrg.id,
blockDuplicateSecretSyncDestinatio... | No issues found. |
const [isLoading, setIsLoading] = useState(false);
const handleToggle = async (state: boolean) => {
setIsLoading(true);
try {
if (!currentOrg?.id) {
setIsLoading(false);
return;
}
await updateOrg({
orgId: currentOrg.id,
blockDuplicateSecretSyncDestinatio... | @@ -0,0 +1,72 @@
+import { useState } from "react";
+
+import { createNotification } from "@app/components/notifications";
+import { OrgPermissionCan } from "@app/components/permissions";
+import { Switch } from "@app/components/v2";
+import { OrgPermissionActions, OrgPermissionSubjects, useOrganization } from "@app/co... | frontend/src/pages/organization/SettingsPage/components/OrgProductSettingsTab/OrgProductSettingsTab.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Add org option to block duplicate destinations on secret syncs | 4,746 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/OrgProductSettingsTab/OrgProductSettingsTab.tsx
PR Title: Add org option to block duplicate destinations on secret syncs
BEFORE CODE:
const [isLoading, setIsLoading] = useState(false);
const han... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// -> initialize empty SAML SSO configuration
await createMutateAsync({
organizationId: currentOrg.id,
authProvider: "okta-saml",
isActive: false,
entryPoint: "",
issuer: "",
cert: ""
});
}
handlePopUp... | No issues found. | // -> initialize empty SAML SSO configuration
await createMutateAsync({
organizationId: currentOrg.id,
authProvider: "okta-saml",
isActive: false,
entryPoint: "",
issuer: "",
cert: ""
});
}
handlePopUp... | @@ -27,7 +27,7 @@ export const OrgSSOSection = (): JSX.Element => {
const { mutateAsync } = useUpdateSSOConfig();
const { popUp, handlePopUpOpen, handlePopUpClose, handlePopUpToggle } = usePopUp([
"upgradePlan",
- "upgradeEnterprisePlan",
+ // "upgradeEnterprisePlan",
"addSSO"
] as const);
@@... | frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgSSOSection.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: Pro/Enterprise plan clarification in ui popup | 4,757 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/SettingsPage/components/OrgSsoTab/OrgSSOSection.tsx
PR Title: fix: Pro/Enterprise plan clarification in ui popup
BEFORE CODE: // -> initialize empty SAML SSO configuration
await createMutateAsync({
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
{
children,
title,
subTitle,
className,
overlayClassName,
footerContent,
bodyClassName,
onClose,
showCloseButton = true,
...props
},
forwardedRef
) => (
<DialogPrimitive.Portal>
<DialogPrimitive.Overlay
className={twMerge("anima... | No issues found. | {
children,
title,
subTitle,
className,
overlayClassName,
footerContent,
bodyClassName,
onClose,
showCloseButton = true,
...props
},
forwardedRef
) => (
<DialogPrimitive.Portal>
<DialogPrimitive.Overlay
className={twMerge("anima... | @@ -14,6 +14,7 @@ export type ModalContentProps = Omit<DialogPrimitive.DialogContentProps, "title"
bodyClassName?: string;
onClose?: () => void;
overlayClassName?: string;
+ showCloseButton?: boolean;
};
export const ModalContent = forwardRef<HTMLDivElement, ModalContentProps>(
@@ -27,6 +28,7 @@ export co... | frontend/src/components/v2/Modal/Modal.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [ENG-3937] fix: makes upgrade license modal intrusive | 4,772 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/components/v2/Modal/Modal.tsx
PR Title: [ENG-3937] fix: makes upgrade license modal intrusive
BEFORE CODE: {
children,
title,
subTitle,
className,
overlayClassName,
footerContent,
bodyClassName,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
return object;
}
});
server.route({
method: "POST",
url: "/destroy",
config: {
rateLimit: writeLimit
},
schema: {
description: "KMIP endpoint for destroying managed objects",
body: z.object({
id: z.string()
}),
response: {
200: z.object({... | No issues found. |
return object;
}
});
server.route({
method: "POST",
url: "/destroy",
config: {
rateLimit: writeLimit
},
schema: {
description: "KMIP endpoint for destroying managed objects",
body: z.object({
id: z.string()
}),
response: {
200: z.object({... | @@ -182,7 +182,8 @@ export const registerKmipSpecRouter = async (server: FastifyZodProvider) => {
algorithm: z.string(),
isActive: z.boolean(),
createdAt: z.date(),
- updatedAt: z.date()
+ updatedAt: z.date(),
+ kmipMetadata: z.record(z.any()).nullish()
... | backend/src/ee/routes/v1/kmip-spec-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | misc: add kmip metadata to the other kmip routes | 4,775 | Infisical/infisical | 22,351 | TypeScript | sheensantoscapadngan | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/v1/kmip-spec-router.ts
PR Title: misc: add kmip metadata to the other kmip routes
BEFORE CODE:
return object;
}
});
server.route({
method: "POST",
url: "/destroy",
config: {
rateLimit: writeLimit
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
<div className="flex gap-2">
<Input
value={search}
onChange={(e) => {
const newSearch = e.target.value;
setSearch(newSearch);
}}
leftIcon={<FontAwesomeIcon icon={faMagnifyingGlass} />}
placeholder="Search logs..."
classNam... | No issues found. | <div className="flex gap-2">
<Input
value={search}
onChange={(e) => {
const newSearch = e.target.value;
setSearch(newSearch);
}}
leftIcon={<FontAwesomeIcon icon={faMagnifyingGlass} />}
placeholder="Search logs..."
classNam... | @@ -1,51 +1,88 @@
-import { useState } from "react";
-import { faChevronDown, faChevronRight } from "@fortawesome/free-solid-svg-icons";
+import { useMemo, useState } from "react";
+import { faChevronRight, faMagnifyingGlass } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/reac... | frontend/src/pages/pam/PamSessionsByIDPage/components/PamSessionLogsSection.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Improve PAM Session Logs | 4,794 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/pam/PamSessionsByIDPage/components/PamSessionLogsSection.tsx
PR Title: Improve PAM Session Logs
BEFORE CODE: <div className="flex gap-2">
<Input
value={search}
onChange={(e) => {
const newSea... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
}
const [doc] = await folderDAL.delete(
{
envId: env.id,
id: folderToDelete.id,
parentId: parentFolder.id,
isReserved: false
},
tx
);
const folderVersions = await folderVersionDAL.findLatestFolderVersions([doc.id], tx);
awa... | No issues found. | }
const [doc] = await folderDAL.delete(
{
envId: env.id,
id: folderToDelete.id,
parentId: parentFolder.id,
isReserved: false
},
tx
);
const folderVersions = await folderVersionDAL.findLatestFolderVersions([doc.id], tx);
awa... | @@ -14,6 +14,7 @@ import { PgSqlLock } from "@app/keystore/keystore";
import { BadRequestError, NotFoundError } from "@app/lib/errors";
import { OrderByDirection, OrgServiceActor } from "@app/lib/types";
import { ActorType } from "@app/services/auth/auth-type";
+import { SecretsOrderBy } from "@app/services/secret/s... | backend/src/services/secret-folder/secret-folder-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [ENG-4074] fix: folder name sorting | 4,797 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/services/secret-folder/secret-folder-service.ts
PR Title: [ENG-4074] fix: folder name sorting
BEFORE CODE: }
const [doc] = await folderDAL.delete(
{
envId: env.id,
id: folderToDelete.id,
parent... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
}: {
host: string;
relayPkiServerCaCertificate: Buffer;
relayPkiServerCaPrivateKey: Buffer;
relayPkiClientCaCertificateChain: Buffer;
relayPkiClientCaCertificate: Buffer;
relaySshServerCaPrivateKey: Buffer;
relaySshClientCaPublicKey: Buffer;
orgId?: string;
}) => {
const alg = ke... | No issues found. | }: {
host: string;
relayPkiServerCaCertificate: Buffer;
relayPkiServerCaPrivateKey: Buffer;
relayPkiClientCaCertificateChain: Buffer;
relayPkiClientCaCertificate: Buffer;
relaySshServerCaPrivateKey: Buffer;
relaySshClientCaPublicKey: Buffer;
orgId?: string;
}) => {
const alg = ke... | @@ -3,7 +3,7 @@ import { isIP } from "node:net";
import { ForbiddenError } from "@casl/ability";
import * as x509 from "@peculiar/x509";
-import { OrganizationActionScope, OrgMembershipRole, TRelays } from "@app/db/schemas";
+import { OrganizationActionScope, OrgMembershipRole, OrgMembershipStatus, TRelays } from "... | backend/src/ee/services/relay/relay-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | don't notify "invited" admins about health alerts | 4,799 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/relay/relay-service.ts
PR Title: don't notify "invited" admins about health alerts
BEFORE CODE: }: {
host: string;
relayPkiServerCaCertificate: Buffer;
relayPkiServerCaPrivateKey: Buffer;
relayPkiClientCaCertificat... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
// akhilmhdh: Dont remove this br. I am still clueless how this works but weirdly enough
// when break is added a line break works properly
return formattedContent.concat(
<br key={`secret-value-linebreak-${formattedContent.length + 1}`} />
);
};
type Props = TextareaHTMLAttributes<HTMLTextAreaElement> & {... | No issues found. | // akhilmhdh: Dont remove this br. I am still clueless how this works but weirdly enough
// when break is added a line break works properly
return formattedContent.concat(
<br key={`secret-value-linebreak-${formattedContent.length + 1}`} />
);
};
type Props = TextareaHTMLAttributes<HTMLTextAreaElement> & {... | @@ -1,18 +1,22 @@
/* eslint-disable react/no-danger */
-import { forwardRef, TextareaHTMLAttributes } from "react";
+import { forwardRef, TextareaHTMLAttributes, useEffect, useState } from "react";
import { twMerge } from "tailwind-merge";
import { useToggle } from "@app/hooks";
import { HIDDEN_SECRET_VALUE } fro... | frontend/src/components/v2/SecretInput/SecretInput.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feature: secret reference shortcut | 4,804 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | Review this pull request change.
Language: TypeScript
File: frontend/src/components/v2/SecretInput/SecretInput.tsx
PR Title: feature: secret reference shortcut
BEFORE CODE: // akhilmhdh: Dont remove this br. I am still clueless how this works but weirdly enough
// when break is added a line break works properly... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
<Th className="w-64">Last Updated At</Th>
<Th />
</Tr>
</THead>
<TBody>
{isPending && <TableSkeleton columns={4} innerKey="project-cert-templates" />}
{!isPending &&
data?.ce... | No issues found. | <Th className="w-64">Last Updated At</Th>
<Th />
</Tr>
</THead>
<TBody>
{isPending && <TableSkeleton columns={4} innerKey="project-cert-templates" />}
{!isPending &&
data?.ce... | @@ -5,6 +5,7 @@ import {
faCertificate,
faCog,
faEllipsis,
+ faFileContract,
faPencil,
faPlus,
faTrash
@@ -40,6 +41,7 @@ import {
Tr
} from "@app/components/v2";
import {
+ ProjectPermissionCertificateActions,
ProjectPermissionPkiTemplateActions,
ProjectPermissionSub,
useProject,
@@ -5... | frontend/src/pages/cert-manager/PkiTemplateListPage/PkiTemplateListPage.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Add new option on legacy templates to issue new certificates | 4,819 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/cert-manager/PkiTemplateListPage/PkiTemplateListPage.tsx
PR Title: Add new option on legacy templates to issue new certificates
BEFORE CODE: <Th className="w-64">Last Updated At</Th>
<Th />
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
IntegrationUrls.AZURE_TOKEN_URL.replace("common", tenantId || "common"),
new URLSearchParams({
grant_type: "client_credentials",
scope: `https://graph.microsoft.com/.default`,
client_id: clientId,
client_secret: clientSecret
})
);
const update... | No issues found. | IntegrationUrls.AZURE_TOKEN_URL.replace("common", tenantId || "common"),
new URLSearchParams({
grant_type: "client_credentials",
scope: `https://graph.microsoft.com/.default`,
client_id: clientId,
client_secret: clientSecret
})
);
const update... | @@ -1,9 +1,14 @@
/* eslint-disable no-case-declarations */
import { AxiosError, AxiosResponse } from "axios";
+import type { KeyObject } from "crypto";
+import RE2 from "re2";
+import { v4 as uuidv4 } from "uuid";
import { getConfig } from "@app/lib/config/env";
import { request } from "@app/lib/config/request";
... | backend/src/services/app-connection/azure-client-secrets/azure-client-secrets-connection-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat(app-connections/azure-client-secrets): certificate auth | 4,820 | Infisical/infisical | 22,351 | TypeScript | varonix0 | Review this pull request change.
Language: TypeScript
File: backend/src/services/app-connection/azure-client-secrets/azure-client-secrets-connection-fns.ts
PR Title: feat(app-connections/azure-client-secrets): certificate auth
BEFORE CODE: IntegrationUrls.AZURE_TOKEN_URL.replace("common", tenantId || "commo... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
)}
</OrgPermissionCan>
)}
<div className="grid grid-cols-2 items-center gap-2">
<Controller
name="method"
control={control}
render={({ field: { value, onChange }, fieldState: { error } }) => (
<FormControl
... | No issues found. | )}
</OrgPermissionCan>
)}
<div className="grid grid-cols-2 items-center gap-2">
<Controller
name="method"
control={control}
render={({ field: { value, onChange }, fieldState: { error } }) => (
<FormControl
... | @@ -4,8 +4,10 @@ import { faQuestionCircle } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { Tab } from "@headlessui/react";
import { zodResolver } from "@hookform/resolvers/zod";
+import { useQuery } from "@tanstack/react-query";
import { z } fro... | frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionForm.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feature: ldap gateway support | 4,825 | Infisical/infisical | 22,351 | TypeScript | victorvhs017 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionForm.tsx
PR Title: feature: ldap gateway support
BEFORE CODE: )}
</OrgPermissionCan>
)}
<div className="grid ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
resourceMetadataDAL,
folderCommitService,
secretSyncQueue,
reminderService,
eventBusService,
licenseService,
membershipRoleDAL,
membershipUserDAL
});
const projectService = projectServiceFactory({
permissionService,
projectDAL,
projectSshConfigDAL,
secretDAL,
sec... | No issues found. | resourceMetadataDAL,
folderCommitService,
secretSyncQueue,
reminderService,
eventBusService,
licenseService,
membershipRoleDAL,
membershipUserDAL
});
const projectService = projectServiceFactory({
permissionService,
projectDAL,
projectSshConfigDAL,
secretDAL,
sec... | @@ -17,30 +17,30 @@ import { accessApprovalRequestDALFactory } from "@app/ee/services/access-approva
import { accessApprovalRequestReviewerDALFactory } from "@app/ee/services/access-approval-request/access-approval-request-reviewer-dal";
import { accessApprovalRequestServiceFactory } from "@app/ee/services/access-app... | backend/src/server/routes/index.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | misc: endpoint for fetching latest active bundle of profile | 4,833 | Infisical/infisical | 22,351 | TypeScript | sheensantoscapadngan | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/index.ts
PR Title: misc: endpoint for fetching latest active bundle of profile
BEFORE CODE: resourceMetadataDAL,
folderCommitService,
secretSyncQueue,
reminderService,
eventBusService,
licenseService,
m... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
(mockCertificateProfileDAL.findBySlugAndProjectId as any).mockResolvedValue(sampleProfile);
const result = await service.getProfileBySlug({
...mockActor,
projectId: "project-123",
slug: "test-profile"
});
expect(result).toEqual(sampleProfile);
expect(mockCertifica... | No issues found. | (mockCertificateProfileDAL.findBySlugAndProjectId as any).mockResolvedValue(sampleProfile);
const result = await service.getProfileBySlug({
...mockActor,
projectId: "project-123",
slug: "test-profile"
});
expect(result).toEqual(sampleProfile);
expect(mockCertifica... | @@ -6,14 +6,15 @@ import { ForbiddenError } from "@casl/ability";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
-import { ForbiddenRequestError, NotFoundError } from "@app/lib/errors";
... | backend/src/services/certificate-profile/certificate-profile-service.test.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [PKI-34] Add license check for PKI ACME feature | 4,848 | Infisical/infisical | 22,351 | TypeScript | fangpenlin | Review this pull request change.
Language: TypeScript
File: backend/src/services/certificate-profile/certificate-profile-service.test.ts
PR Title: [PKI-34] Add license check for PKI ACME feature
BEFORE CODE: (mockCertificateProfileDAL.findBySlugAndProjectId as any).mockResolvedValue(sampleProfile);
con... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
OrgPermissionSubjects.Identity
),
details: { missingPermissions: permissionBoundary.missingPermissions }
});
}
const revokedIdentityTokenAuth = await identityTokenAuthDAL.transaction(async (tx) => {
const deletedTokenAuth = await identityTokenAuthDAL.delete({ ident... | No issues found. | OrgPermissionSubjects.Identity
),
details: { missingPermissions: permissionBoundary.missingPermissions }
});
}
const revokedIdentityTokenAuth = await identityTokenAuthDAL.transaction(async (tx) => {
const deletedTokenAuth = await identityTokenAuthDAL.delete({ ident... | @@ -38,6 +38,7 @@ import {
TAttachTokenAuthDTO,
TCreateTokenAuthTokenDTO,
TGetTokenAuthDTO,
+ TGetTokenAuthTokenByIdDTO,
TGetTokenAuthTokensDTO,
TRevokeTokenAuthDTO,
TRevokeTokenAuthTokenDTO,
@@ -618,6 +619,52 @@ export const identityTokenAuthServiceFactory = ({
return { tokens, identityMembersh... | backend/src/services/identity-token-auth/identity-token-auth-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [ENG-4142] feat: adds GET endpoint for single auth token by ID | 4,858 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/services/identity-token-auth/identity-token-auth-service.ts
PR Title: [ENG-4142] feat: adds GET endpoint for single auth token by ID
BEFORE CODE: OrgPermissionSubjects.Identity
),
details: { missingPermissions: p... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
};
export const SecretContainer = ({ secret, secretKey: key }: Props) => {
const [isVisible, setIsVisible] = useToggle(false);
const [, isCopyingSecret, setCopyTextSecret] = useTimedReset<string>({
initialState: "Copy to clipboard"
});
const decryptedSecret = useMemo(() => {
if (secret.secretValue) {
... | No issues found. | };
export const SecretContainer = ({ secret, secretKey: key }: Props) => {
const [isVisible, setIsVisible] = useToggle(false);
const [, isCopyingSecret, setCopyTextSecret] = useTimedReset<string>({
initialState: "Copy to clipboard"
});
const decryptedSecret = useMemo(() => {
if (secret.secretValue) {
... | @@ -13,6 +13,8 @@ import { Button, IconButton } from "@app/components/v2";
import { useTimedReset, useToggle } from "@app/hooks";
import { TViewSharedSecretResponse } from "@app/hooks/api/secretSharing";
+import { SecretShareInfo } from "./SecretShareInfo";
+
type Props = {
secret: TViewSharedSecretResponse["se... | frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [PLATFRM-87] feat: adds secret sharing validity info | 4,864 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/public/ViewSharedSecretByIDPage/components/SecretContainer.tsx
PR Title: [PLATFRM-87] feat: adds secret sharing validity info
BEFORE CODE: };
export const SecretContainer = ({ secret, secretKey: key }: Props) => {
const [isVisible, se... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
decodedToken.authMethod !== AuthMethod.OIDC &&
!(selectedOrg.bypassOrgAuthEnabled && selectedOrgMembership.userRole === OrgMembershipRole.Admin)
) {
throw new BadRequestError({
message: "Login with the auth method required by your organization."
});
}
if (selectedOrg.googleS... | No issues found. | decodedToken.authMethod !== AuthMethod.OIDC &&
!(selectedOrg.bypassOrgAuthEnabled && selectedOrgMembership.userRole === OrgMembershipRole.Admin)
) {
throw new BadRequestError({
message: "Login with the auth method required by your organization."
});
}
if (selectedOrg.googleS... | @@ -454,6 +454,30 @@ export const authLoginServiceFactory = ({
});
}
+ if (organizationId) {
+ await auditLogService.createAuditLog({
+ orgId: organizationId,
+ ipAddress: ip,
+ userAgent,
+ userAgentType: getUserAgentType(userAgent),
+ actor: {... | backend/src/services/auth/auth-login-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Add user login and select organization audit logs | 4,865 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/auth/auth-login-service.ts
PR Title: Add user login and select organization audit logs
BEFORE CODE: decodedToken.authMethod !== AuthMethod.OIDC &&
!(selectedOrg.bypassOrgAuthEnabled && selectedOrgMembership.userRole === Org... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
auditLogs: false,
auditLogsRetentionDays: 0,
auditLogStreams: false,
auditLogStreamLimit: 3,
samlSSO: false,
enforceGoogleSSO: false,
hsm: false,
oidcSSO: false,
scim: false,
ldap: false,
groups: false,
status: null,
trial_end: null,
has_used_trial: true,
secretApproval: false,
secretRot... | No issues found. | auditLogs: false,
auditLogsRetentionDays: 0,
auditLogStreams: false,
auditLogStreamLimit: 3,
samlSSO: false,
enforceGoogleSSO: false,
hsm: false,
oidcSSO: false,
scim: false,
ldap: false,
groups: false,
status: null,
trial_end: null,
has_used_trial: true,
secretApproval: false,
secretRot... | @@ -1,13 +1,56 @@
import axios, { AxiosError } from "axios";
import { TLicenseServiceFactory } from "@app/ee/services/license/license-service";
-import { getConfig } from "@app/lib/config/env";
+import { getConfig, TEnvConfig } from "@app/lib/config/env";
import { request } from "@app/lib/config/request";
import ... | backend/src/ee/services/license/license-fns.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [ENG-4019] chore: unify license key env variables | 4,868 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/license/license-fns.ts
PR Title: [ENG-4019] chore: unify license key env variables
BEFORE CODE: auditLogs: false,
auditLogsRetentionDays: 0,
auditLogStreams: false,
auditLogStreamLimit: 3,
samlSSO: false,
enforceGoogleSS... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
if (appCfg.NODE_ENV === "production" || !appCfg.isBddNockApiEnabled) {
throw new ForbiddenRequestError({ message: "BDD Nock API is not enabled" });
}
};
server.route({
method: "POST",
url: "/define",
schema: {
body: z.object({ definitions: z.unknown().array() }),
response: {
... | No issues found. | if (appCfg.NODE_ENV === "production" || !appCfg.isBddNockApiEnabled) {
throw new ForbiddenRequestError({ message: "BDD Nock API is not enabled" });
}
};
server.route({
method: "POST",
url: "/define",
schema: {
body: z.object({ definitions: z.unknown().array() }),
response: {
... | @@ -0,0 +1,104 @@
+import type { Definition } from "nock";
+import { z } from "zod";
+
+import { getConfig } from "@app/lib/config/env";
+import { ForbiddenRequestError } from "@app/lib/errors";
+import { logger } from "@app/lib/logger";
+import { verifyAuth } from "@app/server/plugins/auth/verify-auth";
+import { Auth... | backend/src/server/routes/bdd/bdd-nock-router.dev.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | Move nock to dev deps and include the route only for dev/test builds | 4,874 | Infisical/infisical | 22,351 | TypeScript | fangpenlin | Review this pull request change.
Language: TypeScript
File: backend/src/server/routes/bdd/bdd-nock-router.dev.ts
PR Title: Move nock to dev deps and include the route only for dev/test builds
BEFORE CODE: if (appCfg.NODE_ENV === "production" || !appCfg.isBddNockApiEnabled) {
throw new ForbiddenRequestErro... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
isRotationDevelopmentMode:
(data.NODE_ENV === "development" && data.ROTATION_DEVELOPMENT_MODE) || data.NODE_ENV === "test",
isDailyResourceCleanUpDevelopmentMode:
data.NODE_ENV === "development" && data.DAILY_RESOURCE_CLEAN_UP_DEVELOPMENT_MODE,
isAcmeDevelopmentMode: data.NODE_ENV === "developme... | No issues found. | isRotationDevelopmentMode:
(data.NODE_ENV === "development" && data.ROTATION_DEVELOPMENT_MODE) || data.NODE_ENV === "test",
isDailyResourceCleanUpDevelopmentMode:
data.NODE_ENV === "development" && data.DAILY_RESOURCE_CLEAN_UP_DEVELOPMENT_MODE,
isAcmeDevelopmentMode: data.NODE_ENV === "developme... | @@ -391,6 +391,9 @@ const envSchema = z
})
),
+ /* OracleDB ----------------------------------------------------------------------------- */
+ TNS_ADMIN: zpStr(z.string().optional()),
+
/* INTERNAL ----------------------------------------------------------------------------- */
INTERNAL_... | backend/src/lib/config/env.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feature(oracle): allow usage of wallet for oracleDB on self hosted instances | 4,879 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/lib/config/env.ts
PR Title: feature(oracle): allow usage of wallet for oracleDB on self hosted instances
BEFORE CODE: isRotationDevelopmentMode:
(data.NODE_ENV === "development" && data.ROTATION_DEVELOPMENT_MODE) || data.NODE_ENV === ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
})
}
},
onRequest: verifyAuth([AuthMode.IDENTITY_ACCESS_TOKEN]),
handler: async (req) => {
const { session, projectId } = await server.services.pamSession.updateLogsById(
{
sessionId: req.params.sessionId,
logs: req.body.logs
},
req.permission
... | No issues found. | })
}
},
onRequest: verifyAuth([AuthMode.IDENTITY_ACCESS_TOKEN]),
handler: async (req) => {
const { session, projectId } = await server.services.pamSession.updateLogsById(
{
sessionId: req.params.sessionId,
logs: req.body.logs
},
req.permission
... | @@ -41,24 +41,37 @@ export const registerPamSessionRouter = async (server: FastifyZodProvider) => {
},
onRequest: verifyAuth([AuthMode.IDENTITY_ACCESS_TOKEN]),
handler: async (req) => {
- const { credentials, projectId, account } = await server.services.pamAccount.getSessionCredentials(
- req... | backend/src/ee/routes/v1/pam-session-router.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | pam: allow account credentials to be fetched more than once | 4,905 | Infisical/infisical | 22,351 | TypeScript | x032205 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/routes/v1/pam-session-router.ts
PR Title: pam: allow account credentials to be fetched more than once
BEFORE CODE: })
}
},
onRequest: verifyAuth([AuthMode.IDENTITY_ACCESS_TOKEN]),
handler: async (req) => {
con... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
<InfisicalSecretInput
isLoadingValue={isLoadingSecretValue}
isErrorLoadingValue={isErrorFetchingSecretValue}
isReadOnly={isReadOnlySecret}
key="secret-value"
isVisible={isVisible && (!secret... | No issues found. | <InfisicalSecretInput
isLoadingValue={isLoadingSecretValue}
isErrorLoadingValue={isErrorFetchingSecretValue}
isReadOnly={isReadOnlySecret}
key="secret-value"
isVisible={isVisible && (!secret... | @@ -47,13 +47,9 @@ import { faEyeSlash, faKey, faRotate, faWarning } from "@fortawesome/free-solid-
import { PendingAction } from "@app/hooks/api/secretFolders/types";
import { format } from "date-fns";
import { CreateReminderForm } from "@app/pages/secret-manager/SecretDashboardPage/components/SecretListView/Create... | frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: copy secret audit log | 4,928 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretItem.tsx
PR Title: fix: copy secret audit log
BEFORE CODE: <InfisicalSecretInput
isLoadingValue={isLoadingSecretValue}
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const { permission } = await permissionService.getOrgPermission({
actor: actor.type,
actorId: actor.id,
orgId: projectTemplate.orgId,
actorAuthMethod: actor.authMethod,
actorOrgId: actor.orgId,
scope: OrganizationActionScope.Any
});
ForbiddenError.from(permission).throwU... | No issues found. | const { permission } = await permissionService.getOrgPermission({
actor: actor.type,
actorId: actor.id,
orgId: projectTemplate.orgId,
actorAuthMethod: actor.authMethod,
actorOrgId: actor.orgId,
scope: OrganizationActionScope.Any
});
ForbiddenError.from(permission).throwU... | @@ -189,11 +189,15 @@ export const projectTemplateServiceFactory = ({
message: `A project template with the name "${params.name}" already exists.`
});
+ const projectTemplateEnvironments =
+ type === ProjectType.SecretManager && environments === undefined
+ ? ProjectTemplateDefaultEnvir... | backend/src/ee/services/project-template/project-template-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | [ENG-4227] fix: makes environments optional in project template | 4,938 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/project-template/project-template-service.ts
PR Title: [ENG-4227] fix: makes environments optional in project template
BEFORE CODE: const { permission } = await permissionService.getOrgPermission({
actor: actor.type,
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
/**
* Create and initialize a new project in organization with id [organizationId]
* Note: current user should be a member of the organization
*/
export const initProjectHelper = async ({ projectName }: { projectName: string }) => {
// create new project
const {
data: { project }
} = await createWorkspace(... | No issues found. | /**
* Create and initialize a new project in organization with id [organizationId]
* Note: current user should be a member of the organization
*/
export const initProjectHelper = async ({ projectName }: { projectName: string }) => {
// create new project
const {
data: { project }
} = await createWorkspace(... | @@ -14,11 +14,6 @@ const secretsToBeAdded = [
secretValue: "OVERRIDE_THIS",
secretComment: "Override secrets with personal value"
},
- {
- secretKey: "DB_PASSWORD",
- secretValue: "OVERRIDE_THIS",
- secretComment: "Another secret override"
- },
{
secretKey: "DB_PASSWORD",
secretValu... | frontend/src/helpers/project.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: default duplicate secret deletion | 4,939 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: frontend/src/helpers/project.ts
PR Title: fix: default duplicate secret deletion
BEFORE CODE: /**
* Create and initialize a new project in organization with id [organizationId]
* Note: current user should be a member of the organization
*/
export const ... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
);
await membershipUserDAL.updateById(
membership.id,
{
isActive: active
},
tx
);
await userDAL.updateById(
membership.actorUserId!,
{
firstName,
email: email?.toLowerCase(),
lastName,
isEmailVerif... | No issues found. | );
await membershipUserDAL.updateById(
membership.id,
{
isActive: active
},
tx
);
await userDAL.updateById(
membership.actorUserId!,
{
firstName,
email: email?.toLowerCase(),
lastName,
isEmailVerif... | @@ -19,6 +19,7 @@ import { TScimDALFactory } from "@app/ee/services/scim/scim-dal";
import { getConfig } from "@app/lib/config/env";
import { crypto } from "@app/lib/crypto";
import { BadRequestError, NotFoundError, ScimRequestError, UnauthorizedError } from "@app/lib/errors";
+import { logger } from "@app/lib/logge... | backend/src/ee/services/scim/scim-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | feat: adds expiring scim token notification | 4,953 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/scim/scim-service.ts
PR Title: feat: adds expiring scim token notification
BEFORE CODE: );
await membershipUserDAL.updateById(
membership.id,
{
isActive: active
},
tx
);
... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
const wsIdentityIds = new Map();
identityMemberships?.forEach((identityMembership) => {
wsIdentityIds.set(identityMembership.identity.id, true);
});
return (identityMembershipOrgs || []).filter((i) => !wsIdentityIds.has(i.id));
}, [identityMembershipOrgs, identityMemberships]);
const {
... | No issues found. | const wsIdentityIds = new Map();
identityMemberships?.forEach((identityMembership) => {
wsIdentityIds.set(identityMembership.identity.id, true);
});
return (identityMembershipOrgs || []).filter((i) => !wsIdentityIds.has(i.id));
}, [identityMembershipOrgs, identityMemberships]);
const {
... | @@ -5,7 +5,7 @@ import { useQuery } from "@tanstack/react-query";
import { z } from "zod";
import { createNotification } from "@app/components/notifications";
-import { Button, FilterableSelect, FormControl, ModalClose, Spinner } from "@app/components/v2";
+import { Button, FilterableSelect, FormControl, ModalClose... | frontend/src/pages/project/AccessControlPage/components/IdentityTab/components/ProjectLinkIdentityModal.tsx | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | improvement(frontend): update project identity creation flow | 4,964 | Infisical/infisical | 22,351 | TypeScript | scott-ray-wilson | Review this pull request change.
Language: TypeScript
File: frontend/src/pages/project/AccessControlPage/components/IdentityTab/components/ProjectLinkIdentityModal.tsx
PR Title: improvement(frontend): update project identity creation flow
BEFORE CODE: const wsIdentityIds = new Map();
identityMemberships?.f... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
identityId: string;
accessTokenTTL: number;
accessTokenMaxTTL: number;
accessTokenNumUsesLimit: number;
accessTokenTrustedIps: { ipAddress: string }[];
isActorSuperAdmin?: boolean;
} & Omit<TProjectPermission, "projectId">;
export type TUpdateTokenAuthDTO = {
identityId: string;
accessTokenTTL?: number... | No issues found. | identityId: string;
accessTokenTTL: number;
accessTokenMaxTTL: number;
accessTokenNumUsesLimit: number;
accessTokenTrustedIps: { ipAddress: string }[];
isActorSuperAdmin?: boolean;
} & Omit<TProjectPermission, "projectId">;
export type TUpdateTokenAuthDTO = {
identityId: string;
accessTokenTTL?: number... | @@ -42,8 +42,6 @@ export type TGetTokenAuthTokensDTO = {
export type TGetTokenAuthTokenByIdDTO = {
tokenId: string;
- identityId: string;
- isActorSuperAdmin?: boolean;
} & Omit<TProjectPermission, "projectId">;
export type TUpdateTokenAuthTokenDTO = { | backend/src/services/identity-token-auth/identity-token-auth-types.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: get token auth token endpoint [ENG-4248] | 4,966 | Infisical/infisical | 22,351 | TypeScript | gupta-piyush19 | Review this pull request change.
Language: TypeScript
File: backend/src/services/identity-token-auth/identity-token-auth-types.ts
PR Title: fix: get token auth token endpoint [ENG-4248]
BEFORE CODE: identityId: string;
accessTokenTTL: number;
accessTokenMaxTTL: number;
accessTokenNumUsesLimit: number;
ac... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
context.vars["error"] = acme_client.new_account(registration)
except Exception as exp:
context.vars["error"] = exp
def send_raw_acme_req(context: Context, url: str):
acme_client = context.acme_client
content = json.loads(context.text)
protected = replace_vars(content["protected"], cont... | No issues found. | context.vars["error"] = acme_client.new_account(registration)
except Exception as exp:
context.vars["error"] = exp
def send_raw_acme_req(context: Context, url: str):
acme_client = context.acme_client
content = json.loads(context.text)
protected = replace_vars(content["protected"], cont... | @@ -20,6 +20,10 @@
from josepy import json_util
from cryptography.hazmat.primitives import serialization
from cryptography.hazmat.primitives.asymmetric import rsa
+from cryptography.hazmat.primitives.asymmetric import ec
+from cryptography.hazmat.primitives.asymmetric.types import (
+ CertificateIssuerPrivateKeyT... | backend/bdd/features/steps/pki_acme.py | 0 | Python | 1 | none | 16 | 51 | 51 | true | improvement(api): check template for external ca with acme | 4,967 | Infisical/infisical | 22,351 | TypeScript | fangpenlin | Review this pull request change.
Language: Python
File: backend/bdd/features/steps/pki_acme.py
PR Title: improvement(api): check template for external ca with acme
BEFORE CODE: context.vars["error"] = acme_client.new_account(registration)
except Exception as exp:
context.vars["error"] = exp
de... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
renewBeforeDays: finalRenewBeforeDays
});
}
const { permission } = await permissionService.getProjectPermission({
actor,
actorId,
projectId: profile.projectId,
actorAuthMethod,
actorOrgId,
actionProjectType: ActionProjectType.CertificateMana... | No issues found. | renewBeforeDays: finalRenewBeforeDays
});
}
const { permission } = await permissionService.getProjectPermission({
actor,
actorId,
projectId: profile.projectId,
actorAuthMethod,
actorOrgId,
actionProjectType: ActionProjectType.CertificateMana... | @@ -19,8 +19,10 @@ import { TCertificateBodyDALFactory } from "@app/services/certificate/certificat
import { TCertificateDALFactory } from "@app/services/certificate/certificate-dal";
import { TCertificateSecretDALFactory } from "@app/services/certificate/certificate-secret-dal";
import {
+ CertExtendedKeyUsage,
... | backend/src/services/certificate-v3/certificate-v3-service.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: renewals for internal CAs and minor improvement on the export certificate modal | 4,992 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/certificate-v3/certificate-v3-service.ts
PR Title: fix: renewals for internal CAs and minor improvement on the export certificate modal
BEFORE CODE: renewBeforeDays: finalRenewBeforeDays
});
}
const { per... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
permission: createMongoAbility<ProjectPermissionSet>([
{
action: ProjectPermissionCertificateActions.Read,
subject: ProjectPermissionSub.Certificates
}
])
};
const mockRequestWithoutCert = {
id: "550e8400-e29b-41d4-a716-446655440007",
... | No issues found. | permission: createMongoAbility<ProjectPermissionSet>([
{
action: ProjectPermissionCertificateActions.Read,
subject: ProjectPermissionSub.Certificates
}
])
};
const mockRequestWithoutCert = {
id: "550e8400-e29b-41d4-a716-446655440007",
... | @@ -258,7 +258,7 @@ describe("CertificateRequestService", () => {
(mockCertificateService.getCertBody as any).mockResolvedValue(mockCertBody);
(mockCertificateService.getCertPrivateKey as any).mockResolvedValue(mockPrivateKey);
- const result = await service.getCertificateFromRequest(mockGetData);
... | backend/src/services/certificate-request/certificate-request-service.test.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | fix: improvements on certificate request endpoint | 4,993 | Infisical/infisical | 22,351 | TypeScript | carlosmonastyrski | Review this pull request change.
Language: TypeScript
File: backend/src/services/certificate-request/certificate-request-service.test.ts
PR Title: fix: improvements on certificate request endpoint
BEFORE CODE: permission: createMongoAbility<ProjectPermissionSet>([
{
action: ProjectPerm... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. | |
db.ref("certificateId").withSchema(TableName.CertificateRequests).as("certificateId")
)
.forUpdate(TableName.PkiAcmeOrder)
.where(`${TableName.PkiAcmeOrder}.id`, id)
.first();
if (!order) {
return null;
}
const { certificateRequestId, certificateReques... | No issues found. | db.ref("certificateId").withSchema(TableName.CertificateRequests).as("certificateId")
)
.forUpdate(TableName.PkiAcmeOrder)
.where(`${TableName.PkiAcmeOrder}.id`, id)
.first();
if (!order) {
return null;
}
const { certificateRequestId, certificateReques... | @@ -4,6 +4,7 @@ import { TDbClient } from "@app/db";
import { TableName } from "@app/db/schemas";
import { DatabaseError } from "@app/lib/errors";
import { ormify, selectAllTableCols, sqlNestRelationships } from "@app/lib/knex";
+import { CertificateRequestStatus } from "@app/services/certificate-request/certificate... | backend/src/ee/services/pki-acme/pki-acme-order-dal.ts | 0 | TypeScript | 1 | none | 16 | 51 | 51 | true | improvement(api): issue cert from acme in a background queue | 5,003 | Infisical/infisical | 22,351 | TypeScript | fangpenlin | Review this pull request change.
Language: TypeScript
File: backend/src/ee/services/pki-acme/pki-acme-order-dal.ts
PR Title: improvement(api): issue cert from acme in a background queue
BEFORE CODE: db.ref("certificateId").withSchema(TableName.CertificateRequests).as("certificateId")
)
.fo... | No issues found. | You are an expert software engineer and code reviewer. Review pull requests carefully for correctness, bugs, security issues, performance problems, maintainability, and unnecessary complexity. Only raise actionable issues supported by the code. Explain why an issue matters and suggest a concrete fix when appropriate. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.