diff stringlengths 12 9.3k | message stringlengths 8 199 | reasoning_trace null | repo stringlengths 6 68 | license stringclasses 3
values | language stringclasses 16
values |
|---|---|---|---|---|---|
@@ -371,10 +371,9 @@ func TestSaveArtifacts(t *testing.T) {
}
func TestMonitorProgress(t *testing.T) {
- t.Skip("https://github.com/argoproj/argo-workflows/issues/7148")
deadline, ok := t.Deadline()
if !ok {
- deadline = time.Now().Add(30 * time.Second)
+ deadline = time.Now().Add(time.Second)
}
ctx, cancel := context.... | fix(test): Make TestMonitorProgress Faster | null | argoproj/argo-workflows | Apache License 2.0 | Go |
@@ -22,6 +22,7 @@ echo "Running $testcase:"
west build -d build/$testcase -b native_posix -- -DZMK_CONFIG=$testcase > /dev/null 2>&1
if [ $? -gt 0 ]; then
echo "FAIL: $testcase did not build" >> ./build/tests/pass-fail.log
+ exit 1
else
./build/$testcase/zephyr/zmk.exe | sed -e "s/.*> //" | tee build/$testcase/keycode_... | fix(tests): return error code when build fails | null | zmkfirmware/zmk | MIT License | Shell |
@@ -121,7 +121,7 @@ public static bool Unpack(NetworkReader messageReader, out int msgType)
}
catch (Exception e)
{
- logger.LogError($"Exception in MessageHandler: {e.GetType().Name} {e.Message} {e.StackTrace}");
+ logger.LogError($"Exception in MessageHandler: {e.GetType().Name} {e.Message}\n{e.StackTrace}");
conn.Di... | fix: adding newline before StackTrace | null | vis2k/mirror | MIT License | C# |
@@ -140,14 +140,17 @@ chmod 600 .env .env.example
# copy over cli tool
-info "Copying CLI tool from $INSTALL_PATH/install/rctf.py to $RCTF_CLI_INSTALL_PATH"
+info "Copying CLI tool from $INSTALL_PATH/install/rctf.py to ${RCTF_CLI_INSTALL_PATH}..."
+if [ ! -f "$RCTF_CLI_INSTALL_PATH" ]; then
cp install/rctf.py "$RCTF_CL... | fix(install): check if file exists | null | redpwn/rctf | BSD 3-Clause New or Revised License | Shell |
@@ -3,3 +3,4 @@ from recbox.data.dataset.sequential_dataset import SequentialDataset
from recbox.data.dataset.kg_dataset import KnowledgeBasedDataset
from recbox.data.dataset.social_dataset import SocialDataset
from recbox.data.dataset.kg_seq_dataset import Kg_Seq_Dataset
+from recbox.data.dataset.customized_dataset im... | fix: bug in customized dataset selection | null | rucaibox/recbole | MIT License | Python |
@@ -82,7 +82,7 @@ class DocumentPage(BaseTemplatePage):
if meta.is_published_field:
condition_field = meta.is_published_field
elif not meta.custom:
- controller = get_controller(meta.doctype)
+ controller = get_controller(meta.name)
condition_field = controller.website.condition_field
return condition_field
| fix: Document Page | null | frappe/frappe | MIT License | Python |
@@ -47,6 +47,11 @@ final class WalletListViewController: UIViewController {
tableView.tableFooterView = UIView()
tableView.registerCell(WalletListCell.self)
tableView.registerCell(WalletListActionCell.self)
+
+ navigationController?.navigationBar.backgroundColor = UIColor.Zap.seaBlue
+ navigationController?.navigationB... | fix: quick switch list navigation bar color | null | ln-zap/zap-ios | MIT License | Swift |
# License: MIT
#
# pylint: disable=invalid-name
-"""Value objects represent inputs.
+r"""Value objects represent inputs.
+
+.. versionadded:: 0.9.5
+
+- Add to make input object holding some attributes like input type (path,
+ stream or pathlib.Path object), path, opener, etc.
"""
from __future__ import absolute_import... | fix: add missing changelog entry for .inputs | null | ssato/python-anyconfig | MIT License | Python |
@@ -223,9 +223,7 @@ mutation_log_private::mutation_log_private(const std::string &dir,
_plock.lock();
- if (dsn_unlikely(utils::FLAGS_enable_latency_tracer)) {
ADD_POINT(mu->_tracer);
- }
// init pending buffer
if (nullptr == _pending_write) {
| fix: remove unused judgement of FLAGS_enable_latency_tracer in private log | null | apache/incubator-pegasus | Apache License 2.0 | C++ |
@@ -44,7 +44,7 @@ class BaseDeserializer(abc.ABC):
class BytesDeserializer(BaseDeserializer):
"""Deserialize a stream of bytes into a bytes object."""
- ACCEPT = "application/octet-stream"
+ ACCEPT = "*/*"
def deserialize(self, data, content_type):
"""Read a stream of bytes returned from an inference endpoint.
| fix: Update BytesDeserializer accept header | null | aws/sagemaker-python-sdk | Apache License 2.0 | Python |
# SPDX-License-Identifier: Apache-2.0
set -e
-export PATH=$PATH:$(npm bin -g)
if ! which node >/dev/null; then
echo "warning: Node is not installed. Visit https://nodejs.org/en/download/ to install it"
exit 1
-elif ! test -f ./amplifytools.xcconfig; then
- npx amplify-app --platform ios
+fi
+
+export PATH=$PATH:$(npm b... | fix(tools): require min version or use | null | aws-amplify/amplify-ios | Apache License 2.0 | Shell |
@@ -72,6 +72,7 @@ print(f"Sampler is {study.sampler.__class__.__name__}")
# though basically it is outperformed by :class:`optuna.pruners.SuccessiveHalvingPruner` and
# :class:`optuna.pruners.HyperbandPruner` as in `this benchmark result <https://github.com/optuna/optuna/wiki/Benchmarks-with-Kurobako>`_.
#
+#
# Activat... | fix: blank line | null | optuna/optuna | MIT License | Python |
@@ -19,7 +19,8 @@ type PlatformConfig struct {
Consul string `yaml:"consul" json:"consul,omitempty"`
Dashboard Dashboard `yaml:"dashboard,omitempty" json:"dashboard,omitempty"`
// Semistructured data to be reused using YAML anchors
- Data map[string]interface{} `yaml:"data,omitempty" json:"data,omitempty"`
+ // +kubebu... | fix: platform.Data validation | null | flanksource/karina | Apache License 2.0 | Go |
@@ -193,11 +193,11 @@ func (m *machinesService) Create(poolName string) (infra.Machine, error) {
func() {},
)
- for _, name := range diskNames {
+ for idx, name := range diskNames {
mountPoint := fmt.Sprintf("/mnt/disks/%s", name)
if err := infra.Try(monitor, time.NewTimer(time.Minute), 10*time.Second, infraMachine, fu... | fix: persist disk mounts | null | caos/orbos | Apache License 2.0 | Go |
@@ -53,11 +53,18 @@ export default class ValidateSetCookieHeaderHint implements IHint {
return value.replace(/(^")|("$)/g, '');
};
+ /** Concat and unquote the strings after the first `=`. */
+ const unquoteAfterSplitByEqual = (splitResult: string[]): string[] => {
+ const [key, ...value] = splitResult;
+
+ return [key... | fix: Cookie name reported in lower case | null | webhintio/hint | Apache License 2.0 | TypeScript |
@@ -619,7 +619,7 @@ private synchronized void clean()
size--;
}
else if (container.timeAdded >= 0 &&
- container.timeAdded < cleanBefore)
+ container.timeAdded > cleanBefore)
{
// We reached a packet with a timestamp after 'cleanBefore'.
// The rest of the packets are even more recent.
| fix: Fixes a bug which brakes retransmissions (introduced with | null | jitsi/libjitsi | Apache License 2.0 | Java |
@@ -10,11 +10,6 @@ export default {
props: {
button: Boolean,
- fill: {
- type: String,
- default () { return this.indeterminate ? 'none' : 'transparent' }
- },
-
indeterminate: Boolean,
rotate: {
| fix(v-progress-circular): removed unused prop fill | null | vuetifyjs/vuetify | MIT License | JavaScript |
@@ -70,16 +70,19 @@ impl<C: Codec + Send + 'static> P2PNetwork<C> {
self.peer_id.clone()
}
- pub fn dial_remote(&mut self, peer_addr: Multiaddr) -> QueryResult<()> {
+ pub fn connect_remote(&mut self, peer_id: PeerId, peer_addr: Multiaddr) -> QueryResult<()> {
Swarm::dial_addr(&mut self.swarm, peer_addr.clone())
- .map... | fix(p2p): add fn connect_remote | null | iotaledger/stronghold.rs | Apache License 2.0 | Rust |
@@ -28,8 +28,6 @@ import org.springframework.web.filter.OncePerRequestFilter;
/** Redirects the user to the Login servlet if they don't already have a session. */
@Slf4j
public class RequireValidSessionFilter extends OncePerRequestFilter {
- // private static final org.slf4j.Logger log =
- // org.slf4j.LoggerFactory.ge... | fix(maxInactive): Remove unneeded, commented code in RequireValidSessionFilter.java | null | uportal-project/uportal | Apache License 2.0 | Java |
@@ -85,8 +85,8 @@ public class DatabendTableGenerator {
private static List<DatabendColumn> getNewColumns() {
List<DatabendColumn> columns = new ArrayList<>();
for (int i = 0; i < Randomly.smallNumber() + 1; i++) {
- String columnName = String.format("c%d", i);
DatabendCompositeDataType columnType = DatabendCompositeDa... | fix: add the corresponding type name to the original column name | null | sqlancer/sqlancer | MIT License | Java |
@@ -73,7 +73,8 @@ bool event_wait_timed( struct event * ev,
int ret = 0;
clock_gettime( CLOCK_REALTIME, &ts );
- ts.tv_sec += ms;
+ ts.tv_sec += ms / 1000;
+ ts.tv_nsec += ( ( ms % 1000 ) * 1000000 );
pthread_mutex_lock( &ev->mutex );
while( ev->event_triggered == false && ret == 0 )
| fix: timespec bug where time is greater than 1 seconds | null | aws/amazon-freertos | MIT License | C |
@@ -399,12 +399,12 @@ const RundownHeader = translate()(class extends React.Component<Translated<IRund
},{
key: RundownViewKbdShortcuts.RUNDOWN_RESET_RUNDOWN,
up: this.keyResetRundown,
- label: t('Reload Rundown'),
+ label: t('Reset Rundown'),
global: true
},{
key: RundownViewKbdShortcuts.RUNDOWN_RESET_RUNDOWN2,
up: th... | fix: relabel hotkey from "Reload Rundown" to "Reset Rundown" | null | nrkno/tv-automation-server-core | MIT License | TypeScript |
@@ -106,8 +106,9 @@ defmodule Ash.DataLayer.Delegate do
end
@impl true
- def filter(%{query: query} = source_query, filter, _resource) do
- {:ok, %{source_query | query: Ash.Query.filter(query, filter)}}
+ def filter(%{query: query} = source_query, filter, resource) do
+ {:ok,
+ %{source_query | query: Ash.Query.filter... | fix: set resource in delegation query | null | ash-project/ash | MIT License | Elixir |
@@ -93,6 +93,16 @@ impl Cron {
}
}
+ if base.days_of_week != "*" && base.hours == "*" {
+ base.hours = "0".to_string();
+ }
+ if base.hours != "*" && base.minutes == "*" {
+ base.minutes = "0".to_string();
+ }
+ if base.minutes != "*" && base.seconds == "*" {
+ base.seconds = "0".to_string();
+ }
+
base
}
@@ -434,7 +44... | fix(Cron utilities): Zero seconds, minutes, etc when higher periods are not every | null | stencila/stencila | Apache License 2.0 | Rust |
@@ -108,12 +108,11 @@ export class UploadService {
private encryptThenSend(response: number | UploadFile, fileType: FileType, conversationID: number, aesKey: string, file: File): void {
if (response && !Number(response)) {
if ((<UploadFile>response).code === 0) {
- let encedMessages;
switch (fileType) {
case FileType.I... | fix: prevent the failed img message cause the app crash | null | aiursoftweb/kahla.app | MIT License | TypeScript |
@@ -44,15 +44,19 @@ public class FlowListenersService {
this.notifyConsumers();
}
- private synchronized boolean remove(Flow flow) {
+ private boolean remove(Flow flow) {
+ synchronized (this) {
return flows.removeIf(r -> r.equalsWithoutRevision(flow));
}
+ }
private synchronized void upsert(Flow flow) {
+ synchronized... | fix(core): FlowListenersService throw ConcurrentModificationException | null | kestra-io/kestra | Apache License 2.0 | Java |
@@ -40,6 +40,9 @@ public void UpdateData(UserProfileModel newModel)
public bool ContainsItem(string itemId)
{
+ if (inventory == null)
+ return false;
+
return inventory.Contains(itemId);
}
| fix: null reference exceptions in UserProfile.cs | null | decentraland/explorer | Apache License 2.0 | C# |
@@ -120,13 +120,19 @@ public class MailService {
email.attach(ds, "report.xls", EmailAttachment.ATTACHMENT, "test");
}
email.setHostName(mail_smtp_host);
+ if (mail_smtp_ssl_check) {
+ email.setSslSmtpPort(Integer.toString(mail_smtp_port));
+ email.setSSLOnConnect(true);
+ } else {
email.setSmtpPort(mail_smtp_port);
+ ... | fix: Unable to send mail to SSL SMTP server | null | tuiqiao/cboard | Apache License 2.0 | Java |
@@ -1622,8 +1622,9 @@ impl Tab {
self.write_to_active_terminal(mouse_event.into_bytes(), client_id);
} else {
// TODO: rename this method, it is used to forward release events to plugin panes
- active_pane.end_selection(&relative_position, client_id);
+ if let PaneId::Terminal(_) = active_pane.pid() {
if selecting && c... | fix(mouse): middle or right clicks creating selection | null | zellij-org/zellij | MIT License | Rust |
@@ -89,7 +89,8 @@ public class BinaryXMLParser extends CommonBinaryParser {
is.mark(4);
int v = is.readInt16(); // version
int h = is.readInt16(); // header size
- if (v == 0x0003 && h == 0x0008) {
+ // Some APK Manifest.xml the version is 0
+ if (h == 0x0008) {
return true;
}
is.reset();
| fix(res): ignore version in AndroidManifest.xml (#1502)(PR | null | skylot/jadx | Apache License 2.0 | Java |
package loaders
import (
+ "bytes"
"fmt"
"io/ioutil"
"os"
@@ -9,6 +10,7 @@ import (
"strconv"
"strings"
+ "github.com/fsmiamoto/git-todo-parser/todo"
"github.com/jesseduffield/generics/slices"
"github.com/jesseduffield/lazygit/pkg/commands/models"
"github.com/jesseduffield/lazygit/pkg/commands/oscommands"
@@ -307,21 +3... | fix: use todo parser to properly read rebase todo file | null | jesseduffield/lazygit | MIT License | Go |
@@ -55,6 +55,8 @@ class Flattener:
)
self.sources[fp_obj.name] = IMPORT_PATTERN.sub(repl, source)
+ if fp_obj.name not in self.dependencies:
+ self.dependencies[fp_obj.name] = set()
# traverse dependency files - can circular imports happen?
for m in IMPORT_PATTERN.finditer(source):
| fix: handle sources which have no imports | null | eth-brownie/brownie | MIT License | Python |
@@ -114,14 +114,14 @@ class PageService {
}
// const { _ids, path } = pageData;
- const _ids = pagesData.map(page => (page._id));
+ const ids = pagesData.map(page => (page._id));
const paths = pagesData.map(page => (page.path));
const socketClientId = options.socketClientId || null;
logger.debug('Deleting completely', ... | fix: _ids to ids | null | weseek/growi | MIT License | JavaScript |
@@ -119,6 +119,27 @@ const StyledIcon = styled(Icon)`
`}
`;
+const matchingThreshold = (thresholds, item) => {
+ return thresholds
+ .filter(t => {
+ switch (t.comparison) {
+ case '<':
+ return item[t.dataSourceId] < t.value;
+ case '>':
+ return item[t.dataSourceId] > t.value;
+ case '=':
+ return item[t.dataSourceId... | fix(table): minor updates on table card | null | carbon-design-system/carbon-addons-iot-react | Apache License 2.0 | JavaScript |
@@ -761,9 +761,7 @@ fn get_themes(&mut self, ctx: &mut EventCtx, config: &Config) {
#[allow(unused_variables)]
fn get_commands(&mut self, ctx: &mut EventCtx) {
- let excluded_items: Vec<String> = vec![
- String::from("palette.command")
- ];
+ const EXCLUDED_ITEMS: &[&str] = &["palette.command"];
let palette = Arc::make... | fix: Use const &[&str] instead of Vec<String> | null | lapce/lapce | Apache License 2.0 | Rust |
@@ -154,7 +154,7 @@ struct LaneletPartForRouting
~LaneletPartForRouting() = default;
lanelet::ConstLanelet lanelet;
- double start_s = -1.0; // -1 means from the begining
+ double start_s = -1.0; // -1 means from the beginning
double end_s = -1.0; // -1 means to the end
double min_distance_remaining;
| fix(typo): begining => beginning | null | tier4/scenario_simulator_v2 | Apache License 2.0 | C++ |
@@ -148,7 +148,7 @@ read -r result </dev/tty
if [ "$result" = "y" ]; then
info "Running 'docker-compose up -d'..."
- docker-compose up -d --project-directory $INSTALL_PATH
+ docker-compose up -d --project-directory "$INSTALL_PATH"
exit 0
else
info "Installation to $INSTALL_PATH complete."
| fix: fix shellcheck for 1 command install | null | redpwn/rctf | BSD 3-Clause New or Revised License | Shell |
@@ -5,6 +5,7 @@ import (
"context"
"fmt"
"io"
+ "math"
"net/http"
"github.com/buger/jsonparser"
@@ -74,7 +75,7 @@ func (h *gqlSSEConnectionHandler) subscribe(ctx context.Context, sub Subscriptio
_ = resp.Body.Close()
}()
- reader := sse.NewEventStreamReader(resp.Body, 1<<32)
+ reader := sse.NewEventStreamReader(resp.Bo... | fix: subscriptions, event stream reader | null | jensneuse/graphql-go-tools | MIT License | Go |
@@ -41,8 +41,6 @@ type Request struct {
// Active, if set, contains the registration method that is being used. It is initially
// not set.
- //
- // required: true
Active identity.CredentialsType `json:"active,omitempty" db:"active_method"`
// Methods contains context for all enabled registration methods. If a registr... | fix: active field should not be required | null | ory/kratos | Apache License 2.0 | Go |
@@ -145,7 +145,6 @@ class JinaLogger:
}
self.add_handlers(log_config, **context_vars)
- self.success = lambda *x: self.logger.log(LogVerbosity.SUCCESS, *x)
self.debug = self.logger.debug
self.warning = self.logger.warning
self.critical = self.logger.critical
@@ -154,6 +153,14 @@ class JinaLogger:
self._is_closed = Fals... | fix: avoid having a lambda in logger | null | jina-ai/jina | Apache License 2.0 | Python |
@@ -7,6 +7,10 @@ import 'package:firebase_core/firebase_core.dart';
import 'auth.dart';
import 'profile.dart';
+/// Requires that a Firebase local emulator is running locally.
+/// See https://firebase.flutter.dev/docs/auth/start/#optional-prototype-and-test-with-firebase-local-emulator-suite
+bool shouldUseFirebaseEmu... | fix: update firebase_auth example to not be dependent on an emulator | null | firebaseextended/flutterfire | BSD 3-Clause New or Revised License | Dart |
@@ -1323,12 +1323,6 @@ class RenderBoxModel extends RenderBox
renderStyle.backgroundAttachment == CSSBackgroundAttachmentType.local;
}
- @override
- void detach() {
- disposePainter();
- super.detach();
- }
-
/// Called when its corresponding element disposed
void dispose() {
// Clear renderObjects in list when dispose... | fix: should not dispose box decoration painter when renderBoxModel detached | null | openkraken/kraken | Apache License 2.0 | Dart |
@@ -10,6 +10,10 @@ import { DocSearchButton, useDocSearchKeyboardEvents } from '@docsearch/react';
let DocSearchModal = null;
+function Hit({ hit, children }) {
+ return <Link to={hit.url}>{children}</Link>;
+}
+
function SearchBar() {
const { siteConfig = {} } = useDocusaurusContext();
const history = useHistory();
@@... | fix(website): update DocSearch integration | null | algolia/autocomplete | MIT License | JavaScript |
@@ -885,19 +885,28 @@ public class ExtendedWebElement implements IWebElement {
}
/**
- * Check that element visible within specified timeout.
+ * Check that element is visible within specified timeout.
*
- * @param timeout - timeout.
- * @return element visibility status.
+ * @param timeout timeout, in seconds
+ * @ret... | fix(ExtendedWebElement): isVisible method use searchContext | null | zebrunner/carina | Apache License 2.0 | Java |
@@ -231,10 +231,7 @@ protected virtual Renderer CreateHighlightModel(GameObject givenOutlineModel, st
{
Renderer copyModelRenderer = objectToAffect.GetComponentInChildren<Renderer>();
copyModel = (copyModelRenderer != null ? copyModelRenderer.gameObject : null);
- }
- if (copyModel == null)
- {
VRTK_Logger.Error(VRTK_L... | fix(Highlighter): copy shadow casting mode from object renderer | null | extendrealityltd/vrtk | MIT License | C# |
@@ -372,12 +372,14 @@ impl AgentClient {
// store the base64 encoding of `username:password`, but we decode it
// since the Agent requires username and password as separate fields.
let pair = base64::decode(&token).unwrap();
- let v: Vec<String> = String::from_utf8_lossy(pair.as_slice())
- .split(':')
- .take(2)
- .map... | fix: Adjust password parsing | null | dfinity/sdk | Apache License 2.0 | Rust |
@@ -20,9 +20,9 @@ if [ "${NODE_ENV}" != "production" ]; then
echo
echo "WARNING! You are already debugging another node process!"
echo
- echo " force will start without --inspect-brk unless you kill the other process"
+ echo " force will start without --inspect unless you kill the other process"
else
- OPT+=(--inspect-... | fix: Start Inspect | null | artsy/force | MIT License | Shell |
@@ -72,8 +72,8 @@ export const ListAction: Action<ListActionResponse> = {
total,
perPage,
page,
- direction: sort.direction,
- sortBy: sort.sortBy,
+ direction: sort?.direction,
+ sortBy: sort?.sortBy,
},
records: populatedRecords.map(r => r.toJSON(context.currentAdmin)),
}
| fix: list without sortable columns | null | softwarebrothers/admin-bro | MIT License | TypeScript |
@@ -45,6 +45,12 @@ export interface IUser {
created?: number;
modified?: number;
groups?: IGroup[];
- provider?: "arcgis" | "enterprise" | "facebook" | "google";
+ provider?:
+ | "arcgis"
+ | "enterprise"
+ | "facebook"
+ | "google"
+ | "apple"
+ | "github";
id?: string;
}
| fix(arcgis-rest-request): added social providers | null | esri/arcgis-rest-js | Apache License 2.0 | TypeScript |
@@ -22,6 +22,7 @@ import (
"fmt"
"net/http"
"strings"
+ "sync"
openpitrixv1 "kubesphere.io/kubesphere/pkg/kapis/openpitrix/v1"
"kubesphere.io/kubesphere/pkg/utils/clusterclient"
@@ -58,8 +59,7 @@ type ServerRunOptions struct {
ConfigFile string
GenericServerRunOptions *genericoptions.ServerRunOptions
*apiserverconfig.C... | fix: concurrent map read and map write caused by reloading in ks-apiserver | null | kubesphere/kubesphere | Apache License 2.0 | Go |
@@ -146,14 +146,18 @@ impl CsvInputFormat {
let position = pos + position4::<true, b'"', b'\'', b'\r', b'\n'>(&buf[pos..]);
if position != buf.len() {
- if buf[position] == b'"' || buf[position] == b'\'' {
+ return match buf[position] {
+ b'"' | b'\'' => {
state.quotes = buf[position];
- return position + 1;
- } else i... | fix: not allow \n\r as record_delimiter in csv | null | datafuselabs/databend | Apache License 2.0 | Rust |
@@ -152,7 +152,7 @@ impl<'a> GraphiQLSource<'a> {
.replace("%GRAPHIQL_SUBSCRIPTION_URL%", &graphiql_subscription_url)
.replace("%GRAPHIQL_HEADERS%", &graphiql_headers)
.replace("%GRAPHIQL_TITLE%", &graphiql_title)
- .replace("%CREDENTIALS%", &graphiql_credentials)
+ .replace("%GRAPHIQL_CREDENTIALS%", &graphiql_credenti... | fix: credentials variable name typo | null | async-graphql/async-graphql | Apache License 2.0 | Rust |
@@ -25,7 +25,6 @@ export function doesNotExist (value: any): boolean {
* Returns false if the value is ok.
* Returns an EditorValidationIssue object if the value is not ok.
*/
-// eslint-disable-next-line complexity
export function validate (
field: GtfsSpecField,
value: any,
| fix(validation.js): Remove ES lint waiver | null | ibi-group/datatools-ui | MIT License | JavaScript |
@@ -262,8 +262,9 @@ frappe.ui.FilterGroup = class {
update_filters() {
// remove hidden filters and undefined filters
- this.filters.map(f => !f.get_selected_value() && f.remove());
- this.filters = this.filters.filter(f => f.get_selected_value() && f.field);
+ const filter_exists = (f) => ![undefined, null].includes(f... | fix: do not remove filters with 0 value | null | frappe/frappe | MIT License | JavaScript |
@@ -76,6 +76,9 @@ class PairwiseDataLoader(AbstractDataLoader):
raise NotImplementedError()
# TODO
elif self.neg_sample_to is not None:
+ user_num_in_one_batch = self.batch_size // self.neg_sample_to
+ self.batch_size = (user_num_in_one_batch + 1) * self.neg_sample_to
+
uid_field = self.config['USER_ID_FIELD']
iid_fiel... | fix: batch size in test/valid dataloader | null | rucaibox/recbole | MIT License | Python |
@@ -11,7 +11,7 @@ if [[ "-x$RM" == "-x" ]] ; then
RM=rm
fi
-Version=$(git describe --abbrev=0 2>/dev/null)
+Version=$(git describe --abbrev=0 --tags 2>/dev/null)
BranchName=$(git rev-parse --abbrev-ref HEAD 2>/dev/null)
CommitID=$(git rev-parse HEAD 2>/dev/null)
BuildTime=$(date +%Y-%m-%d\ %H:%M)
| fix: main build script issue | null | chubaofs/chubaofs | Apache License 2.0 | Shell |
@@ -457,7 +457,6 @@ func CheckRequest(quotas []corev1.ResourceQuota, a admission.Attributes, evaluat
match, err := evaluator.Matches(&resourceQuota, inputObject)
if err != nil {
- klog.Errorf("Error occurred while matching resource quota, %v, against input object. Err: %v", resourceQuota, err)
klog.ErrorS(err, "Error o... | fix: remove redundant error log print | null | kubernetes/apiserver | Apache License 2.0 | Go |
@@ -47,6 +47,7 @@ namespace MLAPI.Serialization
/// <param name="value">The object to write</param>
public void WriteObjectPacked(object value)
{
+ // Check unitys custom null checks
bool isNull = value == null || (value is UnityEngine.Object && ((UnityEngine.Object)value) == null);
if (isNull || value.GetType().IsNull... | fix: Fixed serialization problem in last versions binary | null | unity-technologies/com.unity.multiplayer.mlapi | MIT License | C# |
@@ -78,8 +78,8 @@ type GrafanaDataStorage struct {
Annotations map[string]string `json:"annotations,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
AccessModes []v1.PersistentVolumeAccessMode `json:"accessModes,omitempty"`
- Size resource.Quantity `json:"size"`
- Class string `json:"class"`
+ Size resour... | fix: add missing omitempty | null | grafana-operator/grafana-operator | Apache License 2.0 | Go |
@@ -70,19 +70,11 @@ public class FlywayMigrationStrategyConfigurationTest {
verify(mockConnection, times(1)).close();
}
- @Test
+ @Test(expected = FlywayException.class)
public void handlesGetConnectionException() throws SQLException {
- boolean caughtException = false;
doThrow(SQLException.class).when(instanceToTest).... | fix: test should not expect close() | null | cloudfoundry-incubator/credhub | Apache License 2.0 | Java |
@@ -130,7 +130,7 @@ install_packages()
sudo apt update
status_msg "Install needed packages"
- sudo apt-get -y install --no-install-recommends git
+ sudo apt-get -y install --no-install-recommends git curl
if ! command -v node -v >/dev/null 2>&1
then
| fix: add curl to the install script | null | eliteschwein/mooncord | MIT License | Shell |
@@ -16,11 +16,11 @@ class UserPermission(Document):
self.validate_default_permission()
def on_update(self):
- frappe.cache().delete_value('user_permissions')
+ frappe.cache().hdel('user_permissions', self.user)
frappe.publish_realtime('update_user_permissions')
def on_trash(self): # pylint: disable=no-self-use
- frappe... | fix: do not delete user permissions for all the user | null | frappe/frappe | MIT License | Python |
@@ -56,7 +56,7 @@ export default class ObjectPartRowViewModel extends BaseViewModel {
this.columns = columns;
this.stateIcon = partStateIcons[state];
- this.label = `Part ${partNumber + 1} of ${partsCount} | ${size} | ${blocks.length} blocks`;
+ this.label = `Part ${partNumber + 1} of ${partsCount} | ${size} | ${blocks... | fix: object parts replaced 'blocks' to 'replicas' | null | noobaa/noobaa-core | Apache License 2.0 | JavaScript |
@@ -56,7 +56,7 @@ export const ProcessorSelectDialog = observer(
onClose,
}: ProcessorSelectDialogProps) {
const translate = useTranslate();
- const node = useNode(context.containerNodePath || '');
+ const { node } = useNode(context.containerNodePath || '');
return styled(styles)(
<CommonDialogWrapper
| fix(data-export-plugin): after merge | null | dbeaver/cloudbeaver | Apache License 2.0 | TypeScript |
<div
x-data="{
- notifications: @js(session()->pull('notifications', [])),
+ notifications: {{ Illuminate\Support\Js::from(session()->pull('notifications', [])) }},
add (event) {
this.notifications = this.notifications.concat(event.detail)
},
| fix: Notifications not showing after redirect | null | laravel-filament/filament | MIT License | PHP |
@@ -171,7 +171,7 @@ class HistogramObserver(MinMaxObserver):
self.bins = bins
self.upsample_rate = upsample_rate
self.dst_nbins = _metadata_dict[dtype].qmax - _metadata_dict[dtype].qmin + 1
- self.histogram = Tensor([-1] + [0.0] * (bins - 1))
+ self.histogram = Tensor([-1] + [0.0] * (bins - 1), dtype="float32")
def _no... | fix(quantize): fix quantize calibration dtype issue | null | megengine/megengine | Apache License 2.0 | Python |
@@ -1425,11 +1425,11 @@ function baseCreateRenderer(
}
if (next) {
+ next.el = vnode.el
updateComponentPreRender(instance, next, optimized)
} else {
next = vnode
}
- next.el = vnode.el
// beforeUpdate hook
if (bu) {
| fix(runtime-core): vnode.el is null in watcher after rerendering | null | vuejs/vue-next | MIT License | TypeScript |
-import { Context, controller, provide, controller, get, post, inject } from 'midway';
+import { Context, controller, provide, get, post, inject } from 'midway';
import { IUserService } from '../../lib/interface';
@provide()
| fix(types): duplicate import of the controller | null | midwayjs/midway | MIT License | TypeScript |
@@ -162,10 +162,11 @@ public class AttendeesFragment extends BaseFragment implements IAttendeesView {
@Override
public void onDetach() {
super.onDetach();
- searchView.setOnQueryTextListener(null);
attendeesPresenter.detach();
refreshLayout.setOnRefreshListener(null);
stickyHeaderAdapter.unregisterAdapterDataObserver(a... | fix: Add null check on searchView | null | fossasia/open-event-organizer-android | Apache License 2.0 | Java |
@@ -67,7 +67,7 @@ export abstract class ViewWithBottomSheetBase extends View {
});
}
protected _showNativeBottomSheet(parent: View, options: BottomSheetOptions) {
- this._bottomSheetContext = options.context;
+ this._bottomSheetContext = options.context || {};
this._whenCloseBottomSheetCallback = (...originalArgs) => {... | fix: ensure _bottomSheetContext is not undefined | null | nativescript-community/ui-material-components | Apache License 2.0 | TypeScript |
@@ -57,7 +57,7 @@ export const promise = async ({
if (typeof siblingData[field.name] === 'undefined') {
// If no incoming data, but existing document data is found, merge it in
if (typeof siblingDoc[field.name] !== 'undefined') {
- if (field.localized && typeof siblingDoc[field.name] === 'object') {
+ if (field.localiz... | fix: rare bug while merging locale data | null | payloadcms/payload | MIT License | TypeScript |
@@ -17,7 +17,9 @@ func copyBinary() error {
return err
}
defer func() { _ = in.Close() }()
- out, err := os.OpenFile("/var/run/argo/argoexec", os.O_RDWR|os.O_CREATE, 0o500) // r-x------
+ // argoexec needs to be executable from non-root user in the main container.
+ // Therefore we set permission 0o555 == r-xr-xr-x.
+ ... | fix(executor): emissary - make argoexec executable from non-root containers. Fixes | null | argoproj/argo-workflows | Apache License 2.0 | Go |
@@ -10,10 +10,11 @@ import {
forwardRef,
HostBinding,
Input,
+ OnChanges,
OnDestroy,
- OnInit,
Output,
Renderer2,
+ SimpleChange,
ViewChild,
ViewEncapsulation,
} from '@angular/core';
@@ -81,7 +82,7 @@ export const MDC_TEXTFIELD_CONTROL_VALUE_ACCESSOR: any = {
changeDetection: ChangeDetectionStrategy.OnPush,
preserveWh... | fix(text-field): Fix error if disabled prior to foundation init | null | trimox/angular-mdc-web | MIT License | TypeScript |
@@ -2900,7 +2900,6 @@ export class SelectQueryBuilder<Entity>
}
}
if (this.selects.length) {
- console.log("adding following selects: ", this.selects)
this.addSelect(this.selects)
}
@@ -3686,7 +3685,6 @@ export class SelectQueryBuilder<Entity>
selection &&
typeof selection[relationName] === "object"
) {
- console.log("... | fix: remove console.log calls from SelectQueryBuilder | null | typeorm/typeorm | MIT License | TypeScript |
@@ -2,7 +2,7 @@ import {WIDTH, HEIGHT} from '../core/constants.js'
import {lerp, unlerp} from '../core/utils.js'
import {ErrorLog} from '../core/ErrorLog.js'
import {MissingImageError} from './errors/MissingImageError.js'
-
+import {flagForDestructionOnReinit} from '../core/rendering.js'
/* global PIXI */
export class ... | fix(endscreen): using flagForDestructionOnReinit | null | codingame/codingame-game-engine | MIT License | JavaScript |
@@ -470,11 +470,14 @@ pub extern fn given_with_param(interaction: handles::InteractionHandle, descript
Ok(json) => json,
Err(_) => json!(value)
};
- match inner.provider_states.iter().find_position(|state| state.name == name) {
+ match inner.provider_states.iter().find_position(|state| state.name == description) {
Some... | fix: incorrectly handling provider state parameters from FFI call | null | pact-foundation/pact-reference | MIT License | Rust |
@@ -189,8 +189,11 @@ private void configureBaseUrl(RestClientBuilder builder) {
&& !propertyOptional.isPresent()) {
throw new IllegalArgumentException(
String.format(
- "Unable to determine the proper baseUrl/baseUri. Consider registering using @RegisterRestClient(baseUri=\"someuri\", configKey=\"orkey\"), or by adding... | fix: correction on the URI/URL error message | null | quarkusio/quarkus | Apache License 2.0 | Java |
#include "json.h"
#include <cinttypes>
+#include <cctype>
using namespace std;
@@ -30,7 +31,12 @@ static void json_write_str_value(FILE *out, const char *str)
fprintf(out, "\\t");
break;
default:
+ if (isprint(*str)) {
fputc(*str, out);
+ } else {
+ auto u8 = static_cast<uint8_t>(*str);
+ fprintf(out, "\\u%04x", u8);
+... | fix: do not output invalid JSON | null | h2o/h2o | MIT License | C++ |
@@ -5,7 +5,7 @@ class Model {
/**
* @param {object} options
* @param {string} options.identifier
- * @param {boolean|string} options.embedded
+ * @param {boolean} options.embedded
* @param {object} [options.config]
* @param {string} [options.config.ip]
* @param {string} [options.config.deviceId]
@@ -20,11 +20,7 @@ clas... | fix: Simplify embedded logic now that 'auto' is gone | null | hypfer/valetudo | Apache License 2.0 | JavaScript |
@@ -77,19 +77,23 @@ export const PoolHeader: FC<PoolHeader> = ({ pair }) => {
<div className="flex gap-3 rounded-lg bg-slate-800 p-3">
<Currency.Icon currency={token0} width={20} height={20} />
<Typography variant="sm" weight={600} className="text-slate-300">
+ <AppearOnMount>
{token0.symbol} ={' '}
{prices?.[token1.wr... | fix(apps/pool): hydration error | null | sushiswap/sushiswap | MIT License | TypeScript |
@@ -188,6 +188,7 @@ func (d *Driver) Create() error {
klog.Infof("duration metric: took %f seconds to extract preloaded images to volume", time.Since(t).Seconds())
}
}()
+ waitForPreload.Wait()
if pErr == oci.ErrInsufficientDockerStorage {
return pErr
}
@@ -200,7 +201,6 @@ func (d *Driver) Create() error {
return error... | fix: check err before preload | null | kubernetes/minikube | Apache License 2.0 | Go |
-import React, { useContext, useEffect, useMemo } from 'react';
-import { Schema, ISchemaFieldProps } from '@formily/react';
+import { ISchemaFieldProps, Schema } from '@formily/react';
+import React, { useContext, useEffect, useMemo, useRef } from 'react';
import { SchemaComponentContext } from '../context';
function ... | fix: useEffect only on update | null | nocobase/nocobase | Apache License 2.0 | TypeScript |
#include "bignum.h"
#include "boatplatform_internal.h"
-#include "cm_sys.h"
+#include "cm_os.h"
/* net releated include */
#include <sys/types.h>
#define GENERATE_KEY_REPEAT_TIMES 100
+
BOAT_RESULT BoatHash(const BoatHashAlgType type, const BUINT8 *input, BUINT32 inputLen,
BUINT8 *hashed, BUINT8 *hashedLen, void *rsvd)... | fix: Modify sleep function | null | aitos-io/boat-x-framework | Apache License 2.0 | C |
@@ -86,9 +86,11 @@ const Title = props => (
const Header = props => (
<header className="header">
+ <div className="title">
<PageHeading>
<Title />
</PageHeading>
+ </div>
<style jsx>{`
.header {
background: linear-gradient(to top, #2bb2e3, #137bc2);
| fix(site): restore title page spacing | null | pluralsight/design-system | Apache License 2.0 | JavaScript |
@@ -52,6 +52,7 @@ class _ProductListPageState extends State<ProductListPage> {
}
return Scaffold(
appBar: AppBar(
+ elevation: 0,
backgroundColor: Colors.white, // TODO(monsieurtanuki): night mode
foregroundColor: Colors.black,
title: Row(
| fix: AppBar does not fit theme | null | openfoodfacts/smooth-app | Apache License 2.0 | Dart |
@@ -36,6 +36,7 @@ import {
AmplifyButton
} from '../AmplifyUI';
import AuthPiece from './AuthPiece';
+import countryDialCodes from '../CountryDialCodes';
import signUpWithUsernameFields, { signUpWithEmailFields, signUpWithPhoneNumberFields } from './common/default-sign-up-fields'
| fix(aws-amplify-react-native): Add countryDialCodes to allow non USA phone numbers | null | aws-amplify/amplify-js | Apache License 2.0 | JavaScript |
@@ -798,7 +798,7 @@ impl From<FileReadFailed> for Error {
fn from(e: FileReadFailed) -> Self {
use FileReadFailed::*;
match e {
- File(_e) => todo!(),
+ File(e) => Error::File(e),
UnexpectedType(ut) => Error::UnexpectedType(ut),
Read(_) => unreachable!("FileVisit does not parse any blocks"),
InvalidCid(l) => Error::Inv... | fix: forgotten unused error variant (File) | null | rs-ipfs/rust-ipfs | Apache License 2.0 | Rust |
@@ -85,7 +85,9 @@ class Page extends Component implements Forms\Contracts\HasForms
public static function getSlug(): string
{
- return static::$slug ?? Str::kebab(static::$title ?? class_basename(static::class));
+ return static::$slug ?? Str::of(static::$title ?? class_basename(static::class))
+ ->kebab()
+ ->slug();
... | fix: wrong slug generation on pages | null | laravel-filament/filament | MIT License | PHP |
if (datePickerCallout == null)
return;
- return datePickerCallout.offsetWidth > window.innerWidth;
+ const datePickerCalloutWidth = datePickerCallout.offsetWidth;
+ const bodyWidth = document.body.offsetWidth;
+ if (datePickerCalloutWidth > bodyWidth) {
+ return true;
+ } else {
+ const calloutLeft = datePickerCallout.... | fix(components): resolve responsive issues of the BitDatePicker component on small screens | null | bitfoundation/bitframework | MIT License | TypeScript |
@@ -4,12 +4,12 @@ import (
"net/http"
_ "net/http/pprof"
+ "github.com/iotaledger/hive.go/node"
+
"github.com/iotaledger/goshimmer/pluginmgr/core"
"github.com/iotaledger/goshimmer/pluginmgr/research"
"github.com/iotaledger/goshimmer/pluginmgr/ui"
"github.com/iotaledger/goshimmer/pluginmgr/webapi"
- "github.com/iotaledg... | fix: fixed merge bug | null | iotaledger/goshimmer | Apache License 2.0 | Go |
@@ -24,7 +24,7 @@ export class MdcLineRipple implements OnInit, OnDestroy {
addClass: (className: string) => this._renderer.addClass(this._getHostElement(), className),
removeClass: (className: string) => this._renderer.removeClass(this._getHostElement(), className),
hasClass: (className: string) => this._getHostElemen... | fix(line-ripple): Rename adapter method setAttr to setStyle | null | trimox/angular-mdc-web | MIT License | TypeScript |
@@ -119,7 +119,7 @@ export class LineChartTransform implements IChartTransform {
if (this.isRelativeMode) {
const data = cloneDeep(this.initialData)
for (const g of data) {
- const indexValue = clone(g.values.find(v => v.time >= this.startYear))
+ const indexValue = clone(g.values.find(v => v.time >= this.startYear && ... | fix: indexed line chart should at the first value that isn't 0 | null | owid/owid-grapher | MIT License | TypeScript |
@@ -25,7 +25,7 @@ use std::{
path::{Path, PathBuf},
sync::{
atomic::{AtomicBool, Ordering},
- Arc, Mutex,
+ Arc,
},
thread,
time::Duration,
@@ -39,7 +39,7 @@ use serde::Deserialize;
use tokio::{
sync::{
broadcast::{channel as broadcast_channel, Receiver as BroadcastReceiver, Sender as BroadcastSender},
- RwLock,
+ Mute... | fix: use tokio mutex so the manager is Send | null | iotaledger/wallet.rs | Apache License 2.0 | Rust |
@@ -1610,6 +1610,14 @@ impl<T: Config> Pallet<T> {
e
})?;
+ if index < side_effects.len() - 1
+ && side_effects[index].reward_asset_id != side_effects[index + 1].reward_asset_id
+ {
+ return Err(
+ "SFX validate failed - enforce all SFX to have the same reward asset field",
+ )
+ }
+
let (insurance, reward) = if let So... | fix: enforce all SFX to have the same reward asset field | null | t3rn/t3rn | Apache License 2.0 | Rust |
@@ -126,7 +126,7 @@ fn parse_tsm_key_internal(key: &[u8]) -> Result<ParsedTSMKey, DataError> {
}
}
KeyType::Field => {
- // since parse_tsm_field_key consumes the rest of the iterator, it
+ // since `parse_tsm_field_key_value` consumes the rest of the iterator, it
// is some kind of logic error if we already have a fie... | fix: Apply suggestions from code review | null | influxdata/influxdb_iox | Apache License 2.0 | Rust |
@@ -415,7 +415,10 @@ public class ObservationEditor extends AppCompatActivity {
setResult(RESULT_OK, (new Intent()).setAction(mUri.toString()));
getIntent().setAction(Intent.ACTION_INSERT);
- } else if (savedInstanceState == null) {
+ } else if ((savedInstanceState == null) ||
+ ((mUri == null) && (intent != null) && (... | fix: Edge case in obs editor that eventually causes wrongful local duplication of all obs | null | inaturalist/inaturalistandroid | MIT License | Java |
@@ -170,7 +170,7 @@ export class MateriaService {
return combineLatest([
safeCombineLatest(materiasObsArray$),
this.lazyData.getEntry('extracts'),
- this.settings.watchSetting('materias:confidence', 0.9)
+ this.settings.watchSetting<number>('materias:confidence', 0.5)
]).pipe(
map(([pieces, extracts, confidence]) => {
... | fix(gearset): fixed confidence rate resetting when including other tools in DoH sets | null | ffxiv-teamcraft/ffxiv-teamcraft | MIT License | TypeScript |
package com.eventyay.organizer.core.ticket.list;
import android.content.Context;
-import androidx.databinding.DataBindingUtil;
import android.os.Bundle;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+
import androidx.annotation.Nullable;
-import com.google.android.mater... | fix: Prevent Tickets fragment from becoming blank | null | fossasia/open-event-organizer-android | Apache License 2.0 | Java |
@@ -66,10 +66,10 @@ class ProjectRoleRestrictionModel extends Base
$restrictions = $this->db
->table(self::TABLE)
->columns(
- self::TABLE.'.restriction_id',
- self::TABLE.'.project_id',
- self::TABLE.'.role_id',
- self::TABLE.'.rule'
+ 'restriction_id',
+ 'project_id',
+ 'role_id',
+ 'rule'
)
->eq(self::TABLE.'.projec... | fix(mssql): do not needlessly qualify columns in ProjectRoleRestrictionModel | null | kanboard/kanboard | MIT License | PHP |
@@ -7,8 +7,8 @@ use std::{
use arrow::datatypes::{DataType, Field};
use data_types::chunk_metadata::ChunkId;
use datafusion::{
- error::{DataFusionError, Result as DatafusionResult},
- logical_plan::{Expr, ExpressionVisitor, LogicalPlan, LogicalPlanBuilder, Operator, Recursion},
+ error::DataFusionError,
+ logical_plan... | fix: remove outdated "supported predicate" check in gRPC planner | null | influxdata/influxdb_iox | Apache License 2.0 | Rust |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.