diff
stringlengths
12
9.3k
message
stringlengths
8
199
reasoning_trace
null
repo
stringlengths
6
68
license
stringclasses
3 values
language
stringclasses
16 values
@@ -30,7 +30,7 @@ async fn main() -> Result<()> { let project = Project::builder().paths(paths).ephemeral().no_artifacts().build().unwrap(); // compile the project and get the artifacts let output = project.compile().unwrap(); - let contract = output.find("SimpleStorage").expect("could not find contract").into_owned();...
fix: use correct artifact api
null
gakonst/ethers-rs
Apache License 2.0
Rust
@@ -2893,7 +2893,7 @@ PlutoConstraints *get_skewing_constraints(bool *src_dims, bool *skew_dims, /* Introduce loop skewing transformations if necessary */ void introduce_skew(PlutoProg *prog) { - int i, j, k, num_sccs, nvar, npar, nstmts, level, ndeps; + int i, j, num_sccs, nvar, npar, nstmts, level, ndeps; int initial...
fix: Memory leak in skew introduction with DFP framework
null
bondhugula/pluto
MIT License
C
@@ -75,6 +75,7 @@ public override void Init() factory.GenerateNetIds(); var configManager = IoCManager.Resolve<IConfigurationManager>(); var dest = configManager.GetCVar(CCVars.DestinationFile); + IoCManager.Resolve<ContentLocalizationManager>().Initialize(); if (string.IsNullOrEmpty(dest)) //hacky but it keeps load ti...
fix: Wiki now displays the proper names and descriptions for chemistry recipes and the rest instead of the localization keys
null
space-wizards/space-station-14
MIT License
C#
@@ -337,6 +337,24 @@ DynamicProgrammingSolver::Solution DynamicProgrammingSolver::Impl::solve( SmallVector<Cut> cuts; size_t cur = 0; + /* \notes: In the layout selection problem, different operator layout configurations + * will produce tensors with same layout (i.e. same state in the DP problem). This + * means we sh...
fix(mgb/gopt): fix global layout transform
null
megengine/megengine
Apache License 2.0
C++
@@ -47,13 +47,13 @@ void AutofillDriver::ShowAutofillPopup( auto* view = web_contents->web_contents()->GetMainFrame()->GetView(); auto offset = view->GetViewBounds().origin() - embedder_view->GetViewBounds().origin(); - popup_bounds.Offset(offset.x(), offset.y()); + popup_bounds.Offset(offset); embedder_frame_host = em...
fix: use coordinate offsets in ShowAutofillPopup
null
electron/electron
MIT License
C++
@@ -739,7 +739,7 @@ impl<'a, 'b> Parser<'a, 'b> #[cfg(not(target_os = "windows"))] use std::os::unix::ffi::OsStrExt; #[cfg(target_os = "windows")] - use ossstringext::OsStrExt3; + use osstringext::OsStrExt3; let n_bytes = n.as_bytes(); let h_bytes = OsStr::new(h).as_bytes();
fix: fixes a misspelled import for Windows
null
clap-rs/clap
Apache License 2.0
Rust
@@ -132,13 +132,6 @@ class Element extends Node renderObject = initOverflowBox(renderObject, style, _scrollListener); } - // BoxModel Border - renderObject = initRenderDecoratedBox(renderObject, style, targetId); - - // Constrained box - renderObject = - renderConstrainedBox = initRenderConstrainedBox(renderObject, sty...
fix: support zIndex are negative values
null
openkraken/kraken
Apache License 2.0
Dart
@@ -150,7 +150,13 @@ function PureDistrictRow({ } const isDistrictRowEqual = (prevProps, currProps) => { - if (!equal(prevProps.data.last_updated, currProps.data.last_updated)) { + if (!equal(prevProps.data?.total, currProps.data?.total)) { + return false; + } else if (!equal(prevProps.data?.delta, currProps.data?.delt...
fix: Rows not showing updated delta values when switching dates
null
covid19india/covid19india-react
MIT License
JavaScript
@@ -195,7 +195,7 @@ export default { // #region Project Path const parsePath = (p: string) => - p.startsWith("~") ? path(p.replace("~", filesystem.homedir())) : path(p) + p?.startsWith("~") ? path(p?.replace("~", filesystem.homedir())) : path(p) const defaultTargetPath = path(projectName) let targetPath = useDefault(op...
fix(new): add optional chain to 'startsWith' in parsePath by
null
infinitered/ignite
MIT License
TypeScript
@@ -444,7 +444,7 @@ impl<'a, 't> InternalPrinter<'a, 't> { match **self.typ { Type::Builtin(BuiltinType::Int) => arena.text(format!("{}", i)), Type::Builtin(BuiltinType::Char) => - if i < ::std::u32::MAX as isize { + if 0 <= i && i <= ::std::u32::MAX as isize { match ::std::char::from_u32(i as u32) { Some('"') => arena...
fix(repl): Print out Char as the "character" instead of code point integer in the repl
null
gluon-lang/gluon
MIT License
Rust
@@ -566,7 +566,7 @@ public EntityBareJid getIdentifierAsJid() */ public String getUserNickname() { - return multiUserChat.getNickname().toString(); + return multiUserChat.getNickname() == null ? null : multiUserChat.getNickname().toString(); } /**
fix: Fixes NPE in xmpp getUserNickname
null
jitsi/jitsi
Apache License 2.0
Java
@@ -261,7 +261,7 @@ def _run_with_permission_query(query: "Query", doctype: str) -> list[dict]: """ permission_query = DatabaseQuery(doctype, frappe.session.user).get_permission_query_conditions() if permission_query: - query = f"{query.get_sql()} AND {permission_query}" + query = f"{query} AND {permission_query}" retu...
fix: Remove unnecessary `get_sql`
null
frappe/frappe
MIT License
Python
@@ -183,17 +183,19 @@ class CanvasRenderingContext2D { ImageElement imageElement = EventTarget.getEventTargetOfNativePtr(argv[0]) as ImageElement; double sx = 0.0, sy = 0.0, sWidth = 0.0, sHeight = 0.0, dx = 0.0, dy = 0.0, dWidth = 0.0, dHeight = 0.0; + if (argv.length == 3) { + dx = argv[1]; + dy = argv[2]; + } else i...
fix: fix canvas drawImage
null
openkraken/kraken
Apache License 2.0
Dart
@@ -6,6 +6,8 @@ __all__ = ['ConventionalCommitsCz'] def parse_scope(text): + if not text: + return None init_char = text[0] text = text.strip().title().split() text = list(''.join(text))
fix: parse scope empty
null
commitizen-tools/commitizen
MIT License
Python
@@ -958,14 +958,14 @@ std::tuple<std::vector<int32_t>, bool> tuple2vector(py::object shape) { } bool enable_fastpath(py::handle inp) { - // FIXME: the way to judge whether it is in traced module is inaccurate + auto&& tm_tr = TransformationManager::get_instance() + .segments[TransformationManager::Segment::ModuleTrace]...
fix(mge): fix fastpath check
null
megengine/megengine
Apache License 2.0
C++
@@ -44,6 +44,7 @@ function LinkWrapper(props: Props) { isCellVisible={props.isCellVisible} isHidden={props.isHidden} isHyperLink + isPadding isTextType onClick={() => { window.open(props.title, "_blank");
fix: align Table widget URL Column type
null
appsmithorg/appsmith
Apache License 2.0
TypeScript
@@ -93,13 +93,9 @@ open class Core: UIBaseObject, UIGestureRecognizerDelegate { } fileprivate func bindEventListeners() { - guard let mediaControl = self.mediaControl else { - return - } - #if os(iOS) - listenTo(mediaControl, eventName: InternalEvent.userRequestEnterInFullscreen.rawValue) { [weak self] _ in self?.fulls...
fix: listening fullscreen events on core
null
clappr/clappr-ios
BSD 3-Clause New or Revised License
Swift
@@ -389,7 +389,7 @@ def make_records(records, debug=False): # pass DuplicateEntryError and continue if e.args and e.args[0]==doc.doctype and e.args[1]==doc.name: # make sure DuplicateEntryError is for the exact same doc and not a related doc - pass + frappe.clear_messages() else: raise
fix: Clear DuplicateEntry message in setup
null
frappe/frappe
MIT License
Python
@@ -134,6 +134,8 @@ def review(doc, points, to_user, reason, review_type='Appreciation'): docname=review_doc.name ) + return review_doc + @frappe.whitelist() def get_reviews(doctype, docname): return frappe.get_all('Energy Point Log', filters={
fix: Return review doc on new review creation
null
frappe/frappe
MIT License
Python
@@ -22,7 +22,15 @@ public class PlayerScoreControl : MonoBehaviour, INeedInjection, IInjectionFinis { get { - return NormalNotesTotalScore + GoldenNotesTotalScore + PerfectSentenceBonusTotalScore; + int calculatedTotalScore = NormalNotesTotalScore + GoldenNotesTotalScore + PerfectSentenceBonusTotalScore; + if (calculat...
fix: do not return more than 10000 points for total score
null
ultrastar-deluxe/play
MIT License
C#
@@ -63,8 +63,10 @@ func DeleteClusterWorkflow(ctx workflow.Context, input DeleteClusterWorkflowInpu errs := make([]error, len(futures)) for i, future := range futures { + if future != nil { errs[i] = errors.Wrapf(future.Get(ctx, nil), "couldn't terminate node pool %q", nodePools[i].Name) } + } if err := errors.Combine(...
fix: delete PKE on AWS cluster failes due to nil pointer dereference
null
banzaicloud/pipeline
Apache License 2.0
Go
@@ -23,11 +23,16 @@ const addConnection = (port) => { const tab = port.sender.tab let connectionId + // Get the port name, connection ID if (port.name.indexOf(':') > -1) { const split = port.name.split(':') connectionId = split[1] port.name = split[0] - } else { + } + + // If we have tab information, use that for the c...
fix(BEX): Tab ID not available from app comm layer in FF
null
quasarframework/quasar
MIT License
JavaScript
@@ -31,6 +31,7 @@ pub struct SubscriptionCommand { pub enum SubscriptionSubcommand { /// Show the details of a single subscription. /// You can use either the subscription ID or the space ID. + #[command(arg_required_else_help = true)] Show { /// Subscription ID #[arg(group = "id")]
fix(rust): show help output when no args passed
null
ockam-network/ockam
Apache License 2.0
Rust
static Instrumentation instrumentation; - public static void premain(@NonNull String agentArgs, @NonNull Instrumentation inst) { + public static void premain(@Nullable String agentArgs, @NonNull Instrumentation inst) { Premain.instrumentation = inst; }
fix(wrapper): agent args may be null
null
cloudnetservice/cloudnet-v3
Apache License 2.0
Java
@@ -102,18 +102,17 @@ public class ActivitiGraphQLStarterIT { } @Test - public void testGraphqlWsSubprotocolServerSupported() { + public void testGraphqlWsSubprotocolConnectionInitXAuthorizationSupported() { ReplayProcessor<String> output = ReplayProcessor.create(); keycloakTokenProducer.setKeycloakTestUser(TESTADMIN);...
fix: test for X-Authorization on connection init
null
activiti/activiti-cloud
Apache License 2.0
Java
@@ -80,15 +80,27 @@ class Course::LessonPlan::Strategies::FomoPersonalizationStrategy < (!items_to_shift.nil? && !items_to_shift.include?(item.id)) end + def item_is_straggling(personal_time, reference_time) + if reference_time.end_at.present? && personal_time.end_at.present? + reference_time.end_at < personal_time.end...
fix(fomo): compute now handles omitted bonus_end_at, end_at
null
coursemology/coursemology2
MIT License
Ruby
@@ -11,7 +11,7 @@ function podlove_pwp5_init() function podlove_pwp5_attributes($attributes) { - $post_id = $attributes['post_id'] ?? get_the_ID(); + $post_id = (isset($attributes['post_id']) && $attributes['post_id']) ? $attributes['post_id'] : get_the_ID(); $episode = Episode::find_one_by_post_id($post_id); $post = g...
fix: legacy compatible PHP syntax
null
podlove/podlove-publisher
MIT License
PHP
@@ -21,6 +21,10 @@ amdFile=$(find "$HOME/project/dist" -name "*darwin_amd64.tar*") armFile=$(find "$HOME/project/dist" -name "*darwin_arm64.tar*") macFiles=("${amdFile}" "${armFile}") +version=$(make version) +plutil -insert CFBundleShortVersionString -string "$version" ~/project/info.plist +plutil -insert CFBundleVers...
fix: Add version number to MacOS packages
null
influxdata/telegraf
MIT License
Shell
@@ -29,7 +29,7 @@ function loader(this: Webpack, contents: string) { const instanceOrError = getTypeScriptInstance(options, this); if (instanceOrError.error !== undefined) { - callback(instanceOrError.error); + callback(new Error(instanceOrError.error.message)); return; }
fix(loader): new Error to webpack when errors occured in the loader function
null
typestrong/ts-loader
MIT License
TypeScript
@@ -199,7 +199,7 @@ class Entries continue; } - $_id = ltrim(rtrim(str_replace(PATH['project'] . '/entries/', '', $current_entry->getPath()), '/'), '/'); + $_id = $uid = ltrim(rtrim(str_replace(PATH['project'] . '/entries/', '', str_replace('\\', '/', $current_entry->getPath())), '/'), '/'); $this->entries[$_id] = $thi...
fix(entries): fix issue with entries paths on Windows
null
flextype/flextype
MIT License
PHP
@@ -186,7 +186,7 @@ def main(): out.error("Command is required") raise SystemExit() - if args.name: + if args.name and not conf.path: conf.update({"name": args.name}) if args.version:
fix(cli): fix name cannot be overwritten through config in newly refactored config design
null
commitizen-tools/commitizen
MIT License
Python
@@ -288,7 +288,7 @@ fn prepare_long_header<'a>( return match bytes { Cow::Borrowed(bytes) => { - let s = str::from_utf8(bytes).map_err(|_| not_unicode(bytes))?; + let s = std::str::from_utf8(bytes).map_err(|_| not_unicode(bytes))?; Ok(Cow::Borrowed(Path::new(s))) } Cow::Owned(bytes) => { @@ -297,11 +297,16 @@ fn prepar...
fix: hopefully get windows compiling
null
rs-ipfs/rust-ipfs
Apache License 2.0
Rust
@@ -155,9 +155,9 @@ static void lrec_it_link_write(LogRec *logrec, char *bufptr) ITLinkLog *log = (ITLinkLog*)logrec; ITLinkData *body = &log->body; struct lrec_item_common *cm = (struct lrec_item_common*)&body->cm; - int offset = offsetof(ITLinkData, data); + int offset = sizeof(LogHdr) + offsetof(ITLinkData, data); -...
fix: fix the length of a log record
null
naver/arcus-memcached
Apache License 2.0
C
@@ -50,7 +50,7 @@ def python_component(name, @dsl.python_component( name='my awesome component', - description='Come, Let's play', + description='Come, Let\'s play', base_image='tensorflow/tensorflow:1.11.0-py3', ) def my_component(a: str, b: int) -> str:
fix(sdk): Fix invalid doc example of python_component
null
kubeflow/pipelines
Apache License 2.0
Python
@@ -213,7 +213,8 @@ func (b *websocketBroker) ServeHTTP() service.Handler { return func(ctx context.Context, w http.ResponseWriter, r *http.Request) (err error) { c, err := upgrader.Upgrade(w, r, nil) if err != nil { - return sdk.WithStack(err) + service.WriteError(ctx, w, r, sdk.WithStack(sdk.ErrWebsocketUpgrade)) + r...
fix(api): handle websocket upgrade error
null
ovh/cds
BSD 3-Clause New or Revised License
Go
-export default function generateHapiPath(path, options, serverless) { +export default function generateHapiPath(path = '', options, serverless) { // path must start with '/' let hapiPath = path.startsWith('/') ? path : `/${path}`
fix: Handle star routes
null
dherault/serverless-offline
MIT License
JavaScript
@@ -23,6 +23,7 @@ package version import ( "os" + "strings" "github.com/heroku/docker-registry-client/registry" log "github.com/sirupsen/logrus" @@ -57,7 +58,7 @@ func GetHelperImageVersion() string { if len(Version) == 0 { return "latest" } - return Version + return strings.TrimPrefix(Version, "v") } // GetK3sVersion ...
fix: trim 'v' prefix when getting helper image tag version due to the new semver release pipeline
null
rancher/k3d
MIT License
Go
@@ -6,7 +6,7 @@ set -u git clone --depth 1 git@github.com:bigcommerce/checkout-sdk-js-server.git /tmp/repo-server # Copy previous releases into a folder for further modification -cp -rf /tmp/repo-server/public ~/repo/dist-cdn +cp -rf /tmp/repo-server/public/* ~/repo/dist-cdn # Rewrite the placeholder text contained in ...
fix(common): Fix path to copy previous releases from
null
bigcommerce/checkout-sdk-js
MIT License
Shell
@@ -193,8 +193,6 @@ class CDateTimeParserTest extends CTestCase { // empty parsed string $this->assertFalse(CDateTimeParser::parse('', 'dd MMMM, yyyy, HH:mm')); - $this->assertFalse(CDateTimeParser::parse(false, 'dd MMMM, yyyy, HH:mm')); - $this->assertFalse(CDateTimeParser::parse(null, 'dd MMMM, yyyy, HH:mm')); // acc...
fix: do not pass `null` into `CDateTimeParser::parse`
null
yiisoft/yii
BSD 3-Clause New or Revised License
PHP
@@ -199,10 +199,10 @@ public class UpdateOrganizationAction implements Serializable { try { setCustomMessages(); organizationService.updateOrganization(this.organization); - if(StringUtils.isNotEmpty(smtpPasswordDecrypted) && smtpPasswordDecrypted!=null){ + if(StringUtils.isNotEmpty(smtpPasswordDecrypted)){ smtpConfigu...
fix: improvement of code;
null
gluufederation/oxtrust
MIT License
Java
@@ -311,6 +311,8 @@ func guestDestPrepareMigrate(ctx context.Context, sid string, body jsonutils.JSO params.QemuVersion = qemuVersion params.LiveMigrate = liveMigrate params.SourceQemuCmdline = qemuCmdline + params.EnableTLS = jsonutils.QueryBoolean(body, "enable_tls", false) + if params.EnableTLS { certsObj, err := bo...
fix(host): dist prepare migrate_certs
null
yunionio/yunioncloud
Apache License 2.0
Go
@@ -750,11 +750,17 @@ public void setVideoStreamCount(int streamCount) { logger.info( "Video stream count for: " + jid + ": " + streamCount); + } int estimatedBefore = getEstimatedVideoStreamCount(); this.videoStreamCount = streamCount; + // The event for video streams count diff are processed on + // a single threaded...
fix(BridgeSelector): quick fix for conference burst
null
jitsi/jicofo
Apache License 2.0
Java
@@ -8,6 +8,7 @@ from pathlib import Path import inspect import importlib import subprocess +import re from pypipe.parameters import ParameterSet @@ -91,8 +92,7 @@ class ScriptTask(Task): def filter_params(self, params): # TODO: remove - task_func = self.get_task_func() - return FuncTask.get_reguired_params(task_func, p...
fix: fixed jupyter & script tasks according to the
null
miksus/rocketry
MIT License
Python
@@ -142,7 +142,7 @@ class SearchFragment : Fragment() { override fun onDestroy() { super.onDestroy() - if (searchView != null) - searchView?.setOnQueryTextListener(null) + if (this::searchView.isInitialized) + searchView.setOnQueryTextListener(null) } } \ No newline at end of file
fix: Crash in Search fragment
null
fossasia/open-event-attendee-android
Apache License 2.0
Kotlin
@@ -200,6 +200,10 @@ public class MainWindow extends JFrame { openFileOrProject(); } else { open(Paths.get(settings.getFiles().get(0))); + } + } + + private void handleSelectClassOption() { if (settings.getCmdSelectClass() != null) { JavaNode javaNode = wrapper.searchJavaClassByClassName(settings.getCmdSelectClass()); ...
fix(gui): resolve --select-class option regression (PR
null
skylot/jadx
Apache License 2.0
Java
@@ -24,29 +24,40 @@ namespace BugsnagUnity.Editor private void OnEnable() { titleContent.text = "Bugsnag"; + CheckForSettingsCreation(); } [MenuItem("Window/Bugsnag/Configuration")] public static void ShowWindow() { + CheckForSettingsCreation(); GetWindow(typeof(BugsnagEditor)); } - private static bool SettingsFileFoun...
fix(settings): create settings file outside OnGui loop
null
bugsnag/bugsnag-unity
MIT License
C#
@@ -113,7 +113,7 @@ def confirm_deletion(email, name, host_name): if doc.status == 'Pending Verification': doc.status = 'Pending Approval' doc.save(ignore_permissions=True) - doc.notify_system_managers(doc) + doc.notify_system_managers() frappe.db.commit() frappe.respond_as_web_page(_("Confirmed"), _("The process for d...
fix: Do not pass doc to notify_system_managers method
null
frappe/frappe
MIT License
Python
@@ -76,6 +76,10 @@ final class ConstructingAggregateRootRepository implements AggregateRootReposito public function persistEvents(AggregateRootId $aggregateRootId, int $aggregateRootVersion, object ...$events): void { + if (count($events) === 0) { + return; + } + // decrease the aggregate root version by the number of ...
fix: Avoid persisting when events are empty
null
eventsaucephp/eventsauce
MIT License
PHP
@@ -94,6 +94,10 @@ func (g *MphMatcherGroup) Build() { g.ac.Build() } keyLen := len(*g.ruleMap) + if keyLen == 0 { + keyLen = 1 + (*g.ruleMap)["empty___"] = RollingHash("empty___") + } g.level0 = make([]uint32, nextPow2(keyLen/4)) g.level0Mask = len(g.level0) - 1 g.level1 = make([]uint32, nextPow2(keyLen))
fix: core panics when zero domain/full type of rule
null
v2fly/v2ray-core
MIT License
Go
@@ -377,7 +377,8 @@ class HTMLRenderer extends AbstractRenderer // Create an external link to rule's help, if there's any provided. $linkHtml = null; - if ($url = $violation->getRule()->getExternalInfoUrl()) { + $url = $violation->getRule()->getExternalInfoUrl(); + if ($url) { $linkHtml = "<a class='info-lnk' href='{$u...
fix: Avoid assigning values to variables in if clauses and the like
null
phpmd/phpmd
BSD 3-Clause New or Revised License
PHP
@@ -52,7 +52,7 @@ export function login (params, callbackId) { } } -const getUserInfo = function (params, callbackId) { +export function getUserInfo (params, callbackId) { const provider = params.provider || 'weixin' const loginService = loginServices[provider] if (!loginService || !loginService.authResult) { @@ -61,9 ...
fix: app-plus uni.getUserInfo
null
dcloudio/uni-app
Apache License 2.0
JavaScript
@@ -154,6 +154,7 @@ const makeManifest = async ({ delete manifest.crossOrigin delete manifest.icon_options delete manifest.include_favicon + delete manifest.cacheDigest // If icons are not manually defined, use the default icon set. if (!manifest.icons) {
fix(gatsby-plugin-manifest): Delete `cacheDigest` from generated webmanifest
null
gatsbyjs/gatsby
MIT License
JavaScript
@@ -835,9 +835,13 @@ rp_grp_entry_t *rp_grp_match(uint32_t group) if (curr_group_mask > mask_ptr->group_mask) continue; - /* reset best priority while mask get longer */ + /* reset best priority/address/hash value while mask get longer */ if (curr_group_mask < mask_ptr->group_mask) + { best_priority = ~0; + best_addres...
fix: on rp election, some variables are not reset
null
troglobit/pimd
BSD 3-Clause New or Revised License
C
@@ -219,7 +219,7 @@ private void SetCursor(Cursor cursor, StreamSequenceToken sequenceToken) } else { - throw new QueueCacheMissException(cursor.SequenceToken, + throw new QueueCacheMissException(sequenceToken, messageBlocks.Last.Value.GetOldestSequenceToken(cacheDataAdapter), messageBlocks.First.Value.GetNewestSequenc...
fix: wrong parameter used when throwing QueueCacheMissException
null
dotnet/orleans
MIT License
C#
@@ -109,7 +109,7 @@ class TestPipeline(object): @freeze_time(FROZEN_TIME) @patch("datahub.ingestion.source.kafka.KafkaSource.get_workunits", autospec=True) - def test_configure_with_file_sink_does_not_init_graph(self, mock_source): + def test_configure_with_file_sink_does_not_init_graph(self, mock_source, tmp_path): pi...
fix(ingest): use temp dir for file generated during test
null
linkedin/datahub
Apache License 2.0
Python
@@ -457,7 +457,7 @@ def accept(web_form, data, docname=None, for_payment=False): if files_to_delete: for f in files_to_delete: if f: - remove_file_by_url(doc.get(fieldname), doctype=doc.doctype, name=doc.name) + remove_file_by_url(f, doctype=doc.doctype, name=doc.name) frappe.flags.web_form_doc = doc
fix: Clearing attachment from web form causes error on save
null
frappe/frappe
MIT License
Python
@@ -154,10 +154,16 @@ class KnowledgeBasedDataLoader(AbstractDataLoader): return self._next_batch_data() def __len__(self): + if self.state == KGDataLoaderState.KG: + return len(self.kg_dataloader) + else: return len(self.general_dataloader) @property def pr_end(self): + if self.state == KGDataLoaderState.KG: + return ...
fix: fix for kg dataloader's len && pr_end
null
rucaibox/recbole
MIT License
Python
@@ -528,8 +528,8 @@ class VirtualPage_Controller extends Page_Controller { * We can't load the content without an ID or record to copy it from. */ public function init(){ - if(isset($this->record) && $this->record->ID){ - if($this->record->VersionID != $this->failover->CopyContentFrom()->Version){ + if(isset($this->rec...
fix: Fix VirtualPage::init() content-modification check
null
silverstripe/silverstripe-cms
BSD 3-Clause New or Revised License
PHP
@@ -126,7 +126,7 @@ public class JPAPushApplicationDao extends JPABaseDao<PushApplication, String> i Long count = entityManager.createQuery("select count(*) " + select, Long.class).getSingleResult(); - List<PushApplication> entities = entityManager.createQuery("select pa " + select, PushApplication.class) + List<PushAp...
fix: sort applications by name
null
aerogear/aerogear-unifiedpush-server
Apache License 2.0
Java
@@ -79,7 +79,9 @@ class Duration { if (typeof input === 'string') { const d = input.match(durationRegex) if (d) { - [,, + const properties = d.slice(2) + const numberD = properties.map(value => Number(value)); + [ this.$d.years, this.$d.months, this.$d.weeks, @@ -87,7 +89,7 @@ class Duration { this.$d.hours, this.$d.mi...
fix: Update duration plugin change string to number
null
iamkun/dayjs
MIT License
JavaScript
@@ -43,11 +43,11 @@ class TeamForm extends Component<Props & FormProps, State> { this.fetchUser(); } - fetchUser = () => { + fetchUser = (query = '') => { this.lastFetchId += 1; const fetchId = this.lastFetchId; this.setState({ users: [], fetching: true }); - request(`${api.user}?limit=1000`).then((res) => { + request(...
fix: search users
null
didi/nightingale
Apache License 2.0
TypeScript
@@ -14,17 +14,15 @@ export function htmlFallbackMiddleware( rewrites: [ { from: /\/$/, - to({ parsedUrl }: any) { + to({ parsedUrl, request }: any) { const rewritten = decodeURIComponent(parsedUrl.pathname) + 'index.html' if (fs.existsSync(path.join(root, rewritten))) { return rewritten - } else { - if (spaFallback) { ...
fix(mpa): support mpa fallback
null
vitejs/vite
MIT License
TypeScript
@@ -27,12 +27,12 @@ public class ParticipantOptions /** * The property name for the type of the participant option. */ - private static final String PROP_TYPE = "TYPE"; + private static final String PROP_TYPE = "type"; /** * The property name for the name of the participant option. */ - private static final String PROP...
fix(ParticipantFactory): make keys lower case
null
jitsi/jitsi-meet-torture
Apache License 2.0
Java
@@ -12,6 +12,8 @@ class IconsController extends Controller { public function __construct(Filesystem $files, BlockMaker $blockMaker) { + parent::__construct(); + $this->files = $files; $this->blockMaker = $blockMaker; }
fix: Call parent constructor in IconsController
null
area17/twill
Apache License 2.0
PHP
@@ -199,19 +199,16 @@ func (s *Statement) unpipeline(task *api.TaskInfo) error { task.Job, s.ssn.UID) } - hostname := task.NodeName - task.NodeName = "" - - if node, found := s.ssn.Nodes[hostname]; found { + if node, found := s.ssn.Nodes[task.NodeName]; found { if err := node.RemoveTask(task); err != nil { klog.Errorf(...
fix: reset task.NodeName after call DeallocateFunc
null
volcano-sh/volcano
Apache License 2.0
Go
@@ -55,7 +55,7 @@ defmodule Ash.Error do parent_error_module = @error_modules[error.class] if parent_error_module == error.__struct__ do - parent_error_module.exception(errors: (error.errors || []) ++ other_errors) + %{error | errors: (error.errors || []) ++ other_errors} else parent_error_module.exception(errors: erro...
fix: parent error messages
null
ash-project/ash
MIT License
Elixir
@@ -11,7 +11,7 @@ use ockam_core::compat::{boxed::Box, collections::BTreeMap, string::String}; use ockam_core::errcode::{Kind, Origin}; use ockam_core::route; use ockam_identity::authenticated_storage::mem::InMemoryStorage; -use ockam_identity::{Identity, TrustEveryonePolicy}; +use ockam_identity::{Identity, IdentityId...
fix(rust): fix `NodeMan` usage in tests
null
ockam-network/ockam
Apache License 2.0
Rust
@@ -21,6 +21,7 @@ type fakeProviderNetwork struct { connectDelay time.Duration queriesMadeMutex sync.RWMutex queriesMade int + liveQueries int } func (fpn *fakeProviderNetwork) ConnectTo(context.Context, peer.ID) error { @@ -31,6 +32,7 @@ func (fpn *fakeProviderNetwork) ConnectTo(context.Context, peer.ID) error { func ...
fix: flaky provider query manager
null
ipfs/go-bitswap
MIT License
Go
@@ -418,7 +418,8 @@ defmodule Timex.Format.DateTime.Formatter do hour = format_token(locale, :hour24, date, modifiers, flags, width_spec(2..2)) min = format_token(locale, :min, date, modifiers, flags, width_spec(2..2)) sec = format_token(locale, :sec, date, modifiers, flags, width_spec(2..2)) - "#{year}#{month}#{day}#{...
fix: fractional seconds should be present in asn1 generalized format
null
bitwalker/timex
MIT License
Elixir
@@ -18,7 +18,7 @@ const withReconfiguration = <Props extends {}>( render(): React.ReactNode { return ( <AdapterContext.Consumer> - {reconfigure => ( + {({ reconfigure }) => ( <Component {...this.props} {...{ [propKey]: reconfigure }} /> )} </AdapterContext.Consumer>
fix(react): with-adapter-reconfiguration
null
tdeekens/flopflip
MIT License
TypeScript
@@ -462,6 +462,10 @@ func ParseEvent(request *http.Request) *scm.EventData { switch event := event.(type) { case *gitlab.TagEvent: + if event.Before != "0000000000000000000000000000000000000000" { + log.Warning("Skip unsupported action 'Tag updated or deleted' of Gitlab.") + return nil + } return &scm.EventData{ Type: ...
fix: GitLab tag deletion should not trigger workflow
null
caicloud/cyclone
Apache License 2.0
Go
* contains user-defined expression function's signature and body. * Please put user defined structs, helper functions etc. in ExprUtil.hpp */ -#include "tg_ExprUtil.hpp" +#include "ExprUtil.hpp" namespace tg_UDIMPL { typedef std::string string; //XXX DON'T REMOVE
fix(udf): change namespace from prospective `tg_UDIMPL` back to `UDIMPL`
null
tigergraph/gsql-graph-algorithms
Apache License 2.0
C++
@@ -95,11 +95,13 @@ class MarkdownReporter( } override fun verifyConsumerFromUrl(pactUrl: UrlPactSource, consumer: IConsumerInfo) { - events.add(Event("verifyConsumerFromUrl", "From `${pactUrl.description()}`<br/>\n", listOf(pactUrl, consumer))) + events.add(Event("verifyConsumerFromUrl", "From `${pactUrl.description()...
fix: detek violations
null
pact-foundation/pact-jvm
Apache License 2.0
Kotlin
@@ -342,6 +342,10 @@ class BigQuerySource(SQLAlchemySource): def get_multiproject_project_id( self, inspector: Optional[Inspector] = None, run_on_compute: bool = False ) -> Optional[str]: + """ + Use run_on_compute = true when running queries on storage project + where you don't have job create rights + """ if self.con...
fix(bigquery): multi-project GCP setup run query through correct project
null
linkedin/datahub
Apache License 2.0
Python
@@ -120,12 +120,12 @@ open class AVFoundationPlayback: Playback { return CMTimeGetSeconds(item.asset.duration) } - if playbackType == .live { - if isDvrAvailable, let duration = seekableTimeRanges.first?.timeRangeValue.duration.seconds { - return duration - } else { - return 0 + if playbackType == .live, isDvrAvailable...
fix: updated duration to use all ranges in seekableTimeRanges instead of the first
null
clappr/clappr-ios
BSD 3-Clause New or Revised License
Swift
@@ -173,7 +173,7 @@ const createMenu = (win: BrowserWindow): Menu => { { type: 'separator' }, { label: i18next.t('toggleDevtools'), - accelerator: 'Cmd+Shift+I', + accelerator: 'Cmd+Option+I', click: (): void => { if (win.webContents.isDevToolsOpened()) { win.webContents.closeDevTools();
fix: accelerator for DevTools on macOS
null
sprout2000/leafview
MIT License
TypeScript
-#!/bin/bash -e +#!/bin/bash -ex # This script is used to run the demo project' tests with a bloated JS bundle. # See the original issue for the motivation behind this: https://github.com/wix/Detox/issues/3507 OS_PLATFORM=$1 -BUNDLE_PATH=./app.js +WORKING_DIR=$(pwd) +BUNDLE_FILE=app.js +BUNDLE_PATH=$WORKING_DIR/$BUNDLE...
fix(demo-rn-bloat-bundle-test): fix bundle path
null
wix/detox
MIT License
Shell
@@ -34,6 +34,7 @@ enum zmk_usb_conn_state zmk_usb_get_conn_state() { case USB_DC_SUSPEND: case USB_DC_CONFIGURED: case USB_DC_RESUME: + case USB_DC_CLEAR_HALT: return ZMK_USB_CONN_HID; case USB_DC_DISCONNECTED:
fix(usb): add USB_DC_CLEAR_HALT to supported states
null
zmkfirmware/zmk
MIT License
C
@@ -646,7 +646,7 @@ where let mut databases: Vec<_> = initialized.databases.iter().collect(); // ensure the databases come back sorted by name - databases.sort_by_key(|(name, _db)| (*name).clone()); + databases.sort_by_key(|(name, _db)| name.as_str()); let databases = databases .into_iter()
fix: Remove an unnecessary clone
null
influxdata/influxdb_iox
Apache License 2.0
Rust
@@ -227,6 +227,7 @@ public class SongAudioPlayer : MonoBehaviour } else { + audioPlayer.clip = null; DurationOfSongInMillis = 0; } } @@ -242,7 +243,7 @@ public class SongAudioPlayer : MonoBehaviour public void PlayAudio() { - if (!audioPlayer.isPlaying) + if (HasAudioClip && !audioPlayer.isPlaying) { audioPlayer.Play()...
fix: SongSelectScene: do not start playing last audio clip when current audio file does not exist
null
ultrastar-deluxe/play
MIT License
C#
@@ -311,6 +311,9 @@ public class DefaultSecurityService if ( isRecoveryLocked( credentials.getUsername() ) ) { + log.warn( "The account recovery operation for the given user is temporarily locked due to too " + + "many calls to this endpoint in the last '" + RECOVERY_LOCKOUT_MINS + "' minutes. Credentials:" + + credent...
fix: Rate limiting of user account recovery
null
dhis2/dhis2-core
BSD 3-Clause New or Revised License
Java
import json import threading +import time from getpass import getpass from pathlib import Path from typing import Any, Dict, Iterator, List, Optional, Tuple, Union @@ -309,8 +310,14 @@ class _PrivateKeyAccount(PublicKeyAccount): last_tx = tx_from_sender[-1] if last_tx.status == -1: return last_tx.nonce + 1 - else: - re...
fix: check that nonce has properly incremented
null
eth-brownie/brownie
MIT License
Python
@@ -44,6 +44,7 @@ import org.hisp.dhis.tracker.domain.Event; import org.hisp.dhis.tracker.domain.TrackedEntity; import org.hisp.dhis.util.ObjectUtils; +import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonProperty; import lombok.Builder; @@ -65,7 +66,9 @@ public class Tracker...
fix: When using redis TrackerErrorReport deserialization failure (2.36)
null
dhis2/dhis2-core
BSD 3-Clause New or Revised License
Java
* a suffix, it contains floats. An integer vector type can contain any type * of integer, from chars to shorts to unsigned long longs. */ -typedef float32x2_t __m64; +typedef int64x1_t __m64; typedef float32x4_t __m128; /* 128-bit vector containing 4 floats */ // On ARM 32-bit architecture, the float64x2_t is not suppo...
fix: Replace data type __m64i with __m64
null
dltcollab/sse2neon
MIT License
C
@@ -190,7 +190,9 @@ bool ElectronCrashReporterClient::GetShouldCompressUploads() { void ElectronCrashReporterClient::GetProcessSimpleAnnotations( std::map<std::string, std::string>* annotations) { - *annotations = global_annotations_; + for (auto&& pair : global_annotations_) { + (*annotations)[pair.first] = pair.secon...
fix: merge crash annotations instead of overwriting
null
electron/electron
MIT License
C++
@@ -65,8 +65,8 @@ def create_json_gz_file(data, dt, dn): "file_name": json_filename, "attached_to_doctype": dt, "attached_to_name": dn, - "content": compressed_content, - "decode": True}) + "content": compressed_content + }) _file.save() @frappe.whitelist()
fix: prepared_report.py
null
frappe/frappe
MIT License
Python
@@ -14,6 +14,7 @@ open class AVFoundationPlayback: Playback { fileprivate var kvoTimeRangesContext = 0 fileprivate var kvoBufferingContext = 0 fileprivate var kvoExternalPlaybackActiveContext = 0 + fileprivate var kvoPlayerRateContext = 0 dynamic fileprivate var player: AVPlayer? fileprivate var playerLayer: AVPlayerLa...
fix: pause on background issue
null
clappr/clappr-ios
BSD 3-Clause New or Revised License
Swift
@@ -191,7 +191,7 @@ mod tests { checkpoint::{PartitionCheckpoint, PersistCheckpointBuilder, ReplayPlanner}, min_max_sequence::OptionalMinMaxSequence, }; - use query::QueryChunk; + use query::{exec::ExecutorType, frontend::sql::SqlQueryPlanner, QueryChunk}; use test_helpers::assert_contains; use tokio_util::sync::Cancel...
fix: replay tests should not fail when awaiting on query results
null
influxdata/influxdb_iox
Apache License 2.0
Rust
@@ -7,7 +7,6 @@ import ( cliflag "k8s.io/component-base/cli/flag" "k8s.io/klog" "kubesphere.io/kubesphere/pkg/apiserver" - authoptions "kubesphere.io/kubesphere/pkg/apiserver/authentication/options" apiserverconfig "kubesphere.io/kubesphere/pkg/apiserver/config" "kubesphere.io/kubesphere/pkg/informers" genericoptions "...
fix: crash if configfile not provide
null
kubesphere/kubesphere
Apache License 2.0
Go
@@ -260,13 +260,17 @@ type TxEntry struct { } func NewTxEntry(key []byte, vLen int, hVal [sha256.Size]byte, vOff int64) *TxEntry { - return &TxEntry{ + e := &TxEntry{ k: make([]byte, len(key)), kLen: len(key), vLen: vLen, hVal: hVal, vOff: vOff, } + + copy(e.k, key) + + return e } func (e *TxEntry) setKey(key []byte) {...
fix(embedded/store): copy key inside TxEntry constructor
null
codenotary/immudb
Apache License 2.0
Go
@@ -11,6 +11,7 @@ import java.util.Collection; import java.util.Date; import java.util.List; +import org.apache.commons.lang.time.DateUtils; import org.camunda.bpm.engine.HistoryService; import org.camunda.bpm.engine.ManagementService; import org.camunda.bpm.engine.ProcessEngineConfiguration; @@ -71,6 +72,9 @@ public c...
fix(engine): adjust test to daylight saving time changes
null
camunda/camunda-bpm-platform
Apache License 2.0
Java
@@ -100,9 +100,6 @@ def clear_doctype_cache(doctype=None): for name in doctype_cache_keys: cache.delete_value(name) - # Clear all document's cache. To clear documents of a specific DocType document_cache should be restructured - clear_document_cache() - def clear_controller_cache(doctype=None): if not doctype: del frap...
fix: Post merge error
null
frappe/frappe
MIT License
Python
@@ -75,30 +75,9 @@ module.exports = function(filter, schema, castedDoc, options) { schema.eachPath(function(path, schemaType) { // Skip single nested paths if underneath a map - const isUnderneathMap = schemaType.path.endsWith('.$*') || - schemaType.path.indexOf('.$*.') !== -1; if (schemaType.path === '_id' && schemaTy...
fix(update): avoid setting single nested subdoc defaults if subdoc isn't set
null
automattic/mongoose
MIT License
JavaScript
@@ -470,6 +470,12 @@ func loadPolicyLine(line string, model model.Model) error { key := tokens[0] sec := key[:1] + if _, ok := model[sec]; !ok { + return fmt.Errorf("invalid RBAC policy: %s", line) + } + if _, ok := model[sec][key]; !ok { + return fmt.Errorf("invalid RBAC policy: %s", line) + } model[sec][key].Policy =...
fix: Fix a possible crash when parsing RBAC
null
argoproj/argo-cd
Apache License 2.0
Go
@@ -57,7 +57,12 @@ func (d SManagedVirtualizedGuestDriver) DoScheduleStorageFilter() bool { return func (d SManagedVirtualizedGuestDriver) DoScheduleCloudproviderTagFilter() bool { return true } func (self *SManagedVirtualizedGuestDriver) GetJsonDescAtHost(ctx context.Context, userCred mcclient.TokenCredential, guest *...
fix(region): user data fix
null
yunionio/yunioncloud
Apache License 2.0
Go
@@ -175,10 +175,12 @@ $app->group('/user', function () { //Reconstructed Payment System $this->post('/payment/purchase', 'App\Services\Payment:purchase'); - $this->post('/payment/notify', 'App\Services\Payment:notify'); $this->get('/payment/return', 'App\Services\Payment:returnHTML'); })->add(new Auth()); +$app->group(...
fix: Authentication error
null
chensee/ss-panel-v3-mod_uim-alipay-wxpay
MIT License
PHP
@@ -226,7 +226,7 @@ class ProgressPercentage: def __init__(self, filename, remote_path): self._filename = filename self._remote_path = remote_path - self._size = float(os.path.getsize(filename)) + self._size = os.path.getsize(filename) self._seen_so_far = 0 self._lock = threading.Lock()
fix: S3 uploader total size is now displayed as an int
null
aws/aws-sam-cli
Apache License 2.0
Python
@@ -216,6 +216,8 @@ void discord_on_guild_role_delete(struct discord *client, guild_role_delete_cb * void discord_on_guild_member_add(struct discord *client, guild_member_cb *callback); void discord_on_guild_member_update(struct discord *client, guild_member_cb *callback); void discord_on_guild_member_remove(struct dis...
fix: missing definition of discord_on_guild_ban_add() and discord_on_guild_ban_remove()
null
cee-studio/orca
MIT License
C
@@ -60,7 +60,7 @@ impl fmt::Display for LinkFormatter<'_> { if current == next_depth { count += 1; } else { - write!(fmt, "{}/", count)?; + write!(fmt, "{}: {}/", current, count)?; let steps_between = if current > next_depth { current - next_depth @@ -68,7 +68,7 @@ impl fmt::Display for LinkFormatter<'_> { next_depth -...
fix: full link block generation
null
rs-ipfs/rust-ipfs
Apache License 2.0
Rust
@@ -22,7 +22,7 @@ extension SignInResult { let deliveryDetails = AuthCodeDeliveryDetails(destination: .sms(codeDetails?.destination)) return .confirmSignInWithSMSMFACode(deliveryDetails, nil) case .customChallenge: - return .confirmSignInWithCustomChallenge(nil) + return .confirmSignInWithCustomChallenge(parameters) ca...
fix(auth): pass public challenge parameters in nextstep when authenticating with custom challenge
null
aws-amplify/amplify-ios
Apache License 2.0
Swift