message
stringlengths
13
484
diff
stringlengths
38
4.63k
Enforce usage of sqlite3 for running tests Simplifies tests by creating a database in memory Does not affect the user setup at all
@@ -159,7 +159,19 @@ WSGI_APPLICATION = 'InvenTree.wsgi.application' DATABASES = {} +""" +When running unit tests, enforce usage of sqlite3 database, +so that the tests can be run in RAM without any setup requirements +""" +if 'test' in sys.argv: + eprint('Running tests - Using sqlite3 memory database') + DATABASES['de...
settings_config: Add waiting_period_threshold_dropdown_values. This list will be used in further commits in settings_org.js code for waiting period threshold setting.
@@ -349,6 +349,21 @@ export const time_limit_dropdown_values = [ export const msg_edit_limit_dropdown_values = time_limit_dropdown_values; export const msg_delete_limit_dropdown_values = time_limit_dropdown_values; +export const waiting_period_threshold_dropdown_values = [ + { + description: $t({defaultMessage: "None"}...
Change layout for the index page Expanding one table doesn't force the neighbouring one to be expanded also
@@ -8,41 +8,19 @@ InvenTree | Index <h3>InvenTree</h3> <hr> -<div class="row"> - <div class="col-sm-6"> +<div class='col-sm-6'> {% include "InvenTree/latest_parts.html" with collapse_id="latest_parts" %} - </div> - <div class="col-sm-6"> - {% include "InvenTree/starred_parts.html" with collapse_id="starred" %} - </div>...
Skip codecov uploads in scheduled daily tests We can only upload a limited number of coverage reports for any commit anyway, this avoids turning these into test failures.
@@ -611,6 +611,7 @@ jobs: timeout-minutes: 6 - name: Upload coverage + if: ${{ github.event_name != 'schedule' }} uses: codecov/codecov-action@v3.1.0 with: file: ./coverage.xml
Remove my name :( ok max
@@ -12,7 +12,7 @@ GitHub. From this directory, ```console -jayden@NAGA:~/dev/holodeck/docs$ make clean && make html +~/dev/holodeck/docs$ make clean && make html ``` [This VSCode extension](https://marketplace.visualstudio.com/items?itemName=lextudio.restructuredtext)
Djongo A connector for using Django with MongoDB
@@ -114,7 +114,7 @@ various Python frameworks and libraries. Django, an `example: <https://github.com/MongoEngine/django-mongoengine/tree/master/example/tumblelog>`_. For more information `<http://docs.mongoengine.org/en/latest/django.html>`_ -* `Djongo <https://nesdis.github.io/djongo/>`_ Djongo is a connector for usi...
Force VSTS to update status For PR builds on branches we don't build anything, but we need to do something so that VSTS updates the status on GitHub for the pr builds.
@@ -123,3 +123,12 @@ phases: - task: mspremier.PostBuildCleanup.PostBuildCleanup-task.PostBuildCleanup@3 condition: always() + +- phase: Skip_libchromiumcontent_PR_build + condition: and(eq(variables['System.PullRequest.IsFork'], 'False'), eq(variables['Build.Reason'], 'PullRequest')) + steps: + - bash: | + echo "Skipp...
Refactor methods to use _get_text_and_embed This changes the converters used by caesarcipher_encrypt and caesarcipher_decrypt in order to accomodate for the manual conversion that _get_text_and_embed does, which allows for this feature to be easily disabled.
@@ -131,7 +131,7 @@ class Fun(Cog): await ctx.send(embed=embed) @staticmethod - async def _caesar_cipher(ctx: Context, offset: int, msg: Union[Message, str], left_shift: bool = False) -> None: + async def _caesar_cipher(ctx: Context, offset: int, msg: str, left_shift: bool = False) -> None: """ Given a positive integer...
Fix assertion for createami test Revert
@@ -59,14 +59,23 @@ def test_createami(region, os, instance, request, pcluster_config_reader, vpc_st + networking_args ) - pcluster_createami_result_stdout_list = [s.lower() for s in pcluster_createami_result.stdout.split("\n")] - assert_that( - any("downloading https://{0}-aws-parallelcluster.s3".format(region) in pcl...
Remove dead code for automatic Self promotion into Entity TN:
@@ -489,20 +489,6 @@ class FieldAccess(AbstractExpression): self.receiver_expr, self.node_data, self.type ) - def wrap_prefix_in_entity(self): - """ - Mutate this expression so that it wraps the prefix into an entity. - """ - from langkit.expressions.envs import make_as_entity - - assert not self.implicit_deref - asser...
Update tracking-arduino.py updated header comment to reflect as-is mrl development build number
# A script to test tracking on the Raspberry Pi driving servos with the AdaFruit16ServoDriver service -# as at mrl development build version 2423 +# as at mrl development build version 2489 # a mashup of code taken from Mats: # https://github.com/MyRobotLab/pyrobotlab/blob/master/home/Mats/Tracking.py # and also from G...
Move DispersiveQED tests into dispersive regime Prevents a warning being emitted, and makes sure the test is testing the behaviour it's intended to.
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ############################################################################### -import warnings import numpy as np import pytest import qutip @@ -70,7 +69,7 @@ single_gate_tests = [ device_lists = [ - pytest.param(DispersiveCavityQED, {"g":0.1}, id...
Speed up verify_broadcast() and verify_unicast() which had unnecessarily high timers, and improve their diagnostic messages. This improves overall integration test run time.
@@ -1427,13 +1427,13 @@ dbs: 'ether dst host ff:ff:ff:ff:ff:ff and ether src host %s' % host_a.MAC()) partials = [partial(host_a.cmd, self.scapy_bcast(host_a))] * packets tcpdump_txt = self.tcpdump_helper( - host_b, tcpdump_filter, partials, packets=packets) + host_b, tcpdump_filter, partials, packets=(packets - 1), ti...
Bug fix for Bug fix for improper handling of packages with - (dash) in name
@@ -265,7 +265,7 @@ class ReqsBaseFinder(BaseFinder): Flask-RESTFul -> flask_restful """ if self.mapping: - name = self.mapping.get(name, name) + name = self.mapping.get(name.replace("-","_"), name) return name.lower().replace("-", "_") def find(self, module_name: str) -> Optional[str]:
Fixed manifest details Path to PNGs Removed tests from the distro
@@ -4,12 +4,12 @@ include kicost/HISTORY.rst include LICENSE include README.rst include kicost/kicost.ico -include block_diag.png -include gui.png +include docs/block_diag.png +include docs/gui.png include kicost/kitspace.png -recursive-include tests * +#recursive-include tests * recursive-exclude * __pycache__ recursi...
Set unit caches as filled even when ref-counting is not involved ... as results must be invalidated anyway, it's not just about ref-counting. TN:
@@ -100,11 +100,12 @@ begin % if property.memoized: Self.${property.memoization_state_field_name} := Computed; + Self.${property.memoization_value_field_name} := Property_Result; + Set_Filled_Caches (Self.Unit); + % if property.type.is_refcounted: Inc_Ref (Property_Result); - Set_Filled_Caches (Self.Unit); % endif - Se...
llvm: Drop compiled function pointer update. This has been basically a dead code since ("llvm: Remove function pointer management and create ctype function directly")
@@ -141,9 +141,6 @@ def _updateNativeBinaries(module, buffer): # one passed to getrefcount function if sys.getrefcount(v) == 4: to_delete.append(k) - else: - new_ptr = _cpu_engine._engine.get_function_address(k) - v.ptr = new_ptr for d in to_delete: del _binaries[d]
Recommended fix for Issue Fixes
@@ -22,7 +22,7 @@ class Command(BaseCommand): def handle(self, *args, **options): """Create Customer objects for Subscribers without Customer objects associated.""" - for subscriber in get_subscriber_model().objects.filter(customer__isnull=True): + for subscriber in get_subscriber_model().objects.filter(djstripe_custom...
Add note When `step` argument is given, `suggest_float` falls back to `suggest_discrete_uniform` which includes both `low` and `high`.
@@ -136,6 +136,12 @@ class Trial(BaseTrial): high: Upper endpoint of the range of suggested values. ``high`` is excluded from the range. + + .. note:: + If ``step`` is specified, ``high`` is included as well as ``low`` because + this method falls back to :func:`~optuna.trial.Trial.suggest_discrete_uniform` + with ``ste...
Update example from .summary() add scale_factor argument to the output
@@ -170,6 +170,7 @@ class Element(ABC): Ip 0.329564 tag None color #b2182b + scale_factor 1 dof_global_index None type DiskElement dtype: object
Remove DGL_LOADALL=true DGL_LOADALL=true is not used in the code anymore.
@@ -19,7 +19,7 @@ mxnet: @echo "# Step 1: Building MXNet tutorials #" @echo "# #" @echo "##################################################################" - @DGLBACKEND=mxnet DGL_LOADALL=true $(SPHINXBUILD) -M html "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) + @DGLBACKEND=mxnet $(SPHINXBUILD) -M html "$(SOURCEDIR...
UI: Progress during optimization passes was off by one * Starting a module was counted as completing it, which is of course wrong.
@@ -241,7 +241,7 @@ def _restartProgress(): ) -def _traceProgress(current_module): +def _traceProgressModuleStart(current_module): optimization_logger.info_fileoutput( """\ Optimizing module '{module_name}', {remaining:d} more modules to go \ @@ -258,6 +258,7 @@ after that.""".format( item=current_module.getFullName(),...
Update brocade_fastiron_telnet.py Formatting changes to be PEP8 compliant
@@ -32,7 +32,6 @@ class BrocadeFastironTelnet(CiscoBaseConnection): delay_factor=delay_factor, max_loops=max_loops) - def _test_channel_read(self, count=40, pattern=""): """Try to read the channel (generally post login) verify you receive data back.""" @@ -133,16 +132,6 @@ class BrocadeFastironTelnet(CiscoBaseConnectio...
tests/transfer_mechanism/uniform_to_normal_noise: Set seeds of noise function instead of RandomState Results change since the 'seed' parameter is converted to list before use.
@@ -301,6 +301,8 @@ class TestDistributionFunctions: def test_transfer_mech_uniform_to_normal_noise(self): try: import scipy + except ModuleNotFoundError: + with pytest.raises(FunctionError) as error_text: T = TransferMechanism( name='T', default_variable=[0, 0, 0, 0], @@ -308,12 +310,8 @@ class TestDistributionFunctio...
Change unclaimed username As requested by
"url": "https://github.community/u/{}/summary", "urlMain": "https://github.community", "username_claimed": "jperl", - "username_unclaimed": "blue" + "username_unclaimed": "noonewouldusethis298" }, "GitLab": { "errorMsg": "[]",
portico: Update advance clicking on tour carousel. We shouldn't move the slide forward if the user is on the last slide. This commit adds an exception for the same.
@@ -243,8 +243,16 @@ var load = function () { // Move to the next slide on clicking inside the carousel container $(".carousel-inner .item-container").click(function (e) { - // We don't want to trigger this event if user clicks on a link - if (e.target.tagName.toLowerCase() !== "a" && e.target.tagName.toLowerCase() !==...
Update hue-dimmer-switch.yml Wrong class listed
name: Hue Dimmer switch (Philips) device_support: - - Light (E1744LightController; 350ms delay) + - Light (HueDimmerController; 350ms delay) integrations: - name: Zigbee2mqtt codename: z2m
Eliminate race condition between the snapshot creation wf and the scheduled execution by creating the snapshot before scheduling the execution
@@ -982,16 +982,16 @@ class ExecutionsTest(AgentlessTestCase): dep_id = dep.id do_retries(verify_deployment_env_created, 30, deployment_id=dep_id) + # Create snapshot and keep it's status 'started' + snapshot = self._create_snapshot_and_modify_execution_status( + Execution.STARTED) + scheduled_time = generate_scheduled...
create_spoken_forms: correct file extension regex The regex was previously matching any character, rather than just the period. This was resulting in some unsupported symbols in the relevant lists and other unintended behavior
@@ -22,11 +22,16 @@ mod = Module() DEFAULT_MINIMUM_TERM_LENGTH = 3 FANCY_REGULAR_EXPRESSION = r"[A-Z]?[a-z]+|[A-Z]+(?![a-z])|[0-9]+" FILE_EXTENSIONS_REGEX = "|".join( - file_extension.strip() + "$" for file_extension in file_extensions.values() + re.escape(file_extension.strip()) + "$" for file_extension in file_extens...
improve tutorial notebook and test_piecewise_linear Delete notebook (to be merged as markdown file), pwl tests name fixes
@@ -8,7 +8,7 @@ from gluonts.distribution import PiecewiseLinear @pytest.mark.parametrize( - "distr, target, expected_cdf, expected_crps", + "distr, target, expected_target_cdf, expected_target_crps", [ ( PiecewiseLinear( @@ -39,15 +39,19 @@ from gluonts.distribution import PiecewiseLinear def test_values( distr: Piece...
[ci] small fix to test_integration_wandb.py trial should be a fixture, instead of a function.
@@ -152,7 +152,7 @@ def wandb_env(): class TestWandbLogger: def test_wandb_logger_project_group(self, monkeypatch): monkeypatch.setenv(WANDB_PROJECT_ENV_VAR, "test_project_from_env_var") - monkeypatch.setenv(WANDB_GROUP_ENV_VAR, "test_group_env_var") + monkeypatch.setenv(WANDB_GROUP_ENV_VAR, "test_group_from_env_var") ...
Update exporting_models.md Conflicts with comment on following line, the comment is correct.
@@ -8,7 +8,7 @@ graph proto. A checkpoint will typically consist of three files: * model.ckpt-${CHECKPOINT_NUMBER}.meta After you've identified a candidate checkpoint to export, run the following -command from tensorflow/models/research/object_detection: +command from tensorflow/models/research/: ``` bash # From tensor...
Fix for grains with list of objects This commit will make it so that grains that are lists of complex objects will be flattened ensuring that comparisons can be made Fixes
@@ -44,6 +44,13 @@ def exists(name, delimiter=DEFAULT_TARGET_DELIM): ret['comment'] = 'Grain does not exist' return ret +def flatten(li, flattened = list()): + for subli in li: + if type(subli) == list: + flatten(subli, flattened) + else: + flattened.append(frozenset(subli)) + return set(flattened) def present(name, va...
[tests] Remove site_detect_tests.APIDisabledTestCase API is available for
@@ -176,15 +176,6 @@ class FailingSiteTestCase(SiteDetectionTestCase): self.assertNoSite('http://wiki.animutationportal.com/index.php/$1') -class APIDisabledTestCase(SiteDetectionTestCase): - - """Test MediaWiki sites without an enabled API.""" - - def test_linuxquestions(self): - """Test detection of MediaWiki sites f...
Fix passing env vars to CmdAction This fixes issue
@@ -189,8 +189,13 @@ class CmdAction(BaseAction): "CmdAction Error creating command string", exc) # set environ to change output buffering + subprocess_pkwargs = self.pkwargs.copy() env = None + if 'env' in subprocess_pkwargs: + env = subprocess_pkwargs['env'] + del subprocess_pkwargs['env'] if self.buffering: + if not...
fix breadcrumbs for root page on page listing when breadcrumbs show in the root page - it is the only item ensure the content is inset so that it shows correctly
{% load wagtailadmin_tags i18n %} {% block header_content %} - {% breadcrumbs parent_page 'wagtailadmin_explore' url_root_name='wagtailadmin_explore_root' %} - + {# Accessible page title #} <h1 class="w-sr-only"> {{ title }} </h1> + {# breadcrumbs #} + {% if parent_page.is_root %} + <div class="w-pl-3">{% breadcrumbs p...
Always lowercase role name Due to [1] ansible always access servers lowcase. Also, in respect to [2], this patch lowercase name which is use in fqdn, hostname, ssh_known_hosts and other places. [1] [2] Resolves: rhbz#1619556
@@ -411,7 +411,7 @@ resources: user_data: {get_resource: UserData} name: yaql: - expression: $.data.hostname_map.get($.data.hostname, $.data.hostname) + expression: $.data.hostname_map.get($.data.hostname, $.data.hostname).toLower() data: hostname: {get_param: Hostname} hostname_map: {get_param: HostnameMap}
admin: fix checkboxes widget This change from a function to an arrow function allows us to access the containing class with `this` in the line below.
@@ -43,7 +43,7 @@ export class CheckboxesInputWidget extends React.PureComponent { let { className, value, placeholder, type, onChange, ...otherProps } = this.props className = (className || '') + ' checkbox' - function onChangeHandler (field, event) { + const onChangeHandler = (field, event) => { const newValue = flip...
invitations: Make stream labels click targets. Label tags can't be nested in each other. Fixes
{{#if default_stream}}checked="checked"{{/if}} /> <span></span> {{#if invite_only}}<i class="fa fa-lock" aria-hidden="true"></i>{{/if}} - <label class="inline-block">{{name}}</label> + {{name}} </label> {{/each}} </div>
Set max bar width for BarChart Center bar chart when max width is reached. Close
@@ -366,6 +366,7 @@ class BarChart extends BaseChart { this.x1 = scaleBand(); this.y = scaleLinear(); this.selections = {}; + this.maxColumnWidth = 100; this.xAxis = axisBottom(this.x0) .tickSizeOuter(0); @@ -418,7 +419,11 @@ class BarChart extends BaseChart { } update() { - this.width = parseInt(container.style('width...
zapping the cmake files in package From my understanding these are not even required because they are generated by conan at isntall
@@ -39,20 +39,11 @@ class WebsocketPPConan(ConanFile): def package(self): self._patch_sources() - cmake = CMake(self) - cmake.configure() - cmake.install() self.copy(pattern="COPYING", dst="licenses", src=self._source_subfolder) # We have to copy the headers manually, since the current install() step in the 0.8.1 relea...
Update ug012_storm_ref_datamod.rst Minor tweaks for wording.
@@ -12,7 +12,7 @@ The operators below can be used to modify the Synapse hypergraph by: All of these operators are defined in `storm.py`__. -**IMPORTANT:** Synapse does not have an "are you sure?" prompt. Caution should be used with operators that can modify Synapse data, especially when used on the output of complex qu...
Improve part information display Better terminology
<td><b>Units</b></td> <td>{{ part.units }}</td> </tr> + {% if part.minimum_stock > 0 %} + <tr> + <td><b>Minimum Stock</b></td> + <td>{{ part.minimum_stock }}</td> + </tr> + {% endif %} </table> </div> <div class='col-sm-6'> <table class='table table-striped'> + {% if part.buildable %} <tr> - <td><b>Buildable</b></td> -...
Conditions: validate for self-dependencies - when setting the owner of a Condition, a warning will be thrown if the owner is a dependency of the Condition
@@ -273,7 +273,9 @@ Class Reference """ +import collections import logging +import warnings from psyneulink.core.globals.parameters import parse_execution_context from psyneulink.core.globals.utilities import call_with_pruned_args @@ -457,6 +459,26 @@ class Condition(object): return call_with_pruned_args(self.func, *(s...
Add major axis calculation To calculate the major axis we apply the shape functions to the complex values from the vector and then calculate the orbit for each of those values.
@@ -381,11 +381,14 @@ class Shape(Results): zn[pos0:pos1] = (node_pos * onn + Le * zeta).reshape(nn) # major axes calculation - # select orbits - orbits = self.orbits[n : n + 2] - major[pos0:pos1] = Nx @ np.array( - [orbits[0].major_axes, 0, orbits[1].major_axes, 0] - ) + xn_complex[pos0:pos1] = Nx @ evec[xx] + yn_comp...
Add Imputer for missing values Uses median strategy for numeric columns, and adds alternate value for missing values in categorical columns.
@@ -3,6 +3,7 @@ import numpy as np import pandas as pd import tensorflow as tf from sklearn.compose import ColumnTransformer +from sklearn.impute import SimpleImputer from sklearn.model_selection import train_test_split from sklearn.pipeline import Pipeline from sklearn.preprocessing import OneHotEncoder, StandardScale...
TargetDescription: generate default config Added a method to TargetDescrition to generate a dict with the default config for that description.
@@ -82,6 +82,14 @@ class TargetDescription(object): self._set('platform_params', platform_params) self._set('conn_params', conn_params) + def get_default_config(self): + param_attrs = ['target_params', 'platform_params', 'conn_params'] + config = {} + for pattr in param_attrs: + for n, p in getattr(self, pattr).iterval...
[dagit] Point to AssetMaterialization Summary: Resolves Test Plan: Buildkite. Reviewers: schrockn, sandyryza
@@ -72,10 +72,11 @@ export const AssetsCatalogTable: React.FunctionComponent<{prefixPath: string[]}> <p> There are no {prefixPath.length ? 'matching ' : 'known '} materialized assets with {prefixPath.length ? 'the ' : 'a '} - specified asset key. Any asset keys that have been specified with a{' '} - <code>Materializati...
Adds ability to do inline translations Allows user to enter translation requests on one line rather than having to enter everything separately. Defaults to staged information input if the rest of the command after "translate" cannot be corrected parsed.
-from plugin import plugin, require +from plugin import plugin, require, alias from googletrans import Translator from googletrans.constants import LANGCODES, LANGUAGES, SPECIAL_CASES @require(network=True) +@alias('trans') @plugin('translate') def translate(jarvis, s): """ translates from one language to another. """ ...
Document python_app target in Python readme. Support for `python_app` targets was added in - here we add documentation in the Python readme.
@@ -151,6 +151,39 @@ Use `test` to run the tests. This uses `pytest`: SUCCESS $ +Python Apps for Deployment +-------------------------- + +For deploying your Python apps, Pants can create archives (e.g.: tar.gz, zip) that contain an +executable pex along with other files it needs at runtime (e.g.: config files, data se...
docs: Update README.md * Update README.md Adding a SAM workshop * capitalize * using url shortener to track
![Install](https://img.shields.io/badge/brew-aws--sam--cli-orange) ![pip](https://img.shields.io/badge/pip-aws--sam--cli-9cf) -[Installation](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html) | [Blogs](https://serverlessland.com/blog?tag=AWS%20SAM) | [Videos...
Improve run_docker_test to handle multiple compose files This feature is required for cross-repository testing.
@@ -66,6 +66,14 @@ def main(): '-f', compose_file ] + # Search for extra compose files and add them to the compose command + if args.extra_file: + for file in args.extra_file: + extra_file = _get_compose_file(file) + compose = compose + [ + '-f', extra_file + ] + compose_up = compose + [ 'up', '--abort-on-container-exi...
Update README.md Forgot to remove old license reference
@@ -216,5 +216,3 @@ We now have a [blogpost](https://medium.com/twentybn/towards-situated-visual-ai- The code is copyright (c) 2020 Twenty Billion Neurons GmbH under an MIT Licence. See the file LICENSE for details. Note that this license only covers the source code of this repo. Pretrained weights come with a separate...
users: Pass email_address_visibility as parameter to can_access_delivery_email. This is a prep commit for adding user-level email visibility setting.
@@ -394,12 +394,11 @@ def validate_user_custom_profile_data( raise JsonableError(error.message) -def can_access_delivery_email(user_profile: UserProfile) -> bool: - realm = user_profile.realm - if realm.email_address_visibility == Realm.EMAIL_ADDRESS_VISIBILITY_ADMINS: +def can_access_delivery_email(user_profile: UserP...
TrivialFix: Move portbindings to neutron-lib Now that neutron-lib houses portbindings api, move the constants section from neutron to neutron-lib in networking-odl. TrivialFix Partially-implements: blueprint neutron-lib-adoption
# License for the specific language governing permissions and limitations # under the License. # - -from neutron.extensions import portbindings from neutron.services.trunk import constants as t_consts +from neutron_lib.api.definitions import portbindings + SUPPORTED_INTERFACES = ( portbindings.VIF_TYPE_OVS,
improved Embed integer check Previous check was not accepting some valid integer types such as int8.
@@ -373,7 +373,7 @@ class Embed(Module): Output which is embedded input data. The output shape follows the input, with an additional `features` dimension appended. """ - if inputs.dtype not in [jnp.int32, jnp.int64, jnp.uint32, jnp.uint64]: + if not jnp.issubdtype(inputs.dtype, jnp.integer): raise ValueError('Input typ...
Update FORWARD_TRAFFIC.yml Support for fortinet (FortiOS 5.4)
-# Logs files identified as type=traffic and subtype=forward (FortiOs 5.4) +# Logs files identified as type=traffic and subtype=forward (FortiOs 5.4). # # <189>date=2019-04-09 time=04:27:29 devname=fw01 devid=FG800D0123456789 logid=0000000013 type=traffic subtype=forward # level=notice vd=root srcip=1.1.1.1 srcport=199...
Remove complex statement from `if`, instead use let binding Clippy warns that the statement used in the `if` clause is complex and should be part of a let binding and then test the variable that is bound.
@@ -123,9 +123,11 @@ impl<'b, 't, B: BatchIndex + 'b, T: TransactionIndex + 't> ChainCommitState<'b, return Err(ChainCommitStateError::DuplicateBatch((*id).into())); } - if self.batch_index.contains(&id).map_err(|err| { + let batch_is_contained = self.batch_index.contains(&id).map_err(|err| { ChainCommitStateError::Err...
WIP add an accept rule instead of modifying surt in place for seed redirects
@@ -203,10 +203,12 @@ class Site(doublethink.Document, ElapsedMixIn): def note_seed_redirect(self, url): new_scope_surt = brozzler.site_surt_canon(url).surt().decode("ascii") + if not "accepts" in self.scope: + self.scope["accepts"] = [] if not new_scope_surt.startswith(self.scope["surt"]): - self.logger.info("changing...
[java-services] add new transient error See We encounter a `is.hail.relocated.com.google.cloud.storage.StorageException` which is caused by a `com.google.api.client.http.HttpResponseException`. The latter exception is not currently considered a transient error. This PR changes isTransientError to recognize `HttpRespons...
@@ -14,6 +14,7 @@ import scala.util.Random import java.io._ import com.google.cloud.storage.StorageException import com.google.api.client.googleapis.json.GoogleJsonResponseException +import com.google.api.client.http.HttpResponseException package object services { lazy val log: Logger = LogManager.getLogger("is.hail.se...
using new conan 1.24.0 tools.cppstd_flag in boost recipe fixes
from conans import ConanFile from conans import tools -from conans.client.build.cppstd_flags import cppstd_flag -from conans.tools import Version +from conans.tools import Version, cppstd_flag from conans.errors import ConanException from conans.errors import ConanInvalidConfiguration @@ -568,12 +567,7 @@ class BoostCo...
Maybe I don't have to be that pedantic I still think that some data can't be trusted.
@@ -324,6 +324,7 @@ class URLPlaylistEntry(BasePlaylistEntry): # Move the temporary file to it's final location. os.rename(unhashed_fname, self.filename) + if self.duration == None: # Get duration from the file after downloaded args = [ 'ffprobe',
Fixed CircleCI Errors Idea for the fix by
@@ -9,6 +9,11 @@ jobs: steps: - checkout + - run: + name: Level synthesis test + command: | + echo -e "y\n" | python3 ./make_level.py testskill testlevel1 + echo -e "y\n" | python3 ./make_level.py testskill testlevel2 - run: name: Set up environment command: | @@ -17,11 +22,6 @@ jobs: pip3 install --user flake8 git con...
Update video.py Adding title and parentTitle to Episode variables (Lines 475 & 476)
@@ -438,6 +438,8 @@ class Episode(Video, Playable): parentKey (str): Key to this episodes :class:`~plexapi.video.Season`. parentRatingKey (int): Unique key for this episodes :class:`~plexapi.video.Season`. parentThumb (str): Key to this episodes thumbnail. + parentTitle (str): Name of this episode's season + title (str...
fixed a bug in the serialisation of Exceptions do not assume that all errors inherit form `MaestralApiError`, e.g., `DropboxDeletedError` inherits from `Exception` list all parent classes in serialisation
@@ -30,11 +30,10 @@ def dropbox_stone_to_dict(obj): def maestral_error_to_dict(err): - assert isinstance(err, MaestralApiError) dictionary = dict( type=err.__class__.__name__, - inherits=MaestralApiError.__name__, + inherits=[str(b) for b in err.__class__.__bases__], cause=err.__cause__, traceback=traceback.format_exce...
Changes made in code to open website as well Checks if internet is active, if active the code will prompt whether to open a website (optional). If internet is not active, code will output "No internet connection!" and exit. *Download geckodriver from (Browser to open website) *Install required modules "selenium"
-import urllib.request - +import urllib2 +import os +from selenium import webdriver +from selenium.webdriver.common.keys import Keys +print "Testing Internet Connection" +print try: - urllib.request.urlopen('http://google.com') - print ("working connection") + urllib2.urlopen("http://google.com", timeout=2)#Tests if co...
Update Changelog.md readme.md typo fix
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). ## [Unreleased] +## Fixed +- README.md typo ## [2.4] - 2019-07-31 ### Added - Tversky index (TI)
Update README.md The extra backslash is unnecessary and breaks the script. PDFs and screenshots are not generated.
@@ -18,7 +18,7 @@ Those numbers are from running it single-threaded on my i5 machine with 50mbps d ```bash # On Mac: brew install Caskroom/versions/google-chrome-canary wget python3 -echo -e '#!/bin/bash\n/Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary \"$@"' > /usr/local/bin/google-chrom...
HotFix Helping out Luis to parerallize in a scenario basis. We found that CEA needs a temp file per scenario. This should not change main functionality. It will just make it easier to parerallize
@@ -1011,7 +1011,11 @@ class InputLocator(object): # OTHER def get_temporary_folder(self): """Temporary folder as returned by `tempfile`.""" - return tempfile.gettempdir() + #every scneario should have its temp folder, otherwise we will have problems with paralellization + temp_folder = os.path.join(tempfile.gettempdir...
Fix for iptables.build_rule does not give full rule even when full=True is provided Changed as suggested by Daniel Yes, that should be changed to if full is True
@@ -501,7 +501,7 @@ def build_rule(table='filter', chain=None, command=None, position='', full=None, rule += after_jump - if full in ['True', 'true']: + if full is True: if not table: return 'Error: Table needs to be specified' if not chain:
cleaning up some cems column descriptions Based on Karl's and Greg's suggestions. Working on Issue
{ "name": "plant_id_eia", "type": "integer", - "description": "EIA Plant Identification number. One to five digit numeric.", + "description": "The unique six-digit facility identification number, also called an ORISPL, assigned by the Energy Information Administration.", "format": "default" }, { { "name": "operating_da...
ensure class state is set on refresh this was broken previously
@@ -239,6 +239,7 @@ function _showContentList(store, options) { const promises = [ _setContentSummary(store, options.contentScopeId, reportPayload), _setContentReport(store, reportPayload), + setClassState(store, options.classId), ]; Promise.all(promises).then( () => { @@ -272,6 +273,7 @@ function _showLearnerList(stor...
Update REQUEST-942-APPLICATION-ATTACK-SQLI.conf removed unnecessary +
@@ -1433,7 +1433,7 @@ SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAME # to the Regexp::Assemble output: # (?:ASSEMBLE_OUTPUT) # -SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAMES|ARGS|XML:/* "@rx (?:[\"'`][\s\d]*?[^\w\s]{1,10}\W*?\d\W*?.*?[\"'`\d])" \ +Se...
Added instantiation tests for qubit objects, should catch the most obvious mess ups
@@ -8,6 +8,9 @@ import pycqed.instrument_drivers.meta_instrument.qubit_objects.CCL_Transmon as c from pycqed.measurement import measurement_control from qcodes import station +from pycqed.instrument_drivers.meta_instrument.qubit_objects.QuDev_transmon import QuDev_transmon +from pycqed.instrument_drivers.meta_instrumen...
[modules/redshift] No digits for transition anymore Having 2 digits *after* the comma for transitions seems excessive - truncate value at the digit sign.
@@ -13,13 +13,9 @@ Parameters: * redshift.lon : longitude if location is set to 'manual' """ +import re import threading -import logging -log = logging.getLogger(__name__) -try: import requests -except ImportError: - log.warning('unable to import module "requests": Location via IP disabled') import core.module import c...
Updates run_default_protocols and adds write_empty_protocol_data. These two functions should work now.
@@ -787,11 +787,28 @@ class ProtocolDirectory(object): def run_default_protocols(data): - default_protocols = data.input.default_protocols - if len(default_protocols) > 1: - proto = MultiProtocol(default_protocols) - elif len(default_protocols) == 1: - proto = default_protocols[list(default_protocols.keys())[0]] + retu...
Possible fix for fixing code smells
@@ -209,7 +209,7 @@ def skip_transcode_movie(files, job, raw_path): # move others into extras folder if file == largest_file_name: # largest movie - utils.move_files(raw_path, file, job, False) + utils.move_files(raw_path, file, job, True) else: # If mainfeature is enabled - skip to the next file if job.config.MAINFEAT...
Log service ID for invalid inbound SMS This could help identify issues with inbound SMS for a service.
@@ -135,7 +135,7 @@ def create_inbound_sms_object(service, content, from_number, provider_ref, date_ user_number = try_validate_and_format_phone_number( from_number, international=True, - log_msg='Invalid from_number received' + log_msg=f'Invalid from_number received for service "{service.id}"' ) provider_date = date_r...
fix regression test for showing buildspec content. We dont raise exception BuildtestError for invalid entry instead we just print message
@@ -318,7 +318,7 @@ def test_buildspec_show(): # run buildtest buildspec <test> show --theme monokai show_buildspecs(test_name, configuration, theme="monokai") - with pytest.raises(BuildTestError): + # testing invalid buildspec name, it should not raise exception random_testname = "".join(random.choices(string.ascii_le...
word-count: Remove unicode test case As discussed in Fixes
from collections import Counter -# to be backwards compatible with the old Python 2.X -def decode_if_needed(string): - try: - return string.decode('utf-8') - except AttributeError: - return string - - def word_count(text): def replace_nonalpha(char): return char.lower() if char.isalnum() else ' ' - text = ''.join(repla...
version: Update API_FEATURE_LEVEL. This was missed in the original commit
@@ -33,7 +33,7 @@ DESKTOP_WARNING_VERSION = "5.4.3" # Changes should be accompanied by documentation explaining what the # new level means in templates/zerver/api/changelog.md, as well as # "**Changes**" entries in the endpoint's documentation in `zulip.yaml`. -API_FEATURE_LEVEL = 130 +API_FEATURE_LEVEL = 131 # Bump th...
Moved qualys test to skipped due to expired account issues currently fails content build nightly
"integrations": "PostgreSQL", "playbookID": "PostgreSQL Test" }, - { - "integrations": "Qualys", - "playbookID": "Qualys-Test", - "nightly": true - }, { "integrations": { "name": "google", { "integrations": "AlphaSOC Wisdom", "playbookID": "AlphaSOC-Wisdom-Test" + }, + { + "integrations": "Qualys", + "playbookID": "Qua...
Removing mention of "Core Access" program I'm not aware of one existing
@@ -25,7 +25,7 @@ Every month, the Mattermost community plans, builds, tests, documents, releases, 2. When a feature idea does not fit the scope of Team Edition, as [defined in the Mattermost Manifesto](http://www.mattermost.org/manifesto/#mattermost-teams), but benefits Enterprise Edition subscribers, a similar proces...
Add note on trial data deletion window, plus link to submit feedback on additional Cloud data regions * Update cloud-subscriptions.rst * Updating sentence structure for consistency See feedback at
@@ -43,6 +43,13 @@ Monthly Cloud subscriptions renew automatically. Frequently Asked Questions --------------------------- +What happens when my 14-day trial period ends? +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +At the end of the 14-day trial, you will lose access to your workspace until you have added yo...
Use logging instead of traceback Instead of just outputting to stderr the rtm connect failure it is more appropriate to use the python logging system and output a appropriate message (and pass in exc_info=True so that the traceback gets logged as well).
# mostly a proxy object to abstract how some of this works import json -import traceback +import logging from .server import Server from .exceptions import ParseResponseError +LOG = logging.getLogger(__name__) + class SlackClient(object): ''' @@ -52,7 +54,7 @@ class SlackClient(object): self.server.rtm_connect(use_rtm_...
Update test_walllet_commands Add test for CreateAddress
@@ -4,7 +4,7 @@ from neo.Implementations.Wallets.peewee.UserWallet import UserWallet from neo.Core.Blockchain import Blockchain from neocore.UInt160 import UInt160 from neocore.Fixed8 import Fixed8 -from neo.Prompt.Commands.Wallet import DeleteAddress, ImportToken, ImportWatchAddr, ShowUnspentCoins, SplitUnspentCoin +f...
feat(ldap): Validate additional required fields. If the user selects 'Custom' LDAP Directory, when they hit save, validate the additional required fields ('ldap_group_objectclass' and 'ldap_group_member_attribute') for this selection to function. Issue
@@ -44,6 +44,11 @@ class LDAPSettings(Document): frappe.throw(_("Ensure the user and group search paths are correct."), title=_("Misconfigured")) + if self.ldap_directory_server.lower() == 'custom': + if not self.ldap_group_member_attribute or not self.ldap_group_mappings_section: + frappe.throw(_("Custom LDAP Directoy...
Fix error when no standards are found If the year of building does not fit in the date range of any standards, just return the first standard.
@@ -165,11 +165,19 @@ def zone_helper(locator, config): calculate_typology_file(locator, zone_df, year_construction, occupancy_type, typology_output_path) -def calc_category(standard_DB, year_array): +def calc_category(standard_db, year_array): def category_assignment(year): - return (standard_DB[(standard_DB['YEAR_STA...
Update README.rst Improved explanation of optional components. Hopefully avoids further user misunderstandings such as
@@ -45,6 +45,11 @@ You can do a minimal installation of ``MushroomRL`` with: Installing everything --------------------- +``MushroomRL`` contains also some optional components e.g., support for ``OpenAI Gym`` +environments, Atari 2600 games from the ``Arcade Learning Environment``, and the support +for physics simulato...
Correct intro sentence re number of nodes The Docker and Kubernetes procedures create five nodes, but the Ubuntu procedure only creates two nodes.
@@ -23,8 +23,9 @@ environment on one of the following platforms: .. note:: - The guides in this chapter set up an environment with five Sawtooth validator - nodes. For a single-node environment, see :doc:`installing_sawtooth`. + The guides in this chapter set up an environment with multiple Sawtooth + validator nodes. ...
Change special webcast filtering logic Check if event is ongoing
@@ -225,7 +225,7 @@ class MainCompetitionseasonHandler(CacheableHandler): for special_webcast in FirebasePusher.get_special_webcasts(): add = True for event in week_events: - if event.webcast: + if event.now and event.webcast: for event_webcast in event.webcast: if (special_webcast.get('type', '') == event_webcast.get(...
Update gridding_functions.py Changes interpolate function docstring to offer more specific explanation of 'hres' parameter
@@ -150,7 +150,8 @@ def interpolate(x, y, z, interp_type='linear', hres=50000, 2) "natural_neighbor", "barnes", or "cressman" from Metpy.mapping . Default "linear". hres: float - The horizontal resolution of the generated grid. Default 50000 meters. + The horizontal resolution of the generated grid, given in the same u...
Update Dockerfile SImplified Dockerfile to just include an xcube environment and CLI
# Image from https://hub.docker.com (syntax: repo/image:version) FROM continuumio/miniconda3:latest -# Person responsible -MAINTAINER helge.dzierzon@brockmann-consult.de - +# Metadata +LABEL maintainer="helge.dzierzon@brockmann-consult.de" LABEL name=xcube -LABEL version=0.7.1 +LABEL version=0.8.0.dev7 LABEL conda_env=...
Inline enter/exit_call recursive guards GL issue libadalang#918
@@ -112,7 +112,8 @@ private package ${ada_lib_name}.Implementation is -- recursive calls. procedure Enter_Call - (Context : Internal_Context; Call_Depth : access Natural); + (Context : Internal_Context; Call_Depth : access Natural) + with Inline_Always; -- Increment the call depth in Context. If the depth exceeds Conte...
Improve LocalRunner.initialize_tf_vars() Thanks to Fixes
@@ -132,11 +132,14 @@ class LocalRunner: def initialize_tf_vars(self): """Initialize all uninitialized variables in session.""" with tf.name_scope("initialize_tf_vars"): + uninited_set = [ + e.decode() + for e in self.sess.run(tf.report_uninitialized_variables()) + ] self.sess.run( tf.variables_initializer([ v for v in...
Remove broken test introduced here My guess is this broke when the year or month changed. Even checking out the original version now this test fails
@@ -62,13 +62,14 @@ describe('Kpi Directive', function () { assert.equal(result, expected); }); - it('tests shows percent info from month parameter', function () { - $location.search('month', new Date().getMonth()); - var expected = true; - - var result = controller.showPercentInfo(); - assert.equal(result, expected); ...
Slack sanitization Multi links will be converted to original content
@@ -21,6 +21,7 @@ Added - Add command line argument ``rasa x --config CONFIG``, to specify path to the policy and NLU pipeline configuration of your bot (default: ``config.yml``) + Changed ------- - Do not retrain the entire Core model if only the ``templates`` section of the domain is changed. @@ -37,6 +38,7 @@ Fixed ...
Upload validations to swift on undercloud install Implements: blueprint store-validations-in-swift Depends-On:
@@ -133,5 +133,8 @@ if [ "$(hiera mistral_api_enabled)" = "true" ]; then if [ "$(hiera enable_validations)" = "true" ]; then echo Execute copy_ssh_key validations openstack workflow execution create tripleo.validations.v1.copy_ssh_key + + echo Upload validations to Swift + openstack action execution run tripleo.validat...
Fix get_force_authn return value to be compatible with older pysaml2 older pysaml2 cannot parse False as a value for force_authn
@@ -58,7 +58,7 @@ def get_force_authn(context, config, sp_config): - the cookie, as it has been stored by the proxy on a redirect to the DS note: the frontend should have been set to mirror the force_authn value. - The value is either "true" or False + The value is either "true" or None """ mirror = config.get(SAMLBack...
input kpoints for bands mode can be a list of fractional coords or a list of Kpoint objects
@@ -122,9 +122,9 @@ class BoltztrapRunner(object): shape. This is useful to correct the often underestimated band gap in DFT. Default is 0.0 (no scissor) kpt_line: - list/array of kpoints in fractional coordinates for BANDS mode - calculation (standard path of high symmetry k-points is - automatically set as default) +...