base_commit stringlengths 40 40 | created_at stringdate 2013-07-19 17:10:26 2025-07-23 01:54:17 | hints_text stringlengths 0 525k | instance_id stringlengths 10 60 | patch stringlengths 174 256k | pr_description stringlengths 3 99.8k | problem_statement stringlengths 0 6.69k | pull_number int64 1 61.8k | repo stringlengths 5 54 | test_patch stringlengths 173 254k | FAIL_TO_PASS listlengths 1 122k | PASS_TO_PASS listlengths 0 190k | interface stringlengths 4 33.3k | license stringclasses 11
values | install_config dict | meta dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
6885663c1110693e29ecc7736f75f1a466952982 | 2023-10-11 08:03:57 | baidu__amis-8354 | diff --git a/docs/zh-CN/components/crud.md b/docs/zh-CN/components/crud.md
index 7a3db1a77..971314e2c 100755
--- a/docs/zh-CN/components/crud.md
+++ b/docs/zh-CN/components/crud.md
@@ -2795,7 +2795,6 @@ CRUD 中不限制有多少个单条操作、添加一个操作对应的添加一
> 本文中的例子为了不相互影响都关闭了这个功能。
> 另外如果需要使用接口联动，需要设置`syncLocation: false`
-
`syncLocation... | fix: Form组件配置页面跳转事件可能会导致持久化数据无法清除问题
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 6556104</samp>
This pull request introduces a new feature for the form renderer to clear the local persist data of the form store. This can help avoid data inconsistency issues when the form data is submitted ... | **Title**
Fix form persistence leakage on navigation and improve CRUD filtering, UI rendering, and formula support
**Problem**
- After a form submission that triggers a page route change, the form’s locally persisted data is not cleared, leading to stale values when the user returns.
- CRUD components exhibit ... | 8,354 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 4670b3906..2fb97d99a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -539,3 +539,26 @@ test('evalute:ISTYPE', () => {
expect(evalu... | [
"evalute:Math"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | No new interfaces are introduced. | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 34,
"num_modified_lines": 523,
"pr_author": "lurunze1226",
"pr_labels": [
"fix"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5":... | |
08412adcb500e92f7ebb55453cd26a028d0c1368 | 2023-10-12 01:53:11 | baidu__amis-8360 | diff --git a/examples/components/CRUD/List.jsx b/examples/components/CRUD/List.jsx
index 15d65c389..18aef7409 100644
--- a/examples/components/CRUD/List.jsx
+++ b/examples/components/CRUD/List.jsx
@@ -3,32 +3,18 @@ export default {
remark: 'bla bla bla',
body: {
type: 'crud',
- api: '/api/sample',
+ na... | chore: 调整列的快速搜索逻辑干掉之前没清理干净的排序相关逻辑 Close: #8342
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 1113e82</samp>
Refactored and simplified a table header component that supports searching and filtering. Used React hooks and removed unused code.
<!--
copilot:poem
-->
### <samp>🤖 Generated by ... | **Title**
Remove residual sorting logic from column quick‑search and streamline related components
**Problem**
The quick‑search dropdown in table headers still injected hidden sorting fields (`orderBy`, `orderDir`) and relied on outdated class‑based implementation, causing confusing query parameters and unnecess... | 8,360 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 4670b3906..2fb97d99a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -539,3 +539,26 @@ test('evalute:ISTYPE', () => {
expect(evalu... | [
"evalute:Math"
] | [
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"parser:multi-expression",
"parser:functionCall",
"parser... | Method: Evaluator.fnPOW(base: number, exponent: number)
Location: packages/amis-formula/src/evalutor.ts → class Evaluator
Inputs:
- **base**: `number` – the base value for exponentiation. If not a number, the function returns the original `base` unchanged.
- **exponent**: `number` – the exponent value. If not a number... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 11,
"num_modified_lines": 212,
"pr_author": "2betop",
"pr_labels": [
"chore"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": fa... | |
79728ddad4ddfdad819d4ea6e152790ba2aa410e | 2023-10-12 06:11:20 | github-actions[bot]: <!-- Labeler (https://github.com/jimschubert/labeler) -->
👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.
Please review the labels and make any necessary changes.
| baidu__amis-8365 | diff --git a/docs/zh-CN/components/table2.md b/docs/zh-CN/components/table2.md
index 3443a8ef2..a3515bd8a 100755
--- a/docs/zh-CN/components/table2.md
+++ b/docs/zh-CN/components/table2.md
@@ -24,7 +24,8 @@ order: 67
"columns": [
{
"title": "Engine",
- ... | fix: 修复 REPLACE 公式第二个参数是空字符串时导致的死循环问题 Close: #8200
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at f5208ec</samp>
This pull request enhances the text manipulation capabilities of `evalutor.ts` by adding or improving functions that normalize, format, and compare text values. It also ensures th... | **Title**
Fix REPLACE formula infinite loop, add POW function and stabilize table rendering
**Problem**
- The `REPLACE` formula entered an endless loop when the search string was empty, breaking formula evaluation.
- Several text functions (e.g., `STARTSWITH`, `ENDSWITH`, `CONTAINS`, `SEARCH`, `MID`) did not c... | 8,365 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 4670b3906..2fb97d99a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -539,3 +539,26 @@ test('evalute:ISTYPE', () => {
expect(evalu... | [
"evalute:Math"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | Method: Evaluator.fnPOW(self, base: number, exponent: number)
Location: packages/amis-formula/src/evalutor.ts (class Evaluator)
Inputs:
- **base** <number>: the base value to be raised. Must be a numeric value; otherwise the function returns the base unchanged.
- **exponent** <number>: the exponent to raise the base... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 22,
"num_modified_lines": 609,
"pr_author": "2betop",
"pr_labels": [
"fix"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": fals... |
79728ddad4ddfdad819d4ea6e152790ba2aa410e | 2023-10-12 08:54:51 | baidu__amis-8370 | diff --git a/examples/components/CRUD/List.jsx b/examples/components/CRUD/List.jsx
index 15d65c389..18aef7409 100644
--- a/examples/components/CRUD/List.jsx
+++ b/examples/components/CRUD/List.jsx
@@ -3,32 +3,18 @@ export default {
remark: 'bla bla bla',
body: {
type: 'crud',
- api: '/api/sample',
+ na... | feat: 表达式新增幂函数(Math.pow)
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 29bf446</samp>
This pull request adds a new `POW` function to the amis-formula package, which allows users to calculate the power of a base value raised to an exponent. It also updates the unit tests, documentation, and ... | **Title**
Add exponentiation support and correct CRUD/store handling
**Problem**
- Formulas had no built‑in way to compute a power, limiting mathematical expressions.
- The CRUD example and its underlying store lost query information and could sync stale data, leading to incorrect API calls.
- Schema transla... | 8,370 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 4670b3906..2fb97d99a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -539,3 +539,26 @@ test('evalute:ISTYPE', () => {
expect(evalu... | [
"evalute:Math"
] | [
"evalute:simple",
"evalute:filter",
"evalute:filter2",
"evalute:filter3",
"evalute:filter4",
"evalute:keywords",
"evalute:oldVariable",
"evalute:ariable2",
"evalute:ariable3",
"evalute:object-variable",
"evalute:literal-variable",
"evalute:tempalte",
"evalute:literal",
"evalute:variableNam... | Method: Evaluator.fnPOW(base: number, exponent: number)
Location: packages/amis-formula/src/evalutor.ts
Inputs:
- **base** – `number` | any – the base value; if the value is not a number the function returns it unchanged.
- **exponent** – `number` | any – the exponent; if the value is not a number the function retur... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 7,
"num_modified_lines": 100,
"pr_author": "lurunze1226",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5":... | |
6f599d5d939201ad5b809001425b333b87c6ec12 | 2023-10-13 09:45:51 | github-actions[bot]: <!-- Labeler (https://github.com/jimschubert/labeler) -->
👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.
Please review the labels and make any necessary changes.
| baidu__amis-8385 | diff --git a/docs/zh-CN/types/classname.md b/docs/zh-CN/types/classname.md
index fbfa53d12..049ac855c 100644
--- a/docs/zh-CN/types/classname.md
+++ b/docs/zh-CN/types/classname.md
@@ -12,7 +12,9 @@ amis 中大部分的组件都支持配置 className 和 xxxClassName，他可以
配置方式有两种：
1. 直接配置字符串如：`className: "text-danger"` 文字标红。
-2. 采用对象配置，这个用法主... | feat: formula 取 cookie, localstorage, sessionstorage支持 &['xxx'] 来获取复杂变量名数据 Close: #8376
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 1b4c5a7</samp>
This pull request updates the amis, amis-core, amis-ui, and amis-formula packages to version `3.4.2`, which includes bug fixes and new feature... | **Title**
Enable dynamic class name expressions and support special‑character keys in cookie/localStorage/sessionStorage namespaces
**Problem**
- `className` objects could only contain static values; expression strings and dynamic keys were not evaluated, limiting UI styling flexibility.
- Variables whose names ... | 8,385 | baidu/amis | diff --git a/packages/amis-formula/__tests__/async-evalute.test.ts b/packages/amis-formula/__tests__/async-evalute.test.ts
index 18bcdf6a6..bd0e6fc1c 100644
--- a/packages/amis-formula/__tests__/async-evalute.test.ts
+++ b/packages/amis-formula/__tests__/async-evalute.test.ts
@@ -587,3 +587,33 @@ test('evalute:ISTYPE',... | [
"evalute:namespace",
"async-evalute:namespace"
] | [
"evalute:simple",
"evalute:filter",
"evalute:filter2",
"evalute:filter3",
"evalute:filter4",
"evalute:keywords",
"evalute:oldVariable",
"evalute:ariable2",
"evalute:ariable3",
"evalute:object-variable",
"evalute:literal-variable",
"evalute:tempalte",
"evalute:literal",
"evalute:variableNam... | No new interfaces are introduced. | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 6,
"num_modified_lines": 95,
"pr_author": "2betop",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false... |
983b98f9573e1bc58602bb78ea31d87d3ce829a0 | 2024-06-13 20:29:57 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/2097?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
All modified and coverable lines are covered by tests :white_che... | materials-consortia__optimade-python-tools-2097 | diff --git a/openapi/openapi.json b/openapi/openapi.json
index c5f1a39e..11eb639e 100644
--- a/openapi/openapi.json
+++ b/openapi/openapi.json
@@ -1664,8 +1664,10 @@
"description": "Description of the entry."
},
"properties": {
- "additionalProperties": {
- "$r... | Validate property names against identifier regular expression
This PR implements property name validation against identifier regular expression as laid out in OPTIMADE specification. | **Title**
Enforce OPTIMADE identifier rules for property and field names
**Problem**
Clients could supply arbitrary strings as property names or output‑field identifiers, which violates the OPTIMADE specification that mandates a specific identifier pattern. This leads to non‑conforming APIs and potential downstr... | 2,097 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_baseinfo.py b/tests/models/test_baseinfo.py
index 6d24a116..49d9bd52 100644
--- a/tests/models/test_baseinfo.py
+++ b/tests/models/test_baseinfo.py
@@ -2,6 +2,7 @@ import pytest
from pydantic import ValidationError
from optimade.models.baseinfo import AvailableApiVersion
+from optimad... | [
"tests/models/test_baseinfo.py::test_bad_entry_info_custom_properties"
] | [
"tests/models/test_baseinfo.py::test_available_api_versions",
"tests/models/test_baseinfo.py::test_good_entry_info_custom_properties"
] | Method: EntryInfoResource.__init__(self, formats: list[str], description: str, output_fields_by_format: dict[str, list[ValidIdentifier]], properties: dict[ValidIdentifier, EntryInfoProperty])
Location: optimade.models.entries
Inputs:
- **formats** – list of supported format strings (e.g., “json”, “xml”).
- **descrip... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 4,
"num_modified_lines": 15,
"pr_author": "merkys",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... |
ce04b39d8a6488b9220f0a8f23f55e09886205fa | 2024-10-30 11:20:48 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/2175?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
Attention: Patch coverage is `48.00000%` with `13 lines` in your... | materials-consortia__optimade-python-tools-2175 | diff --git a/optimade/server/config.py b/optimade/server/config.py
index 29ba11a1..7b56469c 100644
--- a/optimade/server/config.py
+++ b/optimade/server/config.py
@@ -180,6 +180,16 @@ class ServerConfig(BaseSettings):
),
] = None
+ create_default_index: Annotated[
+ bool,
+ Field(
+ ... | Quality of life changes around JSONL & MongoDB
- Better error handling and logging on JSONL insert
- Parallel inserts from MongoDB
- Convenience methods and config for creating indexes: nothing changes by default, but indexes can now be made when inserting from JSONL data. | **Title**
Add optional default index creation and improve robustness of JSONL data ingestion
**Problem**
Loading JSONL files could fail silently on malformed lines and did not automatically create required database indexes, leading to potential duplicate‑key errors and sub‑optimal query performance.
**Root Ca... | 2,175 | Materials-Consortia/optimade-python-tools | diff --git a/tests/server/entry_collections/test_indexes.py b/tests/server/entry_collections/test_indexes.py
new file mode 100644
index 00000000..006bf2e8
--- /dev/null
+++ b/tests/server/entry_collections/test_indexes.py
@@ -0,0 +1,40 @@
+import pytest
+from bson import ObjectId
+
+from optimade.server.config import C... | [
"tests/server/entry_collections/test_indexes.py::test_indexes_are_created_where_appropriate"
] | [] | Method: EntryCollection.insert(self, data: list[EntryResource | dict]) -> None
Location: optimade/server/entry_collections/entry_collections.py – class EntryCollection
Inputs:
- **data** – a list containing either `EntryResource` objects (already mapped to the backend format) or raw `dict` objects representing OPTIMAD... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 6,
"num_modified_lines": 116,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6":... |
e171370b70f66dd849211689b5f4aad3a766d6fb | 2025-02-28 12:35:08 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/2236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
Attention: Patch coverage is `90.90909%` with `1 line` in your c... | materials-consortia__optimade-python-tools-2236 | diff --git a/openapi/openapi.json b/openapi/openapi.json
index e2c67e8e..94ef86e7 100644
--- a/openapi/openapi.json
+++ b/openapi/openapi.json
@@ -4340,6 +4340,24 @@
"x-optimade-support": "should",
"x-optimade-unit": "\u00c5"
},
+ "space_group_symmetry_operations_xyz": {
+ ... | Add support for `space_group_symmetry_operations_xyz`
As above. Adds the OPTIMADE 1.2 field `space_group_symmetry_operations_xyz`, superseding #1422. | **Title**
Add OPTIMADE 1.2 `space_group_symmetry_operations_xyz` support to the Structure model
**Problem**
The latest OPTIMADE specification introduces a new optional property describing symmetry operations in algebraic “x, y, z” notation. The library’s data model and OpenAPI description did not expose this fie... | 2,236 | Materials-Consortia/optimade-python-tools | diff --git a/tests/adapters/structures/test_structures.py b/tests/adapters/structures/test_structures.py
index 3d8b2539..2e9fd5c5 100644
--- a/tests/adapters/structures/test_structures.py
+++ b/tests/adapters/structures/test_structures.py
@@ -191,6 +191,7 @@ def compare_lossy_conversion(
"immutable_id",
... | [
"tests/models/test_structures.py::test_structure_fatal_deformities[deformity28]",
"tests/models/test_structures.py::test_structure_fatal_deformities[deformity29]",
"tests/server/test_client.py::test_list_properties[True]",
"tests/server/test_client.py::test_list_properties[False]"
] | [
"tests/adapters/structures/test_structures.py::test_instantiate",
"tests/adapters/structures/test_structures.py::test_setting_entry",
"tests/adapters/structures/test_structures.py::test_convert_wrong_format",
"tests/adapters/structures/test_structures.py::test_getattr_order",
"tests/adapters/structures/test... | Method: StructureResourceAttributes.check_symmetry_operations(self)
Location: optimade/models/structures.py
Inputs:
- self: an instance of StructureResourceAttributes containing
• nperiodic_dimensions (int)
• space_group_symmetry_operations_xyz (list[SymmetryOperation] | None)
Outputs: Returns the same ins... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 4,
"num_modified_lines": 77,
"pr_author": "ml-evs",
"pr_labels": [
"schema: Concerns the schema models",
"OPTIMADE v1.2: This label describes actions that have to be taken to be complient with OPTIMADE 1.2"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
... |
d6ca66644751d6df2dd0ed3591e63402186cd710 | 2020-04-24 14:12:02 | abdullahgarcia: Please, review accordingly
iYehuda: Hi @abdullahgarcia, thanks for your contribution!
It might take us some time to review since it's not a little PR.
abdullahgarcia: Hi @iYehuda,
No worries.
Please, let me know if you need any assistance or you have further doubts.
Thanks!
Abdullah
abdul... | aquasecurity__kube-hunter-344 | diff --git a/docs/_kb/KHV051.md b/docs/_kb/KHV051.md
new file mode 100644
index 0000000..b09de24
--- /dev/null
+++ b/docs/_kb/KHV051.md
@@ -0,0 +1,40 @@
+---
+vid: KHV051
+title: Exposed Existing Privileged Containers Via Secure Kubelet Port
+categories: [Access Risk]
+---
+
+# {{ page.vid }} - {{ page.title }}
+
+## I... | Two new kubelet active hunters.
<!---
Thank you for contributing to Aqua Security.
Please don't remove the template.
-->
## Description
I'm introducing two new active hunters:
- FootholdViaSecureKubeletPort
- MaliciousIntentViaSecureKubeletPort
Both active hunters enable a deeper analysis on how m... | **Title**
Add active hunters for exposing and exploiting privileged containers via an insecure kubelet secure port
**Problem**
When the kubelet’s secure port permits anonymous requests, privileged containers become reachable from outside the cluster. An attacker can read service‑account tokens, enumerate environme... | 344 | aquasecurity/kube-hunter | diff --git a/tests/core/test_handler.py b/tests/core/test_handler.py
index 5c48975..5ccc71e 100644
--- a/tests/core/test_handler.py
+++ b/tests/core/test_handler.py
@@ -28,11 +28,13 @@ from kube_hunter.modules.hunting.dashboard import KubeDashboard
from kube_hunter.modules.hunting.dns import DnsSpoofHunter
from kube_... | [
"tests/core/test_handler.py::test_passive_hunters_registered",
"tests/core/test_handler.py::test_active_hunters_registered",
"tests/core/test_handler.py::test_all_hunters_registered",
"tests/hunting/test_kubelet.py::test_get_request_valid_url",
"tests/hunting/test_kubelet.py::test_get_request_invalid_url",
... | [] | Method: ProveAnonymousAuth.__init__(self, event)
Location: kube_hunter.modules.hunting.kubelet.ProveAnonymousAuth
Inputs: event – an instance of AnonymousAuthEnabled containing host and a requests‑Session.
Outputs: Initializes the hunter, setting self.event and self.base_url derived from event.host.
Description: Create... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -r requirements-dev.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/core/test_handler.py tests/hunting/... | {
"num_modified_files": 3,
"num_modified_lines": 573,
"pr_author": "abdullahgarcia",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
... |
ad4cfe1c11391f66b05df7e26f2059515f1f9988 | 2020-09-07 12:13:32 | codecov[bot]: # [Codecov](https://codecov.io/gh/aquasecurity/kube-hunter/pull/372?src=pr&el=h1) Report
> Merging [#372](https://codecov.io/gh/aquasecurity/kube-hunter/pull/372?src=pr&el=desc) into [master](https://codecov.io/gh/aquasecurity/kube-hunter/commit/3950a1c2f279a3372496e9369c12b3f2a852d5de?el=desc) will **dec... | aquasecurity__kube-hunter-372 | diff --git a/kube_hunter/modules/hunting/aks.py b/kube_hunter/modules/hunting/aks.py
index a5877c3..f937178 100644
--- a/kube_hunter/modules/hunting/aks.py
+++ b/kube_hunter/modules/hunting/aks.py
@@ -46,11 +46,16 @@ class AzureSpnHunter(Hunter):
logger.debug("failed getting pod info")
else:
... | fix azure spn hunter
Fixes https://github.com/aquasecurity/kube-hunter/issues/370
| **Title**
Improve Azure SPN hunter to detect azure.json mounted via hostPath volumes
**Problem**
The Azure SPN hunter misses pods that expose the Azure credentials file when it is mounted through a hostPath volume, resulting in false‑negative findings. It can also error out when expected fields are absent.
**... | 372 | aquasecurity/kube-hunter | diff --git a/tests/hunting/test_aks.py b/tests/hunting/test_aks.py
new file mode 100644
index 0000000..008501a
--- /dev/null
+++ b/tests/hunting/test_aks.py
@@ -0,0 +1,56 @@
+# flake8: noqa: E402
+import requests_mock
+
+from kube_hunter.conf import Config, set_config
+
+set_config(Config())
+
+from kube_hunter.modules... | [
"tests/hunting/test_aks.py::test_AzureSpnHunter"
] | [] | Method: AzureSpnHunter.__init__(self, handler)
Location: kube_hunter/modules/hunting/aks.py
Inputs:
- **handler** (ExposedRunHandler): an instance representing a reachable kubelet endpoint, providing host, port, and protocol attributes used to build request URLs.
Outputs:
- Instance of AzureSpnHunter properly initial... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -r requirements-dev.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/hunting/test_aks.py"
} | {
"num_modified_files": 1,
"num_modified_lines": 8,
"pr_author": "itaysk",
"pr_labels": [],
"llm_metadata": {
"code": "B3",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": false,
"B2": false,
"B3": true,
"B4": false,
"B5": false,
"B6": f... |
1a26653007ae2c82db04ac73a5d336f2336db772 | 2021-04-20 15:10:44 | aquasecurity__kube-hunter-448 | diff --git a/kube_hunter/core/events/handler.py b/kube_hunter/core/events/handler.py
index 24eb1dc..667e88e 100644
--- a/kube_hunter/core/events/handler.py
+++ b/kube_hunter/core/events/handler.py
@@ -6,7 +6,7 @@ from threading import Thread
from kube_hunter.conf import get_config
from kube_hunter.core.types import... | Multiple Subscriptions Mechanism
# Multiple Subscriptions
A continuation for this old PR #271
When an hunter needs several prerequisites to exist in the cluster, We need to register for multiple events.
This new mechanism allows us to execute once for every new combination of specified required events.
For example... | **Title**
Add support for hunters that depend on multiple prerequisite events
**Problem**
Hunters could only listen to a single event type, making it impossible to trigger logic that requires a combination of different cluster conditions. This limited the ability to run certain checks only after all required inf... | 448 | aquasecurity/kube-hunter | diff --git a/tests/core/test_subscribe.py b/tests/core/test_subscribe.py
index f01ef00..6dc0fc8 100644
--- a/tests/core/test_subscribe.py
+++ b/tests/core/test_subscribe.py
@@ -6,6 +6,8 @@ from kube_hunter.core.events.types import Event, Service
from kube_hunter.core.events import handler
counter = 0
+first_run = T... | [
"tests/core/test_subscribe.py::test_subscribe_mechanism",
"tests/core/test_subscribe.py::test_subscribe_once_mechanism",
"tests/core/test_subscribe.py::test_subscribe_many_mechanism"
] | [] | Method: EventQueue.subscribe_many(self, events: List[Type[Event]], hook: Optional[Type[Hunter]]=None, predicates: Optional[List[Callable]]=None)
Location: kube_hunter.core.events.handler.EventQueue.subscribe_many
Inputs:
- **events** – list of event classes that the hunter requires.
- **hook** – (internal) the ... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -r requirements-dev.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/core/test_subscribe.py"
} | {
"num_modified_files": 2,
"num_modified_lines": 237,
"pr_author": "danielsagi",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
473e4fe2b57d3e91b91777de0ed65d13658ae9cb | 2021-08-19 16:56:12 | aquasecurity__kube-hunter-474 | diff --git a/README.md b/README.md
index 6100636..0d59407 100644
--- a/README.md
+++ b/README.md
@@ -141,7 +141,7 @@ Available dispatch methods are:
* KUBEHUNTER_HTTP_DISPATCH_URL (defaults to: https://localhost)
* KUBEHUNTER_HTTP_DISPATCH_METHOD (defaults to: POST)
-### Advanced Usage
+### Advanced Usage ... | Feature: Changed vulnerability categories to support MITRE ATT&CK
## Description
kube-hunter was one of the first projects that offered a Pentesting solution for kubernetes.
This arose a lot of new problems as this field of "hacking" kubernetes was at it's really early stages, so we had room for innovative new ideas... | **Title**
Align vulnerability categories with MITRE ATT&CK and CVE classifications
**Problem**
The tool still used a legacy set of generic categories that did not reflect the MITRE ATT&CK matrix or CVE‑specific groupings, leading to ambiguous reporting and incorrect severity assignments. The plain‑text reporter al... | 474 | aquasecurity/kube-hunter | diff --git a/tests/hunting/test_apiserver_hunter.py b/tests/hunting/test_apiserver_hunter.py
index 7cd6b20..774d485 100644
--- a/tests/hunting/test_apiserver_hunter.py
+++ b/tests/hunting/test_apiserver_hunter.py
@@ -1,4 +1,5 @@
# flake8: noqa: E402
+from kube_hunter.core.types.vulnerabilities import AccessK8sApiServe... | [
"tests/hunting/test_apiserver_hunter.py::test_ApiServerToken",
"tests/hunting/test_apiserver_hunter.py::test_AccessApiServer",
"tests/hunting/test_apiserver_hunter.py::test_AccessApiServerActive"
] | [] | Class: ExposedSensitiveInterfacesTechnique
Location: kube_hunter.core.types.vulnerabilities
Inputs: None (instantiated implicitly as a class reference; inherits from InitialAccessCategory → MITRECategory)
Outputs: Used as a category identifier; supports identity comparison (`event.category == ExposedSensitiveInterfaces... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -r requirements-dev.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/hunting/test_apiserver_hunter.py"
} | {
"num_modified_files": 22,
"num_modified_lines": 405,
"pr_author": "danielsagi",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
9ce385a19071ea2e639419ba87c14bd18d0faa93 | 2022-05-11 13:51:43 | CLAassistant: [](https://cla-assistant.io/aquasecurity/kube-hunter?pullRequest=504) <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assi... | aquasecurity__kube-hunter-504 | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 54b4bce..747f8cd 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -39,7 +39,7 @@ jobs:
password: ${{ secrets.ECR_SECRET_ACCESS_KEY }}
- name: Get version
id: get_version
- ... | pin image version
## Description
This pins the image version in the job manifest. Using this manifest directly (for example `kubectl apply -f https://raw.githubusercontent.com/aquasecurity/kube-hunter/v0.6.7/job.yaml`) on a pinned version, will allow using that manifest without having to maintain your own, and allo... | **Title**
Pin Kubernetes‑hunter image version and migrate event‑handler imports
**Problem**
- The job manifest referenced an un‑pinned container image, causing pipelines that apply the upstream manifest to break when the image tag changes.
- The internal event‑handler module was moved but import paths througho... | 504 | aquasecurity/kube-hunter | diff --git a/tests/core/test_handler.py b/tests/core/test_handler.py
index 46baab5..3639505 100644
--- a/tests/core/test_handler.py
+++ b/tests/core/test_handler.py
@@ -4,7 +4,7 @@ from kube_hunter.conf import Config, set_config, get_config
set_config(Config(active=True))
-from kube_hunter.core.events.handler impo... | [
"tests/core/test_handler.py::test_passive_hunters_registered",
"tests/core/test_handler.py::test_active_hunters_registered",
"tests/core/test_handler.py::test_all_hunters_registered",
"tests/core/test_subscribe.py::test_subscribe_mechanism",
"tests/core/test_subscribe.py::test_subscribe_once_mechanism",
"... | [] | No new interfaces are introduced. | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -r requirements-dev.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/core/test_handler.py tests/core/tes... | {
"num_modified_files": 26,
"num_modified_lines": 30,
"pr_author": "rhtenhove",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B... |
56450cb8eaaf37904c1f551aa926c94c1953135e | 2025-03-03 20:16:35 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/2240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
All modified and coverable lines are covered by tests :white_che... | materials-consortia__optimade-python-tools-2240 | diff --git a/openapi/openapi.json b/openapi/openapi.json
index 21a0b349..5a76f8e1 100644
--- a/openapi/openapi.json
+++ b/openapi/openapi.json
@@ -4371,6 +4371,68 @@
"x-optimade-queryable": "optional",
"x-optimade-support": "optional"
},
+ "space_group_symbol_hall": {
+ ... | Add remaining symmetry group fields (Hall, HM symbols, IT number)
Finishes the remaining work migrating #1422. | **Title**
Add optional symmetry‑group metadata (Hall, Hermann‑Mauguin, extended H‑M, and IT number) to the Structures model and OpenAPI definition
**Problem**
The Structures endpoint did not expose standard crystallographic symmetry descriptors, preventing clients from accessing Hall symbols, Hermann‑Mauguin sym... | 2,240 | Materials-Consortia/optimade-python-tools | diff --git a/tests/adapters/structures/test_structures.py b/tests/adapters/structures/test_structures.py
index 2e9fd5c5..7e1882bb 100644
--- a/tests/adapters/structures/test_structures.py
+++ b/tests/adapters/structures/test_structures.py
@@ -192,6 +192,10 @@ def compare_lossy_conversion(
"species",
"... | [
"tests/adapters/structures/test_structures.py::test_instantiate",
"tests/adapters/structures/test_structures.py::test_setting_entry",
"tests/adapters/structures/test_structures.py::test_convert_wrong_format",
"tests/adapters/structures/test_structures.py::test_getattr_order",
"tests/adapters/structures/test... | [] | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 3,
"num_modified_lines": 188,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6":... |
0be0c7f0e627652eb6b98ce7cdf83f2f3881843e | 2025-03-08 16:57:19 | ml-evs: pre-commit.ci autofix
ml-evs: pre-commit.ci autofix
codecov[bot]: ## [Codecov](https://app.codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/2242?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
All ... | materials-consortia__optimade-python-tools-2242 | diff --git a/optimade/grammar/v1.2.0.develop.lark b/optimade/grammar/v1.2.0.lark
similarity index 96%
rename from optimade/grammar/v1.2.0.develop.lark
rename to optimade/grammar/v1.2.0.lark
index 12ec22c0..6d803090 100644
--- a/optimade/grammar/v1.2.0.develop.lark
+++ b/optimade/grammar/v1.2.0.lark
@@ -55,7 +55,7 @@ se... | Use 1.2 grammar by default and relax rules on nested fields
This PR simply removes the "develop" tag from the v1.2.0 grammar, which should make it the default.
It also allows nested field names to have more flexibility, inspired by e.g., the MP field `_mp_stability.gga_gga+u_r2scan` (#2182). The spec reads that dict... | **Title**
Default to v1.2 grammar and relax nested property token rules; guard include handling
**Problem**
The library defaults to an older grammar version and enforces overly strict rules on nested property names, rejecting valid dictionary keys such as those containing “+”. Additionally, the relationship‑inclus... | 2,242 | Materials-Consortia/optimade-python-tools | diff --git a/optimade/server/data/test_data.jsonl b/optimade/server/data/test_data.jsonl
index 2872b2f2..f1f58619 100644
--- a/optimade/server/data/test_data.jsonl
+++ b/optimade/server/data/test_data.jsonl
@@ -14,7 +14,7 @@
{"type": "structures", "id": "mpf_3", "attributes": {"immutable_id": "5cfb441f053b174410700d04... | [
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_repr",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_parser_version",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_empty",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_property_names",
... | [
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_repr",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_parser_version",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_empty",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_property_names",
... | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 2,
"num_modified_lines": 6,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": f... |
61b271d41049de4d5e59c4650c175717ae9d26e7 | 2019-07-26 12:37:27 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=h1) Report
> Merging [#60](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/60?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/61b271d41049... | materials-consortia__optimade-python-tools-60 | diff --git a/optimade/server/models/structures.py b/optimade/server/models/structures.py
index 1ea902a2..3b7a5cd9 100644
--- a/optimade/server/models/structures.py
+++ b/optimade/server/models/structures.py
@@ -260,7 +260,7 @@ the elements in this list each refer to the direction of the corresponding entry
""",
)... | Some minor fixes
- Fixed a typo in our version of the schema for the field name `lattice_types` -> `lattice_vectors`.
- Switched the final test that needed a mongo server running to `mongomock` (I assume this is what we want @dwinston ) | **Title**
Correct structure schema field name and replace MongoDB dependency in tests
**Problem**
The structure model exposed a misspelled field name, leading to schema mismatches and validation errors. Additionally, the integration test required a live MongoDB instance, causing failures in environments without ... | 60 | Materials-Consortia/optimade-python-tools | diff --git a/optimade/filtertransformers/tests/test_transformer.py b/optimade/filtertransformers/tests/test_transformer.py
index fb6a60bb..a51ea683 100644
--- a/optimade/filtertransformers/tests/test_transformer.py
+++ b/optimade/filtertransformers/tests/test_transformer.py
@@ -2,7 +2,7 @@ import itertools
from unitte... | [
"optimade/filtertransformers/tests/test_transformer.py::TestTransformer::test_conjunctions"
] | [
"optimade/filtertransformers/tests/test_transformer.py::TestTransformer::test_not",
"optimade/filtertransformers/tests/test_transformer.py::TestTransformer::test_simple_comparisons"
] | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": f... |
c5b579f7a219bbf2e774052cbc71128c1fd82cb0 | 2020-01-13 11:05:08 | materials-consortia__optimade-python-tools-131 | diff --git a/openapi/index_openapi.json b/openapi/index_openapi.json
index a53f6a6f..3bb04fff 100644
--- a/openapi/index_openapi.json
+++ b/openapi/index_openapi.json
@@ -606,8 +606,23 @@
},
"description": "A JSON object containing information about an available API version"
},
- "BaseReso... | Add meta.description to BaseRelationshipResource
Sub-classed BaseResource to introduce special OPTiMaDe requirement of
having an OPTIONAL `meta` field in the relationship resource, which
MUST have the field `description`, it it's present.
Also, introduced some pylint disables for the models to avoid pylint
compla... | **Title**
Add optional `meta.description` support to relationship resources
**Problem**
OPTiMaDe relationship objects must be able to include an optional `meta` object that contains a `description` field. The existing models and OpenAPI schema did not provide this field, leading to non‑compliant responses.
**... | 131 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_models.py b/tests/models/test_models.py
index 072141d3..3c4e7ac0 100644
--- a/tests/models/test_models.py
+++ b/tests/models/test_models.py
@@ -59,18 +59,45 @@ class TestPydanticValidation(unittest.TestCase):
StructureResource(**StructureMapper.map_back(structure))
... | [
"tests/models/test_models.py::TestPydanticValidation::test_advanced_relationships"
] | [
"tests/models/test_models.py::TestPydanticValidation::test_bad_references",
"tests/models/test_models.py::TestPydanticValidation::test_bad_structures",
"tests/models/test_models.py::TestPydanticValidation::test_good_references",
"tests/models/test_models.py::TestPydanticValidation::test_good_structures",
"t... | Class: BaseRealationshipMeta(description: str)
Location: optimade/models/optimade_json.py
Inputs: <description: str – required, human‑readable description of the relationship>
Outputs: <BaseRealationshipMeta instance; ValidationError if description missing or not a string>
Description: Model for the optional “meta” obj... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 9,
"num_modified_lines": 113,
"pr_author": "CasperWA",
"pr_labels": [
"schema: Concerns the OpenAPI schema"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
... | |
69d215c1b5c9e956b150c3b010d4e1ba8bba905d | 2020-01-16 11:03:40 | materials-consortia__optimade-python-tools-137 | diff --git a/optimade/server/config.py b/optimade/server/config.py
index de1a38aa..ac75fcaa 100644
--- a/optimade/server/config.py
+++ b/optimade/server/config.py
@@ -146,7 +146,7 @@ class ServerConfig(Config):
self.implementation = {}
for field in Implementation.schema()["properties"]:
v... | Fix `load_from_json`
This function did not work properly.
Add test file for config.py, for now only with a simple test to run `load_from_json()`.
Feel free to add more tests to `test_config.py` either in this PR or later. | **Title**
Correct defaults handling and provider‑field mapping in server configuration loading
**Problem**
The configuration loader failed to apply default values for implementation settings, collection parameters, and provider fields, causing missing or incorrect configuration state when `load_from_json()` is u... | 137 | Materials-Consortia/optimade-python-tools | diff --git a/tests/server/config_test.ini b/tests/server/config_test.ini
new file mode 100644
index 00000000..17ece366
--- /dev/null
+++ b/tests/server/config_test.ini
@@ -0,0 +1,25 @@
+[BACKEND]
+USE_REAL_MONGO = no
+MONGO_DATABASE = optimade
+LINKS_COLLECTION = links
+REFERENCES_COLLECTION = references
+STRUCTURES_CO... | [
"tests/server/test_config.py::LoadFromJsonTest::test_config_json"
] | [
"tests/server/test_config.py::LoadFromIniTest::test_config_ini"
] | Method: ServerConfig.__init__(self, server_cfg: pathlib.Path)
Location: optimade/server/config.py – class `ServerConfig` constructor
Inputs: `server_cfg` – a `Path` object pointing to a server configuration file (INI or JSON) that contains an `[optimadeconfig]` section with a `CONFIG` entry referencing the actual O... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 1,
"num_modified_lines": 10,
"pr_author": "CasperWA",
"pr_labels": [
"bug: Something isn't working"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4"... | |
5a5e9039997e7095661cb2b24bcff2ed5ba44a34 | 2020-03-12 15:50:53 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/225?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/5a5e90399... | materials-consortia__optimade-python-tools-225 | diff --git a/MANIFEST.in b/MANIFEST.in
index 4a047b4d..ad0839c8 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,3 +1,4 @@
recursive-include optimade/server/ *.ini *.json
recursive-include optimade/server/data/ *
recursive-include optimade/grammar/ *.lark
+recursive-include optimade/validator/data/ *.txt
| Add txt-files in optimade.validator.data to MANIFEST
Also added to `test_setup.py` test.
I found this error, since I couldn't install the latest commit when testing Materials-Consortia/optimade-validator-action#4 | **Title**
Include validator text resources in the source distribution
**Problem**
The package's source distribution omitted the plain‑text files used by the validator component, causing installation failures and test errors when those resources are accessed.
**Root Cause**
The manifest configuration did not... | 225 | Materials-Consortia/optimade-python-tools | diff --git a/tests/test_setup.py b/tests/test_setup.py
index ff972b7a..408df991 100644
--- a/tests/test_setup.py
+++ b/tests/test_setup.py
@@ -35,6 +35,8 @@ class TestSetup(unittest.TestCase):
r"test_structures\.json": False,
r"test_references\.json": False,
r"test_lin... | [
"tests/test_setup.py::TestSetup::test_distributions_package"
] | [] | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "CasperWA",
"pr_labels": [
"bug: Something isn't working",
"priority/high: Issue or PR with a consensus of high priority",
"tests: Related to tests"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": ... |
ed508390a18b67a040c629b284b83f48327d60aa | 2020-03-28 17:31:49 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/241?src=pr&el=h1) Report
> Merging [#241](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/241?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/7768f62f2... | materials-consortia__optimade-python-tools-241 | diff --git a/.github/aiida/profile.yaml b/.github/aiida/profile.yaml
new file mode 100644
index 00000000..582d2859
--- /dev/null
+++ b/.github/aiida/profile.yaml
@@ -0,0 +1,14 @@
+---
+profile: PLACEHOLDER_PROFILE
+email: aiida@localhost
+first_name: AiiDA
+last_name: OPTIMADE
+institution: Materials-Consortia
+db_back... | Add adapters - Base design + 'structures' (+ 'references'... sort of)
The goal of the adapters is to contain a conversion or adaptation ability in a single Python class.
The class will be a proxy for `optimade.models.EntryResource`, where the specific entries will take the place, e.g., `StructureResource`.
In thi... | **Title**
Add unified entry adapters, conversion utilities, and CI support for optional scientific libraries
**Problem**
The package needed a consistent way to expose OPTIMADE resources as objects from popular scientific libraries (e.g., AiiDA, ASE, CIF, PDB, pymatgen). Without a proper adapter layer the convers... | 241 | Materials-Consortia/optimade-python-tools | diff --git a/pytest.ini b/pytest.ini
index 9628d74e..a04215eb 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -4,3 +4,4 @@ filterwarnings =
ignore:.*"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead.*:DeprecationWarning
ignore:.*Using or importing the ABCs from 'collections' instead o... | [
"tests/adapters/references/test_references.py::TestReference::test_instantiate",
"tests/adapters/references/test_references.py::TestReference::test_setting_entry",
"tests/adapters/references/test_references.py::TestReference::test_convert_wrong_format",
"tests/adapters/references/test_references.py::TestRefer... | [] | Function: EntryAdapter.__init__(self, entry: dict)
Location: optimade.adapters.base.EntryAdapter
Inputs: `entry` – a dictionary representing a raw OPTIMADE JSON entry.
Outputs: Initializes the adapter instance, setting internal `_entry` to `None`, `_converted` to `{}`, and populates `_common_converters` for `"json"` an... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 19,
"num_modified_lines": 1185,
"pr_author": "CasperWA",
"pr_labels": [
"enhancement: New feature or request",
"priority/low: Issue or PR with a consensus of low priority"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.93,
"detected_i... |
36af320b6070c5c96abc8c1ed67b19ff654e16db | 2020-06-02 16:48:25 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/287?src=pr&el=h1) Report
> Merging [#287](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/287?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/d29f7a1c1... | materials-consortia__optimade-python-tools-287 | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index ad42c154..d65a1f3b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -4,22 +4,22 @@ The [Materials Consortia](https://github.com/Materials-Consortia) is very open t
This may be anything from simple feedback and raising [new issues](https://github.com/Materials... | Create template filtertransformer BaseTransformer
Here's a first pass at a `BaseTransformer`. I think we need to discuss what to do with the Django, JSON and TransformerSkeleton and elasticsearch transformers, plus all the grammar variants... I haven't really gotten my head around how lark interacts with these magic-wo... | **Title**
Align filter parsing and transformation to the v1.0.0 grammar and consolidate transformer architecture
**Problem**
The package still referenced the historic `Parser` and outdated transformer classes (JSON, Debug, Django), causing version mismatches and duplicated logic across back‑ends. Documentation a... | 287 | Materials-Consortia/optimade-python-tools | diff --git a/tests/filterparser/test_filterparser.py b/tests/filterparser/test_filterparser.py
index f4ef123b..d4a40374 100644
--- a/tests/filterparser/test_filterparser.py
+++ b/tests/filterparser/test_filterparser.py
@@ -40,8 +40,8 @@ class TestParserV0_9_5:
assert repr(self.parser) is not None
-class Te... | [
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_empty",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_property_names",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_string_values",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_number_va... | [
"tests/filterparser/test_filterparser.py::TestParserV0_9_5::test_inputs",
"tests/filterparser/test_filterparser.py::TestParserV0_9_5::test_parser_version",
"tests/filterparser/test_filterparser.py::TestParserV0_9_5::test_repr"
] | Method: DjangoTransformer.__init__(self)
Location: optimade.filtertransformers.django.DjangoTransformer.__init__
Inputs: None (no parameters)
Outputs: An instance of DjangoTransformer (e.g. self.Transformer = DjangoTransformer())
Description: Constructs the (deprecated) Django filter transformer that converts a parsed ... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 10,
"num_modified_lines": 384,
"pr_author": "ml-evs",
"pr_labels": [
"blocking: For issues/PRs that are blocking other PRs.",
"priority/medium: Issue or PR with a consensus of medium priority",
"transformers: Related to all filter transformers"
],
"llm_metadata": {
"c... |
e1cac1e0408ca236ae1d37a9f184eaed170e8f54 | 2020-06-10 07:11:30 | CasperWA: > Yes, I think so too. But we do not have the vacancy in the Specie object. We mention in the 'test_special_species' function. We define a separate Vacancy object.
So the `chemical_symbols` is a list of chemical elements (case sensitive), but can also include `"X"` as an unknown element, which isn't a vaca... | materials-consortia__optimade-python-tools-297 | diff --git a/optimade/adapters/structures/__init__.py b/optimade/adapters/structures/__init__.py
index 048800be..6922615c 100644
--- a/optimade/adapters/structures/__init__.py
+++ b/optimade/adapters/structures/__init__.py
@@ -6,6 +6,7 @@ from .ase import get_ase_atoms
from .cif import get_cif
from .proteindatabank i... | Adding jarvis-tools structures | **Title**
Add JARVIS‑tools support to the structure adapter
**Problem**
The library could convert OPTIMADE structures only to ASE, CIF, PDB, and Pymatgen representations. Users needing JARVIS‑tools atoms had no way to obtain them, limiting interoperability with workflows that rely on that package.
**Root Caus... | 297 | Materials-Consortia/optimade-python-tools | diff --git a/tests/adapters/structures/test_jarvis.py b/tests/adapters/structures/test_jarvis.py
new file mode 100644
index 00000000..929ba425
--- /dev/null
+++ b/tests/adapters/structures/test_jarvis.py
@@ -0,0 +1,53 @@
+# pylint: disable=import-error
+import pytest
+
+from .utils import get_min_ver
+
+min_ver = get_m... | [
"tests/adapters/structures/test_structures.py::TestStructure::test_instantiate",
"tests/adapters/structures/test_structures.py::TestStructure::test_setting_entry",
"tests/adapters/structures/test_structures.py::TestStructure::test_convert",
"tests/adapters/structures/test_structures.py::TestStructure::test_co... | [] | Function: get_jarvis_atoms(optimade_structure: OptimadeStructure) -> Atoms
Location: optimade.adapters.structures.jarvis.get_jarvis_atoms
Inputs:
- **optimade_structure**: An instance of `optimade.models.StructureResource` (or any object exposing the same attribute layout) representing an OPTIMADE structure. The object... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 3,
"num_modified_lines": 56,
"pr_author": "knc6",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": fa... |
06dd2be63200ad094a8926a488f26ae7f0609c93 | 2020-08-05 14:43:13 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/453?src=pr&el=h1) Report
> Merging [#453](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/453?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/e965bc805... | materials-consortia__optimade-python-tools-453 | diff --git a/openapi/openapi.json b/openapi/openapi.json
index cb4f49c6..8a315390 100644
--- a/openapi/openapi.json
+++ b/openapi/openapi.json
@@ -2116,7 +2116,8 @@
"properties": {
"name": {
"title": "Name",
- "type": "string"
+ "type": "string",
+ "desc... | SHOULD/MUST/OPTIONAL fields in models
Following the discussion in #399, this PR is a place to try out ways of incorporating the "SHOULD" level of support for some fields in the specification. This PR does the following:
- adds a couple of wrappers around pydantic's `Field` (namely `OptimadeField` and `StrictField`).... | **Title**
Enforce strict field definitions and add OPTIMADE support metadata across models
**Problem**
Model definitions used generic pydantic fields, allowing unintended keyword arguments, missing descriptions, and typographical errors that broke schema generation. The OPTIMADE specification’s “SHOULD/MUST/OPTI... | 453 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_utils.py b/tests/models/test_utils.py
new file mode 100644
index 00000000..279d4d68
--- /dev/null
+++ b/tests/models/test_utils.py
@@ -0,0 +1,76 @@
+import pytest
+from pydantic import BaseModel
+from optimade.models.utils import OptimadeField, StrictField, SupportLevel
+from typing impor... | [
"tests/models/test_utils.py::test_strict_field",
"tests/models/test_utils.py::test_optimade_field",
"tests/models/test_utils.py::test_compatible_strict_optimade_field"
] | [] | Function: StrictField(*args, description: str = None, **kwargs) → Field
Location: optimade.models.utils.StrictField
Inputs:
- *args: positional arguments forwarded to ``pydantic.Field`` (e.g., default value or Ellipsis).
- description (optional str): description for the field; if omitted a ``UserWarning`` is emitt... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 11,
"num_modified_lines": 519,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... |
e05e0b806e5918ab30b0e8bcbc26b66d3927e306 | 2020-09-15 22:41:33 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/502?src=pr&el=h1) Report
> Merging [#502](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/e05e0b806... | materials-consortia__optimade-python-tools-502 | diff --git a/mkdocs.yml b/mkdocs.yml
index e5d0a559..4dc0288e 100644
--- a/mkdocs.yml
+++ b/mkdocs.yml
@@ -63,6 +63,7 @@ plugins:
- "!__json_encoder__$"
- "!__all__$"
- "!__config__$"
+ - "!ValidatorResults$"
members: true
inherited_mem... | Enable JSON response from the validator
This PR adds a `-j`/`--json` flag to the validator that lowers verbosity to "-1" and only prints a JSON representation of the results to stdout. | **Title**
Add optional JSON‑only output for the validator and encapsulate validation results.
**Problem**
The validator always prints human‑readable summaries and mixes result counters with console output logic. There is no way to retrieve the validation outcome as pure JSON, which is needed for automated pipeline... | 502 | Materials-Consortia/optimade-python-tools | diff --git a/tests/server/test_server_validation.py b/tests/server/test_server_validation.py
index fbe35504..1548052c 100644
--- a/tests/server/test_server_validation.py
+++ b/tests/server/test_server_validation.py
@@ -1,4 +1,6 @@
import os
+import json
+import dataclasses
from traceback import print_exc
import py... | [
"tests/validator/test_utils.py::test_normal_test_case",
"tests/validator/test_utils.py::test_optional_test_case",
"tests/validator/test_utils.py::test_ignored_test_case",
"tests/validator/test_utils.py::test_skip_optional_test_case",
"tests/validator/test_utils.py::test_expected_failure_test_case",
"tests... | [] | Method: ImplementationValidator.__init__(self, client=None, base_url=None, verbosity: int = 0, respond_json: bool = False, page_limit: int = 5, max_retries: int = 5, run_optional_tests: bool = True, fail_fast: bool = False, as_type=None, index: bool = False)
Location: optimade.validator.validator – class Implementati... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 4,
"num_modified_lines": 76,
"pr_author": "ml-evs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... |
c34f8a066011aa1c7bfed254f9b629d24406e761 | 2020-09-21 11:04:40 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/511?src=pr&el=h1) Report
> Merging [#511](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/511?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/41c26e5a7... | materials-consortia__optimade-python-tools-511 | diff --git a/docs/api_reference/server/schemas.md b/docs/api_reference/server/schemas.md
new file mode 100644
index 00000000..7bdb6e54
--- /dev/null
+++ b/docs/api_reference/server/schemas.md
@@ -0,0 +1,3 @@
+# schemas
+
+::: optimade.server.schemas
diff --git a/optimade/server/routers/info.py b/optimade/server/routers... | Move entry schemas to separate submodule
This PR is a shortcut version of #277 whilst retaining most of its features. The `ENTRY_INFO_SCHEMA` constant dict has been moved to a new submodule and new extension fields ("support" and "queryable") are now made available so they can also be used by the validator more cleanly... | **Title**
Centralize entry schemas and extend queryable property handling
**Problem**
Server routes needed a reliable source for entry model schemas, but the schemas were scattered and the utility for extracting queryable properties did not recognise the newly‑added extension fields. This caused duplication and ... | 511 | Materials-Consortia/optimade-python-tools | diff --git a/tests/server/test_schemas.py b/tests/server/test_schemas.py
new file mode 100644
index 00000000..dfb5c980
--- /dev/null
+++ b/tests/server/test_schemas.py
@@ -0,0 +1,32 @@
+from optimade.server.schemas import ENTRY_INFO_SCHEMAS, retrieve_queryable_properties
+
+
+def test_schemas():
+ """Test that the d... | [
"tests/server/test_schemas.py::test_schemas"
] | [] | Function: retrieve_queryable_properties(schema: dict, queryable_properties: list)
Location: optimade.server.schemas
Inputs:
- **schema** (dict): JSON schema dictionary produced by a Pydantic model (e.g., `StructureResource.schema`).
- **queryable_properties** (list): Iterable of top‑level property names that should be ... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 4,
"num_modified_lines": 54,
"pr_author": "ml-evs",
"pr_labels": [
"enhancement: New feature or request",
"priority/medium: Issue or PR with a consensus of medium priority"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_i... |
d207200c7cf8cbaf71dd0f3c4deb67115e4155eb | 2020-10-19 21:29:37 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/560?src=pr&el=h1) Report
> Merging [#560](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/560?src=pr&el=desc) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit/e7432a2cd... | materials-consortia__optimade-python-tools-560 | diff --git a/.github/workflows/deps_lint.yml b/.github/workflows/deps_lint.yml
index 2f1dacb0..3650a70c 100644
--- a/.github/workflows/deps_lint.yml
+++ b/.github/workflows/deps_lint.yml
@@ -175,8 +175,8 @@ jobs:
pip install -r requirements.txt
pip install -r requirements-dev.txt
- - name: Run al... | Relax models to allow for all SHOULD fields to be None
This PR tracks the relaxation of our models to allow for None values for almost any field. The current approach for this is to make non-should fields have the type pydantic-type `Optional` but a default value of `...`, which is interpreted as a required OpenAPI fie... | **Title**
Allow nullable SHOULD fields in structure models and streamline CI testing
**Problem**
Clients and implementations may legitimately provide `null` for many structure properties that are only recommended (SHOULD) rather than mandatory. The previous schema forced these fields to be present and non‑null, ... | 560 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_data/test_bad_structures.json b/tests/models/test_data/test_bad_structures.json
index 1204198b..13da97d9 100644
--- a/tests/models/test_data/test_bad_structures.json
+++ b/tests/models/test_data/test_bad_structures.json
@@ -1503,7 +1503,13 @@
"O",
"O"
],
- "structure... | [
"tests/models/test_structures.py::test_good_structure_with_missing_data",
"tests/models/test_structures.py::test_more_good_structures",
"tests/models/test_structures.py::test_bad_structures",
"tests/models/test_structures.py::test_structure_fatal_deformities[None]",
"tests/models/test_structures.py::test_st... | [] | Function: StructureResource(**data)
Location: optimade.models.structures.StructureResource
Inputs: a mapping (typically a dict) containing the JSON‑API fields required for a structure resource – notably an “id”, “type”, “attributes” dict with optional fields such as `elements`, `nelements`, `dimension_types`, `lattice_... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 5,
"num_modified_lines": 213,
"pr_author": "ml-evs",
"pr_labels": [
"models: For issues related to the pydantic models directly",
"priority/medium: Issue or PR with a consensus of medium priority",
"schema: Concerns the schema models"
],
"llm_metadata": {
"code": "A",... |
33de78f012f11c27c8063dc726c615ae6de9ea84 | 2021-01-06 15:29:18 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/665?src=pr&el=h1) Report
> Merging [#665](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/665?src=pr&el=desc) (ccb9cb5) into [master](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/commit... | materials-consortia__optimade-python-tools-665 | diff --git a/optimade/validator/utils.py b/optimade/validator/utils.py
index ec07afbc..0f02604b 100644
--- a/optimade/validator/utils.py
+++ b/optimade/validator/utils.py
@@ -289,13 +289,7 @@ def test_case(test_fn: Callable[[Any], Tuple[Any, str]]):
else:
result, msg = test_fn(vali... | Validator changes: always check unversioned '/versions' and handle rich HTML pages
This PR does two things:
- Some services e.g. netlify have rich 404 pages which yield unhelpful error messages, those error messages are now improved.
- Following discussion in #662, this PR always checks the existence of the unversion... | **Title**
Improve validator handling of `/versions` endpoint and non‑JSON error responses
**Problem**
When a service’s base URL includes a version segment, the validator does not verify the required unversioned `/versions` endpoint, potentially missing compliance issues. Additionally, services that return rich H... | 665 | Materials-Consortia/optimade-python-tools | diff --git a/tests/validator/test_utils.py b/tests/validator/test_utils.py
index 5b69199e..5c9e983e 100644
--- a/tests/validator/test_utils.py
+++ b/tests/validator/test_utils.py
@@ -164,17 +164,14 @@ def test_expected_failure_test_case():
assert validator.results.internal_failure_count == 0
assert output[0... | [
"tests/validator/test_utils.py::test_expected_failure_test_case"
] | [
"tests/validator/test_utils.py::test_normal_test_case",
"tests/validator/test_utils.py::test_optional_test_case",
"tests/validator/test_utils.py::test_ignored_test_case",
"tests/validator/test_utils.py::test_skip_optional_test_case",
"tests/validator/test_utils.py::test_unexpected_failure_test_case",
"tes... | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 2,
"num_modified_lines": 20,
"pr_author": "ml-evs",
"pr_labels": [
"bug: Something isn't working",
"priority/low: Issue or PR with a consensus of low priority",
"validator: Related to the OPTIMADE validator"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
... |
f80c842ee8e015d41e5c59dcb807b4cd4045fde2 | 2021-06-09 08:44:33 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
> Merging [#845](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/84... | materials-consortia__optimade-python-tools-845 | diff --git a/optimade/models/utils.py b/optimade/models/utils.py
index 5a47b795..8887656e 100644
--- a/optimade/models/utils.py
+++ b/optimade/models/utils.py
@@ -145,7 +145,10 @@ class SemanticVersion(str):
@classmethod
def validate(cls, v: str):
if not cls.regex.match(v):
- raise ValueEr... | Improve semver validation error messsage
Minor fix arising from some validation of AFLOW yesterday (that "1.0" is not a valid semver, and also that semver may not be well known as an abbreviation). | **Title**
Improve the clarity of semantic version validation errors
**Problem**
When a version string fails semantic‑version validation, the raised error provides little guidance, leading to confusion (e.g., treating “1.0” as valid). Users need a more informative message that explains the required format.
**R... | 845 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_baseinfo.py b/tests/models/test_baseinfo.py
index 70ad3bfd..e7230f29 100644
--- a/tests/models/test_baseinfo.py
+++ b/tests/models/test_baseinfo.py
@@ -15,6 +15,8 @@ def test_available_api_versions():
]
bad_versions = [
{"url": "https://example.com/v0", "version": "v0.1... | [
"tests/models/test_baseinfo.py::test_available_api_versions"
] | [] | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "ml-evs",
"pr_labels": [
"models: For issues related to the pydantic models directly",
"priority/low: Issue or PR with a consensus of low priority"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.85... |
38015610d404b044af263ff9eb0bf411cec5b38d | 2021-07-20 17:08:48 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
> Merging [#879](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/87... | materials-consortia__optimade-python-tools-879 | diff --git a/optimade/filterparser/lark_parser.py b/optimade/filterparser/lark_parser.py
index f1200ed0..ab327602 100644
--- a/optimade/filterparser/lark_parser.py
+++ b/optimade/filterparser/lark_parser.py
@@ -61,7 +61,10 @@ class LarkParser:
"""
- version = version if version else max(AVAILABLE_PA... | Tidy up old grammars, add a development grammar for v1.2 and update filterparser tests
This PR does the following:
- removes pre-1.0 grammars and their tests
- Adds a v1.2 grammar that includes `TRUE` and `FALSE` tokens,
- Adds links to a v1.1.0 and v1.0.1 grammars based on v1.0.0
- Unifies the testing of grammar... | **Title**
Update grammar assets, introduce development grammar for v1.2, and refine default parser selection
**Problem**
Legacy grammar specifications for pre‑1.0 releases were still bundled, causing unnecessary maintenance overhead and potential version conflicts. The parser’s version resolution logic could sel... | 879 | Materials-Consortia/optimade-python-tools | diff --git a/tests/filterparser/test_filterparser.py b/tests/filterparser/test_filterparser.py
index 913fc707..99007b9d 100644
--- a/tests/filterparser/test_filterparser.py
+++ b/tests/filterparser/test_filterparser.py
@@ -1,5 +1,5 @@
-import os
-from glob import glob
+import abc
+from typing import Tuple
import pyt... | [
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_repr",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_parser_version",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_empty",
"tests/filterparser/test_filterparser.py::TestParserV1_2_0::test_property_names",
... | [
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_repr",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_parser_version",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_empty",
"tests/filterparser/test_filterparser.py::TestParserV1_0_0::test_property_names",
... | Method: LarkParser.__init__(self, version: Tuple[int, int, int] = None, variant: str = "default")
Location: optimade/filterparser/lark_parser.py
Inputs:
- **version** (optional Tuple[int, int, int]): Desired grammar version; if omitted or None, the parser automatically selects the highest grammar version marked as def... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 3,
"num_modified_lines": 27,
"pr_author": "ml-evs",
"pr_labels": [
"grammar: Concerns the Lark grammar files",
"priority/low: Issue or PR with a consensus of low priority",
"tests: Related to tests"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"conf... |
b5169a88b9f8faa86e2c9c585ed058424405603f | 2022-12-06 23:35:34 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/1428?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
> Merging [#1428](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/... | materials-consortia__optimade-python-tools-1428 | diff --git a/openapi/openapi.json b/openapi/openapi.json
index 918a2965..180dce2b 100644
--- a/openapi/openapi.json
+++ b/openapi/openapi.json
@@ -3360,8 +3360,8 @@
},
"description": "If present MUST be a list of floats expressed in a.m.u.\nElements denoting vacancies MUST have masses equal to... | Allow empty strings through chemical formula regexp
Last PR of the day, and one that can actually be reviewed and merged.
After discussions in https://github.com/Materials-Consortia/OPTIMADE/issues/388, it seems that empty formulae should be allowed -- though we should wait until it is really resolved to merge this.... | **Title**
Allow empty strings for chemical formula fields
**Problem**
The chemical formula properties reject empty strings, conflicting with the discussion that an empty formula should be a valid representation of “no formula”. This causes validation errors for legitimate responses.
**Root Cause**
The valid... | 1,428 | Materials-Consortia/optimade-python-tools | diff --git a/tests/models/test_utils.py b/tests/models/test_utils.py
index 955ecdee..bfeb3a1b 100644
--- a/tests/models/test_utils.py
+++ b/tests/models/test_utils.py
@@ -96,6 +96,7 @@ def test_formula_regexp():
"LiP5",
"Jn7Qb4", # Regexp does not care about the actual existence of elements
... | [
"tests/models/test_utils.py::test_formula_regexp"
] | [
"tests/models/test_utils.py::test_strict_field",
"tests/models/test_utils.py::test_optimade_field",
"tests/models/test_utils.py::test_compatible_strict_optimade_field"
] | No new interfaces are introduced. | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 2,
"num_modified_lines": 10,
"pr_author": "ml-evs",
"pr_labels": [
"schema: Concerns the schema models",
"models: For issues related to the pydantic models directly"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues":... |
7c8f9a63ff169fd1e1c90676e304ca9c99e5b939 | 2023-02-09 19:55:56 | codecov[bot]: # [Codecov](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/1509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Materials-Consortia) Report
> Merging [#1509](https://codecov.io/gh/Materials-Consortia/optimade-python-tools/pull/... | materials-consortia__optimade-python-tools-1509 | diff --git a/README.md b/README.md
index 3dea2fe7..7183842d 100644
--- a/README.md
+++ b/README.md
@@ -4,10 +4,7 @@
<img width="100px" align="center" src="https://matsci.org/uploads/default/original/2X/b/bd2f59b3bf14fb046b74538750699d7da4c19ac1.svg">
</div>
-<h1 align="center">
-OPTIMADE Python tools
-</h1>
-
+# <d... | Add ASE ingester and generalize other ingestion utilities
This PR adds `from_ase` as a new ingester type (following #1296 for pymatgen) and generalises the ingester functionality into a `.ingest_from` method of the base adapter, e.g.,
```python
from optimade.adapters import Structure
atoms = ase.Atoms(...)
st... | **Title**
Add unified ingestion API and ASE support; centralize formula handling
**Problem**
The library only provided a specific ingester for pymatgen, lacking a generic entry‑point and support for ASE structures. Formula reduction and anonymization logic was duplicated across modules, leading to inconsistent val... | 1,509 | Materials-Consortia/optimade-python-tools | diff --git a/tests/adapters/structures/test_ase.py b/tests/adapters/structures/test_ase.py
index a2062b2c..8e4103c8 100644
--- a/tests/adapters/structures/test_ase.py
+++ b/tests/adapters/structures/test_ase.py
@@ -45,3 +45,23 @@ def test_special_species(SPECIAL_SPECIES_STRUCTURES):
def test_null_species(null_species_... | [
"tests/adapters/structures/test_structures.py::test_two_way_conversion[ase]",
"tests/adapters/structures/test_structures.py::test_two_way_conversion_with_implicit_type[ase]",
"tests/models/test_structures.py::test_structure_fatal_deformities[deformity24]",
"tests/models/test_structures.py::test_structure_fata... | [
"tests/adapters/structures/test_structures.py::test_instantiate",
"tests/adapters/structures/test_structures.py::test_setting_entry",
"tests/adapters/structures/test_structures.py::test_convert_wrong_format",
"tests/adapters/structures/test_structures.py::test_getattr_order",
"tests/adapters/structures/test... | Method: EntryAdapter.ingest_from(cls, data: Any, format: Optional[str] = None)
Location: optimade.adapters.base.EntryAdapter (class method)
Inputs:
- **data** (Any): The object to be ingested (e.g., an ASE Atoms instance, a pymatgen Structure, etc.).
- **format** (Optional[str]): Explicit key identifying the ingester t... | MIT | {
"base_image_name": "python_base_310",
"install": [
"git submodule update --init --recursive",
"pip install -q -r requirements.txt -r requirements-dev.txt -r requirements-server.txt -r requirements-http-client.txt",
"pip install -q -e ."
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --... | {
"num_modified_files": 8,
"num_modified_lines": 211,
"pr_author": "ml-evs",
"pr_labels": [
"enhancement: New feature or request",
"adapters: Issues pertaining to adapters (converters)",
"ergonomics: Features that improve the usability of the package"
],
"llm_metadata": {
"code": "B2",
"... |
99988be3f81672a05264f987cb0026fc9d10b91c | 2020-03-03 14:04:30 | tdameritrade__stumpy-137 | diff --git a/stumpy/mstump.py b/stumpy/mstump.py
index 5ee2447..9e00372 100644
--- a/stumpy/mstump.py
+++ b/stumpy/mstump.py
@@ -12,10 +12,10 @@ from . import core
logger = logging.getLogger(__name__)
-def _multi_mass(Q, T, m, M_T, Σ_T, trivial_idx, excl_zone):
+def _multi_mass(Q, T, m, M_T, Σ_T):
"""
A ... | Fixed Issue #136 and improved mstump tests
I tried to stick as much to the issue #136 as I could, but I had to make some changes that touch issue #135 .
- The main change is that I converted `_multi_mass` to return the multidimensional distance profile as discussed.
- I also changed `_get_first_mstump_profile` in ... | **Title**
Correct multi‑dimensional distance handling and first‑profile computation for MSTump
**Problem**
`mstump` produced an incorrect matrix profile because the first distance profile was computed over the entire series and the exclusion zone was applied inconsistently. This also caused a mismatch in how the... | 137 | TDAmeritrade/stumpy | diff --git a/tests/test_mstump.py b/tests/test_mstump.py
index abd69d1..e620f5d 100644
--- a/tests/test_mstump.py
+++ b/tests/test_mstump.py
@@ -13,37 +13,6 @@ import pytest
import utils
-def naive_mass(Q, T, m, trivial_idx, excl_zone):
- D = np.linalg.norm(
- utils.z_norm(core.rolling_window(T, m), 1) -... | [
"tests/test_mstump.py::test_multi_mass[T0-3]",
"tests/test_mstump.py::test_multi_mass[T1-5]",
"tests/test_mstump.py::test_get_first_mstump_profile[T0-3]",
"tests/test_mstump.py::test_get_first_mstump_profile[T1-5]"
] | [
"tests/test_mstump.py::test_get_multi_QT[T0-3]",
"tests/test_mstump.py::test_get_multi_QT[T1-5]",
"tests/test_mstump.py::test_naive_mstump",
"tests/test_mstump.py::test_mstump[T0-3]",
"tests/test_mstump.py::test_mstump[T1-5]",
"tests/test_mstump.py::test_mstump_wrapper[T0-3]",
"tests/test_mstump.py::tes... | Function: _multi_mass(Q, T, m, M_T, Σ_T)
Location: stumpy/mstump.py
Inputs:
- Q: ndarray of shape (d, m) – the query subsequence (across d dimensions).
- T: ndarray of shape (d, n) – the multidimensional time series.
- m: int – subsequence length.
- M_T: ndarray of shape (d, k) – sliding means of T for each dimension (... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -e .",
"pip install -q pytest pandas dask distributed coverage flake8 black"
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/test_m... | {
"num_modified_files": 2,
"num_modified_lines": 47,
"pr_author": "mexxexx",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6":... | |
f0ab95d89309aa5ec5da946f0f46e8563ffd0ebf | 2020-05-24 16:04:32 | codecov-commenter: # [Codecov](https://codecov.io/gh/TDAmeritrade/stumpy/pull/183?src=pr&el=h1) Report
> Merging [#183](https://codecov.io/gh/TDAmeritrade/stumpy/pull/183?src=pr&el=desc) into [master](https://codecov.io/gh/TDAmeritrade/stumpy/commit/f8cd8fbd40df3b0d748d2cf394e6a48f6d581fb6&el=desc) will **not change** ... | tdameritrade__stumpy-183 | diff --git a/stumpy/core.py b/stumpy/core.py
index 24e1ffe..a32ed64 100644
--- a/stumpy/core.py
+++ b/stumpy/core.py
@@ -663,17 +663,81 @@ def mass(Q, T, M_T=None, Σ_T=None):
if np.any(np.isnan(Q)):
distance_profile[:] = np.inf
else:
+ if M_T is None or Σ_T is None:
+ T, M_T, Σ_T = ... | Added preprocess function
Following some discussions in issue #166 I created a preprocessing function (and an `apply_exclusion_zone` function) that is used by all (currently only 1D) algorithms. Furthermore, `core.mass` now supports time series with NaN/Inf.
| **Title**
Unified preprocessing and exclusion‑zone handling for matrix‑profile algorithms
**Problem**
Matrix‑profile functions duplicated logic for handling `NaN`/`Inf` values and for applying exclusion zones, leading to inconsistent behavior and incorrect results when such values appear in the time series.
*... | 183 | TDAmeritrade/stumpy | diff --git a/tests/test_core.py b/tests/test_core.py
index 6d98442..0e85185 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -1,5 +1,6 @@
import numpy as np
import numpy.testing as npt
+import pandas as pd
from stumpy import core
import pytest
import os
@@ -32,20 +33,18 @@ def test_check_window_size():
... | [
"tests/test_core.py::test_mass_nan[Q0-T0]",
"tests/test_core.py::test_mass_nan[Q1-T1]",
"tests/test_core.py::test_mass_nan[Q2-T2]",
"tests/test_core.py::test_mass_inf[Q0-T0]",
"tests/test_core.py::test_mass_inf[Q1-T1]",
"tests/test_core.py::test_mass_inf[Q2-T2]",
"tests/test_core.py::test_apply_exclusio... | [
"tests/test_core.py::test_check_dtype_float32",
"tests/test_core.py::test_check_dtype_float64",
"tests/test_core.py::test_check_window_size",
"tests/test_core.py::test_sliding_dot_product[Q0-T0]",
"tests/test_core.py::test_sliding_dot_product[Q1-T1]",
"tests/test_core.py::test_sliding_dot_product[Q2-T2]",... | Function: apply_exclusion_zone(D, idx, excl_zone)
Location: stumpy.core
Inputs:
- D (ndarray): array (1‑D or ND) on which the exclusion zone will be applied; modified in‑place.
- idx (int): center index of the exclusion zone.
- excl_zone (int): half‑width of the zone; all elements with indices in [idx‑excl_zone, idx+ex... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -e .",
"pip install -q pytest pandas dask distributed coverage flake8 black"
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/test_c... | {
"num_modified_files": 8,
"num_modified_lines": 202,
"pr_author": "mexxexx",
"pr_labels": [],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... |
15b290a11ce2389701e16d127365194192b924d4 | 2020-06-04 14:40:22 | codecov-commenter: # [Codecov](https://codecov.io/gh/TDAmeritrade/stumpy/pull/199?src=pr&el=h1) Report
> Merging [#199](https://codecov.io/gh/TDAmeritrade/stumpy/pull/199?src=pr&el=desc) into [master](https://codecov.io/gh/TDAmeritrade/stumpy/commit/15b290a11ce2389701e16d127365194192b924d4&el=desc) will **not change** ... | tdameritrade__stumpy-199 | diff --git a/stumpy/core.py b/stumpy/core.py
index 66b96a9..6e6cb03 100644
--- a/stumpy/core.py
+++ b/stumpy/core.py
@@ -305,16 +305,20 @@ def compute_mean_std(T, m):
for iteration in range(max_iter):
try:
chunk_size = math.ceil((T.shape[-1] + 1) / num_chunks)
+ if chunk_size < m:
... | Fixed Issue #198
This PR fixes issue #198 . | **Title**
Robust handling of edge cases in mean‑std computation for rolling windows
**Problem**
`compute_mean_std` could fail or return incorrect statistics when the data length does not divide evenly into the requested number of chunks, especially when a chunk becomes smaller than the rolling window size. The p... | 199 | TDAmeritrade/stumpy | diff --git a/tests/test_core.py b/tests/test_core.py
index ae1048e..732ae1c 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -1,7 +1,7 @@
import numpy as np
import numpy.testing as npt
import pandas as pd
-from stumpy import core
+from stumpy import core, config
import pytest
import os
@@ -101,6 +101,... | [
"tests/test_core.py::test_compute_mean_std_chunked[Q0-T0]",
"tests/test_core.py::test_compute_mean_std_chunked[Q1-T1]",
"tests/test_core.py::test_compute_mean_std_chunked[Q2-T2]",
"tests/test_core.py::test_compute_mean_std_chunked_many[Q0-T0]",
"tests/test_core.py::test_compute_mean_std_chunked_many[Q1-T1]"... | [
"tests/test_core.py::test_check_dtype_float32",
"tests/test_core.py::test_check_dtype_float64",
"tests/test_core.py::test_check_window_size",
"tests/test_core.py::test_sliding_dot_product[Q0-T0]",
"tests/test_core.py::test_sliding_dot_product[Q1-T1]",
"tests/test_core.py::test_sliding_dot_product[Q2-T2]",... | Variable: STUMPY_MEAN_STD_NUM_CHUNKS
Location: stumpy.config module
Inputs: int > 0 – number of chunks to split the time‑series into when computing rolling means and standard deviations (default = 1). Setting this to a larger value enables a chunked (memory‑efficient) implementation.
Outputs: None (global configuration... | custom-check-github | {
"base_image_name": "python_base_310",
"install": [
"pip install -q -e .",
"pip install -q pytest pandas dask distributed coverage flake8 black"
],
"log_parser": "parse_log_pytest",
"test_cmd": "pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning tests/test_c... | {
"num_modified_files": 1,
"num_modified_lines": 6,
"pr_author": "mexxexx",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6": ... |
c1d543303e7c0345073b88628604e306dc93d3b6 | 2023-08-18 13:39:59 | github-actions[bot]: **Size Change:** +176 B (+1%)
**Total Size:** 25.1 kB
| Filename | Size | Change | |
| :--- | :---: | :---: | :---: |
| `valibot/dist/valibot.js` | 577 B | +56 B (+11%) | ⚠️ |
| `valibot/dist/valibot.module.js` | 594 B | +57 B (+11%) | ⚠️ |
| `valibot/dist/valibot.umd.js` | 684 B | +63 B (+10%)... | react-hook-form__resolvers-620 | diff --git a/valibot/src/valibot.ts b/valibot/src/valibot.ts
index 9569bd4..ec269b1 100644
--- a/valibot/src/valibot.ts
+++ b/valibot/src/valibot.ts
@@ -7,70 +7,85 @@ import {
parse,
parseAsync,
} from 'valibot';
-import { FieldErrors, FieldError } from 'react-hook-form';
-
-type FlatErrors = Record<string, [Fie... | feat(valibot): add more tests, support of `criteriaMode` and reduce size | **Title**
Add full `criteriaMode` support to Valibot resolver and streamline defaults
**Problem**
The resolver only returned the first validation error per field, ignoring the `criteriaMode: 'all'` option. Default schema options were also not merged reliably, leading to inconsistent behavior across sync/async mode... | 620 | react-hook-form/resolvers | diff --git a/valibot/src/__tests__/Form-native-validation.tsx b/valibot/src/__tests__/Form-native-validation.tsx
new file mode 100644
index 0000000..4439cbb
--- /dev/null
+++ b/valibot/src/__tests__/Form-native-validation.tsx
@@ -0,0 +1,81 @@
+import React from 'react';
+import { useForm } from 'react-hook-form';
+impo... | [
"valibot/src/__tests__/valibot.ts > valibotResolver > should return all the errors from valibotResolver when validation fails with `validateAllFieldCriteria` set to true",
"valibot/src/__tests__/valibot.ts > valibotResolver > should return all the errors from valibotResolver when validation fails with `validateAl... | [
"ajv/src/__tests__/ajv.ts > ajvResolver > should return values from ajvResolver when validation pass",
"ajv/src/__tests__/ajv.ts > ajvResolver > should return values from ajvResolver with `mode: sync` when validation pass",
"ajv/src/__tests__/ajv.ts > ajvResolver > should return single error message from ajvRes... | Method: valibotResolver(schema, schemaOptions?, resolverOptions?) → async (values, _, options) ⇒ Promise<{ values: any; errors: FieldErrors }>
Location: src/valibot.ts
Inputs:
- **schema** – `BaseSchema | BaseSchemaAsync` – the Valibot schema to validate against.
- **schemaOptions** – optional object (default `{ abortE... | MIT | {
"base_image_name": "node_20",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx vitest run --reporter=verbose --color=false"
} | {
"num_modified_files": 1,
"num_modified_lines": 67,
"pr_author": "jorisre",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6":... |
a9d319d43291d4f01616f5d5424c6b19dacdd4e7 | 2023-08-20 09:53:21 | github-actions[bot]: **Size Change:** +364 B (+1%)
**Total Size:** 25.4 kB
| Filename | Size | Change | |
| :--- | :---: | :---: | :---: |
| `dist/resolvers.js` | 484 B | +125 B (+35%) | 🚨 |
| `dist/resolvers.module.js` | 491 B | +118 B (+32%) | 🚨 |
| `dist/resolvers.umd.js` | 575 B | +121 B (+27%) | 🚨 |
<detai... | react-hook-form__resolvers-621 | diff --git a/.vscode/settings.json b/.vscode/settings.json
index eaf6a64..eb5a19a 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -5,7 +5,7 @@
"typescript",
"typescriptreact"
],
- "prettier.configPath": "./.prettierrc.js",
+ "prettier.configPath": "./prettier.config.cjs",
"editor.for... | feat: add support for root errors for field array | **Title**
Add support for root‑level errors on field arrays
**Problem**
When a validation schema reports an error that applies to an entire field array, the error is not represented in the result returned by the resolvers. Consequently, form components cannot react to array‑wide validation failures.
**Root Ca... | 621 | react-hook-form/resolvers | diff --git a/.prettierrc.js b/prettier.config.cjs
similarity index 100%
rename from .prettierrc.js
rename to prettier.config.cjs
diff --git a/src/__tests__/__snapshots__/toNestObject.ts.snap b/src/__tests__/__snapshots__/toNestError.ts.snap
similarity index 100%
rename from src/__tests__/__snapshots__/toNestObject.ts.s... | [
"src/__tests__/toNestErrors.ts > transforms flat object to nested object",
"src/__tests__/toNestErrors.ts > transforms flat object to nested object and shouldUseNativeValidation: true",
"src/__tests__/toNestErrors.ts > transforms flat object to nested object with root error for field array"
] | [
"arktype/src/__tests__/arktype.ts > arktypeResolver > should return values from arktypeResolver when validation pass & raw=true",
"src/__tests__/validateFieldsNatively.ts > validates natively fields",
"computed-types/src/__tests__/computed-types.ts > computedTypesResolver > should return values from computedTyp... | Function: toNestErrors<TFieldValues extends FieldValues>(errors: FieldErrors, options: ResolverOptions<TFieldValues>)
Location: src/toNestErrors.ts
Inputs:
- **errors**: `FieldErrors` – a flat record where keys are field paths (e.g., `"name"` or `"fieldArray.0.name"`) and values are `FieldError` objects containing at l... | MIT | {
"base_image_name": "node_20",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx vitest run --reporter=verbose --color=false"
} | {
"num_modified_files": 19,
"num_modified_lines": 166,
"pr_author": "jorisre",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... |
6f1b139cfe34d5c18d07b5201dec427aa3607e3c | 2023-12-29 19:32:41 | react-hook-form__resolvers-656 | diff --git a/src/toNestErrors.ts b/src/toNestErrors.ts
index 5c4b839..e68d3d3 100644
--- a/src/toNestErrors.ts
+++ b/src/toNestErrors.ts
@@ -23,10 +23,7 @@ export const toNestErrors = <TFieldValues extends FieldValues>(
});
if (isNameInFieldArray(options.names || Object.keys(errors), path)) {
- const f... | Fixes error handling for array errors with root error
Fixes https://github.com/react-hook-form/resolvers/issues/629
Issue:
If you had a field array with two elements and an error in the second element THEN a root error, `.compact` would recognize the second element error as an error in the first element.
Solutio... | **Title**
Correct handling of array element errors when a root error is present
**Problem**
When a field array contains an error on a later element and a separate root‑level error, the error‑mapping logic mistakenly attributes the later element’s error to the first element. This results in inaccurate error displ... | 656 | react-hook-form/resolvers | diff --git a/src/__tests__/toNestErrors.ts b/src/__tests__/toNestErrors.ts
index 6ac0df6..983fdde 100644
--- a/src/__tests__/toNestErrors.ts
+++ b/src/__tests__/toNestErrors.ts
@@ -204,3 +204,54 @@ test('transforms flat object to nested object with root error for field array',
],
});
});
+
+test('ensures consi... | [
"src/__tests__/toNestErrors.ts > ensures consistent ordering when a field array has a root error and an error in the non-first element"
] | [
"src/__tests__/validateFieldsNatively.ts > validates natively fields",
"src/__tests__/toNestErrors.ts > transforms flat object to nested object",
"src/__tests__/toNestErrors.ts > transforms flat object to nested object and shouldUseNativeValidation: true",
"src/__tests__/toNestErrors.ts > transforms flat obje... | Function: toNestErrors<TFieldValues extends FieldValues>(flatErrors: Record<string, { type: string; message: string }>, options: { fields: Record<string, { name: string; ref: { name: string } }>; names: InternalFieldName[]; shouldUseNativeValidation: boolean })
Location: src/toNestErrors.ts
Inputs:
- **flatErrors** – a... | MIT | {
"base_image_name": "node_20",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx vitest run --reporter=verbose --color=false"
} | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "SangJunBak",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
8ea953c84da3ae6a56858b4980fff6df700f8914 | 2025-02-21 16:09:35 | react-hook-form__resolvers-746 | diff --git a/bun.lock b/bun.lock
index b6d9c48..53d1226 100644
--- a/bun.lock
+++ b/bun.lock
@@ -9,6 +9,7 @@
"devDependencies": {
"@sinclair/typebox": "^0.34.15",
"@standard-schema/spec": "^1.0.0",
+ "@standard-schema/utils": "^0.3.0",
"@testing-library/dom": "^10.4.0",
... | fix(standard-schema): Propertly handle object path segments
In StandardSchema issues, path segments can either be keys or an object with a `.key` value.
Current handling just calls `path.join('.')`, which would result in `"object Object"` if any path segments are objects.
The Standard Schema team have `@standard-s... | **Title**
Properly resolve field paths for Standard Schema issues containing object segments
**Problem**
When the Standard Schema validator returns validation issues, the path information can be a mix of plain keys and objects with a `.key` property. The resolver previously concatenated path segments directly, w... | 746 | react-hook-form/resolvers | diff --git a/standard-schema/src/__tests__/__fixtures__/data.ts b/standard-schema/src/__tests__/__fixtures__/data.ts
index e37f521..a71f4c5 100644
--- a/standard-schema/src/__tests__/__fixtures__/data.ts
+++ b/standard-schema/src/__tests__/__fixtures__/data.ts
@@ -1,3 +1,4 @@
+import { StandardSchemaV1 } from '@standar... | [
"typeschema/src/__tests__/Form.tsx > form's validation with TypeSchema and TypeScript's integration"
] | [
"valibot/src/__tests__/Form.tsx > form's validation with Valibot and TypeScript's integration",
"typeschema/src/__tests__/typeschema.ts > typeschemaResolver > should return values from typeschemaResolver when validation pass & raw=true",
"typeschema/src/__tests__/typeschema.ts > typeschemaResolver > should retu... | Function: standardSchemaResolver<Schema extends StandardSchemaV1<FieldValues>>(schema: Schema, resolverOptions?: { raw?: boolean })
Location: exported from `standard-schema/src/standard-schema.ts`
Inputs:
- `schema`: a Standard Schema V1 definition whose `~standard.validate` method is used for validation.
- `resolverOp... | MIT | {
"base_image_name": "node_20",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx vitest run --reporter=verbose --color=false"
} | {
"num_modified_files": 4,
"num_modified_lines": 10,
"pr_author": "EskiMojo14",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B... | |
3bc2ad50a63ef8c114336403f182a32e2df7552d | 2025-06-05 02:44:16 | Jamess-Lucass: I've noticed the error messages returned from the form errors has changed when referencing zod/v4.
```typescript
import { useForm } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import { z } from "zod";
const formSchema = z.object({
firstname: z.string().max(2... | react-hook-form__resolvers-777 | diff --git a/README.md b/README.md
index 9ae0fd4..9fa6f4d 100644
--- a/README.md
+++ b/README.md
@@ -68,7 +68,7 @@ Example:
```tsx
import { useForm } from 'react-hook-form';
import { zodResolver } from '@hookform/resolvers/zod';
-import { z } from 'zod';
+import { z } from 'zod'; // or 'zod/v4'
const schema = z.o... | feat: support Zod 4
Per some discussions I've been having with @bluebill1049, this PR adds support for Zod 4.
The other PR by @alexcraviotto (https://github.com/react-hook-form/resolvers/pull/776) is really solid but we decided to go another direction.
- This PR bumps the minimum Zod version to `3.25.0`
- Wit... | **Title**
Add Zod 4 compatibility to the Zod resolver
**Problem**
The resolver currently only supports Zod 3, so projects that upgrade to Zod 4 lose the ability to use `zodResolver`. The documentation and package metadata also reference the older Zod repository and version range, which can mislead users.
**Ro... | 777 | react-hook-form/resolvers | diff --git a/standard-schema/src/__tests__/__fixtures__/data.ts b/standard-schema/src/__tests__/__fixtures__/data.ts
index fc72250..7236799 100644
--- a/standard-schema/src/__tests__/__fixtures__/data.ts
+++ b/standard-schema/src/__tests__/__fixtures__/data.ts
@@ -1,6 +1,6 @@
import { StandardSchemaV1 } from '@standar... | [
"zod/src/__tests__/zod-v4-mini.ts > zodResolver > should return a single error from zodResolver when validation fails",
"zod/src/__tests__/zod-v4-mini.ts > zodResolver > should return all the errors from zodResolver when validation fails with `validateAllFieldCriteria` set to true",
"zod/src/__tests__/zod-v4-mi... | [
"typanion/src/__tests__/typanion.ts > typanionResolver > should return values from typanionResolver when validation pass",
"typanion/src/__tests__/typanion.ts > typanionResolver > should return a single error from typanionResolver when validation fails",
"typanion/src/__tests__/typanion.ts > typanionResolver > ... | Function: zodResolver(schema: Zod3Type<Output, Input>, schemaOptions?: Zod3ParseParams, resolverOptions?: { mode?: 'async'|'sync'; raw?: false })
Location: zod/src/zod.ts
Inputs:
- **schema** – Zod v3 schema (`z3.ZodSchema`) whose generic `<Output, Input>` describe the parsed output and raw input types.
- **schemaOptio... | MIT | {
"base_image_name": "node_20",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx vitest run --reporter=verbose --color=false"
} | {
"num_modified_files": 5,
"num_modified_lines": 234,
"pr_author": "colinhacks",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... |
8db56ae0dd4062a0a3becb5b36203fa929b835b5 | 2021-11-28 10:48:35 | cdimascio: @zzgab thanks. This looks good. Please add the tsignore and I’ll get this merged
zzgab: Updated.
Thanks. | cdimascio__express-openapi-validator-675 | diff --git a/src/resolvers.ts b/src/resolvers.ts
index 7d7445f..68dd21b 100644
--- a/src/resolvers.ts
+++ b/src/resolvers.ts
@@ -33,18 +33,16 @@ export function defaultResolver(
const modulePath = path.join(handlersPath, baseName);
if (!tmpModules[modulePath]) {
tmpModules[modulePath] = require(moduleP... | #671 default export in handler
Hi,
issue #671
I wasn't sure whether to add the `x-eov-operation-handler` optional property in `OperationObject` interface (since it has an important meaning in the program).
If you think it does not belong, we could instead use a `// @ts-ignore` comment in my new test before li... | **Title**
Support default export handlers in operation resolver
**Problem**
The resolver could not locate a handler when a module used a default export, leading to missing‐handler errors at runtime. Existing error messages did not clarify the default export case.
**Root Cause**
The resolver overwrote the requ... | 675 | cdimascio/express-openapi-validator | diff --git a/test/default-export.spec.ts b/test/default-export.spec.ts
new file mode 100644
index 0000000..6b4cd2f
--- /dev/null
+++ b/test/default-export.spec.ts
@@ -0,0 +1,46 @@
+import * as express from 'express';
+import * as OpenApiValidator from '../src';
+import { expect } from 'chai';
+import * as request from ... | [
"should use default export operation"
] | [
"create campaign should return 201",
"create campaign should return 400",
"create campaign should return 200",
"should return 200",
"should return 201",
"does not mutate the API specification",
"does not validate responses which are not present in the spec",
"should allow additional / unknown properti... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci",
"npm run compile"
],
"log_parser": "parse_log_js",
"test_cmd": "npx mocha -r source-map-support/register -r ts-node/register --files --recursive -R spec test/**/*.spec.ts 2>&1 | sed 's/\\x1b\\[[0-9;]*m//g'"
} | {
"num_modified_files": 1,
"num_modified_lines": 5,
"pr_author": "zzgab",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": fa... |
56f778b524f313f50b1570a50813e34474fd9f31 | 2021-12-24 09:55:42 | cdimascio: @pilerou, can you separate the bug fix from the new feature
i'd like to get the bug fix in immediately, but need more time to consider the feature request.
pilerou: Hi @cdimascio I did the revert in my fork on origin/master linked to this PR.
There's only fixes now on my master branch.
I created a branc... | cdimascio__express-openapi-validator-684 | diff --git a/src/framework/ajv/index.ts b/src/framework/ajv/index.ts
index bd5a6f7..ca879d4 100644
--- a/src/framework/ajv/index.ts
+++ b/src/framework/ajv/index.ts
@@ -59,6 +59,15 @@ function createAjv(
obj[propName] = sch.deserialize(data);
}
catch(e) {
+ ... | Patch on serdes test and allow to use generated AJV out of Express usage
It fixes a bug in serdes unit test by sending a more human readable message
AND
it could allow to use the generated Ajv behind OpenApiValidator out of an express usage.
It could be great, for example, to validate websocket request... | **Title**
Improve serdes error reporting and expose generated AJV for non‑Express usage
**Problem**
- Serdes unit tests receive unhelpful error output, making debugging difficult.
- The AJV instance created by the OpenAPI validator is tightly coupled to Express, preventing reuse in other contexts such as WebSo... | 684 | cdimascio/express-openapi-validator | diff --git a/test/serdes.spec.ts b/test/serdes.spec.ts
index 3f822f8..0260326 100644
--- a/test/serdes.spec.ts
+++ b/test/serdes.spec.ts
@@ -307,13 +307,13 @@ describe('serdes serialize response components only', () => {
.expect(500)
.then((r) => {
console.log(r);
- expect(r.body.message).... | [
"should throw error 500 on invalid object type instead of Date expected"
] | [
"create campaign should return 201",
"create campaign should return 400",
"create campaign should return 200",
"should return 200",
"should return 201",
"does not mutate the API specification",
"does not validate responses which are not present in the spec",
"should allow additional / unknown properti... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci",
"npm run compile"
],
"log_parser": "parse_log_js",
"test_cmd": "npx mocha -r source-map-support/register -r ts-node/register --files --recursive -R spec test/**/*.spec.ts 2>&1 | sed 's/\\x1b\\[[0-9;]*m//g'"
} | {
"num_modified_files": 1,
"num_modified_lines": 18,
"pr_author": "pilerou",
"pr_labels": [],
"llm_metadata": {
"code": "B2|B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": true,
"B5": false,
"B6... |
98796b2c914ec340bd7c17772cdba3e2a5c3218a | 2024-08-08 11:02:54 | iliapolo: Also see https://github.com/cdk8s-team/cdk8s-plus/pull/4500#issuecomment-2283286630. Thanks!
serhatcetinkaya: @iliapolo thanks for the review, #4500 is merged 👍
I sent a fix to separate the tests for this one, can you please also take a look at #4483 when you have time? thanks in advance
iliapolo: @serh... | cdk8s-team__cdk8s-plus-4499 | diff --git a/src/container.ts b/src/container.ts
index 77b8d202..f145ff0f 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -181,6 +181,37 @@ export enum Capability {
WAKE_ALARM = 'WAKE_ALARM',
}
+export enum SeccompProfileType {
+ /**
+ * A profile defined in a file on the node should be used
+ */
+ LO... | feat(container): support seccompProfile in container security context
this adds support for SeccompProfile in container security context.
please refer to:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#seccompprofile-v1-core
this should also be backported to 1.29 and 1.28 main branches | **Title**
Add seccomp profile support to container security context
**Problem**
Containers could not specify a Seccomp profile, preventing users from applying fine‑grained syscall filtering required by many security policies. The lack of this field also meant generated manifests were incomplete for workloads tha... | 4,499 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index f1795cd4..4b4a2ed2 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -1,7 +1,7 @@
import * as cdk8s from 'cdk8s';
import { Size, Testing } from 'cdk8s';
import * as kplus from '../src';
-import { Container, Cpu, Handler, ConnectionS... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"seccompProfile localhostProfile can not be us... | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"defaultChild",
"defaults",
"can select namespaces",
"can select all namespaces",
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"can grant permissions on imported",
"minimal",
"w... | Enum: SeccompProfileType
Location: src/container.ts
Inputs: No runtime inputs (enum values are compile‑time constants)
Outputs: Values ‑ LOCALHOST = 'Localhost', RUNTIME_DEFAULT = 'RuntimeDefault', UNCONFINED = 'Unconfined'
Description: Enumerates the allowed seccomp profile sources for a container. Used when construct... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 44,
"pr_author": "serhatcetinkaya",
"pr_labels": [
"backport-to-k8s-28/main: Backport a PR to the k8s-28 branch",
"backport-to-k8s-29/main: Backport a PR to the k8s-30 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confid... |
b3399e27a1de60ed09d1a9e43e3ad625369918c8 | 2024-08-08 11:55:27 | cdk8s-team__cdk8s-plus-4500 | diff --git a/src/service.ts b/src/service.ts
index 871ab86b..27bb6a5f 100644
--- a/src/service.ts
+++ b/src/service.ts
@@ -94,6 +94,16 @@ export interface ServiceProps extends base.ResourceProps {
*/
readonly loadBalancerSourceRanges?: string[];
+ /**
+ * The publishNotReadyAddresses indicates that any agen... | feat(service): support `publishNotReadyAddresses`
add support for publishNotReadyAddresses. for more info:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#servicespec-v1-core
this should be backported to 1.29 and 1.28 main branches | **Title**
Add support for the `publishNotReadyAddresses` option on Service resources
**Problem**
Creating a Service did not allow callers to control whether endpoints that are not yet ready should be published. This limitation prevented users from configuring services that need to expose pods before they become ... | 4,500 | cdk8s-team/cdk8s-plus | diff --git a/test/service.test.ts b/test/service.test.ts
index 48083e87..106de6bf 100644
--- a/test/service.test.ts
+++ b/test/service.test.ts
@@ -185,3 +185,14 @@ test('can be exposed by an ingress', () => {
const ingress = Testing.synth(chart)[1];
expect(ingress).toMatchSnapshot();
});
+
+test('can set publish... | [
"Must be configured with at least one port",
"Can provide cluster IP",
"can select a deployment",
"Can serve by port",
"Must set externalIPs if provided",
"Must be configured with externalName if type is EXTERNAL_NAME",
"Type defaults to EXTERNAL_NAME if externalName if given",
"Can restrict CIDR IP a... | [
"defaultChild",
"default configuration",
"custom configuration",
"Can be isolated",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not modify existing restart policy of pod spec",
"Synthesizes spec lazily",
"default child",
"defaults",
"custom",
"a label sele... | Method: Service.constructor(scope: Construct, id: string, props: ServiceProps)
Location: src/service.ts
Inputs:
- **scope** – Construct in which the Service will be defined.
- **id** – Unique identifier for the Service construct.
- **props** – ServiceProps object; may include the optional boolean **publishNot... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 13,
"pr_author": "serhatcetinkaya",
"pr_labels": [
"backport-to-k8s-28/main: Backport a PR to the k8s-28 branch",
"backport-to-k8s-29/main: Backport a PR to the k8s-30 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confid... | |
52f2dc56533098c969c1d9338f1bf6301051b41a | 2024-08-12 08:51:11 | cdk8s-team__cdk8s-plus-4510 | diff --git a/src/service.ts b/src/service.ts
index 871ab86b..27bb6a5f 100644
--- a/src/service.ts
+++ b/src/service.ts
@@ -94,6 +94,16 @@ export interface ServiceProps extends base.ResourceProps {
*/
readonly loadBalancerSourceRanges?: string[];
+ /**
+ * The publishNotReadyAddresses indicates that any agen... | feat(service): support `publishNotReadyAddresses` (#4500)
# Backport
This will backport the following commits from `k8s-30/main` to `k8s-28/main`:
- [feat(service): support `publishNotReadyAddresses` (#4500)](https://github.com/cdk8s-team/cdk8s-plus/pull/4500)
<!--- Backport version: 8.9.9 -->
### Questions ?
Ple... | **Title**
Add support for `publishNotReadyAddresses` on Service resources
**Problem**
Consumers need the ability to expose endpoints of pods that are not yet marked ready. The Service construct previously lacked a way to configure this behavior, limiting use‑cases that rely on early traffic routing or mesh integ... | 4,510 | cdk8s-team/cdk8s-plus | diff --git a/test/service.test.ts b/test/service.test.ts
index 48083e87..106de6bf 100644
--- a/test/service.test.ts
+++ b/test/service.test.ts
@@ -185,3 +185,14 @@ test('can be exposed by an ingress', () => {
const ingress = Testing.synth(chart)[1];
expect(ingress).toMatchSnapshot();
});
+
+test('can set publish... | [
"Must be configured with at least one port",
"Can provide cluster IP",
"can select a deployment",
"Can serve by port",
"Must set externalIPs if provided",
"Must be configured with externalName if type is EXTERNAL_NAME",
"Type defaults to EXTERNAL_NAME if externalName if given",
"Can restrict CIDR IP a... | [
"can grant permissions on imported",
"role can bind to imported",
"defaultChild",
"minimal definition",
"secrets can be added to the service account",
"auto mounting token can be disabled",
"Can mutate metadata",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not... | Method: Service.constructor(self, scope: Construct, id: string, props: ServiceProps = {})
Location: src/service.ts
Inputs:
- **scope** – Construct : parent construct in which the Service is defined.
- **id** – string : logical identifier for the Service construct.
- **props** – ServiceProps : configuration ob... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 13,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": false,
"B2": ... | |
cd45d5968ac322367a29972d6fb7af9bcd66c5ba | 2024-08-14 10:15:12 | cdk8s-team__cdk8s-plus-4521 | diff --git a/src/container.ts b/src/container.ts
index 77b8d202..f145ff0f 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -181,6 +181,37 @@ export enum Capability {
WAKE_ALARM = 'WAKE_ALARM',
}
+export enum SeccompProfileType {
+ /**
+ * A profile defined in a file on the node should be used
+ */
+ LO... | feat(container): support seccompProfile in container security context (#4499)
# Backport
This will backport the following commits from `k8s-30/main` to `k8s-28/main`:
- [feat(container): support seccompProfile in container security context (#4499)](https://github.com/cdk8s-team/cdk8s-plus/pull/4499)
<!--- Backport v... | **Title**
Add seccomp profile support to container security contexts
**Problem**
Container security contexts did not expose any way to configure seccomp profiles, preventing users from applying fine‑grained syscall filtering to their workloads.
**Root Cause**
The security context model lacked fields and val... | 4,521 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index f1795cd4..4b4a2ed2 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -1,7 +1,7 @@
import * as cdk8s from 'cdk8s';
import { Size, Testing } from 'cdk8s';
import * as kplus from '../src';
-import { Container, Cpu, Handler, ConnectionS... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"seccompProfile localhostProfile can not be us... | [
"can grant permissions on imported",
"role can bind to imported",
"defaultChild",
"minimal definition",
"secrets can be added to the service account",
"auto mounting token can be disabled",
"defaults",
"custom",
"can be imported",
"can be bounded to a volume at instantiation",
"can be bounded to... | Enum: SeccompProfileType
Location: src/container.ts
Inputs: None (enumeration values)
Outputs: Enum members: LOCALHOST = 'Localhost', RUNTIME_DEFAULT = 'RuntimeDefault', UNCONFINED = 'Unconfined'
Description: Enumerates the supported seccomp profile types for a container's security context. Used to specify whether a pr... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 44,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2":... | |
189074087c2bd858d77316ece86d98c4ab47a3c8 | 2024-08-27 10:52:19 | cdk8s-team__cdk8s-plus-4574 | diff --git a/src/pod.ts b/src/pod.ts
index c7f4ea6b..3ac602bc 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -122,15 +122,15 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public addInitContainer(cont: container.ContainerProps): container.Container {
// https://kubernetes.io/... | fix(pod): allow sidecar containers to have probes (#4483)
# Backport
This will backport the following commits from `k8s-30/main` to `k8s-28/main`:
- [fix(pod): allow sidecar containers to have probes (#4483)](https://github.com/cdk8s-team/cdk8s-plus/pull/4483)
<!--- Backport version: 8.9.9 -->
### Questions ?
Pleas... | **Title**
Allow sidecar init containers to define readiness, liveness and startup probes
**Problem**
Init containers are prohibited from having probes, but init containers that are actually sidecars (declared with a restart policy of Always) need to be able to use probes. The existing validation incorrectly reje... | 4,574 | cdk8s-team/cdk8s-plus | diff --git a/test/pod.test.ts b/test/pod.test.ts
index 977e64da..17f44567 100644
--- a/test/pod.test.ts
+++ b/test/pod.test.ts
@@ -254,6 +254,45 @@ test('init containers cannot have startup probe', () => {
});
+test('sidecar containers can have liveness probe', () => {
+
+ const chart = Testing.chart();
+ const ... | [
"sidecar containers can have liveness probe",
"sidecar containers can have readiness probe",
"sidecar containers can have startup probe"
] | [
"defaultChild",
"defaults",
"can select namespaces",
"can select all namespaces",
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not modify existing restart policy of pod spec",
"Synthesizes spec lazily",
"Can be... | Method: AbstractPod.addInitContainer(cont: container.ContainerProps)
Location: src/pod.ts – class AbstractPod (extends base.Resource)
Inputs:
- **cont** – `container.ContainerProps` describing the init container.
Important fields:
• `image` (string, required)
• `restartPolicy` (`container.ContainerRestartP... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 10,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": false,
"B2": ... | |
bcd98f94e402475318f7a340f752185daf9707b1 | 2024-08-27 10:52:22 | cdk8s-team__cdk8s-plus-4575 | diff --git a/src/pod.ts b/src/pod.ts
index c7f4ea6b..3ac602bc 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -122,15 +122,15 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public addInitContainer(cont: container.ContainerProps): container.Container {
// https://kubernetes.io/... | fix(pod): allow sidecar containers to have probes (#4483)
# Backport
This will backport the following commits from `k8s-30/main` to `k8s-29/main`:
- [fix(pod): allow sidecar containers to have probes (#4483)](https://github.com/cdk8s-team/cdk8s-plus/pull/4483)
<!--- Backport version: 8.9.9 -->
### Questions ?
Pleas... | **Title**
Allow sidecar init containers to define readiness, liveness, and startup probes
**Problem**
Init containers are prohibited from having probes, but sidecar containers (a special type of init container with an always‑restart policy) need to be able to specify them. The existing validation prevented sidec... | 4,575 | cdk8s-team/cdk8s-plus | diff --git a/test/pod.test.ts b/test/pod.test.ts
index 977e64da..17f44567 100644
--- a/test/pod.test.ts
+++ b/test/pod.test.ts
@@ -254,6 +254,45 @@ test('init containers cannot have startup probe', () => {
});
+test('sidecar containers can have liveness probe', () => {
+
+ const chart = Testing.chart();
+ const ... | [
"sidecar containers can have liveness probe",
"sidecar containers can have readiness probe",
"sidecar containers can have startup probe"
] | [
"default child",
"defaults",
"custom",
"a label selector is automatically allocated",
"no selector is generated if \"select\" is false",
"can select by label",
"Can be isolated",
"defaultChild",
"can select namespaces",
"can select all namespaces",
"can grant permissions on imported",
"minimal... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 10,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B6",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2":... | |
4922c60bbff6814fc3571079417990d90a57019d | 2024-02-22 14:48:47 | cdk8s-team__cdk8s-plus-3764 | diff --git a/src/ingress.ts b/src/ingress.ts
index 09bfceb7..983ddbbf 100644
--- a/src/ingress.ts
+++ b/src/ingress.ts
@@ -40,6 +40,14 @@ export interface IngressProps extends base.ResourceProps {
* extension, if the ingress controller fulfilling the ingress supports SNI.
*/
readonly tls?: IngressTls[];
+
+ ... | fix(ingress): add `ingressClassName` to `IngressProps` (#2964)
# Backport
This will backport the following commits from `k8s-27/main` to `k8s-25/main`:
- [fix(ingress): add `ingressClassName` to `IngressProps` (#2964)](https://github.com/cdk8s-team/cdk8s-plus/pull/2964)
<!--- Backport version: 8.5.0 -->
### Questio... | **Title**
Expose `ingressClassName` via Ingress properties
**Problem**
The library’s Ingress construct did not provide a way to specify the Kubernetes `ingressClassName`, preventing users from selecting a particular IngressClass or controller.
**Root Cause**
The Ingress property model omitted the class name... | 3,764 | cdk8s-team/cdk8s-plus | diff --git a/test/ingress.test.ts b/test/ingress.test.ts
index 8f79dc36..65b63503 100644
--- a/test/ingress.test.ts
+++ b/test/ingress.test.ts
@@ -12,6 +12,36 @@ test('defaultChild', () => {
});
+test('IngressClassName can be set', () => {
+ // GIVEN
+ const chart = Testing.chart();
+ const service = new Servic... | [
"IngressClassName can be set",
"fromResource",
"if the service exposes a port, it will be used by the ingress",
"fails if the service does not expose a port",
"fails if a port is explicitly specified, and the service is exposed through a different port",
"service exposes a single port and its the same as ... | [
"defaultChild",
"defaults",
"can select namespaces",
"can select all namespaces",
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"can grant permissions on imported",
"custom",
"can be imported",
"can be bounded to a volume at instantiation",
"can be bounded to a volume post instantiation",
"... | Method: IngressProps.className (optional property)
Location: src/ingress.ts – interface IngressProps extends base.ResourceProps
Inputs: className?: string – the name of the IngressClass to associate with the Ingress.
Outputs: N/A (the value is emitted as spec.ingressClassName in the synthesized Ingress manifest)
Descri... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 9,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": f... | |
f15b7eea1dc24969762326d4dd2bc0eeefc6de4a | 2024-02-22 14:48:51 | cdk8s-team__cdk8s-plus-3765 | diff --git a/src/ingress.ts b/src/ingress.ts
index 09bfceb7..983ddbbf 100644
--- a/src/ingress.ts
+++ b/src/ingress.ts
@@ -40,6 +40,14 @@ export interface IngressProps extends base.ResourceProps {
* extension, if the ingress controller fulfilling the ingress supports SNI.
*/
readonly tls?: IngressTls[];
+
+ ... | fix(ingress): add `ingressClassName` to `IngressProps` (#2964)
# Backport
This will backport the following commits from `k8s-27/main` to `k8s-26/main`:
- [fix(ingress): add `ingressClassName` to `IngressProps` (#2964)](https://github.com/cdk8s-team/cdk8s-plus/pull/2964)
<!--- Backport version: 8.5.0 -->
### Questio... | **Title**
Add support for specifying an Ingress class name in Ingress constructs
**Problem**
Consumers could not declare which IngressClass a created Ingress should use, limiting control over the selected controller. The generated manifest therefore always omitted the `ingressClassName` field.
**Root Cause** ... | 3,765 | cdk8s-team/cdk8s-plus | diff --git a/test/ingress.test.ts b/test/ingress.test.ts
index 8f79dc36..65b63503 100644
--- a/test/ingress.test.ts
+++ b/test/ingress.test.ts
@@ -12,6 +12,36 @@ test('defaultChild', () => {
});
+test('IngressClassName can be set', () => {
+ // GIVEN
+ const chart = Testing.chart();
+ const service = new Servic... | [
"IngressClassName can be set",
"fromResource",
"if the service exposes a port, it will be used by the ingress",
"fails if the service does not expose a port",
"fails if a port is explicitly specified, and the service is exposed through a different port",
"service exposes a single port and its the same as ... | [
"can grant permissions on imported",
"role can bind to imported",
"defaultChild",
"minimal definition",
"secrets can be added to the service account",
"auto mounting token can be disabled",
"default child",
"defaults",
"custom",
"a label selector is automatically allocated",
"no selector is gene... | Method: Ingress.constructor(scope: Construct, id: string, props: IngressProps)
Location: src/ingress.ts
Inputs:
- **scope** – the parent construct (e.g., a Chart) in which the Ingress is defined.
- **id** – logical identifier for the Ingress construct.
- **props** – an `IngressProps` object; may include `defaultBa... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 9,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": f... | |
42147712e37dcd4777bd9c76c780768906bb75c4 | 2024-03-01 07:36:09 | serhatcetinkaya: @iliapolo thanks for the detailed check, I added all your suggestions. It should be ok now, can you give it another look please? | cdk8s-team__cdk8s-plus-3812 | diff --git a/src/container.ts b/src/container.ts
index 28048a6e..e5940b92 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -491,6 +491,27 @@ export interface ContainerLifecycle {
}
+/**
+ * RestartPolicy defines the restart behavior of individual containers in a pod.
+ * This field may only be set for init ... | feat(container): support `restartPolicy` field
[KEP-753](https://github.com/kubernetes/enhancements/tree/e1a916745378660bafb96cb3c9f754fa793342f9/keps/sig-node/753-sidecar-containers) introduced native sidecar container support starting from kubernetes v1.28
This PR adds the field to Container object. Existing tests... | **Title**
Add support for `restartPolicy` on init containers (sidecar semantics)
**Problem**
Customers need to declare a restart policy for init containers that act as sidecars, as introduced in KEP‑753. The library currently lacks this field, and there is no safeguard against setting it on regular containers.
**... | 3,812 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index 5271e331..c94d5044 100644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -1,5 +1,79 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
+exports[`Container "restartPo... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"default security context",
"custom security... | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"defaultChild",
"default configuration",
"custom configuration",
"Can be isolated",
"can grant permissions on imported",
"minimal",
"with data",
"with binaryData",
"with binaryData ... | Enum: ContainerRestartPolicy
Location: src/container.ts
Inputs: NONE (enum definition)
Outputs: Enum values – ALWAYS = 'Always'
Description: Enum that defines the allowed restart policy for init containers (currently only “Always”). Used to set the `restartPolicy` field on a Container when it is an init container.
Met... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 2,
"num_modified_lines": 41,
"pr_author": "serhatcetinkaya",
"pr_labels": [
"backport-to-k8s-27/main: Backport a PR to the k8s-27 branch",
"backport-to-k8s-28/main: Backport a PR to the k8s-28 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confid... |
b8b295b81d6d0bde79567988b79523e6226086e0 | 2024-03-01 08:13:32 | cdk8s-team__cdk8s-plus-3813 | diff --git a/src/role.ts b/src/role.ts
index 4615a2b6..f0fa773c 100644
--- a/src/role.ts
+++ b/src/role.ts
@@ -104,6 +104,10 @@ export class Role extends base.Resource implements IRole {
metadata: props.metadata,
rules: Lazy.any({ produce: () => this.synthesizeRules() }),
});
+
+ for (const rule o... | fix(role): use rules coming from the roleProps
This fixes a bug where any rule given from roleProps is not used. the for loop exists for clusterRole but was missing on Role. a test is included to prevent breaking in future | **Title**
Fix Role to honor permission rules supplied via role properties
**Problem**
When creating a Role, any policy rules passed through its configuration were ignored, leading to roles lacking the intended permissions. This discrepancy did not exist for ClusterRole, which correctly applied such rules.
**R... | 3,813 | cdk8s-team/cdk8s-plus | diff --git a/test/role.test.ts b/test/role.test.ts
index d63180de..e2314754 100644
--- a/test/role.test.ts
+++ b/test/role.test.ts
@@ -154,6 +154,32 @@ Array [
});
+ test('specify access from props', () => {
+
+ // GIVEN
+ const chart = Testing.chart();
+
+ // WHEN
+ new kplus.Role(chart, 'my-role',... | [
"specify access from props"
] | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"can grant permissions on imported",
"role can bind to imported",
"defaultChild",
"minimal definition",
"secrets can be added to the service account",
"auto mounting token can be disabled",
"defaults to the container port",
"specific port",
"optio... | Method: Role(scope: Construct, id: string, props: RoleProps)
Location: src/role.ts
Inputs:
- scope – the construct (e.g., a Chart) in which the Role is defined.
- id – logical ID of the Role construct.
- props – RoleProps object; may include an optional `rules` array where each rule has `verbs: string[]` and `reso... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 5,
"pr_author": "serhatcetinkaya",
"pr_labels": [
"backport-to-k8s-27/main: Backport a PR to the k8s-27 branch",
"backport-to-k8s-28/main: Backport a PR to the k8s-28 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confide... | |
acc315749224bc89ad4ff81a86d78a991d5c9787 | 2024-03-01 11:27:25 | cdk8s-team__cdk8s-plus-3818 | diff --git a/src/_action.ts b/src/_action.ts
index a1c7bc6c..40bb8d88 100644
--- a/src/_action.ts
+++ b/src/_action.ts
@@ -21,11 +21,16 @@ export class Action {
return { command };
}
- public static fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme } = { }): ... | feat(probe): add `host` property to HttpGet probes
HttpGet probes has `host` field. Added support for it in cdk8s-plus:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#httpgetaction-v1-core | **Title**
Add support for specifying a custom host in HTTP GET probes
**Problem**
HTTP GET probes always target the pod IP, making it impossible to direct probes to a specific hostname when required (e.g., when using virtual hosts or DNS overrides).
**Root Cause**
The probe abstraction does not expose the `... | 3,818 | cdk8s-team/cdk8s-plus | diff --git a/test/probe.test.ts b/test/probe.test.ts
index 17946ea5..8040b027 100644
--- a/test/probe.test.ts
+++ b/test/probe.test.ts
@@ -57,6 +57,7 @@ describe('fromHttpGet()', () => {
periodSeconds: Duration.seconds(5),
successThreshold: 3,
timeoutSeconds: Duration.minutes(2),
+ host: '1.1.... | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname"
] | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"Can mutate metadata",
"minimal definition",
"volume name is trimmed if needed",
"custom volume name",
"default mode",
"optional",
"items",
"items are sorted by key for deterministic synthesis",
"items are sorted by key for determinstic synthesis"... | Method: Action.fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme; host?: string } = {}): k8s.HttpGetAction
Location: src/_action.ts
Inputs:
- **container** – Container instance whose ports may be used as a default for the HTTP GET action.
- **path** – The request pat... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 2,
"num_modified_lines": 14,
"pr_author": "serhatcetinkaya",
"pr_labels": [
"backport-to-k8s-27/main: Backport a PR to the k8s-27 branch",
"backport-to-k8s-28/main: Backport a PR to the k8s-28 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confid... | |
e526be13b072255a753bb36aa97c1fd5cd839005 | 2024-04-07 09:03:08 | cdk8s-team__cdk8s-plus-3988 | diff --git a/src/container.ts b/src/container.ts
index 3357c648..28048a6e 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -820,14 +820,15 @@ export class Container {
public addPort(port: ContainerPort) {
const names = this._ports.map(p => p.name).filter(x => x);
- const numbers = this._ports.map(p ... | fix(container): allow the same port number with different protocols (#3508)
# Backport
This will backport the following commits from `k8s-28/main` to `k8s-26/main`:
- [fix(container): allow the same port number with different protocols (#3508)](https://github.com/cdk8s-team/cdk8s-plus/pull/3508)
<!--- Backport versi... | **Title**
Allow containers to expose the same port number with different protocols
**Problem**
Container definitions reject duplicate port numbers even when the protocols differ, preventing legitimate configurations such as TCP and UDP on the same numeric port.
**Root Cause**
Port uniqueness checks consider... | 3,988 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index 331b6fd5..eccb9ba7 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -180,23 +180,56 @@ describe('EnvValue', () => {
describe('Container', () => {
- test('cannot configure identical ports at instantiation', () => {
+ test('canno... | [
"cannot configure identical ports and protocols at instantiation",
"can configure identical ports with different protocols at instantiation",
"cannot add an already existing port number with identical protocol",
"can add an already existing port number with a different protocol"
] | [
"defaultChild",
"defaults",
"can select namespaces",
"can select all namespaces",
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"can grant permissions on imported",
"minimal",
"with data",
"with binaryData",
"with binaryData an... | Method: Container.addPort(port: ContainerPort)
Location: src/container.ts (around line 820)
Inputs:
- **port** – an object describing the container port with the following fields:
- `number` (number, required): the numeric port value.
- `name` (string, optional): an identifier for the port.
- `protocol` (Protoco... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": ... | |
d97429df6d4752cc10470c4504b66442030cf393 | 2024-04-07 09:03:13 | cdk8s-team__cdk8s-plus-3989 | diff --git a/src/container.ts b/src/container.ts
index 3357c648..28048a6e 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -820,14 +820,15 @@ export class Container {
public addPort(port: ContainerPort) {
const names = this._ports.map(p => p.name).filter(x => x);
- const numbers = this._ports.map(p ... | fix(container): allow the same port number with different protocols (#3508)
# Backport
This will backport the following commits from `k8s-28/main` to `k8s-27/main`:
- [fix(container): allow the same port number with different protocols (#3508)](https://github.com/cdk8s-team/cdk8s-plus/pull/3508)
<!--- Backport versi... | **Title**
Allow containers to expose the same port number when using different protocols
**Problem**
Container port validation incorrectly treated any reuse of a port number as a conflict, even when the protocols differed. This prevented legitimate configurations such as exposing TCP and UDP on the same port.
... | 3,989 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index 331b6fd5..eccb9ba7 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -180,23 +180,56 @@ describe('EnvValue', () => {
describe('Container', () => {
- test('cannot configure identical ports at instantiation', () => {
+ test('canno... | [
"cannot configure identical ports and protocols at instantiation",
"can configure identical ports with different protocols at instantiation",
"cannot add an already existing port number with identical protocol",
"can add an already existing port number with a different protocol"
] | [
"can grant permissions on imported",
"role can bind to imported",
"defaultChild",
"minimal definition",
"secrets can be added to the service account",
"auto mounting token can be disabled",
"Can mutate metadata",
"default configuration",
"custom configuration",
"Can be isolated",
"defaults to th... | Method: Container.addPort(port: ContainerPort)
Location: src/container.ts (class Container)
Inputs: `port` – object with mandatory `number: number` and optional `protocol?: Protocol` (defaults to `Protocol.TCP`).
Outputs: `void`; throws `Error` with message “Port with number {number} and protocol {protocol} alrea... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.86,
"detected_issues": {
"B1": false,
"B2": ... | |
ad442c7d4ed5dc6cde827d29ec9b350a22fdb665 | 2024-04-18 07:16:07 | cdk8s-team__cdk8s-plus-4042 | diff --git a/src/_action.ts b/src/_action.ts
index a1c7bc6c..40bb8d88 100644
--- a/src/_action.ts
+++ b/src/_action.ts
@@ -21,11 +21,16 @@ export class Action {
return { command };
}
- public static fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme } = { }): ... | feat(probe): add `host` property to HttpGet probes (#3818)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-27/main`:
- [feat(probe): add `host` property to HttpGet probes (#3818)](https://github.com/cdk8s-team/cdk8s-plus/pull/3818)
<!--- Backport version: 8.5.0 -->
### Questions ?
Ple... | **Title**
Add optional `host` field to HTTP GET probes
**Problem**
HTTP GET probes currently lack a way to specify a target host, forcing them to always use the pod IP. This limits scenarios where probes need to reach a named service or external endpoint.
**Root Cause**
The probe configuration and underlyin... | 4,042 | cdk8s-team/cdk8s-plus | diff --git a/test/probe.test.ts b/test/probe.test.ts
index 17946ea5..8040b027 100644
--- a/test/probe.test.ts
+++ b/test/probe.test.ts
@@ -57,6 +57,7 @@ describe('fromHttpGet()', () => {
periodSeconds: Duration.seconds(5),
successThreshold: 3,
timeoutSeconds: Duration.minutes(2),
+ host: '1.1.... | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname"
] | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"can grant permissions on imported",
"defaults",
"custom",
"can be imported",
"can be bounded to a volume at instantiation",
"can be bounded to a volume post instantiation",
"no-ops if bounded twice to the same volume",
"throws if bounded twice to d... | Method: Action.fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme; host?: string } = {}): k8s.HttpGetAction
Location: src/_action.ts
Inputs:
- **container** – the Container whose port information may be used as a default.
- **path** – HTTP request path.
- **options** – ... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 2,
"num_modified_lines": 14,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": false,
"B2": ... | |
0195aef826ef55ed3cdd35db549beced7c625261 | 2024-04-18 07:16:11 | cdk8s-team__cdk8s-plus-4043 | diff --git a/src/_action.ts b/src/_action.ts
index a1c7bc6c..40bb8d88 100644
--- a/src/_action.ts
+++ b/src/_action.ts
@@ -21,11 +21,16 @@ export class Action {
return { command };
}
- public static fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme } = { }): ... | feat(probe): add `host` property to HttpGet probes (#3818)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-28/main`:
- [feat(probe): add `host` property to HttpGet probes (#3818)](https://github.com/cdk8s-team/cdk8s-plus/pull/3818)
<!--- Backport version: 8.5.0 -->
### Questions ?
Ple... | **Title**
Add host support to HTTP GET probes
**Problem**
HTTP readiness and liveness probes could only target the pod IP, making it impossible to direct probes to a specific hostname. Users needed a way to specify a custom host for HTTP GET probes.
**Root Cause**
The probe abstraction and its underlying HT... | 4,043 | cdk8s-team/cdk8s-plus | diff --git a/test/probe.test.ts b/test/probe.test.ts
index 17946ea5..8040b027 100644
--- a/test/probe.test.ts
+++ b/test/probe.test.ts
@@ -57,6 +57,7 @@ describe('fromHttpGet()', () => {
periodSeconds: Duration.seconds(5),
successThreshold: 3,
timeoutSeconds: Duration.minutes(2),
+ host: '1.1.... | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname"
] | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"can grant permissions on imported",
"defaultChild",
"Can be imported from secret name",
"Can create a new secret",
"Can add data to new secrets",
"Can create a basic auth secret",
"can override the name of a basic auth secret",
"Can create an ssh a... | Method: Action.fromHttpGet(container: Container, path: string, options: { port?: number; scheme?: ConnectionScheme; host?: string } = {})
Location: src/_action.ts
Inputs:
- container – the `Container` whose port may be used as the default when `options.port` is omitted.
- path – HTTP request path for the probe.... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 2,
"num_modified_lines": 14,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": ... | |
45650d32e941655c00affa4ddf44ec0aaff79545 | 2024-04-18 07:21:56 | cdk8s-team__cdk8s-plus-4045 | diff --git a/src/container.ts b/src/container.ts
index 28048a6e..e5940b92 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -491,6 +491,27 @@ export interface ContainerLifecycle {
}
+/**
+ * RestartPolicy defines the restart behavior of individual containers in a pod.
+ * This field may only be set for init ... | feat(container): support `restartPolicy` field (#3812)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-28/main`:
- [feat(container): support `restartPolicy` field (#3812)](https://github.com/cdk8s-team/cdk8s-plus/pull/3812)
<!--- Backport version: 8.5.0 -->
### Questions ?
Please refe... | **Title**
Add support for `restartPolicy` on init containers
**Problem**
Users cannot declare a restart policy for init containers, limiting the ability to run side‑car‑style init containers that stay alive for the pod’s lifetime. The API also does not enforce that this field is only applicable to init container... | 4,045 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index 5271e331..c94d5044 100644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -1,5 +1,79 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
+exports[`Container "restartPo... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"default security context",
"custom security... | [
"can grant permissions on imported",
"defaults",
"custom",
"can be imported",
"can be bounded to a volume at instantiation",
"can be bounded to a volume post instantiation",
"no-ops if bounded twice to the same volume",
"throws if bounded twice to different volumes",
"default child",
"a label sele... | Enum: ContainerRestartPolicy
Location: src/container.ts
Inputs: – (enum members)
Outputs: string values representing Kubernetes restart policy for init containers. Currently only `ALWAYS = 'Always'`.
Description: Enum used to specify the `restartPolicy` field on init containers. The only supported value is `ALWAYS`, wh... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 2,
"num_modified_lines": 41,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2":... | |
6bbed4a739b5aa35f6a396a57e2a2e36893cd56b | 2024-04-18 07:26:13 | cdk8s-team__cdk8s-plus-4046 | diff --git a/src/role.ts b/src/role.ts
index bdf4eb93..0da4b118 100644
--- a/src/role.ts
+++ b/src/role.ts
@@ -104,6 +104,10 @@ export class Role extends base.Resource implements IRole {
metadata: props.metadata,
rules: Lazy.any({ produce: () => this.synthesizeRules() }),
});
+
+ for (const rule o... | fix(role): use rules coming from the roleProps (#3813)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-27/main`:
- [fix(role): use rules coming from the roleProps (#3813)](https://github.com/cdk8s-team/cdk8s-plus/pull/3813)
<!--- Backport version: 8.5.0 -->
### Questions ?
Please refe... | **Title**
Fix Role to honor rules supplied via `roleProps`
**Problem**
When a Role is instantiated with an explicit `rules` array, those rules are not reflected in the resulting Kubernetes Role manifest. This omission can lead to missing permissions for workloads that rely on the declared rules.
**Root Cause**
... | 4,046 | cdk8s-team/cdk8s-plus | diff --git a/test/role.test.ts b/test/role.test.ts
index d63180de..e2314754 100644
--- a/test/role.test.ts
+++ b/test/role.test.ts
@@ -154,6 +154,32 @@ Array [
});
+ test('specify access from props', () => {
+
+ // GIVEN
+ const chart = Testing.chart();
+
+ // WHEN
+ new kplus.Role(chart, 'my-role',... | [
"specify access from props"
] | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"defaultChild",
"defaults",
"can select namespaces",
"can select all namespaces",
"default child",
"custom",
"a label selector is automatically allocated",
"no selector is generated i... | Method: Role.constructor(scope: Construct, id: string, props?: RoleProps)
Location: src/role.ts
Inputs:
- scope – the construct tree parent (e.g., a Chart) where the Role will be added.
- id – logical identifier for the Role within the scope.
- props (optional) – RoleProps where the new optional field `rules?: Array<{ ... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 5,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": ... | |
a428ad09333243488c0bc1e88b034433bfd404ab | 2024-04-18 07:26:16 | cdk8s-team__cdk8s-plus-4047 | diff --git a/src/role.ts b/src/role.ts
index bdf4eb93..0da4b118 100644
--- a/src/role.ts
+++ b/src/role.ts
@@ -104,6 +104,10 @@ export class Role extends base.Resource implements IRole {
metadata: props.metadata,
rules: Lazy.any({ produce: () => this.synthesizeRules() }),
});
+
+ for (const rule o... | fix(role): use rules coming from the roleProps (#3813)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-28/main`:
- [fix(role): use rules coming from the roleProps (#3813)](https://github.com/cdk8s-team/cdk8s-plus/pull/3813)
<!--- Backport version: 8.5.0 -->
### Questions ?
Please refe... | **Title**
Respect `rules` supplied through `Role` properties
**Problem**
When creating a Role, any rule definitions passed via its props were silently ignored, resulting in incomplete RBAC specifications. This caused roles to lack the intended permissions despite being declared.
**Root Cause**
The constructor o... | 4,047 | cdk8s-team/cdk8s-plus | diff --git a/test/role.test.ts b/test/role.test.ts
index d63180de..e2314754 100644
--- a/test/role.test.ts
+++ b/test/role.test.ts
@@ -154,6 +154,32 @@ Array [
});
+ test('specify access from props', () => {
+
+ // GIVEN
+ const chart = Testing.chart();
+
+ // WHEN
+ new kplus.Role(chart, 'my-role',... | [
"specify access from props"
] | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"defaultChild",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not modify existing restart policy of pod spec",
"Synthesizes spec lazily",
"Can be isolated",
"can grant permissions on imported",
"defaults",
"cust... | Method: Role.__init__(self, chart: Chart, id: str, props: RoleProps = None)
Location: src/role.ts
Inputs: chart – the CDK8s chart the role belongs to; id – logical identifier for the role; props (optional) – may contain a **rules** field, which is a list of objects each specifying `verbs: str[]` and `resources: ApiRe... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 5,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": ... | |
a4f6d8e8faadf14d0b453761a1944464456854d7 | 2024-04-18 07:32:24 | cdk8s-team__cdk8s-plus-4048 | diff --git a/src/container.ts b/src/container.ts
index e5940b92..2fcca1e5 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -7,6 +7,188 @@ import * as secret from './secret';
import { undefinedIfEmpty } from './utils';
import * as volume from './volume';
+/**
+ * Capability - complete list of POSIX capabiliti... | feat(container): add capabilities to security context (#3817)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-28/main`:
- [feat(container): add capabilities to security context (#3817)](https://github.com/cdk8s-team/cdk8s-plus/pull/3817)
<!--- Backport version: 8.5.0 -->
### Questions... | **Title**
Add POSIX capability configuration to container security context
**Problem**
Users cannot currently specify Linux capabilities to add or drop when defining a container’s security context, limiting fine‑grained privilege control.
**Root Cause**
The security context model does not expose any field f... | 4,048 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index 4d570d58..bf349bc1 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -1,7 +1,7 @@
import * as cdk8s from 'cdk8s';
import { Size, Testing } from 'cdk8s';
import * as kplus from '../src';
-import { Container, Cpu, Handler, ConnectionS... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"can configure a postStart lifecycle hook",
... | [
"defaultChild",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not modify existing restart policy of pod spec",
"Synthesizes spec lazily",
"Can be isolated",
"defaults",
"can select namespaces",
"can select all namespaces",
"can grant permissions on imported",
... | Enum: Capability
Location: src/container.ts – exported enum `Capability`
Inputs: *(none)*
Outputs: string values representing POSIX capabilities (e.g., `CAP_AUDIT_CONTROL`, `CAP_BPF`, …)
Description: Enumerates all supported POSIX capabilities that can be added to or dropped from a container’s security context.
Interf... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 196,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2":... | |
68ea68125ca4d9b880b884d3faed186d6808688f | 2024-04-18 16:56:53 | cdk8s-team__cdk8s-plus-4055 | diff --git a/src/container.ts b/src/container.ts
index 28048a6e..79cc6dd4 100644
--- a/src/container.ts
+++ b/src/container.ts
@@ -7,6 +7,188 @@ import * as secret from './secret';
import { undefinedIfEmpty } from './utils';
import * as volume from './volume';
+/**
+ * Capability - complete list of POSIX capabiliti... | feat(container): add capabilities to security context (#3817)
# Backport
This will backport the following commits from `k8s-29/main` to `k8s-27/main`:
- [feat(container): add capabilities to security context (#3817)](https://github.com/cdk8s-team/cdk8s-plus/pull/3817)
<!--- Backport version: 8.5.0 -->
### Questions... | **Title**
Expose POSIX capabilities in container security context
**Problem**
Users cannot currently specify which Linux capabilities a container should add or drop, limiting fine‑grained security configuration. The CDK8s Plus API therefore cannot express a common Kubernetes security feature.
**Root Cause** ... | 4,055 | cdk8s-team/cdk8s-plus | diff --git a/test/container.test.ts b/test/container.test.ts
index eccb9ba7..13239370 100644
--- a/test/container.test.ts
+++ b/test/container.test.ts
@@ -1,7 +1,7 @@
import * as cdk8s from 'cdk8s';
import { Size, Testing } from 'cdk8s';
import * as kplus from '../src';
-import { Container, Cpu, Handler, ConnectionS... | [
"Can add only resource requests",
"Can add only resource limits",
"Can add only limits and requests on memory",
"Can add only limits and requests on cpu",
"Can add only limits and requests on emphemeral-storage",
"Can add only limits on emphemeral-storage",
"can configure a postStart lifecycle hook",
... | [
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"defaultChild",
"A label selector is automatically allocated",
"No selector is generated if \"select\" is false",
"Can select by label",
"StatefulSet gets defaults",
"StatefulSet allows overrides",
"Synthesizes spec lazily",
"default update strategy... | Enum: Capability
Location: src/container.ts
Inputs: None (enum values are constants)
Outputs: String values representing Linux POSIX capabilities, e.g., `CAP_AUDIT_CONTROL`, `CAP_BPF`, etc.
Description: Enumeration of all supported POSIX capabilities that can be added to or dropped from a container's security context.
... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 196,
"pr_author": "iliapolo",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
... | |
9e268a1b70d50d7f264041a62ec838bb649f5599 | 2025-02-25 06:53:45 | cdk8s-team__cdk8s-plus-5353 | diff --git a/src/pod.ts b/src/pod.ts
index 3ac602bc..14e4dfd2 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -19,6 +19,7 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public readonly dns: PodDns;
public readonly dockerRegistryAuth?: secret.ISecret;
public readonly automountSe... | feat(pod): shareProcessNamespace (backport #4902)
# Backport
This will backport the following commits from `k8s-31/main` to `k8s-29/main`:
- [feat(pod): shareProcessNamespace (#4902)](https://github.com/cdk8s-team/cdk8s-plus/pull/4902)
<!--- Backport version: 9.5.1 -->
### Questions ?
Please refer to the [Backport ... | **Title**
Add optional process‑namespace sharing to Pod constructs
**Problem**
The library does not expose Kubernetes’ `shareProcessNamespace` flag, preventing users from configuring pods so that containers share a single process namespace.
**Root Cause**
The Pod abstraction lacked a corresponding property ... | 5,353 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index c94d5044..ee03dfa1 100644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -68,6 +68,7 @@ Array [
"runAsNonRoot": true,
},
"setHostnameAsFQDN"... | [
"Can be isolated",
"default configuration",
"custom configuration",
"Can be exposed as via ingress",
"exposing via a service preserves deployment namespace",
"expose captures all container ports",
"can tolerate tainted nodes",
"can be assigned to a node by name",
"can be attracted to a node by selec... | [
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"Can mutate metadata",
"can create a RoleBinding from a Role",
"can create a RoleBinding from a ClusterRole",
"can call bindInNamespace multiple times",
"can create a ClusterRoleBinding fro... | Method: AbstractPod.shareProcessNamespace(self)
Location: src/pod.ts – added as a public readonly field on the AbstractPod class and exposed through the class instance.
Inputs: None (value is initialized from the constructor).
Outputs: <boolean> – the value of the `shareProcessNamespace` flag that was supplied in th... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 11,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": fal... | |
2f8b1d2d492366e416677b2dca6ffad53efd8e6a | 2025-02-25 06:53:49 | cdk8s-team__cdk8s-plus-5354 | diff --git a/src/pod.ts b/src/pod.ts
index 3ac602bc..14e4dfd2 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -19,6 +19,7 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public readonly dns: PodDns;
public readonly dockerRegistryAuth?: secret.ISecret;
public readonly automountSe... | feat(pod): shareProcessNamespace (backport #4902)
# Backport
This will backport the following commits from `k8s-31/main` to `k8s-30/main`:
- [feat(pod): shareProcessNamespace (#4902)](https://github.com/cdk8s-team/cdk8s-plus/pull/4902)
<!--- Backport version: 9.5.1 -->
### Questions ?
Please refer to the [Backport ... | **Title**
Add support for `shareProcessNamespace` option on Pods
**Problem**
Users cannot enable process‑namespace sharing for containers within the same pod, limiting scenarios that require cross‑container process visibility (e.g., debugging or side‑car coordination). The existing pod API lacks a property to co... | 5,354 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index c94d5044..ee03dfa1 100644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -68,6 +68,7 @@ Array [
"runAsNonRoot": true,
},
"setHostnameAsFQDN"... | [
"Can be isolated",
"default configuration",
"custom configuration",
"StatefulSet gets defaults",
"Can be exposed as via ingress",
"exposing via a service preserves deployment namespace",
"expose captures all container ports",
"can tolerate tainted nodes",
"can be assigned to a node by name",
"can ... | [
"Can mutate metadata",
"default child",
"defaults",
"custom",
"a label selector is automatically allocated",
"no selector is generated if \"select\" is false",
"can select by label",
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
... | Method: AbstractPod.constructor(this: AbstractPod, props: AbstractPodProps)
Location: src/pod.ts
Inputs: `props` – an object extending `base.ResourceProps` that may contain the optional boolean `shareProcessNamespace` (default `false`). All other existing fields are unchanged.
Outputs: Returns a new `AbstractPod`... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 11,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": fa... | |
6fbf94183964f0eabef493e1a7ae3e51b4d2482e | 2024-11-13 21:56:17 | cdk8s-team__cdk8s-plus-4902 | diff --git a/src/pod.ts b/src/pod.ts
index 3ac602bc..14e4dfd2 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -19,6 +19,7 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public readonly dns: PodDns;
public readonly dockerRegistryAuth?: secret.ISecret;
public readonly automountSe... | feat(pod): shareProcessNamespace
add shareProcessNamespace to pod spec. Cannot find it anywhere.
https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/ | **Title**
Expose `shareProcessNamespace` option on Pod resources
**Problem**
Users need the ability to enable process‑namespace sharing for containers within a pod, but the current pod construct does not expose this setting. Consequently, manifests cannot be configured to share the process namespace, limiting ce... | 4,902 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/container.test.ts.snap b/test/__snapshots__/container.test.ts.snap
index c94d5044..ee03dfa1 100644
--- a/test/__snapshots__/container.test.ts.snap
+++ b/test/__snapshots__/container.test.ts.snap
@@ -68,6 +68,7 @@ Array [
"runAsNonRoot": true,
},
"setHostnameAsFQDN"... | [
"default configuration",
"custom configuration",
"Can be isolated",
"StatefulSet gets defaults",
"can create a policy for a managed pod",
"can create a policy for a managed workload resource",
"can add ingress from an ip block",
"can add ingress from a managed pod",
"can add ingress from a managed w... | [
"defaultChild",
"Can mutate metadata",
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"defaults",
"can select namespaces",
"can select all namespaces",
"can grant permissions on imported",
"custom",
"can be imported",
"can be bounded to a volume at instantiation",
"can be bounded to a volume... | Class: AbstractPod(props: AbstractPodProps)
Location: src/pod.ts
Inputs: `props` – an object conforming to `AbstractPodProps`; the new optional field `shareProcessNamespace?: boolean` (default false).
Outputs: Instance property `shareProcessNamespace: boolean` (readonly) reflecting the value passed in `props`.
... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 11,
"pr_author": "chensjlv",
"pr_labels": [
"backport-to-k8s-29/main: Backport a PR to the k8s-30 branch",
"backport-to-k8s-30/main: Backport a PR to the k8s-30 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": ... | |
510051b4969b3bae1c07befccebc9753cff5fcf0 | 2025-05-03 06:32:08 | cdk8s-team__cdk8s-plus-5681 | diff --git a/src/pvc.ts b/src/pvc.ts
index 25c133ae..5c23eec2 100644
--- a/src/pvc.ts
+++ b/src/pvc.ts
@@ -1,4 +1,4 @@
-import { Size, ApiObject, Lazy } from 'cdk8s';
+import { Size, SizeRoundingBehavior, ApiObject, Lazy } from 'cdk8s';
import { Construct } from 'constructs';
import * as base from './base';
import *... | fix(pvc): fractional gibibytes storage sizes are not allowed
Fixes https://github.com/cdk8s-team/cdk8s/issues/2511 | **Title**
Prevent unintended rounding of fractional gibibyte storage sizes in PVCs
**Problem**
When a PersistentVolumeClaim specifies a storage size that is not a whole gibibyte, the conversion to a Kubernetes quantity automatically rounded the value. This produced incorrect PVC specifications and broke expectat... | 5,681 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/pvc.test.ts.snap b/test/__snapshots__/pvc.test.ts.snap
index 90a908d2..fe7599ca 100644
--- a/test/__snapshots__/pvc.test.ts.snap
+++ b/test/__snapshots__/pvc.test.ts.snap
@@ -100,3 +100,23 @@ Array [
},
]
`;
+
+exports[`small size 1`] = `
+Array [
+ Object {
+ "apiVersion": "v1"... | [
"small size"
] | [
"defaultChild",
"default configuration",
"custom configuration",
"Can be isolated",
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"defaults",
"can select namespaces",
"can select all namespaces",
"can grant permissions on importe... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "ajacques",
"pr_labels": [
"backport-to-k8s-30/main: Backport a PR to the k8s-30 branch",
"backport-to-k8s-31/main: Backport a PR to the k8s-31 branch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0... | |
54125191b08276e5165d67674b395ad6c9cc76c6 | 2025-05-07 15:40:53 | cdk8s-team__cdk8s-plus-5707 | diff --git a/src/pvc.ts b/src/pvc.ts
index 25c133ae..5c23eec2 100644
--- a/src/pvc.ts
+++ b/src/pvc.ts
@@ -1,4 +1,4 @@
-import { Size, ApiObject, Lazy } from 'cdk8s';
+import { Size, SizeRoundingBehavior, ApiObject, Lazy } from 'cdk8s';
import { Construct } from 'constructs';
import * as base from './base';
import *... | fix(pvc): fractional gibibytes storage sizes are not allowed (backport #5681)
# Backport
This will backport the following commits from `k8s-32/main` to `k8s-30/main`:
- [fix(pvc): fractional gibibytes storage sizes are not allowed (#5681)](https://github.com/cdk8s-team/cdk8s-plus/pull/5681)
<!--- Backport version: 9... | **Title**
Prevent fractional gibibyte storage sizes in PersistentVolumeClaim specifications
**Problem**
Kubernetes PersistentVolumeClaims accept storage sizes only as whole gibibytes. The library previously allowed fractional Gi values, which results in invalid manifests being generated.
**Root Cause**
The size... | 5,707 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/pvc.test.ts.snap b/test/__snapshots__/pvc.test.ts.snap
index 90a908d2..fe7599ca 100644
--- a/test/__snapshots__/pvc.test.ts.snap
+++ b/test/__snapshots__/pvc.test.ts.snap
@@ -100,3 +100,23 @@ Array [
},
]
`;
+
+exports[`small size 1`] = `
+Array [
+ Object {
+ "apiVersion": "v1"... | [
"small size"
] | [
"default child",
"defaults",
"custom",
"a label selector is automatically allocated",
"no selector is generated if \"select\" is false",
"can select by label",
"Can be isolated",
"defaultChild",
"can select namespaces",
"can select all namespaces",
"can grant permissions on imported",
"role ca... | Method: Size.toGibibytes(options?: { rounding: SizeRoundingBehavior })
Location: `cdk8s.Size` class (imported from the `cdk8s` library).
Inputs: Optional `options` object; currently supports a single key `rounding` whose value must be one of the `SizeRoundingBehavior` enum members (e.g., `SizeRoundingBehavior.NONE`... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": fals... | |
c9ce02a18e16c1a98f43abc6a51b9ec9710949d7 | 2025-05-07 15:40:57 | cdk8s-team__cdk8s-plus-5708 | diff --git a/src/pvc.ts b/src/pvc.ts
index 25c133ae..5c23eec2 100644
--- a/src/pvc.ts
+++ b/src/pvc.ts
@@ -1,4 +1,4 @@
-import { Size, ApiObject, Lazy } from 'cdk8s';
+import { Size, SizeRoundingBehavior, ApiObject, Lazy } from 'cdk8s';
import { Construct } from 'constructs';
import * as base from './base';
import *... | fix(pvc): fractional gibibytes storage sizes are not allowed (backport #5681)
# Backport
This will backport the following commits from `k8s-32/main` to `k8s-31/main`:
- [fix(pvc): fractional gibibytes storage sizes are not allowed (#5681)](https://github.com/cdk8s-team/cdk8s-plus/pull/5681)
<!--- Backport version: 9... | **Title**
Prevent unintended rounding of PVC storage sizes expressed in gibibytes
**Problem**
When a PersistentVolumeClaim specifies a size, the library automatically rounded the value to the nearest whole gibibyte. Kubernetes rejects PVC specifications that contain fractional gibibyte values, leading to silent ... | 5,708 | cdk8s-team/cdk8s-plus | diff --git a/test/__snapshots__/pvc.test.ts.snap b/test/__snapshots__/pvc.test.ts.snap
index 90a908d2..fe7599ca 100644
--- a/test/__snapshots__/pvc.test.ts.snap
+++ b/test/__snapshots__/pvc.test.ts.snap
@@ -100,3 +100,23 @@ Array [
},
]
`;
+
+exports[`small size 1`] = `
+Array [
+ Object {
+ "apiVersion": "v1"... | [
"small size"
] | [
"default child",
"defaults",
"custom",
"a label selector is automatically allocated",
"no selector is generated if \"select\" is false",
"can select by label",
"Can be isolated",
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"defaults to the container port",
"specific port",
"options",
"m... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": fals... | |
03a72863b245715c86bea135801b5aad576c4acc | 2025-05-08 08:13:44 | cdk8s-team__cdk8s-plus-5711 | diff --git a/src/pod.ts b/src/pod.ts
index 14e4dfd2..d8d93ec2 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -22,6 +22,7 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public readonly shareProcessNamespace: boolean;
public readonly hostNetwork?: boolean;
public readonly termin... | feat(pod): support `enableServiceLinks` (backport #5471)
# Backport
This will backport the following commits from `k8s-32/main` to `k8s-30/main`:
- [feat(pod): support `enableServiceLinks` (#5471)](https://github.com/cdk8s-team/cdk8s-plus/pull/5471)
<!--- Backport version: 9.5.1 -->
### Questions ?
Please... | **Title**
Add support for the `enableServiceLinks` flag on Pods
**Problem**
The construct library does not expose the Kubernetes `enableServiceLinks` setting, preventing users from disabling automatic injection of service‑related environment variables into a pod.
**Root Cause**
The pod abstraction omits the... | 5,711 | cdk8s-team/cdk8s-plus | diff --git a/test/pod.test.ts b/test/pod.test.ts
index 17f44567..99ea4830 100644
--- a/test/pod.test.ts
+++ b/test/pod.test.ts
@@ -1605,3 +1605,14 @@ test('Containers should not specify "restartPolicy" field', () => {
expect(() => Testing.synth(chart)).toThrowError();
});
+test('enableServiceLinks can be disabled... | [
"fails with two volumes with the same name",
"fails adding a volume with the same name",
"fails with a container that has mounts with different volumes of the same name",
"can configure multiple mounts with the same volume",
"Can add container post instantiation",
"Can attach an existing container post in... | [
"Can mutate metadata",
"defaultChild",
"default configuration",
"custom configuration",
"Can be isolated",
"defaults to the container port",
"specific port",
"options",
"minimal usage",
"specific port and hostname",
"Allows setting all options",
"Applies default restart policy to pod spec",
... | Method: Pod.constructor(scope: Construct, id: string, props: PodProps)
Location: src/pod.ts
Inputs:
- **scope** – the construct tree scope in which to define this pod.
- **id** – logical identifier for the pod construct.
- **props** – `PodProps` object; now includes an optional `enableServiceLinks?: boolean` flag.... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 12,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "B3",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": fa... | |
f6104a55d40167088381d2ae543547e865051d4a | 2025-05-08 08:13:47 | cdk8s-team__cdk8s-plus-5712 | diff --git a/src/pod.ts b/src/pod.ts
index 14e4dfd2..d8d93ec2 100644
--- a/src/pod.ts
+++ b/src/pod.ts
@@ -22,6 +22,7 @@ export abstract class AbstractPod extends base.Resource implements IPodSelector,
public readonly shareProcessNamespace: boolean;
public readonly hostNetwork?: boolean;
public readonly termin... | feat(pod): support `enableServiceLinks` (backport #5471)
# Backport
This will backport the following commits from `k8s-32/main` to `k8s-31/main`:
- [feat(pod): support `enableServiceLinks` (#5471)](https://github.com/cdk8s-team/cdk8s-plus/pull/5471)
<!--- Backport version: 9.5.1 -->
### Questions ?
Please... | **Title**
Add support for configuring `enableServiceLinks` on Pods
**Problem**
Users cannot control whether Kubernetes injects service environment variables into Pods, limiting compatibility with workloads that rely on the default service link behavior.
**Root Cause**
The Pod construct did not expose the `e... | 5,712 | cdk8s-team/cdk8s-plus | diff --git a/test/pod.test.ts b/test/pod.test.ts
index 17f44567..99ea4830 100644
--- a/test/pod.test.ts
+++ b/test/pod.test.ts
@@ -1605,3 +1605,14 @@ test('Containers should not specify "restartPolicy" field', () => {
expect(() => Testing.synth(chart)).toThrowError();
});
+test('enableServiceLinks can be disabled... | [
"fails with two volumes with the same name",
"fails adding a volume with the same name",
"fails with a container that has mounts with different volumes of the same name",
"can configure multiple mounts with the same volume",
"Can add container post instantiation",
"Can attach an existing container post in... | [
"Can mutate metadata",
"defaultChild",
"Allows setting all options",
"Applies default restart policy to pod spec",
"Does not modify existing restart policy of pod spec",
"Synthesizes spec lazily",
"Can be isolated",
"fromCommand",
"fromHttpGet",
"fromTcpSocket",
"can grant permissions on importe... | Method: Pod.constructor(scope: Construct, id: string, props: PodProps)
Location: src/pod.ts
Inputs:
- **scope**: Construct – the construct tree parent.
- **id**: string – logical ID of the pod.
- **props**: PodProps – pod configuration object, now includes an optional `enableServiceLinks?: boolean` (default `true`). W... | Apache-2.0 | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors --testLocationInResults"
} | {
"num_modified_files": 1,
"num_modified_lines": 12,
"pr_author": "cdk8s-automation",
"pr_labels": [
"auto-approve: Pull requests that should be auto approved",
"backport"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": fal... | |
f531d7df16ec08fce902faed92b5017a11c2f771 | 2023-10-26 08:36:31 | github-actions[bot]: <!-- Labeler (https://github.com/jimschubert/labeler) -->
👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.
Please review the labels and make any necessary changes.
| baidu__amis-8510 | diff --git a/docs/zh-CN/start/getting-started.md b/docs/zh-CN/start/getting-started.md
index ff6b2ad74..9fac584e3 100644
--- a/docs/zh-CN/start/getting-started.md
+++ b/docs/zh-CN/start/getting-started.md
@@ -759,8 +759,7 @@ let amisScoped = amis.embed(
{
replaceText: {
service: 'http://localhost'
- }... | feat: env.replaceTextIgnoreKeys 支持函数 Close: #7035
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 55473df</samp>
This pull request improves the `replaceText` feature and its documentation. It allows users to filter keys and values with a custom function, and updates the docs and types accordi... | **Title**
Enhance replaceText ignore‑keys flexibility, refine formula lexer filtering, and unify Tree tooltip handling
**Problem**
`replaceText` could only skip keys via a static string list, limiting dynamic scenarios. The documentation did not reflect newer usage. Additionally, the formula lexer could not reli... | 8,510 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index fb30171c4..32d23b1e5 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -580,3 +580,9 @@ test('evalute:namespace', () => {
expect(eva... | [
"evalute:speical characters"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | Method: lexer(input: string, options: LexerOptions = {})
Location: packages/amis-formula/src/lexer.ts
Inputs:
- **input**: the formula string to be tokenised.
- **options** (optional): an object of type `LexerOptions` that may contain
* `evalMode?: boolean` – treat the input as an expression.
* `variableMode... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 8,
"num_modified_lines": 98,
"pr_author": "2betop",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": true... |
1bb988b942739d3f674260f578a69be4dfe659b9 | 2023-10-26 11:26:59 | baidu__amis-8515 | diff --git a/docs/zh-CN/components/crud.md b/docs/zh-CN/components/crud.md
index d6b2561da..b6ab5a436 100755
--- a/docs/zh-CN/components/crud.md
+++ b/docs/zh-CN/components/crud.md
@@ -200,11 +200,11 @@ CRUD 组件对数据源接口的数据结构要求如下：
| orderDir | 'asc'/'desc' | 排序方式 |
| keywords | string | 搜索关键字 ... | fix: 处理input-number单位选项交互;input-table展示列配置项位置处理 & progress组件配置面板去除模版配置项 feat：组件状态支持"可见"配置项
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 3514f38</samp>
This pull request updates and improves the schema templates for editing various `amis` components in the `amis-editor`. It adds the `visibl... | **Title**
Add lazy‑load support for nested tables/CRUD and related UX, schema, and utility updates
**Problem**
Nested tables in the CRUD component could not load child rows on demand, leaving users unable to view deep data without pre‑loading everything. The editor also lacked a consistent “visible” control and ... | 8,515 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index fb30171c4..32d23b1e5 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -580,3 +580,9 @@ test('evalute:namespace', () => {
expect(eva... | [
"evalute:speical characters"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | Function: lexer(input: string, options?: LexerOptions)
Location: packages/amis-formula/src/lexer.ts
Inputs:
- input string – the raw formula source.
- options LexerOptions (optional) – may include `evalMode`, `variableMode`, `allowFilter`, and new fields `filters` (object of filter functions) and `isFilter` (function ... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 38,
"num_modified_lines": 1138,
"pr_author": "yinchunyu",
"pr_labels": [
"feat",
"fix"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
... | |
1bb988b942739d3f674260f578a69be4dfe659b9 | 2023-10-26 13:06:19 | baidu__amis-8517 | diff --git a/docs/zh-CN/components/crud.md b/docs/zh-CN/components/crud.md
index d6b2561da..b6ab5a436 100755
--- a/docs/zh-CN/components/crud.md
+++ b/docs/zh-CN/components/crud.md
@@ -200,11 +200,11 @@ CRUD 组件对数据源接口的数据结构要求如下：
| orderDir | 'asc'/'desc' | 排序方式 |
| keywords | string | 搜索关键字 ... | feat: CRUD & Table 嵌套支持懒加载 Close: #8411
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 8d09692</samp>
This pull request adds a new feature to the `Table` and `CRUD` components that allows loading nested data lazily using the `deferApi` property. It also improves the appearance and usability ... | **Title**
Add lazy‑load support for nested data in Table/CRUD and related UI improvements
**Problem**
Large hierarchical datasets cause performance issues because Table and CRUD always load all child rows eagerly. There was also no visual feedback or retry mechanism when loading such data fails, and the text‑rep... | 8,517 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index fb30171c4..32d23b1e5 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -580,3 +580,9 @@ test('evalute:namespace', () => {
expect(eva... | [
"evalute:speical characters"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | Function: lexer(input: string, options: LexerOptions = {})
Location: packages/amis-formula/src/lexer.ts
Inputs:
- **input** `string` – the raw formula expression to be tokenised.
- **options** `LexerOptions` (optional, default `{}`) – configuration object that may contain:
- `evalMode` `boolean` – treat the input ... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 30,
"num_modified_lines": 1055,
"pr_author": "2betop",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": fa... | |
8af076ce0ef89d5993c9f80ad2b54387c83392ec | 2023-11-06 06:13:18 | github-actions[bot]: <!-- Labeler (https://github.com/jimschubert/labeler) -->
👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.
Please review the labels and make any necessary changes.
lurunze1226: 补充：
- `showTableAddBtn`
- `showFooterAddBtn`
- `toolbarClassName` | baidu__amis-8629 | diff --git a/docs/zh-CN/components/form/transfer.md b/docs/zh-CN/components/form/transfer.md
index c2c05e5f3..dfaa00e19 100644
--- a/docs/zh-CN/components/form/transfer.md
+++ b/docs/zh-CN/components/form/transfer.md
@@ -878,12 +878,95 @@ icon:
}
```
+## 分页
+
+> `3.6.0`及以上版本
+
+当数据量庞大时，可以开启数据源分页，此时左侧列表底部会出现分页控件，相关配... | feat(amis-editor): InputTable配置面板补充属性
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 1b22ca7</samp>
Added new options to the `table` control plugin schema in `Form/InputTable.tsx` to allow users to control the table layout and actions.
<!--
copilot:poem
-->
### <samp>🤖 Generated by Copil... | **Title**
Add pagination to Transfer, new Image actions/events, improve validation, UI tweaks and docs
**Problem**
- Transfer component had no pagination support, making large option sets unusable.
- Image component lacked event emission and actions for preview/zoom, and scaling limits were missing.
- Form val... | 8,629 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 32d23b1e5..151d84a7a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -563,6 +563,18 @@ test('evalute:Math', () => {
expect(evaluat... | [
"evalute:UUID"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"evalute:simple",
"evalute:filter",
"evalute:filter2",
"evalute:filter3",
"evalute:filter4",
"evalute:keywords",
"evalute:oldVariable",
"evalute:ariable2",
"evalute:ariable3",
"evalute:object-variable",
"evalute:literal-variable",
"evalu... | Method: UUID(length?: number) → string
Location: packages/amis-formula/src/evalutor.ts (Evaluator class)
Inputs:
- length (optional, number) – Desired length of the generated UUID string. If omitted, defaults to 36 characters.
Outputs:
- Returns a UUID‑like string (hex characters with hyphens) truncated or padded to ... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 65,
"num_modified_lines": 2247,
"pr_author": "lurunze1226",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5... |
f9ef0497960713963a42f9f52b63d18fcf1bf9f8 | 2023-11-07 03:35:48 | github-actions[bot]: <!-- Labeler (https://github.com/jimschubert/labeler) -->
👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.
Please review the labels and make any necessary changes.
| baidu__amis-8641 | diff --git a/packages/amis-core/src/store/crud.ts b/packages/amis-core/src/store/crud.ts
index 3eb535c6d..d213b5f28 100644
--- a/packages/amis-core/src/store/crud.ts
+++ b/packages/amis-core/src/store/crud.ts
@@ -161,10 +161,10 @@ export const CRUDStore = ServiceStore.named('CRUDStore')
rule => rule.incl... | fix(amis-editor): Calendar文档链接拼写错误
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 3d11208</samp>
Fixed a typo in the `docLink` property of the `CalendarPlugin` class in `Calendar.tsx`. This ensures that the plugin's documentation link works as expected.
<!--
copilot:poem
-->
### <samp>🤖 ... | **Title**
Multiple stability and usability fixes across editor plugins, core stores and UI components
**Problem**
- Several components and utilities exhibited incorrect behavior: typo in a documentation link, faulty equality checks in the CRUD store, missing support for dynamic sub‑editor variables, inadequate v... | 8,641 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 32d23b1e5..25a7e875f 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -563,6 +563,11 @@ test('evalute:Math', () => {
expect(evaluat... | [
"evalute:UUID"
] | [
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"parser:multi-expression",
"parser:functionCall",
"parser... | Method: Evaluator.fnUUID(self, length: number = 32) Location: packages/amis-formula/src/evalutor.ts
Inputs: Optional numeric `length` (clamped to the range 0‑32, default 32) indicating the desired length of the returned UUID string.
Outputs: `string` – a randomly generated UUID string trimmed to the requested length (h... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 14,
"num_modified_lines": 161,
"pr_author": "chengjinyang0",
"pr_labels": [
"fix"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B... |
e7f23c9859cec2bad56dbd11a4b12615798141c8 | 2023-11-08 08:52:54 | baidu__amis-8662 | diff --git a/packages/amis-formula/src/doc.md b/packages/amis-formula/src/doc.md
index 37b95f335..ea51e564c 100644
--- a/packages/amis-formula/src/doc.md
+++ b/packages/amis-formula/src/doc.md
@@ -591,6 +591,16 @@
返回：a.json`。
+### UUID
+
+用法：`UUID(8)`
+
+ * `length:number` 生成的UUID字符串长度，默认为32位
+
+返回：`string` 生成的UUI... | feat: 公式支持uuid生成
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 12a83f0</samp>
This pull request introduces a new `UUID` function to the `amis-formula` package. The function generates a UUID string of a given length and can be used in formulas. The pull request also updates the documentation... | **Title**
Add built‑in UUID generation to the formula language
**Problem**
Formulas currently have no way to create unique identifier strings, limiting scenarios that require random keys or tokens. Users must resort to external logic to obtain UUIDs.
**Root Cause**
The evaluator did not expose any text‑base... | 8,662 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 32d23b1e5..25a7e875f 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -563,6 +563,11 @@ test('evalute:Math', () => {
expect(evaluat... | [
"evalute:UUID"
] | [
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"parser:multi-expression",
"parser:functionCall",
"parser... | Method: Evaluator.fnUUID(length: number = 32)
Location: packages/amis-formula/src/evalutor.ts
Inputs: optional numeric **length** – desired length of the generated UUID string, clamped to the range 0‑32 (default 32).
Outputs: **string** – a UUID‑style hexadecimal string trimmed to the requested length. Errors: none; ... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 3,
"num_modified_lines": 64,
"pr_author": "allenve",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": null,
"code_quality": null,
"confidence": null,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": fal... | |
5fe0edd141e14171ce9c650b4b075d55c45a893e | 2023-11-09 11:37:48 | baidu__amis-8678 | diff --git a/packages/amis-formula/src/evalutor.ts b/packages/amis-formula/src/evalutor.ts
index e44b570c3..db1d8658d 100644
--- a/packages/amis-formula/src/evalutor.ts
+++ b/packages/amis-formula/src/evalutor.ts
@@ -1524,8 +1524,8 @@ export class Evaluator {
*
* @returns {string} 生成的UUID字符串
*/
- fnUUID(le... | feat: 公式支持uuid生成
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 78c34a3</samp>
Updated the `UUID` function and its test case to use the UUIDv4 format, which has 36 characters including hyphens. This ensures the generated values are valid and consistent with the standard.
<!--
copilot:poem... | **Title**
Align UUID generator with standard UUIDv4 length
**Problem**
The formula engine’s UUID function produced identifiers limited to 32 characters, truncating the standard 36‑character UUIDv4 format and potentially yielding invalid identifiers. Consumers relying on the function expected a full UUID string.
*... | 8,678 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 25a7e875f..151d84a7a 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -564,7 +564,14 @@ test('evalute:Math', () => {
});
test('eva... | [
"evalute:UUID"
] | [
"evalute:simple",
"evalute:filter",
"evalute:filter2",
"evalute:filter3",
"evalute:filter4",
"evalute:keywords",
"evalute:oldVariable",
"evalute:ariable2",
"evalute:ariable3",
"evalute:object-variable",
"evalute:literal-variable",
"evalute:tempalte",
"evalute:literal",
"evalute:variableNam... | Method: Evaluator.fnUUID(length?: number)
Location: packages/amis-formula/src/evalutor.ts (class Evaluator)
Inputs:
- **length** (optional number): Desired length of the returned UUID string. Defaults to 36. The value is clamped to the range 0 – 36.
Outputs:
- **string**: A UUIDv4 formatted string (hexadecimal charac... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 1,
"num_modified_lines": 2,
"pr_author": "allenve",
"pr_labels": [
"feat"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.99,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false... | |
ab0832c3592097029685c7d617608d160be73a1b | 2023-11-09 13:28:09 | baidu__amis-8681 | diff --git a/packages/amis-editor/src/plugin/Form/InputNumber.tsx b/packages/amis-editor/src/plugin/Form/InputNumber.tsx
index a3b7cb8b4..a8cc38cad 100644
--- a/packages/amis-editor/src/plugin/Form/InputNumber.tsx
+++ b/packages/amis-editor/src/plugin/Form/InputNumber.tsx
@@ -19,6 +19,7 @@ import {defaultValue, getSche... | fix: 数字输入框配置面板固定为单侧按钮模式
### What
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 645cd3b</samp>
This pull request improves the schema template for the number input control in the amis-editor plugin. It uses the `Schema` type from `amis-core` and avoids formula editors for the `valueFormula` fields in ... | **Title**
Fix number input configuration UI and correct UUID length handling
**Problem**
The configuration panel for numeric inputs displayed formula editors for value, minimum and maximum fields, which is unsuitable for plain numbers. Additionally, the UUID helper allowed a default length that exceeded the inte... | 8,681 | baidu/amis | diff --git a/packages/amis-formula/__tests__/evalute.test.ts b/packages/amis-formula/__tests__/evalute.test.ts
index 151d84a7a..25a7e875f 100644
--- a/packages/amis-formula/__tests__/evalute.test.ts
+++ b/packages/amis-formula/__tests__/evalute.test.ts
@@ -564,14 +564,7 @@ test('evalute:Math', () => {
});
test('eva... | [
"evalute:UUID"
] | [
"lexer:simple",
"lexer:filter",
"lexer:exception",
"parser:simple",
"parser:complex",
"parser:evalMode",
"parser:template",
"parser:string",
"parser:number",
"parser:single-string",
"parser:object-literall",
"parser:array-literall",
"parser:variable-geter",
"parser:variable-geter2",
"par... | Method: Evaluator.fnUUID(self, length: number = 32)
Location: packages/amis-formula/src/evalutor.ts
Inputs: length – optional number, clamped to the range [0, 32] (default 32)
Outputs: string – a UUID v4 substring whose length equals the final clamped *length* (up to 32 characters)
Description: Generates a UUID string ... | custom-check-github | {
"base_image_name": "node_16",
"install": [
"npm install"
],
"log_parser": "parse_log_js_4",
"test_cmd": "cd packages/amis-formula && npx jest --verbose --no-color"
} | {
"num_modified_files": 2,
"num_modified_lines": 17,
"pr_author": "igrowp",
"pr_labels": [
"fix"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
3ed9f3e6a6b4473cecc6407e36b44f5a5b43ef27 | 2019-02-18 10:32:14 | codecov-io: # [Codecov](https://codecov.io/gh/nuxt/nuxt.js/pull/5054?src=pr&el=h1) Report
> Merging [#5054](https://codecov.io/gh/nuxt/nuxt.js/pull/5054?src=pr&el=desc) into [dev](https://codecov.io/gh/nuxt/nuxt.js/commit/b9391d7ea07f11cd5ed6eb318111e490b9af4f8c?src=pr&el=desc) will **increase** coverage by `0.09%`.
> ... | nuxt__nuxt.js-5054 | diff --git a/packages/builder/src/context/build.js b/packages/builder/src/context/build.js
index 3b60d116e..8dcd1b39a 100644
--- a/packages/builder/src/context/build.js
+++ b/packages/builder/src/context/build.js
@@ -6,6 +6,10 @@ export default class BuildContext {
this.isStatic = false
}
+ get buildOptions(... | refactor: unify context in webpack module
<!--- Provide a general summary of your changes in the title above -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (a non-breaking change which fixes an issue)
- [ ] New feature (a non... | **Title**
Unify build context handling across the webpack bundler and its configuration classes
**Problem**
Various parts of the webpack integration accessed build‑related settings through different paths, leading to fragmented and sometimes out‑of‑sync configuration data. This made it hard to guarantee that the... | 5,054 | nuxt/nuxt.js | diff --git a/packages/builder/test/context/build.test.js b/packages/builder/test/context/build.test.js
index 693d96ed2..a067add15 100644
--- a/packages/builder/test/context/build.test.js
+++ b/packages/builder/test/context/build.test.js
@@ -20,4 +20,14 @@ describe('builder: buildContext', () => {
const context = n... | [
"should return builder build options"
] | [
"should return false in default shouldPrefetch",
"should return true in script/style shouldPreload",
"should return false in other shouldPreload",
"should check if path starts with alias",
"should check if path starts with root alias",
"should check if path starts with src alias",
"should return same pa... | Method: BuildContext.buildOptions
Location: packages/builder/src/context/build.js → class BuildContext
Inputs: None (getter property)
Outputs: Returns the `build` object from the builder’s Nuxt options (`builder.nuxt.options.build`). Used to expose build configuration through the context.
Description: Provides read‑onl... | MIT | {
"base_image_name": "node_16",
"install": [
"sed -i '/\"packageManager\":/d' package.json",
"npm install --prefer-offline --no-audit --progress=false --ignore-scripts --legacy-peer-deps",
"npx lerna link",
"npx jiti ./scripts/pkg.js"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --... | {
"num_modified_files": 9,
"num_modified_lines": 175,
"pr_author": "clarkdo",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.82,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6"... |
3153e89645cce9f487d745e42f189da53cb4faed | 2019-03-21 19:59:34 | codecov-io: # [Codecov](https://codecov.io/gh/nuxt/nuxt.js/pull/5320?src=pr&el=h1) Report
> Merging [#5320](https://codecov.io/gh/nuxt/nuxt.js/pull/5320?src=pr&el=desc) into [dev](https://codecov.io/gh/nuxt/nuxt.js/commit/3153e89645cce9f487d745e42f189da53cb4faed?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> ... | nuxt__nuxt.js-5320 | diff --git a/packages/utils/src/locking.js b/packages/utils/src/locking.js
index 68cc1a731..d0ee5f0f0 100644
--- a/packages/utils/src/locking.js
+++ b/packages/utils/src/locking.js
@@ -40,6 +40,7 @@ export async function lock({ id, dir, root, options }) {
consola.fatal(`A lock with id '${id}' already exists on ${d... | fix: apply default lock options before setting lock
<!--- Provide a general summary of your changes in the title above -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (a non-breaking change which fixes an issue)
- [ ] New feat... | **Title**
Apply default lock options before acquiring a lock
**Problem**
The locking utility was passing raw options directly to the underlying lock implementation, so default values were never applied. This could lead to unexpected lock timeouts or retries and cause intermittent failures.
**Root Cause**
Th... | 5,320 | nuxt/nuxt.js | diff --git a/packages/utils/test/locking.test.js b/packages/utils/test/locking.test.js
index 58dfcf5c4..225c64157 100644
--- a/packages/utils/test/locking.test.js
+++ b/packages/utils/test/locking.test.js
@@ -18,16 +18,16 @@ describe('util: locking', () => {
beforeEach(() => jest.resetAllMocks())
beforeEach(() =>... | [
"lock uses setLockOptions to set defaults"
] | [
"should construct context",
"should return builder plugins context",
"should return builder build options",
"should export Module, Nuxt and Resolver",
"should return server configurations with NUXT_* env",
"should return server configurations with env",
"should return server configurations with npm_* en... | Method: defaultLockOptions.onCompromised()
Location: exported constant `defaultLockOptions` in **packages/utils/src/locking.js** (used directly in tests)
Inputs: none (the method is bound to the default options object)
Outputs: calls `consola.warn` (or the overridden handler) – does not throw by default
Description: De... | MIT | {
"base_image_name": "node_16",
"install": [
"sed -i '/\"packageManager\":/d' package.json",
"npm install --prefer-offline --no-audit --progress=false --ignore-scripts --legacy-peer-deps",
"npx lerna link",
"npx jiti ./scripts/pkg.js"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --... | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "pimlie",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": f... |
3c50876d737ced86f2e3677c1ee7be6328dcdcc9 | 2019-03-22 19:21:14 | codecov-io: # [Codecov](https://codecov.io/gh/nuxt/nuxt.js/pull/5347?src=pr&el=h1) Report
> Merging [#5347](https://codecov.io/gh/nuxt/nuxt.js/pull/5347?src=pr&el=desc) into [dev](https://codecov.io/gh/nuxt/nuxt.js/commit/3c50876d737ced86f2e3677c1ee7be6328dcdcc9?src=pr&el=desc) will **decrease** coverage by `44.73%`.
>... | nuxt__nuxt.js-5347 | diff --git a/packages/utils/src/locking.js b/packages/utils/src/locking.js
index d0ee5f0f0..c9b7fc15b 100644
--- a/packages/utils/src/locking.js
+++ b/packages/utils/src/locking.js
@@ -35,16 +35,33 @@ export async function getLockPath(config) {
export async function lock({ id, dir, root, options }) {
const lockPath... | fix(cli): catch all possible errors thrown from proper-filelock
<!--- Provide a general summary of your changes in the title above -->
## Types of changes
<!--- What types of changes does your code intro... | **Title**
Robust handling of lock‑related errors in the utils locking module
**Problem**
The locking utility relied on a third‑party lock library that can throw exceptions during lock checks, acquisition, and release. These uncaught errors caused the CLI to terminate unexpectedly, even when the lock situation wa... | 5,347 | nuxt/nuxt.js | diff --git a/packages/utils/test/locking.test.js b/packages/utils/test/locking.test.js
index 225c64157..52acfd6dd 100644
--- a/packages/utils/test/locking.test.js
+++ b/packages/utils/test/locking.test.js
@@ -61,7 +61,7 @@ describe('util: locking', () => {
})
test('lock creates a lock and returns a release fn',... | [
"lock logs warning when it couldnt get a lock",
"lock logs warning when proper.lock threw error",
"lock release only logs error when error thrown",
"lock check only logs error when error thrown",
"lock release doesnt log error when error thrown because lock compromised"
] | [
"should export Builder",
"should get context with req and res",
"should get correct globals",
"should export Server and Listener",
"should construct context",
"should export getDefaultNuxtConfig and getNuxtConfig",
"should return false in default shouldPrefetch",
"should return true in script/style sh... | Function: lock({ id, dir, root, options })
Location: packages/utils/src/locking.js
Inputs: An object `config` containing
- `id` (string): identifier for the lock,
- `dir` (string): directory where the lock file should be placed,
- optional `root` (string) and `options` (object) passed to **proper‑lockfile**.
Ou... | MIT | {
"base_image_name": "node_16",
"install": [
"sed -i '/\"packageManager\":/d' package.json",
"npm install --prefer-offline --no-audit --progress=false --ignore-scripts --legacy-peer-deps",
"npx lerna link",
"npx jiti ./scripts/pkg.js"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --... | {
"num_modified_files": 1,
"num_modified_lines": 44,
"pr_author": "pimlie",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... |
3c50876d737ced86f2e3677c1ee7be6328dcdcc9 | 2019-03-22 22:52:21 | codecov-io: # [Codecov](https://codecov.io/gh/nuxt/nuxt.js/pull/5349?src=pr&el=h1) Report
> Merging [#5349](https://codecov.io/gh/nuxt/nuxt.js/pull/5349?src=pr&el=desc) into [dev](https://codecov.io/gh/nuxt/nuxt.js/commit/3c50876d737ced86f2e3677c1ee7be6328dcdcc9?src=pr&el=desc) will **not change** coverage.
> The diff ... | nuxt__nuxt.js-5349 | diff --git a/examples/with-element-ui/package.json b/examples/with-element-ui/package.json
index 6e1108f59..6dd5c6c8c 100644
--- a/examples/with-element-ui/package.json
+++ b/examples/with-element-ui/package.json
@@ -3,14 +3,14 @@
"version": "1.0.0",
"license": "MIT",
"dependencies": {
- "element-ui": "^2",... | examples(with-element-ui): fix package scripts | **Title**
Improve example configuration, error messaging, locking reliability, and polyfill support
**Problem**
* The Element UI example had an incorrectly placed script and an overly broad version range, leading to broken npm/yarn commands.
* Builder emitted a misleading error label, confusing developers abou... | 5,349 | nuxt/nuxt.js | diff --git a/packages/builder/test/builder.build.test.js b/packages/builder/test/builder.build.test.js
index 8c16aea08..9274ee73f 100644
--- a/packages/builder/test/builder.build.test.js
+++ b/packages/builder/test/builder.build.test.js
@@ -263,7 +263,7 @@ describe('builder: builder build', () => {
.mockReturnVa... | [
"lock logs warning when it couldnt get a lock",
"lock logs warning when proper.lock threw error",
"lock release only logs error when error thrown",
"lock check only logs error when error thrown",
"lock release doesnt log error when error thrown because lock compromised"
] | [
"should export getDefaultNuxtConfig and getNuxtConfig",
"should return server configurations with NUXT_* env",
"should return server configurations with env",
"should return server configurations with npm_* env",
"should export Builder",
"should check if path starts with alias",
"should check if path st... | Method: Builder.validateTemplate()
Location: packages/builder/src/builder.js → class Builder
Inputs: (none) – called on a Builder instance after template analysis.
Outputs: Throws Error with message **'Missing App Dependencies'** when required app dependencies are not found; otherwise returns undefined.
Description: Va... | MIT | {
"base_image_name": "node_16",
"install": [
"sed -i '/\"packageManager\":/d' package.json",
"npm install --prefer-offline --no-audit --progress=false --ignore-scripts --legacy-peer-deps",
"npx lerna link",
"npx jiti ./scripts/pkg.js"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --... | {
"num_modified_files": 4,
"num_modified_lines": 50,
"pr_author": "aldarund",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.86,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6"... |
3cdce79d133da0ff0dd8c243e478fe89d5aa771b | 2019-04-05 11:20:32 | codecov-io: # [Codecov](https://codecov.io/gh/nuxt/nuxt.js/pull/5470?src=pr&el=h1) Report
> Merging [#5470](https://codecov.io/gh/nuxt/nuxt.js/pull/5470?src=pr&el=desc) into [dev](https://codecov.io/gh/nuxt/nuxt.js/commit/3cdce79d133da0ff0dd8c243e478fe89d5aa771b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> ... | nuxt__nuxt.js-5470 | diff --git a/packages/config/src/options.js b/packages/config/src/options.js
index fb8d5dd85..f985b4c94 100644
--- a/packages/config/src/options.js
+++ b/packages/config/src/options.js
@@ -22,6 +22,7 @@ export function getNuxtConfig(_options) {
if (options.loading === true) {
delete options.loading
}
+
if... | fix: improve `router.base` handling
<!--- Provide a general summary of your changes in the title above -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (a non-breaking change which fixes an issue)
- [ ] New feature (a non-break... | **Title**
Normalize `router.base` and include it in server listening URLs
**Problem**
When a custom router base is provided without a trailing slash, URLs generated by Nuxt (e.g., CLI banner, `-o` flag) are malformed. The server also reports its listening address without the configured base path.
**Root Cause... | 5,470 | nuxt/nuxt.js | diff --git a/packages/config/test/options.test.js b/packages/config/test/options.test.js
index e744db32e..87b458d81 100644
--- a/packages/config/test/options.test.js
+++ b/packages/config/test/options.test.js
@@ -227,3 +227,10 @@ describe('config: options', () => {
})
})
})
+
+describe('config: router', () => ... | [
"should compute http url",
"should compute https url"
] | [
"should return server configurations with NUXT_* env",
"should return server configurations with env",
"should return server configurations with npm_* env",
"should export getDefaultNuxtConfig and getNuxtConfig",
"should construct context",
"should get context with req and res",
"should get correct glob... | Method: Listener.constructor({port: number, host: string, socket?: string, https?: boolean, app: any, dev: boolean, baseURL?: string})
Location: packages/server/src/listener.js
Inputs:
- **port** – HTTP port number the server will listen on.
- **host** – Hostname or IP address; `'0.0.0.0'` is resolved to the local I... | MIT | {
"base_image_name": "node_16",
"install": [
"sed -i '/\"packageManager\":/d' package.json",
"npm install --prefer-offline --no-audit --progress=false --ignore-scripts --legacy-peer-deps",
"npx lerna link",
"npx jiti ./scripts/pkg.js"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --... | {
"num_modified_files": 3,
"num_modified_lines": 16,
"pr_author": "pi0",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": fal... |
8cddf4d852ce2bd027d3d577796be179a3f24380 | 2023-10-10 16:27:45 | tilt-dev__tilt-6246 | diff --git a/internal/controllers/fake/fixture.go b/internal/controllers/fake/fixture.go
index 60498d4ea..7e84026e4 100644
--- a/internal/controllers/fake/fixture.go
+++ b/internal/controllers/fake/fixture.go
@@ -5,6 +5,7 @@ import (
"io"
"os"
"strings"
+ "sync"
"testing"
"github.com/stretchr/testify/assert... | test: use a mutex to prevent simultaneous reconcilation
i think this will fix a bunch of weird race conditions and test flakiness | **Title**
Prevent concurrent reconciliations in controller test fixtures
**Problem**
Tests that invoke controller reconciliations directly can run multiple reconcile loops at the same time, leading to race conditions and intermittent failures. This divergence from the production execution model makes test outcomes... | 6,246 | tilt-dev/tilt | diff --git a/internal/controllers/core/cluster/reconciler_test.go b/internal/controllers/core/cluster/reconciler_test.go
index c29710da6..a4d30b283 100644
--- a/internal/controllers/core/cluster/reconciler_test.go
+++ b/internal/controllers/core/cluster/reconciler_test.go
@@ -291,9 +291,8 @@ func newFixture(t *testing.... | [
"TestController_LimitFileEventsHistory",
"TestController_ShortRead",
"TestController_IgnoreEphemeralFiles",
"TestController_Watcher_Cancel",
"TestController_Reconcile_Create",
"TestController_Reconcile_Delete",
"TestController_Reconcile_Watches",
"TestController_Disable_By_Configmap",
"TestControlle... | [] | Method: ControllerFixtureBuilder.WithRequeuer(r source.Source) *ControllerFixtureBuilder
Location: internal/controllers/fake/fixture.go
Inputs: r – a source.Source implementation (typically a controller’s requeuer) that will be stored for later wiring into the test fixture.
Outputs: Returns the same *ControllerFixtureB... | Apache-2.0 | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget",
"wget https://go.dev/dl/go1.23.0.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.0.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bin",
... | {
"num_modified_files": 2,
"num_modified_lines": 71,
"pr_author": "nicks",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": f... | |
59f9aa24c86dc5302772c61905275fd90675596f | 2025-01-16 03:29:33 | nicks: hmm..something weird is happening on mac that i have to look into...sadly, circleci turned off our mac runners and i haven't figured out how to fix them. | tilt-dev__tilt-6488 | diff --git a/internal/controllers/core/filewatch/controller.go b/internal/controllers/core/filewatch/controller.go
index 13309173c..5b66aedab 100644
--- a/internal/controllers/core/filewatch/controller.go
+++ b/internal/controllers/core/filewatch/controller.go
@@ -190,6 +190,10 @@ func (c *Controller) addOrReplace(ctx ... | watch: tweak dir change events
fixes https://github.com/tilt-dev/tilt/issues/6485
Signed-off-by: Nick Santos <nick.santos@docker.com>
| **Title**
Prevent unnecessary rebuilds caused by directory metadata changes and clean up MicroK8s Docker handling
**Problem**
File watchers were treating modifications to directory metadata (e.g., timestamp updates) as change events, leading to spurious rebuilds. Additionally, the Docker environment code contain... | 6,488 | tilt-dev/tilt | diff --git a/internal/controllers/core/filewatch/controller_test.go b/internal/controllers/core/filewatch/controller_test.go
index ba392f531..1afbe0c6e 100644
--- a/internal/controllers/core/filewatch/controller_test.go
+++ b/internal/controllers/core/filewatch/controller_test.go
@@ -324,13 +324,14 @@ func TestControll... | [
"TestController_Reconcile_Watches"
] | [
"TestController_LimitFileEventsHistory",
"TestController_ShortRead",
"TestController_IgnoreEphemeralFiles",
"TestController_Watcher_Cancel",
"TestController_Reconcile_Create",
"TestController_Reconcile_Delete",
"TestController_Disable_By_Configmap",
"TestController_Disable_Ignores_File_Changes",
"Te... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget",
"wget https://go.dev/dl/go1.23.0.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.0.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bin",
... | {
"num_modified_files": 6,
"num_modified_lines": 43,
"pr_author": "nicks",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6": f... |
59f9aa24c86dc5302772c61905275fd90675596f | 2025-02-04 07:52:40 | tilt-dev__tilt-6495 | diff --git a/internal/controllers/core/filewatch/controller.go b/internal/controllers/core/filewatch/controller.go
index 13309173c..5b66aedab 100644
--- a/internal/controllers/core/filewatch/controller.go
+++ b/internal/controllers/core/filewatch/controller.go
@@ -190,6 +190,10 @@ func (c *Controller) addOrReplace(ctx ... | docker: remove support for building to microk8s docker socket
i think this feature was removed from microk8s
years ago and we no longer need to support it.
fixes https://github.com/tilt-dev/tilt/issues/6494
Signed-off-by: Nick Santos <nick.santos@docker.com>
| **Title**
Remove outdated MicroK8s Docker socket handling
**Problem**
Tilt tried to detect and switch to a special Docker socket when running on MicroK8s. That socket is no longer provided, causing unnecessary configuration changes and potential build failures.
**Root Cause**
Hard‑coded logic assumed a MicroK... | 6,495 | tilt-dev/tilt | diff --git a/internal/controllers/core/filewatch/controller_test.go b/internal/controllers/core/filewatch/controller_test.go
index ba392f531..1afbe0c6e 100644
--- a/internal/controllers/core/filewatch/controller_test.go
+++ b/internal/controllers/core/filewatch/controller_test.go
@@ -324,13 +324,14 @@ func TestControll... | [
"TestController_Reconcile_Watches"
] | [
"TestController_LimitFileEventsHistory",
"TestController_ShortRead",
"TestController_IgnoreEphemeralFiles",
"TestController_Watcher_Cancel",
"TestController_Reconcile_Create",
"TestController_Reconcile_Delete",
"TestController_Disable_By_Configmap",
"TestController_Disable_Ignores_File_Changes",
"Te... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget",
"wget https://go.dev/dl/go1.23.0.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.0.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bin",
... | {
"num_modified_files": 3,
"num_modified_lines": 5,
"pr_author": "nicks",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": fa... | |
191fbb28376f68e82cb9b49d954a62c257e0263e | 2020-12-22 20:38:03 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1794#" title="Author self-approved">guillaumerose</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-rea... | code-ready__crc-1794 | diff --git a/cmd/crc/cmd/cleanup.go b/cmd/crc/cmd/cleanup.go
index 854504fbd..c443917b8 100644
--- a/cmd/crc/cmd/cleanup.go
+++ b/cmd/crc/cmd/cleanup.go
@@ -6,7 +6,6 @@ import (
"io"
"os"
- "github.com/code-ready/crc/pkg/crc/exit"
"github.com/code-ready/crc/pkg/crc/preflight"
"github.com/spf13/cobra"
)
@@ -2... | Intercept errors and send to segment for all commands
* Remove most of os.Exit in the middle of the code. This is needed to send errors to segment.
* Use RunE instead of Run. postRun() is now correctly called after each method. Even in case of an error.
* Introduce a segment middleware for all commands (except config... | **Title**
Improve CLI error handling and enable telemetry for all commands
**Problem**
The CLI terminated processes directly with exit calls, preventing graceful shutdown, post‑run actions, and consistent telemetry collection. Errors were not propagated to the Cobra framework, and the segment middleware was only... | 1,794 | code-ready/crc | diff --git a/pkg/crc/segment/segment_test.go b/pkg/crc/segment/segment_test.go
index 2f7acce08..cdf4faa22 100644
--- a/pkg/crc/segment/segment_test.go
+++ b/pkg/crc/segment/segment_test.go
@@ -1,10 +1,8 @@
package segment
import (
- "bytes"
"encoding/json"
"errors"
- "io"
"io/ioutil"
"net/http"
"net/http/... | [
"TestClientUploadWithConsent",
"TestClientUploadWithOutConsent"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | Method: Client.Upload(self, action string, err error)
Location: pkg/crc/segment/segment.go
Inputs: action – a string describing the command that triggered the error (e.g., "start"); err – the error to be reported (non‑nil). The client must have telemetry consent enabled; otherwise the call is a no‑op.
Outputs: error... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 18,
"num_modified_lines": 128,
"pr_author": "guillaumerose",
"pr_labels": [
"approved",
"lgtm"
],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4":... |
667a4164481ca9271b424d51775f75baed69243e | 2020-12-24 09:49:29 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1801#" title="Author self-approved">anjannath</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-ready%2... | code-ready__crc-1801 | diff --git a/cmd/crc/cmd/root.go b/cmd/crc/cmd/root.go
index 36e7a13b2..1c2b96adf 100644
--- a/cmd/crc/cmd/root.go
+++ b/cmd/crc/cmd/root.go
@@ -5,6 +5,7 @@ import (
"io/ioutil"
"os"
"strings"
+ "time"
cmdConfig "github.com/code-ready/crc/cmd/crc/cmd/config"
crcConfig "github.com/code-ready/crc/pkg/crc/conf... | Use udev rule to configure the permission and group for /dev/vsock
This would persist the permissions and group change after reboot | **Title**
Persist vsock permissions and improve telemetry reporting
**Problem**
* vsock device permissions and group ownership are not retained after a reboot.
* Telemetry uploads lack execution duration, success status, and OS information, and misuse the Identify call.
**Root Cause**
* The vsock pre‑flight fix onl... | 1,801 | code-ready/crc | diff --git a/pkg/crc/segment/segment_test.go b/pkg/crc/segment/segment_test.go
index cdf4faa22..abc799f97 100644
--- a/pkg/crc/segment/segment_test.go
+++ b/pkg/crc/segment/segment_test.go
@@ -8,7 +8,9 @@ import (
"net/http/httptest"
"os"
"path/filepath"
+ "runtime"
"testing"
+ "time"
cmdConfig "github.com/... | [
"TestClientUploadWithConsent",
"TestClientUploadWithOutConsent"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | Method: (*Client).Upload(action string, duration time.Duration, err error) error
Location: pkg/crc/segment/segment.go
Inputs:
- **action** (string): name of the telemetry event (e.g., “start”).
- **duration** (time.Duration): elapsed time of the operation, recorded in milliseconds.
- **err** (error): the error returne... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 4,
"num_modified_lines": 84,
"pr_author": "anjannath",
"pr_labels": [
"approved",
"lgtm"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false... |
ea33a56c2cac947eca13ae7fd4696da1fb511653 | 2020-12-24 09:54:18 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1802#" title="Author self-approved">guillaumerose</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-rea... | code-ready__crc-1802 | diff --git a/Makefile b/Makefile
index e17520a54..16a5b83c9 100644
--- a/Makefile
+++ b/Makefile
@@ -102,7 +102,7 @@ cross: $(BUILD_DIR)/macos-amd64/crc $(BUILD_DIR)/linux-amd64/crc $(BUILD_DIR)/wi
.PHONY: test
test:
- go test --tags build -v -ldflags="$(VERSION_VARIABLES)" ./pkg/... ./cmd/...
+ go test -race --tag... | Import 90% of machine code in crc
Only drivers (rpc, driver interface, hyperkit and libvirt structs) and state are left in code-ready/machine.
It will be easier to refactor machine code: better tests in the future, etc. All the persistence is now done in crc side. code-ready/machine is stateless and also all drivers... | **Title**
Refactor machine component imports and improve test setup
**Problem**
The CRC codebase now contains the former machine implementation, but many source files still import the old vendored machine packages, causing compilation failures. The test command also omitted the race detector, and the CI environm... | 1,802 | code-ready/crc | diff --git a/pkg/libmachine/host/host_test.go b/pkg/libmachine/host/host_test.go
new file mode 100644
index 000000000..9b724352f
--- /dev/null
+++ b/pkg/libmachine/host/host_test.go
@@ -0,0 +1,37 @@
+package host
+
+import (
+ "testing"
+
+ _ "github.com/code-ready/crc/pkg/drivers/none"
+)
+
+func TestValidateHostnameV... | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | [] | Method: Filestore.SetExists(hostName string) error
Location: pkg/libmachine/persist/filestore.go
Inputs:
- **hostName** (string): the name of the machine whose existence flag should be recorded in the filestore.
Outputs:
- **error**: nil on success, or a non‑nil error if the flag cannot be written (e.g., I/O failure,... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 18,
"num_modified_lines": 47,
"pr_author": "guillaumerose",
"pr_labels": [
"approved",
"lgtm"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": ... |
7b098c1bcaad0422dad36a390f8b335a9554548e | 2021-01-05 10:11:01 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1815#" title="Author self-approved">praveenkumar</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-read... | code-ready__crc-1815 | diff --git a/cmd/crc/cmd/config/config.go b/cmd/crc/cmd/config/config.go
index 6a191653b..4aa2e4cdb 100644
--- a/cmd/crc/cmd/config/config.go
+++ b/cmd/crc/cmd/config/config.go
@@ -52,22 +52,15 @@ func RegisterSettings(cfg *config.Config) {
}
func isPreflightKey(key string) bool {
- return strings.HasPrefix(key, "s... | Remove kubelet status check from start
It made sense before to check the status before perfoming some of
the cluster specific tasks since we were stopping/starting kubelet
service many time but now we just start the service and then do all
the cluster specific operations. If there is any issue with kubelet
service ... | **Title**
Simplify start flow, remove obsolete kubelet check and streamline pre‑flight, telemetry and platform handling
**Problem**
- The start command performed an unnecessary kubelet‑service status check, causing premature failures.
- Pre‑flight configuration exposed both `skip-` and `warn-` flags, complicat... | 1,815 | code-ready/crc | diff --git a/pkg/crc/preflight/preflight_darwin_test.go b/pkg/crc/preflight/preflight_darwin_test.go
index 9b0b840c6..5f94d8c75 100644
--- a/pkg/crc/preflight/preflight_darwin_test.go
+++ b/pkg/crc/preflight/preflight_darwin_test.go
@@ -12,7 +12,7 @@ import (
func TestCountConfigurationOptions(t *testing.T) {
cfg :=... | [
"TestCountConfigurationOptions",
"TestClientUploadWithConsent",
"TestClientUploadWithOutConsent"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | Method: Client.Upload(action string, duration time.Duration, err error)
Location: pkg/crc/segment/segment.go
Inputs:
- **action** (string): name of the command or operation being reported (e.g., “start”).
- **duration** (time.Duration): elapsed time of the operation; used for the “duration” property in the telemetry pa... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 12,
"num_modified_lines": 119,
"pr_author": "praveenkumar",
"pr_labels": [
"approved"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
... |
10c1dda3168a5ce13d4ed1431189e8e2ec086141 | 2021-01-05 14:25:06 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1816#" title="Author self-approved">praveenkumar</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-read... | code-ready__crc-1816 | diff --git a/cmd/crc/cmd/config/config.go b/cmd/crc/cmd/config/config.go
index 6a191653b..4aa2e4cdb 100644
--- a/cmd/crc/cmd/config/config.go
+++ b/cmd/crc/cmd/config/config.go
@@ -52,22 +52,15 @@ func RegisterSettings(cfg *config.Config) {
}
func isPreflightKey(key string) bool {
- return strings.HasPrefix(key, "s... | Remove warn flags from the config
`warn-<preflight-check>` is not used in crc context because we
are already capturing the checks data as part of debug logs. `skip`
is there to skip a check if a user don't want to run a check. | **Title**
Simplify pre‑flight configuration by removing warning flags and clean up related logging
**Problem**
The configuration exposed `warn-<check>` flags that were never used in practice, leading to unnecessary complexity and confusing documentation. Additionally, noisy debug output was generated for non‑criti... | 1,816 | code-ready/crc | diff --git a/pkg/crc/preflight/preflight_darwin_test.go b/pkg/crc/preflight/preflight_darwin_test.go
index 9b0b840c6..5f94d8c75 100644
--- a/pkg/crc/preflight/preflight_darwin_test.go
+++ b/pkg/crc/preflight/preflight_darwin_test.go
@@ -12,7 +12,7 @@ import (
func TestCountConfigurationOptions(t *testing.T) {
cfg :=... | [
"TestCountConfigurationOptions"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 5,
"num_modified_lines": 11,
"pr_author": "praveenkumar",
"pr_labels": [
"approved"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.95,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"... |
30f676113cb292d62ba6b9dd1aa7b1ec406b8c0d | 2021-01-05 19:46:12 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1818#" title="Author self-approved">guillaumerose</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-rea... | code-ready__crc-1818 | diff --git a/cmd/crc-embedder/cmd/extract.go b/cmd/crc-embedder/cmd/extract.go
index e99ce853f..f0cab79ed 100644
--- a/cmd/crc-embedder/cmd/extract.go
+++ b/cmd/crc-embedder/cmd/extract.go
@@ -1,10 +1,10 @@
package cmd
import (
+ "fmt"
+
"github.com/code-ready/crc/pkg/crc/logging"
- "github.com/code-ready/crc/pkg... | Ask the user to turn on telemetry when running crc setup
```
$ crc setup
CodeReady Containers is constantly improving and we would like to know more about usage!
Would you like to contribute anonymous usage statistics (more details at https://developers.redhat.com/article/tool-data-collection)? [y/N]: y
Thanks fo... | **Title**
Enable telemetry consent prompting and clean up console output handling
**Problem**
The `crc setup` command never asked users for telemetry consent, and the telemetry configuration was stored as a boolean while the rest of the code treated it as a string. Additionally, the custom output helper was remo... | 1,818 | code-ready/crc | diff --git a/pkg/crc/segment/segment_test.go b/pkg/crc/segment/segment_test.go
index abc799f97..0eabde50c 100644
--- a/pkg/crc/segment/segment_test.go
+++ b/pkg/crc/segment/segment_test.go
@@ -60,7 +60,7 @@ func mockServer() (chan []byte, *httptest.Server) {
return done, server
}
-func newTestConfig(value bool) (*... | [
"TestClientUploadWithConsent",
"TestClientUploadWithOutConsent"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | Function: newTestConfig(value string)
Location: pkg/crc/segment/segment_test.go (test helper used by TestClientUploadWithConsent and TestClientUploadWithOutConsent)
Inputs: <code>value</code> – a string expected to be either <code>"yes"</code> or <code>"no"</code>, which is stored as the telemetry consent value in the ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 19,
"num_modified_lines": 67,
"pr_author": "guillaumerose",
"pr_labels": [
"approved",
"lgtm"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": ... |
667a4164481ca9271b424d51775f75baed69243e | 2021-01-06 11:34:15 | openshift-ci-robot: [APPROVALNOTIFIER] This PR is **APPROVED**
This pull-request has been approved by: *<a href="https://github.com/code-ready/crc/pull/1819#" title="Author self-approved">cfergeau</a>*
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=code-ready%2F... | code-ready__crc-1819 | diff --git a/cmd/crc/cmd/root.go b/cmd/crc/cmd/root.go
index 36e7a13b2..1c2b96adf 100644
--- a/cmd/crc/cmd/root.go
+++ b/cmd/crc/cmd/root.go
@@ -5,6 +5,7 @@ import (
"io/ioutil"
"os"
"strings"
+ "time"
cmdConfig "github.com/code-ready/crc/cmd/crc/cmd/config"
crcConfig "github.com/code-ready/crc/pkg/crc/conf... | fedora33: Workaround NetworkManager bug with systemd-resolved
crc DNS configuration on systems using systemd-resolved is done through
a NetworkManager dispatcher file which gets run when the crc bridge is
created by libvirt. This file then uses resolvectl to configure the
bridge as the interface to use for resolving na... | **Title**
Improve NetworkManager DNS dispatcher handling and enrich telemetry reporting
**Problem**
- On systems where NetworkManager overwrites `resolvectl` settings, the CRC split‑DNS configuration is lost after any network connection change.
- Telemetry uploads previously did not capture command execution dur... | 1,819 | code-ready/crc | diff --git a/pkg/crc/segment/segment_test.go b/pkg/crc/segment/segment_test.go
index cdf4faa22..abc799f97 100644
--- a/pkg/crc/segment/segment_test.go
+++ b/pkg/crc/segment/segment_test.go
@@ -8,7 +8,9 @@ import (
"net/http/httptest"
"os"
"path/filepath"
+ "runtime"
"testing"
+ "time"
cmdConfig "github.com/... | [
"TestClientUploadWithConsent",
"TestClientUploadWithOutConsent"
] | [
"TestApi",
"TestSetconfigApi",
"TestGetconfigApi",
"TestGetClusterOperatorsStatus",
"TestGetClusterOperatorsStatusProgressing",
"TestGetClusterOperatorStatus",
"TestGetClusterOperatorStatusNotFound",
"TestSuccessfullyApplied",
"TestViperConfigUnknown",
"TestViperConfigSetAndGet",
"TestViperConfi... | Method: Client.Upload(self, action string, duration time.Duration, err error) error
Location: pkg/crc/segment/segment.go
Inputs:
- action (string) – name of the telemetry event (e.g., “start”).
- duration (time.Duration) – elapsed time of the command execution; sent as duration (ms) in the event properties.
- err (err... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive && apt-get update -qq && apt-get install -y -qq golang",
"export GOPATH=$HOME/go && export GOCACHE=$HOME/.cache/go-build && export XDG_CACHE_HOME=$HOME/.cache && export HOME=/tmp && mkdir -p $GOCACHE $HOME",
"go mod d... | {
"num_modified_files": 3,
"num_modified_lines": 49,
"pr_author": "cfergeau",
"pr_labels": [
"approved",
"lgtm"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,... |
6861b30cc43f17876894476e92305f2eb8ccfbff | 2021-09-15 04:29:22 | googleapis__google-cloud-go-4754 | diff --git a/bigquery/job.go b/bigquery/job.go
index 657d338e4b..510cdda054 100644
--- a/bigquery/job.go
+++ b/bigquery/job.go
@@ -375,6 +375,9 @@ type JobStatistics struct {
// TransactionInfo indicates the transaction ID associated with the job, if any.
TransactionInfo *TransactionInfo
+
+ // SessionInfo contai... | feat(bigquery): add session and connection support
Adds:
* CreateSession to Query config
* ConnectionProperties to specify connection keys/values in Query config
* SessionInfo in JobStatistics to record session stats
Also contains some minor test refactoring to make it easier to test query execution. | **Title**
Add BigQuery session creation and connection property support to query configuration and job statistics
**Problem**
Clients could not request a new session for a query nor specify custom connection key‑value settings. Additionally, job statistics did not expose any information about the session a job b... | 4,754 | googleapis/google-cloud-go | diff --git a/bigquery/integration_test.go b/bigquery/integration_test.go
index 2526392b37..de9b2a5847 100644
--- a/bigquery/integration_test.go
+++ b/bigquery/integration_test.go
@@ -479,7 +479,7 @@ func TestIntegration_SnapshotAndRestore(t *testing.T) {
FROM
UNNEST(GENERATE_ARRAY(0,999))
`, qualified)
- if _, e... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorFromErrorProto",
"TestError... | [] | Function: runQueryJob(ctx context.Context, q *Query) (*JobStatistics, *QueryStatistics, error)
Location: bigquery/integration_test.go (production implementation in bigquery/job.go is unchanged; test calls the exported helper)
Inputs:
- ctx – request‑level context controlling cancellation and deadlines.
- q – a *bigq... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 2,
"num_modified_lines": 78,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"cla: yes: This human has signed the Contributor License Agreement.",
"automerge: Merge the pull request once unit tests and other checks pass."
],
... | |
1c145f401131666e94fb3159d6967fddc007abcf | 2022-04-18 21:20:52 | googleapis__google-cloud-go-5907 | diff --git a/bigquery/intervalvalue.go b/bigquery/intervalvalue.go
new file mode 100644
index 0000000000..dc4510c33f
--- /dev/null
+++ b/bigquery/intervalvalue.go
@@ -0,0 +1,321 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except ... | feat(bigquery): add interval support
This PR adds INTERVAL type support to cloud.google.com/go/bigquery
It includes a new go type (IntervalValue), which can be used to represent/manipulate an interval value. It also includes requisite param support (using IntervalValue). Conversions between IntervalValue and time.... | **Title**
Add full support for the BigQuery INTERVAL data type
**Problem**
The client library could not represent, serialize, or deserialize BigQuery INTERVAL values, making it impossible to use intervals in query parameters, schema definitions, or result rows. This gap caused runtime errors when users attempted t... | 5,907 | googleapis/google-cloud-go | diff --git a/bigquery/intervalvalue_test.go b/bigquery/intervalvalue_test.go
new file mode 100644
index 0000000000..f657eb4a1c
--- /dev/null
+++ b/bigquery/intervalvalue_test.go
@@ -0,0 +1,179 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use th... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: (*IntervalValue).Canonicalize()
Location: bigquery/intervalvalue.go
Inputs: receiver *IntervalValue (any sign/scale)
Outputs: *IntervalValue – a new value where Y‑M and H:M:S.F components have consistent signs and are reduced (months < 12, minutes < 60, etc.)
Description: Normalizes an IntervalValue to its ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 4,
"num_modified_lines": 357,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: l: Pull request size is large."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {... | |
38af8ae88ae851ca21cf385795250ed8e8d16aab | 2022-05-04 00:17:02 | googleapis__google-cloud-go-5986 | diff --git a/bigquery/nulls.go b/bigquery/nulls.go
index 6ef53d13fc..cbe4fa34dc 100644
--- a/bigquery/nulls.go
+++ b/bigquery/nulls.go
@@ -60,6 +60,14 @@ type NullGeography struct {
func (n NullGeography) String() string { return nullstr(n.Valid, n.GeographyVal) }
+// NullJSON represents a BigQuery JSON string tha... | feat(bigquery): support JSON as a data type | **Title**
Add full support for the JSON data type in the BigQuery client library
**Problem**
The client library did not recognize BigQuery’s native JSON type, preventing users from sending, receiving, or defining JSON fields in queries and schemas. Null handling and parameter conversion for JSON were also missin... | 5,986 | googleapis/google-cloud-go | diff --git a/bigquery/nulls_test.go b/bigquery/nulls_test.go
index 7e5c939a14..7e9b1f0054 100644
--- a/bigquery/nulls_test.go
+++ b/bigquery/nulls_test.go
@@ -39,6 +39,7 @@ func TestNullsJSON(t *testing.T) {
{&NullBool{Valid: true, Bool: true}, `true`},
{&NullString{Valid: true, StringVal: "foo"}, `"foo"`},
{&... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: NullJSON.String() string
Location: bigquery/nulls.go
Inputs: none (receiver NullJSON)
Outputs: string – returns `"null"` if n.Valid is false, otherwise the JSON string value.
Description: Provides a string representation of a nullable JSON value for debugging and formatting.
Method: NullJSON.MarshalJSON() ([]b... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 4,
"num_modified_lines": 63,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"stale: extraold: Pull request is critically old and needs prioritization.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code"... | |
22d9f1e0cb114e7df2fe21fba4b26b869c9ce323 | 2022-05-19 17:30:36 | googleapis__google-cloud-go-6069 | diff --git a/bigquery/go.mod b/bigquery/go.mod
index 6377029efa..bc4207dac1 100644
--- a/bigquery/go.mod
+++ b/bigquery/go.mod
@@ -6,7 +6,7 @@ require (
cloud.google.com/go v0.100.2
cloud.google.com/go/datacatalog v1.3.0
cloud.google.com/go/iam v0.3.0
- cloud.google.com/go/storage v1.22.0
+ cloud.google.com/go/st... | chore(all): bump storage to latest release | **Title**
Update Cloud Storage client to the latest patch release across all modules
**Problem**
The repository was still using an older Cloud Storage client (v1.22.0). That version misses recent fixes and may cause compatibility or security issues for services that depend on it.
**Root Cause**
The go.mod f... | 6,069 | googleapis/google-cloud-go | diff --git a/internal/godocfx/testdata/golden/index.yml b/internal/godocfx/testdata/golden/index.yml
index 15e7ea3301..ccc6d95733 100644
--- a/internal/godocfx/testdata/golden/index.yml
+++ b/internal/godocfx/testdata/golden/index.yml
@@ -2491,6 +2491,9 @@ items:
attribute is specified, the content type will be au... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 10,
"num_modified_lines": 40,
"pr_author": "codyoss",
"pr_labels": [
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
... | |
b83b5b6ffc66954a87ef9f1a1767b58f496618d8 | 2024-01-09 14:40:15 | vercel[bot]: [vc]: #m5JwGxZRy1nv50m24FNcA4QtovnHyuXS1s/0r9qhD/s=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJoZWFkbGVzc3VpLXJlYWN0Iiwicm9vdERpcmVjdG9yeSI6InBsYXlncm91bmRzL3JlYWN0IiwiaW5zcGVjdG9yVXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3RhaWx3aW5kbGFicy9oZWFkbGVzc3VpLXJlYWN0LzNQZ2o1R0tzWVphUlY3d1p... | tailwindlabs__headlessui-2918 | diff --git a/packages/@headlessui-react/CHANGELOG.md b/packages/@headlessui-react/CHANGELOG.md
index faa061e..1b7359e 100644
--- a/packages/@headlessui-react/CHANGELOG.md
+++ b/packages/@headlessui-react/CHANGELOG.md
@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## ... | Expose `disabled` state on `<Tab />` component
This PR fixes an issue where `disabled` on the `<Tab/>` component wasn't exposed.
This will expose it such that you can use it with `ui-disabled`. In the Alpha version of React, you can also use `data-[disabled]` because it will be exposed as `data-disabled` over there ... | **Title**
Expose the `disabled` state on the `<Tab />` component
**Problem**
The `<Tab />` component never surfaced its `disabled` prop, so utilities like `ui-disabled` or data attributes could not react to a disabled tab. This caused inconsistencies compared to other components that already expose this state. ... | 2,918 | tailwindlabs/headlessui | diff --git a/packages/@headlessui-react/src/components/tabs/tabs.test.tsx b/packages/@headlessui-react/src/components/tabs/tabs.test.tsx
index 679a4cb..9cb78f2 100644
--- a/packages/@headlessui-react/src/components/tabs/tabs.test.tsx
+++ b/packages/@headlessui-react/src/components/tabs/tabs.test.tsx
@@ -544,6 +544,7 @@... | [
"should keep the delay time into account",
"should expose the `selected` state on the `Tab` components",
"should transition in completely (duration defined in milliseconds)",
"should fire events for all the stages"
] | [
"should be possible to get the text value from an element",
"should strip out emojis when receiving the text from the element",
"should strip out hidden elements",
"should strip out aria-hidden elements",
"should strip out role=\"img\" elements",
"should be possible to get the text value from the aria-lab... | Method: Tab (React) render prop argument <TabRenderPropArg>
Location: packages/@headlessui-react/src/components/tabs/tabs.tsx → type TabRenderPropArg
Inputs:
- selected: boolean – whether the tab is currently selected.
- active: boolean – whether the tab is the active (focused) element.
- focus: boolean – whether the t... | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci --prefer-offline --no-audit --progress=false"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npm test -- --verbose --no-colors"
} | {
"num_modified_files": 4,
"num_modified_lines": 11,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
f2bc6fdd4021969fb0ddeada980d5996fc106790 | 2024-01-23 12:58:01 | tailwindlabs__headlessui-2941 | diff --git a/packages/@headlessui-react/CHANGELOG.md b/packages/@headlessui-react/CHANGELOG.md
index f98abbf..52d371a 100644
--- a/packages/@headlessui-react/CHANGELOG.md
+++ b/packages/@headlessui-react/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- E... | Ensure `children` prop of `Field` component can be a render prop
This PR ensures that the `Field` can be used using a render prop as the children of the `Field` component.
This means that we can now do this again:
```tsx
<Field>
{({ disabled }) => {
return <input className={disabled ? "..." : "..."} />;
}}
</... | **Title**
Allow `Field` component to accept a render‑prop as its children
**Problem**
The `Field` component could only render static JSX children. When a function (render prop) was passed, it was treated as a regular node, preventing access to the field’s internal state (e.g., `disabled`). This broke the common ... | 2,941 | tailwindlabs/headlessui | diff --git a/packages/@headlessui-react/src/components/field/field.test.tsx b/packages/@headlessui-react/src/components/field/field.test.tsx
index 0ec7dd2..d1c8b88 100644
--- a/packages/@headlessui-react/src/components/field/field.test.tsx
+++ b/packages/@headlessui-react/src/components/field/field.test.tsx
@@ -14,6 +1... | [
"should wait the correct amount of time to finish a transition",
"should render a `Field` component with a render prop",
"should transition in and out completely"
] | [
"should be possible to server side render the Disclosure in a closed state",
"should be possible to server side render the Disclosure in an open state",
"should be possible to inert an element",
"should not mark an element as inert when the hook is disabled",
"should mark the element as not inert anymore, o... | Function: Field(props: { disabled?: boolean, children?: React.ReactNode | ((slot: { disabled: boolean }) => React.ReactNode) })
Location: packages/@headlessui-react/src/components/field/field.tsx
Inputs:
- **disabled** (optional boolean): controls the disabled state of the field.
- **children** (ReactNode | function):... | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci --prefer-offline --no-audit --progress=false"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npm test -- --verbose --no-colors"
} | {
"num_modified_files": 2,
"num_modified_lines": 8,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
da94b80860703d3c25c17631eaf84435821e7088 | 2024-02-03 16:18:36 | vercel[bot]: [vc]: #62L27VL5fhxoxrpYowr4T76pFVp3yVeONxx5DJmVItA=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJoZWFkbGVzc3VpLXZ1ZSIsInJvb3REaXJlY3RvcnkiOiJwbGF5Z3JvdW5kcy92dWUiLCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vdGFpbHdpbmRsYWJzL2hlYWRsZXNzdWktdnVlL0cyemZ0TjdnN0Q1c3RQTHppU2tmTlF... | tailwindlabs__headlessui-2966 | diff --git a/packages/@headlessui-react/CHANGELOG.md b/packages/@headlessui-react/CHANGELOG.md
index 61c0898..3908d51 100644
--- a/packages/@headlessui-react/CHANGELOG.md
+++ b/packages/@headlessui-react/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- E... | Allow setting custom `tabIndex` on the `<Switch />` component
This PR allows overriding the `tabIndex` of the `<Switch />` component if you need to change the tab index. However, we still need it to be focusable using the keyboard so we will always fallback to `0` even if `-1` was pased.
Fixes: #2915
| **Title**
Expose a customizable `tabIndex` prop for the `<Switch />` component while preserving keyboard focusability.
**Problem**
The switch component always forced a `tabIndex` of 0, preventing developers from providing their own tab order. At the same time, it needed to stay focusable via the keyboard.
**Root ... | 2,966 | tailwindlabs/headlessui | diff --git a/packages/@headlessui-react/src/components/switch/switch.test.tsx b/packages/@headlessui-react/src/components/switch/switch.test.tsx
index c65ddf5..b6988f2 100644
--- a/packages/@headlessui-react/src/components/switch/switch.test.tsx
+++ b/packages/@headlessui-react/src/components/switch/switch.test.tsx
@@ ... | [
"should be possible to override the `tabIndex`",
"should transition in completely (duration defined in seconds)",
"should transition in completely",
"should transition in and out completely",
"should transition in and out completely (render strategy = hidden)",
"should not unmount the whole tree when some... | [
"should be possible to get the text value from an element",
"should strip out emojis when receiving the text from the element",
"should strip out hidden elements",
"should strip out aria-hidden elements",
"should strip out role=\"img\" elements",
"should be possible to get the text value from the aria-lab... | Method: Switch<TTag extends ElementType = typeof DEFAULT_SWITCH_TAG>(props: SwitchProps<TTag> & { tabIndex?: number })
Location: packages/@headlessui-react/src/components/switch/switch.tsx
Inputs:
- tabIndex?: number – optional numeric prop; defaults to 0. If the caller provides -1 the component coerces it to 0 to kee... | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci --prefer-offline --no-audit --progress=false"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npm test -- --verbose --no-colors"
} | {
"num_modified_files": 4,
"num_modified_lines": 8,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... |
08baf094d22810e113514dec6bf9a05133353757 | 2024-02-21 13:08:31 | vercel[bot]: [vc]: #XFMtm9bVIaVWoByZM1t5TdWDXTP4a4CGwywr3CEXsxs=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJoZWFkbGVzc3VpLXJlYWN0Iiwicm9vdERpcmVjdG9yeSI6InBsYXlncm91bmRzL3JlYWN0IiwiaW5zcGVjdG9yVXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL3RhaWx3aW5kbGFicy9oZWFkbGVzc3VpLXJlYWN0L0ZON2VGMVd0bTE3djc4eHh... | tailwindlabs__headlessui-3004 | diff --git a/packages/@headlessui-react/CHANGELOG.md b/packages/@headlessui-react/CHANGELOG.md
index 14cc2f7..1035c32 100644
--- a/packages/@headlessui-react/CHANGELOG.md
+++ b/packages/@headlessui-react/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- A... | Forward `disabled` state to hidden inputs in form-like components
This PR fixes an issue where form-like components are disabled then the hidden input fields should be disabled as well otherwise they will be submitted to the form.
We will now forward the `disabled` state to the hidden inputs.
Fixes: #2988
| **Title**
Forward disabled state to hidden inputs in form‑like components
**Problem**
When a form‑like component (checkbox, combobox, listbox, radio group, switch) is disabled, its internally rendered hidden input remains enabled and is submitted with the form. This contradicts the expected HTML behavior where d... | 3,004 | tailwindlabs/headlessui | diff --git a/packages/@headlessui-react/src/components/combobox/combobox.test.tsx b/packages/@headlessui-react/src/components/combobox/combobox.test.tsx
index 525f345..562a33e 100644
--- a/packages/@headlessui-react/src/components/combobox/combobox.test.tsx
+++ b/packages/@headlessui-react/src/components/combobox/combo... | [
"should not submit the data if the Switch is disabled",
"should not submit the data if the RadioGroup is disabled",
"should fire events in the correct order",
"should not submit the data if the Listbox is disabled",
"should transition in completely",
"should transition out completely",
"should transitio... | [
"should be possible to get the text value from an element",
"should strip out emojis when receiving the text from the element",
"should strip out hidden elements",
"should strip out aria-hidden elements",
"should strip out role=\"img\" elements",
"should be possible to get the text value from the aria-lab... | Function: Switch(props)
Location: packages/@headlessui-vue/src/components/switch/switch.ts
Inputs:
- **disabled** (boolean, default false) – when true the component is non‑interactive and the hidden input that participates in form submission will receive a `disabled` attribute.
- **name** (string, optional) – the name ... | MIT | {
"base_image_name": "node_20",
"install": [
"npm ci --prefer-offline --no-audit --progress=false"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npm test -- --verbose --no-colors"
} | {
"num_modified_files": 12,
"num_modified_lines": 30,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.