base_commit stringlengths 40 40 | created_at stringdate 2013-07-19 17:10:26 2025-07-23 01:54:17 | hints_text stringlengths 0 525k | instance_id stringlengths 10 60 | patch stringlengths 174 256k | pr_description stringlengths 3 99.8k | problem_statement stringlengths 0 6.69k | pull_number int64 1 61.8k | repo stringlengths 5 54 | test_patch stringlengths 173 254k | FAIL_TO_PASS listlengths 1 122k | PASS_TO_PASS listlengths 0 190k | interface stringlengths 4 33.3k | license stringclasses 11
values | install_config dict | meta dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
704fc042be715857e97621442605e49113a4a3cc | 2023-01-29 23:07:13 | changeset-bot[bot]: ### 🦋 Changeset detected
Latest commit: b3590877cf75f2ec51f2e872a3da07cdad2a1a76
**The changes in this PR will be included in the next version bump.**
<details><summary>This PR includes changesets to release 18 packages</summary>
| Name | Type |
| -----------------... | remix-run__remix-5305 | diff --git a/.changeset/honest-crabs-sort.md b/.changeset/honest-crabs-sort.md
new file mode 100644
index 000000000..448b7a13e
--- /dev/null
+++ b/.changeset/honest-crabs-sort.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+Support decorators in files using CSS side-effect imports
diff --git a/packages/remix-d... | fix: support decorators with CSS side-effects
Closes: #5287
- [ ] Docs
- [x] Tests
Testing Strategy:
I've added snapshot tests that exercise a bunch of language features for all combinations of JS/TS with and without JSX. I wanted to make sure there weren't other obvious cases we weren't handling, but I also ... | **Title**
Support decorators in modules that import CSS for side effects
**Problem**
Modules that both import CSS for side effects and use decorator syntax currently fail to compile. This breaks developer workflows that rely on decorators alongside stylesheet imports.
**Root Cause**
The compilation plugin c... | 5,305 | remix-run/remix | diff --git a/packages/remix-dev/__tests__/cssSideEffectsPlugin-test.ts b/packages/remix-dev/__tests__/cssSideEffectsPlugin-test.ts
index 7c67d4a03..f9eac955a 100644
--- a/packages/remix-dev/__tests__/cssSideEffectsPlugin-test.ts
+++ b/packages/remix-dev/__tests__/cssSideEffectsPlugin-test.ts
@@ -222,4 +222,255 @@ descr... | [
"JS language features",
"JSX language features",
"TS language features",
"TSX language features"
] | [
"can use a custom upload handler",
"can return undefined",
"can throw errors in upload handlers",
"when controller errors",
"when controller is closed",
"returns an array of routes",
"works with async data",
"allows multiple routes with the same route module",
"throws an error on route id collisions... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_16",
"install": [
"npm install --engine-strict=false",
"npx rollup -c"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx jest --verbose --no-colors"
} | {
"num_modified_files": 2,
"num_modified_lines": 11,
"pr_author": "markdalgleish",
"pr_labels": [
"CLA Signed",
"package:dev"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
... |
c695aa1e086b14a77479d9a6dad8855c4e1a51c7 | 2024-03-18 12:45:57 | codesandbox[bot]: #### Review or Edit in CodeSandbox
Open the branch in <a href="https://codesandbox.io/p/github/fabricjs/fabric.js/fix/dirty-bubbling?mode=review&utm_source=gh_app">Web Editor</a> • <a href="https://codesandbox.io/p/vscode?owner=fabricjs&repo=fabric.js&branch=fix/dirty-bubbling&utm_source=gh_app"... | fabricjs__fabric.js-9741 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3e6e3ec9b..1f0fc04f0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@
- chore(TS): minor changes to typescript notation to be compatible with a 5.3.3 [#9725](https://github.com/fabricjs/fabric.js/pull/9725)
- fix(InteractiveObject): "borderOpacityWhenMoving" ... | fix(): bubble dirty flag to parent
<!--
Hi there!
Thanks for taking the time and putting the effort into making fabric better! 💖
Take a look at /CONTRIBUTING.md for crucial instructions regarding local setup, testing etc.
https://github.com/fabricjs/fabric.js/blob/master/CONTRIBUTIN... | **Title**
Correct dirty‑flag propagation to the true parent object
**Problem**
When a child object is marked dirty, the flag was incorrectly bubbled to its immediate group reference instead of the actual parent in the hierarchy. This caused unnecessary dirty marking of `ActiveSelection` objects (which never cach... | 9,741 | fabricjs/fabric.js | diff --git a/test/unit/group.js b/test/unit/group.js
index b8f94144f..4e2a4e334 100644
--- a/test/unit/group.js
+++ b/test/unit/group.js
@@ -677,18 +677,6 @@
assert.equal(g1.dirty, true, 'Group has dirty flag set');
});
- QUnit.test('dirty flag propagation from children up is stopped if group is not caching'... | [
"when dirty is true it bubbles to the parent"
] | [
"setCoords should calculate control coords only if canvas ref is set",
"clones an object deeply",
"it maintains an object fixed on a constrain point",
"the fixed anchor point works with an origin swap",
"operates as expected",
"returns dimensions of the polyline regardless of transform or strokeWidth",
... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_20",
"install": [
"git submodule update --init --recursive",
"npm ci --quiet"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npm run test:jest -- --verbose --no-colors"
} | {
"num_modified_files": 4,
"num_modified_lines": 32,
"pr_author": "ShaMan123",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... |
10a6bd7514d7541c122408681e1ae179e4baa4fd | 2022-02-16 20:32:15 | shollyman: Blocked on internal issue 211633697
shollyman: necessary discovery fixes present in google.golang.org/api v0.71.0 or later | googleapis__google-cloud-go-5666 | diff --git a/bigquery/dataset.go b/bigquery/dataset.go
index 7f9115a5c2..7c23b286e4 100644
--- a/bigquery/dataset.go
+++ b/bigquery/dataset.go
@@ -207,10 +207,10 @@ func (d *Dataset) Metadata(ctx context.Context) (md *DatasetMetadata, err error)
}); err != nil {
return nil, err
}
- return bqToDatasetMetadata(ds)... | feat(bigquery): support authorized datasets
This augments what you can express in a dataset ACL, and can include a
dataset with a set of allowed resource types. In short, this allows for
simplifying authorized views by allowing an entry that says "all views
in this dataset are authorized" vs the current behavior, w... | **Title**
Add support for dataset‑level access entries in BigQuery ACLs
**Problem**
The current ACL model only allows individual views, tables, or routines to be granted access, making it cumbersome to authorize all resources of a given type within a dataset. Additionally, metadata conversion lost the reference ... | 5,666 | googleapis/google-cloud-go | diff --git a/bigquery/dataset_test.go b/bigquery/dataset_test.go
index fb4d3ea2ee..1d49c68151 100644
--- a/bigquery/dataset_test.go
+++ b/bigquery/dataset_test.go
@@ -24,6 +24,7 @@ import (
"cloud.google.com/go/internal/testutil"
"github.com/google/go-cmp/cmp"
+ "github.com/google/go-cmp/cmp/cmpopts"
bq "google... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Function: bqToDatasetMetadata(d *bq.Dataset, c *Client)
Location: bigquery/dataset.go
Inputs:
- d: pointer to the Google API representation of a BigQuery dataset (type *bq.Dataset).
- c: a *Client used to resolve dataset references when converting access entries (required for the new DatasetEntity type).
Outputs:
- ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 3,
"num_modified_lines": 69,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: s: Pull request size is small."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
... |
a8fc2fa7b0abc8863c51c7f6bd91990e603a0bad | 2022-02-18 04:32:40 | googleapis__google-cloud-go-5672 | diff --git a/bigquery/copy.go b/bigquery/copy.go
index aaec924113..a8226e9798 100644
--- a/bigquery/copy.go
+++ b/bigquery/copy.go
@@ -28,10 +28,14 @@ type TableCopyOperationType string
var (
// CopyOperation indicates normal table to table copying.
CopyOperation TableCopyOperationType = "COPY"
- // SnapshotOperat... | feat(bigquery): support table cloning
This PR adds support for cloning tables. | **Title**
Add full support for BigQuery table cloning in the client library
**Problem**
The library could copy and snapshot tables but had no way to create or inspect writable table clones. Consequently, developers could not leverage BigQuery’s clone feature through the Go SDK.
**Root Cause**
The copy opera... | 5,672 | googleapis/google-cloud-go | diff --git a/bigquery/integration_test.go b/bigquery/integration_test.go
index c5a05fd77a..5505170fef 100644
--- a/bigquery/integration_test.go
+++ b/bigquery/integration_test.go
@@ -322,7 +322,7 @@ func TestIntegration_JobFrom(t *testing.T) {
}
-func TestIntegration_SnapshotAndRestore(t *testing.T) {
+func TestIn... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: Table.CopierFrom(src *Table) *TableCopier
Location: bigquery/table.go (method on *Table)
Inputs: src – the source *Table whose data will be copied or cloned.
Outputs: *TableCopier – a copier object that can be configured (e.g., OperationType) and executed with Run.
Description: Creates a copier configur... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 2,
"num_modified_lines": 47,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"stale: old: Pull request is old and needs attention.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code": "B4",
"code_qua... | |
a34503bc0f0b95399285e8db66976b227e3b0072 | 2022-03-01 22:00:36 | googleapis__google-cloud-go-5707 | diff --git a/bigquery/copy.go b/bigquery/copy.go
index 38d4eee839..aaec924113 100644
--- a/bigquery/copy.go
+++ b/bigquery/copy.go
@@ -16,6 +16,7 @@ package bigquery
import (
"context"
+ "time"
bq "google.golang.org/api/bigquery/v2"
)
@@ -58,6 +59,16 @@ type CopyConfig struct {
// One of the supported opera... | feat(bigquery): add job timeout support
This feature allows callers to configure a job timeout. If a BigQuery
job runs longer than this duration, BigQuery may cancel the job.
We expose JobTimeout in each of the job config types, given the existing pattern.
Fixes: https://github.com/googleapis/google-cloud-go/is... | **Title**
Add support for specifying a per‑job timeout in BigQuery job configurations
**Problem**
Clients cannot currently set a deadline for an individual BigQuery job, so long‑running jobs may continue indefinitely unless cancelled manually. The library does not expose the underlying `jobTimeoutMs` field that ... | 5,707 | googleapis/google-cloud-go | diff --git a/bigquery/copy_test.go b/bigquery/copy_test.go
index 9b16ebf2d3..368c4fd58c 100644
--- a/bigquery/copy_test.go
+++ b/bigquery/copy_test.go
@@ -16,6 +16,7 @@ package bigquery
import (
"testing"
+ "time"
"cloud.google.com/go/internal/testutil"
"github.com/google/go-cmp/cmp/cmpopts"
@@ -152,10 +153,... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: CopyConfig.toBQ()
Location: bigquery/copy.go (method of *CopyConfig)
Inputs: the receiver holds all copy‑job settings, notably the newly added **JobTimeout time.Duration** field.
Outputs: returns *bq.JobConfiguration where the field **JobTimeoutMs** is set to `c.JobTimeout.Milliseconds()` (zero omitted). ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 4,
"num_modified_lines": 60,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: s: Pull request size is small."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
... | |
9e979c9718df1de440d440e4c3e20bb3cb8c5aa1 | 2022-03-09 18:01:31 | googleapis__google-cloud-go-5739 | diff --git a/bigquery/external.go b/bigquery/external.go
index afe255660d..c5337a0021 100644
--- a/bigquery/external.go
+++ b/bigquery/external.go
@@ -104,6 +104,11 @@ type ExternalDataConfig struct {
//
// StringTargetType supports all precision and scale values.
DecimalTargetTypes []DecimalTargetType
+
+ // Con... | feat(bigquery): expose connections and schema autodetect modifier
This exposes the connectionID in the in the external data config,
and wires in the new autodetect schema as a variadic option on the
Update() method for tables.
Technically this is a breaking signature change, but in practice
variadic options can b... | **Title**
Enable connection ID on external data configs and add schema autodetect option to table updates
**Problem**
* The external data configuration did not provide a way to associate a BigQuery connection ID, limiting integration with the Connection API.
* Table updates lacked a mechanism to request schema... | 5,739 | googleapis/google-cloud-go | diff --git a/bigquery/external_test.go b/bigquery/external_test.go
index 6eb930d74b..db83771fc8 100644
--- a/bigquery/external_test.go
+++ b/bigquery/external_test.go
@@ -41,6 +41,7 @@ func TestExternalDataConfig(t *testing.T) {
SkipLeadingRows: 3,
NullMarker: "marker",
},
+ ConnectionID: "... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: Table.Update(self, ctx context.Context, tm TableMetadataToUpdate, etag string, opts ...TableUpdateOption)
Location: bigquery/table.go
Inputs:
- ctx: context.Context – request‑level context.
- tm: TableMetadataToUpdate – struct containing the fields to modify (e.g., ExternalDataConfig, Description, etc.).
- etag... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 2,
"num_modified_lines": 45,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"stale: old: Pull request is old and needs attention.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code": "A",
"code_qual... | |
74da335fea6cd70b27808507f2e58ae53f5f4910 | 2022-07-29 20:10:22 | googleapis__google-cloud-go-6448 | diff --git a/bigquery/external.go b/bigquery/external.go
index c5337a0021..3d3442b7fa 100644
--- a/bigquery/external.go
+++ b/bigquery/external.go
@@ -230,17 +230,22 @@ type CSVOptions struct {
// An optional custom string that will represent a NULL
// value in CSV import data.
NullMarker string
+
+ // Preserves ... | feat(bigquery): add PreserveAsciiControlCharacters support for CSV | **Title**
Add support for preserving ASCII control characters in CSV load and external data options
**Problem**
When importing CSV data, embedded ASCII control characters (0x00‑0x1F) are always stripped, preventing callers from preserving legitimate control‑character content. The client library lacks a way to en... | 6,448 | googleapis/google-cloud-go | diff --git a/bigquery/file_test.go b/bigquery/file_test.go
index e57633f363..77ba8b2610 100644
--- a/bigquery/file_test.go
+++ b/bigquery/file_test.go
@@ -33,13 +33,14 @@ var (
nestedFieldSchema(),
},
CSVOptions: CSVOptions{
- Quote: hyphen,
- FieldDelimiter: "\t",
- SkipLeadingRows: ... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: (*CSVOptions) populateExternalDataConfig(c *bq.ExternalDataConfiguration)
Location: bigquery/external.go (CSVOptions method)
Inputs: o *CSVOptions – includes the new field PreserveASCIIControlCharacters (bool); c *bq.ExternalDataConfiguration – will have its CsvOptions.PreserveAsciiControlCharacters set to the ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 2,
"num_modified_lines": 21,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {... | |
7d3b5a1bcfe8727dd91beb7d125a7e14c5307d0d | 2025-04-14 14:56:22 | coderabbitai[bot]: <!-- This is an auto-generated comment: summarize by coderabbit.ai -->
<!-- This is an auto-generated comment: skip review by coderabbit.ai -->
> [!IMPORTANT]
> ## Review skipped
>
> Auto reviews are limited to specific labels.
>
> <details>
> <summary>:label: Labels to auto review (1)</summary>
>... | lightningnetwork__lnd-9713 | diff --git a/channeldb/migration_01_to_11/db.go b/channeldb/migration_01_to_11/db.go
index 4045d52bd..65cc8d221 100644
--- a/channeldb/migration_01_to_11/db.go
+++ b/channeldb/migration_01_to_11/db.go
@@ -57,7 +57,7 @@ func Open(dbPath string, modifiers ...OptionModifier) (*DB, error) {
// freelist grows to be very l... | scripts: use LND status to determine when a node is ready for RPC calls
## Context
The backwards compatibility test sometimes fails due to the `[lncli] rpc error: code = Unknown desc = server is still in the process of starting` error when we try to connect nodes right after checking if they have started. This is ca... | **Title**
Simplify DB handling, drop obsolete neutrino migration, and remove legacy payment‑hash patch
**Problem**
Various parts of the codebase still used an outdated read‑only flag, a complex neutrino‑to‑Postgres migration path, and a legacy hash‑patch for old payments. These remnants caused build issues, unnece... | 9,713 | lightningnetwork/lnd | diff --git a/aliasmgr/aliasmgr_test.go b/aliasmgr/aliasmgr_test.go
index b288ade0d..1844a82ef 100644
--- a/aliasmgr/aliasmgr_test.go
+++ b/aliasmgr/aliasmgr_test.go
@@ -19,7 +19,6 @@ func TestAliasStorePeerAlias(t *testing.T) {
dbPath := filepath.Join(t.TempDir(), "testdb")
db, err := kvdb.Create(
kvdb.BoltBacke... | [
"TestProbabilityExtrapolation",
"TestMppSend",
"TestMppSend/sufficient_inbound",
"TestMppSend/no_splitting",
"TestMppSend/one_path_split",
"TestMppSend/insufficient_total_balance",
"TestMppSend/max_shard_size_clamping",
"TestMissionControlStore",
"TestMissionControlStoreFlushing",
"TestMissionCont... | [
"TestQueryRoutes",
"TestQueryRoutes/no_mission_control",
"TestQueryRoutes/no_mission_control_and_msat",
"TestQueryRoutes/with_mission_control",
"TestQueryRoutes/no_mission_control_bad_cltv_limit",
"TestUnmarshalMPP",
"TestUnmarshalMPP/nil_record",
"TestUnmarshalMPP/invalid_total_or_addr",
"TestUnmar... | Method: Create(backendName string, dbPath string, init bool, timeout time.Duration) (Backend, error)
Location: kvdb/backend.go (function Create)
Inputs:
- **backendName** – name of the KVDB backend (e.g., `kvdb.BoltBackendName` or `"bdb"`).
- **dbPath** – filesystem path for the database file.
- **init** – `t... | MIT | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget curl",
"wget -q https://go.dev/dl/go1.23.6.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.6.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bi... | {
"num_modified_files": 14,
"num_modified_lines": 31,
"pr_author": "ellemouton",
"pr_labels": [],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": true,
"... |
6d648ad90ab70e45449fa98594305a4aa2865f62 | 2025-04-14 15:12:46 | lightningnetwork__lnd-9715 | diff --git a/channeldb/migration_01_to_11/db.go b/channeldb/migration_01_to_11/db.go
index 4045d52bd..65cc8d221 100644
--- a/channeldb/migration_01_to_11/db.go
+++ b/channeldb/migration_01_to_11/db.go
@@ -57,7 +57,7 @@ func Open(dbPath string, modifiers ...OptionModifier) (*DB, error) {
// freelist grows to be very l... | itest: remove manual channel closures from route blinding tests
The itest framework now handles the closure of any channels opened during the test and so we dont need to manually close them. The manual closure code in the route blinding tests were resulting in the occasional test flake.
(I've lost the link to the bu... | **Title**
Simplify KVDB configuration, update dependencies, and clean up legacy payment handling
**Problem**
The KVDB backend retained a read‑only flag and related code that is no longer used, leading to unnecessary complexity and potential mismatches after dependency upgrades. Additionally, some release‑note entr... | 9,715 | lightningnetwork/lnd | diff --git a/aliasmgr/aliasmgr_test.go b/aliasmgr/aliasmgr_test.go
index b288ade0d..1844a82ef 100644
--- a/aliasmgr/aliasmgr_test.go
+++ b/aliasmgr/aliasmgr_test.go
@@ -19,7 +19,6 @@ func TestAliasStorePeerAlias(t *testing.T) {
dbPath := filepath.Join(t.TempDir(), "testdb")
db, err := kvdb.Create(
kvdb.BoltBacke... | [
"TestProbabilityExtrapolation",
"TestMppSend",
"TestMppSend/sufficient_inbound",
"TestMppSend/no_splitting",
"TestMppSend/one_path_split",
"TestMppSend/insufficient_total_balance",
"TestMppSend/max_shard_size_clamping",
"TestMissionControlStore",
"TestMissionControlStoreFlushing",
"TestMissionCont... | [
"TestQueryRoutes",
"TestQueryRoutes/no_mission_control",
"TestQueryRoutes/no_mission_control_and_msat",
"TestQueryRoutes/with_mission_control",
"TestQueryRoutes/no_mission_control_bad_cltv_limit",
"TestUnmarshalMPP",
"TestUnmarshalMPP/nil_record",
"TestUnmarshalMPP/invalid_total_or_addr",
"TestUnmar... | Method: kvdb.Create(name string, dbPath string, syncFreelist bool, timeout time.Duration) (Backend, error)
Location: package kvdb
Inputs:
- **name** (string): backend type identifier, currently always `"bdb"` for the Bolt backend.
- **dbPath** (string): full file path of the database file to create/open.
- **syncFreeli... | MIT | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget curl",
"wget -q https://go.dev/dl/go1.23.6.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.6.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bi... | {
"num_modified_files": 12,
"num_modified_lines": 19,
"pr_author": "ellemouton",
"pr_labels": [
"no-changelog"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
... | |
51add8a701eefc942fff7b6c3ddef370ac892737 | 2025-04-15 01:58:03 | coderabbitai[bot]: <!-- This is an auto-generated comment: summarize by coderabbit.ai -->
<!-- This is an auto-generated comment: skip review by coderabbit.ai -->
> [!IMPORTANT]
> ## Review skipped
>
> Auto reviews are limited to specific labels.
>
> <details>
> <summary>:label: Labels to auto review (1)</summary>
>... | lightningnetwork__lnd-9719 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 4bbe88971..913b4458e 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -21,7 +21,7 @@ defaults:
shell: bash
env:
- BITCOIN_VERSION: "29"
+ BITCOIN_VERSION: "28"
# TRANCHES defines the number of tranches... | accessman: add logging to new sub-system
In this PR, we add logging to the new Access Manager. It was committed without any logs at all, which otherwise would've made it hard to monitor and debug the new sub-system. | **Title**
Add comprehensive logging to the Access Manager and simplify PSBT funding API
**Problem**
The newly introduced Access Manager lacked any observability, making debugging and monitoring impossible.
The wallet RPC `FundPsbt` exposed `custom_lock_id` and `lock_expiration_seconds` fields that were never u... | 9,719 | lightningnetwork/lnd | diff --git a/itest/list_on_test.go b/itest/list_on_test.go
index 320f69f9e..e4dbc32ca 100644
--- a/itest/list_on_test.go
+++ b/itest/list_on_test.go
@@ -273,10 +273,6 @@ var allTestCases = []*lntest.TestCase{
Name: "fund psbt",
TestFunc: testFundPsbt,
},
- {
- Name: "fund psbt custom lock",
- TestFunc... | [
"TestBandwidthManager",
"TestBandwidthManager/channel_not_ours",
"TestBandwidthManager/channel_ours,_link_not_online",
"TestBandwidthManager/channel_ours,_link_not_eligible",
"TestBandwidthManager/channel_ours,_link_can't_add_htlc",
"TestBandwidthManager/channel_ours,_bandwidth_available",
"TestBlindedP... | [
"TestQueryRoutes",
"TestQueryRoutes/no_mission_control",
"TestQueryRoutes/no_mission_control_and_msat",
"TestQueryRoutes/with_mission_control",
"TestQueryRoutes/no_mission_control_bad_cltv_limit",
"TestUnmarshalMPP",
"TestUnmarshalMPP/nil_record",
"TestUnmarshalMPP/invalid_total_or_addr",
"TestUnmar... | No new interfaces are introduced. | MIT | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq wget curl",
"wget -q https://go.dev/dl/go1.23.6.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.6.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bi... | {
"num_modified_files": 20,
"num_modified_lines": 554,
"pr_author": "Roasbeef",
"pr_labels": [
"no-changelog"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
... |
e91f9e35e847021051c7d7b5e42cfc24cb3c532f | 2019-12-10 13:43:49 | kubernetes-sigs__cluster-api-provider-aws-1407 | diff --git a/Makefile b/Makefile
index cc55371c2..7a8b5b6f7 100644
--- a/Makefile
+++ b/Makefile
@@ -75,7 +75,7 @@ help: ## Display this help
## --------------------------------------
.PHONY: test
-test: generate lint ## Run tests
+test: ## Run tests
go test -v ./...
.PHONY: test-integration
diff --git a/cont... | ⚠️ Support bootstrap data in secret
<!-- please add a icon to the title of this PR (see https://sigs.k8s.io/cluster-api/VERSIONING.md), and delete this line and similar ones -->
<!-- the icon will be either ⚠️ (:warning:, major or breaking changes), ✨ (:sparkles:, minor or feature additions), 🐛 (:bug:, patch and bugf... | **Title**
Support bootstrap data stored in a secret for AWSMachine provisioning
**Problem**
The upstream Cluster API now places machine bootstrap data in a Kubernetes Secret rather than an inline field. The controller still expected the data in the deprecated inline location, leading to missing user‑data during ... | 1,407 | kubernetes-sigs/cluster-api-provider-aws | diff --git a/controllers/awsmachine_controller_test.go b/controllers/awsmachine_controller_test.go
index c26f0c2e2..89a716ee2 100644
--- a/controllers/awsmachine_controller_test.go
+++ b/controllers/awsmachine_controller_test.go
@@ -71,7 +71,7 @@ var _ = Describe("AWSMachineReconciler", func() {
Machine: &clusterv... | [
"TestAWSMachineReconciler_AWSClusterToAWSMachines",
"TestAMIs",
"TestAMIs/simple_test",
"TestAMIsWithInvalidCreationDate",
"TestAMIsWithInvalidCreationDate/simple_test",
"TestReconcileInternetGateways",
"TestReconcileInternetGateways/has_igw",
"TestReconcileInternetGateways/no_igw_attached,_creates_on... | [
"TestTags_Merge",
"TestTags_Merge/nil_other",
"TestTags_Merge/empty_other",
"TestTags_Merge/disjoint",
"TestTags_Merge/overlapping,_other_wins",
"TestAWSMachine_ValidateUpdate",
"TestAWSMachine_ValidateUpdate/change_in_providerid,_tags_and_securitygroups",
"TestAWSMachine_ValidateUpdate/change_in_fiel... | Method: MachineScope.GetBootstrapData(self)
Location: pkg/cloud/scope/machine.go
Inputs: (none) – uses the Machine object's `Spec.Bootstrap.DataSecretName` to locate a `corev1.Secret` in the same namespace.
Outputs: (string, error) – returns the bootstrap user‑data string from the secret's `["value"]` entry, or an e... | Apache-2.0 | {
"base_image_name": "go_1.23.8",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -y -qq",
"apt-get install -y -qq wget",
"wget https://go.dev/dl/go1.23.0.linux-amd64.tar.gz",
"tar -C /usr/local -xzf go1.23.0.linux-amd64.tar.gz",
"export PATH=$PATH:/usr/local/go/bin",
... | {
"num_modified_files": 6,
"num_modified_lines": 48,
"pr_author": "vincepri",
"pr_labels": [
"approved: Indicates a PR has been approved by an approver from all required OWNERS files.",
"cncf-cla: yes: Indicates the PR's author has signed the CNCF CLA.",
"lgtm: Indicates that a PR is ready to be mer... | |
198690fd755ec00cfe7f4d324d9487e565e82d4e | 2023-12-27 19:25:08 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/andregasser/bigbone/pull/410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andr%C3%A9+Gasser) Report
Attention: `9 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`6960044`)... | andregasser__bigbone-410 | diff --git a/bigbone/src/main/kotlin/social/bigbone/api/method/AccountMethods.kt b/bigbone/src/main/kotlin/social/bigbone/api/method/AccountMethods.kt
index 0b5569c..501552a 100644
--- a/bigbone/src/main/kotlin/social/bigbone/api/method/AccountMethods.kt
+++ b/bigbone/src/main/kotlin/social/bigbone/api/method/AccountMe... | Clean up endpoint definitions in methods classes
# Description
In this PR, I cleaned up how we refer to endpoints:
1. Ensure that all endpoints start _without_ a leading slash (`api/v1/…`, not `/api/v1/…`)
2. Ensure that all endpoints defined as a class-level `val` are named `endpoint` (or `endpointV1` and `endp... | **Title**
Standardize API endpoint constants across method classes
**Problem**
Method classes define API endpoints inconsistently: some include a leading slash, some use different variable names, and many hard‑code the path in each request. This makes maintenance error‑prone and hampers readability.
**Root Cause*... | 410 | andregasser/bigbone | diff --git a/bigbone/src/test/kotlin/social/bigbone/api/method/DomainBlockMethodsTest.kt b/bigbone/src/test/kotlin/social/bigbone/api/method/DomainBlockMethodsTest.kt
index 107f19f..7a2dbed 100644
--- a/bigbone/src/test/kotlin/social/bigbone/api/method/DomainBlockMethodsTest.kt
+++ b/bigbone/src/test/kotlin/social/bigb... | [
"deserialize() (social.bigbone.api.entity.MediaAttachmentTest)",
"Dismiss an announcement and verify that the method was called correctly() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Dismiss announcement with exception() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Add reaction to announ... | [] | No new interfaces are introduced. | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"chmod +x gradlew",
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew check --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*'... | {
"num_modified_files": 41,
"num_modified_lines": 233,
"pr_author": "PattaFeuFeu",
"pr_labels": [
"code quality: Everything related to code quality"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
... |
cf71753c3e0922750b4972ed36c51d368d2de27f | 2023-12-28 14:32:16 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/andregasser/bigbone/pull/411?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andr%C3%A9+Gasser) Report
Attention: `144 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`6960044... | andregasser__bigbone-411 | diff --git a/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxAccountMethods.kt b/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxAccountMethods.kt
index 59366a5..13875cb 100644
--- a/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxAccountMethods.kt
+++ b/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxAccountMethods.kt
@@ ... | Fully implement partially implemented AccountMethods
# Description
This PR is part 1 for #405 and implements missing properties and entity parameters. No new methods will be added in this PR—that’ll be the task for a follow-up PR.
# Type of Change
- New feature
- Documentation
# Breaking Changes
- `Acco... | **Title**
Complete implementation of Account‑related API methods and entities
**Problem**
The account API layer was missing several properties and parameters introduced by Mastodon, causing returned types to be incomplete and query calls to ignore new options. Documentation for the account entities was also outd... | 411 | andregasser/bigbone | diff --git a/bigbone/src/test/assets/accounts_register_422.json b/bigbone/src/test/assets/accounts_register_422.json
new file mode 100644
index 0000000..41d1fa8
--- /dev/null
+++ b/bigbone/src/test/assets/accounts_register_422.json
@@ -0,0 +1,23 @@
+{
+ "error": "Validation failed: Password can't be blank, Username mu... | [
"deserialize() (social.bigbone.api.entity.MediaAttachmentTest)",
"Dismiss an announcement and verify that the method was called correctly() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Dismiss announcement with exception() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Add reaction to announ... | [] | Method: AccountMethods.verifyCredentials(self)
Location: class AccountMethods – provides verification of the current user’s credentials.
Inputs: none.
Outputs: returns **CredentialAccount** on success; throws **BigBoneRequestException** on HTTP error.
Description: Calls `GET /api/v1/accounts/verify_credentials`... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"chmod +x gradlew",
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew check --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*'... | {
"num_modified_files": 7,
"num_modified_lines": 616,
"pr_author": "PattaFeuFeu",
"pr_labels": [
"documentation: Improvements or additions to documentation or sample code",
"enhancement: New feature or request",
"breaking: Incompatible with previous versions"
],
"llm_metadata": {
"code": "A"... |
90c825942359b3985490c7e7eb3b3d5e42701014 | 2023-12-29 18:10:09 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/andregasser/bigbone/pull/413?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andr%C3%A9+Gasser) Report
Attention: `21 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`90c8259`... | andregasser__bigbone-413 | diff --git a/bigbone-rx/src/main/kotlin/social/bigbone/rx/admin/RxAdminDomainAllowMethods.kt b/bigbone-rx/src/main/kotlin/social/bigbone/rx/admin/RxAdminDomainAllowMethods.kt
new file mode 100644
index 0000000..74af792
--- /dev/null
+++ b/bigbone-rx/src/main/kotlin/social/bigbone/rx/admin/RxAdminDomainAllowMethods.kt
@... | Add Admin::DomainAllow methods
# Description
This PR implements the [domain allows API](https://docs.joinmastodon.org/methods/admin/domain_allows/) so that users with role of admin to both see allowed federated domains, remove allowed domain and add new domain to be federated.
This closes https://github.com/andre... | **Title**
Add full support for Admin “Domain Allows” API
**Problem**
The library did not expose the Mastodon admin endpoint for managing allowed federated domains, preventing administrators from listing, retrieving, creating, or deleting allowed domains via the client.
**Root Cause**
No corresponding entity... | 413 | andregasser/bigbone | diff --git a/bigbone/src/test/assets/admin_domain_allow.json b/bigbone/src/test/assets/admin_domain_allow.json
new file mode 100644
index 0000000..94fd8ae
--- /dev/null
+++ b/bigbone/src/test/assets/admin_domain_allow.json
@@ -0,0 +1,5 @@
+{
+ "id": "1",
+ "domain": "mastodon.social",
+ "created_at": "2022-09-14T21:... | [
"deserialize() (social.bigbone.api.entity.MediaAttachmentTest)",
"Dismiss an announcement and verify that the method was called correctly() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Dismiss announcement with exception() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Add reaction to announ... | [] | Method: AdminDomainAllowMethods.getAllAllowedDomains(self, range: Range = Range())
Location:
Inputs: optional range of type Range used to specify pagination parameters (max_id, min_id, since_id, limit). If omitted a default empty Range is used.
Outputs: MastodonRequest\<Pageable\<AdminDomainAllow\>\> that, when execut... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"chmod +x gradlew",
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew check --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*'... | {
"num_modified_files": 6,
"num_modified_lines": 178,
"pr_author": "G10xy",
"pr_labels": [
"enhancement: New feature or request"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.99,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
... |
75ae65513a377a60061ed333991c29bb2c007c06 | 2024-10-18 23:11:31 | andregasser__bigbone-494 | diff --git a/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxGroupedNotificationMethods.kt b/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxGroupedNotificationMethods.kt
new file mode 100644
index 0000000..817a016
--- /dev/null
+++ b/bigbone-rx/src/main/kotlin/social/bigbone/rx/RxGroupedNotificationMethods.kt
@@ -0,0 +1... | Add grouped_notifications API
# Description
This PR adds new [methods for Grouped Notifications](https://docs.joinmastodon.org/methods/grouped_notifications) that were added as part of the most recent [Mastodon 4.3.0 release](https://github.com/mastodon/mastodon/releases).
Sorry, this got a lot larger than initia... | **Title**
Add full support for Mastodon grouped notifications API (v4.3.0)
**Problem**
The library did not expose the new grouped‑notifications endpoints introduced in Mastodon 4.3.0, nor did it correctly decode the server’s pageable response format for these calls. Additionally, notification‑type handling and rel... | 494 | andregasser/bigbone | diff --git a/bigbone/src/test/assets/grouped_notifications_get_accounts_of_notifications_success.json b/bigbone/src/test/assets/grouped_notifications_get_accounts_of_notifications_success.json
new file mode 100644
index 0000000..7c04199
--- /dev/null
+++ b/bigbone/src/test/assets/grouped_notifications_get_accounts_of_n... | [
"deserialize() (social.bigbone.api.entity.MediaAttachmentTest)",
"Dismiss an announcement and verify that the method was called correctly() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Dismiss announcement with exception() (social.bigbone.api.method.AnnouncementMethodsTest)",
"Add reaction to announ... | [] | Method: GroupedNotificationMethods.getAllGroupedNotifications(self, includeTypes: List<NotificationType>?, excludeTypes: List<NotificationType>?, accountId: String?, expandAccounts: ExpandAccounts?, groupedTypes: List<NotificationType>?, includeFiltered: Boolean = false, range: Range = Range())
Location: bigbone/src/ma... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"chmod +x gradlew",
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew check --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*'... | {
"num_modified_files": 18,
"num_modified_lines": 1131,
"pr_author": "PattaFeuFeu",
"pr_labels": [
"documentation: Improvements or additions to documentation or sample code",
"enhancement: New feature or request",
"breaking: Incompatible with previous versions"
],
"llm_metadata": {
"code": "... | |
100d3b5a945c45592b72de92225d2c92a8a5b190 | 2024-12-16 19:28:49 | PattaFeuFeu: Thank you for your contribution @jdpgrailsdev! I will try to give this PR a review in the course of this week.
codecov[bot]: ## [Codecov](https://app.codecov.io/gh/andregasser/bigbone/pull/512?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&... | andregasser__bigbone-512 | diff --git a/bigbone/build.gradle b/bigbone/build.gradle
index d5fbeb1..0937d53 100644
--- a/bigbone/build.gradle
+++ b/bigbone/build.gradle
@@ -18,4 +18,5 @@ dependencies {
testImplementation(libs.kotlin.reflect)
testImplementation libs.mockk
testImplementation libs.mockk.dsl
+ testImplementation lib... | refactor: pass scheme and port to server info url
# Description
Modifies the retrieve server info method of the `NodeInfoClient` to use the same scheme and port configuration from the calling `MastodonClient` builder. This is to allow the customization of the link for testing with mocking frameworks, such as WireMo... | **Title**
Allow configurable scheme and port for NodeInfo server discovery
**Problem**
The NodeInfo client always constructed URLs with the hard‑coded “https” scheme and port 443. This prevented using alternative ports or schemes, which is required for testing against mock servers and for instances that run on n... | 512 | andregasser/bigbone | diff --git a/bigbone/src/test/kotlin/social/bigbone/MastodonClientTest.kt b/bigbone/src/test/kotlin/social/bigbone/MastodonClientTest.kt
index f061de6..dfea5aa 100644
--- a/bigbone/src/test/kotlin/social/bigbone/MastodonClientTest.kt
+++ b/bigbone/src/test/kotlin/social/bigbone/MastodonClientTest.kt
@@ -22,10 +22,39 @@... | [
"Given a client returning success, when resending confirmation mail to a new address, then verify correct method was called() (social.bigbone.api.method.EmailMethodsTest)",
"Given a client returning success, when resending confirmation mail to existing address, then verify correct method was called() (social.bigb... | [] | Method: NodeInfoClient.retrieveServerInfo(host: String, scheme: String = "https", port: Int = 443) → Server?
Location: social.bigbone.nodeinfo.NodeInfoClient (object)
Inputs:
- host: String – the hostname of the server to query.
- scheme: String – URL scheme to use (default "https").
- port: Int – port number for the r... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"chmod +x gradlew",
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew check --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*'... | {
"num_modified_files": 3,
"num_modified_lines": 11,
"pr_author": "jdpgrailsdev",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
3de4c44148a8c6234eae04dc90d2a6091a28a749 | 2022-01-20 15:45:44 | codecov[bot]: # [Codecov](https://codecov.io/gh/analysis-dev/diktat/pull/1180?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=analysis-dev) Report
> Merging [#1180](https://codecov.io/gh/analysis-dev/diktat/pull/1180?src=pr&el=desc&utm_medium=referral&utm_source=... | analysis-dev__diktat-1180 | diff --git a/README.md b/README.md
index 707fbb82..1c7d4103 100644
--- a/README.md
+++ b/README.md
@@ -47,6 +47,8 @@ Main features of diktat are the following:
4) **Strict detailed coding convention** that you can use in your project.
## Run as CLI-application
+<details>
+<summary>Download and install binaries:</su... | Gradle and Maven Plugins: reporter types are fixed and updated
### What's done:
- Fixing gradle plugin reporter to support Sarif
- Adding the support of reporters to maven plugin
This pull request partially closes https://github.com/analysis-dev/diktat/issues/1179
| **Title**
Add SARIF reporter support and unify reporter configuration for Gradle and Maven plugins
**Problem**
The plugins only exposed a limited set of reporters and lacked guidance for using SARIF, which is the preferred format for GitHub Code Scanning. Documentation and configuration options were also fragmen... | 1,180 | analysis-dev/diktat | diff --git a/diktat-gradle-plugin/src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt b/diktat-gradle-plugin/src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt
index 723368d3..1d6f19d9 100644
--- a/diktat-gradle-plugin/src/functionalTest/k... | [
"check system property with multiproject build with custom config() (org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest)",
"check command line in debug mode() (org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest)",
"check command line has reporter type without output() (org.cqfn.diktat.plugin.gradle.DiktatJa... | [] | Method: DiktatExtension.reporter
Location: org.cqfn.diktat.plugin.gradle.DiktatExtension
Inputs: String value – the name of the reporter to use (e.g., "plain", "json", "html", "sarif"); empty or unsupported values are accepted but will fallback to "plain" during task execution.
Outputs: The property holds the current r... | MIT | {
"base_image_name": "kotlin-jdk-11",
"install": [
"cd diktat-gradle-plugin",
"./gradlew -q clean assemble"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "cd diktat-gradle-plugin && ./gradlew clean test --console=plain --info && find build/test-results/test/ -name '*.xml' -exec cat {} \\;"
} | {
"num_modified_files": 5,
"num_modified_lines": 96,
"pr_author": "akuleshov7",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B... |
234521a9f337051df4c4958a6757a83a7eec0836 | 2022-12-12 16:47:13 | cashapp__redwood-622 | diff --git a/redwood-cli/src/main/kotlin/app/cash/redwood/generator/GenerateCommand.kt b/redwood-cli/src/main/kotlin/app/cash/redwood/generator/GenerateCommand.kt
index 6232cd2b9..712979837 100644
--- a/redwood-cli/src/main/kotlin/app/cash/redwood/generator/GenerateCommand.kt
+++ b/redwood-cli/src/main/kotlin/app/cash/... | The diff consuming factory produces nodes, not widgets
Naming debt from a previous change. | **Title**
Rename diff‑consuming widget factories to node factories and clean up attachment handling
**Problem**
The code generator and runtime were still producing and exposing a “widget”‑oriented diff‑consuming factory, while the protocol now expects a node‑oriented factory. Additionally, an obsolete composable... | 622 | cashapp/redwood | diff --git a/redwood-cli/src/test/kotlin/app/cash/redwood/generator/ComposeGenerationTest.kt b/redwood-cli/src/test/kotlin/app/cash/redwood/generator/ComposeGenerationTest.kt
index 49d1e0882..2033f0b6c 100644
--- a/redwood-cli/src/test/kotlin/app/cash/redwood/generator/ComposeGenerationTest.kt
+++ b/redwood-cli/src/tes... | [
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_direction_column_flexShrinkSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_directionRow_fixedSizeViewAndShrinkable_doNotExceedMaxMainSize[jvm] (app.cash.r... | [] | Function: generateDiffConsumingNodeFactory(schema: ProtocolSchema): FileSpec
Location: redwood-cli/src/main/kotlin/app/cash/redwood/generator/diffConsumingGeneration.kt
Inputs: schema – the protocol schema that defines widget tags, widget types, and any dependent schemas.
Outputs: FileSpec – a KotlinPoet file containin... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 10,
"num_modified_lines": 73,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
88d81bea6e719ae57b409ba3febaf990abf3b9b2 | 2022-12-14 19:19:36 | cashapp__redwood-631 | diff --git a/redwood-layout-composeui/build.gradle b/redwood-layout-composeui/build.gradle
index 9a387d8c1..2ce7657b4 100644
--- a/redwood-layout-composeui/build.gradle
+++ b/redwood-layout-composeui/build.gradle
@@ -8,7 +8,7 @@ apply plugin: 'com.vanniktech.maven.publish'
apply plugin: 'org.jetbrains.dokka' // Must b... | Move all core artifacts to the root
This works around a bug in Kotlin/JS in that it uses the project name rather than something we can control such as `archivesBaseName`. We aren't hitting the bug currently, but a forthcoming change will. Fixing it separately to keep this change and that change small. | **Title**
Move core Redwood layout and lazy‑layout artifacts to top‑level modules
**Problem**
The project currently publishes layout‑related artifacts under nested module paths, causing Kotlin/JS to derive its coordinates from the project name. This will soon break publishing when Kotlin/JS expects a controllabl... | 631 | cashapp/redwood | diff --git a/redwood-layout-shared-test/build.gradle b/redwood-layout-shared-test/build.gradle
index 74cdaba40..1c2f2c3b0 100644
--- a/redwood-layout-shared-test/build.gradle
+++ b/redwood-layout-shared-test/build.gradle
@@ -4,7 +4,7 @@ apply plugin: 'org.jetbrains.kotlin.android'
dependencies {
api projects.redwoo... | [
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_direction_column_flexShrinkSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_directionRow_fixedSizeViewAndShrinkable_doNotExceedMaxMainSize[jvm] (app.cash.r... | [] | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 12,
"num_modified_lines": 17,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.84,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": true,
... | |
4a0a93b002b989295c0663d2aaf798b27dbfe985 | 2022-12-16 19:57:05 | JakeWharton: This side is mostly boring but was easier. There's a symmetric change to the consuming side which is much more interesting as it should allow divorcing the creation of the diff-consuming wrapper (one per code load) from creation of the native widget factory (effectively a singleton) meaning we can eliminat... | cashapp__redwood-644 | diff --git a/redwood-protocol-compose/src/commonMain/kotlin/app/cash/redwood/protocol/compose/DiffProducingWidget.kt b/redwood-protocol-compose/src/commonMain/kotlin/app/cash/redwood/protocol/compose/DiffProducingWidget.kt
index 1fc650428..3fdc828a5 100644
--- a/redwood-protocol-compose/src/commonMain/kotlin/app/cash/r... | Expose only a minimal bridge type for diff-producing codegen
This reduces the generated API surface to something that hides 100% of the factory and widget types. Instead, a `ProtocolBridge` subtype is exposed with its companion acting as a factory. | **Title**
Expose a minimal `ProtocolBridge` interface for diff‑producing codegen
**Problem**
The public API for diff‑producing widgets exposed the full concrete bridge class and a nested `Provider` interface, leaking internal implementation details and inflating the API surface. This tight coupling made generate... | 644 | cashapp/redwood | diff --git a/redwood-protocol-compose/src/commonTest/kotlin/app/cash/redwood/protocol/compose/DiffProducingWidgetFactoryTest.kt b/redwood-protocol-compose/src/commonTest/kotlin/app/cash/redwood/protocol/compose/DiffProducingWidgetFactoryTest.kt
index 595cf0717..148e2eb8a 100644
--- a/redwood-protocol-compose/src/common... | [
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_direction_column_flexShrinkSet[jvm] (app.cash.redwood.flexbox.FlexContainerTest)",
"testDetermineMainSize_directionRow_fixedSizeViewAndShrinkable_doNotExceedMaxMainSize[jvm] (app.cash.r... | [] | Method: ProtocolBridge.createDiffOrNull(self)
Location: Interface `app.cash.redwood.protocol.compose.ProtocolBridge`
Inputs: *none*
Outputs: `Diff?` – returns a `Diff` containing all accumulated widget‐tree changes since the previous call, or `null` if there were no changes.
Description: Used by composition cod... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 13,
"num_modified_lines": 244,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
4ef8240341fa02d79376c3ee338f7b4bcbec0d34 | 2023-01-30 07:23:38 | cashapp__redwood-759 | diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index e6960b6a0..1e21ea914 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -22,14 +22,9 @@ jobs:
distribution: 'zulu'
java-version: 19
- # For cinterop issues. Remove with Kotlin 1.8.
- ... | Update to Kotlin 1.8.
Updates Redwood to Kotlin 1.8. Resolves: https://github.com/cashapp/redwood/issues/701
This works around https://github.com/Kotlin/kotlinx.serialization/issues/1454 by only running either the redwood or zipline plugin in each module (not both). | **Title**
Upgrade project to Kotlin 1.8 and align tooling, dependencies, and APIs
**Problem**
The codebase was built against Kotlin 1.7 and relied on internal Compose APIs and older schema abstractions, causing compilation and runtime failures after moving to Kotlin 1.8. Additionally, CI steps and Android test con... | 759 | cashapp/redwood | diff --git a/redwood-gradle-plugin/src/test/fixture/compose-ui/gradle.properties b/redwood-gradle-plugin/src/test/fixture/compose-ui/gradle.properties
index fa5642925..7853c51dc 100644
--- a/redwood-gradle-plugin/src/test/fixture/compose-ui/gradle.properties
+++ b/redwood-gradle-plugin/src/test/fixture/compose-ui/gradl... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: SchemaSet.schema
Location: Interface app.cash.redwood.tooling.schema.SchemaSet
Inputs: None (property getter)
Outputs: Returns the primary Schema instance contained in the set.
Description: Provides access to the main schema when working with a SchemaSet, used by the code generator and tests to obtain the concr... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 39,
"num_modified_lines": 372,
"pr_author": "colinrtwhite",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.86,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
... | |
d08de06357868890433e7c99eb81825099b29dd4 | 2023-02-02 23:49:58 | cashapp__redwood-787 | diff --git a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
index ef4b70e48..d2348546a 100644
--- a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
+++ b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/Genera... | Generate testing APIs | **Title**
Add generation of Redwood testing APIs
**Problem**
Redwood’s code generation did not produce the utilities required for UI‑testing, such as testers, mutable widget factories, and widget value types. Consequently, developers could not rely on generated test helpers when writing tests for schemas.
**Roo... | 787 | cashapp/redwood | diff --git a/redwood-compose-testing/build.gradle b/redwood-compose-testing/build.gradle
index 0707788ff..2c76a6a6d 100644
--- a/redwood-compose-testing/build.gradle
+++ b/redwood-compose-testing/build.gradle
@@ -11,12 +11,16 @@ kotlin {
commonMain {
dependencies {
api libs.jetbrains.compose.runtim... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Interface: WidgetValue
Location: app.cash.redwood.compose.testing.WidgetValue
Inputs:
- layoutModifiers: LayoutModifier – the widget’s layout modifier (default provided by implementations).
- childrenLists: List<List<WidgetValue>> – direct children grouped by slot; default implementation returns an empty list.
Out... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 9,
"num_modified_lines": 60,
"pr_author": "swankjesse",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B... | |
9e6a50174dc6a87c3df18ebcc5c068bcfc257dae | 2023-02-07 02:41:24 | cashapp__redwood-797 | diff --git a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
index d2348546a..5c119ff33 100644
--- a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
+++ b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/Genera... | Embed representation of schema as JSON in jar
This will allow us to perform codegen without needing to parse anything. This will become essential in the future when we switch to AST-based parsing.
Note, nothing is actually switched yet. This just generates the JSON as a first step.
<details>
<summary>Sample of t... | **Title**
Add JSON embedding of Redwood schema and Gradle support
**Problem**
Schema‑based code generation currently requires parsing the Kotlin source at each run, which hinders future AST‑based processing. There is no way to package a pre‑generated, machine‑readable representation of the schema alongside the c... | 797 | cashapp/redwood | diff --git a/test-schema/build.gradle b/test-schema/build.gradle
index 1d47e7540..c82679c0e 100644
--- a/test-schema/build.gradle
+++ b/test-schema/build.gradle
@@ -1,6 +1,10 @@
apply plugin: 'org.jetbrains.kotlin.jvm'
+apply plugin: 'app.cash.redwood.schema'
dependencies {
- implementation projects.redwoodSchema
... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: RedwoodSchemaExtension.type(self, value: String)
Location: test-schema/build.gradle (redwoodSchema { type = … } block)
Inputs: Fully‑qualified name of the `@Schema`‑annotated interface to embed (e.g., `example.redwood.ExampleSchema`).
Outputs: Sets the `type` Property<String> on the extension; no direct return ... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 12,
"num_modified_lines": 415,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
cae4d348642011aa60ad21b3aec4ae9e300c1fd9 | 2023-02-07 20:32:04 | cashapp__redwood-801 | diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 034c881fc..e6960b6a0 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -31,7 +31,9 @@ jobs:
- run: ./gradlew build dokkaHtmlMultiModule --parallel -PredwoodNoSamples
+ # If we're on the integrati... | Use `FqType` in `Schema`
No more `KClass` or `KType`. This also fixes a bunch of places where we didn't support nested types.
Refs #19 | **Title**
Replace reflection‑based type representations with a fully qualified type model in the schema tooling
**Problem**
The schema definitions and code‑generation utilities relied on Kotlin reflection types (`KClass`, `KType`). This prevented correct handling of nested classes, generic variance, star projectio... | 801 | cashapp/redwood | diff --git a/redwood-protocol-compose/src/commonTest/kotlin/app/cash/redwood/protocol/compose/DiffAwaitingFrameClock.kt b/redwood-protocol-compose/src/commonTest/kotlin/app/cash/redwood/protocol/compose/DiffAwaitingFrameClock.kt
new file mode 100644
index 000000000..1436a26ef
--- /dev/null
+++ b/redwood-protocol-compos... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: DiffAwaitingFrameClock.awaitDiff(timeout: Duration = 2.seconds): Diff
Location: redwood-protocol-compose/src/commonTest/kotlin/app/cash/redwood/protocol/compose/DiffAwaitingFrameClock.kt
Inputs: timeout – optional duration, defaults to 2 seconds; used to bound how long the call will wait for a Diff.
Outputs: Re... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 13,
"num_modified_lines": 297,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e9e0ef83a4bb43f1b91cf142a2ce5f1116e4b756 | 2023-02-09 04:21:45 | cashapp__redwood-814 | diff --git a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
index 5c119ff33..d37a93f53 100644
--- a/redwood-cli/src/main/kotlin/app/cash/redwood/cli/GenerateCommand.kt
+++ b/redwood-cli/src/main/kotlin/app/cash/redwood/cli/Genera... | Do not embed dependencies as full schemas
Instead we only reference the `FqType`, and expose a new type to return a schema and its dependencies.
Next step is to read dependencies from JSON rather than reflection.
Refs #19 | **Title**
Replace embedded dependency schemas with reference‑based schema sets
**Problem**
Code generation previously required full dependent schemas to be embedded, leading to unnecessary duplication and reliance on reflection. This made schema handling heavyweight and error‑prone.
**Root Cause**
Schema defini... | 814 | cashapp/redwood | diff --git a/redwood-tooling-codegen/src/main/kotlin/app/cash/redwood/tooling/codegen/testingGeneration.kt b/redwood-tooling-codegen/src/main/kotlin/app/cash/redwood/tooling/codegen/testingGeneration.kt
index eb58577a9..c6cda4114 100644
--- a/redwood-tooling-codegen/src/main/kotlin/app/cash/redwood/tooling/codegen/test... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: parseSchema(schemaType: KClass<*>): SchemaSet
Location: redwood-tooling-schema/src/main/kotlin/app/cash/redwood/tooling/schema/schemaParser.kt
Inputs:
- schemaType: KClass<*> – Kotlin class annotated with @Schema that defines a Redwood schema.
Outputs:
- SchemaSet – an object exposing the parsed Schema via .s... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 11,
"num_modified_lines": 108,
"pr_author": "JakeWharton",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e7447941d3853f00e93f0ab93651bee1462852a3 | 2023-03-01 12:18:32 | cashapp__redwood-842 | diff --git a/redwood-layout-composeui/src/commonMain/kotlin/app/cash/redwood/layout/composeui/ComposeUiRedwoodLayoutWidgetFactory.kt b/redwood-layout-composeui/src/commonMain/kotlin/app/cash/redwood/layout/composeui/ComposeUiRedwoodLayoutWidgetFactory.kt
index 65709b8de..22ed6f742 100644
--- a/redwood-layout-composeui/... | Add support for Spacer to redwood-layout.
Adds support for a basic `Spacer` class to `redwood-layout`. The motivation for this is to support cases when we want to add space in between two items in a list, but want to avoid using the `padding` modifier as hiding the item it's attached to will also hide the padding. The ... | **Title**
Add a first‑class Spacer widget to the Redwood layout system
**Problem**
Developers need a way to insert empty space between layout children without relying on padding, which is hidden when the attached child’s visibility changes. The layout API currently lacks a dedicated Spacer component.
**Root C... | 842 | cashapp/redwood | diff --git a/redwood-layout-composeui/src/androidInstrumentedTest/kotlin/app/cash/redwood/layout/composeui/ComposeUiSpacerTest.kt b/redwood-layout-composeui/src/androidInstrumentedTest/kotlin/app/cash/redwood/layout/composeui/ComposeUiSpacerTest.kt
new file mode 100644
index 000000000..6ee93be57
--- /dev/null
+++ b/red... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: RedwoodLayoutWidgetFactory.Spacer(self)
Location: RedwoodLayoutWidgetFactory\<T\> (generic layout widget factory)
Inputs: none
Outputs: Spacer\<T\> – creates a platform‑specific spacer widget that can be sized and placed within a layout.
Description: New factory method added to expose the Spacer widget for ... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 16,
"num_modified_lines": 296,
"pr_author": "colinrtwhite",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e4cc821b6d6d5f3755f72cb5e1201ac208d4048e | 2023-03-17 21:14:53 | cashapp__redwood-858 | diff --git a/redwood-treehouse-composeui/src/commonMain/kotlin/app/cash/redwood/treehouse/composeui/TreehouseContent.kt b/redwood-treehouse-composeui/src/commonMain/kotlin/app/cash/redwood/treehouse/composeui/TreehouseContent.kt
index cac1c1864..8da69caae 100644
--- a/redwood-treehouse-composeui/src/commonMain/kotlin/a... | New Content interface and implementation
This is a major step towards breaking the dependency from TreehouseView onto Zipline etc.
With this change TreehouseView no longer knows about TreehouseApp, and no longer needs a renderTo() call.
I'm not particularly happy with the 'readyForContent' variable name or the Re... | **Title**
Introduce a decoupled Content model and ready‑for‑content lifecycle handling
**Problem**
`TreehouseView` was tightly coupled to `TreehouseApp`, exposing a content source and a state‑change listener that required the app to call `renderTo()` on every view. This made view lifecycle management fragile and f... | 858 | cashapp/redwood | diff --git a/redwood-treehouse-host/src/androidInstrumentedTest/kotlin/app/cash/redwood/treehouse/TreehouseWidgetViewTest.kt b/redwood-treehouse-host/src/androidInstrumentedTest/kotlin/app/cash/redwood/treehouse/TreehouseWidgetViewTest.kt
index 3b0b6b818..15a4e8529 100644
--- a/redwood-treehouse-host/src/androidInstrum... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Method: TreehouseView.ReadyForContentChangeListener.onReadyForContentChanged(view: TreehouseView<Nothing>)
Location: app.cash.redwood.treehouse.TreehouseView (TreehouseView.kt)
Inputs: *view* – the TreehouseView whose `readyForContent` state has just changed; generic type may be any `AppService` (tests use `Nothing... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 13,
"num_modified_lines": 271,
"pr_author": "swankjesse",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
791843ecd06dfa07561354fe032def9323b5e447 | 2023-03-18 04:01:16 | cashapp__redwood-859 | diff --git a/redwood-treehouse-composeui/src/commonMain/kotlin/app/cash/redwood/treehouse/composeui/TreehouseContent.kt b/redwood-treehouse-composeui/src/commonMain/kotlin/app/cash/redwood/treehouse/composeui/TreehouseContent.kt
index 8da69caae..c5314697d 100644
--- a/redwood-treehouse-composeui/src/commonMain/kotlin/a... | Drop type parameters on TreehouseView and WidgetSystem
These are no longer necessary. | **Title**
Remove unnecessary type parameters from TreehouseView and related interfaces
**Problem**
`TreehouseView` and its nested interfaces were generic over the app service type even though the type parameter was never leveraged for safety or behavior. This added undue complexity to the API surface across the pr... | 859 | cashapp/redwood | diff --git a/redwood-treehouse-host/src/androidInstrumentedTest/kotlin/app/cash/redwood/treehouse/TreehouseWidgetViewTest.kt b/redwood-treehouse-host/src/androidInstrumentedTest/kotlin/app/cash/redwood/treehouse/TreehouseWidgetViewTest.kt
index 15a4e8529..7e080cb74 100644
--- a/redwood-treehouse-host/src/androidInstrum... | [
"flattenNoHierarchy[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenSiblingSubtreeFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"flattenParentsFirst[jvm] (app.cash.redwood.compose.testing.WidgetValueTest)",
"testDetermineMainSize_direction_column_flexGrowSet[jvm] (app.cash.... | [] | Function: widgetFactory(app: TreehouseApp<*>, json: Json, protocolMismatchHandler: ProtocolMismatchHandler): DiffConsumingNode.Factory<*>
Location: app.cash.redwood.treehouse.TreehouseView.WidgetSystem
Inputs:
• app – the TreehouseApp whose services are used to create the widget factory; type is TreehouseApp<*>, allo... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"echo \"sdk.dir=/opt/android-sdk\" > local.properties"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew jvmTest --no-daemon --console=plain -PredwoodNoSamples && find . -name '*.xml' -path '*/test-results/*' -exec cat {} +"
} | {
"num_modified_files": 19,
"num_modified_lines": 64,
"pr_author": "swankjesse",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
8be6a22419838fe96bb2364fc782bcef8c5b4021 | 2024-03-08 00:22:34 | jraska: Thanks for the contribution 👍 | jraska__modules-graph-assert-251 | diff --git a/build.gradle b/build.gradle
index f9d8a33..51df018 100644
--- a/build.gradle
+++ b/build.gradle
@@ -16,6 +16,6 @@ allprojects {
}
}
-task clean(type: Delete) {
- delete rootProject.buildDir
+tasks.register('clean', Delete) { Delete _ ->
+ delete rootProject.layout.buildDirectory
}
diff --git a/gra... | Fix various inconsistencies and a build error
I fixed a typo, some inconsistencies with final newlines, a Gradle task configuration optimization and a Gradle deprecation warning. I also fixed a build error (inconsistent JVM-target compatibility) | **Title**
Align Gradle configuration and fix API configuration constant typo
**Problem**
The build suffered from a misspelled constant used for API configuration detection, outdated task registration syntax, and mismatched JVM target settings that produced a compilation error and Gradle deprecation warnings.
... | 251 | jraska/modules-graph-assert | diff --git a/plugin/src/test/kotlin/com/jraska/module/graph/assertion/GradleDependencyGraphFactorySingleModuleProjectTest.kt b/plugin/src/test/kotlin/com/jraska/module/graph/assertion/GradleDependencyGraphFactorySingleModuleProjectTest.kt
index 7e46c30..820bc6b 100644
--- a/plugin/src/test/kotlin/com/jraska/module/grap... | [
"printsBothCorrectStatistics (com.jraska.module.graph.assertion.FullProjectMultipleAppliedGradleTest)",
"generatesProperGraph (com.jraska.module.graph.assertion.GradleDependencyGraphFactoryTest)",
"generatesWithTestImplementatinoGraph (com.jraska.module.graph.assertion.GradleDependencyGraphFactoryTest)",
"gen... | [] | Method: Api.API_IMPLEMENTATION_CONFIGURATIONS
Location: object Api (plugin/src/main/kotlin/com/jraska/module/graph/assertion/Api.kt)
Inputs: *none* (constant)
Outputs: Set<String> – a constant set containing the strings `"api"` and `"implementation"`.
Description: Exposes the default configuration names that are treate... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-21",
"install": [
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew plugin:cleanTest plugin:test --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*' ... | {
"num_modified_files": 6,
"num_modified_lines": 11,
"pr_author": "IsakTheHacker",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
... |
a99a276a68092d762146e30d6a6508268f782326 | 2024-07-23 15:03:36 | jraska__modules-graph-assert-264 | diff --git a/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt b/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt
index 3a6275b..5edd981 100644
--- a/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt
+++ b/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt... | Detect cycles when creating subgraphs
- Related to https://github.com/jraska/modules-graph-assert/issues/257 | **Title**
Add cycle detection for subgraph creation
**Problem**
Creating a subgraph of module dependencies could enter an infinite recursive loop when the underlying graph contains a cycle. This results in stack overflow and crashes during graph analysis.
**Root Cause**
The recursive traversal that collects dep... | 264 | jraska/modules-graph-assert | diff --git a/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt b/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt
index 356c15d..048a3d2 100644
--- a/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt
+++ b/plugin/src/test/kotl... | [
"correctHeightIsMaintained (com.jraska.module.graph.DependencyGraphTest)",
"detectsSingleNodeCycle (com.jraska.module.graph.DependencyGraphTest)",
"subtreeOfLeafModuleIsNotEmpty (com.jraska.module.graph.DependencyGraphTest)",
"detectsThreeNodesCycle (com.jraska.module.graph.DependencyGraphTest)",
"countsSta... | [] | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "kotlin-jdk-21",
"install": [
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew plugin:cleanTest plugin:test --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*' ... | {
"num_modified_files": 1,
"num_modified_lines": 17,
"pr_author": "jraska",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6": ... | |
abc7391c3e6f41b9001f4d2a7df4eb60980a69d0 | 2024-07-23 15:35:34 | jraska__modules-graph-assert-265 | diff --git a/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt b/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt
index 5edd981..2426a81 100644
--- a/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt
+++ b/plugin/src/main/kotlin/com/jraska/module/graph/DependencyGraph.kt... | Calculating subgraph to O(V+E) complexity
- Previous complexity O(V<sup>V</sup>)
- Current complexity O(V+E)
- _One would say this is too obvious... to easy to forget._ 🙈 | **Title**
Linear‑time subgraph calculation for dependency graphs
**Problem**
Generating a subgraph of module dependencies could take exponential time, making large projects impractically slow. The existing traversal also risked revisiting the same nodes repeatedly.
**Root Cause**
The recursive walk did not ... | 265 | jraska/modules-graph-assert | diff --git a/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt b/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt
index 048a3d2..d90c71a 100644
--- a/plugin/src/test/kotlin/com/jraska/module/graph/DependencyGraphPerformanceTest.kt
+++ b/plugin/src/test/kotl... | [
"printsBothCorrectStatistics (com.jraska.module.graph.assertion.FullProjectMultipleAppliedGradleTest)",
"correctHeightIsMaintained (com.jraska.module.graph.DependencyGraphTest)",
"detectsSingleNodeCycle (com.jraska.module.graph.DependencyGraphTest)",
"subtreeOfLeafModuleIsNotEmpty (com.jraska.module.graph.Dep... | [] | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "kotlin-jdk-21",
"install": [
"./gradlew clean build --no-daemon --console=plain --info -x test 2>&1 | tail -n 50"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew plugin:cleanTest plugin:test --no-daemon --console=plain && find . -name '*.xml' -path '*/test-results/*' ... | {
"num_modified_files": 1,
"num_modified_lines": 12,
"pr_author": "jraska",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... | |
b6017e5fa881f51cb866cb9dbbbaa012b1340a0f | 2020-04-04 16:43:35 | julioz__floorplan-10 | diff --git a/src/main/kotlin/com/zynger/floorplan/dbml/Reference.kt b/src/main/kotlin/com/zynger/floorplan/dbml/Reference.kt
index 4e40373..f8b12f2 100644
--- a/src/main/kotlin/com/zynger/floorplan/dbml/Reference.kt
+++ b/src/main/kotlin/com/zynger/floorplan/dbml/Reference.kt
@@ -1,6 +1,7 @@
package com.zynger.floorpl... | Define foreign key referential actions
According to DBML's spec: https://www.dbml.org/docs/#relationship-settings | **Title**
Add proper foreign‑key referential actions to DBML generation
**Problem**
The DBML output omitted the delete and update actions defined on foreign keys, so the generated schema did not fully comply with the DBML specification.
**Root Cause**
Foreign‑key actions were stored as plain strings and the... | 10 | julioz/FloorPlan | diff --git a/src/test/kotlin/com/zynger/floorplan/dbml/ReferenceTest.kt b/src/test/kotlin/com/zynger/floorplan/dbml/ReferenceTest.kt
index a9efcad..bfdc7cc 100644
--- a/src/test/kotlin/com/zynger/floorplan/dbml/ReferenceTest.kt
+++ b/src/test/kotlin/com/zynger/floorplan/dbml/ReferenceTest.kt
@@ -1,6 +1,7 @@
package co... | [
"list single column index (com.zynger.floorplan.dbml.IndexTest)",
"lists multiple column index (com.zynger.floorplan.dbml.IndexTest)",
"adds uniqueness note when index is unique (com.zynger.floorplan.dbml.IndexTest)",
"do not support home directory expansion for explicit user names (com.zynger.floorplan.Input... | [] | Method: Reference.toString(self)
Location: src/main/kotlin/com/zynger/floorplan/dbml/Reference.kt
Inputs: None
Outputs: String – a DBML‑formatted representation of the reference that includes the delete and update actions inside brackets (e.g., `[delete: no action, update: no action]`).
Description: Returns a f... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 3,
"num_modified_lines": 55,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6": ... | |
8d7a388dabfc58ca1e92cfd3a0dbe5d15cdd5de0 | 2020-05-19 13:00:01 | julioz__floorplan-21 | diff --git a/dbml-parser/build.gradle b/dbml-parser/build.gradle
new file mode 100644
index 0000000..ce06f61
--- /dev/null
+++ b/dbml-parser/build.gradle
@@ -0,0 +1,23 @@
+plugins {
+ id 'java'
+ id 'org.jetbrains.kotlin.jvm'
+}
+
+sourceCompatibility = 1.8
+
+repositories {
+ mavenCentral()
+ jcenter()
+}
... | Add dbml parser module
Adds module to allow for creating an in-memory model of DBML schemas.
To be done separately:
- Add support for Index parsing (currently hack in place)
- Parse column default values
- Include table aliases and table notes in modeling
- Pull out DBML modeling classes into shared module that ... | **Title**
Introduce a DBML parsing module to construct an in‑memory representation of schemas
**Problem**
The project had no component capable of interpreting DBML text and turning it into usable model objects. Consequently, downstream tools could not reason about tables, columns, indexes, or relationships defin... | 21 | julioz/FloorPlan | diff --git a/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt b/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt
new file mode 100644
index 0000000..8cd040d
--- /dev/null
+++ b/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt
@@ -0,0 +1,171 @@
+pac... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserTest)",
"no tables (com.zynger.floorplan.lex.TableParserTest)",
"ignores indexes (com.zynger.floorplan.lex.TableParserTest)",
"passes column content to be parsed by delegat... | [
"list single column index (com.zynger.floorplan.dbml.IndexTest)",
"lists multiple column index (com.zynger.floorplan.dbml.IndexTest)",
"adds uniqueness note when index is unique (com.zynger.floorplan.dbml.IndexTest)",
"non-primary key with default value gets rendered with default note even if it is an empty s... | Method: ColumnParser.parseColumns(tableName: String, columnsInput: String)
Location: com.zynger.floorplan.lex.ColumnParser
Inputs:
- tableName – the name of the table to which the columns belong (String).
- columnsInput – raw DBML text containing column definitions, typically the content inside a table’s curly brace... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 12,
"num_modified_lines": 234,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
550451b9752b6a4115d93011b351262d1afeaa88 | 2020-05-20 15:53:37 | julioz__floorplan-26 | diff --git a/core/build.gradle b/core/build.gradle
index aca9717..5965844 100644
--- a/core/build.gradle
+++ b/core/build.gradle
@@ -12,6 +12,7 @@ repositories {
}
dependencies {
+ implementation project(":room-consumer") // TODO to be removed https://github.com/julioz/FloorPlan/issues/25
implementation "or... | Pull out Room and DBML models into modules
- The `:floorplan-cli` module now depends directly on `:room-consumer`, but the goal is that eventually that becomes ['consumer-agnostic'](https://github.com/julioz/FloorPlan/issues/19).
- There is a new `:dbml` module that is home for the DBML representations in Kotlin. Th... | **Title**
Modularize model definitions by extracting DBML and Room consumer components into their own modules
**Problem**
The project’s core module mixed DBML representations with Room‑specific schema models, creating tight coupling and preventing the CLI from being consumer‑agnostic. This made it difficult to s... | 26 | julioz/FloorPlan | diff --git a/core/src/test/kotlin/com/zynger/floorplan/dbml/FieldTest.kt b/core/src/test/kotlin/com/zynger/floorplan/dbml/FieldTest.kt
index fb3b4ca..ca7c931 100644
--- a/core/src/test/kotlin/com/zynger/floorplan/dbml/FieldTest.kt
+++ b/core/src/test/kotlin/com/zynger/floorplan/dbml/FieldTest.kt
@@ -1,9 +1,9 @@
packag... | [
"list single column index (com.zynger.floorplan.dbml.IndexTest)",
"lists multiple column index (com.zynger.floorplan.dbml.IndexTest)",
"adds uniqueness note when index is unique (com.zynger.floorplan.dbml.IndexTest)",
"non-primary key with default value gets rendered with default note even if it is an empty s... | [] | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 31,
"num_modified_lines": 115,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
09eb6d4d3f71e2588ab4e4016588ff54be635ac3 | 2020-05-27 09:13:26 | julioz__floorplan-29 | diff --git a/floorplan-cli/src/main/kotlin/com/zynger/floorplan/App.kt b/floorplan-cli/src/main/kotlin/com/zynger/floorplan/App.kt
index a4cc7d0..df17ae4 100644
--- a/floorplan-cli/src/main/kotlin/com/zynger/floorplan/App.kt
+++ b/floorplan-cli/src/main/kotlin/com/zynger/floorplan/App.kt
@@ -3,6 +3,7 @@ package com.zyn... | Add command line argument to define output format
Adds `--format=<format_definition>` to the command line input argument parser to allow for one of:
```
gradle run --args=<path_to_schema> --format=dbml
gradle run --args=<path_to_schema> --format=svg
gradle run --args=<path_to_schema> --format=png
gradle run --args... | **Title**
Add configurable output format via `--format` CLI flag
**Problem**
The tool always generated DBML output, offering no way to select other supported renderings (SVG, PNG, DOT). Consequently, users could not produce visual diagrams directly from the CLI and had to rely on post‑processing.
**Root Cause... | 29 | julioz/FloorPlan | diff --git a/floorplan-cli/src/test/kotlin/com/zynger/floorplan/InputParserTest.kt b/floorplan-cli/src/test/kotlin/com/zynger/floorplan/InputParserTest.kt
index 4350152..c38b0ab 100644
--- a/floorplan-cli/src/test/kotlin/com/zynger/floorplan/InputParserTest.kt
+++ b/floorplan-cli/src/test/kotlin/com/zynger/floorplan/In... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserTest)",
"no tables (com.zynger.floorplan.lex.TableParserTest)",
"ignores indexes (com.zynger.floorplan.lex.TableParserTest)",
"passes column content to be parsed by delegat... | [] | Method: InputParser.parse(args: Array<String>) → Input
Location: floorplan-cli/src/main/kotlin/com/zynger/floorplan/InputParser.kt
Inputs:
- args: Array<String> – the raw command‑line arguments passed to the program (must contain at least the schema path).
Outputs:
- Input – a data‑class instance containing the parse... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 3,
"num_modified_lines": 583,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6":... | |
20013135eae357635620c27c7a4e7db416586ba0 | 2020-06-04 13:02:57 | julioz__floorplan-31 | diff --git a/.gitignore b/.gitignore
index 2a36be0..1dff827 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,7 @@ samples/**
# Gradle
.idea/**/gradle.xml
.idea/**/libraries
+local.properties
# Gradle and Maven with auto-import
# When using Gradle or Maven with auto-import, you should exclude module files,
d... | WIP: FloorPlan gradle plugin
Adds Gradle Plugin implementation, with initial integration tests, sample project for manual end to end test and updates documentation.
```
floorPlan {
schemaLocation = "$projectDir/schemas-dir".toString()
outputLocation = "$projectDir/output-dir".toString()
outputFormat ... | **Add Gradle plugin implementation, documentation, and sample project**
**Problem**
The repository lacked a published Gradle plugin for FloorPlan, making it difficult for users to integrate the tool into their builds. Documentation and guidance for using the plugin were also missing, and there was no example project... | 31 | julioz/FloorPlan | diff --git a/docs/tests.md b/docs/tests.md
deleted file mode 100644
index 92ddb2d..0000000
--- a/docs/tests.md
+++ /dev/null
@@ -1,7 +0,0 @@
-# Tests
-
-The project is unit tested. These can be run via Gradle with:
-```
-gradlew test
-```
-
diff --git a/floorplan-gradle-plugin/src/test/kotlin/com/zynger/floorplan/Floor... | [
"testMultipleEnabledOutputFormatFailsBuild (com.zynger.floorplan.FloorPlanGradlePluginIntegrationTest)",
"testMultipleOutputFormatButSingleEnabled (com.zynger.floorplan.FloorPlanGradlePluginIntegrationTest)",
"testMissingOutputLocationFailsBuild (com.zynger.floorplan.FloorPlanGradlePluginIntegrationTest)",
"t... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserTest)",
"no tables (com.zynger.floorplan.lex.TableParserTest)",
"ignores indexes (com.zynger.floorplan.lex.TableParserTest)",
"passes column content to be parsed by delegat... | Method: FloorPlanExtension.schemaLocation: Property<String>
Location: com.zynger.floorplan.gradle.extension.FloorPlanExtension
Inputs: None (property holder)
Outputs: Property<String> – Gradle property representing the path to the schema directory; must be present for the plugin to run.
Description: Holds the configura... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 22,
"num_modified_lines": 2170,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
d93a4999e52e204d27a200428d2cf355e25f033b | 2020-06-07 13:54:04 | julioz__floorplan-37 | diff --git a/floorplan-gradle-plugin/src/main/kotlin/com/zynger/floorplan/gradle/FloorPlanTask.kt b/floorplan-gradle-plugin/src/main/kotlin/com/zynger/floorplan/gradle/FloorPlanTask.kt
index c69d97b..35fba55 100644
--- a/floorplan-gradle-plugin/src/main/kotlin/com/zynger/floorplan/gradle/FloorPlanTask.kt
+++ b/floorpla... | Gradle Plugin: Preserve directory structure
Fixes https://github.com/julioz/FloorPlan/issues/33
Room's directory structure when generating DB schemas adds the database definition package name and database name to a parent directory to prevent name clashes and conflicts.
Here we move the schemas from our sample an... | **Title**
Preserve schema directory hierarchy when generating FloorPlan output
**Problem**
Output files were always written to the root of the configured output directory, ignoring the original sub‑directory layout of Room schema files. This could cause naming conflicts and broke the expectation that generated a... | 37 | julioz/FloorPlan | diff --git a/floorplan-gradle-plugin/src/test/kotlin/com/zynger/floorplan/gradle/OutputParameterHandlerTest.kt b/floorplan-gradle-plugin/src/test/kotlin/com/zynger/floorplan/gradle/OutputParameterHandlerTest.kt
new file mode 100644
index 0000000..b18afb6
--- /dev/null
+++ b/floorplan-gradle-plugin/src/test/kotlin/com/z... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserTest)",
"no tables (com.zynger.floorplan.lex.TableParserTest)",
"ignores indexes (com.zynger.floorplan.lex.TableParserTest)",
"passes column content to be parsed by delegat... | [] | Method: OutputParameterHandler.format(outputFormat: OutputFormat) → Format
Location: com.zynger.floorplan.gradle.OutputParameterHandler.format
Inputs:
- outputFormat: OutputFormat – a sealed‑class describing the desired output (DBML with a Gradle‑plugin‑specific DbmlConfiguration, SVG, PNG, or DOT).
Outputs:
- Return... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 2,
"num_modified_lines": 52,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... | |
c1c1db07a2b939df93509ec8f6eb10bba64342d9 | 2020-06-19 14:05:03 | julioz__floorplan-40 | diff --git a/consumer-sniffer/build.gradle b/consumer-sniffer/build.gradle
new file mode 100644
index 0000000..33d55ee
--- /dev/null
+++ b/consumer-sniffer/build.gradle
@@ -0,0 +1,25 @@
+plugins {
+ id 'java'
+ id 'org.jetbrains.kotlin.jvm'
+}
+
+sourceCompatibility = 1.8
+
+repositories {
+ mavenCentral()
+ ... | Add SQLite schema consumer
SQLDelight is a popular multiplatform ORM that is able to expose its schemas via a Gradle task. On #19, we discuss the possibility of ingesting them to generate ER diagrams similarly to how we do for Android's Room.
Interestingly, they export `.db` files, standard SQLite database definitio... | **Title**
Add generic schema consumer support and SQLite `.db` handling
**Problem**
FloorPlan only understood Room JSON schemas, preventing use of other ORM schema formats such as SQLDelight’s SQLite `.db` files. The CLI and Gradle task were hard‑wired to the Room consumer, limiting extensibility.
**Root Caus... | 40 | julioz/FloorPlan | diff --git a/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/IndexParserTest.kt b/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/IndexParserTest.kt
new file mode 100644
index 0000000..3a56153
--- /dev/null
+++ b/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/IndexParserTest.kt
@@ -0,0 +1,188 @@
+packag... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"passes index content to be parsed by delegation (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserTest)",
"no tables (com.zynger.floorplan.lex.TableParserTest)",
"passes column... | [] | Function: parseIndexes(indexContent: String)
Location: com.zynger.floorplan.lex.IndexParser (object)
Inputs:
- **indexContent**: `String` – a DBML fragment that may contain an `Indexes { … }` block. The block can list one or more index definitions, each with column list and optional properties such as `name:` and `uni... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 18,
"num_modified_lines": 374,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
864bd2c97f113b758048cb057d1c511420a8aaea | 2020-07-26 09:48:25 | julioz__floorplan-50 | diff --git a/dbml-parser/src/main/kotlin/com/zynger/floorplan/dbmlparser/CompositePrimaryKey.kt b/dbml-parser/src/main/kotlin/com/zynger/floorplan/dbmlparser/CompositePrimaryKey.kt
new file mode 100644
index 0000000..110228f
--- /dev/null
+++ b/dbml-parser/src/main/kotlin/com/zynger/floorplan/dbmlparser/CompositePrimar... | Parse composite primary keys indexes
Indexes allow users to quickly locate and access the data. Users can define single or multi-column indexes.
One can define a composite primary key (in DBML) via the `indexes` block:
```
Table bookings {
id integer
country varchar
booking_date date
created_at times... | **Title**
Support parsing of composite primary keys defined via index blocks
**Problem**
Composite primary keys defined in the `indexes` block were treated as ordinary indexes, so the involved columns were not marked as primary keys. This caused inaccurate schema representation and potential downstream errors. ... | 50 | julioz/FloorPlan | diff --git a/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt b/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt
index 54218f6..ad2899f 100644
--- a/dbml-parser/src/test/kotlin/com/zynger/floorplan/lex/ColumnParserTest.kt
+++ b/dbml-parser/src/test/kotlin/com/zynger/floor... | [
"parses name of table (com.zynger.floorplan.lex.TableParserTest)",
"passes index content to be parsed by delegation (com.zynger.floorplan.lex.TableParserTest)",
"parses name of table with quotes (com.zynger.floorplan.lex.TableParserTest)",
"parses name of multiple tables (com.zynger.floorplan.lex.TableParserT... | [] | Method: ColumnParser.parseColumns(tableName: String, columnsInput: String, compositePrimaryKeys: List<CompositePrimaryKey> = emptyList()): List<Column>
Location: com.zynger.floorplan.lex.ColumnParser
Inputs:
- **tableName** – name of the table the columns belong to.
- **columnsInput** – raw DBML text that defines th... | Apache-2.0 | {
"base_image_name": "kotlin-jdk-11",
"install": [
"sed -i '/include '\\''floorplan-intellij-plugin'\\''/d' settings.gradle"
],
"log_parser": "parse_log_gradlew_v1",
"test_cmd": "./gradlew clean test --no-daemon --console=plain --info && find . -name \"*.xml\" -path \"*/test-results/*\" -exec cat {} \\;"
... | {
"num_modified_files": 4,
"num_modified_lines": 35,
"pr_author": "julioz",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B6": f... | |
d52c4046c8f613e6173e0cf37508e45d5b5f9dbb | 2021-07-20 09:02:14 | k8s-ci-robot: [APPROVALNOTIFIER] This PR is **NOT APPROVED**
This pull-request has been approved by:
To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cecilerobertmichon** after the PR has been reviewed.
You can assign the PR to t... | kubernetes-sigs__cluster-api-provider-azure-1544 | diff --git a/api/v1alpha3/azureclusteridentity_conversion.go b/api/v1alpha3/azureclusteridentity_conversion.go
index ff2b30ea1..006909119 100644
--- a/api/v1alpha3/azureclusteridentity_conversion.go
+++ b/api/v1alpha3/azureclusteridentity_conversion.go
@@ -17,17 +17,12 @@ limitations under the License.
package v1alpha... | 🐛managedcluster/agentpool in non-terminal state should return error
<!-- If this is your first PR, welcome! Please make sure you read the [contributing guidelines](../CONTRIBUTING.md). -->
<!-- Please label this pull request according to what type of issue you are addressing (see ../CONTRIBUTING.md) -->
**What t... | **Title**
Treat non‑terminal provisioning states as errors and remove deprecated subnet name handling
**Problem**
* Updates to Azure resources (agent pools, managed clusters, etc.) were attempted while the resources were still provisioning, leading to silent failures and inconsistent state.
* The `subnetName` ... | 1,544 | kubernetes-sigs/cluster-api-provider-azure | diff --git a/api/v1alpha4/azurecluster_validation_test.go b/api/v1alpha4/azurecluster_validation_test.go
index 0ac8eb817..ba7edaffc 100644
--- a/api/v1alpha4/azurecluster_validation_test.go
+++ b/api/v1alpha4/azurecluster_validation_test.go
@@ -273,10 +273,13 @@ func TestNetworkSpecWithPreexistingVnetLackRequiredSubnet... | [
"TestResourceGroupDefault",
"TestResourceGroupDefault/don't_change_if_mismatched",
"TestResourceGroupDefault/default_empty_rg",
"TestVnetDefaults",
"TestVnetDefaults/resource_group_vnet_specified",
"TestVnetDefaults/custom_CIDR",
"TestVnetDefaults/IPv6_enabled",
"TestVnetDefaults/vnet_not_specified",
... | [] | Method: validateNodeOutboundLB(lb *LoadBalancerSpec, old *LoadBalancerSpec, apiserverLB LoadBalancerSpec, nodeSubnet SubnetSpec, fldPath *field.Path) field.ErrorList
Location: api/v1alpha4/azurecluster_validation.go
Inputs:
- lb *LoadBalancerSpec – the desired node outbound load balancer spec (may be nil).
- old *Lo... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -y -qq",
"apt-get install -y -qq golang",
"export HOME=/root",
"export GOCACHE=$HOME/.cache/go-build",
"mkdir -p $GOCACHE"
],
"log_parser": "parse_log_gotest",
"test_cmd": "go test ... | {
"num_modified_files": 44,
"num_modified_lines": 485,
"pr_author": "alexeldeib",
"pr_labels": [
"approved: Indicates a PR has been approved by an approver from all required OWNERS files.",
"area/provider/azure: Issues or PRs related to azure provider",
"cncf-cla: yes: Indicates the PR's author has ... |
5e6e99ee250d679a839f40d1d7e9ba784a5bb126 | 2022-08-02 22:11:14 | googleapis__google-cloud-go-6464 | diff --git a/bigquery/schema.go b/bigquery/schema.go
index aa9efe36e5..c35ac17f29 100644
--- a/bigquery/schema.go
+++ b/bigquery/schema.go
@@ -121,17 +121,38 @@ type FieldSchema struct {
//
// See the Precision field for additional guidance about valid values.
Scale int64
+
+ // DefaultValueExpression is used to ... | feat(bigquery): add preview support for default values | **Title**
Add support for default value expressions in BigQuery schema handling
**Problem**
Clients cannot specify or retrieve column default values via the Go client, limiting the ability to work with tables that define defaults. This omission also prevents previewing tables with default expressions accurately.... | 6,464 | googleapis/google-cloud-go | diff --git a/bigquery/schema_test.go b/bigquery/schema_test.go
index d69cbbd822..d3ca8f7fa7 100644
--- a/bigquery/schema_test.go
+++ b/bigquery/schema_test.go
@@ -320,6 +320,34 @@ func TestSchemaConversion(t *testing.T) {
},
},
},
+ {
+ // default values
+ bqSchema: &bq.TableSchema{
+ Fields: []*bq.... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: FieldSchema (struct) — new exported field
Location: type FieldSchema in bigquery/schema.go
Inputs: DefaultValueExpression string // SQL expression used as the column’s default value; valid for top‑level fields only.
Outputs: n/a (field added to struct)
Description: Adds a string field to FieldSchema tha... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 1,
"num_modified_lines": 38,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": ... | |
3b8bfb44a237fc0696e77a47c5a8305caa5ec64b | 2023-04-07 17:10:17 | googleapis__google-cloud-go-7706 | diff --git a/bigquery/dataset.go b/bigquery/dataset.go
index b2be93d9ba..03fba3963e 100644
--- a/bigquery/dataset.go
+++ b/bigquery/dataset.go
@@ -58,6 +58,10 @@ type DatasetMetadata struct {
// More information: https://cloud.google.com/bigquery/docs/reference/standard-sql/collation-concepts
DefaultCollation strin... | feat(bigquery): expose dataset MaxTimeTravelHours | **Title**
Expose MaxTimeTravelHours on BigQuery datasets
**Problem**
The Go client library did not provide any way to read or set a dataset’s maximum time‑travel window, preventing users from managing this retention setting through code.
**Root Cause**
The dataset metadata structures and their conversion lo... | 7,706 | googleapis/google-cloud-go | diff --git a/bigquery/dataset_integration_test.go b/bigquery/dataset_integration_test.go
index 91ec36c4bd..fad77bb49f 100644
--- a/bigquery/dataset_integration_test.go
+++ b/bigquery/dataset_integration_test.go
@@ -159,7 +159,7 @@ func TestIntegration_DatasetUpdateETags(t *testing.T) {
check(md3, "", "")
}
-func T... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: DatasetMetadata.MaxTimeTravelHours time.Duration
Location: type DatasetMetadata struct in package bigquery
Inputs: (field on a DatasetMetadata value) – no parameters
Outputs: time.Duration representing the maximum time‑travel window for tables in the dataset; the duration is stored in whole‑hour increments (rou... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 1,
"num_modified_lines": 19,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"size: s: Pull request size is small."
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
... | |
22a666c766fa4565ee120574709b345e7fc37c5f | 2023-04-07 17:56:35 | googleapis__google-cloud-go-7707 | diff --git a/bigquery/dataset.go b/bigquery/dataset.go
index 03fba3963e..2b8d5b9915 100644
--- a/bigquery/dataset.go
+++ b/bigquery/dataset.go
@@ -58,9 +58,9 @@ type DatasetMetadata struct {
// More information: https://cloud.google.com/bigquery/docs/reference/standard-sql/collation-concepts
DefaultCollation string... | refactor(bigquery): amend name for MaxTimeTravel on datasets
PR https://github.com/googleapis/google-cloud-go/pull/7706 submitted before the edit to shorten the name landed. This PR updates it. | **Title**
Rename dataset max‑time‑travel field to `MaxTimeTravel` for consistency.
**Problem**
The dataset metadata struct exposed a field named `MaxTimeTravelHours` while the underlying API uses a generic “max time travel” concept. This mismatch caused confusion and required callers to use an inaccurate name when... | 7,707 | googleapis/google-cloud-go | diff --git a/bigquery/dataset_integration_test.go b/bigquery/dataset_integration_test.go
index fad77bb49f..5d20f67311 100644
--- a/bigquery/dataset_integration_test.go
+++ b/bigquery/dataset_integration_test.go
@@ -173,7 +173,7 @@ func TestIntegration_DatasetUpdateDefaultExpirationAndMaxTimeTravel(t *testing.T
// Set... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: DatasetMetadata.MaxTimeTravel (field)
Location: package bigquery, type DatasetMetadata
Inputs: time.Duration representing the maximum time‑travel window (expressed in hours; zero value means unset)
Outputs: N/A – the field holds the value and is used by internal conversion methods (toBQ, bqToDatasetMetada... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 1,
"num_modified_lines": 8,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"automerge: Merge the pull request once unit tests and other checks pass.",
"size: s: Pull request size is small."
],
"llm_metadata": {
"code": "... | |
0e15a92857eb1e51b1f8adef6c18e809ef46e608 | 2022-11-01 21:39:44 | shollyman: > LGTM. But I think we might need to start some design doc or discussion around making the retry logic more configurable. Do we know of other client libraries that allow that to take some inspiration ?
There's some hooks we can consider such as https://pkg.go.dev/github.com/googleapis/gax-go/v2#WithRetry
... | googleapis__google-cloud-go-6976 | diff --git a/bigquery/bigquery.go b/bigquery/bigquery.go
index 9b47357222..8bb92ba683 100644
--- a/bigquery/bigquery.go
+++ b/bigquery/bigquery.go
@@ -203,12 +203,16 @@ func runWithRetryExplicit(ctx context.Context, call func() error, allowedReasons
var (
defaultRetryReasons = []string{"backendError", "rateLimitExce... | feat(bigquery): widen retry predicate
This PR adds 500,504 http response codes for the default retry predicate on unary retries.
This doesn't introduce job-level retries (jobs must be recreated wholly, they can't be effectively restarted), so the primary risk of this change is terminal job state propagating into the... | **Title**
Expand BigQuery unary retry predicate to cover additional 5xx HTTP responses
**Problem**
Transient server‑side failures (e.g., internal errors, gateway timeouts) were not always retried, causing client operations to fail prematurely. This limited retry scope could surface as intermittent errors in poll... | 6,976 | googleapis/google-cloud-go | diff --git a/bigquery/bigquery_test.go b/bigquery/bigquery_test.go
index c5207c0ab1..f1fd24745a 100644
--- a/bigquery/bigquery_test.go
+++ b/bigquery/bigquery_test.go
@@ -86,7 +86,7 @@ func TestRetryableErrors(t *testing.T) {
&googleapi.Error{
Code: http.StatusInternalServerError,
},
- false,
+ true,
... | [
"TestRetryableErrors"
] | [
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorFromErrorProto",
"TestEr... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 1,
"num_modified_lines": 12,
"pr_author": "shollyman",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"automerge: Merge the pull request once unit tests and other checks pass.",
"size: s: Pull request size is small."
],
"llm_metadata": {
"code": ... |
ea389a93b7251bf07019fbddbb512f6981bc69d1 | 2023-02-13 22:30:16 | googleapis__google-cloud-go-7418 | diff --git a/bigquery/load.go b/bigquery/load.go
index cf515beefe..8af650d7a8 100644
--- a/bigquery/load.go
+++ b/bigquery/load.go
@@ -92,6 +92,15 @@ type LoadConfig struct {
// When loading a table with external data, the user can provide a reference file with the table schema.
// This is enabled for the following... | feat(bigquery): add support for session in load jobs
Towards internal b/268630262 | **Title**
Add session creation and connection‑property support to BigQuery load jobs
**Problem**
Load jobs could not be executed within a session nor accept arbitrary connection properties, limiting advanced use‑cases such as session‑based state sharing.
**Root Cause**
The load‑job configuration did not exp... | 7,418 | googleapis/google-cloud-go | diff --git a/bigquery/integration_test.go b/bigquery/integration_test.go
index 81c1b12344..9ad8b9584b 100644
--- a/bigquery/integration_test.go
+++ b/bigquery/integration_test.go
@@ -1421,7 +1421,88 @@ func TestIntegration_Load(t *testing.T) {
t.Fatal(err)
}
checkReadAndTotalRows(t, "reader load", table.Read(ctx... | [
"TestRetryableErrors",
"TestCopy",
"TestTables",
"TestModels",
"TestRoutines",
"TestDatasets",
"TestDatasetToBQ",
"TestBQToDatasetMetadata",
"TestDatasetMetadataToUpdateToBQ",
"TestConvertAccessEntry",
"TestDatasetIdentifiers",
"TestPutMultiErrorString",
"TestMultiErrorString",
"TestErrorF... | [] | Method: Loader.CreateSession
Location: type Loader (bigquery package)
Inputs: bool flag – when true a new load‑job session is created (server‑generated ID); when false the job runs without a session or uses an existing session ID supplied via ConnectionProperties.
Outputs: none (field value is read by the client when b... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update",
"apt-get install -y -qq golang",
"export GOPATH=/root/go",
"export GOMODCACHE=$GOPATH/pkg/mod",
"export GOCACHE=/root/.cache/go-build",
"export XDG_CACHE_HOME=/root/.cache",
"mk... | {
"num_modified_files": 2,
"num_modified_lines": 18,
"pr_author": "alvarowolfx",
"pr_labels": [
"api: bigquery: Issues related to the BigQuery API.",
"automerge: Merge the pull request once unit tests and other checks pass.",
"size: m: Pull request size is medium."
],
"llm_metadata": {
"code... | |
605611649dc18ddea53a781142a81e0a6fd3529c | 2020-11-26 06:22:09 | crossplane__oam-kubernetes-runtime-313 | diff --git a/cmd/oam-kubernetes-runtime/main.go b/cmd/oam-kubernetes-runtime/main.go
index 7b5998f..61cfeff 100644
--- a/cmd/oam-kubernetes-runtime/main.go
+++ b/cmd/oam-kubernetes-runtime/main.go
@@ -47,7 +47,7 @@ func main() {
"Enable leader election for controller manager. Enabling this will ensure there is only ... | fix validating-webhook on ApplyTo
related to #50
Signed-off-by: roy wang <seiwy2010@gmail.com> | **Title**
Correct trait‑to‑workload validation in the ApplicationConfiguration webhook
**Problem**
The validating webhook incorrectly determines whether a trait can be applied to a workload, leading to valid configurations being rejected. This stems from using inappropriate fields to resolve the workload type an... | 313 | crossplane/oam-kubernetes-runtime | diff --git a/pkg/webhook/v1alpha2/applicationconfiguration/validating_handler_test.go b/pkg/webhook/v1alpha2/applicationconfiguration/validating_handler_test.go
index 5243900..bfd8922 100644
--- a/pkg/webhook/v1alpha2/applicationconfiguration/validating_handler_test.go
+++ b/pkg/webhook/v1alpha2/applicationconfiguratio... | [
"TestValidateTraitAppliableToWorkloadFn"
] | [
"TestCheckParams",
"TestApplicationConfigurationWebHandler",
"TestValidateRevisionNameFn",
"TestValidateTraitObjectFn",
"TestValidateWorkloadNameForVersioningFn"
] | Function: ValidateTraitAppliableToWorkloadFn(ctx context.Context, v ValidatingAppConfig) []error
Location: pkg/webhook/v1alpha2/applicationconfiguration/validating_handler.go
Inputs:
- ctx: context for the validation call (unused in current logic).
- v: a ValidatingAppConfig that contains the ApplicationConfiguration b... | custom-check-github | {
"base_image_name": "go_1.19.13",
"install": [
"export GOPATH=/tmp/go",
"export GOMODCACHE=/tmp/go-modules",
"export GOCACHE=/tmp/go-cache",
"mkdir -p $GOPATH $GOMODCACHE $GOCACHE",
"go mod download"
],
"log_parser": "parse_log_gotest",
"test_cmd": "go test -v ./pkg/webhook/v1alpha2/appli... | {
"num_modified_files": 2,
"num_modified_lines": 18,
"pr_author": "captainroy-hy",
"pr_labels": [],
"llm_metadata": {
"code": null,
"code_quality": null,
"confidence": null,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
67aef3bc4df75ea86ce9b1553b4f6a88ebc20bff | 2019-10-29 01:47:04 | aws__amazon-ecs-cli-v2-245 | diff --git a/internal/pkg/archer/manifest.go b/internal/pkg/archer/manifest.go
index 64b7de17..52596d7d 100644
--- a/internal/pkg/archer/manifest.go
+++ b/internal/pkg/archer/manifest.go
@@ -6,5 +6,4 @@ package archer
// Manifest is the interface for serializing a manifest object to a YAML document or CloudFormation t... | Modified existing code in order to add pipeline CFN
<!-- Provide summary of changes -->
Refactored cloudformation.go and updated the pipeline data model to prepare for the work on dynamic Archer pipeline CFN generation.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
Part of #223.
By ... | **Title**
Add pipeline CloudFormation scaffolding and refactor pipeline manifest API
**Problem**
The pipeline manifest could not reliably produce a CloudFormation template because the required method was unimplemented, the manifest lacked an explicit pipeline name, and default stages were silently added, leading... | 245 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/pipeline_test.go b/internal/pkg/deploy/cloudformation/pipeline_test.go
new file mode 100644
index 00000000..4c9e9412
--- /dev/null
+++ b/internal/pkg/deploy/cloudformation/pipeline_test.go
@@ -0,0 +1,84 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights ... | [
"TestDeploy",
"TestDeploy/should_wrap_error_returned_from_CreateChangeSet_call",
"TestDeploy/should_wrap_error_returned_from_WaitUntilChangeSetCreateComplete_call",
"TestDeploy/should_wrap_error_return_from_DescribeChangeSet_call",
"TestDeploy/should_not_execute_Change_Set_with_no_changes",
"TestDeploy/sh... | [] | Method: newPipelineStackConfig(in *deploy.CreatePipelineInput) *pipelineStackConfig
Location: internal/pkg/deploy/cloudformation/pipeline.go
Inputs: in – pointer to a deploy.CreatePipelineInput containing pipeline configuration (project name, pipeline name, source, stages).
Outputs: pointer to a pipelineStackConfig emb... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 5,
"num_modified_lines": 112,
"pr_author": "hencrice",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": true,
"B5": false,
"B6"... | |
4860c8ce23ae7f251496b14785ec35b3184cdf43 | 2019-10-29 21:19:29 | aws__amazon-ecs-cli-v2-247 | diff --git a/internal/pkg/archer/env.go b/internal/pkg/archer/env.go
index f6681c7a..757c0c2d 100644
--- a/internal/pkg/archer/env.go
+++ b/internal/pkg/archer/env.go
@@ -4,9 +4,10 @@
// Package archer contains the structs that represent archer concepts, and the associated interfaces to manipulate them.
package arche... | Move DeployEnvironmentInput to the deploy pkg
1. Moved the `DeployEnvironmentInput` struct to `deploy` pkg
2. Renamed the struct to just `Environment`
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Refactor deployment input model into a dedicated package and update its usage
**Problem**
The structure that describes the fields required to create an environment was defined in the core “archer” package, mixing deployment‑specific data with generic environment definitions. This coupling made the code... | 247 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go b/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
index a8eac1d6..aa4cfe95 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_i... | [
"TestDeploy",
"TestDeploy/should_return_a_ErrStackAlreadyExists_if_the_stack_already_exists",
"TestDeploy/should_deploy",
"TestDeploy/should_not_execute_Change_Set_with_no_changes",
"TestDeploy/should_not_execute_Change_Set_with_no_updates",
"TestDeploy/should_fail_Change_Set_with_unexpected_status",
"T... | [] | Method: CloudFormation.DeployEnvironment(env *deploy.CreateEnvironmentInput)
Location: internal/pkg/deploy/cloudformation/cloudformation.go
Inputs: pointer to deploy.CreateEnvironmentInput – contains Project, Name, Prod, PublicLoadBalancer, ToolsAccountPrincipalARN.
Outputs: error – nil on success, otherwise wrapped... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 9,
"num_modified_lines": 41,
"pr_author": "efekarakus",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B... | |
fdafeb5498fa66a91743782f422a385f3eb3e4b8 | 2019-11-04 18:06:13 | aws__amazon-ecs-cli-v2-272 | diff --git a/Makefile b/Makefile
index 6665020c..8d8585bf 100644
--- a/Makefile
+++ b/Makefile
@@ -40,7 +40,7 @@ packr-clean: tools
test: packr-build run-unit-test packr-clean
run-unit-test:
- go test -v -race -cover -count=1 -coverprofile ${COVERAGE} ${PACKAGES}
+ go test -race -cover -count=1 -coverprofile ${COVE... | Add app deploy subcommand
<!-- Provide summary of changes -->
* Removed the `-v` flag in the `run-unit-test` `Makefile` target to make viewing the output easier
* Added the `app deploy` sub-command
* Added a few independent clients that the `app deploy` sub-command depends on
* `ecr`, `docker`, and `project` pack... | **Title**
Add full “app deploy” workflow and supporting infrastructure
**Problem**
Deploying an application required manual steps and could not be triggered from the CLI. The manifest did not expose the Dockerfile location, and the tool for discovering Dockerfiles returned file paths that conflicted with the new d... | 272 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/build/ecr/ecr_test.go b/internal/pkg/build/ecr/ecr_test.go
new file mode 100644
index 00000000..9b8b1c1c
--- /dev/null
+++ b/internal/pkg/build/ecr/ecr_test.go
@@ -0,0 +1,196 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
... | [
"TestDeployApp",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeploy",
"TestDeploy/should_return_a_ErrStackAlreadyExists_if_the_stack_already_exists",
"TestDeploy/should_wrap_... | [
"TestLBFargateStackConfig_StackName",
"TestLBFargateStackConfig_StackName/valid_stack_name",
"TestLBFargateStackConfig_StackName/longer_than_128_characters",
"TestLBFargateStackConfig_Template/unavailable_template",
"TestLBFargateStackConfig_SerializedParameters/unavailable_template",
"TestLBFargateStackC... | Method: Service.GetECRAuth()
Location: internal/pkg/build/ecr/ecr.go
Inputs: none
Outputs: (Auth, error) – returns a struct with Username and Password fields, or a wrapped error if the ECR GetAuthorizationToken call fails.
Description: Retrieves an ECR authorization token, decodes it, and returns basic auth credent... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 12,
"num_modified_lines": 899,
"pr_author": "sonofachamp",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e7fea8c28349c3c223e6d3f3c541c95a1bb58a5e | 2019-11-06 00:47:53 | aws__amazon-ecs-cli-v2-284 | diff --git a/internal/pkg/deploy/cloudformation/stack/project.go b/internal/pkg/deploy/cloudformation/stack/project.go
index e7c8ad06..b2df8bf1 100644
--- a/internal/pkg/deploy/cloudformation/stack/project.go
+++ b/internal/pkg/deploy/cloudformation/stack/project.go
@@ -8,6 +8,7 @@ import (
"fmt"
"html/template"
... | Fix project-resources template for apps with "-" in the name
CloudFormation logical IDs can't have dashes in the name. This
change "sanitizes" the logical IDs we generate in the project
resources stack.
We'll replace dashes with the word DASH (since caps aren't
allowed in app/project names - we won't have any col... | **Title**
Sanitize CloudFormation logical IDs for applications with hyphens
**Problem**
CloudFormation logical IDs generated from application names that contain hyphens cause stack‑creation failures, breaking deployments for such projects.
**Root Cause**
The project‑resource template builds logical IDs dire... | 284 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go b/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
index 64ab835e..ff63831d 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_i... | [
"TestProjResourceTemplate",
"TestProjResourceTemplate/should_replace_dashes_in_logical_IDs"
] | [
"TestDeploy",
"TestDeploy/should_return_a_ErrStackAlreadyExists_if_the_stack_already_exists",
"TestDeploy/should_not_execute_Change_Set_with_no_changes",
"TestDeploy/should_wrap_error_returned_from_ExecuteChangeSet_call",
"TestDeploy/should_deploy",
"TestDeploy/should_fail_Change_Set_with_unexpected_statu... | Method: ProjectStackConfig.ResourceTemplate(self, config *ProjectResourcesConfig)
Location: internal/pkg/deploy/cloudformation/stack/project.go
Inputs: *ProjectResourcesConfig containing Accounts []string, Apps []string (may include dash‑containing names), Version int, Project string – used to render the project‑reso... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 2,
"num_modified_lines": 12,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.95,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
0a88b39afe3e8dedf0a43fdc10a3a4c2a6621f7d | 2019-11-06 23:59:55 | aws__amazon-ecs-cli-v2-287 | diff --git a/internal/pkg/cli/app_package.go b/internal/pkg/cli/app_package.go
index 2f89c8d1..7f3d5b3e 100644
--- a/internal/pkg/cli/app_package.go
+++ b/internal/pkg/cli/app_package.go
@@ -15,7 +15,7 @@ import (
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer"
"github.com/aws/amazon-ecs-cli-v2/internal/pk... | Move LBFargateStackConfig to stack pkg
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Refactor load‑balanced Fargate stack configuration into dedicated stack package
**Problem**
The load‑balanced Fargate stack configuration was located in a generic CloudFormation package, mixing concerns and making the package harder to maintain. This caused coupling issues for callers that only needed ... | 287 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/lb_fargate_app_test.go b/internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go
similarity index 99%
rename from internal/pkg/deploy/cloudformation/lb_fargate_app_test.go
rename to internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go
index 2d46f77e..f4... | [
"TestLBFargateStackConfig_StackName",
"TestLBFargateStackConfig_StackName/valid_stack_name",
"TestLBFargateStackConfig_StackName/longer_than_128_characters",
"TestLBFargateStackConfig_Template",
"TestLBFargateStackConfig_Template/unavailable_template",
"TestLBFargateStackConfig_Template/render_default_tem... | [
"TestDeploy",
"TestDeploy/should_return_a_ErrStackAlreadyExists_if_the_stack_already_exists",
"TestDeploy/should_wrap_error_returned_from_WaitUntilChangeSetCreateComplete_call",
"TestDeploy/should_wrap_error_return_from_DescribeChangeSet_call",
"TestDeploy/should_fail_Change_Set_with_unexpected_status",
"... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 2,
"num_modified_lines": 9,
"pr_author": "efekarakus",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
1f7f06d50cd3e18d66ea6154988ccb654856bee9 | 2019-11-07 00:31:08 | efekarakus: @SoManyHs I'll fill that value once the interfaces in this PR https://github.com/aws/amazon-ecs-cli-v2/pull/289#pullrequestreview-312963184 are implemented :) | aws__amazon-ecs-cli-v2-288 | diff --git a/internal/pkg/cli/app_deploy.go b/internal/pkg/cli/app_deploy.go
index eb19c575..89ae30c4 100644
--- a/internal/pkg/cli/app_deploy.go
+++ b/internal/pkg/cli/app_deploy.go
@@ -341,6 +341,10 @@ func (opts appDeployOpts) deployApp() error {
func (opts appDeployOpts) getAppDeployTemplate() (string, error) {
... | Add a ImageRepoURL field to CreateLBFargateAppInput
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Include ECR repository URL when generating CloudFormation templates for load‑balanced Fargate apps
**Problem**
The CLI generated an image location by stitching together project metadata, which fails when an application’s repository URL does not follow that pattern or is missing. This also caused confus... | 288 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/cli/app_package_test.go b/internal/pkg/cli/app_package_test.go
index 9ebae785..50615c67 100644
--- a/internal/pkg/cli/app_package_test.go
+++ b/internal/pkg/cli/app_package_test.go
@@ -11,6 +11,7 @@ import (
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer"
climocks "github.com/aws/... | [
"TestLBFargateStackConfig_StackName",
"TestLBFargateStackConfig_StackName/valid_stack_name",
"TestLBFargateStackConfig_StackName/longer_than_128_characters",
"TestLBFargateStackConfig_Template",
"TestLBFargateStackConfig_Template/unavailable_template",
"TestLBFargateStackConfig_Template/render_default_tem... | [
"TestDeployApp",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_wrap_DescribeChangeSet_error_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_comp... | Method: projectService.ListEnvironments(projectName string) ([]*archer.Environment, error)
Location: internal/pkg/cli
Inputs: projectName – name of the project to list environments for.
Outputs: slice of *archer.Environment for the project, or an error.
Method: projectService.GetEnvironment(projectName string, envName... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 6,
"num_modified_lines": 129,
"pr_author": "efekarakus",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"... |
4715e8380ba04578e0399f09f43d1ade0ef99f38 | 2019-11-07 06:57:44 | aws__amazon-ecs-cli-v2-290 | diff --git a/internal/pkg/aws/ecr/ecr.go b/internal/pkg/aws/ecr/ecr.go
new file mode 100644
index 00000000..47bf9449
--- /dev/null
+++ b/internal/pkg/aws/ecr/ecr.go
@@ -0,0 +1,32 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+// Package ecr cont... | Add implementation for Project Resources
This adds the ability to get project resources by
reading the output of project resource cloudformation stacks.
<!-- Provide summary of changes -->
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
By submitting this pull request, I confirm tha... | **Title**
Add full project resource discovery with cross‑region support
**Problem**
The CLI was unable to retrieve a project's regional resources (KMS key, S3 bucket, ECR repositories) after deployment, and it could only query CloudFormation stacks in the session’s default region.
**Root Cause**
The CloudFo... | 290 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/aws/ecr/erc_test.go b/internal/pkg/aws/ecr/erc_test.go
new file mode 100644
index 00000000..4661cb71
--- /dev/null
+++ b/internal/pkg/aws/ecr/erc_test.go
@@ -0,0 +1,49 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+pack... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [] | Method: CloudFormation.GetRegionalProjectResources(self, project *archer.Project) ([]*archer.ProjectRegionalResources, error)
Location: internal/pkg/deploy/cloudformation/project.go
Inputs:
- project: pointer to an archer.Project representing the ECS project (contains Name and AccountID).
Outputs:
- slice of pointers t... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 5,
"num_modified_lines": 217,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6"... | |
2b20e571c43c41c7aba12f508be563e97f7d6e6c | 2019-11-07 22:59:49 | aws__amazon-ecs-cli-v2-299 | diff --git a/Makefile b/Makefile
index 8d8585bf..37fa0218 100644
--- a/Makefile
+++ b/Makefile
@@ -98,5 +98,5 @@ gen-mocks: tools
${GOBIN}/mockgen -source=./internal/pkg/cli/cli.go -package=mocks -destination=./internal/pkg/cli/mocks/mock_cli.go
${GOBIN}/mockgen -source=./internal/pkg/cli/completion.go -package=moc... | "project init" cmd creates the stack set
Running `project init` will now create the stack set.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Create project stack set during `archer init`
**Problem**
Running `archer init` only created local metadata and a workspace; it never provisioned the CloudFormation stack set that holds the project‑wide resources. Users also received no clear progress or error messages for this step, and the CLI interfac... | 299 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/cli/env_init_test.go b/internal/pkg/cli/env_init_test.go
index d454bdee..d010455f 100644
--- a/internal/pkg/cli/env_init_test.go
+++ b/internal/pkg/cli/env_init_test.go
@@ -12,7 +12,7 @@ import (
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/identity"
"github.com/aws/amazon-ecs-cli-v2... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeploy",
"TestDeploy/should_wrap_error_returned_from_CreateChangeSet_call",
"TestDeploy/should_not_execute_Change... | [] | Method: CloudFormation.DeployProject(self, in *deploy.CreateProjectInput) error
Location: internal/pkg/deploy/cloudformation/project.go
Inputs: in – pointer to deploy.CreateProjectInput containing Project (project name) and AccountID (AWS account ID) used to create or update the project StackSet.
Outputs: error – nil o... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 16,
"num_modified_lines": 251,
"pr_author": "efekarakus",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
f88c7717be3bcc71109b076e894cae5a03db6364 | 2019-11-09 02:33:51 | aws__amazon-ecs-cli-v2-315 | diff --git a/internal/pkg/deploy/cloudformation/pipeline.go b/internal/pkg/deploy/cloudformation/stack/pipeline.go
similarity index 98%
rename from internal/pkg/deploy/cloudformation/pipeline.go
rename to internal/pkg/deploy/cloudformation/stack/pipeline.go
index 1da1b568..2647cf93 100644
--- a/internal/pkg/deploy/clou... | Move pipeline files into stack pkg
<!-- Provide summary of changes -->
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Refactor pipeline CloudFormation code into the dedicated stack package
**Problem**
The pipeline‑related CloudFormation utilities were placed in the generic cloudformation package, mixing concerns and obscuring the module’s structure. This made the codebase harder to navigate and increased the risk of i... | 315 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/pipeline_test.go b/internal/pkg/deploy/cloudformation/stack/pipeline_test.go
similarity index 96%
rename from internal/pkg/deploy/cloudformation/pipeline_test.go
rename to internal/pkg/deploy/cloudformation/stack/pipeline_test.go
index 1e51414f..a1729b31 100644
--- a/inte... | [
"TestLBFargateStackConfig_StackName",
"TestLBFargateStackConfig_StackName/valid_stack_name",
"TestLBFargateStackConfig_StackName/longer_than_128_characters",
"TestLBFargateStackConfig_Template",
"TestLBFargateStackConfig_Template/unavailable_template",
"TestLBFargateStackConfig_Template/render_default_tem... | [
"TestDeployApp",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_wrap_DescribeChangeSet_error_if_WaitUntilChangeSetCreateComplete_fails",
"Tes... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 1,
"num_modified_lines": 2,
"pr_author": "SoManyHs",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6":... | |
176cade9e14315362a8f67eaf7c30d6435bca970 | 2019-11-15 02:43:35 | aws__amazon-ecs-cli-v2-359 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation.go b/internal/pkg/deploy/cloudformation/cloudformation.go
index 556b52e2..e1158494 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation.go
@@ -67,55 +67,6 @@ func New(sess *session.Session... | Restructure deploy logic for env for consistency
<!-- Provide summary of changes -->
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Refactor environment deployment configuration for consistency across CloudFormation components
**Problem**
Environment‑specific CloudFormation logic was tightly coupled with the deployment implementation, leading to duplicated code and divergent behavior compared to other stack types. This made mainten... | 359 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_test.go b/internal/pkg/deploy/cloudformation/cloudformation_test.go
index 90b4211a..3ab11131 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_test.go
@@ -9,8 +9,7 @@ import (
"r... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [] | Function: NewEnvStackConfig(input *deploy.CreateEnvironmentInput, box packd.Box) *EnvStackConfig
Location: internal/pkg/deploy/cloudformation/stack/env.go
Inputs:
- input: pointer to deploy.CreateEnvironmentInput containing environment creation parameters (project, name, etc.).
- box: packd.Box providing access to emb... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 3,
"num_modified_lines": 184,
"pr_author": "SoManyHs",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6... | |
87ef0fccdf22bf0d0a50e525c40dc8e94b764d5f | 2019-11-15 05:45:33 | kohidave: This is so rad. Thank you so much! | aws__amazon-ecs-cli-v2-360 | diff --git a/internal/pkg/cli/deploy.go b/internal/pkg/cli/deploy.go
index c6a428af..8bc0087f 100644
--- a/internal/pkg/cli/deploy.go
+++ b/internal/pkg/cli/deploy.go
@@ -8,11 +8,19 @@ import (
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy"
)
+// Interfaces for deploying resources through CloudFormation. F... | Pipeline update
<!-- Provide summary of changes -->
This PR DOES:
- deploy the pipeline.yml
this PR DOES NOT:
- deploy a pipeline that actually works
Fast follow: Ensure role name does not exceed 64 characters, but submitting this to get early feedback.
<!-- Issue number, if available. E.g. "Fixes #31", ... | **Title**
Add full pipeline update support and related CLI enhancements
**Problem**
The CLI could only initialize a pipeline but lacked a command to apply updates, and the existing GitHub repository validation was overly strict. Additionally, pipeline resource handling used incorrect bucket identifiers and did n... | 360 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/cli/validate_test.go b/internal/pkg/cli/validate_test.go
index 26000014..6b08c7ed 100644
--- a/internal/pkg/cli/validate_test.go
+++ b/internal/pkg/cli/validate_test.go
@@ -144,3 +144,32 @@ func TestIsCorrectFormat(t *testing.T) {
})
}
}
+
+func TestValidateGitHubRepo(t *testing.T) {
+ t... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvTags",
"TestStackName",
"TestToEnv",
"TestToEnv/should_return_error_if_Stack_ID_is_invalid",
"TestToEnv/should_return_a_well_for... | [
"TestDeployApp",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_wrap_DescribeChangeSet_error_if_WaitUntilChangeSetCreateComplete_fails",
"Tes... | Function: NewPipelineStackConfig(in *deploy.CreatePipelineInput) *pipelineStackConfig
Location: internal/pkg/deploy/cloudformation/stack/pipeline.go
Inputs: A pointer to a deploy.CreatePipelineInput struct containing the pipeline configuration (project name, pipeline name, source, stages, artifact buckets, etc.). The i... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 12,
"num_modified_lines": 448,
"pr_author": "SoManyHs",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B... |
33e2c383d2905d35954c2cb1cfa9b1f3bf403b5b | 2019-11-16 21:46:25 | aws__amazon-ecs-cli-v2-393 | diff --git a/internal/pkg/deploy/cloudformation/app.go b/internal/pkg/deploy/cloudformation/app.go
index a638c3ac..18bae105 100644
--- a/internal/pkg/deploy/cloudformation/app.go
+++ b/internal/pkg/deploy/cloudformation/app.go
@@ -4,6 +4,7 @@
package cloudformation
import (
+ "context"
"fmt"
"github.com/aws/a... | Reduce wait time for CF polling from 30s -> 3s
If we pass in our own waiters, we can specify
the wait time that CF waits before checking
the status of creating stacks, updating them, etc.
This helps a lot, especially since we use changesets
and changeset creation is usually much faster than 30s.
a full project... | **Title**
Faster CloudFormation polling by using custom waiter intervals
**Problem**
The default CloudFormation waiters poll every 30 seconds, which adds unnecessary latency to stack creation, update, and change‑set operations. This slowdown is noticeable during full project initialization.
**Root Cause**
W... | 393 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/app_test.go b/internal/pkg/deploy/cloudformation/app_test.go
index d4e741fe..f6d8af71 100644
--- a/internal/pkg/deploy/cloudformation/app_test.go
+++ b/internal/pkg/deploy/cloudformation/app_test.go
@@ -20,13 +20,13 @@ func TestDeployApp(t *testing.T) {
mockError := err... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvTags",
"TestStackName",
"TestToEnv",
"TestToEnv/should_return_error_if_Stack_ID_is_invalid",
"TestToEnv/should_return_a_well_for... | Method: CloudFormationAPI.WaitUntilStackCreateCompleteWithContext(ctx context.Context, in *cloudformation.DescribeStacksInput, opts ...request.WaiterOption) error
Location: Implements the AWS CloudFormation waiter interface used by CloudFormation client and mockCloudFormation.
Inputs:
- ctx – request‑scoped context (o... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 4,
"num_modified_lines": 30,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
c80b45a10e2e1d51cd38ed5252e06fd0abb7bdce | 2019-11-17 04:18:15 | aws__amazon-ecs-cli-v2-394 | diff --git a/internal/pkg/archer/project.go b/internal/pkg/archer/project.go
index b7b01dd5..f5515ad5 100644
--- a/internal/pkg/archer/project.go
+++ b/internal/pkg/archer/project.go
@@ -11,6 +11,11 @@ type Project struct {
Version string `json:"version"` // The version of the project layout in the underlying datas... | DNS delegation part 1
Attach environment principal to DNS Delegation Policy
This change makes it so we can do cross-account DNS delegation. It
grants the environment permission to update the project's hosted zone.
TODO: the project.yml template is not complete, it just adds a role.
But thi... | **Title**
Add cross‑account DNS delegation support for projects
**Problem**
Projects that require a custom domain need to allow environments in other AWS accounts to modify the project's Route 53 hosted zone. The CLI previously had no way to detect this need, nor to grant the necessary IAM permissions, causing c... | 394 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/cli/env_init_test.go b/internal/pkg/cli/env_init_test.go
index 392791a0..ec8dd245 100644
--- a/internal/pkg/cli/env_init_test.go
+++ b/internal/pkg/cli/env_init_test.go
@@ -373,6 +373,52 @@ func TestInitEnvOpts_Execute(t *testing.T) {
}).Return(nil)
},
},
+ "success with DNS Deleg... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [] | Method: projectDeployer.DelegateDNSPermissions(project *archer.Project, accountID string) error
Location: internal/pkg/cli/deploy.go (interface definition) – implemented by the CloudFormation deployer and mocked in tests.
Inputs:
- project: *archer.Project – the project whose DNS Delegation role needs to be updated. M... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 14,
"num_modified_lines": 370,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "B2|B4",
"code_quality": null,
"confidence": 0.84,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": true,
"B5": false,
... | |
75c53040e5c73371bd5601e677cd542cc2d31416 | 2019-11-18 02:42:16 | aws__amazon-ecs-cli-v2-395 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation.go b/internal/pkg/deploy/cloudformation/cloudformation.go
index 3fb0afd7..9377cbfe 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation.go
@@ -168,46 +168,115 @@ func (cf CloudFormation) d... | Tighten up CloudFormation error handling
This fixes and enhances some cf error handling:
1. For create, if a stack was failed to have been crated,
we'll delete it and then create the stack. This means
if someone creates an env stack, it fails, and the run
env init again, it'll delete the old failed stack a... | **Title**
Improve CloudFormation stack lifecycle error handling
**Problem**
Creating or updating a CloudFormation stack could succeed in ambiguous ways: a failed‑to‑create stack was left behind, attempts to create an already‑existing stack produced generic errors, and updates against stacks that were already in ... | 395 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go b/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
index 0dcd1966..179f1f6a 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_i... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvTags",
"TestStackName",
"TestToEnv",
"TestToEnv/should_return_error_if_Stack_ID_is_invalid",
"TestToEnv/should_return_a_well_for... | Method: CloudFormation.create(self, stackConfig stackConfiguration) error
Location: internal/pkg/deploy/cloudformation/cloudformation.go
Inputs: stackConfig – an implementation of stackConfiguration providing StackName(), Template(), Parameters(), and Tags(). Called directly in TestCreate to attempt a stack creation.
O... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 3,
"num_modified_lines": 137,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
0df8d576aec613e28638df0cabaf78801621e849 | 2019-11-18 03:56:38 | aws__amazon-ecs-cli-v2-396 | diff --git a/internal/pkg/deploy/cloudformation/stack/project.go b/internal/pkg/deploy/cloudformation/stack/project.go
index eeb6871f..fc2cd6b5 100644
--- a/internal/pkg/deploy/cloudformation/stack/project.go
+++ b/internal/pkg/deploy/cloudformation/stack/project.go
@@ -52,6 +52,7 @@ const (
projectOutputECRRepoPrefi... | Project Hosted Zone and Delegation Role
This change adds creates the project hosted zone
and record set in the parent hosted zone. It updates
the DNS Delegation role to only have write permissions
to this particular hosted zone.
<!-- Provide summary of changes -->
<!-- Issue number, if available. E.g. "Fixes #... | **Title**
Add per‑project hosted zone creation and tighten DNS delegation permissions
**Problem**
Projects that specify a domain need an isolated Route 53 hosted zone and a delegation record in the parent zone. The existing stack created a delegation role with unrestricted Route 53 access and did not provision t... | 396 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/project_test.go b/internal/pkg/deploy/cloudformation/project_test.go
index 3f6f9fec..ae889821 100644
--- a/internal/pkg/deploy/cloudformation/project_test.go
+++ b/internal/pkg/deploy/cloudformation/project_test.go
@@ -1022,7 +1022,7 @@ func TestDelegateDNSPermissions(t *... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvTags",
"TestStackName",
"TestToEnv",
"TestToEnv/should_return_error_if_Stack_ID_is_invalid",
"TestToEnv/should_return_a_well_for... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 2,
"num_modified_lines": 36,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.85,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
75875c30e0993f3d0100089c2cafbaa9028fcf8c | 2019-11-19 23:20:09 | aws__amazon-ecs-cli-v2-416 | diff --git a/internal/pkg/deploy/cloudformation/changeset.go b/internal/pkg/deploy/cloudformation/changeset.go
index 5bc96126..e478a184 100644
--- a/internal/pkg/deploy/cloudformation/changeset.go
+++ b/internal/pkg/deploy/cloudformation/changeset.go
@@ -103,6 +103,16 @@ func (set *changeSet) execute() error {
return... | Ignore empty changesets
This change makes it so we don't fail
if there are no changes to a stack.
It also cleans up empty changesets so they
don't clutter a customer's account.
I yoinked some of the code directly from @sonofachamp :D
<!-- Provide summary of changes -->
<!-- Issue number, if available. E.g. ... | **Title**
Handle empty CloudFormation change sets without error
**Problem**
Deployments currently fail when a stack has no changes and leave empty change sets that accumulate in the account, potentially hitting service limits.
**Root Cause**
The deployment flow treats any error from waiting for a change set... | 416 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_test.go b/internal/pkg/deploy/cloudformation/cloudformation_test.go
index b052befd..1db8d388 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_test.go
@@ -37,6 +37,7 @@ type mockCl... | [
"TestDeploy",
"TestDeploy/should_gracefully_skip_deploys_when_there_are_no_changes_and_clean_up_failed_changeset"
] | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | Function: DeleteChangeSet(in *cloudformation.DeleteChangeSetInput) (*cloudformation.DeleteChangeSetOutput, error)
Location: internal/pkg/deploy/cloudformation/cloudformation.go (method on the CloudFormation client interface, exercised via mockCloudFormation in tests)
Inputs: *cloudformation.DeleteChangeSetInput – must ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 2,
"num_modified_lines": 25,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6"... | |
20d6055857bf808dd9b0f71341053f6376d47220 | 2019-11-20 03:05:38 | aws__amazon-ecs-cli-v2-426 | diff --git a/internal/pkg/cli/env_init.go b/internal/pkg/cli/env_init.go
index 7a58882b..c3fcd5f4 100644
--- a/internal/pkg/cli/env_init.go
+++ b/internal/pkg/cli/env_init.go
@@ -100,6 +100,7 @@ func (opts *InitEnvOpts) Execute() error {
Prod: opts.IsProduction,
PublicLoadBalancer: true,... | Set up resources in env/project stack for DNS Delegation
This pipes through the DNS name of the project to the env
templates, and wires in the custom resources.
TODO: Add the integration tests for this - but the
existing, non DNS integ tests are running fine.
I manually ran the env setup for a DNS project.
... | **Title**
Add full DNS delegation support for environments that require it
**Problem**
Environments that need DNS delegation could not provision the necessary hosted zone, certificate validation, and related IAM role, causing DNS‑related deployments to fail. The DNS name of a project was not passed through the e... | 426 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go b/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
index 179f1f6a..62d89be7 100644
--- a/internal/pkg/deploy/cloudformation/cloudformation_integration_test.go
+++ b/internal/pkg/deploy/cloudformation/cloudformation_i... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvParameters",
"TestEnvParameters/without_DNS",
"TestEnvParameters/with_DNS",
"TestEnvDNSDelegationRole",
"TestEnvDNSDelegationRole/without_tools_account... | [
"TestDeployApp",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_wrap_DescribeChangeSet_error_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_comp... | Method: EnvStackConfig.dnsDelegationRole(self)
Location: internal/pkg/deploy/cloudformation/stack/env.go
Inputs: None (relies on the EnvStackConfig fields `ToolsAccountPrincipalARN` and `ProjectDNSName`).
Outputs: `string` – the ARN of the IAM role that should be used for DNS delegation, or an empty string if the... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 6,
"num_modified_lines": 258,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": true,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
ed5cbee5129e3374f6f0712a2061b866a917f92e | 2019-11-20 05:12:48 | aws__amazon-ecs-cli-v2-427 | diff --git a/internal/pkg/cli/app_deploy.go b/internal/pkg/cli/app_deploy.go
index a4b6f66a..4e0b4c64 100644
--- a/internal/pkg/cli/app_deploy.go
+++ b/internal/pkg/cli/app_deploy.go
@@ -123,7 +123,6 @@ func (opts *appDeployOpts) init() error {
return fmt.Errorf("intialize workspace service: %w", err)
}
opts.wor... | Add HTTPS to lb_fargate_app template & x-account deploys
This change updates the lb fargate app to create an https
listner if the project is configured for https.
It also enables cross account deployments and brings
the app stack name in line with the codepipeline's apps
(project-env-app).
<!-- Provide summary... | **Title**
Add HTTPS support to load‑balanced Fargate apps and enable cross‑account deployments with unified stack naming
**Problem**
- Fargate applications were always deployed without an HTTPS listener, even when the project required it.
- Application stacks were created using the tooling account’s CloudForma... | 427 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/cli/app_package_test.go b/internal/pkg/cli/app_package_test.go
index 07ca139e..a8b01eac 100644
--- a/internal/pkg/cli/app_package_test.go
+++ b/internal/pkg/cli/app_package_test.go
@@ -520,6 +520,46 @@ http:
path: '*'
cpu: 256
memory: 512
+count: 1`), nil)
+ },
+ expectDeployer: func(... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [] | Method: CloudFormation.DeployApp(template string, stackName string, changeSetName string, cfExecutionRole string, tags map[string]string) error
Location: internal/pkg/deploy/cloudformation/app.go
Inputs: CloudFormation client (receiver), template body (string), stack name (string), change‑set name (string), execution r... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 7,
"num_modified_lines": 108,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
8fd198efe4cfb7928baacb957623773033a09cb5 | 2019-11-21 21:07:48 | aws__amazon-ecs-cli-v2-454 | diff --git a/cf-custom-resources/lib/alb-rule-priority-generator.js b/cf-custom-resources/lib/alb-rule-priority-generator.js
new file mode 100644
index 00000000..7fe64dfa
--- /dev/null
+++ b/cf-custom-resources/lib/alb-rule-priority-generator.js
@@ -0,0 +1,141 @@
+// Copyright 2019 Amazon.com, Inc. or its affiliates. A... | Fix Multiple Listener Rules
Right now, we pass in the Listener rule value of 1.
This works for 1 app, but not if we want to add another.
To solve this, we have to use a custom resource to generate
the next available rule priority by looking at the existing LB
Listener rules, and returning the max + 1.
This chang... | **Title**
Enable dynamic ALB listener rule priorities, fix service‑listener race, and expose load‑balancer DNS to tasks
**Problem**
- Listener rules were always created with a fixed priority, preventing multiple services from sharing the same load balancer.
- The ECS service could start before its listener rul... | 454 | aws/amazon-ecs-cli-v2 | diff --git a/cf-custom-resources/test/alb-rule-priority-generator-test.js b/cf-custom-resources/test/alb-rule-priority-generator-test.js
new file mode 100644
index 00000000..c7e08d25
--- /dev/null
+++ b/cf-custom-resources/test/alb-rule-priority-generator-test.js
@@ -0,0 +1,274 @@
+// Copyright 2019 Amazon.com, Inc. or... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvParameters/without_DNS",
"TestEnvParameters/with_DNS",
"TestEnvDNSDelegationRole",
"TestEnvDNSDelegationRole/with_invalid_tools_pr... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | Function: withDefaultResponseURL(url)
Location: exported from `cf-custom-resources/lib/alb-rule-priority-generator.js`
Inputs:
- `url` (string) – the default CloudFormation response URL to be used when the incoming Lambda event does not contain a `ResponseURL` field (used in tests to inject a mock endpoint).
Outputs: ... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 4,
"num_modified_lines": 281,
"pr_author": "kohidave",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6... | |
89378d3362c57d42edaf55274d86927a01861087 | 2019-11-22 01:45:55 | aws__amazon-ecs-cli-v2-461 | diff --git a/internal/pkg/archer/app.go b/internal/pkg/archer/app.go
index c34d09fa..f4bdb720 100644
--- a/internal/pkg/archer/app.go
+++ b/internal/pkg/archer/app.go
@@ -15,6 +15,7 @@ type ApplicationStore interface {
ApplicationLister
ApplicationGetter
ApplicationCreator
+ ApplicationDeleter
}
// Applicatio... | Add app delete sub-command
<!-- Provide summary of changes -->
Add `app delete` functionality:
* Delete all app deployment stacks across associated environments
* Empty ECR repositories in all associated environment regions
* Update project resources to remove app ECR repositories
* Delete the app SSM parameter
*... | **Title**
Add full application deletion capability to the CLI
**Problem**
There was no way to remove an application and all of its associated cloud resources from a project, resulting in orphaned CloudFormation stacks, ECR repositories, SSM parameters, and workspace files.
**Root Cause**
The CLI and underlyin... | 461 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/aws/ecr/erc_test.go b/internal/pkg/aws/ecr/erc_test.go
index 4661cb71..c722f860 100644
--- a/internal/pkg/aws/ecr/erc_test.go
+++ b/internal/pkg/aws/ecr/erc_test.go
@@ -4,12 +4,279 @@
package ecr
import (
+ "encoding/base64"
+ "errors"
"fmt"
"testing"
+ "github.com/aws/aws-sdk-go/aws... | [
"TestDeployApp",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_describe_stack_to_check_for_no_changes_scenario_if_WaitUntilChangeSetCreateComplete_fails",
"TestD... | [
"TestEnvTemplate",
"TestEnvTemplate/should_return_error_given_template_not_found",
"TestEnvTemplate/should_return_template_body_when_present",
"TestEnvParameters",
"TestEnvParameters/without_DNS",
"TestEnvParameters/with_DNS",
"TestEnvDNSDelegationRole",
"TestEnvDNSDelegationRole/without_tools_account... | Method: Service.GetECRAuth(self) → (Auth, error)
Location: internal/pkg/aws/ecr/ecr.go
Inputs: none
Outputs: Returns an Auth struct containing Username and Password, or an error wrapped as “get ECR auth: …”.
Description: Retrieves an authorization token from ECR, decodes it, and returns the Docker registry credentials.... | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 14,
"num_modified_lines": 681,
"pr_author": "sonofachamp",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
a5df240339e60bcc5258e8860f95f38eb9f8118d | 2019-11-25 22:58:07 | aws__amazon-ecs-cli-v2-480 | diff --git a/internal/pkg/deploy/cloudformation/stack/lb_fargate_app.go b/internal/pkg/deploy/cloudformation/stack/lb_fargate_app.go
index 42363ba9..b9513ab0 100644
--- a/internal/pkg/deploy/cloudformation/stack/lb_fargate_app.go
+++ b/internal/pkg/deploy/cloudformation/stack/lb_fargate_app.go
@@ -30,7 +30,6 @@ const (... | Remove unused RulePriority template parameter
Removes unused functionality.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| **Title**
Remove the unused listener rule priority parameter from the Fargate load‑balancer stack
**Problem**
The Fargate load‑balancer CloudFormation stack accepts a `RulePriority` parameter that is never referenced when rendering the template. Keeping this unused input adds unnecessary complexity and can cause... | 480 | aws/amazon-ecs-cli-v2 | diff --git a/internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go b/internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go
index a88cc41a..13de369f 100644
--- a/internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go
+++ b/internal/pkg/deploy/cloudformation/stack/lb_fargate_app_test.go
@@ -1... | [
"TestLBFargateStackConfig_Parameters",
"TestLBFargateStackConfig_Parameters/HTTPS_Not_Enabled",
"TestLBFargateStackConfig_Parameters/HTTPS_Enabled"
] | [
"TestDeployApp",
"TestDeployApp/should_wrap_DescribeChangeSet_error_if_WaitUntilChangeSetCreateComplete_fails",
"TestDeployApp/should_create_the_stack_if_one_didn't_exist_already_and_wait_for_completion",
"TestDeployApp/should_create_and_execute_change_set_if_stack_already_exists",
"TestDeployApp/should_des... | No new interfaces are introduced. | Apache-2.0 | {
"base_image_name": "go_1.19.13",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq golang nodejs npm",
"export GOPATH=/go",
"export GOMODCACHE=/go/pkg/mod",
"export GOCACHE=/tmp/go-cache",
"export HOME=/tmp",
"mkdir -p /tmp/go-cache... | {
"num_modified_files": 3,
"num_modified_lines": 0,
"pr_author": "efekarakus",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.98,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6... | |
99886661a272dcebe6c8b74938c3976960049d45 | 2021-12-03 11:09:13 | serpro69: Hi @jgiovaresco ,
Thanks for this contribution! I'll go over your PR on the weekend. | serpro69__kotlin-faker-115 | diff --git a/cli-bot/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot/reflect-config.json b/cli-bot/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot/reflect-config.json
index 8e00f612..d2e5b3fa 100644
--- a/cli-bot/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot... | Add Crossfit® provider to Faker | **Title**
Add Crossfit® data provider to the Faker API
**Problem**
The library did not expose any Crossfit‑related fake data, leaving users without convenient access to competitions, athletes, movements, and workouts.
**Root Cause**
The Crossfit category was absent from the internal dictionary enumeration, ... | 115 | serpro69/kotlin-faker | diff --git a/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt b/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt
index c659347f..64248c21 100644
--- a/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt
+++ b/cli-bot/src/test/kotlin/io/... | [
"should contain all providers (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should contain all functions of the provider (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should not contain deprecated functions (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"toString() should return a ... | [] | Method: Crossfit.competitions()
Location: core/src/main/kotlin/io/github/serpro69/kfaker/provider/Crossfit.kt
Inputs: none (uses the internally configured FakerService to resolve a random competition name from the “crossfit.competition” dictionary)
Outputs: String – a non‑null competition name (e.g., “CrossFit Fittest ... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"apt-get update",
"apt-get install -y -qq openjdk-8-jdk",
"echo \"org.gradle.java.installations.paths=/usr/lib/jvm/java-8-openjdk-amd64,/opt/java/openjdk\" > gradle.properties",
"./gradlew clean build --no-daemon --console=plain --info -x test -x do... | {
"num_modified_files": 7,
"num_modified_lines": 165,
"pr_author": "jgiovaresco",
"pr_labels": [
"enhancement :rocket:: New feature or request",
"core :zero::one:: Issue related to core functionality"
],
"llm_metadata": {
"code": "B2",
"code_quality": null,
"confidence": 0.87,
"detec... |
0b34d19d77aa728ed87382444908c90a63cc5f52 | 2022-01-03 04:44:29 | serpro69: Hi @humblehacker ,
This sounds like a great addition, thanks! I'll review the code later this week. | serpro69__kotlin-faker-117 | diff --git a/README.md b/README.md
index 63e2bdd2..0fcf2b49 100644
--- a/README.md
+++ b/README.md
@@ -646,10 +646,10 @@ class Test {
#### Pre-Configuring type generation for constructor params
-Some, or all, of the constructor params can be instantiated with values following some pre-configured logic using `typeG... | Add namedParameterGenerator for RandomProvider#randomClassInstance
Faker provides the ability to create a random object instance for a specific type, and to override the generation of the object's fields by type as described in this example from the documentation:
```kotlin
class Baz(val id: Int, val uuid: UUID)
... | **Title**
Add support for constructor‑parameter‑specific value generation
**Problem**
The random object creator can customize values only by type. When a class has multiple parameters of the same type, it is impossible to assign distinct or related values to each field, limiting realistic object generation.
**Roo... | 117 | serpro69/kotlin-faker | diff --git a/core/src/test/kotlin/io/github/serpro69/kfaker/provider/RandomProviderTest.kt b/core/src/test/kotlin/io/github/serpro69/kfaker/provider/RandomProviderTest.kt
index df7cb703..76da322d 100644
--- a/core/src/test/kotlin/io/github/serpro69/kfaker/provider/RandomProviderTest.kt
+++ b/core/src/test/kotlin/io/git... | [
"should contain all providers (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should contain all functions of the provider (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should not contain deprecated functions (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"toString() should return a ... | [] | Method: RandomProviderConfig.namedParameterGenerator(parameterName: String, generator: () -> K?)
Location: class **RandomProviderConfig** in package `io.github.serpro69.kfaker.provider`
Inputs:
- **parameterName** – the exact name of a constructor parameter (String).
- **generator** – a lambda returning a value... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"apt-get update",
"apt-get install -y -qq openjdk-8-jdk",
"echo \"org.gradle.java.installations.paths=/usr/lib/jvm/java-8-openjdk-amd64,/opt/java/openjdk\" > gradle.properties",
"./gradlew clean build --no-daemon --console=plain --info -x test -x do... | {
"num_modified_files": 4,
"num_modified_lines": 40,
"pr_author": "humblehacker",
"pr_labels": [
"enhancement :rocket:: New feature or request",
"core :zero::one:: Issue related to core functionality"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detect... |
e49385d3240a8e0051c28d764d5723e6dbcef10f | 2022-08-01 08:43:24 | serpro69__kotlin-faker-150 | diff --git a/core/src/main/kotlin/io/github/serpro69/kfaker/provider/StarWars.kt b/core/src/main/kotlin/io/github/serpro69/kfaker/provider/StarWars.kt
index ba987554..b065d809 100644
--- a/core/src/main/kotlin/io/github/serpro69/kfaker/provider/StarWars.kt
+++ b/core/src/main/kotlin/io/github/serpro69/kfaker/provider/S... | fix StarWars quotes by character not working
this fixes https://github.com/serpro69/kotlin-faker/issues/148
I also added tests, but i am not familiar with kotest, so maybe you should have a look first. | **Title**
Correct Star Wars character quote lookup
**Problem**
Fetching quotes by character name fails for names containing spaces, leading to missing or empty results. This breaks the public API for obtaining character‑specific quotes.
**Root Cause**
The character name is normalized using the wrong transformat... | 150 | serpro69/kotlin-faker | diff --git a/core/src/test/kotlin/io/github/serpro69/kfaker/provider/CrossfitTest.kt b/core/src/test/kotlin/io/github/serpro69/kfaker/provider/CrossfitTest.kt
index 8cc66390..ab27cef6 100644
--- a/core/src/test/kotlin/io/github/serpro69/kfaker/provider/CrossfitTest.kt
+++ b/core/src/test/kotlin/io/github/serpro69/kfake... | [
"should contain all providers (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should contain all functions of the provider (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"should not contain deprecated functions (io.github.serpro69.kfaker.app.cli.IntrospectorTest)",
"toString() should return a ... | [] | Method: StarWars.quotes(character: String)
Location: io.github.serpro69.kfaker.provider.StarWars
Inputs: character – name of a Star Wars character, case‑insensitive; underscores are treated as word separators (e.g., “admiral_ackbar” → “admiral ackbar” after lower‑casing and space‑to‑underscore conversion).
Outputs: Ret... | MIT | {
"base_image_name": "kotlin-jdk-21",
"install": [
"apt-get update",
"apt-get install -y -qq openjdk-8-jdk",
"echo \"org.gradle.java.installations.paths=/usr/lib/jvm/java-8-openjdk-amd64,/opt/java/openjdk\" > gradle.properties",
"./gradlew clean build --no-daemon --console=plain --info -x test -x do... | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "TZanke",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": f... | |
20fd61f0282a230466d7f7bb190ffd9c0bed63cf | 2023-07-06 21:29:07 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-js/pull/3364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) Report
> :exclamation: No coverage uploaded for pull request base (`v3.x@20fd61f`). [Click here to learn what that means](h... | datadog__dd-trace-js-3364 | diff --git a/benchmark/sirun/log/index.js b/benchmark/sirun/log/index.js
index d0e25521e..efafd46a1 100644
--- a/benchmark/sirun/log/index.js
+++ b/benchmark/sirun/log/index.js
@@ -18,6 +18,6 @@ log.use({
error () {}
})
-for (let i = 0; i < 1000000; i++) {
+for (let i = 0; i < 10000000; i++) {
log[WITH_LEVEL](... | v3.27.0
### Improvements
- core/redis: peer service extract host and port (#3345)
- core/kafka: extract bootstrap servers from producers and use for peer.service (#3344)
- build: update CI parametric tests (#3342)
### Bug Fixes
- core/openai: do not crash when dogstatsd not configured (#3361)
- build: incre... | **Title**
Add peer‑service metadata for Redis and Kafka, guard OpenAI metrics when DogStatsD is absent, and increase log benchmark load
**Problem**
The tracing library did not expose connection details for Redis and Kafka, causing missing peer‑service information. The OpenAI integration assumed a DogStatsD clien... | 3,364 | DataDog/dd-trace-js | diff --git a/.github/workflows/system-tests.yml b/.github/workflows/system-tests.yml
index c869d3549..8658bb206 100644
--- a/.github/workflows/system-tests.yml
+++ b/.github/workflows/system-tests.yml
@@ -58,7 +58,7 @@ jobs:
parametric:
runs-on: ubuntu-latest
env:
- CLIENTS_ENABLED: nodejs
+ TEST... | [
"should send gauges",
"should send counters",
"should send multiple metrics",
"should support tags",
"should buffer metrics",
"should not flush if the queue is empty",
"should not flush if the dns lookup fails",
"should not call DNS if the host is an IPv4 address",
"should not call DNS if the host i... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | Method: KafkajsProducerPlugin.start({ topic: string, messages: Array<object>, bootstrapServers?: string })
Location: packages/datadog-plugin-kafkajs/src/producer.js
Inputs:
- **topic** – name of the Kafka topic (string)
- **messages** – array of message objects to produce
- **bootstrapServers** – optional comma‑separa... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 8,
"num_modified_lines": 97,
"pr_author": "tlhunter",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"... |
f612de8a85911753fc2fdf2b5b51dfdf3aaac091 | 2023-07-06 21:30:24 | github-actions[bot]:
# Overall package size
Self size: 4.79 MB
Deduped: 61.53 MB
No deduping: 61.63 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/pprof | 2.2.3 | 14.25 MB | 15.13 MB |
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB ... | datadog__dd-trace-js-3365 | diff --git a/benchmark/sirun/log/index.js b/benchmark/sirun/log/index.js
index d0e25521e..efafd46a1 100644
--- a/benchmark/sirun/log/index.js
+++ b/benchmark/sirun/log/index.js
@@ -18,6 +18,6 @@ log.use({
error () {}
})
-for (let i = 0; i < 1000000; i++) {
+for (let i = 0; i < 10000000; i++) {
log[WITH_LEVEL](... | v4.6.0
### Improvements
- core/redis: peer service extract host and port (#3345)
- core/kafka: extract bootstrap servers from producers and use for peer.service (#3344)
- build: update CI parametric tests (#3342)
### Bug Fixes
- core/openai: do not crash when dogstatsd not configured (#3361)
- build: increa... | **Title**
Add peer‑service extraction for Kafka and Redis, make OpenAI safe without DogStatsD, and expand log benchmark iterations.
**Problem**
Kafka and Redis instrumentation did not expose connection information needed for peer‑service tagging. The OpenAI integration assumed a DogStatsD client was always configu... | 3,365 | DataDog/dd-trace-js | diff --git a/.github/workflows/system-tests.yml b/.github/workflows/system-tests.yml
index c869d3549..8658bb206 100644
--- a/.github/workflows/system-tests.yml
+++ b/.github/workflows/system-tests.yml
@@ -58,7 +58,7 @@ jobs:
parametric:
runs-on: ubuntu-latest
env:
- CLIENTS_ENABLED: nodejs
+ TEST... | [
"should send gauges",
"should send counters",
"should send multiple metrics",
"should support tags",
"should buffer metrics",
"should not flush if the queue is empty",
"should not flush if the dns lookup fails",
"should not call DNS if the host is an IPv4 address",
"should not call DNS if the host i... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | Method: KafkajsProducerPlugin.start({ topic, messages, bootstrapServers })
Location: packages/datadog-plugin-kafkajs/src/producer.js
Inputs:
- **topic** (string) – Kafka topic name.
- **messages** (Array) – Array of message objects to be sent.
- **bootstrapServers** (string | undefined) – Optional comma‑separated list... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 8,
"num_modified_lines": 97,
"pr_author": "tlhunter",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.78,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"... |
3a2347c872a3b6ca6c9e64212435e50d5cfa8db9 | 2023-07-07 01:13:51 | github-actions[bot]:
# Overall package size
Self size: 4.79 MB
Deduped: 61.54 MB
No deduping: 61.63 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/pprof | 2.2.3 | 14.25 MB | 15.13 MB |
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB ... | datadog__dd-trace-js-3366 | diff --git a/packages/datadog-instrumentations/src/grpc/client.js b/packages/datadog-instrumentations/src/grpc/client.js
index 305e76fad..c1a97d96b 100644
--- a/packages/datadog-instrumentations/src/grpc/client.js
+++ b/packages/datadog-instrumentations/src/grpc/client.js
@@ -1,7 +1,7 @@
'use strict'
const types = ... | Convert grpc to use tracing channel
### What does this PR do?
grpc client and server instrumentation has been converted to use the tracing channel pattern rather than `AsyncResource`.
### Motivation
This is an attempt to resolve an AsyncResource leak caused by the grpc instrumentation by eliminating its use.
| **Title**
Replace AsyncResource‑based gRPC instrumentation with tracing channels and introduce full IAST telemetry support
**Problem**
- The gRPC client and server instrumentations relied on `AsyncResource`, which caused a resource‑leak in long‑running services.
- IAST components (analyzers, taint‑tracking, pl... | 3,366 | DataDog/dd-trace-js | diff --git a/packages/dd-trace/test/appsec/iast/analyzers/ldap-injection-analyzer.spec.js b/packages/dd-trace/test/appsec/iast/analyzers/ldap-injection-analyzer.spec.js
index 48223e1f1..59413db0a 100644
--- a/packages/dd-trace/test/appsec/iast/analyzers/ldap-injection-analyzer.spec.js
+++ b/packages/dd-trace/test/appse... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should set telemetry default values",
"should set DD_TELEMETRY_METRICS_ENABLED"
] | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Method: Analyzer.configure(self, enabled)
Location: packages/dd-trace/src/appsec/iast/analyzers/vulnerability-analyzer.js
Inputs: enabled – boolean indicating whether the analyzer should be activated.
Outputs: None. Calls the Plugin.configure method; ensures the analyzer’s onConfigure hook runs only once.
Description: ... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 34,
"num_modified_lines": 978,
"pr_author": "Qard",
"pr_labels": [
"bug: Something isn't working",
"semver-patch"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.71,
"detected_issues": {
"B1": false,
"B2": false,
"B3"... |
4165f1679b5d906320af7242e6851ab4a84ca413 | 2023-07-10 10:08:34 | github-actions[bot]:
# Overall package size
Self size: 4.81 MB
Deduped: 61.55 MB
No deduping: 61.64 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/pprof | 2.2.3 | 14.25 MB | 15.13 MB |
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB ... | datadog__dd-trace-js-3376 | diff --git a/packages/datadog-plugin-cassandra-driver/src/index.js b/packages/datadog-plugin-cassandra-driver/src/index.js
index e717726be..f60f63182 100644
--- a/packages/datadog-plugin-cassandra-driver/src/index.js
+++ b/packages/datadog-plugin-cassandra-driver/src/index.js
@@ -14,7 +14,7 @@ class CassandraDriverPlug... | Refactor naming schema
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Refactor service naming and test framework for service naming to fit with needs of aws-sdk and http server plugins for service naming.
* move to object unpacking for arguments of `TracingP... | **Title**
Unify service and operation naming APIs across plugins and schemas
**Problem**
Plugins and the naming schema relied on positional arguments for service and operation names, leading to mismatched signatures, limited extensibility, and incorrect service naming in edge cases (e.g., custom service function... | 3,376 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 60ddd12db..97c4d39d0 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -248,7 +248,7 @@ testFrameworks.forEach(({
testOutput += chunk.toString()
})... | [
"should forward additional args to serviceName and add configured service"
] | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | Method: TracingPlugin.serviceName(opts = {})
Location: packages/dd-trace/src/plugins/tracing.js
Inputs: an optional options object – typically `{ pluginConfig, system, connectionName, ... }`. The object may contain the original plugin configuration, the system name (e.g., “redis”, “mysql”), a connection name for spli... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 16,
"num_modified_lines": 82,
"pr_author": "rarguelloF",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
... |
0b196399b7e22a22f50de4f27d54c0af3953dca6 | 2023-07-12 15:10:19 | github-actions[bot]:
# Overall package size
Self size: 4.87 MB
Deduped: 57.86 MB
No deduping: 57.95 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 1... | datadog__dd-trace-js-3386 | diff --git a/README.md b/README.md
index 71c9ca046..94ee1ce56 100644
--- a/README.md
+++ b/README.md
@@ -143,8 +143,8 @@ $ yarn leak:plugins
### Linting
-We use [ESLint](https://eslint.org) to make sure that new code is
-conform to our coding standards.
+We use [ESLint](https://eslint.org) to make sure that new co... | Fix same dependency detection
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
If the same library name is loaded from different `node_modules` directories, this library could be reported twice if they have different version number.
### Motivation
<!-- What i... | **Title**
Prevent duplicate dependency telemetry when the same package is loaded from multiple locations
**Problem**
If a library is present in more than one `node_modules` directory, the tracer can emit multiple entries for that library—once for each location—and may omit other expected dependencies.
**Root ... | 3,386 | DataDog/dd-trace-js | diff --git a/packages/dd-trace/test/telemetry/dependencies.spec.js b/packages/dd-trace/test/telemetry/dependencies.spec.js
index 5ccaa6d18..e3084c9ef 100644
--- a/packages/dd-trace/test/telemetry/dependencies.spec.js
+++ b/packages/dd-trace/test/telemetry/dependencies.spec.js
@@ -198,6 +198,73 @@ describe('dependencies... | [
"should include two dependencies when they are in different paths"
] | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | No new interfaces are introduced. | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 2,
"num_modified_lines": 26,
"pr_author": "uurien",
"pr_labels": [
"semver-patch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5... |
556237873e0222fbfd46af14434e2df5efe81c6c | 2023-07-14 16:07:08 | github-actions[bot]:
# Overall package size
Self size: 4.88 MB
Deduped: 57.98 MB
No deduping: 58.08 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 1... | datadog__dd-trace-js-3395 | diff --git a/packages/datadog-instrumentations/src/http2/client.js b/packages/datadog-instrumentations/src/http2/client.js
index 5e2fb0742..de4957318 100644
--- a/packages/datadog-instrumentations/src/http2/client.js
+++ b/packages/datadog-instrumentations/src/http2/client.js
@@ -30,6 +30,8 @@ function createWrapEmit (... | add support for remote tracing configuration
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Add support for remote tracing configuration. I also added some basic change detection so that changes can be reported to telemetry.
### Motivation
<!-- What inspi... | **Title**
Enable dynamic remote tracing configuration and related telemetry
**Problem**
Tracing options could only be set at process start and could not be updated from the UI.
Remote configuration changes were not merged with existing settings, nor reported to telemetry.
**Root Cause**
Configuration hand... | 3,395 | DataDog/dd-trace-js | diff --git a/packages/datadog-plugin-http/test/client.spec.js b/packages/datadog-plugin-http/test/client.spec.js
index 67fc04327..c5139f78d 100644
--- a/packages/datadog-plugin-http/test/client.spec.js
+++ b/packages/datadog-plugin-http/test/client.spec.js
@@ -1131,7 +1131,7 @@ describe('Plugin', () => {
con... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should sanitize the sample rate to be between 0 and 1",
"should support applying remote config",
"startupLog should be formatted correctly",
"should pass the sampling options to the priority sampler",
"should... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Method: Tracer.configure({ env, sampler })
Location: packages/dd-trace/src/tracer.js – added as a public method of the `Tracer` class.
Inputs:
- `env` (string): the environment name to set on the tracer’s priority sampler.
- `sampler` (object): sampler configuration containing at least `sampleRate` (number between 0 a... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 15,
"num_modified_lines": 240,
"pr_author": "rochdev",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
... |
3cd0704caefc15738f0be4db88baa2f33393a90a | 2023-07-17 11:29:04 | github-actions[bot]:
# Overall package size
Self size: 4.89 MB
Deduped: 57.99 MB
No deduping: 58.09 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 1... | datadog__dd-trace-js-3401 | diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml
index 93c8ad824..20e03df15 100644
--- a/.github/workflows/plugins.yml
+++ b/.github/workflows/plugins.yml
@@ -182,24 +182,25 @@ jobs:
uses: ./.github/actions/testagent/logs
- uses: codecov/codecov-action@v2
- # couchbase:
- #... | Add BITBUCKET_GIT_HTTP_ORIGIN env variable
### What does this PR do?
This PR adds `BITBUCKET_GIT_HTTP_ORIGIN` support to `dd-trace-js`, this was not supported previously.
### Motivation
BitBucket has multiple ways of defining the git repository URL, these should be supported in `dd-trace-js`
[1]: https://github.c... | **Title**
Enhance CI, configuration, and plugin handling (Bitbucket HTTP origin, peer‑service logic, GraphQL naming, OpenAI, Jest, etc.)
**Problem**
The library had several gaps: Bitbucket repositories could lose their repository URL, peer‑service tags were computed with incorrect defaults, Jest tests did not capt... | 3,401 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 8b716d560..60ddd12db 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -230,6 +230,28 @@ testFrameworks.forEach(({
}).catch(done)
})
})
+ ... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should activate peer service in v1 unless explicitly false",
"should give priority to the options",
"should always add single span ingestion tags from options if present",
... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Function: withNamingSchema(spanProducerFn, expectedOpName, expectedServiceName, expectedShortCircuitName, selectSpan = (traces) => traces[0][0])
Location: packages/dd-trace/test/setup/mocha.js
Inputs:
- **spanProducerFn** *(Function)* – a function that creates the operation (e.g., runs a GraphQL query) whose spans will... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 25,
"num_modified_lines": 179,
"pr_author": "ericlaz",
"pr_labels": [
"ci-app",
"semver-patch"
],
"llm_metadata": {
"code": "B1|B4",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B... |
3cd0704caefc15738f0be4db88baa2f33393a90a | 2023-07-18 23:05:40 | github-actions[bot]:
# Overall package size
Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13.38... | datadog__dd-trace-js-3412 | diff --git a/packages/datadog-instrumentations/src/jest.js b/packages/datadog-instrumentations/src/jest.js
index e76240a2d..00eeea369 100644
--- a/packages/datadog-instrumentations/src/jest.js
+++ b/packages/datadog-instrumentations/src/jest.js
@@ -129,8 +129,7 @@ function getWrappedEnvironment (BaseEnvironment, jestVe... | Ensure OTel span name is copied to resource.name
### What does this PR do?
Copies the OTel span name input to the `resource.name` tag.
### Motivation
We plan to change the operation name of the span to better align with how OTel intends it to work. For now, we want to make sure we're capturing the existing val... | **Title**
Align OpenTelemetry span handling with resource naming and correct ancillary integrations
**Problem**
OpenTelemetry spans were not propagating their original name to the `resource.name` tag, risking loss of identifying information when operation names are later altered. Additionally, several internal c... | 3,412 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 8b716d560..60ddd12db 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -230,6 +230,28 @@ testFrameworks.forEach(({
}).catch(done)
})
})
+ ... | [
"should always add single span ingestion tags from options if present",
"should properly sample a single span",
"should consider missing service as match-all for service name",
"should consider missing name as match-all for span name",
"should stop at first rule match",
"should use span service name tags ... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | Method: DatadogSpanContext.constructor(props)
Location: packages/dd-trace/src/opentracing/span_context.js → class `DatadogSpanContext`
Inputs: `props` – an object that may contain `sampling` (object) and other span‑context fields.
Outputs: Initializes a new span‑context instance. **New behavior:** ensures `this._... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 7,
"num_modified_lines": 25,
"pr_author": "Qard",
"pr_labels": [
"semver-patch"
],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.86,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5"... |
3cd0704caefc15738f0be4db88baa2f33393a90a | 2023-07-19 00:37:49 | github-actions[bot]:
# Overall package size
Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13.38... | datadog__dd-trace-js-3414 | diff --git a/packages/datadog-instrumentations/src/jest.js b/packages/datadog-instrumentations/src/jest.js
index e76240a2d..00eeea369 100644
--- a/packages/datadog-instrumentations/src/jest.js
+++ b/packages/datadog-instrumentations/src/jest.js
@@ -129,8 +129,7 @@ function getWrappedEnvironment (BaseEnvironment, jestVe... | Make datadog distributed tracing header take priority over tracecontext
### What does this PR do?
Makes the datadog distributed tracing headers take priority over w3c tracecontext.
### Motivation
Some cloud providers such as GCP inject their _own_ traceparent headers between services, altering the parentage wi... | **Title**
Prioritize Datadog propagation, fix sampling handling and improve CI/test and profiling metadata
**Problem**
When upstream services inject W3C `traceparent` headers, the tracer may select those over Datadog’s own headers, breaking the end‑to‑end trace link. Additionally, several components were not attac... | 3,414 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 8b716d560..60ddd12db 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -230,6 +230,28 @@ testFrameworks.forEach(({
}).catch(done)
})
})
+ ... | [
"should initialize with the correct defaults",
"should always add single span ingestion tags from options if present",
"should properly sample a single span",
"should consider missing service as match-all for service name",
"should consider missing name as match-all for span name",
"should stop at first r... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Method: SpanSampler.sample(span)
Location: packages/dd-trace/src/span_sampler.js (class SpanSampler)
Inputs: *span* – an instance of a Datadog Span whose `.context()` method returns a SpanContext.
Outputs: Mutates the span’s context by adding or updating the internal `_spanSampling` property with an object `{ sam... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 8,
"num_modified_lines": 26,
"pr_author": "Qard",
"pr_labels": [
"bug: Something isn't working",
"semver-patch"
],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.9,
"detected_issues": {
"B1": true,
"B2": false,
"B3": fa... |
fc014bbdbd8a8a9f47fb3bfc4406411fd8ae32da | 2023-07-19 11:07:25 | codecov[bot]: ## [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-js/pull/3415?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) Report
> Merging [#3415](https://app.codecov.io/gh/DataDog/dd-trace-js/pull/3415?src=pr&el=desc&utm_medium=referral&utm_sou... | datadog__dd-trace-js-3415 | diff --git a/.gitlab/benchmarks.yml b/.gitlab/benchmarks.yml
index bb907aee0..e9040c90e 100644
--- a/.gitlab/benchmarks.yml
+++ b/.gitlab/benchmarks.yml
@@ -39,7 +39,8 @@ benchmarks-pr-comment:
- export REPORTS_DIR="$(pwd)/reports/" && (mkdir "${REPORTS_DIR}" || :)
- git config --global url."https://gitlab-ci... | Add ci-app-libraries team as code owner of CI Visibility files
### What does this PR do?
Set ci-app-libraries team as owners of CI Visibility files
### Motivation
Make reviews faster
| **Title**
Improve CI ownership, update dependencies, and enhance bundler instrumentation support
**Problem**
The repository lacked explicit code owners for CI‑visibility files, causing slower review cycles. Several dependency versions were outdated, leading to compatibility and security concerns. Instrumentation f... | 3,415 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 97c4d39d0..a9cb5b90a 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -18,7 +18,8 @@ const {
TEST_CODE_COVERAGE_ENABLED,
TEST_ITR_SKIPPING_ENABLED,
TEST_ITR_... | [
"observes configuration options"
] | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | Method: BaseAwsSdkPlugin.operationFromRequest(request)
Location: packages/datadog-plugin-aws-sdk/src/base.js → class BaseAwsSdkPlugin
Inputs:
- **request** *(Object)* – the AWS SDK request object; expected to contain at least `operation` (string) and other fields used by subclasses.
Outputs:
- **String** – the name o... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 35,
"num_modified_lines": 1205,
"pr_author": "juan-fernandez",
"pr_labels": [
"semver-patch",
"dont-land-on-v2.x: If a commit depends on a major change not included in v2.x",
"dont-land-on-v3.x: If a commit depends on a major change not included in v3.x",
"dont-land-on-v4... |
257294b6a3117b06f9b1518ab892c1e34824ffb0 | 2023-07-19 16:59:15 | github-actions[bot]:
# Overall package size
Self size: 4.91 MB
Deduped: 58 MB
No deduping: 58.1 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13.38... | datadog__dd-trace-js-3419 | diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml
index 93c8ad824..1326c7c6e 100644
--- a/.github/workflows/plugins.yml
+++ b/.github/workflows/plugins.yml
@@ -778,6 +778,23 @@ jobs:
uses: ./.github/actions/testagent/logs
- uses: codecov/codecov-action@v2
+ openai:
+ runs-... | Fix service representation config
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Defaults and computation for service representation (mostly peer service flag) were missing tests and had unaccounted for edge cases.
| **Title**
Correct service naming and peer‑service configuration handling
**Problem**
Service representation logic produced inconsistent peer‑service tags and could fail when configuration objects or API keys were missing. Missing defaults and edge‑case handling also led to empty telemetry payloads.
**Root Cau... | 3,419 | DataDog/dd-trace-js | diff --git a/packages/datadog-plugin-openai/test/index.spec.js b/packages/datadog-plugin-openai/test/index.spec.js
index f981f50d4..cf3411ef3 100644
--- a/packages/datadog-plugin-openai/test/index.spec.js
+++ b/packages/datadog-plugin-openai/test/index.spec.js
@@ -6,12 +6,15 @@ const { expect } = require('chai')
const... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should activate peer service in v1 unless explicitly false",
"should give priority to the options",
"should always add single span ingestion tags from options if present",
... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Function: Config(options?)
Location: packages/dd-trace/src/config.js
Inputs: Optional **options** object – may contain `spanAttributeSchema` (string, `'v0'` or `'v1'`), `spanComputePeerService` (boolean), `spanRemoveIntegrationFromService` (boolean), `peerServiceMapping` (object mapping integration names to service nam... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 11,
"num_modified_lines": 89,
"pr_author": "jbertran",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
... |
87dc2b7a67b9b910d12b826640e90b4b6ed6feb8 | 2023-07-19 22:10:21 | github-actions[bot]:
# Overall package size
Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.09 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13.38... | datadog__dd-trace-js-3421 | diff --git a/packages/dd-trace/src/telemetry/metrics.js b/packages/dd-trace/src/telemetry/metrics.js
index 7348daaa2..fbdb568b2 100644
--- a/packages/dd-trace/src/telemetry/metrics.js
+++ b/packages/dd-trace/src/telemetry/metrics.js
@@ -25,6 +25,10 @@ function mapToJsonArray (map) {
return Array.from(map.values()).m... | Exclude empty telemetry metrics
### What does this PR do?
Excludes empty telemetry metrics from being sent.
### Motivation
If a metric has not been updated since the last reporting interval it will contain an empty points list. The backend processor considers this an error so the metric should instead be omitt... | **Title**
Prevent transmission of telemetry metrics that contain no data points
**Problem**
When a metric is not updated during a reporting interval it remains in the collection with an empty points list. Sending such empty metrics triggers an error in the backend processor.
**Root Cause**
The telemetry ser... | 3,421 | DataDog/dd-trace-js | diff --git a/packages/dd-trace/test/telemetry/metrics.spec.js b/packages/dd-trace/test/telemetry/metrics.spec.js
index a471d5865..27a2d66de 100644
--- a/packages/dd-trace/test/telemetry/metrics.spec.js
+++ b/packages/dd-trace/test/telemetry/metrics.spec.js
@@ -157,6 +157,33 @@ describe('metrics', () => {
]
... | [
"should not send empty metrics",
"should skip empty metrics"
] | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should initialize with the correct defaults",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from t... | No new interfaces are introduced. | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 1,
"num_modified_lines": 11,
"pr_author": "Qard",
"pr_labels": [
"bug: Something isn't working",
"semver-patch"
],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": f... |
2456bd330a51593d1a80331cd3b359d4c1103885 | 2023-07-20 08:13:22 | github-actions[bot]:
# Overall package size
Self size: 4.91 MB
Deduped: 58 MB
No deduping: 58.1 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13.38... | datadog__dd-trace-js-3424 | diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml
index 1326c7c6e..20e03df15 100644
--- a/.github/workflows/plugins.yml
+++ b/.github/workflows/plugins.yml
@@ -182,24 +182,25 @@ jobs:
uses: ./.github/actions/testagent/logs
- uses: codecov/codecov-action@v2
- # couchbase:
- #... | Add exclusions for weak hash vulnerabilities
### What does this PR do?
Excludes Weak Hash vulnerability detection for legit use in `mongodb`, `sqreen` and `pusher` libraries.
### Motivation
We are detecting as vulnerability each time a vulnerable hashing algorithm is used in the customer application.
In some case... | **Title**
Refactor tracing APIs, improve environment detection, and add weak‑hash exclusions
**Problem**
Several tracing plugins were using outdated signatures, causing incorrect service and operation names and missed span lifecycles. The weak‑hash analyzer was flagging legitimate library usage, and the CI confi... | 3,424 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 60ddd12db..97c4d39d0 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -248,7 +248,7 @@ testFrameworks.forEach(({
testOutput += chunk.toString()
})... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should activate peer service in v1 unless explicitly false",
"should give priority to the options",
"should not set DD_TRACE_TELEMETRY_ENABLED if Azure Consumption Plan Fun... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Function: withNamingSchema(spanProducerFn, expected, selectSpan = (traces) => traces[0][0], opts = {})
Location: packages/dd-trace/test/setup/mocha.js
Inputs:
- spanProducerFn: Function – a function that produces a span (or executes instrumented code) when called.
- expected: Object – a mapping of schema version string... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 43,
"num_modified_lines": 385,
"pr_author": "CarlesDD",
"pr_labels": [
"semver-patch",
"asm-iast"
],
"llm_metadata": {
"code": null,
"code_quality": null,
"confidence": null,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"... |
23f9b8a7dae30d7902a1d5de3e8d3e158d166f6f | 2023-07-20 14:13:44 | github-actions[bot]:
# Overall package size
Self size: 4.91 MB
Deduped: 58.01 MB
No deduping: 58.1 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13... | datadog__dd-trace-js-3426 | diff --git a/.eslintignore b/.eslintignore
index 4995ab9bc..6803a9b63 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -6,3 +6,4 @@ node_modules
versions
acmeair-nodejs
vendor
+integration-tests/esbuild/out.js
diff --git a/.eslintrc.json b/.eslintrc.json
index b04698f66..fe6ef8899 100644
--- a/.eslintrc.json
+++ b/... | V4.8.0 proposal
### Features
- profiling: Associate tracing span IDs with samples in the wall profiler (#3371)
- iast: Taint request URI (#3302)
- iast: Detect missing header vulnerabilities (#3269)
- graphql: implement naming schema for graphql plugin (#3279)
### Enhancements
- openai: be defensive about res... | **Title**
Release 4.8.0 – configuration fixes, IAST header analyzers, OpenAI robustness, profiling enhancements, and CI updates
**Problem**
Several components were mis‑configuring defaults or omitting critical data, leading to false‑negative security findings, missing trace tags, unstable OpenAI instrumentation,... | 3,426 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 8b716d560..97c4d39d0 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -230,6 +230,28 @@ testFrameworks.forEach(({
}).catch(done)
})
})
+ ... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should activate peer service in v1 unless explicitly false",
"should give priority to the options",
"should always add single span ingestion tags from options if present",
... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Method: Analyzer(key_params...)
Location: packages/dd-trace/src/appsec/iast/analyzers/vulnerability-analyzer.js
Inputs:
- No constructor parameters.
Outputs:
- Instance of Analyzer.
Description: Constructs an Analyzer used for IAST vulnerability detection. Provides internal methods such as _createHash for generatin... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 50,
"num_modified_lines": 609,
"pr_author": "szegedi",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": null,
"code_quality": null,
"confidence": null,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
... |
51eabba682d52cb52204e569016da1038a035cd3 | 2023-07-20 14:46:13 | github-actions[bot]:
# Overall package size
Self size: 4.91 MB
Deduped: 58.01 MB
No deduping: 58.1 MB
# Dependency sizes
| name | version | self size | total size |
|------|---------|-----------|------------|
| @datadog/native-iast-taint-tracking | 1.5.0 | 14.86 MB | 14.86 MB |
| @datadog/native-appsec | 3.2.0 | 13... | datadog__dd-trace-js-3427 | diff --git a/.eslintignore b/.eslintignore
index 4995ab9bc..6803a9b63 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -6,3 +6,4 @@ node_modules
versions
acmeair-nodejs
vendor
+integration-tests/esbuild/out.js
diff --git a/.eslintrc.json b/.eslintrc.json
index b04698f66..fe6ef8899 100644
--- a/.eslintrc.json
+++ b/... | V3.29.0 proposal
### Features
- profiling: Associate tracing span IDs with samples in the wall profiler (#3371)
- iast: Taint request URI (#3302)
- iast: Detect missing header vulnerabilities (#3269)
- graphql: implement naming schema for graphql plugin (#3279)
### Enhancements
- openai: be defensive about re... | **Title**
Release 3.29.0 – Linting, CI, configuration, IAST, OpenAI, profiling and telemetry improvements
**Problem**
The codebase contained several inconsistencies and missing safeguards: linting rules were outdated, CI pipelines for Couchbase and OpenAI plugins were disabled, configuration handling for propaga... | 3,427 | DataDog/dd-trace-js | diff --git a/integration-tests/ci-visibility.spec.js b/integration-tests/ci-visibility.spec.js
index 8b716d560..97c4d39d0 100644
--- a/integration-tests/ci-visibility.spec.js
+++ b/integration-tests/ci-visibility.spec.js
@@ -230,6 +230,28 @@ testFrameworks.forEach(({
}).catch(done)
})
})
+ ... | [
"should initialize with the correct defaults",
"should initialize from environment variables",
"should initialize from the options",
"should activate peer service in v1 unless explicitly false",
"should give priority to the options",
"should always add single span ingestion tags from options if present",
... | [
"should sample a span",
"should sample a span by span name",
"should not sample by default",
"should sample if `measuredByDefault` is true",
"should support logging",
"should not warn on undefined DD_TRACE_SPAN_ATTRIBUTE_SCHEMA",
"should initialize from the default service",
"should initialize from th... | Method: NoopExternalLogger.__init__(self)
Location: packages/dd-trace/src/external-logger/src/index.js
Inputs: None (no parameters)
Outputs: An instance of NoopExternalLogger – a logger object whose methods are no‑ops.
Description: Constructs a logger that silently discards all logging calls. Used by the OpenAI plugin ... | custom-check-github | {
"base_image_name": "node_20",
"install": [
"export DEBIAN_FRONTEND=noninteractive",
"apt-get update -qq",
"apt-get install -y -qq yarn",
"npm install -g --force yarn",
"yarn install --frozen-lockfile --non-interactive --silent"
],
"log_parser": "parse_log_js_4",
"test_cmd": "yarn test:tr... | {
"num_modified_files": 50,
"num_modified_lines": 609,
"pr_author": "szegedi",
"pr_labels": [
"semver-minor"
],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.87,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
... |
36a02edf11bb606c23e282b688b66d097842ebf0 | 2021-06-16 16:06:01 | tailwindlabs__tailwindcss-4666 | diff --git a/src/lib/expandApplyAtRules.js b/src/lib/expandApplyAtRules.js
index 056057c1..e9de7713 100644
--- a/src/lib/expandApplyAtRules.js
+++ b/src/lib/expandApplyAtRules.js
@@ -3,6 +3,11 @@ import { resolveMatches } from './generateRules'
import bigSign from '../util/bigSign'
import escapeClassName from '../uti... | Throw when applying`.group`
This PR will ensure that an error will be thrown when applying the `.group` class.
This is because, `.group` does not actually exist.
Fixes: #4553 | **Title**
Error out when `@apply` is used with the non‑existent `.group` utility
**Problem**
`@apply` silently accepted the `.group` utility even though it does not correspond to an actual CSS class, potentially producing invalid output. Additionally, the default Tailwind configuration unintentionally injected a... | 4,666 | tailwindlabs/tailwindcss | diff --git a/tests/jit/apply.test.js b/tests/jit/apply.test.js
index 08992239..3dba79d3 100644
--- a/tests/jit/apply.test.js
+++ b/tests/jit/apply.test.js
@@ -11,6 +11,10 @@ function run(input, config = {}) {
})
}
+function css(templates) {
+ return templates.join('')
+}
+
test('@apply', () => {
let config =... | [
"@apply error when using .group utility",
"@apply error when using a prefixed .group utility"
] | [
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused backwards infinite ease-in 1s 2s name\" correctly",
"should parse \"paused backwards infinite ease-in 1s 2s name normal\" correc... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 2,
"num_modified_lines": 12,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e36d242c8d26631c4e040be29d9375015f0e2292 | 2021-07-09 17:02:18 | mainej: +1 I'd love to have this too. Would address https://github.com/tailwindlabs/tailwindcss-forms/issues/25 | tailwindlabs__tailwindcss-4936 | diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 35cd0c10..cfd8d5c2 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -27,7 +27,7 @@ npm run style -- --fix
You can run the test suite using the following commands:
```sh
-npm test
+npm run babelify && npm test
```
Please en... | Add variant for `::file-selector-button` pseudo element
This PR adds a variant for the [`::file-selector-button`](https://developer.mozilla.org/en-US/docs/Web/CSS/::file-selector-button) pseudo element, which is supported by the latest versions of all three engines.
I think I've added to the relevant tests but feel... | **Title**
Add support for the `::file-selector-button` pseudo‑element variant and improve safelist, nesting, and CLI handling
**Problem**
Tailwind CSS did not provide a variant for the `::file-selector-button` pseudo‑element, preventing developers from styling file input buttons with utility classes. At the same... | 4,936 | tailwindlabs/tailwindcss | diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
new file mode 100644
index 00000000..7e314924
--- /dev/null
+++ b/.github/workflows/integration-tests.yml
@@ -0,0 +1,59 @@
+name: Integration Tests
+
+on:
+ push:
+ branches: [master]
+ pull_request:
+ branches: [mast... | [
"should safelist strings",
"should safelist based on a pattern regex",
"should not generate duplicates",
"should safelist when using a custom prefix",
"should warn when we detect nested css",
"should only warn for the first detected nesting",
"experimental universal selector improvements (child selector... | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should parse \"black\" to the correct value",
"should parse \"#0088cc\" to the correct value",
"should parse \"#08c\" to the correct value",
"should parse \"#0088cc99\" to the correc... | Method: RunProcess.onStderr(messageMatcher)
Location: src/integrations/execute.js – returned object from the `$` helper used in integration tests.
Inputs: `messageMatcher` – a function that receives a string (the stderr line) and returns a boolean indicating if the condition is satisfied (e.g., `msg => msg.includes... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 37,
"num_modified_lines": 396,
"pr_author": "lukewarlow",
"pr_labels": [],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.86,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
4142b3fbaf1d9ba8934a149277ce69978db52413 | 2021-09-03 11:50:54 | tailwindlabs__tailwindcss-5378 | diff --git a/src/lib/expandApplyAtRules.js b/src/lib/expandApplyAtRules.js
index e9de7713..ed3caa13 100644
--- a/src/lib/expandApplyAtRules.js
+++ b/src/lib/expandApplyAtRules.js
@@ -97,6 +97,7 @@ function processApply(root, context) {
for (let util of candidates) {
applyCandidates.add(util)
}
+
a... | Support `@apply` for classes outside of a `@layer`
This PR will allow you to apply classes that are not inside a `@layer` directive. This is an important part of making JIT the default for backwards compatibility reasons. In short:
The following already worked:
```css
@tailwind utilities;
.foo {
@apply bg-re... | **Title**
Allow `@apply` to reference classes defined outside of `@layer` directives
**Problem**
`@apply` could only use utilities that were emitted from Tailwind’s defined layers. Custom or plain CSS rules that lived outside any `@layer` were ignored, causing a syntax error when such selectors were referenced. ... | 5,378 | tailwindlabs/tailwindcss | diff --git a/tests/apply.test.js b/tests/apply.test.js
index 0c96c273..182e0214 100644
--- a/tests/apply.test.js
+++ b/tests/apply.test.js
@@ -1,7 +1,7 @@
import fs from 'fs'
import path from 'path'
-import { run, css } from './util/run'
+import { run, html, css } from './util/run'
test('@apply', () => {
let ... | [
"@apply classes from outside a @layer",
"@applying classes from outside a @layer respects the source order"
] | [
"it parses simple single class definitions",
"it parses multiple class definitions",
"it parses nested pseudo-selectors",
"it parses top-level media queries",
"it parses nested media queries",
"it bubbles nested screen rules",
"it parses pseudo-selectors in nested media queries",
"it parses descendant... | Function: html(strings, ...values)
Location: src/util/run.js (exported from `./util/run`)
Inputs: • `strings` – an array of string literals from a tagged template literal.
• `...values` – any interpolated values (typically strings) to be concatenated.
The function concatenates the parts to produce a plain HTML ... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 3,
"num_modified_lines": 46,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
e37931ba65922842db6d6bc124210f8762fa4d7d | 2021-09-03 12:18:14 | tailwindlabs__tailwindcss-5379 | diff --git a/src/util/resolveConfig.js b/src/util/resolveConfig.js
index ffb94d1a..c031b0ee 100644
--- a/src/util/resolveConfig.js
+++ b/src/util/resolveConfig.js
@@ -123,6 +123,12 @@ function resolveFunctionKeys(object) {
return val === undefined ? defaultValue : val
}
+ resolvePath.theme = resolvePath
+
+ ... | Port `@layer` tests from AOT to JIT mode | **Title**
Enable proper `@layer` handling in JIT mode by fixing configuration resolution
**Problem**
`@layer` directives that rely on theme values fail when Tailwind runs in JIT mode. The existing configuration resolver does not expose the necessary theme accessor and utility helpers, causing lookup errors during ... | 5,379 | tailwindlabs/tailwindcss | diff --git a/tests/layer-at-rules.test.js b/tests/layer-at-rules.test.js
index ac89d178..2cb7c11b 100644
--- a/tests/layer-at-rules.test.js
+++ b/tests/layer-at-rules.test.js
@@ -49,3 +49,134 @@ test('custom user-land utilities', () => {
`)
})
})
+
+test('layers are grouped and inserted at the matching @tailwi... | [
"all helpers can be destructured from the first function argument"
] | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"it flattens nested color objects",
"it flattens deeply nested color objects",
"it handles empty objects",
"it prefixes classes with the provided prefix",
"it handles a function as ... | Function: resolveConfig(configs)
Location:
Inputs: an array of configuration objects (e.g., userConfig, defaultConfig). Each object may define theme values as functions that receive a destructured helpers object `{ theme, colors, negative, breakpoints }` allowing look‑ups and transformations.
Outputs: a single merged T... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 1,
"num_modified_lines": 6,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
e37931ba65922842db6d6bc124210f8762fa4d7d | 2021-09-03 14:09:02 | tailwindlabs__tailwindcss-5382 | diff --git a/src/util/resolveConfig.js b/src/util/resolveConfig.js
index ffb94d1a..c031b0ee 100644
--- a/src/util/resolveConfig.js
+++ b/src/util/resolveConfig.js
@@ -123,6 +123,12 @@ function resolveFunctionKeys(object) {
return val === undefined ? defaultValue : val
}
+ resolvePath.theme = resolvePath
+
+ ... | Unify config helpers into single object
This PR makes it possible to destructure all the config helpers from the first parameter so that you don't need to have an unused `theme` parameter just to access the second parameter.
```diff
- colors: (theme, { colors }) => ({ colors })
+ colors: ({ theme, colors }) => ({ ... | **Title**
Expose config helper utilities on the theme resolver function
**Problem**
Consumers of the configuration API had to accept a separate `theme` argument just to reach the helper utilities, leading to unnecessary boilerplate and confusing signatures.
**Root Cause**
The resolver function that provides... | 5,382 | tailwindlabs/tailwindcss | diff --git a/tests/resolveConfig.test.js b/tests/resolveConfig.test.js
index 0be4482f..bcba03bd 100644
--- a/tests/resolveConfig.test.js
+++ b/tests/resolveConfig.test.js
@@ -2215,3 +2215,62 @@ test('plugins are merged', () => {
plugins: ['1', '2', '3'],
})
})
+
+test('all helpers can be destructured from the ... | [
"all helpers can be destructured from the first function argument"
] | [
"it flattens nested color objects",
"it flattens deeply nested color objects",
"it handles empty objects",
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should be possible to load a custom nesting plugin",
"should be possible ... | Method: resolvePath.theme(path: string | string[]) → any
Location: src/util/resolveConfig.js (attached to the resolvePath function used to evaluate user‑provided theme functions)
Inputs: a string or array representing a path inside the theme configuration (e.g., `"fontWeight.bold"` or `["spacing", "2"]`).
Outputs... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 1,
"num_modified_lines": 6,
"pr_author": "reinink",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... | |
4f89215d88a1071f44361b5de4205714834b9954 | 2021-09-03 15:45:38 | tailwindlabs__tailwindcss-5383 | diff --git a/src/lib/setupContextUtils.js b/src/lib/setupContextUtils.js
index 9c6b3325..26ba8e29 100644
--- a/src/lib/setupContextUtils.js
+++ b/src/lib/setupContextUtils.js
@@ -499,7 +499,7 @@ function registerPlugins(plugins, context) {
pluginItem(pluginApi)
}
} else {
- plugin(pluginApi)
+... | Add custom plugins tests
- add tests for the plugin API
- make plugin invocation optional
Ported these tests from the AOT engine. | **Title**
Safely handle optional custom plugins during registration
**Problem**
The plugin registration logic unconditionally invoked a plugin argument, causing runtime errors when a plugin value is absent. Tests for the plugin API expect that plugins can be omitted without breaking the build.
**Root Cause** ... | 5,383 | tailwindlabs/tailwindcss | diff --git a/tests/custom-plugins.test.js b/tests/custom-plugins.test.js
new file mode 100644
index 00000000..1256ff8b
--- /dev/null
+++ b/tests/custom-plugins.test.js
@@ -0,0 +1,1894 @@
+import createPlugin from './../plugin'
+import { run, html, css } from './util/run'
+
+test('plugins can create utilities with objec... | [
"plugins can provide a config but no handler"
] | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"it adds the right custom property",
"it ignores colors that cannot be parsed",
"it ignores colors that already have an alpha channel",
"it allows a closure to be passed",
"it trans... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 1,
"num_modified_lines": 1,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
c315db5f150428f6d8e0b2f6c83de63feb6ca036 | 2021-09-03 15:55:53 | tailwindlabs__tailwindcss-5384 | diff --git a/colors.js b/colors.js
index 4f94e2c2..f8797e77 100644
--- a/colors.js
+++ b/colors.js
@@ -1,146 +1,149 @@
-let warned = false
+let warned = []
+
+function warn({ version, from, to }) {
+ if (!warned.includes(from)) {
+ console.log(`warn - As of Tailwind CSS ${version}, \`${from}\` has been renamed to \... | Enable extended color palette
This PR updates the default config to include all of the colors available in the extended color palette.
**This is a breaking change** because several of the colors in the extended palette have names that conflict with the colors in the default palette, but we have included several meas... | **Title**
Modernize Tailwind core: replace lodash, improve warnings, make colors lazy, and add universal‑defaults flag
**Problem**
The core relied heavily on lodash utilities, a single boolean flag for deprecation warnings, and a static color export that omitted `transparent` and `current`. This caused unnecessa... | 5,384 | tailwindlabs/tailwindcss | diff --git a/tests/basic-usage.test.css b/tests/basic-usage.test.css
index ab005dfe..ad5ec5eb 100644
--- a/tests/basic-usage.test.css
+++ b/tests/basic-usage.test.css
@@ -480,7 +480,7 @@
}
.bg-green-500 {
--tw-bg-opacity: 1;
- background-color: rgba(16, 185, 129, var(--tw-bg-opacity));
+ background-color: rgba(3... | [
"should keep an array as an array",
"should convert \"a.b.c\" to \"[\"a\", \"b\", \"c\"]\"",
"should convert \"a[0].b.c\" to \"[\"a\", \"0\", \"b\", \"c\"]\"",
"should convert \".a\" to \"[\"\", \"a\"]\"",
"should convert \"[].a\" to \"[\"\", \"a\"]\"",
"custom properties are multiplied by -1 for negative... | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused bac... | Method: createPlugin(handler: (api) => void, defaults?: object) Location: src/plugin.js (export default)
Inputs: – **handler** – function that receives the Tailwind plugin API (`addUtilities`, `addComponents`, `theme`, etc.) and uses it to register utilities/components.
– **defaults** – optional object that merges ... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 30,
"num_modified_lines": 501,
"pr_author": "adamwathan",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
c315db5f150428f6d8e0b2f6c83de63feb6ca036 | 2021-09-04 11:28:08 | lukewarlow: As this only has support in 2/3 browsers, I understand this may not be merged soon.
Here's the accent-color utilities in plugin form: https://github.com/lukewarlow/tailwind-accent-color
lukewarlow: The test is failing locally but the css output doesn't make much sense to me, seeing as this is basically a... | tailwindlabs__tailwindcss-5387 | diff --git a/.github/workflows/release-insiders.yml b/.github/workflows/release-insiders.yml
new file mode 100644
index 00000000..1b169de6
--- /dev/null
+++ b/.github/workflows/release-insiders.yml
@@ -0,0 +1,58 @@
+name: Release Insiders
+
+on:
+ push:
+ branches: [master]
+
+jobs:
+ build:
+ runs-on: ubuntu-l... | Add `accent-color` utilities
This PR adds utilities for the [`accent-color`](https://developer.mozilla.org/en-US/docs/Web/CSS/accent-color) property.
Example usage:
`<input type="checkbox" class="accent-red-500">` | **Add native `accent-color` utilities and clean up internal dependencies**
**Problem**
Tailwind CSS lacked utilities for the CSS `accent-color` property, preventing developers from styling form control accents with utility classes. The existing color handling also relied on heavy dependencies and emitted deprecati... | 5,387 | tailwindlabs/tailwindcss | diff --git a/tests/apply.test.js b/tests/apply.test.js
index 0c96c273..182e0214 100644
--- a/tests/apply.test.js
+++ b/tests/apply.test.js
@@ -1,7 +1,7 @@
import fs from 'fs'
import path from 'path'
-import { run, css } from './util/run'
+import { run, html, css } from './util/run'
test('@apply', () => {
let ... | [
"custom properties are multiplied by -1 for negative values",
"should keep an array as an array",
"should convert \"a.b.c\" to \"[\"a\", \"b\", \"c\"]\"",
"should convert \"a[0].b.c\" to \"[\"a\", \"0\", \"b\", \"c\"]\"",
"should convert \".a\" to \"[\"\", \"a\"]\"",
"should convert \"[].a\" to \"[\"\", \... | [
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused backwards infinite ease-in 1s 2s name\" correctly",
"should parse \"paused backwards infinite ease-in 1s 2s name normal\" correc... | Function: html(strings, ...values)
Location: src/util/run.js
Inputs: A template literal (``html`<div class="foo"></div>` ``) where *strings* is an array of literal sections and *values* are any interpolated expressions.
Outputs: A plain string containing the concatenated HTML markup (template‑literal raw value). Used i... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 37,
"num_modified_lines": 734,
"pr_author": "lukewarlow",
"pr_labels": [],
"llm_metadata": {
"code": "B5",
"code_quality": null,
"confidence": 0.95,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": true,
... |
e36d242c8d26631c4e040be29d9375015f0e2292 | 2021-09-04 12:23:42 | lukewarlow: I think tailwind generally only adds utilities for CSS with support in all three browsers. So if this does wait for Safari to unflag its support, here's it in plugin form: https://github.com/lukewarlow/tailwind-scroll-behavior | tailwindlabs__tailwindcss-5388 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 45e11bea..23b83d11 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,10 +19,40 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add native `aspect-ratio` utilities ([#5359](https://github.com/tailwindlabs/tailwindcss/pull/5359))
- U... | Add `scroll-behavior` utilities
This PR adds utilities for the [`scroll-behavior`](https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior) property.
I would recommend pushing people towards using this property responsibly in combination with the `motion-safe` variant. I don't believe we have to manually en... | **Title**
Improve core utility handling, add scroll‑behavior utilities, and streamline configuration processing
**Problem**
Core color utilities produced invalid CSS when related opacity plugins were disabled, and the library lacked built‑in scroll‑behavior utilities. Additionally, variant handling logic was out... | 5,388 | tailwindlabs/tailwindcss | diff --git a/tests/custom-plugins.test.js b/tests/custom-plugins.test.js
index 1256ff8b..4d52cd5f 100644
--- a/tests/custom-plugins.test.js
+++ b/tests/custom-plugins.test.js
@@ -1217,15 +1217,14 @@ test('plugins can be created using the `createPlugin` function', () => {
},
plugins: [
createPlugin(
- ... | [
"colors defined as functions work when opacity plugins are disabled"
] | [
"it can generate media queries from configured screen sizes",
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"e... | Method: createUtilityPlugin(utilityVariations, options) → (api) => void
Location: src/util/createUtilityPlugin.js
Inputs: utilityVariations – an array defining utility name/variation pairs; options – object with optional keys filterDefault (boolean) and resolveArbitraryValue (function). The returned function is invoked... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 7,
"num_modified_lines": 96,
"pr_author": "lukewarlow",
"pr_labels": [],
"llm_metadata": {
"code": "B1",
"code_quality": null,
"confidence": 0.88,
"detected_issues": {
"B1": true,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B... |
2dac5bb5692b36a60501122e4f141a1635696a9a | 2021-09-04 14:28:20 | tailwindlabs__tailwindcss-5389 | diff --git a/defaultConfig.js b/defaultConfig.js
index 820ae3e1..0a131abc 100644
--- a/defaultConfig.js
+++ b/defaultConfig.js
@@ -1,4 +1,4 @@
-const cloneDeep = require('lodash/cloneDeep')
-const defaultConfig = require('./stubs/defaultConfig.stub.js')
+let { cloneDeep } = require('./src/util/cloneDeep')
+let defaultC... | Simplify negate value
This PR will simplify the `negateValue` function by swapping the signs if it can, if not it will use a `calc(original * -1)`. We used to use a package called `reduce-css-calc`, but this also actually simplified the calc. For example it used to simplify `calc( 1 + 1 )` to `2`. This is not necessary... | **Title**
Remove heavy dependencies and simplify core utilities
**Problem**
Tailwind CSS relied on the `lodash` suite and `reduce-css-calc` for many simple operations, inflating the package size and coupling core logic to external libraries. Additionally, the `negateValue` helper performed unnecessary calculatio... | 5,389 | tailwindlabs/tailwindcss | diff --git a/tests/resolveConfig.test.js b/tests/resolveConfig.test.js
index bcba03bd..b5b6147e 100644
--- a/tests/resolveConfig.test.js
+++ b/tests/resolveConfig.test.js
@@ -1320,13 +1320,16 @@ test('custom properties are multiplied by -1 for negative values', () => {
const userConfig = {
theme: {
spaci... | [
"custom properties are multiplied by -1 for negative values",
"should keep an array as an array",
"should convert \"a.b.c\" to \"[\"a\", \"b\", \"c\"]\"",
"should convert \"a[0].b.c\" to \"[\"a\", \"0\", \"b\", \"c\"]\"",
"should convert \".a\" to \"[\"\", \"a\"]\"",
"should convert \"[].a\" to \"[\"\", \... | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"it prefixes classes with the provided prefix",
"it handles a function as the prefix",
"it properly prefixes selectors with non-standard characters",
"it prefixes all classes in a sel... | Function: toPath(path)
Location: src/util/toPath.js
Inputs:
- **path**: `string | string[]` – a dot‑ and bracket‑delimited property path (e.g., `"a.b[0].c"`), or an already‑split array of path segments.
Outputs:
- `string[]` – an array of path segments. If the input is already an array, it is returned unchanged; othe... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 28,
"num_modified_lines": 217,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
2dac5bb5692b36a60501122e4f141a1635696a9a | 2021-09-04 15:20:43 | tailwindlabs__tailwindcss-5390 | diff --git a/defaultConfig.js b/defaultConfig.js
index 820ae3e1..0a131abc 100644
--- a/defaultConfig.js
+++ b/defaultConfig.js
@@ -1,4 +1,4 @@
-const cloneDeep = require('lodash/cloneDeep')
-const defaultConfig = require('./stubs/defaultConfig.stub.js')
+let { cloneDeep } = require('./src/util/cloneDeep')
+let defaultC... | Remove lodash
This PR will get rid of the `lodash` dependency since it is rather big. I replaced most of the functions with plain built-ins. I've added a few extra utilities to mimic lodash' behaviour.
Some files (like the `resolveConfig`) can use some refactoring, however I tried to mainly focus on `lodash`'s removal... | **Title**
Eliminate lodash dependency and replace it with native utilities
**Problem**
Tailwind CSS pulls in the entire lodash library even though only a handful of its helpers are used, inflating the package size and adding unnecessary maintenance overhead. The project needs to function without lodash while pre... | 5,390 | tailwindlabs/tailwindcss | diff --git a/tests/to-path.test.js b/tests/to-path.test.js
new file mode 100644
index 00000000..dbd39c54
--- /dev/null
+++ b/tests/to-path.test.js
@@ -0,0 +1,17 @@
+import { toPath } from '../src/util/toPath'
+
+it('should keep an array as an array', () => {
+ let input = ['a', 'b', '0', 'c']
+
+ expect(toPath(input)... | [
"should keep an array as an array",
"should convert \"a.b.c\" to \"[\"a\", \"b\", \"c\"]\"",
"should convert \"a[0].b.c\" to \"[\"a\", \"0\", \"b\", \"c\"]\"",
"should convert \".a\" to \"[\"\", \"a\"]\"",
"should convert \"[].a\" to \"[\"\", \"a\"]\""
] | [
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused backwards infinite ease-in 1s 2s name\" correctly",
"should parse \"paused backwards infinite ease-in 1s 2s name normal\" correc... | Function: toPath(path)
Location: src/util/toPath.js
Inputs:
- `path`: either an Array of string segments (e.g., `['a','b']`) **or** a string representing a dotted/ bracketed path (e.g., `'a.b[0].c'`). No other types are expected.
Outputs:
- Returns an Array of string segments. If the input is already an array, it ret... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 27,
"num_modified_lines": 205,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.96,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... | |
2dac5bb5692b36a60501122e4f141a1635696a9a | 2021-09-06 11:50:45 | tailwindlabs__tailwindcss-5405 | diff --git a/defaultConfig.js b/defaultConfig.js
index 820ae3e1..0a131abc 100644
--- a/defaultConfig.js
+++ b/defaultConfig.js
@@ -1,4 +1,4 @@
-const cloneDeep = require('lodash/cloneDeep')
-const defaultConfig = require('./stubs/defaultConfig.stub.js')
+let { cloneDeep } = require('./src/util/cloneDeep')
+let defaultC... | Update package `files` config
- Remove `dist/*.css` as these files no longer exist
- Add `src/*` as this can be useful for some use-cases | **Title**
Remove lodash dependency and streamline utilities while fixing package file publishing
**Problem**
The codebase relied heavily on lodash for many simple operations, inflating bundle size and pulling in unused modules. Additionally, the package manifest listed build artifacts that no longer exist, causing... | 5,405 | tailwindlabs/tailwindcss | diff --git a/tests/to-path.test.js b/tests/to-path.test.js
new file mode 100644
index 00000000..dbd39c54
--- /dev/null
+++ b/tests/to-path.test.js
@@ -0,0 +1,17 @@
+import { toPath } from '../src/util/toPath'
+
+it('should keep an array as an array', () => {
+ let input = ['a', 'b', '0', 'c']
+
+ expect(toPath(input)... | [
"should keep an array as an array",
"should convert \"a.b.c\" to \"[\"a\", \"b\", \"c\"]\"",
"should convert \"a[0].b.c\" to \"[\"a\", \"0\", \"b\", \"c\"]\"",
"should convert \".a\" to \"[\"\", \"a\"]\"",
"should convert \"[].a\" to \"[\"\", \"a\"]\""
] | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused bac... | Function: toPath(path)
Location: src/util/toPath.js
Inputs: <code>path</code> – a string representing a property path using dot and bracket notation (e.g., <code>"a.b[0].c"</code>) or an array of strings already representing the path.
Outputs: An array of strings containing the individual path segments. If <code>path</... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 27,
"num_modified_lines": 206,
"pr_author": "bradlc",
"pr_labels": [],
"llm_metadata": {
"code": "B4",
"code_quality": null,
"confidence": 0.92,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": true,
"B5": false,
"B6"... | |
a5425abd86bcd634e1194dc3314e781173d30189 | 2021-09-08 09:34:58 | tailwindlabs__tailwindcss-5438 | diff --git a/src/plugins/divideWidth.js b/src/plugins/divideWidth.js
index 27b1bd05..ce305976 100644
--- a/src/plugins/divideWidth.js
+++ b/src/plugins/divideWidth.js
@@ -7,6 +7,7 @@ export default function () {
return {
'& > :not([hidden]) ~ :not([hidden])': {
+ '@defaults border... | Ensure that `divide` utilities inject a default border color
If we don't do this, then the default divide color would be black instead of gray.200
https://play.tailwindcss.com/3wvAh2JdUK vs. https://play.tailwindcss.com/fhwQkuwjJ5 | **Title**
Add default border settings to divide utilities
**Problem**
When using the divide utilities, the generated dividers fall back to a black color instead of the expected neutral gray. This produces visual inconsistency with the design system.
**Root Cause**
The divide plugin does not inject the frame... | 5,438 | tailwindlabs/tailwindcss | diff --git a/tests/plugins/divide.test.js b/tests/plugins/divide.test.js
new file mode 100644
index 00000000..fcfb45ec
--- /dev/null
+++ b/tests/plugins/divide.test.js
@@ -0,0 +1,121 @@
+import { run, html, css } from '../util/run'
+
+it('should add the divide styles for divide-y and a default border color', () => {
+ ... | [
"should add the divide styles for divide-y and a default border color",
"should add the divide styles for divide-x and a default border color",
"should add the divide styles for divide-y-reverse and a default border color",
"should add the divide styles for divide-x-reverse and a default border color"
] | [
"should parse \"1s spin 1s infinite\" correctly",
"should parse \"infinite infinite 1s 1s\" correctly",
"should parse \"ease 1s ease 1s\" correctly",
"should parse \"normal paused backwards infinite ease-in 1s 2s name\" correctly",
"should parse \"paused backwards infinite ease-in 1s 2s name normal\" correc... | No new interfaces are introduced. | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 1,
"num_modified_lines": 4,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.97,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"... | |
12fa78b9ca14b5062eb4fb5c7f16c48501f27385 | 2021-09-08 11:49:41 | tailwindlabs__tailwindcss-5442 | diff --git a/package-lock.json b/package-lock.json
index 16d63944..aa6d9081 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -12,8 +12,8 @@
"arg": "^5.0.1",
"chalk": "^4.1.2",
"chokidar": "^3.5.2",
+ "color-name": "^1.1.4",
"cosmiconfig": "^7.0.1",
- "culori": ... | Update color parsing and formatting
This PR replaces `culori` with a lightweight hex/rgb/hsl colour parser. The main motivation for this is to reduce the bundle size impact when bundling for the browser.
This PR also updates the format of the colours outputted by the `withAlphaVariable` function. These colours now u... | **Title**
Replace heavy color library with lightweight parser and switch to space‑separated CSS color syntax
**Problem**
Tailwind’s color handling relied on a large third‑party package, inflating the browser bundle size.
Additionally, generated colors used the legacy comma‑separated `rgb()/rgba()` syntax, whil... | 5,442 | tailwindlabs/tailwindcss | diff --git a/tests/apply.test.css b/tests/apply.test.css
index 3c6df8f9..1eef7c6e 100644
--- a/tests/apply.test.css
+++ b/tests/apply.test.css
@@ -1,7 +1,7 @@
.basic-example {
border-radius: 0.375rem;
--tw-bg-opacity: 1;
- background-color: rgba(59, 130, 246, var(--tw-bg-opacity));
+ background-color: rgb(59 1... | [
"it adds the right custom property",
"it transforms rgb and hsl to space-separated rgb and hsl",
"it transforms named colors to rgb",
"should parse \"black\" to the correct value",
"should parse \"#0088cc\" to the correct value",
"should parse \"#08c\" to the correct value",
"should parse \"#0088cc99\" ... | [
"it flattens nested color objects",
"it flattens deeply nested color objects",
"it handles empty objects",
"it parses simple single class definitions",
"it parses multiple class definitions",
"it parses nested pseudo-selectors",
"it parses top-level media queries",
"it parses nested media queries",
... | Function: parseColor(colorString)
Location: src/util/color.js
Inputs: <code>colorString</code> – a string containing a CSS colour value (e.g., named colour, hex, rgb(), rgba(), hsl(), hsla(), or the keyword “transparent”). The function trims the input and returns <code>null</code> for any value it cannot interpret.
Out... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 7,
"num_modified_lines": 90,
"pr_author": "bradlc",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.94,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
"B6": ... | |
4919cbfbb8b84add5fca7ae24fc147d45bc3b4e1 | 2021-09-09 14:49:57 | tailwindlabs__tailwindcss-5460 | diff --git a/src/corePlugins.js b/src/corePlugins.js
index 12228c7b..f9a9a97c 100644
--- a/src/corePlugins.js
+++ b/src/corePlugins.js
@@ -9,7 +9,6 @@ import withAlphaVariable, { withAlphaValue } from './util/withAlphaVariable'
import toColorValue from './util/toColorValue'
import isPlainObject from './util/isPlainOb... | Replace underscore with space in arbitrary values
This PR changes how we handle spaces in arbitrary values by automatically converting underscores to spaces instead of relying on commas.
Prior to this, certain plugins supported using commas in place of spaces, and Tailwind would convert those commas to spaces for yo... | **Title**
Standardize handling of spaces in arbitrary values by using underscores
**Problem**
Arbitrary values that require spaces relied on commas as a workaround, leading to inconsistent syntax across plugins and confusing readability. Developers need a clearer, uniform way to express spaces within class names... | 5,460 | tailwindlabs/tailwindcss | diff --git a/tests/arbitrary-values.test.js b/tests/arbitrary-values.test.js
index e75d7f98..2472d7a7 100644
--- a/tests/arbitrary-values.test.js
+++ b/tests/arbitrary-values.test.js
@@ -1,7 +1,7 @@
import fs from 'fs'
import path from 'path'
-import { run } from './util/run'
+import { run, html, css } from './util... | [
"should convert _ to spaces",
"should not convert escaped underscores with spaces"
] | [
"setting a plugin to false removes it",
"passing only false removes all plugins",
"passing an array whitelists plugins",
"should parse \"black\" to the correct value",
"should parse \"#0088cc\" to the correct value",
"should parse \"#08c\" to the correct value",
"should parse \"#0088cc99\" to the correc... | Function: run(entry, config)
Location: src/util/run.js (exported)
Inputs:
- **entry** (`string`): Tailwind entry source to process (e.g., `'@tailwind utilities'`).
- **config** (`object`): Tailwind configuration object passed to the compiler (may contain `content`, `corePlugins`, etc.).
Outputs:
- Returns a `Promis... | MIT | {
"base_image_name": "node_16",
"install": [
"npm install",
"npm run babelify"
],
"log_parser": "parse_log_js_4",
"test_cmd": "npx cross-env TAILWIND_MODE=build jest --verbose --no-colors"
} | {
"num_modified_files": 4,
"num_modified_lines": 34,
"pr_author": "RobinMalfait",
"pr_labels": [],
"llm_metadata": {
"code": "A",
"code_quality": null,
"confidence": 0.93,
"detected_issues": {
"B1": false,
"B2": false,
"B3": false,
"B4": false,
"B5": false,
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.