owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 685,683,494 | 2,015 | LinusBorg | That still a bit fragile, however.
When the target's parent gets removed from the DOM, the portal content is removed from the DOM with it - but the source component won't be informed about this and consequently, in it's vdom, it assumes that the elements still are in the DOM. That will likely result in update errors... | 2020-09-02T11:57:46 | 2020-09-02T11:57:46 | {
"+1": 3
} | MEMBER |
vuejs | core | 687,193,504 | 2,045 | yyx990803 | This is a documented change: https://github.com/vuejs/rfcs/blob/master/active-rfcs/0006-slots-unification.md | 2020-09-04T14:47:42 | 2020-09-04T14:47:42 | {} | MEMBER |
vuejs | core | 683,386,341 | 1,989 | CyberAP | I think it's important to distinguish model update events from any other events exactly for this to work. Model update event listeners should have a special treatment which they do have right now. But in a case of `update:` we can't do that because `update:` doesn't tell that this event is a model update event. You cou... | 2020-08-30T07:21:10 | 2020-08-30T07:21:10 | {} | CONTRIBUTOR |
vuejs | core | 683,548,688 | 2,014 | skirtles-code | Related: #1165. | 2020-08-31T04:57:29 | 2020-08-31T04:57:29 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 684,543,513 | 2,020 | Raiondesu | Hey, @pikax, thanks for the answer.
Can you, please, make a somewhat convincing case on why "internal types" should not be exposed?\
It's not like they're some executable pieces of code that could "break" Vue in the hands of users, like some internal runtime APIs could.
I get that there are some types that are u... | 2020-09-01T08:12:32 | 2020-09-01T08:27:12 | {} | NONE |
vuejs | core | 684,798,231 | 2,025 | SebastianSpeitel | I just found out I can use `track` and `trigger` to get everything I need to create a custom reactive class. | 2020-09-01T11:56:20 | 2020-09-01T11:56:20 | {} | NONE |
vuejs | core | 685,217,642 | 2,012 | yyx990803 | good catch! | 2020-09-02T01:04:01 | 2020-09-02T01:04:01 | {} | MEMBER |
vuejs | core | 685,681,488 | 2,027 | rothskeller | @posva I see two references: [here](https://github.com/vuejs/vue-router-next/blob/2e277ef51679f9c5f94388af1f37ecf9d2f24579/docs/guide/essentials/dynamic-matching.md#L44) and [here](https://github.com/vuejs/vue-router-next/blob/2b7300ba2b48e5a2f3729deff77a53cf9ecb4838/docs/guide/advanced/data-fetching.md#L46). | 2020-09-02T11:53:55 | 2020-09-02T11:53:55 | {} | NONE |
vuejs | core | 685,728,397 | 2,036 | pikax | If you need to access it inside of the `setup` you should be using [useCssModule](https://github.com/vuejs/vue-next/blob/master/packages/runtime-dom/src/helpers/useCssModule.ts) | 2020-09-02T13:15:02 | 2020-09-02T13:15:02 | {} | MEMBER |
vuejs | core | 683,592,762 | 2,014 | posva | See https://github.com/vuejs/vue-next/issues/1165#issuecomment-626857730 | 2020-08-31T06:42:16 | 2020-08-31T06:42:16 | {} | MEMBER |
vuejs | core | 683,654,767 | 1,849 | chenjiahan | How to access the component instance in setup?
Current usage:
```js
import { getCurrentInstance } from "vue";
setup() {
const instance = getCurrentInstance();
instance.proxy. // == vm
}
``` | 2020-08-31T08:54:02 | 2020-08-31T08:54:02 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 684,131,230 | 2,020 | yyx990803 | You already have the types needed to write that function.
```ts
import { FunctionalComponent, ExtractPropTypes } from 'vue'
function withProps<T>(props: T, fn: FunctionalComponent<ExtractPropTypes<T>>) {
// ...
}
``` | 2020-09-01T01:10:18 | 2020-09-01T01:10:18 | {
"eyes": 1
} | MEMBER |
vuejs | core | 684,589,892 | 1,849 | Picknight | > I still think we should revert it, it's especially useful in third-party libraries such as [vue-test-utils-next](https://github.com/vuejs/vue-test-utils-next), also very commonly used in component libraries.
Agreed. | 2020-09-01T08:44:38 | 2020-09-01T08:44:38 | {} | CONTRIBUTOR |
vuejs | core | 684,602,924 | 2,020 | pikax | > Can you, please, make a somewhat convincing case on why "internal types" should not be exposed?
IMO is to make the vue types bloated with unnecessary types, this will prevent the user to try to access internal APIs or write code with a type that might change. This simplify users life with less types to be import, ... | 2020-09-01T08:53:21 | 2020-09-01T08:53:21 | {} | MEMBER |
vuejs | core | 684,822,266 | 2,025 | posva | Closing since `track` and `trigger` solve the original problem | 2020-09-01T12:39:15 | 2020-09-01T12:39:15 | {} | MEMBER |
vuejs | core | 685,016,582 | 1,981 | Justineo | I believe in Vue 3 prop declarations are optional. | 2020-09-01T17:26:58 | 2020-09-01T17:26:58 | {} | MEMBER |
vuejs | core | 685,247,759 | 1,981 | CarterLi | > Can you provide a reproduction link? In this way, others can help you better 😁
Here it is: https://jsfiddle.net/j1h8z9cb/1/ | 2020-09-02T02:28:34 | 2020-09-02T02:28:34 | {} | CONTRIBUTOR |
vuejs | core | 687,223,355 | 2,045 | Haroenv | I see now, but it wasn't too straightforward since it wasn't mentioned in the "migration strategy" key. I'll make a pull request to add it a little more explicit, since I think I looked at least 30 minutes why it wasn't displaying anything :) | 2020-09-04T15:34:00 | 2020-09-04T15:34:00 | {} | NONE |
vuejs | core | 687,622,854 | 2,054 | posva | > These three forms are consistent
Please be more precise, what do you exactly expect to be the same? | 2020-09-05T15:02:49 | 2020-09-05T15:02:49 | {} | MEMBER |
vuejs | core | 682,610,236 | 2,000 | LinusBorg | Changing a property mutates teh object, but it's still the same object. hence, the valu passed to `<my-node>` is still the same, there's no need to re-render the component, and consequently, there will also be no diffing and patching going on.
`<my-node>` can watch `props.reactiveProp` for deep changes and update ac... | 2020-08-28T14:23:51 | 2020-08-29T10:37:18 | {} | MEMBER |
vuejs | core | 683,862,073 | 2,018 | unbyte | if `ref()` wraps an object, it will make this object reactive | 2020-08-31T15:46:11 | 2020-08-31T15:46:11 | {} | CONTRIBUTOR |
vuejs | core | 685,213,290 | 2,002 | yyx990803 | Good catch! Although in this case, we can simply remove the `has` and `ownKeys` traps for readonly proxies (see 691a4b95) | 2020-09-02T00:53:28 | 2020-09-02T00:53:28 | {} | MEMBER |
vuejs | core | 685,221,488 | 1,849 | yyx990803 | Why are people trying to get `instance.proxy` in `setup`? What is the use case for this? | 2020-09-02T01:13:30 | 2020-09-02T01:13:30 | {} | MEMBER |
vuejs | core | 685,270,293 | 1,849 | Picknight | @chenjiahan You can achieve your purpose like this:
```js
// Form.jsx
export default {
name: 'MyForm',
methods: {
reset() {
// reset form
}
},
setup() {
return () => <div class="form"></div>
},
};
``` | 2020-09-02T03:35:05 | 2020-09-02T03:35:05 | {} | CONTRIBUTOR |
vuejs | core | 685,293,655 | 2,015 | unbyte | works well
```javascript
const useTele = () => {
const target = ref(null)
return () => target
}
const useThisTele = useTele()
createApp({
setup() {
return { target: useThisTele() }
},
template: `
<div>
<h1>App</h1>
<div id="dest" :ref="d => target = ... | 2020-09-02T04:49:34 | 2020-09-02T04:49:34 | {
"hooray": 1
} | CONTRIBUTOR |
vuejs | core | 685,732,728 | 2,036 | pikax | There's an equivalent [useCssModule](https://github.com/vuejs/composition-api/blob/master/src/apis/useCssModule.ts) for the `@vue/composition-api` plugin | 2020-09-02T13:21:38 | 2020-09-02T13:21:38 | {
"+1": 1
} | MEMBER |
vuejs | core | 685,746,821 | 2,036 | posva | Okay, closing then. This is also vue 3 repository. BTW you should access `slots` on the second argument of `setup`, the context (https://composition-api.vuejs.org/api.html#setup) | 2020-09-02T13:44:23 | 2020-09-02T13:44:23 | {} | MEMBER |
vuejs | core | 683,329,852 | 2,010 | sqal | https://github.com/vuejs/rfcs/issues/167 | 2020-08-29T19:00:18 | 2020-08-29T19:00:18 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 683,837,772 | 2,018 | nerdcave | Added a public repo that can be pulled down.
I wasn't convinced it was simply a pass by reference issue because `count` and `items` appear to have different ref internals. e.g. `ref(props.items)` contains Proxy objects and `ref(props.count)` does not:
 {
const vm = getCurrentInstance().proxy;
const text = ref('foo');
vm.reset = () => {
// reset form
text.value = '';
};
return () => <div class="form">{text.value}</div>
},
};
... | 2020-09-02T03:39:23 | 2020-09-02T03:44:04 | {} | CONTRIBUTOR |
vuejs | core | 685,795,932 | 2,038 | yyx990803 | https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3Ca%20%40click.capture%3D%5C%22foo%5C%22%20%2F%3E%5Cn%3Ca%20%40click.once%3D%5C%22foo%5C%22%20%2F%3E%22%2C%22ssr%22%3Afalse%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%22%3Afalse%2C%22optimizeImports%22%3Afalse%2C%22hoistStatic... | 2020-09-02T15:03:22 | 2020-09-02T15:03:22 | {} | MEMBER |
vuejs | core | 687,709,035 | 2,058 | HcySunYang | You should ensure that the component is always registered correctly, why do you need unregistered components? If it's a built-in component(specific platform), you may need the corresponding compiler options:
```js
/**
* If the pairing runtime provides additional built-in elements, use this to
* mark them as... | 2020-09-06T06:26:22 | 2020-09-06T06:26:22 | {} | MEMBER |
vuejs | core | 683,398,108 | 1,990 | designerzen | Hi thanks for looking into this.
I understand the parent behavior and this makes perfect sense. However it is the ref inside the async component that I want to access (ie, in the component itself - not from it's parent)
After adding the watch command the issue remains in that the watch never resolves with the act... | 2020-08-30T09:31:05 | 2020-08-30T09:31:05 | {} | NONE |
vuejs | core | 683,609,845 | 1,946 | floj | @CyberAP Thanks for the heads up, this of cause works as expected.
I think its worth considering to merge #1957 because having Set as a model working without a `computed` property saved some lines of code and eliminates the need the wrap the `data`s property. | 2020-08-31T07:18:32 | 2020-08-31T07:18:32 | {} | NONE |
vuejs | core | 685,144,707 | 2,025 | SebastianSpeitel | The best solution I found is to create a `customRef<void>` in the constructor and store the given `track` and `trigger` callbacks as instance properties, so I can use them whenever I want.
Storing the returned `Ref<void>` as a property gives me the ability to do `watch(myinstance.ref)`. | 2020-09-01T21:31:22 | 2020-09-01T21:31:22 | {} | NONE |
vuejs | core | 685,895,963 | 1,682 | rchl | After this or some later changes I'm seeing weird behavior with my refs being unwrapped in watchers. For example:
```vue
<template>
<div>Check the console</div>
</template>
<script>
import { reactive, watchEffect, ref } from "@vue/composition-api";
export default {
setup() {
const temp = ref("xxx")... | 2020-09-02T17:47:37 | 2020-09-02T17:47:37 | {} | NONE |
vuejs | core | 686,249,752 | 2,015 | Fuzzyma | @unbyte so you basically pass (or import) useThisRef to the components which define it and which uses it as target. Is that correct? (so in easy terms you pass around a reference) | 2020-09-03T04:46:39 | 2020-09-03T04:46:39 | {} | NONE |
vuejs | core | 687,193,027 | 2,044 | yyx990803 | Use Vuex or a shared reactive object with provide/inject. Don't reach for parent like that. | 2020-09-04T14:47:01 | 2020-09-04T14:47:17 | {
"+1": 1
} | MEMBER |
vuejs | core | 622,446,461 | 626 | pikax | @dolymood Thank you for the changes!
It looks good so far (went through most of the code), but unfortunately the current typings for `defineComponent` won't work with `Typescript 3.9-rc`.
Types returned by
```ts
ComponentPublicInstanceConstructor<
CreateComponentPublicInstance<
ExtractPropTypes<PropsOp... | 2020-05-01T15:58:23 | 2020-05-01T15:58:23 | {} | MEMBER |
vuejs | core | 622,549,280 | 1,083 | yyx990803 | see b40fcbc4 | 2020-05-01T20:18:16 | 2020-05-01T20:18:16 | {} | MEMBER |
vuejs | core | 622,941,986 | 1,033 | deleonio | Either vue or react not both.
That is the same issue by use react and preact together.
Use storybook for your components doc. | 2020-05-02T11:54:08 | 2020-05-02T11:54:08 | {} | NONE |
vuejs | core | 623,255,288 | 1,110 | liulinboyi | https://vue-composition-api-rfc.netlify.app/api.html#watch
```
// watching a getter
const state = reactive({ count: 0 })
watch(
() => state.count,
(count, prevCount) => {
/* ... */
}
)
``` | 2020-05-04T04:48:47 | 2020-05-04T04:48:47 | {} | MEMBER |
vuejs | core | 623,259,853 | 1,110 | Gavin-yh | @liulinboyi Thanks. Why not add a layer of processing to directly listen to the properties of the reactive object, not in the form of functions, like Ref. | 2020-05-04T05:09:33 | 2020-05-04T05:09:33 | {} | NONE |
vuejs | core | 623,470,452 | 1,109 | rigor789 | Thank you @yyx990803! | 2020-05-04T13:40:05 | 2020-05-04T13:40:05 | {} | CONTRIBUTOR |
vuejs | core | 623,611,081 | 1,105 | danyadev | After this “fix”, all uses of TransitionGroup with keyed v-for began to display warnings in the console
![image](https://user-images.githubusercontent.com/35631027/80996515-96fa5880-8e48-11ea-947b-61b8bc7f... | 2020-05-04T17:53:13 | 2020-05-04T17:53:13 | {} | CONTRIBUTOR |
vuejs | core | 624,477,837 | 1,128 | underfin | I don't get the problem with you.Can you explain it detaily with this?I find nothing with problem after check the link you provider.
```
import { createVNode as _createVNode, createStaticVNode as _createStaticVNode, openBlock as _openBlock, createBlock as _createBlock } from "vue"
const _hoisted_1 = /*#__PURE__*/_... | 2020-05-06T07:02:27 | 2020-05-06T07:02:27 | {} | MEMBER |
vuejs | core | 624,577,145 | 1,119 | jacekkarczmarczyk | You don't return them, you just call hooks in setup():
https://composition-api.vuejs.org/#lifecycle-hooks | 2020-05-06T10:49:03 | 2020-05-06T10:49:25 | {} | CONTRIBUTOR |
vuejs | core | 624,646,277 | 1,128 | underfin | it is better if it is possible stringfy other div node. | 2020-05-06T13:23:05 | 2020-05-06T13:23:05 | {} | MEMBER |
vuejs | core | 624,698,139 | 1,128 | gzzhanghao | @yyx990803 Correct, but I think `<input indeterminate>` should work as well (just like `<CustomComponent indeterminate />`).
Meanwhile, I wonder if we should handle custom properties here, so we can put raw data objects on elements (source locations, for example). | 2020-05-06T14:54:41 | 2020-05-06T15:02:53 | {} | CONTRIBUTOR |
vuejs | core | 624,821,089 | 1,135 | LongTengDao | @yyx990803 Why not set on the target to replace that computed like the other cases do?
https://github.com/vuejs/vue-next/blob/d66211849ca174c4458b59d3df5569730ee224f6/packages/reactivity/src/baseHandlers.ts#L104
While running this function, user is just trying to set value on target[key], not on target[key].value... | 2020-05-06T18:41:29 | 2020-05-07T16:00:07 | {} | CONTRIBUTOR |
vuejs | core | 626,195,083 | 1,152 | underfin | The props with `Transition` component is static.Maybe we can change `Transition` implement use setup instead of functional.But it is complex for watch the transition enter finish.
So, I think this will be better solution.
When mount is used appear class, we can reset origin class when finish event trigger.
Wel... | 2020-05-09T15:45:42 | 2020-05-09T16:03:57 | {} | MEMBER |
vuejs | core | 626,763,107 | 1,159 | kjugi | Thanks for the help with fiddle @posva . Also, I've updated my issue | 2020-05-11T15:07:28 | 2020-05-11T15:07:28 | {} | NONE |
vuejs | core | 622,982,439 | 1,083 | yangmingshan | @yyx990803 Thanks, and maybe you will be interested in https://github.com/microsoft/rushstack/issues/1709. | 2020-05-02T16:51:12 | 2020-05-02T16:51:12 | {} | CONTRIBUTOR |
vuejs | core | 623,529,665 | 626 | ktsn | Regarding TS 3.9 issue, looks like we are affected by "Intersections Reduced By Discriminant Properties" breaking change.
https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-rc/
Looks like the culprit property is `call` type in `ComponentOptionsBase`.
https://github.com/vuejs/vue-next/blob/master/p... | 2020-05-04T15:23:03 | 2020-05-04T15:23:03 | {} | CONTRIBUTOR |
vuejs | core | 623,003,305 | 1,033 | deleonio | I think the ide does not differnce beetween the subfolder projects.
Thank you for this perspective ... because I believe/feel "mono repos are a other name for monoliths."
try to reduce the overhead by managing the independent packages ... a go back to move all in only one repo.
If you are disciplined, then you... | 2020-05-02T19:36:54 | 2020-05-02T19:36:54 | {
"eyes": 1,
"laugh": 1
} | NONE |
vuejs | core | 623,383,115 | 1,117 | dependabot-preview[bot] | Sorry, only users with push access can use that command. | 2020-05-04T10:24:58 | 2020-05-04T10:24:58 | {} | CONTRIBUTOR |
vuejs | core | 623,476,151 | 1,119 | aztalbot | In your repro, you are missing `.value` on `inputRef` in the NotWorkingExample component. Add that and it works just like your other component. I think if you need to expose public methods (e.g. so a parent can call it on the child component via ref), you would do
```js
setup () {
return {
inputRef,
cl... | 2020-05-04T13:50:32 | 2020-05-04T13:51:45 | {
"-1": 1
} | CONTRIBUTOR |
vuejs | core | 623,812,801 | 1,121 | SyntheticGoop | My bad, didn't read the manual.
Here is a working reproduction (no issue): https://jsfiddle.net/3k56phfz
| 2020-05-05T03:23:55 | 2020-05-05T03:23:55 | {} | NONE |
vuejs | core | 624,638,039 | 1,132 | yyx990803 | Can you also add a test case for this? | 2020-05-06T13:07:36 | 2020-05-06T13:07:36 | {} | MEMBER |
vuejs | core | 623,110,065 | 1,080 | xland | When I create a new demo project to reappear this issue.
I found it is gone.
But I do not know why my old project has this issue.
I pay a whole day on it.
Maybe I need more time, or just let it go.
Thanks anyway.
| 2020-05-03T13:26:01 | 2020-05-03T13:26:01 | {} | NONE |
vuejs | core | 623,267,663 | 1,110 | liulinboyi | > @liulinboyi Thanks. Why not add a layer of processing to directly listen to the properties of the reactive object, not in the form of functions, like Ref.
@yyx990803 | 2020-05-04T05:41:32 | 2020-05-04T05:41:32 | {} | MEMBER |
vuejs | core | 624,527,470 | 1,129 | pikax | I would like to avoid exposing `UnwrapRef<>` to the user.
If you cast the value to `State` it works
```ts
function useState<State extends string>(initial: State) {
const state = ref(initial) // state.value -> string
const set = (v: State) => void (state.value = v) // pass
const another = state.value as S... | 2020-05-06T09:01:25 | 2020-05-06T09:01:25 | {
"+1": 1
} | MEMBER |
vuejs | core | 624,647,434 | 1,128 | gzzhanghao | @underfin @posva Sorry for the confusion. But the real problem here is that stringified node behaves differently with non-stringified one. It may cause confusion in development since the optimization happens automatically - things can break without any relevant update.
A possible solution is adding `.prop` modifier ... | 2020-05-06T13:25:10 | 2020-05-06T13:25:10 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 626,171,096 | 1,151 | underfin | When I add transiton test.It always fail down in me local dev.So its is slow with add test. and it lead me to confused with diff the behavior with v2.So I want to get some help to improve it.
other.
When test the dom element with spy called argments.I get "{}".
When I get use `page().evalate(()=> document.getelement... | 2020-05-09T12:47:54 | 2020-05-09T12:47:54 | {} | MEMBER |
vuejs | core | 622,599,225 | 1,051 | yyx990803 | See 20bc7ba1 and 98bee596 | 2020-05-01T22:48:09 | 2020-05-01T22:48:09 | {} | MEMBER |
vuejs | core | 622,646,763 | 1,061 | underfin | My email is likui6666666@gmail.com.Looking forward to your letter. | 2020-05-02T01:08:49 | 2020-05-02T02:07:10 | {} | MEMBER |
vuejs | core | 622,958,594 | 1,033 | elevatebart | React and VueJs are not in the same package in the above monorepo. | 2020-05-02T14:03:15 | 2020-05-02T14:03:15 | {} | CONTRIBUTOR |
vuejs | core | 623,445,912 | 1,115 | pikax | fixed https://github.com/vuejs/vue-next/commit/bc1f097e29c5c823737503532baa23c11d4824f8 | 2020-05-04T12:54:07 | 2020-05-04T12:54:07 | {} | MEMBER |
vuejs | core | 623,530,506 | 1,106 | ktsn | We may not need to create `DefineComponent` type. See my comment at https://github.com/vuejs/vue-next/pull/626#issuecomment-623529665 | 2020-05-04T15:24:22 | 2020-05-04T15:24:22 | {} | CONTRIBUTOR |
vuejs | core | 623,711,497 | 1,105 | yyx990803 | @danyadev fixed in f05aeea7 | 2020-05-04T21:18:38 | 2020-05-04T21:18:38 | {} | MEMBER |
vuejs | core | 624,647,127 | 1,033 | elevatebart | Thank you @yyx990803, this will help a lot.
If you are looking for someone to bounce ideas with, ping me on VueLand.
I'll be happy to show enthusiasm or constructive criticism.
Except for this hiccup, the migration to Vue 3 is bringing a lot of performance to docgen and styleguidist. I like it. | 2020-05-06T13:24:40 | 2020-05-06T13:24:40 | {} | CONTRIBUTOR |
vuejs | core | 624,974,107 | 1,136 | yyx990803 | If you are prototyping, then browser support of ESM isn't really an issue. And SystemJS should work with ESM builds, isn't that what it's all about?
For production there is no point in providing UMD either, since you will be bundling and all major bundlers support ESM today.
Also if you are prototyping with Vue 3... | 2020-05-07T01:19:15 | 2020-05-07T01:19:56 | {} | MEMBER |
vuejs | core | 625,072,532 | 1,136 | privatenumber | SystemJS doesn't seem to [support ESM](https://github.com/systemjs/systemjs/blob/master/docs/module-types.md) right now ([FR](https://github.com/systemjs/systemjs/issues/2013)).
I can give you a real example of a production scenario where UMD/AMD would be useful:
We have a large codebase that builds using Webpack... | 2020-05-07T07:08:23 | 2020-05-07T15:04:38 | {} | CONTRIBUTOR |
vuejs | core | 625,679,188 | 1,782 | posva | @yyx990803 I need your help with this one. Here is a boiled down repro without vue-router: https://github.com/posva/vite-app. I tried reproducing it in a jsfiddle but it doesn't work: https://jsfiddle.net/posva/uhw02n4a/
The one with Vite shows the warning and an empty `attrs` list but I would expect to be able to h... | 2020-05-08T07:26:30 | 2020-05-08T07:26:30 | {
"+1": 1
} | MEMBER |
vuejs | core | 626,751,319 | 1,106 | yyx990803 | @pikax can you resolve the conflict in the lockfile? | 2020-05-11T14:48:33 | 2020-05-11T14:48:33 | {
"+1": 1
} | MEMBER |
vuejs | core | 622,962,256 | 1,060 | yyx990803 | Hmm, I didn't realize `WeakSet/Map` addition can be this expensive at large sizes. We may have to reconsider internal reactive-ness tracking cost of this too.
I am a bit torn on "magic hidden flag exposed as public API"... feels dirty. I'll think about this in the next beta release. | 2020-05-02T14:30:37 | 2020-05-02T14:30:37 | {} | MEMBER |
vuejs | core | 624,669,397 | 1,128 | yyx990803 | If binding as a prop it should be `<input :indeterminate="true">` | 2020-05-06T14:04:11 | 2020-05-06T14:04:11 | {} | MEMBER |
vuejs | core | 625,107,644 | 1,137 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/4939?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-05-07T08:24:11 | 2020-05-07T08:24:11 | {} | CONTRIBUTOR |
vuejs | core | 622,915,406 | 1,060 | basvanmeurs | > `markRaw` simply adds the item to a `WeakMap`, there really isn't too much of a perf cost - if any, it's not that different from a property existence check.
Thanks for your response Evan, but can you please reconsider it?
Looking up in a WeakSet can be more costly than a simple property lookup. Especially when ... | 2020-05-02T09:05:51 | 2020-05-02T09:05:51 | {} | CONTRIBUTOR |
vuejs | core | 623,504,262 | 1,100 | yyx990803 | Hey @AlexandreBonaventure thank you so much for the PR. After looking into it, I realized this is a bit more involved than I expected, and there were simply too many changes to make if I were to base it on top of this PR, so I did it in a separate commit. Hope you don't mind. | 2020-05-04T14:39:30 | 2020-05-04T14:39:30 | {} | MEMBER |
vuejs | core | 624,562,586 | 1,128 | underfin | Got it.The bahavior what `<input type="checkbox" indeterminate/>` is not support with browser.
You can use binding ` <input type="checkbox" :indeterminate="" />` to reslove this. | 2020-05-06T10:17:55 | 2020-05-06T10:17:55 | {} | MEMBER |
vuejs | core | 624,575,795 | 1,119 | dwanl | How to return the lifecycle function when using rendering function？
| 2020-05-06T10:46:10 | 2020-05-06T10:46:10 | {} | NONE |
vuejs | core | 624,640,755 | 1,128 | yyx990803 | In Vue 3 the idea is Vue auto detects prop vs. attributes. I think there should be some intuition from the compiler to avoid stringifying nodes with prop-only bindings, even static. | 2020-05-06T13:12:35 | 2020-05-06T13:12:43 | {
"+1": 1
} | MEMBER |
vuejs | core | 624,660,399 | 1,132 | LongTengDao | @yyx990803 对该测试框架不太熟悉；如果我所料不错，应该加好了。 | 2020-05-06T13:48:20 | 2020-05-06T13:48:20 | {} | CONTRIBUTOR |
vuejs | core | 624,708,521 | 1,129 | ktsn | I think having `noRef` type parameter is as same as cast. I would say we don't have to introduce dedicated api for that. We can just do below if we don't want to encourage users to use `UnwrapRef`:
```ts
function useState<State extends string>(initial: State) {
const state = ref(initial) as Ref<State> // state.v... | 2020-05-06T15:11:51 | 2020-05-06T15:11:51 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 624,715,929 | 1,129 | pikax | We need to add that to the docs I can see some people having problems | 2020-05-06T15:24:32 | 2020-05-06T15:24:32 | {
"heart": 6
} | MEMBER |
vuejs | core | 625,640,782 | 1,126 | jonaskuske | > You can try merge two v-for into one , like the blow code , hope this help you.
Yep, merging them all into one `v-for` kinda works, thanks! But the limitation that TransitionGroup only works for child nodes on the same flat level is already quite severe as is (different discussion) – and not being able to freely m... | 2020-05-08T05:38:38 | 2020-05-08T05:58:53 | {} | CONTRIBUTOR |
vuejs | core | 626,752,540 | 1,146 | yyx990803 | Duplicate of #1142 | 2020-05-11T14:49:48 | 2020-05-11T14:49:48 | {} | MEMBER |
vuejs | core | 622,519,277 | 1,082 | yyx990803 | First, as you have noticed, you don't really need the `_Tabs` wrapper - which already makes it work. But your original case still helped me identify 2 bugs which are fixed in ac6a6f11 and 08bf7e36.
Note that even with the fixes, you should never directly mutate a vnode in Vue 3: vnodes should be considered immutable... | 2020-05-01T19:02:38 | 2020-05-01T19:02:38 | {
"+1": 6
} | MEMBER |
vuejs | core | 623,485,916 | 1,118 | ayZagen | @underfin problem still exists. Edited the issue. Could you please change the vue version in jsFiddle to .beta-6 and compare the console logs ? | 2020-05-04T14:07:52 | 2020-05-04T14:11:03 | {} | NONE |
vuejs | core | 623,488,352 | 1,109 | msaelices | thanks so much @yyx990803 | 2020-05-04T14:12:14 | 2020-05-04T14:12:14 | {} | NONE |
vuejs | core | 623,488,789 | 1,118 | ayZagen | This is in `3.0.0-beta.6`
And this is what happens on `3.0.0-beta.7`
| 2020-05-04T14:12:58 | 2020-05-04T14:12:58 | {} | NONE |
vuejs | core | 623,512,332 | 1,119 | aztalbot | @jacekkarczmarczyk you're totally right there. In that case a variation of what you had works, but I'm not sure something like that will be common practice.
```js
function setupWithRender(setup) {
let _render;
const _setup = (...args) => {
const result = setup(...args);
_render = result.render;
... | 2020-05-04T14:53:26 | 2020-05-04T14:53:26 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 624,641,831 | 1,033 | yyx990803 | @elevatebart just so you know I'm considering doing this, but still trying to figure out the best way to organize it with the upcoming Vue 3 JSX transform. | 2020-05-06T13:14:33 | 2020-05-06T13:14:33 | {} | MEMBER |
vuejs | core | 622,550,776 | 1,061 | yyx990803 | @underfin nice job! Thanks a lot for your great contributions - do you have an email I can contact you with? | 2020-05-01T20:21:27 | 2020-05-01T20:21:27 | {} | MEMBER |
vuejs | core | 623,013,600 | 1,060 | yyx990803 | Did a refactor in d901b6be - this technically allows you to use `__v_skip` to mark an object as raw. | 2020-05-02T21:10:14 | 2020-05-02T21:10:14 | {
"hooray": 2
} | MEMBER |
vuejs | core | 623,445,674 | 1,114 | leopiccionia | The Optional Props Declaration RFC was revoked, and replaced by [this active RFC](https://github.com/vuejs/rfcs/blob/amend-optional-props/active-rfcs/0031-attr-fallthrough.md). | 2020-05-04T12:53:34 | 2020-05-04T12:53:34 | {} | CONTRIBUTOR |
vuejs | core | 623,479,979 | 1,119 | jacekkarczmarczyk | Thank you, i've updated the repro.
The problem with your solution is that I need to expose all refs/methods/etc so that I could access them in `render()`, that's acceptable for me though, closing the issue | 2020-05-04T13:57:17 | 2020-05-04T13:57:17 | {} | CONTRIBUTOR |
vuejs | core | 624,580,966 | 1,020 | dwanl | 通过返回 render 函数进行渲染时，如何监听在 document 上绑定的事件呢？在生命周期 onMounted(() => {}) 注册不生效。
```
setup() {
const handler = () => {}
onMounted(() => {
document.removeEventListener('click', handler)
})
return () => h('div' {...})
}
``` | 2020-05-06T10:58:42 | 2020-05-06T10:58:42 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.