owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 599,721,810 | 660 | sionzee | The [docs](https://vue-composition-api-rfc.netlify.com/api.html#template-refs) are really outdated or I have found a bug.
At **Usage inside v-for** they are showing how to put the elements to the array.
But inside the ref function, you can't access the state.
` :ref="el => { divs[i] = el }">`
so here the **di... | 2020-03-16T19:32:32 | 2020-03-16T19:39:49 | {} | NONE |
vuejs | core | 599,735,308 | 660 | sionzee | @yyx990803 I'm sorry for commenting under this issue. Anyway when you gave me already a response. If this works as is intended then the documentation is written wrongly? I can't spot almost any difference between code above and documentation.
Just found I can access **_ctx.<variable>** (where is the real ref)
So it... | 2020-03-16T20:06:09 | 2020-03-16T20:30:57 | {} | NONE |
vuejs | core | 600,480,558 | 721 | relief-melone | Well vue wouldn't have to decide what what arguments to provide as you would only have to support functions that can be called without arguments (as you set all the defaults for the parameters). And it just checks if the exported default is a function or an object.
If its a function it would just run it without arg... | 2020-03-18T08:08:20 | 2020-03-18T08:10:40 | {} | NONE |
vuejs | core | 600,780,631 | 854 | posva | I think this is intended. It's consistent with the behavior in Vue 2. Casting to `true` only happens with boolean props | 2020-03-18T18:03:55 | 2020-03-18T18:03:55 | {} | MEMBER |
vuejs | core | 592,982,160 | 749 | yyx990803 | @ysj16 see the RFC linked in the commit. | 2020-02-29T19:00:15 | 2020-02-29T19:00:15 | {
"+1": 1
} | MEMBER |
vuejs | core | 596,109,733 | 660 | jods4 | I wish this behavior would be changed, esp. since alpha 8.
In Vue 3 you don't think in refs names anymore. With the API you think in an object that represent a reactive state.
So it's natural to think that `ref='abc'` in a template would set the `abc` property of your state to that element.
Forcing a ref here is... | 2020-03-07T17:13:14 | 2020-03-07T17:13:14 | {} | CONTRIBUTOR |
vuejs | core | 597,428,589 | 813 | underfin | The click event trigger twice because the event is bubbling.
The code will works.
```
<button @click.stop="onClick"><slot/></button>
``` | 2020-03-11T03:41:15 | 2020-03-11T03:41:15 | {} | MEMBER |
vuejs | core | 599,161,524 | 837 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-03-15T03:05:12 | 2020-03-15T03:05:12 | {} | CONTRIBUTOR |
vuejs | core | 600,079,024 | 847 | yyx990803 | It's working fine for me. Can you share your tsconfig? | 2020-03-17T13:43:42 | 2020-03-17T13:43:42 | {} | MEMBER |
vuejs | core | 601,538,740 | 853 | ysj16 | @yyx990803 I still have some confusion, because a component will always add into parent's dynamic children list when create vnode | 2020-03-20T04:56:03 | 2020-03-20T04:56:03 | {} | CONTRIBUTOR |
vuejs | core | 596,395,544 | 810 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [Header rules](https://app.netlify.com/sites/vue-next-coverage/deploys/5e65ff1184741b00075aa4c5)
- [Pages changed](https://app.netlify.com/sites/vue-next-coverage/deploys/5e65ff1184741b00075aa4c5)
Dependabot will still automatically merg... | 2020-03-09T08:33:27 | 2020-03-09T08:33:27 | {} | CONTRIBUTOR |
vuejs | core | 597,467,574 | 813 | LastHeaven | @hareku
Thanks，it worked。 | 2020-03-11T06:35:20 | 2020-03-11T06:35:20 | {} | NONE |
vuejs | core | 599,030,147 | 831 | sqal | ouch! I don't know how I missed that :( Sorry for false alarm | 2020-03-14T08:55:18 | 2020-03-14T09:17:32 | {} | CONTRIBUTOR |
vuejs | core | 599,653,623 | 575 | jaskang | > Is this feature in progress? If not, I can try. @yyx990803
@ysj16 If you have no time, I'll do it for you. hahah | 2020-03-16T17:05:39 | 2020-03-16T17:05:39 | {
"+1": 3
} | NONE |
vuejs | core | 599,726,311 | 660 | yyx990803 | @sionzeecz your case is working as intended. If you want to report a bug, open a new issue with actual reproduction instead of commenting on other issues. | 2020-03-16T19:43:12 | 2020-03-16T19:43:12 | {
"+1": 1,
"-1": 2
} | MEMBER |
vuejs | core | 599,765,707 | 660 | yyx990803 | By "working as intended" I mean the code you showed *is* working. There is no bug. If there is one, you should provide a reproduction (e.g. a codepen, and in a separate issue). | 2020-03-16T21:26:30 | 2020-03-16T21:28:17 | {} | MEMBER |
vuejs | core | 599,793,043 | 721 | yyx990803 | There are many issues that are unclear here, most importantly how Vue is supposed to know what arguments to provide to the exported function. Exporting a function also conflicts with plain functional components.
Closing since there isn't anything actionable for implementation - if you are interested in pushing this ... | 2020-03-16T22:51:02 | 2020-03-16T22:51:02 | {} | MEMBER |
vuejs | core | 600,080,622 | 660 | jods4 | With the change I proposed it would totally work, wouldn't it? And that's kind of the point.
I don't see how `ref` is more consistent or explicit.
It may be for users coming from a Vue 2 background, I understand that and it should definitely work for them as they expect.
At the same time, Vue 2 is the past, Vue 3 ... | 2020-03-17T13:46:53 | 2020-03-17T13:46:53 | {} | CONTRIBUTOR |
vuejs | core | 600,790,894 | 849 | loeffel-io | Added all features:
- Allow glob patterns like `packages/**` or `packages/*/src` or also `packages/**/{src,__tests__}`
- Allow combining multiple allowed cases like `camelCase | PascalCase`
I created two solutions:
**1) Matches all files, really strict**
```yaml
ls:
.js: kebab-case
.ts: camelCase
... | 2020-03-18T18:26:21 | 2020-03-18T18:26:21 | {} | CONTRIBUTOR |
vuejs | core | 601,759,642 | 858 | yyx990803 | `watch` is a component level concept. The lower level equivalent is `effect` in `@vue/reactivity`. | 2020-03-20T15:29:13 | 2020-03-20T15:29:13 | {} | MEMBER |
vuejs | core | 597,439,934 | 813 | hareku | @LastHeaven
The attr fallthrough behavior was changed at https://github.com/vuejs/vue-next/commit/e1660f4338fbf4d2a434e13193a58e00f844379b for https://github.com/vuejs/rfcs/pull/137.
When you set `inheritAttrs: false` to MButton component, it will work as you expected. | 2020-03-11T04:36:27 | 2020-03-11T04:36:27 | {
"+1": 8
} | CONTRIBUTOR |
vuejs | core | 599,797,843 | 660 | jods4 | @yyx990803 Can I ask what's the motivation?
The changes I proposed seemed simple enough... why can't I put a DOM element reference into a `reactive` object? | 2020-03-16T23:08:39 | 2020-03-16T23:08:39 | {} | CONTRIBUTOR |
vuejs | core | 600,105,727 | 843 | yyx990803 | Fixed the boolean validation issue in 3b282e7.
Re the trick: I think we should stick to something that's easier to understand. | 2020-03-17T14:36:11 | 2020-03-17T14:36:11 | {
"+1": 1
} | MEMBER |
vuejs | core | 600,827,428 | 849 | yyx990803 | Is the `ignore` really needed with only directory specific rules? | 2020-03-18T19:51:30 | 2020-03-18T19:51:30 | {} | MEMBER |
vuejs | core | 600,855,906 | 849 | yyx990803 | Cool.
One final pet peeve I have is for `dist` files, our actual naming scheme is kebab-case followed by point.case. Because we have a lot of extension ending combination for the dist files, it's pretty annoying to have to list all of them. Maybe `ls-lint` can support combining cases like `[kebab-case].[point.case]`... | 2020-03-18T21:00:34 | 2020-03-18T21:00:34 | {} | MEMBER |
vuejs | core | 597,695,080 | 813 | yyx990803 | In v3 all `v-on` listeners will fallthrough to child component root by default - which means it's no longer necessary to manually re-emit the `click` event. You can simply remove your click listener in the child instead of using `inheritAttrs: false` (which disables fallthrough for other attributes, e.g. `class`) | 2020-03-11T15:19:34 | 2020-03-11T15:20:18 | {
"+1": 18,
"heart": 5,
"rocket": 4
} | MEMBER |
vuejs | core | 598,255,232 | 815 | yyx990803 | You can use the `cloneVNode` helper which accepts a second argument for extra props to be merged:
``` js
import { cloneVNode } from 'vue'
// in render fn
const slotContent = slots.default ? slots.default() : []
const transformedSlotContent = slotContent.map(vnode => cloneVNode(vnode, {
onClick: () => { /* .... | 2020-03-12T15:35:27 | 2020-03-12T15:36:48 | {
"+1": 3
} | MEMBER |
vuejs | core | 599,050,560 | 832 | jods4 | Oh right, my bad.
I really like the fact that with the template compiler you can self-close elements. Got so used to it that I forgot it was parsed by browser when used in codesandbox.
TIL: didn't know that if you use `<template>` it's parsed as text by Vue rather than browser. Thanks for the tip. | 2020-03-14T12:17:51 | 2020-03-14T12:17:51 | {} | CONTRIBUTOR |
vuejs | core | 592,767,423 | 762 | yyx990803 | See https://github.com/vuejs/vue-next/commit/e1660f4338fbf4d2a434e13193a58e00f844379b | 2020-02-28T22:57:40 | 2020-02-28T22:57:40 | {} | MEMBER |
vuejs | core | 592,959,021 | 749 | ysj16 | > Maybe `class` and `style` should be special cased even when no props are declared.
All attrs will fallthrough in vue 2.x | 2020-02-29T15:51:22 | 2020-02-29T15:51:22 | {} | CONTRIBUTOR |
vuejs | core | 592,979,360 | 681 | veaba | The triggered animation node should not follow the length of v-for to re render, only the new node | 2020-02-29T18:30:04 | 2020-02-29T18:30:04 | {} | MEMBER |
vuejs | core | 595,632,967 | 803 | underfin | Fix at https://github.com/vuejs/vue-next/commit/e67f655b2687042fcc74dc0993581405abed56de | 2020-03-06T07:12:23 | 2020-03-06T07:12:23 | {
"+1": 1,
"heart": 1,
"hooray": 1
} | MEMBER |
vuejs | core | 595,850,066 | 793 | cexbrayat | Ha my bad, I thought it was working without it when I tested.
I updated the PR to just bump monaco then. | 2020-03-06T16:32:19 | 2020-03-06T16:32:19 | {} | MEMBER |
vuejs | core | 597,446,807 | 815 | jbruni | It looks like this other issue (closed automatically) is related: https://github.com/vuejs/vue-next/issues/814 | 2020-03-11T05:08:21 | 2020-03-11T05:08:21 | {} | NONE |
vuejs | core | 597,736,026 | 815 | yyx990803 | This is expected, because calling slot functions technically always return fresh vnodes. The reason why `#parent2` works is because the static slot content has been hoisted so it is returning the same (already mounted) vnode.
The idea here is that:
1. You should **not** be relying on `vnode.el` in userland code. ... | 2020-03-11T16:31:59 | 2020-03-11T16:31:59 | {
"+1": 2,
"eyes": 1
} | MEMBER |
vuejs | core | 598,207,464 | 826 | yyx990803 | v3 no longer supports rendering component using strings, since when you are using render functions you can always use the direct value. This also enables better compiler optimizations.
If you **have** to use a global registered component in render functions, use `resolveComponent`:
``` js
import { resolveCompone... | 2020-03-12T14:11:15 | 2020-03-12T14:11:29 | {} | MEMBER |
vuejs | core | 599,960,861 | 848 | jiangying000 | # Two approaches
1. You can config webpack like:
```js
{
test: /\.vue$/,
use: {
loader: "vue-loader",
options: {
compilerOptions: {
isCustomElement: tag => {
return tag === "custom";
}
}
}
}
... | 2020-03-17T09:12:44 | 2020-03-17T09:12:44 | {} | CONTRIBUTOR |
vuejs | core | 600,046,010 | 843 | jods4 | Also I learned a new trick today. It's more obscure but maybe more efficent, `>>>` _always_ returns a positive integer, _even in edge case `>>> 0`_. So `-1 >>> 0 == 4294967295`
So where my PR did
`stringIndex < 0 || booleanIndex < stringIndex`
you could do, if you're into bit tricks:
`booleanIndex < (stringInde... | 2020-03-17T12:34:27 | 2020-03-17T12:34:27 | {} | CONTRIBUTOR |
vuejs | core | 600,853,325 | 849 | loeffel-io | My fault!
```yml
ls:
packages/**/{src,__tests__}:
.js: kebab-case
.ts: camelCase | PascalCase
.d.ts: camelCase
.spec.ts: camelCase | PascalCase
.mock.ts: camelCase
packages/**/dist:
.global.js: kebab-case
.umd.js: kebab-case
```
This would be the final configuration �... | 2020-03-18T20:54:27 | 2020-03-18T20:54:27 | {} | CONTRIBUTOR |
vuejs | core | 691,896,137 | 2,110 | posva | I think it would make sense to only treat it as an `template` tag if it's used alongside `v-pre`. In Vue 2, the behavior is not completely consistent:
- Using one single template:
```html
<template v-pre>
Hello {{''}}
</template>
```
still outputs `Hello {{''}}`
- While using two templates:
```htm... | 2020-09-14T08:12:43 | 2020-09-14T08:12:43 | {
"+1": 1
} | MEMBER |
vuejs | core | 692,143,709 | 2,056 | yyx990803 | Unfortunately this will be the expected behavior in Vue 3 due to how templates are now compiled differently to enable better update performance. In brief, template node structures are always treated as "stable" and `key` can now only force replacement of the a node itself, but can no longer enforce reuse of nodes that ... | 2020-09-14T15:44:36 | 2020-09-14T15:44:36 | {} | MEMBER |
vuejs | core | 692,405,224 | 2,052 | yyx990803 | Thanks for catching this - I managed to type it in a way that doesn't require modifying existing runtime code: b2dc9537 | 2020-09-15T01:27:09 | 2020-09-15T01:27:09 | {} | MEMBER |
vuejs | core | 692,405,621 | 2,076 | yyx990803 | In this case moderate duplication is better, IMO. | 2020-09-15T01:28:24 | 2020-09-15T01:28:24 | {} | MEMBER |
vuejs | core | 693,460,608 | 2,125 | unbyte | Oh, it was fixed while I was typing 😁 | 2020-09-16T14:54:41 | 2020-09-16T14:54:41 | {
"rocket": 1
} | CONTRIBUTOR |
vuejs | core | 693,506,167 | 2,135 | unbyte | I've pull the latest code and run the test, and it failed
```js
it('should avoid infinite recursive loops when use Array.prototype.push', () => {
const arr = reactive<number[]>([])
const counterSpy1 = jest.fn(() => arr.push(1))
const counterSpy2 = jest.fn(() => arr.push(2))
effect(counterSpy1)... | 2020-09-16T16:05:33 | 2020-09-16T16:06:47 | {} | CONTRIBUTOR |
vuejs | core | 693,511,898 | 2,134 | lovetingyuan | I am not sure about the reason. But if I remove `keep-alive` or remove the comment node in `ListComp.vue`, there is no render error.
| 2020-09-16T16:15:38 | 2020-09-16T16:15:38 | {} | NONE |
vuejs | core | 693,812,696 | 2,137 | CyberAP | This is expected since your effect is mutating its dependency. | 2020-09-17T04:29:47 | 2020-09-17T04:29:47 | {} | CONTRIBUTOR |
vuejs | core | 694,668,311 | 2,138 | CyberAP | I am a bit confused by this change, a more common use-case is broken now:
```js
setup() {
const arr = ref([])
watchEffect(() => {
console.log('Array: ', arr.value)
})
arr.value.push('test') // doesn't log
return { arr }
}
``` | 2020-09-18T05:50:17 | 2020-09-18T05:51:36 | {
"+1": 4
} | CONTRIBUTOR |
vuejs | core | 694,681,772 | 2,138 | unbyte | > I am a bit confused by this change, a more common use-case is broken now:
>
> ```js
> setup() {
> const arr = ref([])
>
> watchEffect(() => {
> console.log('Array: ', arr.value)
> })
>
> arr.value.push('test') // doesn't log
>
> return { arr }
> }
> ```
tested on rc... | 2020-09-18T06:27:35 | 2020-09-18T06:48:45 | {} | CONTRIBUTOR |
vuejs | core | 692,449,937 | 1,074 | johnsoncodehk | @yyx990803 Seems unable to inject css module $style, has any alternative method? | 2020-09-15T04:05:06 | 2020-09-15T04:34:05 | {} | MEMBER |
vuejs | core | 693,162,915 | 2,048 | wonderful-panda | Thank you. Rebased and pushed now.
BTW, [ExtraPropTypes](https://github.com/wonderful-panda/vue-next/blob/b3b9ec8072ecec2b320aaf743bcbe432dfd77bec/packages/runtime-core/src/componentProps.ts#L93) no longer needs second parameter (`MakeDefaultRequired`). It can be removed for now. | 2020-09-16T04:31:16 | 2020-09-16T04:31:16 | {} | CONTRIBUTOR |
vuejs | core | 693,822,908 | 2,137 | unbyte | @CyberAP I don't think it's reasonable, operating one array in two effects leads to infinite recursive call, it sounds crazy 😂 | 2020-09-17T04:37:23 | 2020-09-17T04:37:23 | {
"-1": 1
} | CONTRIBUTOR |
vuejs | core | 694,677,293 | 2,138 | edison1105 | > I believe that by fixing the logic of these mutational effects it could be possible to solve the issue without affecting valid use-cases like above:
>
> ```js
> const arr = reactive([])
>
> watchEffect(()=>{
> if (arr.includes(1)) return
> arr.push(1)
> })
>
> watchEffect(()=>{
> if (arr.includes(... | 2020-09-18T06:14:26 | 2020-09-18T06:14:26 | {} | MEMBER |
vuejs | core | 692,188,244 | 2,094 | yyx990803 | Should be fairly straightforward to provide - open to PR. | 2020-09-14T17:03:50 | 2020-09-14T17:03:50 | {} | MEMBER |
vuejs | core | 692,418,439 | 2,088 | yyx990803 | > Re: shall we fail gracefully if an error is thrown during parsing?
I added graceful fallback for failed parse when there is only `<script>` in c67e78ab | 2020-09-15T02:11:21 | 2020-09-15T02:11:21 | {} | MEMBER |
vuejs | core | 693,524,663 | 2,136 | pikax | When using ref or reactive with generics you need to cast to `as Ref<T>` and `as reactive<T>` if you sure that the type doesn't have any nested refs, because ref and reactive will unwrap nested refs automatically.
EDIT: You can test by simply doing:
```ts
const value = {
a: ref({
a : 1
})
}
value.a... | 2020-09-16T16:38:45 | 2020-09-16T16:44:32 | {
"+1": 9,
"heart": 4
} | MEMBER |
vuejs | core | 693,756,105 | 2,135 | dsonet | @unbyte If so, unshift may should also be included. | 2020-09-17T01:39:36 | 2020-09-17T01:46:06 | {} | CONTRIBUTOR |
vuejs | core | 694,610,017 | 2,154 | justinfagnani | Why wouldn't https://unpkg.com/@vue/reactivity?module be expected to resolve to a version that works in browsers?
The big problem is locally though. I would expect to simply write `@vue/reactivity` this to import the library:
```ts
import {shallowReactive, effect} from '@vue/reactivity';
```
But this fails, ... | 2020-09-18T02:24:20 | 2020-09-18T02:24:20 | {} | NONE |
vuejs | core | 694,837,191 | 2,155 | IndexXuan | In native Dom, we can onclick="handleClick" or we can dom.addEventListener as we want | 2020-09-18T12:25:08 | 2020-09-18T12:25:08 | {} | NONE |
vuejs | core | 691,696,147 | 2,106 | raphael10-collab | @posva Here: https://v3.vuejs.org/guide/migration/introduction.html#where-should-i-start-in-a-migration we read "Start by running the migration helper (still under development) on a current project. We've carefully minified and compressed a senior Vue dev into a simple command line interface. Whenever they recognize an... | 2020-09-13T16:55:29 | 2020-09-13T17:03:07 | {
"+1": 3
} | NONE |
vuejs | core | 692,184,320 | 1,981 | yyx990803 | We can't warn it in every case since technically you can let `v-model` generated props fall through to an inner component.
As for making it easier to migrate to the new usage, that belongs to the migration build where we try to provide v2 compatibility and detailed warnings when possible. `v-model` will definitely b... | 2020-09-14T16:56:42 | 2020-09-14T16:56:42 | {} | MEMBER |
vuejs | core | 692,538,696 | 1,074 | johnsoncodehk | @posva I have been troubled by this problem for a long time! I always to use ```getCurrentInstance().proxy.$style``` before. Thanks a lot!! | 2020-09-15T07:57:31 | 2020-09-15T07:57:31 | {} | MEMBER |
vuejs | core | 693,146,678 | 2,123 | akai007 | Is my mistake. when I run npm install than the Vue version roll back to 2.x. | 2020-09-16T03:22:50 | 2020-09-16T03:22:50 | {} | NONE |
vuejs | core | 693,410,804 | 2,132 | cexbrayat | @yyx990803 Ok thanks, i saw the changes but thought this one would still work.
I still have something weird I think:
```html
<button @click="toggled = !toggled">Toggle {{ toggled }}</button>
<Suspense>
<div v-if="toggled">
<hello />
</div>
<template #fallback>Loading...</template>
</Suspense>
`... | 2020-09-16T13:37:38 | 2020-09-16T13:37:38 | {} | MEMBER |
vuejs | core | 693,432,830 | 2,127 | yyx990803 | This is a bit too strict - ideally we want to use ESLint with `after-used` but not checking args in types. | 2020-09-16T14:11:49 | 2020-09-16T14:11:49 | {} | MEMBER |
vuejs | core | 694,124,843 | 1,414 | soultice | This seems to break now that vue-cli isn't using vue-cli-plugin-vue-next anymore.
I'm getting
```bash
Module Error (from ./node_modules/vue-loader/lib/index.js):
[vue-loader] vue-template-compiler must be installed as a peer dependency, or a compatible compiler implementation must be passed via options.
```
Whe... | 2020-09-17T09:50:37 | 2020-09-17T10:34:23 | {} | NONE |
vuejs | core | 694,358,177 | 2,142 | leopiccionia | According to #2099, it's an intended change.
> By default, the current active tree will stay on the screen until the pending tree is resolved. The pending tree, when resolved, replaces the previous active tree and becomes the new active tree.
>
> A `timeout` prop can be specified - if a pending tree remains pendin... | 2020-09-17T16:42:53 | 2020-09-17T17:28:00 | {} | CONTRIBUTOR |
vuejs | core | 694,439,446 | 2,137 | CyberAP | You'll get the same result in Vue 2, the problem here is with the logic of the code, not with the Vue's API. | 2020-09-17T19:07:26 | 2020-09-17T19:07:26 | {} | CONTRIBUTOR |
vuejs | core | 692,719,508 | 2,120 | yyx990803 | Thanks! | 2020-09-15T13:36:35 | 2020-09-15T13:36:35 | {
"+1": 1,
"hooray": 1
} | MEMBER |
vuejs | core | 693,442,785 | 1,378 | ayZagen | I face with this issue when my component doesn't have `props`.
I faced with this on
**vue**: 3.0.0-rc.11
**rollup**: 2.27.0
**ts**: 4.0.2
This fails:
```js
export default defineComponent({
name: 'Test',
setup(){}
})
```
while this compiles OK:
```js
export default defineComponent({
name: 'Test',... | 2020-09-16T14:27:26 | 2020-09-16T14:27:26 | {
"+1": 1
} | NONE |
vuejs | core | 693,758,420 | 2,135 | unbyte | @dsonet and `pop` and `shift`, they all cause infinite recursion cuz they all depend on `.length` | 2020-09-17T01:48:00 | 2020-09-17T01:48:00 | {} | CONTRIBUTOR |
vuejs | core | 694,085,835 | 2,139 | RobbinBaauw | See https://github.com/vuejs/vue-next/issues/1166 | 2020-09-17T08:36:23 | 2020-09-17T08:36:23 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 692,176,432 | 2,061 | yyx990803 | See a096a58e - I think the previous case where v-if + component doesn't generate a block was a bit of an over optimization and removing that condition is easier. | 2020-09-14T16:42:38 | 2020-09-14T16:42:38 | {} | MEMBER |
vuejs | core | 693,444,067 | 1,378 | pikax | @aztalbot fixed on https://github.com/vuejs/vue-next/pull/2124 wait for the next version please | 2020-09-16T14:29:21 | 2020-09-16T14:29:21 | {
"+1": 2
} | MEMBER |
vuejs | core | 693,708,580 | 1,837 | jtommy | @nstuyvesant Same problem! I'm not able to get `componentInstance` as i did in vue 2 and "new" `component` field is always null
PS: I'm using options api | 2020-09-16T22:56:49 | 2020-09-16T22:56:49 | {} | NONE |
vuejs | core | 693,804,911 | 2,137 | dsonet | What about method splice? | 2020-09-17T04:23:56 | 2020-09-17T04:23:56 | {} | CONTRIBUTOR |
vuejs | core | 694,110,404 | 2,141 | lawvs | Please use `getCurrentInstance`.
```ts
import { getCurrentInstance } from 'vue'
onMounted(() => {
const instance = getCurrentInstance()
})
```
<!--
Ref #1849
--> | 2020-09-17T09:22:05 | 2020-09-17T09:30:31 | {} | CONTRIBUTOR |
vuejs | core | 694,649,338 | 2,138 | yyx990803 | I updated the implementation to use static instrumentations in the same map (this is more efficient than creating a new function on every access). | 2020-09-18T04:53:05 | 2020-09-18T04:53:05 | {
"-1": 2,
"laugh": 1
} | MEMBER |
vuejs | core | 691,848,952 | 1,997 | dxvladislavvolkov | @yyx990803 I see in the [documentation](https://v3.vuejs.org/api/global-api.html#h) that I can use null as a type | 2020-09-14T06:40:13 | 2020-09-14T06:40:13 | {} | NONE |
vuejs | core | 692,282,037 | 2,089 | yyx990803 | Update: only call it when the stable fragment has key + do not traverse recursively. | 2020-09-14T20:02:02 | 2020-09-14T20:02:02 | {} | MEMBER |
vuejs | core | 692,524,197 | 1,074 | posva | @johnsoncodehk you have `useCssModules` and `useCssVars` 😉 They still have to be added to the docs.
Remember you can use the [Discord chat](https://vue-land.js.org/) to ask questions! | 2020-09-15T07:29:31 | 2020-09-15T07:29:31 | {
"heart": 1
} | MEMBER |
vuejs | core | 694,454,499 | 2,142 | cexbrayat | @leopiccionia 👍 I agree, but it's weird to have the fallback tree on first load (if `toggled` is `true`), right away (depite having a timeout or not) and not on the following toggles without timeout. If that's expected, I don't mind closing it, but I'd like a confirmation. I personally think it was more intuitive prev... | 2020-09-17T19:34:07 | 2020-09-17T19:34:07 | {} | MEMBER |
vuejs | core | 694,641,157 | 2,142 | yyx990803 | @leopiccionia 's interpretation is correct. However, I agree this is still open to discussion. Maybe we should default the `timeout` to `0` which encourages users to always set a timeout. | 2020-09-18T04:20:43 | 2020-09-18T04:20:43 | {} | MEMBER |
vuejs | core | 694,680,036 | 2,138 | CyberAP | It depends on the logic that describes why it should call `arr.push` in the first place. That logic should be contained within the effect.
When I see an effect that says `arr.push` I think of it as this: when an array changes push another value there. But this is recursive by definition. So in order to break infinite ... | 2020-09-18T06:22:37 | 2020-09-18T06:22:37 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 693,404,310 | 2,132 | yyx990803 | Not really a regression - Suspense usage has been reworked. In short, only suspense root node toggles will trigger pending state now. More details in https://github.com/vuejs/vue-next/pull/2099 | 2020-09-16T13:26:57 | 2020-09-16T13:27:26 | {} | MEMBER |
vuejs | core | 694,064,058 | 2,139 | dnlsndr | What is your issue? Provide some more explaination or examples please? | 2020-09-17T07:55:21 | 2020-09-17T07:55:21 | {} | NONE |
vuejs | core | 694,670,710 | 2,138 | CyberAP | I believe that by fixing the logic of these mutational effects it could be possible to solve the issue without affecting valid use-cases like above:
```js
const arr = reactive([])
watchEffect(()=>{
if (arr.includes(1)) return
arr.push(1)
})
watchEffect(()=>{
if (arr.includes(2)) return
arr.push(2... | 2020-09-18T05:56:38 | 2020-09-18T05:57:07 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 694,824,339 | 2,156 | posva | `unref` is more common because you use it to extract arguments in composition functions that can accept both raw data and refs. On top of that, you don't need to check if the data is a ref when calling `ref(data)`, it should already work
There is already a `toRef` function BTW | 2020-09-18T11:53:23 | 2020-09-18T11:53:23 | {} | MEMBER |
vuejs | core | 692,411,137 | 1,999 | yyx990803 | I think it's better to not keep legacy compat code here (they should be in the compat build). We will document this as an non-RFC minor breaking change in the migration guide and only emit a warning for now (to keep consistent behavior between prod and dev). | 2020-09-15T01:47:25 | 2020-09-15T01:47:25 | {} | MEMBER |
vuejs | core | 694,984,055 | 963 | unbyte | As a supplement, the reason I think is that when call this arrow function as an argument of `c`, typescript can't infer the type of this arrow function.
```typescript
() => {
return x.a;
}
``` | 2020-09-18T17:12:14 | 2020-09-18T17:14:22 | {} | CONTRIBUTOR |
vuejs | core | 695,145,471 | 2,159 | wonderful-panda | (edit) I posted this comment here by mistake, this is comment for https://github.com/vuejs/vue-next/pull/2160.
-----
Sorry, this fix has a problem. (type of $emit is broken)
Before:
After:
![image](... | 2020-09-19T01:28:08 | 2020-09-19T01:48:07 | {} | CONTRIBUTOR |
vuejs | core | 692,398,437 | 2,117 | yyx990803 | https://github.com/vitejs/vite/issues/809#issuecomment-692398088 | 2020-09-15T01:04:41 | 2020-09-15T01:04:41 | {} | MEMBER |
vuejs | core | 693,128,922 | 2,115 | yi-tuan | > Thanks for the PR but I don't think this is necessary. A union literal is more straightforward in my opinion.
Yeah, but the number type is missing here~ The PropertyKey built-in type contains `number、string、symbol`
| 2020-09-16T02:20:02 | 2020-09-16T02:50:27 | {} | NONE |
vuejs | core | 693,766,119 | 1,837 | nstuyvesant | The only way I was able to overcome the problem was to use the render function as shown above. Neither the options nor composition API gave me the ability to get a componentInstance from a vnode. | 2020-09-17T02:15:06 | 2020-09-17T02:15:06 | {} | NONE |
vuejs | core | 694,082,678 | 2,139 | xjh1230 | in vue2 $refs.items is [li#1, li#2, li#3]
<div id="app">
<ul>
<li ref="items" v-for="item in items" :id="item" :key="item">{{item}}</li>
</ul>
</div>
<script src="https://cdn.jsdelivr.net/npm/vue/dist/vue.js"></script>
<script>
var app = new Vue({
... | 2020-09-17T08:30:22 | 2020-09-17T08:30:22 | {} | NONE |
vuejs | core | 694,825,402 | 2,155 | posva | See https://v3.vuejs.org/guide/migration/events-api.html#overview
---
Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.... | 2020-09-18T11:56:15 | 2020-09-18T11:56:15 | {} | MEMBER |
vuejs | core | 694,880,598 | 2,155 | posva | The components no longer implement that API: https://v3.vuejs.org/guide/migration/events-api.html#overview it went through an RFC https://github.com/vuejs/rfcs/pull/118 | 2020-09-18T13:51:21 | 2020-09-18T13:51:21 | {} | MEMBER |
vuejs | core | 695,023,037 | 963 | fnlctrl | 
I think the error message is quite clear
'x' implicitly has type 'any' because it does not have a type annotation and **is referenced directly or indirectly in its own initializer**.(7022)
An easy workar... | 2020-09-18T18:34:51 | 2020-09-18T18:34:51 | {
"+1": 2
} | MEMBER |
vuejs | core | 695,147,338 | 2,160 | wonderful-panda | Fixed problem of [this comment](https://github.com/vuejs/vue-next/issues/2159#issuecomment-695145471) by 758119b
| 2020-09-19T01:43:53 | 2020-09-19T01:43:53 | {} | CONTRIBUTOR |
vuejs | core | 695,197,588 | 2,163 | unbyte | `watchEffect` returns a function to stop effect so you can stop it manually
```js
const stop = watchEffect(() => {
/* ... */
})
// later
stop()
``` | 2020-09-19T10:43:03 | 2020-09-19T10:43:03 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.