owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 660,460,577 | 1,618 | legnaleurc | I have no idea.
I saw this during migrating some legacy code to v3. Maybe there was a `v-if` or it was a slot, but been removed and only the `template` tag left.
Both behavior are OK to me. Just curious about whether this is a bug fix for v2. | 2020-07-18T10:10:34 | 2020-07-18T10:10:34 | {} | NONE |
vuejs | core | 660,655,806 | 1,637 | xPaw | Changing `template` to `div` fixes the issue.
[AST for template](https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3Ctemplate%20v-if%3D%5C%22false%5C%22%3E%3C%2Ftemplate%3E%5Cn%3Ctemplate%20v-for%3D%5C%22abc%20in%20%5B1%2C%202%2C%203%5D%5C%22%20v-else%3E%5Cn%20%20%7B%7B%20abc%20%7D%7D%5Cn%3C%2Ftempl... | 2020-07-19T14:44:17 | 2020-07-19T14:44:17 | {} | NONE |
vuejs | core | 660,180,745 | 1,600 | yyx990803 | > In my project, I used the parser of vue compiler to do some template conversion work
Can you be more specific? Are you converting legacy HTML to Vue templates or doing transforms on Vue templates? Why would you need the whitespace to be preserved? | 2020-07-17T15:46:36 | 2020-07-17T15:46:36 | {} | MEMBER |
vuejs | core | 660,453,691 | 1,618 | posva | what do you create a `template` tag for if you don't use `v-if` or `v-for` on it? | 2020-07-18T09:08:27 | 2020-07-18T09:08:27 | {} | MEMBER |
vuejs | core | 660,573,324 | 1,618 | yyx990803 | This is intended. `<template>` with no structural directives will be rendered as-is. You can consider it a "fix". | 2020-07-19T02:10:39 | 2020-07-19T02:10:39 | {} | MEMBER |
vuejs | core | 660,693,741 | 1,609 | posva | It works fine. What is the version you are using? | 2020-07-19T19:15:20 | 2020-07-19T19:15:20 | {} | MEMBER |
vuejs | core | 660,951,790 | 1,655 | posva | as the warning suggests, you need to use a function: `watch(() => array` with reactive. You will also need `{ deep: true }` to track changes inside of the array | 2020-07-20T10:45:03 | 2020-07-20T10:45:03 | {} | MEMBER |
vuejs | core | 661,163,218 | 1,645 | yyx990803 | The type of a component (stateful vs. functional) must be known before hand because the side-effect of calling
```js
function Counter(props) {
// the render function itself
return h('div', props.foo)
}
```
vs.
```js
function Counter(props) {
// stateful setup logic
return () => h('div', props... | 2020-07-20T16:35:02 | 2020-07-20T16:35:02 | {
"+1": 4
} | MEMBER |
vuejs | core | 661,600,036 | 1,662 | yyx990803 | See https://github.com/vuejs/vue-cli/pull/5637
You will be able to select Vue 2/3 when you create a new project via `vue-cli` once the PR is merged. | 2020-07-21T03:03:21 | 2020-07-21T03:03:21 | {} | MEMBER |
vuejs | core | 659,425,379 | 1,598 | aztalbot | Could you use the existing `getCurrentInstance` function for what you are trying to do?
```js
import { getCurrentInstance } from "vue"
export function useContext() {
const { props, emit, slots, attrs } = getCurrentInstance()
return { props, emit, slots, attrs } // assuming you aren't interested in the whole ... | 2020-07-16T13:50:00 | 2020-07-16T14:04:38 | {} | CONTRIBUTOR |
vuejs | core | 659,540,793 | 1,600 | CodeDaraW | In my project, I used the parser of vue compiler to do some template conversion work, but found that the whitespaces and newlines were ignored in the final AST. So I hope the compiler can provide this strategy configuration item. | 2020-07-16T16:56:16 | 2020-07-16T16:56:16 | {} | CONTRIBUTOR |
vuejs | core | 659,796,777 | 1,600 | Justineo | @CodeDaraW I think that's a valid use case and I was bringing up a related issue. | 2020-07-17T02:29:18 | 2020-07-17T02:29:18 | {} | MEMBER |
vuejs | core | 660,671,294 | 1,641 | jacekkarczmarczyk | see https://github.com/vuejs/vue-next/issues/1119 | 2020-07-19T16:22:59 | 2020-07-19T16:22:59 | {} | CONTRIBUTOR |
vuejs | core | 661,111,444 | 1,645 | CyberAP | @bjarkihall if you need to simplify your component you can use setup to return a render function, instead of creating a Functional Component for that:
```js
export default {
setup() {
const counter = ref(0)
const increment = () => counter.value++
return () => [
h('div', counter),
... | 2020-07-20T15:29:46 | 2020-07-20T15:29:46 | {} | CONTRIBUTOR |
vuejs | core | 661,577,502 | 1,646 | fnoori | > The CLI plugin for vue-next is still WIP: [vuejs/vue-cli#5637](https://github.com/vuejs/vue-cli/pull/5637). Since you are also using Vue-property-decorator, you will also need to make sure to use the correct versions: [kaorun343/vue-property-decorator#294](https://github.com/kaorun343/vue-property-decorator/issues/29... | 2020-07-21T02:30:39 | 2020-07-21T02:30:39 | {} | NONE |
vuejs | core | 661,604,323 | 1,648 | lexSeven | > I think you misunderstood the intention of this list.
> It's not meant to (nor able to) "guide" users.
Put aside the problem itself. I think you underestimate the influence of vue3. It has tens of thousands of users. Any details will be magnified and will affect many users | 2020-07-21T03:16:00 | 2020-07-21T03:16:00 | {} | CONTRIBUTOR |
vuejs | core | 659,591,072 | 1,598 | AlexandreBonaventure | well, in my mind composition API scope is much bigger than just dealing with reusable state & lifecycle. To me it was brought in to overcome shared component logic issues with mixins as a whole. | 2020-07-16T18:28:07 | 2020-07-16T18:28:34 | {} | CONTRIBUTOR |
vuejs | core | 660,454,192 | 1,617 | posva | The recommendation hasn't changed.
I think the example you should compare it to is at https://github.com/vuejs/vue/blob/dev/examples/tree/tree.js | 2020-07-18T09:12:30 | 2020-07-18T09:12:30 | {} | MEMBER |
vuejs | core | 660,868,014 | 1,645 | icehaunter | @baryla I believe they state in the docs that performance difference is negligible for functional components, so [Vue 3 migration guide](https://v3.vuejs.org/guide/migration/functional-components.html) recommends using stateful components | 2020-07-20T07:57:41 | 2020-07-20T07:57:41 | {} | NONE |
vuejs | core | 660,980,271 | 1,648 | haoqunjiang | I think you misunderstood the intention of this list.
It's not meant to (nor able to) "guide" users. | 2020-07-20T11:51:09 | 2020-07-20T11:51:09 | {
"+1": 1
} | MEMBER |
vuejs | core | 661,179,439 | 1,659 | yyx990803 | This is not for compatibility, it is simply for performance. Using Symbols is significantly slower than plain string keys. | 2020-07-20T16:49:45 | 2020-07-20T16:49:45 | {} | MEMBER |
vuejs | core | 661,632,482 | 1,648 | lexSeven | It's not about right or wrong. It's not about you. It's not about me. It's a matter of attitude | 2020-07-21T04:54:01 | 2020-07-21T04:54:01 | {} | CONTRIBUTOR |
vuejs | core | 659,449,771 | 1,599 | yyx990803 | First, I'd say this kind of chained watching is bad practice - you are relying on side effects to propagate the consistency of the state graph.
From your example, the only actual mutable state is `zoom` while `visibleRange` and all other state the depends on `zoom` are **derived state**, which by design should be mo... | 2020-07-16T14:29:02 | 2020-07-16T14:29:02 | {} | MEMBER |
vuejs | core | 660,957,572 | 1,650 | haoqunjiang | There's no `background-image` attribute in HTML standard. It can't be added to `isKnownAttr`. | 2020-07-20T10:58:11 | 2020-07-20T10:58:11 | {} | MEMBER |
vuejs | core | 661,118,647 | 1,645 | baryla | @bjarkihall that's very interesting indeed and I totally agree that it may be confusing for React devs wanting to try Vue but it's all down to the direction of Vue. Very nice writeup though, thanks for the investigation!
@Aurelius333 oh that's quite nice! So if we already have that ability, it may not be too much wo... | 2020-07-20T15:41:43 | 2020-07-20T15:41:43 | {} | NONE |
vuejs | core | 659,449,148 | 1,598 | AlexandreBonaventure | @aztalbot I was not aware of this API, sounds like it's exactly what I'm looking for! thanks.
I leave it open because of
> The main caveat here I think is that the props, slots, and attrs in setup have an additional proxy wrapper around each of them, and when using getCurrentInstance you have unproxied slots and a... | 2020-07-16T14:28:03 | 2020-07-16T14:28:03 | {} | CONTRIBUTOR |
vuejs | core | 659,450,875 | 1,600 | yyx990803 | What's the actual use for this?
@Justineo can you summarize the differences between condense mode and JSX whitespace handling? | 2020-07-16T14:30:43 | 2020-07-16T14:31:37 | {} | MEMBER |
vuejs | core | 659,451,093 | 1,595 | RobbinBaauw | https://github.com/vuejs/vue-next/commit/165068dbc295bb70fdec9ae56dfcaac17d2f977c may have introduced another problem (it broke our custom renderer). `flushPostFlushCbs` is called in the render function: https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/renderer.ts#L2125-L2135.
The problem lies... | 2020-07-16T14:31:04 | 2020-07-16T14:44:29 | {} | CONTRIBUTOR |
vuejs | core | 660,673,000 | 1,632 | fwh1990 | Of course https://github.com/easy-demo/vue-3-rc1
The error only happens when we enable declaration:
```json5
// tsconfig.json
{
"declaration": true
}
``` | 2020-07-19T16:35:08 | 2020-07-19T16:35:08 | {} | NONE |
vuejs | core | 661,051,718 | 1,645 | bjarkihall | I thought functional components would support the Composition API, according to [rfc0008](https://github.com/vuejs/rfcs/blob/render-fn-api-change/active-rfcs/0008-render-function-api-change.md#functional-component-signature).
So is inject only reactive but not refs? | 2020-07-20T13:49:46 | 2020-07-20T13:49:46 | {} | CONTRIBUTOR |
vuejs | core | 661,385,053 | 1,657 | lmiller1990 | Is there a good way to know if a component is functional? Something like SHAPE_FLAGS to detect a functional component? What do you think @cuixiaorui ? We explore this a bit before making changes in core.
It might lead to more complexity in VUT but that's fine - core already has more than enough complexity as it is.... | 2020-07-20T22:27:36 | 2020-07-20T22:27:36 | {} | MEMBER |
vuejs | core | 660,447,101 | 1,618 | a1mersnow | Same question here | 2020-07-18T08:06:33 | 2020-07-18T08:06:33 | {} | NONE |
vuejs | core | 660,696,337 | 1,644 | yyx990803 | emit an event to let the parent update the props. | 2020-07-19T19:33:49 | 2020-07-19T19:33:49 | {} | MEMBER |
vuejs | core | 660,714,488 | 1,645 | CyberAP | Functional components do not have state so this should be expected. | 2020-07-19T21:45:48 | 2020-07-19T21:45:48 | {} | CONTRIBUTOR |
vuejs | core | 660,823,533 | 1,648 | Justineo | One of the major concerns in web technology is backward compatibility. I don't think it's good to break that, no mention `width` and `height` are only deprecated for some elements, not for things like `<img>`. On the contrary, they are very crucial to user experience, which prevents layout shifts during resource loadin... | 2020-07-20T06:07:20 | 2020-07-20T06:07:20 | {
"+1": 4
} | MEMBER |
vuejs | core | 660,860,975 | 1,646 | posva | The CLI plugin for vue-next is still WIP: https://github.com/vuejs/vue-cli/pull/5637. Since you are also using Vue-property-decorator, you will also need to make sure to use the correct versions: https://github.com/kaorun343/vue-property-decorator/issues/294
Some types like `RouteConfig` have been renamed, so please... | 2020-07-20T07:42:01 | 2020-07-20T07:42:01 | {
"heart": 2
} | MEMBER |
vuejs | core | 661,081,313 | 1,627 | wxy0902 | reference: https://developer.mozilla.org/zh-CN/docs/Web/HTML/Element/big | 2020-07-20T14:39:21 | 2020-07-20T14:39:21 | {} | CONTRIBUTOR |
vuejs | core | 661,145,579 | 1,645 | aztalbot | > I wonder why this isn't possible then (returning a function which returns the vnode), just like setup does:
@bjarkihall ... If I understand what you are suggesting, I remembered this had been considered in the past before settling on the approach of using `defineComponent`.
https://github.com/vuejs/rfcs/pull/42... | 2020-07-20T16:17:15 | 2020-07-20T16:17:29 | {} | CONTRIBUTOR |
vuejs | core | 661,162,522 | 1,645 | bjarkihall | @Aurelius333 I didn't notice that, thanks! I'd think the "name" mostly matters when using devtools, so maybe the implementation could use `if(__DEV__)` to get the name of the function, it's treeshaken away after all, right?
@CyberAP I know, the Functional Components were not clear (stateless vs stateful) - they're kin... | 2020-07-20T16:34:16 | 2020-07-20T16:34:16 | {} | CONTRIBUTOR |
vuejs | core | 678,774,516 | 1,935 | unbyte | @Zohenn i believe i have fixed it completely. However, to make `minlength` work well, the `oldValue !== newValue` comparison is required in every update for every `el.value`. i don't think it's a good way to fix it. | 2020-08-23T13:27:21 | 2020-08-23T13:27:21 | {} | CONTRIBUTOR |
vuejs | core | 679,448,870 | 1,956 | cool-little-fish | This happens beacause when call applyOptions, component's data was first resolved. #1953 | 2020-08-25T01:27:48 | 2020-08-25T01:27:48 | {} | CONTRIBUTOR |
vuejs | core | 680,018,933 | 1,958 | cool-little-fish | Try to add this to your MyButton.vue file:
The reason is simple, only when component define prop inside self, the outside prop can be prop value of component instance | 2020-08-25T13:17:13 | 2020-08-25T13:23:19 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 680,289,302 | 1,961 | posva | I'm referring to the alt text, search the word alpha just above in the markdown file | 2020-08-25T21:56:13 | 2020-08-25T21:56:13 | {} | MEMBER |
vuejs | core | 680,838,997 | 1,970 | HcySunYang | > I don't see how that works for nested objects.
Just use `toRaw()`:
```js
history.pushState(toRaw(s))
``` | 2020-08-26T12:08:13 | 2020-08-26T12:15:09 | {} | MEMBER |
vuejs | core | 681,150,482 | 1,965 | yyx990803 | We have to avoid mutating the original options because it may be used by other components as base for `extends` or as a mixin.
This regression was introduced by https://github.com/vuejs/vue-next/commit/a75b8a268fca800a49c7d772b4a290b4435e85b9 - I originally removed `components` and `directives` from component instan... | 2020-08-26T22:12:05 | 2020-08-26T22:12:05 | {} | MEMBER |
vuejs | core | 681,710,094 | 982 | bhabgs | Why not on the d.ts use it ?
(为什么不能在d.ts 中设置这个？)
``` js
declare module '@vue/runtime-core' {
interface ComponentCustomProperties {
$router: Router
}
}
```
| 2020-08-27T07:43:04 | 2020-08-27T07:43:04 | {} | NONE |
vuejs | core | 682,375,906 | 1,997 | dxvladislavvolkov | @HcySunYang I can't find it in docs. Is it a global API?
Why can't I use h function? | 2020-08-28T07:32:02 | 2020-08-28T07:32:02 | {} | NONE |
vuejs | core | 683,073,508 | 1,989 | CyberAP | Possibly related https://github.com/vuejs/vue-next/blob/00683fce9a1c6856be23b35ff0226d8ac5c96791/packages/runtime-dom/src/patchProp.ts#L38-L40 | 2020-08-28T18:47:56 | 2020-08-28T18:47:56 | {
"eyes": 1
} | CONTRIBUTOR |
vuejs | core | 683,130,241 | 1,962 | yyx990803 | 👍 | 2020-08-28T20:21:09 | 2020-08-28T20:21:09 | {} | MEMBER |
vuejs | core | 678,775,967 | 1,943 | ktsn | Oops, the type is used in `h` function. Let me fix it. | 2020-08-23T13:41:11 | 2020-08-23T13:41:11 | {} | CONTRIBUTOR |
vuejs | core | 679,012,093 | 1,916 | Picknight | @luvsic3 You can solve it as follows, I verified it on iOS 12 iPhone 8 Plus simulator:
```js
var seen = [];
const res = JSON.stringify(s, function (key, val) {
if (val != null && typeof val === "object") {
if (seen.indexOf(val) >= 0) {
return;
}
seen.push(val);
}
return val;
});
``` | 2020-08-24T09:18:40 | 2020-08-24T09:18:57 | {} | CONTRIBUTOR |
vuejs | core | 679,491,818 | 1,937 | unbyte | 🤐I have not processed a `changes requested` review, I am a bit at a loss, may have hit the inappropriate button | 2020-08-25T03:09:40 | 2020-08-25T03:09:40 | {} | CONTRIBUTOR |
vuejs | core | 680,044,382 | 1,959 | yyx990803 | Good catch! However, I think it's better to avoid the `__weh` details to leak outside of `apiLifecycle.ts`, so I made `injectHook` return the wrapped hook instead. | 2020-08-25T14:02:10 | 2020-08-25T14:02:50 | {
"+1": 1
} | MEMBER |
vuejs | core | 680,744,678 | 1,970 | posva | Create a copy instead, HistoryState does not accept all kind of values | 2020-08-26T08:41:45 | 2020-08-26T08:41:45 | {} | MEMBER |
vuejs | core | 680,812,631 | 1,970 | yagebu | > You cannot pass a Map to HistoryState, you will have to serialize it yourself anyway
As stated a couple of times, this is not about HistoryState (although that does to use SCA and support Maps, at least in some modern browsers: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algor... | 2020-08-26T11:06:12 | 2020-08-26T11:06:12 | {} | NONE |
vuejs | core | 680,913,794 | 1,970 | HcySunYang | @posva Maybe we need to reopen this? I think it's a valid use case 🤔. | 2020-08-26T14:26:23 | 2020-08-26T14:26:23 | {} | MEMBER |
vuejs | core | 681,014,293 | 1,958 | SancheZz | @yyx990803 Can I import an external `type` that I have to import in every SFC file?
```ts
import { ExternalStructType } from './types';
declare const props: {
struct: ExternalStructType;
};
``` | 2020-08-26T17:19:04 | 2020-08-26T17:19:04 | {} | NONE |
vuejs | core | 681,690,798 | 1,985 | unbyte | sorry I just find that it's a duplicate issue with #1978 😂 | 2020-08-27T07:30:17 | 2020-08-27T07:30:17 | {} | CONTRIBUTOR |
vuejs | core | 682,891,227 | 1,990 | yyx990803 | 1. The ref not being available in parent `mounted` is expected behavior. Suspense means its inner content may or may not be resolved when the parent component itself is considered "mounted". Or in other words, the parent's mounted hook is not going to wait for async child content (similar to how it won't wait for a chi... | 2020-08-28T16:56:32 | 2020-08-28T16:56:32 | {} | MEMBER |
vuejs | core | 678,988,794 | 1,943 | sunhao0313 | @yyx990803 hello , when will the next rc-version release? | 2020-08-24T08:33:34 | 2020-08-25T01:38:42 | {} | NONE |
vuejs | core | 680,262,122 | 1,961 | amerikan | @posva Not sure what alpha? This is what I see:
Are you referring to possibly the badge? If so that's an `<img>`, your browser might be caching an older one that says alpha. | 2020-08-25T20:48:42 | 2020-08-25T20:49:20 | {} | CONTRIBUTOR |
vuejs | core | 680,611,010 | 1,960 | dolymood | Thanks for your explanation.
I made some changes, replace `vue-reactivity-with-polyfill` with `vue-reactivity-polyfill` which is a pure polyfill and helper to enhance `@vue/reactivity`. For application do not need to replace `@vue/reactivity` now, just add `vue-reactivity-polyfill`.
Agreed with your ideas, the be... | 2020-08-26T04:46:39 | 2020-08-26T04:46:39 | {} | CONTRIBUTOR |
vuejs | core | 680,958,978 | 1,962 | yyx990803 | - `BindingMetadata` can only be one of `'data' | 'props' | 'setup' | 'options'` - so anything that is not data, setup or props goes into `options`.
- Re attach AST on the block: yeah I think that's a good idea. | 2020-08-26T15:40:09 | 2020-08-26T15:40:09 | {} | MEMBER |
vuejs | core | 681,000,612 | 1,228 | spikyjt | @sapphi-red thanks, that does work. However, either this is now a docs bug (should mention `skipLibCheck`) or still a code bug. I can't see how a library that's primary intended use is with transpiling by either babel or esbuild (i.e. where `isolatedModules` is a requirement) can be exporting const enums. It makes no s... | 2020-08-26T16:53:41 | 2020-08-26T16:53:41 | {
"+1": 6
} | NONE |
vuejs | core | 681,932,501 | 1,989 | Turboscherbe | Also when I add ```inheritAttrs: false``` to ```component-a``` (and ```component-b```), it also works like expected. | 2020-08-27T12:59:01 | 2020-08-27T12:59:01 | {} | NONE |
vuejs | core | 674,642,363 | 1,130 | ryansolid | The best use of something like `untracked` is to safeguard against people unknowingly doing stupid things in terms of execution when they are consumers of an API.
I've hit a number oftimes is you are making some composable hook-like behaviour that takes a callback function.. like say some sort of reactive mapping wh... | 2020-08-17T03:57:29 | 2020-08-26T18:12:28 | {
"+1": 4
} | NONE |
vuejs | core | 681,961,624 | 1,600 | CodeDaraW | > > In my project, I used the parser of vue compiler to do some template conversion work
>
> Can you be more specific? Are you converting legacy HTML to Vue templates or doing transforms on Vue templates? Why would you need the whitespace to be preserved?
Sorry to reply now, I've been busy these days.
Actual... | 2020-08-27T13:50:53 | 2020-08-27T13:52:01 | {} | CONTRIBUTOR |
vuejs | core | 682,852,029 | 1,958 | yyx990803 | @SancheZz that would work, but the compiler won't be able to infer the runtime type for it so it's going to skip runtime type check. | 2020-08-28T16:39:12 | 2020-08-28T16:39:12 | {} | MEMBER |
vuejs | core | 683,093,895 | 2,003 | CyberAP | It's strange that it didn't go through an RFC process. I can understand removing it from the `$watch` function, but removing it from the `watch` option doesn't look like an improvement to me (you'll have to create a computed for that watcher to work now). | 2020-08-28T19:10:27 | 2020-08-28T19:10:27 | {} | CONTRIBUTOR |
vuejs | core | 678,779,444 | 1,935 | Zohenn | @unbyte Maybe someone else will look into this and provide a different solution. I'm afraid I can't help you with this, but you're probably right about it being not the most optimal fix. | 2020-08-23T14:13:00 | 2020-08-23T14:13:00 | {} | NONE |
vuejs | core | 679,404,679 | 1,947 | yyx990803 | Note 53ed991 is a partial commit (I forgot to save the file when committing)
Proper fix commit is 36fa42a8 | 2020-08-24T22:48:17 | 2020-08-24T22:48:17 | {
"+1": 1
} | MEMBER |
vuejs | core | 679,450,853 | 1,944 | yyx990803 | It's ok to be explicit. I don't think it's worth changing. | 2020-08-25T01:35:13 | 2020-08-25T01:35:13 | {} | MEMBER |
vuejs | core | 679,453,258 | 1,943 | yyx990803 | This seems to fail the tests introduced in 955450f5 | 2020-08-25T01:44:44 | 2020-08-25T01:44:44 | {} | MEMBER |
vuejs | core | 680,047,756 | 1,958 | yyx990803 | `<script setup>` compilation requires props definitions to be in the same file. If we support arbitrary external imports then we will potentially crawling and parsing many TS files for a single SFC. We can detect and produce a warning for this case though. | 2020-08-25T14:07:48 | 2020-08-25T14:07:48 | {
"+1": 1
} | MEMBER |
vuejs | core | 680,940,717 | 1,970 | yyx990803 | Just re-read the spec and in item 23 of the [SCA](https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializeinternal) it explicitly states SCA does not accept Proxy objects. So yes a deep clone is pretty much required in this case. It actually is not related to the `[[Call]]` slot. | 2020-08-26T15:09:51 | 2020-08-26T15:10:28 | {
"+1": 1
} | MEMBER |
vuejs | core | 680,947,091 | 1,970 | HcySunYang | Ah, see it~ | 2020-08-26T15:19:59 | 2020-08-26T15:19:59 | {} | MEMBER |
vuejs | core | 682,213,189 | 1,994 | boussadjra | Oh, i didn't think about that, i forgot that we still working with javascript | 2020-08-27T22:01:52 | 2020-08-27T22:01:52 | {} | NONE |
vuejs | core | 683,197,672 | 2,003 | skirtles-code | This was mentioned briefly in #671 but it looks like it got lost in the subsequent discussion about potential changes to `immediate`. | 2020-08-29T00:06:58 | 2020-08-29T00:06:58 | {} | CONTRIBUTOR |
vuejs | core | 678,780,505 | 1,935 | unbyte | what about using `pattern`? this almost costs nothing
btw, I've tried to replace `minlength`'s native behavior with a js validator, unfortunately js can't operate on the value of `invalid` | 2020-08-23T14:22:59 | 2020-08-23T14:22:59 | {} | CONTRIBUTOR |
vuejs | core | 679,217,423 | 1,947 | zhigui | Face the same problem. Some use cases like [Tiptap](https://github.com/ueberdosis/tiptap).
🤔 related issue: https://github.com/vuejs/vue-next/issues/1595#issuecomment-659451093 | 2020-08-24T16:03:15 | 2020-08-24T16:03:15 | {} | NONE |
vuejs | core | 679,387,246 | 1,954 | yyx990803 | This is a known issue in `eslint-plugin-vue`: https://github.com/vuejs/eslint-plugin-vue/issues/1279
Will require a new release of it for this to be fixed. For now, you can disable the related rules in your eslint config. | 2020-08-24T21:57:13 | 2020-08-24T21:57:27 | {} | MEMBER |
vuejs | core | 680,960,582 | 1,850 | yyx990803 | If you want to have transition then the component being transitioned must have a single root. Transition multiple root nodes can lead to very complex edge cases and it's simply not worth it. | 2020-08-26T15:42:57 | 2020-08-26T15:43:55 | {} | MEMBER |
vuejs | core | 682,114,404 | 1,993 | cool-little-fish | I was a little confused about isEmitListener method...... | 2020-08-27T18:22:42 | 2020-08-27T18:22:42 | {} | CONTRIBUTOR |
vuejs | core | 682,373,251 | 1,997 | HcySunYang | Use `createCommentVNode()` instead. | 2020-08-28T07:25:02 | 2020-08-28T07:25:02 | {} | MEMBER |
vuejs | core | 683,214,916 | 1,995 | Fuzzyma | @yyx990803 seems reasonable. One quick follow up tho: Is teleport only supposed to port content to an element which is NOT controlled by Vue? Whenever my teleport target is in the app itself, it is not working. Is this a bug or a feature limitation? | 2020-08-29T01:37:17 | 2020-08-29T01:37:17 | {} | NONE |
vuejs | core | 679,482,401 | 1,937 | unbyte | > Why not just compare the 2 values? The less involved the better performance.
some biased performance tests misled me. it's my fault. 😭 | 2020-08-25T03:02:24 | 2020-08-25T03:02:24 | {} | CONTRIBUTOR |
vuejs | core | 680,291,396 | 1,961 | amerikan | @posva ah ok, updated. | 2020-08-25T22:01:53 | 2020-08-25T22:01:53 | {} | CONTRIBUTOR |
vuejs | core | 681,166,061 | 1,962 | CyberAP | I've managed to do parsing only once by passing AST directly to `analyzeScriptBindings`.
Is this ok? Should `analyzeScriptBindings` be exported in that case? | 2020-08-26T22:59:02 | 2020-08-26T22:59:02 | {} | CONTRIBUTOR |
vuejs | core | 682,147,097 | 1,989 | skirtles-code | I believe this is because `onUpdate:modelValue` is in the `$attrs` so it's automatically being added to the root element of the child.
Explicitly adding `emits: ['update:modelValue'],` will remove the event from the `$attrs`, fixing the problem. It's not entirely intuitive though as the original code would work fine... | 2020-08-27T19:29:20 | 2020-08-27T19:29:20 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 679,449,944 | 1,956 | yyx990803 | Thanks - I happened to be working on the same thing 😂 See c15311cf | 2020-08-25T01:31:47 | 2020-08-25T01:31:47 | {} | MEMBER |
vuejs | core | 680,748,428 | 1,970 | HcySunYang | The [whatwg#structuredserializeinternal](https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializeinternal) specification says:
> if [IsCallable(value)](https://tc39.es/ecma262/#sec-iscallable) is true, then throw a "DataCloneError" DOMException.
The Proxy Object contains [`[[call]]`](https... | 2020-08-26T08:49:33 | 2020-08-26T08:49:33 | {
"+1": 2
} | MEMBER |
vuejs | core | 681,047,289 | 1,977 | jacekkarczmarczyk | https://github.com/vuejs/eslint-plugin-vue/issues/1279 | 2020-08-26T18:25:13 | 2020-08-26T18:25:13 | {} | CONTRIBUTOR |
vuejs | core | 678,786,692 | 1,935 | Zohenn | @unbyte I'm currently using `pattern`, however the behaviour is somewhat different. With `minlength="5"` you can easily differentiate which constraint is not satisfied - `el.validity` will have `tooShort` property set to `true`. With `pattern=".{5,}"` it will always be `patternMismatch`. That's about the only differenc... | 2020-08-23T15:17:55 | 2020-08-23T15:17:55 | {
"heart": 1
} | NONE |
vuejs | core | 680,238,674 | 1,960 | yyx990803 | This is an interesting approach! However:
1. Vue 3 intends to support IE11 only.
2. The Proxy polyfill creates a lot of indirect-ness, and patching the current `@vue/reactivity` creates a ton of complexity, since the patch package cannot really modify `@vue/reactivity` but `@vue/reactivity` will inevitably need t... | 2020-08-25T19:57:35 | 2020-08-25T19:57:35 | {} | MEMBER |
vuejs | core | 680,796,298 | 1,970 | yagebu | > Create a copy instead
Since the structured clone algorithm is a standardised algorithm to copy Javascript objects, which is more powerful than `JSON.parse(JSON.stringify(...))`, I don't quite understand how I would simply "create a copy" (with more complex objects like a Map).
Again, my usecase isn't really His... | 2020-08-26T10:26:54 | 2020-08-26T10:26:54 | {} | NONE |
vuejs | core | 682,641,508 | 2,000 | victortwc | Clear, thank you :) | 2020-08-28T14:43:02 | 2020-08-28T14:43:02 | {} | NONE |
vuejs | core | 683,067,568 | 2,003 | DanielAsher | [done](https://github.com/vuejs/docs-next/issues/437)
thanks for the awesome work! | 2020-08-28T18:40:41 | 2020-08-28T18:40:41 | {} | NONE |
vuejs | core | 683,158,135 | 2,005 | pikax | Generics and `ref`, you need to cast to T
Check https://github.com/vuejs/vue-next/pull/1129
And https://github.com/microsoft/TypeScript/issues/33942
Also Vue 3 docs https://v3.vuejs.org/guide/typescript-support.html#typing-refs | 2020-08-28T21:38:53 | 2020-08-28T21:38:53 | {
"+1": 2,
"heart": 1
} | MEMBER |
vuejs | core | 683,251,015 | 2,005 | noook | Ohhh that helped a lot. Thank you very much. | 2020-08-29T07:33:34 | 2020-08-29T07:33:34 | {} | NONE |
vuejs | core | 679,019,263 | 1,916 | Picknight | Root cause speculation:
`JSON.stringify()` needs to get key-array first, and then get the value. It will trigger the call of `Reflect.ownKeys()`. The return of `ownKeys` will not be directly used as the key-array, `Enumerable` of the attribute will be verified here. But this verification does not seem to be performe... | 2020-08-24T09:33:48 | 2020-08-24T09:36:49 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.