owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 707,352,435 | 2,369 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 39.95 KB (0%) |
| runtime-dom.global.prod.js | 26.28 KB (0%) |
| size-check.global.prod.js | 15.8 KB (0%) | | 2020-10-12T21:22:57 | 2020-10-13T21:22:34 | {} | NONE |
vuejs | core | 708,126,899 | 2,375 | edison1105 | ```javascript
import { ref, reactive, defineComponent } from 'vue'
class CounterStore {
count = ref(1)
add = () => {
this.count.value++
}
}
const store = reactive(new CounterStore())
export default defineComponent({
setup () {
return () => <button onClick={store.add}>{store.count}</button... | 2020-10-14T03:06:47 | 2020-10-14T05:37:56 | {} | MEMBER |
vuejs | core | 708,930,999 | 2,382 | LinusBorg | We can't do anything with this report as there is no information about your setup or, as is required, a runnable reproduction.
Please provide those or the issue will be closed as it's not actionable. | 2020-10-15T06:32:21 | 2020-10-15T06:32:21 | {} | MEMBER |
vuejs | core | 709,922,786 | 2,390 | posva | @soletan transferred to the correct repository.
You can add this with `app.config.globalProperties`: https://v3.vuejs.org/api/application-config.html#globalproperties
| 2020-10-16T09:02:36 | 2020-10-16T09:02:36 | {} | MEMBER |
vuejs | core | 710,015,692 | 629 | seanlandsman | @swapagarwal this part:
`data: () => ({params}),`
makes ```params``` available to the created component (via ```this.params```).
So just provide what you need via the ```data``` function
| 2020-10-16T12:29:36 | 2020-10-16T12:29:36 | {} | NONE |
vuejs | core | 710,081,725 | 2,389 | basvanmeurs | One question @yyx990803
In the final commit, I clear the cached value upon cleanup.
Personally, I think that it should also be cleared immediately after setting the dirty flag in the scheduler. It will never be used anyway and will use memory until the computed is read again. | 2020-10-16T14:28:50 | 2020-10-16T14:28:50 | {} | CONTRIBUTOR |
vuejs | core | 711,078,739 | 1,706 | bekliev | @skirtles-code great breakdown! | 2020-10-17T20:50:31 | 2020-10-17T20:50:31 | {} | NONE |
vuejs | core | 707,029,283 | 2,361 | posva | This is expected, the getter keeps returning undefined since there is no v-model and the prop is never modified | 2020-10-12T10:18:24 | 2020-10-12T10:19:07 | {} | MEMBER |
vuejs | core | 707,167,578 | 2,364 | unbyte | > with vue@2, no any problem with FF 48a2
> But with vue@3, I don't understand why.
sorry but I refer to this only for reference and to indicate that const itself is supported in Firefox 48
> Any bug in here?
> ```js
> if(s)for(const e in s)t[e]=s[e]
> ```
is this fragment at ` line 296:19`? but const in f... | 2020-10-12T14:50:35 | 2020-10-12T14:50:57 | {} | CONTRIBUTOR |
vuejs | core | 707,845,660 | 2,368 | yyx990803 | 👍 | 2020-10-13T16:05:17 | 2020-10-13T16:05:17 | {} | MEMBER |
vuejs | core | 708,425,710 | 2,345 | basvanmeurs | Moving back to draft as I have some additional optimizations | 2020-10-14T14:04:41 | 2020-10-14T14:04:41 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 708,577,268 | 2,380 | mannok | > Edit: Oh I see you came to the same conclusion ... 😊
>
> That's because `strict: true` walks the entire state tree order to enforce warn if the state as mutated outside of a mutation.
>
> My first instinct is to rate this s bug: `deep: true` should _not_ traverse objects marked as raw, I'd rate this a bug.
> ... | 2020-10-14T18:19:18 | 2020-10-14T18:22:10 | {} | NONE |
vuejs | core | 708,955,556 | 2,195 | antfu | @knightly-bot build this | 2020-10-15T07:24:03 | 2020-10-15T07:24:03 | {} | MEMBER |
vuejs | core | 709,860,132 | 2,097 | skirtles-code | I did some experimenting using the idea @yyx990803 suggested. Here is a crude demo:
[https://jsfiddle.net/skirtle/94sfdLvm/](https://jsfiddle.net/skirtle/94sfdLvm/)
I changed the API slightly:
```js
// To add
const vm = app.render(Component, props, el)
// To remove
app.unrender(vm)
```
The reasoning ... | 2020-10-16T06:58:19 | 2020-10-16T06:58:19 | {
"+1": 1,
"heart": 2
} | CONTRIBUTOR |
vuejs | core | 711,066,729 | 2,405 | vue-bot | Hello, thank you for taking time filling this issue!
However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic... | 2020-10-17T19:11:31 | 2020-10-17T19:11:31 | {} | CONTRIBUTOR |
vuejs | core | 711,085,138 | 2,408 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 39.97 KB (0%) |
| runtime-dom.global.prod.js | 26.3 KB (0%) |
| size-check.global.prod.js | 15.8 KB (0%) | | 2020-10-17T21:56:07 | 2020-10-17T21:56:07 | {} | NONE |
vuejs | core | 703,069,354 | 2,281 | smilingkite | For anybody else running into this, apparently this is not a bug, but a legacy feature, but there IS a difference between how the options api and the composition api handle non-reactive properties.
I worked out the differences here: https://www.hesselinkwebdesign.nl/2020/reactivity-and-non-reactivity-introduction-f... | 2020-10-03T08:37:25 | 2020-10-18T07:49:56 | {} | NONE |
vuejs | core | 707,694,179 | 2,372 | SeregPie | Maybe some clear definitions are needed.
Here are my proposals.
```js
// nested object
let object = {a: {b: 1}};
console.log(isReactive(shallowReactive(object).a)); // should always be false
console.log(isReactive(reactive(object).a)); // should always be true
```
```js
// ref in object
let object = {a:... | 2020-10-13T12:06:55 | 2020-10-13T12:06:55 | {} | NONE |
vuejs | core | 707,966,007 | 2,184 | yyx990803 | This type of direct manipulation of a child ref is discouraged. I also don't see why you can't just pass the click handler via the template. | 2020-10-13T19:41:25 | 2020-10-13T19:41:25 | {} | MEMBER |
vuejs | core | 707,988,778 | 2,354 | yyx990803 | Great job hunting this down! | 2020-10-13T20:25:24 | 2020-10-13T20:25:24 | {
"hooray": 2
} | MEMBER |
vuejs | core | 708,030,323 | 2,369 | posva | Should be good! | 2020-10-13T21:54:26 | 2020-10-13T21:54:26 | {} | MEMBER |
vuejs | core | 708,474,129 | 2,244 | FossPrime | @posva I had the same issue with this config on Ubuntu.. I just made a new project with the latest vue-cli... it's quite broken :/
I simply ran `npm run test:unit` to get the catastrophic failure error
please reopen
```
{
"useTaobaoRegistry": false,
"presets": {
"foss": {
"useConfigFiles": f... | 2020-10-14T15:20:17 | 2020-10-14T15:22:56 | {
"+1": 1
} | NONE |
vuejs | core | 708,550,137 | 2,380 | LinusBorg | Edit: Oh I see you came to the same conclusion ... 😊
That's because `strict: true` walks the entire state tree order to enforce warn if the state as mutated outside of a mutation.
My first instinct is to rate this s bug: `deep: true` should *not* traverse objects marked as raw, I'd rate this a bug.
But think... | 2020-10-14T17:30:53 | 2020-10-14T17:42:11 | {
"+1": 1
} | MEMBER |
vuejs | core | 708,994,609 | 2,353 | unbyte | @posva https://jsben.ch/wP8Q4
it wouldn't make a significant impact on performance according to this benchmark ( see `loop`, it's very close to the original performance). after all, this change only affects how to initialize props. | 2020-10-15T08:37:57 | 2020-10-15T08:40:11 | {} | CONTRIBUTOR |
vuejs | core | 709,023,372 | 2,353 | unbyte | well there may be some misunderstanding. plz allow me to explain
this pr is mainly to solve the problem of `:value`, not vModel.
> https://github.com/vuejs/vue-next/commit/54ed7592e416fc411196e9b767aebcc4f2ca20d8 ignored that :value also can cause #2325 , which is due to the order when initializing an element's attri... | 2020-10-15T09:10:57 | 2020-10-15T09:10:57 | {
"+1": 1,
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 709,419,762 | 2,240 | dependabot-preview[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.
If you change your mind, just re-... | 2020-10-15T15:52:45 | 2020-10-15T15:52:45 | {} | CONTRIBUTOR |
vuejs | core | 709,550,151 | 2,381 | tim-janik | > watch effects created with `$watch` are cleaned up up on unmount automatically so I don't see the need to do that manually.
> Try leaving that call out.
Are you serious?
How is the *caller* of unwatch supposed to know if instance.effects has been reset when it has to ensure that the watch callback must not be ca... | 2020-10-15T19:42:54 | 2020-10-15T19:42:54 | {} | NONE |
vuejs | core | 709,959,108 | 2,392 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 39.95 KB (0%) |
| runtime-dom.global.prod.js | 26.28 KB (0%) |
| size-check.global.prod.js | 15.8 KB (0%) | | 2020-10-16T10:17:36 | 2020-10-16T10:17:36 | {} | NONE |
vuejs | core | 710,096,762 | 2,398 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 39.95 KB (0%) |
| runtime-dom.global.prod.js | 26.28 KB (0%) |
| size-check.global.prod.js | 15.8 KB (0%) | | 2020-10-16T14:55:57 | 2020-10-16T14:55:57 | {} | NONE |
vuejs | core | 710,103,539 | 2,390 | LinusBorg | I'd rather not give the impression that it's a good idea to i.e. do `app.component('X', X )` somewhere down the tree by actively exposing the app instance in every component.
For most intents and purposes, it will and should only be accessed before mounting.
For edge cases like yours, i feel like `app.config.glob... | 2020-10-16T15:07:26 | 2020-10-16T15:08:09 | {
"+1": 2
} | MEMBER |
vuejs | core | 711,135,091 | 2,414 | jacekkarczmarczyk | it's in markup
there should be commit that makes `<template>` without any directives to render as dom template, can't find it though | 2020-10-18T08:31:50 | 2020-10-18T08:31:50 | {} | CONTRIBUTOR |
vuejs | core | 707,188,370 | 2,345 | basvanmeurs | I think we need to keep track of the performance of the vue core, especially the reactivity part. To verify my own work, as well as testing for future development, I created this little repository: https://github.com/basvanmeurs/vue-next-benchmarks
You can run some reactivity benchmarks live here: https://basvanmeur... | 2020-10-12T15:26:55 | 2020-10-13T10:43:08 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 708,042,162 | 2,345 | dsonet | It would be very great to implement #2195 after this. | 2020-10-13T22:24:08 | 2020-10-13T22:24:08 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 708,999,299 | 2,353 | posva | I was only talking about setting `min`, `max` and similar attributes on the vModel directive code (which is dom specific) before setting the `value`. All directly in `created` and removing the code of `mounted`
I don't really understand what you want to say with the jsbench 😅 | 2020-10-15T08:46:43 | 2020-10-15T08:46:43 | {} | MEMBER |
vuejs | core | 709,982,765 | 2,388 | LinusBorg | The compiler doesn't actually account for a dynamic non-null value, but I think we still support this, so it's rather a bug.
```js
_createVNode("button", {
["on" + _capitalize($options.ev)]: _cache[2] || (_cache[2] = (...args) => ($options.handleClick(...args)))
```
The compiler should skip adding that prop ... | 2020-10-16T11:12:17 | 2020-10-16T11:12:17 | {} | MEMBER |
vuejs | core | 707,115,733 | 2,364 | kleinfreund | Slightly related: I can’t seem to find any statement with regards to browser support/compatibility in the Vue.js 3 documentation. Without it, how can I know whether Firefox 48 is supposed to be supported? | 2020-10-12T13:19:45 | 2020-10-12T13:19:45 | {} | CONTRIBUTOR |
vuejs | core | 707,978,230 | 2,212 | yyx990803 | The code was there when `map.forEach` dep wasn't triggered by SET mutations, but now they are, so this can indeed be simplified. | 2020-10-13T20:06:28 | 2020-10-13T20:06:28 | {} | MEMBER |
vuejs | core | 709,930,989 | 2,390 | soletan | We've found this opportunity for now as well. Thought it might be easier to expose it more generically. However, we are fine with sticking with globalProperties, too. | 2020-10-16T09:18:10 | 2020-10-16T09:18:10 | {} | NONE |
vuejs | core | 709,959,875 | 2,369 | posva | Done at https://github.com/vuejs/vue-next/pull/2392 | 2020-10-16T10:19:21 | 2020-10-16T10:19:21 | {} | MEMBER |
vuejs | core | 660,583,206 | 1,782 | andrewspy | FYI, I have updated to vue (v3.0.0-rc.1) and vue-router (v4.0.0-beta.2), and the problem still persist. Is the problem limited to Vite or does it affect all Vue3 in general? | 2020-07-19T04:07:17 | 2020-07-19T04:07:17 | {} | NONE |
vuejs | core | 660,680,928 | 1,641 | yyx990803 | You don't. Exposing imperative methods on the component instance is not recommended. Use a prop to let other component control it. | 2020-07-19T17:35:47 | 2020-07-19T17:35:47 | {} | MEMBER |
vuejs | core | 660,684,346 | 1,630 | yyx990803 | Hmm, just curious, what's your use case for putting `render` in a mixin? | 2020-07-19T18:03:10 | 2020-07-19T18:03:10 | {} | MEMBER |
vuejs | core | 660,833,426 | 1,648 | lexSeven | > One of the major concerns in web technology is backward compatibility. I don't think it's good to break that, no mention `width` and `height` are only deprecated for some elements, not for things like `<img>`. On the contrary, they are very crucial to user experience, which prevents layout shifts during resource load... | 2020-07-20T06:35:26 | 2020-07-20T06:35:26 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 660,889,421 | 1,645 | baryla | @icehaunter thanks for the link buddy. Yeah I read that part which is fair enough but I thought that maybe we can remove that extra indentation that we have with `setup` and potentially have functional components be stateful - _**kind of**_ like what we see with React and it's functional components and hooks. No big de... | 2020-07-20T08:39:27 | 2020-07-20T08:39:27 | {} | NONE |
vuejs | core | 659,598,387 | 1,598 | AlexandreBonaventure | @CyberAP I don't really get your point..
The goal is to use the composition API here. | 2020-07-16T18:42:42 | 2020-07-16T18:42:42 | {} | CONTRIBUTOR |
vuejs | core | 660,651,967 | 1,636 | tangjinzhou | ref #1521 | 2020-07-19T14:24:42 | 2020-07-19T14:24:42 | {} | CONTRIBUTOR |
vuejs | core | 661,046,865 | 1,657 | lmiller1990 | Some context: we intercept `$emit` and add some middleware to track what events are emitted using a mixin on the `beforeCreated` lifecycle; [see here](https://github.com/vuejs/vue-test-utils-next/blob/master/src/emitMixin.ts). The problem is functional components do not call the lifecycle hooks, so we never get a chanc... | 2020-07-20T13:41:23 | 2020-07-20T13:41:23 | {} | MEMBER |
vuejs | core | 660,689,685 | 1,600 | CyberAP | I've actually been struggling with whitespace issues as well. It's not expected that mustache syntax preserves whitespace, while elements do not when passed to a slot.
```html
<SlottedComponent>
{{ 'this will preserve whitespace (including spaces and newline after component tag)' }}
</SlottedComponent>
```
... | 2020-07-19T18:46:03 | 2020-07-19T18:46:03 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 660,836,335 | 1,648 | Justineo | There are still apps built with Vue 2 and intend to migrate to Vue 3. This will make the process even harder. | 2020-07-20T06:43:11 | 2020-07-20T06:43:11 | {} | MEMBER |
vuejs | core | 660,850,582 | 1,648 | motao314 | Tags such as canvas still need to use the width and height attributes, but for example, bgcolor, we should discard them | 2020-07-20T07:18:32 | 2020-07-20T07:18:32 | {} | CONTRIBUTOR |
vuejs | core | 660,860,689 | 1,648 | lexSeven | > Tags such as canvas still need to use the width and height attributes, but for example, bgcolor, we should discard them
Agree, we keep the width and height | 2020-07-20T07:41:26 | 2020-07-20T07:41:26 | {} | CONTRIBUTOR |
vuejs | core | 660,902,578 | 1,627 | shengxinjing | duplicate #1613 | 2020-07-20T09:05:14 | 2020-07-20T09:05:14 | {} | CONTRIBUTOR |
vuejs | core | 661,229,625 | 1,659 | yyx990803 | Have you tested object creation with symbols as computed keys? I think that was what caused us to move away from symbols. | 2020-07-20T17:39:04 | 2020-07-20T17:39:15 | {} | MEMBER |
vuejs | core | 661,606,777 | 1,648 | haoqunjiang | > Put aside the problem itself.
But I mean it in the exact context of this PR.
It's one thing to deprecate obsolete features, it's another thing to intentionally degrade performance for those who use such features. | 2020-07-21T03:23:32 | 2020-07-21T03:23:55 | {} | MEMBER |
vuejs | core | 661,636,144 | 1,648 | haoqunjiang | > but I don't think it has anything to do with performance
The list is introduced as a hint for render fast path. It **is** all for performance. PLEASE READ THE CODE. | 2020-07-21T05:07:49 | 2020-07-21T05:07:49 | {} | MEMBER |
vuejs | core | 659,508,393 | 1,600 | Justineo | https://github.com/vuejs/vue/issues/9208#issuecomment-450012518
`condense` mode is “not entirely removing leading/ending whitespaces inside an element”. It seems it’s the only difference.
| 2020-07-16T16:00:57 | 2020-07-16T16:01:14 | {} | MEMBER |
vuejs | core | 659,902,107 | 1,609 | posva | Your code works fine on Safari: value1, value2, comp1 and comp2 are properly displayed | 2020-07-17T06:51:31 | 2020-07-17T06:51:31 | {} | MEMBER |
vuejs | core | 660,245,090 | 1,600 | ZhangJian-3ti | The ignored white space doesn't affect the output for browser at all. It's kinda like an optimization without any side effects. | 2020-07-17T17:34:47 | 2020-07-17T17:34:47 | {} | CONTRIBUTOR |
vuejs | core | 660,684,645 | 1,609 | aswathamaramakrishnan | @posva could you please check .. in safari its still not coming
This is chrome
This is safari
 in module scope raises the counter, since the function of the FC is invoked whenever the ref updates.
So this doesn't work:
```tsx
function useCounter() {
const counter = ref(0);
function increment() {
counter.v... | 2020-07-20T15:18:32 | 2020-07-20T15:20:52 | {} | CONTRIBUTOR |
vuejs | core | 661,633,842 | 1,648 | haoqunjiang | Do you really understand what exactly this PR does?? | 2020-07-21T04:59:19 | 2020-07-21T04:59:19 | {} | MEMBER |
vuejs | core | 659,819,204 | 1,597 | motao314 | Combined functions | 2020-07-17T03:28:29 | 2020-07-17T03:28:29 | {} | CONTRIBUTOR |
vuejs | core | 660,473,824 | 1,620 | icehaunter | I tried recording a reproduction video. Here I repeatedly add and remove symbols from the line, saving the file each time, as you can tell from "reload" lines. I do not know whether the fact that component goes missing multiple times in the browser is the same bug or an error with Vite.
![test](https://user-images.g... | 2020-07-18T12:09:59 | 2020-07-18T12:09:59 | {} | NONE |
vuejs | core | 660,573,570 | 1,619 | yyx990803 | If the type you got is a return type from `defineComponent`, it is a constructor so you should be able to get its props type as `InstanceType<TComponent>['$props']`. This is also what TSX uses to infer props. | 2020-07-19T02:13:43 | 2020-07-19T02:14:01 | {} | MEMBER |
vuejs | core | 660,574,080 | 1,626 | yyx990803 | Most likely caused by https://github.com/vuejs/vue-next/commit/5f61aa0f719cbd90182af1e27fad37b91c2c351e
What you can do now: specify
```js
vueCompilerOptioons: {
hoistStatic: process.env.NODE_ENV === 'production'
}
```
in your vite config. | 2020-07-19T02:19:55 | 2020-07-19T02:21:21 | {} | MEMBER |
vuejs | core | 660,576,843 | 1,624 | yyx990803 | I just realized this is actually not the follow up PR for #1597 - sorry I had to revert this one since #1597 was submitted first. | 2020-07-19T02:53:33 | 2020-07-19T02:53:33 | {} | MEMBER |
vuejs | core | 660,948,713 | 1,627 | Justineo | Actually this one isn't duplicated...it's for types. | 2020-07-20T10:37:50 | 2020-07-20T10:37:50 | {
"+1": 1
} | MEMBER |
vuejs | core | 661,245,464 | 1,660 | callumacrae | Duplicate - my first search didn't find this issue! https://github.com/vuejs/vue-next/issues/1387#issuecomment-647119510 | 2020-07-20T18:02:01 | 2020-07-20T18:02:01 | {} | NONE |
vuejs | core | 659,439,841 | 1,597 | yyx990803 | We can probably extract a shared function to reduce the repetition here. | 2020-07-16T14:13:09 | 2020-07-16T14:13:09 | {} | MEMBER |
vuejs | core | 659,526,939 | 1,278 | yyx990803 | I figured out the weird testing issues - Jest is running in jsdom env by default and that makes `sass` to think it's running in the browser and using a different set of path resolution logic. | 2020-07-16T16:31:54 | 2020-07-16T16:31:54 | {
"+1": 1
} | MEMBER |
vuejs | core | 660,178,995 | 1,614 | yyx990803 | 👍 | 2020-07-17T15:43:34 | 2020-07-17T15:43:34 | {} | MEMBER |
vuejs | core | 660,475,304 | 1,621 | zhangzhonghe | see [https://github.com/zhangzhonghe/vue-keep-alive-bug](url) | 2020-07-18T12:22:43 | 2020-07-18T12:22:43 | {} | MEMBER |
vuejs | core | 660,476,530 | 1,620 | icehaunter | I made a better reproduction demonstration, where editing `<script setup>` block causes many more errors and they appear much quicker. Am just adding/removing whitespace here.
| 2020-07-18T12:33:05 | 2020-07-18T12:33:26 | {} | NONE |
vuejs | core | 660,690,952 | 1,643 | CyberAP | Possibly related to recent model event listeners fallthrough fix: https://github.com/vuejs/vue-next/commit/903e8f697e4377e0ae92e1a6b58777438fba3610
Right now you can fix that by adding `emits: ['update:modelValue']` to both of your components. | 2020-07-19T18:55:38 | 2020-07-19T18:55:38 | {} | CONTRIBUTOR |
vuejs | core | 660,839,220 | 1,648 | motao314 | As an excellent new version framework, vue3 should play a leading role | 2020-07-20T06:50:53 | 2020-07-20T06:50:53 | {} | CONTRIBUTOR |
vuejs | core | 661,111,819 | 1,645 | AjaiKN | If you don't care about having the `name` field, I think `defineComponent` already wraps a function into `setup` if you pass it a function directly: <https://github.com/vuejs/vue-next/blob/d39c03771b7ae2eb6026c3463a5c0972767780ff/packages/runtime-core/src/apiDefineComponent.ts#L207-L209>
So it seems like you could d... | 2020-07-20T15:30:27 | 2020-07-20T15:35:12 | {
"+1": 3
} | CONTRIBUTOR |
vuejs | core | 659,948,881 | 1,610 | dependabot-preview[bot] | One of your CI runs failed on this pull request, so Dependabot won't merge it.
- [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/7136?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Dependabot will still automatically merge this pull request if you amend it and your test... | 2020-07-17T08:12:00 | 2020-07-17T08:12:00 | {} | CONTRIBUTOR |
vuejs | core | 660,634,694 | 1,629 | underfin | See https://github.com/vuejs/vue-next/issues/992#issuecomment-616126089 | 2020-07-19T12:14:31 | 2020-07-19T12:14:31 | {} | MEMBER |
vuejs | core | 660,645,545 | 1,632 | HcySunYang | Can you give a valid reproduction link? | 2020-07-19T13:43:03 | 2020-07-19T13:43:03 | {} | MEMBER |
vuejs | core | 660,870,216 | 1,630 | yusufkandemir | I was migrating a library not an app btw, I guess it can made some difference in context.
We have a field component that has basic functionality, different design options, validation mechanics, etc. This component obviously has `render` function because it can be used standalone, and is extensible through either by ... | 2020-07-20T08:02:08 | 2020-07-20T08:02:08 | {} | NONE |
vuejs | core | 660,965,291 | 1,643 | ByScripts | Thank for the workaround.
`emits: ['update:modelValue']` makes the component working as expected :) | 2020-07-20T11:17:16 | 2020-07-20T11:17:16 | {} | NONE |
vuejs | core | 661,190,658 | 1,659 | LongTengDao | Here is a test, I saw they are almost same (900M ops/sec in Chrome, 3 set and 3 get for each op):
- result for Chrome (in Chinese): <https://www.zhihu.com/question/342518045/answer/802165687>
- test: <https://jsperf.com/dom-plain-string-symbol-weakmap-attribute-dataset/3>
@yyx990803 | 2020-07-20T17:00:09 | 2020-07-20T18:12:00 | {} | CONTRIBUTOR |
vuejs | core | 661,250,863 | 1,659 | LongTengDao | > Have you tested object creation with symbols as computed keys? I think that was what caused us to move away from symbols.
I'm not sure what "object creation with symbols as computed keys" means, so I write a new test, just remain the cases meaningful to Vue:
Mark the test here: <https://jsperf.com/stringkey-vs-... | 2020-07-20T18:12:39 | 2020-07-20T18:52:47 | {} | CONTRIBUTOR |
vuejs | core | 659,453,144 | 1,601 | yyx990803 | Thanks but this doesn't seem necessary. | 2020-07-16T14:34:19 | 2020-07-16T14:34:19 | {} | MEMBER |
vuejs | core | 660,573,895 | 1,617 | yyx990803 | The example was actually trying to reproduce exact the same logic, mostly to serve as an e2e test for backwards behavior compatibility. You should still avoid doing this in actual code. We should probably update the example to remove that usage though. | 2020-07-19T02:17:31 | 2020-07-19T02:17:31 | {
"+1": 1
} | MEMBER |
vuejs | core | 660,679,350 | 1,628 | yyx990803 | see 4655d699 | 2020-07-19T17:23:43 | 2020-07-19T17:23:43 | {} | MEMBER |
vuejs | core | 660,680,431 | 1,638 | yyx990803 | This is not a typo... kept as in past tense. | 2020-07-19T17:32:13 | 2020-07-19T17:32:13 | {} | MEMBER |
vuejs | core | 660,681,151 | 1,642 | yyx990803 | This is related to the root app mounting behavior change when using in-DOM templates: the "container" is no longer part of the template, so vue template syntax on it are ignored. | 2020-07-19T17:37:27 | 2020-07-19T17:37:27 | {} | MEMBER |
vuejs | core | 660,714,614 | 1,598 | pikax | getCurrentInstance is advanced api and you should be really careful using it, in this case I believe is fair to use it.
There's my implementation of the vmodel composable https://github.com/pikax/vue-composable/blob/master/packages/vue-composable/src/misc/vmodel.ts
| 2020-07-19T21:47:07 | 2020-07-19T21:47:07 | {
"+1": 3
} | MEMBER |
vuejs | core | 660,717,721 | 1,645 | baryla | @CyberAP Yeah that totally makes sense. Just makes me curious whether there would be any major performance impacts in having functional components be stateful. | 2020-07-19T22:15:30 | 2020-07-19T22:15:30 | {} | NONE |
vuejs | core | 661,178,503 | 1,657 | yyx990803 | What if you just wrap the functional component?
``` js
const wrapped = (props, ctx) => {
// intercept ctx.emit... or clone the ctx
return ActualComp(props, ctx)
}
``` | 2020-07-20T16:49:01 | 2020-07-20T16:49:01 | {} | MEMBER |
vuejs | core | 659,594,583 | 1,598 | CyberAP | You can have the same thing in options API without the need for extra hooks just by using a factory function:
```js
export const createPropModel = (propName) => ({
get () { return this[propName] },
set (value) { this.$emit(`update:${propName}`, value) }
})
``` | 2020-07-16T18:34:57 | 2020-07-16T18:34:57 | {} | CONTRIBUTOR |
vuejs | core | 659,612,791 | 1,599 | basvanmeurs | Thanks for the suggestion, I didn't realise that they were handled differently than watchEffects in terms of scheduling.
I will try to convert my code and see if that works. | 2020-07-16T19:09:50 | 2020-07-16T19:09:50 | {} | CONTRIBUTOR |
vuejs | core | 659,904,068 | 1,607 | posva | Thanks but it's still worth having in the list as it could collide in Firefox | 2020-07-17T06:54:39 | 2020-07-17T06:54:39 | {} | MEMBER |
vuejs | core | 661,108,130 | 1,645 | bjarkihall | Shouldn't this at least be caught by eslint and be documented to avoid confusion? | 2020-07-20T15:24:24 | 2020-07-20T15:24:24 | {} | CONTRIBUTOR |
vuejs | core | 661,242,507 | 1,609 | aswathamaramakrishnan | @posva
Safari - 12.1
| 2020-07-20T17:56:03 | 2020-07-20T17:56:56 | {} | NONE |
vuejs | core | 661,627,657 | 1,648 | lexSeven | > > Put aside the problem itself.
>
> But I mean it in the exact context of this PR.
>
> It's one thing to deprecate obsolete features, it's another thing to intentionally degrade performance for those who use such features.
It's true that some properties may be used, such as width and height, but I don't thin... | 2020-07-21T04:35:00 | 2020-07-21T04:35:00 | {} | CONTRIBUTOR |
vuejs | core | 659,602,279 | 1,598 | CyberAP | Composition API is not an ideal candidate for this task it seems to me. `getCurrentInstance` is an advanced API for plugins and I think it's not a best suit to automate computed model creation. Instead I'd suggest to take a look at [this RFC](https://github.com/vuejs/rfcs/pull/140) which aims to simplify the exact sam... | 2020-07-16T18:50:13 | 2020-07-16T18:50:13 | {
"+1": 1,
"eyes": 1
} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.