owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 742,182,464 | 2,783 | Zcating | The `<teleport>` will render `<!--teleport start-->` & `<!--teleport end-->` in dom to mark which doms need to teleport.
As I see, The root element is containing a `<teleport>`, so `this.$el` must be the `<teleport>` rendered product. | 2020-12-10T01:56:25 | 2020-12-10T02:03:09 | {} | CONTRIBUTOR |
vuejs | core | 743,734,492 | 2,801 | edison1105 | Ok,I got the point. | 2020-12-12T10:16:48 | 2020-12-12T10:16:48 | {} | MEMBER |
vuejs | core | 744,145,790 | 2,810 | ht-sauce | > 请首先将问题报告给element-plus，或者提供不包含element-plus的最小复制量。
ok | 2020-12-14T03:40:47 | 2020-12-14T03:40:47 | {} | NONE |
vuejs | core | 741,600,268 | 2,776 | luwuer | 1. 你提供的 repo 没有复现问题的代码
2. 你最好提供英文描述的 issue (这样问题或许能更快被修复) | 2020-12-09T07:54:02 | 2020-12-09T07:54:02 | {} | CONTRIBUTOR |
vuejs | core | 741,866,256 | 2,782 | posva | This is unrelated to Vue. You should open the issue on the repository where they are including that package | 2020-12-09T15:56:54 | 2020-12-09T15:56:54 | {} | MEMBER |
vuejs | core | 742,201,935 | 2,783 | hyjiacan | > The `<teleport>` will render `<!--teleport start-->` & `<!--teleport end-->` in dom to mark which doms need to teleport.
> As I see, The root element is containing a `<teleport>`, so `this.$el` must be the `<teleport>` rendered product.
Is there any suggestion to get the `div#content` without `ref` ? | 2020-12-10T02:53:51 | 2020-12-10T02:53:51 | {} | NONE |
vuejs | core | 743,701,348 | 2,801 | edison1105 | @posva
setAttribute can avoid this problem.I don't know why we not use `setAttribute `here.
Is there any special reason?
| 2020-12-12T04:36:24 | 2020-12-12T04:36:24 | {} | MEMBER |
vuejs | core | 743,796,857 | 2,806 | posva | If you want to open a bug report please provide a boiled down repro of what you are trying to do but it looks like you were relying on internals.
It's not clear what you mean by _let Vue know it's been handled_ | 2020-12-12T18:30:21 | 2020-12-12T18:30:21 | {} | MEMBER |
vuejs | core | 744,108,330 | 2,809 | ycmjason | Make sense. Thanks you @Zcating.
I find it slightly hard to work with the typing when we have nested refs.
For example, this will cause the type go wrong
```ts
const useA = () => ({
a: ref(3),
});
const x = ref(useA());
x.value = useA(); // you can't do this coz x is not `Ref<{ a: number }>`
```
| 2020-12-14T01:10:59 | 2020-12-14T01:12:18 | {} | CONTRIBUTOR |
vuejs | core | 744,226,269 | 2,813 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2020-12-14T07:13:54 | 2020-12-14T07:13:54 | {} | NONE |
vuejs | core | 741,606,052 | 2,775 | littlesmilelove | > You should use arrow function while using validator or default attr. #2474
This answer is correct. | 2020-12-09T08:06:47 | 2020-12-09T08:06:47 | {} | NONE |
vuejs | core | 741,623,315 | 2,776 | posva | Read https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro
Please, open issues in English | 2020-12-09T08:40:58 | 2020-12-09T08:40:58 | {} | MEMBER |
vuejs | core | 741,721,090 | 2,564 | posva | Tried locally and this works correctly. @07akioni make sure to test locally next time! You can download a zip from codesandbox to make sure the correct versions are used, sometimes there are cache issues on CS | 2020-12-09T11:47:56 | 2020-12-09T11:47:56 | {} | MEMBER |
vuejs | core | 745,079,557 | 2,823 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2020-12-15T06:19:01 | 2020-12-15T06:19:01 | {} | NONE |
vuejs | core | 745,079,796 | 2,824 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2020-12-15T06:19:41 | 2020-12-15T06:19:41 | {} | NONE |
vuejs | core | 741,711,733 | 2,768 | posva | Thanks a lot @edison1105 ! | 2020-12-09T11:27:28 | 2020-12-09T11:27:28 | {} | MEMBER |
vuejs | core | 743,103,425 | 2,795 | posva | Read https://new-issue.vuejs.org/?repo=vuejs/vue#why-repro
I guess that as you said, we can track this at #1347 | 2020-12-11T10:09:53 | 2020-12-11T10:09:53 | {} | MEMBER |
vuejs | core | 743,140,230 | 2,790 | LinusBorg | I think I get it now. Thanks for explaining.
Reopening. | 2020-12-11T11:28:22 | 2020-12-11T11:30:50 | {} | MEMBER |
vuejs | core | 743,800,394 | 2,806 | MartinMalinda | "let Vue know it's been handled" means "don't report the unhandled promise rejection / error". Sorry if it wasn't clear.
For example:
"[Vue warn]: Unhandled error during execution of mounted hook ..."
I could open a bug report if it was a bug. But as you said, I did rely on internals and I'm looking for a way to... | 2020-12-12T18:58:48 | 2020-12-12T18:58:48 | {} | NONE |
vuejs | core | 743,988,505 | 2,730 | asv7c2 | ```When a user effect is queued, it is by default invoked before all component update effects```
With template refs you always must use flush post because refs assigned after rendering. | 2020-12-13T10:55:03 | 2020-12-13T11:05:11 | {} | NONE |
vuejs | core | 744,305,702 | 2,790 | luwuer | But if resuing when there has ref will lead to this issue, and the `refDom.value` will be changed nextTick. | 2020-12-14T09:26:06 | 2020-12-14T09:26:06 | {} | CONTRIBUTOR |
vuejs | core | 742,867,291 | 2,791 | LongTengDao | only `components` change could be expected work right in `beforeCreated`, not including dynamic `computed` `props` `inject`.
because they are pre defined in the prototype, not define for each instance. and only root instance (`new Vue` / `Vue.createApp`) won't do that, component in `compontents` or registered in `Vu... | 2020-12-10T23:31:19 | 2020-12-10T23:33:31 | {} | CONTRIBUTOR |
vuejs | core | 743,121,558 | 2,790 | LinusBorg | I can't follow.
The div will be re-used as it doesn't have a key. That's expected behavior (or did I miss an optization in Vue 3? Totally possible!).
Since it's being re-used, the logged element will first contain `'hello'`, but the component will immediately update due to the changed ref value to `true`, so it ... | 2020-12-11T10:46:45 | 2020-12-11T11:29:46 | {} | MEMBER |
vuejs | core | 743,776,619 | 2,805 | BrainEno | > Duplicate #2804
I see,I will close it | 2020-12-12T16:00:42 | 2020-12-12T16:00:42 | {} | NONE |
vuejs | core | 743,988,325 | 2,730 | skirtles-code | @asv1 I don't see anything in the docs to suggest that this is by design.
Triggering a `flush: 'pre'` watcher during rendering is an awkward case. There is some wiggle room for deciding what the 'correct' behaviour should be but I don't think it makes sense to leave unflushed items in the queue. | 2020-12-13T10:53:50 | 2020-12-13T10:53:50 | {} | CONTRIBUTOR |
vuejs | core | 744,303,358 | 2,790 | HcySunYang | Your solution is not correct. There is no problem in reusing nodes, because `pre-div(hello)` and `next-div(foo)` should be reusable, because their type(`div`) and key(`undefined`) are the same, which has nothing to do with `ref` dom. | 2020-12-14T09:22:22 | 2020-12-14T09:22:22 | {
"+1": 1
} | MEMBER |
vuejs | core | 741,622,793 | 2,771 | posva | You should check and open an issue on docs-next repository to document this | 2020-12-09T08:39:55 | 2020-12-09T08:39:55 | {} | MEMBER |
vuejs | core | 741,633,713 | 2,751 | signor-pedro | @sapphi-red - if you are right and we should be inferring `SetupContext<{"update:modelValue": () => true}>`, how can I then type-hint the `context` properly?
All I wanted to do in my coposable is
```
function myFn({ emit }: SetupContext) {
emit('sth', ...);
}
```
so that TypeScript (and in turn PHPStorm) in... | 2020-12-09T09:01:11 | 2020-12-09T09:02:55 | {} | NONE |
vuejs | core | 741,669,664 | 2,768 | edison1105 | I debugged this bug locally, but found it works. My local code is the latest master. so I think it's fixed by some commits.
see demo: https://codesandbox.io/s/nervous-raman-2776d?file=/index.html | 2020-12-09T10:06:46 | 2020-12-09T10:07:22 | {} | MEMBER |
vuejs | core | 742,534,400 | 2,790 | edison1105 | Very strange, I added a breakpoint and it worked.
| 2020-12-10T13:53:30 | 2020-12-10T13:53:30 | {} | MEMBER |
vuejs | core | 742,913,770 | 2,790 | skirtles-code | Is this because the `<div>` is being reused across renderings and the console logging shows the current content of that `<div>`, not the content it had when it was logged? The content of that `<div>` gets updated when it re-renders. You'd need to give it a `key` for the diffing to pair up the correct nodes.
Using `c... | 2020-12-11T01:55:31 | 2020-12-11T01:58:31 | {
"+1": 4
} | CONTRIBUTOR |
vuejs | core | 743,092,865 | 2,790 | LinusBorg | Yep. Would say this is expected behavior. | 2020-12-11T09:49:20 | 2020-12-11T09:49:20 | {} | MEMBER |
vuejs | core | 743,269,547 | 2,801 | posva | The width and height attributes should be in pixels: https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/width | 2020-12-11T15:44:56 | 2020-12-11T15:44:56 | {} | MEMBER |
vuejs | core | 741,624,690 | 2,770 | posva | dynamic imports work with urls, you can use that, but this is a user land feature.
| 2020-12-09T08:43:41 | 2020-12-09T08:43:41 | {} | MEMBER |
vuejs | core | 741,712,489 | 2,768 | edison1105 | @posva I think it is worth to add a test case make it not regress again.Although I haven't found the specific reason. | 2020-12-09T11:29:05 | 2020-12-09T11:29:05 | {} | MEMBER |
vuejs | core | 741,714,789 | 2,768 | edison1105 | > yeah, PR welcome for a non regression test!
OK, I will try it later. | 2020-12-09T11:33:58 | 2020-12-09T11:33:58 | {} | MEMBER |
vuejs | core | 742,271,145 | 2,787 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.51 KB (0%) |
| runtime-dom.global.prod.js | 26.83 KB (0%) |
| size-check.global.prod.js | 16.21 KB (0%) | | 2020-12-10T06:25:41 | 2020-12-10T06:25:41 | {} | NONE |
vuejs | core | 744,109,951 | 2,809 | Zcating | It is because the getter & setter must be the same type. If change `ref.value` to `ref.setValue & ref.getValue`, you can do this:
```
setValue(value: T);
getValue(): UnwarpRef<T>;
``` | 2020-12-14T01:17:42 | 2020-12-14T01:19:54 | {} | CONTRIBUTOR |
vuejs | core | 744,304,874 | 2,790 | qq397023775 | > Your solution is not correct. There is no problem in reusing nodes, because pre-div(hello) and next-div(foo) should be reusable, because their type(div) and key(undefined) are the same, which has nothing to do with ref dom.
yep, consensus. | 2020-12-14T09:24:42 | 2020-12-14T09:24:42 | {} | NONE |
vuejs | core | 809,861,624 | 3,507 | KunHwanAhn | interesting 🤔
at the following comment, only lowercase is allowed.
https://github.com/vuejs/vue-next/issues/1167#issuecomment-626968071
But, PR https://github.com/vuejs/vue-next/pull/3508 make `<Component>` allowed.. 🤔 | 2021-03-30T02:41:25 | 2021-03-30T02:41:25 | {} | NONE |
vuejs | core | 809,867,229 | 3,507 | KunHwanAhn | > That should be a misunderstanding, because Vue2 allows a capitalized version, so we should keep that behavior.
Ah, I understood, Vue3 allow `<Component>` case as well. | 2021-03-30T02:57:33 | 2021-03-30T02:57:33 | {} | NONE |
vuejs | core | 810,107,306 | 2,633 | skirtles-code | Just to clarify, adding the duplicate keys warning was just one, small part of this.
Primarily I was trying to get the types updated with a view to updating the docs. | 2021-03-30T10:26:41 | 2021-03-30T10:26:41 | {} | CONTRIBUTOR |
vuejs | core | 810,483,268 | 3,513 | cexbrayat | @HcySunYang I suspect we found a similar issue on VTU-next
This template `<transition><div></div></transition>` (note the lack of content in the div) throws:
```
Uncaught TypeError: children is null
filterSingleRoot https://sfc.vuejs.org/vue.runtime.esm-browser.js:2171
setScopeId https://sfc.vuejs.org/vu... | 2021-03-30T18:30:24 | 2021-03-30T18:30:24 | {} | MEMBER |
vuejs | core | 810,740,103 | 1,600 | HcySunYang | @CodeDaraW Can you fix the conflict? this needs to be reabsed now | 2021-03-31T03:56:37 | 2021-03-31T03:56:37 | {} | MEMBER |
vuejs | core | 810,746,285 | 2,748 | HcySunYang | Fixed in https://github.com/vuejs/vue-next/commit/4ca4666d58ee8025570dc14f1c163bdeac9c6012 | 2021-03-31T04:15:07 | 2021-03-31T04:15:07 | {} | MEMBER |
vuejs | core | 813,023,361 | 3,538 | tbeckenhauer | It started life as a blog post about how I think functions should be ordered to improve readability: push high level details up to be more visible and low level details down to be less visible.
This module was pretty close to that already.
So I submitted a PR when the tests were still passing. It doesn't resolve... | 2021-04-04T12:17:26 | 2021-04-04T12:17:26 | {} | NONE |
vuejs | core | 810,168,134 | 3,513 | HcySunYang | I have some ideas, and that requires changes to the compiler, but it has a relatively large impact..... | 2021-03-30T12:09:13 | 2021-03-30T12:09:13 | {} | MEMBER |
vuejs | core | 810,347,172 | 3,399 | yyx990803 | @pikax looks like there's a test failing after the merge | 2021-03-30T15:17:19 | 2021-03-30T15:17:19 | {
"+1": 1,
"eyes": 3
} | MEMBER |
vuejs | core | 810,746,417 | 2,752 | HcySunYang | see https://github.com/vuejs/vue-next/commit/4ca4666d58ee8025570dc14f1c163bdeac9c6012 | 2021-03-31T04:15:26 | 2021-03-31T04:15:26 | {} | MEMBER |
vuejs | core | 812,291,104 | 3,327 | HcySunYang | @LinusBorg Should we close this one? | 2021-04-02T03:02:55 | 2021-04-02T03:02:55 | {} | MEMBER |
vuejs | core | 814,199,194 | 3,547 | posva | Duplicate of https://github.com/vuejs/vue-next/issues/2633 | 2021-04-06T15:10:09 | 2021-04-06T15:10:09 | {} | MEMBER |
vuejs | core | 810,180,351 | 3,288 | Justineo | After some discussion with @pikax I think this issue should be reopened. As with current implementation, we actually cannot reliably detect missing props with a simple `key in props` check, while improving the experience of `toRefs` may bring more benefits. | 2021-03-30T12:27:20 | 2021-03-30T12:27:20 | {} | MEMBER |
vuejs | core | 810,735,674 | 2,386 | SalathielGenese | Has this fix been deployed yet? | 2021-03-31T03:42:22 | 2021-03-31T03:42:22 | {} | NONE |
vuejs | core | 812,288,531 | 3,526 | HcySunYang | Duplicate of https://github.com/vuejs/vue-next/issues/2949, see comment https://github.com/vuejs/vue-next/issues/2949#issuecomment-755215688 | 2021-04-02T02:52:44 | 2021-04-02T02:52:44 | {} | MEMBER |
vuejs | core | 813,967,789 | 3,317 | LinusBorg | Hey, thanks for the gentle reminder. Need to get back to this, will look at your branch this week as I have the week off. If that branch helps me to reproduce the error it will definitely help.
Already played with a solution but was not sure how to to add a proper test for it without a way to make it fail before ...... | 2021-04-06T09:18:15 | 2021-04-06T09:18:15 | {
"+1": 1
} | MEMBER |
vuejs | core | 809,863,770 | 3,507 | HcySunYang | And sorry to @danyadev for that | 2021-03-30T02:47:22 | 2021-03-30T02:47:22 | {} | MEMBER |
vuejs | core | 810,324,836 | 3,507 | yyx990803 | Yeah, I closed #1167 without checking Vue 2 behavior, which was a mistake.
Since uppercase `<Component :is>` does work in Vue 2, we are keeping it consistent in Vue 3. | 2021-03-30T14:49:21 | 2021-03-30T14:49:21 | {
"+1": 4
} | MEMBER |
vuejs | core | 810,652,640 | 3,513 | yyx990803 | @cexbrayat the bug you mentioned is fixed in 9cf75258 | 2021-03-30T23:55:53 | 2021-03-30T23:55:53 | {
"+1": 2
} | MEMBER |
vuejs | core | 812,237,075 | 3,432 | yyx990803 | Closing as the original behavior being raised is by design. Whether we need a way to expose declared `emits` listeners should have its own thread. | 2021-04-01T23:52:11 | 2021-04-01T23:52:11 | {} | MEMBER |
vuejs | core | 812,845,668 | 3,418 | LinusBorg | > It should be fixed.
Did any of us say anything to the contrary? | 2021-04-03T10:22:38 | 2021-04-03T10:22:38 | {} | MEMBER |
vuejs | core | 814,125,575 | 3,547 | edison1105 | I think this is about Volar and `string | number` is recommended key type, not `symbol`.
BTW, We recommend using [sfc.vuejs.org](https://sfc.vuejs.org) to create a reproduction. | 2021-04-06T13:36:26 | 2021-04-06T13:36:26 | {} | MEMBER |
vuejs | core | 814,126,366 | 3,547 | yyx990803 | I can't reproduce this locally and your file download link doesn't seem to work (stuck at downloading)
Just pasting the content of the file directly here would be easier... | 2021-04-06T13:37:31 | 2021-04-06T13:37:57 | {} | MEMBER |
vuejs | core | 814,530,563 | 3,435 | shen-zhao | > `splice` is significantly slower than `push` though, so I actually prefer returning `-1` from `findInsertionIndex` whenever we can.
Yes, I thought about it the same way before, let me do it! | 2021-04-07T01:12:06 | 2021-04-07T01:12:06 | {} | CONTRIBUTOR |
vuejs | core | 810,022,363 | 3,517 | posva | Duplicate of https://github.com/vuejs/vue-next/issues/826#issuecomment-598207464 | 2021-03-30T08:23:21 | 2021-03-30T08:23:21 | {} | MEMBER |
vuejs | core | 810,030,606 | 3,517 | posva | It's documented: https://v3.vuejs.org/guide/migration/render-function-api.html#_2-x-syntax-4 | 2021-03-30T08:35:17 | 2021-03-30T08:35:17 | {
"+1": 1
} | MEMBER |
vuejs | core | 812,365,260 | 3,478 | henribru | Good point, I wasn't aware of this limitation. However, it looks Typescript 4.3 will allow different types for setters and getters: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/
I'm guessing it might be a good while before 4.3+ is adopted well enough to use its features in Vue's types tho... | 2021-04-02T07:08:47 | 2021-04-02T07:08:47 | {} | NONE |
vuejs | core | 813,389,948 | 3,418 | bazuka5801 | > > It should be fixed.
>
> Did any of us say anything to the contrary?
No. | 2021-04-05T13:22:12 | 2021-04-05T13:22:12 | {} | NONE |
vuejs | core | 814,581,348 | 3,548 | Alanscut | Removing `&& this.$slots.popoverContent()` of the `hasPopover` function also works, that's strange...
https://codesandbox.io/s/eloquent-sun-29s91?file=/src/ControlButton.vue | 2021-04-07T03:55:37 | 2021-04-07T03:55:37 | {} | CONTRIBUTOR |
vuejs | core | 813,901,532 | 1,600 | CodeDaraW | @HcySunYang I've fixed the conflict. | 2021-04-06T07:39:31 | 2021-04-06T07:39:31 | {
"+1": 5
} | CONTRIBUTOR |
vuejs | core | 813,959,006 | 3,317 | viniciuskneves | Hey @LinusBorg, did my last message helped somehow? | 2021-04-06T09:04:42 | 2021-04-06T09:04:42 | {} | NONE |
vuejs | core | 814,074,812 | 3,519 | edison1105 | @CarterLi Indeed, you are right that this change lowers performance.
Close this one. | 2021-04-06T12:19:54 | 2021-04-06T12:19:54 | {} | MEMBER |
vuejs | core | 814,215,494 | 3,547 | valdoryu | Sorry guys, I tried to reproduce with typescript in the proposed repro tools without success.
I'll try better next time.
Issue is indeed #2633 | 2021-04-06T15:31:39 | 2021-04-06T15:33:29 | {} | NONE |
vuejs | core | 809,866,846 | 3,507 | KunHwanAhn | So... does it means that this issue is not an issue?
Vue3 `DO NOT` allow Pascal Case, `<Component>`? | 2021-03-30T02:56:32 | 2021-03-30T04:11:29 | {} | NONE |
vuejs | core | 784,100,108 | 3,288 | posva | How would you differentiate a prop passed as `undefined` from a missing prop?
Wouldn't make more sense to do:
```js
const foo = toRef(props, 'foo')
```
Edit: Although this is technically a breaking change, having the key with `undefined` seems to be more flexible, especially with `toRefs()` (which otherwise... | 2021-02-23T10:30:57 | 2021-03-30T12:39:25 | {} | MEMBER |
vuejs | core | 810,494,111 | 3,512 | HeavyMedl | +1 | 2021-03-30T18:47:23 | 2021-03-30T18:47:23 | {} | NONE |
vuejs | core | 809,109,435 | 3,498 | johnsoncodehk | Can we change this implement if this is not the design? | 2021-03-29T06:33:27 | 2021-03-30T19:37:02 | {} | MEMBER |
vuejs | core | 810,570,785 | 3,513 | yyx990803 | @cexbrayat that's a runtime error, definitely a different issue. | 2021-03-30T20:54:02 | 2021-03-30T20:54:02 | {} | MEMBER |
vuejs | core | 812,297,991 | 2,027 | ChenWeihua123 | > vue3 中，这个是devtools 6.0.0 beta 2打印的，我把devtools关闭，这个waring就消失了
请问怎么关闭 vue-devtools （vue3）
我也遇到了同样的警告信息，页面直接卡死无响应 | 2021-04-02T03:31:01 | 2021-04-02T03:31:01 | {} | NONE |
vuejs | core | 813,139,726 | 3,250 | tbeckenhauer | A quick google search shows Vue CLI is using webpack 5. I am wondering if any other frameworks are having this problem. If we can answer that question it will be clear if this is a webpack thing or a vue thing. | 2021-04-05T01:48:41 | 2021-04-05T01:48:52 | {} | NONE |
vuejs | core | 813,956,277 | 3,543 | HcySunYang | Finally I came up with the solution https://github.com/vuejs/vue-next/pull/3546 | 2021-04-06T09:00:45 | 2021-04-06T09:00:45 | {} | MEMBER |
vuejs | core | 810,852,983 | 2,353 | unbyte | @HcySunYang
I just rebase on master branch and all tests are passed 😂
Since I haven't paid attention to vue-next for a long time, I just temporarily checked the files involved in this PR, which should not damage the current operation mechanism. If there is any, please let me know and I will fix it as soon as possi... | 2021-03-31T07:45:31 | 2021-03-31T07:45:31 | {} | CONTRIBUTOR |
vuejs | core | 811,165,300 | 1,600 | LinusBorg | @martinbean I don't disagree with the obviously correct factual content of the comment. *Because* of the obviousness, it *appears* like a snarky or tounge-in-cheek way to say _"if you had done your job at the priority that we wanted you to, then ..."_, regardless of intent - and as such it's not contributing anything ... | 2021-03-31T15:39:45 | 2021-03-31T15:40:12 | {
"+1": 8
} | MEMBER |
vuejs | core | 812,211,853 | 3,524 | yyx990803 | This only happens in dev - the intention is that it forces you to consider handling the error with error handlers. Once you add a global error handler or `onErrorCaptured` somewhere up the parent chain, the app will be able to function despite the error. Production mode also auto-recovers even without error handlers to... | 2021-04-01T22:31:04 | 2021-04-01T22:31:04 | {} | MEMBER |
vuejs | core | 812,845,286 | 3,418 | LinusBorg | @bazuka5801 Just to be clear: the docs example isn't *generally* failing. it's failing under specific conditions that you guys must have encountered (can't say more as you couldn't provide a reproduction). Hence a test wouldn't really have helped.
In can't talk to your specific situation as you never provided a comp... | 2021-04-03T10:19:00 | 2021-04-03T10:19:30 | {} | MEMBER |
vuejs | core | 813,797,010 | 3,541 | HcySunYang | As a workaround, you can create a new array instead of modifying the original array:
```js
const keyup = () => {
const newArr = state.arr.slice()
newArr.unshift(Math.random())
state.arr = newArr
}
``` | 2021-04-06T03:34:22 | 2021-04-06T03:34:22 | {} | MEMBER |
vuejs | core | 813,975,994 | 3,519 | CarterLi | > Basically, simpler code tends to benefit more from optimization by the engines
Maybe yes for other cases. But for `for loop` no.
Because `forEach`, `some` and other Array methods are basically implemented ( and can only be ) as plain for loop, with other additional (and usually unnecessary) checks. A standard c... | 2021-04-06T09:30:41 | 2021-04-06T09:30:41 | {} | CONTRIBUTOR |
vuejs | core | 810,167,160 | 3,513 | HcySunYang | The [resolveScopeId](https://github.com/vuejs/vue-next/blob/master/packages/server-renderer/src/render.ts#L290) function is also problematic. When a component is SSR-optimized, it will no longer have `subTree`, this will cause the inheritance of scopeId to be broken, the following example can be used to reproduce:
`... | 2021-03-30T12:07:48 | 2021-03-30T12:07:48 | {} | MEMBER |
vuejs | core | 810,692,917 | 3,490 | HcySunYang | The SFC parser is for SFC files, which is opinionated and does not mean letting users customize their behavior. But you can use a lower-level API to manually implement your needs | 2021-03-31T01:45:09 | 2021-03-31T01:45:09 | {} | MEMBER |
vuejs | core | 810,762,634 | 2,483 | HcySunYang | @KaelWD Hey, can you fix the conflict? | 2021-03-31T05:02:00 | 2021-03-31T05:02:00 | {} | MEMBER |
vuejs | core | 811,632,358 | 2,353 | HcySunYang | @unbyte Thanks | 2021-04-01T04:39:35 | 2021-04-01T04:39:35 | {} | MEMBER |
vuejs | core | 813,389,534 | 3,542 | HcySunYang | For the browser, `<user-name>` is a custom tag, and the custom tag requires a closing tag. Only certain tags in HTML are allowed to be self-closing: https://html.spec.whatwg.org/multipage/syntax.html#void-elements, and a non-void element **must** have an end tag, also see https://github.com/WICG/webcomponents/issues/62... | 2021-04-05T13:21:14 | 2021-04-05T13:21:14 | {} | MEMBER |
vuejs | core | 813,872,683 | 3,545 | Alanscut | This seems to be a bug and is normal in vue2.
As a workaround, using `style` attribute could solve your problem.
```
<img alt="Vue logo" src="./assets/logo.png" style="width: 100px" />
```
| 2021-04-06T06:52:14 | 2021-04-06T06:52:14 | {
"heart": 1
} | CONTRIBUTOR |
vuejs | core | 814,001,693 | 3,519 | CarterLi | > thats weird.
> [measurethat.net/Benchmarks/Show/12451/0/for-loop-vs-arraysome-vs-for-of](https://www.measurethat.net/Benchmarks/Show/12451/0/for-loop-vs-arraysome-vs-for-of)
>
> > We use Array methods not because they are fast, but because they are easier to write and result in cleaner code. For library uses, I d... | 2021-04-06T10:11:14 | 2021-04-06T10:11:14 | {} | CONTRIBUTOR |
vuejs | core | 810,053,634 | 3,513 | HcySunYang | A hint, this problem occurs when rendering components with manually written render function between ssr optimized components. E.g.
`ComA` is scoped, and SSR-optimized:
```js
const _withId =_withScopeId("scope-id")
const CompA = {
ssrRender = _withId((_ctx, _push, _parent, _attrs) => {
const RouterView... | 2021-03-30T09:08:33 | 2021-03-30T11:42:20 | {} | MEMBER |
vuejs | core | 810,630,185 | 3,513 | yyx990803 | @HcySunYang your case in https://github.com/vuejs/vue-next/issues/3513#issuecomment-810167160 won't happen because SSR-optimized HOC components pass `attrs` down:
```diff
const Comp = {
__scopeId: 'parent',
- ssrRender: (ctx: any, push: any, parent: any) => {
- push(ssrRenderComponent(Comp2, null, null, pa... | 2021-03-30T22:52:23 | 2021-03-30T22:53:42 | {} | MEMBER |
vuejs | core | 811,090,800 | 1,600 | LinusBorg | @martinbean thanks for this insightful comment. | 2021-03-31T13:59:10 | 2021-03-31T13:59:10 | {
"laugh": 1
} | MEMBER |
vuejs | core | 812,092,665 | 3,498 | yyx990803 | `<template v-for="..." v-slot>` generates code like `createSlots({ ... })` since it's dynamically generated slots. In this case the codegen tree is the source of truth and the original AST is left untouched. We *can* technically adjust the behavior, but it will solely be for external tooling and actually risks breaking... | 2021-04-01T18:30:31 | 2021-04-01T18:30:31 | {
"+1": 1
} | MEMBER |
vuejs | core | 812,567,486 | 3,250 | yura3d | The bug is also reproducible in apps created by Vue CLI 5. | 2021-04-02T15:00:17 | 2021-04-02T15:00:17 | {} | NONE |
vuejs | core | 809,862,724 | 3,507 | HcySunYang | That should be a misunderstanding, because Vue2 allows a capitalized version, so we should keep that behavior. | 2021-03-30T02:44:28 | 2021-03-30T02:44:28 | {} | MEMBER |
vuejs | core | 810,302,795 | 3,518 | LinusBorg | 1. The reproduction link doesn't point to a reproduction
2. We don't maintain or support the plugins mentioned.
3. Vue 3 doesn't support that browser.
4. Various features we use in Vue 3 can't be fully polyfilled
5. The proposed workarounds will inevitably lead to other bugs.
I'd recomment opening an issue at on... | 2021-03-30T14:22:52 | 2021-03-30T14:22:52 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.