Datasets:
open-index
/
open-github-issues

Dataset card Data Studio Files
xet
 Community
1
owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
579,832,499
671
yyx990803
@lbogdan yeah, that would be really helpful.
2020-01-29T16:11:27
2020-01-29T16:11:27
{}
MEMBER
vuejs
core
580,042,139
673
yyx990803
I would suggest doing a PR with benchmarks, since this feels like premature optimization to me. The cost of managing `arrayRanges` isn't necessarily cheaper than normal `track` calls (which really aren't that expensive).
2020-01-30T01:26:55
2020-01-30T01:26:55
{}
MEMBER
vuejs
core
580,394,741
673
yyx990803
I think around 1000 would be the upside of what we typically see? Reopening since I think this is worth pursuing if a benchmark shows significant improvement.
2020-01-30T18:40:48
2020-01-30T18:40:48
{}
MEMBER
vuejs
core
579,301,004
669
yyx990803
78beed2
2020-01-28T15:29:17
2020-01-28T15:29:17
{}
MEMBER
vuejs
core
579,785,869
670
yyx990803
I think this is an issue that should be fixed in `vue-cli-plugin-vue-next` by not including `vue-template-compiler` (which is for 2.x only)
2020-01-29T14:41:03
2020-01-29T14:41:03
{ "+1": 3 }
MEMBER
vuejs
core
580,760,933
671
yyx990803
@cawa-93 that's a good point. So another option we have is: - Keep the 2.x behavior of the `watch` option; - Rename the current `watch` in Composition API to: - `autorun`? - `runAndWatch`? - `effect`?
2020-01-31T14:42:01
2020-01-31T14:42:01
{}
MEMBER
vuejs
core
581,398,178
688
dsseng
Probably this is a duplicate of #687.
2020-02-03T12:48:21
2020-02-03T12:48:21
{}
CONTRIBUTOR
vuejs
core
582,488,296
697
yyx990803
Good catch! I implemented an easier fix in 8f6b669 so that we don't need to worry about calling with the correct arguments in transforms. We also need to make sure helpers imported from Vue core are using the correct package name, e.g. `mergeProps`.
2020-02-05T16:21:33
2020-02-05T16:22:25
{}
MEMBER
vuejs
core
583,249,397
700
yyx990803
I prefer avoiding a large global timeout. Only e2e tests can go over default timeout and they all have explicit timeouts now: https://github.com/vuejs/vue-next/blob/master/packages/vue/examples/__tests__/commits.spec.ts#L54
2020-02-07T06:10:25
2020-02-07T06:10:25
{}
MEMBER
vuejs
core
583,691,819
701
jiangying000
> And I found there are 75 empty lines with leading white spaces in snapshots. > ![image](https://user-images.githubusercontent.com/23182033/74026039-3c379900-49e0-11ea-9a34-89314570d966.png) All spaces removed expect those in inlineSnapshots
2020-02-08T02:15:28
2020-02-08T02:15:28
{}
CONTRIBUTOR
vuejs
core
583,709,061
703
hareku
`charAt` is faster than `startsWith` on Node.js v10.16.0 ```node const { performance } = require('perf_hooks') const start = performance.now() const string = './my-page' for(var i = 0; i < 10000000; i++){ if(string.startsWith('.')) { // } } console.log(performance.now() - start) // 436.695001006...
2020-02-08T06:40:09
2020-02-08T06:40:09
{ "+1": 4 }
CONTRIBUTOR
vuejs
core
578,746,318
660
jods4
>Thanks for the example, it gives more context! Instead of using toRefs, using ref(null) instead of null seems easier imo. Yeah but I'm using `reactive` to avoid declaring several `ref` and having to use `value`. It's definitely weird to have to include one `ref` in the lot because of how it's used in the template.
2020-01-27T13:28:57
2020-01-27T13:28:57
{}
CONTRIBUTOR
vuejs
core
579,321,179
661
jods4
@DinsmoreDesign If the button stays on screen during a long running operation (e.g. a server call) I think you absolutely should update the UI (disable the button, show a spinner, etc.). In the context of elements being removed from DOM, it's not a good solution. Let's take the router transitioning to another p...
2020-01-28T16:03:01
2020-01-28T16:03:01
{}
CONTRIBUTOR
vuejs
core
580,651,939
671
cawa-93
@yyx990803 > @lbogdan I think there is a force of habit here. What I've found is that in a lot of cases people are actually doing this: > > ```js > created() { > this.fetchData(this.id) > }, > watch: { > id: fetchData > }, > methods: { > fetchData(id) { > // ... > } > } > ``` > > Where w...
2020-01-31T09:17:21
2020-01-31T13:13:41
{}
CONTRIBUTOR
vuejs
core
581,137,262
673
jods4
@yyx990803 I built a benchmark to evaluate what kind of improvement we are talking about. I would like to engage in a discussion about what the best solution is here, as there are many possible designs and trade-offs. The benchmark is based on optimized arrays in userland. ### App under test I built a fake proce...
2020-02-02T13:48:02
2020-02-02T13:48:02
{}
CONTRIBUTOR
vuejs
core
579,170,999
664
posva
You need to adapt the mounting code: ```diff -const app = createApp() +const app = createApp(App) -app.mount(App, '#app') +app.mount('#app') ``` This was one of the breaking changes: https://github.com/vuejs/vue-next/compare/v3.0.0-alpha.3...v3.0.0-alpha.4 [Changelog](https://github.com/vuejs/vue-next/blo...
2020-01-28T10:08:39
2020-01-28T10:32:02
{ "+1": 5 }
MEMBER
vuejs
core
583,422,047
684
yyx990803
Hmm, maybe we should rename the `vnodeXXX` hooks to `elementXXX`, since they are actually designed for working with DOM elements (and is the underlying mechanism for directives). When used on a component, they are passed down to the component as part of `$attrs`, and automatically spread on to the child component ro...
2020-02-07T14:48:06
2020-02-07T14:49:06
{}
MEMBER
vuejs
core
583,732,420
677
jonaskuske
Well I don't have the time to work on this myself at the moment, and since there's been no activity from others, I'd assume so? Prior triage would be appreciated though @yyx990803 :)
2020-02-08T12:30:47
2020-02-08T12:30:47
{}
CONTRIBUTOR
vuejs
core
584,601,536
716
ShenQingchuan
As the issue #709 said, befor PR Iterating a Map only tracks addition/removal. Modifications of map contents don't run effect, resulting in unexpected, stale values. But for the belowing: > When enumerating `entries` or `values` on a Map, **`next` should call `track` on the key** before returning the results, as ...
2020-02-11T11:57:54
2020-02-11T11:57:54
{}
CONTRIBUTOR
vuejs
core
581,089,291
671
lmiller1990
I'm not a fan of `effect` either - `watch` is definitely more intuitive to me. I don't think it's too late to change the name - Vue 3 is still in alpha. Other words that come to mind are`observe` and `perform`.
2020-02-02T02:02:55
2020-02-02T02:02:55
{}
MEMBER
vuejs
core
581,566,070
690
yyx990803
It already does? https://github.com/vuejs/vue-next/blob/master/packages/compiler-sfc/src/compileTemplate.ts#L38-L39 Also in `vue-loader` pre-processor for the template is done by adding `lang="pug"` + configuring a corresponding loader.
2020-02-03T19:04:18
2020-02-03T19:04:18
{}
MEMBER
vuejs
core
583,810,187
708
jamesgeorge007
@yyx990803 please enable the sponsor button from settings.
2020-02-09T06:35:00
2020-02-09T06:35:00
{}
CONTRIBUTOR
vuejs
core
577,960,987
629
yyx990803
Yes - PR welcome!
2020-01-24T02:00:49
2020-01-24T02:00:49
{ "hooray": 2 }
MEMBER
vuejs
core
579,131,936
664
veaba
rolled back `vue@3.0.0-alpha.3`
2020-01-28T08:22:01
2020-01-28T08:22:01
{}
MEMBER
vuejs
core
579,313,759
661
DinsmoreDesign
Why not just disable the form elements after the first click...?
2020-01-28T15:48:40
2020-01-28T15:48:40
{}
NONE
vuejs
core
579,818,159
671
yyx990803
Yes, these are somewhat intended. - The [watch](https://composition-api.vuejs.org/api.html#watch) in Composition API exhibits the new behavior described. In 3.0, watchers are fired immediately after component mount. I think it's better for the `watch` option to be made consistent with the Composition API instea...
2020-01-29T15:42:02
2020-01-29T15:42:14
{ "+1": 2 }
MEMBER
vuejs
core
580,310,207
671
yyx990803
@pimlie FYI `watch` in Vue 3 is not fired synchronously (even for the initial call) - they are in fact deferred until the component is mounted - so even with immediate by default they won't fire during SSR unless you explicitly use `{ flush: 'sync' }` in the watcher's options.
2020-01-30T15:35:35
2020-01-30T15:35:35
{ "+1": 1 }
MEMBER
vuejs
core
578,655,325
660
posva
Why would you want a more implicit behavior without saying it's a `ref`? Why is this more confusing to you? Is it because before it was that implicit as well: it was only necessary to declare `ref="a"` in the template and that gave you access to the Component/Element reference?
2020-01-27T09:11:53
2020-01-27T09:11:53
{}
MEMBER
vuejs
core
578,753,434
661
posva
> It's pretty much desirable on every element leaving DOM > ... > It's pretty much useful every time you animate an element, so including it by default removes boilerplate code. But it's not every time, that's the problem. Also, it would be easy if `inert` was a silver bullet but it isn't. I agree it would be very...
2020-01-27T13:46:25
2020-01-27T13:46:25
{}
MEMBER
vuejs
core
578,896,535
659
ruslansteiger
Thank you alot @posva. It is working now 🤗 Would be nice if some deprecation message would appear if you use the old syntax.
2020-01-27T18:52:58
2020-01-27T18:52:58
{}
NONE
vuejs
core
579,790,974
670
cexbrayat
Thx for the feedback, I opened https://github.com/vuejs/vue-cli-plugin-vue-next/issues/5 to track it
2020-01-29T14:52:11
2020-01-29T14:52:11
{}
MEMBER
vuejs
core
581,415,334
674
dsseng
I'm working on this one now.
2020-02-03T13:33:07
2020-02-03T13:33:07
{}
CONTRIBUTOR
vuejs
core
584,068,007
700
jiangying000
Also, run with `jest --runInBand` can avoid timeout for me
2020-02-10T11:00:42
2020-02-10T11:02:34
{}
CONTRIBUTOR
vuejs
core
584,259,790
692
yyx990803
Thanks a lot for this PR. However after looking into it, I had to rework vnode hooks handling in cfadb98.
2020-02-10T18:18:16
2020-02-10T18:18:16
{}
MEMBER
vuejs
core
579,128,558
661
jods4
@Justineo Yes, it's probably the most important bit of `inert` in this context (for double-clicks and such). `inert` also prevents keyboard interaction and removes the contents from assistive technology (the latter is not very important in the case of leave transition, as the element would get removed soon enough). ...
2020-01-28T08:11:31
2020-01-28T08:11:31
{}
CONTRIBUTOR
vuejs
core
580,047,412
675
yyx990803
I think having such optimized collections PRed directly into the lib itself would be more beneficial (avoids fragmentation, benefits more users, also ensures it works properly with future changes)
2020-01-30T01:50:49
2020-01-30T01:50:49
{}
MEMBER
vuejs
core
581,132,019
671
wvffle
I also think that `observe` is much more clear in meaning than `effect`. However `watch` has less letters so it's faster to type. I'd rathet stay with `watch`
2020-02-02T12:45:14
2020-02-02T12:45:14
{}
NONE
vuejs
core
581,170,557
673
yyx990803
This is very informative, thanks! So here's my takeaways from the benchmark: - It's impractical to have an "automatic-best-case-for-all" solution because we can never be sure of the user's intentions - However, if we were to provide dedicated APIs for users to optimize such cases, it can lead to APIs that are ...
2020-02-02T19:53:53
2020-02-02T19:58:28
{}
MEMBER
vuejs
core
583,875,826
703
yyx990803
Thanks but I don't think this is necessary (plus the performance difference)
2020-02-09T18:15:10
2020-02-09T18:15:10
{ "+1": 1 }
MEMBER
vuejs
core
787,468,306
1,600
hawkeye64
@LinusBorg Just so you know, you @mentioned the wrong evan ![image](https://user-images.githubusercontent.com/10262924/109423573-33c05080-799d-11eb-8e02-dab88a144b80.png)
2021-02-28T15:16:09
2021-02-28T15:16:09
{ "laugh": 1 }
NONE
vuejs
core
788,634,212
3,304
CarterLi
This issue broke my code. Could you please fix it ASAP?
2021-03-02T05:53:23
2021-03-02T05:53:23
{ "+1": 4 }
CONTRIBUTOR
vuejs
core
788,646,251
3,335
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.68 KB (0%) | | runtime-dom.global.prod.js | 27.01 KB (0%) | | size-check.global.prod.js | 16.37 KB (0%) |
2021-03-02T06:17:29
2021-03-02T06:17:29
{}
NONE
vuejs
core
789,473,847
3,345
flozero
When it’s empty it should not be injected On Wed, Mar 3, 2021 at 1:29 AM HcySunYang <notifications@github.com> wrote: > You can filter them out manually, and I'm not sure if they should be > filtered out by default. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view i...
2021-03-03T06:30:25
2021-03-03T06:30:25
{}
NONE
vuejs
core
789,477,801
3,338
HcySunYang
Although we can check whether it is a multi-root with a single element node. However, if `Transition` can work in this case, then the `directives` and `attr fallthrough` should also work in this case.
2021-03-03T06:39:38
2021-03-03T06:39:38
{ "+1": 1 }
MEMBER
vuejs
core
783,937,173
3,284
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.68 KB (0%) | | runtime-dom.global.prod.js | 27.01 KB (0%) | | size-check.global.prod.js | 16.37 KB (0%) |
2021-02-23T06:12:17
2021-03-03T16:23:05
{}
NONE
vuejs
core
790,254,544
3,348
HcySunYang
It has nothing to do with `slots`, the root cause is that the `props` of the `GridItem` component will not change from the perspective of the compiler, so it is skipped during runtime diff. Users manually modified the value of props, which is not known to the runtime. As a workground, just add `privateShow` to the `Gri...
2021-03-04T03:13:25
2021-03-04T03:13:25
{}
MEMBER
vuejs
core
790,292,735
3,353
HcySunYang
I believe the CI failure is not related to this PR...
2021-03-04T05:01:36
2021-03-04T05:01:36
{}
MEMBER
vuejs
core
790,325,233
3,355
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.74 KB (0%) | | runtime-dom.global.prod.js | 27.08 KB (0%) | | size-check.global.prod.js | 16.4 KB (0%) |
2021-03-04T06:13:09
2021-03-04T06:13:09
{}
NONE
vuejs
core
790,346,830
3,351
LinusBorg
I'd presume this is not about slots, but more generally, handling whitespace: https://github.com/vuejs/vue-next/pull/1600
2021-03-04T06:36:18
2021-03-04T06:36:18
{}
MEMBER
vuejs
core
787,512,145
3,325
LinusBorg
It may make sense in this scenario, but may cause a break later in other scenarios, which then would have to be traced back to the warning. If you try to render something that is not a valid vnode / component / null, you wrote code that is fundamentally wrong and you probably shouldn't be able to ignore a warning an...
2021-02-28T19:56:49
2021-03-01T15:59:09
{ "+1": 1 }
MEMBER
vuejs
core
788,552,145
2,054
yxmg
> in v3, `v-for` is compiled as a single fragment node. You will need to check the fragment's children for the list items. @yyx990803 But i need to traverse the slot array and check slot type. How should I know that slot is a v-for fragment node and traverse it's children ``` // 过滤注释节点 const isCommentNode = slo...
2021-03-02T03:29:39
2021-03-02T03:52:02
{}
NONE
vuejs
core
788,663,955
3,317
Mister-Hope
> Could you provide a complete code sample? a screenshot where the code is covered in large parts is hard to reproduce. A complete reproduction in issue would be even better. > > I ask because I regularly use readonly and haven't experienced this issue. If you are trying to export a `readonly` value from a compon...
2021-03-02T06:52:43
2021-03-02T06:54:38
{}
NONE
vuejs
core
788,783,412
3,339
vue-bot
Hello, thank you for taking time filling this issue! However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic...
2021-03-02T10:00:28
2021-03-02T10:00:28
{}
CONTRIBUTOR
vuejs
core
788,801,238
3,337
604587986
> This is intended because `<component someProp="" />` is the same as just `<component someProp />` and the order of the array matters. This is also consistent with Vue 2 This is easy to create unexpected bug. Like this => [https://github.com/element-plus/element-plus/blob/dev/packages/radio/src/radio-group.vue#L41]...
2021-03-02T10:26:48
2021-03-02T10:41:17
{}
NONE
vuejs
core
789,473,347
3,345
HcySunYang
You can filter them out manually, and I'm not sure if they should be filtered out by default.
2021-03-03T06:29:17
2021-03-03T06:29:17
{}
MEMBER
vuejs
core
789,844,468
3,293
dependabot-preview[bot]
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-...
2021-03-03T16:27:00
2021-03-03T16:27:00
{}
CONTRIBUTOR
vuejs
core
787,704,800
2,775
LinusBorg
https://v3.vuejs.org/guide/typescript-support.html#annotating-return-types
2021-03-01T07:01:44
2021-03-01T07:01:44
{}
MEMBER
vuejs
core
788,798,111
3,338
shameleo
Yes, I understand this, I thought maybe Vue can check how many elements slot **actually** returns, because it is always single element in my case. But if not, I'm ok with your workaround. It's strange, though because component have multiple root nodes as well, but Vue handles this and transition on components is allowe...
2021-03-02T10:21:51
2021-03-02T10:29:40
{ "+1": 5 }
NONE
vuejs
core
789,253,705
3,342
posva
This is expected and convenient. Wrap the object with`reactive` to unwrap: `return slots.default(reactive({ count })`
2021-03-02T22:06:02
2021-03-02T22:06:02
{}
MEMBER
vuejs
core
789,372,988
3,343
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.68 KB (0%) | | runtime-dom.global.prod.js | 27.01 KB (0%) | | size-check.global.prod.js | 16.37 KB (0%) |
2021-03-03T02:15:49
2021-03-03T02:15:49
{}
NONE
vuejs
core
787,826,150
3,270
yingpengsha
The source code clearly states that setup components take precedence over user components. Maybe it's not a bug, It's counterintuitive though. @HcySunYang https://github.com/vuejs/vue-next/blob/58c46d77eac05ee72f17aa2669239c4d7c9a3abe/packages/compiler-core/src/transforms/transformElement.ts#L260
2021-03-01T10:07:50
2021-03-01T10:07:50
{}
NONE
vuejs
core
787,870,830
3,270
yingpengsha
Maybe it should be resolved in resolveComponent.
2021-03-01T11:18:47
2021-03-01T11:18:47
{}
NONE
vuejs
core
788,550,748
2,540
richardltyler
This may not be the issue that everyone else is having, but I was getting this message because I was using `this.$parent.$emit('some-function-name')`. Essentially, from the grandchild component, I was telling the parent component to emit to the grandparent component. I was able to get around the warnings by adding the ...
2021-03-02T03:25:36
2021-03-02T03:25:36
{}
NONE
vuejs
core
788,657,186
3,323
HcySunYang
@tjk , great work, thanks
2021-03-02T06:39:59
2021-03-02T06:39:59
{ "+1": 1 }
MEMBER
vuejs
core
790,627,992
3,359
posva
I would say this is vanilla JS behavior: an element detached and reattached to the DOM loses its focus. You have to manually focus it again. We could look at `document.activeElement` before patching but I'm sure of its cost
2021-03-04T13:44:55
2021-03-04T13:44:55
{}
MEMBER
vuejs
core
789,088,150
3,317
LinusBorg
Hm, this problem only happens with Vetur, not Volar. Does it break on build? Haven't had time to check that out. Anyway, I would suspect the issue is rather with `DeepReadonly`, as it breaks the `Ref` type and turns it into a normal object type: https://github.com/vuejs/vue-next/blob/fbf2d68bbcde75c95363e1fd17946...
2021-03-02T17:44:33
2021-03-02T17:44:33
{ "+1": 1 }
MEMBER
vuejs
core
789,637,113
3,349
LinusBorg
That's an intended change in Vue 3. If there's a mistake in the docs, please open an issue in the docs-next repo with an exact location where you spotted the mistake. Thanks.
2021-03-03T11:13:55
2021-03-03T11:13:55
{}
MEMBER
vuejs
core
790,310,378
3,348
07akioni
> It has nothing to do with `slots`, the root cause is that the `props` of the `GridItem` component will not change from the perspective of the compiler, so it is skipped during runtime diff. Users manually modified the value of props, which is not known to the runtime. As a workground, just add `privateShow` to the `G...
2021-03-04T05:44:06
2021-03-04T07:28:12
{}
CONTRIBUTOR
vuejs
core
790,499,445
3,358
posva
Read https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro --- Remember to use the [forum](http://forum.vuejs.org/) or the [Discord chat](https://vue-land.js.org/) to ask questions!
2021-03-04T10:12:53
2021-03-04T10:12:53
{}
MEMBER
vuejs
core
787,405,515
3,300
tangjinzhou
@yyx990803 Is it possible to release a version, this issue causes the antdv component library cannot work
2021-02-28T06:47:00
2021-02-28T06:47:00
{}
CONTRIBUTOR
vuejs
core
787,754,909
3,330
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.66 KB (0%) | | runtime-dom.global.prod.js | 26.99 KB (0%) | | size-check.global.prod.js | 16.34 KB (0%) |
2021-03-01T08:23:26
2021-03-01T08:23:26
{}
NONE
vuejs
core
787,830,843
3,270
HcySunYang
This is not about component priority, it is about components/directives and data name conflicts
2021-03-01T10:15:59
2021-03-01T10:15:59
{}
MEMBER
vuejs
core
789,481,484
3,327
LinusBorg
I think we discussed this in the original RFC for `Teleport` and found that the added complexity in the renderer for updates etc, especially concerning `order`, wasn't worth it, at least initially. A simple workaround for prepending in `body` is to add an empty as the first child of `body` and mount to that. I'm ...
2021-03-03T06:47:46
2021-03-03T06:47:46
{ "+1": 2 }
MEMBER
vuejs
core
790,536,927
3,357
HcySunYang
I'm sure this can be fixed in #3119
2021-03-04T11:13:05
2021-03-04T11:13:05
{}
MEMBER
vuejs
core
787,416,902
3,320
Ryan2128
> works fine use `deep` > > ```js > watch(() => test.test, () => { > console.log(111) > },{deep:true}) > ``` > > or > > ```js > watch(test.test, () => { > console.log(111) > }) > ``` Thank you. 👍
2021-02-28T08:34:39
2021-02-28T08:34:39
{}
NONE
vuejs
core
787,463,349
3,034
yesixuan
> These timers should also be cleared in the `onBeforeUnmount` hook 你好，已经按你的要求在 `onBeforeUnmount` hook 中清除定时器了。
2021-02-28T14:42:46
2021-02-28T14:42:46
{}
NONE
vuejs
core
787,754,593
3,329
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.66 KB (0%) | | runtime-dom.global.prod.js | 26.99 KB (0%) | | size-check.global.prod.js | 16.34 KB (0%) |
2021-03-01T08:23:02
2021-03-01T08:23:02
{}
NONE
vuejs
core
787,806,393
3,331
posva
Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js). --- See https://blog.vuejs.org/posts/hello-2021.html
2021-03-01T09:35:33
2021-03-01T09:35:33
{}
MEMBER
vuejs
core
787,915,783
3,332
Fuzzyma
Oh sorry, didn't see that you deleted the comment. I also couldn't figure out what changed. And yes, I mentioned this on discord yesterday. The issue first occurred for me with my ts-node setup but it is the same with node, too. It is super annoying because my server code just stopped working. I went back to 3.0.5 for ...
2021-03-01T12:34:57
2021-03-01T12:34:57
{}
NONE
vuejs
core
788,724,546
992
zyxm5
> The target element cannot be a part of the same component... It needs to be outside of `<div id="app">`. It is not work
2021-03-02T08:31:03
2021-03-02T08:31:03
{}
NONE
vuejs
core
788,758,041
3,337
604587986
> ```ts > // [Boolean, String] > prop[BooleanFlags.shouldCast] = booleanIndex > -1 > prop[BooleanFlags.shouldCastTrue] = > stringIndex < 0 || booleanIndex < stringIndex > ``` > > ```ts > // boolean casting > if (opt[BooleanFlags.shouldCast]) { > if (!hasOwn(props, key) && !hasDefault) ...
2021-03-02T09:22:02
2021-03-02T09:22:02
{}
NONE
vuejs
core
788,957,781
3,258
nandi95
Can this PR have couple more reviews on it?
2021-03-02T14:42:50
2021-03-02T14:42:50
{ "+1": 2, "heart": 2 }
CONTRIBUTOR
vuejs
core
789,545,336
3,345
posva
can you clarify the steps: c_lick here, write this, ..._ and the expected vs actually happening: _it displays x vs it should display y in the input_. Thanks
2021-03-03T08:46:33
2021-03-03T08:46:33
{}
MEMBER
vuejs
core
787,406,604
3,300
antfu
@tangjinzhou You can use the nightly build here: https://www.npmjs.com/package/@knightly/vue/v/master
2021-02-28T07:01:01
2021-02-28T07:01:01
{}
MEMBER
vuejs
core
788,646,459
3,336
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.68 KB (0%) | | runtime-dom.global.prod.js | 27.01 KB (0%) | | size-check.global.prod.js | 16.37 KB (0%) |
2021-03-02T06:17:55
2021-03-02T06:17:55
{}
NONE
vuejs
core
789,609,546
3,334
HcySunYang
I adjusted the PR and updated the initial proposal above. About the `ssrClientBranch`, do you mean something like this when compiling for SSR: ```js context.ssr = true context.ssrClientBranch = false // default context.ssrClientBranch = true // when compiling the fallback branch ```
2021-03-03T10:28:37
2021-03-03T10:54:24
{}
MEMBER
vuejs
core
790,429,794
3,119
07akioni
@pikax
2021-03-04T08:35:03
2021-03-04T08:35:03
{}
CONTRIBUTOR
vuejs
core
790,616,850
3,345
flozero
Thank's for your answer. Is it something that the user should take care of? @posva Or Vue has to delete it? That's the point of my pull request.
2021-03-04T13:26:49
2021-03-04T13:26:49
{}
NONE
vuejs
core
787,592,299
3,323
HcySunYang
I think it would be better if we write test case in `server-renderer`, as a special case, although it is related to `watch`, but it is also related to the rendering behavior of SSR.
2021-03-01T02:30:14
2021-03-01T02:30:14
{ "+1": 1 }
MEMBER
vuejs
core
787,853,484
3,328
songsf520
thank you , I got it;
2021-03-01T10:51:31
2021-03-01T10:51:31
{}
NONE
vuejs
core
788,748,235
3,337
Kingbultsea
```typescript // [Boolean, String] prop[BooleanFlags.shouldCast] = booleanIndex > -1 prop[BooleanFlags.shouldCastTrue] = stringIndex < 0 || booleanIndex < stringIndex ``` ```typescript // boolean casting if (opt[BooleanFlags.shouldCast]) { if (!hasOwn(props, key) && !hasDefault) { ...
2021-03-02T09:07:44
2021-03-02T09:18:21
{}
CONTRIBUTOR
vuejs
core
788,802,030
3,340
posva
The error is there with TS so this is probably something with your local TS setup. --- Remember to use the [forum](http://forum.vuejs.org/) or the [Discord chat](https://vue-land.js.org/) to ask questions!
2021-03-02T10:27:56
2021-03-02T10:27:56
{}
MEMBER
vuejs
core
788,938,397
3,334
yyx990803
> 1. Static `class` appears before `v-bind`: > > ```html > <p class="foo" v-bind="obj" /> > ``` > > Need full normalization, because `v-bind` can override the static class. > > output: > > ```js > createElementBlock("p", > normalizeProps(mergeProps({ class: "foo" }, _ctx.obj)) > ) > ``` `mergeProps...
2021-03-02T14:14:08
2021-03-02T14:19:05
{}
MEMBER
vuejs
core
790,459,928
3,358
edison1105
You should provide a mini demo or code.
2021-03-04T09:15:09
2021-03-04T09:15:09
{}
MEMBER
vuejs
core
790,462,285
3,351
r0the
@LinusBorg Thanks, this is the same thing.
2021-03-04T09:18:28
2021-03-04T09:18:28
{}
NONE
vuejs
core
790,558,452
3,345
HcySunYang
The modifiers of `v-modle` introduces additional props, e.g. ```html <Comp v-model.a.b="val" /> ``` Will be compiled to: ```js createVNode(Comp, { modelValue: _ctx.val, "onUpdate:modelValue": $event => (_ctx.val = $event), modelModifiers: { a: true, b: true } }) ``` If the `Comp` compone...
2021-03-04T11:51:44
2021-03-04T11:51:44
{ "+1": 1 }
MEMBER
vuejs
core
787,493,267
3,325
cathrinevaage
> What do you expect Vue to render/do when it receives a "functional component" that really isn't one? just render nothing, and essentially silently fail? Throw a warning? an error? Rendering nothing and throwing a warning is the current behaviour. This issue is about what happens after. It's not intuitive to m...
2021-02-28T18:01:31
2021-02-28T18:07:29
{}
CONTRIBUTOR
vuejs
core
787,710,244
3,328
edison1105
Variable reassignment does not trigger reactive. use ref instead.
2021-03-01T07:10:57
2021-03-01T07:12:18
{}
MEMBER
vuejs
core
787,906,530
3,333
HcySunYang
Hey, Thank you for your PR but this is not the right approach
2021-03-01T12:19:08
2021-03-01T12:19:08
{}
MEMBER
vuejs
core
789,201,720
3,150
yyx990803
see https://github.com/vuejs/vue-next/issues/2892#issuecomment-789201581
2021-03-02T20:42:04
2021-03-02T20:42:04
{}
MEMBER