Datasets:
open-index
/
open-github-issues

Dataset card Data Studio Files
xet
 Community
1
owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
773,232,420
2,765
HcySunYang
> @edison1105 Thoughts on the last comment? Does that cover the case you mentioned? @LinusBorg yes, that comment covers that case.
2021-02-04T11:18:18
2021-02-04T11:18:18
{ "+1": 1, "rocket": 1 }
MEMBER
vuejs
core
773,669,710
3,164
canac
I discovered that defining setting the `date` `type` to `Date as PropType<Date>` and removing the type annotation from `setup` works, as suggested in #1494. That gets my code working again, but it seems a little hacky, and it would be nice if Vue could correctly infer prop types for dates like it can for numbers and st...
2021-02-04T23:25:08
2021-02-04T23:25:08
{}
NONE
vuejs
core
773,676,357
2,938
github-actions[bot]
## Size report | Path | Size | | -------------------------- | -------------------- | | vue.global.prod.js | 40.66 KB (+0.26% 🔺) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-04T23:41:44
2021-02-04T23:41:44
{}
NONE
vuejs
core
773,949,133
3,037
cexbrayat
Hi @web2033 and thank you for the PR! A similar fix has been merged recently, so I'm going to close this one. See de7f9d1efd7fa19a908357d3f3a706c52694d8bd
2021-02-05T10:36:20
2021-02-05T10:36:20
{}
MEMBER
vuejs
core
774,384,900
3,172
HcySunYang
See this https://codesandbox.io/s/fervent-visvesvaraya-jwqd2
2021-02-06T02:47:43
2021-02-06T02:47:43
{}
MEMBER
vuejs
core
774,389,352
3,173
wenfangdu
@HcySunYang Yes, I've known that, I guess this issue belongs to the vue 2 repo, I've created one there (https://github.com/vuejs/vue/issues/11902). Also, > [If the bound value is null or undefined then the attribute will not be included on the rendered element.](https://v3.vuejs.org/guide/template-syntax.html#attri...
2021-02-06T03:22:44
2021-02-06T03:26:40
{}
NONE
vuejs
core
774,518,148
3,125
Eterion
Is it really the best course of action to extend the `ExtractPropTypes` with a parameter, instead of creating new type for it? I'm concerned about the final readability in the code, for example: ```ts const useProps: ExtractPropTypes<typeof props, true> = {} ``` It's not really obvious what the second paramete...
2021-02-06T18:11:48
2021-02-06T18:11:48
{ "+1": 1 }
NONE
vuejs
core
774,675,004
3,186
LinusBorg
changes to `_obj` are not reactive. you have to go through the reactive proxy, `classState`
2021-02-07T13:31:46
2021-02-07T13:31:46
{ "+1": 1 }
MEMBER
vuejs
core
773,758,154
2,015
mayuxian
@unbyte `<teleport to='#elementId'>` don`t work https://github.com/vuejs/vue-next/issues/3142#issue-798032619 Should this problem should be fixed?
2021-02-05T03:21:23
2021-02-05T03:21:23
{}
NONE
vuejs
core
774,494,458
3,173
HcySunYang
Only call `removeAttribute` when the element does not have any class. In other cases, `className` is used. I think it's fine.
2021-02-06T15:30:56
2021-02-06T15:30:56
{}
MEMBER
vuejs
core
774,653,129
3,183
LinusBorg
It's a Bug in the compiler that doesn't differentiate between type exports and runtime exports. As a workaround, you can use `import type { Ref } from 'vue'` to import types explicitly as types.
2021-02-07T10:52:22
2021-02-07T10:52:22
{ "+1": 11 }
MEMBER
vuejs
core
772,622,452
3,070
HcySunYang
@Akryum How about this https://github.com/vuejs/vue-next/pull/2902, it supports hooks from mixin/extend.
2021-02-03T16:06:18
2021-02-03T16:06:18
{}
MEMBER
vuejs
core
773,819,723
3,166
dependabot-preview[bot]
One of your CI runs failed on this pull request, so Dependabot won't merge it. - [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/12098?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) Dependabot will still automatically merge this pull request if you amend it and your tes...
2021-02-05T06:19:56
2021-02-05T06:19:56
{}
CONTRIBUTOR
vuejs
core
774,531,064
3,178
plc-dev
Ah gotcha, thanks for pointing it out!
2021-02-06T19:40:18
2021-02-06T19:40:18
{}
NONE
vuejs
core
773,722,253
2,280
github-actions[bot]
## Size report | Path | Size | | -------------------------- | -------------------- | | vue.global.prod.js | 40.65 KB (+0.23% 🔺) | | runtime-dom.global.prod.js | 26.98 KB (+0.13% 🔺) | | size-check.global.prod.js | 16.49 KB (+1.09% 🔺) |
2021-02-05T01:41:49
2021-02-05T02:02:42
{}
NONE
vuejs
core
773,768,296
3,039
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-05T03:49:40
2021-02-05T03:51:52
{}
NONE
vuejs
core
773,818,833
3,167
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-05T06:17:56
2021-02-05T06:17:56
{}
NONE
vuejs
core
773,819,416
3,168
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-05T06:19:20
2021-02-05T06:19:20
{}
NONE
vuejs
core
774,222,658
1,600
LinusBorg
@evan Would like your input on this before marking it as ready to merge.
2021-02-05T18:54:03
2021-02-05T18:54:03
{ "+1": 1, "rocket": 1 }
MEMBER
vuejs
core
774,493,830
3,177
HcySunYang
Duplicate of https://github.com/vuejs/vue-next/issues/2843
2021-02-06T15:26:39
2021-02-06T15:26:39
{}
MEMBER
vuejs
core
774,677,718
3,186
HcySunYang
As @LinusBorg said, you should always operate the proxy object, rather than the original object, see: https://codesandbox.io/s/festive-swartz-rygqi?file=/src/index.ts
2021-02-07T13:50:57
2021-02-07T13:50:57
{}
MEMBER
vuejs
core
772,392,187
2,687
realityfilter
This is still a problem in 3.0.4 with classes with private fields. Version 3.0.2 is working. Vue 2 with composition api, too. Short Example: ```vue class X { a: string; private b: string; } import { defineComponent, PropType, toRefs } from 'vue'; export default defineComponent({ name: 'TestX', ...
2021-02-03T10:10:04
2021-02-03T10:10:04
{}
NONE
vuejs
core
772,740,722
2,758
LinusBorg
@fnlctrl Does this PR have any advantage over the earlier #2589 ?
2021-02-03T18:56:38
2021-02-03T18:56:38
{}
MEMBER
vuejs
core
772,986,806
3,131
eli-crow
Submitted my first RFC here: https://github.com/vuejs/rfcs/pull/262 Feel free to close this issue.
2021-02-04T02:50:04
2021-02-04T02:50:04
{}
NONE
vuejs
core
773,819,568
3,169
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-05T06:19:37
2021-02-05T06:19:37
{}
NONE
vuejs
core
774,628,582
2,625
yangmingshan
@posva Can we move this PR forward?
2021-02-07T07:42:59
2021-02-07T07:42:59
{}
CONTRIBUTOR
vuejs
core
774,651,702
3,184
HcySunYang
CI failed due to E2E testing
2021-02-07T10:42:15
2021-02-07T10:42:15
{}
MEMBER
vuejs
core
774,665,114
3,181
LinusBorg
package.json has the filename wrong. PR sent.
2021-02-07T12:17:50
2021-02-07T12:17:50
{}
MEMBER
vuejs
core
772,270,983
3,153
HcySunYang
The demo you provided cannot reproduce your problem, I ran: ``` npm i npm run build ``` then start the static server to serve the dist folder, I got the following: ![image](https://user-images.githubusercontent.com/14146560/106707763-b9fea680-662c-11eb-9a68-9233c0897248.png)
2021-02-03T06:33:52
2021-02-03T06:33:52
{}
MEMBER
vuejs
core
773,083,457
2,280
HcySunYang
> @HcySunYang can you fix the conflicts? yes, but I need to re-review this PR by myself.
2021-02-04T07:04:33
2021-02-04T07:04:33
{}
MEMBER
vuejs
core
773,500,488
3,106
LinusBorg
@HcySunYang which priority label is this? More of a common situation or an edge case?
2021-02-04T18:04:08
2021-02-04T18:04:08
{}
MEMBER
vuejs
core
773,818,584
3,166
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-05T06:17:21
2021-02-05T06:17:21
{}
NONE
vuejs
core
774,653,438
3,183
HcySunYang
Is it related to vite? https://github.com/vitejs/vite/issues/1661
2021-02-07T10:54:53
2021-02-07T10:54:53
{}
MEMBER
vuejs
core
774,665,148
3,185
github-actions[bot]
## Size report | Path | Size | | -------------------------- | ------------- | | vue.global.prod.js | 40.56 KB (0%) | | runtime-dom.global.prod.js | 26.95 KB (0%) | | size-check.global.prod.js | 16.31 KB (0%) |
2021-02-07T12:17:59
2021-02-07T12:17:59
{}
NONE
vuejs
core
772,303,085
2,830
dependabot-preview[bot]
Superseded by #3154.
2021-02-03T07:38:06
2021-02-03T07:38:06
{}
CONTRIBUTOR
vuejs
core
773,677,693
2,938
HcySunYang
@cexbrayat thank you
2021-02-04T23:45:18
2021-02-04T23:45:18
{}
MEMBER
vuejs
core
773,746,362
3,113
HcySunYang
Closed because it is trivial
2021-02-05T02:48:16
2021-02-05T02:48:16
{}
MEMBER
vuejs
core
774,385,128
3,173
wenfangdu
@HcySunYang ```html <template> <div :style="false" :class="false" :foo="false"> Lorem ipsum dolor sit amet, consectetur adipisicing elit. Laudantium modi repudiandae, illum sequi nemo est deleniti optio distinctio quaerat quasi dolores vitae aspernatur quisquam, voluptatibus quibusdam ullam, ipsum ...
2021-02-06T02:49:30
2021-02-06T02:49:53
{}
NONE
vuejs
core
763,278,609
2,975
yangmingshan
It's necessary for https://github.com/vuejs/vue-next/pull/2616/files#diff-bef066f3036cebd9b6db8a01d40f6eb0fdfe71c06da414b7d226652c016d7efdR658, otherwise TS will report error.
2021-01-20T02:11:21
2021-02-07T07:37:29
{}
CONTRIBUTOR
vuejs
core
570,531,843
574
sqal
@posva of course, here's an example of what I do all the time when writing components in plain JS ```js function render() { return h('div', [ // isOpen is boolean props.isOpen && h('div', []) ]) } ```
2020-01-03T10:26:15
2020-01-03T10:27:07
{}
CONTRIBUTOR
vuejs
core
574,400,294
618
yyx990803
This is an intended behavior change, and necessary for Vue 3's new template optimization strategy. For components like this, you can still use explicit keys to force the reuse. Alternatively, you can have a computed property that computes the props to pass to `<gsm-select>` instead of relying on `v-if`.
2020-01-14T22:16:35
2020-01-14T22:16:35
{}
MEMBER
vuejs
core
574,400,399
618
yyx990803
Note: we should document this behavior change.
2020-01-14T22:16:50
2020-01-14T22:16:50
{ "+1": 2 }
MEMBER
vuejs
core
575,980,817
637
underfin
Year.The implementation has diffrent with sfc.
2020-01-19T08:44:45
2020-01-19T08:44:45
{}
MEMBER
vuejs
core
570,639,943
575
sqal
I fully understand that :) I was just playing with the alpha today and noticed that this feature is not implemented so I thought I'd open a new issue and maybe someone with free time who would like to contribute to vue 3 can add this feature.
2020-01-03T17:27:39
2020-01-03T17:29:12
{ "+1": 26 }
CONTRIBUTOR
vuejs
core
572,359,904
597
nmsmith
In `collectionHandlers.ts`, the add() function seems to unwrap the "value" before insertion, but the deleteEntry() does not unwrap the "key" (which for sets, is also the value). The issue may be caused by this asymmetrical handling: it seems these functions are supposed to be generic over both Sets and Maps?
2020-01-09T02:58:16
2020-01-09T02:58:16
{ "+1": 1 }
NONE
vuejs
core
573,268,692
609
underfin
You should use `ref` or `reactive` api to make the data is observed in v3.
2020-01-11T02:00:02
2020-01-11T02:00:02
{ "+1": 1 }
MEMBER
vuejs
core
574,685,707
619
yyx990803
This is intentional (`=== true` is stricter)
2020-01-15T14:33:12
2020-01-15T14:33:12
{}
MEMBER
vuejs
core
576,367,246
643
yyyanghj
> Thanks, but the `isSVGTag` utility should be used in compiler only (it bloats runtime size). A proper fix is landed in [035b656](https://github.com/vuejs/vue-next/commit/035b6560f7eb64ce940ed0d06e19086ad9a3890f) But this example still doesn't work ``` const App = { template: ` <div id="App"> <svg ...
2020-01-20T17:20:51
2020-01-20T17:20:51
{}
CONTRIBUTOR
vuejs
core
571,114,381
583
KaelWD
I think this would be fine if they were converted back to kebab-case in the DOM, but they get lowercased instead.
2020-01-06T12:03:09
2020-01-06T12:03:09
{}
CONTRIBUTOR
vuejs
core
571,319,055
587
yyx990803
Thanks!
2020-01-06T21:19:24
2020-01-06T21:19:24
{}
MEMBER
vuejs
core
573,274,425
609
sys-keys
The issue is that your `this` in `increment` is refering to the unproxied state object so vue does not track changes made through it. [Working version here](https://jsfiddle.net/trehw76m/)
2020-01-11T03:08:16
2020-01-11T03:09:36
{ "+1": 1 }
NONE
vuejs
core
573,494,699
608
yangmingshan
@posva I agree. And I think there needs to be some way to let people know about this, before they run into it, document maybe (in the future)?
2020-01-13T03:21:21
2020-01-13T03:21:21
{}
CONTRIBUTOR
vuejs
core
576,765,420
643
yyx990803
Good catch! Addressed in 4f06eeb
2020-01-21T16:33:04
2020-01-21T16:33:04
{}
MEMBER
vuejs
core
577,207,973
652
yyx990803
Technically these global types should not be part of `@vue/test-runtime` anyway, so I moved them.
2020-01-22T14:31:29
2020-01-22T14:31:29
{}
MEMBER
vuejs
core
577,560,772
617
LinusBorg
Feature additions require an RFC. You can use an issue in that repo to first discuss merits before writing a full RFC. https://github.com/vuejs/rfcs
2020-01-23T07:59:17
2020-01-23T07:59:17
{}
MEMBER
vuejs
core
570,468,004
572
decademoon
Also I want to mention that the issue helper website doesn't let you pick any version for `vue-next` which blocks creating any issues using the form.
2020-01-03T05:33:16
2020-01-03T05:33:16
{}
NONE
vuejs
core
570,615,668
572
ThaDaVos
@decademoon -> this link? https://new-issue.vuejs.org/?repo=vuejs/vue-next You'll have to fill in the version yourself as far as I can see
2020-01-03T16:04:26
2020-01-03T16:04:26
{}
NONE
vuejs
core
570,706,142
577
yyx990803
This technically doesn't matter, since `createVNode` is not tree-shakable (it's going to be used regardless) and `_ctx` will be dropped by the minifier. Removing them is purely aesthetic but would need more code in the compiler.
2020-01-03T21:39:02
2020-01-03T21:39:28
{}
MEMBER
vuejs
core
570,717,356
572
decademoon
@ThaDaVos It's working now.
2020-01-03T22:28:25
2020-01-03T22:28:25
{}
NONE
vuejs
core
572,610,795
603
vue-bot
Hello, thank you for taking time filling this issue! However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic...
2020-01-09T15:26:07
2020-01-09T15:26:07
{}
CONTRIBUTOR
vuejs
core
573,625,667
608
posva
How did you personally run into it and do you have any idea of other ways people will run into it? This will helps us to find the place it fits in the docs. Since most people won't use that syntax naturally nor by following the guide, it needs to be in the right place to be effective
2020-01-13T11:46:53
2020-01-13T11:46:53
{}
MEMBER
vuejs
core
573,897,028
598
yyx990803
👍
2020-01-13T22:11:56
2020-01-13T22:11:56
{}
MEMBER
vuejs
core
573,897,367
602
yyx990803
Thanks!
2020-01-13T22:12:53
2020-01-13T22:12:53
{}
MEMBER
vuejs
core
574,081,263
608
posva
I see 😆 To me this is the kind of cases most people won't hit and when they do, they should be able to find a forum post or issue with the reasoning. Putting it on the docs as a tip adds mental overhead that will be useless to most users and it's something we are avoiding and, instead, trying to integrate the expla...
2020-01-14T09:23:33
2020-01-14T09:23:33
{ "+1": 3 }
MEMBER
vuejs
core
575,979,585
637
CaiPeng1989
> ` createApp().mount(App, '#app')` The default code is like this. But, [Global API Change](https://github.com/vuejs/vue-next/issues/30) said: ``` import { createApp } from 'vue' import App from './App.vue' const app = createApp(App) app.config.ignoredElements = [/^app-/] app.use(/* ... */) app.mixin...
2020-01-19T08:28:28
2020-01-19T08:28:28
{}
NONE
vuejs
core
576,409,632
643
yyx990803
Should be fixed in f2ac28b
2020-01-20T19:49:01
2020-01-20T19:49:01
{}
MEMBER
vuejs
core
571,224,865
573
yyx990803
Thanks, however we need to preserve the `()` for non-multi-statement cases so that the handler returns the value of the inner expression. See 137893a
2020-01-06T17:13:00
2020-01-06T17:13:00
{}
MEMBER
vuejs
core
572,898,956
606
vue-bot
Hello, thank you for taking time filling this issue! However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic...
2020-01-10T06:52:04
2020-01-10T06:52:04
{}
CONTRIBUTOR
vuejs
core
574,838,294
623
Gregg
I got it wrong... a Dep is a set of Effects.
2020-01-15T20:18:08
2020-01-15T20:18:08
{}
NONE
vuejs
core
576,331,075
635
yyx990803
Now that I think about it, simply returning an array containing the values of all triggered handlers would make sense. It'd be best to submit an RFC for this though: https://github.com/vuejs/rfcs
2020-01-20T15:48:59
2020-01-20T15:48:59
{ "+1": 3 }
MEMBER
vuejs
core
577,248,698
653
yyx990803
👍
2020-01-22T15:45:33
2020-01-22T15:45:33
{}
MEMBER
vuejs
core
570,951,044
582
Mario-Brendel
Thanks a lot, posva! This actually solves the issue :).
2020-01-05T21:46:17
2020-01-05T21:46:17
{}
NONE
vuejs
core
572,933,341
608
KaelWD
It saves creating two proxy instances if the argument isn't used. https://github.com/vuejs/vue-next/blob/b9479e2543fc24b65b6920bc9aaf17635d77f106/packages/runtime-core/src/component.ts#L442-L452
2020-01-10T08:46:23
2020-01-10T08:46:23
{}
CONTRIBUTOR
vuejs
core
576,347,471
637
yyx990803
The RFC PR had outdated summary (fixed)
2020-01-20T16:29:02
2020-01-20T16:29:02
{}
MEMBER
vuejs
core
572,437,443
593
underfin
You can do like this. ``` const app = Vue.createApp() app.mount(Root, document.getElementById('app')) setTimeout(() => { // equal to $destroy Vue.render(null, document.getElementById('app') ) }, 1000) ```
2020-01-09T07:55:10
2020-01-09T07:55:10
{ "+1": 5 }
MEMBER
vuejs
core
573,896,037
601
yyx990803
Looks like you have an IDE setup that automatically re-orders the imports, which makes the changes a bit messy. Can you try disabling that in future PRs? Thanks!
2020-01-13T22:09:18
2020-01-13T22:09:28
{}
MEMBER
vuejs
core
573,959,817
601
underfin
Yea.Thanks a lot.I will be pay attention to this.
2020-01-14T01:48:10
2020-01-14T01:48:10
{}
MEMBER
vuejs
core
574,621,397
604
cexbrayat
@yyx990803 I'm still running into this issue in `alpha.2` with a simple `v-else`: ```html <input id="role-input" v-model="user.role" /> <div id="else"> <div v-if="user.role === 'ADMIN'"> <h2>Admin</h2> </div> <div v-else> <h2 id="hello">Hello</h2> </div> <div id...
2020-01-15T11:35:49
2020-01-15T11:35:49
{}
MEMBER
vuejs
core
575,882,579
634
vue-bot
Hello, thank you for taking time filling this issue! However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic...
2020-01-18T09:32:46
2020-01-18T09:32:46
{}
CONTRIBUTOR
vuejs
core
575,977,464
637
underfin
You should run ` createApp().mount(App, '#app')`
2020-01-19T07:58:45
2020-01-19T07:58:45
{}
MEMBER
vuejs
core
575,982,296
637
underfin
Yea.It is works for current master code.
2020-01-19T09:02:50
2020-01-19T09:02:50
{}
MEMBER
vuejs
core
576,357,966
643
yyx990803
Thanks, but the `isSVGTag` utility should be used in compiler only (it bloats runtime size). A proper fix is landed in 035b656
2020-01-20T16:55:35
2020-01-20T16:55:35
{}
MEMBER
vuejs
core
576,484,086
647
0xPoe
Sorry, I ignored some implicit type conversion rules. How about this: ```js const array2 = ref([1, new Map<string, any>(), ref('1')]).value for (let i = 0; i < array2.length; i++) { if (typeof array2[i] === 'string') { array2[i] += 'foo' } else if (typeof array2[i] === 'number') { ...
2020-01-21T01:47:32
2020-01-21T01:47:32
{}
CONTRIBUTOR
vuejs
core
570,635,462
575
ThaDaVos
@sqal - don't forget, VueJs 3 is still Alpha, it's far from finished and as far as I know, only contains what's needed to get it up to par with VueJs 3 (as it is a rewrite) - I'm also hoping for the implementation for this but I think we just have to wait for VueJs 3 to be finished
2020-01-03T17:11:33
2020-01-03T17:11:33
{ "-1": 38 }
NONE
vuejs
core
571,470,262
591
dependabot-preview[bot]
One of your CI runs failed on this pull request, so Dependabot won't merge it. - [ci/circleci: test](https://circleci.com/gh/vuejs/vue-next/1830?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) Dependabot will still automatically merge this pull request if you amend it and your test...
2020-01-07T07:30:06
2020-01-07T07:30:06
{}
CONTRIBUTOR
vuejs
core
572,931,669
594
hsxfjames
See [non-null-assertion-operator](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-0.html#non-null-assertion-operator).
2020-01-10T08:41:50
2020-01-10T08:41:50
{}
NONE
vuejs
core
574,426,661
618
sirlancelot
Ah, I also found #18 which has some better strategies than what I'm currently employing. I'll probably adjust to building a single computed prop. Thanks!
2020-01-14T23:42:28
2020-01-14T23:42:28
{}
NONE
vuejs
core
576,500,475
643
yyyanghj
> Should be fixed in [f2ac28b](https://github.com/vuejs/vue-next/commit/f2ac28b31e9f1e8ebcd68ca9a1e8ea29653b0916) I think we should do something with `<foreignObject>` . ``` const App = { template: ` <div id="App"> <svg width="200" height="200"> <foreignObject> <div></div> ...
2020-01-21T03:16:34
2020-01-21T03:16:34
{}
CONTRIBUTOR
vuejs
core
571,073,899
287
MBearo
try to use yarn instead of npm
2020-01-06T09:47:45
2020-01-07T03:26:02
{ "+1": 1 }
NONE
vuejs
core
571,944,607
594
cyyjs
😆
2020-01-08T08:34:42
2020-01-08T08:34:42
{}
NONE
vuejs
core
571,971,632
594
ununian
ts的optional chaining
2020-01-08T09:47:46
2020-01-08T09:47:46
{}
NONE
vuejs
core
572,165,520
585
yyx990803
I think effects triggered in the same tick should still run so the check is unnecessary.
2020-01-08T17:08:54
2020-01-08T17:08:54
{}
MEMBER
vuejs
core
573,265,590
594
limingzhiguang
> See [non-null-assertion-operator](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-0.html#non-null-assertion-operator). thank you very much!
2020-01-11T01:30:35
2020-01-11T01:30:35
{}
NONE
vuejs
core
574,689,678
621
yyx990803
Thanks for the PR. In general, `set` is called much much less often than `get`. There can be thousands of `get` calls during an update, but usually only a few `set` calls when the user performs some interaction with the UI. So `set` is almost never the performance bottleneck and checking the access cache for `set` is u...
2020-01-15T14:42:09
2020-01-15T14:42:09
{}
MEMBER
vuejs
core
575,981,103
637
CaiPeng1989
So we need to write code like this: ``` import { createApp } from 'vue' import App from './App.vue' const app = createApp() app.config.ignoredElements = [/^app-/] app.use(/* ... */) app.mixin(/* ... */) app.component(/* ... */) app.directive(/* ... */) app.mount(App, '#app') ```
2020-01-19T08:48:41
2020-01-19T08:48:41
{}
NONE
vuejs
core
576,346,702
640
yyx990803
I think it's better to use per-test timeouts as specified here: https://github.com/facebook/jest/issues/5055#issuecomment-350827560
2020-01-20T16:27:13
2020-01-20T16:27:13
{}
MEMBER
vuejs
core
576,411,317
647
yyx990803
It was written intentionally to test the type inference by narrowing the type with conditional branches.
2020-01-20T19:55:11
2020-01-20T19:55:11
{}
MEMBER
vuejs
core
570,890,614
581
vue-bot
Hello, thank you for taking time filling this issue! However, we kindly ask you to use our [Issue Helper](https://new-issue.vuejs.org/?repo=vuejs/vue-next) when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatic...
2020-01-05T08:53:01
2020-01-05T08:53:01
{}
CONTRIBUTOR
vuejs
core
572,438,888
593
underfin
Maybe should add some api like `unmount`.
2020-01-09T07:59:21
2020-01-09T07:59:21
{}
MEMBER
vuejs
core
575,387,368
630
yyx990803
Can you add a test case for this? Can be in `vIf.spec.ts` and simply assert the snapshot.
2020-01-16T23:01:16
2020-01-16T23:01:16
{}
MEMBER