owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 842,487,999 | 3,785 | posva | I'm not sure this is a bug or by design: only direct-children (e.g. the div that is wrapping `Comp`) trigger the hook | 2021-05-17T17:05:20 | 2021-05-17T17:05:20 | {} | MEMBER |
vuejs | core | 843,134,514 | 3,789 | HcySunYang | @pikax ok | 2021-05-18T12:37:09 | 2021-05-18T12:37:09 | {} | MEMBER |
vuejs | core | 844,250,514 | 3,796 | posva | You might want to open a PR. But you will need to explain yourself (in English) Ines off just post pictures | 2021-05-19T16:08:32 | 2021-05-19T16:08:32 | {} | MEMBER |
vuejs | core | 845,079,431 | 3,802 | Justineo | It seemed you have configured a custom option merge strategy via `app.config.optionMergeStrategies` but it's not a function.
---
Next time, please use the [forum](http://forum.vuejs.org/) or the [Discord chat](https://vue-land.js.org/) to ask questions. | 2021-05-20T12:45:11 | 2021-05-20T12:45:11 | {} | MEMBER |
vuejs | core | 845,113,801 | 3,802 | tomassimanaitis | No, I haven't. But thanks for the answer, I will use the forum from now on | 2021-05-20T13:19:11 | 2021-05-20T13:19:11 | {} | NONE |
vuejs | core | 845,620,235 | 3,806 | HcySunYang | Hint: the root cause is that when jobs in `PostFlushCbs` are executed, the new pre-flush job may still be queued to `PreFlushCbs`. This issue may have the same reason as https://github.com/vuejs/vue-next/issues/2730 | 2021-05-21T03:11:55 | 2021-05-21T03:13:55 | {} | MEMBER |
vuejs | core | 845,719,842 | 3,809 | hyf0 | It's not a bug rather a normal behavior. View Updating is because changing of `shallowReactiveState.name = 'zmj'` not `shallowReactiveState.age.number = 1000`
Try this.
https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPlxuICAgPGRpdiBpZD0nYXBwJz5cbiAgICBuYW1lOnt7c2hhbGxvd1JlYWN0aXZlU3RhdGUubmFtZX19XG4gICAgPGRpdj48... | 2021-05-21T07:16:53 | 2021-05-21T07:18:51 | {} | CONTRIBUTOR |
vuejs | core | 838,054,778 | 3,758 | posva | Open a new issue with a boiled down reproduction at https://sfc.vuejs.org
See https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro | 2021-05-11T08:20:26 | 2021-05-11T08:20:26 | {} | MEMBER |
vuejs | core | 839,793,743 | 3,747 | Gavin-Gong | > This can be specified on the user side, e.g. https://github.com/vuejs/vue-next/blob/master/packages/runtime-test/src/index.ts#L16-L17
When we want to custom render, you can specify `HostElement` type。But once we comsume `runtime-dom`'s API to write web app，`HostElement` type should be specified in Vue internal, e.... | 2021-05-12T13:56:30 | 2021-05-12T14:29:37 | {} | CONTRIBUTOR |
vuejs | core | 840,665,259 | 3,695 | ais-one | Hi,
I think this should be escalated and not flagged as a P3-monor-bug...
https://github.com/vueComponent/ant-design-vue/issues/3998#issuecomment-840341390
The number of warnings increases as the number of components on the page increases...
| 2021-05-13T16:10:17 | 2021-05-13T16:10:17 | {
"+1": 2
} | NONE |
vuejs | core | 841,106,799 | 3,774 | HcySunYang | Duplicate of https://github.com/vuejs/vue-next/pull/3473/files | 2021-05-14T08:46:17 | 2021-05-14T08:46:17 | {} | MEMBER |
vuejs | core | 841,184,825 | 3,775 | Justineo | It's an intentional breaking change. See our [migration guide](https://v3.vuejs.org/guide/migration/global-api-treeshaking.html#global-api-treeshaking). | 2021-05-14T11:25:30 | 2021-05-14T11:25:30 | {} | MEMBER |
vuejs | core | 841,484,038 | 1,813 | m4heshd | @Aurelius333 I realized that minutes after posting the above. I agree. Docs should mention that. Either way I'm still using `<teleport>` inside `#app` with mounted validation for the root component. Works perfectly fine.
In my case, there's no alternative because I'm writing an Electron app that has a title bar whi... | 2021-05-14T20:28:10 | 2021-05-14T20:28:10 | {
"+1": 4
} | NONE |
vuejs | core | 843,684,756 | 3,792 | Giwayume | I don't think adding a directive to every web component instantiation is a good workaround, especially if the entire app is built around those components. | 2021-05-19T01:54:52 | 2021-05-19T01:54:52 | {
"+1": 1
} | NONE |
vuejs | core | 845,635,688 | 2,137 | hyf0 | I don't consider it as a bug or something need to fix. That's how it should be. It looks similar to #3653.
| 2021-05-21T03:59:37 | 2021-05-21T03:59:37 | {} | CONTRIBUTOR |
vuejs | core | 845,905,214 | 3,812 | wellrus | @iheyunfei
It looks like a clarification of the fix required.
Check latest chrome
```
let arr = [];
const MAX_VALID_ARRAY_LENGTH = 4294967295; // Math.pow(2, 32) - 1
// correct array length
arr = [];
arr[MAX_VALID_ARRAY_LENGTH - 1] = true;
console.log(arr.length);
if (arr.length === MAX_VAL... | 2021-05-21T12:08:33 | 2021-05-21T12:10:47 | {} | NONE |
vuejs | core | 846,296,859 | 3,792 | liamdebeasi | Good question! So we have `reflect` enabled for some but not all of the properties in our components. For example, we have some properties like `disabled` in `ion-button` that have reflect enabled: https://github.com/ionic-team/ionic-framework/blob/master/core/src/components/button/button.tsx#L50-L63
This lets devel... | 2021-05-21T22:43:04 | 2021-05-21T22:43:04 | {} | NONE |
vuejs | core | 846,388,222 | 3,813 | jacekkarczmarczyk | Where is this behaviour described in docs? I can't find anything about it, neither in the guide/api reference nor in the migration guide. | 2021-05-22T10:26:20 | 2021-05-22T10:26:20 | {} | CONTRIBUTOR |
vuejs | core | 846,428,765 | 3,811 | HcySunYang | I cloned the project you provided, and then:
```js
npm i
yarn build
serve dist
```
Everything is working fine, please make sure to provide a valid reproduction | 2021-05-22T16:04:46 | 2021-05-22T16:04:46 | {} | MEMBER |
vuejs | core | 840,869,836 | 3,767 | yyx990803 | FYI for the following case:
```html
<Comp>
<template #header> Header </template>
<template #footer> Footer </template>
</Comp>
```
we should not generate the default slot because it contains only whitespace so the `isNonWhitespaceContent` check should be moved up. (see https://github.com/vuejs/vue-next/p... | 2021-05-13T22:24:06 | 2021-05-13T22:24:06 | {} | MEMBER |
vuejs | core | 841,200,089 | 3,655 | Bigfish8 | Thanks, I have done. | 2021-05-14T12:01:44 | 2021-05-14T12:01:44 | {} | CONTRIBUTOR |
vuejs | core | 846,294,296 | 3,792 | LinusBorg | @liamdebeasi Awesome, thanks!
PS: I did an edit while you replied, please check it. | 2021-05-21T22:33:25 | 2021-05-21T22:33:25 | {} | MEMBER |
vuejs | core | 846,437,023 | 3,815 | hyf0 | This is caused by the feature auto unwrap refs on public instance `data` .
type of `data` will be put in `UnwrapNestedRefs<Data>`, which will deeply unwrap the `data` object. So your type 'Foo' will be put in ` { [K in keyof T]: UnwrapRefSimple<T[K]> }` as `T`.
After putting, type `Foo` will become `{ readonly... | 2021-05-22T17:08:33 | 2021-05-22T18:15:44 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 846,488,234 | 3,811 | Justineo | 如果 push 不上 GitHub，可以把最小化复现提交到 Gitee 试一下。满足提 issue 的条件以后开一个新的 issue，谢谢。 | 2021-05-23T01:50:07 | 2021-05-23T01:50:07 | {} | MEMBER |
vuejs | core | 846,496,710 | 3,815 | hyf0 | @tonyfinn You can also use `this.$data.foo`, whose type is `Foo`. Nevertheless, that will disable `auto unwrapping` in type and cause inconsistency between static type and runtime type. | 2021-05-23T03:43:43 | 2021-05-23T03:43:43 | {} | CONTRIBUTOR |
vuejs | core | 839,819,142 | 3,764 | Gavin-Gong | `ShadowRoot` is very special, when we want to mount to `ShawRoot`, the `HostElement` could be `Element` or `SVGElement`, so add a genirc argument called `RootHostElement` to pass and specify `rootContainer` type, also set `HostElement` as `RootHostElement`'s default value.
Another solution, just one line code. but... | 2021-05-12T14:28:56 | 2021-05-12T14:35:34 | {} | CONTRIBUTOR |
vuejs | core | 840,116,822 | 3,732 | dependabot[bot] | OK, I won't notify you again about this release, but will get in touch when a new version is available.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it. | 2021-05-12T21:45:08 | 2021-05-12T21:45:08 | {} | CONTRIBUTOR |
vuejs | core | 840,996,166 | 3,773 | HcySunYang | You should use the `app.config.errorHandler` to register an error handling function for the first App:
```js
const app = createApp({
setup() {
watchEffect(() => {
throw ""
}, { flush: 'post' })
},
render() {
return 'asdf'
}
})
// here
app.config.error... | 2021-05-14T04:20:06 | 2021-05-14T06:56:12 | {} | MEMBER |
vuejs | core | 841,861,656 | 2,389 | Valter4o | Hey
I was intrigued as well by the changes to the effectApi and `cleanup()` addition. I haven't gotten to the point where I need them in a project ( surely I will do soon ) but I really think that the differences in the API's would be a struggle for the every devs that want to use them
I get that there is a diffe... | 2021-05-16T19:01:31 | 2021-05-16T19:05:56 | {} | NONE |
vuejs | core | 842,523,487 | 3,786 | yyx990803 | Why not just actually register it as `@touchstart.passive`? That's what the warning is about. You **should** use passive touch event listeners.
I don't see a point in providing a way to do `passive: false` since its only purpose is to intentionally suppress a warning with worse performance for end users? | 2021-05-17T18:02:37 | 2021-05-17T18:02:37 | {} | MEMBER |
vuejs | core | 845,655,288 | 2,138 | hyf0 | The situation looks similar to #3653. I'm also not convinced that it should be fixed.
I don't think this is a common use case. I think this PR should be revert and pending for not getting enough feedback of real world use case. I'm deeply worried that this PR can't be reverted for causing breaking change in the f... | 2021-05-21T05:04:12 | 2021-05-21T05:04:12 | {} | CONTRIBUTOR |
vuejs | core | 846,457,621 | 3,813 | jods4 | @jacekkarczmarczyk I found out about this feature by reading the code. I don't think I ever saw it mentioned in docs.
I'd say it's rather logical and nice to have, when you bind a `type=number` you kind of expect its value to be a number, don't you?
A bit like when you bind a `type=checkbox` you get a boolean.
A... | 2021-05-22T20:09:25 | 2021-05-22T20:09:25 | {} | CONTRIBUTOR |
vuejs | core | 846,483,023 | 3,811 | hearsay316 | 
我的 node 版本是 v12.22.1
系统版本 window10 20H2
我还发现这个只在于 引用的异步函数.
写成这个调用,打包就是有dom生成的,非常匪夷所思,整... | 2021-05-23T00:51:55 | 2021-05-23T00:51:55 | {} | NONE |
vuejs | core | 846,300,697 | 3,792 | LinusBorg | The reasoning for the way the virtualdom handles this is a result of two points, basically:
1. With the move to a flat vnode structure, we could unlock important perf and memory usage improvements compared to the Vue 2 vdom. But a flat vdom also means we no longer can differentiate at the vnode level between props m... | 2021-05-21T22:58:15 | 2021-05-21T22:59:30 | {} | MEMBER |
vuejs | core | 840,864,577 | 3,769 | AlttiRi | It works as expected in Firefox, but it does not work in Chromium. | 2021-05-13T22:10:51 | 2021-05-13T22:19:12 | {} | NONE |
vuejs | core | 840,870,557 | 3,769 | yyx990803 | You can't combine `contenteditable` with Vue controlled DOM output. Vue can only manipulate the DOM assuming it's not going to be mutated by other sources (wether `contenteditable` or direct DOM manipulation code) | 2021-05-13T22:26:14 | 2021-05-13T22:26:14 | {} | MEMBER |
vuejs | core | 845,709,428 | 3,695 | wenfangdu | This is quite annoying, please fix this ASAP 🙏.
| 2021-05-21T06:59:49 | 2021-05-21T06:59:49 | {
"+1": 4
} | NONE |
vuejs | core | 845,865,982 | 3,809 | littlekie | > deep data change does not **trigger** watch, but it is still a data change (e.g. `shallowReactiveState.age.number` is still modified). So if anyone tries to **pull** the data, he will see the 1000 rather than the original 99.
>
> Then there is the scope of DOM update. There are optimizations built in so that Vue d... | 2021-05-21T10:53:19 | 2021-05-21T10:53:19 | {} | NONE |
vuejs | core | 846,354,538 | 3,794 | cokemine | https://github.com/vuejs/vue-router-next/issues/560 | 2021-05-22T05:41:39 | 2021-05-22T05:41:39 | {} | NONE |
vuejs | core | 791,211,725 | 3,361 | kevinvalk | Thanks for the information! I thought that solution (re-emitting event `@event="(depth) => $emit('event', depth)"`) was suboptimal because of call stack depth and performance reasons. For posterity: I was partially wrong on that front https://webkit.org/blog/6240/ecmascript-6-proper-tail-calls-in-webkit/
TL;DR; If y... | 2021-03-05T07:18:12 | 2021-03-05T09:16:36 | {} | NONE |
vuejs | core | 791,924,748 | 3,377 | LinusBorg | I added a test but would like input if there are more scenarios to cover. | 2021-03-06T12:00:43 | 2021-03-06T12:00:43 | {} | MEMBER |
vuejs | core | 792,298,922 | 3,357 | 07akioni | Workaround
```
prop: xxx
=>
prop: {
type: xxx,
default: undefined
}
``` | 2021-03-07T15:43:38 | 2021-03-07T15:43:38 | {} | CONTRIBUTOR |
vuejs | core | 792,514,607 | 3,388 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.89 KB (0%) |
| runtime-dom.global.prod.js | 27.16 KB (0%) |
| size-check.global.prod.js | 16.47 KB (0%) | | 2021-03-08T06:47:50 | 2021-03-08T06:47:50 | {} | NONE |
vuejs | core | 793,684,801 | 3,367 | johnsoncodehk | @gertqin I need to avoid use vue 3 helper types to support others like `Vue.extends` / `@vue/composition-api` / `vue-class-component` etc, so I would like to do this:
```ts
type LocalComponents = typeof myComponent extends { components?: infer C } ? C : unknown;
// LocalComponents = { "OtherComponent": typeof Othe... | 2021-03-09T10:31:15 | 2021-03-09T10:45:23 | {} | MEMBER |
vuejs | core | 794,758,757 | 3,266 | HcySunYang | fixed | 2021-03-10T02:28:15 | 2021-03-10T02:28:15 | {} | MEMBER |
vuejs | core | 794,936,533 | 3,249 | little-buddy | I think so. | 2021-03-10T06:03:48 | 2021-03-10T06:03:48 | {} | NONE |
vuejs | core | 794,972,108 | 3,227 | LinusBorg | Was already working on a solution, got a bit stumped by some Type confusion on my side. Will give it another go now though. | 2021-03-10T06:41:50 | 2021-03-10T06:41:50 | {} | MEMBER |
vuejs | core | 791,217,703 | 3,361 | HcySunYang | Yeah, I did also aware of the problem. I think I should reopen this issue for further discussion. | 2021-03-05T07:29:28 | 2021-03-05T07:29:28 | {} | MEMBER |
vuejs | core | 792,527,631 | 3,382 | Kingbultsea | The third is also fragment too, Why is it a bug... | 2021-03-08T07:11:21 | 2021-03-08T07:11:21 | {} | CONTRIBUTOR |
vuejs | core | 793,024,415 | 3,390 | posva | You have a typo: `errorTypes0`
---
Please, next time consider using the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js) for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂 | 2021-03-08T19:45:00 | 2021-03-08T19:45:00 | {} | MEMBER |
vuejs | core | 793,989,055 | 3,129 | posva | There is a similar open PR for Vue 2 at https://github.com/vuejs/vue/pull/9484 that should also be merged if this gets aproved | 2021-03-09T14:44:09 | 2021-03-09T14:44:09 | {} | MEMBER |
vuejs | core | 794,883,107 | 3,325 | HcySunYang | Cosed, like @LinusBorg said, don't use lies to verify lies, so don't use the wrong usage to verify the unexpected. Warnings don’t mean you don’t need to pay attention, you should fix it. | 2021-03-10T04:59:50 | 2021-03-10T04:59:50 | {} | MEMBER |
vuejs | core | 795,080,280 | 2,738 | kuanyui | This issue still exists even if using an arrow function as the validator of a prop. (vue 3.0.7, typescript 4.2.3)
, the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js). | 2021-03-04T14:44:03 | 2021-03-04T14:44:03 | {} | MEMBER |
vuejs | core | 791,446,900 | 3,368 | posva | Provide the editable codepen please: https://codepen.io/jh3y/pen/PoGbxLp | 2021-03-05T14:17:43 | 2021-03-05T14:17:43 | {} | MEMBER |
vuejs | core | 791,773,799 | 3,374 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | -------------------- |
| vue.global.prod.js | 40.89 KB (+0.35% 🔺) |
| runtime-dom.global.prod.js | 27.16 KB (+0.3% 🔺) |
| size-check.global.prod.js | 16.47 KB (+0.41% 🔺) | | 2021-03-05T23:00:09 | 2021-03-05T23:21:14 | {} | NONE |
vuejs | core | 791,881,231 | 3,119 | 07akioni | fix #3357 | 2021-03-06T06:11:30 | 2021-03-06T06:11:38 | {} | CONTRIBUTOR |
vuejs | core | 791,962,612 | 3,373 | sreenaths | Started discussion @ https://github.com/vuejs/rfcs/discussions/276 | 2021-03-06T14:33:40 | 2021-03-06T14:33:40 | {} | NONE |
vuejs | core | 792,537,239 | 3,382 | LinusBorg | > In this case, I think it is worth mentioning this in the manual, since at the moment it is very difficult to come to this conclusion after reading the manual.
A few paragraphs down the same manual page:
https://vue-loader.vuejs.org/guide/scoped-css.html#child-component-root-elements
> With `scoped`, the pare... | 2021-03-08T07:28:06 | 2021-03-08T07:28:58 | {} | MEMBER |
vuejs | core | 794,802,394 | 3,382 | HcySunYang | This will be fixed in https://github.com/vuejs/vue-next/pull/3374 | 2021-03-10T03:20:15 | 2021-03-10T03:20:15 | {} | MEMBER |
vuejs | core | 795,105,357 | 727 | takechihorn | Hi
I'm currently struggling to invoke this Suspense function for Vitesse SSR App in server side. (App:https://github.com/frandiox/vitesse-ssr-template)
Are there any better effects to use Suspense in server side rather than in client side.
I confirmed Suspense is available in client side, but HTML Component surroun... | 2021-03-10T08:52:55 | 2021-03-10T08:52:55 | {} | NONE |
vuejs | core | 791,153,956 | 3,365 | HcySunYang | This can also be fixed in #3363 | 2021-03-05T04:57:54 | 2021-03-05T04:57:54 | {} | MEMBER |
vuejs | core | 792,297,716 | 3,378 | posva | The only difference would be being able to use the `??` operator if the value was `null` instead of an empty string, but you still have a way to verify if an input is empty by just comparing it to the empty string. Unfortunately, this would be a breaking change now. It's still fairly subjective and would need to go thr... | 2021-03-07T15:35:14 | 2021-03-07T15:35:14 | {
"confused": 6
} | MEMBER |
vuejs | core | 793,445,795 | 3,397 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.89 KB (0%) |
| runtime-dom.global.prod.js | 27.16 KB (0%) |
| size-check.global.prod.js | 16.47 KB (0%) | | 2021-03-09T06:14:46 | 2021-03-09T06:14:46 | {} | NONE |
vuejs | core | 794,941,663 | 3,354 | dependabot-preview[bot] | Superseded by #3401. | 2021-03-10T06:09:29 | 2021-03-10T06:09:29 | {} | CONTRIBUTOR |
vuejs | core | 795,211,438 | 3,399 | pikax | > We also need `ComponentCustomComponents` (global components).
Maybe a better name would be good, any suggestions? | 2021-03-10T10:27:08 | 2021-03-10T10:27:08 | {} | MEMBER |
vuejs | core | 790,632,668 | 3,345 | flozero | If it's something that the user should be aware sure close it and thanks for your answers :) | 2021-03-04T13:52:16 | 2021-03-04T13:52:16 | {} | NONE |
vuejs | core | 790,768,876 | 3,348 | 07akioni | > I can get your point, I'm discussing how to solve this kind of needs. I have a two ideas, just hint here:
>
> 1. Proxy the `vnode.props`
>
> Intercept the user's operations on `vnode.props`, so that we can correctly adjust the corresponding `patchFlags` and `dynamicProps`. But this brings extra `VNode creation`... | 2021-03-04T17:00:44 | 2021-03-04T17:00:44 | {} | CONTRIBUTOR |
vuejs | core | 792,518,313 | 3,379 | HcySunYang | You should use `createSSRApp` in `browser.js`:
```js
createSSRApp(Main()).mount(document.getElementById('app'))
```
For that workaround, yes, that’s because the default behavior of webpack is that [the `module` field has a higher priority](https://webpack.js.org/configuration/resolve/#resolvemainfields).
| 2021-03-08T06:54:38 | 2021-03-08T06:54:38 | {} | MEMBER |
vuejs | core | 794,944,089 | 3,402 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.89 KB (0%) |
| runtime-dom.global.prod.js | 27.16 KB (0%) |
| size-check.global.prod.js | 16.47 KB (0%) | | 2021-03-10T06:12:05 | 2021-03-10T06:12:05 | {} | NONE |
vuejs | core | 795,137,866 | 727 | posva | Hi @takechihorn, you can ask questions on the [forum](http://forum.vuejs.org/), the [Discord server](https://vue-land.js.org/) or [StackOverflow](http://stackoverflow.com/tags/vue.js). | 2021-03-10T09:21:32 | 2021-03-10T09:21:32 | {} | MEMBER |
vuejs | core | 791,891,295 | 3,371 | SaavyGirl | On Fri, Mar 5, 2021 at 11:53 PM edison <notifications@github.com> wrote:
> you should
>
> const register = (isVisible) => {
> console.log("useRelocatableParent - register");
> const index = nextIndex++;
>
> // like this
> registeredEntries.value[index] = { isVisible: isVisible.value };
> return inde... | 2021-03-06T07:51:20 | 2021-03-06T11:08:06 | {} | NONE |
vuejs | core | 791,961,977 | 3,373 | sreenaths | Thanks @LinusBorg
I agree that I should have demonstrated it without using bind. The intention behind the following lines was just to bypass hasOwn check. Technically `.bind is irrelevant`.
```
this.onAdd = this.onAdd.bind(this);
this.onSubtract = this.onSubtract.bind(this);
```
Following is the same... | 2021-03-06T14:28:22 | 2021-03-06T14:28:22 | {} | NONE |
vuejs | core | 792,298,802 | 3,119 | 07akioni | @HcySunYang Code is reviewed | 2021-03-07T15:42:43 | 2021-03-07T15:42:43 | {} | CONTRIBUTOR |
vuejs | core | 791,185,401 | 3,366 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.74 KB (0%) |
| runtime-dom.global.prod.js | 27.08 KB (0%) |
| size-check.global.prod.js | 16.4 KB (0%) | | 2021-03-05T06:18:03 | 2021-03-05T06:18:03 | {} | NONE |
vuejs | core | 792,295,221 | 3,385 | posva | Using `flush: 'sync'` could avoid multiple renders | 2021-03-07T15:18:01 | 2021-03-07T15:18:01 | {
"+1": 1
} | MEMBER |
vuejs | core | 792,522,726 | 3,382 | LinusBorg | the first two examples are expected, even though they are admittedly non-ideal. Why:
In Vue 2, every component had a root node, and scoped styles were specifically designed to also be apply-able to a child component's root node in order to control .e. it's positioning from the parent.
However in Vue 3, we know ha... | 2021-03-08T07:02:45 | 2021-03-08T07:02:45 | {
"eyes": 1
} | MEMBER |
vuejs | core | 792,551,593 | 3,382 | mixalbl4-127 | Some thoughts: I think you will not be able to make the same logic for the Composition API, since the compiler cannot know how many root components will be returned until the component is mounted. It is not up to the compiler to decide during the build process. | 2021-03-08T07:53:37 | 2021-03-08T07:53:37 | {} | NONE |
vuejs | core | 793,091,867 | 3,391 | posva | This is intended. The Foo component never gets to render again and so the watcher isn't triggered. The opposite would be a problem because it will lead to wasted renders as the components would get swapped out right after. This is described in the documentation at https://v3.vuejs.org/guide/change-detection.html#async-... | 2021-03-08T21:27:57 | 2021-03-08T23:24:11 | {} | MEMBER |
vuejs | core | 793,445,175 | 3,396 | github-actions[bot] | ## Size report
| Path | Size |
| -------------------------- | ------------- |
| vue.global.prod.js | 40.89 KB (0%) |
| runtime-dom.global.prod.js | 27.16 KB (0%) |
| size-check.global.prod.js | 16.47 KB (0%) | | 2021-03-09T06:13:22 | 2021-03-09T06:13:22 | {} | NONE |
vuejs | core | 793,485,756 | 3,367 | HcySunYang | Hi @johnsoncodehk , @gertqin . Can you two share more context or information? Let me know what we should do. Thanks~ | 2021-03-09T07:34:53 | 2021-03-09T07:34:53 | {} | MEMBER |
vuejs | core | 794,720,094 | 3,227 | edison1105 | `onLeave` is an Array | 2021-03-10T01:44:19 | 2021-03-10T01:47:43 | {} | MEMBER |
vuejs | core | 791,127,637 | 3,362 | HcySunYang | Yeah, by default if the boolean props are absent then they will be cast to `false`, but we still need to raise a warning if it is `required`. | 2021-03-05T03:36:52 | 2021-03-05T03:36:52 | {} | MEMBER |
vuejs | core | 791,913,935 | 3,371 | LinusBorg | To get the smaller issue out of cleared up: wrapping a computed in `readonly` doesn't make much sense as its readonly already. But nonetheless we should probably not have it break.
*Should likely be handled in a separate issue.* (-> #3376, PR: #3377)
The thing we should concentrate on here is that, yes, it's wei... | 2021-03-06T11:08:16 | 2021-03-06T12:15:27 | {
"+1": 1
} | MEMBER |
vuejs | core | 792,531,840 | 3,382 | LinusBorg | Because the style is applied, when it shouldn't be applied to fragments at all. | 2021-03-08T07:18:36 | 2021-03-08T07:18:36 | {} | MEMBER |
vuejs | core | 792,570,830 | 3,382 | mixalbl4-127 | @Kingbultsea better when "only second", but in first and second itteration its not same
if (isFirst.value) res.push(h("div", { class: "tst", key: 1 }, "first"));
if (isSecond.v... | 2021-03-08T08:24:24 | 2021-03-08T08:25:43 | {
"heart": 1
} | NONE |
vuejs | core | 792,554,794 | 3,183 | yoyoys | @LinusBorg
The problem is I didn't install prettier as dependency.
(I thought that `eslint-plugin-prettier` has the dependency)
Everything is okay right now, sorry for that. | 2021-03-08T07:58:51 | 2021-03-08T12:09:11 | {} | NONE |
vuejs | core | 792,981,496 | 3,389 | posva | This is too much for a reproduction. It should have no TS (unless a type error), and no multi packages (lerna). Please boil it down and open a new issue so we can take a look | 2021-03-08T18:39:28 | 2021-03-08T18:39:28 | {} | MEMBER |
vuejs | core | 793,152,391 | 3,391 | Lilja | To further demonstrate why I think this is a problem and to give some more context of how this reflects my real world problem, I’ve written some code that is more applicable to my issue. Essentially, the logic that was inside of the outermost setTimeout inside Parent is inside the child component Foo.
```javascript... | 2021-03-08T23:04:20 | 2021-03-08T23:04:20 | {} | NONE |
vuejs | core | 794,210,135 | 3,266 | LinusBorg | @HcySunYang There's a conflict now. | 2021-03-09T17:36:10 | 2021-03-09T17:36:10 | {} | MEMBER |
vuejs | core | 794,805,212 | 3,400 | edison1105 | This way the performance will be lower | 2021-03-10T03:23:37 | 2021-03-10T03:23:37 | {} | MEMBER |
vuejs | core | 791,589,492 | 3,372 | posva | You need to write
```ts
const ComponentProps = {
msg: {
type: String as PropType<string>,
required: true
}
} as const
```
since you are declaring them outside of `defineComponent()` | 2021-03-05T18:06:45 | 2021-03-05T18:06:45 | {} | MEMBER |
vuejs | core | 791,911,707 | 3,373 | LinusBorg | Hey @sreenaths
thanks for doing this write-up! It's kinda cool that this works out of the box for the most part.
However, I don't see a real chance for this to become part of core.
Apart from style-preferences, the only advantage that you can bring up is that of avoiding duplicated functions because of their ... | 2021-03-06T10:54:43 | 2021-03-06T10:54:43 | {} | MEMBER |
vuejs | core | 791,935,039 | 3,368 | wzhzzmzzy | In CodePen, `onErrorCapture` in root could not catch the error that thrown by child.
But I tried `onErrorCapture` and `app.config.errorHandler` locally, they all can get it settled, both at ssr and csr.
Thanks a lot. | 2021-03-06T13:05:17 | 2021-03-06T13:05:17 | {} | NONE |
vuejs | core | 791,963,770 | 3,373 | LinusBorg | I think you kind of missed the point about how `bind()` is *required* regardless of `hasOwn`.
Here's a plan JS demo:
```js
class Store {
constructor() {
this.data = 'hello'
Object.assign(this, {
setData: this.setData
})
}
setData(v) { this.data = v }
}
const store = new Store()... | 2021-03-06T14:41:40 | 2021-03-06T14:52:54 | {} | MEMBER |
vuejs | core | 792,546,490 | 3,382 | mixalbl4-127 | @Kingbultsea
https://codesandbox.io/s/blissful-stallman-zdne1?file=/src/components/HelloWorld.vue
new example betwean same logic in tradition and composition API style.
@LinusBorg
ok, I understood. But my suggestion is to enable manual control of this behavior. Example:
new `scopedStyleStrategy` key with 3... | 2021-03-08T07:44:47 | 2021-03-08T07:44:47 | {} | NONE |
vuejs | core | 793,165,133 | 3,391 | posva | I updated my comment 😉
We have a [forum](http://forum.vuejs.org/), a [Discord server](https://vue-land.js.org/) to ask questions where people are very active and helpful! | 2021-03-08T23:25:20 | 2021-03-08T23:25:20 | {} | MEMBER |
vuejs | core | 793,341,700 | 3,393 | HcySunYang | Try this in your `vue.config.js`
```js
const { WebpackManifestPlugin } = require('webpack-manifest-plugin')
const nodeExternals = require('webpack-node-externals')
module.exports = {
chainWebpack: config => {
config.plugin('manifest').use(new WebpackManifestPlugin({ fileName: 'manifest.json' }))
... | 2021-03-09T03:51:01 | 2021-03-09T03:51:01 | {} | MEMBER |
vuejs | core | 794,812,311 | 3,400 | xiaofeng-bm | > This way the performance will be lower
OK， I know | 2021-03-10T03:32:07 | 2021-03-10T03:32:07 | {} | NONE |
vuejs | core | 795,098,283 | 2,474 | kuanyui | Still encountered the same issue even if following doc... (vue 3.0.7, typescript 4.2.3)
https://github.com/vuejs/vue-next/issues/2738#issuecomment-795080280 | 2021-03-10T08:46:15 | 2021-03-10T08:46:15 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.