Datasets:
open-index
/
open-github-issues

Dataset card Data Studio Files
xet
 Community
1
owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
1,550,109,711
8,303
arpowers
@xiaoxiangmoe good work! @edison1105 duplicated the issue here: https://github.com/arpowers/vite-example Is related to `tsx`
2023-05-16T17:47:56
2023-05-16T17:47:56
{}
NONE
vuejs
core
1,545,322,664
8,293
1739616529
> ![image](https://user-images.githubusercontent.com/32354856/237897723-2e9ad4f5-98cb-4764-bbf1-631f78913370.png) Maybe there is something wrong with the playground too i know because `toRefs`
2023-05-12T07:46:25
2023-05-12T07:46:25
{}
NONE
vuejs
core
1,544,184,473
4,294
so1ve
> can not get OtherProps > > ```ts > type OtherProps = Pick<InputProps, 'suffixIcon' | 'prefixIcon' | 'clearIcon'> > > export interface SearchProps extends OtherProps { > modelValue?: string | number; > placeholder?: string; > clearable?: boolean; > width?: string | number; > popoverCfg?: PopoverP...
2023-05-11T15:18:22
2023-05-12T11:40:25
{ "+1": 6 }
MEMBER
vuejs
core
1,546,715,253
8,307
auvred
`view` is [reserved html tag](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/view)
2023-05-13T17:27:03
2023-05-13T17:27:03
{}
CONTRIBUTOR
vuejs
core
1,548,865,236
8,326
kalvenschraut
I don't think it should matter about the extension TBH. Volar resolves to the file correctly when using go to definition. Also regardless Vue should not be failing to build if the type cannot be resolved.
2023-05-16T02:11:44
2023-05-16T02:13:02
{}
CONTRIBUTOR
vuejs
core
1,548,885,939
8,310
an501920078
There is also a BUG,` InstanceType<typeof genericComponent>,` which is also problematic ![Dingtalk_20230516104144](https://github.com/vuejs/core/assets/45625953/e370bf3a-ea31-4b76-8162-3f66b5bd2e77)
2023-05-16T02:42:08
2023-05-16T02:44:24
{ "+1": 2, "eyes": 1 }
NONE
vuejs
core
1,549,296,133
8,331
pikax
> @jd-solanki No, this is a different issue from vuejs/core#8310. @xiaoxiangmoe is the same error as #8310
2023-05-16T09:14:26
2023-05-16T09:14:26
{ "+1": 1 }
MEMBER
vuejs
core
1,550,046,227
7,030
dword-design
This seems to also be related https://github.com/vuejs/core/issues/6811. And this linked PR https://github.com/vuejs/core/pull/7009.
2023-05-16T17:01:36
2023-05-16T17:02:17
{}
NONE
vuejs
core
1,544,242,545
4,314
Buroni
This feature would also be useful as shadow DOM doesn't work with many popular libraries [such as plotly.js](https://www.webcomponents.org/element/ginkgobioworks/plotly-plot#:~:text=NOTE%3A%20The%20plotly.js%20library%20is%20incompatible%20with%20shadow%20DOM). I've wanted to use Vue 3's web components for several yea...
2023-05-11T15:50:23
2023-05-12T17:44:03
{ "+1": 4 }
NONE
vuejs
core
1,547,844,559
7,274
so1ve
FYI: I have made a small unplugin to make the code work. https://github.com/so1ve/unplugin-vue-tsx-auto-props
2023-05-15T13:16:46
2023-05-15T13:16:46
{ "heart": 1 }
MEMBER
vuejs
core
1,549,197,443
8,310
xiaoxiangmoe
@pikax 's demo is work as intended. @Anubarak Your demo is a Vue error, not work as intended and different with @pikax 's demo. Maybe we should create a separately issue.
2023-05-16T08:08:04
2023-05-16T08:09:01
{}
CONTRIBUTOR
vuejs
core
1,547,832,029
8,319
JorisAerts
> It seems that you should use the second parameter of defineComponent to pass it instead of assigning it directly. > > ```ts > import { defineComponent, h } from 'vue'; > > const props = { > text: { type: String, default: 'ok' }, > }; > > const component = defineComponent( > (props, { attrs }) => { >...
2023-05-15T13:09:02
2023-05-15T13:09:02
{}
NONE
vuejs
core
1,547,896,331
8,286
seahindeniz
The magical comment is not a good DX friendly solution, IMHO
2023-05-15T13:50:50
2023-05-15T13:50:50
{ "+1": 16 }
NONE
vuejs
core
1,549,128,277
8,310
xiaoxiangmoe
@an501920078 The problem you are having is not the same as the problem with pikax. It is recommended to file an issue separately.
2023-05-16T07:18:27
2023-05-16T07:18:27
{}
CONTRIBUTOR
vuejs
core
1,549,163,838
8,329
jacekkarczmarczyk
It's because your component is named "button". Don't name your components same like native dom elements, use two-words (or more) names for all your components
2023-05-16T07:44:38
2023-05-16T07:45:19
{}
CONTRIBUTOR
vuejs
core
1,549,551,012
6,951
rutgerbakker95
Any updates?
2023-05-16T12:15:53
2023-05-16T12:15:53
{ "eyes": 4 }
NONE
vuejs
core
1,545,329,466
8,294
baiwusanyu-c
Please give a repo link that can reproduce the problem. In addition, I think this may be caused by the lack of compatibility of downstream repo. I cannot confirm that it is a problem with vue. You can report this issue to `@vitejs/plugin-vue-jsx` and `element-plus` at the same time, and attach an issue link so that eac...
2023-05-12T07:52:30
2023-05-12T07:53:07
{}
MEMBER
vuejs
core
1,545,573,220
8,284
euaaaio
One more case: ### Vue version 3.3.1 ### Link to minimal reproduction https://play.vuejs.org/#eNqNVE2PmzAQ/SsjLiESwbvaW5REW0V76LmHPZSqSmEIbMG2bJMcIv57xx9NgCxpT4jn+XjvzdiX6IuU6anDaB1tdK5qaUCj6eQu43UrhTLwppRQ+4PJK1RQKtHCImVD0KYvxuFY7AX9cuRmnDI4CGkb5ttSQ/ox2MrmYJD+ADbDLg7JjMcGZZgPHTEiaMOupaIk8txW7UGmH1pwEntx5c...
2023-05-12T11:08:35
2023-05-12T11:10:51
{}
NONE
vuejs
core
1,547,024,451
8,310
morgan-willock
I'm having the same issue using `Vue@3.3.0` ```typescript type Props = { options: T[]; valueKey: keyof T; displayKey: keyof T; multiple?: boolean; closeMenu?: boolean; }; const props = withDefaults(defineProps<Props>(), { multiple: false, closeMenu: false, }); ``` ![Screenshot 2023-05...
2023-05-14T23:17:02
2023-05-14T23:17:02
{ "+1": 4 }
NONE
vuejs
core
1,547,286,803
8,317
Alfred-Skyblue
It seems to have been duplicated with #8314
2023-05-15T06:55:04
2023-05-15T06:55:04
{}
MEMBER
vuejs
core
1,549,443,227
8,334
sqal
It seems to be an issue with binding @once event. Your reproduction doesn't show any errors, If you look at [SFC Playground](https://play.vuejs.org/#eNqVVMGK2zAQ/ZXBFOJAGy89uk5oKT0VutAWevHFtZWNqC0JS/Z2WfLvOyONHQctxHsxozdvRtabJz0nX4zZjYNI8qSwdS+NAyvcYKCt1MO+TJwtk0OpZGd07+Cr7gwce93BZpfRgko3pQIoVa2VdeAEfvaQbmF/gKoVvUuxCYJ...
2023-05-16T10:58:42
2023-05-16T11:00:24
{}
CONTRIBUTOR
vuejs
core
1,549,856,969
8,326
kalvenschraut
I would say the problem is more so that vue is trying to do a relative resolve of an import that is inside of an external package. While this could work, would have to fix `resolveExt` to handle the various scenarios, I think the more ideal direction is to allow typescript resolve these relative imports if there ar...
2023-05-16T15:05:50
2023-05-16T15:42:46
{}
CONTRIBUTOR
vuejs
core
1,548,849,682
8,325
xiaoxiangmoe
This is work as intended For example: ```ts function someFunction<T extends string>( sameModel: T = 'sameModel default' ) { } ``` ``` Type 'string' is not assignable to type 'T'. 'string' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constra...
2023-05-16T01:51:45
2023-05-16T01:51:45
{}
CONTRIBUTOR
vuejs
core
1,549,801,299
8,326
kalvenschraut
Updated the repo to show this
2023-05-16T14:34:53
2023-05-16T14:46:24
{}
CONTRIBUTOR
vuejs
core
1,549,852,673
8,303
xiaoxiangmoe
@arpowers Do you use tsx or something else to run vite?
2023-05-16T15:03:33
2023-05-16T16:55:00
{}
CONTRIBUTOR
vuejs
core
1,545,295,232
8,289
Lehoczky
Yeah, but it would be better to keep the previous behaviour and introduce a deprecation warning after the new destructuring feature becomes stable and only then change the default compiler output. People would have a chance to react to this breaking change by doing it this way.
2023-05-12T07:22:20
2023-05-12T07:22:20
{}
NONE
vuejs
core
1,545,408,667
8,286
LeoFeng23
same problem
2023-05-12T08:55:38
2023-05-12T08:55:38
{}
NONE
vuejs
core
1,546,656,948
8,306
elonehoo
It seems that the ```vue v-model:is-open=" isWatchYouTubeEmployerTalkVideoModalOpen " ``` should be changed to ```vue v-model:is-open="isWatchYouTubeEmployerTalkVideoModalOpen" ```
2023-05-13T13:47:16
2023-05-13T13:47:16
{ "+1": 8, "heart": 1, "hooray": 1 }
NONE
vuejs
core
1,547,121,996
8,303
edison1105
Could you provide a runnable minimal reproduction?
2023-05-15T02:59:55
2023-05-15T02:59:55
{}
MEMBER
vuejs
core
1,549,247,515
8,310
Anubarak
> @pikax 's demo is work as intended. @Anubarak Your demo is a Vue error, not work as intended and different with @pikax 's demo. Maybe we should create a separately issue. Okay, there is already an issue but you closed it and the other issue referenced this one. That's why I thought we should continue here. Sorry m...
2023-05-16T08:42:40
2023-05-16T08:42:40
{}
NONE
vuejs
core
1,549,429,045
8,310
xiaoxiangmoe
```html <script setup lang="ts" generic="T extends { a: string }"> const props = withDefaults( defineProps<{ foo?: T; }>(), { foo: () => ({ a: '' }) }, ); const emit = defineEmits<{ (event: 'update:foo', foo: T): void; }>(); function onClick(){ emit('update:foo'...
2023-05-16T10:47:14
2023-05-16T10:57:25
{ "+1": 1 }
CONTRIBUTOR
vuejs
core
1,545,539,243
8,298
cccopilot
Additionally, if I replace the second template in `space.vue` with a div, an error occurs when I click the button. Like this: ``` <template> <div v-for="(child, index) in children" :key="index"> <component :is="child"></component> </div> </template> ```
2023-05-12T10:37:57
2023-05-12T10:37:57
{}
NONE
vuejs
core
1,546,165,188
8,214
TheSeg
I just fell into this bug as well. I expected `null`. The `""` makes the value a string. This means at runtime the variable is effectively `number | string` instead of `number` or `number | null`.
2023-05-12T19:08:49
2023-05-12T19:08:49
{}
NONE
vuejs
core
1,548,866,431
8,310
an501920078
Can't generic and withDefaults be used together?
2023-05-16T02:13:48
2023-05-16T02:13:48
{}
NONE
vuejs
core
1,549,222,331
8,331
xiaoxiangmoe
@jd-solanki No, this is a different issue from `vuejs/core#8310`.
2023-05-16T08:11:07
2023-05-16T08:11:50
{ "+1": 1 }
CONTRIBUTOR
vuejs
core
1,549,218,824
8,310
an501920078
> @an501920078 The problem you are having is not the same as the problem with pikax. It is recommended to file an issue separately. Sorry, because github where I am is unstable, so it is troublesome to submit it alone. Please check whether others have submitted this problem later
2023-05-16T08:23:02
2023-05-16T08:23:02
{}
NONE
vuejs
core
1,549,390,767
2,291
LunarLambda
It was fixed in https://github.com/vuejs/core/commit/78c199d6dbe8931520b75d8bfe0d49366a06922a, it seems like? The jsfiddle production link (which gets the latest version of vue via unpkg) in the issue description no longer shows the described behaviour
2023-05-16T10:18:09
2023-05-16T10:18:09
{}
NONE
vuejs
core
1,549,788,746
8,326
kalvenschraut
@edison1105 That doesn't change the problem. It didn't seem to affect the error so I didn't add any value to the ts file
2023-05-16T14:28:44
2023-05-16T14:28:44
{}
CONTRIBUTOR
vuejs
core
1,756,984,666
9,369
sadeghbarati
Composable usage restrictions - https://github.com/vuejs/core/discussions/7488 - https://vuejs.org/guide/reusability/composables.html#usage-restrictions You are using Date api which is defined in both `browser` and `node` environment --- You can create custom composable which return date only on `browser` or you ...
2023-10-11T07:06:55
2023-10-11T07:07:22
{}
NONE
vuejs
core
1,757,536,179
4,809
cyfung1031
@sxzz could someone review this PR and merge? almost 2 years ago. Just 17 lines.
2023-10-11T11:58:10
2023-10-11T11:59:12
{}
NONE
vuejs
core
1,760,046,486
9,389
Anoesj
Possibly the same as #6273? If it is, then I understand this is by design. How would one handle this case though: - Get huge array with large amounts of data from e.g. an API/JSON - Don't make the whole array recursively reactive (use a `shallowRef`), but let Vue know whenever it should rerender template content t...
2023-10-12T17:25:32
2023-10-12T17:25:32
{}
NONE
vuejs
core
1,761,492,633
9,397
LinusBorg
Your build process includes two copies of vue, from the two packages' node_modules https://vitejs.dev/config/shared-options.html#resolve-dedupe
2023-10-13T13:07:29
2023-10-13T13:07:29
{}
MEMBER
vuejs
core
1,761,731,649
9,399
pikax
/ecosystem-ci run
2023-10-13T15:46:20
2023-10-13T15:46:20
{ "+1": 1 }
MEMBER
vuejs
core
1,761,749,416
9,399
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6510313286) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6504201662) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-13T15:59:10
2023-10-13T15:59:10
{}
CONTRIBUTOR
vuejs
core
1,763,327,488
8,943
LinusBorg
Closing as no reproduction has been provided for the supposed problem
2023-10-15T09:02:30
2023-10-15T09:02:30
{}
MEMBER
vuejs
core
1,757,090,477
9,375
baiwusanyu-c
As @kaine0923 said
2023-10-11T08:14:48
2023-10-11T08:14:48
{}
MEMBER
vuejs
core
1,757,227,077
9,351
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6480303811) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6478163140) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-11T09:14:00
2023-10-11T09:14:00
{}
CONTRIBUTOR
vuejs
core
1,760,705,335
8,859
slavanossar
@posva Is it possible to get this tagged `p4-important` to align it with #6951? It's causing downstream issues in Nuxt that breaks `enter` page transitions on initial load. Thanks!
2023-10-13T03:25:42
2023-10-13T03:28:08
{ "+1": 1, "heart": 1 }
NONE
vuejs
core
1,761,009,447
9,388
edison1105
LGTM
2023-10-13T07:02:54
2023-10-13T07:02:54
{}
MEMBER
vuejs
core
1,761,172,123
9,394
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size |...
2023-10-13T09:04:13
2023-10-13T09:04:13
{}
NONE
vuejs
core
1,761,340,010
9,355
pikax
closing this PR, read reason [here](https://github.com/vuejs/core/pull/9355#discussion_r1358121909) Removing `__COMPAT__` here won't simplify anything and prevent from the branch from being excluded
2023-10-13T11:13:12
2023-10-13T11:13:12
{}
MEMBER
vuejs
core
1,764,130,729
9,383
pikax
`slots` looks to work: <img width="581" alt="image" src="https://github.com/vuejs/core/assets/4620458/2da82999-ac75-4dfa-9a0c-83f2d064934a"> I think this might be an issue with language tools /cc @johnsoncodehk
2023-10-16T09:59:18
2023-10-16T09:59:18
{}
MEMBER
vuejs
core
1,764,454,589
9,383
so1ve
Blocked by https://github.com/vuejs/language-tools/issues/3651, I opened https://github.com/vuejs/language-tools/pull/3671 to fix this issue temporarily
2023-10-16T13:10:07
2023-10-16T13:11:51
{}
MEMBER
vuejs
core
1,764,621,602
9,257
DawidKopys
What do you mean? I can use generics this way according to vue docs [here](https://vuejs.org/api/sfc-script-setup.html#generics).
2023-10-16T14:36:47
2023-10-16T14:36:47
{ "+1": 1 }
NONE
vuejs
core
1,756,032,893
9,372
skirtles-code
Maybe worth comparing to #8530.
2023-10-10T18:45:29
2023-10-10T18:45:29
{}
CONTRIBUTOR
vuejs
core
1,761,116,865
9,388
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6505699258) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6504201662) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-13T08:23:28
2023-10-13T08:23:28
{}
CONTRIBUTOR
vuejs
core
1,761,504,179
9,389
LinusBorg
I'll close this issue as it's not a bug. Feel free to reach out for more input in this repo's "Discussions" section or on our Discord chat.
2023-10-13T13:16:06
2023-10-13T13:16:06
{}
MEMBER
vuejs
core
1,758,925,852
7,966
edison1105
a note here: the root cause is that the suspense resolves before the fallback node is mounted. This caused component B to be unmounted twice, causing this issue when it was unmounted the second time.
2023-10-12T05:16:28
2023-10-12T05:16:28
{}
MEMBER
vuejs
core
1,759,211,906
9,384
baiwusanyu-c
I think it's better to move to discussion
2023-10-12T08:59:09
2023-10-12T08:59:09
{}
MEMBER
vuejs
core
1,757,051,988
9,370
Disservin
Nice, thanks!
2023-10-11T07:52:56
2023-10-11T07:52:56
{}
CONTRIBUTOR
vuejs
core
1,757,191,887
9,351
baiwusanyu-c
/ecosystem-ci run
2023-10-11T09:00:49
2023-10-11T09:00:49
{ "+1": 2 }
MEMBER
vuejs
core
1,761,111,723
9,383
haoqunjiang
`const slots = defineSlots<Record<T, () => any> & { footer(props: { id: number }): any}>();` doesn't work but `const slots = defineSlots<{ footer(props: { id: number }): any} & Record<T, () => any>>();` works. I guess this might be related to https://github.com/microsoft/TypeScript/issues/51092
2023-10-13T08:20:51
2023-10-13T08:20:51
{ "+1": 1 }
MEMBER
vuejs
core
1,761,187,531
8,376
pikax
I also got to the same point, with a simple helper ```ts export type MergeComponent<T, M> = T & M; // change return type MergeComponent< DefineComponent< PropsOptions, RawBindings, D, C, M, Mixin, Extends, E, EE /* These are not exported by Vue. DefineComponen...
2023-10-13T09:14:35
2023-10-13T09:14:35
{}
MEMBER
vuejs
core
1,761,196,985
8,320
edison1105
this is not the proper fix. It doesn't solve the root problem.see https://github.com/vuejs/core/pull/9392
2023-10-13T09:20:53
2023-10-13T09:20:53
{}
MEMBER
vuejs
core
1,761,404,452
9,389
Anoesj
Appreciate the fast reply! Could you eleborate on this immutable data pattern and how to apply it in Vue? Do you mean working with `readonly`? `Object.freeze`? Or more like https://vuejs.org/guide/extras/reactivity-in-depth.html#immutable-data?
2023-10-13T12:04:13
2023-10-13T12:04:13
{}
NONE
vuejs
core
1,761,909,815
8,376
KaelWD
I couldn't get either of these to work in the actual project, it always emits the resolved `new (...args: any[]): {...}` type even with the most minimal possible component.
2023-10-13T17:38:32
2023-10-13T17:38:32
{}
CONTRIBUTOR
vuejs
core
1,762,515,399
9,400
sxzz
Should we warn if there's a return statement inside of if branch? ```vue <script setup> import { ref } from 'vue' const msg = ref('Hello World!') if (msg.value !== '') return () => msg.value // never return </script> ``` The setup function is only called once, so most cases of `if + return statement`...
2023-10-14T02:57:33
2023-10-14T02:57:33
{}
MEMBER
vuejs
core
1,763,576,017
9,406
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size |...
2023-10-16T01:07:37
2023-10-16T01:07:37
{}
NONE
vuejs
core
1,763,960,448
9,108
pikax
> I believe we should offer comprehensive support for this, so that we can pass a function in situations where it's uncertain whether `tag` represents a component or an `HTMLElement`: I'm not saying otherwise, just saying this is a change of the current API, changing API is more cumbersome, there's typescript that n...
2023-10-16T08:15:41
2023-10-16T08:15:41
{}
MEMBER
vuejs
core
1,755,698,455
9,362
OBe95
Hello @ondrej-tesar-digital The issue is that you're using the `index` as `key` for the `Row` components and you're mutating the list of `recipients`, which causes the element on which the `dragStart` fired to be unmounted, thus no `dragEnd` event will be emitted If you try a unique key for each recipient, it shou...
2023-10-10T15:32:00
2023-10-10T15:32:00
{}
NONE
vuejs
core
1,761,457,220
9,389
LinusBorg
The latter. Its basically about not mutating objects, but instead always creating new copies that contain the changes from the previous version
2023-10-13T12:43:14
2023-10-13T12:43:14
{}
MEMBER
vuejs
core
1,761,945,973
9,108
pikax
Based on the comment on [h.ts](https://github.com/vuejs/core/blob/main/packages/runtime-core/src/h.ts#L24-L53) ```ts /* // type only h('div') // type + props h('div', {}) // type + omit props + children // Omit props does NOT support named slots h('div', []) // array h('div', 'foo') // text h('div', h(...
2023-10-13T17:52:32
2023-10-13T17:53:18
{}
MEMBER
vuejs
core
1,762,002,965
7,444
sadeghbarati
@rudyxu1102 Thanks for the PR Managed to test your PR It works with `defineComponent`(TS/TSX) way But in `.vue`(SFC) `useAttrs` does not accept any argument/generics ```ts const attrs = useAttrs<{ // Expected 0 type arguments, but got 1. bar: string }>() ```
2023-10-13T18:31:25
2023-10-13T18:31:25
{ "eyes": 1 }
NONE
vuejs
core
1,762,742,638
9,348
LinusBorg
A ClientOnly Component is pretty simple, basically render the slot only after mounted: [Playground Example](https://play.vuejs.org/#__SSR__eNp9Uk1P4zAU/CtvfWmRsolW3Ni00i5C2l1pAQESF19C8tIaHNvyRymK8t95dmjaIkC5xDPzkpnn6dkvY/JNQHbGSldbYTw49MEsuRKd0dZDDxbbDBpshcJzTaBC5TPQ6r8OymMDA7RWdzCjz8ymsXMpSHal5Msbmxd7KP6RpONTa+U8dG...
2023-10-14T08:41:26
2023-10-14T08:41:26
{}
MEMBER
vuejs
core
1,763,603,833
7,748
edison1105
LGTM
2023-10-16T01:48:19
2023-10-16T01:48:19
{}
MEMBER
vuejs
core
1,763,682,944
9,408
Alfred-Skyblue
`watchEffect` cannot be used to watch data within asynchronous queues. If you specifically need to watch a variable, you should use `watch`. If you use `watchEffect`, you need to access the variable before entering the asynchronous queue.
2023-10-16T03:51:07
2023-10-16T03:51:07
{}
MEMBER
vuejs
core
1,764,241,656
9,108
Alfred-Skyblue
https://github.com/vuejs/core/blob/2857a59e61c9955e15553180e7480aa40714151c/packages/runtime-core/src/h.ts#L108-L112 @pikax I see there are overloads for `Teleport` here.
2023-10-16T11:10:44
2023-10-16T11:10:44
{}
MEMBER
vuejs
core
1,759,973,612
4,809
LinusBorg
> This can already be achieved with `app.runWithContext(() => inject('key'))` so maybe it's not needed anymore I agree and will close this
2023-10-12T16:36:53
2023-10-12T16:36:53
{}
MEMBER
vuejs
core
1,760,293,433
8,804
shamrin
I've started a related discussion about JSDoc and `defineProps()` macro: https://github.com/vuejs/rfcs/discussions/584
2023-10-12T20:04:33
2023-10-12T20:04:33
{}
NONE
vuejs
core
1,761,087,828
8,376
pikax
Can't reproduce this locally, even when copying most of [defineComponent.tsx](https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/src/util/defineComponent.tsx) types and build them, they still get generated as expected with `vue-tsc` and `tsc`, I suspect the bad typing is caused by a misconfiguration on `...
2023-10-13T08:07:37
2023-10-13T08:07:37
{}
MEMBER
vuejs
core
1,761,091,878
9,388
pikax
/ecosystem-ci run
2023-10-13T08:10:32
2023-10-13T08:10:32
{ "+1": 2 }
MEMBER
vuejs
core
1,761,142,045
9,386
so1ve
Could you please transfer this issue to vuejs/language-tools?
2023-10-13T08:41:53
2023-10-13T08:41:53
{}
MEMBER
vuejs
core
1,761,175,918
9,386
galimovkirill
> Could you please transfer this issue to vuejs/language-tools? Done
2023-10-13T09:06:51
2023-10-13T09:06:51
{}
NONE
vuejs
core
1,761,408,180
9,336
pikax
@davidmatter looks good, but wondering why there's changes on the import order, can you rollback changes on the order please
2023-10-13T12:07:00
2023-10-13T12:07:00
{ "+1": 1, "eyes": 1 }
MEMBER
vuejs
core
1,761,637,951
9,343
sxzz
Duplicate of #8960
2023-10-13T14:42:46
2023-10-13T14:42:46
{}
MEMBER
vuejs
core
1,763,625,631
9,108
Alfred-Skyblue
@pikax I believe we should offer comprehensive support for this, so that we can pass a function in situations where it's uncertain whether `tag` represents a component or an `HTMLElement`: ```ts let tag: string | Component = 'div' h(tag, {}, () => 'hello world') ``` If we only support `Component`, the abov...
2023-10-16T02:22:30
2023-10-16T02:22:30
{}
MEMBER
vuejs
core
1,757,027,278
9,370
Disservin
Thanks for the pr, I cant test it right now but I assume that also fixes the issue of my reproduction right in #9264 and not only posva's ?
2023-10-11T07:37:00
2023-10-11T07:37:00
{}
CONTRIBUTOR
vuejs
core
1,760,291,584
6,854
shamrin
I've started a related discussion about JSDoc and `defineProps()` macro: https://github.com/vuejs/rfcs/discussions/584
2023-10-12T20:03:27
2023-10-12T20:03:27
{}
NONE
vuejs
core
1,760,712,095
9,383
edison1105
/cc @so1ve
2023-10-13T03:37:58
2023-10-13T03:37:58
{}
MEMBER
vuejs
core
1,761,323,576
9,372
pikax
New API's should have a [RFC](https://github.com/vuejs/rfcs) attached
2023-10-13T10:59:11
2023-10-13T10:59:11
{ "+1": 1 }
MEMBER
vuejs
core
1,762,671,578
9,400
pikax
> The setup function is only called once, so most cases of `if + return statement` are invalid and likely cause unexpected behaviors. I wouldn't call "invalid", they are likely to be incorrect, but I think that's a linter's job, not compiler, we don't know how people use it, if you add a warning we need a way to rem...
2023-10-14T07:03:13
2023-10-14T07:04:27
{ "+1": 2 }
MEMBER
vuejs
core
1,763,590,248
9,396
cess123456
Yes, these classes really shouldn't have been kept, but eventually he did, so this is a bug
2023-10-16T01:28:36
2023-10-16T01:28:36
{}
NONE
vuejs
core
1,758,076,797
9,379
haoqunjiang
/ecosystem-ci run
2023-10-11T16:34:24
2023-10-11T16:34:24
{ "+1": 1 }
MEMBER
vuejs
core
1,759,446,976
9,362
ondrej-tesar-digital
Oh wow. Thanks! @OBe95 And here I though for the first time the problem is not between the computer screen and the chair, but here I am 😄
2023-10-12T11:42:23
2023-10-12T11:42:23
{}
NONE
vuejs
core
1,759,531,920
9,387
Alfred-Skyblue
`Object.hasOwn` is a feature supported in Chrome version 93 and later. You can refer to its compatibility at https://caniuse.com/?search=Object.%20hasOwn
2023-10-12T12:36:22
2023-10-12T12:36:22
{}
MEMBER
vuejs
core
1,759,552,534
9,377
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size |...
2023-10-12T12:50:06
2023-10-12T12:50:06
{}
NONE
vuejs
core
1,760,681,370
9,380
haoqunjiang
Could be solved by https://github.com/vuejs/core/pull/5912
2023-10-13T02:47:05
2023-10-13T02:47:05
{}
MEMBER
vuejs
core
1,761,062,019
9,389
LinusBorg
This is by design, yes. The best way to deal with this scenario would likely be to use immutable data a la React etc.
2023-10-13T07:47:27
2023-10-13T07:47:27
{}
MEMBER
vuejs
core
1,761,346,803
9,343
pikax
@OBe95 can you add some tests pls
2023-10-13T11:18:49
2023-10-13T11:18:49
{}
MEMBER
vuejs
core
1,761,815,181
9,400
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size |...
2023-10-13T16:49:45
2023-10-13T16:49:45
{}
NONE