owner
stringclasses
14 values
repo
stringclasses
14 values
id
int64
116k
4.61B
issue_number
int32
1
181k
author
stringlengths
1
39
body
stringlengths
1
262k
created_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:16:18
updated_at
timestamp[us]date
2000-06-06 02:40:44
2026-06-02 20:22:56
reactions
unknown
author_association
stringclasses
5 values
vuejs
core
1,794,287,006
8,604
yang131323
There seems to be a problem with the type returned by the defineComponent function. The example is as follows: ``` tsx const TestCom = defineComponent((props) => { // ... }, { props: { name: { type: String, required: true, }, size: { type: Number, default: 16, },...
2023-11-06T08:17:30
2023-11-06T08:17:30
{}
NONE
vuejs
core
1,794,354,686
9,541
jacekkarczmarczyk
Duplicate of https://github.com/vuejs/core/issues/8465
2023-11-06T09:00:13
2023-11-06T09:00:13
{}
CONTRIBUTOR
vuejs
core
1,794,553,490
9,532
yyx990803
See https://github.com/vuejs/core/issues/9531#issuecomment-1794552371 I think the case you raised is still valid (although really an edge case)
2023-11-06T10:53:11
2023-11-06T10:53:11
{}
MEMBER
vuejs
core
1,790,611,965
7,290
edison1105
> I made a minimal reproduction of root cause of #6095 > > [playground link](https://play.vuejs.org/#eNqVU02PmzAQ/SuWLyEShWz3lpJIabWHVmq7avboC4JJ6l2wLX8kqVD+e2dMgKQfqxYJ4Zl5Y94bP3d8Y0x2CMCXvHCVlcYzBz6YtVCyNdp69kG3hu2sbtksyykg+Gwsd2wbnAHlIGVafdZBeahTZmHHzpe2Hi9UpZXzrC59yVYESGa0ns2pNrYmyZyt1qwTiuFDgOxQNgGwJcLf4lZnbCny...
2023-11-02T12:10:08
2023-11-02T12:16:46
{}
MEMBER
vuejs
core
1,792,621,366
9,528
Sublime1
Yes, you've convinced me of the correctness of your approach. In fact, I'm going to fork Prototype, and take a few security things that I saw in their PRs too. Then I won't even need sodatea's clever workaround. It will buy me a little more time before I inevitably have to migrate all my Prototype code to something mod...
2023-11-03T15:12:43
2023-11-03T15:12:43
{ "+1": 118, "heart": 19 }
NONE
vuejs
core
1,794,331,620
9,541
KUN1007
You are using `emit` incorrectly. `emit` is used for child components to send events to their parent components. Therefore, you need to declare the change function in the parent component. One more thing, you have defined an `unchange` function in the `Emit` interface. This means that in `emits('func', value)`, you...
2023-11-06T08:47:30
2023-11-06T08:50:00
{ "-1": 2 }
NONE
vuejs
core
1,784,638,629
5,955
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6689625947) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6688511870) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-30T07:41:37
2023-10-30T07:41:37
{}
CONTRIBUTOR
vuejs
core
1,787,380,597
3,962
MisterDr
Could you bump this one? So far this warning generated probably a few terabytes of logs.
2023-10-31T14:53:23
2023-10-31T14:53:23
{}
NONE
vuejs
core
1,789,469,268
9,528
haoqunjiang
In 3.2.46 we refactored the `ast.helpers` to a `Set` and used `Array.from` to get the helpers array. https://github.com/vuejs/core/pull/6774/files#diff-3990584204ce4ce4bd8dcd1e3172f04a8211ee56ec2cdd2dfde626d926610681R211 Prototype.js overwrites the `Array.from` method: http://api.prototypejs.org/language/Array/from...
2023-11-01T18:42:56
2023-11-01T18:42:56
{ "+1": 3, "heart": 3 }
MEMBER
vuejs
core
1,790,223,827
9,532
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------ | ------------------- | | runtime-dom.global.prod.js | 86.4 kB (**-7 B**) | 32.9 kB (**+5 B**) | 29.7 kB (**-9 B**) | | vue....
2023-11-02T07:44:49
2023-11-02T09:32:50
{}
NONE
vuejs
core
1,790,622,771
7,290
mmis1000
> > I made a minimal reproduction of root cause of #6095 > > [playground link](https://play.vuejs.org/#eNqVU02PmzAQ/SuWLyEShWz3lpJIabWHVmq7avboC4JJ6l2wLX8kqVD+e2dMgKQfqxYJ4Zl5Y94bP3d8Y0x2CMCXvHCVlcYzBz6YtVCyNdp69kG3hu2sbtksyykg+Gwsd2wbnAHlIGVafdZBeahTZmHHzpe2Hi9UpZXzrC59yVYESGa0ns2pNrYmyZyt1qwTiuFDgOxQNgGwJcLf4lZnbCny...
2023-11-02T12:18:11
2023-11-02T13:00:15
{}
CONTRIBUTOR
vuejs
core
1,792,858,197
9,493
haoqunjiang
Workaround: use a helper function ```ts const getLoopSlotName = (item) => `item:${item.key}`; ``` ```vue <Loop :items="items"> <template v-for="item in items" :key="item.key" #[getLoopSlotName(item)]="{ value }" > {{ value }} </template> </Loop> ```
2023-11-03T17:31:43
2023-11-03T17:31:43
{ "heart": 1 }
MEMBER
vuejs
core
1,793,402,864
9,497
skirtles-code
I have some concerns about this addition. Given this PR has already been merged into `minor`, I've started a separate discussion at <https://github.com/vuejs/rfcs/discussions/594>, rather than posting it all here.
2023-11-04T10:12:13
2023-11-04T10:12:13
{}
CONTRIBUTOR
vuejs
core
1,793,614,668
9,548
edison1105
see https://github.com/vuejs/core/pull/7216/files
2023-11-05T02:40:11
2023-11-05T02:40:11
{}
MEMBER
vuejs
core
1,794,356,929
9,541
KUN1007
> Code below seems to work > > ```ts > type Emits = BaseEmits & { > (e: 'unChange', id: number): void > } > ``` You're welcome! I didn't know about this usage either.
2023-11-06T09:01:40
2023-11-06T09:01:40
{}
NONE
vuejs
core
1,794,488,693
9,532
yyx990803
We haven't seen a real reproduction from the original reports, I'm not sure if this is caused by a real left bracket comment since that would be very unlikely in user code.
2023-11-06T10:13:56
2023-11-06T10:13:56
{}
MEMBER
vuejs
core
1,794,552,371
9,531
yyx990803
No real reproduction from users were provided, so we can only make the best guess. First of all, this is caused by #8859. Before #8859, this branch is only entered when there is a hydration mismatch where the client vnode is a comment (authored by the user in the template), but the DOM node being hydrated is not a c...
2023-11-06T10:52:30
2023-11-06T10:52:30
{ "+1": 2 }
MEMBER
vuejs
core
1,797,928,862
8,465
so1ve
Before the fix gets merged, you can use https://github.com/unplugin/unplugin-vue-complex-types as a temporal solution.
2023-11-07T07:06:57
2023-11-07T07:06:57
{}
MEMBER
vuejs
core
1,789,819,282
9,521
Seungwoo321
@deot thanks you I was also same issue. Your suggestions are useful.
2023-11-01T23:17:17
2023-11-01T23:27:00
{}
NONE
vuejs
core
1,793,139,890
8,952
louiss0
C'mon Vue and **TS NEED FULL SYNERGY**.
2023-11-03T21:45:26
2023-11-03T21:45:26
{ "laugh": 8 }
NONE
vuejs
core
1,785,694,592
9,508
LinusBorg
We can't investigate without a reproduction, let alone from *code screenshots*
2023-10-30T17:15:23
2023-10-30T17:15:33
{}
MEMBER
vuejs
core
1,790,524,696
7,290
mmis1000
I made a minimal reproduction of root cause of #6095 [playground link](https://play.vuejs.org/#eNqVU02PmzAQ/SuWLyEShWz3lpJIabWHVmq7avboC4JJ6l2wLX8kqVD+e2dMgKQfqxYJ4Zl5Y94bP3d8Y0x2CMCXvHCVlcYzBz6YtVCyNdp69kG3hu2sbtksyykg+Gwsd2wbnAHlIGVafdZBeahTZmHHzpe2Hi9UpZXzrC59yVYESGa0ns2pNrYmyZyt1qwTiuFDgOxQNgGwJcLf4lZnbCnyni4Sx...
2023-11-02T11:09:46
2023-11-02T11:19:03
{}
CONTRIBUTOR
vuejs
core
1,792,989,843
3,095
pikax
Closing as it's working on the latest main. <img width="594" alt="image" src="https://github.com/vuejs/core/assets/4620458/730a38d3-6550-4fb8-b677-a972b8612706">
2023-11-03T19:31:33
2023-11-03T19:31:33
{}
MEMBER
vuejs
core
1,793,109,285
8,591
pikax
duplicate of https://github.com/vuejs/core/issues/9335 Closing this one, because the other one has a PR attached.
2023-11-03T21:10:27
2023-11-03T21:10:27
{}
MEMBER
vuejs
core
1,787,689,203
7,836
sto3psl
@sxzz sure I can do that once the mentioned PR has landed. Is there any plan to reset the new tag list with am major update in the future? I assume that these won't stay new forever. Do people that have vue components with reserved names get a runtime warning?
2023-10-31T17:43:22
2023-10-31T17:43:22
{}
CONTRIBUTOR
vuejs
core
1,788,710,439
9,523
LinusBorg
Your problem is that your lib bundle inlcudes the Vue package, which you should have excluded from the build, as per the vite docs for its library mode: https://vitejs.dev/guide/build.html#library-mode <img width="619" alt="Bildschirmfoto 2023-11-01 um 11 11 15" src="https://github.com/vuejs/core/assets/1444526/...
2023-11-01T10:11:21
2023-11-01T10:11:21
{}
MEMBER
vuejs
core
1,783,953,570
6,463
edison1105
The problem is here: https://github.com/vuejs/core/blob/3be4e3cbe34b394096210897c1be8deeb6d748d8/packages/runtime-core/src/components/Suspense.ts#L211-L244 When the component is toggled before the pending tree is resolved, patching should not be performed. Instead, the logic under the "else" statement should be exec...
2023-10-29T00:37:39
2023-11-03T00:56:24
{}
MEMBER
vuejs
core
1,793,015,650
7,875
pikax
@browsnet if you could also provided proof of this is improving performance it would be great :)
2023-11-03T19:53:09
2023-11-03T19:53:09
{}
MEMBER
vuejs
core
1,797,111,929
9,531
edison1105
@yyx990803 @sodatea There is actually a reproduction for it [here](https://github.com/nuxt/nuxt/issues/23981#issuecomment-1788481043). Although it's quite complex, based on the debugging results, the `vnode.el` rendered on the client side is **indeed a comment node**. However, it has also been fixed by https://github...
2023-11-07T01:09:38
2023-11-07T01:12:09
{}
MEMBER
vuejs
core
1,786,092,269
9,510
jakebailey
Closing in favor of https://github.com/microsoft/TypeScript/pull/56265.
2023-10-30T21:41:07
2023-10-30T21:41:07
{}
NONE
vuejs
core
1,790,079,652
9,528
haoqunjiang
In case you need it: Putting the following lines before the first call to `createApp` fixes the issue: ```js const iframe = document.body.appendChild(document.createElement("iframe")); const iframeArray = iframe.contentWindow.Array; document.body.removeChild(iframe); Array.from = iframeArray.from ```
2023-11-02T05:11:55
2023-11-02T05:11:55
{ "+1": 12, "heart": 20 }
MEMBER
vuejs
core
1,791,760,054
6,463
edison1105
duplicate of https://github.com/vuejs/core/pull/6095
2023-11-03T00:57:53
2023-11-03T00:57:53
{}
MEMBER
vuejs
core
1,787,314,212
9,497
yyx990803
I'll keep this in mind when we update the docs for 3.4.
2023-10-31T14:19:32
2023-10-31T14:19:32
{ "+1": 1 }
MEMBER
vuejs
core
1,787,327,372
2,788
pikax
closing this as stale
2023-10-31T14:26:23
2023-10-31T14:26:23
{}
MEMBER
vuejs
core
1,789,369,430
9,529
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB | | vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB | ### Usages | Name | Size |...
2023-11-01T17:33:03
2023-11-01T17:33:03
{}
NONE
vuejs
core
1,790,238,910
9,531
edison1105
[simplified demo](https://play.vuejs.org/#__SSR__eNp9kDFPwzAQhf+K8dKlaYdulRUJUAcYAAEbXqLkElwc2/KdQ6Qo/x3bUQMD6nb33nendzfxW+d2QwB+5AJrrxwxBAqulEb1znpiE/PQspm13vZsE9GNNGK/sJGKDUHvdEUQO8ZEo4ZSoKtM2VobwVSJm6L4KIpS7JOb5tcZvuWEtTWt6nZntCYGmdIeyWvbO6XBPztS1qDkR5ad5FVa2+/HrJEPsL3o9SfUX//oZxyTJvmLBwQ/gOSrR5XvgBb79PYEY6xXs7dN0JG...
2023-11-02T07:58:05
2023-11-02T09:34:03
{}
MEMBER
vuejs
core
1,798,200,439
9,557
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 1af9e3031ddbda186d3af3b0846d7c43f7b4b7bf | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue...
2023-11-07T10:10:52
2023-11-07T10:12:07
{}
NONE
vuejs
core
1,786,275,230
9,511
johnsoncodehk
> This PR is meant to be against `v3.4.0-alpha.1` but as it is only a tag and not a branch, I had to go against `main` Thanks for following up! You can go against the `minor` branch, and I will help review the changes.
2023-10-31T01:05:28
2023-10-31T01:05:28
{}
MEMBER
vuejs
core
1,772,170,113
6,497
pikax
Closing this based on @sxzz comment. Numbers work as expected, they are converted to `string` internally [playground](https://play.vuejs.org/#eNp9UctOwzAQ/BXLlxYpSlT1VgISoB7gAAg4+hIl2+KS2Ja9CZWi/Du7bpMW8YgUyTszux7v9PLGubRrQa5kHkqvHYoA2LprZXTjrEfRC+dtpytIhIeNGMTG20bMqGc2ae5s4454mnHBI2eXyihzbJ4vErFYXCiTZ4dr6AIqEBpXFw...
2023-10-20T06:38:54
2023-10-20T06:38:54
{}
MEMBER
vuejs
core
1,772,005,771
8,986
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | c24462a1155fbf05cff2e84e937fe324fe0b34a9 | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue...
2023-10-20T03:07:14
2023-10-20T07:11:29
{}
NONE
vuejs
core
1,772,401,022
7,748
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6585881741) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6583567356) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-20T09:34:34
2023-10-20T09:34:34
{}
CONTRIBUTOR
vuejs
core
1,772,939,935
7,866
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size ...
2023-10-20T15:20:59
2023-10-20T15:20:59
{}
NONE
vuejs
core
1,772,363,866
9,443
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.4 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T09:09:21
2023-10-21T08:54:56
{}
NONE
vuejs
core
1,772,450,114
9,444
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T10:08:51
2023-10-20T10:08:51
{}
NONE
vuejs
core
1,772,555,766
8,304
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 2cf0678fc14fd7331f6d6da15881e19ebeb26290 | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue...
2023-10-20T11:19:27
2023-10-20T11:19:27
{}
NONE
vuejs
core
1,772,177,461
6,414
pikax
Closing as it's not needed
2023-10-20T06:46:14
2023-10-20T06:46:14
{}
MEMBER
vuejs
core
1,772,206,944
9,438
Disservin
Also might be good (not sure if you have the permissions) to add this to the project board ? https://github.com/orgs/vuejs/projects/13/views/1 as Ready to merge?
2023-10-20T07:14:09
2023-10-20T07:14:09
{}
CONTRIBUTOR
vuejs
core
1,772,215,456
9,438
sxzz
Merged. Thx!
2023-10-20T07:21:35
2023-10-20T07:21:35
{ "+1": 1 }
MEMBER
vuejs
core
1,772,551,340
8,304
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 2cf0678fc14fd7331f6d6da15881e19ebeb26290 | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s...
2023-10-20T11:15:45
2023-10-20T11:15:45
{}
NONE
vuejs
core
1,761,722,515
9,399
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------- | ------------------- | ------------------- | | runtime-dom.global.prod.js | 85.9 kB (**+26 B**) | 32.7 kB (**+9 B**) | 29.5 kB (**+36 B**) | ...
2023-10-13T15:39:32
2023-10-21T03:32:31
{}
NONE
vuejs
core
1,773,693,354
9,450
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.4 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-21T06:35:06
2023-10-21T06:35:06
{}
NONE
vuejs
core
1,772,220,974
7,282
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T07:26:06
2023-10-20T07:26:06
{}
NONE
vuejs
core
1,772,365,483
9,443
sxzz
/ecosystem-ci run
2023-10-20T09:10:30
2023-10-20T09:57:20
{ "+1": 1 }
MEMBER
vuejs
core
1,772,445,661
9,443
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6586192994) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6583567356) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-20T10:06:05
2023-10-20T10:06:05
{}
CONTRIBUTOR
vuejs
core
1,773,032,559
7,568
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------ | ------------------- | | runtime-dom.global.prod.js | 85.9 kB (**+7 B**) | 32.7 kB (**+3 B**) | 29.5 kB (**+16 B**) | | vue....
2023-10-20T16:21:13
2023-10-20T16:21:13
{}
NONE
vuejs
core
1,773,650,325
6,979
yyx990803
Some context: the reproduction in #6926 was deleted, but the cause of the original issue is that `useCssVars` codegen was only skipped for SSR + inline mode. So the code is still generated for non-inlined mode (only in webpack / vue-loader SSR setup), and the effect getter is run immediately in SSR, leading to the erro...
2023-10-21T04:03:53
2023-10-21T04:03:53
{}
MEMBER
vuejs
core
1,772,202,036
7,212
pikax
Closing this, because it has conflicts and it would be nice to go through issue first to get a better idea of the needed use case
2023-10-20T07:09:44
2023-10-20T07:09:44
{}
MEMBER
vuejs
core
1,772,311,121
8,032
pikax
duplicate of https://github.com/vuejs/core/pull/7938
2023-10-20T08:33:10
2023-10-20T08:33:10
{}
MEMBER
vuejs
core
1,772,374,070
9,442
edison1105
@pikax This is a playground problem, there is no problem locally. This is probably because `runtime` and `ssr` use the same `currentInstance` in the playground.
2023-10-20T09:16:24
2023-10-20T09:16:24
{ "+1": 1 }
MEMBER
vuejs
core
1,772,506,928
8,596
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T10:41:36
2023-10-20T10:41:36
{}
NONE
vuejs
core
1,772,785,295
5,912
leopiccionia
Would be the introduction of `WeakRef` a breaking change in regard to browser compatibility? It does not affect me personally, but I'm curious if Vue depends on another feature as new.
2023-10-20T13:54:58
2023-10-20T13:54:58
{ "eyes": 1 }
CONTRIBUTOR
vuejs
core
1,772,855,015
6,463
plcdnl
> Same issue for me with Nuxt 3.1.1. > > Changing line 35 of @vue/runtime-dom `runtime-dom.esm-bundler.js` to `parentNode: node => node ? node.parentNode : null,` seems to fix the issue though I am not sure what downstream effects this could have. Had the same problem in nuxt 3.8.0. Finally solved by patching in ...
2023-10-20T14:32:59
2023-10-20T14:32:59
{}
NONE
vuejs
core
1,772,451,713
5,912
johnsoncodehk
In order to solve the memory leak I mentioned in https://github.com/vuejs/core/issues/9233#issuecomment-1772122030, `WeakRef` will now be used for creating `computed` / `effect`..., resulting in some performance degradation, but for the reliability of downstream programs, the fix is ​​necessary. ~~Performance degrad...
2023-10-20T10:09:58
2023-10-20T18:56:26
{}
MEMBER
vuejs
core
1,772,227,771
9,419
LinusBorg
Yeah, I'm actually already convinced since looking at @skirtles-code 's fix, which would do what you ask for, for object keys and normal string based ones. Seems my mental model was off.
2023-10-20T07:31:05
2023-10-20T07:31:05
{ "laugh": 1 }
MEMBER
vuejs
core
1,772,332,899
7,018
sxzz
Related #9069
2023-10-20T08:48:02
2023-10-20T08:48:02
{}
MEMBER
vuejs
core
1,772,385,227
9,443
vue-bot
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6585736932) | suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6583567356) | |-------|--------|----------------| | language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a...
2023-10-20T09:23:41
2023-10-20T09:30:20
{}
CONTRIBUTOR
vuejs
core
1,772,241,557
7,364
pikax
@tinyfind can you provide answers for skirtles questions please? > Could you maybe explain how your proposed solution compares to the existing PRs for those two issues? > > * [fix(runtime-core): Fix cssvars reporting error when teleport is disabled #7341](https://github.com/vuejs/core/pull/7341) > * [fix(runt...
2023-10-20T07:41:50
2023-10-20T07:41:50
{}
MEMBER
vuejs
core
1,772,289,130
8,549
LinusBorg
Okay, seems I was too quick here. Thanks for getting back to me quickly. :)
2023-10-20T08:17:52
2023-10-20T08:17:52
{ "rocket": 2 }
MEMBER
vuejs
core
1,772,292,063
6,124
liulinboyi
> @liulinboyi do you have intentions in getting this PR ready to review or should it be closed? ok, i have no time to deal with it, i will close the PR.
2023-10-20T08:20:00
2023-10-20T08:20:00
{}
MEMBER
vuejs
core
1,772,347,636
8,510
pikax
Thank you for the PR I'll close this, because even though is nice to not use `as any` there are situations where it doesn't really make a difference, such as this.
2023-10-20T08:58:21
2023-10-20T08:58:21
{}
MEMBER
vuejs
core
1,772,442,069
9,249
yyx990803
The way we handle built-in HTML tags makes this technically a breaking change if someone was previously having a component named `search`. Right now: - If a tag is listed as built-in, it can't be registered as a component because the parser directly parses the tag as native. - If a tag is not listed as built-in bu...
2023-10-20T10:03:36
2023-10-20T10:03:36
{ "+1": 6 }
MEMBER
vuejs
core
1,772,533,613
8,596
netlify[bot]
### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed. | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 2c72be39082dde1986a1a80db86b5d662378f1cb | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue...
2023-10-20T11:01:55
2023-10-20T11:01:55
{}
NONE
vuejs
core
1,772,358,592
9,442
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T09:05:41
2023-10-20T11:02:05
{}
NONE
vuejs
core
1,773,613,818
9,249
lukewarlow
To provide a concrete example of more new tag names that might get added. https://open-ui.org/components/selectlist/ OpenUI is currently working on a new stylable select element, as part of that proposal at least 3 new Html elements are currently proposed to be added. And it's likely that more such elements will be add...
2023-10-21T02:28:53
2023-10-21T02:28:53
{}
NONE
vuejs
core
1,773,706,187
2,403
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.4 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-21T07:33:00
2023-10-21T07:33:00
{}
NONE
vuejs
core
1,772,180,499
6,338
pikax
Closing because there's no issue assign to it and is unclear what this will be solving, please create an detailed issue and then reopen or create a new PR if needed
2023-10-20T06:49:23
2023-10-20T06:49:23
{ "+1": 1 }
MEMBER
vuejs
core
1,772,186,143
6,692
pikax
Closing this because it does not have an issue assigned and based on skirtles is unclear the intention.
2023-10-20T06:55:03
2023-10-20T06:55:03
{}
MEMBER
vuejs
core
1,772,200,341
7,251
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-20T07:08:09
2023-10-20T07:08:09
{}
NONE
vuejs
core
1,772,278,057
7,582
pikax
Closing this, since its stale, if the problem is still present please create a detailed issue and then create another PR
2023-10-20T08:09:47
2023-10-20T08:09:54
{}
MEMBER
vuejs
core
1,706,085,124
8,796
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB | ### Usages | Name | Size |...
2023-09-05T07:27:19
2023-10-20T08:33:24
{}
NONE
vuejs
core
1,685,799,766
7,761
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB | 44.3 kB | ### Usages | Name | Size |...
2023-08-21T07:30:53
2023-10-20T08:47:29
{}
NONE
vuejs
core
1,772,972,763
5,912
johnsoncodehk
Yes this introduces breaking changes, browser support dropped from 95.39% to 92.52%: - https://caniuse.com/?search=Weakset - https://caniuse.com/?search=weakref I haven't figured out a **reliable** fix that doesn't rely on `WeakRef`.
2023-10-20T15:39:08
2023-10-20T15:39:08
{}
MEMBER
vuejs
core
1,751,099,092
5,387
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.4 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-06T16:48:21
2023-10-21T07:23:59
{}
NONE
vuejs
core
1,772,137,760
9,419
GrantGryczan
> This is not a "memory leak", you just created millions of (valid) deps for a single set's `has` method. And all of these deps are required, since the effect should be re-run as soon as you do `set.add("an existing dep")` somewhere else in the code. So as long as that effect exists, we need to keep these deps, and the...
2023-10-20T06:07:53
2023-10-20T06:24:01
{}
NONE
vuejs
core
1,686,116,405
8,986
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------------------ | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB (**+8 B**) | 29.5 kB | | vue.global.prod.js | 132 kB | 49.3 kB (**+7 B**) | 44.3 kB | #...
2023-08-21T11:03:38
2023-10-20T07:12:28
{}
NONE
vuejs
core
1,772,324,649
8,304
pikax
@auvred is it possible to add a test please?
2023-10-20T08:42:44
2023-10-20T08:42:44
{}
MEMBER
vuejs
core
1,772,405,039
7,748
edison1105
> @edison1105 ecosystem-ci failures are due to the branch being very outdated. I just force rebased. I've looked into https://github.com/vuejs/core/issues/7576 in-depth before and this PR is correct
2023-10-20T09:37:28
2023-10-20T09:37:28
{}
MEMBER
vuejs
core
1,773,272,324
5,912
johnsoncodehk
The browser compatibility regression caused by `WeakRef` has been fixed in [`8ff2a89` (#5912)](https://github.com/vuejs/core/pull/5912/commits/8ff2a897396431ca916fa112d715a1b66061f000). For browsers that don't support `WeakRef`, we just stub it, so fallback to the behavior computed possible memory leaks. (To avoid misu...
2023-10-20T19:14:11
2023-10-20T19:14:11
{}
MEMBER
vuejs
core
1,773,706,727
2,494
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------- | ------- | ------- | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue.global.prod.js | 132 kB | 49.4 kB | 44.3 kB | ### Usages | Name | Size |...
2023-10-21T07:36:06
2023-10-21T07:36:06
{}
NONE
vuejs
core
1,772,230,953
8,549
LinusBorg
This PR solves the same problem as #7827, but I *think* #7827 should be preferred as it would also clean up deps that are primitive types (strings). But maybe the WeakMap approach is more perfomant? Not sure. either way the pros and cons should be weighted before merging this. Also, johnson seems to already have inc...
2023-10-20T07:33:23
2023-10-20T07:34:15
{}
MEMBER
vuejs
core
1,772,295,733
7,773
pikax
@JayFate noticing this PR has conflicts and there's not much information on what is meant to fix, I'll close this for now, there's a few changes in style. Please create an companion issue then we can reopen this :)
2023-10-20T08:22:43
2023-10-20T08:22:43
{}
MEMBER
vuejs
core
1,772,339,379
7,018
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------ | ------------------- | | runtime-dom.global.prod.js | 85.9 kB (**+6 B**) | 32.7 kB (**+4 B**) | 29.5 kB (**+22 B**) | | vue....
2023-10-20T08:52:36
2023-10-20T08:52:36
{}
NONE
vuejs
core
1,772,340,929
8,477
pikax
Thank you for the PR, the change of value check is already done on other tests, to keep the test simple and concise, I believe just testing the nest update is the ideal case for this.
2023-10-20T08:53:48
2023-10-20T08:53:48
{}
MEMBER
vuejs
core
1,772,357,693
9,442
pikax
@edison1105 test pls 🙏
2023-10-20T09:05:02
2023-10-20T09:05:02
{}
MEMBER
vuejs
core
1,772,365,797
7,748
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------- | ------------------- | ------------------- | | runtime-dom.global.prod.js | 85.9 kB (**+22 B**) | 32.7 kB (**+21 B**) | 29.5 kB (**-28 B**) | ...
2023-10-20T09:10:43
2023-10-20T09:10:43
{}
NONE
vuejs
core
1,772,384,990
7,748
yyx990803
/ecosystem-ci run
2023-10-20T09:23:31
2023-10-20T09:23:31
{ "+1": 1 }
MEMBER
vuejs
core
1,772,398,278
9,443
sxzz
/ecosystem-ci run
2023-10-20T09:32:35
2023-10-20T09:54:47
{ "+1": 1 }
MEMBER
vuejs
core
1,772,469,006
9,233
johnsoncodehk
@Alfred-Skyblue I don't think the author's original problem needs fixing, it's expected behavior, but my playground link shows a different problem, someObject still doesn't get recycled even though computed itself is set to undefined.
2023-10-20T10:18:18
2023-10-20T10:18:18
{ "+1": 2 }
MEMBER
vuejs
core
1,772,471,178
8,920
pikax
Requests for API changes like this should go through RFC to scope out possible issues.
2023-10-20T10:18:59
2023-10-20T10:18:59
{}
MEMBER
vuejs
core
1,772,753,777
9,448
github-actions[bot]
## Size Report ### Bundles | File | Size | Gzip | Brotli | | -------------------------- | ------------------ | ------------------- | ------------------ | | runtime-dom.global.prod.js | 85.9 kB | 32.7 kB | 29.5 kB | | vue....
2023-10-20T13:35:37
2023-10-20T13:35:37
{}
NONE