owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 1,727,995,667 | 9,260 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-09-20T15:51:55 | 2023-09-20T15:51:55 | {} | NONE |
vuejs | core | 1,727,898,899 | 6,715 | SebbeJohansson | ~I think this is also happening when using slots that are empty. On the server nothing is rendered, but on the client and empty comment is rendered.~
edit: this seems to only happen in nuxt, and not in vue with vite. I will open an issue there. | 2023-09-20T14:57:09 | 2023-09-20T19:31:21 | {} | NONE |
vuejs | core | 1,728,748,042 | 9,243 | sxzz | It’s ok. If it is not referenced, it will be removed by tree-shaking. | 2023-09-21T04:29:10 | 2023-09-21T04:29:10 | {} | MEMBER |
vuejs | core | 1,730,871,355 | 9,263 | xiaoxiangmoe | Also, in your PR, there exist some any
<img width="688" alt="image" src="https://github.com/vuejs/core/assets/8111351/1f571e81-7f87-44a9-8582-24e951af5775">
But in my PR, I add types for them
<img width="960" alt="image" src="https://github.com/vuejs/core/assets/8111351/af2fa4a6-b3cd-419b-b15b-1f39e8a69fde">
... | 2023-09-22T06:26:55 | 2023-09-22T06:26:55 | {} | CONTRIBUTOR |
vuejs | core | 1,725,019,391 | 9,182 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 75f9b04b98e812ee0455b81ec9a0a64a43d1b263 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s... | 2023-09-19T08:03:47 | 2023-09-19T08:03:47 | {} | NONE |
vuejs | core | 1,717,505,353 | 5,386 | tafelnl | I would argue your 5th 'level' describes the most logical and expected behaviour of them all, especially when combining it with `vue-router`. Suppose we have a simple app, with a "home"-page and another page (let's say "about us"). We use `keep-alive` in combination with `vue-router` to keep track of the entire state o... | 2023-09-13T12:10:19 | 2023-09-19T09:14:56 | {
"+1": 4
} | NONE |
vuejs | core | 1,490,985,110 | 6,529 | mateo-m | @edison1105 do you know if this PR could be merged sometime soon? | 2023-03-30T21:24:47 | 2023-09-20T00:08:44 | {} | NONE |
vuejs | core | 1,727,984,254 | 9,238 | sxzz | /ecosystem-ci run | 2023-09-20T15:45:07 | 2023-09-20T15:45:07 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,725,636,327 | 9,238 | sxzz | /ecosystem-ci run | 2023-09-19T13:57:18 | 2023-09-20T15:45:14 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,728,767,405 | 9,243 | yangmingshan | Not all of them, some `enum` will be exported, tree-shaking won't help, bundle size will increase a little.
But you can see the results first and then decide. | 2023-09-21T04:37:34 | 2023-09-21T04:37:34 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,729,122,667 | 8,986 | haoqunjiang | Now that Renovate is configured for this repo, I think we can also use it for automatic Node.js version updates.
Currently, Renovate doesn't detect the `node-version` string in GitHub Actions by default. But there are 2 possible workarounds:
1. Use `regexManagers`: https://github.com/renovatebot/renovate/issues/771... | 2023-09-21T08:42:57 | 2023-09-21T08:42:57 | {
"+1": 2
} | MEMBER |
vuejs | core | 1,729,383,318 | 9,265 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-09-21T11:31:01 | 2023-09-21T11:31:01 | {} | NONE |
vuejs | core | 1,722,903,449 | 5,386 | tafelnl | @yxchai I think that's a totally different issue to be honest. I am talking about pausing `computed` and `watch` and pausing rendering after navigating away from a route. That issue talks about invoking the `activated` hook for child components | 2023-09-18T07:47:13 | 2023-09-18T07:47:13 | {
"+1": 2
} | NONE |
vuejs | core | 1,725,114,241 | 9,206 | tafelnl | This looks and sounds promising. Could you maybe elaborate on to what extend this is the same as what @BenceSzalai explained in https://github.com/vuejs/core/issues/5386#issuecomment-1449649119. I think this is what he calls 'level 5' right?
Also you mentioned in https://github.com/vuejs/core/issues/5386#issuecommen... | 2023-09-19T09:06:21 | 2023-09-19T09:08:56 | {} | NONE |
vuejs | core | 1,727,323,945 | 9,255 | m13886695261 | Sorry I was influenced by uniapp,didn't notice that the onupdated hook had been called.
Thanks for explaining it to me, now I get it. | 2023-09-20T09:21:59 | 2023-09-20T09:21:59 | {} | NONE |
vuejs | core | 1,729,116,793 | 9,263 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ---------------------- | ---------------------- | -------------------- |
| runtime-dom.global.prod.js | 88.4 kB (**+2.58 kB**) | 33.6 kB (**+1 kB**) | 30... | 2023-09-21T08:39:30 | 2023-09-21T08:39:30 | {} | NONE |
vuejs | core | 1,727,785,108 | 9,216 | zaalbarxx | You are right, after closer inspection it seems that it works properly when filtering null values before mapping over. Thanks a lot @wusiquan, I totally missed that :) 🍺 | 2023-09-20T13:55:08 | 2023-09-20T13:55:49 | {} | NONE |
vuejs | core | 1,728,005,235 | 9,238 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6250989382)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6244181010) |
|-------|--------|----------------|
| nuxt | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/actions/run... | 2023-09-20T15:56:55 | 2023-09-20T15:56:55 | {} | CONTRIBUTOR |
vuejs | core | 1,729,116,586 | 9,261 | yangmingshan | A competition PR #9263 😁 | 2023-09-21T08:39:21 | 2023-09-21T08:39:21 | {} | CONTRIBUTOR |
vuejs | core | 1,729,324,044 | 8,986 | Alfred-Skyblue | Agreed, I also think the second approach is indeed better, we can use `.node-version` file to manage the Node.js version. | 2023-09-21T10:49:09 | 2023-09-21T10:49:09 | {} | MEMBER |
vuejs | core | 1,729,428,351 | 9,267 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | dcca710b5e9c645cecd40ee7b385fb01ffaa6bbf |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-09-21T12:00:20 | 2023-09-21T12:00:20 | {} | NONE |
vuejs | core | 1,725,033,533 | 6,529 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6232768362)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6218368255) |
|-------|--------|----------------|
| nuxt | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/actions/run... | 2023-09-19T08:14:07 | 2023-09-19T08:14:07 | {} | CONTRIBUTOR |
vuejs | core | 1,724,884,099 | 5,912 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6062346222)
| suite | result |
|-------|--------|
| [nuxt](https://github.com/vuejs/ecosystem-ci/actions/runs/6062346222/job/16920575452) | :white_check_mark: success |
| [pinia](https://github.com/vuejs/ecosystem-ci/actions/runs/60623462... | 2023-09-19T06:09:53 | 2023-09-19T10:10:42 | {} | CONTRIBUTOR |
vuejs | core | 1,727,357,223 | 5,912 | johnsoncodehk | > @johnsoncodehk is the VueUse fail case somewhat expected?
Yes, it has a watch test result inconsistent with the snapshot due to one callback trigger less, but that's expected. | 2023-09-20T09:40:46 | 2023-09-20T09:51:46 | {} | MEMBER |
vuejs | core | 1,728,313,459 | 7,898 | RomanSkrypnik | Facing the same problem | 2023-09-20T19:31:31 | 2023-09-20T19:31:31 | {} | NONE |
vuejs | core | 1,728,963,573 | 9,243 | xiaoxiangmoe | @yangmingshan hi, I create a plugin to inline enum, see https://github.com/vuejs/core/pull/9261/files#diff-52a2558e5292b080df0a8a6b519b0ed62af0605833abe1766af51524e1985a34.
Maybe you can refer to this to continue improving your PR. | 2023-09-21T06:56:52 | 2023-09-21T06:56:52 | {} | CONTRIBUTOR |
vuejs | core | 1,729,440,785 | 9,266 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-09-21T12:08:58 | 2023-09-21T12:08:58 | {} | NONE |
vuejs | core | 1,723,127,779 | 9,243 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-09-18T10:22:00 | 2023-09-18T10:22:00 | {} | NONE |
vuejs | core | 1,727,020,906 | 7,213 | haoqunjiang | Let's track this feature request in the RFC discussion instead https://github.com/vuejs/rfcs/discussions/525 | 2023-09-20T06:00:46 | 2023-09-20T06:00:46 | {} | MEMBER |
vuejs | core | 1,727,395,052 | 9,258 | danielbender1989 | Duplicate of https://github.com/vuejs/core/issues/8910 | 2023-09-20T10:03:34 | 2023-09-20T10:03:34 | {} | NONE |
vuejs | core | 1,729,399,252 | 6,532 | YasserB94 | Bump - I also have this issue
***
**Here's what works for me now**
```html
<script setup lang="ts">
import {ButtonHTMLAttributes} from 'vue';
defineProps<ButtonHTMLAttributes>();
</script>
```
```html
<template>
<button :type="type ?? 'button'">
<slot />
</button>
</template>
```
***
**H... | 2023-09-21T11:42:14 | 2023-09-21T11:42:14 | {} | NONE |
vuejs | core | 1,729,428,512 | 9,266 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 16aaf024594652971de1de3ceebfbf9d140041a3 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s... | 2023-09-21T12:00:26 | 2023-09-21T12:00:26 | {} | NONE |
vuejs | core | 1,729,438,603 | 9,266 | renovate[bot] | ### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ **Warning**: custom changes will be lost. | 2023-09-21T12:07:29 | 2023-09-21T12:07:29 | {} | CONTRIBUTOR |
vuejs | core | 1,730,851,469 | 9,263 | xiaoxiangmoe | @yangmingshan
The js generated by your PR will look like this
```ts
var ElementTypes = /* @__PURE__ */ ((ElementTypes2) => {
ElementTypes2[ElementTypes2["ELEMENT"] = 0] = "ELEMENT";
ElementTypes2[ElementTypes2["COMPONENT"] = 1] = "COMPONENT";
ElementTypes2[ElementTypes2["SLOT"] = 2] = "SLOT";
Elemen... | 2023-09-22T06:07:30 | 2023-09-22T06:07:30 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 1,723,032,921 | 7,542 | lucasfischer | Running into the same issue while migrating from Vue 2 to Vue 3. Are there any known workarounds yet? | 2023-09-18T09:15:33 | 2023-09-18T09:15:33 | {} | NONE |
vuejs | core | 1,724,787,941 | 9,239 | edison1105 | a workaround:
```diff
<div v-for="(vv0, index0) in 3" :key="index0" ref="refDivArr">
+<div v-for="(vv0, index0) in 3" ref="refDivArr">
<CompB ref="refCompArr"></CompB>
</div>
``` | 2023-09-19T03:41:32 | 2023-09-19T03:41:32 | {} | MEMBER |
vuejs | core | 1,685,787,529 | 8,786 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-08-21T07:21:40 | 2023-09-21T04:06:41 | {} | NONE |
vuejs | core | 1,728,744,773 | 9,243 | yangmingshan | @sxzz If we use this approach, we will need contain `enum` in bundle, otherwise user cannot use these `enum` at runtime, but it will increase the bundle size. Is it ok? | 2023-09-21T04:25:34 | 2023-09-21T04:25:34 | {} | CONTRIBUTOR |
vuejs | core | 1,766,007,304 | 9,416 | Alfred-Skyblue | @Dunqing, I apologize, I've found that, as @Okysu mentioned, this is a `reactive` type of issue.
When we use `watch([ref(0), ref(1), ref(2)], callback)`, we do not encounter this issue. However, `reactive([ref(0), ref(1), ref(2)])` is inferred as the same type. Perhaps we should avoid using `reactive` to create reac... | 2023-10-17T09:14:49 | 2023-10-17T09:18:35 | {} | MEMBER |
vuejs | core | 1,766,541,802 | 9,206 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | a5446a3d5156ca44e9242a39d2252f7ef222558d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-17T14:31:22 | 2023-10-17T14:31:22 | {} | NONE |
vuejs | core | 1,768,625,471 | 9,419 | LinusBorg | Yep, that seems to be exactly it. | 2023-10-18T14:45:54 | 2023-10-18T14:45:54 | {} | MEMBER |
vuejs | core | 1,770,274,562 | 7,030 | dword-design | It has other implications to use `flush: post` because it changes the time when the watcher is called. I think it needs a fix. Calling a watcher of a component that is unmounted feels like a bug. | 2023-10-19T08:02:35 | 2023-10-19T08:02:35 | {} | NONE |
vuejs | core | 1,771,394,632 | 8,559 | pikax | Why not use `PropertyKey` type instead?
<img width="283" alt="image" src="https://github.com/vuejs/core/assets/4620458/c2c8376e-416b-4b53-9ea3-0c13d4e6b048">
| 2023-10-19T17:08:02 | 2023-10-19T17:08:11 | {} | MEMBER |
vuejs | core | 1,771,979,446 | 9,286 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | f18555bf7b1040d4d954d3794915d4f2b5759a8a |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:29:18 | 2023-10-20T02:42:07 | {} | NONE |
vuejs | core | 1,765,727,123 | 9,416 | Alfred-Skyblue | By design, rawValue should be obtained, but it is a breaking change. | 2023-10-17T06:06:02 | 2023-10-17T06:06:02 | {} | MEMBER |
vuejs | core | 1,766,093,516 | 9,400 | pikax | I disagree if think we should at the very least alert on both cases, there should not be multiple render functions, because one will never be called. That's more likely to be a bug than intentional. | 2023-10-17T10:06:14 | 2023-10-17T10:06:14 | {} | MEMBER |
vuejs | core | 1,770,206,810 | 7,030 | posva | The easiest workaround is to use `flush: post` for your watchers. It's been mentioned in other related issues but it's getting difficult to find now | 2023-10-19T07:18:16 | 2023-10-19T07:18:16 | {
"confused": 1
} | MEMBER |
vuejs | core | 1,770,209,623 | 7,030 | lwansbrough | One man’s “easiest” is another man’s “thousands of changes and infinite test surface”…
Might as well close this issue if there’s no intent to fix the discrepancy. | 2023-10-19T07:20:12 | 2023-10-19T07:28:15 | {} | NONE |
vuejs | core | 1,770,338,662 | 8,929 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6571937269)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-19T08:41:39 | 2023-10-19T08:41:39 | {} | CONTRIBUTOR |
vuejs | core | 1,093,197,325 | 5,691 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2ba6cc50b54de39b9e3b0ec8eb1f6df08d22ebae |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2022-04-08T18:37:13 | 2023-10-19T15:00:01 | {} | NONE |
vuejs | core | 1,772,044,746 | 8,809 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 85.9 kB (**+53 B**) | 32.7 kB (**+12 B**) | 29.5 kB (**+14 B**) |
... | 2023-10-20T04:05:49 | 2023-10-20T04:05:49 | {} | NONE |
vuejs | core | 1,766,989,150 | 3,842 | SirMishaa | Having the same issue when migrating a project from Vue 2 to Vue 3.
The PR seems ready, does something prevent it from being merged ?
Regards | 2023-10-17T18:57:49 | 2023-10-17T18:57:49 | {} | NONE |
vuejs | core | 1,767,838,137 | 9,400 | sxzz | Now an error will be threw when `defineRender()` used with `<template>` | 2023-10-18T07:31:27 | 2023-10-18T07:31:27 | {} | MEMBER |
vuejs | core | 1,770,202,731 | 7,030 | lwansbrough | @posva since you closed my issue can you offer a signal of intent for this issue? This is marked as a minor issue but anybody migrating from Vue 2 is probably experiencing this issue whether they realize it or not. Our code base consists of thousands of components across hundreds of pages. It’s not possible to test the... | 2023-10-19T07:15:21 | 2023-10-19T07:15:21 | {} | NONE |
vuejs | core | 1,770,348,032 | 5,912 | zhangenming | make vue great(fast) again | 2023-10-19T08:47:00 | 2023-10-19T08:47:54 | {} | CONTRIBUTOR |
vuejs | core | 1,770,364,782 | 7,030 | posva | It's just a workaround 😉 . I'm adding it in case it helps some folks. Hopefully the PR can be merged for the next release | 2023-10-19T08:56:45 | 2023-10-19T08:56:45 | {
"eyes": 1
} | MEMBER |
vuejs | core | 1,771,986,698 | 9,267 | yyx990803 | @sxzz My bad, I thought this was automated and didn't see the code related changes you did, should've merged this earlier.
Manually landed in f5a253f6 | 2023-10-20T02:38:56 | 2023-10-20T02:38:56 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,772,130,085 | 6,124 | pikax | @liulinboyi do you have intentions in getting this PR ready to review or should it be closed? | 2023-10-20T05:58:28 | 2023-10-20T05:58:28 | {} | MEMBER |
vuejs | core | 1,768,236,231 | 5,912 | dimatakoy | awesome! looks like we really need this ;-) | 2023-10-18T11:18:29 | 2023-10-18T11:18:29 | {} | NONE |
vuejs | core | 1,743,282,551 | 9,260 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 4badfa9e5aaf34f9ff2c211f17cd753cd0887215 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-02T15:56:07 | 2023-10-18T11:52:50 | {} | NONE |
vuejs | core | 1,770,135,355 | 9,425 | LinusBorg | Your watchEffects are *not* equivalent to the watch() variations.
1. The First watch watches a reactive object, so a change to any of that objects property will trigger it.
2. The second one watches a ref, which by default would only react to a reassignment of the ref's `.value` - but you make it watch all of the n... | 2023-10-19T06:19:46 | 2023-10-19T06:19:46 | {} | MEMBER |
vuejs | core | 1,770,268,662 | 7,181 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6571484849)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/657... | 2023-10-19T07:59:07 | 2023-10-19T07:59:07 | {} | CONTRIBUTOR |
vuejs | core | 1,770,685,179 | 7,181 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 85.9 kB (**+33 B**) | 32.7 kB (**+26 B**) | 29.5 kB (**+20 B**) |
... | 2023-10-19T11:26:59 | 2023-10-19T11:26:59 | {} | NONE |
vuejs | core | 1,771,005,426 | 7,181 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6575243449)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-19T13:36:01 | 2023-10-19T13:36:01 | {} | CONTRIBUTOR |
vuejs | core | 1,766,329,878 | 9,413 | rudyxu1102 | > #7444 did the same thing (`defineAttrs` macro) before my review. As [my review comment](https://github.com/vuejs/core/pull/7444#discussion_r1303492845) in #7444, I don't think it's necessary to introduce a new macro for attrs. Reusing `useAttrs` is enough for declaring types.
>
> In you PR, `defineAttrs` will be r... | 2023-10-17T12:35:44 | 2023-10-19T15:58:28 | {} | CONTRIBUTOR |
vuejs | core | 1,771,606,482 | 8,940 | skirtles-code | Seems similar to #6765. | 2023-10-19T19:46:15 | 2023-10-19T19:46:15 | {} | CONTRIBUTOR |
vuejs | core | 1,765,564,375 | 9,413 | sxzz | Is there any difference between this PR and #7444? | 2023-10-17T02:39:37 | 2023-10-17T02:39:37 | {} | MEMBER |
vuejs | core | 1,766,210,762 | 9,413 | sadeghbarati | > Is there any difference between this PR and #7444?
If I understand correctly, this PR is for **typed/inferring** `attrs` with macro in `<script setup>` (SFC)
and this PR https://github.com/vuejs/core/pull/7444 is the same but for `defineComponent` or `functional components` (TS/TSX) | 2023-10-17T11:21:20 | 2023-10-17T11:21:20 | {
"+1": 1
} | NONE |
vuejs | core | 1,767,913,206 | 9,419 | LinusBorg | This is not a "memory leak", you just created millions of (valid) deps for a single set's `has` method. And all of these deps are required, since the effect should be re-run as soon as you do `set.add("an existing dep")` somewhere else in the code. So as long as that effect exists, we need to keep these deps, and they ... | 2023-10-18T08:09:08 | 2023-10-18T08:15:49 | {} | MEMBER |
vuejs | core | 1,767,971,825 | 8,372 | DreamShaded | any news? | 2023-10-18T08:42:22 | 2023-10-18T08:42:22 | {} | NONE |
vuejs | core | 1,768,260,459 | 9,423 | LinusBorg | updating the style attribute means updating the DOM. to update the DOM, the component needs to re-render. That's how virtualDOM based rendering libraries work.
This will be likely be different once we ship the alternate rendering mode called "vapor mode", but there no clear ETA on that. | 2023-10-18T11:34:24 | 2023-10-18T11:34:24 | {} | MEMBER |
vuejs | core | 1,765,239,279 | 9,381 | davidmatter | @pikax @johnsoncodehk same as https://github.com/vuejs/core/pull/9336. Fixed in https://github.com/vuejs/language-tools/pull/3672 | 2023-10-16T20:42:09 | 2023-10-16T20:42:09 | {} | CONTRIBUTOR |
vuejs | core | 1,766,394,361 | 9,413 | sxzz | After discussion, we decided to do something similar to `defineSlots`.
`useAttrs` will not be changed, but add a `defineAttrs<T>()` macro. | 2023-10-17T13:13:32 | 2023-10-17T13:13:32 | {} | MEMBER |
vuejs | core | 1,769,800,106 | 7,312 | Swivelgames | Here's another [playground](https://play.vuejs.org/#eNqNVE1v2zAM/SuEiiEt0CTeenPTYF89bMC6YQ2wHXxRbDpRa0uCJLsJgvz3UZLjZmnS7WaR75HvmZQ27IPWo7ZBlrKJzY3QDiy6Rk8zKWqtjIMNGCxhC6VRNQwIOshkJnMlLUGX6ulOwY2HnJe8snhxvZ/7JdzyMLvLV8hbnHnywBkubcUd/j5/myRvLgZ9EZQOzQtQEhCTcRRMUungsNY+SyeAybxxTkl4n1cif7zJWC/UmQYzNr2nM1BghhV6l5NxZET2zLcS... | 2023-10-19T02:41:54 | 2023-10-19T02:41:54 | {} | NONE |
vuejs | core | 1,769,834,768 | 7,312 | alkami-jdalrymple | Is there a reason why these vars aren't just hoisted to `:root`? If they're made adequately unique, there shouldn't be any fear of unintentionally overwriting existing vars, should there?
------
> but you could easily generate a unique name
I actually ended up trying your method here, but making them unique re... | 2023-10-19T03:30:19 | 2023-10-19T03:32:47 | {
"heart": 3
} | NONE |
vuejs | core | 1,093,196,945 | 5,691 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2ba6cc50b54de39b9e3b0ec8eb1f6df08d22ebae |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s... | 2022-04-08T18:37:03 | 2023-10-19T14:59:57 | {} | NONE |
vuejs | core | 1,771,392,878 | 8,559 | sxzz | It's actually a simple refactoring. `keyof any` equals `string | number | symbol` | 2023-10-19T17:06:39 | 2023-10-19T17:06:39 | {} | MEMBER |
vuejs | core | 1,771,980,273 | 9,322 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 8503075c032682b79b60c1083c2e963f6357c8a8 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:30:39 | 2023-10-20T02:30:39 | {} | NONE |
vuejs | core | 1,772,131,110 | 9,233 | Alfred-Skyblue | @johnsoncodehk If we want to solve this problem, we must run the `effect` every time `set` is executed, even if `get` is not triggered. Perhaps we should add a parameter to it to indicate whether it needs lazy loading, like `lazy: false`. | 2023-10-20T05:59:40 | 2023-10-20T05:59:40 | {} | MEMBER |
vuejs | core | 1,766,083,093 | 9,400 | baiwusanyu-c | > > It should not be shared with template syntax, right?
> > ```
> > <script setup lang='jsx'>
> > import { ref } from 'vue'
> > const msg = ref('Hello World!')
> > defineRender(<p>{msg.value}</p>)
> > </script>
> > <template>
> > <p>{msg.value}</p>
> > </template>
> > ```
>
> It should be the same... | 2023-10-17T09:59:50 | 2023-10-17T09:59:50 | {} | MEMBER |
vuejs | core | 1,771,410,670 | 8,559 | sxzz | Good idea, TIL! | 2023-10-19T17:20:02 | 2023-10-19T17:20:02 | {} | MEMBER |
vuejs | core | 1,771,418,898 | 9,418 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-10-19T17:26:14 | 2023-10-19T17:26:14 | {} | NONE |
vuejs | core | 1,766,272,943 | 9,413 | sxzz | #7444 did the same thing (`defineAttrs` macro) before my review. As [my review comment](https://github.com/vuejs/core/pull/7444#discussion_r1303492845) in #7444, I don't think it's necessary to introduce a new macro for attrs. Reusing `useAttrs` is enough for declaring types.
In you PR, `defineAttrs` will be replace... | 2023-10-17T12:00:27 | 2023-10-17T12:00:27 | {} | MEMBER |
vuejs | core | 1,766,373,722 | 9,413 | sxzz | Sorry, I was misled and thought these two PRs belonged to two different authors. (P.S hope to have a more detailed PR description in the future :P )
Compared to `defineSlots`, you're right. However, we need only one generic support, which means maybe adding a macro `defineAttrs` is enough. For non `<script setup>`, ... | 2023-10-17T13:01:27 | 2023-10-17T13:01:27 | {
"heart": 1
} | MEMBER |
vuejs | core | 1,770,253,260 | 7,181 | edison1105 | /ecosystem-ci run | 2023-10-19T07:48:42 | 2023-10-19T07:48:42 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,771,993,321 | 9,325 | yyx990803 | Putting this in a minor as technically the breaking change in v6 can affect cases where users pass in `modulesOptions` via `compileStyle` options. | 2023-10-20T02:48:45 | 2023-10-20T02:48:45 | {} | MEMBER |
vuejs | core | 1,771,999,957 | 9,325 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 757d8adcdf6c57bff1837b0ae7e7e908e3249a90 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:58:23 | 2023-10-20T02:58:23 | {} | NONE |
vuejs | core | 1,769,177,169 | 9,419 | johnsoncodehk | I solved this problem by the way in [`93b5beb` (#5912)](https://github.com/vuejs/core/pull/5912/commits/93b5bebc0730a2d868d752bc77c712503b69cd38) (have added @skirtles-code as co-author due to directly using the tests he wrote) | 2023-10-18T19:21:48 | 2023-10-18T19:26:40 | {
"+1": 2
} | MEMBER |
vuejs | core | 1,770,866,071 | 7,914 | pikax | @btea can you add a test pls? | 2023-10-19T12:26:30 | 2023-10-19T12:26:30 | {} | MEMBER |
vuejs | core | 1,770,975,086 | 8,559 | pikax | What problem does this solve? | 2023-10-19T13:19:20 | 2023-10-19T13:19:20 | {} | MEMBER |
vuejs | core | 1,771,865,081 | 5,627 | edison1105 | > @LinusBorg is the problem still present, if so @edison1105 what can we do to get this PR resolved or closed
see https://github.com/vuejs/core/issues/5626#issuecomment-1079932015
The problem still present. We need this PR. | 2023-10-20T00:04:25 | 2023-10-20T00:04:25 | {} | MEMBER |
vuejs | core | 1,766,015,504 | 9,400 | sxzz | After discussing with Evan, we added one more macro, defineRender.
Compared to the return statement:
- Macro is more explicit for defining render. The `return` statement has unclear semantics.
- `return` can be written more than once can could cause losing reactivity like [I mentioned before](https://github.com/vu... | 2023-10-17T09:19:53 | 2023-10-17T09:19:53 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,768,214,293 | 9,419 | LinusBorg | (accidentally delete my comment so here's a re-write)
Thinking further about this, I think we might have a potential for optimzation when it comes to Map keys / Set content that are objects.
My previous explanation holds true for keys that are primitive types, but if we look at objects, those could be held in mem... | 2023-10-18T11:03:12 | 2023-10-18T11:03:12 | {} | MEMBER |
vuejs | core | 1,768,509,517 | 7,898 | edison1105 | duplicate of https://github.com/vuejs/core/issues/5168 | 2023-10-18T13:52:17 | 2023-10-18T13:52:17 | {} | MEMBER |
vuejs | core | 1,770,262,433 | 7,341 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6571420846)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-19T07:54:50 | 2023-10-19T07:54:50 | {} | CONTRIBUTOR |
vuejs | core | 1,770,310,403 | 7,557 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6571726911)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-19T08:24:45 | 2023-10-19T08:24:45 | {} | CONTRIBUTOR |
vuejs | core | 1,771,913,978 | 5,955 | sxzz | Could you please rebase your code? | 2023-10-20T01:10:43 | 2023-10-20T01:10:43 | {} | MEMBER |
vuejs | core | 1,771,979,760 | 9,259 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 95d1263bf46986282ab7b5458011f0f59a2dd07c |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:29:48 | 2023-10-20T02:29:48 | {} | NONE |
vuejs | core | 1,772,035,113 | 7,245 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-10-20T03:51:04 | 2023-10-20T03:51:04 | {} | NONE |
vuejs | core | 1,772,040,926 | 7,490 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 85.9 kB (**+24 B**) | 32.7 kB (**+8 B**) | 29.5 kB (**+33 B**) |
... | 2023-10-20T04:00:18 | 2023-10-20T04:00:18 | {} | NONE |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.