owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 1,766,032,984 | 9,400 | baiwusanyu-c | It should not be shared with template syntax, right?
```
<script setup lang='jsx'>
import { ref } from 'vue'
const msg = ref('Hello World!')
defineRender(<p>{msg.value}</p>)
</script>
<template>
<p>{msg.value}</p>
</template>
``` | 2023-10-17T09:30:28 | 2023-10-17T09:30:28 | {} | MEMBER |
vuejs | core | 1,767,435,815 | 9,420 | cloydlau | Wrong place. | 2023-10-18T01:06:39 | 2023-10-18T01:06:39 | {} | CONTRIBUTOR |
vuejs | core | 1,768,580,965 | 9,419 | skirtles-code | @LinusBorg Perhaps I've misunderstood, but I think the scenario you're describing involving object keys is the same problem I tried to fix in #7827. I will need to redo that PR once Johnson's reactivity optimizations are merged. | 2023-10-18T14:24:59 | 2023-10-18T14:24:59 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 1,770,253,827 | 8,824 | haoqunjiang | /ecosystem-ci run | 2023-10-19T07:49:02 | 2023-10-19T07:49:02 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,770,323,851 | 7,181 | edison1105 | Maybe ecosystem-ci should be triggered after rebase. | 2023-10-19T08:32:23 | 2023-10-19T08:32:23 | {} | MEMBER |
vuejs | core | 1,770,983,165 | 3,258 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-10-19T13:23:48 | 2023-10-19T13:23:48 | {} | NONE |
vuejs | core | 1,771,421,794 | 5,627 | pikax | @LinusBorg is the problem still present, if so @edison1105 what can we do to get this PR resolved or closed | 2023-10-19T17:28:22 | 2023-10-19T17:28:22 | {} | MEMBER |
vuejs | core | 1,772,127,298 | 6,185 | pikax | closing this in favour of https://github.com/vuejs/core/pull/7827, since it also has this changes | 2023-10-20T05:55:41 | 2023-10-20T05:55:41 | {} | MEMBER |
vuejs | core | 1,765,912,193 | 9,416 | Dunqing | > By design, rawValue should be obtained, but it is a breaking change.
Yes, I had a PR do this | 2023-10-17T08:21:32 | 2023-10-17T08:21:32 | {} | CONTRIBUTOR |
vuejs | core | 1,766,036,928 | 9,400 | pikax | Should it go through RFC first?
I would say if `defineRender` is used the compiler should throw an error if `<template>` (the render template) is present | 2023-10-17T09:32:48 | 2023-10-17T09:32:48 | {} | MEMBER |
vuejs | core | 1,770,426,867 | 9,430 | vandelpavel | Sorry just noticed that this is the wrong repo. Closing the issue.
Link to the issue on "vueUse" repo: https://github.com/vueuse/vueuse/issues/3484 | 2023-10-19T09:30:50 | 2023-10-19T09:30:50 | {} | NONE |
vuejs | core | 1,771,980,109 | 9,354 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | d18ced4352231afc6d5f4d892c1bfc66d27d8570 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:30:20 | 2023-10-20T02:49:12 | {} | NONE |
vuejs | core | 1,765,983,628 | 9,416 | Okysu | The type of `numbers` is essentially still `Ref<number>[]`, but it is possible that plugins like Volar have inferred the type and directly destructure the `.value` member of Ref to obtain the original value, thus inferring the type as number[]. From my understanding, this should not be considered an error in the Vue me... | 2023-10-17T09:01:26 | 2023-10-17T09:01:26 | {
"+1": 3
} | NONE |
vuejs | core | 1,766,395,289 | 9,413 | sxzz | I think this PR and #7444 can be combined into one. WDYT? | 2023-10-17T13:14:03 | 2023-10-17T13:14:03 | {} | MEMBER |
vuejs | core | 1,767,437,321 | 9,420 | baiwusanyu-c | 修饰符只适用于表单元素，组件上修饰符需要自己实现 | 2023-10-18T01:08:05 | 2023-10-18T01:08:05 | {} | MEMBER |
vuejs | core | 1,769,790,110 | 8,718 | johnsoncodehk | Also resolved by #5912. Note that dep could change during iterations, but in #5912 it will only change after iterations, so the spread can be safely removed. | 2023-10-19T02:27:23 | 2023-10-19T02:27:23 | {
"+1": 2
} | MEMBER |
vuejs | core | 1,772,028,718 | 7,748 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6583023972)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/658... | 2023-10-20T03:40:47 | 2023-10-20T03:40:47 | {} | CONTRIBUTOR |
vuejs | core | 1,766,077,906 | 9,400 | Alfred-Skyblue | > It should not be shared with template syntax, right?
>
> ```
> <script setup lang='jsx'>
> import { ref } from 'vue'
> const msg = ref('Hello World!')
> defineRender(<p>{msg.value}</p>)
> </script>
> <template>
> <p>{msg.value}</p>
> </template>
> ```
It should be the same as the render functio... | 2023-10-17T09:56:31 | 2023-10-17T09:56:31 | {} | MEMBER |
vuejs | core | 1,766,136,374 | 9,416 | pikax | This seems to be working as expected:
```ts
describe('should unwrap tuple correctly', () => {
const readonlyTuple = [ref(0)] as const
const reactiveReadonlyTuple = reactive(readonlyTuple)
expectType<Ref<number>>(reactiveReadonlyTuple[0])
const tuple: [Ref<number>] = [ref(0)]
const reactiveTuple = rea... | 2023-10-17T10:32:29 | 2023-10-17T10:36:23 | {} | MEMBER |
vuejs | core | 1,765,912,762 | 9,417 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | ------------------- |
| runtime-dom.global.prod.js | 85.9 kB (**+27 B**) | 32.7 kB (**+28 B**) | 29.5 kB (**+17 B**) |
... | 2023-10-17T08:21:52 | 2023-10-17T12:02:58 | {} | NONE |
vuejs | core | 1,770,242,750 | 7,341 | haoqunjiang | /ecosystem-ci run | 2023-10-19T07:41:46 | 2023-10-19T07:41:46 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,770,278,197 | 8,824 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6571488229)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6556406503) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-19T08:04:56 | 2023-10-19T08:04:56 | {} | CONTRIBUTOR |
vuejs | core | 1,770,288,992 | 7,557 | haoqunjiang | /ecosystem-ci run | 2023-10-19T08:12:14 | 2023-10-19T08:12:14 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,771,992,868 | 5,955 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 885ec726bde8fb4373f68faa4ee1ec005069def5 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-10-20T02:48:06 | 2023-10-20T02:51:25 | {} | NONE |
vuejs | core | 1,772,018,576 | 7,748 | edison1105 | /ecosystem-ci run | 2023-10-20T03:26:30 | 2023-10-20T03:26:30 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,766,752,255 | 9,400 | baiwusanyu-c | Synchronous discussion:
The implementation of `defineRender` is to compile `jsx` content into the return value of the `setup` function, which is different from what vue's existing `jsx` plugin does (for example, `@vitejs/plugin-vue-jsx ` is to convert `jsx ` into a runtime rendering function code).
Therefore, when `d... | 2023-10-17T16:20:23 | 2023-10-17T16:21:42 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,770,241,339 | 9,400 | sxzz | > Should it go through RFC first?
>
> I would say if `defineRender` is used the compiler should throw an error if `<template>` (the render template) is present
@pikax
- Now The macro cannot be used with `<template>`.
- The RFC has been written, PTAL https://github.com/vuejs/rfcs/discussions/585
| 2023-10-19T07:40:49 | 2023-10-19T07:40:49 | {
"rocket": 2
} | MEMBER |
vuejs | core | 1,770,854,803 | 9,306 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-10-19T12:22:18 | 2023-10-19T12:22:18 | {} | NONE |
vuejs | core | 1,771,990,905 | 9,407 | yyx990803 | beb487ef | 2023-10-20T02:45:03 | 2023-10-20T02:45:03 | {} | MEMBER |
vuejs | core | 1,772,122,030 | 9,233 | johnsoncodehk | I modified your minimal reproduction to highlight the more obvious problem: computed cannot be recycled when it is no longer referenced
I think this might be what's really causing your memory leak, but I'm not sure. This is obviously a bug anyway.
https://play.vuejs.org/#eNqdVE1v2kAQ/Ssrn0AC+9CeKKC0USolh6RKeqnky2KP... | 2023-10-20T05:49:03 | 2023-10-20T05:49:03 | {} | MEMBER |
vuejs | core | 1,767,804,210 | 9,400 | sxzz | Actually, JSX is not within the scope of defineRender. Whatever using or not `defineRender`, the order of compilation is transforming Vue SFC into JavaScript (or JSX) code (`@vitejs/plugin-vue`), then transform JSX into JS (`@vitejs/plugin-vue-jsx`). | 2023-10-18T07:06:41 | 2023-10-18T07:06:41 | {} | MEMBER |
vuejs | core | 1,768,426,989 | 9,351 | edison1105 | also fix #8127 | 2023-10-18T13:12:00 | 2023-10-18T13:12:00 | {} | MEMBER |
vuejs | core | 1,770,320,882 | 8,929 | haoqunjiang | /ecosystem-ci run | 2023-10-19T08:30:32 | 2023-10-19T08:30:32 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,770,481,336 | 7,173 | AndrewBogdanovTSS | > Yeah. Once it gets supported in Vue compiler, then ESLint, Volar, and other tools have to support this feature as well.
I don't understand the argument, this can be said about any feature in any framework, should we stop adding them because of it?
> Sounds like editors and IDEs could potentially lose out on s... | 2023-10-19T10:01:27 | 2023-10-19T10:01:27 | {} | NONE |
vuejs | core | 1,770,978,248 | 7,181 | edison1105 | /ecosystem-ci run | 2023-10-19T13:21:10 | 2023-10-19T13:21:10 | {
"+1": 2
} | MEMBER |
vuejs | core | 1,771,169,433 | 5,691 | vercel[bot] | @nandi95 is attempting to deploy a commit to the **vuejs** Team on [Vercel](https://vercel.com).
A member of the Team first needs to [authorize it](https://vercel.com/git/authorize?team=vuejs&type=github&job=%7B%22headInfo%22%3A%7B%22sha%22%3A%222ba6cc50b54de39b9e3b0ec8eb1f6df08d22ebae%22%7D%2C%22id%22%3A%22QmbhBdRZnL... | 2023-10-19T14:59:42 | 2023-10-19T14:59:42 | {} | NONE |
vuejs | core | 1,771,417,090 | 9,429 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 85.9 kB | 32.6 kB | 29.5 kB |
| vue.global.prod.js | 132 kB | 49.3 kB | 44.4 kB |
### Usages
| Name | Size |... | 2023-10-19T17:24:49 | 2023-10-19T17:24:49 | {} | NONE |
vuejs | core | 1,771,981,510 | 5,955 | zhmushan | @sxzz Done. | 2023-10-20T02:32:37 | 2023-10-20T02:32:37 | {} | CONTRIBUTOR |
vuejs | core | 1,780,157,607 | 9,478 | b12k | @sodatea I recreated this fix and added more details.
Thank you in advance!
FYI: @edison1105 | 2023-10-25T22:43:11 | 2023-10-25T22:43:11 | {} | CONTRIBUTOR |
vuejs | core | 1,780,333,012 | 5,912 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6648768610)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6635940543) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-26T02:48:47 | 2023-10-26T02:48:47 | {} | CONTRIBUTOR |
vuejs | core | 1,780,418,850 | 9,479 | haoqunjiang | Expected.
https://vuejs.org/guide/essentials/list.html#maintaining-state-with-key
> This default mode is efficient, but **only suitable when your list render output does not rely on child component state or temporary DOM state (e.g. form input values)**.
Stateful child components must use `key` to ensure correct... | 2023-10-26T05:01:49 | 2023-10-26T05:01:49 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,780,687,761 | 9,233 | yyx990803 | Closing as the original issue is not considered a leak: a leak means the memory has a chance of infinitely growing over time - in this case, there will always only be at most 1 copy of a cached value held, and it is properly released on next access / component unmount. | 2023-10-26T08:52:01 | 2023-10-26T08:52:01 | {} | MEMBER |
vuejs | core | 1,782,757,325 | 6,463 | TomasSestak | this is serious issue - is it on the roadmap? | 2023-10-27T11:31:52 | 2023-10-27T11:31:52 | {
"+1": 14
} | NONE |
vuejs | core | 1,783,148,273 | 6,018 | johnsoncodehk | Fixed by #5912. | 2023-10-27T15:54:36 | 2023-10-27T15:54:36 | {
"hooray": 1
} | MEMBER |
vuejs | core | 1,783,250,542 | 7,444 | rudyxu1102 | > Could you please **REBASE** your branch due the minor branch has been also rebased.
@sxzz done | 2023-10-27T17:14:41 | 2023-10-27T17:14:41 | {
"heart": 4
} | CONTRIBUTOR |
vuejs | core | 1,780,807,338 | 9,478 | b12k | `resolveType.spec.ts`
Test `relative ts on Windows` does not include condition when file is located in another folder.
I will update the test to illustrate the issue | 2023-10-26T10:04:46 | 2023-10-26T10:04:46 | {} | CONTRIBUTOR |
vuejs | core | 1,780,564,033 | 9,478 | pikax | @b12k can you provide an example of this error happening, I've been using windows and haven't noticed this issue. | 2023-10-26T07:29:59 | 2023-10-26T07:29:59 | {} | MEMBER |
vuejs | core | 1,780,634,739 | 9,480 | pikax | Thank you for the link, based on that you can optimise it even further see [perf](https://perf.link/%EF%BC%89%EF%BC%9AJSPerf#eyJpZCI6ImFvejkyNjFqa3kyIiwidGl0bGUiOiJGaW5kaW5nIG51bWJlcnMgaW4gYW4gYXJyYXkgb2YgMTAwMCIsImJlZm9yZSI6ImNvbnN0IGVmZmVjdHMgPSBbXVxuZm9yKGxldCBpPTA7aTwxMDA7aSsrKXtcbiAgZWZmZWN0cy5wdXNoKHtcbiAgIGNvbX... | 2023-10-26T08:18:26 | 2023-10-26T08:18:26 | {} | MEMBER |
vuejs | core | 1,780,771,615 | 5,912 | johnsoncodehk | We removed the memory leak fix based on WeakRef, FinalizationRegistry, because computed will already be recycled by effectScope when the component is unmounted. | 2023-10-26T09:42:55 | 2023-10-26T09:42:55 | {
"+1": 7
} | MEMBER |
vuejs | core | 1,780,889,741 | 8,530 | Alfred-Skyblue | @skirtles-code The contentious part is currently being handled in a manner similar to `toRef`, and it has been updated. | 2023-10-26T10:58:05 | 2023-10-26T10:58:05 | {} | MEMBER |
vuejs | core | 1,780,896,783 | 5,312 | NojusM | **Vue 3.3.5**
Still a problem and @seregarom workaround doesn't seem to work for me.
Current workaround i found is asserting` v-for source array as {}`
```vue
<template
v-for="(name, index) of (Object.keys($slots) as {})"
OR
v-for="(_, name, index) in ($slots as {})"
v-slot:[n... | 2023-10-26T11:02:58 | 2023-10-26T11:04:16 | {
"+1": 17,
"hooray": 1
} | NONE |
vuejs | core | 1,782,273,773 | 9,489 | Alfred-Skyblue | In #8978, the `@typescript-eslint/eslint-plugin` plugin was added for unified processing. | 2023-10-27T04:29:50 | 2023-10-27T04:29:50 | {} | MEMBER |
vuejs | core | 1,782,448,005 | 9,478 | b12k | @sodatea May I please ask you to have a look one more time? | 2023-10-27T07:39:43 | 2023-10-27T07:43:52 | {} | CONTRIBUTOR |
vuejs | core | 1,783,762,609 | 5,912 | johnsoncodehk | @ferferga You need to cache and return the old object if possible.
```ts
let computed1Value
const count = ref(0)
const computed1 = computed(() => {
const prop1 = Math.round(count.value / 1000)
const prop2 = Math.round(count.value / 1000) * 2
if (computed1Value && computed1Value.prop1 === prop1 && compu... | 2023-10-28T09:44:37 | 2023-10-28T09:44:37 | {
"+1": 3,
"hooray": 3
} | MEMBER |
vuejs | core | 1,783,842,428 | 9,416 | liulinboyi | I have a try with your example, If you write a `getter function` in the `watch` like the follow code:
```vue
<script setup lang="ts">
import { watch, ref, reactive } from 'vue'
const numbers = reactive([ref(0), ref(1), ref(2)])
watch(() => numbers, (value) => {
// The type of the value is number[], but the ... | 2023-10-28T15:08:51 | 2023-10-28T15:08:51 | {} | MEMBER |
vuejs | core | 1,783,852,659 | 5,912 | johnsoncodehk | @ferferga the object-hash's approach is great! I think we can have an object-hash based computed API in vueuse. cc @antfu | 2023-10-28T15:43:05 | 2023-10-28T15:43:05 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,706,628,721 | 9,139 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | -------------------- | -------------------- | -------------------- |
| runtime-dom.global.prod.js | 87.1 kB (**+664 B**) | 33 kB (**+157 B**) | 29.8 kB (**+12... | 2023-09-05T13:30:59 | 2023-10-27T14:30:51 | {} | NONE |
vuejs | core | 1,783,814,152 | 5,912 | Anoesj | @johnsoncodehk I [played around](https://play.vuejs.org/#eNq9Vk1zmzAQ/Ss7HBrc2GCb9OJgT9pMDu1MP6b1kQsBYUhBUEnYyXj4711JQAATJ73UF4+0T2/frnZXHI2PRWHtS2KsDJcHLCkEcCLKAlKf7taeIbhnbDyaZEXOBByBkWgKQZ4VpSDhFA6+CGKoIGJ5BhfIc9FiE373p/TT2hQLUfCVbQchtR54SNJkzyxKhE2LzE7z0OexlXAiT9xcWR+suX1JeIZsHo1KGogkp63bWz+ISehugTwKQkMOPn3amBFdgTm... | 2023-10-28T13:39:44 | 2023-10-28T13:39:44 | {
"eyes": 1
} | NONE |
vuejs | core | 1,783,987,530 | 7,836 | sxzz | See https://github.com/vuejs/core/pull/9249#issuecomment-1772442069
I think we should also treat MathML tags as "late added tags" | 2023-10-29T03:25:01 | 2023-10-29T03:25:01 | {} | MEMBER |
vuejs | core | 1,784,034,206 | 8,929 | doutatsu | 😭 How much longer I wonder | 2023-10-29T08:32:03 | 2023-10-29T08:32:03 | {} | NONE |
vuejs | core | 1,780,252,190 | 5,627 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB (**+1 B**) | 29.7 kB (**-31 B**) |
| vue.global.prod.js | 132 kB ... | 2023-10-26T00:53:05 | 2023-10-26T00:53:05 | {} | NONE |
vuejs | core | 1,781,314,637 | 9,486 | pikax | @its-lee the issue is not related with `<script setup>` the issue is that you are rendering with a custom function that will render your component with `h`, that's a low level creation of a render component, when you do that you must understand how the component will be render, on your case you are not passing the arg... | 2023-10-26T15:05:56 | 2023-10-26T15:05:56 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,781,623,684 | 7,018 | skirtles-code | @posva It looks like this PR has been mangled by changes elsewhere. The file `globalsWhitelist.ts` has been renamed to `globalAllowList.ts`, which is likely why the unit test is failing on the CI. | 2023-10-26T18:20:55 | 2023-10-26T18:20:55 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,782,553,294 | 9,134 | Alfred-Skyblue | > The error is not present but the behaviour is incorrect: [playground](https://deploy-preview-9134--vue-sfc-playground.netlify.app/#eNqtVE2PmzAQ/SsjLslKBKJGlSqapE2qPbSHttrNkYsLA/Eu2Mg2bKIo/71jOwsoaStV2pvn6817MwOnYNM0UddikARLnSneGNBo2madCl43Uhk4QY4FF/hFki1QmBD2IQg8mB3PnkPQe1ZV8uUBCzhDoWQNE8KbfExFJoU20NdtYHUNNT2lAkChyFE... | 2023-10-27T08:58:26 | 2023-10-27T08:58:26 | {} | MEMBER |
vuejs | core | 1,783,150,424 | 9,419 | johnsoncodehk | Fixed by #5912 | 2023-10-27T15:56:08 | 2023-10-27T15:56:08 | {} | MEMBER |
vuejs | core | 1,783,858,753 | 5,912 | Anoesj | @johnsoncodehk Nice, that would also work. Also, one hour ago? Dude, you're beast, haha! | 2023-10-28T16:07:10 | 2023-10-28T16:07:10 | {
"laugh": 1
} | NONE |
vuejs | core | 1,780,389,595 | 5,912 | johnsoncodehk | nuxt re-run is passed, but update-comment failed. cc @sodatea | 2023-10-26T04:18:08 | 2023-10-26T04:18:08 | {} | MEMBER |
vuejs | core | 1,781,355,937 | 9,478 | b12k | > `joinPaths` is also used in minimatch patterns:
>
> https://github.com/vuejs/core/blob/edf2572615d0b065bb7ae49de4c3b71086771310/packages/compiler-sfc/src/script/resolveType.ts#L883
> which only accepts forward slashes: https://github.com/isaacs/minimatch#windows
> I'm afraid that's what's causing the Windows tes... | 2023-10-26T15:28:37 | 2023-10-26T15:28:37 | {} | CONTRIBUTOR |
vuejs | core | 1,783,489,709 | 8,652 | liamdebeasi | I am going to close this as I no longer need this feature. I used the "created" hook in a custom directive instead of the "onVnodeBeforeMount" VNode hook. The problem was that the application event listener and the internal event listener were added to the same element, but the application event listener was added firs... | 2023-10-27T20:42:12 | 2023-10-27T20:42:12 | {} | NONE |
vuejs | core | 1,783,743,796 | 5,912 | ferferga | Hello, sorry if commenting in a merged PR is undesired and an issue should be opened instead. With the alpha release of 3.4.0, I had the chance to test this more deeply in the playground, but it doesn't seem to work properly with objects. Is this expected to only work right with primitives?
<details>
<summary>Repro... | 2023-10-28T08:13:30 | 2023-10-28T08:13:30 | {} | CONTRIBUTOR |
vuejs | core | 1,784,340,508 | 9,501 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-30T01:32:58 | 2023-10-30T01:32:58 | {} | NONE |
vuejs | core | 1,780,355,401 | 5,912 | yyx990803 | Looking at ecosystem-ci:
- VueUse: failing case is `computedEager` which should be no longer needed after this PR
- Quasar: seems to be fail because Quasar is using a TS configuration that doesn't include the `WeakRef` global type - this means the type change may break other existing Vue projects with similar TS ... | 2023-10-26T03:24:18 | 2023-10-26T03:24:18 | {} | MEMBER |
vuejs | core | 1,780,665,416 | 9,485 | LinusBorg | that's also just stackblitz | 2023-10-26T08:38:08 | 2023-10-26T08:38:08 | {} | MEMBER |
vuejs | core | 1,782,213,744 | 9,489 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-27T03:02:55 | 2023-10-27T03:02:55 | {} | NONE |
vuejs | core | 1,782,522,952 | 9,478 | b12k | > @b12k can you provide an example of this error happening, I've been using windows and haven't noticed this issue.
I created a test case for that
[packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts](https://github.com/vuejs/core/pull/9478/files#diff-ba884e3c055eca4af5d6c4a16daa31397a191ceabac0a4018a... | 2023-10-27T08:36:24 | 2023-10-27T19:49:04 | {} | CONTRIBUTOR |
vuejs | core | 1,783,854,349 | 5,912 | ferferga | @johnsoncodehk What are the difficulties you see to have it in core? It's great that we can finally have a one-size-fits-all approach to computed and no longer need computedEager, so I think it'd be great too to not have other comp's implementation
I understand your concerns of more potential breakage, but maybe for... | 2023-10-28T15:48:36 | 2023-10-28T16:01:24 | {
"eyes": 1
} | CONTRIBUTOR |
vuejs | core | 1,779,615,503 | 9,451 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6642994241)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6635940543) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-25T16:10:54 | 2023-10-25T16:10:54 | {} | CONTRIBUTOR |
vuejs | core | 1,780,641,520 | 9,485 | len-ny | Actually my demo project also has some errors, just there are different from my local project created from scratch.
| 2023-10-26T08:22:56 | 2023-10-26T08:22:56 | {} | NONE |
vuejs | core | 1,780,666,960 | 9,480 | Simon-He95 | Quite good, but you need to ensure that it is consistent with the original logic, and you need to execute the effect.computed effect first. | 2023-10-26T08:39:09 | 2023-10-26T08:39:09 | {} | CONTRIBUTOR |
vuejs | core | 1,780,680,215 | 9,233 | yyx990803 | I dug a bit more and it seems the case @johnsoncodehk discovered is an edge case.
- It's true that simply setting the computed to `undefined` doesn't cause its cached value to be garbage collected.
- However, if we put the same test case inside a child component and unmount that child component, the computed valu... | 2023-10-26T08:47:27 | 2023-10-26T08:47:27 | {} | MEMBER |
vuejs | core | 1,781,503,508 | 9,478 | b12k | Strange that e2e failed.
It passes locally on Windows and Ubuntu
| 2023-10-26T17:00:42 | 2023-10-26T17:00:42 | {} | CONTRIBUTOR |
vuejs | core | 1,783,150,541 | 9,464 | johnsoncodehk | Fixed by #5912 | 2023-10-27T15:56:14 | 2023-10-27T15:56:14 | {
"rocket": 1
} | MEMBER |
vuejs | core | 1,783,738,240 | 9,495 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-28T07:49:57 | 2023-10-28T07:49:57 | {} | NONE |
vuejs | core | 1,783,846,597 | 5,912 | johnsoncodehk | @Anoesj #9497 can reduce a bit of boilerplate code.
We cannot built-in `isEqual` for object. In addition to performance issues, we should not assume that objects with the same properties should produce the same behavior in user logic. | 2023-10-28T15:22:26 | 2023-10-28T15:23:52 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,784,189,843 | 7,998 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------ | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 86.5 kB (**+8 B**) | 32.9 kB (**+6 B**) | 29.7 kB (**-38 B**) |
| vue.... | 2023-10-29T18:25:57 | 2023-10-29T18:25:57 | {} | NONE |
vuejs | core | 1,780,559,002 | 9,480 | pikax | I don't think this is a performance improvement, you not running 2 loops but you creating a new array, push to it and then looping it, not sure how this will affect the performance, I'd recommend benchmarking to prove there's actually performance benefits here. | 2023-10-26T07:26:22 | 2023-10-26T07:26:22 | {} | MEMBER |
vuejs | core | 1,781,286,963 | 9,486 | its-lee | Thanks @pikax ! RE:
> Can we also ask that the exact method for defining renderless components using script setup is documented, as the methods used above were only documented on sites like StackOverflow (https://stackoverflow.com/a/70151867).
Would there be any issue documenting this somewhere in the Vue docs(at... | 2023-10-26T14:50:45 | 2023-10-26T14:50:45 | {} | NONE |
vuejs | core | 1,781,764,978 | 7,018 | posva | @skirtles-code It should be good now! | 2023-10-26T19:22:08 | 2023-10-26T19:22:08 | {} | MEMBER |
vuejs | core | 1,782,364,472 | 8,943 | LinusBorg | There is nothing to solve as no reproduction of thr issue was provided. So - no. | 2023-10-27T06:23:29 | 2023-10-27T06:23:29 | {} | MEMBER |
vuejs | core | 1,783,112,508 | 7,782 | federicoibba | Hello, my team is facing the same issue and it's blocking our use of `vue-tcs`. A pull request is also ready #7937 , are there any chances this will be fixed soon? If I can be helpful somehow, let me know :)
Thank you! | 2023-10-27T15:30:13 | 2023-10-27T16:21:59 | {
"eyes": 1
} | NONE |
vuejs | core | 1,783,369,715 | 7,290 | mmis1000 | @pikax I think I also find the root cause of client side suspense crash caused by update before async dep resolved.
It seems the `initialVNode.el` of any async setup component is `null`. Which cause its parent component's `instance.subTree.el` to be `null` if its parent only contain exactly one children (which is th... | 2023-10-27T18:56:25 | 2023-10-27T18:58:13 | {} | CONTRIBUTOR |
vuejs | core | 1,783,846,045 | 5,912 | Anoesj | Of course, I get that. It was just a quick PoC. But having some built-in way to prevent rerenders on non-primitive computeds would be very nice. | 2023-10-28T15:20:26 | 2023-10-28T15:20:26 | {} | NONE |
vuejs | core | 1,784,422,387 | 9,504 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-30T03:35:07 | 2023-10-30T03:35:07 | {} | NONE |
vuejs | core | 1,771,953,116 | 5,955 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-20T01:55:43 | 2023-10-30T07:20:54 | {} | NONE |
vuejs | core | 1,779,951,694 | 8,763 | skirtles-code | > Hence, it is crucial to ensure that we remove our own event listeners on this element when the component is unmounted.
I'm still unclear why this is important. Is this just to avoid a memory leak, or is there some other reason to remove the listener?
If the objective is to allow the callback itself to be GCed t... | 2023-10-25T19:50:59 | 2023-10-25T19:50:59 | {} | CONTRIBUTOR |
vuejs | core | 1,779,823,265 | 9,475 | b12k | ~~I confirm that it's fixed in latest release.~~
Not fixed | 2023-10-25T18:25:29 | 2023-10-25T22:41:26 | {} | CONTRIBUTOR |
vuejs | core | 1,780,363,622 | 5,912 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6649071764)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6635940543) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-26T03:37:03 | 2023-10-26T03:37:03 | {} | CONTRIBUTOR |
vuejs | core | 1,748,985,641 | 5,912 | johnsoncodehk | > * dependencies might change on each run, and should be updated directly to avoid unnecessary triggering
Already done this! We only reset `_depsLength` in `cleanupEffect()` without changing `deps.length` to avoid unnecessary GC. New deps will overwrite old deps one by one during run, and finally trim the old deps t... | 2023-10-05T14:11:54 | 2023-10-26T10:15:29 | {
"heart": 38,
"rocket": 41
} | MEMBER |
vuejs | core | 1,782,427,577 | 5,912 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6664065565)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6663081744) |
|-------|--------|----------------|
| language-tools | :white_check_mark: [success](https://github.com/vuejs/ecosystem-ci/a... | 2023-10-27T07:24:07 | 2023-10-27T07:24:07 | {} | CONTRIBUTOR |
vuejs | core | 1,783,731,152 | 9,491 | yyx990803 | This is a known change between Vue 2 and Vue 3 - in Vue 3, the transition can only be triggered by `v-if` or `v-show` in the same template with the `<transition>` component. This is intended behavior. | 2023-10-28T07:21:04 | 2023-10-28T07:21:04 | {} | MEMBER |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.