prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Checks-Effects-Interactions Pattern Violation
### Description
**Update**
The client fixed the issue in commit `8b33ed13552abae7cf6db072095b9568c17ed3a2`and provided the following explanation:
> The cancellation of the proposal has been moved before the execution of the proposal.
**File(s) affected:**`Web3Mus... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Variable totalBalance without an access modifier.
### Description
**Recommendation**:
You can make an access modifier public for convenience and to increase user trust. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Types are not checked on runtime
### Description
Although the check in [line 95 of UpgradeableToken.sol](https://github.com/Storj/storj-contracts/blob/2bdeb27c0216d2f0889b6e7363d8a84b54cd7f39/contracts/UpgradeableToken.sol#L95) is a good idea, and will potentially catch errors when upgrading a token, we’d like... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary inheritance from `Ownable`
### Description
`NFTMintSale` and `NFTMintSaleMultiple` contracts are inherited from `MintSaleBase` and `Ownable`. But `MintSaleBase` is already inherited from `Ownable`.
### Recommendation
We recommend removing unnecessary inheritance from `Ownable` in `NFTMintSale` and... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing `PausableUpgradeable` init
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In Contract Trading.sol, PausableUpgradeable is inherited but not initialized.
**Recommendation**:
Initialize the `PausableUpgradeable` in the `initialize()` method adding `__Pausable_init... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Burnt Passports And Increased AML Scores May Lead To Locked Funds
### Description
**Update**
From dev team:
> Users should not be able to interact with the lending contracts if they do not meet the minimum criteria (i.e. having a passport + AML above a specific risk score). Similar to how funds are frozen in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Admin Roles Should Be Distinct
### Description
**Update**
Addressed in: `3238a6fcb9333b198fc1c969fe9970cd54c212f5`. The client now only assigns the `DEFAULT_ADMIN_ROLE` upon instantiation.
**File(s) affected:**`ExtendedAccessControl.sol`
**Description:**`DEFAULT_ADMIN_ROLE`, `MANAGER_ROLE`, and `PAUSER_ROLE`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: reverts during certain self-transfer
### Description
If the amount of tokens to do a self-transfer using a `transfer`/`transferFrom` call is larger than `2**128`, the transfer will fail. This breaks invariants expected of transfer functions. Traditionally, the `transferFrom` method moves tokens from one accoun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Inefficiency In Multiple Modifier Checks
### Description
In the LRTDepositPool contract, the function `removeManyNodeDelegatorContractsFromQueue()` on line [349] iteratively calls `removeNodeDelegatorContractFromQueue()`, invoking the `onlyLRTAdmin` modifier with each iteration. This repeated check for adminis... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Potential underflow in slashing logic
### Description
**Description:** The `VaultTokenized::onSlash` uses a cascading slashing logic when handling scenarios where the calculated `withdrawalsSlashed` exceeds available `withdrawals_`. In such cases, the excess amount is added to `nextWithdrawalsSlashed` witho... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Removing assets from _supportedAssets bricks pending redemptions in LevelMinting
### Description
In `LevelMinting`, the `_transferToBeneficiary()` function checks if the asset to be transferred is in the `_supportedAssets` set:
```solidity
if (!_supportedAssets.contains(asset)) revert UnsupportedAsset();
`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: External call to transfer ETH might fail because of memory returned data
### Description
**Severity**: High
**Status**: Resolved
**Description**
The Token library is used as a functionality wrapper to work with all different types of tokens that the protocol supports, ERC20, ERC721, ERC1155 and ETH ( or th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Insufficient Validation
### Description
The [`spend_allowance` helper function](https://github.com/OpenZeppelin/stellar-contracts/blob/01dbcb53d3992570dba5faf517a3d0502ebf1254/contracts/token/fungible/src/storage.rs#L227) implemented in the `openzeppelin_fungible_token` crate deducts the given amount of tokens... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use `do while loops` instead of for loops
### Description
A `do while` loop will cost less gas since the condition is not being checked for the first iteration.
*There are 10 instances of this issue.* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: It Should Not Be Possible to `setContractACL` if `_allowedContractToFunctions` Does Not Have an Entry for Contract
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `dd77a1105ff26718d69b089e5c3fc50b21f12e5a`. The client provided the following explanation:
> Modified as recommended.
`_... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | token | false | false | ## Medium: `IdRegistry.transfer/transferFor()` might be revoked by a recovery address.
### Description
In every `fid`, there exists an owner and a recovery address, each possessing identical authority, enabling either one to modify the other.
But while transferring the `fid`, it just changes the owner and this scenari... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: 8] USDC Blacklist Can Trigger DoS in quexCallback() Function
### Description
**Severity:** Medium
**Path:** contracts/main/contracts/pool/UFarmPool.sol#L554
**Description:** The `UFarmPool.quexCallback()` function is responsible for processing all pending deposit and withdrawal requests from users. It it... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | rounding | true | true | ## Gas: Consider using stETH.getPooledEthByShares directly instead of passing through wstETH
### Description
The current implementation of `WstEthEthExchangeRateChainlinkAdapter.latestRoundData` queries the wstETH contract to get the wstETH/stETH conversion rate. The underlying logic of this function inside wstETH dir... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Do not calculate constants
### Description
Due to how constant variables are implemented (replacements at compile-time), an expression assigned to a constant variable is recomputed each time the variable is used, which wastes some gas.
https://github.com/code-423n4/2023-05-maia/blob/main/src/hermes/minters/B... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: User can grief bootstrap process by sending the cap amount of unlocked tokens to it.
### Description
The bootstrap process relies on users locking up all their tokens as it will only use tokens that are marked locked in `totals[MIM].locked` and `totals[USDB].locked`.
[BlastOnboardingBoot.sol#L96-L127](http... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary calls to Timelock when canceling unqueued proposals
### Description
At any time before a proposal is executed, it may be moved immediately to the canceled state by calling `cancel` in the `GovernorAlpha` contract. In the event that a proposal is already queued, then it must also be canceled in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: Redistributions can occur even if the Shrine is killed
### Description
The Aura protocol has steps to shut down gracefully. First, the `Caretaker::shut` function is invoked, which kills the `Shrine` and withdraws collateral from the `Gate` contract to the `Caretaker` contract. The amount of collateral withdra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Uncollected interest on NFTs not counted in liquidity calculation
### Description
When `getHypotheticalAccountLiquidityInternal()` is called to calculate whether a user's overall account is in good standing or has a shortfall, it calculates the value of their collateral (discounted by the collateral factor)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | signature | true | false | Source: https://github.com/sherlock-audit/2023-02-hats-judging/issues/124
## Found by
unforgiven, cducrest-brainbot
## Summary
to prevent reentrancy during the safe's `execTransaction()` function call code use `_guardEntries` and increase it in the `checkTransaction()` and decrease it in the `checkAfterExecution()`... | Sherlock | 5 | Hats |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: An unfavorable exchange may occur
### Description
At the lines:
https://github.com/lidofinance/anchor-collateral-steth/blob/8d52ce72cb42d48dff1851222e3b624c941ddb30/contracts/RewardsLiquidator.vy#L306-L308
and
https://github.com/lidofinance/anchor-collateral-steth/blob/8d52ce72cb42d48dff1851222e3b624c941... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: The result of function calls should be cached rather than re-calling the function
### Description
The instances below point to the second+ call of the function within a single function
*There is 1 instance of this issue:*
https://github.com/code-423n4/2022-10-blur/blob/2fdaa6e13b544c8c11d1c022a575f16c3a72e3b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: All `initialize()` functions are front-runnable in the solution
### Description
Consider adding some access control to them or deploying atomically or using constructor `initializer`: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Inattentive fork escrowers may lose funds to fork quitters
### Description
Fork escrowers already have their original DAO treasury pro rate funds transferred to the fork DAO treasury (when the fork executes) and are expected to `claimFromEscrow()` after the fork executes to mint their fork DAO tokens and th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: If an isolated borrower/bidder is blacklisted by the debt token, risk of DOS liquidation/auction of the corresponding loan
### Description
If a debt asset has a blacklisting feature (e.g., USDC), and an isolated borrower/bidder is blacklisted by the asset token, isolated liquidation/auction of the correspon... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Refactor nested EIP-712 code
### Description
The nested EIP-712 flow inlined functions that can be found in the Solady dependency. Solady's code has diverged by now. For ease of maintenance and to reduce mistakes from copying over the code, consider removing the inlined function and directly calling Solady's f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: getSwapFee and getUnstakedFee may return a value above their intended limits
### Description
The `enableTickSpacing` function caps the maximum fee at 100,000 pips (10%). The `getUnstakedFee` function, by default, returns 100,000 and should implicitly never return any value above 1,000,000 pips.
### Recommenda... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Anyone can remove all market’s dispute crowdsourcers
### Description
After an initial report is done, the tentative outcome for an Augur market can be disputed by any REP token holder during the market’s dispute round. Such dispute consists of staking REP tokens on an outcome other than the market’s current t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | false | false | ## High: `utilization` for `_getInterestRate()` does not factor in interest
### Description
The calculation for `utilization` in `_getInterestRate()` does not factor in the accrued interest. This leads to `_accrueInfo.interestPerSecond` being under-represented, and leading to incorrect interest rate calculation and po... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: `AiArenaHelper` constructor sets probabilities twice
### Description
Notice below that the constructor sets the probabilities twice:
```solidity
constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
addAttributeProbabilities(0, pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: stdweb is unmaintained
### Description
**Severity**: Informational
**Status**: Acknowledged
**File**: Cargo.lock
**Details**:
The author of the stdweb crate is unresponsive.
**Recommendation**:
Possible alternatives: wasm-bindgen, js-sys, web-sys | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: It is not possible to redeem right when the locking period ends
### Description
The [`_canRedeem` function](https://github.com/mcdexio/mai-fund-protocol/blob/98af0d1d7e9872ba2b5e734e2a43c161ef635608/contracts/component/ERC20CappedRedeemable.sol#L113-L122) in the `ERC20CappedRedeemable` contract implements a ch... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [N‑05] Constant redefined elsewhere
### Description
Consider defining in only one contract so that values cannot become out of sync when only one location is updated. A [cheap way](https://medium.com/coinmonks/gas-cost-of-solidity-library-functions-dbe0cedd4678) to store constants in a single location is to c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [G‑04] Avoid contract existence checks by using low level calls
### Description
Prior to 0.8.10 the compiler inserted extra code, including `EXTCODESIZE` (**100 gas**), to check for contract existence for external function calls. In more recent solidity versions, the compiler will not insert these checks if th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | critical | front-running | true | true | ## Critical: Liquidations can be made to revert by an attacker through various means, causing losses to liquidators and bad debt to accrue in the vault
### Description
Coordination between two malicious accounts combined with various other attack vectors fully documented in separate findings can be leveraged by an att... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Unprotected `reinitializer` function
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `d1818def1443874e7670f03ebe5e16f7370f7d18`.
**File(s) affected:**`src/clients/RecoveredLCPClientUpgradeable.sol`
**Description:** The `RecoveredLCPClientUpgradeable.upgrade()` is an unprotected `rei... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Duplicated require()/revert() checks should be refactored to a modifier or function
### Description
See [docs](https://solidity.readthedocs.io/en/develop/contracts.html#function-modifiers)
This saves deployement gas
https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/sr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Typos
### Description
**Severity** : Informational
**Status** : Acknowledged
**Description**
The revert string for require at L109 inside SakeVaultV2 should be "Sake: positionID is not valid.
The revert string for require at L207 inside SakeVaultV2 should be "Fee split cannot be more than 90%" instead. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: ERC2981 royalties discrepancy with strategy
### Description
In `Edition.sol`, functions that set the value of `works[tokenId].strategy` which includes `works[tokenId].strategy.royaltyBps` do not set ERC2981's internal token royalty value.
### Impact
The value returned by `works[tokenId].strategy.royaltyBps... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Lack of Deregistration Mechanism for TokenPairs
### Description
The [`TokenPairs contract`](https://github.com/Fantom-foundation/Bridge/blob/558465d3aba2ffae1a4436a2fc14c723b82926df/contracts/TokenPairs.sol) lacks a mechanism to remove registered token pairs. Without the ability to remove token pairs, the brid... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: TRST-M-3 Rewards may be stuck due to unchangeable slippage parameter
### Description
**Description:**
In NyPtvFantomWftmBooSpookyV2StrategyToUsdc.sol, MAX_SLIPPAGE is used to limit
slippage in trades of BOO tokens to USDC, for yield:
If slippage is not satisfied the entire transaction reverts. Since **MAX... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Attacker can deploy vaults with a malicious Staking contract
### Description
### Impact
Anyone can deploy a Vault with a malicious Staking contract attached. If the Staking contract already exists, we can just pass its address to `deployVault` and no checks will be applied to see whether the Staking contract... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Ownership Can Be Renounced
### Description
**Update**
From the team:
**File(s) affected:**`packages/protocol/contracts/core/balance-sheet/BalanceSheetV2.sol`, `packages/protocol/contracts/core/fintroller/Fintroller.sol`, `packages/protocol/contracts/core/h-token/HToken.sol`, `packages/protocol/contracts/orac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Unlimited DEFAULT_ADMIN_ROLE Power Over ADMIN_ROLE and WHITELISTED_ROLE
### Description
The intended hierarchy in the [`Whitelist`](https://github.com/LaChain/capyfi-sc/blob/cf47234ecffe0747f894dc73c4df15b78469b0bf/src/contracts/Access/Whitelist.sol#L13-L170) contract is that only users with `ADMIN_ROLE` can g... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: A depositor of the GMXVault can bypass paying the fee when the depositor deposit into the GMXVault.
### Description
The fee-minted in the form of shares (svTokens) would **not** be subtracted from the amount of shares (svTokens) to be minted to the GMXVault's depositor.
Due to that, a depositor of the GMXV... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Storage operations optimization ✓ Addressed
### Description
There are a lot of operations that write some value to the storage (uses `SSTORE` opcode) without actually changing it.
### Recommendation
Mitigated in [skalenetwork/skale-manager#179](https://github.com/skalenetwork/skale-manager/pull/179) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Race condition if PoolFactory deploy pools before fees are set
### Description
The `deployPool` function of the `PoolFactory` contract can deploy pools before the `changeInterval` value and minting and burning fees are set. This means that fees would not be subtracted. The exact boundaries for the `mintingFee`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: Dependency on Third-Party APIs to Create the Right Payload
### Description
The Socket system of routes and controllers integrates swaps, bridges, and potentially other solutions that are vastly different from each other. The function arguments that are required to execute them may often seem like a black bo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: addL1L2MessageHashes Allows L1 → L2 Messages to Be Censored and May Prevent Finalization
### Description
Due to the V1 method for processing L1 messages (`addL1L2MessageHashes`) still existing on L2 and being callable by the operator after the upgrade, two issues arise:
1. The rolling hash mechanism can b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Bypass or reduction on the lockup period of Pool FDTs.
### Description
In `Pool.sol`, the lockup restriction of withdrawal (`Pool.sol#396`) can be bypassed or reduced if new liquidity providers cooperate with existing ones.
1. A liquidity provider, Alice, deposits liquidity assets into the pool and minted ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: No deposit token validation
### Description
**Description**
Vesting.sol
Since the contract does not have any validation for deposit tokens, consider the usage of
SafeERC20 library for transfers of deposit token and ReentrancyGuard in order to prevent
reentrancy+fake token attack combination.
Potentially af... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Unusable unzap() Function Due To Missing Approval
### Description
The `unzap()` function of the BorpaGateway contract performs a swap with the wrong assumption that the DEX router has enough allowance of `tokenToSwap`. Therefore, this would effectivelly prevent anyone from using such functionallity. See the `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Version hash is not correctly enforced in code unpacker
### Description
In code unpacker, version hash is not correctly enforced.
### Proof of Concept
In code unpacker, we enforce that version hash is correct.
let version_hash_matches = UInt16::equals(cs, &chunks[1], &versioned_hash_top_16_bits);
sta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Duplicated logic in the anyone-can-pay lock contract
### Description
The `check_payment_unlock` function in the anyone-can-pay lock contract has a significant amount of duplicated logic. The same logic is used in two places (an input cell and an output cell) and loads the type hash, CKB amount, and UDT amount.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | false | false | ## High: The vault can be drained one share at a time
### Description
During the withdrawal process, users can specify the [amount of assets](https://github.com/pods-finance/yield-contracts/blob/9389ab46e9ecdd1ea1fd7228c9d9c6821c00f057/contracts/vaults/BaseVault.sol#L163-L167) to withdraw, which is then [rounded down ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: `AccountV1#flashActionByCreditor` can be used to drain assets from account without withdrawing
### Description
`AccountV1#flashActionByCreditor` is designed to allow atomic flash actions moving funds from the `owner` of the account. By making the account own itself, these arbitrary calls can be used to transf... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: [18] Function `settleWithBuyout()` incorrectly calculate the main lender because single lender can have multiple tranches in a loan
### Description
*Note: At the judge’s request [here](https://github.com/code-423n4/2024-04-gondi-findings/issues/70#issuecomment-2067964983), this downgraded issue from the same w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Changes to Pyth entropy provider used by `ScaledEntropyProvider` allow attacker to fix jackpot result
### Description
### Finding description and impact
When the `Jackpot` requests entropy from the `ScaledEntropyProvider` during `Jackpot::runJackpot`, the `ScaledEntropyProvider` tracks each request by the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: SafeTransferLib.permit2 is not capable of revoking approvals for DAI
### Description
The `SafeTransferLib.permit2` method acts as a gas optimized dispatcher to the ERC2612 permit method which can additionally fall back to calling Uniswap's Permit2 to submit a previously signed approval adhering to either the E... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | other | true | false | Source: https://github.com/sherlock-audit/2023-03-taurus-judging/issues/149
## Found by
SunSec, GimelSec, chaduke, shaka, tvdung94, Ruhum, cducrest-brainbot, nobody2018, Chinmay, duc, LethL, y1cunhui, mstpr-brainbot, HonorLt, 8olidity, bytes032
## Summary
Upon burning TAU, it incorrectly updates the `currentMinted... | Sherlock | 5 | Taurus |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: WE SUGGEST USING A MORE RECENT SOLIDITY PRAGMA TO TAKE ADVANTAGE
### Description
We recommend using a more recent version of Solidity, such as 0.8.18, to take advantage of the latest improvements and features, including better code readability in the case of mappings.
You have 19 mappings in the scope.
For e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: TRST-H-8 “Exact output” swaps cannot be executed, blocking repayment of debt
### Description
**Description:**
When performing “exact output” swaps via Uniswap V2 and V3, the maximum input amount
argument (**amountInMax** when calling Uniswap V2’s `swapTokensForExactTokens()`,
**amountInMaximum** when callin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: M13] Unbounded loops
### Description
###### Medium
Multiple `for` loops are bounded by a variable that does not have a maximum value:
* In `CurrencyGovernance`, the loops in [L266](https://github.com/BeamNetwork/currency/blob/51b65c5c7af455391af2bc30d13d761566d8c236/contracts/inflation/CurrencyGovernanc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: EIP-712 name and project symbol are misaligned
### Description
The [symbol](https://github.com/OneWpOrg/audit-2024-10-oneworld/blob/416630e46ea6f0e9bd9bdd0aea6a48119d0b515a/contracts/dao/MembershipFactory.sol#L69) used for the `MembershipERC1155` token is `1WP`; however, `OWP` is used in the EIP-712 [name decl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: No null checks for recipient in s_referrerConfig
### Description
If `recipient` in `s_referrerConfig` is a null address, then there is no need to calculate `referrerAmount`, because `referrerAmount` will always be 0.
Also, `referrerAmount` will be redundant for `serviceAmount`. Additionaly, we can bypass calli... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Misconfigured Owner Leads to No Liquid Accessories
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `0b9529b307ddf1e0dcfac05d00a4f95d107434a8`.
**File(s) affected:**`LiquidAccessories.sol`, `Deployer.sol`
**Description:**`LiquidAccessories` is an `Ownable` contract that transfers ow... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | flash-loan | false | false | ## Low: Flash Loan Accessibility Restriction
### Description
## Lending Pool Functions
In `lending_pool`, `start_flashloan`, and `end_flashloan` are marked as `public(friend)`, implying they may only be called by other modules or addresses that are designated as friends of the module, not by external users directly. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Malicious User can dilute staking Rewards to a longer timeframe
### Description
The `SymmStaking` contract allows anyone to add new rewards using the `notifyRewardAmount` function. However, if new rewards are continuously added while existing rewards are still active, the total rewards get spread over a lon... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Liquidation is not validated at the right time.
### Description
**Severity**: Critical
**Status**: Resolved
**Description**
When a user calls `increasePosition()` within the TradeFacet.sol it is validated if the position is liquidable or not before the updates of the position have been applied.
Consider ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Use nested if and, avoid multiple check combinations
### Description
Using nested is cheaper than using && multiple check combinations. There are more advantages, such as easier to read code and better coverage reports.
5 results - 2 files:
[EntryPoint.sol#L303](https://github.com/code-423n4/2023-01-biconomy... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Messages with non-printable characters are displayed incorrectly in personal_sign request
### Description
The Uniswap wallet browser extension opens a pop-up dialog box when a dapp requests a signature using the JavaScript Ethereum API. The dialog box displays a message to be signed to a user. The message is s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate
### Description
Saves a storage slot for the mapping. Depending on the circumstances and sizes of types, can avoid a Gsset (**20000 gas**) per mapping combined. Reads and subsequent writes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Centralization Risk for trusted owners
### Description
Some smart contracts under analysis have owners with privileged rights to perform administrative operations and need to be trusted to not act maliciously.
- contracts/BaseTokenLock.sol [Line: 20](contracts/BaseTokenLock.sol#L20)
```
abstract contract Ba... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Unreachable code path in `RoyaltyEngine::_getRoyaltyAndSpec`
### Description
Within `RoyaltyEngine`, `int16` values have been copied over from the manifold contract for use as enum values relating to different royalty specifications with `int16 private constant NONE = -1;` and `int16 private constant NOT_CONFI... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: The `colRedeemed` variable is wrongly retrieved in `LibBytes::readProposalData` function
### Description
The `LibBytes::readProposalData` function uses inline assembly for efficient data extraction from a byte array. The `colRedeemed` variable, which represents an 11-byte value within the `ProposalData` str... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Stale split ratios in UniversalBuyback
### Description
The `gulp` and `pendingBurning` functions of the `UniversalBuyback` contract use the hardcoded, constant values of `DEFAULT_REWARD_BUYBACK1_SHARE` and `DEFAULT_REWARD_BUYBACK2_SHARE` to determine the ratio the trade value is split with.
Consequently, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Lack of Encryption for Stored Session Data
### Description
Storing sensitive information, such as session data, without encryption can expose it to unauthorized access if the storage mechanism is compromised.
In `storage.ts`, session data was stored in `chrome.storage.session` without encryption, which cou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Incorrect Bit Masking and Shifting Operations for uint128 SID Handling
### Description
The **SidLibrary** library is designed to perform operations on a **uint128 SID** (Security Identifier) by extracting specific components such as chain ID, protocol ID, and pool ID from the SID. However, the library defines ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: currentepoch - Unnecesary Conversion From/to String ✓ Fixed
### Description
It is unclear why `currentepoch` is declared as `String` while calculations require it to be numerical.
### Recommendation
fixed in [ethereum-push-notification-service/push-protocol-snaps@1a6a32ef760088ca59f73e555f41b5b5d871f761](htt... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [04] With the expiration period update, the proposals will become expired
### Description
Proposals become expired if no one has executed them during the expiration period. After that we will have to delete the proposal, add it again and wait for the delay. Suppose that the expiration period is set to 5 days,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Lack of PDA Validation
### Description
## Token Pool PDA Validation Issue
In both `MintToInstruction` and `TransferInstruction`, the `token_pool_pda` account is included as a mutable account but does not undergo any seed validation or authority checks. This implies that there are no checks to ensure that `to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Unused slippage params
### Description
_Submitted by pauliax, also found by TomFrenchBlockchain_
#### Impact
Unused slippage params.
function `addLiquidity` in VaderRouter (both V1 and V2) do not use slippage parameters:
making it susceptible to sandwich attacks / MEV.
For a more detailed explanation, see... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Refunds sent to incorrect addresses in certain cases
### Description
The [`_processClaim`](https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L723) internal function is responsible for calling the `claimFromFactory` function in the art contract, transf... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `RECOVERY_ADDRESS` zero address check
### Description
Constructor: missing `RECOVERY_ADDRESS` zero check. https://github.com/MetaLex-Tech/borg-core/blob/9074503d37cfa1d777ef16f6c88b84c98b4f54eb/src/implants/failSafeImplant.sol#L52
### Recommendation
We recommend adding parameters checks from the description. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Clickjacking and Missing Content Security Policy ✓ Fixed
### Description
A content security policy (CSP) provides an added layer of protection against cross-site scripting (XSS), clickjacking, and other client-side attacks that rely on executing malicious content in the context of the website.
Specifically,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | true | ## Low: `FeeCollector::updateFeeType` wrong fee share validation leads to impossible update for some fee types
### Description
The `FeeCollector::updateFeeType` updates parameters for a specific fee type. Each fee type has shares that determine how the collected fees are distributed among different stakeholders (`veRA... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | initialization | false | false | ##### Description
The `StrategyBaseUpgradeable` contract inherits from `OwnableUpgradeable`, `ReentrancyGuardUpgradeable` and `UUPSUpgradeable`, but only calls the initializers for `OwnableUpgradeable` (`__Ownable_init`) and `UUPSUpgradeable` (`__UUPSUpgradeable_init`) within its `__StrategyBase_init()` function. This... | Halborn | 4 | ION Strategies v1 |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Missing Gas Claim Functionality
### Description
## BazaarManagerBlast Gas Claiming Issue
The current implementation of `BazaarManagerBlast` does not explicitly include a method for claiming gas. The constructor calls `configureClaimableGas` on the `BLAST` instance; however, the contract lacks a dedicated m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Reward sniffing
### Description
User can deposit-withdraw tokens several times (at the same transaction), causing reward sniffing.
The emulation of this behavior is presented below:
```python
def main():
deployer = accounts[0]
workerOwner = accounts[1]
escrow = deployer.deploy(StakingEscrowMock)
es... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Inconsistencies In Asset Transfer
### Description
## TokenBridgeUtilities
TokenBridgeUtilities normalizes asset transfer amounts with decimals exceeding eight before sending them and denormalizes the received amount upon reception. This process ensures consistency in handling asset amounts with different d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Params has both value and reference receivers
### Description
Params has two methods, one uses pointer and the other a value reciver. GoLang documentation recommends choosing either one or the other.
(Arguments being consistency, readability and performance)
https://go.dev/doc/faq#methods_on_values_or_pointers... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Fixed Amount of Gas Sent in Call May Be Insufficient
### Description
_Submitted by kirk-baird_
### Impact
The function `attemptETHTransfer()` makes a call with a fixed amount of gas, 30,000. If the receiver is a contract this may be insufficient to process the `receive()` function. As a result the user wo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: Runtime cost can be optimized in detriment of the deploy cost
### Description
There are two optimization to improve runtime cost. Although the following optimizations will increase the gas cost of new pair creation and certain admin functions, it will decrease runtime cost of core protocol functions (swap, add... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Using vulnerable version of OpenZeppelin
### Description
The brownie configuration file says that the project is using 3.4.0 of OpenZeppelin which [has a vulnerability](https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-9c22-pwxw-p6hx) in initializers that call external contracts, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: bitcoin.waitForPayment function callback could be called multiple times
### Description
[waitForPayment function of bitcoin.js module in fundraiser-lib](https://github.com/cosmos/fundraiser-lib/blob/426425dfc296060a9b87830e69e19ae8a6d444c0/src/bitcoin.js#L60) doesn’t handle correctly requests that take long... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Premium owed can be calculated as a very big number due to reentrancy on uninitialized pools
### Description
When minting or burning a position, an attacker can take advantage of reentrancy to make the pool has more `removedLiquidity` than it has. This would make the owed premium to be mistakenly very high ... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.