prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use explicit sizes instead of `uint`
### Description
**Description:** While `uint` defaults to `uint256`, it is considered good practice to use the explicit types including the size and to avoid using `uint`:
**Strata:** Fixed in commit [61f5910](https://github.com/Strata-Money/contracts/commit/61f591088754e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: _checkUniswapRateDifference may not use highest percentage difference
### Description
The [`_checkUniswapRateDifference`](https://github.com/swapnet-protocol/swapnet-lite/blob/66ce8f3e529410a5272b7a57c8391fcb80a375fd/packages/contracts/contracts/Escrow.sol#L1087) function calculates [`rateDiff`](https://github... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Constants should be in uppercase
### Description
[EllipticCurve.sol#L21-L35](https://github.com/code-423n4/2023-04-ens/blob/45ea10bacb2a398e14d711fe28d1738271cd7640/contracts/dnssec-oracle/algorithms/EllipticCurve.sol#L21-L35) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Outdated Solidity Version
### Description
**Update**
The version of Solidity has been updated to 0.8.18 as recommended.
Commit: `c9fbc6d7bbe93ba0a508fa79ed628c35172b7431`
**File(s) affected:**`*.sol`
**Description:** As security standards develop, so does the Solidity language. To stay up to date with curre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Unnecessary Use of `SafeMath` in Solidity 0.8.x
### Description
**Update**
Fixed in commit `b98e1d0e868b1349938f111bf3317ffc3ee22a27`.
**File(s) affected:**`StorageOperator.sol`
**Description:** This is generally unnecessary in the Solidity version above 0.8 because the integer overflow problem is properly a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Improper Tank Value Update
### Description
## Claiming Collateral in the Tank Module
The `claim_collateral` function in the tank module claims the collateral gained from liquidations. After claiming the collateral on a `ContributorToken`, `start_s` updates to indicate the claim of collateral up to that poi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: `<x> += <y>` costs more gas than `<x> = <x> + <y>` for state variables
### Description
Using the addition operator instead of plus-equals saves gas
- [WithdrawHook.sol#L64](https://github.com/prepo-io/prepo-monorepo/blob/feat/2022-12-prepo/apps/smart-contracts/core/contracts/WithdrawHook.sol#L64)
- [WithdrawH... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Excessive Oracle Stale Time
### Description
The current time to stale for the oracle price is 60 seconds, which seems unnecessarily high. This can lead to price discrepancies if the market is too volatile.
### Recommendation
It is recommended to decrease the time to stale for the oracle price from 60 seconds ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Incorrect BorrowRate Updating In UpdateStates
### Description
## InSpotEngineStates's `_updateState` Function
For the `utilRatio > interestInflection`, the equation is acting improperly in certain cases.
**File:** contracts/SpotEngineStates.sol (SOLIDITY)
Since `utilRatio = borrow / deposit`, it may equal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Unsafe cast in `WellPrice::getDeltaB`
### Description
While not likely to overflow, there is an [unsafe cast](https://github.com/BeanstalkFarms/Beanstalk/blob/12c608a22535e3a1fe379db1153185fe43851ea7/protocol/contracts/ecosystem/price/WellPrice.sol#L97) in `WellPrice::getDeltaB` which could be replaced with a ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Route not verified in FeeReducer buyBackBurn.
### Description
**Description**
FeeReducer.sol: function buyBackBurn(). The function is supposed to swap TEN token and burn the balance of MyShare token. Thus, the route is supposed to start with TEN token and end with MyShare token and should be validated.
**Rec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Use constants instead of type(uintx).max
### Description
using type(uintx).max can result in higher gas costs because it involves a runtime operation to calculate the maximum value at runtime. This calculation is performed every time the expression is evaluated.
To save gas, it is recommended to use constants... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Withdrawal with zero amount is possible ✓ Fixed
### Description
When creating a withdrawal request, the amount of tokens to withdraw is passed as a parameter:
**code/contracts/PolicyBook.sol:L358**
```
function requestWithdrawal(uint256 \_tokensToWithdraw) external override {
```
The problem is that th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | input-validation | false | false | ## Low: Lack of validation to prevent receiving less LINEA tokens for the swap than the expected `minAmountOut`
### Description
There is no validation on the [`V3DexSwap::swap` ](https://github.com/Consensys/linea-monorepo/blob/8285efababe0689aec5f0a21a28212d9d22df22e/contracts/src/operational/V3DexSwap.sol#L50-L74)to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Users can withdraw the same stake more than once with the emergency withdrawal function.
### Description
**Description**
TokensFarm.sol: function emergencyWithdraw().
Perpetual TokensFarm.sol: function emergencyWithdraw(). Users can execute the emergencyWithdraw() function with the same stake, even when the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Vaults can be griefed to not be able to be used for deposits
### Description
Interaction with SavETHVault and StakingFundsVault require a minimum amount of `MIN_STAKING_AMOUNT`. In order to be used for staking, there needs to be 24 ETH or 4 ETH for the desired BLS public key in those vaults. The issue is th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: `_withdrawToChain()` will refund excess gas for LZ call to the wrong address
### Description
**Severity**
**Impact:** Medium, as refunded gas will be lost
**Likelihood:** Medium, happens for certain cases when performing cross chain withdrawals
**Description**
As `MagnetarMarketModule._withdrawToChain()... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Incorrect bond/stablecoin pair decimals assumptions in `OracleUniGeoDistribution`
### Description
**Description:** The `OracleUniGeoDistribution` intends to compute a geometric or uniform distribution with two limits; one is arbitrarily set by the owner, and the other is derived from an external price oracl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | true | false | ## High: Withdrawal requests through deposit pool lost permanently
### Description
The `requestWithdrawal()` function in `ElytraDepositPoolV1` creates withdrawal requests that will be permanently lost due to incorrect user address tracking. When a user calls `requestWithdrawal()`, the deposit pool transfers the user's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Incorrect type conversion in the contract `ABC` makes users unable to burn FSD tokens
### Description
The function `_calculateDeltaOfFSD` of contract `ABC` incorrectly converts an `int256` type parameter, `_reserveDelta`, to `uint256` by explicit conversion, which in general results in an extremely large numb... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Centralization Risk For Trusted Owners
### Description
The smart contracts under analysis have owners with privileged rights to perform administrative operations and need to be trusted not to act maliciously.
- src/Governance/MultichainGovernor/MultichainVoteCollection.sol [Line: 371]
```
function setGasL... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Subsequent rounds of winner selection is blocked for a pot
### Description
The second call to `rotateLiquidity()` for a pot reverts due to the call to `entropy.reveal()`. Once a `sequenceNumber` is used, `entropy` reverts if it’s used again as it clears the request. Hence, a pot cannot be used to select a win... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | true | true | ## Medium: Investors transferring all their balances among their wallets or self-transferring on the same wallet causes to incorrectly decrement the investor counters causing DoS for other investors transfers
### Description
`ComplianceServiceRegulated::recordTransfer()` is in charge of adjusting the investor counters... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | true | false | ## Low: Incorrect calculation in `getGlobalData`
### Description
The `getGlobalData` function exposes data from the contract, including the amounts of input tokens and ULTI tokens currently in the liquidity pool.
The calculation of these values is done in the `_getLiquidityAmounts` function:
However, the value obt... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Protocol will leak value to users due to rounding in `SecuritizeSwap::buy`
### Description
**Description:** Protocols should always round against users in favor of the protocol. The `buy` function in the `SecuritizeSwap.sol` is rounding the stable coin need it in favor of the user:
With this rounding down, i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: The claimable rewards amount for borrowers decreases over time
### Description
The `RewardsController` handles the distribution of `rewards` for both `borrowers` and `depositors`.
Once `rewards` are assigned to users, they should not be changed, as is typical in most `rewards distribution system`.
However, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Valid transactions cannot be enqueued
### Description
Transactions to be appended to the Canonical Transaction Chain (CTC) can come from two sources: the L1 queue and the Sequencer. When transactions are enqueued in the `OVM_CanonicalTransactionChain` contract via its public [`enqueue` function](https://githu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: No entry checks in crossSwap[Exact]TokensFor[Exact]Tokens
### Description
The functions crossSwapTokensForExactTokens and crossSwapExactTokensForTokens of MarginRouter.sol do not check who is calling the function. They also do not check the contents of pairs and tokens nor do they check if the size of pairs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | rounding | true | false | ## Gas: _decimalsOffset() related code can be simplified
### Description
The value of `_decimalsOffset()` is `0` which is compatible with `decimals()`. So this value won't change.
### Recommendation
Consider simplifying the code to make it more readable while also saving gas:
```solidity
function _convertToShares(uin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: MarinateV2.sol may hold unrecoverable balances after token/NFT removal.
### Description
**Description**
MarinateV2.sol - removeApproved Reward Token & removeApproved Multiplier Token, MarinateV2 still holds balances of NFTs and reward tokens after removal and can not be dealt with using normal circumstance... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Inverted Merkle Proof Verification in claimLogic
### Description
A critical flaw in the `claimLogic` function in `EpochDistributor.sol` inverts the result of the Merkle proof check, causing valid proofs to fail and invalid proofs to succeed.
### Recommendation
Replace the inverted check:
```solidity
require(
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Storage variable unstreamed can be artificially inflated
### Description
_Submitted by harleythedog, also found by csanuragjain, gpersoon, hubble, and WatchPug_
#### Impact
The storage variable `unstreamed` keeps track of the global amount of deposit token in the contract that have not been streamed yet. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Centralization vulnerabilities are present in the protocol
### Description
**Severity**
**Impact:**
High, as it can lead to a rug pull
**Likelihood:**
Low, as it requires a compromised or a malicious owner
**Description**
The `owner` of `BatonLaunchpad` has total control of the `nftImplementation` and `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Malicious actors can exploit user-approved allowances on `VaultRouter` to drain their ERC20 tokens
### Description
### Finding description and impact
Once a user approves `VaultRouter` to spend their ERC20 tokens, anyone could call `VaultRouter# execute()` to drain the user’s ERC20 assets.
### Proof of Conc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: stipend for external call might be insufficient and lead to stuck ETH
### Description
**Proof of Concept**
The way the Zerem protocol transfers out ETH looks like this
As you see, there is a gas stipend of 3000, but this might not be enough in some cases as some smart contract recipients need more than 3... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Milestone Index Validation Before Access
### Description
This issue has been identified in the `confirmMilestone` function of the [BaseAllocation](https://github.com/MetaLex-Tech/MetaVesT/blob/b614405e60bce8b852e46d06c03fd47b04d86dde/src/BaseAllocation.sol#L223-L243) contract.
The function does not adequatel... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Yin cannot be pulled out of the Absorber if the Shrine is killed
### Description
When the system is shut down, the Caretaker module is responsible for withdrawing as much collateral as possible to back the yin supply as close to 1:1 as possible. To do this, the `shut` function is called. It will mint any fina... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: 4] Order fulfillment can be front-ran to steal from taker using reinitialization
### Description
**Severity:** Critical
**Path:** programs/fusion-swap/src/lib.rs#L106-L258
**Description:**
The Fusion Swap program allows a user to create an order and cancel an order permissionlessly, containing some set of c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Range for variables not set
### Description
Range for variables is not set:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/tokens/Vesting.sol#L45
### Recommendation
We recommend to add allowable range for variables | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Certain command sequences invoked via `UniswapV4Router` can be griefed
### Description
_Acknowledged_
The `ActionConstants.CONTRACT_BALANCE` flag is used to indicate that the router should use its own internal balance for the specified token amount. This implies that the user has previously transferred the ne... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: [05] Potential mis-pricing when a token gets removed/deregistered from a Balancer pool
### Description
In the constructor:
These token addresses are then used in price calculations:
The BalancerOracle contract stores token addresses as immutable variables in the constructor. However, if a token is deregist... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Missing Import of Events, Structs, and Enums from Contract to ABI
### Description
The [`renderSystemInterface` function](https://github.com/latticexyz/mud/blob/f6133591a86eb169a7b1b2b8d342733a887af610/packages/world/ts/node/render-solidity/renderSystemInterface.ts#L16-L27) automatically generates an interface ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Reentry in `withdrawAll`
### Description
Malicious token/workerOwner may have a reentry callback to the contract here
https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking_contracts/PoolingStakingContractV2.sol#L236
but the state of the contract changes here
ht... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: No way to set UsdTokenSwapConfig pd curve parameters
### Description
There is no way to set pd curve parameters of `UsdTokenSwapConfig`. This will result in division by zero panic when users try to swap usd token to collateral asset.
### Impact
* Important parameters are missing from protocol
* Once vault ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: Uniswap oracle manipulation to buy for a lower price
### Description
**Severity**
**Impact:** High
**Likelihood:** High
**Description**
`uniswapV2Router.getAmountsIn()` is used to calculate the amount of `paymentToken` required for the amount in `referenceToken`.
This feed is easily manipulated by a large... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Centralization risk due to owner setting the protocol contracts
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
In Contract AFiStorage.sol, the owner can set the protocol contracts for aave, compound and dydx using afiSync(...) method.
A malicious owner can utilize this to set ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: ER_UPDATE_FREQUENCY_BOUND is set much lower than Starknet block time
### Description
To monitor and determine the frequency with which price feeds for a given yang in the Shrine can be updated per block (using the `update_price` function), the Seer module has an `update_frequency` state variable. Currently, th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Sum of normalized weights can be di�ferent from 1
### Description
The weighted pool token normalizes token weights such that a weight is a percentage of the tokens’ total weight. The computation expects the sum of all weights to be equal to 1, but rounding may result in a different sum.
To compute normalized ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Missing admin input sanitization
### Description
**Likelihood:**
Low, because it requires a malicious/compromised admin or an error on admin side
**Impact:**
High, because important protocol functionality can be bricked
**Description**
It is not checked that the `claimTimeout` property in `LP.sol` both i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Initializers are missing lock mechanism
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
Contracts Ve and veVC are missing a lock mechanism for the initialize function. It is part of best practices and recommandations to lock all your initializers, the lock mechanism can be added... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Function’s return value is incorrect
### Description
**Severity**: High
**Status**: Resolved
**Description**
From the docs it can be observed that the `_withdrawFromTarget` function should `return a boolean that evaluates to true if the full withdrawalAmount could be withdrawn fro the withdrawTarget.` Ho... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | true | ## Medium: LToken's implmentation is not fully up to EIP-4626's specification
### Description
Note: This issue is a part of the extra scope added by Sentiment AFTER the audit contest. This scope was only reviewed by WatchPug and relates to these three PRs:
1. [Lending deposit cap](https://github.com/sentimentxyz/prot... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: curve admin can drain pool via reentrancy (equal to execute emergency withdraw and rug tokenmak fund by third party)
### Description
Source: https://github.com/sherlock-audit/2023-06-tokemak-judging/issues/862
## Found by
ctf\_sec
curve admin can drain pool via reentrancy (equal to execute emergency wit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: CoreCollection can be reinitialized
### Description
_Submitted by hyh, also found by 0xkatana, hubble, kirk-baird, leastwood, pedroais, rayn, rfa, Ruhum, saian, securerodd, and WatchPug_
Reinitialization is possible for CoreCollection as `initialize` function sets `initialized` flag, but doesn't control for ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Avoid reverts which break specs
### Description
In LSP0ERC725AccountCore's `isValidSignature()`, when owner is an EOA, ECDSA.recover() is
used to fetch the signer. However, that function will revert if the signature is invalid. This
function should only return **MAGICVALUE** or **FAILVALUE**, so it would be ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: The rewards distribution in the NFTPositionManager is unfair
### Description
In `NFTPositionManager`, users can `deposit` or `borrow` `assets` and earn `rewards` in `zero`.
However, the distribution of these `rewards` is not working correctly.
### Recommendation
```solidity
function _supply(AssetOperationP... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Liquidating Morpho's Aave position leads to state desync
### Description
Morpho has a single position on Aave that encompasses all of Morpho's individual user positions that are on the pool. When this Aave Morpho position is liquidated, the user position state tracked in Morpho desyncs from the actual Aave po... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Optimize Zero Fixed Point
### Description
## Fixed Point Object Representation
In `fixed_point32.move`, `zero` creates a fixed point object representing zero utilizing `fixed_point32::create_from_rational(0, 1)`. However, a simpler approach exists. `fixed_point32::create_from_raw_value(0)` may directly genera... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Validation On Linked Messengers
### Description
In the `SpokePool` contract, there is no standard way of checking whether a contract supports specific interfaces or features. In particular, when adding a messenger, the [single check](https://github.com/across-protocol/contracts/blob/c5d7541037d19053ce2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Loss of accrued interest on updating InterestRateModel
### Description
When the `InterestRateModel` is changed for the `LendingPool` in the `Repository`, `LendingPool._accrueInterest()` is not automatically called, which could lead to a loss of accrued interest for both borrowers and suppliers.
### Recomme... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | true | true | ## Medium: Proposal execution can be DOSed with return bombs when calling untrusted execution contracts
### Description
`GovPool::execute` does not check for return bombs when executing a low-level call. A return bomb is a large bytes array that expands the memory so much that any attempt to execute the transaction wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using storage instead of memory for structs/arrays saves gas
### Description
When fetching data from a storage location, assigning the data to a memory variable causes all fields of the struct/array to be read from storage, which incurs a Gcoldsload (2100 gas) for each field of the struct/array. If the fields ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Insufficient Bid Fund Assertion
### Description
## Verifying Auction Bid Transactions
One of the most crucial aspects in verifying the validity of an auction bid transaction is to ensure that the bidder has a sufficient balance to cover the bid. In the original implementation, this is done by comparing the bi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | flash-loan | false | false | ## Low: Liquidator may prefer Redistribution
### Description
**Impact**
Liquity V2 introduces 2 different premiums for liquidators
Liquidations can be profitable or unprofitable both for SP stakers and for Redistributed Troves, profitability is not a factor, only the liquidity in the SP is
Assuming that LIQUIDATION... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: The Escrow’s owner can arbitrarily increase the balance of any job without spending RNDR tokens
### Description
In the`Escrow` contract, the address of the associated token contract is tracked by the [`renderTokenAddress`](https://github.com/jeualvarez/Token-Audit/blob/e946177747e57312690775204834b8fca1bbb0d5... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Users can get immediate profit when deposit and redeem in `PerpetualAtlanticVaultLP`
### Description
Due to wrong order between `previewDeposit` and `updateFunding` inside `PerpetualAtlanticVaultLP.deposit`. In some case, user can get immediate profit when call `deposit` and `redeem` in the same block.
### P... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: ChainlinkFactory will pay non-requested versions keeper fees
### Description
Protocol definition: `Requested versions will pay out a keeper fee, non-requested versions will not.`
But ChainlinkFactory ignores `numRequested`, which pays for both.
### Impact
If `non-requested versions` will pay as well, it is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | true | false | ## High: Transferred NFTs May Be Missing Royalty Vault
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `efb615e3aef4e38ad324b2e9be5c5da16f0e7c83`.
**File(s) affected:**`IpNFT.sol`
**Description:** The token owners receive royalty payments for subscriptions, and may also be rewarded for disp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: Reentrancy from `matchOneToManyOrders`
### Description
_Submitted by kenzo, also found by 0xDjango_
### Vulnerability Details
`matchOneToManyOrders` doesn't conform to Checks-Effects-Interactions pattern, and updates the maker order nonce only after the NFTs and payment have been sent.
Using this, a malici... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Auction winner can prevent payments via `safeTransferFrom` callback
### Description
An auction winner can decide to conditionally revert the `claimAuction()` execution.
This leads to the following impacts:
- Other bidders can't get their funds back
- The protocol doesn't receive the funds from the winning... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Crank Reimbursement Edge Case
### Description
## Reimbursement Calculation Issue
After the target program invocation, in certain edge cases, the signatory might receive additional lamports. As a result, the following reimbursement calculation might abort due to the use of `checked_sub`.
## Code Example
## ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Redundant checks
### Description
**Severity**: Low
**Status**: Resolved
**Description**
Redundant check on line: 265:
if (assetAmt == 0) revert Errors.InsufficientDepositAmount();
This check is redundant because lines: 262 and 263 already cover the scenario for the check on line: 265. And thus can be remov... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Checked increments in for loops increases gas consumption
### Description
Most of the solidity for loops use an **uint256** variable counter that increments by 1 and starts at 0. These increments don't need to be checked for over/underflow because the variable will never reach the max capacity of **uint256** a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: StrategyCvxHelper: safeApprove instead of approve
### Description
## Handle
hickuphh3
## Vulnerability details
### Impact
This was probably an oversight since
- the veCVXStrategy contract used `safeApprove()` for token approvals
- `using SafeERC20Upgradeable for IERC20Upgradeable;` was declared
### Reco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Permissionless `sendCurrentOperatorsKeys()`
### Description
## Severity
**Impact:** High
**Likelihood:** Medium
## Description
### The First impact
The `Middleware.sendCurrentOperatorsKeys()` function is permissionless, meaning any external actor can call it. This function triggers the `Gateway.sendOpera... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Incorrect implementation of the onDropMessage function in the L1ReverseCustomGateway contract
### Description
Source: https://github.com/sherlock-audit/2024-08-morphl2-judging/issues/66
## Found by
0xRajkumar, mstpr-brainbot, sammy
## Summary and Vulnerability Detail
In the L1ReverseCustomGateway, tokens a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | signature | true | false | ## Gas: In `NonceHolder.sol`, ID mappings can be combined into a single `mapping` of an ID to a `struct`
### Description
**File:** `NonceHolder.sol`
[File: code/system-contracts/contracts/NonceHolder.sol](https://github.com/code-423n4/2024-03-zksync/blob/main/code/system-contracts/contracts/NonceHolder.sol#L36) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary public visibility in some functions which are not used locally in the contracts.
### Description
**Recommendation**:
Change the public with external visibility for functions that are not used locally in the contracts
to reduce gas costs. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: [13] DoS attack
### Description
In the long-term malicious addresses can keep reserving one big period or multiple small ones. By triggering `execute.rs#setreservationforlongterm()`, the attacker will only lose the gas fee
because the logic doesn't for users to deposit funds first in order to reserve for long-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use of Excessive Digits for Variable Assignments
### Description
The `issueFeeRate` and `interestRate` variables are assigned with an excessive number of digits. This representation is prone to errors and complicates the review process.
### Recommendation
The recommendation above was implemented by the develo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `StrategySupplyBase.undeploy` does not return the amount of assets actually undeployed, which can cause a withdrawal to fail
### Description
### Finding description and impact
The `StrategySupplyBase.undeploy` function returns the user’s requested amount instead of the actual withdrawn asset amount. When a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: Remove or replace unused state variables
### Description
Saves a storage slot. If the variable is assigned a non-zero value, saves Gsset (20000 gas). If it's assigned a zero value, saves Gsreset (2900 gas). If the variable remains unassigned, there is no gas savings. If the state variable is overriding an inte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: MustAccAddressFromBech32 can panic unexpectedly in the keeper package
### Description
In the current implementation of the keeper package, the utility function utils.**MustAccAddressFromBech32** is used to convert Bech32 encoded addresses to sdk.**AccAddress** in multiple locations (e.g., **SaveVoting, Finaliz... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Break out of `LibWhitelist ` loops early once the condition is met
### Description
Once the given address is found in the array passed to `LibWhitelist::checkTokenInArray` or `LibWhitelist::checkTokenNotInArray`, these functions could break early to avoid potentially unnecessary additional loop iterations. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Usage of Insecure Approval Functions
### Description
Throughout the [codebase](https://github.com/radiant-capital/v2-core/tree/e8f21f103e17736907b62809d1ad902febc53714/contracts/radiant) there are multiple instances of insecure approvals that may lead to security issues:
* Function [`swapToWeth`](https://git... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: Refund recipient defaults to inaccessible address for contracts
### Description
In [`_requestL2Transaction`](https://github.com/matter-labs/zksync-2-contracts/blob/3f345ce52bc378c4b5d710c80d817db170775049/ethereum/contracts/zksync/facets/Mailbox.sol#L301), if `address(0)` is specified as the refund recipien... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | true | ## Medium: An attacker can manipulate `omniChainData.cdsPoolValue` by breaking protocol.
### Description
Missing update of `lastEthprice` in `borrowing.sol#depositTokens()` will cause manipulation of `omniChainData.cdsPoolValue` as an attaker replays `borrowing.sol#depositTokens()` by breaking protocol.
https://githu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: EVM STACK LIMIT SURPASSED
### Description
The EVM stack is a maximum of 16 deep. Every variable that is created will get pushed onto the stack. This includes function parameters and local variables. The Lord constructor uses too many parameters and local variables, which causes the following error to be displa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: USDO’s MSG_TAP_EXERCISE compose messages where exercised options must be withdrawn to another chain will always fail due to wrongly requiring sendParam's to address to be whitelisted in the Cluster
### Description
Wrongly checking for the sendParam's `to` address to be whitelisted when bridging exercised op... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Incorrect assumption that Chainlink price feeds will always have the same decimals
### Description
**Description:** There are several instances [[1](https://github.com/Benqi-fi/ignite-contracts/blob/bbca0ddb399225f378c1d774fb70a7486e655eea/src/Ignite.sol#L227), [2](https://github.com/Benqi-fi/ignite-contracts/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: No Need To Initialize Variables With Default Values
### Description
Initialization to 0 or false is not necessary, as these are the default values in Solidity.
### Recommendation
Remove the initialization values of 0 or false.
**Remediation Plan:** The Entangle team acknowledged the issue. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | true | false | ## High: 7] RushERC20 launch fee bypass due to flash loan stake
### Description
**Severity:** High
**Path:** LiquidityDeployer.sol:deployLiquidity#L114-L222
**Description:** When a user launches their own RushERC20, they will have to provide fees as ETH through `msg.value`. The fee consists of a fee paid to the Liqu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: In some situations the liquidation can become unprofitable for liquidators, keeping unhealthy positions
### Description
Source: https://github.com/sherlock-audit/2023-10-aloe-judging/issues/43
## Found by
panprog
When liquidators liquidate unhealthy accounts and the swap is required, they receive `LIQUI... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Unable To Get Rewards If Admin Withdraws \$VE3D tokens From `VeTokenMinter` Contract
### Description
_Submitted by xiaoming90, also found by 0x1f8b, and VAD37_
It was observed that users will not be able to get their rewards from the reward contract at certain point of time if admin withdraws \$VE3D token ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: The cycle payment due may span over approx. 2 cycles and block the borrower from paying
### Description
If a borrower makes the expected cycle payment early in the first payment cycle and then tries to make the cycle payment in the second cycle, the payment reverts, due to insufficient amount.
### Impact
T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Duplicate checks in `_closePosition()`
### Description
The implementation of `_closePosition()` checks that the required amounts needed to recover the liquidity do not exceed the available tokens in the position:
https://github.com/code-423n4/2023-12-particle/blob/a3af40839b24aa13f5764d4f84933dbfa8bc8134/cont... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Current redemption design causes users to be charged a penalty despite doing nothing wrong
### Description
Upon users redeeming their escrow positions, we have the following piece of code if the cooldown and grace period have expired:
```solidity
else {
// We are about to return stables to user and charg... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Possible state transitions never happen
### Description
The tracker transition table defines the possible state transitions; however, some of them never happen in the implementation of the edge tracker in the act function. The following state transitions are defined in the transition table but never happen:
- f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: 3S-LENFT-N19 protocol/GenesisNFT.sol: remove always false condition
### Description
The genesis NFT contract, function _getCircleColor() has the [following statement](https://github.com/leNFT/contracts/blob/9b1ae95f97ec5d2423c022179642714cee470a68/contracts/protocol/GenesisNFT.sol#L243-L245):
```solidity
if (... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: 6] Missing validation of lastRewardBlock when adding a new pool in ZealousSwapFarms
### Description
**Severity:** Low
**Path:** contracts/ZealousSwapFarms.sol#L143-L148
**Description:** In the `ZealousSwapFarms::add()` function, if it reactivates an old pool, the `lastRewardBlock` of that pool is set to the ... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.