prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: User rewards stop accruing after any `_writeCheckpoint` calling action
### Description
Any user balance affecting action, i.e. deposit, withdraw/withdrawToken or getReward, calls \_writeCheckpoint to update the balance records used for the earned reward estimation. The issue is that \_writeCheckpoint always s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: The removeRedirectedOffChainDistribution function can be called repeatedly
### Description
The `DistributionModule.removeRedirectedOffChainDistribution` function does not check if a non-zero `activeRedirectedOffChainDistribution` state exists for an account before deleting that state. As a result, the `removeR... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Business Logic | true | true | _Submitted by BowTiedWardens, also found by WatchPug_
Issue: there is a huge arb opportunity for people who deposit 1 block before the `rebase()`.
Consequences: then they can call `instantUnstakeReserve` or `instantUnstakeCurve` to unstake the staked amount, in this way the profit that needs to be distributed on the ... | Code4rena | 3 | Yieldy |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Using `calldata` instead of `memory` for read-only arguments in `external` functions saves gas
### Description
When a function with a `memory` array is called externally, the `abi.decode()` step has to use a for-loop to copy each index of the `calldata` to the `memory` index. **Each iteration of this for-loop ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | access-control | true | true | ## High: Users can get their withdrawal active requests DoSed by malicious users
### Description
Users can opt to withdraw either `USDe` or `sUSDe`.
- When withdrawing `sUSDe`, the assets can be put on a cooldown period depending on the Tranche from which the withdrawal is requested.
- When withdrawing `USDe`, regardl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Event invocations have to be prefixed by emit
### Description
**Description**
contracts/OrderBook.sol#257
It is recommended to explicitly use emit keyword for the event to distinguish the functions
calls and events emitting per recommendation from the Solidity checklist.
**Recommendation**:
Event invocation... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | false | ## Low: NFT safe transfers will revert using `ERC721TransferEnforcer`
### Description
The `ERC721TransferEnforcer` enforcer is designed to authorize NFT token transfers, but it currently restricts transfers to only use the `transferFrom` selector. The issue lies in this code section:
```solidity
//ERC721TransferEnfor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Clarity on collateral liquidation.
### Description
**Description**
ERC20BondingCurve.sol
Protocol allows users to borrow Base token for XGBT, however, in lending protocols, the position of the user can be liquidated under certain circumstances (After some period of time or in case user's borrow balance colla... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Function ordering does not follow the Solidity style guide
### Description
Function ordering does not follow the Solidity style guide | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: More Appropriate Function Names
### Description
## Function Overview
The function `ctx_check_state_addr` checks if the given state account is equal to the Program Derived Address (PDA) generated with the state seeds stored on the ctx.
## Remediation
A more appropriate name for `ctx_check_state_addr` functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | initialization | true | false | ## Low: Refactor `InvestorBasedRateLimiter::checkAndUpdateMintLimit` and `checkAndUpdateRedemptionLimit` to avoid performing unnecessary operations when creating a new investor
### Description
When creating a new investor inside `InvestorBasedRateLimiter::checkAndUpdateMintLimit` and `checkAndUpdateRedemptionLimit` th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Remove Unnecessary Parameter
### Description
## TheTokenPairMetadata Struct
The `TokenPairMetadata` struct contains an unnecessary `lp` field. This field is used during the `remove_liquidity` as an intermediary but serves no purpose and can be removed:
## MOVE
Coins are transferred to `TokenPairMetadata.lp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: `StabilityPool::claimableReward` incorrectly returns lower than actual value as it doesn't include `storedPendingReward`
### Description
`StabilityPool::claimableReward` is an `external view` function that can be used to show users their pending reward. However it doesn't [include](https://github.com/Bima-Labs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: Lack of validation of signed dealing against original dealing
### Description
The `EcdsaPreSignerImpl::validate_dealing_support` method does not check that the content of signed dealings matches the original dealings. A malicious receiver could exploit this lack of validation by changing the requested heigh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Denial of Service in Finalization Blocks Due to Fallback Operator Role Renunciation
### Description
In the rollup contract, the [`setFallbackOperator` function](https://github.com/Consensys/linea-monorepo/blob/660f849d1757700df369ebf33964ed03862b8a8c/contracts/contracts/LineaRollup.sol#L176) allows the [`fa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `GlobalConfigurationBranch::updateSettlementConfiguration` can be called for a non-existent `marketId`
### Description
**Description:** `GlobalConfigurationBranch::updateSettlementConfiguration` doesn't validate if the `marketId` exists:
But other functions like `updatePerpMarketStatus` do validate that the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Untyped data signing
### Description
_Submitted by Lambda, also found by 0x1f8b, 0x52, horsefacts, vlad_bochok, and wastewa_
[Community.sol#L175](https://github.com/code-423n4/2022-08-rigor/blob/e35f5f61be9ff4b8dc5153e313419ac42964d1fd/contracts/Community.sol#L175)
[Community.sol#L213](https://github.com... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: The silent behavior on attempting withdraw of small amount of Ether
### Description
The `_requestWithdrawal` function may silently bypass the attempt to withdraw small amount of Ether (i.e. < 100 wei, depending on the implementation). No event nor revert will be generated. On the edge cases, this may mislead o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Pegged | false | false | Source: https://github.com/sherlock-audit/2023-01-uxd-judging/issues/305
## Found by
0x52
## Summary
When minting UXD using PerpDepository.sol the amount of UXD minted corresponds to the amount of vUSD gained from selling the deposited ETH. This is problematic given that Perp Protocol is a derivative rather than a... | Sherlock | 4 | UXD Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Method ownerDepositForDistribution should check if enough tokens present in the rewards contract
### Description
Severity: Low
Status: Resolved
**Description**
In Contract Rewards.sol, the method ownerDepsoitForDistribution(..) sets a distribution amount but does not check if enough tokens are present in th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Improving FeesClaimed event information
### Description
The recipient is not particularly helpful information to emit in the `FeesClaimed` event. The recipient can be inferred from the underlying token's `Transfer` event in the same transaction.
### Recommendation
The event should emit the address that had it... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Missing access control in burn
### Description
**Severity**: Critical
**Status**: Resolved
**Description**
In the TokenStableV6 contract, there is a missing access control in `burn()`. This function can be used by an attacker to burn tokens from any address.
**Recommendation**:
It is advised to either... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use `ITroveManager::Status` enum types instead of casting to `uint256`
### Description
**Description:** Use `ITroveManager::Status` enum types instead of casting to `uint256`:
**Bima:**
Fixed in commit [1ab7ebf](https://github.com/Bima-Labs/bima-v1-core/commit/1ab7ebffbd1653e39230bf0b24f1996fbf89c117).
**Cy... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Mixed value and pointer receivers
### Description
**Severity**: Informational
**Status**: Resolved
**File**: core/blocklog/events.go
**Type**: EventLookupKey
**Details**:
Mixing value and pointer receivers for methods on a single type in Go can lead to confusion and potential issues.
**Recommendation**:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Withdrawable.withdraw does not decrease pendingWithdrawals
### Description
## Handle
cmichel
## Vulnerability details
## Vulnerability Details
The name `pendingWithdrawals` indicates that this storage variable tracks the withdrawals that need yet to be paid out which also matches the behavior in `_increas... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: The spent offer amounts provided to OrderFulfilled for collection of (advanced) orders is not the actual amount spent in general
### Description
When Seaport is called to fulfill or match a collection of (advanced) orders, the `OrderFulfilled` is called before applying fulfillments and executing transfers. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: ERC4626 does not work with fee-on-transfer tokens
### Description
Source: https://github.com/sherlock-audit/2022-10-astaria-judging/issues/3
## Found by
pashov, w42d3n, Bnke0x0
## Summary
## Vulnerability Detail
## Impact
The ERC4626-Cloned.deposit/mint functions do not work well with fee-on-transfer ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | token | true | true |
The `TokenggAVAX` contract (<https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/tokens/TokenggAVAX.sol#L24>) can be paused.
The `whenTokenNotPaused` modifier is applied to the following functions (<https://github.com/code-423n4/2022-12-gogopool/blob/aec9928... | Code4rena | 5 | GoGoPool |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Use `Ownable2Step` instead of Ownable for `LiquidityFreeLaunchFactory`
### Description
**Severity**: Low
**Status**: Resolved
**Location**: LiquidityFreeLaunchFactory.sol
**Description**:
The `renounceOwnership()` function can be called accidentally by the owner leading to immediate renouncement of ownersh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Exposure to replay attack
### Description
Severity: Critical
Status: Resolved
**Description**
CommunityRound.sol, method: reserve(_request, _message, v, r, s), _request along with _message and signature can be replayed. It is assumed that this is not intended since balances[sender_] = _request.amount; whic... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Upgradeable Contracts Do Not Use a Time Lock
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> I accept it, and may include a time lock in future versions.
**File(s) affected:**`contracts/treasury.fc`, `contracts/parent.fc`
**Description:** T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: OOG error in `clearLoop()`
### Description
Function `ResetClearLoopSubsystem.clearLoop()` calls `PointsMap.clear(empire)` to clear all utilities associated with an empire. The issue is that this function loops through all players of the empire and clears their data and if the player's count is very big then... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: `block.timestamp` use in dex swap deadlines may cause poor trading
### Description
In the PositionInteractionFacet.sol contract, when executing DEX swaps, the `deadline` parameter is set to `block.timestamp + 30 minutes`:
```solidity
IV3SwapRouter.ExactOutputSingleParams memory params = IV3SwapRouter.Exact... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: `CompositeMultiOracle` returns wrong decimals for prices?
### Description
_Submitted by cmichel_
The `CompositeMultiOracle.peek/get` functions seem to return wrong prices.
It's unclear what decimals `source.decimals` refers to in this case. Does it refer to `source.source` token decimals?
It chains the pric... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Prevention of Cross-Chain Replay Attacks
### Description
## Fee Payload Update
Add `chain_id` to the fee payload, similar to how it is included in the mint payload. This prevents replay attacks, where a transaction could be relayed on a different chain. Adding `chain_id` ensures that signed fee transactions a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: No need to initialize default values
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In Contract Platform.sol, a few storage variables are being initialized to their default values which are not needed.
**Recommendation**:
Remove unnecessary initializations. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: initialize maxPercentForWithdraw and maxPercentForDeposit?
### Description
## Handle
gpersoon
## Vulnerability details
## Impact
The parameters maxPercentForWithdraw and maxPercentForDeposit are not directly initialized.
If functions, which rely on these parameters, are called, before setWhaleThresholdWith... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Inefficient use of array for counting pairs in AdaswapFactory.
### Description
**Description**
In the presented smart contract infrastructure, the allPairs array in AdaswapFactory is used for counting all created pairs. Using an array to store and retrieve the number of created pairs is not an optimal solutio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: ERC5095.deposit doesn't check if received shares is less then provided amount
### Description
`ERC5095.deposit` doesn't check if received shares is less then provided amount. In some cases this leads to lost of funds.
### Impact
Lost of funds.
### Recommendation
Add this check at the end
`require(returned... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Incorrect Mint() Event Emission in RToken#mint()
### Description
In `RToken#mint()`, the calculation of `scaledBalance` is **incorrect**, leading to an **incorrect computation of** **`balanceIncrease`**. As a result, the `Mint()` event **emits incorrect values**.
### Impact
**Events display wrong data:** **Mi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Misleading Comment
### Description
In [line 484 of `Executor.sol`](https://github.com/matter-labs/zksync-2-contracts/blob/098bc7ee2d13f78d365c386a8d27c1ae09b31164/ethereum/contracts/zksync/facets/Executor.sol#L484), it says "Returns if the bit at index {\_index} is 1". It should instead say "Returns true if th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Users might overpay while borrowing
### Description
The final cost of borrowing is determined by taking a sum of `marginDeposit`, `liquidationBonus`, `dailyRateCollateral` and `holdTokenEntranceFee`.
Users can pass on `maxDailyRate` to check if the `dailyRateCollateral` has changed in between them submitting... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of check for arrays length
### Description
The `CryptoLegacyBasePlugin.update` function lacks a check to ensure that the [arrays](https://github.com/CryptoCust/cryptolegacy-contracts/blob/e409929501d5b78941bc78411f1fa3da36249a94/contracts/plugins/CryptoLegacyBasePlugin.sol#L294) **_lockToChainIds** and **... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `StakedCitadel.deposit()`: Use `calldata` instead of `memory`
### Description
When arguments are read-only on external functions, the data location should be `calldata`: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Initialization of the `virtualPool` should be made earlier
### Description
`virtualPool` is currently initialized after using it in the check.
https://github.com/cryptoalgebra/Algebra/blob/7290fad656bfa89db3743c52af631154f6a8a2d5/src/tokenomics/contracts/farmings/AlgebraEternalFarming.sol#L398
### Recommen... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Unsafe use of `transfer()`/`transferFrom()` with `IERC20`
### Description
Some tokens do not implement the ERC20 standard properly but are still accepted by most code that accepts ERC20 tokens. For example Tether (USDT)'s `transfer()` and `transferFrom()` functions do not return booleans as the specification ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Avoid using `SafeMath::div` when it is not possible for the divisor to be zero | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: Loss of decimal precision for `currentFundingTime`
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The `settleFundingPayments` function in the `Formula.sol` smart contract contains a `currentFundingTime` variable that is calculated as:
uint256 currentFundingTime = (block.times... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Multiple accesses of a mapping/array should use a local variable cache
### Description
Caching a mapping's value in a storage pointer when the value is accessed multiple times saves ~40 gas per access due to not having to perform the same offset calculation every time. Help the Optimizer by saving a storage va... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Floating Pragma Version in Solidity Files
### Description
**Severity**: Informational
**Status**: Resolved
**Location**: All
**Description**
The Solidity files in this codebase contain pragma statements specifying the compiler version in a floating manner (e.g., ^0.8.0, ^0.8.4, ^0.8.11). Floating pragmas c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Users Cannot Change Their Vote Once Cast in a Voting Period
### Description
**Description:** The voting system prevents users from changing or revoking their votes once they have voted in a voting round. While this maybe an intentional design to prevent duplicate voting, it may impact user experience if users ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Disruption From renounceOwnership() In PolygonMigration
### Description
The function `renounceOwnership()` is accessible in the `PolygonMigration` contract as it is inherited from OpenZeppelin’s `Ownable2StepUpgradeable` contract. Invoking `renounceOwnership()` will render the function `PolygonMigration.update... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `BondAggregator.findMarketFor` Function Will Break In Certain Conditions
### Description
`BondAggregator.findMarketFor` function will break when the `BondBaseSDA.payoutFor` function within the for-loop reverts under certain conditions.
### Impact
The find market feature within the protocol is broken under ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: LidoSTETHConnector#_connector_deposit returns ETH amount instead of stETH received amount
### Description
The strategy (and connector) are designed to return the amount of assets deposited. When a user deposits ETH, the ETH is submitted for stETH. The exact amount of ETH deposited is returned, which is then us... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Terminate SmartEscrow after vesting period expires
### Description
## SmartEscrow Token Recovery
**Context:** SmartEscrow.sol#L211-L211
**Description:** Once the vesting schedule is completed, all tokens transferred to the SmartEscrow contract should be recovered by the escrow owner.
**Recommendation:** The... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Unsafe support of non-standard ERC-20 tokens
### Description
When retrieving the underlying tokens from the liquidator, the code does not perform checks for the return value. Although standard implementations of ERC-20 will revert on a failed [transferFrom](https://github.com/Gearbox-protocol/bots-v3/blob/4... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: TRST-H-3 Additional Satin/$CASH LP locked in an owner-created veSatin can’t be withdrawn
### Description
**Description:**
_The protocol allows the owners to create a special veSatin for the owners and partners via
`createLockForOwner()`, which does not require to lock LP. On such veSatin, the protocol
rever... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | false | false | ## Medium: Governable is an abstract upgradeable contract but doesn’t contain any storage gaps which could result in collisions on upgrade
### Description
**Severity**: Low
**Status**: Resolved
**Location**: Governable.sol
**Description**:
The Governable.sol contract is a part of the Receivable and IsleGlobals co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | overflow | false | true |
Submitting as high risk because it breaks a fundamental operation (transferring) for a large number of tokens.
### Proof of Concept
<https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/vote-escrow/VoteEscrowDelegation.sol#L212-L213>
uint256 nCheckpoints = numC... | Code4rena | 5 | Golom |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Get virtual price is not monotonically increasing
### Description
_Submitted by jonah1005_
#### Impact
There's a feature of `virtualPrice` that is monotonically increasing regardless of the market. This function is heavily used in multiple protocols. e.g.(curve metapool, mim, ...) This is not held in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing tests
### Description
No tests were found for the governance system implemented in the contracts. This is considered a major shortcoming in the project, as there is no way to determine if the current implementation matches the system’s expected behavior.
Consider adding tests for diverse cases and ed... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Retrieve and enforce token decimal precision
### Description
**Description:** Retrieve and enforce token decimal precision using [`IERC20Metadata`](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/IERC20Metadata.sol). For example:
1) `PledgeManager::initializ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Deposited staking tokens can be lost if rewards token info added by mistake in addReward() in VE3DRewardPool and there is no checking to ensure this would not happen (ve3Token for one reward was equal to stacking token)
### Description
_Submitted by unforgiven_
### Impact
If `owner` by mistake or bad int... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of spec on the modules
### Description
The spec file intends to outline the common structure for specifications within this directory. The modules are missing spec. This documentation is segmented into developer-focused messages and end-user-facing messages. These messages may be shown to the end user (th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Illogical order of statements in ‘addRebalancer()
### Description
The function `addRebalancer()` first sets `isRebalancer[]` and then performs an additional check that can revert. It is more logical to reverse these statements.
### Recommendation
Consider changing the code to:
```solidity
function addRebalan... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: `ETH` calls on `Dolomite_Module` have no corresponding calls on Dolomite
### Description
The following calls have no corresponding call on the Dolomite [deployed contract](https://berascan.com/address/0xd6a31b6aea4d26a19bf479b5032d9ddc481187e6#writeContract):
* [`Dolomite_Module::dolomite_depositETH`](https://... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: tbtc - Variable shadowing in DepositFactory ✓ Addressed
### Description
`DepositFactory` inherits from `TBTCSystemAuthority`. Both contracts declare a state variable with the same name, `tbtcSystem`.
**tbtc/implementation/contracts/proxy/DepositFactory.sol:L21**
```
address public tbtcSystem;
```
### Rec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Functions guaranteed to revert when called by normal users can be marked `payable`
### Description
| |Issue|Instances|Total Gas Saved|
|-|:-|:-:|:-:|
| [G‑15] | `.length` should not be looked up in every loop of a `for`-loop | 2 | 6 |
| [G‑16] | `require()`/`revert()` strings longer than 32 byte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | reentrancy | true | false | ## Gas: Bake ReentrancyGuard into Escrow
### Description
`ReentrancyGuard.sol` is a very simple abstract contract. Its functionality can be baked into `Escrow.sol`, and its gas can be optimized as well.
### Impact
Over 800 gas can be saved between deployments. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Shift Right instead of Dividing by 2
### Description
A division by 2 can be calculated by shifting one to the right.
While the `DIV` opcode uses 5 gas, the `SHR` opcode only uses 3 gas. Furthermore, Solidity's division operation also includes a division-by-0 prevention which is bypassed using shifting.
I sug... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Minimize Redundant Computations in Functions
### Description
[Tokenid.sol](https://github.com/code-423n4/2023-11-panoptic/blob/main/contracts/types/TokenId.sol#L298)
Reducing redundant computations within functions, especially those called frequently, can result in significant gas savings. This involves ident... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | false | ## High: Signature does not take all parameters into account and can be reused
### Description
The `CommonPool`'s `allocateFunds` function accepts a Deposit / Withdraw payload and a corresponding signature (it is a structure made of the signature bytes, an expiration date, and a nonce). The expiration date and the non... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Consider adding a `deadline` parameter to user facing calls
### Description
**Description:** The `buy`, `sell`, `addLiquidity`, and `removeLiquidity` functions currently do not accept a `deadline` parameter to constrain when a transaction must be executed. Without a deadline, transactions may be mined at unexp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Incorrect event emission is possible in `AccountableAsyncRedeemVault::cancelRedeemRequest` flows
### Description
`cancelRedeemRequest()` takes "requestID" as input, but it is never used and never validated to be associated with the input controller address.
All cancellation flows (immediate/ async) work with ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Finalizing a game after 10 minutes will lock user’s earned funds.
### Description
**Severity**: High
**Status**: Resolved
**Description**
The `finalizeGame()` function within the `UpDown.sol` and `OneVsOneExactPrice`, smart contract is used by the administrator to end a game, submit the results, and distr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Attacker can cause losses to others by partially closing their position at an unfavorable price
### Description
**Description:** In our new perp order flow, we verify whether the leverage is valid using `check_client_leverage_from`. However, this check is only executed if any of the following conditions are t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Miscellaneous General Comments
### Description
This section details miscellaneous findings discovered by the testing team that do not have direct security implications. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [3] Using `storage` instead of `memory` for structs/arrays saves gas
### Description
When fetching data from a storage location, assigning the data to a `memory` variable causes all fields of the struct/array to be read from storage, which incurs a Gcoldsload (**2100 gas**) for *each* field of the struct/array... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Juicebox project owner can create a honeypot to cause grief
### Description
_Submitted by dirk_y, also found by IllIllI, and ylv_
### Impact
In a Juicebox project the project owner (or anyone that they approve) can set splits. These splits are details of the token distributions to other addresses in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Unused `gasReimbursements` Mapping
### Description
`L1BTCRedeemerWormhole` declares a public `gasReimbursements` mapping that is never written to or read from. Because each mapping occupies a dedicated storage slot, this increases contract size and deployment cost without providing any functionality. Unused st... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: evcused by the PegStabilityModule and ESynth contract may not be the same
### Description
The `PegStabilityModule` constructor stores an ESynth address which is not enforced to be related to the corresponding EVC used. Add a sanity check that enforces that the `PegStabilityModule` EVC is the same one used by t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Response payload to authentication challenge is not signed
### Description
During the authentication process, the strategy executor signs a challenge message with a nonce and returns it to the API to obtain credentials, together with other information such as its IP address, display name, beneficiary address, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Market utilization ratio near 100% will DoS deposits as harvest tries to withdraw and reverts
### Description
`StakedEXA::_update()` harvests when depositing, withdrawing assets from the provider in the given market. However, due to the utilization ratio check in the market, it may not be possible to withdr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | false | false | ## High: Attacker captures unclaimed fees by timing deposit with range re-entry and price manipulation
### Description
Whenever users deposit into or withdraw from Burve, the associated fees are collected and redistributed back into the ranges according to their weights. However, if the current Burve ranges are *out o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Unhandled Chainlink Oracle Access Revocation Risk
### Description
**Severity**: Low
**Status**: Resolved
**Location**: GammaSwapLiquidityWarehouse.sol
**Description**
The `_getAssetOraclePrice` function in the `GammaLiquidityWarehouse` contract directly calls the `latestRoundData` function of Chainlink pri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: In `Operator._transfer()`, `onDelegate()` should be called after updating the token balances
### Description
**Severity:** Medium
**Description:** In `_transfer()`, `onDelegate()` is called to validate the owner's `minimumSelfDelegationFraction` requirement.
But `onDelegate()` is called before updating t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Delegated stake weight reduction can be bypassed by using an external contract Won't Fix
### Description
Staking pools allow ZRX holders to delegate their staked ZRX to a market maker in exchange for a configurable percentage of the stake reward (accrued over time through exchange fees). When staking as expe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | true | ## High: Insufficient parameter validation in `validateInteractions()`
### Description
- https://github.com/Liquorice-HQ/contracts/blob/a5b4c6a56df589b8ea4f6c7b8cb028b1723ad479/src/contracts/settlement/Signing.sol#L109
The `validateInteractions` function in the `Signing` contract does not sufficiently check parameter... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `require()`/`revert()` statements should have descriptive reason strings
### Description
*There are 93 instances of this issue. For in-depth details, see the warden's [full report](https://github.com/code-423n4/2022-05-velodrome-findings/issues/128).* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Calling `updateNodeRunnerWhitelistStatus` function always reverts
### Description
Calling the `updateNodeRunnerWhitelistStatus` function by the DAO supposes to allow the trusted node runners to use and interact with the protocol when `enableWhitelisting` is set to `true`. However, since calling the `updateN... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Wrong Math | false | false | ## Severity: High Risk
## Context
- AstariaRouter.sol#L417-L422
- VaultImplementation.sol#L392
## Description
`totalBorrowed` is the sum of all `commitments[i].lienRequest.amount`. But if `s.feeTo` is set, some of the funds/assets from the vaults get transferred to `s.feeTo` when `handleProtocolFee` is called, and on... | Spearbit | 5 | Astaria |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: [19] Unused balance helper functions can mask future inconsistencies
### Description
### Vulnerability details
Functions `_nativeBalance()`, `_erc20Balance()`, and `_erc20BalanceOf()` are never invoked anywhere in the router. Because they are dead code, any future contributor might start using them under the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: ToDo in code and commented code.
### Description
**Description**
ToDos: line 107, 122, 125, 211, 228, 233, 299, 489.
Commented code: line 178-184.
Pre-production contracts should not contain ToDos in code.
**Recommendation**:
Implement or remove ToDos. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Comments state that pre-existing ETH can be used but it can't
### Description
It is possible to provide an initial contribution to the `ReraiseETHCrowdfund` and `InitialETHCrowdfund` contracts.
The initial contribution is processed when the `initialize` function is called.
In both contracts it is stated ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: Improper Oracle Calculations
### Description
## Pyth Price Calculations Issue
Pyth price calculations in `oracle.move` are performed incorrectly.
## Location
- File: `oracle/sources/oracle.move`
- Language: RUST
## Code Snippet
## Problem
The price should be multiplied by, not divided by, the magnitude.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | front-running | false | false | ## Swapper Contract Security Concerns
## Context
- **Swapper**: `Swapper.sol#L133`
- **Uniswap V3 Swapper**: `UniswapV3Swapper.sol#L187`
## Description
The `Swapper` contract may never have any left-over token balances after performing a swap because token balances can be stolen by anyone in several ways:
- By using ... | Spearbit | 5 | Timeless |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Proposals cannot contain duplicate transactions
### Description
When [queueing a proposal](https://github.com/compound-finance/compound-protocol/blob/f86c247f6f81e14f8e0fd78402653a0b8371266a/contracts/Governance/GovernorBravoDelegate.sol#L82-L84) in the `Timelock` contract, a [check is done](https://github.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use `furnace` instead of `main.furnace()`
### Description
Gas savings: ~2.6K
Code: https://github.com/reserve-protocol/protocol/blob/c4ec2473bbcb4831d62af55d275368e73e16b984/contracts/p1/RToken.sol#L184
https://github.com/reserve-protocol/protocol/blob/c4ec2473bbcb4831d62af55d275368e73e16b984/contracts/p1/RTo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | false | false | ## High: Incorrect Storage Slot Calculations
### Description
In the [`L2ScrollMessenger` contract](https://github.com/scroll-tech/scroll/blob/3bc8a3f5c6ac816ddffadca41024331dcf4d3064/contracts/src/L2/L2ScrollMessenger.sol), the functions [`verifyMessageInclusionStatus`](https://github.com/scroll-tech/scroll/blob/3bc8a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Ineffective Ownership Transfer Due to Lack of External Accessibility
### Description
The smart contract includes ownership transfer functions in both `global_params.rs` and `chain_config.rs` files—specifically `change_global_param_owner_id` and `change_chain_configs_owner_id`—intended to allow the transfer of ... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.