prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: No need to use an assembly block to get the chain ID
### Description
Currently the `getChainId` method in `Signature` uses an assembly block to get the current chain id. This is not needed since there is a global variable for this already.
### Recommendation
Remove the `getChainId` function and just use `bloc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: CONTRACTS ARE NOT USING disableInitializers FUNCTION
### Description
The StakeManager and BnbX contracts use Open Zeppelin `Initializable` module. According to the Open Zeppelin [guidelines](https://docs.openzeppelin.com/upgrades-plugins/1.x/writing-upgradeable#initializing_the_implementation_contract) the `_d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: No slippage protection
### Description
The Burve contract allows users to provide liquidity to both the Island pool and Uniswap V3 pools. The number of shares minted to users is determined using the following calculation:
```solidity
function islandLiqToShares(uint128 liq) internal view returns (uint256 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Function updateInvoiceArrears() does not emit old values
### Description
**Description:** Function updateInvoiceArrears() should consider emitting previous `invoiceArrears` and `lastInvoiceDate` values to maintain consistency with other setter functions updateL1LineaTokenBurner, updateDex and updateInvoicePaym... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Improve Check For Second Highest Bid
### Description
## Auction Bid Validation in auction.move
The file `auction.move` includes checks for the creation time of the highest bid to ensure that it falls within the appropriate range. However, no such checks are included for the second highest bid.
### Code Snipp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: Dead GoDoc params for `TradeInputForExactOutput`
### Description
The GoDoc for `swap:TradeInputForExactOutput` contain two parameters are not in the method signature and there are no likely matching candidates, these lines should be deleted as they'll only serve to sow confusion.
swap.go L68-69
@param sender:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: RPC starkNet_signMessage - Inconsistency When Previewing the Signed Message (Markdown Injection) ✓ Fixed
### Description
The snap displays an dialogue to the user requesting them to confirm that they want to sign a message when a dapp performs a request to `starkNet_signMessage`. However, the MetaMask Snaps U... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of events
### Description
**Severity**: Low
**Status**: Acknowledged
**Description**
`L 138, 146, 154, 164, 175, 181, 192, 201`
The setter functions don’t emit events when key states are updated.
**Recommendation**:
Add events according to the states to be update | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: The constructor of BridgedGovernorProxy cannot support non-zero value calls
### Description
The constructor of the `BridgedGovernorProxy` contract executes Calls. Since a Call can have a non-zero value field, it is better to mark the constructor as payable.
### Recommendation
Add this change:
```solidity
- c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Error message with opposite meaning
### Description
The anti-bricking checks return `PRIVILEGE_NOT_DOWNGRADED` if the sender/signer key removes their own privilege. If this is attempted, this error message suggests that the privilege should have been downgraded but wasn't, which is the opposite of what is inte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Updating the ERC20 Token Could Temporarily Lock Funds
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `29efd69`. The client provided the following explanation:
> This fix no longer applies since the logic was deleted
Review comment: this issue is unresolved. However, based on "There... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | DOS | true | true | Source: https://github.com/sherlock-audit/2023-01-ajna-judging/issues/116
## Found by
oxcm
## Summary
The code in the transferLPs function has an incorrect validation check, where it requires `allowances_` to be strictly equal to `lenderLpBalance`, instead of just `allowances_` being greater than `transferAmount`.... | Sherlock | 4 | Ajna |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Market::forceReplenish can be DoSed
### Description
## Lines of code
https://github.com/code-423n4/2022-10-inverse/blob/main/src/Market.sol#L562
## Vulnerability details
## Impact
If a user wants to completely forceReplenish a borrower with deficit, the borrower or any other malicious party can front ru... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | false | false | ## Gas: Add `unchecked {}` for subtractions where the operands cannot underflow because of a previous `require()` or `if` statement
### Description
`require(a require(a
`if(a if(a
This will stop the check for overflow and underflow so it will save gas
- [Exchange.sol#L607](https://github.com/code-423n4/2022-11-no... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | liquidation | true | false | ## Gas: Using storage instead of memory for structs/arrays saves gas
### Description
When fetching data from a storage location, assigning the data to a memory variable causes all fields of the struct/array to be read from storage, which incurs a Gcoldsload (2100 gas) for each field of the struct/array. If the fields ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Extra rewards due to a malfunction with the `_cumulativeRewardPerLpToken`
### Description
**Severity**
**Impact:** High, because users may receive more rewards than allocated.
**Likelihood:** Low, because it requires the removal and re-addition of a `rewardToken`.
**Description**
When the rewards for a ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Fund loss or griefing in all order matching functions [`matchOneToOneOrders()`, `matchOneToManyOrders()`, `matchOrders()`, `takeMultipleOneOrders()`, `takeOrders()`] because condition `(seller != buyer )` is not checked in any of them
### Description
_Submitted by unforgiven, also found by GreyArt_
Functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: `RedeemEvent` emits wrong `to` address
### Description
In the `dMute.RedeemTo` function the `RedeemEvent` is emitted ([Link](https://github.com/code-423n4/2023-03-mute/blob/4d8b13add2907b17ac14627cfa04e0c3cc9a2bed/contracts/dao/dMute.sol#L128)).
It is defined as:
[Link](https://github.com/code-423n4/2023-03... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Potential Issue with Signature Verification in `pauseDeposits` Function
### Description
The issue is identified within the [pauseDeposits](https://github.com/lidofinance/core/blob/fafa232a7b3522fdee5600c345b5186b4bcb7ada/contracts/0.8.9/DepositSecurityModule.sol#L384) function of the contract `DepositSecurityM... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: TWA update is not correct
### Description
Time-warped-price is updated incorrectly and this affects moving bins.
### Proof of Concept
The protocol updates `twa` on every swap and uses that to decide how to move bins.
But in the function `swap()`, the delta's `endSqrtPrice` can not contribute negatively t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Account Size Calculation
### Description
## Analysis of the `init_locker` Function
In `init_locker`, the allocated space for an account is determined by the passed space. Receiving the number of potential mints in Locker as user input and then calculating the space based on that would increase efficiency. Sto... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: ERC721 interest model miscalculates utilization rate due to reserves
### Description
Like the other interest models, `CErc721InterestModel.sol` calculates the utilization rate as follows:
This formula makes sense in other markets, because `reserves` are fees earned by the protocol that will show up in the `c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Avoid Repeated Calls
### Description
## Liquidator Code Optimization
In `liquidator.move`, `liquidate_obligation_with_cetus_pool_only_a` and `liquidate_obligation_with_cetus_pool_only_beach` invoke `&get()` twice. Repeated function calls may impact performance. Storing the result of `&get()` in a variable and... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Destroyed Routes Eth Balances Will Be Left Locked in SocketDeployFactory
### Description
`SocketDeployFactory.destroy` calls the `killme` function which in turn self-destructs the route and sends back any eth to the factory contract. However, these funds can not be claimed from the `SocketDeployFactory` contra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Pre/Post Balance | false | true |
<https://github.com/code-423n4/2022-11-redactedcartel/blob/03b71a8d395c02324cb9fdaf92401357da5b19d1/src/vaults/AutoPxGlp.sol#L197-L296>
<https://github.com/code-423n4/2022-11-redactedcartel/blob/03b71a8d395c02324cb9fdaf92401357da5b19d1/src/vaults/AutoPxGmx.sol#L230-L313>
### Impact
Function `compound()` in `AutoPxG... | Code4rena | 4 | Redacted Cartel |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: [10] Misaligned access control on `setTopNPools()` function
### Description
### Finding description
The `setTopNPools` function is responsible for updating the list of top N pool addresses in the protocol:
As per the comment, the function is intended to be callable by either the contract owner or the AVM. H... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Transfer tokens before minting shares in `rOUSG::wrap`
### Description
**Description:** `rOUSG::wrap` [L411-413](https://github.com/ondoprotocol/rwa-internal/blob/6747ebada1c867a668a8da917aaaa7a0639a5b7a/contracts/ousg/rOUSG.sol#L411-L413) currently mints shares before transferring tokens used to mint those sh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: 8] Redundant double check of max operator count in register operator
### Description
**Severity:** Low
**Path:** SlashingRegistryCoordinator.sol:registerOperator#L151-L225
**Description:** The `registerOperator` function is called from the AllocationManager. The operator can specify a few parameters, such as... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | false | ## High: Public RPC Methods and Consent Management ✓ Fixed
### Description
User consent may not consistently be enforced. Identities are bound to their origin (URL). Third-party origins are outside the scope of this Snap and are therefore in a lower trust zone where it is uncertain what security measures are in place ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Fee-on-Transfer Tokens Can Cause Accounting Errors in Swappee Contract
### Description
The `Swappee` contract contains a vulnerability in its handling of Fee-on-Transfer (FOT) tokens. The issue manifests in the swappee function, where the contract assumes the actual received amount of tokens will equal the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Anyone with enough liquidity to reach the maxGenesisPrice can make profit from genesis
### Description
The [`GenesisGroup` contract](https://github.com/fei-protocol/fei-protocol-core/blob/29aeefddd97f31c7f2a598fb3dca3ef24dc0beb4/contracts/genesis/GenesisGroup.sol) allows users to deposit ETH through the [`pur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Incorrect `SmartVaultV4` function arguments should be renamed
### Description
The following functions in `SmartVaultV4` take an argument `_USDCTargetAmount`:
* `calculateAmountIn()`
* `swapCollateral()`
* `autoRedemption()`
However, this is semantically incorrect as it is intended to represent the target `USD... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Removing more gauge weight than it should be while transferring `ERC20Gauges` token
### Description
The `_decrementWeightUntilFree()` function is not well implemented. If there are deprecated gauges, it would remove more gauge weight than it should be while transferring `ERC20Gauges` token.
### Proof of Co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Incorrect transfer of parameter values
### Description
At the lines:
- https://github.com/orbxball/stablecoins-3pool/blob/adeb776933c6cb3b8306239cc3357d4c6239a88d/contracts/StrategyUSDC.sol#L222
- https://github.com/orbxball/stablecoins-3pool/blob/adeb776933c6cb3b8306239cc3357d4c6239a88d/contracts/StrategyUSD... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: [10] `txId` is generated differently on Starknet
### Description
### Issue Description
`tx_id` in `handler_erc20` is generated differently, compared to `ChakraSettlementHandler`.
In Cairo it contains the following params:
- `transaction_hash`
- `msg_count`
[ChakraSettlementHandler.sol](https://github.com/c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Initial Deposit Can Skew Receipt Token Price
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> We've been acknowledged the concern. However we have the authorized capability of enabling the deposit to the new fund. So we can ensure every fund's... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Loss of precision possible due to rewardRate rounding
### Description
In `MultiRewards.notifyRewardAmount`, we compute the `rewardRate` given the amount of reward tokens to distribute divided by the `rewardsDuration`, e.g.:
```solidity
rewardData[_rewardsToken].rewardRate = reward.div(
rewardData[_reward... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: Potential clash between proxy and implementation function selectors
### Description
ink! allows developers to set custom selectors for the functions defined on a contract as mentioned in [**Custom Selectors could facilitate proxy selector clashing attack**](#h01). When this feature is not used, the [`compute` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: There are many stale branches
### Description
There are [21 stale branches in the `celo-monorepo` repository](https://github.com/celo-org/celo-monorepo/branches/stale).
When there are many open branches in the team repository, it is not clear which contain work in progress, which ones are experimental and wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Empty data return
### Description
The functions `getVestingSchedule` and `getVestingScheduleByAddressAndIndex` may return empty data if the vesting schedule ID does not exist in the mapping. This could lead to unintended behavior if these functions are used without proper validation.
### Recommendation
Add ch... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: An array's length should be cached to save gas in for-loops
### Description
Reading array length at each iteration of the loop takes 6 gas (3 for mload and 3 to place memory_offset) in the stack.
Caching the array length in the stack saves around 3 gas per iteration.
Here, I suggest storing the array's lengt... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Remove Unnecessary Logging
### Description
## Security Recommendations for Logging
In order to prevent potential security vulnerabilities, it is recommended to avoid logging sensitive information in production environments. During the audit, it was observed that certain application dependencies were logging s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: `processYield()` and `distributeYield()` may run out of gas and revert due to long list of extra rewards/yields
### Description
_Submitted by IllIllI, also found by leastwood and StErMi_
Yields will not be able to be distributed to lenders because attempts to do so will revert.
### Proof of Concept
The `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `setBorrFactors_e18()` could check for duplicate `_pools` as an additional check to make sure that no incorrect factors are set
### Description
If 2 duplicates are sent, only the latter will take effect, which could have very dangerous implications. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Closing an Ordered Channel on Packet Timeout Is Not Reflected in the Provable Store
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `7e58f5b388fbdfe42c5e04f6c82401ee960ff126`.
**File(s) affected:**`IBCChannelPacketTimeout.sol`
**Description:** In the function `IBCChannelPacketTimeo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Migration fails when all tokens are joined
### Description
_Submitted by Lambda, also found by 0x29A_
### Impact
When `proposal.totalFractions` is equal to the total supply (meaning that all token holders want to participate in a migration), there is a division by zero in `_calculateTotal`.
In contrast ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Unnecessary initialization
### Description
New `uint256` variables are equal to zero by default:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditFilter.sol#L297
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce05... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: push0 OPCODE Incompatible With Arbitrum
### Description
The `push0` OPCODE ([EIP-3855](https://eips.ethereum.org/EIPS/eip-3855)) is implemented in the latest Shanghai EVM version, which is the default version for the Solidity compiler `0.8.20` or higher. As of the time of writing, Arbitrum does [not yet suppor... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: A borrower may pay more interest that he has specified, if orders are matched by a malicious actor
### Description
In the ``DebitaV3Aggregator.sol`` contract, anybody can match borrow and lend orders by calling the [matchOffersV3()](https://github.com/sherlock-audit/2024-11-debita-finance-v3/blob/main/Debit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Interest rate for pool is bounded wrongly
### Description
It is documented that pools can be created for tokens with interest rate between 1-10%.
> Pool creators: create pool by providing a fungible token for quote and collateral and an interest rate between 1-10%
However, due to a wrong implementation, p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: The owner can manipulate oracles
### Description
The `Oracle` contract has a function [`setExternalOracle`](https://github.com/DivergenceProtocol/diver-contracts/blob/e5286f94a7ccb9d6279fae51ea66a8833672628a/src/core/Oracle.sol#L24) that set an external oracle address for symbols. The owner is able to set a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Remove duplicate code
### Description
Duplicate code makes it harder to understand the code’s intention and thus, auditing the code correctly. It also increases the risk of introducing hidden bugs when modifying one of the copies of some code and not the others. We recommend the following to remove duplicate c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | false | false | ## High: `Mul/div` relation should not be enforced when divisor is zero
### Description
### Lines of code
### Impact
When applying opcode `div`, if dividend is nonzero and divisor is zero, the resulted quotient and remainder are both zero. The enforced `mul/div` relation does not hold. An unprovable transaction wil... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [N‑06] Lines are too long
### Description
Usually lines in source code are limited to [80](https://softwareengineering.stackexchange.com/questions/148677/why-is-80-characters-the-standard-limit-for-code-width) characters. Today's screens are much larger so it's reasonable to stretch this in some cases. Since ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Denial of Service in Finalization Blocks Due to Fallback Operator Role Renunciation
### Description
In the rollup contract, the [`setFallbackOperator` function](https://github.com/Consensys/linea-monorepo/blob/660f849d1757700df369ebf33964ed03862b8a8c/contracts/contracts/LineaRollup.sol#L176) allows the [`fa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Redundant use of uint256
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In contract TradingExtension, function “getVerifiedPrice” at line #143, the function argument “_withSpreadIsLong” is declared as uint256 even it acts as a flag and takes small values. This is also found... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | dos | true | false | ## High: Incorrect Reward Claim Logic in FeeCollector::claimRewards Causes Denial of Service
### Description
The `claimRewards` function in the FeeCollector contract is designed to allow users to claim their accumulated rewards based on their voting power. The rewards are calculated using the formula:
pendingReward =... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: StakerLightFactory Requires Dual-Step Initialization
### Description
The `StakerLightFactory` contract, as implemented, has a critical dependency on setting the `referenceImplementation` before its primary function, `createStakerLight()`, can be invoked. This dependency creates a mandatory two-step initializat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Set Solidity version fixed
### Description
**Description**
Contracts have ^0.8.0 Solidity version and ^4.1.0 OpenZeppelin version. Technically such a
setup should pick the highest available version. Nevertheless, the best practice is to have a
fixed version of Solidity and OZ library (like 0.8.4 or the latest... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: getReserves does not check if tokens match
### Description
## Email address
mail@cmichel.io
## Handle
@cmichelio
## Eth address
0x6823636c2462cfdcD8d33fE53fBCD0EdbE2752ad
## Vulnerability details
The `UniswapStyleLib.getReserves` function does not check if the tokens are the pair's underlying tokens.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Redundant Selector Validation in `_validateSingleCall()`
### Description
The function `_validateSingleCall()` performs a redundant validation check by calling `_isValidSelector(selector)` after the same check was already executed within the `_digestClaimTx()` function. It creates unnecessary gas overhead and c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: yieldDistribution iterates over unbounded yieldRecipients array
### Description
The `Deal.yieldDistribution` function is used whenever yield is distributed in `DealManager.initiateInterestPayout`. The function iterates over the entire Deal's `$.yieldRecipients` state array.
This array never shrinks; yield re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing `initializer` modifier on constructor
### Description
OpenZeppelin [recommends](https://forum.openzeppelin.com/t/uupsupgradeable-vulnerability-post-mortem/15680/5) that the `initializer` modifier be applied to constructors in order to avoid potential griefs, [social engineering](https://forum.openzeppe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Division before multiplication in the `calculateShareFromTime` method
### Description
The `requiredRebases` variable is calculated by using division by `1 days`. It can unexpectedly round down to zero but this won't lead to any problems, as then the result is passed to the `calculateRebasePercentage` method, w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Using only DEX swappers is suboptimal
### Description
**Severity**
Impact: Medium, swaps without aggregator might have a high price impact for large amounts.
Likelihood: Medium. Depending on how much amount it is being swapped this can be a frequent problem.
**Description**
Currently, most of the action... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Business Logic | true | false | ## Medium Risk Severity Report
## Context
LibDiamond.sol#L95-L119
## Description
The function `diamondCut()` of `LibDiamond` verifies the signed version of the update parameters. It checks whether the signed version is available and if a sufficient amount of time has passed. However, it doesn’t prevent multiple execu... | Spearbit | 5 | Connext |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Ohm library limitation for nested expressions
### Description
The Tact compiler uses the Ohm parsing toolkit to implement the source code parser. The Ohm library uses recursion to parse nested items in expressions and throws a `RangeError: Maximum call stack size exceeded` error for deeply nested expressions.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Proxy admin doesn’t entirely cede upgrade control to governance address
### Description
In the [`AudiusAdminUpgradeabilityProxy` contract](https://github.com/AudiusProject/audius-protocol/blob/6f3b31562b9d4c43cef91af0a011986a2580fba2/eth-contracts/contracts/AudiusAdminUpgradeabilityProxy.sol#L11), the [inline... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use onlyAccredited Modfier . . . . . . . . . . . . . . . . . . . . . . . . . . . .
### Description
## Contract Functionality and Accredited Addresses
For many functions in the contract, the `accreditedAddresses` check is used to ensure the functions can only be called by the accredited addresses (Vault, Closu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Type Mismatch in Decoding Functions
### Description
The decoding functions in the `VWCode` library (`chainidsAndExpTime`, `splitCode`, `getFlag`) return values using incorrect type sizes. For example, `dstChainId` is declared as `uint256` but should be `uint32` as per the type used in the `genCode` function. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `Minter.updatePeriod` fails if `Voter.totalWeight` is zero
### Description
In the `Minter` contract, the `updatePeriod()` function is responsible for distributing rewards to the `RewardDistributor` contract, `team`, and `Voter` contract.
The function calls `VOTER.notifyRewardAmount()` after sending the rewards... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: [15] Owner cannot change the allocator address from `address(0)`
### Description
*Note: At the judge’s request [here](https://github.com/code-423n4/2024-04-gondi-findings/issues/70#issuecomment-2067964983), this downgraded issue from the same warden has been included in this report for completeness.*
https://... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unused Variables
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
The smart contract contains variables `minStakingDuration` and `locked` that are declared but not used anywhere in the code. Unused variables can lead to unnecessary gas costs and code bloat. They may also indi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Lack of safe transfer wrapper
### Description
In `ousgInstantManager` the admin can make a call to transfer any tokens out of the contract.
[`ousgInstantManager::retrieveTokens`](https://github.com/code-423n4/2024-03-ondo-finance/blob/main/contracts/ousg/ousgInstantManager.sol#L819-L825):
Some tokens behave... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Time Weighted Average Price oracles are susceptible to manipulation
### Description
It should be noted that on-chain TWAP oracles are [susceptible to manipulation](https://eprint.iacr.org/2022/445.pdf). Using them to power critical parts of any on-chain protocol is [potentially dangerous](https://blog.openzepp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | logic | true | false | ## Medium: reLP() mintokenAAmount the calculations are wrong
### Description
in `reLP()` , Calculating ` mintokenAAmount ` using the wrong formula can invalidate the slippage protection
### Proof of Concept
`ReLPContract.reLP()`The implementation is as follows:
The formula for calculating `mintokenAAmount` in the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: [17] Not using the named return variables anywhere in the function is confusing
### Description
Consider changing the variable to be an unnamed one
*There are 3 instances of this issue:*
https://github.com/code-423n4/2022-09-artgobblers/blob/d2087c5a8a6a4f1b9784520e7fe75afa3a9cbdbe/src/utils/token/GobblersE... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Denial-of-Service Condition by Maliciously Extending Auctions
### Description
It is possible to prevent genuine use of any auction for up to `bid.maxTTL` in certain scenarios. This can be done by starting and repeatedly updating (via `placeBid()`) an auction for a token with no or very low initial balance. Thi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Users setting an incorrect tokenURI might end up losing their deposits
### Description
When buying tokens via `crossChainBuy()` if a user sets an empty `tokenURI` for an ERC721 DAO, or sets a non-empty `tokenURI` for an ERC20 DAO, the transaction will succeed on the source chain, but it will revert on the dest... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Vote | false | false | Source: https://github.com/sherlock-audit/2022-11-frankendao-judging/issues/25
## Found by
hansfriese, 0x52, Trumpero
## Summary
Governance#castVote can be called by anyone, even users that don't have any votes. Since the voting refund is per address, an adversary could use a large number of addresses to vote with... | Sherlock | 4 | FrankenDAO |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: add_tokens_to_basket does not check whether any of the values in mints is Pubkey::default()
### Description
The `add_tokens_to_basket` function takes a vector of public keys and adds them to the `token_amounts` array. The function uses `Pubkey::default()` as a sentinel value to represent an empty slot in the a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Protocol and Reserve Fees cannot be withdrawn
### Description
## Context
**File:** `InterestImpl.sol#L51`
**Description:** Shares equivalent to the protocol and reserve fees are assigned to the correct recipient. However, they cannot withdraw because only the `wrappedVault` is allowed to call the `Dahlia.wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: ContractMigrationFacet migrates incorrect amount of Stalk
### Description
L2ContractMigrationFacet is used to migrate Silo deposits owned by smart contracts. During migration it calculates grown Stalk associated with deposits. Problem is that wrong precision is used in that calculation.
### Impact
Grown Stal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | true | ## Low: logic doesn 't verify against $enabledSessions
### Description
In general, when a permission ID is used in an important function of the SmartSession codebase, there is a check that the user's `$enabledSessions` storage contains the permission ID. However, this check is missing in the ERC-1271 logic.
Fortunate... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | true | ## Medium: Seller finalization of an o�fer with an a�filiate and commission results in trapped funds
### Description
When a buyer submits a listing offer with a commission value and it is subsequently accepted by the seller, the commission is subtracted from the listing’s deposit, leaving the commission escrowed in the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Liquidator will leave a pool with unassigned earnings on `Market::clearBadDebt()` free to claim for anyone when the repaid maturity is not the last
### Description
This issue remains from the [last](https://github.com/sherlock-audit/2024-04-interest-rate-model-judging/issues/130) audit, only a partial fix w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: `abi.encodePacked` Allows Hash Collision
### Description
From the solidity documentation:
https://docs.soliditylang.org/en/v0.8.17/abi-spec.html?highlight=collisions#non-standard-packed-mode
> If you use `keccak256(abi.encodePacked(a, b))` and both `a` and `b` are dynamic types, it is easy to craft collis... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Connected pair of parameters (phaseversion and tokendebit)
### Description
**Description**
Parameters phaseversion and tokendebit are set together in constructor and can be changed
only together in enablePhase2() method. There is no way to change them separately, and
these two parameters can have only 2 possib... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: [08] Code does not follow the best practice of check-effects-interaction
### Description
Code should follow the best-practice of [check-effects-interaction](https://blockchain-academy.hs-mittweida.de/courses/solidity-coding-beginners-to-intermediate/lessons/solidity-11-coding-patterns/topic/checks-effects-inte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using a positive conditional flow to save a NOT opcode
### Description
In order to save some gas (NOT opcode costing 3 gas), switch to a positive statement:
Estimated saving:
| Method call or Contract deployment | Before | After | After - Before | (After - Before) / Before |
| :- | :-: | :-: | :-: | :-: |... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Collateral Depreciation Can Result in Protocol Debt Spiral
### Description
**Update**
The client provided the following explanation:
> Centralization method to buy back the bad debt.
**Update**
This issue was extensively discussed with the client. The client takes all measures in preventing bad debt and is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: Missing Input Validation
### Description
* There is no zero address check in function `addOperator` for the operator address and fee recipient. Also, the function doesn’t check whether the operator already exists.
**src/contracts/StakingContract.sol:L392-L405**
```
function addOperator(address \_operato... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Non-existing revenue contract can be passed to claimRevenue to send all tokens to treasury
### Description
Neither `SpigotLib.claimRevenue` nor `SpigotLib._claimRevenue` check that the provided `revenueContract` was registered before. If this is not the case, `SpigotLib._claimRevenue` assumes that this is a r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Misleading `elementIds` Configuration Is Ignored During Result Generation
### Description
The `elementIds` are accepted as part of `BuildConfiguration` but are never stored or used. Only the length of the array is persisted (`elementCount`), and all result generation implicitly assumes element IDs are `0..elem... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Missing Size Checks for `compose_msg` can Lead to Oversized Messages and Transaction Failures
### Description
The ONFT implementation currently lacks explicit size checks for the `compose_msg` parameter in its encoding functions. This omission could potentially lead to the creation of oversized messages, wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Rebalance amounts should be checked so that updated balances falls within thresholds
### Description
Rebalance operations are allowed when the current percentage of xETH in the Curve pool is outside the defined thresholds. However, there is no check to ensure that the amount of xETH added or burned from the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Variables: "constants" expressions are expressions, not constants
### Description
Due to how `constant` variables are implemented (replacements at compile-time), an expression assigned to a `constant` variable is recomputed each time that the variable is used, which wastes some gas.
If the variable was `immut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Add Sanity Checks
### Description
## Audit Summary: native_pool::unstake_amount_from_validators
`native_pool::unstake_amount_from_validators` has the potential to terminate unexpectedly in two different instances due to unforeseen cases.
## Original Code
## Remediation
Handle these cases instead of trigge... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: _isEnoughIMStrict might not be strong enough
### Description
In the case that `critHR Hf` is greater than 1 wad, the check in `_isEnoughIMStrict` is not strong enough to guarantee that the health ratio would not be less than `Hf`. Based on the Boros research paper and its Finding 1, we know that (the 1st in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: _priceToIndex will revert if price istype(uint128).max
### Description
Because `price` is of type `uint128`, the increment will overflow first before it is cast to `uint256`:
```solidity
uint256 shiftedPrice = uint256(price + 1) << 64;
```
### Recommendation
Cast `price` to `uint256` first:
```solidity
- uint... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.