prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: UNEXPECTED LIQUIDATABLE STATUS IN NEW ESCROWEDLOAN
### Description
In the `EscrowedLoan` contract, the `_healthcheck()` internal function is supposed to check if the loan has the correct collateral ratio. Otherwise, the loan status is set to `LIQUIDATABLE`. The `_healthcheck()` function base on the `_getLates... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Function Calls in Loop Could Lead to Denial of Service
### Description
Function calls made in unbounded loop are error-prone with potential resource exhaustion as it can trap the contract due to the gas limitations or failed transactions
[RRUtils.sol#L291-L295](https://github.com/code-423n4/2023-04-ens/blob/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: withdrawETH can be blocked
### Description
Users submit their transactions to the sequencer either directly or through a forcing mechanism on L1. The sequencer then bundles those into blocks. Either through luck or in a worst-case scenario, through collusion with the sequencer, a user could continue to submit ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: GoErrorStringFormat (wallets/usbwallet/ledger.go: 140)
### Description
**Severity**: Low
**Status**: Acknowledged
**Recommendation**:
Rewrite the error message not to be capitalized and not end with punctuation. For example, change it to "Ledger version 1.5.0 or higher is required for EIP-712 signing (foun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: CC `WP-H4 `from the WatchPug first report
### Description
There is still no definite code for interest accounting and the share price math used in PoolV3 deposit and withdrawal operations is always `1.0`, not taking into account. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Incomplete Cap Safety Check Against `MAX_SANE_AMOUNT`
### Description
Within `_validateCap`, caps are validated only based on a dynamic `allowedAdjustFactor`. However, **hard sanity limits** (`MAX_SANE_AMOUNT`) will still be enforced in downstream contracts like the **GovernanceModule**, leading to **unexpecte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Accounting error in PartyB's pending locked balance led to loss of funds
### Description
Accounting error in the PartyB's pending locked balance during the partial filling of a position could lead to a loss of assets for PartyB.
### Impact
Every time PartyB partially fill a position, their $pendingLockedBala... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Uniswap DOS
### Description
The `README.md` talks about the fact that the orderer splits up orders to reduce price impact. This means that either the `orderer` has a slippage bounds which can DOSed with [sandwich attacks](https://github.com/code-423n4/2021-04-maple-findings/issues/105), or the code uses some s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | false | ## Low: Use `msg.sender` instead of `owner()` inside `onlyOwner` functions
### Description
Using `msg.sender` instead of `owner()` inside `onlyOwner` functions is more efficient as it eliminates reading from storage. It is also safe since the `onlyOwner` modifier ensures that `msg.sender` is the owner:
```solidity
757... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Unbounded Bonus Ball Max Calculation Causes Denial of Service in Drawing Settlement Due to Excessive Gas Consumption
### Description
The `bonusballMax` value is calculated dynamically during drawing initialization without upper bounds validation, which can cause out-of-gas errors in critical settlement functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unnecessary converting
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In the `depositFromRewards()` function, `lastRewardsCycleEnd` local variable is set with a value converted `rewardsCycleEnd` to `uint32`. But `rewardsCycleEnd` is already a `uint32` type so no need to con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Incorrect Account And Bump
### Description
## Withdraw_v2 Runtime Error and Remediation
`Withdraw_v2` checks the `withdraw_from_burner_ta` variable to determine whether the withdrawal will occur from `burn_ta` or `vault_ta`. However, if `withdraw_from_burner_ta` is set to true, it utilizes `vault_ta` and `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | false | false | ## Medium: `WithdrawalPool::withdrawalBatches` array is only every increasing in size potentially leading to Denial Of Service
### Description
Every time withdrawals are finalized, a new batchId gets appended to `withdrawalBatches` array. Over time, this array is ever increasing and can lead to extremely large size. I... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Wrong state update in `liquidationType1` call
### Description
Not updating `usdaGainedFromLiquidation` state on `liquidationType1` instead `abondUSDaPool` is being updated.
This will make `abond usda ratio from liquidation` always == 0. And yields will never be increased/decreased.
Instead, yield from liquida... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Lack of The Expiry Parameter
### Description
The issue arises within the [`placeOrder`](https://github.com/longgammalabs/hanji-contracts/blob/09b6188e028650b9c1758010846080c5f8c80f8e/src/OnchainLOB.sol#L199) function of the `LOB` contract.
There is an issue due to the absence of an expiration parameter for... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Reward token in `GaugeFactoryCL` can be drained by anyone
### Description
### Findings Description and Impact
The `GaugeFactoryCL.sol` contract, responsible for creating `GaugeCL` instances for Algebra Concentrated Liquidity pools, has a public `createGauge` function. Below is the implementation of the funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Business Logic | false | false | Source: https://github.com/sherlock-audit/2023-01-uxd-judging/issues/288
## Found by
clems4ever, dipp, 0xNazgul, DecorativePineapple, ctf\_sec, unforgiven, 0x52, ck, HollaDieWaldfee, GimelSec, chiranz, berndartmueller, yixxas, Zarf, carrot, koxuan, hl\_, Ruhum, kankodu, Bahurum
## Summary
PerpDespository#reblance ... | Sherlock | 5 | UXD Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: API - AUTHENTICATED INTERNAL USERS CAN CREATE ADMIN USER
### Description
Inside the `user_router` within the `create_user` function which is responsible for creating new users, it was noted that the function requires only an authenticated user without any special permissions.
The `user` parameter within `crea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | reentrancy | true | true | ## High: Lack of reserve updates when collecting fees allows anyone to drain the Vault
### Description
The lack of reserve updates when fees are collected allows anyone to drain the Vault. The accumulated fees for each of the pools are counted as part of the token reserves of the Vault and can be collected by calling ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: public Functions Not Used Internally Could Be Marked external ✓ Fixed
### Description
In the mentioned locations, `public` functions are used within the smart contracts, but these functions do not appear to be called internally. Functions declared as `public` can be called both externally and internally, which... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Cache storage to prevent identical storage reads
### Description
**Description:** Reading from storage is expensive; cache storage to prevent identical storage reads:
* `ComplianceChecker.sol`:
* `CompliantDepositRegistry.sol`:
* `Blacklistable.sol`:
* `Minter.sol`:
* `StakingVault.sol`:
**Syntetika:... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: | Unequal Minting Rewards
### Description
**Description**
In `publicMint` the rewards distribution to `CYBERs` holders can only occur on the first mint and never
after.
**Recommendation**
Ensure this is the expected behavior. If it isn’t, refactor the reward logic to more fairly include `CYBERs` holders.
*... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Token approvals & allowances management is flawed
### Description
**Likelihood:**
Medium, because it will be problematic only with special type of tokens
**Impact:**
Medium, because it can lead to a limited loss of funds
**Description**
There are a few problems related to approvals & allowances in the co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Unenforced staking requirement of 500K HYPE may lead to unexpected behavior
### Description
Hyperliquid's HIP-3 enables permissionless deployment of custom perpetual futures markets on the HyperCore layer. It enforces a **500K HYPE** staking requirement to serve as a bond for market deployers and deter any mal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Redeem limit shouldn't be set below the `currentMintAmount`
### Description
The function `setRedeemLimit` is used by the admin to update the amount of token that can be redeemed during one epoch.
A check should be made to ensure the new redeem limit isn't set below the `currentMintAmount`.
As this problem will... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Protocol Fee Recipient Updates Are Not Enforced On Old EulerSwap Instances
### Description
**Description:** The `protocolFeeRecipient` value is stored in the parameters of each `EulerSwap` instance at the time of its deployment. When the [`ProtocolFee::setProtocolFeeRecipient`](https://github.com/euler-xyz/eul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | integer-overflow | true | false | ## Low: Use != 0 instead of > 0 for unsigned integer comparison | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Unrestricted call to destroyInstance
### Description
**Severity**: Critical
**Status**: Resolved
**Locaton**: Admin.sol
**Description**
The `destroyInstance()` function within the smart contract poses a significant security risk due to its unrestricted accessibility. Any wallet or address can call this fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: Replace `modifier` with `function` (6 instances)
### Description
Modifiers make code more elegant, but cost more than normal functions.
Deployment Gas Saved: **460 154**
All modifiers except `permissioned` due to unresolved error flow.
* src/Kernel.sol:[70-73](https://github.com/code-423n4/2022-08-olympus/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Ever-increasing priceCumulative variables Status: Resolved
### Description
In the Band price feed, `observations.priceCumulative` variables can increase indefinitely and overflow. Every call to the `update` method adds to one of the `observations.priceCumulative` variables, and there is neither a check for ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Loss of Fees for Router `UpliftOnlyExample` due to Division Rounding in Admin Fee Calculation, Causing Unfair Fee Distribution
### Description
The audit identified a vulnerability in the `UpliftOnlyExample` contract where a division rounding in the admin fee calculation lead to significant precision loss, res... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Spelling mistakes
### Description
Some texts have spelling mistakes:
1) `balanceAdderess` -> `balanceAddress`
https://github.com/EnsoFinance/shortcuts-contracts/blob/4902e55608f975f73772310955444110b1cfc4fc/contracts/helpers/EnsoShortcutsHelpers.sol#L14
2) `renounes` -> `renouns`
https://github.com/EnsoFin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Referrer rewards can be arbitraged by sandwich attacks
### Description
The `BunniToken` contract has a referrer mechanism, and referrer rewards are based on their scores. When BunniToken is transferred, the scores of the `from`'s referrer will be transferred to the `to`'s referrer.
```solidity
function t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: (HAL-02) Missing slippage checks in multiple locations
### Description
In multiple strategies, when converting reward tokens back to the underlying asset, the code commonly passes a minimum output of `1`:
```
IUniversalLiquidator(...).swap(rewardToken, underlying, balance, 1, address(this));
```
This does... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Inconsistent use of decimal/hex notation in inline assembly
### Description
For readability and to prevent errors when working with inline assembly, decimal notation should be used for integer constants and hex notation for memory offsets.
**Beanstalk:** All new code written for Basin uses decimal notation. D... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: The Owner and Proxy Admin can make users lose funds ("rug vectors")
### Description
_Submitted by gellej, also found by WatchPug, Czar102, csanuragjain, p4st13r4, pedroais, TomFrenchBlockchain, defsec, hubble, gzeon, 0x1f8b, and sirhashalot_
The contest explicitly asks to analyze the contract for "Rug Vect... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect Semantics for `Bitfield.activateFrom()`
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `5e6c5e40466b151d96b6ab1f2301800dda0cf7d2`.
Recommendation implemented.
**File(s) affected:**`Bitfield.sol`
**Description:** The function `activateFrom()` "takes an existing bitfield, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Risk users are required to payout if the price of the pegged asset goes higher than underlying
### Description
Insurance is to protect the user in case the pegged asset drops significantly below the underlying but risk users are required to payout if the pegged asset is worth more than the underlying.
### Pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unpinned NPM Dependencies
### Description
## Supply Chain Vulnerability in NPM Packages
The application incorporates specific NPM packages for which the dependency versions are not explicitly defined in the project’s configuration. This situation may allow supply chain attackers to exploit a package within th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Full access key is not removed on ownership change
### Description
**Description:** The full access key is not removed on changing owner. This allow old owner to still have ownership using the access key set by him.
- Owner Asets a new full access key using attach\_full\_access\_key function
- Owner is chang... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Duplicated Code In Admin.viewCurrentMaintenanceStaker()
### Description
## Handle
jvaqa
## Vulnerability details
Duplicated Code In Admin.viewCurrentMaintenanceStaker()
## Impact
There are four lines of code that are duplicated in viewCurrentMaintenanceStaker
## Recommended Mitigation Steps
Change this... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Possible transfer of bad account
### Description
User can have bad account with Hf < 1 but not liquidated yet, and transfer it to another user:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditManager.sol#L954
### Recommendation
We rec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Docstrings
### Description
Throughout the in-scope codebase, multiple instances of missing docstrings were identified. For instance, in [line 107](https://github.com/crown-xyz/crown-contracts/blob/13631abf8ba2f2c183918ec288781c297b344d14/contracts/YieldStripping.sol#L106:107) of `YieldStripping.sol`
C... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: Cache required storage slots in top-level functions then pass cached values to child functions
### Description
A common pattern of inefficiency is when parent functions read certain storage slots, then call child functions (which can themselves call other child functions), and the child functions re-read the s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Functions should be declared as external
### Description
**Description**
ImpossiblePair.getFeeAndXybk() (ImpossiblePair.sol#67-70)
ImpossiblePair.updateGovernance(address) (ImpossiblePair.sol#140-143)
ImpossiblePair.makeXybk(uint8,uint8,uint32,uint32) (ImpossiblePair.sol#146-169)
ImpossiblePair.makeUni() (Imp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Potential lock of rewards in the custody contracts
### Description
The `swap_to_stable_denom` function in the custody contracts swaps all other native tokens into a specific one. The function creates swap messages for all the other native tokens and adds them as sub-messages, and handles the reply only when... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: level calls with solidity version 0.8.14 can result in optimiser bug
### Description
https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/governance/OwnerProxy.sol#L20
The protocol is using low level calls with solidity version 0.8.14 which can result in optimiz... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Debt write off can be prohibited by HPB depositor by continuously allocating settlement blocking dust deposits in the higher buckets
### Description
High price bucket depositor who faces bad debt settlement can add multiple dust quote token deposits to many higher price buckets and stale settlement.
### Impa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Delegations of the entire totalPool can be griefed
### Description
Delegations are permissioned only to the operator role. An intended action would be for the operator role to fetch the total pool value and call `delegate` with the entire amount:
```solidity
function delegate(uint256 validatorId, uint256 amou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Hidden governance
### Description
_Submitted by 0x1f8b_
The contract use two governance model, one looks hidden.
### Proof of Concept
The [VUSD contract](https://github.com/code-423n4/2022-02-hubble/blob/8c157f519bc32e552f8cc832ecc75dc381faa91e/contracts/VUSD.sol#L11) uses `VanillaGovernable` but inherit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | false | false | ## Low: `TokenBank::addToken` should revert if token has already been added
### Description
`TokenBank::addToken` should revert if token has already been added.
### Impact
Token data such as `saleAmount` and `feeAmount` will be reset to zero causing other core functions to malfunction. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Privileged Roles
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> Acknowledged. Documentation updated.
**File(s) affected:**`STPV2.sol`, `STPV2Factory.sol`
**Description:** We include the observed privileged roles and their capabilities belo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [09] Incorrect NatSpec comment in `adjustCdpWithWstEth` function leading to potential misunderstanding
### Description
The NatSpec comment for the `adjustCdpWithWstEth` function incorrectly mentions "wrapped Ether" instead of "wrapped staked Ether". This could cause confusion for auditors and developers.
http... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: PausableInterface variables never used
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In TradingStorage contract, `trading` and `callbacks` variables uses PausableInterface but never uses the only method defined in it, i.e. isPaused().
**Recommendation**:
Remove the unus... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: LACK OF ADDRESS NORMALIZATION
### Description
The `set_manager` function of the staking contract takes user input directly as an address without performing any validation. This could lead to failed messages or the storage of incorrect information.
However, the impact in this particular case is very limited si... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: GoDeprecation
### Description
**Severity**: Low
**Status**: Acknowledged
**Description:**
The codebase uses several deprecated functions and types. While this does not necessarily indicate a vulnerability, it is good practice to update to newer versions to benefit from potential improvements and bug fixes.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Double Verification For Owner Change
### Description
## Update Lending Market Owner Process
In `handler_update_lending_market::process`, the owner of the lending market is updated via `UpdateLendingMarketMode`. However, the owner change is currently a single-step process; there is no confirmation step. Once t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: partial_sha256_var_interstitial Unnecessary Constraints When N Is Larger Than message_size by More Than BLOCK_SIZE
### Description
As described in [issue 5.6](#partial_sha256_var_interstitial-may-give-the-same-hash-state-h-for-different-data-objects-if-they-are-smaller-than-message_size) , there are issues ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Transfer identifier could be stored with a cheaper value type
### Description
In Solidity, using strings is not the most gas efficient way to handle data, since they are stored as a dynamic array.
If the length is 32 bytes or longer, the slot in which they are defined stores the length of the `string * 2 + 1`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Vault curator can force `operator.claimReward()` to revert with precision
### Description
A vault curator can allocate a **very small amount** of stake to an operator. Due to precision loss (e.g., rounding errors) in `_getRewardsAmountPerVault()`, the vault may end up with a **reward amount of zero**.
```so... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: WithdrawalRequestERC721 balance does not decrease after claiming
### Description
**Severity:** Low
**Path:** WithdrawalRequestERC721.sol:balanceOf#L112-L115
**Description:**
A withdrawal request implements ERC721 and so acts as an NFT. Once a withdrawal request is claimed, it cannot be transferred anymore a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Reserving a listing checkpoints the collection's `compoundFactor` at an intermediary higher compound factor
### Description
When a listing is reserved (**Listings**#`reserve()`) there are multiple CollectionToken operations that affect its `totalSupply` that take place in the following order: transfer → tra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Incorrect Execution Fee Refund address on Failed Deposits or withdrawals in Strategy Vaults
### Description
The Strategy Vaults within the protocol use a two-step process for handling deposits/withdrawals via GMXv2. A **`createDeposit()`** transaction is followed by a callback function (**`afterDepositExecuti... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: TokenFaucet refill can have an unexpected outcome
### Description
The `TokenFaucet` contract can only disburse tokens to the users if it has enough balance. When the contract is running out of tokens, it stops dripping.
**code/pool-contracts/contracts/token-faucet/TokenFaucet.sol:L119-L138**
```
uint256... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing checks for address(0) on initialization
### Description
Throughout the code in scope, there are several instances where the contracts do not check for the `address(0)` when initializing the upgradeable contracts in scope. This can lead to an incorrect deployment state of contracts, where an improper in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Wrong Math | true | false | ## Handle
cmichel
## Vulnerability details
The `Vault.balance` function uses the `balanceOfThis` function which scales ("normalizes") all balances to 18 decimals.
```
for (uint8 i; i < _tokens.length; i++) {
address _token = _tokens[i];
// everything is padded to 18 decimals
_balance = _balance.add(_no... | Code4rena | 5 | yAxis |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Reentrancy concerns ✓ Fixed
### Description
#### Resolution
Fixed in [3bbafab926df0ea39f444ef0fd5d2a6197f99a5d](https://github.com/TidalFinance/tidal-contracts-v2/tree/3bbafab926df0ea39f444ef0fd5d2a6197f99a5d) by implementing the auditor’s recommendations.
#### Description and Recommendation
A. All exter... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: ETH redemptions via `SignatureRedeemQueue` are broken due to missing `receive` function
### Description
The `SignatureRedeemQueue` contract lacks a `receive()` function, causing ETH redemptions to fail.
### Impact
ETH users cannot redeem through Signature queues - the transaction always fails.
### Recomme... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Reading Same state variable twice due to modifier usage (Save 2040 Gas on average from the tests)
### Description
https://github.com/code-423n4/2023-10-ethena/blob/ee67d9b542642c9757a6b826c82d0cae60256509/contracts/EthenaMinting.sol#L194-L205
| | Min | Average | Median | Max |
| ------ | --- | ------- | --... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Whitelist can be bypassed in `DIAWhitelistedStaking`
### Description
This issue has been identified within the `stakeForAddress` function of the `DIAWhitelistedStaking` contract.
It is possible to call `stakeForAddress()` and specify any whitelisted beneficiary, assigning 100% of the rewards to the principa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Variable participants could lose their fee earnings
### Description
**Severity**
**Impact:** High, affected variable participants will lose their fee earnings
**Likelihood:** Medium, occurs when final total staking earnings is lower than on-going period
**Description**
`calculateVariableWithdrawState()` i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | false | false | ## Gas: State variables only set in the constructor should be declared `immutable`
### Description
Avoids a Gsset (**20000 gas**) in the constructor, and replaces each Gwarmacces (**100 gas**) with a `PUSH32` (**3 gas**).
*There are 2 instances of this issue. (For in-depth details on this and all further gas optimiza... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Missing Docstrings
### Description
Throughout the [codebase](https://github.com/matter-labs/zksync-2-contracts/tree/4346dfc55a3c56817934a1231b64d6ef246074a7/), there are several parts that do not have docstrings:
* [`ethereum/contracts/bridge/interfaces/IL2Bridge.sol`](https://github.com/matter-labs/zksync-2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `amountDeposited` is never decremented, blocking new deposits
### Description
_Acknowledged_
In `deposit()`, the module increases `_getStakingModuleStorage().amountDeposited` by the deposited amount, but never decreases it when funds are withdrawn. Because the deposit cap check compares against the cumulative... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | true | ## High: Dispute pledges for a NoResolution dispute can be stolen by anyone
### Description
If a dispute status has been marked as `NoResolution`, anyone can steal all of the pledged tokens for this dispute.
Once an escalated dispute has been resolved, the `BondEscalationAccounting` contract allows users to withdraw ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Math rounding in AutoRoller.sol is not ERC4626-complicant: previewWithdraw should round up.
### Description
Math rounding in AutoRoller.sol is not ERC4626-complicant: previewWithdraw should round up.
### Impact
Other protocols that integrate with Sense finance AutoRoller.sol might wrongly assume that the f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: `migrateToken` in MarinateV2.sol does not update `totalTokenRewardsPerStake`.
### Description
**Description**
MarinateV2.sol - migrate Token transfers reward tokens to another address and does not update the value of total Token RewardsPerStake accordingly, which shall in turn cause loss of funds to some sta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Incorrect CPI and transfer call sequence in `cancel_auction`.
### Description
**Description**
During the testing phase, the team discovered an issue with the cancellation of the auction where the bid was placed. We received a runtime error "UnbalancedInstruction". It occurred because there is a transfer of... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Two powerful functions could be combined to reduce impact
### Description
The function `BaseRouter::_transferToEscrow` and `node::finalizeRedemption()` are both quite powerful:
- `BaseRouter::_transferToEscrow`: Moves assets to the escrow.
- `node::finalizeRedemption()`:
- Burns shares
- Updates `sharesE... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Factory owner can prevent fee collector from claiming fees
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
`claimFees` function is used to claim fees that accrue over time.
10 percent of the fees go to the factory owner.
If the factory owner is a contract that is compr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: `initNXTP` and `initHop` emit no event.
### Description
[NXTPFacet.sol: L33-37](https://github.com/code-423n4/2022-03-lifinance/blob/main/src/Facets/NXTPFacet.sol#L33-L37)
[HopFacet.sol: L40-52](https://github.com/code-423n4/2022-03-lifinance/blob/main/src/Facets/HopFacet.sol#L40-L52)
Emitting an event with t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | flash-loan | false | false | ## Medium: PoolManager allows funds from verified pools to be used by sanctioned accounts during flashloans
### Description
Severity: Medium Risk
Context: (No context files were provided by the reviewer)
Description: Tainted funds can be moved throughPoolManager and sanctioned entities can borrow capital which
stems f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Lack of Ether Withdrawal Functionality
### Description
**Severity**: Low
**Status**: Resolved
**Description**
The FlashDuels contract includes both fallback() and receive() functions to accept incoming Ether. However, there is no function that allows the contract to withdraw or transfer the Ether back out. ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Outdated OpenZeppelin vesting contract in use
### Description
The vesting contract [`TokenVesting`](https://github.com/propsproject/props-token-distribution/blob/eaf0c6fddd320a258a9d7531d72d07a830fae58a/contracts/TokenVesting.sol) is outdated and has two known low-severity issues, thoroughly described in [the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: Structs can be packed into fewer storage slots
### Description
Each slot saved can avoid an extra Gsset (**20000 gas**) for the first setting of the struct. Subsequent reads as well as writes have smaller gas savings
*There are 2 instances of this issue. (For in-depth details on this and all further gas optim... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | access-control | true | false | Source: https://github.com/sherlock-audit/2023-03-taurus-judging/issues/43
## Found by
J4de, KingNFT
## Summary
According to Taurus contest details, all roles, including the admin ````Multisig````, should not be able to drain users collateral.
```solidity
2. Multisig. Trusted with essentially everything but user co... | Sherlock | 4 | Taurus |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: Users deposit assets to the vault but receives no strategy token in return
### Description
Due to a rounding error in Solidity, it is possible that a user deposits assets to the vault, but receives no strategy token in return due to issues in the following functions:
- StrategyUtils._convertBPTClaimToStrate... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Missing access restriction on lockUnits/unlockUnits
### Description
## Handle
@cmichelio
## Vulnerability details
## Vulnerability Details
The `Pool.lockUnits` allows anyone to steal pool tokens from a `member` and assign them to `msg.sender`.
## Impact
Anyone can steal pool tokens from any other user.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Risk of Fertilizer id collision that could result in loss of funds
### Description
If a user mints Fertilizer tokens twice during two different seasons, the same token id for both tokens could be calculated, and the first entry will be overridden; if this occurs and the bpf value changes, the user would be en... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | initialization | true | true | Source: https://github.com/sherlock-audit/2024-01-napier-judging/issues/90
## Found by
xiaoming90
## Summary
LP Tokens are always valued at 3 PTs. As a result, users of the AMM pool might receive fewer assets/PTs than expected. The AMM pool might be unfairly arbitraged, resulting in a loss for the pool's LPs.
## V... | Sherlock | 5 | Napier |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: NFTs can never be redeemed back to their conviction scores leading to lock/loss of funds
### Description
Besides the conviction scores of users, there appears to be tracking of the FairSide protocol's tokenized conviction score as a whole (using `fscAddress = address(fairSideConviction)`). This is evident i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Missing slippage protection in `deposit()`,` mint()`, and `redeem()` functions
### Description
- The `deposit()`, `mint()`, and `redeem()` functions in the `OmoRouter` contract lack a slippage mechanism to safeguard against significant deviations in the assets received or shares minted, which would result i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Vault Inflation Attack
### Description
Malicious users can perform an inflation attack against the vault to steal the assets of the victim.
### Impact
Malicous users could steal the assets of the victim.
### Recommendation
A `MIN_LIQUIDITY` amount of shares needs to exist within the vault to guard against... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Ineffective Shared Escrow Validation
### Description
## CreatePool Shared Escrow Constraint Issue
In `CreatePool`, the `shared_escrow` field is constrained with the following check:
This constraint is intended to ensure that a pool using shared escrow cannot have a `PoolType::NFT` configuration. However,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: SignatureVerification BrokenUnderEIP-7702DuetoRelianceonisContractLogic
### Description
In the FactCheckExchange.sol contract,the settleMatchedOrders() function attempts to
validate orders using signatures by distinguishing EOAs from contracts. It uses the following logic:
-If the address has code (isContr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: WASI preview 1 may be incompatible with future versions
### Description
Stylus was recently updated to use Go 1.21’s WASI preview 1 for its WASM execution. (Previously, WASM was run through a JavaScript engine embedded in the Rust code.) However, since this iteration of WASI is only a preview and, according to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Unchecked Fund Provision
### Description
## Pyth Price Update Issue in Contracts
In the `GlpManager`, `PositionRouter`, and `Router` contracts, when updating Pyth prices, the invoker of `updatePriceFeeds` must pay an update fee. The contracts assume that the caller (i.e., `msg.sender`) is responsible for cove... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Function Can Be Declared external
### Description
The `claimRelayerRefund` [function](https://github.com/across-protocol/contracts/blob/401e24ccca1b3af919dd521e58acd445297b65b6/contracts/SpokePool.sol#L1265) of the `SpokePool` contract is declared as `public` but can be defined as `external` instead.
In order... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: The `DeliveryPlace::settleAskTaker()` function mistakenly uses `makerInfo.tokenAddress` to update the `TokenBalanceType.PointToken` in the `userTokenBalanceMap` mapping, leading to a critical error.
### Description
The `DeliveryPlace::settleAskTaker()` function mistakenly uses `makerInfo.tokenAddress` to upda... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Wrong Math | true | true | ## Lines of code
https://github.com/code-423n4/2022-03-biconomy/blob/db8a1fdddd02e8cc209a4c73ffbb3de210e4a81a/contracts/hyphen/LiquidityPool.sol#L319-L322
## Vulnerability details
## Impact
The `getAmountToTransfer` function of `LiquidityPool` updates `incentivePool[tokenAddress]` by adding some fee to it but the f... | Code4rena | 3 | Biconomy |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.