prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | true | ## Low: Easily bypass `setGuardian` proposal passing requirement
### Description
`AdminVoting::createNewProposal` calls `_isSetGuardianPayload` to detect whether a proposal contains a call to `IBabelCore.setGuardian`. If `true` then it requires a 50.1% majority in order for the `setGuardian` proposal to succeed, other... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Account Creation DOS
### Description
## Schedule Initialization Issue
In the create instruction, the program forcefully initializes the schedule associated token account. This would fail if the account already exists, leading to a denial of service. Note that anybody can create an associated token account.
T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Staking Before Initial notifyRewardAmount Can Lead to Disproportionate Rewards
### Description
If a user successfully stakes an amount of UNI tokens before the function `notifyRewardAmount()` is called for the first time, their `initialuserRewardPerTokenPaid` will be set to zero. The first time `notifyRewardA... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Wrong naming with closeLong and closeShort booleans
### Description
In the `LimitTradeHandler`, the `closeLong` boolean is true if and only if the order is decreasing a short position, and the `closeShort` boolean is true if and only if the order is decreasing a long position. The naming seems to be the opposi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | token | true | false | Source: https://github.com/sherlock-audit/2023-03-sense-judging/issues/36
## Found by
spyrosonic10
## Summary
`sponsorSeries()` fails when user want to use `swapQuote` to swap for stake token to sponsor a series.
## Vulnerability Detail
stake is token that user need to deposit (technically is pulled) to be able to... | Sherlock | 5 | Sense Update #1 |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Prefixed variable name
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In contract Swap.sol, at line 102 the variable of type IBorrowForSwap is prefixed with the “$” sign. This is not considered naming best practice in Solidity and is not ideal for readability.
**Recommenda... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate
### Description
Saves a storage slot for the mapping. Depending on the circumstances and sizes of types, can avoid a Gsset (**20000 gas**) per mapping combined. Reads and subsequent writes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Mint Checks on Token Account
### Description
## Token Account Mint Validation
In some instructions, there is no validation for the mint of the token account. Even though mint check was ensured by the token transfer CPI calls, it is better to catch errors before this happens and provide a custom error message.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Unintended token burning due to invalidation of _to in transfer functions.
### Description
The _to field in transfer events is not checked for the 0x0 address. External third-party applications which implement the ERC20 interface may interpret no input in ERC20 fields as 0. Thus, users can quite easily inadver... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `createAccount()` skips `isModuleAllowed` for prevalidation hooks
### Description
The `createAccount` function in the `RegistryFactory` contract verifies whether each module (validators, executors, hook, and fallbacks) is whitelisted using the `_isModuleAllowed` check. However, it does not perform this check f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: No minimum rate in the auction may break the protocol under network failure
### Description
_Submitted by jonah1005_
#### Impact
The aution contract decides a new `ibRatio` in the function `settleAuction`. [Auction.sol#L89-L91](https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contrac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Governance can indefinitely disable withdrawal of user funds
### Description
**Severity** : Informational
**Status**: Acknowledged
**Description**
In contract FEYTraderJoeProduct, function withdrawn(), allows a user to withdraw the investment from the product once the tranche is matured. The gacPausable() ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Potential inability to claim reward
### Description
https://github.com/defistarter/contracts/blob/9ffe009ee6047ced669711dde14fe38483abdf7e/StakingPool.sol#L328
There is a `for` loop with potentially huge amounts of iterations, so that can take an uncontrolled amount of gas and that can cause inability to c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: BasePool.swap() Is Callable By Anyone
### Description
## Handle
leastwood
## Vulnerability details
## Impact
The `BasePool.swap()` function differs from its implementation in `BasePoolV2.swap()` in which it lacks an `onlyRouter` modifier. This ensures that users cannot call this function directly as `V... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Avoid Setting Large Shared Decimals on XVS Bridges
### Description
**Update**
Marked as "Acknowledged" by the Venus team. The Venus team provided the following explanation:
> The `sharedDecimals_` will be set to 8 on the bridges, as can be checked in the following deployment scripts:
>
>
> https://github.co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: `treasuryPct` can be exceeded than `BPS` due to incorrect validation in `RevenueHandler.sol` constructor
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/RevenueHandler.sol
Impacts:
- Logic errors
- Contract fails to deliver promised retur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: The `mint()` Functions in `NftFactory` Do Not Function Properly
### Description
The `publicMint()` and `preMint()` in `NftFactory.sol` will call the corresponding functions in the NFT contract:
```solidity
function publicMint(address nft, uint256 mintAmount) external returns (uint256) {
uint256 tokenId =... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Unbacked tokens can be used for opening positions
### Description
When a position is opened the leverage is taken from the corresponding pool. If the pools available liquidity is lower than the requested leverage amount then the operation can't be executed. However, there is an edge case where pools availab... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Blacklisted accounts can still transact.
### Description
Accounts that have been blacklisted by the [`BLACKLISTER_ROLE`](https://github.com/sherlock-audit/2024-02-telcoin-platform-audit-update/blob/21920190e0772afa18e7f856a036fea3ef5b9635/telcoin-contracts/contracts/util/abstract/Blacklist.sol#L32) continue... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Redundant account checks
### Description
## Event Queue Validation in Aob and Dex
## Aob's `consume_events` Instruction
In Aob's `consume_events` instruction, the market's event queue is validated twice.
## Aob’s `new_order` Instruction
In Aob’s `new_order` instruction, the event queue header’s account ta... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Floating Pragma
### Description
The solidity compiler version should be fixed to clearly identify the Solidity version with which the contracts will be compiled instead of having a floating pragma:
```solidity
pragma solidity >=0.8.0 <0.9.0;
```
### Recommendation
Update the version to the fixed version that... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use of General receive() Functions is Discouraged
### Description
In several locations, general `receive()` functions are used. It is recommended to use more specific receive functions.
For example, instead of:
```solidity
receive() external payable {}
(bool sent,) = payable(withdrawalManager).call{ value: ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: `transferFee()` uses an incorrect transfer method
### Description
The `transferFee` function in the `TheCounter` contract incorrectly uses `safeTransferFrom` instead of `safeTransfer` when transferring collected fees from the contract to the admin. This implementation error will cause the function to revert d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | true | false | ## High: Calls Made to Non-Existent/Removed Routes or Controllers Will Not Result in Failure
### Description
This issue was found in commit hash `a8d0ad1c280a699d88dc280d9648eacaf215fb41`.
In the Ethereum Virtual Machine (EVM), `delegatecall` will succeed for calls to externally owned accounts and more specifically ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect ERC165 identifier for ERC2981
### Description
The SofamonWearable contract implements the ERC165 standard, which is used to detect interface support in smart contracts. However, the contract incorrectly hardcodes the identifier for the ERC-2981 standard as `0x0e89341c`, whereas the correct identifier... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Users can register assets with empty name and ticker symbol fields
### Description
The SORA Network allows any user to register an asset by providing a name and ticker symbol for it. The code validates name and ticker symbol values (Figure 3.1) but permits the use of empty strings.
According to UTF-8 encoding,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: The capping mechanism for Panther token leads to increased fees
### Description
Panther token has a cap in transfer sizes, so any transfer in the contract is limited beforehand:
**wheat-v1-core-audit/contracts/PantherSwapCompoundingStrategyToken.sol:L218-L245**
```
function gulp(uint256 \_minRewardAmoun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: solhint-disable rule no longer needed
### Description
With the removal of the `pack()` function, this solhint rule no longer needs to be disabled.
### Recommendation
Remove this line to re-enable the rule.
```solidity
// SPDX-License-Identifier: GPL-3.0
pragma solidity ^0.8.12;
/* solhint-disable reason-stri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Rename `StrategyPassiveManagerUniswap::price` to `scaledUpPrice` to explicitly indicate returned price is scaled up
### Description
The current implementation of function `price` returns the price scaled up but the function name doesn't indicate this. Other places in the code that use this function do scale th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Using spot price inside `_calculateTWAP()` makes code vulnerable to price manipulations
### Description
Code uses `_calculateTWAP()` to perform slippage checks and prevent malicious users from extracting values by manipulating the liquidity pool and interacting with the ULTI token. The issue is that `_calculat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | false | false | ## Gas: caching variable of struct in one slot
### Description
store more than one variable in one storage slot save gas
### Impact
gas saving
Each slot saved can avoid an extra Gas (20000 gas) for the first setting of the struct
store the variable in one storage slot is more gas efficient . | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Usage of magic constants
### Description
There are several [magic constants](https://en.wikipedia.org/wiki/Magic_number_%28programming%29) in the contract code. Some examples are:
*
*
*
Use of magic constants reduces code readability and makes it harder to understand code intention. We recommend extract... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Cache storage variables in memory when read multiple times without being changed
### Description
**Description:** Cache storage variables in memory when read multiple times without being changed:
File: `SolidlyV3Pool.sol`
File: `SolidlyV3Factory.sol`
**Solidly:**
Acknowledged. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: `VerbsToken.tokenURI()` is vulnerable to JSON injection attacks
### Description
`CultureIndex.createPiece()` function doesn't sanitize malicious charcacters in `metadata.image` and `metadata.animationUrl`, which would cause `VerbsToken.tokenURI()` suffering various JSON injection attack vectors.
1. If the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Reentrancy risk in _cancel() for interacting protocols
### Description
The `_cancel()` function is used to end a stream, sending the total streamed amount to the recipient and the remaining funds back to the sender. It also implements the `onStreamCanceled()` callback function for protocols that interact wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Macro Attributes for Pausable Derivation
### Description
**Description:**
For example, if users want to change the storage key of Pausable in examples/pausable-examples/pausable\_base/src/lib.rs line 7-12, he will add #[pausable(paused\_storage\_key="new\_storage\_key") However, the rust compiler can... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Potential Incompatibility with ERC-4337
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> The plan for achieving ERC-4337 compatibility has been outlined in https://github.com/thesis/orangekit/pull/81.
The plan mentioned above consists of an R... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Corrupted oracle system if more than 2 underlying tokens are used and one of them is WSTETH
### Description
The `priceX96()` function always enforces a cross-oracle price check, even when a direct price feed is provided by Chainlink.
### Impact
There is no possibility to use the current oracle system and i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Usage of `safeApprove` might be incompatible with tokens like `USDT`
### Description
Some tokens implement an approval race protection mechanism (`USDT`, `KNC`) which requires the pre-approval allowance to be either zero or `type(uint256).max`. Currently the code in `initiatePreHoldSwap` uses `safeApprove` for... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: SwapManager assumes Morpho token is token0 of every token pair
### Description
The `consult` function wrongly assumes that the Morpho token is always the first token (`token0`) in the Morpho <> Reward token token pair. This could lead to inverted prices and a denial of service attack when claiming rewards, as... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Avoid duplicated code whenever possible to reduce inconsistencies
### Description
## Code Review Summary
## Context
- **GasZipPeriphery.sol**: Lines 100-103
- **ReceiverAcrossV3.sol**: Lines 78-82
## Description
### ReceiverAcrossV3.pullToken
The `pullToken` function replicates the functionality of `Withdra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Increments/decrements can be unchecked in for-loops
### Description
In Solidity 0.8+, there's a default overflow check on unsigned integers. It's possible to uncheck this in for-loops and save some gas at each iteration, but at the cost of some code readability, as this uncheck cannot be made inline.
[ethereu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: tokenState.setState redundant checks ✓ Addressed
### Description
`tokenState.setState` is used to change the state of the token from:
* PROPOSED to ACCEPTED (in `accept()`)
* DELEGATED to ENDING\_DELEGATED (in `requestUndelegation()`
The if/else statement in `setState` is too complicated and can be simp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Lack of input validation
### Description
While many of the functions in the codebase that take external input do verify those inputs, there are some instances of constructors and functions that lack sufficient input validation. This is especially true of functions that take input from “trusted” parties, such a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Unlimited reward rate enables overflow DoS attack in `DIARewardsDistribution`
### Description
The `updateRewardRatePerDay()` function in `DIARewardsDistribution` lacks upper bounds validation for the `newRewardRate` parameter, allowing the owner to set arbitrarily large values that cause arithmetic overflow in... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: ALCK rewards are lost when merging tokens because the rewards are not claimed before burning the token.
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/VotingEscrow.sol
Impacts:
- Permanent freezing of unclaimed yield
## Description
## ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Optimize names to save gas
### Description
`public`/`external` function names and `public` member variable names can be optimized to save gas. See [this](https://gist.github.com/IllIllI000/a5d8b486a8259f9f77891a919febd1a9) link for an example of how it works. Below are the interfaces/abstract contracts that ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Users can not remove some amount of collateral from contract because of wrong implementation of "canRemoveCollateral()"
### Description
When users want to remove significant amount of collateral (not all) from protocol, they fail to do so because of wrong check in canRemoveCollateral() function.
### Impact... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: No incentive for evaluating proposals with outcome other than Yes
### Description
After a voting period has ended, the [`evaluateProposalOutcome` function of the `Governance` contract](https://github.com/AudiusProject/audius-protocol/blob/6f3b31562b9d4c43cef91af0a011986a2580fba2/eth-contracts/contracts/Govern... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Usage of `uints`/`ints` smaller than 32 bytes (256 bits) incurs overhead
### Description
> When using elements that are smaller than 32 bytes, your contract’s gas usage may be higher. This is because the EVM operates on 32 bytes at a time. Therefore, if the element is smaller than that, the EVM must use more... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Unnecessary initialization
### Description
New `uint256` variables are equal to zero by default:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditFilter.sol#L297
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce05... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Discrepancies Between the ERC-7579 Draft Standard and Delegator’s Implementation ✓ Fixed
### Description
The standard `ERC-7579` outlines the minimal required interfaces and behavior for modular smart accounts to ensure interoperability across implementations.
However, It should be noted that this ERC is curre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Use of tx.origin for access controls
### Description
The wallet factory uses `tx.origin` to authenticate users. This pattern is commonly considered insecure, and it could result in the creation of undesired wallets or wallets in a vulnerable state.
`WalletFactory` allows users to call the `createAndCallTxO... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Trade index has been set twice while registering the trade
### Description
**Severity**: Low
**Status**: Resolved
**Description**
In NarwhatTradingCallbacks contract, registerTrade method called the trading storage contract to find the first empty trade index and sets it as `trade.index`.
In the same method... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: New fee should not be applied to ACTIVE loans Severity: Medium
### Description
**Description:**
The owner can change the fee by using the setFeePercent() function. The problem is that this new fee is also applied to ACTIVE loans, which is not agreed upon by the users at the time of creation. Users only ag... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `CompoundV3InvestStrategy.disconnect()` Ignores Claimable Rewards
### Description
**Update**
Addressed in: `511a9fce43f09c970b4f8f714466eb4eba2a9ba7`. The client provided the following explanation:
> I applied the recommendation, now disconnect fails if there are rewards to be claimed (unless forced).
**File... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Unused or Dead Code
### Description
During the security assessment of the smart contracts, several instances of unused code were identified. These unnecessary components can clutter the codebase, reduce readability, and potentially lead to confusion during development or auditing. Additionally, unused imports ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Missing Docstrings
### Description
Throughout the codebase, multiple instances of missing docstrings were identified:
* In `Arbitrum_CustomGasToken_Adapter.sol`, the [`FunderInterface` interface](https://github.com/across-protocol/contracts/blob/f56146a01ca9c62e6206a2c23c55dbe01a25a912/contracts/chain-adapter... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Missing event for a critical operation
### Description
The system does not emit an event when a protocol fee is levied in the `_transferFeesAndFunds` and `_transferFeesAndFundsWithWETH` functions. Operations that transfer value or perform critical operations should trigger events so that users and off-chain mo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Incorrect loan limit will be shown to user
### Description
The `_getLoanLimit` function will round up a value like 29.495 ether to 29.5 ether and show the same to the user while checking Tick wrapper token details. In reality, however, the user will only be allowed to borrow a maximum of 29.495 ether, which ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | rounding | true | false | ## High: Makers' rebates are not paid in case of swap
### Description
When orders are matched, we choose between AMM and orderbook based on which offers better prices. In case of `swap` when orderbook doesnt exist, we trade with only AMM, when it exists we choose better of both.. we create a temporary client's primary... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: FTokens are burned after `quorumVotes` are recorded making a portion of the shares unclaimable
### Description
`params.quorumVotes` is larger than it should because Locker's collection tokens are [burned](https://github.com/sherlock-audit/2024-08-flayer/blob/main/flayer/src/contracts/utils/CollectionShutdow... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Remove/Resolve TODO comments
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
Across the protocol, in many contracts, there are several TODO comments which show unresolved work and advised to remove or resolve before mainnet deployment.
**Recommendation**:
Resolve or r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Use of `_mint` in `ReraiseETHCrowdfund#_contribute` is incompatible with `PartyGovernanceNFT#mint`
### Description
Misconfigured receiver could accidentally DOS party.
### Proof of Concept
[ReraiseETHCrowdfund.sol#L238](https://github.com/code-423n4/2023-04-party/blob/440aafacb0f15d037594cebc85fd471729bcb... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Changing asset strategy without zero allocation check
### Description
_Resolved_
The `updateAssetStrategy` function allows updating an asset’s strategy without verifying that the current allocation to the existing strategy is zero. This can lead to inconsistencies in asset allocation tracking and potential lo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | true | ## Low: Enforce 18 decimal collateral tokens in `Factory::deployNewInstance`
### Description
The protocol assumes collateral tokens decimals are 18.
### Proof of Concept
While calculating a `TCR` in [BorrowerOperations::_getTCRData](https://github.com/Bima-Labs/bima-v1-core/blob/main/contracts/core/BorrowerOperations... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Restricting zero decimals in `AggregateChainedOracle`
### Description
`AggregateChainedOracle.addCallPath()` does not allow zero decimals:
- https://github.com/defidotmoney/dfm-core/blob/0bde9fb784400d73f434d585aab7d9dd0ad1c679/contracts/cdp/oracles/AggregateChainedOracle.sol#L119
But in fact, zero decimals w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: `MultiInvoker._latest` calculates incorrect closable for the current oracle version causing some liquidations to revert
### Description
`closable` is the value calculated as the maximum possible position size that can be closed even if some pending position updates are invalidated due to invalid oracle vers... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Claiming bribes for epochs you didn't vote for, leading to protocol insolvency.
### Description
> This is a text-dense report we apologize in advance. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `vaultWithdrawalClaimable()` Does Not Check `WithdrawalRequest.claimed` Flag
### Description
This issue has been identified within the `vaultWithdrawalClaimable` function of the `EnjoyoorsWithdrawalApprover` contract.
Currently, the function returns `true` even if the withdrawal request has already been execut... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `CrvDepositor.sol` Wrong implementation of the 2-week buffer for lock
### Description
_Submitted by WatchPug_
[CrvDepositor.sol#L127-L134](https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/convex-platform/contracts/contracts/CrvDepositor.sol#L127-L134)
In `_lockCurv... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Instant Unstake Fee Can Be Bypassed
### Description
## Unstaking stAPT
Users can unstake their stAPT instantly or with a delay. In order to unstake instantly, a fee, defined in the configuration parameter `instant_unstake_fee_bps`, is charged. The fee is computed using the `utils::calculate_fee` function:
T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: stringify() for bytes32 may unexpectedly truncate data
### Description
In [Require.sol](https://github.com/dydxprotocol/solo/blob/17df84db351d5438e1b7437572722b4f52c8b2b4/contracts/protocol/lib/Require.sol#L143-L161), the `stringify()` function for the `bytes32` type may unexpectedly truncate data. The functio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | reentrancy | true | false | ## Gas: Use Constants instead of Enum
### Description
Enum is used in ``Escrow`` contract for managing various states of functions. But Enums are gas expensive and it can be done cheaper by using constants. One of the examples of using constants instead of enums is ``Openzeppelin's ReentrancyGuard.sol`` contract.
http... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Natspec documentation issues: missed parameters, typos or suggested updates
### Description
We have found various NatSpec documentation issues that include missing parameters, typos, or general suggestions for improvement.
- **MathLib.sol**: Some functions are missing the `@notice`, `@param`, and `@return` Na... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Can make the variable outside the loop to save gas
### Description
Consider making the stack variables before the loop which gonna save gas
2 instances here `collection` and `collectionScore`
- [NFTScoreRequirement.sol#L59](https://github.com/prepo-io/prepo-monorepo/blob/feat/2022-12-prepo/packages/prepo-shar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect balance assertion
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
In contract MiltonInternal at line 328, in function _getAccruedBalance the liquidityPool balance is checked before returning the accruedBalance. The statement checks for greater than or equal to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: RewardManager's extra reward token might have excessive slippage
### Description
If the extra reward token is not supported by conic oracles, its slippage is set to zero upon sale:
```
function _minAmountOut
...
if (!oracle_.isTokenSupported(tokenIn_) ||
!oracle_.isTokenSupported(tokenOut_)
) {
retu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: `setPrices()` accesses the settlement history by a wrong value
### Description
Let's take a look at the `setPrices()` function:
```solidity
function setPrices(SettlementNoClientId[] memory settlements) external onlyOwner {
for (uint256 i = 0; i < settlements.length; ++i) {
SettlementState storage settl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing validation allows `bonusEndTime` to be set to past timestamps
### Description
_Resolved_
The `BonusWrapper::setBonusEndTime` lacks validation to ensure the new timestamp is in the future. An administrator could accidentally set `bonusEndTime` to a past timestamp, which would cause all next stake attem... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Lack of High-Level and Inline Documentation
### Description
The codebase currently lacks inline documentation, and the repository is missing high-level documentation explaining the Snap capabilities and features. This absence of documentation poses several concerns for future maintenance and transparency.
W... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | dos | false | false | ## Low: Unbounded weight scale factor causes precision loss in stake conversion, potentially leading to loss of operator funds
### Description
The `AvalancheL1Middleware` uses a `WEIGHT_SCALE_FACTOR` to convert between 256-bit stake amounts and 64-bit validator weights for the P-Chain. However, there are no bounds on ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: Consider modifying the build() function which allows anyone to create an ODProxy for any user
### Description
There is 1 instance of this issue:
The build() function on Line 90 below allows anyone to create an ODProxy for any user. Although this is a convenient method, it should still implement some sort of a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing transaction deadline validation
### Description
The vault's liquidity management functions (`_increaseLiquidity` and `_decreaseLiquidity`) set transaction `deadlines` to `type(uint256).max`, effectively removing any timeout protection for liquidity operations. This creates several risks when during per... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: Functions in the `VotiumStrategy` contract are susceptible to sandwich attacks
### Description
In `VotiumStrategyCore.sol`, the `buyCvx()` and `sellCvx()` functions call `exchange_underlying()` of Curve's ETH / CVX pool to buy and sell CVX respectively:
[VotiumStrategyCore.sol#L233-L240](https://github.com/c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Risks and safeguards for wrappedM integration
### Description
One of the requests of the security review was to document and analyze how WrappedM could be used to attack UsualM and what safeguards UsualM can consider/has implemented against it. Our findings of the non-exhaustive risks and safeguards in place a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: D3Oracle.getPrice() and D3Oracle.getOriginalPrice() doesn't check If Arbitrum sequencer is down for Chainlink feeds
### Description
When utilizing Chainlink in L2 chains like Arbitrum, it's important to ensure that the prices provided are not falsely perceived as fresh, even when the sequencer is down. This... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Potential Data Corruption in Trie Structure
### Description
The issue is identified within the[`removeOrderFromNonRightmostNodeDescendants`](https://github.com/longgammalabs/hanji-contracts/blob/09b6188e028650b9c1758010846080c5f8c80f8e/src/TrieLib.sol#L780-L795) function of the `Trie` contract.
There is a cr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: `getCollaterals()` does not return the last collateral
### Description
The `getCollaterals()` function is used to retrieve all the existing collaterals in the protocol. And as evident in `addCollateral()`, the `collateralIndex` for existing collateral starts from 1, while 0 is not used for any collateral.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Gas optimization for `getVaults` function
### Description
The `MiddlewareVaultManager::getVaults` uses an inefficient pattern that iterates through the entire list of vaults twice. The first iteration counts the number of active vaults, while the second iteration builds the array of active vaults.
This implem... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Consider enforcing a minimum deposit amount
### Description
The vault/strategy accepts arbitrarily small deposits (down to 1 wei). While functionally correct, dust deposits are effectively useless for legitimate users (since the gas to call `deposit` often exceeds the value deposited) and can be abused by adve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Mixing testing and production code
### Description
The codebase contains a few duplicated contracts with slightly different, security-relevant behaviors. Specifically:
* The [`BuybackConstructor` contract](https://github.com/OriginProtocol/origin-dollar/blob/bf4ff28d5944ecc277e66294fd2c702fee5cd58b/contracts... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | access-control | true | false | ## High: Missing access control in `CollateralLiquidityProvider::setExternalCollateralRedemption`
### Description
The contract `CollateralLiquidityProvider` relies on `externalCollateralRedemption` to provide liquidity and this state variable can be changed via the function `setExternalCollateralRedemption()` as below... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Rejected auction is always in default state
### Description
After the auction has been rejected, there is no way for the owner or user to close the pool. So, in `PoolFactory.marketPools`, `PoolFactory.pools` this pool (with default status and rejected auction) will be there for infinity.
```
// start some au... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Race condition may result in users earning less interest than expected
### Description
The absence of a minimal interest rate might return a lower bonus for users than expected. LiquidityGauge computes the interest earned by users. A bonus is applied to VotingEscrow token’s holder:
```python
def _update_liqui... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | initialization | true | false | ## Gas: Avoid unnecessary initialization to zero in `BeefyVaultConcLiq::deposit`
### Description
**Description:** `BeefyVaultConcLiq::deposit` declares the `shares` variable on [L127](https://github.com/beefyfinance/experiments/blob/14a313b76888581b05d42b6f7b6097c79f3e65c6/contracts/protocol/concliq/vault/BeefyVaultCo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Incorrect number of shares minted as fee
### Description
Source: https://github.com/sherlock-audit/2023-06-tokemak-judging/issues/624
## Found by
0x007, xiaoming90
An incorrect number of shares was minted as fees during fee collection, resulting in a loss of fee.
## Vulnerability Detail
https://github.c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Restrict Endpoint Access
### Description
If both engines are not initialized via `Clearinghouse.sol`, the transactions to `Endpoint.sol` are likely to fail. Therefore, it is preferred to freeze the contract until both engines are properly initialized.
## Remediation
1. Add a function in `Clearinghouse.sol` w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: OpenZeppelin library leaves sorting differs from 9th merkle tree invariant
### Description
`@openzeppelin/merkle-tree` is used to assemble the Merkle tree. Its implementation sorts the leaves according to their hashes, then stores them starting from the last slot in the tree array.
```typescript
export functi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Anyone can always transfer 1 wei stETH
### Description
**Severity:** Low
**Path:** StETH.sol:getSharesByPooledEth#L311-L315
**Description:**
The functions getSharesByPooledEth and getPooledEthByShares are used to convert from stETH to shares and vice versa. Normally, the pooled ETH amount is greater than th... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.