prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: Admin can rug L2 Escrow tokens leading to reputation risk
### Description
_Submitted by harleythedog_.
The `L1Escrow` contract has the function `approve` that is callable by the admin to approve an arbitrary spender with an arbitrary amount (so they can steal all of the escrow's holdings if they want). Eve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: `MODULE_ENABLE_MODE_TYPE_HASH` is incompatible with eip-712
### Description
As of this moment the `MODULE_ENABLE_MODE_TYPE_HASH` looks like this:
However, this could lead to reverts in the `ModuleManager::_enableMode` function because of the way `structHash` is computed:
As per eip712:
>Definition: The dynam... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Can fake market order in TakeOrder event
### Description
Market orders in `Orderbook.marketOrder` set the 8th bit of options. This options value is later used in `_take`'s `TakeOrder` event. However, one can call `Orderbook.limitOrder` with this 8th bit set and spoof a market order event.
### Recommendation
C... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Use of revert strings over custom errors increases gas costs
### Description
In Solidity development, replacing hard-coded revert message strings with the `Error()` syntax is an optimization strategy that can significantly reduce gas costs. Hard-coded strings, stored on the blockchain, increase the size and co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Update the error message typo and check
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In contract cloudX_staker.sol and contract cloudX_rewardLocker.sol, the following require statement error message through out both contracts needs to be updated. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | token | false | false | Source: https://github.com/sherlock-audit/2024-06-leveraged-vaults-judging/issues/14
## Found by
novaman33
## Summary
Lido protocol has limitation regarding the requestWithdraw function. However some of these limitation have not been considered in the `_initiateWithdrawImpl` leading to users being unable to claim th... | Sherlock | 4 | Notional Leveraged Vaults: Pendle PT and Vault Incentives |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The `redeemObligation` will always be reverted
### Description
`redeemObligation` is designed to be called when the state is `Outcome.ONGOING`. However, it utilizes [`Battle.withdrawObligation`](https://github.com/DivergenceProtocol/diver-contracts/blob/b094ef8a453f4e0c688f36f8ef7743e7f40a36cb/src/periphery... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Assumption of Constant Token Decimal Places Can Lead to Incorrect Value Calculation
### Description
**Description:**
The getLatestPrice function in the provided code snippet assumes that all tokens have 18 decimal places. It multiplies the received price value, which comes with 8 decimal places, by 1e10 to ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Import `MILLAGE_DENOMINATOR`
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In Contract FeeHelper, variable `MILLAGE_DENOMINATOR` can be imported from ./libs/VarCanstant.sol file like in other contracts to maintain uniformity.
**Recommendation**:
Import the variable as ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Potential DoS of messages in the `postDispatch` function
### Description
The `postDispatch()` function of the `ProtocolFeeHook` contract lacks access control check.
The function updates the `messageValidated` mapping and marks `messageId` as validated to prevent double-processing. But that function is define... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Inheritance is possibly not needed in the protocol
### Description
The inheritance tree of the protocol is a strange one - both `ApproverManager` and `PayrollManager` inherit from `Storage` and `Pausable`, while `Organizer` inherits from both `ApproverManager` and `PayrollManager`.
Also, some contracts are de... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | false | false | ## High: Introduction of additional BondingCurves creates period of volatility
### Description
The [`BondingCurve` contract](https://github.com/fei-protocol/fei-protocol-core-internal/blob/f54d7bb07c55adb78e2e142e7044f60090bb7602/contracts/bondingcurve/BondingCurve.sol) enables use of generic bonding curves for any ER... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Missing NatSpec `@author` from contract declaration
### Description
Some contract definitions have an incomplete NatSpec: add a `@author` notation to improve the code documentation.
*There is 1 instance of this issue.*
[[6](https://github.com/code-423n4/2024-04-panoptic/blob/6908144756ef0cce2ede6d3b2013291f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Protocol Modifications
### Description
## Current Setup Issues
1. In the current setup, all custody vaults share the same authority, implying that a single authority manages operations across different custody vaults. This may result in account validation issues if there are conflicts or unexpected interactio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: With most functions in VaultTracker.sol, users can call them only once after maturity has been reached.
### Description
_Submitted by hansfriese, also found by panprog_
### Impact
With most functions in VaultTracker.sol, users can call them only once after maturity has been reached.
So from the second c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Ownable and AccessControl mixed
### Description
**Description**
LYO.sol utilizes both ownership and access control with roles, which is over-complification of
the contract, as owner can be set up as a separate role or the admin itself.
**Recommendation**:
Omit Ownable functionality and use AccessControl onl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: Updating a pool's total points doesn't affect existing stake positions for rewards calculation
### Description
Staking rewards are calculated based on the user's share of total points in the corresponding asset pool, this is the sum of the points associated to the staker's positions divided by the total point... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Unnecessary setting on each mint
### Description
Setting base URI on each mint is unnecessary:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/tokens/GearNFT.sol#L14
### Recommendation
We recommend moving setting of base URI to constructor. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: [04] Protocol might overvalue the asset transferred in by a user and unintentionally flaw their accounting logic
### Description
First would be key to note that protocol is to support different types of ERC20, which include tokens that apply fee whenever being transferred, this can be seen from the _### ERC20 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Project Team Unable to Retrieve Remaining Giveaway Tokens
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `1807575c79b6998014fdd7b82e12986fd3bfea0a`.
**File(s) affected:**`IFFundable.sol`, `IFSale.sol`
**Description:** The `IFundable.cash()` function is designed to enable the projec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Incompatibility with Fee-On-Transfer & Rebase Tokens
### Description
Some ERC20 token implementations have a fee that is charged on each token transfer. This means that the transferred amount isn't exactly what the receiver will get. The main issue then lies in that the protocol will pull funds from arbitrary ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: [12] Mistake in inline comment - minimum vs. maximum
### Description
The following [inline comment](https://github.com/code-423n4/2024-01-opus/blob/4720e9481a4fb20f4ab4140f9cc391a23ede3817/src/core/purger.cairo#L559-L561) is wrong because it contradicts the context:
> // If the threshold is below the given mi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `type(uint<n>).max` should be used instead of `uint<n>(-1)`
### Description
*There are 8 instances of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of event emission after sensitive actions
### Description
The [`__acceptAdmin`](https://github.com/emptysetsquad/emptyset/blob/bf9753ef9cd5b17236036257f290e0d0b850a029/protocol/contracts/src/governance/GovernerAlpha.sol#L313) and the [`__abdicate`](https://github.com/emptysetsquad/emptyset/blob/bf9753ef9c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Incorrect Transfer Types Check
### Description
## Error in Assertion within `transfer::its_transfer`
There is an error in the assertion within `transfer::its_transfer`. `its_transfer` is specifically designed to handle transfers of ITS tokens. Since it deals with ITS tokens, the expected swap type in the data... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Zero Address Management Inconsistencies
### Description
In the Substrate ecosystem, public addresses adopt the SS58 encoding. The Base-58 alphabet omits characters prone to confusion when printed, such as the number 0.
Given this, referring to the "zero address" from EVM blockchains can be confusing. In thi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Function reverts if called a second time
### Description
`safeApprove()` reverts if called a second time without fist calling `safeApprove(0)`
*There is 1 instance of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: DoS on deposits during the early bird period
### Description
On deposits, the deposit price is calculated using the TWAP, but in the first 24 hours after the launch, a fixed price is used instead. This fixed price is the initial price in the pool.
```solidity
981: if (block.timestamp < launchTimestamp + EAR... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [05] Method call syntax in `native_test_only_set_block_info` is not correct
### Description
`set_block_info` in `native_test_only_set_block_info` function is incorrectly called as a static method using `NativeBlockContext::set_block_info()` syntax when it’s defined as an instance method. This causes a compilat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: User's voting power never decays over time.
### Description
When a user locks tokens, the contract computes a “point” consisting of a bias (initial voting power) and a slope (the rate at which that power decays). In a correct implementation (like Curve’s veCRV), the voting power at any later time is given b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inconsistent version of English being used
### Description
Some functions use American English, whereas others use British English. A single project should use only one of the two
*There are 2 instances of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Incorrect implementation of `ERC4626ViewAdjustor`
### Description
Adjustor contracts have 2 main functions which are `toNominal` and `toReal`, which convert between real and nominal values of a token.
`ERC4626ViewAdjustor` is an implementation for LSTs such as `stETH`.
However, the implementation of `toNomin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: [13] Variable names that consist of all capital letters should be reserved for `constant`/`immutable` variables
### Description
If the variable needs to be different based on which class it comes from, a `view`/`pure` _function_ should be used instead (e.g. like [this](https://github.com/OpenZeppelin/openzepp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Increase test coverage
### Description
The test coverage of key contracts under review, including `OmniXMultisender.sol` and `OmniXMultisenderFactory.sol`, is less than complete. Adequate test coverage (both line and branch) ensures the codebase works as expected. Insufficient code coverage can lead to unexpec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Invalid emissionSchedule length check
### Description
The `AaveDistributionManager` contract allows the direct call to the `configureAssets` function without validating the length of the `emissionSchedule`. This can lead to an out-of-bounds error when fetching the asset index if an invalid `emissionSchedule... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Test suite inconsistencies / failures
### Description
The Balancer protocol tests experience inconsistent behavior when they are built and run. The Balancer tests fail to run on certain machines with a fresh clone of the repository because they are unable to find certain artifacts (figure 2.1). An inability to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: Ignored Return Values
### Description
In Solidity, return values often provide critical information about the success or failure of an operation. Disregarding these values can result in missed error handling.
The following instances were identified:
* In `CoreVault.sol`:
```
function stake() external pa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Remove redundant `uint256` cast in `PerpMarket::getMarkPrice`
### Description
**Description:** Remove redundant `uint256` cast in `PerpMarket::getMarkPrice` since `self.configuration.skewScale` is [already](https://github.com/zaros-labs/zaros-core-audit/blob/de09d030c780942b70f1bebcb2d245214144acd2/src/perpetu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: `CNft.sol` - revert inside `safeTransferFrom` will break composability & standard behaviour
### Description
_Submitted by hubble_
[CNft.sol#L204](https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/CNft.sol#L204)
The function safeTransferFrom is a stand... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | signature | false | false | ## Gas: verifyNonce Always Returns true
### Description
The `verifyNonce` function returns a boolean value, but this value is always true (the function reverts in any case that returning false would be appropriate). Since this function is called on-chain, having this unneeded return value uses unnecessary gas.
### Re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: [01] Incorrect intermediate validation of cumulative parameter rules
### Description
The `PermissionValidator` incorrectly validates cumulative parameter rules against intermediate values rather than final accumulated totals. This prevents legitimate multi-transaction operations where individual steps don’t sa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: Users can vote multiple times in one epoch
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/Voter.sol
Impacts:
- Direct theft of any user funds, whether at-rest or in-motion, other than unclaimed yield
- Theft of unclaimed yield
## Descr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: `Goldilend.lock()` will always revert
### Description
**Severity:** High
**Description:** In `lock()`, it calls `_refreshiBGT()` before pulling `iBGT` from the user and will revert while calling `iBGTVault(ibgtVault).stake()`.
**Impact:** Users can't lock `iBGT` as `lock()` always reverts.
**Recommended M... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use assembly to check for address(0)
### Description
**Description:**
Use assembly to check for address(0).
**Recommendations:**
Change the check for assembly check. Status: Resolved. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Wrong value of precision
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
Vester.sol - precision value is set to
uint256 public precision = 10e9
But according to function vest(), the error message in the first line states that precision should be 1e9.
**Recommendation**
C... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Zero Value Checks in `enableSessionKey()`
### Description
In the `enableSessionKey()` function, the `sessionKey`, `token`, `interfaceId`, `funcSelector` and `spendingLimit` parameters lack checks for zero values / addresses. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Use of non-checked SPL Token instructions
### Description
During the review of the proposed Solana programs, it was identified that the standard, unchecked SPL token instructions are used, rather than their `checked` variation, specifically:
* `token::transfer(...)`
* `token::mint_to(...)`
* `token::burn(...)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: DoS of full liquidations are possible by frontrunning the liquidators
### Description
Liquidators must specify precise amounts of DSC tokens to be burned during the liquidation process. Unfortunately, this opens up the possibility for malicious actors to prevent the full liquidation by frontrunning the liqu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | false | false | ## High: Delegators can immediately undelegate before their delegatee is jailed
### Description
There is no penalty for preemptively signaling redelegation immediately after initial delegation. Doing so (and waiting through the cooldown) would give delegates the ability to front-run future jail transactions and avoid ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Selfdestruct | true | false | _Submitted by horsefacts_
When deploying a new `MIMOProxy`, the `MIMOProxyRegistry` first checks whether a proxy exists with the same owner for the given address. If an existing proxy is found, the deployment reverts:
[`MIMOProxyRegistry#deployFor`](https://github.com/code-423n4/2022-08-mimo/blob/eb1a5016b69f72bc1e4f... | Code4rena | 4 | Mimo DeFi |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Potential optimization for IStWSX.
### Description
**Description**
IStWSX.sol,_emitTransferAfterMinting Shares()
Function_emitTransferAfter Minting Shares() seems over-engineered, as it is a particular case of the_emitTransferEvents() function, and can be eliminated, thus simplifying the code.
**Recommendati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: Saving large JSON integers could result in interoperability issues
### Description
The DeGate protocol’s method of parsing user- and operator-generated JSON integers differs from that of mainstream implementations such as NodeJS and jq. The JSON standard warns about certain "interoperability problems" in nu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Lack of Minimum feeRate check may allow orders to be fullfilled without paying any fees
### Description
The settleMatchedOrders function allows the backend to settle matched orders that
were created and matched off-chain. While the contract enforces an upper bound for feeRate, it does
not enforce a minimum ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: A Dark Age Can End Prematurely
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `7736eb06074e1de55cccebfc2cbf572e892c08bc`. The client provided the following explanation: Uses supply at mint of the last minted token rather than current supply to calculate isDarkAge.
**File(s) affecte... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Inaccurate comment in `LibTokenSilo::removeDepositFromAccount` NatSpec should be updated
### Description
Legacy Silo v2 Deposits are stored in a [legacy mapping](https://github.com/BeanstalkFarms/Beanstalk/blob/c7a20e56a0a6659c09314a877b440198eff0cd81/protocol/contracts/beanstalk/AppStorage.sol#L149), now depr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Precision Loss In Reward Calculation
### Description
In `SDIncentiveController`, there is a potential, albeit unlikely, risk of precision loss in reward calculations. This scenario may occur when the `totalSupply` of cTokens significantly outweighs the `emissionPerBlock`. Precision loss in reward distribution ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Inconsistent spacing in comments
### Description
Some lines use `// x` and some use `//x`. The instances below point out the usages that don't follow the majority, within each file
*There are 2 instances of this issue:*
https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: Incorrect initialization gives IL protection of only 1 second instead of 100 days in Router.sol
### Description
Incorrect initialization of `timeForFullProtection` to 1 sec instead of 8640000 secs (100 days) as indicated in code comments, appears to be a test setting mistakenly carried over for deployment. Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Settlement Will Not Be Finalised Unless Purchase Tokens Are Transferred to the Contract Before Finalisation of the Settlement
### Description
In the fix from the previous code, the protocol added a treasury address:
```solidity
address public treasury;
```
During purchase, they are transferring the whole `pu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Remove obsolete check in `updateFee`
### Description
Remove obsolete check in `updateFee`:
```diff
- require(newFee >= 0, "Fee must not be negative");
```
This check is obsolete since `newFee` is declared as `uint256` therefore cannot be negative. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | flash-loan | true | false | ## Medium: Zappers and swaps can leave dust
### Description
**Executive Summary**
Zapper can leave dust amounts under two conditions:
- Debt to repay is less than the amount -> Dust amount, QA in most cases
- Borrowed amount is more than enough to repay the flashloan -> Will result in a significant amount of WETH bei... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Missing or Misleading Documentation
### Description
Throughout the codebase, there are multiple sections which are difficult to understand, and would benefit from additional or clearer documentation:
* It was difficult to assert that reward tokens are [actually rewarded to the strategy.](https://github.co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unexpectedly High Tax for Borrower
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `abd99ad352b9f397f003eea31693daf024fccf79`.
**File(s) affected:**`MultiSourceLoan.sol`
**Description:** In case borrowers draw from a line of credit with some maximum capacity, the possible `taxCost` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Violations of Solidity Style Guide Conventions - magic numbers.
### Description
**Description**
2. Magic numbers usage. Hard-coded constants like:
a) ChainportSideBridge: setArbitrage ManagerAndLimit $()\rightarrow10000$ preMint Threshold() → 10000;
b) ChainportMainBridge: setArbitrage ManagerAndLimit() → 100... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Missing Implementation of EIPs May Lead to Denial of Service
### Description
The Spurious Dragon hardfork led to the implementation of four new Ethereum improvements (EIP 155, 160, 161, 170). These improvements make denial of service attacks more difficult. RSK implements only EIP 155. As a result, RSK may ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Possible reentrancy
### Description
In the following function reentrancy can occur:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/adapters/CurveV1.sol#L56
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad741... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Stale or incorrect data may be returned by getAttestation functions during paused state
### Description
The `AttestationIndexer` contract includes a `pause()` function that, when invoked, pauses the contract. This halts the indexing process, preventing the `index` function from further indexing operations. How... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: No way to retrieve ETH sent with call to `SecuritizeBridge::receiveWormholeMessages`
### Description
**Description:** `SecuritizeBridge::receiveWormholeMessages` is marked as `payable` however:
* it does nothing with `msg.value`
* there is no function in `SecuritizeBridge` to withdraw ETH
**Impact:** If ETH s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Possible incorrect setting value for `maxLeverageFactor`
### Description
`maxLeverageFactor` can be set to 0:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditManager.sol#L722
### Recommendation
We recommend adding a check that `_max... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Reassigning Token Indices May Allow Unused Old Signatures to Claim New Tokens
### Description
**Update**
Addressed in: `b1e316d50708eb3273e37b489df5e73626c987e6` and `62ec38c40a6764f63ca620cb41fa6815783e0236`. The client provided the following explanation:
> We accept an address directly instead of giving tin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: cvgControlTower and veCVG lock timing will be different and lead to yield loss scenarios
### Description
When creating a locked CVG position, there are two more or less independent locks that are created. The first is in lockingPositionService and the other is in veCVG. LockingPositionService operates on cy... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: The result of a function call should be cached rather than re-calling the function
### Description
External calls are expensive. Consider caching the following:
https://github.com/code-423n4/2023-04-frankencoin/blob/1022cb106919fba963a89205d3b90bf62543f68f/contracts/Equity.sol#L144-L148
### Equity.sol.adjustT... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | initialization | true | false | ## Medium: Incorrect `chainid` prevents correct Strategy deployment on Berachain
### Description
The Strategy contract includes a special configuration specifying which facets should be used for different chains. However, the `chainid` assigned to Berachain is incorrect, as seen in [`Strategy::constructor`](https://g... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: Check effects Interactions Pattern not being followed
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
Checks effects interactions(CEI) is not being followed in the transfer function of CEToken.sol. There is external call being made on line: 165. Not following CEI can result in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | reentrancy | true | false | ## Medium: `TokenBank::withdrawFunds` resets `memory` not `storage` fee and sale amounts allowing multiple withdraws for the same token
### Description
`TokenBank::withdrawFunds` resets `memory` not `storage` fee and sale amounts allowing multiple withdraws for the same token:
```solidity
function withdrawFunds(
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `require()`/`revert()` strings longer than 32 bytes cost extra gas
### Description
Each extra memory word of bytes past the original 32 [incurs an MSTORE](https://gist.github.com/hrkrshnn/ee8fabd532058307229d65dcd5836ddc#consider-having-short-revert-strings) which costs **3 gas**
*There are 8 instances of thi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: COLLATERAL CAN BE UPDATED IN SETTLED BOARDS
### Description
The `_doTrade` and `addCollateral` functions from **OptionMarket** contract allow updating collateral on positions, even if the board is **settled**. As a consequence, unexpected situations may happen:
* The added collateral could be forever stuck i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: UX on stream cancel might hinder or deter sender from canceling or recipient from with- drawing
### Description
When the sender cancels a stream, the `SablierV2Lockup` issues a callback to the sender's `onLockupStreamCanceled()` if it is a contract. A `try/catch` ensures that any revert will not block the c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Users May Force One Another Out of Tiers
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `cb5470d2ca3af7de27a2beea2d6a0978740f386b`.
If a subscription is being purchased for an account other than the calling address, the subscription tier can no longer be changed.
**File(s) affec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Storage Collision | true | true | ## Severity: Critical Risk
**Context:**
ManagedPool.sol#L75-L77, ManagedPool.sol#L84-L86, LegacyBasePool.sol, WordCodec.sol
**Description:**
Balancer’s ManagedPool uses 32-bit values for `startTime` and `endTime`, but it does not verify if those values exist within that range. Values are stored in a 32-byte `_mis... | Spearbit | 5 | Gauntlet |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: Unoptimized loops
### Description
If a loop is iterated many times, the amount of gas required to execute the function increases significantly. In Solidity, excessive looping can cause a function to use more than the maximum allowed gas, which causes the function to fail.
`RandomNumber.sol`
* Line 32: `for (... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Blacklisting a protocol leads to lower allocations
### Description
Blacklisting a protocol does not update (decrease) the totalAllocatedTokens. It is used to calculate the new allocations and if it is larger than it should be it will lead to lower token allocations to protocols and lower yield.
### Impact
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Removal of Hardhat Console Log Import in Mainnet Contracts
### Description
The import statement for `hardhat/console.sol` found in the Solidity contract is intended for development purposes, facilitating debugging during the development and testing phases by allowing developers to print variable values and con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Unnecessary payable modificator
### Description
In the current version proxy constructor can receive assets, but does not use it anywhere:
https://github.com/lidofinance/steth-price-feed/blob/459495f07c97d04f6e3839e7a3b32acfcade22ad/contracts/PriceFeedProxy.sol#L57
### Recommendation
We recommend to remove `p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Implementation Contracts Can Be Initialized
### Description
According to the documentation, `CoreVault`, `MergeMarketplaceStrategy` and `Marketplace` contracts are upgradeable contracts. In order to prevent leaving the contracts uninitialized, OpenZeppelin's documentation recommends adding the `_disableInitial... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Lack of pool existence check in `setAmAmmEnabledOverride()`
### Description
The `BunniHook::setAmAmmEnabledOverride` function allows an override to be set for the amAmm availability of a pool without verifying if the pool actually exists. This can lead to situations where overrides are set for non-existent poo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: openPosition exposed to cross-function reentrance
### Description
**Severity**: Low
**Status**: Resolved
**Description**
SakeVaultV2.sol - Function openPosition() is not guarded by nonReentrant modifier which makes it susceptible to be reentered from other related functions like closePosition(). Functions l... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Receiver closes channel, contradicting Golang guidance
### Description
According to Golang’s official guidance, **“Only the sender should close a channel, never the receiver. Sending on a closed channel will cause a panic.”** However, along some code paths within the watcher code, the receiver of a channel clo... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Initializer reentrancy may lead to double initialization
### Description
Initializer functions that are invoked separate from contract creation (the most prominent example being minimal proxies) may be reentered if they make an untrusted non-view external call.
Once an initializer has finished running it can ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Anybody can deposit and withdraw on behalf of users
### Description
**Description:** Issuer contracts allow anybody to call deposits and withdrawals on behalf of any account, without restrictions.
While no way was found to leverage this to perform a more harmful attack, it is still not ideal that anybody can ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Potential Double Counting in `totalAssets()` if Multiple Strategies Share the Same Underlying Asset
### Description
**Update**
Addressed in: `c1bedbade0383966cfa944e40d155e6c382e7972`. The client acknowledged the issue and provided the following explanation:
> We were aware of this, we added a warning comment... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Contract files should define a locked compiler version
### Description
Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler ve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `settleRewards()` can be called even when the token has not graduated
### Description
In the `settleReward()` function, the idea is to swap part of the `settleAmount` (in ETH) to stardust tokens and distribute the rest to users.
Even if the token has not graduated, the function still can be called, skipping th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | true | false | ## Low: FERTILIZERPREMINT.BUYANDMINT FUNCTION COULD BE SANDWICHED
### Description
In the `FertilizerPreMint`, the function `buy()` is used to swap Ether into USDC through the UniswapV3 router:
### Recommendation
**SOLVED**: The `Beanstalk team` documented their code mentioning that any slippage should be properly acc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Improper Initialization of `LaunchToken` Can Cause Campaign Finalization Failure
### Description
The vulnerability lies in the `initialize()` function, where there is no validation of the `tokenAddress` inside the `LaunchToken` struct. During the initialization, the contract does not ensure that the `tokenA... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Broken account must be deleted
### Description
In case if some tokens cannot be transferred from the account, then this account must be deleted:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/CreditManager.sol#L451
### Recommendation
We re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unpinned Compiler Version
### Description
Valid compiler versions are set via the `pragma solidity` tag at the top of Solidity files. Most of the codebase provides [`pragma solidity ^0.8.0`](https://github.com/scroll-tech/scroll/blob/3bc8a3f5c6ac816ddffadca41024331dcf4d3064/contracts/src/L1/rollup/ScrollChain.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | false | false | ## Medium: `_handleDeposit` and `_handleWithdraw` do not account for tokens with decimals higher than 18
### Description
### Impact
In `Trading.sol` a [deposit](https://github.com/code-423n4/2022-12-tigris/blob/main/contracts/Trading.sol#L675) or [withdrawal](https://github.com/code-423n4/2022-12-tigris/blob/main/con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: STORING VARIABLE CAN SAVE GAS
### Description
Calling a contract, although a view function, still requires some gas from the contract. The **UndelegationHolder** contract performs the call to the **StakePool** contract twice instead of storing the result on a variable.
Code Location
-------------
[Undelegati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Transfers of 0 Amount Not Possible
### Description
The [`update` helper function](https://github.com/OpenZeppelin/stellar-contracts/blob/01dbcb53d3992570dba5faf517a3d0502ebf1254/contracts/token/fungible/src/storage.rs#L356) defined in the `openzeppelin_fungible_token` crate is responsible for updating token ba... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.