prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Refunds will be over-credited in a negative yield event
### Description
Deposits added to the queue are [point-in-time](https://github.com/pods-finance/yield-contracts/blob/c4b401ce674c24798de5f9d02c82e466ee0a2600/contracts/vaults/BaseVault.sol#L413) stETH balance amounts. The stETH token rebases to account... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | other | true | false | Source: https://github.com/sherlock-audit/2023-03-taurus-judging/issues/160
## Found by
GimelSec, shaka
## Summary
`swap()` will be reverted if `path` has more tokens, the keepers will not be able to successfully call `swapForTau()`.
## Vulnerability Detail
In `test/SwapAdapters/00_UniswapSwapAdapter.ts`:
```ja... | Sherlock | 5 | Taurus |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Risk of unaccounted asset removal
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
The `MarginAccount.availableErc20` list is crucial for functions like `MarginAccount::preparationTokensParams`, which helps in valuing the account, and `MarginAccount::liquidate`. Removing... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: There is no recovery for excess `stETH`
### Description
It is possible to transfer `stETH` to `wstETH` so it will be frozen in the contract.
https://github.com/lidofinance/lido-dao/blob/801d3e854efb33ff33a59fe51187e187047a6be2/contracts/0.6.12/WstETH.sol#L28-L118
### Recommendation
It is necessary to add ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Wrong comment in `getFee`
### Description
_Submitted by cmichel_
The `ThreePieceWiseLinearPriceCurve.getFee` comment states that the total + the input must be less than the cap:
> If dollarCap == 0, then it is not capped. Otherwise, **then the total + the total input** must be less than the cap.
The code... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: sendtochannel RPC call does not validate erc20 address
### Description
The `sendtochannel` RPC call is handled by `rpc::set_evm_forwarding()`. This function issues a `TokenForwardHTLC` message, which is then processed in `channel_manager::evm_channel()`.
The `TokenForwardHTLC` handler in `channel_manager::ev... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Malicious owner could arbitrage sales
### Description
**Impact:**
High, as it will charge users more than the should be charged
**Likelihood:**
Low, as it requires a malicious/compromised owner
**Description**
Currently, the `setFeeRate` and `setLocalFeeRate` methods do not have an upper bound on the fee... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: BE - MNEMONIC PHRASE EXPOSURE IN MEMORY
### Description
The Mnemonic Phrase of the wallet kept unencrypted in memory, even the wallet was locked. As a result, an attacker with access to the user’s machine could exfiltrate the Mnemonic Phrase. It was possible to retrieve the Mnemonic Phrase from memory in thes... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: | Boolean Redundancy
### Description
**Description**
Modifiers `hasWhitelistGold` and `hasWhitelistSilver` use `whitelistedGold[msg.sender] == true` and `whitelistedSilver[msg.sender] == true` respectively. This is redundant since the mapping values are booleans themselves.
**Recommendation**
Remove the unn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: More efficient way of checking for empty string in `CommonUtils::isEmptyString`
### Description
**Description:** More efficient way of checking for empty string in `CommonUtils::isEmptyString`:
**Securitize:** Fixed in commit [22b117a](https://github.com/securitize-io/dstoken/commit/22b117a3514c04b766aa7be6c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: optimizations - storage over memory
### Description
Some functions are using memory to read state variables when using storage is more gas efficient.
[Solidity doc reference](https://docs.soliditylang.org/en/v0.4.21/types.html#reference-types)
**[ZeframLou (88mph) disputed](https://github.com/code-423n4/2021... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Withdrawals can fail due to deposits reverting in `completeQueuedWithdrawal()`
### Description
The [`OperatorDelegator.completeQueuedWithdrawal()`](https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Delegation/OperatorDelegator.sol#L265) function serves to finalize a queued withdrawal consistin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Incorrect BTC Delegation Reward Calculation Due to Using Current Stake Amount Instead of Historical Stake
### Description
Missing historical stake tracking in the incentive reward system will cause incorrect reward distribution for BTC delegators as changing delegation amounts after a period but before rewa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | true | ## High: Any token with large volume flash minting capability can be stolen
### Description
In `SablierV2LockupDynamic.sol`, the amount of a token that is available to be withdrawn is calculated in the following function:
```solidity
function withdrawableAmountOf(uint256 streamId)
public
view
override(ISablierV2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [4] State variables should be cached in stack variables rather than re-reading them from storage
### Description
The instances below point to the second+ access of a state variable within a function. Caching of a state variable replace each Gwarmaccess (**100 gas**) with a much cheaper stack read. Other less o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Check Against Non Existing Nonce
### Description
## BlobstreamX Security Analysis
In `BlobstreamX`, `state_proofNonce` is initialized to one within `initialize`. However, since the `_proofNonce` indexes `state_dataCommitments` in `verifyAttestation`, having `_proofNonce` as zero may result in using the uninit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: A sanity check of the time interval
### Description
The [`governanceTimeDelay`](https://github.com/Threshold-USD/dev/blob/800c6c19e44628dfda3cecaea6eedcb498bf0bf3/packages/contracts/contracts/THUSDToken.sol#L79) parameter value has no sanity check. The deployer can unintentionally use a milliseconds value inst... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Loan creation can be frontrun, preventing the users from creating loans
### Description
Report type: Smart Contract
Target: https://testnet.snowtrace.io/address/0x2cAa1315bd676FbecABFC3195000c642f503f1C9
Impacts:
- Griefing (e.g. no profit motive for an attacker, but damage to the users or the protocol)
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: money-market-contracts: Market max\_borrow\_factor is not capped
### Description
There is no check to ensure that `max_borrow_factor` is less than 100% (`Decimal::One()`). It is therefore possible to set a borrow factor of > 1. However, the consequence of it is negligible because it would be the same as settin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Decrease In Efficiency Due To Sequential Validation
### Description
## Sequential Validation in Scheduler
In the current implementation of sequential validation within the scheduler, a transaction waits for the validation of the previous task to complete before starting the validation of the current task. Thi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Order of Functions
### Description
Some internal functions are between public, some external functions are between public, and some public functions are between external.
### Instances
* [BaseV1-core.sol: 137](https://github.com/code-423n4/2022-09-canto/blob/main/src/Swap/BaseV1-core.sol#L137)
* [BaseV1-co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | false | false | ## High: LPs of VaderPoolV2 can manipulate pool reserves to extract funds from the reserve.
### Description
_Submitted by TomFrenchBlockchain, also found by WatchPug_
#### Impact
Impermanent loss protection can be exploited to drain the reserve.
#### Proof of Concept
In `VaderPoolV2.burn` we calculate the current ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Admin can change _dcttaxpercent to cause users to permanently lose all staked funds
### Description
The `updateConfigs()` function in `Controller.sol` allows any admin to change key parameters, one of which is `_dctTaxPercent`, without any upper limit. This vulnerability allows a rogue admin to set `_dctTax... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Don't initialize to default values
### Description
**Description:** Don't initialize to default values as Solidity already does this:
**Evo:**
Fixed in commit [f594ae0](https://github.com/contractlevel/sbt/commit/f594ae004d4afc80f19e17c0f61d50caa00a4811).
**Cyfrin:** Verified. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | integer-overflow | true | true | ## Low: Possible to escape burning of DSTokens by removing the wallet from the current investor and adding it as the wallet of another investor
### Description
Investors owning multiple investor accounts can split the `balanceOfInvestor()` and `balanceOf()` in their accounts by removing the wallet from the investor wh... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Using `bool`s for storage incurs overhead
### Description
*Credit: Description by [IllIllI000](https://gist.github.com/IllIllI000)*.
// Booleans are more expensive than uint256 or any type that takes up a full
// word because each write operation emits an extra SLOAD to first read the
// slot's contents... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Auctions are susceptible to transaction-reordering attacks
### Description
MCD features three types of auctions, each of which is susceptible to a transaction-reordering attack, where a miner replaces a legitimate bid with their own bid:
- **Flip auction** occurs when a Collateral Debt Position (CDP) loses to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Solidity compiler optimizations can be dangerous
### Description
Dharma Labs has enabled optional compiler optimizations in Solidity. There have been several bugs with security implications related to optimizations. Moreover, optimizations are actively being developed. Solidity compiler optimizations are disab... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: FraxlendPair.changeFee() doesn't update interest before changing fee.
### Description
_Submitted by auditor0517_
This function is changing the protocol fee that is used during interest calculation [here](https://github.com/code-423n4/2022-08-frax/blob/c4189a3a98b38c8c962c5ea72f1a322fbc2ae45f/src/contracts/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Potential collateralization imbalance
### Description
In function `balance` defined at https://github.com/bondappetit/bondappetit-protocol/blob/88680691fe8d872c5fc26e9500d19cf7caaa9861/contracts/depositary/StableTokenDepositaryBalanceView.sol#L81 contract aggregates balances through different tokens, so functi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Well-funded malicious actors can DOS the bridge
### Description
A malicious actor (e.g. a well-funded cross-chain messaging competitor) can DOS the bridge cheaply. Assume Ethereum Polygon bridge and the liquidity cap is set to 1m for USDC.
1. Using a slow transfer to avoid router liquidity fees, Bob (attacke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Wrong variable passed.
### Description
**Description**
Line 725. Instead of a local variable ‘_strategies’, a storage variable ‘strategies’ is passed in
Hash.sameStrategies(), which means that ‘require’ won’t revert.
**Recommendation**:
Pass the local variable ‘_strategies’ instead. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Identical transactions can be executed inside the same proposal
### Description
When a proposal is sent through the Polygon bridge, the `BaseBridgeReceiver` contract processes it by [queuing all transactions that are included in the proposal](https://github.com/compound-finance/comet/blob/2eb33b5e8454dba148373... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Updated implementation of the ERC1967Factory
### Description
**Severity**: Low
**Status**: Resolved
**File**: src/ERC1967Factory.sol
**Details**:
A newer implementation for the ERC1967Factory is available at its author's repository under commit hash: `9833cc764901b603398012b6f3b48930a7418f80`. It saves eve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: ChainID should not be 1
### Description
There are references in the codebase to Ethereum related bootnode ENRs as well as chainID defaults that are equal to Ethereum mainnet and various testnets.
### Recommendation
The default ChainID for Overprotocol Mainnet should be changed to something unique, and ENRs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | reentrancy | true | false | ## Severity: Medium Risk
## Context
- LSSVMPair.sol: Lines 192-245
- LSSVMPairERC20.sol: Lines 90-105
- LSSVMPairETH.sol: Lines 53-66
## Description
Assume a scenario where an NFT pool with `assetRecipient` set has the received funds sent directly to the `assetRecipient`. Now, suppose a user executes the `swapTokenFo... | Spearbit | 5 | Sudoswap |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: State-Account Balance Discrepancies in Token Management
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `eef2a9b27809735afdc7c1b1992cf111f01d26ff`. The client provided the following explanation:
> Use vault ata balance for any checks
**Update**
The client added additional instru... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Last withdrawer will donate fees to empty pool allowing MEV and having always stuck funds in the pool
### Description
in `onAfterRemoveLiquidity()` fees of the withdrawn tokens amounts (whatever its upLift or the minimum fees) of the last user withdrawing from the pool will be donated to empty pool.
### Im... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: `OpenEdition.buy()` might revert due to uint overflow when it should work.
### Description
`OpenEdition.buy()` might revert due to uint overflow when it should work.
### Proof of Concept
`OpenEdition.buy()` validates the total funds like below.
Here, `amount` was declared as `uint24` and `sale.price` is... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Event for critical parameters change
### Description
**Description:**
Events help non-contract tools to track changes, and events prevent users from being surprised by changes
**Recommendation:**
Add Event-Emit | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Change ``public`` state variable visibility to ``private``
### Description
If it is preferred to change the visibility of the `owner` and `pendingOwnerstate` state variables to ``private``, this will save significant gas.
2 result - 1 file:
https://github.com/code-423n4/2023-01-timeswap/blob/main/packages/v... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: `_governanceAdapter` and `_governanceExecutor` not checked
### Description
Constructor, `setGovernanceAdapter()` and `setGovernanceExecutor()`: missing `_governanceAdapter` and `_governanceExecutor` zero checks: https://github.com/MetaLex-Tech/borg-core/blob/9074503d37cfa1d777ef16f6c88b84c98b4f54eb/src/implant... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: PayloadController is unable to receive native tokens
### Description
It is possible to register payloads that send native tokens, such as ETH, when executed. However, there is no practical way of sending native tokens to the `PayloadsController` contract.
Payload transactions are ultimately executed by th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: LACK OF EMERGENCY STOP PATTERN IMPLEMENTATION
### Description
It was identified that the `whennotpaused` modifier is not used in the `Compliance` contract, even though it is inherited from the `BaseAccessControlPausableUpgradeable` contract.
### Recommendation
**SOLVED:** The \client team solved the issue in ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [06] `PrelaunchPoints::_validateData` accepts `address(0)` as a valid value for `recipient`
### Description
`PrelaunchPoints::_validateData` accepts `address(0)` as a valid value for the `recipient` field of `bytes calldata _data`.
This essentially means that later in the transaction flow, when `Prelaunchdata... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use of duplicate functions
### Description
The `ProteusLogic` and `Proteus` contracts both contain a function used to update the internal slices array. Although calls to these functions currently lead to identical outcomes, there is a risk that a future update could be applied to one function but not the other... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | overflow | true | false | ## Medium: Possible Integer Overflow/Underflow in quicksort function in utils library
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The use of `uint(left + (right - left) / 2)` might result in an overflow if the right is a very large negative number. Consider validating the array indices... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | true | ## Medium: L2 Oracle Update Can Be Sandwiched to Gain Extra Tokens
### Description
When a user calls `deposit()` in `L2SyncPool`, he deposits in the asset (tokenIn) and gets some shares. This asset will be in the contract until `sync()` is called to bridge the assets to L1 and be deposited into the `apxETH` vault.
Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | front-running | true | false | ## High: During voting the attacker 's refund is vulnerable to a sandwich attack
### Description
The `_tryFinalize` function in `Voting.sol` is vulnerable to sandwich attacks. The root cause of this vulnerability is the failure to implement slippage checks on the Uniswap transaction when selling WstETH to refund the a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Incorrect bonus percentages for partner and referrer
### Description
In the `VisibilityCredits` contract, the `PARTNER_FEE` and `PARTNER_REFERRER_BONUS` are incorrectly set to 250 ppm, which represents 0.025%. However, as per the comment in the contract, these values should be set to 0.25%. This misconfigur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Open `TODO`s in the codebase
### Description
There are currently 4 opened `TODO`s in the code, one of which shows an intent to add code/features post-audit - `// TODO: ADD A MERKLE SIGNATURE HERE ONCE FRONTEND IS FINALISED`. Remove or resolve all of them. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | false | false | ## Gas: State variables should be cached in stack variables rather than re-reading them from storage
### Description
The instances below point to the second+ access of a state variable within a function. Caching of a state variable replaces each Gwarmaccess (100 gas) with a much cheaper stack read. Other less obvious ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Don't update state | true | true | ## Lines of code
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/SyndicateRewardsProcessor.sol#L63
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/StakingFundsVault.sol#L88
... | Code4rena | 5 | Stakehouse Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Listing Ids Start at 1
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `85844dca34aa18802254dab43a59572f3bc6661a`. The client provided the following explanation:
> Added a check to revert if zero is passed as listingId for NFTMarketAuction and NFTMarketSimple contracts.
**File(s) af... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: ETH Can Be Locked Through Address Aliasing
### Description
Whenever interacting with L2 from L1, either through the `Mailbox.requestL2Transaction` or the `L1WethBridge.deposit` function, the user can specify a refund recipient address. This address receives a refund (on L2) of any excessive ETH provided, up... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | logic-error | true | false | ## Medium: Wrong accounting of fee in perp engine
### Description
In the perp fee calculation logic within [perp_engine.rs](https://github.com/deriverse/protocol-v1/blob/30b06d2da69e956c000120cdc15907b5f33088d7/src/program/perp/perp_engine.rs#L1202), when a user has partial fee prepayment that doesn't fully cover the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | true | false | ## Low: [02] Left the Default `MESSAGE_HASH`
### Description
For the in-scope code `MESSAGE` is left to the default value
[MultiMerkleRedeemer.sol#L53-L54](https://github.com/code-423n4/2022-09-tribe/blob/769b0586b4975270b669d7d1581aa5672d6999d5/contracts/shutdown/fuse/MultiMerkleRedeemer.sol#L53-L54)
This could ca... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Explicitly Initialize All Pool State Fields
### Description
## CreatePool Instruction Overview
The `CreatePool` instruction only initializes certain fields of the `PoolState` struct, implicitly setting the rest to zero. It would be clearer if these assignments were made explicit.
## Remediation
Explicitly i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | signature | true | true | ## Low: Cross-Chain votes can be invalidated in some scenarios due to Hub-Spoke timestamp mismatch
### Description
Current implementation of the cross-chain voting mechanism in the `HubVotePool` contract does not account for the timestamp of votes cast on spoke chains. When the `HubVotePool::crossChainVote` function i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Gap Between Periods Can Lead to Erroneous Rewards
### Description
The SNX rewards are earned each period based on reward and duration as specified in the `notifyRewardAmount()` function.
The "rate per second" at which rewards are distributed is given by:
```
rewardRate = reward / duration
```
Rewards are... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Insu�cient protection of sensitive keys
### Description
Sensitive information such as Etherscan keys, API keys, and an owner private key used in testing is stored in the process environment. This method of storage could make it easier for an attacker to compromise the keys; compromise of the owner key, for ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: NFT Hub implementation deviates from ERC721 for transfer functions
### Description
_Submitted by [0xRajeev](https://twitter.com/0xRajeev)_
ERC721 standard and implementation allows the use of approved addresses to affect transfers besides the token owners. However, the L2 NFT Hub implementation deviates fr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Variable opening fee will always be wrongly computed if collateral is not a stablecoin
### Description
Borrowing fees will be computed wrongly because of a combination of hardcoded values and a wrongly implemented setter function.
### Impact
Medium. Although this looks like a bug that doesn’t have a big im... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Rounding | true | true |
<https://github.com/code-423n4/2022-11-redactedcartel/blob/03b71a8d395c02324cb9fdaf92401357da5b19d1/src/vaults/PirexERC4626.sol#L156>
<https://github.com/code-423n4/2022-11-redactedcartel/blob/03b71a8d395c02324cb9fdaf92401357da5b19d1/src/vaults/AutoPxGmx.sol#L199>
<https://github.com/code-423n4/2022-11-redactedcarte... | Code4rena | 5 | Redacted Cartel |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: `NestedFactory.sol#_submitInOrders()` Wrong implementation cause users to be overcharged
### Description
_Submitted by WatchPug_
When executing orders, the actual `amountSpent + feesAmount` can be lower than `_inputTokenAmount`, the unspent amount should be returned to the user.
However, in the current im... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | false | ## Low: `StakingContract` refunds are affected by global parameter updates
### Description
When [`StakingContract::refundStakedAmount`](https://code.zeeve.net/zeeve-endeavors/benqi_smartcontract/-/blob/b63336201f50f9a67451bf5c7b32ddcc4a847ce2/contracts/staking.sol#L691-741) is called by the BENQI admin, the following ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | initialization | false | false | ## Low: Possible failure to redeem
### Description
In `Goldivault`, `redeemOwnership()` wouldn't work as expected after calling `changeProtocolParameters/initializeProtocol()` because `endTime/duration` is changed. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Price disparities between spot and perpetual pricing can heavily destabilize UXD
### Description
When minting UXD using PerpDepository.sol the amount of UXD minted corresponds to the amount of vUSD gained from selling the deposited ETH. This is problematic given that Perp Protocol is a derivative rather tha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Risks of the Balancer protocol should be explicitly documented
### Description
Severity: Low Risk
Context: Global scope
Description: Due to the high level of complexity that the Vault brings to the system, we recommend documenting
all historical issues that has affected Balancer, to ensure that these issues ar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Unlimited Flux minting
### Description
Report type: Smart Contract
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/Voter.sol
Impacts:
- Direct theft of any user funds, whether at-rest or in-motion, other than unclaimed yield
- Manipulation of governance voting result deviating fro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Use of magic numbers
### Description
In programming, "magic numbers" refer to the use of unexplained numerical or string values directly in code, without any clear indication of their purpose or origin. The use of magic numbers can lead to confusion and make your code more difficult to understand, maintain, an... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of Input Validation
### Description
The `BaseFee` parameter of type `big.Int` [is checked for not being `nil`](https://github.com/mantlenetworkio/mantle-v2/blob/bb0ff7002520ee936101c4c263ac02a66e7e3c96/op-node/rollup/types.go#L236-L238). However, a `big.Int` can be a negative number which does not make se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: `name()` function can revert for some Curve pools
### Description
_Resolved_
[Some Curve pools](https://etherscan.io/address/0xDC24316b9AE028F1497c275EB9192a3Ea0f67022#code) are not compatible with the `ICurvePool` interface, as they do not have a `name()` and `decimals()` function.
For such pools, the `name... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | false | false | ## High: Users can exercise small amounts without sending collateral
### Description
When exercising option tokens, the [`_exercise` function](https://github.com/AuctusProject/aco/blob/36bcab024c9781d799381f8f973e99fd5b0f4d2d/smart-contracts/contracts/core/ACOToken.sol#L638) calls `_validateAndBurn` to validate that t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | logic | true | false | ## High: The `addLiquidity` private function is unreachable and never calls `uniswapV2Router.addLiquidity`
### Description
The overriding `_update` function in the `QodaToken` contract performs a call to the `swapBack` private function when certain conditions are met:
**- Function** `_update` **- src/QodaToken.sol [L... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Floating pragma
### Description
All contracts in scope currently use floating pragma versions `^0.8.4` , `^0.6.8` , and `^0.6.1` which means that the code can be compiled by any compiler version that is greater than or equal to the respective version, and less than the next major version (0.9.0 or 0.7.0 respec... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | false | false | ## Medium: Users can add collateral to closed trades
### Description
During our audit, the Futureswap team independently discovered that users were capable of adding collateral to closed trades. Consider calling the [`ensureTradeOpen` function](https://github.com/futureswap/fs_core/blob/96255fc4a550a5f34681c117b5969b8... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: else-block is not required in `getOperationState()`
### Description
**File:** `Governance.sol`
[File: code/contracts/ethereum/contracts/governance/Governance.sol](https://github.com/code-423n4/2024-03-zksync/blob/main/code/contracts/ethereum/contracts/governance/Governance.sol#L105)
The `else` instruction a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: wrong minting amount
### Description
_Submitted by danb_
should be:
**[gititGoro (Behodler) confirmed, but disagreed with High severity and commented](https://github.com/code-423n4/2022-01-behodler-findings/issues/297#issuecomment-1030508474):**
> Should be a balanceBefore and balanceAfter calculation wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing checks for `address(0)` in constructor/initializers
### Description
Check for zero-address to avoid the risk of setting `address(0)` for state variables when deploying.
*There are 9 instances of this issue.*
--- | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Reduced Liquidation Fee due to Improper Reset
### Description
## Liquidation Fee Calculation in Position Size Increase
When the position size is increased in `increase_position_long` and `increase_position_short` instructions, the `position.liquidation_fee_usd` field is recalculated proportionally to the inc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Incorrect __Essential_init() function is used in TaikoToken making snapshooter devoid of calling snapshot()
### Description
The EssentialContract.sol contract is inherited by the TaikoToken contract. This essential contract contains two \__Essential_init() functions, one with an owner parameter only (see [h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Staking contracts should be assert TKN != WETH
### Description
The staking contract is incompatible with the same address of TKN and WETH. So you should force them to be different address in the constructor, otherwise it will mess up the internal accounting system.
### Impact
Staking contracts is not compatib... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: An `evm_block` May Be Associated with Multiple Hashes
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> In the Event Receiver chain, we allow multiple blocks with the same (network_id, evm_block_height) but different evm_block_hash. Theoretical... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Continuous encoding and decoding of data is confusing and error prone
### Description
Multiple structured representations of the collateral data exist within the system, such as the `IdentityObj`, `EnclaveIdentityJsonObj`, and `TcbInfoBasic` (figure 4.1). However, most of the data is encoded and stored as blob... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Refactor code with assembly to check zero address, hash values, and perform external call
### Description
In the instance below, we can check for the zero address using assembly. In addition, we can reuse memory to hash values and perform an external call.
**Note: In order to do this optimization safely we wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: The `V3AMO._mintAndSellBoost()` function does not work with Velodrome, Aerodrome, Fenix, Thena and Ramses
### Description
The protocol mints `BOOST` tokens and sells them for USD using the `_mintAndSellBoost()` function for SolidlyV3 DEXes. Since Velodrome, Aerodrome, Fenix, Thena and Ramses are parts of th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | false | ## Low: Use named mapping parameters
### Description
Solidity 0.8.18 [introduced](https://soliditylang.org/blog/2023/02/01/solidity-0.8.18-release-announcement/) named `mapping` parameters; use this feature for clearer mappings:
```solidity
PriceFeed.sol
StabilityPool.sol
dao/AdminVoting.sol
dao/AllocationVesting.sol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | logic | true | false | ## High: ContractMigrationFacet doesn't increase total Stalk and Roots
### Description
L2ContractMigrationFacet is used to migrate deposits owned by smart contracts.
Problem is that it increases balance of Stalk and Roots associated with migrated deposit, but never updates global balances of Stalk in Roots in Silo.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Inconsistent A Value in Calculations
### Description
This issue occurs in the `SelfPeggingAsset` contract, where calculations use a locally stored `A` parameter instead of fetching the current value from the `rampAController`.
During ramping periods, this leads to inconsistencies because the stored `A` va... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Fee calculation mismatch in `mint`, `deposit`, `redeem` and `withdraw`
### Description
When users calls `mint(shares)` code calls `_deposit(previewMint(_shares), _shares` and `previewMint(shares) = convertToAssets(shares).addBp()`.
When users calls `deposit(amount)` code calls `_deposit(_amount, previewDeposi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Constant HUNDRED declared twice with different values
### Description
The constant HUNDRED is assigned the value `10**2` in [StabilityFeeTreasury](https://github.com/reflexer-labs/geb/blob/261407b6b332c2063e4256aa5f9b223d52dad7e1/src/StabilityFeeTreasury.sol#L128) and the value `10**29` in [TaxCollector](https... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: The gas checks in the PixelswapStreamPool contract are wrongly placed
### Description
The gas checks in the `PlaceOrder` message receiver of the `PixelswapStreamPool` contract are placed after the `pair_status` update. This can lead to loss of funds for users and pair reserves and balances going out of sync.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Receive function
### Description
InfinityStaker.sol is not supposed to receive ETH. Instead of using a rescue function, remove `receive()` and `fallback()` altogether.
### Proof of Concept
Instances include:
#### InfinityStaker.sol
[fallback() external payable](https://github.com/code-423n4/2022-06-infinit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: Inline small internal functions only used once
### Description
It is more gas efficient to inline small internal functions only used once.
For example `pUSDeDepositor::getPhase` is only called by `deposit_sUSDe`. Changing `deposit_sUSDe` to cache `pUSDe` then use the cached copy in the call to `PreDepositPhas... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [03] The Mint Command Prompt is Missing the mint-to-address Parameter
### Description
This function defines a command-line interface (CLI) command for broadcasting a MsgMint message using the Cobra library. Specifically, it implements a CLI command for minting new tokens and broadcasting the operation to the b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Performance fees can exceed 100%
### Description
When a vault is created, a vault-wide performance fee is set; a performance fee is also set for each strategy when it is added to the vault. The vault contract assumes that the sum of the vault performance fee and the performance fee of a given strategy will be ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Bypass whenNotPaused modifier
### Description
## Lines of code
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/Staking.sol#L328-L332
https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contrac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | true | false | ## Medium: Not checking `allowMessagesFrom` on the destination chain
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
The Cross-chain Teller contract has configurations for each supported chain. They can separately configure whether to only receive messages (`allowMessagesFrom`), o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Risk Free Negative Price Trades
### Description
Description
The tracer markets are designed to allow for negative price trades. However users can make trades without mak-
ing deposits (or can make a trade and then withdraw their initial deposit (see Maximum Withdrawal Observations
for a simple analysis)).
The... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.