prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Redundant Console Import
### Description
The following contracts currently imports `forge-std/console.sol`, which is a debugging tool typically used during development and testing:
* ALTT.sol
* StakingFactory.sol
* StakingVault.sol
* SubscribeRegistry.sol
* XPRedeem.sol
This import is redundant in a producti... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: `erc721DecreaseIsolateSupplyOnLiquidate()` missing clear `lockerAddr`
### Description
When `isolateLiquidate(supplyAsCollateral=false)` is executed, finally `erc721DecreaseIsolateSupplyOnLiquidate()` will be executed and the NFT will be transferred to the user.
We know from the above code that this method d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Use named mapping parameters to explicitly note the purpose of keys and values
### Description
Use named mapping parameters to explicitly note the purpose of keys and values:
* [`BasisTradeTailor`](https://github.com/buttonxyz/button-protocol/blob/9002f2b0d05ba80039bd942c809dbe5bc1a252c9/src/BasisTradeTailor.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Unoptimized Loops
### Description
When a loop iterates many times, it causes the amount of gas required to execute the function to increase significantly. In Solidity, excessive looping can cause a function to use more than the maximum allowed gas, which causes the function to fail.
``` File: Compounde... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Attacker can make pledge on behalf of users if those users have approved `PledgeManager` to spend their tokens
### Description
**Description:** `PledgeManager` requires users to approve it to spend their tokens in order to make pledges. Users can do this by either:
1) using `IERC20Permit::permit` which enforc... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Typos, redundancies, errors and missing data in comments & NatSpec docs
### Description
Many comments and NatSpec docs have errors or redundancies in them and should be improved.
### Recommendation
- The NatSpec of `validatePayrollTxHashes` is missing `@return` parameter.
- Typo in the NatSpec of `getDomainSe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | false | ## Medium: The function `updateValset` does not have enough sanity checks
### Description
_Submitted by hrkrshnn, also found by pauliax and shw_
In the [updateValset](https://github.com/althea-net/cosmos-gravity-bridge/blob/92d0e12cea813305e6472851beeb80bd2eaf858d/solidity/contracts/Gravity.sol#L224) function, the cu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Self-liquidations of leveraged positions can be profitable
### Description
## High Risk Vulnerability in Liquidation.sol
**Severity:** High Risk
**Context:** Liquidation.sol#L127
**Description:** An attacker can perform the following attack by sandwiching a price oracle update:
1. Taking on a leveraged ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: ABSENCE OF CLIENT-SIDE CONTROL
### Description
Even if user input controls should be established at least in the backend side, it is important to ensure that client-side controls also work as expected.
### Recommendation
Even if the finding does not have impact (the transaction failed), it is important to ens... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Caching storage variable and function calls
### Description
This is one of the most common ways to save a nice amount of gas. Every additional read costs 100 gas units (when it comes to mapping or arrays there's additional cost), and each additional function call costs at least 100 gas units (usually much more... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Change `v3-rewards/package.json` to require minimum OpenZeppelin v4.9.2 as prior versions had a security vulnerability in Merkle Multi Proof
### Description
**Description:** `v3-rewards/package.json` currently [specifies](https://github.com/SolidlyV3/v3-rewards/blob/6dfb435392ffa64652c8f88c98698756ca80cf28/pac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: [ACKNOWLEDGED] Owner fails to receive native token transfer in `FathomProxyWalletOwner`
### Description
In the function [`closePositionFull`](https://github.com/Into-the-Fathom/fathom-stablecoin-smart-contracts/tree/3768c87367d286ae0e82f444b2f9d760417b507e/contracts/main/fathom-SDK/FathomProxyWalletOwner.so... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: UI/AlertView - Unnecessary Use of dangerouslySetInnerHTML ✓ Fixed
### Description
`AlertView` is populated by setting `innerHTML` instead of the component’s value, which would be auto-escaped. This only makes sense if the component is supposed to render HTML. However, the component is never used with HTML a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: `tokenURI()` reverts for tokens that don't implement `IERC20Metadata`
### Description
While the ticket descriptors are not in scope, the code calling them is. `NFTLoanTicket.tokenURI()`, which is in scope, ends up calling descriptor code which casts the asset to `IERC20Metadata`. This interface is separate fro... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `ComplianceConfigurationService::getWorldWideForceFullTransfer` is not applied to US investors
### Description
**Description:** `ComplianceConfigurationService::getWorldWideForceFullTransfer` function name implies global application across all regions, but the implementation only applies this setting to non-US... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Use a more recent version of solidity
### Description
Use a solidity version of at least 0.8.13 to get the ability to use `using for` with a list of free functions
*There are 2 instances of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Usage of uints/ints smaller than 32 bytes (256 bits) incurs overhead
### Description
When using elements that are smaller than 32 bytes, your contracts gas usage may be higher. This is because the EVM operates on 32 bytes at a time. Therefore, if the element is smaller than that, the EVM must use more operatio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | true | false | ## High: BalanceRedirectPresale - Presale can be extended indefinitely Won't Fix
### Description
The `OPEN_ROLE` can indefinitely extend the Presale even after users contributed funds to it by adjusting the presale period. The period might be further manipulated to avoid that token trading in the MarketMaker is opene... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [03] No validation of token being removed has shares
### Description
The manual remove function doesn't validate whether the pool being removed has shares. It can organically have shares during the removal either by TX order or already the share is there. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Use `unchecked` for Non-Loop Increment/Decrement operations
### Description
*Disclaimer: You should be sure that underflow is not possible. Using `unchecked` increments can save gas by bypassing the built-in overflow checks. This can save 30-40 gas per iteration. It is recommended to use unchecked increments w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | logic-error | true | true | ## Low: Empty strategies can be created due to missing zero length check
### Description
`StrategyBuilderPlugin.createStrategy()` does not currently revert if the `steps` array length is zero. This means strategies can be created that can never be deleted, per the `strategyExist` modifier logic that is applied to `Str... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Hardcoded `BTC_SIG_GAS_USAGE` can brick the bridge in case of a network upgrade
### Description
The function `_remFees` in `Bridge.sol` contract deducts gas fees for the validators. It calculates this assuming a fixed cost for submitting the bitcoin signature.
However, due to a network upgrade, gas fees for ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Auction settler can steal user funds if bond timestamp is high enough
### Description
## Handle
kenzo
## Vulnerability details
After an auction has started, as time passes and according to the bondTimestamp, newRatio (which starts at 2*ibRatio) gets smaller and smaller and therefore less and less tokens... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Incorrect use of Time-Weighted Average Prices
### Description
Throughout the codebase, oracles of type `IOracle` are used to update, and read asset prices. These prices are then used to inform decisions that together try to keep the price of FEI stable. The oracle interface is designed such that the protoco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Users need admin trust for fractional IP in fundraise
### Description
For fundraising, the registration and fractionalizing of the IP is executed by the admin only after the fundraise if completed. This means that the participants of the fundraise are expected to trust the admin to register and fractionalize t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | false | false | ## Medium: Contracts storage layout can be corrupted on upgradeable contracts
### Description
The Celo protocol has an [unstructured storage proxy pattern](https://blog.openzeppelin.com/upgradeability-using-unstructured-storage/) system implemented, very similar to the one proposed in the [OpenZeppelin SDK](https://gi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Explicit Use Of Assert
### Description
## InSpoke
`depositCollateralNative` and `repayNative` enable the caller to initiate a cross-chain deposit or repay respectively with native tokens, given the caller has provided enough `msg.value` to cover the relay and return, and their desired deposit/repay amount.
#... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Plot allowances should have defined the index and start
### Description
Plot allowances are not completely constrained and can lead to users move pods that approvers would not like to
### Impact
Low | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | true | false | ## High: Top bid can lock rent indefinitely by clearing the next bid before the promotion
### Description
In the amAMM, the manager of a top bid might be interested in keeping this status, especially if he is paying a low rent in comparison with the fees received.
There are two ways for the top bid to be replaced by ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Continued reference to "Seeds" in `InitBipBasinIntegration::init` is confusing
### Description
With the deprecation of the "Seeds" terminology, [continued reference](https://github.com/BeanstalkFarms/Beanstalk/blob/12c608a22535e3a1fe379db1153185fe43851ea7/protocol/contracts/beanstalk/init/InitBipBasinIntegrati... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Disabling the cooldown period during post-slashing could affect the auction
### Description
The `StakedToken.redeem()` function allows the redemption of staked tokens after the stakers' cooldown period. During the post-slashing state when the auction is ongoing, stakers can redeem immediately without waiting f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Use of post-increment operator
### Description
In the `deposit` function of the `InceptionBridge` contract, the post-increment operator is used to increment the `_globalNonce` variable:
```
_globalNonce++;
```
This is not the most gas efficient approach to incrementing a variable.
### Recommendation
Replace... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | token | true | false | ## Gas: optimizations - calculation getBalanceLocked
### Description
## Handle
a_delamo
## Vulnerability details
## Impact
In Visor.sol, the function `getBalanceLocked` returns the amount locked.
This method do will O(n) to return the highest locked value.
But this method is only being used to verify that there... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Evergrowing array:
### Description
**Description**
The problem with this loop is that on every unStake() the user pushes a new unstake value to
the array increasing its length, but on withdrawUnstakedTokens() array’s length is not
decreased. If the user repeats the process of (stake -> unstake -> withdraw... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: Liquidator Can Bid With Insufficient Cash
### Description
Description
When executeBid() performs _symmetricManagerAdjustment() on the cash asset of the bidder, there is no check that
the bidder’s cash balance remains positive after the adjustment. This could result in a negative cash balance after the
bid.
The ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing Address Validation
### Description
**Update**
The team now validates every address with the exception of a missing validation in the `constructor` of `CreditToken` to ensure that `_operator` is not the zero address. See ARC-44 for additional details.
**Update**
The team fixed the issue by adding the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Bounceable Message Sent Despite No Processing of Such
### Description
**Update**
Marked as "Acknowledged" by the client. The client provided the following explanation:
> send_jettons() is only used for withdrawals and for the return Jetton flow. Withdrawals are only actioned by authorized users (RhinoFi backe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: USE A MORE RECENT VERSION OF SOLIDITY
### Description
It is recommended to update the version of Solidity being used, as an old version is currently in use. It is advisable to consider using the latest version, `0.8.19`. You can check the improvements and bug fixes offered by the new versions [here](https://gi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Redundant Initialization of Variables
### Description
**Severity**: Informational
**Status**: Resolved
**Location**: PoolBase.sol
**Description**
The code contains redundant initializations of variables to zero. In Solidity, the default value for uninitialized variables is zero, making these initializatio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Owner Should Not be Able to Mint COINC to Their Wallets
### Description
**Description:**
In the CoinlendCredits contract, the owner can mint an infinite amount of tokens to their wallet, even though it is only necessary to mint to the contract address for users to call buyCredits().
**Recommendations:**
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: `RubiconMarket: buy()` may not take any fee for tokens with low decimal precision
### Description
In the `buy` function of the `RubiconMarket` contract, a fee is subtracted on taker trades.
The default `feeBPS` is set to `1` which is equivalent to a fee of `0.01%` or `0.0001` in decimal form.
For tokens li... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [02] `UseIERC4626.withdrawVault` does not check if vault is `address(0)`
### Description
### Proof of Concept
While other functions check if the `vault` parameter is `address(0)`, `UseIERC4626.withdrawVault` does not check if `vault` is `address(0)`.
### Recommended Mitigation Steps
The `UseIERC4626.withdr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `tokenURI()` does not revert if the `id` is not a valid NFT
### Description
The specification of [ERC-721](https://eips.ethereum.org/EIPS/eip-721) states the following regarding the `tokenURI` function: `Throws if _tokenId is not a valid NFT`.
However, the `tokenURI()` function in `NFTShadows` does not check ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Attacker can drain most of the reserves by weaponizing USDC blacklisting
### Description
Auction mechanism uses push transfer to refund the lowest bidder when their bid has fallen out of the queue. Since refund token will be USDC, this opens a possibility to weaponize USDC blacklisting feature and attack th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Open fee is overcharged in `_addLeveragePostCallback` function
### Description
In the `_addLeveragePostCallback` function, the user pays an open fee proportional to `pairedLpDesired`, which is the amount of `pairedLPToken` that the user has decided to use for `lpAndStakeInPod`.
In fact, there are `pairedLPT... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: SimpleShares contract allows execution during pause
### Description
Some functions defined in the **SimpleShares** contract are not restricted to prevent execution during a paused contract state. This leads to successful function invocation during a paused state.
The **SimpleShares** implementation of `distr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | false | false | ## High: Cross-chain messaging via `Anycall` will fail
### Description
### Lines of code
### Impact
Cross-chain calls will fail since source-fee is not supplied to `Anycall`.
### Proof of Concept
In `_performCall()` of `BranchBridgeAgent.sol`, a cross-chain call is made using `anyCall()` with the `_flag` of [4](h... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Implement Fee Market Integrated into Consensus Layer
### Description
During periods of high network activity, maintaining liveness and usability becomes challenging without a robust fee market mechanism in place. While there are various approaches, the Ethereum Improvement Proposal (EIP-1559) has proven to be ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Redistributed debt does not accrue interest until next trove action
### Description
When a trove becomes eligible for liquidation and the **Absorber** does not have enough yin to cover the trove’s debt, a redistribution occurs. A redistribution will take all of the debt and collateral from an unhealthy trove a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Flaw in Full Transfer Checks
### Description
## Compliance Service Pre-Deposit Check Regulated
In `compliance_service::pre_deposit_check_regulated`, the `get_force_full_transfer` condition checks if full transfers are enforced when the transfer originates from the US. If this condition is true, the function ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Protocol Prioritises Lower Level Users, Hence Robbing the Higher Level Ones of Commissions
### Description
Let's investigate the flow of the following scenario:
`L0 => L5 => L1`
The L0 user wants to directly connect with the specific L5 user and pay the 12% commission to him. The problem in this example wi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Unrequired Checks With Liquidation Amount
### Description
## Liquidation Amount Function
In the `assertLiquidationAmount` function, the checks for `originalBalanceX18` are unrequired, since the conditions are validated in the checks. For when `liquidationAmountX18 > 0` and `originalBalanceX18 >= liquidationAm... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Anyone can steal all `HoneyJar` NFTs in `HoneyJarPortal` and exploit its allowances
### Description
**Impact:**
High, as it is a value loss for users
**Likelihood:**
High, as it is a common vulnerability and requires no preconditions
**Description**
The `_debitFrom` function in `HoneyJarPortal` is exploita... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | access-control | false | false | **Description:** The project's Makefile contains hardcoded sensitive credentials including:
- A private key used for contract deployments
- Multiple RPC endpoint URLs with API keys
- Several Etherscan API keys for different networks
**Impact:** Although no customer funds were at risk and the deployer key had no admin... | Cyfrin | 4 | D |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Uninitialized global variable
### Description
The [`OracleRef` contract](https://github.com/fei-protocol/fei-protocol-core-internal/blob/f54d7bb07c55adb78e2e142e7044f60090bb7602/contracts/refs/OracleRef.sol) relies on 2 oracle addresses – the main `oracle`, and a `backupOracle`. However, only the `oracle` can ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Refactor `If`/`require` statements to save SLOADs in case of early revert
### Description
Checks that involve calldata should come before checks that involve state variables, function calls, and calculations. By doing these checks first, the function is able to revert before using excessive gas in a call that ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: [48] Use a struct to encapsulate multiple function parameters
### Description
If a function has too many parameters, replacing them with a struct can improve code readability and maintainability, increase reusability, and reduce the likelihood of errors when passing the parameters.
BidOrdersFacet.sol ([40-47]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Zero price validation could be included in the price oracle
### Description
**Description:** `FeeController.calculateTokenAmount()` validates that the price returned by the oracle is non-zero:
Instead, this could be included in `PriceOracle._scalePythPrice()` which already validates the price is non-negative... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: setAllowedSlippage and setMinRatio functions are unreachable
### Description
The administrative functions `setAllowedSlippage` and `setMinRatio` have a requirement that they can be called only by the `poolManager`. However, they are not called by any reachable function in the PoolManager contract.
```solidity... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using `bool`s for storage incurs overhead
### Description
1. File: src/EternalStorage.sol (line [14](https://github.com/code-423n4/2022-04-axelar/blob/f1c8bfc16f82a27797f61cb3a310c0f936dce567/src/EternalStorage.sol#L14)) | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Missing Buy Token Amount Validation
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `87f0db3aa86a8749fc49afcbad13c4f6e8fa9175`.
**File(s) affected:**`take_offer.rs`
**Description:** The `instructions::take_offer::calculate_buy_amount()` function does not return an error if the calcu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Incomplete Balance Check Missing Transaction Fee and Reserve Balance
### Description
The `create_client_account()` function checks if the wallet has sufficient balance to create two accounts, but it does not account for transaction fees or reserve balance for the wallet itself. This can lead to transaction fai... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: The Chainlink price feed's input is not properly validated
### Description
**Impact:**
High, as it can result in the application working with an incorrect asset price
**Likelihood:**
Low, as Chainlink oracles are mostly reliable, but there has been occurrences of this issue before
**Description**
The cod... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | true | ## Medium: Pausing `WardenPledge` contract, which takes effect immediately, by its owner can unexpectedly block pledge creator from calling `closePledge` or `retrievePledgeRewards` function
### Description
### Impact
The owner of the `WardenPledge` contract is able to call the `pause` function to pause this contract.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Inconsistent upper bounds on optionAllocationPct
### Description
The `optionAllocationPct` state variable in [`RibbonDeltaVault`](https://github.com/ribbon-finance/ribbon-v2/blob/3fa3bec15ad1e2b18ad87f979b87a68368497f13/contracts/vaults/RibbonDeltaVault.sol) is required to be [less than 100%](https://github.co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Game doesn't accrued rewards for previous rebalance period in case if rebalanceBasket is called in next period
### Description
Game doesn't accrued rewards for previous rebalance period in case if `rebalanceBasket` is called in next period. Because of that user do not receive rewards for the previous period... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Rewards are not rolled over
### Description
If there is no deposit for sometime in start then rewards for those period are never used.
### Proof of Concept
1. Admin has added reward which made reward rate as 10 reward per second using notifyRewardAmount function
rewardRate = reward.div(rewardsDuratio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: sessionKeys can't be expired
### Description
The whitepaper contains:
However, there is no (onchain) functionality to expire or revoke sessionKeys.
### Recommendation
The keys are inspired by Zerodev. This protocol has a way to expire keys: `ZeroDevSessionKeyPlugin - revokeSessionKey()`. Consider adding som... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Visibility not declared
### Description
**Severity**: Informational
**Status**: Resolved
**File**: core/evm/iscmagic/ERC20BaseTokens.sol
**Constant**: MAX_UINT64
**Details**:
The constant doesn't have an explicit visibility declared. It will be set as public implicitly. To avoid unintended exposure, decla... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: While changing vote delegator from himself to another user, `_delegateBalances` should not be decreased
### Description
**Description:** In `setUserVoteDelegate` function, when a user set vote delegator to himeself, his `_delegateBalances` value doesn't contain his `userBalance` from L149.
When he changes v... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `>=` costs less gas than `>`
### Description
The compiler uses opcodes GT and ISZERO for solidity code that uses `>`, but only requires LT for `>=`, which saves 3 gas. If `<` is being used, the condition can be inverted. In cases where a for-loop is being used, one can count down rather than up, in order to us... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: `CurveLPOracle` is not working
### Description
- https://github.com/ConicFinance/protocol/blob/7a66d26ef84f93059a811a189655e17c11d95f5c/contracts/oracles/GenericOracle.sol#L34
`_chainlinkOracle` is the first in sequence in `GenericOracle.getUSDPrice`.
Since there is already a `crvUSD` oracle on the mainn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Unnecessary modifier `whenPaused`
### Description
The issue is identified within the [resume](https://github.com/lidofinance/community-staking-module/blob/a898d045b63303294752d1a60ad9dfe8d8ba69ca/src/CSFeeOracle.sol#L139) function of the `CSFeeOracle` contract. There is an unnecessary `whenPaused` modifier use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Arbitrary data can be passed to forceDeallocate
### Description
Only an allocator B, a sentinel S (and also this due to `forceDeallocate` calling `deallocate`) can call `deallocate` and provide data for a registered adapter. This would make one think that the data provided by the trusted privileged entities B ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [04] Pool's `ParamLibrary.check` function for `TimeswapV2PoolCollectParam` checks `param.strike == 0` less restrictively than pool's other `ParamLibrary.check` functions
### Description
As shown below, calling the pool's `ParamLibrary.check` function for `TimeswapV2PoolCollectParam` will not revert when `para... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: `public` functions not called by the contract should be declared `external` instead
### Description
Contracts [are allowed](https://docs.soliditylang.org/en/latest/contracts.html#function-overriding) to override their parents' functions and change the visibility from `external` to `public`.
*There is 1 instan... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `<array>.length` should not be looked up in every loop of a `for-loop`
### Description
Reading array length at each iteration of the loop consumes more gas than necessary.
In the best case scenario (length read on a memory variable), caching the array length in the stack saves around **3 gas** per iteration.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [13]
### Description
There is no upper limit for the lender fee [HomeFi.sol#L194](https://github.com/code-423n4/2022-08-rigor/blob/f2498c86dbd0e265f82ec76d9ec576442e896a87/contracts/HomeFi.sol#L194). Consider enforcing a limit of 1,000 (or even something like 200) to avoid errors and give users an upper limit ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Dispensable gas fees from unoptimized loops
### Description
Throughout the code in scope, there are several instances of unoptimized `for` loop declarations that may incur in higher gas costs than necessary. The affected functions are:
* `redeem()`
* `isAbleToRedeem()`
* `getTotalDelegated()`
* `_verifyDelega... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Divide by zero
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
Voter.sol - Variables being the divisor of division are not ensured to be non-zero.
In notifyRewardAmount() function
uint256 _ratio = amount * 1e18 / totalWeight;
In _vote() function
uint256 _poolWeight = _... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: `operationalTreasury`: assumes 1:1 USD value for base token
### Description
In `OperationalTreasury`, the protocol calculates fees and premium amounts in USD, but it assumes that the `baseSetUp.token` (buy token) value is always equal to 1 USD. This assumption can lead to a wrong collection of funds if the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Reserved Grant Miscalculation
### Description
## Potential Vulnerability in `add_genesis_liquidity`
There is a potential vulnerability in the `add_genesis_liquidity` instruction related to the interaction between `claim_reserved_grant_amount` and `sanity_check` within `GenesisLock`.
- `reserved_grant_amount... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Old router retains token allowance after update
### Description
The `setRouter` function, which is in both `StrategyArb` and `StrategyOp` contracts, fails to revoke the allowance of the old router when a new router is set. This leads to unintended permission where the previous router retains the ability to una... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | true | false | ## High: Invalid RLP encoding causes proof verification failures for values with leading zeros
### Description
The Prover contract incorrectly prepends fixed-length RLP encoding prefixes to values being proven, causing proof verification to fail when values contain leading zeros. This affects both L2 state root verific... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | true | ## Medium: Incorrect rounding in previewWithdraw function leads to residual wstUSR balance
### Description
The `previewWithdraw` function in the `WstUSR` contract uses incorrect rounding when calculating the amount of wstUSR required to withdraw a certain amount of USR. The function rounds down instead of rounding up,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: Malicious recipient can gas grief the relayer
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
When a user sends BTC on the Bitcoin mainnet, the relayer attempts to execute the swap on BoB network with onramp contract
The on-ramp contract transfers 1:1 amounts of wrapp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: We can save some SLOADS by refactoring the function `buyCurvesTokenWhitelisted` (Saves 113 Gas on average)
### Description
https://github.com/code-423n4/2024-01-curves/blob/516aedb7b9a8d341d0d2666c23780d2bd8a9a600/contracts/Curves.sol#L404-L420
| | Min | Max | Avg |
| ------ | --- | ------- | ----- |
| Be... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: #60 line. Useless variable. To reduce the total bytecode of the contract, you can write in 1 line. For example, _deposits [swapId] [participant] = DepositLeg (...);
### Description
There are a lot of storage reads in the redeem function.
**Recommendation**:
Move the most frequently used variables into local ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | true | ## Low: Unvested amount is lost if all users withdraw
### Description
`sUSBD` permanently locks an initial “burnt” share balance (minted to the vault itself for donation-attack protection). During a vesting period, if all user shares are redeemed/burned such that only the locked shares remain, the remaining unvested r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: Typos
### Description
*There are 6 instances of this issue:*
https://github.com/code-423n4/2022-05-backd/blob/2a5664d35cde5b036074edef3c1369b984d10010/protocol/contracts/BkdLocker.sol#L173
https://github.com/code-423n4/2022-05-backd/blob/2a5664d35cde5b036074edef3c1369b984d10010/protocol/contracts/tokenomics... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: get_vault_borrowing_power() could prevent vault’s functionality
### Description
External calls from `get_vault_borrowing_power()` could revert, disabling the ability to borrow against a vault or liquidate a vault.
`get_vault_borrowing_power()` contains a loop, starting on line [580], which loops through a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Validation Logic
### Description
## Code Review Summary
1. **Issue in FillOrder**
The code currently fails to explicitly check that the `maker_base_vault` and `maker_quote_vault` are owned by the SPL Token program (`spl_token::ID`). While this will result in an error later in the process when attemp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Reserve May Fall Below the Minimum Percentage of Total Supply
### Description
**Update**
The team fixed the issue as recommended in the commit `0976587`.
**File(s) affected:**`Reserve.sol`
**Description:** The `Reserve` currently uses `pToken.scaledTotalSupply()` instead of actual token supply `pToken.tot... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Client Project Has No Ownership Over the Engine Configuration
### Description
At present, the contract engine is solely governed by a single administrator address. As this address is expected to actively operate the contract, it is most likely to be a Spherex-controlled address. This means that if SphereS, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Insecure BytesLib Dependency
### Description
The `solidity-bytes-utils` v0.0.6 dependency has a critical vulnerability in the `BytesLib.slice()` method.
See [here](https://github.com/GNSPS/solidity-bytes-utils#important-fixes-changelog) for more info.
The current codebase does not expose this vulnerability... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Two Step Governance Change
### Description
**Description:**
1. Observe the updateGovernance function
2. Note that Governance is updated directly.
3. If old governance has provided incorrect address for new governance then governanceAddress is updated incorrectly
**Recommendations:**
Implement 2 step govern... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [04] Functions that are not supported in transaction mode should revert not send empty arrays
### Description
https://github.com/code-423n4/2024-03-phala-network/blob/a01ffbe992560d8d0f17deadfb9b9a2bed38377e/phala-blockchain/crates/pink/runtime/src/runtime/extension.rs#L436
https://github.com/code-423n4/2024-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Function call() is risky and can be restricted further
### Description
The function `call()` is powerful and thus risky. To reduce the risk, it can be restricted further by disallowing potentially dangerous function selectors. This is also a step closer to introducing permissionless routers.
```solidity
fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Unbounded Fee Parameters Allow Abusive Fees and Redemption DoS
### Description
`PawnShop` charges a fee (in basis points) on top of the borrowed principal when a borrower redeems their NFT via `redeem(...)` (context).
However, `setFees(...)` allows `MANAGER_ROLE` to set `fee7Days` and `fee30Days` to any `uint... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: UploadDataArgs struct is unused
### Description
## Unused Struct in `sugar/src/upload/assets.rs`
In `sugar/src/upload/assets.rs`, the `UploadDataArgs` struct is defined but not used anywhere in the crate.
## Code Snippet
## Remediation
Remove the `UploadDataArgs` struct definition.
© 2022 OtterSec LLC. A... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.