prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | true | false | ## High: Incorrect Integration of Permit2 in StarBaseDCA, StarBaseLimitOrder ✓ Fixed
### Description
In the `claimTokens` function of the `StarBaseDCA` contract, the same `permitSignature` and `permitSingle` variables are called twice in the `IStarBaseApproveProxy(_StarBase_APPROVE_PROXY_).claimTokens` call. However, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Incorrect natspec for `setLimit()`
### Description
The comments seem outdated as the only parameter that is updated by the function is the maximum collateral that can be concurrently auctioned off.
```solidity
/// - the auction duration to calculate liquidation prices
/// - the proportion of the collateral ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: Shorthand way to write if / else statement
### Description
The normal if / else statement can be refactored in a shorthand way to write it:
Increases readability
Shortens the overall SLOC
[OffchainDNSResolver.sol#L216-L220](https://github.com/code-423n4/2023-04-ens/blob/45ea10bacb2a398e14d711fe28d1738271cd7... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: Shorten the array rather than copying to a new one
### Description
Inline-assembly can be used to shorten the array by changing the length slot, so that the entries don't have to be copied to a new, shorter array
*There is 1 instance of this issue:*
https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use indexed events for value types as they are less costly compared to non-indexed ones
### Description
### Relevant GitHub Links
https://github.com/Cyfrin/2023-07-beedle/tree/main/src/Lender.sol#L13
https://github.com/Cyfrin/2023-07-beedle/tree/main/src/Lender.sol#L14-L17
https://github.com/Cyfrin/2023-07-b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [03] `PanopticPool::_checkSolvencyAtTicks` incorrect code comments
### Description
The code implementation is as follows: if there are multiple `atTicks[]` passed in as parameter:
- For `expectedSolvent == true`, all ticks must be solvent
- For `expectedSolvent == false`, all ticks must be insolvent
However,... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | true | false | ## Low: Synchronous function calls inside asynchronous functions
### Description
In multiple locations in the tree-builder component, synchronous functions are called inside asynchronous functions; for example, the synchronous `fs.writeFileSync` function is called inside the asynchronous `createKeyPairs` function (Fig... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Lack of restriction on `BasketManager`'s `execute`
### Description
Currently, the `execute` function can call arbitrary addresses and perform arbitrary operations, including transferring assets held within `BasketManager` and registered in the `assetRegistry`, which is a restricted operation under `rescue`. Co... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Increase test coverage
### Description
Test coverage is fairly limited.
LPStaking tests only cover the happy path.
StakeLPCoreV8 has no tests.
Many test descriptions are inaccurate.
### Recommendation
Comment from pSTAKE Finance team:
>
> Created deep-dive test for each unique scenarios locally and test... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Incorrect signature can lead to incorrect call
### Description
In the following function, if signature is incorrect and maker is a user, then this function would revert because of static call for user:
https://github.com/1inch/limit-order-protocol/tree/a14bde6a260458de5083cee117d734221e1cbc05/contracts/Limi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: Function getPoints() allows overbuying
### Description
The `getPoints()` function does not ensure the amount of USDC taken from the users is equal to the value of IPT given from the contract. This can occur if the balance of IPT in the SlowRoll contract is less than `_maxQuantity` at the final wave. It is v... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The default Governor Anastasius is unable to call `resetStakes`
### Description
The `StRSR` contract contains a function [`resetStakes`](https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol#L490), which is used to reset the staking of a specific RToken system, when the stake rate b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: DAO membership fees cannot be retrieved by the creator
### Description
**Description:** The DAO membership fee taken from users who invoke [`MembershipFactory::joinDAO`](https://github.com/OneWpOrg/audit-2024-10-oneworld/blob/416630e46ea6f0e9bd9bdd0aea6a48119d0b515a/contracts/dao/MembershipFactory.sol#L120-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use Two-Step Ownership Transfer
### Description
To enhance the security and flexibility of ownership transfer in your smart contracts, it is recommended to use a two-step ownership transfer process. This approach allows for a more controlled transfer of ownership, reducing the risk of unintended consequences o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Deadline is set to block.timestamp
### Description
In the `swapExactTokensForNative` function, when calling the router to swap tokens for ETH, the deadline parameter is set to block.timestamp. This means the deadline is set to the current block timestamp when the transaction is included by the validator, not w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: `call()` should be used instead of `transfer()` on an address payable
### Description
Source: https://github.com/sherlock-audit/2022-11-dodo-judging/issues/5
## Found by
ak1, Nyx, sach1r0, pashov, 0xNazgul, yixxas, 0x4non, virtualfact, Bnke0x0, Tomo, rvierdiiev, 8olidity, ElKu, defsec
## Summary
## Vul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Use `abi.encode` to convert safest way from uint values to bytes
### Description
### DRAWBACKS
Now the protocol uses direct conversion way this is not safe. bytes(value) to convert a uint to bytes is not considered a safe way because it creates an uninitialized byte array of length. This means that the content... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | false | false | ## High: Not following good Smart Contract development practices
### Description
The [ArroToken project](https://github.com/pjsimpkins/ArroERC20Code/commit/1ca1cc85f2e7e046070c187031b75b3335ef57c3) lacks of a standard Solidity project structure. There are no unit tests and integration tests implemented, and there is n... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: User balances partially non-withdrawable after `LOT_SIZE_UNITS` changes
### Description
The protocol allows the contract owner to dynamically update `LOT_SIZE_UNITS` using `setTradingParameters`, with the stated goal of keeping trading accessible as prices increase.
However, **all share-changing operations... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Vault transactions are not time-limited.
### Description
**Description**
Vault.sol
Usually, transactions in multi-sig contracts have a deadline, after which the transaction can't be executed. This is done to mitigate the situation when a part of owners iscompromised. For Vault.sol, such an issue is marked as ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Duplicated functions
### Description
Some functions in the codebase are duplicated (i.e.: they contain the same code logic), which could make it harder to apply future changes in the common logic of the functions and can even introduce potential bugs. The affected functions are the following:
* `DataStore.app... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: There is no check in `AlgebraEternalFarming._isIncentiveActive()` that the plugin is still connected to the pool
### Description
https://github.com/cryptoalgebra/Algebra/blob/6f57b3e218630106a4d41aedefd38f9e83b41e2b/src/farming/contracts/farmings/AlgebraEternalFarming.sol#L349
A plugin with some incentive conn... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | false | false | ## Gas: Unchecked arithmetic
### Description
The default "checked" behavior costs more gas when adding/diving/multiplying, because under-the-hood those checks are implemented as a series of opcodes that, prior to performing the actual arithmetic, check for under/overflow and revert if it is detected.
If it can static... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Proxy deployment using create2 does not revert upon failure
### Description
The [`deployProxyWithNonce` function](https://github.com/AugurProject/augur/blob/67c0fec95e65fca8d27751f28a6c06e5247978c6/packages/augur-core/source/contracts/ProxyFactory.sol#L80) of the `ProxyFactory` contract does not revert the tra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Use a more recent version of Solidity
### Description
Use a Solidity version of at least 0.8.10 to have `external` calls skip contract existence checks if the external call has a return value.
Use a Solidity version of at least 0.8.12 to get `string.concat()` to be used instead of `abi.encodePacked(,)`.
Use ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Error Propagation
### Description
The codebase uses an error propagation mechanism that works as follows:
* A function that is supposed to return value `X`, instead returns a tuple `(NO_ERROR, X)`
* A function that would normally error out instead returns a tuple `(ERROR_NAME, 0)`
* Note that in both case... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | signature | true | false | ## Low: Use `EIP712Upgradeable` library to simplify `DocumentManager`
### Description
Use [`EIP712Upgradeable`](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/contracts/utils/cryptography/EIP712Upgradeable.sol) library to simplify `DocumentManager` as this library provides the domain se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Unnecessary unchecked block
### Description
The unchecked block is unnecessary since no operator within it has overflow checks.
### Recommendation
Do not use an unchecked block here. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [04] Interchain token servicing lacks any cancellation/deadlining logic
### Description
When a transfer is to be made interchain. The current logic is simple to follow:
- User specifies their transfer to the destination chain from the source chain.
- On the destination chain, the transfer gets processed to th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: State variables can be packed into fewer storage slots
### Description
If variables occupying the same slot are both written the same function or by the constructor, avoids a separate Gsset (**20000 gas**). Reads of the variables can also be cheaper
*There is 1 instance of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: `LidoEthStrategy._currentBalance` is subject to price manipulation, allows overborrowing and liquidations
### Description
The strategy is pricing stETH as ETH by asking the pool for it's return value
This is easily manipulatable by performing a swap big enough
### POC
* Imbalance the Pool to overvalue th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Method removeTradingContract(...) needs to check if the trading contract is added or not
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In TradingStorage contract, `removeTradingContract(address _trading)` does not check if _trading contract is added or not before flagging ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Validators Can Submit Multiple Attestations to Maliciously Force Wrong Consensus
### Description
**File(s) affected:**`DataMarket.sol`
**Description:** The function `submitBatchAttestation()` allows a validator to vote on a given batchCid while providing a `finalizedCidsRootHash`. However, it does not guard ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Rounding error allows liquidity to be added without depositing tokens
### Description
In pools that have an asset token of six decimals, small allocations of those tokens will be scaled by the number of decimals and then rounded down. A `deltaAsset` value of 0 can be returned by the `getLiquidityDeltas` funct... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: 10] Fund creation DoS by front-running factory call
### Description
**Severity:** Medium
**Path:** FundFactory.sol:createFund#L47-L49
**Description:** The FundFactory exposes the `createFund` function, which uses a beacon proxy and `CREATE2` to deploy a new UFarmFund contract. This function is called from... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `keccak256()` should only need to be called on a specific string literal once
### Description
It should be saved to an immutable variable, and the variable used instead. If the hash is being used as a part of a function selector, the cast to `bytes4` should also only be done once
https://github.com/code-423n4... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | true | false | ## High: Token Bridging doesn't work with Wormhole fees
### Description
Line
- https://github.com/certusone/wormhole/blob/9bc408ca1912e7000c5c2085215be9d44713028b/ethereum/contracts/bridge/Bridge.sol#L93
has a `transferTokens ()` function of type `payable`. In the body of this function, on line 133, a call to the int... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Use of TLS1.2
### Description
TLS 1.2 is still secure but lacks some security enhancements and optimizations of TLS 1.3, including better encryption methods, forward secrecy, and reduced latency.
### Recommendation
Upgrade to TLS 1.3 to benefit from stronger encryption, forward secrecy, and reduced handshake ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | high | Don't update state | true | true | ## Lines of code
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/GiantPoolBase.sol#L50-L64
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/GiantMevAndFeesPool.sol#L180-L193
... | Code4rena | 5 | Stakehouse Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Messages Are Not Guaranteed to Be Unique for Each Operation
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `659b9990b87bc8b14fe382d752908236874a00d4`.
**File(s) affected:**`rell/src/lib/ft4/core/auth/module.rell`
**Description:**`generate_operation_auth_message()` generates a messa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: Borrowers can DoS liquidations by repaying as little as 1 share.
### Description
Liquidations can be DoSed which increments the risk of bad debt being generated on position.
### Proof of Concept
When a liquidator is liquidating a position in `WiseLending`, the liquidator needs to specify the amount of sha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: TRST-L-8 Admin can set plugin fee to 100%
### Description
**Description:**
The admin can set Mozaic's cut from strategy earnings through setFee(), up to 100%. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `resolveId` will return the 0 ID even if an address does not have an account
### Description
This is error prone and requires all clients of the `resolveId` function to do checks for `!= 0`, as we can see in `NodeRegistry` where this method is called. A better and safer approach is to just revert in the `resol... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | false | false | ## Medium: `maxSumOfPrices` check is broken
### Description
_Submitted by [0xRajeev](https://twitter.com/0xRajeev)_
`rentAllCards()` requires the sender to specify a `_maxSumOfPrices` parameter which specifies “limit to the sum of the bids to place” as specified in the Natspec @param comment. This is apparently for f... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Unnecessary Initialization of Variables to Zero in Solidity
### Description
**Severity**: Informational
**Status** - Resolved
**Location**: MPROMasterDistributor Line 133
**Summary**:
In Solidity, variables are initialized to their default values automatically, with uint256 types defaulting to 0. Explici... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Dirty bytes in _loc and_len can override other values when packing a typed memory view in unsafeBuildUnchecked
### Description
For a `TypedMemView`, the location and the length are supposed to occupy 12 bytes (`uint96`), but the type used for these values for the input parameters for `unsafeBuildUnchecked` is ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Quorum votes have no effect for determining whether proposal is defeated or succeeded when token supply is low
### Description
_Submitted by rbserver, also found by cccz, dipp, joestakey, pashov, and R2_
At the early stage of the deployed DAO, it is possible that the following `quorum` function returns 0 b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: A bit more costly calculation chosen despite availability of alternative
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
VodkaVaultV2.sol - At line 674 , a bit costly and repeated computation is being carried out.
It is worth noting though that the computation has already b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: Extra inheritance
### Description
The `OrderMixin` contract inherits the `NonceManager` contract, and the `PredicateHelper` contract inherits the `NonceManager` contract. You can remove the `NonceManager` contract from the `OrderMixin` inheritance chain because the `OrderMixin` contract inherits `PredicateHelp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Unhandled return values of transfer and transferFrom ✓ Fixed
### Description
#### Resolution
The issue was fixed by using OpenZeppelin’s `safeTransfer` and `safeTransferFrom` wrappers.
ERC20 implementations are not always consistent. Some implementations of `transfer` and `transferFrom` could return ‘fa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Prefer Solidity Custom Errors over `require` statements with strings
### Description
Using Solidity Custom Errors has the benefits of less gas spent in reverted transactions, better interoperability of the protocol as clients of it can catch the errors easily on-chain, as well as you can give descriptive names... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | false | false | ## High: User Funds Burned With No ETH Returned Due to Missing withdrawalRequests[msg.sender]Assignment After Unstake
### Description
The unstaking process is executed in two steps:
The user initiates unstake().
If currentWithheldETH is insufficient, the contract attempts to unstake from the Plume validator.
However, ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [G‑05] Using `storage` instead of `memory` for structs/arrays saves gas
### Description
When fetching data from a storage location, assigning the data to a `memory` variable causes all fields of the struct/array to be read from storage, which incurs a Gcoldsload (**2100 gas**) for *each* field of the struct/a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Business Logic | true | false | ## Token Gated Drop Vulnerability Analysis
## Severity: Medium Risk
**Context:** `SeaDrop.sol#L345`
### Description
There are scenarios where an actor with only 1 token from an allowed NFT can drain Token Gated Drops that are happening simultaneously or back to back.
#### Scenario 1 - Self-Registration of ERC721Sea... | Spearbit | 5 | SeaDrop |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | ERC721 | true | true |
[HolographERC721.sol#L366](https://github.com/code-423n4/2022-10-holograph/blob/24bc4d8dfeb6e4328d2c6291d20553b1d3eff00b/src/enforcer/HolographERC721.sol#L366)<br>
According to EIP-721, we have the following for `safeTransferFrom`:
```solidity
/// (...) When transfer is complete, this function
/// checks if `_to` ... | Code4rena | 4 | Holograph |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Data feeds may be outdated
### Description
[Chainlink's documentation](https://docs.chain.link/data-feeds/#monitoring-data-feeds) recommends validating that prices returned by their feeds are recent and fall within reasonable bounds. The `price` function of the [`OracleRouterBase`](https://github.com/Origin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Unlock: free UDT arbitrage opportunity
### Description
_Submitted by itsmeSTYJ_
Uniswap v2 made oracle attacks much more expensive to execute (since it needs to be manipulated over X number of blocks) however its biggest drawback is that it reacts slow to price volatility (depends on how far back you look)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | true | false | ## Medium: Logic issue on vault removal
### Description
There's a logic issue on `removeVault` on `VaultRegistry.sol`. If the admin of vault manager chooses a wrong address vault and a correct vault ID to be removed (`removeVault(address vault_, bytes32 vaultId_)`), will be removed the wrong ones. This issue could lea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Refactor `inState` modifier for high gas savings
### Description
Instead of housing the logic in a modifier, moving it into an internal function, and making a call to that function inside the modifier, can save a lot of gas.
### Impact
Gas
### Recommendation
Use the `inState` modifier in conjunction with an ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | other | true | false | ## Medium: Inconsistent stake calculation due to mutable `vaultManager` reference in `AvalancheL1Middleware` | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | cross-chain | true | false | ## Gas: Counting down in `for` statements is more gas efficient
### Description
Counting down is more gas efficient than counting up because neither we are making zero variable to non-zero variable and also we will get gas refund in the last transaction when making non-zero to zero variable.
### Proof Of Concept
ht... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: Misleading comment in `setOutbox()` function
### Description
The current comment indicates that the function is adding a contract authorized to put messages into the rollup's inbox, but the function itself is setting an outbox contract and registering it with the bridge, rather than directly dealing with the i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Validators may fail to be uninstalled
### Description
In smart account, validator, as one module, can be installed or uninstalled. If there is something wrong in the validator, we have to uninstall this validator.
In the function `uninstallModule`, we will trigger `onUninstall` function to notify the validato... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | logic-error | false | false | ## Low: Fee-on-transfer tokens are not supported in spice auction
### Description
Fee-on-transfer tokens are not supported in spice auction contract, which might result in incorrect calculation in auction tokens.
### Recommendation
Use pre/post balance difference to calculate actually moved bid token amount. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Using `private` rather than `public` for constants, saves gas
### Description
When you declare a constant variable as `public`, Solidity generates a getter function that allows anyone to read the value of the constant. This getter function can consume gas, especially if the constant is read frequently or the c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | flash-loan | true | false | ## Low: [04] Lack of view function for user to query if the `flashloan` can be used
### Description
It is recommended to implement and adopt [https://eips.ethereum.org/EIPS/eip-3156] where there are views function for external user to call to query if the flashloan can be used: | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: It's impossible for a user to claim his rewards, as `claimReward` will never send out `USDC`
### Description
**Impact:**
High, because users will never receive rewards from the contract
**Likelihood:**
High, because the code just uses the ERC20 API incorrectly
**Description**
The `claimReward` method shoul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Optimization.
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
dpnm_sc.sol - In the depositBonus
Values of the treeuserlevelslock mapping are all booleans. So there is no need to compare with true or false. It will cause more gas consumption.
if(treeuserlevelslock[userAdd... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: MEV bots will steal from users due to an incorrectly manipulated value
### Description
MEV bots will steal from users due to an incorrectly manipulated value
### Impact
Theft of funds from innocent users who have done nothing wrong
### Recommendation
Do not manipulate the value for users who provided a sp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Additional Safety Checks
### Description
## Liquidity Pool Improvements
## 1. Validation Step in `pool::deposit_liquidity`
Add a validation step in `pool::deposit_liquidity` to check whether the minted LP tokens (`lp_coins`) are at least equal to `MINIMUM_LIQUIDITY` if this is the first deposit into the pool... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: Centralization risks
### Description
The smart contract system of the bridge exhibits significant centralization and lack of trustlessness. The owner has the authority to change the implementation of both the `FireBridge` and `FToken` contracts.
Minting of FBTC on the EVM chains, cross-chain EVM transfers... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Merkle leaves are the same length as the parents that are hashed
### Description
_Submitted by AuditsAreUS_
### Impact
The size of a `leaf` is the same size of the parent data that is hashed, both are 64 bytes. As a result it is possible to have a hash collision between a leaf and any node in the tree. T... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Use constants instead of type(uintx).max
### Description
type(uint120).max or type(uint112).max, etc. it uses more gas in the distribution process and also for each transaction than constant usage.
3 results - 2 files:
[EntryPoint.sol#L397](https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Emergency Withdraw in veRAACToken Breaks Governance Security
### Description
Governance proposals can be created, voted, and executed during an emergency withdrawal period in veRAACToken, allowing manipulation of voting decisions when voting power calculations are unreliable.
### Impact
Governance can be m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Architecture-dependent code
### Description
In the Go programming language, the bit size of an `int` variable depends on the platform on which the code is executed. On a 32-bit platform, it will be 32 bits, and on a 64-bit platform, 64 bits. Validators running on different architectures will therefore interpre... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | high | reentrancy | true | true | ## High: Reward distribution can be blocked by an initial distribution of long duration
### Description
Given that distribution of rewards is permissionless, anyone can distribute any arbitrary amount of tokens with a duration greater than 1 week. If there is an existing distribution active for a given token and addit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: Potential front-running grief attack on unleashThisMeme()
### Description
When a new meme token is unleashed, the contract ensures that no pre-existing Uniswap V3 pool with the given token pair exists, expecting the returned pool address to be zero before creation. If an attacker anticipates the token address ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Adversary can prevent updating price feed addresses by creating poisonous proposals ending in `_confirm`
### Description
An adversary can prevent the creation of `setContract` and `websiteUpdate` proposals by creating a poisonous proposal with the same ballot name + `_confirm`. This attack can be performed ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Production Builds Allow Development and Localhost Origins; Snap Does Not Enforce Transport Security Partially Addressed
### Description
The snaps RPC access is restricted to certain origins only. However, there is no logic that disables development/test domains from origin checks in production builds.
Th... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Missing deadline parameter in _performLiquidation
### Description
**Severity:** Medium
**Path:** src/liquidation/LiquidationRow.sol::_performLiquidation()#L292-L369
**Description:**
The `_performLiquidation()` function in the `LiquidationRow.sol` contract uses a price margin (`priceMarginBps`) to ensure ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Rough BASIS_FRACTION
### Description
At the line https://github.com/nucypher/nucypher/blob/main/nucypher/blockchain/eth/sol/source/contracts/staking_contracts/PoolingStakingContractV2.sol#L37
`BASIS_FRACTION = 100` is too rough.
### Recommendation
It would be better to set it to 10000 or even more to increase... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: 11. INCORRECT INDEX SIZE IN VERIFYMERKLEPROOF
### Description
**Severity:** Informational
**Path:** DepositContract.sol:L90-L112
**Description:**
In the contract DepositContract.sol
The index is of size uint64, and as the merkle tree levels are 32, the most significant bits of the index can be manipulated... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Unrevoked approvals causing swap failures in `UniswapV3Swapper.swap()`
### Description
The `UniswapV3Swapper.swap()` function has an issue where it does not revoke tokens approvals from the router after the swap, leading to a potential DoS with tokens like `USDT`, where this issue arises due to the fact tha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: `<array>.length` should not be looked up in every loop of a `for`-loop
### Description
The overheads outlined below are _PER LOOP_, excluding the first loop
* storage arrays incur a Gwarmaccess (**100 gas**)
* memory arrays use `MLOAD` (**3 gas**)
* calldata arrays use `CALLDATALOAD` (**3 gas**)
Caching the l... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Unnecessary variables in `LibMap.sol`
### Description
**Function `get`:**
Variables `mapValue` and `bitOffset` are used only once, which means they don't need to be declared at all. The code snippet below can be changed from:
[File: ethereum/contracts/zksync/libraries/LibMap.sol](https://github.com/code-423n... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Include return parameters in NatSpec comments
### Description
`@return` tag is missing.
[ProfilePicture.sol#L67-L70](https://github.com/code-423n4/2023-03-canto-identity/blob/077372297fc419ea7688ab62cc3fd4e8f4e24e66/canto-pfp-protocol/src/ProfilePicture.sol#L67-L70)
[Bio.sol#L40-L43](https://github.com/code-... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Inability to Withdraw ETH/tokens in BorrowLiquidation Contract if `closeThePositionInSynthetix` is Called
### Description
The `BorrowLiquidation` contract lacks the ability to withdraw ETH/native tokens or other tokens received from closing positions in Synthetix, potentially locking these assets within the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | overflow | true | false | ## High: `userTotalStaked` invariant will be broken due to vulnerable implementations in `release()`
### Description
`userTotalStaked` invariant will be broken due to vulnerable implementations in `release()`. Users might lose funds due to underflow errors in withdraw methods.
### Proof of Concept
According to the [... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: persistedData Race Where snap_manageState.get Returnsnull ✓ Fixed
### Description
Metamask Error:
```
Oops! Something went wrong.
Snap Error: 'Cannot read properties of null (reading 'addresses')'. Error Code: '-32603'
```
`snap.request(, {method: 'snap_manageState', params: {operation: 'get'}})` may retur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: `consolidatePendingStake()` should be public
### Description
### Relevant GitHub Links
https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L119
### by [CarlosAlegreUr](https://github.com/CarlosAlegreUr)
### **`consolidatePendingStake()` should be public** 🔢
## **Summary ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | dos | true | true | ## Medium: DoS on stake accounting functions by bloating `operatorNodesArray` with irremovable nodes
### Description
When an operator removes a node the intended flow is:
1. `removeNode()` (middleware)
2. `calcAndCacheNodeStakeForAllOperators()` (called immediately or by the `updateGlobalNodeStakeOncePerEpoch` modifi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Unbounded Gas In Queries
### Description
## EVM Gas Limit Considerations
By setting `seiGasRemaining` to `math.MaxUint64` when the gas limit is zero or negative, `callEVM` essentially allows for unbounded contract execution during EVM static calls. This implies that contracts invoked via external queries m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: TODO Left in the code
### Description
Several open TODO comments are identified in the contracts, indicating that their development is not finished.
```
./NglToken/BridgeRouter.sol:50: /// @dev Calculates the bridge fee (TODO).
./NglToken/BridgeRouter.sol:52: // TODO:
./test/SynthFactoryMock.sol:32: // TOD... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: amountOut Not Converted to shares
### Description
The function `swap()` swaps `amountIn` of `tokenIn` to `amountOut` of `tokenOut`. To calculate `amountIn`, this function deducts the current balances (`balance0` and `balance1`) with the previous recorded balances (stored in variable `reserve0` and `reserve1`)... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The `withdraw` method in `Router.sol` should not be payable
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
The `withdraw` method in `Router.sol` is payable which means callers can provide ETH with their function call. However, there is no reason for this method to be p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Trusted/Oracle-Nodes can vote multiple times for different outcomes
### Description
Trusted/oracle nodes submit various ETH2 observations to the RocketPool contracts. When 51% of nodes submitted the same observation, the result is stored in the contract. However, while it is recorded that a node already vot... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Inconsistent shares upgrade
### Description
After shares update in the NFT contract https://github.com/FantiumAG/smart-contracts/blob/c622b4c35132167bacc22cf76656d80715edb5fd/contracts/FantiumNFTV3.sol#L638-L640 `tournamentDistributionAmount` and `otherDistributionAmount` should be updated for all distributio... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | oracle | true | false | ## Gas: State variables can be cached instead of re-reading them from storage
### Description
Caching of a state variable replaces each `Gwarmaccess (100 gas)` with a much cheaper stack read.
https://github.com/code-423n4/2023-04-ens/blob/main/contracts/dnssec-oracle/DNSSECImpl.sol#L415-L425
*Gas Savings for `DNSReg... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: `boreWell` can be frontrun/DoS-d
### Description
The `boreWell` function in the Aquifer contract is responsible for creating new Wells. However, there are two critical security issues:
1. **Stealing of user's deposit amount**: The public readability of the `salt` parameter allows an attacker to frontrun a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | true | ## Low: Return value of call is not checked causing failed transactions to go through
### Description
Report type: Smart Contract
Target: https://etherscan.io/address/0x3C28B7c7Ba1A1f55c9Ce66b263B33B204f2126eA#code
Impacts:
- Failed transactions continue execution without reverting
## Description
## Brief/Intro
Th... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.