prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Cache `amount` variable should be used within loop to save gas
### Description
The `amount` variable is assigned within `IncentiveManager::notifyRemoveLiquidty` to avoid repeated typecasting; however, it is not currently used within the loop.
### Recommendation
```diff
function notifyRemoveLiquidty(PoolId... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | access-control | true | false | ## Gas: Cache state variables outside of loop to avoid reading/writing storage on every iteration
### Description
Reading from storage should always try to be avoided within loops. In the following instances, we are able to cache state variables outside of the loop to save a `Gwarmaccess (100 gas)` per loop iteration.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | true | false | ## Medium: Attacker can inflate share price and cause loss for users
### Description
**Severity**
**Impact:** High
**Likelihood:** Low
**Description**
When the share amount is calculated and `totalSupply` is zero, the code uses the deposit amount and doesn't add extra precision, this will give the attacker the abi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: INSTR, Governance: upon module's upgrade, all instruction data should be carried over to the new modules
### Description
*
*
The `Governance`'s logic will break if the `INSTR` module is upgraded to a new contract without having the same instructions data, since the `proposalId`'s the `Governance` is usin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | Min/Max Cap Validation | false | true | _Submitted by 0x52_
[TopUpAction.sol#L154](https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/actions/topup/TopUpAction.sol#L154)<br>
[TopUpAction.sol#L187](https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/a... | Code4rena | 4 | Backd |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | true | true | ## High: Potential Flashloan Attacks on sanRate
### Description
The function `_updateSanRate()` is used to distribute any fees or interest payments to the current holders of SanTokens. This is done by increasing the `sanRate`, which will be multiplied against a user’s token balance to determine the amount of collatera... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Interest rates can be raised above the market as a griefing, disabling the pool
### Description
Interest rates algorithm is based on `MAU` to `TAU` dynamics, where TAU is 3.5 day EMA of total debt to LUP * total collateral. The latter value can be manipulated by a big collateral holder by becoming a borrowe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | cross-chain | false | false | ## Gas: Remove redundant modifiers from `TokenBridge::bridgeTokenWithPermit`
### Description
**Description:** Since `TokenBridge::bridgeTokenWithPermit` calls `bridgeToken`, it doesn't need to repeat the same modifiers that `bridgeToken` contains; this just incurs additional gas costs.
The only benefit to the redunda... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | true | false | ## Low: PR 273 introduces multiple issues
### Description
The Yearn Finance team asked Trail of Bits to review changes introduced in pull request 273. We uncovered several issues in our review.
The first issue involves the locked profit calculation, which occurred after the lastReport timestamp was updated to the cur... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Casting Risk in Premia Values
### Description
Values packed into the right and left slots of `legPremia` (type `int256`) are unsigned 128-bit integers. Those values will be cast to `int128` when written and then subsequently read as `int128`. If the original unsigned values have a non-zero most-significant bit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | token | true | false | ## Low: Consider adding share-based sell function to avoid dust shares
### Description
The current interface requires users to specify the desired amount out (tokens) when selling shares, rather than the amount in (shares to sell). This makes it difficult for users or integrators to accurately sell all their shares, e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: MainToken.set_mint_multisig() doesn’t check that _minting_multisig doesn’t equal zero
### Description
## Handle
pants
## Vulnerability details
The function `MainToken.set_mint_multisig()` doesn't check that `_minting_multisig` doesn't equal zero before it sets it as the new `minting_multisig`.
## Impac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Can’t enableCollateral after a disableCollateral
### Description
## Handle
gpersoon
## Vulnerability details
## Impact
The function disableCollateral of OverlayV1Mothership.sol doesn't set collateralActive[_collateral] = false;
But it does revoke the roles.
Now enableCollateral can never be used becau... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Position Manager providing the wrong strike when storing user's position data
### Description
When users mint position using `PositionManager`, users can provide strike that want to be used for the trade. However, if the provided strike data is not exactly the same with IG's current strike, the minted posit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [13] Common setup code in tests can be extracted to a base class
### Description
Currently, there is a lot of duplicated setup code and variables in the tests. See the setup of:
- `AiArenaHelper.t.sol`
- `FighterFarm.t.sol`
- `MergingPool.t.sol`
- `RankedBattle.t.sol`
- `StakeAtRisk.t.sol`
- `VoltageManager.t.... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | true | false | ## Medium: Chainlink's Oracle Might Return Stale or Incorrect Data
### Description
The `USDzPriceOracle` and `SPCTPriceOracle` contracts use Chainlink as their price oracle. When requesting the price via the `getPrice()` function, the contracts query Chainlink for the underlying token price using the `latestRoundData(... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Missing Event Emissions in Setter Functions
### Description
**Severity**: Low
**Status**: Resolved
**Description**
Several setter functions in the contract update critical state variables without emitting corresponding events. Event emissions in setter functions provide an essential audit trail on the block... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | false | false | ## Low: emiting `EthReceived` event when `RollupRevenueVault` receives 0 eth
### Description
[`RollupRevenueVault::receive`](https://github.com/Consensys/linea-monorepo/blob/8285efababe0689aec5f0a21a28212d9d22df22e/contracts/src/operational/RollupRevenueVault.sol#L292-L294) && [`RollupRevenueVault:fallback`](https://g... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | signature | false | false | ## High: Approved proposal may be impossible to queue, cancel or execute
### Description
The [`propose` function](https://github.com/compound-finance/compound-protocol-alpha/blob/6858417c91921208c0b3ff342b11065c09665b1b/contracts/Governance/GovernorAlpha.sol#L150) of the `GovernorAlpha` contract allows proposers to su... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: If a winner is blacklisted on any of the tokens they can't receive their funds
### Description
Normally this would be a big issue since transfers are done in a loop to all winners _i.e all winners wouldn't be able to get their tokens_, but winners are chosen off chain and from [the Q&A section of SparkN onboar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Missing signature validation in `Order` structure
### Description
In the `Signing` contract, the `Order` structure includes the fields `baseTokenData.toRecipient` and `quoteTokenData.toTrader`. These fields are currently ignored in the signature verification process. They are not included in the data that i... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: `_execBuyNftFromMarket()` Need to determine if NFT can't already be in the contract
### Description
Use other Lien's NFTs for repayment
### Proof of Concept
`_execBuyNftFromMarket()` Whether the NFT is in the current contract after the buy, to represent the successful purchase of NFT.
But before executing... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Outdated Chainlink Interface
### Description
In [line 201 of `ChainlinkOracle`](https://github.com/VenusProtocol/oracle/blob/78b1a411c42e5c103e688e4e76bc69c476206833/contracts/oracles/ChainlinkOracle.sol#L201), the interface `AggregatorV2V3Interface` is used, which inherits from both the `AggregatorInterface` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Fees wrongly given to current voters for past distributions
### Description
_Acknowledged_
In the `Voter` contract, the `_claimAndDistributeAlgebraPoolFees()` function is used to:
1. Collect community fees from the Algebra pool via `AlgebraCommunityVault.collectFees()`.
2. Forward these fees to the `VotingRe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Unused modifier
### Description
`CoverPool`'s modifier `onlyGov` defined at line https://github.com/CoverProtocol/cover-core-v2/blob/513f5e502a8e8a623729c2c3480fca4e80fdef39/contracts/CoverPool.sol#L67 is never used within the contract. In the same time there are methods having requires just within the meth... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: treasuryShare is Overwritten in FeePoolV0._shareMochi()
### Description
## Handle
leastwood
## Vulnerability details
## Impact
The `FeePoolV0.sol` contract accrues fees upon the liquidation of undercollaterised positions. These fees are split between treasury and `vMochi` contracts. However, when `distri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: No upgradeability pattern used despite indicators.
### Description
**Description**
In contracts LzApp.sol and NonnlockingLzApp.sol you are leaving an empty reserved space, for possible future upgrades and also using the OwnableUpgradeable and Initializer contracts. However, there's no upgradability mechanism ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: `createProposal` snapshot block can temporarily desync with `minApproval` / `minVotingPower`
### Description
minApproval and member list will be temporarily out of sync, potentially causing approval issues.
### Proof of Concept
[Multisig.sol#L214-L245](https://github.com/code-423n4/2023-03-aragon/blob/4db... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Errors and omissions in events
### Description
Throughout the codebase, events are used to signify when changes are made to the contracts. However, many events lack indexed parameters or are missing important parameters. Some sensitive actions are lacking events altogether.
Events lacking indexed paramete... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing 0 Address Check for `changeKYCApprover`
### Description
**Description**
When assigning the kyc approver via changeKYCApprover it should be checked that the newKYCApprover is not the 0-address, if set to 0 address then purchases won't be allowed.
**Recommendation**
Introduce a address check on the fu... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | false | false | ## High: A borrower can borrow SOL without backing it by a collateral
### Description
The borrower can borrow SOL from the lender without backing it by a collateral. This is possible because the borrower can open two positions at the same time (same TX) but link both `addCollateral` to one position. Although `borrow` ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: `path` length not checked
### Description
`path` length is not checked:
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d417158a/contracts/credit/LeverageActions.sol#L107
https://github.com/Gearbox-protocol/gearbox-contracts/blob/0ac33ba87212ce056ac6b6357ad74161d41... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Eject Functionality May Harm Interacting Contracts
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `368371f68489ad6d7c2835bcaac89134bf7ec559`.
The client provided the following explanation:
Quantstamp notes that the TokenLocker has an eject function that allows anyone to force a use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect Pool Id
### Description
**Severity**: Low
**Status**: Resolved
**Description**
In Contract GlmManager.sol, the method `getPoolIdByMarketToken(...)` will return 0 by default if no matching pool with the given Market token is found.
Since index 0 corresponds to the ETH pool, this will lead to unexp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | true | ## Low: Transaction failure encountered during spam withdrawals
### Description
A smart contract named `SpamWithdrawals` was created to test the behavior of the withdrawal pre-compile function when making a large number of small native token transfers.
```solidity
contract SpamWithdrawals {
function doWithdrawals()... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | true | false | ## Medium: A vector in the liquidity-proxy’s swap extrinsic can be used for network spamming
### Description
There are insufficient limits on `selected_source_types`, which is a vector in the liquidity-proxy pallet's swap extrinsic. Specifically, the vector can contain duplicate entries, and there is no check preventi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | logic | true | false | ## Low: Incorrect templeGold minting due to unresolved accumulation in `TempleGold::setVestingFactor`
### Description
`templeGold` is minted at a rate strictly following the `VestingFactor`. However, when the operators call `TempleGold::setVestingFactor` to modify the `VestingFactor`, the tokens accumulated based on t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Code Redundancy
### Description
## Findings and Recommendations
1. The `max_validators` value is currently stored in both the `Config` and `Candidates`. However, only the value of `max_validators` from `Candidates` is utilized. Therefore, the `max_validators` value in `Config` may be removed to reduce redunda... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Stream sender is unable to cancel a stream with a pausable asset that is paused
### Description
When the stream sender cancels a stream, we call the asset transfer method to reimburse the amount that is yet to be streamed to the sender. If this call reverts, then the call to cancel the stream reverts as well.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: GoUnusedExportedType
### Description
**Severity**: Low
**Status**: Acknowledged
**Description:**
Some exported types are not used within the codebase
**Files**:
x/wasm/keeper/genesis_test.go: 685
x/wasm/keeper/staking_test.go: 76
**Recommendation**:
Consider removing these types if they are not part ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Inline all these little functions
### Description
Defining all these little functions cause 2 things:
1. contract's code size gets bigger
2. the function calls consumes more gas than exectuing it as an inlined function (part of the code, without the function call)
So in order to save gas, I would recommend... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Draining the protocol fully
### Description
* Attacker deposits a large collateral, and creates an order with large size delta. Later, it fills.
* Then, the attacker creates second order, and later it fills.
* The second order will increase the mark price, so the old position will gain large unrealized profit... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Halving interval is 7 days contrary to the documentation of 24 months
### Description
The halving interval is set to **7 days**, which is contrary to the documentation of **24 months**.
- **DCT.sol#L14**:
```solidity
uint constant public HALVING_INTERVAL = 7 days;
```
The documentation states it sho... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: THE IMMUTABLE KEYWORD COSTS LESS GAS FOR CONSTANT VARIABLES
### Description
The `_name` and `_symbol` variables in the `GammaPoolERC721` contract were designed to be set only once. The `immutable` keyword consumes less gas. It might be useful to declare these variables as `immutable` to optimize gas usage in t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Incorrect Implementation of pow_u32 Exponentiation for Even Exponent
### Description
In [`algebraic_torus.rs`](https://github.com/matter-labs/zksync-crypto/blob/feature/ec_precompiles/crates/boojum/src/gadgets/tower_extension/algebraic_torus.rs#L187), the `pow_u32>(&mut self, cs: &mut CS, exponent: S)` functi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: `LiquidationKeeper::checkUpkeep` should only continue processing if lower bounds are smaller than upper bounds
### Description
`LiquidationKeeper::checkUpkeep` should only continue processing if `checkLowerBound < checkUpperBound || performLowerBound < performUpperBound` at L70.
Currently the revert check use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Withdrawals accrued rewards are not distributed among stakers
### Description
**Severity:** Medium
**Path:** PositiveTokenRebaseLimiter.sol
**Description:**
The PositiveTokenRebaseLimiter calculates the rewards to be taken from the vaults and the amount of shares to be burned for withdrawal requests.
Or... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | input-validation | true | false | ## Medium: `TradingAccount::getAccountMarginRequirementUsdAndUnrealizedPnlUsd` uses incorrect price during order settlement
### Description
During order settlement `SettlementBranch::_fillOrder` uses an off-chain price provided by the keeper:
```solidity
File: SettlementBranch.sol
120: ctx.fillPrice = perpMar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | front-running | true | false | ## Medium: `AuctionLoanLiquidator#placeBid` can be DoS
### Description
The attacker performs a DoS attack on the `Bid` function, causing other users to be unable to participate and eventually obtaining the NFT at a low price.
### Proof of Concept
The `placeBid` function requires each bid to increase by 5% from the o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `<x> += <y>` Costs More Gas Than `<x> = <x> + <y>` For State Variables
### Description
https://github.com/code-423n4/2023-03-wenwin/tree/main/src/Lottery.sol#L129
https://github.com/code-423n4/2023-03-wenwin/tree/main/src/Lottery.sol#L173
https://github.com/code-423n4/2023-03-wenwin/tree/main/src/Lottery.s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: Loss/lock of rewards in case of withdrawing fully before a flood
### Description
Withdrawing a deposit entirely before a flood results in a situation where the SOP rewards held in the protocol become unclaimable and inaccessible. In other words, the user cannot claim their rewards, and the rewards will be p... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: (HAL-02) GAS INEFFICIENT ERROR HANDLING
### Description
It was identified that long revert strings are used in the several contracts. Starting from Solidity v0.8.4, there is a convenient and gas-efficient way to explain to users why an operation failed through the use of custom errors. If the revert string use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Division by powers of two should use bit shifting in `Merkle.sol`
### Description
While the bot report reported every division by powers of two in a form: `A / 2`, it misses an instance, which looks like: `A /= 2`.
[File: ethereum/contracts/zksync/libraries/Merkle.sol](https://github.com/code-423n4/2023-10-zk... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Change of program output offsets breaks compatibility with old programs
### Description
The structure of data and offsets in the program output was changed. A new field for data availability mode was added in offset 1, shifting the old fields one position in the output structure. This makes old program outputs... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: Admin Sidestep - `Guard.sol` DelegateCall is still possible via Modules
### Description
Delegatecall could still be performed by setting up modules
IMO this is fine, however, signers should be warned that adding a module could cause a full sidestep of the security guarantees of the project
The same can happe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Not using `SafeTransferLib`
### Description
**Severity**
**Impact:** Medium
**Likelihood:** Medium
**Description**
Most of the token transfer operations within the `Pool` already utilize `SafeTransferLib`. However, several operations, including those in `removeLiquidity`, `rescue`, and `skim`, still use... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | false | false | ## Low: `OwnerProxy` can call `selfdestruct()`
### Description
https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/governance/OwnerProxy.sol#L9-L36
### Impact
OwnerProxy's selfdestruct
### Proof of Concept
While only the owner (the timelock) can call the execute fun... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | flash-loan | false | false | ## High: Inaccurate `liquidityAdded` Parameter Before Flashloan Transfer
### Description
https://github.com/aave/protocol-v2/blob/56d25e81cb0fdfcac785d669d3577b1ef2d9286e/contracts/lendingpool/LendingPool.sol#L511
The `liquidityAdded` parameter of the `updateInterestRates` call seems to be incorrect as the flashloan ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Using `calldata` instead of `memory` for read-only arguments in `external` functions saves gas
### Description
See [original submission](https://github.com/code-423n4/2022-04-axelar-findings/issues/39) for list of instances. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Reading a storage variable in the event
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**
In the `setDecay()` and `setFee()` function, `DecayChanged()` and `FeeChanged()` events read storage variables even if local variables exist for the same value.
**Recommendation**:
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Cache storage reads in `upperLookupRecentCheckpoint`
### Description
**Description:** Functions like `upperLookupRecentCheckpoint` in `Checkpoints` perform multiple expensive storage reads for `self._trace._checkpoints.length` and repeated `_unsafeAccess` calls.
**Recommended Mitigation:** Cache the checkpoin... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | true | false | ## Low: Risk calling recover on APUFFToken
### Description
**Severity**: Low
**Status**: Resolved
**Location**: ChefIncentivesController.sol
**Description**
The smart contract contains a function named `recoverERC20` that allows the owner to withdraw an arbitrary amount of an arbitrary ERC20 token (tokenAddress) a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | access-control | false | false | ## High: Linear iteration over undelegations with unmetered token transfers expose a permission- less chain halt
### Description
An attacker can accumulate service delegations (each with multiple delegated denoms) and then undelegate them in batches across successive blocks. This results in a growing number of accumul... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | access-control | false | false | ## Medium: Incorrect Loss Calculation in `_completeWithdraw`
### Description
This issue has been identified within the [\_completeWithdraw](https://github.com/Se7en-Seas/cMETH-boring-vault/blob/d6e2d18f45a3e05d749d34966139fc85fc47f7e6/src/base/Roles/DelayedWithdraw.sol#568) function of the `DelayedWithdraw` contract.
... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: Approve is Incompatible with Non-Standard ERC20 Tokens
### Description
**Severity**: Medium
**Status**: Resolved
**Description**
The approve function used in the contract is incompatible with some non-standard ERC20 tokens that do not correctly implement the EIP20 standard. For example, tokens like USDT ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [01] `PoolRegistry.supportMarket()` cannot be paused
### Description
Most actions in `PoolRegistry` can be paused, e.g. `_addToMarket()`, `exitMarket()`, `preMintHook()` etc.
Consider adding a "support" field in the enum Action and allowing `supportMarket()` to be paused. Not allowing `supportMarket()` to be ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Liquidity provisioning can skew fee assessments
### Description
In the [`HubPool`](https://github.com/across-protocol/across-smart-contracts-v2/blob/bf03255cbd1db3045cd2fbf1580f24081f46b43a/contracts/HubPool.sol) contract the [`enableL1TokenForLiquidityProvision`](https://github.com/across-protocol/across-smar... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Inaccurate update of limitPrice
### Description
**Severity**: Medium
**Status**: Acknowledged
**Description**
In contract TradingExtension in function “_limitClose” at lines #94 and #102 the variable “_limitPrice” is updated using “_trade.tpPrice” or “_trade.slPrice” fields. The assignment of these varia... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect handling of AaveDataProvider data when checking max deposit
### Description
When calculating the maximum deposit through the `_underlyingProtocolMaxDeposit` in the AaveV3Farm contract, the contract calls AaveDataProvider to get the `supplyCap`. A `supplyCap` of `0` indicates an uncapped pool, but the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: User can exponentially increase the value of their position through the `memorializePositions` function
### Description
The [PositionManager contract](https://github.com/code-423n4/2023-05-ajna/blob/276942bc2f97488d07b887c8edceaaab7a5c3964/ajna-core/src/PositionManager.sol#L42) allows a lender to mint an NFT ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Provers Can Reject Time-Consuming Proof Tiers
### Description
The proof tier required for a block is calculated during a call to `proposeBlock()`. A lazy prover can detect the tier of a proof and force the transaction suggesting it to revert at no cost to themselves. While this costs the prover nothing, it wou... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Variable balance token causing fund lock and loss
### Description
[VTVLVesting.sol#L295](https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e8126b839afeab5f/contracts/VTVLVesting.sol#L295)
[VTVLVesting.sol#L388](https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e81... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Remove `BabelVault::receiverUpdatedWeek` and add `updatedWeek` member to struct `Receiver`
### Description
The mapping `idToReceiver` already links the receiver id to the receiver's data:
```solidity
mapping(uint256 receiverId => Receiver receiverData) public idToReceiver;
```
Hence it is simpler & cleaner to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Setting a new rewards manager breaks claiming old rewards
### Description
Setting a new rewards manager will break any old unclaimed rewards as users can only claim through the `PositionManager.claimRewards` function which then uses the new reward manager.
### Recommendation
Be cautious when setting new re... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | true | false | ## High: Inaccurate Reward Calculation
### Description
## Withdrawal Request Issue
In `withdrawal_request`, the `last_received_rewards_height` parameter of `vault_params` is not updated to the `current_height` after rewards are calculated and transferred.
> _restaking/programs/restaking/src/lib.rs_
If a user cance... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | true | false | ## Low: `_receiverGas` check excludes minimum acceptable value
### Description
**Description:** In the LayerZero bridge contracts [`BridgeLR::send`](https://github.com/YieldFiLabs/contracts/blob/40caad6c60625d750cc5c3a5a7df92b96a93a2fb/contracts/bridge/BridgeLR.sol#L76) and [`BridgeMB::send`](https://github.com/YieldF... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Positions that are not eligible for rewards will affect the reward income of eligible positions
### Description
### Lines of code
### Impact
When calculating reward distribution, the contract uses the current position's liquidity time weight divided by the total liquidity time weight of the pool, instead... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | dos | true | false | ## Low: Potential DoS of `SeasonFacet::gm` due to division by zero in `LibGauge::updateGaugePoints` | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | signature | false | false | ## Low: No SuperVaultAggregator.forwardPPS validation on updateAuthority and args.timestamp
### Description
The only validation on `updateAuthority` and `timestamp` is to determine if an upkeep fee is required. This means:
- Out of order updates may be made (earlier timestamps can replace later ones).
- Anyone can cal... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Non-Reverting Execution Hooks In Case Of No `functionId` Match
### Description
**Update**
Nonmatching `functionId`s now revert. Fixed in commit `3c1b5b6002be43e42c9c4feba182a83aaa2d139a`
**File(s) affected:**`plugins/session/permissions/SessionKeyPermissionsPlugin.sol`
**Description:** The reference implemen... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: `<x> += <y>` costs more gas than `<x> = <x> + <y>` for state variables
### Description
Using the addition operator instead of plus-equals saves **[113 gas](https://gist.github.com/IllIllI000/cbbfb267425b898e5be734d4008d4fe8)**.
*There are 10 instances of this issue.* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | medium | front-running | true | true | ## Medium: Missing slippage protection when removing liquidity
### Description
When a user removes liquidity, they can expect a specific amount of tokens in exchange; however, depending on the relative position of the price to the range from which the concentrated liquidity is being removed, this can be computed as si... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | access-control | false | true |
The `buy` function on the `LPDA.sol` contract is not validating if the auction is still running, allowing a purchase to be made after the stipulated time. The `endtime` variable used to store the end date of the auction is not used at any point to validate whether the purchase is being made within the deadline.
### P... | Code4rena | 5 | Escher |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | true | false | ## Low: `fulfillmentTxGasLimit` is missing
### Description
In ZKPay, users send one query request. In this query request, users will define the `fulfillmentTxGasLimit`, the maximum amount of gas to use for the callback.. This is one important parameter. The merchant oracle will evaluate the total gas consume that the ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Code Maturity
### Description
## Code Refactor Recommendations
1. Replace `create_associated_token_account` with `create_associated_token_account_idempotent` in the `create_staking_pool` and `init_neptune_foundation_tokens` instructions to ensure successful execution even if the associated token account alrea... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: State variables can be packed to use fewer storage slots
### Description
The EVM works with 32 byte words. Variables less than 32 bytes can be declared next to each other in storage and this will pack the values together into a single 32 byte storage slot (if the values combined are <= 32 bytes). If the variab... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Rollback functionality can lead to untested combinations Acknowledged
### Description
`SimpleFunctionRegistry` maps individual function selectors to implementation contracts. As features are newly deployed or upgraded, functions are registered in logical groups after a timelock enforced by the owning multisig... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Zero reward due to a missing scaling factor
### Description
When a caller triggers `seasonfacet:gm` or `seasonfacet:sunrise`, according to the comment 'gm advances Beanstalk to the next Season and sends reward Beans to a specified address or the caller'. The calculation of the reward is based on the blocks lat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Additional checks are required for constructor of RaiinmakerCampaignVault.sol
### Description
**Description**
There is no verification for the zero address for the _feeToken and _withdrawSigner.
**Recommendation**:
Add additional checks:
require(_withdrawSigner != address(0), "Wrong signer address");
requ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Unresolved `TODOs` in Code
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `6597ff095fd4f4f253cc37f49d34b16e3578edbd`.
The client provided the following explanation: Unnecessary TODOs removed.
**File(s) affected:**`bitfield.sol`, `PolicyManager.sol`
**Description:** The following `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Issues relating to collateral tokens sudden price swings
### Description
The development team asked the testing team to consider the case of a sudden price drop in the value of one or more collateral tokens. It is true that, after a significant price drop, calculations in `collateralSeizureAmounts` will return... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Missing constraints in LOADWand STOREW
### Description
In the recursion VM, the LOADW and STOREW instructions are missing constraints to link the read value to the written value. As a result, a malicious prover can write any value.
### Recommendation
Since `cols.data_read` and `cols.data_write` should always... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Only a billion checkpoints available
### Description
A user can only have a billion checkpoints which, if the user is a DAO, may cause issues down the line, especially if the last checkpoint involved delegating and can thereafter not be undone
*There is 1 instance of this issue:*
https://github.com/code-423n... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Validation for Zero toRepay in repayLogic
### Description
**Severity**: Informational
**Status**: Acknowledged
**Description**:
The repayLogic function calculates the toRepay value as the minimum of _getUserBorrowBalanceInOf(_poolToken, _onBehalf) and _amount. However, the function does not check w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Implementation contracts can be initialized
### Description
The implementation contracts `Karma.sol` and `MechMarketplace.sol` allow direct initialization, which can result in their state being set independently of the proxy mechanism. In upgradeable proxy patterns, the implementation contract is meant to rema... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [05] Helpers should have their expectations explained in NatSpec/comments
### Description
Certain functions with `unchecked` blocks or other "exotic logic" have assumptions for certain input values. These assumptions are not documented well. It makes it error prone to validate against possible inputs and/or ex... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: Missing `whenNotPaused` modifier
### Description
_Submitted by SmartSek, also found by csanuragjain and hansfriese_
[StableSwapFacet.sol#L279-L286](https://github.com/code-423n4/2022-06-connext/blob/b4532655071566b33c41eac46e75be29b4a381ed/contracts/contracts/core/connext/facets/StableSwapFacet.sol#L279-L2... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: DSROracleForwarderBase._packMessage() type-casts silently drop bits
### Description
The `DSROracleForwarderBase._packMessage()` function reads three `uint256` fields from the pot and casts them to lower types:
- `dsr`: `uint96(pot.dsr())`
- `chi`: `uint120(pot.chi())`
- `rho`: `uint40(pot.rho())`
If the fiel... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Mnemonic stays in memory for too long
### Description
Both iOS and Android wallets need to load the mnemonic to memory in plaintext in order to show it to the user and derive private keys for signing transactions. To minimize the risk of exposure, the mnemonic should not reside in memory except when needed ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Missing Docstrings
### Description
Throughout the [codebase](https://github.com/scroll-tech/scroll/tree/ae2e010324506d52f30d1aa98b98cc3e44f8c501/), there are several parts that do not have docstrings. For instance:
* [Line 10](https://github.com/scroll-tech/scroll/blob/ae2e010324506d52f30d1aa98b98cc3e44f8c50... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.