Datasets:
r1v3r
/
auto_0207_bug

Dataset card Data Studio Files
xet
 Community
1
repo
stringlengths
8
35
pull_number
int64
25
15.2k
instance_id
stringlengths
13
40
issue_numbers
listlengths
1
3
base_commit
stringlengths
40
40
patch
stringlengths
274
342k
test_patch
stringlengths
308
210k
problem_statement
stringlengths
25
44.3k
hints_text
stringlengths
0
33.6k
created_at
stringlengths
19
30
version
stringlengths
3
5
environment_setup_commit
stringlengths
40
40
FAIL_TO_PASS
listlengths
1
1.1k
PASS_TO_PASS
listlengths
0
7.38k
FAIL_TO_FAIL
listlengths
0
1.72k
PASS_TO_FAIL
listlengths
0
49
__index_level_0__
int64
0
689
nushell/nushell
13,725
nushell__nushell-13725
[ "13380" ]
abd230e12e72d5f1863fc33e91ce11733913ce92
diff --git a/crates/nu-cli/src/completions/completion_common.rs b/crates/nu-cli/src/completions/completion_common.rs --- a/crates/nu-cli/src/completions/completion_common.rs +++ b/crates/nu-cli/src/completions/completion_common.rs @@ -1,3 +1,4 @@ +use super::MatchAlgorithm; use crate::{ completions::{matches, Com...
diff --git a/crates/nu-cli/tests/completions/mod.rs b/crates/nu-cli/tests/completions/mod.rs --- a/crates/nu-cli/tests/completions/mod.rs +++ b/crates/nu-cli/tests/completions/mod.rs @@ -299,7 +299,7 @@ fn file_completions() { match_suggestions(&expected_paths, &suggestions); // Test completions for hidden ...
"cd ..." and Tab should show the files in that folder? ### Question When constructing a command such as "cd ..." and pressing tab, I would expect to see the files in that folder. Should this be working? Edit: removed question about interpreting the "..." as not a glob-expansion. Since "go test ./..." can be run w...
This might explain some odd actions I am getting running p4 from nushell as well. Wrapping the path in single quotes fixed the issue for me. @coodeneko You're right, thx! Edited the question accordingly. I'm not quite sure what the issue is. Could you possibly provide an example and let me know what it produces, as wel...
2024-08-29T03:36:43
1.78
4d2d553cca5abd3f6c204c20c1eca0f1df094924
[ "completions::partial_completion_with_dot_expansions" ]
[ "completions::command_completions::command_completions_tests::test_find_non_whitespace_index", "completions::completion_options::test::match_algorithm_prefix", "completions::completion_options::test::match_algorithm_fuzzy", "reedline_config::test::test_error", "reedline_config::test::test_edit_event", "re...
[ "commands::keybindings_list::not_empty", "commands::nu_highlight::nu_highlight_not_expr", "completions::folder_with_directorycompletions_do_not_collapse_dots", "completions::folder_with_directorycompletions_with_dots", "completions::folder_with_directorycompletions_with_three_trailing_dots" ]
[]
121
nushell/nushell
9,309
nushell__nushell-9309
[ "9278" ]
3005fe10e54a247de843e01f68c98c4b53a17148
diff --git a/crates/nu-parser/src/parser.rs b/crates/nu-parser/src/parser.rs --- a/crates/nu-parser/src/parser.rs +++ b/crates/nu-parser/src/parser.rs @@ -2217,6 +2217,12 @@ pub fn parse_filesize(working_set: &mut StateWorkingSet, span: Span) -> Expressi let bytes = working_set.get_span_contents(span); + //...
diff --git a/src/tests/test_parser.rs b/src/tests/test_parser.rs --- a/src/tests/test_parser.rs +++ b/src/tests/test_parser.rs @@ -561,3 +561,8 @@ fn filesize_with_underscores_2() -> TestResult { fn filesize_with_underscores_3() -> TestResult { fail_test("42m_b", "executable was not found") } + +#[test] +fn file...
Filesieze literal conflicts with hex integer literal ### Describe the bug Hexadecimal literal ending with `b` is parsed as filesize (bytes) and fails. ### How to reproduce ``` > 0x6b Error: × filesize value must be a number ╭─[entry #1:1:1] 1 │ 0x6b · ─┬─ · ╰── not a number ╰──── ``` ### Exp...
oh, wow, that's interesting. i'm surprised we've never seen that before. Maybe a recent regression. I know it was working a while ago, when I last touched the parser. on 0.80.0 it works fine ``` > 0x6b 107 ``` Interesting, then it must be some recent regression. Just bisected. ``` 0e4729b203a042c5851f8d58ec3d12a...
2023-05-28T05:47:40
0.80
e6be167797f31f4702934d7951801d331dbe5498
[ "tests::test_parser::filesize_is_not_hex" ]
[ "tests::test_bits::bits_or", "tests::test_bits::bits_or_list", "tests::test_bits::bits_and_list", "tests::test_bits::bits_rotate_right", "tests::test_bits::bits_and_negative", "tests::test_bits::bits_rotate_left", "tests::test_bits::bits_rotate_left_negative", "tests::test_bits::bits_or_negative", "...
[ "path::canonicalize::canonicalize_ndots" ]
[]
122
nushell/nushell
8,953
nushell__nushell-8953
[ "8916" ]
24b4ac692e7614eae00826013cdc179a31029b5d
diff --git a/crates/nu-engine/src/eval.rs b/crates/nu-engine/src/eval.rs --- a/crates/nu-engine/src/eval.rs +++ b/crates/nu-engine/src/eval.rs @@ -112,7 +112,22 @@ pub fn eval_call( if let Some(var_id) = named.var_id { let mut found = false; for call_named in call.named_it...
diff --git a/src/tests/test_engine.rs b/src/tests/test_engine.rs --- a/src/tests/test_engine.rs +++ b/src/tests/test_engine.rs @@ -379,3 +379,27 @@ fn assignment_to_in_var_no_panic() -> TestResult { fn assignment_to_env_no_panic() -> TestResult { fail_test(r#"$env = 3"#, "cannot_replace_env") } + +#[test] +fn sh...
Option resolution of custom command does not work properly ### Describe the bug Consider the following case ```shell def foo [-a: int = -1, -b] { echo $'a: ($a) -> ($a | describe), b: ($b) -> ($b | describe)' } ``` All the executions are well done but `foo -a <value>`, given an unexpected reply `a: <valu...
Very well-reported. I appreciate the thoroughness. agree with @jt, thanks for the crystal-clear issue :sparkles:
2023-04-21T18:23:58
0.78
24b4ac692e7614eae00826013cdc179a31029b5d
[ "tests::test_engine::short_flags_1", "tests::test_engine::short_flags", "tests::test_engine::short_flags_2" ]
[ "tests::test_bits::bits_and_list", "tests::test_bits::bits_and", "tests::test_bits::bits_or_negative", "tests::test_bits::bits_or", "tests::test_bits::bits_rotate_left_list", "tests::test_bits::bits_rotate_left_negative", "tests::test_bits::bits_and_negative", "tests::test_bits::bits_rotate_left", "...
[ "path::canonicalize::canonicalize_ndots" ]
[]
123
nushell/nushell
8,940
nushell__nushell-8940
[ "8939" ]
d42c2b2dbc941d63c5a05404a0c22c4a7cd9f965
diff --git a/crates/nu-engine/src/eval.rs b/crates/nu-engine/src/eval.rs --- a/crates/nu-engine/src/eval.rs +++ b/crates/nu-engine/src/eval.rs @@ -72,9 +72,8 @@ pub fn eval_call( if let Some(arg) = call.positional_nth(param_idx) { let result = eval_expression(engine_state, caller_stack, ar...
diff --git a/src/tests/test_engine.rs b/src/tests/test_engine.rs --- a/src/tests/test_engine.rs +++ b/src/tests/test_engine.rs @@ -323,8 +323,16 @@ fn default_value12() -> TestResult { } #[test] -fn default_value_expression() -> TestResult { - run_test(r#"def foo [x = ("foo" | str length)] { $x }; foo"#, "3") +f...
Default parameters should be `Values`, not `Expressions` ### Describe the bug The type of `default_value` in `PositionalArg` is an [optional expression](https://github.com/nushell/nushell/blob/91c01bf6b3bc58fc1510ba0caa3da414b76fac36/crates/nu-protocol/src/signature.rs#L38), but this is overly flexible. It would make ...
I don't mind working on this BTW 😺
2023-04-20T13:04:27
0.78
24b4ac692e7614eae00826013cdc179a31029b5d
[ "tests::test_engine::default_value_not_constant" ]
[ "tests::test_bits::bits_rotate_right", "tests::test_bits::bits_rotate_left_negative", "tests::test_bits::bits_or", "tests::test_bits::bits_rotate_right_negative", "tests::test_bits::bits_and_list", "tests::test_bits::bits_or_negative", "tests::test_bits::bits_rotate_right_list", "tests::test_bits::bit...
[ "path::canonicalize::canonicalize_ndots" ]
[]
124
nushell/nushell
8,919
nushell__nushell-8919
[ "8863" ]
32f098d91df4861d9024a70a6427527896f347d0
diff --git a/crates/nu-cli/src/completions/variable_completions.rs b/crates/nu-cli/src/completions/variable_completions.rs --- a/crates/nu-cli/src/completions/variable_completions.rs +++ b/crates/nu-cli/src/completions/variable_completions.rs @@ -1,5 +1,5 @@ use crate::completions::{Completer, CompletionOptions}; -use...
diff --git a/crates/nu-cli/tests/completions.rs b/crates/nu-cli/tests/completions.rs --- a/crates/nu-cli/tests/completions.rs +++ b/crates/nu-cli/tests/completions.rs @@ -556,6 +556,100 @@ fn variables_completions() { // Match results match_suggestions(expected, suggestions); + // Test completions for $n...
completion on `$nu` uses `$nu | columns` at all depth ### Describe the bug could not find a similar in the issue tracker so here i go :smirk: when we try to auto-complete on the `$nu` variable, no matter the depth in the data, we get results from `$nu | columns` :open_mouth: ### How to reproduce see [this rec...
2023-04-18T19:46:55
0.78
24b4ac692e7614eae00826013cdc179a31029b5d
[ "variables_completions" ]
[ "command_save_with_filecompletion", "command_watch_with_filecompletion", "command_cp_with_globcompletion", "command_open_with_filecompletion", "command_touch_with_filecompletion", "command_ls_with_filecompletion", "command_rm_with_globcompletion", "alias_of_command_and_flags", "alias_of_basic_comman...
[]
[]
125
nushell/nushell
8,151
nushell__nushell-8151
[ "8137" ]
e89866bedb2353969ff13c6edfc71789744cc8d0
diff --git a/crates/nu-parser/src/lex.rs b/crates/nu-parser/src/lex.rs --- a/crates/nu-parser/src/lex.rs +++ b/crates/nu-parser/src/lex.rs @@ -59,7 +59,6 @@ fn is_item_terminator( || c == b'\r' || c == b'|' || c == b';' - || c == b'#' || additional_whitespa...
diff --git a/crates/nu-parser/tests/test_lex.rs b/crates/nu-parser/tests/test_lex.rs --- a/crates/nu-parser/tests/test_lex.rs +++ b/crates/nu-parser/tests/test_lex.rs @@ -93,6 +93,57 @@ fn lex_incomplete_quote() { assert!(matches!(err, ParseError::UnexpectedEof(v, _) if v == "'")); } +#[test] +fn lex_comments_n...
Behaviour of comments in shell usage ### Question Hi, I'm using nix and hence I write commands like this very often: `nix <command> <some-flake>#<output>`. The issue here is the `#` which gets interpreted as a comment in nu. Is it possible to turn off this behavior or somehow make it such that the comment syntax i...
Duplicate of #6335 Requiring the space before end of line comments in the lexer would certainly be a breaking change for some people that have put (doc)comments directly after the documented item. Personally having the space is pleasant style to me, so I wouldn't oppose making that change. I don't know if we have...
2023-02-21T18:53:16
0.75
e89866bedb2353969ff13c6edfc71789744cc8d0
[ "lex_comments_no_space" ]
[ "lex_basic", "lex_comments", "lex_comment", "lex_incomplete_paren", "lex_incomplete_quote", "lex_parenthesis", "lex_empty", "lex_is_incomplete", "lex_newline" ]
[]
[]
126
nushell/nushell
7,897
nushell__nushell-7897
[ "7886" ]
afb4209f101720c7bf97df99b9318daeb7cc04b5
diff --git a/crates/nu-command/src/strings/parse.rs b/crates/nu-command/src/strings/parse.rs --- a/crates/nu-command/src/strings/parse.rs +++ b/crates/nu-command/src/strings/parse.rs @@ -276,7 +276,7 @@ fn column_names(regex: &Regex) -> Vec<String> { .skip(1) .map(|(i, name)| { name.map(S...
diff --git a/crates/nu-command/src/strings/parse.rs b/crates/nu-command/src/strings/parse.rs --- a/crates/nu-command/src/strings/parse.rs +++ b/crates/nu-command/src/strings/parse.rs @@ -74,12 +74,12 @@ impl Command for Parse { result: Some(Value::List { vals: vec![ ...
Automatic column name inconsistency: `parse -r` columns are 1-indexed capitalised when most other commands are 0-indexed uncapitalised ### Describe the bug See below. ### How to reproduce ``` 〉'A|B|C' | parse -r '(\w)\|(\w)\|(\w)' ╭───┬──────────┬──────────┬──────────╮ │ # │ Capture1 │ Capture2 │ Capture3 │ ├───...
Thanks. You're right. We should be consistent.
2023-01-29T13:09:43
0.74
afb4209f101720c7bf97df99b9318daeb7cc04b5
[ "strings::parse::test::test_examples" ]
[ "bytes::build_::test::test_examples", "bits::or::test::test_examples", "bits::shift_right::test::test_examples", "bits::rotate_left::test::test_examples", "bits::and::test::test_examples", "bits::rotate_right::test::test_examples", "bits::xor::test::test_examples", "bits::not::test::test_examples", ...
[ "filters::each_while::test::uses_optional_index_argument", "filters::par_each::test::uses_optional_index_argument", "strings::split::words::test::test_incompat_flags_2", "strings::split::words::test::test_incompat_flags", "system::benchmark::test_benchmark_closure", "system::benchmark::test_benchmark_clos...
[]
127
nushell/nushell
7,777
nushell__nushell-7777
[ "6986" ]
afb4209f101720c7bf97df99b9318daeb7cc04b5
diff --git a/crates/nu-command/src/core_commands/for_.rs b/crates/nu-command/src/core_commands/for_.rs --- a/crates/nu-command/src/core_commands/for_.rs +++ b/crates/nu-command/src/core_commands/for_.rs @@ -34,7 +34,7 @@ impl Command for For { .required("block", SyntaxShape::Block, "the block to run") ...
diff --git a/crates/nu-command/src/example_test.rs b/crates/nu-command/src/example_test.rs --- a/crates/nu-command/src/example_test.rs +++ b/crates/nu-command/src/example_test.rs @@ -9,9 +9,9 @@ pub fn test_examples(cmd: impl Command + 'static) { #[cfg(test)] mod test_examples { use super::super::{ - Ansi...
Why does `reduce --numbered` cause both the accumulator and the element to become {item, index} records? ### Question ``` 〉[a b c d e f] | reduce --fold '' --numbered {|e a| $e.item + $a.item } fedcba ``` This is what I mean - you have to write `$a.item` as well as `$e.item`, *even though both $a.index and $e.inde...
2023-01-16T20:45:28
0.74
afb4209f101720c7bf97df99b9318daeb7cc04b5
[ "filters::each_while::test::test_examples", "filters::reduce::test::test_examples", "filters::par_each::test::test_examples", "strings::split::words::test::test_incompat_flags", "strings::split::words::test::test_incompat_flags_2", "system::benchmark::test_benchmark_closure", "system::benchmark::test_be...
[ "bytes::build_::test::test_examples", "bits::or::test::test_examples", "bits::shift_right::test::test_examples", "bits::xor::test::test_examples", "bits::rotate_left::test::test_examples", "bits::and::test::test_examples", "bits::rotate_right::test::test_examples", "bytes::collect::tests::test_example...
[ "commands::cd::cd_permission_denied_folder", "path::canonicalize::canonicalize_ndots" ]
[]
128
nushell/nushell
13,447
nushell__nushell-13447
[ "13441" ]
a88c3f48e281ce50dd2a0518ff8e899314e427b5
diff --git a/crates/nu-protocol/src/ast/expression.rs b/crates/nu-protocol/src/ast/expression.rs --- a/crates/nu-protocol/src/ast/expression.rs +++ b/crates/nu-protocol/src/ast/expression.rs @@ -432,7 +432,17 @@ impl Expression { Expr::Int(_) => {} Expr::Float(_) => {} Expr::Binar...
diff --git a/tests/repl/test_engine.rs b/tests/repl/test_engine.rs --- a/tests/repl/test_engine.rs +++ b/tests/repl/test_engine.rs @@ -75,6 +75,16 @@ fn in_used_twice_and_also_in_pipeline() -> TestResult { ) } +// #13441 +#[test] +fn in_used_in_range_from() -> TestResult { + run_test(r#"6 | $in..10 | math su...
`$in` errors with range in 0.96.0 ### Describe the bug previously this code had no problems cc @devyn ### How to reproduce ```nu > 101 | 1..($in // 100) Error: nu::shell::variable_not_found × Variable not found ╭─[entry #9:2:7] 1 │ 101 2 │ | 1..($in // 100) · ─┬─ · ╰── vari...
2024-07-25T10:01:35
1.77
a88c3f48e281ce50dd2a0518ff8e899314e427b5
[ "repl::test_engine::in_used_in_range_to", "repl::test_engine::in_used_in_range_from" ]
[ "const_::const_binary_operator::case_04", "const_::const_binary", "const_::const_binary_operator::case_05", "const_::const_binary_operator::case_02", "const_::const_binary_operator::case_03", "const_::const_binary_operator::case_06", "const_::const_binary_operator::case_01", "const_::const_binary_oper...
[]
[]
129
nushell/nushell
12,438
nushell__nushell-12438
[ "12203" ]
67c8b0db693a5428042ddb3110d50e82f17470bf
diff --git a/crates/nu-cli/src/completions/completion_common.rs b/crates/nu-cli/src/completions/completion_common.rs --- a/crates/nu-cli/src/completions/completion_common.rs +++ b/crates/nu-cli/src/completions/completion_common.rs @@ -7,40 +7,65 @@ use nu_protocol::{ Span, }; use nu_utils::get_ls_colors; -use st...
diff --git a/crates/nu-cli/tests/completions.rs b/crates/nu-cli/tests/completions.rs --- a/crates/nu-cli/tests/completions.rs +++ b/crates/nu-cli/tests/completions.rs @@ -333,7 +333,26 @@ fn partial_completions() { let suggestions = completer.complete(&target_dir, target_dir.len()); // Create the expected v...
Completions not working with files that have multiple periods in the name ### Describe the bug Completions not working with files that have multiple periods in the name. In most cases I get no results and in a few cases I get a partial match of the results. Reproduces: f4d9ddd3a Fix completions for directories...
Thanks for the reproduction steps! For the first example (`open a<tab>`) I get all results, but I had a folder starting with a in the same directory. @132ikl are you interested in looking into this? Yes, I'll take a look. Awesome, thanks I cannot reproduce the bug with the previous version: | key ...
2024-04-07T11:24:43
1.74
67c8b0db693a5428042ddb3110d50e82f17470bf
[ "partial_completions" ]
[ "custom_completer_triggers_cursor_after_word", "alias_of_another_alias", "command_save_with_filecompletion", "command_touch_with_filecompletion", "command_cp_with_globcompletion", "command_rm_with_globcompletion", "custom_completer_triggers_cursor_before_word", "command_open_with_filecompletion", "c...
[]
[]
130
nushell/nushell
7,119
nushell__nushell-7119
[ "6737" ]
585ab56ea4dc3ff5cdb23a56da6496bd42b858d7
diff --git a/crates/nu-parser/src/parser.rs b/crates/nu-parser/src/parser.rs --- a/crates/nu-parser/src/parser.rs +++ b/crates/nu-parser/src/parser.rs @@ -1634,42 +1634,52 @@ pub fn parse_string_interpolation( let mut token_start = start; let mut delimiter_stack = vec![]; + let mut consecutive_backslashe...
diff --git a/crates/nu-parser/tests/test_parser.rs b/crates/nu-parser/tests/test_parser.rs --- a/crates/nu-parser/tests/test_parser.rs +++ b/crates/nu-parser/tests/test_parser.rs @@ -210,48 +210,6 @@ pub fn parse_binary_with_multi_byte_char() { } } -#[test] -pub fn parse_string() { - let engine_state = Engin...
String interpolation doesn't seem to work with escaped \ characters immediately before it ### Describe the bug When a \ appears directly before the string interpolation parentheses in a $ string, the parentheses stop working altogether, EVEN if the \ is escaped with another \\. ### How to reproduce Get a load ...
Thanks for the report. Maybe reading this could help explain it further, which I just wrote yesterday https://hackmd.io/yBEUx4czTMuHcTICt-xZAA?view, to understand how it's supposed to work. > When a \ appears directly before the string interpolation ... It's not really a matter of string interpolation but instead...
2022-11-13T01:51:21
0.72
5f48452e3b8da8dd76ddb9adf03e832a3041dac9
[ "string::interpolation::parse_string_interpolation_escaped_backslash_before_parenthesis" ]
[ "parse_binary_with_binary_format", "parse_binary_with_hex_format", "parse_binary_with_incomplete_binary_format", "input_types::call_types_test", "input_types::call_non_custom_types_test", "parse_binary_with_incomplete_hex_format", "input_types::nested_operations_test", "parse_binary_with_incomplete_oc...
[]
[]
131
hatoo/oha
309
hatoo__oha-309
[ "308" ]
de6b00be6b9efb7db5a13e04b512c2fcc5c257e8
diff --git a/src/main.rs b/src/main.rs --- a/src/main.rs +++ b/src/main.rs @@ -256,19 +256,6 @@ async fn main() -> anyhow::Result<()> { http::header::HeaderValue::from_str(url.authority())?, ); - headers.extend( - opts.headers - .into_iter() - .map...
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -421,6 +421,8 @@ async fn test_setting_custom_header() { async fn test_setting_accept_header() { let header = get_header_body(&["-A", "text/html"]).await.0; assert_eq!(header.get("accept").unwrap().to_str().unwrap(), "t...
incorrect header host value? I tried using it like below, hoping to simulate the access to a service on my local machine. The service online is a service of xxx.com, so use the host header to simulate it. ```bash oha -H "host:xxx.com" -z 30m "http://127.0.0.1:8000" ``` What is received on the server side is ...
2023-09-16T14:33:43
0.6
de6b00be6b9efb7db5a13e04b512c2fcc5c257e8
[ "test_setting_accept_header", "test_setting_host" ]
[ "test_connect_to", "test_setting_basic_auth", "test_enable_compression_default", "test_query_rand_regex", "test_query", "test_connect_to_ipv6_requested", "test_setting_body", "test_connect_to_redirect", "test_setting_content_type_header", "test_setting_custom_header", "test_setting_method", "t...
[ "test_connect_to_ipv6_target", "test_ipv6" ]
[]
132
o2sh/onefetch
1,389
o2sh__onefetch-1389
[ "1306" ]
81b4831fed2386efb0c3239b7db8b7618f6cc8f9
diff --git a/src/info/utils/mod.rs b/src/info/utils/mod.rs --- a/src/info/utils/mod.rs +++ b/src/info/utils/mod.rs @@ -2,7 +2,7 @@ use crate::cli::NumberSeparator; use gix::date::Time; use num_format::ToFormattedString; use owo_colors::{DynColors, Style}; -use std::time::{Duration, SystemTime}; +use std::time::Syste...
diff --git a/src/info/utils/mod.rs b/src/info/utils/mod.rs --- a/src/info/utils/mod.rs +++ b/src/info/utils/mod.rs @@ -107,24 +103,22 @@ mod tests { } #[test] - #[should_panic( - expected = "Achievement unlocked: time travel! Check your system clock and commit dates." - )] - fn should_panic_...
Handle future commit datetimes in the future without panicking ### Duplicates - [X] I have searched the existing issues ### Current behavior 😯 If the commit time is in the future, onefetch crashes. ### Expected behavior 🤔 It should possibly handle the case or fail gracefully. The crash report blames th...
I'm that colleague But I like that "time travel" achievement :cry: :laughing: But you're right that we could handle this more gracefully. I think that most people don't pay attention to the commit time, so even if it was an unreasonable value like in the year 3000 it could still get merged in. And if that happens th...
2024-08-08T22:15:11
2.21
61ab2982bddb698f31ab78e7b3134d5f959d014e
[ "info::utils::tests::display_time_before_epoch", "info::utils::tests::handle_display_human_time_and_commit_date_in_the_future" ]
[ "info::authors::test::test_authors_info_title_with_one_author", "info::authors::test::test_authors_info_title_with_two_authors", "info::authors::test::test_compute_authors", "info::authors::test::test_digit_difference::case_1", "info::authors::test::test_digit_difference::case_2", "info::authors::test::te...
[]
[]
134
ordinals/ord
4,126
ordinals__ord-4126
[ "4121" ]
fcfc93c18b695cd91795a1f663a16d6ad06058cd
diff --git a/src/wallet/wallet_constructor.rs b/src/wallet/wallet_constructor.rs --- a/src/wallet/wallet_constructor.rs +++ b/src/wallet/wallet_constructor.rs @@ -67,21 +67,21 @@ impl WalletConstructor { client }; - let chain_block_count = bitcoin_client.get_block_count().unwrap() + 1; + let bitcoin...
diff --git a/tests/wallet/balance.rs b/tests/wallet/balance.rs --- a/tests/wallet/balance.rs +++ b/tests/wallet/balance.rs @@ -174,7 +174,7 @@ fn unsynced_wallet_fails_with_unindexed_output() { .ord(&no_sync_ord) .core(&core) .expected_exit_code(1) - .expected_stderr("error: wallet failed to synchroni...
wallet failed to synchronize after 20 attempts Hello, I am getting this error, any ideas how to resolve it? ``` > ord wallet balance error: wallet failed to synchronize with `ord server` after 20 attempts ``` ### My setup `ord server --http-port 4455` # already sync-ed and indexed ord.yaml ``` cooki...
Rebuilt the index from scratch, and still getting the same issue: New settings: ``` ord settings { "bitcoin_data_dir": "/home/deploy/.bitcoin", "bitcoin_rpc_limit": 12, "bitcoin_rpc_password": null, "bitcoin_rpc_url": "127.0.0.1:18332", "bitcoin_rpc_username": null, "chain": "testnet", "commi...
2024-12-11T05:59:22
0.22
fcfc93c18b695cd91795a1f663a16d6ad06058cd
[ "wallet::inscribe::reinscribe_with_flag" ]
[ "decimal::tests::to_string", "index::entry::tests::inscription_id_entry", "fee_rate::tests::parse", "index::entry::tests::mintable_cap", "decimal::tests::from_str", "decimal::tests::to_amount", "chain::tests::from_str", "index::entry::tests::inscription_entry", "fee_rate::tests::fee", "index::entr...
[ "balances::with_runes", "decode::from_core", "index::export_inscription_number_to_id_tsv", "json_api::get_inscription", "json_api::get_inscription_with_metaprotocol", "json_api::get_runes", "json_api::get_sat_with_inscription_and_sat_index", "json_api::get_sat_with_inscription_on_common_sat_and_more_i...
[]
135
ordinals/ord
3,968
ordinals__ord-3968
[ "3919" ]
e71efa105be5d13871dc8fb5e93a3252ef53930b
diff --git a/src/index.rs b/src/index.rs --- a/src/index.rs +++ b/src/index.rs @@ -169,6 +169,15 @@ impl<T> BitcoinCoreRpcResultExt<T> for Result<T, bitcoincore_rpc::Error> { Err(bitcoincore_rpc::Error::JsonRpc(bitcoincore_rpc::jsonrpc::error::Error::Rpc( bitcoincore_rpc::jsonrpc::error::RpcError { code...
diff --git a/src/subcommand/server.rs b/src/subcommand/server.rs --- a/src/subcommand/server.rs +++ b/src/subcommand/server.rs @@ -7152,4 +7152,14 @@ next } ); } + + #[test] + fn unknown_output_returns_404() { + let server = TestServer::builder().chain(Chain::Regtest).build(); + server.assert_res...
Non-existant output lookups return 500 error For example: https://ordinals.com/output/0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef:123 This is because the JSON RPC status code / message for output not found was changed, so we don't correctly transform it into a 404 not found HTTP error.
When reproduced in the `env` terminal I see this error: `error serving request: JSON-RPC error: RPC error response: RpcError { code: -5, message: "No such mempool or blockchain transaction. Use gettransaction for wallet transactions.", data: None }` I hope this information will help in getting to the bottom of it...
2024-09-30T23:06:45
1.76
e71efa105be5d13871dc8fb5e93a3252ef53930b
[ "runes::one_rune", "server::address_page_shows_aggregated_inscriptions", "json_api::get_runes_balances", "wallet::batch_command::batch_inscribe_can_create_one_inscription", "wallet::batch_command::batch_inscribe_respects_dry_run_flag", "wallet::batch_command::etch_sub_minimum_rune_error", "wallet::batch...
[ "chain::tests::from_str", "decimal::tests::from_str", "decimal::tests::to_amount", "deserialize_from_str::tests::deserialize_from_str", "decimal::tests::to_string", "fee_rate::tests::parse", "fee_rate::tests::fee", "index::entry::tests::inscription_id_entry", "index::entry::tests::header", "index:...
[ "balances::with_runes", "index::export_inscription_number_to_id_tsv", "decode::from_core", "json_api::get_inscription", "json_api::get_runes", "json_api::get_sat_with_inscription_and_sat_index", "json_api::get_sat_with_inscription_on_common_sat_and_more_inscriptions", "json_api::get_status", "runes:...
[ "server::inscription_appears_on_output_page", "server::inscription_appears_on_reveal_transaction_page", "server::inscription_metadata", "wallet::batch_command::batch_can_etch_rune_without_premine", "wallet::batch_command::batch_in_same_output_with_non_default_postage", "wallet::batch_command::batch_inscri...
138
ordinals/ord
3,947
ordinals__ord-3947
[ "3944" ]
5953ccaaeb10eb79bc7672159778a81a8bf2c262
diff --git a/src/templates/iframe.rs b/src/templates/iframe.rs --- a/src/templates/iframe.rs +++ b/src/templates/iframe.rs @@ -29,7 +29,7 @@ impl Display for Iframe { write!( f, - "<iframe sandbox=allow-scripts scrolling=no loading=lazy src=/preview/{}></iframe>", + "<iframe sandbox=allow-script...
diff --git a/src/subcommand/server.rs b/src/subcommand/server.rs --- a/src/subcommand/server.rs +++ b/src/subcommand/server.rs @@ -3826,7 +3826,7 @@ mod tests { <dl> <dt>inscriptions</dt> <dd class=thumbnails> - <a href=/inscription/.*><iframe sandbox=allow-scripts scrolling=no loading=lazy src=/preview/.*></...
Allow iframe scroll on HTML Inscriptions See here: https://ordinals.com/inscription/124181f2d2f1f1e3cd95ebe0ccd064a4f48bb60849e918ece9d8ccd76a984d6ei0 Compared to here where it scrolls nicely: https://ordiscan.com/inscription/75724848 Here is issue: <img width="414" alt="image" src="https://github.com/user-at...
2024-09-13T19:10:52
1.76
e71efa105be5d13871dc8fb5e93a3252ef53930b
[ "templates::iframe::tests::main", "templates::iframe::tests::thumbnail", "subcommand::server::tests::unbound_output_receives_unbound_inscriptions", "server::inscription_appears_on_reveal_transaction_page", "server::inscription_appears_on_output_page", "server::address_page_shows_aggregated_inscriptions", ...
[ "chain::tests::from_str", "decimal::tests::from_str", "deserialize_from_str::tests::deserialize_from_str", "decimal::tests::to_string", "fee_rate::tests::fee", "fee_rate::tests::parse", "decimal::tests::to_amount", "index::entry::tests::header", "index::entry::tests::mintable_height_end", "index::...
[ "balances::with_runes", "index::export_inscription_number_to_id_tsv", "decode::from_core", "json_api::get_inscription", "json_api::get_runes", "json_api::get_runes_balances", "json_api::get_sat_with_inscription_and_sat_index", "json_api::get_sat_with_inscription_on_common_sat_and_more_inscriptions", ...
[ "subcommand::server::tests::input", "server::inscriptions_page_is_sorted", "wallet::batch_command::batch_inscribe_with_fee_rate", "wallet::batch_command::batch_same_sat_with_satpoint_and_reinscription", "wallet::batch_command::etch_mintable_plus_premine_overflow_error", "wallet::batch_command::invalid_end...
140
ordinals/ord
3,768
ordinals__ord-3768
[ "3764" ]
301f256267c600ca4ef43aced7c649e08b0a09aa
diff --git a/src/settings.rs b/src/settings.rs --- a/src/settings.rs +++ b/src/settings.rs @@ -31,7 +31,7 @@ pub struct Settings { } impl Settings { - pub(crate) fn load(options: Options) -> Result<Settings> { + pub fn load(options: Options) -> Result<Settings> { let mut env = BTreeMap::<String, String>::new...
diff --git a/src/settings.rs b/src/settings.rs --- a/src/settings.rs +++ b/src/settings.rs @@ -481,22 +481,22 @@ impl Settings { Ok(path.join(".cookie")) } - pub(crate) fn credentials(&self) -> Option<(&str, &str)> { + pub fn credentials(&self) -> Option<(&str, &str)> { self .server_username ...
Events Settings are private? Hi, I am trying to open_with_event_sender but settings from options are private. Can someone help me? ``` use clap::Parser; use ord::{ settings::Settings, index::{event::Event, Index}, }; use std::{ sync::atomic::{AtomicBool, Ordering}, thread, }; static SH...
@felipelincoln i tag you because you created firstly @mi-yu @raphjaph We could make this public
2024-05-20T21:59:33
0.18
88aa27fea0e3b9f2c43f46f3ba7075b622c5b4ed
[ "index::export_inscription_number_to_id_tsv", "balances::with_runes", "runes::two_runes", "server::inscriptions_page_has_next_and_previous", "server::inscription_page_after_send", "server::inscriptions_page_is_sorted", "wallet::batch_command::batch_inscribe_with_sat_arg_fails_if_wrong_mode", "wallet::...
[ "chain::tests::from_str", "decimal::tests::from_str", "deserialize_from_str::tests::deserialize_from_str", "decimal::tests::to_amount", "decimal::tests::to_string", "fee_rate::tests::fee", "fee_rate::tests::parse", "index::entry::tests::header", "index::entry::tests::inscription_id_entry", "index:...
[ "json_api::get_runes", "wallet::balance::unsynced_wallet_fails_with_unindexed_output", "server::run_no_sync", "wallet::batch_command::etch_reserved_rune_error", "wallet::batch_command::etch_sub_minimum_rune_error", "wallet::batch_command::invalid_end_height_error", "wallet::batch_command::incorrect_supp...
[ "json_api::get_runes_balances", "json_api::get_sat_with_inscription_and_sat_index", "server::inscription_content", "server::inscription_appears_on_reveal_transaction_page", "wallet::batch_command::batch_in_separate_outputs_with_parent", "wallet::batch_command::batch_inscribe_can_create_one_inscription", ...
141
ordinals/ord
3,748
ordinals__ord-3748
[ "3493" ]
abd7f6cc00ada499fc3b7ee2e80423bfafea5c3e
diff --git a/src/index/entry.rs b/src/index/entry.rs --- a/src/index/entry.rs +++ b/src/index/entry.rs @@ -92,6 +92,15 @@ impl RuneEntry { .unwrap_or_default() } + pub fn max_supply(&self) -> u128 { + self.premine + + self.terms.and_then(|terms| terms.cap).unwrap_or_default() + * self + ...
diff --git a/src/subcommand/server.rs b/src/subcommand/server.rs --- a/src/subcommand/server.rs +++ b/src/subcommand/server.rs @@ -3007,6 +3007,8 @@ mod tests { <dd>no</dd> <dt>supply</dt> <dd>340282366920938463463374607431768211455\u{A0}%</dd> + <dt>mint progress</dt> + <dd>100%</dd> <dt>premine</dt> ...
`ord list` doesn't work in 0.17.1 The `is_output_in_active_chain()` function in index.rs is looking at the `in_active_chain` field of the raw transaction output, but it is always None. That field is only set if `getrawtransaction` is passed a block hash, and it isn't. This fixes it: ``` diff --git a/src/index...
Thanks for the report! Could you open a PR for this? Hi @gmart7t2 - does this issue persist in the latest version? If so, would you please open a PR for it? Thanks!
2024-05-13T20:57:59
0.18
88aa27fea0e3b9f2c43f46f3ba7075b622c5b4ed
[ "subcommand::server::tests::charm_unbound", "subcommand::server::tests::runes_are_displayed_on_rune_page", "templates::rune::tests::display", "balances::with_runes", "server::inscription_metadata", "server::inscription_page", "runes::one_rune", "json_api::get_runes_balances", "json_api::get_runes", ...
[ "deserialize_from_str::tests::deserialize_from_str", "decimal::tests::from_str", "decimal::tests::to_string", "chain::tests::from_str", "decimal::tests::to_amount", "fee_rate::tests::parse", "fee_rate::tests::fee", "index::entry::tests::inscription_id_entry", "index::entry::tests::header", "index:...
[ "server::inscription_appears_on_output_page", "server::run_no_sync" ]
[ "json_api::get_status", "server::inscription_content", "server::inscription_transactions_are_stored_with_transaction_index", "server::inscription_page_after_send", "wallet::batch_command::batch_in_same_output_but_different_satpoints", "wallet::batch_command::batch_inscribe_can_create_one_inscription", "...
145
shssoichiro/oxipng
466
shssoichiro__oxipng-466
[ "459" ]
bab00cb961fb1b0d898c327e4a92a9b8f07069f3
diff --git a/src/headers.rs b/src/headers.rs --- a/src/headers.rs +++ b/src/headers.rs @@ -71,7 +71,7 @@ pub enum Headers { None, /// Remove specific chunks Strip(Vec<String>), - /// Headers that won't affect rendering (all but cHRM, gAMA, iCCP, sBIT, sRGB, bKGD, hIST, pHYs, sPLT) + /// Headers tha...
diff --git a/tests/regression.rs b/tests/regression.rs --- a/tests/regression.rs +++ b/tests/regression.rs @@ -62,7 +62,13 @@ fn test_it_converts( "optimized to wrong bit depth" ); if let Some(palette) = png.raw.palette.as_ref() { - assert!(palette.len() <= 1 << (png.raw.ihdr.bit_depth.as_u8()...
Oxipng produces corrupted paletted images Pngcheck says "bKGD index (61) falls outside PLTE (61)" [wrong_bKGD_index.zip](https://github.com/shssoichiro/oxipng/files/9893334/wrong_bKGD_index.zip)
Just FYI, I've been looking into this as it came up during some experiments I was doing. The bKGD colour can get dropped from the palette if it isn't used in the idat. I hope to get a PR up to fix this sometime, but it may be a little more involved than it seems... [edit] Note these aren't really "corrupted", they j...
2022-11-29T15:36:02
6.0
1934587253789ceccd67c86e63f3b563abd78339
[ "issue_52_01", "issue_159", "issue_80" ]
[ "filter_0_for_palette_1", "filter_0_for_palette_2", "filter_0_for_palette_4", "filter_0_for_grayscale_16", "filter_1_for_grayscale_16", "filter_1_for_palette_1", "filter_1_for_palette_2", "filter_0_for_grayscale_8", "filter_0_for_grayscale_alpha_8", "filter_0_for_grayscale_alpha_16", "filter_1_f...
[]
[]
148
pest-parser/pest
341
pest-parser__pest-341
[ "338" ]
c0430b34bc6faf8d4ff20bd144c802c9d4aa0065
diff --git a/meta/src/optimizer/restorer.rs b/meta/src/optimizer/restorer.rs --- a/meta/src/optimizer/restorer.rs +++ b/meta/src/optimizer/restorer.rs @@ -66,6 +66,7 @@ fn child_modifies_state( ) -> bool { expr.iter_top_down().any(|expr| match expr { OptimizedExpr::Push(_) => true, + OptimizedExpr...
diff --git a/derive/tests/grammar.pest b/derive/tests/grammar.pest --- a/derive/tests/grammar.pest +++ b/derive/tests/grammar.pest @@ -41,7 +41,9 @@ peek_all = { PUSH(range) ~ PUSH(range) ~ PEEK_ALL } pop_ = { PUSH(range) ~ PUSH(range) ~ POP ~ POP } pop_all = { PUSH(range) ~ PUSH(range) ~ POP_ALL } pop_fail = { PUSH...
Bug: Non-matching rule changes parsing result I created a test repo: https://github.com/flying-sheep/pest-bug It contains two almost identical grammars and a test for each that checks if the parse tree matches my expectations. One of them doesn’t, while it really should. Check out the two grammars: They only differ ...
Looking into this right now. There is a debugger PR #277, but it would need to be rebased in order to work with your branch of pest. Also, really nice minimal example! 👍 The difference is the content of the stack. In `title_two_rules` every time you peek, the stack contains: ``` stack: [" "] stack: [" "] st...
2018-11-15T20:58:31
2.0
35a5b8892c6869e0ed86ca7b67e666e0fce7a797
[ "stack::test::snapshot_twice" ]
[ "error::tests::display_custom_span_three_lines", "error::tests::display_custom_pos", "error::tests::display_custom_span_two_lines", "error::tests::display_custom_span_two_lines_inverted_cols", "error::tests::display_parsing_error_mixed", "error::tests::display_parsing_error_positives", "error::tests::er...
[]
[]
150
petgraph/petgraph
670
petgraph__petgraph-670
[ "586" ]
c32a86b1b8c5c198079efc9149ea2fcf956b8f6c
diff --git a/src/algo/dominators.rs b/src/algo/dominators.rs --- a/src/algo/dominators.rs +++ b/src/algo/dominators.rs @@ -132,9 +132,11 @@ where type Item = N; fn next(&mut self) -> Option<Self::Item> { - for next in self.iter.by_ref() { - if next.1 == &self.node { - return...
diff --git a/src/algo/dominators.rs b/src/algo/dominators.rs --- a/src/algo/dominators.rs +++ b/src/algo/dominators.rs @@ -326,5 +328,6 @@ mod tests { let dom_by: Vec<_> = doms.immediately_dominated_by(1).collect(); assert_eq!(vec![2], dom_by); assert_eq!(None, doms.immediately_dominated_by(9...
immediately_dominated_by function called on root of graph returns root itself Hello petgraph maintainers! While using this amazing crate we stumbled upon 1 small bug. The documentation of the [immediately_dominated_by](https://docs.rs/petgraph/latest/petgraph/algo/dominators/struct.Dominators.html#method.immediately...
2024-09-17T08:42:45
0.6
c32a86b1b8c5c198079efc9149ea2fcf956b8f6c
[ "algo::dominators::tests::test_iter_dominators" ]
[ "algo::simple_paths::test::test_all_simple_paths", "algo::simple_paths::test::test_one_simple_path", "algo::simple_paths::test::test_no_simple_paths", "csr::tests::csr1", "csr::tests::csr_dfs", "algo::tred::test_easy_tred", "csr::tests::csr_from", "csr::tests::csr_from_error_1 - should panic", "csr:...
[]
[]
151
petgraph/petgraph
432
petgraph__petgraph-432
[ "431" ]
c36e48217c2d0c9ede447c446fb1f0779634adc3
diff --git a/src/graphmap.rs b/src/graphmap.rs --- a/src/graphmap.rs +++ b/src/graphmap.rs @@ -80,6 +80,17 @@ enum CompactDirection { Incoming, } +impl CompactDirection { + /// Return the opposite `CompactDirection`. + #[inline] + pub fn opposite(self) -> CompactDirection { + match self { + ...
diff --git a/tests/graphmap.rs b/tests/graphmap.rs --- a/tests/graphmap.rs +++ b/tests/graphmap.rs @@ -82,6 +82,20 @@ fn remov() { assert_eq!(g.neighbors(1).count(), 0); } +#[test] +fn remove_node() { + // From #431 + let mut graph = petgraph::graphmap::DiGraphMap::<u32, ()>::new(); + graph.add_edge(1,...
Removing a node in a directed GraphMap does not remove incoming edges When using a directed GraphMap, removing a node does not remove incoming edges to that node. I believe this is a bug—as far as I can tell, the expected invariant is that a node only has an entry in its adjacency list if the neighbor is in the graph a...
Thanks, I'll look into this.
2021-05-17T01:56:46
0.5
c36e48217c2d0c9ede447c446fb1f0779634adc3
[ "remove_node" ]
[ "algo::dominators::tests::test_iter_dominators", "csr::tests::csr_dfs", "algo::tred::test_easy_tred", "csr::tests::test_edge_references", "dot::test::test_edgeindexlable_option", "dot::test::test_edgenolable_option", "dot::test::test_escape", "dot::test::test_nodeindexlable_option", "dot::test::test...
[]
[]
152
petgraph/petgraph
427
petgraph__petgraph-427
[ "425" ]
9dc94b680a7c3a481fa696930dcc00105475d0f7
diff --git a/src/matrix_graph.rs b/src/matrix_graph.rs --- a/src/matrix_graph.rs +++ b/src/matrix_graph.rs @@ -230,13 +230,23 @@ impl<N, E, Ty: EdgeType, Null: Nullable<Wrapped = E>, Ix: IndexType> }; debug_assert!(node_capacity <= <Ix as IndexType>::max().index()); - m.extend_capacity_for_no...
diff --git a/src/matrix_graph.rs b/src/matrix_graph.rs --- a/src/matrix_graph.rs +++ b/src/matrix_graph.rs @@ -1279,6 +1322,45 @@ mod tests { assert_eq!(g.edge_count(), 2); } + #[test] + /// Adds an edge that triggers a second extension of the matrix. + /// From #425 + fn test_add_edge_with_...
Edge disappearing, or misunderstanding matrix graph? ### Test Case ```rust use petgraph::matrix_graph::DiMatrix; struct Node(u8); fn main() { let mut graph = DiMatrix::<Node, ()>::new(); let n0 = graph.add_node(Node(0)); let n1 = graph.add_node(Node(1)); let n2 = graph.add_node(Node(2));...
2021-05-13T02:55:51
0.5
c36e48217c2d0c9ede447c446fb1f0779634adc3
[ "matrix_graph::tests::test_add_edge_with_extension" ]
[ "csr::tests::csr1", "csr::tests::csr_from_error_1 - should panic", "csr::tests::test_edge_references", "dot::test::test_edgeindexlable_option", "dot::test::test_edgenolable_option", "dot::test::test_escape", "dot::test::test_nodeindexlable_option", "dot::test::test_nodenolable_option", "csr::tests::...
[]
[]
153
petgraph/petgraph
415
petgraph__petgraph-415
[ "412" ]
944057cdc57824f90a36f838f3ee7f148157c801
diff --git a/src/graph_impl/stable_graph/mod.rs b/src/graph_impl/stable_graph/mod.rs --- a/src/graph_impl/stable_graph/mod.rs +++ b/src/graph_impl/stable_graph/mod.rs @@ -78,10 +78,14 @@ pub struct StableGraph<N, E, Ty = Directed, Ix = DefaultIx> { // node and edge free lists (both work the same way) // ...
diff --git a/src/graph_impl/stable_graph/mod.rs b/src/graph_impl/stable_graph/mod.rs --- a/src/graph_impl/stable_graph/mod.rs +++ b/src/graph_impl/stable_graph/mod.rs @@ -1815,3 +1864,25 @@ fn test_retain_nodes() { gr.check_free_lists(); } + +#[test] +fn extend_with_edges() { + let mut gr = StableGraph::<_, ...
Panic in StableGraph::extend_with_edges ### Test Case ```rust let mut gr = StableGraph::<_, _>::default(); let a = gr.add_node("a"); let b = gr.add_node("b"); let c = gr.add_node("c"); let _d = gr.add_node("d"); gr.remove_node(a); gr.remove_node(b); gr.remove_node(c); gr.extend_with_edges(vec![(0,1,())]); ...
2021-04-20T07:28:25
0.5
c36e48217c2d0c9ede447c446fb1f0779634adc3
[ "graph_impl::stable_graph::extend_with_edges" ]
[ "algo::dominators::tests::test_iter_dominators", "algo::tred::test_easy_tred", "csr::tests::csr1", "csr::tests::csr_dfs", "csr::tests::csr_from", "csr::tests::csr_from_error_1 - should panic", "csr::tests::csr_from_error_2 - should panic", "csr::tests::csr_tarjan", "csr::tests::csr_undirected", "c...
[]
[]
154
petgraph/petgraph
303
petgraph__petgraph-303
[ "288" ]
d4681eaf1a87be34c7bf95c51edb1984d329002b
diff --git a/src/algo/mod.rs b/src/algo/mod.rs --- a/src/algo/mod.rs +++ b/src/algo/mod.rs @@ -6,7 +6,7 @@ pub mod dominators; -use std::collections::BinaryHeap; +use std::collections::{BinaryHeap, HashMap}; use std::cmp::min; use crate::prelude::*; diff --git a/src/algo/mod.rs b/src/algo/mod.rs --- a/src/algo...
diff --git a/tests/stable_graph.rs b/tests/stable_graph.rs --- a/tests/stable_graph.rs +++ b/tests/stable_graph.rs @@ -7,7 +7,7 @@ extern crate itertools; use petgraph::prelude::*; use petgraph::stable_graph::node_index as n; use petgraph::EdgeType; -use petgraph::algo::{kosaraju_scc, tarjan_scc}; +use petgraph::alg...
StableGraph::from_elements(min_spanning_tree(&graph)) asserts that node does not exist in graph ### Test Case Here's the JSON-serialized representation of the `Undirected` `StableGraph` I'm using: https://gist.github.com/bonsairobo/1897e608f031cf076ca09df12f5665c3 ### Steps To Reproduce Load the graph and call...
Even simpler graph with the same problem: JSON: ``` {"nodes":[17,25,26,27,30,48,56,69,73,82,85,91,96],"node_holes":[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,18,19,20,21,22,23,24,28,29,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,49,50,51,52,53,54,55,57,58,59,60,61,62,63,64,65,66,67,68,70,71,72,74,75,76,77,78...
2019-12-19T12:56:00
0.4
1102680bb563643e63afae66aef8de22434d97e7
[ "from_min_spanning_tree" ]
[ "algo::dominators::tests::test_iter_dominators", "csr::tests::csr1", "csr::tests::csr_dfs", "csr::tests::csr_from", "csr::tests::csr_from_error_1 - should panic", "csr::tests::csr_from_error_2 - should panic", "csr::tests::csr_tarjan", "csr::tests::csr_undirected", "csr::tests::test_add_node", "cs...
[]
[]
155
petgraph/petgraph
286
petgraph__petgraph-286
[ "281" ]
cb6420b3252c1d951857ace44ddb377354475d7d
diff --git a/src/graphmap.rs b/src/graphmap.rs --- a/src/graphmap.rs +++ b/src/graphmap.rs @@ -348,6 +348,7 @@ impl<N, E, Ty> GraphMap<N, E, Ty> Some(neigh) => neigh.iter(), None => [].iter(), }, + start_node: a, dir: dir, ty: self.ty, ...
diff --git a/tests/graphmap.rs b/tests/graphmap.rs --- a/tests/graphmap.rs +++ b/tests/graphmap.rs @@ -298,4 +298,41 @@ fn test_all_edges_mut() { for (start, end, weight) in graph.all_edges() { assert_eq!((start + end) * 2, *weight); } -} \ No newline at end of file +} + +#[test] +fn neighbors_incomi...
Listing incoming nodes for digraphmap <!-- ************************ BUG REPORTS *************************** --> ### Test Case ```rust use ::petgraph::{ graphmap::DiGraphMap, Direction}; fn main() { let mut graph: DiGraphMap<u32, u32> = DiGraphMap::new(); let n0 = graph.add_node(0); let n1 = gra...
I had a look at the implementation of `add_edge()` and found this comment: https://github.com/petgraph/petgraph/blob/98fb3ff6c5ae60912db87aec283c7703ed8357ce/src/graphmap.rs#L247-L252 I'm not quite sure what was the reasoning behind this, but IMO this is a bug. I'll try digging a bit in the repo's history to find ou...
2019-10-09T02:40:37
0.4
1102680bb563643e63afae66aef8de22434d97e7
[ "neighbors_incoming_includes_self_loops" ]
[ "csr::tests::csr_dfs", "algo::dominators::tests::test_iter_dominators", "csr::tests::csr_tarjan", "csr::tests::csr_from_error_2 - should panic", "csr::tests::csr_from_error_1 - should panic", "csr::tests::csr1", "csr::tests::csr_undirected", "csr::tests::test_add_node", "csr::tests::csr_from", "cs...
[]
[]
156
postgresml/pgcat
835
postgresml__pgcat-835
[ "829" ]
3935366d86737a13a584d7bcf87c70c797ebe9f7
diff --git a/src/query_router.rs b/src/query_router.rs --- a/src/query_router.rs +++ b/src/query_router.rs @@ -386,6 +386,18 @@ impl QueryRouter { } } + /// Determines if a query is mutable or not. + fn query_is_mutable_statement(q: &sqlparser::ast::Query) -> bool { + use sqlparser::ast::*;...
diff --git a/src/query_router.rs b/src/query_router.rs --- a/src/query_router.rs +++ b/src/query_router.rs @@ -1113,6 +1126,26 @@ mod test { assert_eq!(qr.role(), None); } + #[test] + fn test_split_cte_queries() { + QueryRouter::setup(); + let mut qr = QueryRouter::new(); + qr...
Splitting of read/write queries to replicas fail for CTEs **Describe the bug** When `query_parser_read_write_splitting` is set to `true` and `primary_reads_enabled` set to `false`, any query that is sent as a CTE (thus, WITH ... UPDATE ... RETURNING ... SELECT) is incorrectly identified as having the ability to be spl...
2024-10-17T02:19:21
1.2
3935366d86737a13a584d7bcf87c70c797ebe9f7
[ "query_router::test::test_split_cte_queries" ]
[ "messages::tests::parse_fields", "dns_cache::tests::new", "dns_cache::tests::incorrect_address", "dns_cache::tests::has_changed", "dns_cache::tests::lookup_ip", "dns_cache::tests::thread", "dns_cache::tests::unknown_host", "config::test::test_config", "config::test::test_serialize_configs", "query...
[]
[]
157
cloudflare/pingora
211
cloudflare__pingora-211
[ "186" ]
7ce6f4ac1c440756a63b0766f72dbeca25c6fc94
diff --git a/.bleep b/.bleep --- a/.bleep +++ b/.bleep @@ -1,1 +1,1 @@ -836062d709916982c97b1990f56e446f834e610d \ No newline at end of file +fa95ba9cdfb9a347913e0cffbb84ca003833ccaa diff --git a/.rustfmt.toml b/.rustfmt.toml --- a/.rustfmt.toml +++ b/.rustfmt.toml @@ -0,0 +1,1 @@ +edition = "2021" diff --git a/pingora...
diff --git a/pingora-core/src/protocols/http/v1/server.rs b/pingora-core/src/protocols/http/v1/server.rs --- a/pingora-core/src/protocols/http/v1/server.rs +++ b/pingora-core/src/protocols/http/v1/server.rs @@ -1088,10 +1097,10 @@ mod tests_stream { .build(); let mut http_stream = HttpSession::new...
TinyUFO unable to run benches ## Describe the bug When running TinyUFO (benches / tests) I am getting an error due to the Bucket struct not being publicly usable for the `bucket.rs` file. ## Pingora info Please include the following information about your environment: **Pingora version**: 0.1.1 **Rust vers...
2024-04-20T02:33:34
0.1
7ce6f4ac1c440756a63b0766f72dbeca25c6fc94
[ "test_lru_unit::test_remove", "test_lru_unit::test_insert_tail" ]
[ "estimator::tests::desc", "estimator::tests::get", "estimator::tests::incr", "estimator::tests::reset", "inflight::tests::inflight_count", "rate::tests::test_observe_rate", "linked_list::test::test_exist_near_head", "linked_list::test::test_pop", "linked_list::test::test_insert", "test_lru::test_a...
[]
[]
158
cloudflare/pingora
219
cloudflare__pingora-219
[ "186" ]
7ce6f4ac1c440756a63b0766f72dbeca25c6fc94
diff --git a/.bleep b/.bleep --- a/.bleep +++ b/.bleep @@ -1,1 +1,1 @@ -836062d709916982c97b1990f56e446f834e610d \ No newline at end of file +fa95ba9cdfb9a347913e0cffbb84ca003833ccaa \ No newline at end of file diff --git a/.rustfmt.toml b/.rustfmt.toml --- a/.rustfmt.toml +++ b/.rustfmt.toml @@ -0,0 +1,1 @@ +edition =...
diff --git a/pingora-core/src/protocols/http/v1/server.rs b/pingora-core/src/protocols/http/v1/server.rs --- a/pingora-core/src/protocols/http/v1/server.rs +++ b/pingora-core/src/protocols/http/v1/server.rs @@ -1088,10 +1097,10 @@ mod tests_stream { .build(); let mut http_stream = HttpSession::new...
TinyUFO unable to run benches ## Describe the bug When running TinyUFO (benches / tests) I am getting an error due to the Bucket struct not being publicly usable for the `bucket.rs` file. ## Pingora info Please include the following information about your environment: **Pingora version**: 0.1.1 **Rust vers...
2024-04-22T23:27:20
0.1
7ce6f4ac1c440756a63b0766f72dbeca25c6fc94
[ "test_lru_unit::test_insert_tail", "test_lru_unit::test_remove" ]
[ "estimator::tests::incr", "estimator::tests::desc", "estimator::tests::get", "estimator::tests::reset", "inflight::tests::inflight_count", "rate::tests::test_observe_rate", "linked_list::test::test_exist_near_head", "linked_list::test::test_pop", "test_lru_unit::test_evict", "test_lru_unit::test_a...
[]
[]
159
plotters-rs/plotters
378
plotters-rs__plotters-378
[ "368" ]
e29840cfbf0c7aa0654d6033679a45ad02944ddb
diff --git a/plotters-bitmap/src/bitmap.rs b/plotters-bitmap/src/bitmap.rs --- a/plotters-bitmap/src/bitmap.rs +++ b/plotters-bitmap/src/bitmap.rs @@ -252,12 +252,12 @@ impl<'a, P: PixelFormat> DrawingBackend for BitMapBackend<'a, P> { if (from.0 == to.0 || from.1 == to.1) && style.stroke_width() == 1 { ...
diff --git a/.github/workflows/plotters-core.yml b/.github/workflows/plotters-core.yml --- a/.github/workflows/plotters-core.yml +++ b/.github/workflows/plotters-core.yml @@ -63,7 +63,7 @@ jobs: - uses: actions-rs/cargo@v1 with: command: test - args: --verbose --no-default-features --lib...
[BUG] `DrawingArea::fill` doesn't fill the right and bottom edge in some backends **Describe the bug** `DrawingArea::fill` doesn't fill the right and bottom edge in some backends and leaves transparent edges in a generated image. As far as I have checked, [plotters-svg](https://github.com/plotters-rs/plotters-svg) and...
`plotters-cairo` has the same issue. Adding the code below to the example in `gtk-demo` generated the red edge. ```rust // ↓ Added root.draw(&Rectangle::new( [(0, 0), (500, 500)], ShapeStyle { color: RGBAColor(255, 0, 0, 1.0), filled: true...
2022-06-25T11:41:53
0.3
e29840cfbf0c7aa0654d6033679a45ad02944ddb
[ "drawing::area::drawing_area_tests::test_margin", "drawing::area::drawing_area_tests::test_relative_shrink" ]
[ "chart::builder::test::test_label_area_size", "chart::builder::test::test_margin_configure", "coord::ranged1d::combinators::ckps::test::test_with_key_points", "coord::ranged1d::combinators::ckps::test::test_with_key_point_method", "coord::ranged1d::combinators::group_by::test::test_group_by", "coord::rang...
[ "plotters/src/chart/state.rs - chart::state::ChartState (line 15)", "plotters/src/lib.rs - (line 450)", "plotters/src/lib.rs - (line 472)", "plotters/src/lib.rs - (line 500)", "plotters/src/lib.rs - (line 308)", "plotters/src/lib.rs - (line 568)" ]
[ "plotters/src/element/mod.rs - element (line 20)", "plotters/src/element/mod.rs - element (line 73)" ]
160
probe-rs/probe-rs
2,832
probe-rs__probe-rs-2832
[ "2810" ]
0eaed1a2461caafdfdaf3cd6c1a5cafa7013ab52
diff --git /dev/null b/changelog/fixed-flash-algo-crash.md new file mode 100644 --- /dev/null +++ b/changelog/fixed-flash-algo-crash.md @@ -0,0 +1,1 @@ +Fixed crashes when processing flash algorithm data of devices with small RAM. \ No newline at end of file diff --git a/probe-rs-target/src/chip_family.rs b/probe-rs-ta...
diff --git a/probe-rs-target/src/memory.rs b/probe-rs-target/src/memory.rs --- a/probe-rs-target/src/memory.rs +++ b/probe-rs-target/src/memory.rs @@ -589,4 +591,82 @@ mod test { assert_eq!(range.start, 4); assert_eq!(range.end, 16); } + + #[test] + fn merge_consecutive_outputs_single_regio...
Overflow panic can occur when calculating ram_for_data in flash algorithm with very little ram **Describe the bug** I was using probe-rs with a newly generated target file for the MSPM0C1104. The generated target file did not contain a stack size and therefore a default stack usage of `512` bytes was picked. This dev...
So... fix your target descriptor?
2024-09-29T21:50:34
0.24
0549f3ce312b94ebd6ee546734ae935f4b80acea
[ "memory::test::merge_consecutive_separates_ranges_with_different_cores" ]
[ "memory::test::contains_range3", "memory::test::contains_range2", "memory::test::contains_range1", "memory::test::contains_range4", "memory::test::contains_range5", "memory::test::contains_range6", "memory::test::intersects_range1", "memory::test::intersects_range2", "memory::test::intersects_range4...
[]
[]
161
PRQL/prql
4,931
PRQL__prql-4931
[ "4878" ]
7d83e65c666a00d1653f29d2732fdad10e5fd1ca
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,9 @@ odd number of quotes when being formatted. The previous implementation would use an even number, which is invalid PRQL. (@max-sixty, #4850) +- A few more keywords are quoted, such as `user`, which is a reserved keyw...
diff --git a/prqlc/prqlc/src/sql/gen_query.rs b/prqlc/prqlc/src/sql/gen_query.rs --- a/prqlc/prqlc/src/sql/gen_query.rs +++ b/prqlc/prqlc/src/sql/gen_query.rs @@ -709,7 +709,7 @@ mod test { let sql_ast = crate::tests::compile(query).unwrap(); - assert_snapshot!(sql_ast, @r###" + assert_snapsh...
Converting quotes properly to double quotes in Postgres in custom field name scenario ### What happened? When using quotes in field names, it should properly convert them to double quotes, but PRQL just removes them. Note the quoted `sum_income` part that converts to sum_income without any quotes. ### PRQL inp...
Thanks for the issue. Currently PRQL evaluates that ident as not requiring quotes — are they required? Thanks for the quick reply. In most of the cases they are not required. The scenario I am working on is if a user entered text of the field name is a reserved word by Postgres. In that case I add quotes and expect...
2024-10-02T10:55:37
1.70
7d83e65c666a00d1653f29d2732fdad10e5fd1ca
[ "sql::keywords::test_sql_keywords" ]
[ "codegen::ast::test::test_query_def", "codegen::ast::test::test_double_braces", "codegen::ast::test::test_annotation", "codegen::ast::test::test_escaped_string", "codegen::ast::test::test_func", "codegen::ast::test::test_simple", "codegen::ast::test::test_alias", "codegen::ast::test::test_unary", "s...
[ "queries::results::aggregation", "queries::results::arithmetic", "queries::results::invoice_totals", "queries::results::loop_01", "queries::results::distinct_on", "queries::results::constants_only", "queries::results::math_module", "queries::results::sort", "queries::results::switch", "queries::re...
[]
162
PRQL/prql
3,846
PRQL__prql-3846
[ "3835" ]
283c72ee6ea5ed62afda6dce5a48bdd74f9ebc4a
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ **Fixes**: +- Fix an issue with arithmetic precedence (@max-sixty, #3846) + **Documentation**: **Web**: diff --git a/prqlc/prql-compiler/src/sql/gen_expr.rs b/prqlc/prql-compiler/src/sql/gen_expr.rs --- a/prqlc/prq...
diff --git a/prqlc/prql-compiler/tests/sql/sql.rs b/prqlc/prql-compiler/tests/sql/sql.rs --- a/prqlc/prql-compiler/tests/sql/sql.rs +++ b/prqlc/prql-compiler/tests/sql/sql.rs @@ -51,6 +51,23 @@ fn json_of_test() { #[test] fn test_precedence() { + assert_display_snapshot!((compile(r###" + from artists + der...
a-(b+c) becomes a-b+c ### What happened? wrong operator precedence ### PRQL input ```elm from foo select a - (b + c) ``` ### SQL output ```SQL SELECT a - b + c FROM foo ``` ### Expected SQL output ```SQL SELECT a - (b + c) FROM foo ``` ### MVCE confirmation - [x] Minimal example - [x] New iss...
I'm not sure how this happened. I'm looking into it now. I thought I fixed a bunch of complicated precedence problems — seems like I missed a very simple one?!
2023-11-25T04:16:17
1.65
283c72ee6ea5ed62afda6dce5a48bdd74f9ebc4a
[ "sql::test_precedence" ]
[ "codegen::ast::test::test_double_braces", "codegen::ast::test::test_escaped_string", "codegen::ast::test::test_simple", "semantic::module::tests::test_module", "semantic::module::tests::test_module_shadow_unshadow", "codegen::ast::test::test_range", "codegen::ast::test::test_unary", "codegen::ast::tes...
[ "test_rdbms" ]
[]
163
PRQL/prql
218
PRQL__prql-218
[ "213" ]
a5b708001601a58ee0acb69139118cdd492e8647
diff --git a/src/materializer.rs b/src/materializer.rs --- a/src/materializer.rs +++ b/src/materializer.rs @@ -64,6 +64,19 @@ impl AstFold for ReplaceVariables { } .into_unnested()) } + // Once we get to an Aggregate, we want to run the replacement, but then we + // want to remove the varia...
diff --git a/src/materializer.rs b/src/materializer.rs --- a/src/materializer.rs +++ b/src/materializer.rs @@ -649,4 +662,55 @@ take 20 Ok(()) } + + #[test] + fn test_variable_after_aggregate() -> Result<()> { + let ast = parse( + r#" +from employees +aggregate by:[emp_no] [ + e...
Scope variables within splits We're currently getting `AVG(AVG(salary)) AS avg_salary,` in https://github.com/max-sixty/prql/issues/194: ```sql WITH table_0 AS ( SELECT AVG(salary) AS emp_salary, * FROM employees LEFT JOIN salaries ON salaries.emp_no = employees.emp_no GROUP BY emp...
2022-03-21T04:01:19
1.58
a5b708001601a58ee0acb69139118cdd492e8647
[ "materializer::test::test_variable_after_aggregate", "materializer::test::test_replace_variables", "materializer::test::test_materialize", "translator::test::test_prql_to_sql", "transpile_joins", "transpile_variables" ]
[ "ast::test::test_into_unnested", "materializer::test::test_named_args", "parser::test::test_parse_filter", "materializer::test::test_run_functions_no_arg", "parser::test::test_parse_func_call", "parser::test::test_parse_aggregate", "materializer::test::test_run_functions_args", "parser::test::test_inl...
[]
[]
164
pulldown-cmark/pulldown-cmark
930
pulldown-cmark__pulldown-cmark-930
[ "927" ]
2f2928992ec643811c06e5d3de06ede53b26afa0
diff --git a/pulldown-cmark/specs/footnotes.txt b/pulldown-cmark/specs/footnotes.txt --- a/pulldown-cmark/specs/footnotes.txt +++ b/pulldown-cmark/specs/footnotes.txt @@ -396,11 +396,8 @@ Test case for the relationship between link references and footnotes. GitHub writes `My [cmark-gfm]<sup class="footnote-referenc...
diff --git a/pulldown-cmark/specs/footnotes.txt b/pulldown-cmark/specs/footnotes.txt --- a/pulldown-cmark/specs/footnotes.txt +++ b/pulldown-cmark/specs/footnotes.txt @@ -423,7 +420,7 @@ My [otherlink[^c]]. [otherlink[^c]]: https://github.com/github/cmark-gfm/blob/1e230827a584ebc9938c3eadc5059c55ef3c9abf/test/extens...
[regression in 0.10] Consecutive footnote refs fail to parse correctly Consider the following markdown: ``` Lorem ipsum.[^a][^b] [^a]: Foo [^b]: Bar ``` Which on GitHub, renders thus: Lorem ipsum.[^a][^b] [^a]: Foo [^b]: Bar With pulldown-cmark **v0.9.6**, these were correctly parsed as two consec...
There also appears to be a difference in the footnote definition between 0.9. and 0.11 using the "old footnotes" behavior. I'd expect them to still produce the same footnote definitions, but 0.11 returns an incorrect text for footnote definition B here: On 0.9: ``` 32..42: Start(FootnoteDefinition(Borrowed("b"))...
2024-08-13T05:25:39
0.11
95cb4f47c544c3a8f2b3451eada45b80d3d0e82c
[ "suite::footnotes::footnotes_test_16" ]
[ "firstpass::simd::simd_test::border_skip", "firstpass::simd::simd_test::simple_match", "firstpass::simd::simd_test::long_match", "firstpass::simd::simd_test::single_open_fish", "firstpass::simd::simd_test::simple_no_match", "linklabel::test::return_carriage_linefeed_ok", "parse::test::issue_289", "par...
[]
[]
166
pulldown-cmark/pulldown-cmark
925
pulldown-cmark__pulldown-cmark-925
[ "923" ]
4e9bc2ccb10ed271855dfbd771e588795a2d4b92
diff --git a/pulldown-cmark/src/parse.rs b/pulldown-cmark/src/parse.rs --- a/pulldown-cmark/src/parse.rs +++ b/pulldown-cmark/src/parse.rs @@ -720,6 +720,8 @@ impl<'input, F: BrokenLinkCallback<'input>> Parser<'input, F> { self.tree[tos.node].child = None; ...
diff --git a/pulldown-cmark/src/parse.rs b/pulldown-cmark/src/parse.rs --- a/pulldown-cmark/src/parse.rs +++ b/pulldown-cmark/src/parse.rs @@ -2321,6 +2323,29 @@ mod test { assert_eq!(12..16, range); } + #[test] + fn footnote_offsets_exclamation() { + let mut immediately_before_footnote = N...
Exclamation point before footnote causes footnote reference event to be incorrect ``` Hello, world![^footnote] This is some text. [^footnote]: This is the footnote. ``` Events with ranges: ``` Raw event: Some((Start(Paragraph), 0..44)) Raw event: Some((Text(Borrowed("Hello, world")), 0..12)) Raw event: So...
2024-08-11T04:43:37
0.11
95cb4f47c544c3a8f2b3451eada45b80d3d0e82c
[ "parse::test::footnote_offsets_exclamation" ]
[ "firstpass::simd::simd_test::long_match", "firstpass::simd::simd_test::border_skip", "firstpass::simd::simd_test::simple_match", "firstpass::simd::simd_test::single_open_fish", "linklabel::test::return_carriage_linefeed_ok", "firstpass::simd::simd_test::simple_no_match", "parse::test::another_emphasis_p...
[]
[]
167
pulldown-cmark/pulldown-cmark
829
pulldown-cmark__pulldown-cmark-829
[ "828" ]
a5c0e64ccb7c0bba00ce8c0ce19c00f8eca94b29
diff --git a/src/parse.rs b/src/parse.rs --- a/src/parse.rs +++ b/src/parse.rs @@ -131,6 +131,7 @@ impl ItemBody { | ItemBody::TableHead | ItemBody::TableRow | ItemBody::TableCell + | ItemBody::Heading(..) ) } } diff --git a/src/parse.rs b...
diff --git a/specs/regression.txt b/specs/regression.txt --- a/specs/regression.txt +++ b/specs/regression.txt @@ -2224,3 +2224,29 @@ invalid unicode is replaced with the unknown U+FFFD. . <p>�</p> ```````````````````````````````` + +ISSUE 828 + +```````````````````````````````` example +- _t + # test + t_ +. +<ul...
[fuzz result] tight lists can wrap atx header within emphasis Similar to https://github.com/raphlinus/pulldown-cmark/issues/797 ```console $ cargo run Finished dev [unoptimized + debuginfo] target(s) in 0.02s Running `target/debug/pulldown-cmark` - _t # test t_ <ul> <li><em>t <h1>test</h1> t</...
2024-01-27T12:37:09
0.9
a5c0e64ccb7c0bba00ce8c0ce19c00f8eca94b29
[ "suite::regression::regression_test_164", "suite::regression::regression_test_165" ]
[ "escape::simd::html_scan_tests::multichunk", "escape::test::check_href_escape", "escape::simd::html_scan_tests::only_right_bytes_matched", "firstpass::simd::simd_test::border_skip", "firstpass::simd::simd_test::long_match", "firstpass::simd::simd_test::simple_match", "firstpass::simd::simd_test::simple_...
[]
[]
168
pulldown-cmark/pulldown-cmark
822
pulldown-cmark__pulldown-cmark-822
[ "662" ]
340b2c3efa84b28d103eec668137e9fc007e436f
diff --git a/specs/regression.txt b/specs/regression.txt --- a/specs/regression.txt +++ b/specs/regression.txt @@ -114,7 +114,6 @@ ISSUE #43 (2) <p>make something</p> </li> </ul> - ```````````````````````````````` ISSUE #239 diff --git a/src/firstpass.rs b/src/firstpass.rs --- a/src/firstpass.rs +++ b/src/firstp...
diff --git a/specs/regression.txt b/specs/regression.txt --- a/specs/regression.txt +++ b/specs/regression.txt @@ -2250,3 +2249,115 @@ t_</li> N*</li> </ul> ```````````````````````````````` + +ISSUE 662 + +```````````````````````````````` example + + <foo> +. + <foo> +```````````````````````````````` + +````````````...
HTML block loses initial indentation Events from pulldown-cmark: ```rust "\n <foo>" -> [ Html(Boxed("<foo>")) ] ``` Events from commonmark.js: ```rust "\n <foo>" -> [ Html(Boxed(" <foo>")) ] ``` XML from [commonmark.js](https://spec.commonmark.org/dingus/?text=%0A%20%3Cfoo%3E): ```xml <?xml ...
This bug keeps happening after merging #704.
2024-01-27T00:28:32
0.9
a5c0e64ccb7c0bba00ce8c0ce19c00f8eca94b29
[ "suite::regression::regression_test_166", "suite::regression::regression_test_168", "suite::regression::regression_test_170", "suite::regression::regression_test_171", "suite::regression::regression_test_173", "suite::regression::regression_test_174", "suite::regression::regression_test_175", "suite::...
[ "escape::simd::html_scan_tests::multichunk", "escape::test::check_attr_escape", "escape::test::check_body_escape", "escape::simd::html_scan_tests::only_right_bytes_matched", "escape::test::check_href_escape", "firstpass::simd::simd_test::border_skip", "firstpass::simd::simd_test::long_match", "firstpa...
[]
[]
169
pulldown-cmark/pulldown-cmark
820
pulldown-cmark__pulldown-cmark-820
[ "819" ]
241eb484999a923141b343816bc275bc46e0e280
diff --git a/src/firstpass.rs b/src/firstpass.rs --- a/src/firstpass.rs +++ b/src/firstpass.rs @@ -1319,7 +1319,12 @@ impl<'a, 'b> FirstPass<'a, 'b> { self.parse_line(ix, Some(content_end), TableParseMode::Disabled); (header_end, content_end, attrs) } else { - ix = self.par...
diff --git a/tests/html.rs b/tests/html.rs --- a/tests/html.rs +++ b/tests/html.rs @@ -325,3 +325,27 @@ fn trim_space_before_soft_break() { html::push_html(&mut s, Parser::new(&original)); assert_eq!(expected, s); } + +// Can't easily use regression.txt due to newline normalization. +#[test] +fn issue_819() ...
[fuzz result] misparse on single-line header with backslash Events from pulldown-cmark: ```rust "# \\\n\n\n" -> [ Start(Heading { level: H1, id: None, classes: [], attrs: [] }) End(Heading(H1)) ] ``` Events from pandoc: ```rust "# \\\n\n\n" -> [ Start(Heading { level: H1, id: None, classes: [], at...
2024-01-23T04:47:17
0.9
a5c0e64ccb7c0bba00ce8c0ce19c00f8eca94b29
[ "issue_819" ]
[ "escape::simd::html_scan_tests::multichunk", "escape::simd::html_scan_tests::only_right_bytes_matched", "escape::test::check_href_escape", "firstpass::simd::simd_test::border_skip", "firstpass::simd::simd_test::long_match", "firstpass::simd::simd_test::simple_no_match", "firstpass::simd::simd_test::simp...
[]
[]
170
cloudflare/quiche
615
cloudflare__quiche-615
[ "614" ]
2e787686b0dd6630345ae47f46b2332506f1e488
diff --git a/src/lib.rs b/src/lib.rs --- a/src/lib.rs +++ b/src/lib.rs @@ -1568,7 +1568,14 @@ impl Connection { let payload_len = if hdr.ty == packet::Type::Short { b.cap() } else { - b.get_varint()? as usize + b.get_varint().map_err(|e| { + drop_pkt_o...
diff --git a/src/lib.rs b/src/lib.rs --- a/src/lib.rs +++ b/src/lib.rs @@ -7080,6 +7087,46 @@ mod tests { // Make sure client's PTO timer is armed. assert!(pipe.client.timeout().is_some()); } + + #[test] + /// Tests that packets with corrupted type (from Handshake to Initial) are + /// p...
quiche should not close connection when Handshake packet is corrupted into an Initial [quiche-neqo2.zip](https://github.com/cloudflare/quiche/files/5024526/quiche-neqo2.zip) see server/log.txt line 16470. Quiche thinks it receives an initial packet, it's invalid, and the server sends ConnectionClose. see output.t...
Thanks for reporting @agrover! I was able to reproduce this in a test case, need to figure out why the error is returned instead of ignoring the packet.
2020-08-05T20:10:45
0.5
46f7bf9850a7b3536a983362554183ae60d6c774
[ "tests::handshake_packet_type_corruption" ]
[ "crypto::tests::derive_chacha20_secrets", "frame::tests::crypto", "frame::tests::data_blocked", "frame::tests::application_close", "frame::tests::connection_close", "crypto::tests::derive_initial_secrets", "frame::tests::handshake_done", "crypto::tests::derive_initial_secrets_old", "frame::tests::ma...
[ "packet::tests::decrypt_chacha20", "packet::tests::decrypt_client_initial", "packet::tests::decrypt_client_initial_old", "packet::tests::decrypt_server_initial", "packet::tests::decrypt_server_initial_old", "packet::tests::encrypt_chacha20", "packet::tests::encrypt_client_initial", "packet::tests::enc...
[]
175
BurntSushi/quickcheck
185
BurntSushi__quickcheck-185
[ "143" ]
02e24a9e88ac30f3068dec3c3e03631c3ac29cb0
diff --git a/src/arbitrary.rs b/src/arbitrary.rs --- a/src/arbitrary.rs +++ b/src/arbitrary.rs @@ -569,16 +569,14 @@ macro_rules! unsigned_shrinker { } macro_rules! unsigned_arbitrary { - ($($ty:ty),*) => { + ($($ty:tt),*) => { $( impl Arbitrary for $ty { fn arbitrary<G:...
diff --git a/src/tester.rs b/src/tester.rs --- a/src/tester.rs +++ b/src/tester.rs @@ -371,7 +371,8 @@ impl<A: Arbitrary + Debug> AShow for A {} #[cfg(test)] mod test { - use QuickCheck; + use {QuickCheck, StdGen}; + use rand; #[test] fn shrinking_regression_issue_126() { diff --git a/src/teste...
Increasing size creates problems when generating arbitrary i8 The Arbitrary implementation for integers does not handle large size correctly, which means that generating i8 often fails if you bump the size. They should saturate at the maximum value of the type instead of truncating. As it is now you can run into the lo...
2017-10-24T09:11:12
0.4
02e24a9e88ac30f3068dec3c3e03631c3ac29cb0
[ "tester::test::size_for_small_types_issue_143" ]
[ "arbitrary::test::arby_uint", "arbitrary::test::arby_int", "arbitrary::test::bools", "arbitrary::test::arby_unit", "arbitrary::test::binaryheaps", "arbitrary::test::btreemap", "arbitrary::test::btreesets", "arbitrary::test::chars", "arbitrary::test::floats32", "arbitrary::test::floats64", "arbit...
[]
[]
176
quinn-rs/quinn
1,869
quinn-rs__quinn-1869
[ "1818" ]
540296c26849fbbf5cdb7923d0d798159df503fa
diff --git a/quinn-proto/src/connection/assembler.rs b/quinn-proto/src/connection/assembler.rs --- a/quinn-proto/src/connection/assembler.rs +++ b/quinn-proto/src/connection/assembler.rs @@ -200,10 +200,6 @@ impl Assembler { } } - pub(super) fn set_bytes_read(&mut self, new: u64) { - self.byte...
diff --git a/quinn-proto/src/connection/streams/recv.rs b/quinn-proto/src/connection/streams/recv.rs --- a/quinn-proto/src/connection/streams/recv.rs +++ b/quinn-proto/src/connection/streams/recv.rs @@ -386,3 +400,105 @@ impl Default for RecvState { Self::Recv { size: None } } } + +#[cfg(test)] +mod test...
Underflow computing growth in stream data flow control credit We've encountered a panic in `quinn-proto-0.10.4`. We're using `quinn-0.10.2` with `libp2p-0.53.1`. ``` thread 'main' panicked at HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quinn-proto-0.10.4/src/connection/streams/recv.rs:108:20: attempt...
Thanks for the report! > Full Backtrace This is the backtrace for the poisoned mutex panic, not the original underflow panic that caused it. You'll want to look just above in the logs. > [let diff = max_stream_data - self.sent_max_stream_data;](https://github.com/quinn-rs/quinn/blob/main/quinn-proto/src/connec...
2024-05-19T03:11:04
0.11
540296c26849fbbf5cdb7923d0d798159df503fa
[ "connection::streams::recv::tests::reordered_frames_while_stopped" ]
[ "cid_queue::tests::insert_duplicate", "cid_generator::tests::validate_keyed_cid", "cid_queue::tests::insert_retired", "cid_queue::tests::insert_limit", "cid_queue::tests::next_dense", "cid_queue::tests::always_valid", "cid_queue::tests::next_sparse", "cid_queue::tests::retire_dense", "cid_queue::tes...
[]
[]
177
quinn-rs/quinn
1,837
quinn-rs__quinn-1837
[ "1832" ]
8c89b79e15573886d3fb1eccc8dcbb2a8872f6b9
diff --git a/quinn-proto/src/connection/datagrams.rs b/quinn-proto/src/connection/datagrams.rs --- a/quinn-proto/src/connection/datagrams.rs +++ b/quinn-proto/src/connection/datagrams.rs @@ -7,7 +7,6 @@ use tracing::{debug, trace}; use super::Connection; use crate::{ frame::{Datagram, FrameStruct}, - packet::...
diff --git a/quinn-proto/src/tests/mod.rs b/quinn-proto/src/tests/mod.rs --- a/quinn-proto/src/tests/mod.rs +++ b/quinn-proto/src/tests/mod.rs @@ -3012,3 +3012,55 @@ fn stream_gso() { let final_ios = pair.client_conn_mut(client_ch).stats().udp_tx.ios; assert_eq!(final_ios - initial_ios, 2); } + +#[test] +fn ...
GSO padding has high overhead for application datagrams larger than half MTU For example, if an application is on a path with a 1500 byte MTU and is sending large numbers of 1200 byte datagrams (e.g. tunneling traffic from a non-MTU-aware protocol), up to 25% of bandwidth will be spent padding 1200 byte QUIC packets to...
2024-04-27T09:30:42
0.11
540296c26849fbbf5cdb7923d0d798159df503fa
[ "tests::gso_truncation", "tests::datagram_gso" ]
[ "cid_queue::tests::insert_limit", "cid_queue::tests::always_valid", "cid_queue::tests::insert_retired", "cid_queue::tests::next_dense", "cid_queue::tests::insert_duplicate", "cid_generator::tests::validate_keyed_cid", "cid_queue::tests::next_sparse", "cid_queue::tests::retire_dense", "cid_queue::tes...
[]
[]
178
slawlor/ractor
230
slawlor__ractor-230
[ "226" ]
8b05d4bd87c964797dcbb3f4e4623bcaa8cbf1c8
diff --git a/ractor/src/actor/mod.rs b/ractor/src/actor/mod.rs --- a/ractor/src/actor/mod.rs +++ b/ractor/src/actor/mod.rs @@ -427,6 +427,40 @@ pub trait Actor: Sized + Sync + Send + 'static { } } +/// Helper struct for tracking the results from actor processing loops +#[doc(hidden)] +struct ActorLoopResult { +...
diff --git a/ractor/src/actor/tests/supervisor.rs b/ractor/src/actor/tests/supervisor.rs --- a/ractor/src/actor/tests/supervisor.rs +++ b/ractor/src/actor/tests/supervisor.rs @@ -1252,3 +1252,87 @@ async fn test_simple_monitor() { m.stop(None); mh.await.unwrap(); } + +#[crate::concurrency::test] +#[tracing_t...
`post_stop` of children are being called when supervisor fails. **Describe the bug** Imagine a supervision tree with `A -> B`. If `A` panics its `post_stop` is not called as expected but ractor terminates all its children via normal stop with reason "Killed" and then `post_stop` is called for this situation. The pr...
Yes this shouldn't happen, I'll investigate and work on a fix. Thank you for reporting!
2024-05-01T00:45:39
0.9
8b05d4bd87c964797dcbb3f4e4623bcaa8cbf1c8
[ "actor::tests::supervisor::test_supervisor_exit_doesnt_call_child_post_stop" ]
[ "actor::actor_id::tests::test_is_local", "actor::actor_id::tests::test_pid", "actor::tests::returns_actor_references", "actor::tests::supervisor::test_supervision_error_in_post_stop", "actor::tests::supervisor::test_supervision_panic_in_post_startup", "actor::tests::supervisor::test_supervision_error_in_s...
[]
[]
180
rbspy/rbspy
371
rbspy__rbspy-371
[ "367" ]
1211aedd3f5a5c9125084824626407366fc015b7
diff --git a/src/ui/pprof.rs b/src/ui/pprof.rs --- a/src/ui/pprof.rs +++ b/src/ui/pprof.rs @@ -41,7 +41,15 @@ impl Stats { pub fn record(&mut self, stack: &StackTrace) -> Result<()> { let this_time = stack.time.unwrap_or_else(SystemTime::now); let ns_since_last_sample = match self.prev_time { - ...
diff --git a/src/ui/pprof.rs b/src/ui/pprof.rs --- a/src/ui/pprof.rs +++ b/src/ui/pprof.rs @@ -219,6 +227,15 @@ mod test { stats } + #[test] + fn tolerate_stacktrace_timestamps_arriving_out_of_order() { + let mut stats = Stats::new(); + let mut time = SystemTime::now(); + stat...
Profiling multiple subprocesses fails in 0.12.1 If I run the profiling of a multiprocess app for a while (in this case unicorn workers), I get the following crash: ``` thread '<unnamed>' panicked at 'couldn't send error: SendError { .. }', src/sampler/mod.rs:121:56 stack backtrace: thread '<unnamed>' panicked at ...
I'm not able to reproduce this. What distro/version of Linux are you running? And does the panic still happen if you remove `--nonblocking`? Sorry, forgot about this one. Yes, I can reproduce this with and without `nonblocking`.
2022-11-08T20:52:53
0.13
1211aedd3f5a5c9125084824626407366fc015b7
[ "ui::pprof::test::tolerate_stacktrace_timestamps_arriving_out_of_order" ]
[ "core::ruby_spy::tests::test_initialize_with_nonexistent_process", "ui::callgrind::tests::stats_aggregate", "ui::flamegraph::tests::test_collapsed", "ui::callgrind::tests::stats_write", "ui::flamegraph::tests::test_stats", "ui::summary::tests::stats_by_line_number", "ui::summary::tests::stats_by_functio...
[ "core::ruby_spy::tests::test_get_trace", "core::ruby_spy::tests::test_get_trace_when_process_has_exited", "sampler::tests::test_sample_single_process", "sampler::tests::test_sample_single_process_with_time_limit", "sampler::tests::test_sample_subprocesses" ]
[]
181
cberner/redb
223
cberner__redb-223
[ "208" ]
552735ed33355fdab8feabae5c257996ff1f867e
diff --git a/benches/common.rs b/benches/common.rs --- a/benches/common.rs +++ b/benches/common.rs @@ -108,7 +108,7 @@ impl<'a, 'b> BenchWriteTransaction<'b> for RedbBenchWriteTransaction<'a> { } pub struct RedbBenchInserter<'a> { - table: redb::Table<'a, [u8], [u8]>, + table: redb::Table<'a, 'a, [u8], [u8]>,...
diff --git a/src/db.rs b/src/db.rs --- a/src/db.rs +++ b/src/db.rs @@ -514,8 +530,10 @@ mod test { let tmpfile: NamedTempFile = NamedTempFile::new().unwrap(); let db = unsafe { Database::create(tmpfile.path(), 1024 * 1024).unwrap() }; let write_txn = db.begin_write().unwrap(); - let mu...
Can't reopen table during transaction I noticed that you can't open a table, drop it, and then reopen it during the same transaction. I ran into it because I was refactoring some transaction code, and I was in an intermediate state where the half the code was in one function, and the rest was in another function, and I...
Whoops, fat-fingered the submit button. Fixed now. Ah, I wondered if anyone was going to hit this when I added that restriction :stuck_out_tongue: Ya, this is pretty easy to fix
2022-03-18T09:43:15
0.0
48209ec58d81cddc2b20277a66e992fafba3b5d0
[ "reopen_table" ]
[ "tree_store::page_store::buddy_allocator::test::alloc_large", "tree_store::page_store::page_allocator::test::alloc", "tree_store::page_store::page_allocator::test::free", "tree_store::page_store::page_allocator::test::all_space_used", "tree_store::page_store::page_allocator::test::record_alloc", "tree_sto...
[]
[]
182
restatedev/restate
1,129
restatedev__restate-1129
[ "1128" ]
881e9dc134f98bd0a8e4b97a1d3dc144b58d7c2d
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -1516,7 +1516,7 @@ dependencies = [ [[package]] name = "codederror" -version = "0.7.1" +version = "0.8.0" dependencies = [ "codederror-derive", "thiserror", diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -4716,...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -4912,7 +4912,7 @@ dependencies = [ [[package]] name = "restate-ingress-dispatcher" -version = "0.7.1" +version = "0.8.0" dependencies = [ "bytes", "bytestring", diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -...
Excessive logging of message size warnings Once a message exceeds the message size warning, we log the warning every time the `Decoder` tries to decode the message. This can lead to many warnings resulting from a single large message. Instead, we should only log the warning for each message that exceeds the threshold o...
2024-01-30T02:30:50
0.7
881e9dc134f98bd0a8e4b97a1d3dc144b58d7c2d
[ "message::encoding::tests::hit_message_size_limit" ]
[ "codec::tests::complete_invoke", "message::encoding::tests::fill_decoder_with_partial_body", "message::encoding::tests::fill_decoder_with_partial_header", "awakeable_id::tests::test_encode_decode", "message::header::tests::completed_get_state", "message::encoding::tests::fill_decoder_with_several_messages...
[]
[]
185
restatedev/restate
1,532
restatedev__restate-1532
[ "1531" ]
58479caf05f4337009dcdc6841aa59a18bf21425
diff --git a/crates/network/src/rpc_router.rs b/crates/network/src/rpc_router.rs --- a/crates/network/src/rpc_router.rs +++ b/crates/network/src/rpc_router.rs @@ -10,6 +10,7 @@ use std::sync::{Arc, Weak}; +use dashmap::mapref::entry::Entry; use dashmap::DashMap; use futures::stream::BoxStream; use futures::Stre...
diff --git a/crates/network/src/rpc_router.rs b/crates/network/src/rpc_router.rs --- a/crates/network/src/rpc_router.rs +++ b/crates/network/src/rpc_router.rs @@ -309,8 +304,10 @@ where #[cfg(test)] mod test { use super::*; + use futures::future::join_all; use restate_node_protocol::common::TargetName; ...
Race condition in ResponseTracker If a new token with an existing correlation id is created while the same correlation id gets completed, this can lead to a lost message in the rpc ResponseTracker.
2024-05-20T05:01:00
0.9
b07da55240cd9e5dc7064937709c0743d3bf8616
[ "rpc_router::test::concurrent_response_tracker_modifications" ]
[ "connection_manager::tests::test_bad_handshake", "connection_manager::tests::test_hello_welcome_handshake", "connection_manager::tests::test_hello_welcome_timeout", "connection_manager::tests::test_node_generation", "rpc_router::test::test_rpc_flight_tracker_drop", "rpc_router::test::test_rpc_flight_track...
[]
[]
186
linebender/resvg
586
linebender__resvg-586
[ "581" ]
00005084c2544179a7e094d4efa979df1ec04e1b
diff --git a/usvg-text-layout/src/lib.rs b/usvg-text-layout/src/lib.rs --- a/usvg-text-layout/src/lib.rs +++ b/usvg-text-layout/src/lib.rs @@ -805,7 +805,13 @@ fn convert_decoration( let mut path = PathData::new(); for dec_span in decoration_spans { - let rect = Rect::new(0.0, -thickness / 2.0, dec_s...
diff --git a/tests/integration/render.rs b/tests/integration/render.rs --- a/tests/integration/render.rs +++ b/tests/integration/render.rs @@ -482,6 +482,7 @@ use crate::render; #[test] fn a_text_decoration_017() { assert_eq!(render("a-text-decoration-017"), 0); } #[test] fn a_text_decoration_018() { assert_eq!(rende...
panic with SVG generated by PlantUML Example SVG: https://www.plantuml.com/plantuml/svg/SoWkIImgAStDuU9ApaaiBbPmoy_dujBcud98pKi12WC0 call stack: ```txt # Child-SP RetAddr Call Site 00 00000042`c8ef9db0 00007ffd`c8846720 KERNELBASE!RaiseException+0x69 01 00000042`c8ef9e90 00007ff7`cdf6...
For some reason I cannot download this file. Can you add it here? SVG raw content: ```xml <?xml version="1.0" encoding="UTF-8" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" height="343px" preserveAspectRatio="none" style="width:533px;...
2023-02-25T04:55:45
0.29
00005084c2544179a7e094d4efa979df1ec04e1b
[ "render::a_text_rendering_001", "render::a_text_rendering_002", "render::a_text_rendering_004", "render::a_text_rendering_003", "render::a_transform_002", "render::a_transform_003", "render::a_transform_004", "render::a_text_rendering_005", "render::a_transform_001", "render::a_transform_005", "...
[ "render::a_alignment_baseline_002", "render::a_alignment_baseline_010", "render::a_alignment_baseline_012", "render::a_alignment_baseline_011", "render::a_alignment_baseline_006", "render::a_alignment_baseline_005", "render::a_alignment_baseline_001", "render::a_alignment_baseline_008", "render::a_a...
[]
[]
187
BurntSushi/ripgrep
2,885
BurntSushi__ripgrep-2885
[ "2884" ]
6c5108ed17987531644518fac8c1659b0b202611
diff --git a/crates/regex/src/literal.rs b/crates/regex/src/literal.rs --- a/crates/regex/src/literal.rs +++ b/crates/regex/src/literal.rs @@ -430,6 +430,7 @@ impl Extractor { } seq1.union(seq2); assert!(seq1.len().map_or(true, |x| x <= self.limit_total)); + seq1.prefix = seq1.prefix &...
diff --git a/crates/regex/src/literal.rs b/crates/regex/src/literal.rs --- a/crates/regex/src/literal.rs +++ b/crates/regex/src/literal.rs @@ -681,7 +687,7 @@ mod tests { assert_eq!(e(r"foo"), seq([E("foo")])); assert_eq!(e(r"[a-z]foo[a-z]"), seq([I("foo")])); assert_eq!(e(r"[a-z](foo)(bar)[a...
Alternation match regression ### Please tick this box to confirm you have reviewed the above. - [X] I have a different issue. ### What version of ripgrep are you using? 14.1.0 ### How did you install ripgrep? Cargo ### What operating system are you using ripgrep on? Fedora 40 ### Describe your bug. ripgrep fai...
2024-09-09T09:55:16
14.1
6c5108ed17987531644518fac8c1659b0b202611
[ "literal::tests::case_insensitive_alternation", "literal::tests::anything", "literal::tests::various" ]
[ "ast::tests::various", "literal::tests::empty", "ban::tests::various", "literal::tests::class", "literal::tests::concat", "literal::tests::heuristics", "literal::tests::crazy_repeats", "literal::tests::impossible", "matcher::tests::line_terminator_error", "literal::tests::optimize", "literal::te...
[]
[]
188
ron-rs/ron
124
ron-rs__ron-124
[ "121" ]
cfb92c484853af8851c738c4446e2a46fddadcd4
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ron" -version = "0.3.0" +version = "0.4.0" license = "MIT/Apache-2.0" keywords = ["parser", "serde", "serialization"] authors = [ diff --git a/src/de/mod.rs b/src/de/mod.rs --- a/src/de/mod.rs +++ b/src/de/mod....
diff --git a/src/de/value.rs b/src/de/value.rs --- a/src/de/value.rs +++ b/src/de/value.rs @@ -177,6 +182,45 @@ mod tests { ); } + #[test] + fn test_tuples_basic() { + assert_eq!( + eval("(3, 4, 5)"), + Value::Seq( + vec![ + Value::Num...
Ron does not properly round trip through Value ```rust #[macro_use] extern crate serde; extern crate ron; use ron::de::*; use ron::ser; use ron::value::Value; #[derive(Serialize)] struct Scene(Option<(u32, u32)>); #[derive(Serialize)] struct Scene2 { foo: Option<(u32, u32)>, } fn main() { ...
It looks even plain tuples don't work: ```rust { let s = ser::to_string(&(1, 1) ).unwrap(); println!("{}", s); let scene: Value = from_str(&s).unwrap(); println!("{:?}", scene); } ``` gives: ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value...
2018-08-05T16:57:09
0.3
cfb92c484853af8851c738c4446e2a46fddadcd4
[ "de::value::tests::test_tuples_basic", "de::value::tests::test_tuples_error", "de::value::tests::test_tuples_ident", "roundtrip", "unit" ]
[ "de::tests::expected_attribute", "de::tests::expected_attribute_end", "de::tests::forgot_apostrophes", "de::tests::invalid_attribute", "de::tests::test_array", "de::tests::implicit_some", "de::tests::multiple_attributes", "de::tests::test_byte_stream", "de::tests::test_char", "de::tests::test_comm...
[ "test_nul_in_string" ]
[]
189
BurntSushi/rust-csv
213
BurntSushi__rust-csv-213
[ "207" ]
f0f53a49f895a4046b8027df6068901d572e6a00
diff --git a/src/reader.rs b/src/reader.rs --- a/src/reader.rs +++ b/src/reader.rs @@ -686,6 +686,10 @@ impl ReaderBuilder { /// [`ReaderBuilder`](struct.ReaderBuilder.html). /// * When reading CSV data from a resource (like a file), it is possible for /// reading from the underlying resource to fail. This will ...
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -1,7 +1,9 @@ #![allow(dead_code)] +use csv::Reader; + use std::env; -use std::io::{self, Write}; +use std::io::{self, Read, Write}; use std::path::PathBuf; use std::process::{self, Command}; diff --git a/tests/tests.rs b/t...
Recovering from CSV read errors leads to infinite loops when caused by IO errors #### What version of the `csv` crate are you using? 1.1.3 #### Briefly describe the question, bug or feature request. Recovering from CSV errors leads to infinite loops when caused by IO errors #### Include a complete program de...
Hi again. @BurntSushi This has just cost us thousands of euros due to generating tons of useless logs after an invalid file was transferred, leading to an always-erroring reader. Would you be open to a PR fixing this ? I don't really understand what needs to be fixed in the csv crate here. You're getting an error and...
2020-11-03T04:48:18
1.1
f0f53a49f895a4046b8027df6068901d572e6a00
[ "no_infinite_loop_on_io_errors" ]
[ "byte_record::tests::empty_field_2", "byte_record::tests::empty_field_1", "byte_record::tests::empty_record", "byte_record::tests::empty_surround_1", "byte_record::tests::empty_surround_2", "byte_record::tests::eq_record_len", "byte_record::tests::eq_field_boundaries", "byte_record::tests::iter", "b...
[]
[]
190
libp2p/rust-libp2p
2,125
libp2p__rust-libp2p-2125
[ "2121" ]
99da27bd9714c28f6ea01a0a87569ccf55181c75
diff --git a/protocols/kad/CHANGELOG.md b/protocols/kad/CHANGELOG.md --- a/protocols/kad/CHANGELOG.md +++ b/protocols/kad/CHANGELOG.md @@ -13,8 +13,11 @@ - Remove false `debug_assert` on `connected_peers` (see [PR 2120]). +- Return correct number of remaining bootstrap requests (see [PR 2125]). + [PR 2087]: https...
diff --git a/protocols/kad/src/behaviour/test.rs b/protocols/kad/src/behaviour/test.rs --- a/protocols/kad/src/behaviour/test.rs +++ b/protocols/kad/src/behaviour/test.rs @@ -196,6 +196,10 @@ fn bootstrap() { } first = false; ...
Inconsequent Kademlia bootstrapping events Following events coming from the Kademlia protocol, I always receive bootstrapping events in the following pattern: ``` BootstrapOk { peer: PeerId("12D3KooWAYFzVvNfpu8j6HZ8cS6tXngRe8kLXCrwEeXBw86JG9h6"), num_remaining: 11 } ... BootstrapOk { peer: PeerId("1AkytfpPb2r6xtH...
> I.e. there are always two different events with num_remaining: 0 at the end. I think there must be a bug in either the discovery algorithm or the counter (for remaining peerids to be discovered) has an off by one error. Great catch @izolyomi! From taking a quick look, the issue seems to be here: https://github....
2021-07-09T18:34:36
0.39
99da27bd9714c28f6ea01a0a87569ccf55181c75
[ "behaviour::test::bootstrap" ]
[ "behaviour::test::exp_decr_expiration_overflow", "behaviour::test::network_behaviour_inject_address_change", "behaviour::test::unresponsive_not_returned_direct", "jobs::tests::new_job_not_running", "behaviour::test::exceed_jobs_max_queries", "behaviour::test::unresponsive_not_returned_indirect", "behavi...
[]
[]
191
libp2p/rust-libp2p
2,972
libp2p__rust-libp2p-2972
[ "2971" ]
9b182778e119200ee3f1e623f92149ef63d677ae
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -10,10 +10,13 @@ - Update `multistream-select` to `v0.12.1`. See [PR 3090]. +- Improve error messages in case keys cannot be decoded because of missing feature flags. See [PR 2972]. + [PR 3031]: https://github.co...
diff --git a/swarm/src/lib.rs b/swarm/src/lib.rs --- a/swarm/src/lib.rs +++ b/swarm/src/lib.rs @@ -1745,13 +1773,16 @@ mod tests { use futures::future::poll_fn; use futures::future::Either; use futures::{executor, future, ready}; + use libp2p_core::either::EitherError; use libp2p_core::multiaddr:...
Unable to dial bootstrap nodes `InvalidKey` ## Summary I just upgraded my fork to the current `master`, but am now getting the following error when dialing the boostrap nodes ``` 2022-10-03T18:33:11.985412Z DEBUG iroh_bitswap: dial failure QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb: Transport([("/dnsaddr/bo...
You are dialing RSA keys but probably have not enabled the `rsa` feature. I gotten bitten by the same thing, the error message should really be better!
2022-10-04T08:06:05
1.62
a99718162ba8dc1455b377e061f921c888595aff
[ "tests::dial_error_prints_sources" ]
[ "behaviour::toggle::tests::ignore_listen_upgrade_error_when_disabled", "handler::one_shot::tests::do_not_keep_idle_connection_alive", "registry::tests::score_retention_finite_0", "registry::tests::isort_sorts", "tests::dial_self_by_id", "registry::tests::score_retention", "tests::max_outgoing", "tests...
[]
[]
192
rust-lang/rustfmt
6,425
rust-lang__rustfmt-6425
[ "6411" ]
8a2c07398845420d7951d2f4e83d5f97c4df0875
diff --git a/src/expr.rs b/src/expr.rs --- a/src/expr.rs +++ b/src/expr.rs @@ -200,14 +200,22 @@ pub(crate) fn format_expr( } ast::ExprKind::Continue(ref opt_label) => { let id_str = match *opt_label { - Some(label) => format!(" {}", label.ident), + Some(labe...
diff --git /dev/null b/tests/target/issue-6411.rs new file mode 100644 --- /dev/null +++ b/tests/target/issue-6411.rs @@ -0,0 +1,21 @@ +// rustfmt-edition: 2021 + +fn test_break() { + 'r#if: { + break 'r#if; + } + + 'r#a: { + break 'r#a; + } +} + +fn test_continue() { + 'r#if: { + co...
Incorrectly strips r# prefix from labels Rust playground: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=051766b3584e787d3abab1d2f18424bb The following code: ```rust 'r#if: { break 'r#if; } ``` when run through either stable or nightly rustfmt will incorrectly be formatted into this: ```...
@Raspberry1111 thanks for the report. Has it always been possible to use `r#` in labels? Judging from this pull request: https://github.com/rust-lang/rust/pull/126452 they were added in version `1.83` which is coincidentally the current stable release Testing this with `rustc +1.82 --edition 2021 test.rs` gives: ```ru...
2024-12-22T21:14:48
1.8
8a2c07398845420d7951d2f4e83d5f97c4df0875
[ "test::idempotence_tests" ]
[ "attr::doc_comment::tests::single_line_doc_comment_is_formatted_correctly", "attr::doc_comment::tests::multi_line_doc_comment_is_formatted_correctly", "attr::doc_comment::tests::whitespace_within_lines_is_preserved", "comment::test::test_itemized_block_nonobvious_markers_are_rejected", "attr::doc_comment::t...
[]
[]
193
rust-lang/rustfmt
5,369
rust-lang__rustfmt-5369
[ "5368" ]
79515f17ed4661da864347c90c76c51f9bf86069
diff --git a/src/formatting.rs b/src/formatting.rs --- a/src/formatting.rs +++ b/src/formatting.rs @@ -40,12 +40,10 @@ impl<'b, T: Write + 'b> Session<'b, T> { rustc_span::create_session_if_not_set_then(self.config.edition().into(), |_| { if self.config.disable_all_formatting() { ...
diff --git a/src/test/mod.rs b/src/test/mod.rs --- a/src/test/mod.rs +++ b/src/test/mod.rs @@ -578,6 +578,30 @@ fn stdin_generated_files_issue_5172() { ); } +#[test] +fn stdin_handles_mod_inner_ignore_attr() { + // see https://github.com/rust-lang/rustfmt/issues/5368 + init_log(); + let input = String:...
regression: rustfmt using input from stdin emits empty output when using `#![rustfmt::skip]` Since #5094 - rustfmt now emits nothing to stdout if reading a file with `#![rustfmt::skip]` is provided via stdin. For example, running `echo '#![rustfmt::skip]\n\nfn main() { }' | rustfmt` no longer emits anything to stdo...
Thank you for the report and bisection!
2022-06-04T23:09:44
1.4
64f1f57a4837694cb2449d6bc1f614e60c6ff42c
[ "test::stdin_handles_mod_inner_ignore_attr" ]
[ "attr::doc_comment::tests::whitespace_within_lines_is_preserved", "attr::doc_comment::tests::multi_line_doc_comment_is_formatted_correctly", "attr::doc_comment::tests::literal_controls_leading_spaces", "attr::doc_comment::tests::single_line_doc_comment_is_formatted_correctly", "comment::test::char_classes",...
[]
[]
195
rust-lang/rustfmt
5,262
rust-lang__rustfmt-5262
[ "5260" ]
b26c86b51afa013815fc54404ef033f14541c707
diff --git a/src/comment.rs b/src/comment.rs --- a/src/comment.rs +++ b/src/comment.rs @@ -796,7 +796,7 @@ impl<'a> CommentRewrite<'a> { // 1) wrap_comments = true is configured // 2) The comment is not the start of a markdown header doc comment // 3) The comment width exceeds the shape's wid...
diff --git a/src/string.rs b/src/string.rs --- a/src/string.rs +++ b/src/string.rs @@ -369,6 +387,19 @@ mod test { rewrite_string("eq_", &fmt, 2); } + #[test] + fn line_break_at_valid_points_test() { + let string = "[TheName](Dont::break::my::type::That::would::be::very::nice) break here"; ...
wrap_comments can break up type links Similar to #5250, I have a problem when addressing types. They get split over multiple lines and are not valid links anymore in rust doc. ``` /// [IntermediateBucketResult](crate::aggregation::intermediate_agg_result::IntermediateBucketResult) ``` This is converted to: ``...
Thanks for the report! We fixed wrapping reference style links back in #5096. As a workaround for now you might consider rewriting the link as: ```rust /// [IntermediateBucketResult] /// [IntermediateBucketResult]: crate::aggregation::intermediate_agg_result::IntermediateBucketResult ``` I Imagine we could ta...
2022-03-12T13:56:43
1.4
64f1f57a4837694cb2449d6bc1f614e60c6ff42c
[ "test::system_tests", "test::idempotence_tests" ]
[ "attr::doc_comment::tests::whitespace_within_lines_is_preserved", "attr::doc_comment::tests::single_line_doc_comment_is_formatted_correctly", "attr::doc_comment::tests::multi_line_doc_comment_is_formatted_correctly", "attr::doc_comment::tests::literal_controls_leading_spaces", "comment::test::char_classes",...
[]
[ "test::stdin_works_with_json" ]
196
rust-lang/rustlings
599
rust-lang__rustlings-599
[ "281", "585" ]
0d65753fdb41be12310bec970123911aaee76235
diff --git a/src/exercise.rs b/src/exercise.rs --- a/src/exercise.rs +++ b/src/exercise.rs @@ -232,6 +232,16 @@ path = "{}.rs""#, State::Pending(context) } + + // Check that the exercise looks to be solved using self.state() + // This is not the best way to check since + // the user can just re...
diff --git a/tests/fixture/state/info.toml b/tests/fixture/state/info.toml --- a/tests/fixture/state/info.toml +++ b/tests/fixture/state/info.toml @@ -9,3 +9,10 @@ name = "pending_test_exercise" path = "pending_test_exercise.rs" mode = "test" hint = """""" + +[[exercises]] +name = "finished_exercise" +path = "finish...
Follow `rustlings watch` with editor by opening source files in the same order First of all, thank you so much for rustlings, this is an amazing project! A well thought-out practice test suite is worth a thousand tutorials. I got lazy from having to close nvim and open it on the next file to keep up with `rustlings ...
Great idea! And thanks for the script. But I guess my version of rg is out-of-date, since I got `Unknown flag: '--only-matching'` Here's my version, which works with `emacs` or `emacsclient` and should work any time `$EDITOR` is defined: ``` files=$(sed -n 's/^path = "\([^"]*\)"/\1/p' info.toml) # Open each ...
2020-12-13T10:44:50
4.3
0d65753fdb41be12310bec970123911aaee76235
[ "run_rustlings_list_without_done", "run_rustlings_list_without_pending", "run_rustlings_list_both_done_and_pending" ]
[ "exercise::test::test_finished_exercise", "exercise::test::test_pending_state", "exercise::test::test_exercise_with_output", "exercise::test::test_clean", "all_exercises_require_confirmation", "run_rustlings_list_conflicting_display_options", "run_rustlings_list_conflicting_solve_options", "fails_when...
[]
[]
197
rustsec/rustsec
848
rustsec__rustsec-848
[ "736" ]
3eef2ee1f3b327b24c95e3f40b54ba0978e45767
diff --git a/cargo-audit/src/auditor.rs b/cargo-audit/src/auditor.rs --- a/cargo-audit/src/auditor.rs +++ b/cargo-audit/src/auditor.rs @@ -146,7 +146,13 @@ impl Auditor { self.presenter.before_report(lockfile_path, &lockfile); - self.audit(&lockfile, None) + let report = self.audit(&lockfile,...
diff --git a/cargo-audit/src/presenter.rs b/cargo-audit/src/presenter.rs --- a/cargo-audit/src/presenter.rs +++ b/cargo-audit/src/presenter.rs @@ -196,17 +176,30 @@ impl Presenter { } } } + } + + /// Print the vulnerability report for cargo-audit + pub fn print_self_repor...
Advisories for `cargo audit` itself are printed for every scanned binary (instead of once) `cargo_audit::presenter::print_report` contains the following code: https://github.com/rustsec/rustsec/blob/a7310a402b2809a88d62cdd770a6401fae2382ae/cargo-audit/src/presenter.rs#L166-L176 Since this function is run for ever...
2023-03-27T11:41:24
0.26
3eef2ee1f3b327b24c95e3f40b54ba0978e45767
[ "advisories_found_exit_error" ]
[ "auditable_binary_with_vulnerabilities_fails", "parse_audit_toml_example" ]
[ "no_lockfile_exit_error", "advisories_found_but_ignored_json", "no_advisories_found_exit_success", "advisories_found_json", "no_advisories_found_empty_json", "notice_advisories_found_json", "unmaintained_advisories_found_json", "unmaintained_exit_failure_deny_warnings", "unmaintained_exit_success_by...
[]
198
kkawakam/rustyline
750
kkawakam__rustyline-750
[ "748" ]
3f3538d993d64e230fbbfc7c79835a987c2bfd30
diff --git a/src/lib.rs b/src/lib.rs --- a/src/lib.rs +++ b/src/lib.rs @@ -151,7 +151,7 @@ fn complete_line<H: Helper>( } else if CompletionType::List == config.completion_type() { if let Some(lcp) = longest_common_prefix(&candidates) { // if we can extend the item, extend it - if ...
diff --git a/src/test/mod.rs b/src/test/mod.rs --- a/src/test/mod.rs +++ b/src/test/mod.rs @@ -1,7 +1,7 @@ use std::vec::IntoIter; use crate::completion::Completer; -use crate::config::{Config, EditMode}; +use crate::config::{CompletionType, Config, EditMode}; use crate::edit::init_state; use crate::highlight::Hi...
CompletionType::List does not support completion candidates that are shorter than the input Thank you for maintaining this crate — we use it in [Numbat](https://github.com/sharkdp/numbat) and it works great. We want to implement a feature where a user could type something like `\hbar` in the REPL, press <kbd>Tab</kb...
Not strictly related to the issue but to your remark: > that check above should probably use lcp.unicode_width() instead of lcp.len() (?). `s.line.pos()` and `start` are byte offsets so the difference between them is a number of bytes. So `lcp.len()` seems right. But maybe we should compare `s.line[start..s.line....
2023-12-02T21:43:11
12.0
3f3538d993d64e230fbbfc7c79835a987c2bfd30
[ "test::complete_symbol" ]
[ "binding::test::encode", "completion::tests::escape", "binding::test::no_collision", "completion::tests::extract_word", "completion::tests::find_unclosed_quote", "completion::tests::unescape", "completion::tests::longest_common_prefix", "highlight::tests::check_bracket", "edit::test::edit_history_ne...
[ "binding::test::size_of_event" ]
[]
199
kkawakam/rustyline
296
kkawakam__rustyline-296
[ "294" ]
fb048a885f2f4b9bc947fd7603d7b3939951b02a
diff --git a/src/edit.rs b/src/edit.rs --- a/src/edit.rs +++ b/src/edit.rs @@ -210,6 +210,10 @@ impl<'out, 'prompt, H: Helper> State<'out, 'prompt, H> { false } } + + pub fn is_default_prompt(&self) -> bool { + self.layout.default_prompt + } } impl<'out, 'prompt, H: Helper> R...
diff --git a/src/test/emacs.rs b/src/test/emacs.rs --- a/src/test/emacs.rs +++ b/src/test/emacs.rs @@ -159,6 +159,7 @@ fn ctrl_n() { KeyPress::Ctrl('N'), KeyPress::Enter, ], + "", ("line2", ""), ); } diff --git a/src/test/emacs.rs b/src/test/emacs.rs --- a/src/te...
Crash when searching for a value This code: ``` fn main() { use std::io::{stdin, stdout, Write}; use rustyline::error::ReadlineError; use rustyline::Editor; loop { let mut editor = Editor::<()>::new(); if editor.load_history("history.log").is_err() { } let r...
2019-10-23T02:57:12
5.0
fb048a885f2f4b9bc947fd7603d7b3939951b02a
[ "test::history::ctrl_r_with_long_prompt" ]
[ "completion::tests::escape", "completion::tests::extract_word", "completion::tests::find_unclosed_quote", "completion::tests::longest_common_prefix", "completion::tests::unescape", "highlight::tests::check_bracket", "edit::test::edit_history_next", "highlight::tests::find_matching_bracket", "highlig...
[]
[]
200
kkawakam/rustyline
706
kkawakam__rustyline-706
[ "705" ]
97df24087bf7b32fd7647f7f9ba6643c0d092fe5
diff --git a/src/keymap.rs b/src/keymap.rs --- a/src/keymap.rs +++ b/src/keymap.rs @@ -711,7 +711,9 @@ impl<'b> InputState<'b> { E(K::Char('$') | K::End, M::NONE) => Cmd::Move(Movement::EndOfLine), E(K::Char('.'), M::NONE) => { // vi-redo (repeat last command) - ...
diff --git a/src/test/vi_cmd.rs b/src/test/vi_cmd.rs --- a/src/test/vi_cmd.rs +++ b/src/test/vi_cmd.rs @@ -13,10 +13,15 @@ fn dollar() { ); } -/*#[test] +#[test] fn dot() { - // TODO -}*/ + assert_cursor( + EditMode::Vi, + ("", ""), + &[E::ESC, E::from('.'), E::ENTER], + ("", ...
Crash at rustyline-11.0.0/src/keymap.rs:205:18 Hi, when I have rustyline configured the following way: ``` let config_builder = rustyline::config::Config::builder() .max_history_size(10000)? .history_ignore_dups( true)? .auto_add_history(true) .bell_style(rustyline::config::BellStyle::None) .c...
Thanks for the detailed bug report.
2023-06-24T01:04:46
11.0
97df24087bf7b32fd7647f7f9ba6643c0d092fe5
[ "test::vi_cmd::dot" ]
[ "binding::test::no_collision", "binding::test::encode", "completion::tests::find_unclosed_quote", "completion::tests::escape", "completion::tests::extract_word", "completion::tests::unescape", "completion::tests::longest_common_prefix", "highlight::tests::check_bracket", "highlight::tests::is_open_b...
[ "binding::test::size_of_event" ]
[]
201
kkawakam/rustyline
646
kkawakam__rustyline-646
[ "645" ]
5682cd33e47ae84fc71c9bfc846c8760005d1a4a
diff --git a/src/command.rs b/src/command.rs --- a/src/command.rs +++ b/src/command.rs @@ -51,7 +51,9 @@ pub fn execute<H: Helper>( } Cmd::Move(Movement::ViFirstPrint) => { s.edit_move_home()?; - s.edit_move_to_next_word(At::Start, Word::Big, 1)?; + if s.line.starts_...
diff --git a/src/test/vi_cmd.rs b/src/test/vi_cmd.rs --- a/src/test/vi_cmd.rs +++ b/src/test/vi_cmd.rs @@ -58,6 +58,16 @@ fn caret() { ); } +#[test] +fn caret_no_whitespace() { + assert_cursor( + EditMode::Vi, + ("Hi", ""), + &[E::ESC, E::from('^'), E::ENTER], + ("", "Hi"), + )...
Caret key (`^`) does not work as expected in evcxr_repl in vi edit mode I originally posted the issue in google/evcxr#239 , but it turned out to be a bug of thi scrate, rustyline. > Caret key should jump the cursor to the first non-empty character in the current line. But it is implemented that it instead jumps ......
Thanks for the bug report. ```diff diff --git a/src/command.rs b/src/command.rs index c16f966..652e9f1 100644 --- a/src/command.rs +++ b/src/command.rs @@ -51,7 +51,9 @@ pub fn execute<H: Helper>( } Cmd::Move(Movement::ViFirstPrint) => { s.edit_move_home()?; - s.edit_...
2022-08-21T01:04:36
10.0
5682cd33e47ae84fc71c9bfc846c8760005d1a4a
[ "test::vi_cmd::caret_no_whitespace" ]
[ "completion::tests::escape", "binding::test::encode", "completion::tests::find_unclosed_quote", "binding::test::no_collision", "completion::tests::extract_word", "completion::tests::longest_common_prefix", "completion::tests::unescape", "highlight::tests::check_bracket", "highlight::tests::find_matc...
[ "binding::test::size_of_event" ]
[]
202
kkawakam/rustyline
511
kkawakam__rustyline-511
[ "509" ]
bd73bdd5fdd4b59e3a1809be175c47a91b8bb512
diff --git a/src/binding.rs b/src/binding.rs --- a/src/binding.rs +++ b/src/binding.rs @@ -71,15 +71,15 @@ impl KeyEvent { fn encode(&self) -> u32 { let mut u = match self.0 { KeyCode::UnknownEscSeq => 0, - KeyCode::Backspace => u32::from('H') | BASE_CONTROL, - KeyCode::...
diff --git a/src/binding.rs b/src/binding.rs --- a/src/binding.rs +++ b/src/binding.rs @@ -204,7 +204,7 @@ pub trait ConditionalEventHandler: Send + Sync { #[cfg(test)] mod test { use super::{Event, EventHandler}; - use crate::{Cmd, KeyEvent}; + use crate::{Cmd, KeyCode, KeyEvent, Modifiers}; use radi...
Trie key collisions for some custom bind sequences Here's a snippet that worked in Rustyline 7.1.0 but is broken in 8.0.0. ``` let mut rl = rustyline::Editor::<()>::new(); // Enable Ctrl-Backspace to delete the current word. rl.bind_sequence( rustyline::KeyEvent:...
On Unix platform, `Backspace` == `Ctrl-H`. So at least on Unix platform, afaik, we cannot make the difference. But we should fix it on Windows platform. Could please confirm that you add custom bindings for both `Backspace` and Ctrl-`Backspace` ? Thanks.
2021-04-04T17:24:56
8.0
36752fe1b30dbfeaaaaa7a7b30cfd7b578742c26
[ "binding::test::no_collision" ]
[ "binding::test::encode", "completion::tests::escape", "completion::tests::unescape", "edit::test::edit_history_next", "highlight::tests::find_matching_bracket", "highlight::tests::is_open_bracket", "highlight::tests::matching_bracket", "history::tests::add", "highlight::tests::check_bracket", "com...
[]
[]
203
salsa-rs/salsa
596
salsa-rs__salsa-596
[ "519" ]
c6c51a0ea0bb11ce5a449c4b9256c66c5e484fee
diff --git a/components/salsa-macros/src/tracked_fn.rs b/components/salsa-macros/src/tracked_fn.rs --- a/components/salsa-macros/src/tracked_fn.rs +++ b/components/salsa-macros/src/tracked_fn.rs @@ -1,4 +1,5 @@ use proc_macro2::{Literal, Span, TokenStream}; +use quote::ToTokens; use syn::{spanned::Spanned, ItemFn}; ...
diff --git a/tests/compile-fail/tracked_fn_incompatibles.rs b/tests/compile-fail/tracked_fn_incompatibles.rs --- a/tests/compile-fail/tracked_fn_incompatibles.rs +++ b/tests/compile-fail/tracked_fn_incompatibles.rs @@ -34,4 +34,38 @@ fn tracked_fn_with_too_many_arguments_for_specify( ) -> u32 { } +#[salsa::interned...
inconsistent behavior with respect to lifetime elision In #518 the behavior with respect to lifetime elision for tracked functions is kind of inconsistent: * For the `&dyn Db` parameter, we always infer the elided lifetime to be `'db` * For other random inputs, we basically disallow elision: if you use a `'_`, it w...
2024-10-16T00:56:26
0.18
e4d36daf2dc4a096009753b6e326cf44e6c6e18a
[ "compile_fail" ]
[ "get_a_logs_after_changing_b", "accumulate_once", "change_a_from_2_to_0", "change_a_from_2_to_1", "accumulate_chain", "accumulate_custom_clone", "accumulate_custom_debug", "accumulate_a_called_twice", "accumulate_execution_order", "test1", "accumulate_no_duplicates", "tests/compile-fail/accumu...
[]
[]
204
salsa-rs/salsa
591
salsa-rs__salsa-591
[ "590" ]
c6c51a0ea0bb11ce5a449c4b9256c66c5e484fee
diff --git a/src/active_query.rs b/src/active_query.rs --- a/src/active_query.rs +++ b/src/active_query.rs @@ -1,17 +1,17 @@ use rustc_hash::FxHashMap; +use super::zalsa_local::{EdgeKind, QueryEdges, QueryOrigin, QueryRevisions}; +use crate::tracked_struct::IdentityHash; use crate::{ accumulator::accumulated_m...
diff --git /dev/null b/tests/hash_collision.rs new file mode 100644 --- /dev/null +++ b/tests/hash_collision.rs @@ -0,0 +1,32 @@ +use std::hash::Hash; + +#[test] +fn hello() { + use salsa::{Database, DatabaseImpl, Setter}; + + #[salsa::input] + struct Bool { + value: bool, + } + + #[salsa::tracked...
Input change cause panic on next queries From Zulip (thanks Andrey for the minimal repro) : ```rust #[test] fn hello() { use salsa::{Database, DatabaseImpl, Setter}; #[salsa::input] struct Bool { value: bool, } #[salsa::tracked] struct True<'db> {} #[salsa::tracked...
In struct::new only data_hash and nonce are used to distinguish structs. Can we add IngredientIndex to KeyStruct to fix this bug? Following what was said on Zulip, I was able to fix this issue by adding the IngredientIndex to the hash in `new_struct` [here](https://github.com/salsa-rs/salsa/commit/b7cd2684623f9e7b7bcb5...
2024-10-12T23:58:10
0.18
e4d36daf2dc4a096009753b6e326cf44e6c6e18a
[ "hello" ]
[ "get_a_logs_after_changing_b", "accumulate_once", "change_a_from_2_to_0", "change_a_from_2_to_1", "accumulate_chain", "accumulate_custom_clone", "accumulate_custom_debug", "accumulate_a_called_twice", "accumulate_execution_order", "test1", "accumulate_no_duplicates", "tests/compile-fail/accumu...
[]
[]
205
salvo-rs/salvo
844
salvo-rs__salvo-844
[ "842" ]
81844145f73bad93435c68a4e7f1d231ec9d9eb4
diff --git a/crates/core/src/http/request.rs b/crates/core/src/http/request.rs --- a/crates/core/src/http/request.rs +++ b/crates/core/src/http/request.rs @@ -14,7 +14,6 @@ pub use http::request::Parts; use http::uri::{Scheme, Uri}; use http::Extensions; use http_body_util::{BodyExt, Limited}; -use indexmap::IndexMa...
diff --git a/crates/core/src/routing/filters/path.rs b/crates/core/src/routing/filters/path.rs --- a/crates/core/src/routing/filters/path.rs +++ b/crates/core/src/routing/filters/path.rs @@ -930,11 +930,6 @@ mod tests { let segments = PathParser::new("/").parse().unwrap(); assert!(segments.is_empty())...
使用PathParam时，路由通配符<**id>不生效 **Is your feature request related to a problem? Please describe.** 定义了两个路由，分别为以下：↓ 路由1： ``` rust Router::with_path("/system/roles").get(role_controller::get_list) ``` 路由2： ``` rust Router::with_path("/system/roles/<id>").get(role_controller::get_one) ``` 路由2相关代码定义： ```rust ...
2024-07-29T13:10:39
0.68
81844145f73bad93435c68a4e7f1d231ec9d9eb4
[ "tests::test_serve_embed_files" ]
[ "conn::addr::tests::test_addr_ipv4", "conn::addr::tests::test_addr_ipv6", "catcher::tests::test_custom_catcher", "catcher::tests::test_handle_error", "conn::acme::config::tests::test_acme_config_builder", "depot::test::test_depot", "conn::joined::tests::test_joined_listener", "error::tests::test_anyho...
[]
[]
206
salvo-rs/salvo
25
salvo-rs__salvo-25
[ "24" ]
9f6ca8954cf4435f061e5f83fe25064b57815ccc
diff --git a/core/src/routing/filter/impls/path.rs b/core/src/routing/filter/impls/path.rs --- a/core/src/routing/filter/impls/path.rs +++ b/core/src/routing/filter/impls/path.rs @@ -57,6 +57,14 @@ where C: Fn(char) -> bool + Sync + Send + 'static, { fn build(&self, name: String, _sign: String, args: Vec<Str...
diff --git a/core/src/routing/filter/impls/path.rs b/core/src/routing/filter/impls/path.rs --- a/core/src/routing/filter/impls/path.rs +++ b/core/src/routing/filter/impls/path.rs @@ -738,7 +746,15 @@ mod tests { ); } #[test] - fn test_parse_num() { + fn test_parse_num0() { + let segments...
master/examples/routing.rs Compilation fails - https://github.com/salvo-rs/salvo/blob/master/examples/routing.rs **dependencies** ``` rustc 1.51.0 (2fd73fabe 2021-03-23) Deepin GNU/Linux 20.2 [dependencies] salvo = { version = "0.11", features = ["full"] } tokio = { version = "1", features = ["full"] } ```...
2021-05-02T11:19:57
0.11
9f6ca8954cf4435f061e5f83fe25064b57815ccc
[ "routing::filter::impls::path::tests::test_parse_num0" ]
[ "error::error_size_of", "http::multipart::boundary::test::test_empty_stream", "http::multipart::boundary::test::test_one_boundary", "http::multipart::boundary::test::test_one_empty_field", "http::multipart::boundary::test::test_one_nonempty_field", "http::multipart::field::headers::test_header_end_split",...
[ "routing::filter::impls::path::tests::test_parse_multi_regex_with_prefix_and_suffix", "routing::filter::impls::path::tests::test_parse_multi_regex", "routing::filter::impls::path::tests::test_parse_multi_regex_with_prefix", "routing::filter::impls::path::tests::test_parse_single_regex", "routing::filter::im...
[]
209
mozilla/sccache
1,724
mozilla__sccache-1724
[ "1723" ]
6fffb2a20ea0f51ec4a722b0f9d0caa608716ffc
diff --git a/docs/S3.md b/docs/S3.md --- a/docs/S3.md +++ b/docs/S3.md @@ -26,4 +26,4 @@ Sccache is able to load credentials from various sources. Including: - AssumeRole: assume role with the role specified by `AWS_ROLE_ARN`. - AssumeRoleWithWebIdentity: assume role with web webIdentity specified by `AWS_ROLE_ARN` a...
diff --git a/src/config.rs b/src/config.rs --- a/src/config.rs +++ b/src/config.rs @@ -1080,8 +1088,8 @@ fn config_overrides() { #[test] #[serial] -fn test_s3_no_credentials() { - env::set_var("SCCACHE_S3_NO_CREDENTIALS", "1"); +fn test_s3_no_credentials_conflict() { + env::set_var("SCCACHE_S3_NO_CREDENTIALS"...
Proposal: Make `SCCACHE_S3_NO_CREDENTIALS` require a value of `true` It seems that `SCCACHE_S3_NO_CREDENTIALS` takes effect even when its value is set to non-truthy values like `SCCACHE_S3_NO_CREDENTIALS=false`. From reviewing the source code, it looks like this is intended. Can we switch this environment variabl...
Sounds good. I am all for hardening options.
2023-04-13T00:37:43
0.4
6fffb2a20ea0f51ec4a722b0f9d0caa608716ffc
[ "config::test_s3_no_credentials_invalid", "config::test_s3_no_credentials_valid_false", "test::tests::test_server_port_in_use" ]
[ "cache::cache::test::test_normalize_key", "compiler::args::tests::assert_tests::test_args_iter_no_conflict", "cache::s3::test::test_endpoint_resolver", "compiler::args::tests::assert_tests::test_arginfo_process_take_arg - should panic", "compiler::args::tests::assert_tests::test_arginfo_process_take_maybe_c...
[ "test_dist_nobuilder", "test_dist_failingserver", "test_dist_basic", "test_dist_restartedserver", "test_auth", "test_s3_invalid_args", "test_rust_cargo_run_with_env_dep_parsing", "test_rust_cargo_check", "test_rust_cargo_build_nightly", "test_run_log_no_perm", "test_rust_cargo_check_nightly", ...
[]
210
mozilla/sccache
1,547
mozilla__sccache-1547
[ "1266" ]
762f5c60b5f6e76812fe291f12002a4b93c5b26b
diff --git a/src/compiler/clang.rs b/src/compiler/clang.rs --- a/src/compiler/clang.rs +++ b/src/compiler/clang.rs @@ -184,6 +184,7 @@ counted_array!(pub static ARGS: [ArgInfo<gcc::ArgData>; _] = [ // Note: this overrides the -fprofile-use option in gcc.rs. take_arg!("-fprofile-use", PathBuf, Concatenated('='...
diff --git a/src/compiler/clang.rs b/src/compiler/clang.rs --- a/src/compiler/clang.rs +++ b/src/compiler/clang.rs @@ -550,6 +551,12 @@ mod test { assert_eq!(ovec!["-Xclang", "-no-opaque-pointers"], a.preprocessor_args); } + #[test] + fn test_parse_xclang_use_ctor_homing() { + let a = parse...
Can't handle UnknownFlag arguments with -Xclang (-fuse-ctor-homing) Hi, I think I have no cache hit while building chromium on Ubuntu. ``` $ sccache -s [2022-08-05T07:21:57Z DEBUG sccache::config] Attempting to read config file at "/home/user/.config/sccache/config" [2022-08-05T07:21:57Z DEBUG sccache::config] Co...
2023-01-10T01:55:40
0.7
762f5c60b5f6e76812fe291f12002a4b93c5b26b
[ "compiler::clang::test::test_parse_xclang_use_ctor_homing" ]
[ "cache::cache::test::test_normalize_key", "compiler::args::tests::assert_tests::test_arginfo_process_take_concat_arg_delim - should panic", "compiler::args::tests::assert_tests::test_arginfo_process_take_arg - should panic", "compiler::args::tests::assert_tests::test_arginfo_process_take_concat_arg - should p...
[ "test_dist_failingserver", "test_dist_restartedserver", "test_dist_nobuilder", "test_dist_basic", "test_auth", "test_s3_invalid_args", "test_rust_cargo_check_nightly", "test_run_log_no_perm", "test_rust_cargo_build", "test_rust_cargo_check", "test_rust_cargo_run_with_env_dep_parsing", "test_ru...
[]
211
mozilla/sccache
1,157
mozilla__sccache-1157
[ "1156" ]
5edd91a739df0f51f260766d7f68f6f59a89d56e
diff --git a/src/compiler/rust.rs b/src/compiler/rust.rs --- a/src/compiler/rust.rs +++ b/src/compiler/rust.rs @@ -2276,10 +2276,12 @@ impl RlibDepReader { #[cfg(feature = "dist-client")] fn parse_rustc_z_ls(stdout: &str) -> Result<Vec<&str>> { let mut lines = stdout.lines(); - match lines.next() { - S...
diff --git a/src/compiler/rust.rs b/src/compiler/rust.rs --- a/src/compiler/rust.rs +++ b/src/compiler/rust.rs @@ -2895,13 +2897,38 @@ c:/foo/bar.rs: #[cfg(feature = "dist-client")] #[test] - fn test_parse_rustc_z_ls() { + fn test_parse_rustc_z_ls_pre_1_55() { let output = "=External Dependen...
RlibDepReader is failing due to different stdout on recent rust versions According to `test_parse_rustc_z_ls` we would expect the full output to be: ``` =External Dependencies= 1 std-a46a068050a12a4b hash ce2bb5d0f13de257 host_hash None kind Explicit 2 core-98b4d121af2b7335 hash ab9053be6f183cd6 host_hash None kind...
2022-04-14T18:32:32
0.12
5edd91a739df0f51f260766d7f68f6f59a89d56e
[ "compiler::rust::test::test_parse_rustc_z_ls_post_1_55" ]
[ "azure::credentials::test::test_conn_str_with_endpoint_suffix_only", "azure::credentials::test::test_parse_connection_string", "azure::credentials::test::test_parse_connection_string_without_account_key", "azure::blobstore::test::test_canonicalize_resource", "azure::blobstore::test::test_signing", "cache:...
[ "test_dist_restartedserver", "test_dist_basic", "test_dist_failingserver", "test_dist_nobuilder", "test_auth", "test_rust_cargo_build", "test_rust_cargo_check", "test_rust_cargo_build_nightly", "test_rust_cargo_check_nightly", "test_rust_cargo_run_with_env_dep_parsing" ]
[]
212
rust-scraper/scraper
213
rust-scraper__scraper-213
[ "212" ]
e0d4ea7a3373b3a75bd79ad85af21243fac93e60
diff --git a/scraper/src/error/utils.rs b/scraper/src/error/utils.rs --- a/scraper/src/error/utils.rs +++ b/scraper/src/error/utils.rs @@ -1,14 +1,12 @@ use cssparser::Token; pub(crate) fn render_token(token: &Token<'_>) -> String { - // THIS TOOK FOREVER TO IMPLEMENT - match token { - // TODO: Give ...
diff --git a/scraper/src/error/utils.rs b/scraper/src/error/utils.rs --- a/scraper/src/error/utils.rs +++ b/scraper/src/error/utils.rs @@ -89,3 +78,14 @@ fn render_int_signed(num: f32) -> String { fn render_int_unsigned(num: f32) -> String { format!("{}", num) } + +#[cfg(test)] +mod tests { + use crate::Selec...
Using map_err on a SelectorErrorKind error results in a panic Hey there, absolutely love your work on this library! Unfortunately, the way that the `SelectorErrorKind` error behaves is a bit unusual. ```rust use anyhow::anyhow; use scraper::Selector; fn main() { let selector_result = Selector::parse("di...
I think this is a bug in our `render_single_char_token` function which does not handle `cssparser`'s [`Token::Delim`](https://docs.rs/cssparser/0.31.2/cssparser/enum.Token.html#variant.Delim) yet. I guess this was an oversight when we last updated that dependencies. We should add a regression test and make sure that...
2024-10-24T20:03:23
0.20
e0d4ea7a3373b3a75bd79ad85af21243fac93e60
[ "error::utils::tests::regression_test_issue212" ]
[ "html::tests::html_is_send", "element_ref::element::tests::test_is_link", "element_ref::tests::test_scope", "html::tests::root_element_document_doctype", "html::tests::root_element_document_comment", "html::tests::root_element_fragment", "element_ref::element::tests::test_has_id", "element_ref::elemen...
[]
[]
214
chmln/sd
115
chmln__sd-115
[ "94" ]
479f0403db6024d331f872ca3a1039db061a8d3b
diff --git a/src/replacer.rs b/src/replacer.rs --- a/src/replacer.rs +++ b/src/replacer.rs @@ -1,6 +1,6 @@ use crate::{utils, Error, Result}; use regex::bytes::Regex; -use std::{fs::File, io::prelude::*, path::Path}; +use std::{fs, fs::File, io::prelude::*, path::Path}; pub(crate) struct Replacer { regex: Reg...
diff --git a/tests/cli.rs b/tests/cli.rs --- a/tests/cli.rs +++ b/tests/cli.rs @@ -13,6 +13,18 @@ mod cli { assert_eq!(content, std::fs::read_to_string(path).unwrap()); } + fn create_soft_link<P: AsRef<std::path::Path>>( + src: &P, + dst: &P, + ) -> Result<()> { + #[cfg(target...
When using sd over a symlink, symlink get replaced by a full-featured file As stated in the issue title, when sd is used over a symlink, the symlink gets replaced with a complete file rewrited over it, copy of the file the symlink was pointing to.
2021-03-14T05:57:26
0.7
479f0403db6024d331f872ca3a1039db061a8d3b
[ "cli::in_place_following_symlink" ]
[ "replacer::tests::default_global", "replacer::tests::case_sensitive_default", "replacer::tests::escaped_char_preservation", "replacer::tests::unescape_regex_replacements", "replacer::tests::full_word_replace", "replacer::tests::sanity_check_literal_replacements", "replacer::tests::no_unescape_literal_re...
[]
[]
215
SeaQL/sea-orm
1,953
SeaQL__sea-orm-1953
[ "1699" ]
06c632712f3d167df0cda742dd228661b953ab7f
diff --git a/sea-orm-codegen/src/entity/writer.rs b/sea-orm-codegen/src/entity/writer.rs --- a/sea-orm-codegen/src/entity/writer.rs +++ b/sea-orm-codegen/src/entity/writer.rs @@ -460,15 +460,23 @@ impl EntityWriter { entity .columns .iter() - .fold(TokenStream::new(), |mut ...
diff --git a/sea-orm-codegen/src/entity/writer.rs b/sea-orm-codegen/src/entity/writer.rs --- a/sea-orm-codegen/src/entity/writer.rs +++ b/sea-orm-codegen/src/entity/writer.rs @@ -814,7 +822,8 @@ mod tests { }; use pretty_assertions::assert_eq; use proc_macro2::TokenStream; - use sea_query::{ColumnType...
sea-orm-codegen: Enum `use` statements getting generated multiple times <!-- Welcome! Thank you for reporting bugs! First of all, please star our repo. Your support is vital to the continued maintenance of SeaORM. Want to ask a question? You can reach us via: - Discord: https://discord.com/invite/uCPdDXzbdv...
2023-11-02T09:02:02
0.12
c6e1a84a120dff5a73abe450fb56ed4483d9413d
[ "entity::writer::tests::test_gen_import_active_enum" ]
[ "entity::base_entity::tests::test_get_conjunct_relations_to_upper_camel_case", "entity::base_entity::tests::test_get_conjunct_relations_via_snake_case", "entity::base_entity::tests::test_get_eq_needed", "entity::base_entity::tests::test_get_column_names_snake_case", "entity::base_entity::tests::test_get_col...
[]
[]
216
SeaQL/sea-orm
1,821
SeaQL__sea-orm-1821
[ "1819" ]
131f9f11230b7fd2d318870fd0c2d441c80ed734
diff --git a/sea-orm-codegen/src/entity/active_enum.rs b/sea-orm-codegen/src/entity/active_enum.rs --- a/sea-orm-codegen/src/entity/active_enum.rs +++ b/sea-orm-codegen/src/entity/active_enum.rs @@ -26,7 +26,18 @@ impl ActiveEnum { if v.chars().next().map(char::is_numeric).unwrap_or(false) { ...
diff --git a/sea-orm-codegen/src/entity/active_enum.rs b/sea-orm-codegen/src/entity/active_enum.rs --- a/sea-orm-codegen/src/entity/active_enum.rs +++ b/sea-orm-codegen/src/entity/active_enum.rs @@ -223,4 +234,53 @@ mod tests { .to_string() ) } + + #[test] + fn test_enum_variant_utf8_en...
`sea-orm-cli` entities generator panics when an item in EnumType consist entirely without any letters or numbers <!-- Welcome! Thank you for reporting bugs! First of all, please star our repo. Your support is vital to the continued maintenance of SeaORM. Want to ask a question? You can reach us via: - Disco...
What's more, I changed the source code of `sea-orm-codegen` to solve my problem, and it works fine. If you think this is ok, I can run the test and make a pull request. `sea-orm-codegen/src/entity/active_enum.rs` ```rs impl ActiveEnum { pub fn impl_active_enum(&self, with_serde: &WithSerde, with_copy_enums: b...
2023-08-22T18:03:15
0.12
c6e1a84a120dff5a73abe450fb56ed4483d9413d
[ "entity::active_enum::tests::test_enum_variant_utf8_encode" ]
[ "entity::active_enum::tests::test_enum_extra_derives", "entity::base_entity::tests::test_get_column_names_snake_case", "entity::base_entity::tests::test_get_column_rs_types", "entity::base_entity::tests::test_get_conjunct_relations_to_upper_camel_case", "entity::base_entity::tests::test_get_conjunct_relatio...
[]
[]
217
SeaQL/sea-orm
226
SeaQL__sea-orm-226
[ "225" ]
125ee401610038ea0200142676353b6094cda8e5
diff --git a/sea-orm-codegen/src/entity/column.rs b/sea-orm-codegen/src/entity/column.rs --- a/sea-orm-codegen/src/entity/column.rs +++ b/sea-orm-codegen/src/entity/column.rs @@ -27,8 +27,6 @@ impl Column { ColumnType::Char(_) | ColumnType::String(_) | ColumnType::Text - ...
diff --git a/sea-orm-codegen/src/entity/column.rs b/sea-orm-codegen/src/entity/column.rs --- a/sea-orm-codegen/src/entity/column.rs +++ b/sea-orm-codegen/src/entity/column.rs @@ -194,6 +194,11 @@ mod tests { make_col!("CAKE_FILLING_ID", ColumnType::Double(None)), make_col!("CAKE-FILLING-ID", C...
sea-orm-cli: does not recognize SQL Date on Postgres ``` sea-orm = { version = "^0.2.4", features = ["sqlx-postgres", "macros", "runtime-async-std-native-tls", ], default-features = false } ``` sea-orm-cli: 0.2.4 --- Creating a Postgres tables with: Postgres sql: ```sql create table stores ...
Hey @shi-rudo, thanks for the feedback! Just found the faulty lines. I will create a PR fixing it ASAP. https://github.com/SeaQL/sea-orm/blob/632290469b649d40b45760ff00f687a1467c5508/sea-orm-codegen/src/entity/column.rs#L30-L31 Please change... for now ```rust #[derive(Clone, Debug, PartialEq, DeriveEntityModel)...
2021-10-05T23:03:30
0.2
8d06f4b9e9c2816cc09141d96df3b365cd6fafbd
[ "entity::column::tests::test_get_rs_type" ]
[ "entity::base_entity::tests::test_get_column_defs", "entity::base_entity::tests::test_get_column_names_camel_case", "entity::base_entity::tests::test_get_column_names_snake_case", "entity::base_entity::tests::test_get_conjunct_relations_to_snake_case", "entity::base_entity::tests::test_get_primary_key_names...
[]
[]
218
SeaQL/sea-orm
746
SeaQL__sea-orm-746
[ "704" ]
a0a2492a921c92b47cabff95be7f25ed0a4ebad2
diff --git a/sea-orm-codegen/src/entity/column.rs b/sea-orm-codegen/src/entity/column.rs --- a/sea-orm-codegen/src/entity/column.rs +++ b/sea-orm-codegen/src/entity/column.rs @@ -68,7 +68,7 @@ impl Column { }, ColumnType::Decimal(_) | ColumnType::Money(_) => "Decimal".to_owned(), ...
diff --git a/sea-orm-codegen/src/entity/column.rs b/sea-orm-codegen/src/entity/column.rs --- a/sea-orm-codegen/src/entity/column.rs +++ b/sea-orm-codegen/src/entity/column.rs @@ -266,6 +266,7 @@ mod tests { make_col!("cake-filling-id", ColumnType::Float(None)), make_col!("CAKE_FILLING_ID", Col...
mismatched types; Rust type `core::option::Option<alloc::string::String>` (as SQL type `VARCHAR`) is not compatible with SQL type `VARBINARY` <!-- Welcome! Thanks for reporting bugs! Do you want to ask a question? Are you looking for support? Please ask us on - Discord: https://discord.com/invite/uCPdDXzbdv - ...
Hello, @ttys3! Thank you for the report. Can write a small example which reproduces error? And I think varbinary is not equal to String. You can use Binary instead of String. Hey @ttys3, I think `varbinary` should represented as `Vec<u8>` in Rust @ikrivosheev @billy1624 I updated the issue with re-produce steps. ...
2022-05-18T15:56:49
0.9
87a9eb9d15674830a35ef0c60c46d19fd364590e
[ "entity::column::tests::test_get_rs_type_with_chrono", "entity::column::tests::test_get_rs_type_with_time", "entity::column::tests::test_get_def" ]
[ "entity::base_entity::tests::test_get_column_defs", "entity::base_entity::tests::test_get_conjunct_relations_to_camel_case", "entity::base_entity::tests::test_get_column_rs_types", "entity::base_entity::tests::test_get_column_names_camel_case", "entity::base_entity::tests::test_get_column_names_snake_case",...
[]
[]
219
skim-rs/skim
563
skim-rs__skim-563
[ "194", "495" ]
8a579837daaeb71938c635aa5352cbde9669d5f8
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -75,7 +75,7 @@ impl Perform for ANSIParser { match code[0] { 0 => attr = Attr::default(), 1 => attr.effect |= Effect::BOLD, - 2 => attr.effect |= !Effect::BOLD, + 2 ...
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -606,4 +606,21 @@ mod tests { assert_eq!(Some(('a', highlight)), it.next()); assert_eq!(None, it.next()); } + + #[test] + fn test_ansi_dim() { + // https://github.com/lotabout/skim/issues/495 + let i...
Color not working with `ag` When using silver searcher, coloring of file path and line numbers aren't working. Used the following command: ``` $ sk --ansi -i -c 'ag --color "{}"' ``` Dimmed colors not properly displayed Whenever an item in the list of entries passed to `skim` is _dimmed_, `skim` does not prop...
Confirmed. Will fix when I got time.
2024-04-03T00:37:59
0.10
8a579837daaeb71938c635aa5352cbde9669d5f8
[ "ansi::tests::test_ansi_dim" ]
[ "ansi::tests::test_multi_bytes", "ansi::tests::test_ansi_iterator", "ansi::tests::test_highlight_indices", "ansi::tests::test_merge_fragments", "ansi::tests::test_multi_byte_359", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "ansi::tests::test_reset", "field::test::tes...
[]
[]
220
skim-rs/skim
362
skim-rs__skim-362
[ "359" ]
bedadf1a37d50a56a2cf279b7289cbef5b3ca206
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -337,7 +337,7 @@ impl<'a> From<(&'a str, &'a [usize], Attr)> for AnsiString<'a> { pub struct AnsiStringIterator<'a> { fragments: &'a [(Attr, (u32, u32))], fragment_idx: usize, - chars_iter: std::str::CharIndices<'a>, + chars_...
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -581,4 +581,16 @@ mod tests { vec![(ao, (1, 2)), (an, (2, 6)), (ao, (6, 7)), (ao, (9, 11))] ); } + + #[test] + fn test_multi_byte_359() { + // https://github.com/lotabout/skim/issues/359 + let hi...
Crashes with multi-byte characters input and --regex After update to 0.9.1, I'm having trouble with sk. ```shell-session $ sk --version 0.9.1 $ echo $SKIM_DEFAULT_OPTIONS $ echo $LANG ja_JP.UTF-8 $ od -tx1z <<< 'ああa' 0000000 e3 81 82 e3 81 82 61 0a >......a.< 0000010 $ echo 'ああa' ...
2020-10-21T22:25:28
0.9
2ad92dfc3d0f9f6b172e1c6659a235ff13fe0f64
[ "ansi::tests::test_multi_byte_359" ]
[ "ansi::tests::test_highlight_indices", "ansi::tests::test_ansi_iterator", "ansi::tests::test_merge_fragments", "ansi::tests::test_normal_string", "ansi::tests::test_multiple_attributes", "ansi::tests::test_reset", "field::test::test_parse_field_range", "global::tests::test", "helper::selector::tests...
[]
[]
221
skim-rs/skim
282
skim-rs__skim-282
[ "278" ]
dade97c7247eb971d7e4dda8d8f648d8c143aa7f
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -10,8 +10,18 @@ use crate::field::get_string_by_range; use crate::item::ItemWrapper; use crate::SkimItem; +lazy_static! { + static ref RE_ESCAPE: Regex = Regex::new(r"['\U{00}]").unwrap(); +} + pub fn escape_single_quote(text: &str) -...
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -413,4 +423,9 @@ mod tests { assert_eq!("'cmd_query'", inject_command("{cq}", default_context)); assert_eq!("'a,b,c' 'x,y,z'", inject_command("{+}", default_context)); } + + #[test] + fn test_escape_single_quote()...
Can't preview string with nul byte ```zsh > sk --preview-window=down --preview='echo {}' <<<$'abc\0cba' ``` Got an error: ![图片](https://user-images.githubusercontent.com/17017672/75601906-e8a9fe00-5afa-11ea-9fdb-9e6e7e45c9fe.png)
2020-03-01T14:58:58
0.8
da913fb9de587a75158fe67b3756574dbd5e5efb
[ "util::tests::test_escape_single_quote" ]
[ "ansi::tests::test_normal_string", "ansi::tests::test_reset", "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "spinlock::tests::smoke", "query::test:...
[]
[]
222
skim-rs/skim
105
skim-rs__skim-105
[ "104" ]
817b75c09663bf57888bee1ae08bd820dc4d7414
diff --git a/shell/key-bindings.bash b/shell/key-bindings.bash --- a/shell/key-bindings.bash +++ b/shell/key-bindings.bash @@ -58,7 +58,7 @@ __skim_history__() ( shopt -u nocaseglob nocasematch line=$( HISTTIMEFORMAT= history | - SKIM_DEFAULT_OPTIONS="--height ${SKIM_TMUX_HEIGHT:-40%} $SKIM_DEFAULT_OPTION...
diff --git a/src/field.rs b/src/field.rs --- a/src/field.rs +++ b/src/field.rs @@ -251,7 +244,7 @@ mod test { #[test] fn test_parse_transform_fields() { // delimiter is "," - let re = Regex::new(".*?,").unwrap(); + let re = Regex::new(",").unwrap(); assert_eq!( s...
zsh history binding malfunctional? Perhaps I am missing something, but when using the zsh history binding, it doesn't work as before. A couple things I've tried that don't work: `^r` doesn't rotate the mode and `prefix-exact-match`. The search syntax isn't completely broken, as at least the `exact-match` type works. ...
2018-11-10T09:56:39
0.5
a33fe3635b080be7ccfcd7468a457db01fec05bb
[ "field::test::test_parse_transform_fields", "field::test::test_parse_matching_fields" ]
[ "field::test::test_parse_field_range", "model::tests::test_reshape_string", "model::tests::test_accumulate_text_width", "orderedvec::test::test_push_get", "query::test::test_add_char", "query::test::test_backward_delete_char", "field::test::test_get_string_by_field", "query::test::test_new_query", "...
[]
[]
223
skim-rs/skim
239
skim-rs__skim-239
[ "231", "220" ]
11c80768e0664878fc6fada1a31e7c9d0dfa8590
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -69,9 +69,14 @@ impl Perform for ANSIParser { return; } - let mut attr = self.last_attr; - let mut iter = params.into_iter(); + // \[[m => means reset + let mut attr = if params.is_empty() {...
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -349,4 +355,11 @@ mod tests { assert_eq!(Some(('i', attr)), it.next()); assert_eq!(None, it.next()); } + + #[test] + fn test_reset() { + let input = "\x1B[35mA\x1B[mB"; + let ansistring = ANSIParser:...
ANSI colors are ignored in some cases I can reproduce it by: ```sh /usr/bin/ls -1 --color | sk --ansi ``` Or... ```sh e=$(echo -ne '\e') sk --ansi <<EOF $e[34mno $e[36mno$e[0m $e[36mno$e[0m ABC$e[34myes $e[36myes$e[39mABC ABC$e[36myes$e[0m ABC$e[36myes$e[0mABC EOF ``` bat highlight-line not working pro...
Should be fixed? Tested on MacOS + current master. ![image](https://user-images.githubusercontent.com/1527040/70593585-91417380-1c18-11ea-8e81-22106a753304.png)
2019-12-11T23:58:55
0.6
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "ansi::tests::test_reset" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "field::test::test_parse_field_range", "query::test::test_add_char", "field::test::test_parse_matching_fields", "query::test::test_new_query", "query::test::test_backward_delete_char", "fie...
[]
[]
224
starship/starship
2,613
starship__starship-2613
[ "2610" ]
0f3a58352f4e84718b95bfb42340348cfc60ee25
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -1453,7 +1453,8 @@ symbol = "🌟 " The `jobs` module shows the current number of jobs running. The module will be shown only if there are background jobs running. The module will show the number of jo...
diff --git a/src/modules/jobs.rs b/src/modules/jobs.rs --- a/src/modules/jobs.rs +++ b/src/modules/jobs.rs @@ -109,4 +118,32 @@ mod test { let expected = Some(format!("{} ", Color::Blue.bold().paint("✦3"))); assert_eq!(expected, actual); } + + #[test] + fn config_0_job_0() { + let ac...
[jobs] Cannot take negative value (zero jobs not shown) ## Bug Report #### Current Behavior ```toml [jobs] threshold = -1 ``` does not show 0 (zero) in the output if there are no background jobs. #### Expected Behavior `0` (zero) is printed for zero background jobs #### Environment ``` $ starsh...
2021-04-20T07:04:13
0.51
0f3a58352f4e84718b95bfb42340348cfc60ee25
[ "modules::golang::tests::folder_with_go_file", "modules::golang::tests::folder_with_go_mod", "modules::jobs::test::config_0_job_0", "modules::nodejs::tests::engines_node_version_match", "modules::nodejs::tests::engines_node_version_not_match", "modules::nodejs::tests::folder_with_ts_file", "modules::oca...
[ "bug_report::tests::test_get_shell_info", "bug_report::tests::test_get_config_path", "config::tests::test_from_string", "bug_report::tests::test_make_github_link", "config::tests::table_get_styles_bold_italic_underline_green_dimmy_silly_caps", "config::tests::test_load_nested_config", "config::tests::te...
[ "modules::cmake::tests::buildfolder_with_cmake_cache", "modules::crystal::tests::folder_with_cr_file", "modules::dart::tests::folder_with_dart_file", "modules::crystal::tests::folder_with_shard_file", "modules::cmake::tests::folder_with_cmake_lists", "modules::deno::tests::folder_with_deps_js", "modules...
[ "modules::dotnet::tests::shows_latest_in_directory_with_fsproj", "modules::dotnet::tests::shows_latest_in_directory_with_csproj", "modules::dotnet::tests::shows_latest_in_directory_with_directory_build_props_file", "modules::dotnet::tests::shows_latest_in_directory_with_directory_build_targets_file" ]
225
starship/starship
2,456
starship__starship-2456
[ "2009" ]
69b9bf72c3380217d82cec863edb7db0f29e6862
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -454,7 +454,7 @@ the module will be activated if any of the following conditions are met: | Option | Default | Description |...
diff --git a/src/modules/cmake.rs b/src/modules/cmake.rs --- a/src/modules/cmake.rs +++ b/src/modules/cmake.rs @@ -77,7 +77,7 @@ mod tests { let dir = tempfile::tempdir()?; File::create(dir.path().join("CMakeLists.txt"))?.sync_all()?; let actual = ModuleRenderer::new("cmake").path(dir.path())...
NerdFonts Codepoint Leakage [Issue 365 on NerdFonts](https://github.com/ryanoasis/nerd-fonts/issues/365) affects the CMake symbol that we currently use in our module. There are two issues here: - Users who are not using nerd-patched fonts will see a CJK symbol instead of however their terminal emulator displays an u...
Maybe this is why I can see this broken symbol instead of the battery icon? ![image](https://user-images.githubusercontent.com/21174107/104346753-1247fa00-5500-11eb-86e2-c8d68f1fd0fe.png) Manjaro with Konsole, Breeze shell theme with Fira Code 10pt font from system repository. How can I solve it or what has b...
2021-03-13T00:55:47
0.50
69b9bf72c3380217d82cec863edb7db0f29e6862
[ "modules::cmake::tests::buildfolder_with_cmake_cache", "modules::cmake::tests::folder_with_cmake_lists" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_ordered", "config::tests::table_get_styles_bold_italic_underline_green_dimmy_silly_caps", "config::tests::test_from_bool", "bug_report::tests::test_get_shell_info", "config::tests::table_get_styles_plain_and_broken_styles", "con...
[ "modules::directory::tests::linux::directory_in_root", "modules::directory::tests::root_directory", "modules::username::tests::logname_equals_user", "modules::username::tests::current_user_not_logname", "modules::username::tests::no_logname_env_variable", "modules::username::tests::ssh_connection", "mod...
[]
227
starship/starship
3,750
starship__starship-3750
[ "3746" ]
848bf693a4147db2651887f17751be11ba24e5a8
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -3083,7 +3083,7 @@ format = '[📦 \[$env\]]($style) ' ## Status The `status` module displays the exit code of the previous command. -The module will be shown only if the exit code is not `0`. +If $su...
diff --git a/src/modules/status.rs b/src/modules/status.rs --- a/src/modules/status.rs +++ b/src/modules/status.rs @@ -228,13 +229,59 @@ mod tests { use crate::test::ModuleRenderer; #[test] - fn success_status() { + fn success_status_success_symbol_empty() { let expected = None; + //...
success_symbol option of the status module is being ignored <!-- ───────────────────────────────────────────── ⚠️ IMPORTANT: Please run the following command to create an issue: starship bug-report An issue will be pre-populated with your system's configuration, making the process a whole lot quicker �...
Looking through the code, I see this comment: https://github.com/starship/starship/blob/a10e24b2052047d431b6a44b0a202f605c39bc96/src/modules/status.rs#L20 Seems like a rather odd choice. Why to restrict the user from displaying success status if he wishes to? Since it can easily be disabled by default by using: `...
2022-03-15T05:02:26
1.4
52fa4bbab4393589aebbeded4351886e657a6275
[ "modules::status::tests::success_status_success_symbol_filled" ]
[ "config::tests::test_from_bool", "config::tests::table_get_styles_with_none", "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_ordered", "config::tests::table_get_styles_plain_and_broken_styles", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", ...
[]
[]
231
starship/starship
3,569
starship__starship-3569
[ "3487" ]
589576d3eb643dad0dd88dc5df0236625497177a
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -1879,9 +1879,10 @@ kotlin_binary = "kotlinc" ## Kubernetes -Displays the current [Kubernetes context](https://kubernetes.io/docs/concepts/configuration/organize-cluster-access-kubeconfig/#context)...
diff --git a/src/modules/kubernetes.rs b/src/modules/kubernetes.rs --- a/src/modules/kubernetes.rs +++ b/src/modules/kubernetes.rs @@ -463,4 +528,162 @@ users: [] dir.close() } + + #[test] + fn test_kube_user() -> io::Result<()> { + let dir = tempfile::tempdir()?; + + let filename = ...
How to set kubernetes username ie with whom we login into k8s cluster in prompt <!-- ───────────────────────────────────────────── ⚠️ IMPORTANT: Please run the following command to create an issue: starship bug-report An issue will be pre-populated with your system's configuration, making the process a...
2022-02-06T23:40:28
1.2
589576d3eb643dad0dd88dc5df0236625497177a
[ "modules::aws::tests::expiration_date_set", "modules::kubernetes::tests::test_kube_cluster", "modules::kubernetes::tests::test_kube_cluster_missing", "modules::kubernetes::tests::test_kube_user_missing", "modules::kubernetes::tests::test_kube_user" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_ordered", "config::tests::table_get_styles_plain_and_broken_s...
[]
[]
232
starship/starship
3,536
starship__starship-3536
[ "3221" ]
c89c13038a34a52291d253e6d4b15c0dd4aa5dfa
diff --git a/src/modules/directory.rs b/src/modules/directory.rs --- a/src/modules/directory.rs +++ b/src/modules/directory.rs @@ -106,7 +106,9 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> { let after_repo_root = contracted_path.replacen(repo_path_vec[0], "", 1); let num_se...
diff --git a/src/modules/directory.rs b/src/modules/directory.rs --- a/src/modules/directory.rs +++ b/src/modules/directory.rs @@ -1669,6 +1671,36 @@ mod tests { assert_eq!(expected, actual); tmp_dir.close() } + + #[test] + fn highlight_git_root_dir_zero_truncation_length() -> io::Result<()...
Custom repo_root_style does not work with truncation_length = 0 <!-- ───────────────────────────────────────────── ⚠️ IMPORTANT: Please run the following command to create an issue: ...
2022-01-29T08:30:41
1.5
230e85be37a0fc12999d1e6ff1209e7d5f99ecd1
[ "modules::directory::tests::highlight_git_root_dir_zero_truncation_length" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_ordered", "config::tests::test_from_bool", "config::tests::...
[]
[]
233
starship/starship
3,359
starship__starship-3359
[ "3358" ]
c63e9a71bd958c576100fbbeaf5723bb22450fd9
diff --git a/src/modules/rust.rs b/src/modules/rust.rs --- a/src/modules/rust.rs +++ b/src/modules/rust.rs @@ -79,7 +79,7 @@ fn get_module_version(context: &Context, config: &RustConfig) -> Option<String> .or_else(|| find_rust_toolchain_file(context)) .or_else(|| execute_rustup_default(context)) ...
diff --git a/src/modules/rust.rs b/src/modules/rust.rs --- a/src/modules/rust.rs +++ b/src/modules/rust.rs @@ -275,11 +288,13 @@ mod tests { ); static OVERRIDES_INPUT: &str = - "/home/user/src/a beta-x86_64-unknown-linux-gnu\n\ - /home/user/src/b...
Rust version is incorrect when creating a rustup override #### Current Behavior <!-- A clear and concise description of the behavior. --> I have created an override with rustup, `rustup override set nightly` in one of my folders. #### Expected Behavior <!-- A clear and concise description of what you expected t...
starship is reading the output of `rustup override list` and tries to match it with the CWD. Related PR is https://github.com/starship/starship/pull/426 . A wild guess would be that there is a problem with matching the path under Windows? The place in the code is [here](https://github.com/syphar/starship/blob/e...
2021-12-29T06:01:52
1.1
c63e9a71bd958c576100fbbeaf5723bb22450fd9
[ "modules::rust::tests::test_extract_toolchain_from_rustup_override_list" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_ordered", "config::tests::test_from_bool", "config::tests::...
[]
[]
234
starship/starship
3,349
starship__starship-3349
[ "3341" ]
10e89121595827ce99042d036b1ee55f8a3a6a08
diff --git a/src/modules/dart.rs b/src/modules/dart.rs --- a/src/modules/dart.rs +++ b/src/modules/dart.rs @@ -3,6 +3,7 @@ use super::{Context, Module, RootModuleConfig}; use crate::configs::dart::DartConfig; use crate::formatter::StringFormatter; use crate::formatter::VersionFormatter; +use crate::utils::get_comman...
diff --git a/src/modules/dart.rs b/src/modules/dart.rs --- a/src/modules/dart.rs +++ b/src/modules/dart.rs @@ -71,6 +72,7 @@ fn parse_dart_version(dart_version: &str) -> Option<String> { #[cfg(test)] mod tests { use crate::test::ModuleRenderer; + use crate::utils::CommandOutput; use ansi_term::Color; ...
Dart version is not shown at all. #### Current Behavior With default dart module config I am shown `via 🎯 `, when I am in directory with dart project. #### Expected Behavior It should show the version. The output should be `via 🎯 2.15.1` #### Additional context/Screenshots I have not installed dart directly ...
What is the output of `command -v dart`? Is `dart` possibly a shell function that starship can't access? In general, this line could also be causing your issues by restricting `PATH` to only `/home/h` ```sh export PATH=/home/h ``` you might want to replace this with this: ```sh export PATH="/home/h:$PATH" ``...
2021-12-24T16:52:43
1.1
c63e9a71bd958c576100fbbeaf5723bb22450fd9
[ "modules::dart::tests::detect_version_output_in_stdout" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_with_none", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_plain_and_broken...
[]
[]
235
starship/starship
4,689
starship__starship-4689
[ "4608" ]
c9de67bd6629de7c31c753adbc6e31ddc807d8b6
diff --git a/.github/config-schema.json b/.github/config-schema.json --- a/.github/config-schema.json +++ b/.github/config-schema.json @@ -73,7 +73,7 @@ "disabled": false, "format": "with [$symbol($version )]($style)", "style": "bold blue", - "symbol": "🦬 ", + "symbol": "🐃 ", ...
diff --git a/src/modules/buf.rs b/src/modules/buf.rs --- a/src/modules/buf.rs +++ b/src/modules/buf.rs @@ -103,8 +102,10 @@ mod tests { .sync_all() .unwrap(); let actual = ModuleRenderer::new("buf").path(dir.path()).collect(); - let expected = Some(format!("with...
"Buf" icon broken on Windows 10 or lower #### Current Behavior On Windows 10, the icon for "buf" shows as an unknown symbol. #### Expected Behavior The icon should be shown correctly. #### Additional context/Screenshots The icon showed properly (but without a version number because the command timed out when t...
2022-12-06T11:14:19
1.11
c9de67bd6629de7c31c753adbc6e31ddc807d8b6
[ "modules::buf::tests::folder_with_buf_config" ]
[ "bug_report::tests::test_get_config_path", "bug_report::tests::test_make_github_link", "config::tests::table_get_palette", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_hidden_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests...
[]
[]
236
starship/starship
2,973
starship__starship-2973
[ "2937" ]
2865f135f0d0c0337f67141960e454f47e9d45b2
diff --git a/src/modules/git_status.rs b/src/modules/git_status.rs --- a/src/modules/git_status.rs +++ b/src/modules/git_status.rs @@ -230,43 +230,48 @@ struct RepoStatus { } impl RepoStatus { - fn is_conflicted(status: &str) -> bool { - status.starts_with("u ") - } - - fn is_deleted(status: &str) -...
diff --git a/src/modules/git_status.rs b/src/modules/git_status.rs --- a/src/modules/git_status.rs +++ b/src/modules/git_status.rs @@ -313,7 +318,7 @@ fn format_symbol(format_str: &str, config_path: &str) -> Option<Vec<Segment>> { mod tests { use ansi_term::{ANSIStrings, Color}; use std::fs::{self, File}; - ...
Git status: modified files are not shown if also staged #### Current Behavior When a file is both modified and staged, it will only be dis played as « staged ». #### Expected Behavior Take the file into account both in « staged » and « modified » #### Additional context/Screenshots ##### Git status of repo ...
2021-08-09T19:38:30
0.56
2865f135f0d0c0337f67141960e454f47e9d45b2
[ "modules::crystal::tests::folder_with_shard_file", "modules::dart::tests::folder_with_pubspec_yaml_file", "modules::cmake::tests::buildfolder_with_cmake_cache", "modules::deno::tests::folder_with_deps_ts", "modules::crystal::tests::folder_with_cr_file", "modules::dart::tests::folder_with_dart_file", "mo...
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_ordered", "config::tests::table_get_styles_plain_and_broken_s...
[ "modules::java::tests::folder_with_class_file", "modules::java::tests::folder_with_gradle_file", "modules::java::tests::folder_with_java_file_no_java_installed", "modules::java::tests::folder_with_gradle_kotlin_build_file", "modules::java::tests::folder_with_jar_archive", "modules::java::tests::folder_wit...
[ "modules::golang::tests::folder_with_glide_yaml", "modules::golang::tests::folder_with_go_mod", "modules::golang::tests::folder_with_go_file" ]
238
starship/starship
2,785
starship__starship-2785
[ "2567" ]
14a2ada1ee1db32d2334789587b57f18fe6913b4
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -839,7 +839,6 @@ the following files are present in the current directory: - `Directory.Build.props` - `Directory.Build.targets` - `Packages.props` -- `*.sln` - `*.csproj` - `*.fsproj` - `*.xproj`...
diff --git a/src/modules/dotnet.rs b/src/modules/dotnet.rs --- a/src/modules/dotnet.rs +++ b/src/modules/dotnet.rs @@ -395,10 +395,7 @@ mod tests { fn shows_latest_in_directory_with_solution() -> io::Result<()> { let workspace = create_workspace(false)?; touch_path(&workspace, "solution.sln", Non...
Dotnet module shows in a C/C++ repository <!-- ───────────────────────────────────────────── ⚠️ IMPORTANT: Please run the following command to create an issue: ...
Maybe one solution is not to consider the existence of a .sln file in "DotnetConfig.detect_extensions" as a proof of being in a dotnet project. In the end a '.sln' file is a structure to organize projects in a solution, and it can have a mix of c++ and c#/vb/f# subprojects in different folders.
2021-06-05T16:55:54
0.54
dc92d664e22f945645c3ac124a592285d5109894
[ "modules::aws::tests::expiration_date_set", "modules::crystal::tests::folder_with_shard_file", "modules::dart::tests::folder_with_pubspec_lock_file", "modules::dart::tests::folder_with_dart_file", "modules::cmake::tests::folder_with_cmake_lists", "modules::dart::tests::folder_with_pubspec_yaml_file", "m...
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_plain_and_broken_styles", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_or...
[]
[ "modules::perl::tests::folder_with_makefile_file", "modules::perl::tests::folder_with_cpanfile_file", "modules::perl::tests::folder_with_buildfile_file", "modules::perl::tests::folder_with_cpanfile_snapshot_file", "modules::perl::tests::folder_with_meta_json_file", "modules::perl::tests::folder_with_meta_...
239
starship/starship
2,782
starship__starship-2782
[ "2022" ]
2d92e70f516e9ebab4ff20c4d47f0e6098731629
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -791,7 +791,8 @@ truncation_symbol = "…/" The `docker_context` module shows the currently active [Docker context](https://docs.docker.com/engine/context/working-with-contexts/) if it's not set to -`...
diff --git a/src/modules/docker_context.rs b/src/modules/docker_context.rs --- a/src/modules/docker_context.rs +++ b/src/modules/docker_context.rs @@ -35,50 +41,46 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> { ) .join("config.json"); - if !docker_config.exists() { - return Non...
DOCKER_HOST should also be used for docker_context <!-- ───────────────────────────────────────────── ⚠️ IMPORTANT: Please run the following command to create an issue: ...
2021-06-04T23:13:44
0.55
2d92e70f516e9ebab4ff20c4d47f0e6098731629
[ "modules::deno::tests::folder_with_mod_ts", "modules::helm::tests::folder_with_helm_file" ]
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_ordered", "config::tests::table_get_styles_plain_and_broken_s...
[]
[ "modules::crystal::tests::folder_with_cr_file", "modules::cmake::tests::buildfolder_with_cmake_cache", "modules::cmake::tests::folder_with_cmake_lists", "modules::dart::tests::folder_with_pubspec_yaml_file", "modules::dart::tests::folder_with_pubspec_lock_file", "modules::dart::tests::folder_with_dart_fil...
240
starship/starship
2,702
starship__starship-2702
[ "1155" ]
c4f977c48d29790f27d332c32d97eff40fd258f1
diff --git a/src/modules/git_status.rs b/src/modules/git_status.rs --- a/src/modules/git_status.rs +++ b/src/modules/git_status.rs @@ -256,7 +256,7 @@ impl RepoStatus { fn is_modified(status: &str) -> bool { // is_wt_modified - status.starts_with("1 .M") + status.starts_with("1 .M") || sta...
diff --git a/src/modules/git_status.rs b/src/modules/git_status.rs --- a/src/modules/git_status.rs +++ b/src/modules/git_status.rs @@ -633,6 +633,21 @@ mod tests { repo_dir.close() } + #[test] + fn shows_added() -> io::Result<()> { + let repo_dir = fixture_repo(FixtureProvider::Git)?; + + ...
`git add -N` / `git add --intent-to-add` shows files as staged while they are not #### Current Behavior <!-- A clear and concise description of the behavior. --> When adding an untracked file using `git add -N -- $file` or `git add --intent-to-add -- $file`, then starship shows that there are staged files. However,...
Here is where it get wrong. https://github.com/starship/starship/blob/02edad0c66474758d145ac17e36ba28836d1eced/src/modules/git_status.rs#L266 It should be easy to fix by reading the API of `libgit2`. Currently there is a refactor that replaces this module with a faster alternative (see matchai/starship-poc, whic...
2021-05-08T03:54:19
0.53
c4f977c48d29790f27d332c32d97eff40fd258f1
[ "modules::elm::tests::folder_with_elm_file", "modules::elm::tests::folder_with_elm_json", "modules::dotnet::tests::shows_single_tfm", "modules::elixir::tests::test_with_mix_file", "modules::elm::tests::folder_with_elm_version", "modules::erlang::tests::test_with_config", "modules::elm::tests::folder_wit...
[ "bug_report::tests::test_get_config_path", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_silly_caps", "config::tests::table_get_styles_plain_and_broken_styles", "config::tests::table_get_styles_or...
[]
[ "modules::golang::tests::folder_with_go_version", "modules::helm::tests::folder_with_chart_file", "modules::helm::tests::folder_with_helm_file", "modules::golang::tests::folder_with_gopkg_lock", "modules::golang::tests::folder_with_gopkg_yml", "modules::nodejs::tests::engines_node_version_not_match", "m...
241
starship/starship
6,314
starship__starship-6314
[ "6170" ]
cbc22a316db52f253719e258a3cd3c8fa4e1495b
diff --git a/docs/config/README.md b/docs/config/README.md --- a/docs/config/README.md +++ b/docs/config/README.md @@ -1267,7 +1267,7 @@ disabled = false The `docker_context` module shows the currently active [Docker context](https://docs.docker.com/engine/context/working-with-contexts/) -if it's not set to `defaul...
diff --git a/src/modules/docker_context.rs b/src/modules/docker_context.rs --- a/src/modules/docker_context.rs +++ b/src/modules/docker_context.rs @@ -347,6 +348,24 @@ mod tests { cfg_dir.close() } + #[test] + fn test_docker_context_default_after_3_5() -> io::Result<()> { + let cfg_dir = te...
Docker context is shown even though is is default #### Current Behavior Docker Desktop uses "desktop-linux" instead of "default" as the default context since version 3.5. #### Expected Behavior If the context is "desktop-linux" it should not be shown in my opinion. #### Environment - Starship version: 1.20.1 ...
2024-10-12T07:26:51
1.20
cbc22a316db52f253719e258a3cd3c8fa4e1495b
[ "modules::docker_context::tests::test_docker_context_default_after_3_5" ]
[ "config::tests::read_config_no_config_file_path_provided", "bug_report::tests::test_get_config_path", "config::tests::table_get_colors_palette", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_inverted_silly_caps", "config::tests::table_get_styles_bold_italic_underline_green_dimmed_blink...
[ "modules::username::tests::show_always_false" ]
[]
242
static-web-server/static-web-server
166
static-web-server__static-web-server-166
[ "165" ]
8017446d9d1099217b7d1ed451e57b2912d0cc1e
diff --git a/src/compression_static.rs b/src/compression_static.rs --- a/src/compression_static.rs +++ b/src/compression_static.rs @@ -31,20 +31,22 @@ pub async fn precompressed_variant( // Try to find the pre-compressed metadata variant for the given file path if let Some(ext) = precomp_ext { let mu...
diff --git a/tests/compression_static.rs b/tests/compression_static.rs --- a/tests/compression_static.rs +++ b/tests/compression_static.rs @@ -126,4 +126,31 @@ mod tests { "body and index_gz_buf are not equal in length" ); } + + #[tokio::test] + async fn compression_static_base_path_as_...
Server crashes with compression-static enabled and root as "." **Describe the bug** The server crashes when it receives a request for "/" with static compression enabled and root as ".". This only happens if the client supports compression **To Reproduce** run `static-web-server --root . --compression-static true...
2022-12-02T11:22:49
2.14
8017446d9d1099217b7d1ed451e57b2912d0cc1e
[ "tests::compression_static_base_path_as_dot" ]
[ "basic_auth::tests::test_invalid_auth_encoding", "basic_auth::tests::test_invalid_auth_encoding2", "basic_auth::tests::test_invalid_auth", "basic_auth::tests::test_invalid_auth_header", "basic_auth::tests::test_invalid_auth_pairs", "static_files::tests::test_sanitize_path", "control_headers::tests::head...
[]
[]
245
static-web-server/static-web-server
471
static-web-server__static-web-server-471
[ "470" ]
dd48972896d859344a84e5d2944d6662ccc22dcb
diff --git a/src/compression.rs b/src/compression.rs --- a/src/compression.rs +++ b/src/compression.rs @@ -98,6 +98,11 @@ pub(crate) fn post_process<T>( return Ok(resp); } + let is_precompressed = resp.headers().get(CONTENT_ENCODING).is_some(); + if is_precompressed { + return Ok(resp); + ...
diff --git a/tests/compression.rs b/tests/compression.rs --- a/tests/compression.rs +++ b/tests/compression.rs @@ -16,7 +16,7 @@ pub mod tests { #[tokio::test] async fn compression_file() { - let opts = fixture_settings("toml/handler.toml"); + let opts = fixture_settings("toml/handler_fixtures...
Incorrect `content-encoding` for `gzip` when file is already available + `compression-static` ### Search for duplicate issues - [X] I already searched, and this issue is not a duplicate. ### Issue scope Docker / Kubernetes ### Describe the bug If I run `SWS` with my "frontend" package, with both regular and pre-co...
2024-08-13T07:20:43
2.32
dd48972896d859344a84e5d2944d6662ccc22dcb
[ "tests::compression_file" ]
[ "basic_auth::tests::test_auth_disabled", "basic_auth::tests::test_invalid_auth_encoding", "basic_auth::tests::test_invalid_auth", "basic_auth::tests::test_options_request", "basic_auth::tests::test_invalid_auth_configuration", "basic_auth::tests::test_invalid_auth_header", "basic_auth::tests::test_inval...
[]
[]
246
Peternator7/strum
288
Peternator7__strum-288
[ "283" ]
fcb9841a744543b993eb1645db35dbda541e9a30
diff --git a/strum_macros/src/helpers/type_props.rs b/strum_macros/src/helpers/type_props.rs --- a/strum_macros/src/helpers/type_props.rs +++ b/strum_macros/src/helpers/type_props.rs @@ -21,6 +21,7 @@ pub struct StrumTypeProperties { pub discriminant_others: Vec<TokenStream>, pub discriminant_vis: Option<Visi...
diff --git a/strum_tests/tests/enum_discriminants.rs b/strum_tests/tests/enum_discriminants.rs --- a/strum_tests/tests/enum_discriminants.rs +++ b/strum_tests/tests/enum_discriminants.rs @@ -1,6 +1,9 @@ -use enum_variant_type::EnumVariantType; -use strum::{Display, EnumDiscriminants, EnumIter, EnumMessage, EnumString, ...
EnumDiscriminants should inherit the repr of the enum they are derived from The below example code will generate `VehicleDiscriminants` enum with `Car` and `Truck` variants but it will be `repr(usize)` instead of inheriting the `u8` repr of `Vehicle` additionally they will have the default enum representations (`Car = ...
It's a breaking change, but I agree it's certainly more inline with what would be expected. Happy to take a PR if you're interested.
2023-08-01T22:43:37
0.25
597f8e941fb9dec5603f6892df4109b50f615160
[ "with_explicit_discriminant_value", "with_repr_uint", "with_repr_align" ]
[ "arbitrary_attributes_pass_through", "complicated_test", "crate_module_path_test", "from_ref_test", "fields_test", "filter_variant_attributes_pass_through", "from_ref_test_complex", "from_test", "from_test_complex", "override_visibility", "split_attributes_test", "renamed_test", "with_defaul...
[]
[]
249
Peternator7/strum
268
Peternator7__strum-268
[ "267" ]
025b1b5687d061bc4116f77578fa9fc2b3fc1f26
diff --git a/strum_macros/src/macros/enum_count.rs b/strum_macros/src/macros/enum_count.rs --- a/strum_macros/src/macros/enum_count.rs +++ b/strum_macros/src/macros/enum_count.rs @@ -2,11 +2,18 @@ use proc_macro2::TokenStream; use quote::quote; use syn::{Data, DeriveInput}; +use crate::helpers::variant_props::HasSt...
diff --git a/strum_tests/tests/enum_count.rs b/strum_tests/tests/enum_count.rs --- a/strum_tests/tests/enum_count.rs +++ b/strum_tests/tests/enum_count.rs @@ -11,12 +11,29 @@ enum Week { Saturday, } +#[allow(dead_code)] +#[derive(Debug, EnumCount, EnumIter)] +enum Pets { + Dog, + Cat, + Fish, + Bird...
Disabled variant still included in Count The [additional attributes docs](https://docs.rs/strum/latest/strum/additional_attributes/index.html#attributes-on-variants) define the `disabled` attribute as: > `disabled`: removes variant from generated code. However, when deriving the `EnumCount` trait, the disabled va...
2023-04-26T18:46:25
0.24
025b1b5687d061bc4116f77578fa9fc2b3fc1f26
[ "disabled_test" ]
[ "crate_module_path_test", "simple_test" ]
[]
[]
250
FuelLabs/sway
6,451
FuelLabs__sway-6451
[ "6447" ]
4af5cd5f52b26194c06c720fd14c7f8ce123befb
diff --git a/swayfmt/src/items/item_storage/mod.rs b/swayfmt/src/items/item_storage/mod.rs --- a/swayfmt/src/items/item_storage/mod.rs +++ b/swayfmt/src/items/item_storage/mod.rs @@ -275,6 +275,12 @@ impl LeafSpans for StorageEntry { impl LeafSpans for StorageField { fn leaf_spans(&self) -> Vec<ByteSpan> { ...
diff --git a/swayfmt/tests/mod.rs b/swayfmt/tests/mod.rs --- a/swayfmt/tests/mod.rs +++ b/swayfmt/tests/mod.rs @@ -3129,3 +3129,29 @@ fn impl_func_where() { "#}, ); } + +#[test] +fn retain_in_keyword() { + check( + indoc! {r#" + contract; + use standards::src14::{SRC14, SRC14_TARG...
forc-fmt: removes `in` keyword With forc 0.63.1 nightly: <img width="441" alt="Screenshot 2024-08-21 at 17 49 20" src="https://github.com/user-attachments/assets/f626e873-0273-4b2f-85fe-3eb3623bf766"> using forc fmt removes the `in` keyword: https://github.com/user-attachments/assets/1e65a067-2ae4-40aa-a891-a66d...
2024-08-22T10:56:18
0.32
eaac6499681135f1f499a2a9bf89bbaf4f82f78e
[ "retain_in_keyword" ]
[ "comment_between_closing_brace_and_else", "chained_methods_1", "broken_doc_comment", "bug_whitespace_added_after_comment", "chained_methods_0", "comments_before_module_kind", "abi_supertrait", "comment_between_if_else_inline_to_multiline", "comments_between_if_else", "comments_empty_traits", "co...
[]
[]
253