Datasets:
r1v3r
/
auto_0207_bug

Dataset card Data Studio Files
xet
 Community
1
repo
stringlengths
8
35
pull_number
int64
25
15.2k
instance_id
stringlengths
13
40
issue_numbers
listlengths
1
3
base_commit
stringlengths
40
40
patch
stringlengths
274
342k
test_patch
stringlengths
308
210k
problem_statement
stringlengths
25
44.3k
hints_text
stringlengths
0
33.6k
created_at
stringlengths
19
30
version
stringlengths
3
5
environment_setup_commit
stringlengths
40
40
FAIL_TO_PASS
listlengths
1
1.1k
PASS_TO_PASS
listlengths
0
7.38k
FAIL_TO_FAIL
listlengths
0
1.72k
PASS_TO_FAIL
listlengths
0
49
__index_level_0__
int64
0
689
swc-project/swc
2,227
swc-project__swc-2227
[ "2050" ]
9ffe47106a70150579b80d103bd1a0193e5b8483
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2287,7 +2287,7 @@ checksum = "6446ced80d6c486436db5c078dde11a9f73d42b57fb273121e160b84f63d894c" [[package]] name = "swc" -version = "0.52.0" +version = "0.53.0" dependencies = [ "ahash", "anyhow", diff --git a/Cargo.lock b/Cargo.lock --...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -3161,7 +3161,7 @@ dependencies = [ [[package]] name = "testing" -version = "0.13.0" +version = "0.13.1" dependencies = [ "ansi_term 0.12.1", "difference", diff --git a/node-swc/__tests__/paths_test.mjs b/node-swc/__tests__/paths_test.mj...
Path aliases don't seem to respect nested folder structure <!-- If you are using swc at work, please considering adding your company to https://swc.rs/users/ If then, your issue will be fixed more quickly. --> **Describe the bug** After https://github.com/swc-project/swc/issues/1934 and https://github.com/swc-pr...
Also worth noting that SWC currently only appears to transform ES-style `import`s. Paths are not resolved for CJS imports with `require('~/file.ts')` @schmod I don't think that's related to this issue, you may want to create a new one, I guess. There is also https://github.com/swc-project/swc/issues/1943 but that...
2021-09-10T14:53:50
0.52
9ffe47106a70150579b80d103bd1a0193e5b8483
[ "tests_tests__fixture__paths__cjs_001__input" ]
[ "config::tests::object", "config::tests::issue_1532", "config::tests::array", "swcrc_simple", "issue_1532", "await_expr", "await_expr_2", "deno_10282_2", "codegen_1", "issue_1549", "deno_10282_1", "issue_1052", "issue_226", "issue_1984", "issue_406", "issue_225", "issue_389", "issu...
[ "env_query_chrome_71", "project_env", "tests_tests__fixture__issue_1271__input", "tests_tests__fixture__issue_1235__case_1__input", "tests_tests__fixture__issue_1314__case1__input", "tests_tests__fixture__issue_1402__case1__input", "tests_tests__fixture__issue_1448__case1__input", "tests_tests__fixtur...
[]
254
swc-project/swc
2,514
swc-project__swc-2514
[ "2344" ]
4abde38dd78fb1885b0acfcdd90be50795628f9d
diff --git a/ecmascript/transforms/module/src/util.rs b/ecmascript/transforms/module/src/util.rs --- a/ecmascript/transforms/module/src/util.rs +++ b/ecmascript/transforms/module/src/util.rs @@ -506,6 +506,7 @@ impl Scope { } match expr { + // In a JavaScript module, this is undefined at ...
diff --git a/ecmascript/transforms/module/tests/common_js.rs b/ecmascript/transforms/module/tests/common_js.rs --- a/ecmascript/transforms/module/tests/common_js.rs +++ b/ecmascript/transforms/module/tests/common_js.rs @@ -26,6 +26,7 @@ fn syntax() -> Syntax { Syntax::Es(EsConfig { dynamic_import: true, ...
Incorrect transpilation of an arrow function in class fields Hi team, first, thanks for the awesome work! I struggle with an issue when `swc` doesn't transpile correctly an arrow funciton when it used as a value of a class field (no matter JS or TS). It's quite typical way for React users to avoid an explicit hand...
This is caused by commonjs transform. Edit: I know Another problem, although I don't know if it's within swc's scope to provide single transform: When using only arrow transform, swc would transform following code ```js class LoggingButton extends React.Component { handleClick = () => { con...
2021-10-23T03:02:56
0.77
430a06ce4ddf4e0ee96176789df86ed5df137702
[ "issue_2344_3", "issue_2344_1", "issue_2344_2" ]
[ "for_of_as_array_for_of_import_commonjs", "custom_02", "fixture_tests__fixture__commonjs__issue_2211__2__input_js", "fixture_tests__fixture__commonjs__issue_2297__input_js", "fixture_tests__fixture__commonjs__issue_2211__1__input_js", "disable_strict_mode_strict_mode_false", "custom_usage", "interop_e...
[]
[]
256
swc-project/swc
2,447
swc-project__swc-2447
[ "2351", "2446" ]
7f04ef47155cb8ec06eb4296d8c3c915c79221d6
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2707,7 +2707,7 @@ dependencies = [ [[package]] name = "swc_ecma_parser" -version = "0.73.13" +version = "0.73.14" dependencies = [ "either", "enum_kind", diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2926,7 ...
diff --git a/ecmascript/parser/src/lexer/tests.rs b/ecmascript/parser/src/lexer/tests.rs --- a/ecmascript/parser/src/lexer/tests.rs +++ b/ecmascript/parser/src/lexer/tests.rs @@ -939,7 +939,7 @@ fn issue_299_01() { Token::JSXName { name: "num".into() }, tok!('='), Token::Str { - ...
JSX attribute parsing applies incorrect escapes **Describe the bug** JSX attributes should be parsed as HTML (i.e. escapes are HTML entities), however SWC seems to parse them as JS strings (i.e. backslashes escape characters). **Input code** ```js const a = <abbr title="\d">\d</abbr>; ``` [See in REPL](ht...
I don’t think the above PR fixes the issue; if I’m reading the test code correctly then it seems to enforce the broken behaviour.
2021-10-16T10:42:35
0.70
7f04ef47155cb8ec06eb4296d8c3c915c79221d6
[ "jsx::tests::fixture_tests__jsx__fixture__vercel__2__input_js" ]
[ "error::size_of_error", "lexer::number::tests::issue_480", "lexer::number::tests::large_bin_number", "lexer::number::tests::big_number_with_fract", "lexer::number::tests::large_float_number", "lexer::number::tests::num_big_many_zero", "lexer::number::tests::num_big_exp", "lexer::number::tests::num_inf...
[ "lexer::tests::issue_299_01", "lexer::tests::issue_299_02", "jsx::tests::fixture_tests__jsx__fixture__react__should_escape_xhtml_jsxattribute__input_js", "jsx::tests::fixture_tests__jsx__fixture__react__should_escape_xhtml_jsxattribute_babel_7__input_js", "jsx::tests::fixture_tests__jsx__fixture__react_auto...
[]
257
swc-project/swc
9,631
swc-project__swc-9631
[ "9630" ]
aa3bb873653d8c33a535a8b6547480e363575a05
diff --git /dev/null b/.changeset/neat-ties-smoke.md new file mode 100644 --- /dev/null +++ b/.changeset/neat-ties-smoke.md @@ -0,0 +1,6 @@ +--- +swc_ecma_codegen: patch +swc_core: patch +--- + +fix(es/codegen): Emit space after div if rhs has leading comment diff --git a/crates/swc_ecma_codegen/src/lib.rs b/crates/swc...
diff --git a/crates/swc_ecma_codegen/src/tests.rs b/crates/swc_ecma_codegen/src/tests.rs --- a/crates/swc_ecma_codegen/src/tests.rs +++ b/crates/swc_ecma_codegen/src/tests.rs @@ -962,6 +962,19 @@ fn issue_8491_2() { ); } +#[test] +fn issue_9630() { + test_from_to_custom_config( + "console.log(1 / /* @...
Correctness - Division plus block comment is turned into line comment ### Describe the bug When a division operator is followed by a block comment, the result must have a whitespace between them, otherwise it becomes a line comment. ```js // original a / /**/ b // current behavior a//**/b // what it should lo...
2024-10-11T10:23:50
2.0
82c6059121107a989b37c4ac0e8964cf54caaaae
[ "tests::issue_9630" ]
[ "expr::tests::conditional_expression", "decl::tests::issue_1764", "decl::tests::issue_275", "expr::tests::bin_expr", "expr::tests::array_spread", "expr::tests::call_expression", "decl::tests::class_static_block", "decl::tests::single_argument_arrow_expression", "expr::tests::bigint_property_key", ...
[ "tests::test_str_lit_tests__str_lits__pr_7985__splitted__16_txt", "tests::test_str_lit_tests__str_lits__pr_7985__splitted__1_txt", "tests::test_str_lit_tests__str_lits__pr_7985__splitted__15_txt", "tests::test_str_lit_tests__str_lits__pr_7985__splitted__14_txt", "tests::test_str_lit_tests__str_lits__pr_7985...
[]
258
sycamore-rs/sycamore
760
sycamore-rs__sycamore-760
[ "718" ]
1e492e2f7fe110663b26f44961aaf08c26717af7
diff --git a/packages/sycamore-macro/src/component.rs b/packages/sycamore-macro/src/component.rs --- a/packages/sycamore-macro/src/component.rs +++ b/packages/sycamore-macro/src/component.rs @@ -280,23 +280,31 @@ fn inline_props_impl(item: &mut ItemFn, attrs: Punctuated<Meta, Token![,]>) -> R let props = inputs.cl...
diff --git a/packages/sycamore-macro/tests/component/inline-props-fail.rs b/packages/sycamore-macro/tests/component/inline-props-fail.rs --- a/packages/sycamore-macro/tests/component/inline-props-fail.rs +++ b/packages/sycamore-macro/tests/component/inline-props-fail.rs @@ -5,4 +5,20 @@ fn NotInlineProps() -> View { ...
Inline props does not properly support patterns **Describe the bug** Using `#[component(inline_props)]` does not properly account for using patterns in function parameters. **To Reproduce** ```rust #[component(inline_props)] fn Foo(mut value: i32) -> View { view! {} } ``` The problem occurs when genera...
@lukechu10 i can work on this > @lukechu10 i can work on this Great! Let's me know if you run into any issues.
2024-11-17T22:26:39
0.9
1e492e2f7fe110663b26f44961aaf08c26717af7
[ "tests/component/inline-props-pass.rs", "component_ui" ]
[ "tests/view/component-pass.rs", "tests/view/element-pass.rs", "tests/view/root-pass.rs", "view_ui", "tests/component/component-pass.rs", "packages/sycamore-macro/src/lib.rs - cfg_not_ssr (line 90)", "packages/sycamore-macro/src/lib.rs - cfg_ssr (line 66)" ]
[]
[]
259
trishume/syntect
530
trishume__syntect-530
[ "529", "529" ]
53413d566d6dc10e78cae2733a29e4aae7a98bdd
diff --git a/src/parsing/syntax_set.rs b/src/parsing/syntax_set.rs --- a/src/parsing/syntax_set.rs +++ b/src/parsing/syntax_set.rs @@ -213,6 +213,7 @@ impl SyntaxSet { /// This uses regexes that come with some sublime syntax grammars for matching things like /// shebangs and mode lines like `-*- Mode: C -*-` ...
diff --git a/src/parsing/syntax_set.rs b/src/parsing/syntax_set.rs --- a/src/parsing/syntax_set.rs +++ b/src/parsing/syntax_set.rs @@ -1401,6 +1402,16 @@ mod tests { assert_prototype_only_on(&["main"], &rebuilt, &rebuilt.syntaxes()[0]); } + #[test] + fn find_syntax_set_from_line_with_bom() { + ...
UTF-8 BOM prevents syntax detection by the first line of file This issue was reoprted to my project at first: https://github.com/rhysd/hgrep/issues/20 When [UTF-8 BOM](https://en.wikipedia.org/wiki/Byte_order_mark) is inserted at the head of file content, syntect fails to detect the syntax from the first line. Re...
2024-04-15T19:22:13
5.2
53413d566d6dc10e78cae2733a29e4aae7a98bdd
[ "parsing::syntax_set::tests::find_syntax_set_from_line_with_bom" ]
[ "highlighting::highlighter::tests::tricky_cases", "highlighting::selector::tests::matching_works", "highlighting::selector::tests::empty_stack_matching_works", "highlighting::selector::tests::multiple_excludes_matching_works", "highlighting::selector::tests::selectors_work", "easy::tests::can_find_regions...
[ "public_api" ]
[]
260
trishume/syntect
456
trishume__syntect-456
[ "453" ]
8678b7c68a7fbd195733aa23dcaa3dbaedaceb10
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -228,7 +228,10 @@ impl<'a> Iterator for LinesWithEndings<'a> { /// the `Vec<(Style, &str)>` returned by `highlight` methods. Look at the source /// code for `modify_range` for an example usage. #[allow(clippy::type_complexity)] -pub fn spl...
diff --git a/src/util.rs b/src/util.rs --- a/src/util.rs +++ b/src/util.rs @@ -328,6 +338,31 @@ mod tests { let (before, after) = split_at(l, 10); // out of bounds assert_eq!((&before[..], &after[..]), (&[(0u8, "abc"), (1u8, "def"), (2u8, "ghi")][..], &[][..])); + + let l = &[(0u8, "こんにちは"), ...
util::split_at panics with multibyte characters Sorry if duplicated. To reproduce panic, run the following code: ```rs use syntect::easy::HighlightLines; use syntect::highlighting::{Style, ThemeSet}; use syntect::parsing::SyntaxSet; use syntect::util::{as_24_bit_terminal_escaped, split_at, LinesWithEndings}; ...
Seems this panic comes from this line: ``` let (sa, sb) = rest[0].1.split_at(rest_split_i); ``` [[str - Rust](https://doc.rust-lang.org/std/primitive.str.html#method.split_at)](https://doc.rust-lang.org/std/primitive.str.html#method.split_at) > Panics if mid is not on a UTF-8 code point boundary, or...
2022-11-03T13:57:07
5.0
8678b7c68a7fbd195733aa23dcaa3dbaedaceb10
[ "util::tests::test_split_at" ]
[ "highlighting::selector::tests::empty_stack_matching_works", "highlighting::highlighter::tests::tricky_cases", "highlighting::selector::tests::matching_works", "highlighting::selector::tests::multiple_excludes_matching_works", "highlighting::selector::tests::selectors_work", "dumps::tests::has_default_the...
[]
[]
262
trishume/syntect
170
trishume__syntect-170
[ "169" ]
42f3da410ed78f3fcadf56e64f5990539c058110
diff --git a/src/parsing/syntax_set.rs b/src/parsing/syntax_set.rs --- a/src/parsing/syntax_set.rs +++ b/src/parsing/syntax_set.rs @@ -209,10 +209,10 @@ impl SyntaxSet { path_obj: P) -> io::Result<Option<&SyntaxDefinition>...
diff --git a/src/parsing/syntax_set.rs b/src/parsing/syntax_set.rs --- a/src/parsing/syntax_set.rs +++ b/src/parsing/syntax_set.rs @@ -418,9 +418,25 @@ impl FirstLineCache { mod tests { use super::*; use parsing::{Scope, syntax_definition}; + use std::collections::HashMap; + #[test] fn can_load(...
Unable to find correct syntax for "CMakeLists.txt" This [CMake.sublime-syntax](https://github.com/zyxar/Sublime-CMakeLists/blob/ff9a800a4ca942edd095de553ca05fba03b02275/CMake.sublime-syntax#L7) file specifies `CMakeLists.txt` as a "file extension", but `syntect` is currently not able to find the correct syntax, because...
2018-05-30T04:56:38
2.0
42f3da410ed78f3fcadf56e64f5990539c058110
[ "parsing::syntax_set::tests::can_load" ]
[ "highlighting::selector::tests::selectors_work", "highlighting::selector::tests::multiple_excludes_matching_works", "highlighting::selector::tests::matching_works", "highlighting::selector::tests::empty_stack_matching_works", "dumps::tests::has_default_themes", "highlighting::theme_set::tests::can_parse_c...
[]
[]
263
trishume/syntect
148
trishume__syntect-148
[ "139" ]
7243993a5dd4fdb04e60091ac4b6f9ddfa68ee7a
diff --git a/src/parsing/yaml_load.rs b/src/parsing/yaml_load.rs --- a/src/parsing/yaml_load.rs +++ b/src/parsing/yaml_load.rs @@ -54,8 +54,11 @@ struct ParserState<'a> { lines_include_newline: bool, } +// `__start` must not include prototypes from the actual syntax definition, +// otherwise it's possible that ...
diff --git a/src/parsing/parser.rs b/src/parsing/parser.rs --- a/src/parsing/parser.rs +++ b/src/parsing/parser.rs @@ -675,6 +675,27 @@ mod tests { expect_scope_stacks(&line, &expect, TEST_SYNTAX); } + #[test] + fn can_parse_prototype_that_pops_main() { + let syntax = r#" +name: test +scope...
Panicked at 'attempt to subtract with overflow', src/parsing/parser.rs I got a panic when parsing a Java file, here's a minimal reproduction case: ```shell $ echo '// TODO "%>"' > Minimal.java $ RUST_BACKTRACE=1 cargo run --example synstats Minimal.java ``` Stack trace: ``` thread 'main' panicked at 'attem...
I'm guessing the `main` context gets pushed off the stack due to https://github.com/sublimehq/Packages/blob/1c1aa090b6e892620faf4c05e29dc4797deff59e/Java/Java.sublime-syntax#L26-L28. I thought we re-push it like ST does when it is the root syntax, but I guess it's not working properly in this case due to the lookahead ...
2018-04-26T11:36:29
2.0
42f3da410ed78f3fcadf56e64f5990539c058110
[ "parsing::parser::tests::can_parse_prototype_that_pops_main" ]
[ "highlighting::selector::tests::multiple_excludes_matching_works", "highlighting::selector::tests::matching_works", "highlighting::selector::tests::empty_stack_matching_works", "highlighting::selector::tests::selectors_work", "dumps::tests::has_default_themes", "highlighting::theme_set::tests::can_parse_c...
[]
[]
264
quickwit-oss/tantivy
874
quickwit-oss__tantivy-874
[ "796" ]
2737822620362dd348b8d9396a26dd68cd928337
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -37,7 +37,7 @@ owning_ref = "0.4" stable_deref_trait = "1.0.0" rust-stemmers = "1.2" downcast-rs = { version="1.0" } -tantivy-query-grammar = { version="0.13", path="./query-grammar" } +tantivy-query-grammar = { version="0.14.0-dev", path="./q...
diff --git a/query-grammar/src/query_grammar.rs b/query-grammar/src/query_grammar.rs --- a/query-grammar/src/query_grammar.rs +++ b/query-grammar/src/query_grammar.rs @@ -279,6 +281,8 @@ pub fn parse_to_ast<'a>() -> impl Parser<&'a str, Output = UserInputAST> { #[cfg(test)] mod test { + type TestParseResult = Re...
Restrict characters in field names or fix query parser. As reported in https://jstrong.dev/posts/2020/building-a-site-search-with-tantivy/. Right now `my-field` is an accepted field, but the query parser is confused when parsing `my-field:myfieldvalue` Either fix the queryparser or restrict the available chara...
2020-08-30T22:09:27
1.3
2737822620362dd348b8d9396a26dd68cd928337
[ "query_grammar::test::test_field_name" ]
[ "occur::test::test_occur_compose", "query_grammar::test::test_occur_symbol", "query_grammar::test::test_occur_leaf", "query_grammar::test::test_parse_empty_to_ast", "query_grammar::test::test_parse_query_default_clause", "query_grammar::test::test_parse_query_single_term", "query_grammar::test::test_mus...
[]
[]
266
xd009642/tarpaulin
1,206
xd009642__tarpaulin-1206
[ "1160" ]
89c72d9590e376a3e300ae8158f8f58d4327d68b
diff --git a/src/source_analysis/attributes.rs b/src/source_analysis/attributes.rs --- a/src/source_analysis/attributes.rs +++ b/src/source_analysis/attributes.rs @@ -55,8 +55,24 @@ pub(crate) fn check_cfg_attr(attr: &Meta) -> bool { } } } + } else if id.is_ident("cfg_attr") { ...
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ operating systems - Set `LLVM_PROFILE_FILE` for building tests and delete the generated profraws to ignore build script coverage - Remove dependency on memmap +- Filter out expressions or items with `#[cfg_attr(tarpauli...
`#[no_coverage]` is working but `#[cfg_attr(tarpaulin, no_coverage)]` not **Describe the bug** I am conditionally add `no_coverage` attribute only if `--cfg tarpaulin` is set. ```rust #[cfg_attr(tarpaulin, no_coverage)] mod info; ``` It's not working but putting just `#[no_coverage]` works as expected. *...
2023-01-31T04:49:15
0.24
89c72d9590e376a3e300ae8158f8f58d4327d68b
[ "source_analysis::tests::tarpaulin_skip_attr" ]
[ "cargo::tests::llvm_cov_compatible_version", "cargo::tests::llvm_cov_incompatible_version", "branching::tests::for_branches", "branching::tests::if_elif_else", "cargo::tests::parse_rustflags_from_toml", "branching::tests::while_branches", "branching::tests::match_branches", "branching::tests::if_branc...
[ "cargo_run_coverage", "examples_coverage", "doc_test_bootstrap", "array_coverage", "failure_thresholds::coverage_above_threshold", "access_env_var", "breaks_expr_coverage", "continues_expr_coverage", "config_file_coverage", "dot_rs_in_dir_name", "boxes_coverage", "failure_thresholds::coverage_...
[]
267
Keats/tera
908
Keats__tera-908
[ "882" ]
3b2e96f624bd898cc96e964cd63194d58701ca4a
diff --git a/src/parser/mod.rs b/src/parser/mod.rs --- a/src/parser/mod.rs +++ b/src/parser/mod.rs @@ -427,6 +427,7 @@ fn parse_logic_val(pair: Pair<Rule>) -> TeraResult<Expr> { Rule::in_cond => expr = Some(parse_in_condition(p)?), Rule::comparison_expr => expr = Some(parse_comparison_expressi...
diff --git a/src/parser/tests/parser.rs b/src/parser/tests/parser.rs --- a/src/parser/tests/parser.rs +++ b/src/parser/tests/parser.rs @@ -360,6 +360,30 @@ fn parse_variable_tag_negated_expr() { ); } +#[test] +fn parse_variable_tag_negated_expr_with_parentheses() { + let ast = parse("{{ (not id or not true) ...
`if` statement with parens fails to parse The following fails to parse with tera but works fine with jinja2: ``` {% if (brand.id == "barfoo") or (brand.id == "foobar") %}LOL{% endif %} ``` with the following error: ``` Tera error: Error { kind: Msg("Failed to parse 'test.html'"), source: Some(Error { kind: Msg(...
I've just added a test in the next version for that (https://github.com/Keats/tera2/commit/c5dc6c9b5cfad6ae54ecc4a6f4bfc58641e29e3f) and it works Do you have a rough timeline for when we can expect terra2? Are we talking days, weeks or months? 😄 Definitely closer to months. A beta release will be tested for quite som...
2024-04-30T16:58:32
1.19
3b2e96f624bd898cc96e964cd63194d58701ca4a
[ "parser::tests::parser::parse_variable_tag_negated_expr_with_parentheses", "renderer::tests::basic::render_if_elif_else" ]
[ "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_first", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_first_empty", "builtins::filters::array::tests::tes...
[]
[]
269
Keats/tera
820
Keats__tera-820
[ "819" ]
226d0108cdb64c8d056e46c5c9a67a4a4e8549ea
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## 1.18.1 (2023-03-15) + +- Fix panic on invalid globs to Tera::new + ## 1.18.0 (2023-03-08) - Add `abs` filter diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [pack...
diff --git a/src/tera.rs b/src/tera.rs --- a/src/tera.rs +++ b/src/tera.rs @@ -1219,4 +1219,12 @@ mod tests { } } } + + // https://github.com/Keats/tera/issues/819 + #[test] + fn doesnt_panic_on_invalid_glob() { + let tera = Tera::new("\\dev/null/*"); + println!("{:?}",...
Non existent path causes panic instead of Error result New versions of tera panic instead of returning Error when passed an invalid glob path. For example: [rsgen-avro](https://github.com/lerouxrgd/rsgen-avro/blob/9e3eb0bfd0f7ba7a583bb7f3166fd67c41f4e708/src/templates.rs#L338 ) let mut tera = Tera::new("/dev/null...
That's not good, I'll fix it today unless someone beats me to it On Wed, 15 Mar 2023, 02:23 chupaty, ***@***.***> wrote: > New versions of tera panic instead of returning Error when passed an > invalid glob path. For example: > rsgen-avro > <https://github.com/lerouxrgd/rsgen-avro/blob/9e3eb0bfd0f7ba7a583bb7f3166fd67...
2023-03-15T17:14:22
1.18
226d0108cdb64c8d056e46c5c9a67a4a4e8549ea
[ "tera::tests::doesnt_panic_on_invalid_glob" ]
[ "builtins::filters::array::tests::test_first", "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests::test_first_empty", "builtins::filters::array::tests::tes...
[]
[]
270
Keats/tera
772
Keats__tera-772
[ "771" ]
da358f389f589649b4b99bef70195a870f5f73ff
diff --git a/src/builtins/filters/string.rs b/src/builtins/filters/string.rs --- a/src/builtins/filters/string.rs +++ b/src/builtins/filters/string.rs @@ -61,7 +61,7 @@ const PYTHON_ENCODE_SET: &AsciiSet = &USERINFO_ENCODE_SET lazy_static! { static ref STRIPTAGS_RE: Regex = Regex::new(r"(<!--.*?-->|<[^>]*>)").u...
diff --git a/src/builtins/filters/string.rs b/src/builtins/filters/string.rs --- a/src/builtins/filters/string.rs +++ b/src/builtins/filters/string.rs @@ -662,6 +662,7 @@ mod tests { ("\tfoo\tbar\t", "\tFoo\tBar\t"), ("foo bar ", "Foo Bar "), ("foo bar\t", "Foo Bar\t"), + ...
Title case filter with apostrophe - Capitalize issue With this input: {{ "Steiner's theorem" | title }} Current result is: Steiner'**S** Theorem Expected result is: Steiner'**s** Theorem First mentioned here: https://zola.discourse.group/t/title-case-filter-with-apostrophes/1526 Can be reproduced here: h...
I have a fix and a test case for it. I'll submit a PR.
2022-11-05T14:50:47
1.17
da358f389f589649b4b99bef70195a870f5f73ff
[ "builtins::filters::string::tests::test_title" ]
[ "builtins::filters::array::tests::test_filter", "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_filter_no_value", "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests...
[]
[]
271
Keats/tera
744
Keats__tera-744
[ "738" ]
76824f6a4bcdb0f845eaa3eac189c98cf25fd4ed
diff --git a/src/renderer/processor.rs b/src/renderer/processor.rs --- a/src/renderer/processor.rs +++ b/src/renderer/processor.rs @@ -303,8 +303,8 @@ impl<'a> Processor<'a> { } fn eval_in_condition(&mut self, in_cond: &'a In) -> Result<bool> { - let lhs = self.eval_expression(&in_cond.lhs)?; - ...
diff --git a/src/renderer/tests/basic.rs b/src/renderer/tests/basic.rs --- a/src/renderer/tests/basic.rs +++ b/src/renderer/tests/basic.rs @@ -151,6 +151,7 @@ fn render_variable_block_logic_expr() { hashmap.insert("b", 10); hashmap.insert("john", 100); context.insert("object", &hashmap); + context.ins...
The template's `in` doesn't work when a slash (/) exists due to escaping Given the Rust + template ``` context.insert("friends", &vec!["https://Bob", "Kate"]); ... Output: {% if "https://Bob" in friends %}TRUE{% endif %} ``` the output will be blank. If we instead run: - `{% if "https://Bob" in ["https:...
Weird that the literal would be escaped when checking with `in`, definitely a bug
2022-08-08T19:13:52
1.16
76824f6a4bcdb0f845eaa3eac189c98cf25fd4ed
[ "renderer::tests::basic::render_variable_block_logic_expr" ]
[ "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_join_empty", "builtins::filters::array::tests::test_last_empty", "builtins::filters::array::tests::test_map_empty", "builtins::filters::array::tests::test_map"...
[ "renderer::tests::basic::render_variable_block_ident", "renderer::tests::basic::render_variable_block_lit_expr" ]
[]
272
Keats/tera
703
Keats__tera-703
[ "702" ]
bf8a3d8305cb3ddae4cc191a3172b1ec646ff3df
diff --git a/src/builtins/filters/array.rs b/src/builtins/filters/array.rs --- a/src/builtins/filters/array.rs +++ b/src/builtins/filters/array.rs @@ -268,11 +268,6 @@ pub fn slice(value: &Value, args: &HashMap<String, Value>) -> Result<Value> { None => 0, }; - // Not an error, but returns an empty V...
diff --git a/src/builtins/filters/array.rs b/src/builtins/filters/array.rs --- a/src/builtins/filters/array.rs +++ b/src/builtins/filters/array.rs @@ -646,6 +646,8 @@ mod tests { (make_args(Some(1), Some(2.0)), vec![2]), (make_args(None, Some(-2.0)), vec![1, 2, 3]), (make_args(Non...
if `start > end` then `slice` filter panicks Hello! ``` {{ [1, "foo", 1, "true", "FOO", true, 2] | slice(start=4, end=2) }} ``` panick: ``` thread 'thread '<unnamed>thread '<unnamed>' panicked at 'slice index starts at 4 but ends at 2' panicked at 'slice index starts at 4 but ends at 2<unnamed>' panicked at '...
I think return an empty array so as to be consistent since following doesn't panick and simply returns empty array even if `start > end`: ``` {{ [1, "foo", 1, "true", "FOO", true, 2] | slice(start=8, end=2) }} ``` Preparing a PR now...
2022-01-08T03:16:53
1.15
bf8a3d8305cb3ddae4cc191a3172b1ec646ff3df
[ "builtins::filters::array::tests::test_slice" ]
[ "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_first", "builtins::filters::array::tests::test_first_empty", "builtins::filters::array::tests::tes...
[ "renderer::tests::basic::render_variable_block_lit_expr", "renderer::tests::basic::render_variable_block_ident" ]
[]
273
Keats/tera
623
Keats__tera-623
[ "590" ]
006f8e895f2dad8085378bb7feabcf6fcd38187b
diff --git a/src/renderer/processor.rs b/src/renderer/processor.rs --- a/src/renderer/processor.rs +++ b/src/renderer/processor.rs @@ -63,11 +63,11 @@ fn evaluate_sub_variables<'a>(key: &str, call_stack: &CallStack<'a>) -> Result<S Ok(new_key .replace("/", "~1") // https://tools.ietf.org/html/rfc6901#se...
diff --git a/src/context.rs b/src/context.rs --- a/src/context.rs +++ b/src/context.rs @@ -204,7 +204,15 @@ impl ValueTruthy for Value { /// Converts a dotted path to a json pointer one #[inline] pub fn get_json_pointer(key: &str) -> String { - ["/", &key.replace(".", "/")].join("") + lazy_static::lazy_static!...
URLs in HashMap keys results in "Failed to render" First off: thanks for making & maintaining this! Love it :) It seems like the square bracket syntax does not support (some of the characters in) URLs. ```rust let mut tera_context = tera::Context::new(); let mut map= HashMap::new(); map.insert("htt...
I think that's because the map key in the parser doesn't support characters like `:` or `/` maybe? A bit weird and shouldn't be too hard to fix if it's that. I did a few tests, and it's actually the `.` that's the problem. The map index is interpreted as a JSON Pointer into the context when rendered, but the dot is ...
2021-04-14T20:29:02
1.7
006f8e895f2dad8085378bb7feabcf6fcd38187b
[ "tera::tests::test_render_map_with_dotted_keys" ]
[ "builtins::filters::array::tests::test_filter_empty", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_first", "builtins::filters::array::tests::test_first_empty", "builtins::filters::array::tests::tes...
[ "renderer::tests::basic::render_variable_block_lit_expr", "renderer::tests::basic::render_variable_block_ident" ]
[]
274
Keats/tera
350
Keats__tera-350
[ "348" ]
507ae7cc7043a38b8c3a49df1e6dc7c4728bde00
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,16 @@ # Changelog +## 0.11.19 (2018-10-31) + +- Allow function calls in math expressions +- Allow string concatenation to start with a number +- Allow function calls in string concatenations +- Add a `concat` filter to concat ...
diff --git a/src/builtins/filters/array.rs b/src/builtins/filters/array.rs --- a/src/builtins/filters/array.rs +++ b/src/builtins/filters/array.rs @@ -174,6 +174,33 @@ pub fn slice(value: Value, args: HashMap<String, Value>) -> Result<Value> { Ok(arr[start..end].into()) } +/// Concat the array with another one ...
Expressions involving functions Some expressions that involve function calls don't work One such example is math operations on numbers: ```jinja2 {% set a = 3 %} {% set b = a + func_returning_integer() %} ``` This throws an unimplemented panic in `src/renderer/processor.rs:661` The workaround is to use an ...
That's a bug - well an unimplemented thing really. It should be easy to fix
2018-10-23T23:44:21
0.11
549510506fb972654a625df5bb54d02f07127b9a
[ "parser::tests::lexer::lex_string_concat", "renderer::tests::basic::can_use_concat_to_push_to_array", "renderer::tests::basic::can_do_string_concat" ]
[ "builtins::filters::array::tests::test_concat_array", "builtins::filters::array::tests::test_concat_single_value", "builtins::filters::array::tests::test_first", "builtins::filters::array::tests::test_first_empty", "builtins::filters::array::tests::test_filter", "builtins::filters::array::tests::test_join...
[ "parser::tests::errors::invalid_filter_section_missing_name", "parser::tests::errors::invalid_fn_call_missing_value", "parser::tests::errors::invalid_op", "parser::tests::errors::missing_container_name_in_forloop", "parser::tests::errors::missing_expression_in_if", "parser::tests::errors::missing_value_in...
[]
276
latex-lsp/texlab
1,291
latex-lsp__texlab-1291
[ "1279" ]
e99406e06519db99c4855d1e5979427cd4075f42
diff --git a/crates/parser/src/latex.rs b/crates/parser/src/latex.rs --- a/crates/parser/src/latex.rs +++ b/crates/parser/src/latex.rs @@ -113,6 +113,7 @@ impl<'a> Parser<'a> { Token::Pipe | Token::Word | Token::Comma => self.text(context), Token::Eq => self.eat(), Token::Dollar =...
diff --git a/crates/parser/src/latex/tests.rs b/crates/parser/src/latex/tests.rs --- a/crates/parser/src/latex/tests.rs +++ b/crates/parser/src/latex/tests.rs @@ -3690,3 +3690,541 @@ fn test_label_brackets_unbalanced() { "#]], ); } + +#[test] +fn test_href_with_space() { + check( + r#"\href{https:/...
[bug] texlab considers links containing `%` in `\href` as a comment Links to files containing spaces contain `%`, and `\href` allows you to insert the link as is. texlab seems to understand it as a comment and considers the `{` from `\href` to not be closed, therefore giving an error expecting a `}`. Reproducible ...
You can escape the `%` as `\%`, ``` \href{https://github.com/latex-lsp/texlab/example\%20file.pdf}{URL with \%}. ``` Alternatively, you can use a space instead of `%20`, ``` \href{https://github.com/latex-lsp/texlab/example file.pdf}{URL with \%}. ``` Both of these produce the desired result without the diagno...
2024-12-14T08:26:40
5.21
e99406e06519db99c4855d1e5979427cd4075f42
[ "latex::tests::test_href_nonstandard_char", "latex::tests::test_href_numeric_percentage", "latex::tests::test_href_top_anchor", "latex::tests::test_href_with_percent_character", "latex::tests::test_href_with_percent_encoded_query", "latex::tests::test_href_lone_space", "latex::tests::test_href_with_spac...
[ "bibtex::tests::test_aho_2006", "bibtex::tests::test_aksin_2006", "bibtex::tests::test_averroes_1998", "bibtex::tests::test_jain_1999", "bibtex::tests::test_kastenholz_2006", "bibtex::tests::test_betram_1996", "bibtex::tests::test_almendro_1998", "bibtex::tests::test_comment", "bibtex::tests::test_k...
[]
[]
278
latex-lsp/texlab
1,251
latex-lsp__texlab-1251
[ "910" ]
5fa0f4b49638497f8238a8a1e29d4ccfff50c74a
diff --git a/crates/base-db/src/semantics/auxiliary.rs b/crates/base-db/src/semantics/auxiliary.rs --- a/crates/base-db/src/semantics/auxiliary.rs +++ b/crates/base-db/src/semantics/auxiliary.rs @@ -5,6 +5,7 @@ use syntax::latex::{self, HasCurly}; #[derive(Debug, Clone, Default)] pub struct Semantics { pub label...
diff --git a/crates/symbols/src/document/tests.rs b/crates/symbols/src/document/tests.rs --- a/crates/symbols/src/document/tests.rs +++ b/crates/symbols/src/document/tests.rs @@ -281,44 +281,44 @@ fn test_section() { check( &fixture, expect![[r#" - [ - Symbol { - ...
Numbering on textDocument/documentSymbol I noticed, that when requesting for textDocument/documentSymbol the resulting sections (SymbolKind.Module = 2) only have a number if they are assigned with a label. A small example would be a document with ``` \section{Section}\label{sec:outer} % 1 Section \subsection{Subs...
2024-10-26T11:03:29
5.20
5fa0f4b49638497f8238a8a1e29d4ccfff50c74a
[ "document::tests::test_section" ]
[ "document::tests::test_equation", "workspace::sort::tests::test_no_cycles", "document::tests::test_float", "workspace::sort::tests::test_two_layers", "workspace::sort::tests::test_multiple_roots", "document::tests::test_theorem_amsthm", "document::tests::test_theorem_thmtools", "workspace::sort::tests...
[]
[]
279
XAMPPRocky/tokei
535
XAMPPRocky__tokei-535
[ "330" ]
ee19d28195647556607a7f0465ea96e94cf48eda
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,6 +65,24 @@ let x = /* There is a reason 10; ``` +The `verbatim_quotes` property expects an array of strings, as some languages +have multiple syntaxes for defining verbatim strings. A verbatim string +in the conte...
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -123,11 +141,13 @@ The comment should use the syntax of the language you're testing. A good example of a test file is [`tests/data/rust.rs`]. ```rust -// 39 lines 32 code 2 comments 5 blanks +// 41 lines 33 code 3 comments...
C# line count is broken if verbatim string with backslash is present **Describe the bug** Count is broken when there is a line in C# file with verbatim string in it like this: `private const string BasePath = @"a:\";`. **To Reproduce** 1. Download file [SccTokeiFailure.zip](https://github.com/boyter/scc/files/3...
Thank you for your issue! Yes tokei has no concept of verbatim strings. Do you know of any more languages with verbatim strings? I know Rust has them. I'll try to add this for the next version of Tokei. F# has them same way as C#. C++ has Raw Strings. Groovy has some form of that too AFAIK. Python has them too, e.g. no...
2020-05-19T12:32:23
11.2
ee19d28195647556607a7f0465ea96e94cf48eda
[ "cpp", "csharp", "fsharp", "rust" ]
[ "utils::ext::tests::contains", "language::language_type::tests::rust_allows_nested", "utils::ext::tests::trim", "utils::ext::tests::is_whitespace", "utils::fs::tests::ignore_directory_with_extension", "utils::fs::tests::no_ignore_parent", "utils::fs::tests::no_ignore", "utils::fs::tests::hidden", "u...
[]
[]
280
XAMPPRocky/tokei
868
XAMPPRocky__tokei-868
[ "859" ]
9ea344445cd938efe24d2132fb3b4347d8c8a6bc
diff --git a/src/language/language_type.rs b/src/language/language_type.rs --- a/src/language/language_type.rs +++ b/src/language/language_type.rs @@ -260,7 +260,8 @@ impl LanguageType { .collect::<Vec<_>>(); for (language, stats) in iter { - *jupyter_stats.blobs.entry(language).or_de...
diff --git a/src/language/language_type.rs b/src/language/language_type.rs --- a/src/language/language_type.rs +++ b/src/language/language_type.rs @@ -271,8 +272,29 @@ impl LanguageType { mod tests { use super::*; + use std::{fs, path::Path}; + #[test] fn rust_allows_nested() { assert!(Lan...
Jupyter Notebooks lines does not contribute to total sum Hi! It seams to me that `.ipynb` files get counted, but somehow do not contribute to the grand total. Example with the table from below: 415 lines of JavaScript + 2536 lines of Python = 2951 lines. Note that we have not added the "Jupyter Notebooks" lines ...
2021-12-19T13:58:12
12.1
9ea344445cd938efe24d2132fb3b4347d8c8a6bc
[ "language::language_type::tests::jupyter_notebook_has_correct_totals" ]
[ "language::language_type::tests::rust_allows_nested", "utils::ext::tests::is_whitespace", "utils::ext::tests::contains", "utils::ext::tests::trim", "utils::fs::tests::ignore_directory_with_extension", "utils::fs::tests::no_ignore_dot", "utils::fs::tests::no_ignore_implies_dot", "utils::fs::tests::no_i...
[]
[]
281
hyperium/tonic
395
hyperium__tonic-395
[ "379" ]
034c8502549fef85cd81332bc401bd2492f66ed3
diff --git a/tonic/src/status.rs b/tonic/src/status.rs --- a/tonic/src/status.rs +++ b/tonic/src/status.rs @@ -474,10 +474,11 @@ impl Status { } if !self.details.is_empty() { + let details = base64::encode_config(&self.details[..], base64::STANDARD_NO_PAD); + header_map.inser...
diff --git a/tonic/src/status.rs b/tonic/src/status.rs --- a/tonic/src/status.rs +++ b/tonic/src/status.rs @@ -837,4 +832,23 @@ mod tests { assert_eq!(Status::data_loss("").code(), Code::DataLoss); assert_eq!(Status::unauthenticated("").code(), Code::Unauthenticated); } + + #[test] + fn det...
`Status::details` leaks base64 encoding Currently, the `Status::with_details` will encode the details blob into base64 but when the getter `Status::details` gets called it will return the base64 encoded version where in-fact this should return the original blob.
2020-07-11T00:31:22
0.2
034c8502549fef85cd81332bc401bd2492f66ed3
[ "status::tests::details" ]
[ "codec::buffer::tests::decode_buf", "metadata::map::tests::test_from_headers_takes_http_headers", "metadata::map::tests::test_values_categorizes_binary_entries", "metadata::map::tests::test_values_categorizes_ascii_entries", "codec::buffer::tests::encode_buf", "metadata::map::tests::test_iter_mut_categori...
[]
[]
282
rome/tools
4,732
rome__tools-4732
[ "4193" ]
c1973600b0e5222ea7a294b82f744a8b08cc40c5
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,11 @@ - Fixed the diagnostics emitted when running the `rome format` command; +- Rome doesn't warn anymore when discovering (possibly infinite) symbolic links between directories. + This fixes [#4193](https://github.com/ro...
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -61,10 +61,10 @@ rome_parser = { version = "0.0.1", path = "./crates/rome_parser" rome_rowan = { version = "0.0.1", path = "./crates/rome_rowan" } rome_service = { path = "./crates/rome_service" }...
🐛 Infinite symlink expansion error when there's no infinite symlink AFAICT ### Environment information ```block CLI: Version: 11.0.0 Color support: true Platform: CPU Architecture: x86_64 OS: linux Environment: ROME_LOG_DIR: unset NO_COLOR: ...
The symbolic link detection is optimized for speed and does not cache the entire resolution tree. For this reason, the displayed error message is not very detailed. The warning message is shown, when an already traversed file path is found more than once. The interner is a cache of all traversed file paths. https://...
2023-07-28T19:32:19
0.0
85645de58d9f2a6b692bba6d9f19456a201eb774
[ "commands::check::fs_files_ignore_symlink" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::check::applies_organize_imports_from_cli", "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration", "cases::config_extends::extends_resolves_when_using_conf...
[ "commands::lint::fs_files_ignore_symlink" ]
[]
283
rome/tools
4,618
rome__tools-4618
[ "3989" ]
08645a80c6139ab969aa1917f7e01dae3845d236
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -117,6 +117,10 @@ multiple files: This rules disallow the use of `void`. +- Add [`noNonoctalDecimalEscape`](https://docs.rome.tools/lint/rules/nononoctaldecimalescape/) + + This rule disallows `\8` and `\9` escape sequences in strin...
diff --git /dev/null b/crates/rome_js_analyze/src/analyzers/nursery/no_nonoctal_decimal_escape.rs new file mode 100644 --- /dev/null +++ b/crates/rome_js_analyze/src/analyzers/nursery/no_nonoctal_decimal_escape.rs @@ -0,0 +1,381 @@ +use crate::JsRuleAction; +use rome_analyze::{context::RuleContext, declare_rule, Action...
`noNonoctalDecimalEscape`, no-nonoctal-decimal-escape https://eslint.org/docs/latest/rules/no-nonoctal-decimal-escape
👋 @rome/staff please triage this issue by adding one of the following labels: `S-Bug: confirmed`, `S-Planned` , `S-Wishlist` or `umbrella` 👋 @rome/staff please triage this issue by adding one of the following labels: `S-Bug: confirmed`, `S-Planned` , `S-Wishlist` or `umbrella` I'll work on this.
2023-06-26T01:26:59
0.1
08645a80c6139ab969aa1917f7e01dae3845d236
[ "specs::nursery::no_nonoctal_decimal_escape::valid_js", "specs::nursery::no_nonoctal_decimal_escape::invalid_js" ]
[ "aria_services::tests::test_extract_attributes", "utils::batch::tests::ok_remove_formal_parameter_from_class_constructor_first", "react::hooks::test::ok_react_stable_captures", "utils::batch::tests::ok_remove_first_member", "utils::batch::tests::ok_remove_formal_parameter_first", "utils::batch::tests::ok_...
[]
[]
285
tokio-rs/tracing
2,794
tokio-rs__tracing-2794
[ "1934" ]
f622a1e83ebe23a41a5e85269b66bee9c24b09f8
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -3,7 +3,6 @@ name: CI on: push: branches: - - master - "v0.1.x" pull_request: {} diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml --- a/.github/workflow...
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -40,16 +36,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 - with: - toolchain: stable - profile: ...
`NonBlocking` requires its inner writer to be `Sync` and I'm not sure why ## Bug Report ### Version `tracing-appender` master (according to tracing.rs) and 0.2.0 (according to docs.rs) ### Crates tracing-appender ### Description `tracing_appender::non_blocking::NonBlocking` requires its wrapped writer...
2023-11-07T08:23:27
0.1
96c0e297f1d5f1585166efcadf6057a804905447
[ "fields" ]
[ "rolling::test::test_never_date_rounding - should panic", "rolling::test::test_rotations", "rolling::test::write_daily_log", "rolling::test::write_hourly_log", "rolling::test::write_never_log", "rolling::test::test_make_writer", "rolling::test::write_minutely_log", "rolling::test::test_path_concatenat...
[ "string_field", "tracing-error/src/backtrace.rs - backtrace::SpanTrace::capture (line 79)", "tests::futures_03_tests::sink_enter_exit_is_reasonable", "tests::futures_03_tests::stream_enter_exit_is_reasonable", "journal_fields", "internal_null_byte", "multiline_message", "multiple_spans_metadata", "m...
[]
286
crate-ci/typos
410
crate-ci__typos-410
[ "409" ]
a329a99ec746285b3f31f11109f738a05a77dbec
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -216,7 +216,14 @@ mod parser { <T as nom::InputTakeAtPosition>::Item: AsChar + Copy, <T as nom::InputIter>::Item: AsChar + Copy, { - terminated( + ...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -935,10 +943,10 @@ mod test { fn tokenize_ignore_ordinal() { let parser = TokenizerBuilder::new().build(); - let input = "Hello 1st 2nd 3rd 4th World"; + ...
Underscore after ordinal number causes it to be marked as typo Bolding "2nd" using markdown is causing it to be marked as a typo ``` error: `nd` should be `and` --> ./gatsby/content/blog/2022/01/2022-01-21-twim.mdx:41:156 | 41 | > Work on preparing the release of Matrix v1.2 is currently underway. As of tod...
2022-01-25T10:01:37
1.3
4b2e66487c0d94e0f0ab1765a9e74bfed663aa1e
[ "tokens::test::tokenize_ignore_ordinal" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_ignore_email", "tokens::test::tokenize_ignore_base64", "tokens::test::tokenize_ignore_e...
[]
[]
288
crate-ci/typos
293
crate-ci__typos-293
[ "288" ]
a46cc76baebd75257e806ce35b3747ed922a683d
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](http://semver.org/). <!-- next-header --> ## [Unreleased] - ReleaseDate +#### Change of Behavior + +- `ignore-hex` and `identifier-leading-digit` are deprecated and `typo...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -613,11 +825,8 @@ mod test { } #[test] - fn tokenize_ignore_hex_enabled() { - let parser = TokenizerBuilder::new() - .ignore_hex(true) - ....
Don't Change Typos inside of URL I tried to apply this automatically to some repos and it tried to fix some URLs. Obviously, that won't work if the original URL has a typo and the URL is not under your control. Absolute HTTPS URLs should not be changed or at least there should be an option to disable the changing of th...
Things that might be useful from another tool - email handling: https://github.com/client9/misspell/blob/master/notwords.go#L66 - host handling: https://github.com/client9/misspell/blob/master/notwords.go#L71 - escape sequences: https://github.com/client9/misspell/blob/master/notwords.go#L77 - urls: https://github....
2021-06-30T03:44:26
1.0
a46cc76baebd75257e806ce35b3747ed922a683d
[ "tokens::test::tokenize_ignore_base64", "tokens::test::tokenize_ignore_email", "tokens::test::tokenize_ignore_max_url", "tokens::test::tokenize_ignore_min_url", "tokens::test::tokenize_ignore_uuid", "tokens::test::tokenize_leading_digits" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_ignore_hash", "tokens::test::tokenize_ignore_hex", "tokens::test::tokenize_namespace_separated_words", "tokens::test::tokenize_space_separated_words", "tokens::te...
[]
[]
290
crate-ci/typos
279
crate-ci__typos-279
[ "277" ]
04f5d40e574f04461859fd638c1c7b5b78eaecf7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/). <!-- next-header --> ## [Unreleased] - ReleaseDate +#### Bug Fixes + +- Fix the prior `typos <file>` fix that broke all other forms +- Extend the fix...
diff --git a/tests/cli.rs b/tests/cli.rs --- a/tests/cli.rs +++ b/tests/cli.rs @@ -29,3 +29,16 @@ fn test_file_failure() { cmd.arg("README.md"); cmd.assert().code(2); } + +#[test] +fn test_relative_dir_failure() { + let mut cmd = Command::cargo_bin("typos").unwrap(); + cmd.arg("."); + cmd.assert().c...
typos-cli Crash Report name = 'typos-cli' operating_system = 'windows' crate_version = '1.0.5' explanation = ''' Panic occurred in file 'C:\Users\brian\.cargo\registry\src\github.com-1ecc6299db9ec823\typos-cli-1.0.5\src\policy.rs' at line 90 ''' cause = '`walk()` should be called first' method = 'Panic' backtra...
Same error here. Tried running ``typos`` on Manjaro Linux using the v1.0.5 precompiled binary and this crash occurred. Same for `mac os`, when running `typos` binary after `cargo install`: ``` name = 'typos-cli' operating_system = 'unix:OSX' crate_version = '1.0.5' explanation = ''' Panic occurred in file '/Us...
2021-06-07T19:30:00
1.0
a46cc76baebd75257e806ce35b3747ed922a683d
[ "test_assumed_dir_failure", "test_relative_dir_failure" ]
[ "config::test::test_extend_glob_extends", "config::test::test_extend_glob_updates", "config::test::test_from_defaults", "config::test::test_update_from_defaults", "dict::test::test_case_correct", "config::test::test_update_from_nothing", "dict::test::test_dict_correct", "dict::test::test_dict_to_varco...
[]
[]
291
crate-ci/typos
254
crate-ci__typos-254
[ "253" ]
e6c595c5851a55a461710ec63cf27b5f7c57f475
diff --git a/crates/typos-vars/codegen/src/main.rs b/crates/typos-vars/codegen/src/main.rs --- a/crates/typos-vars/codegen/src/main.rs +++ b/crates/typos-vars/codegen/src/main.rs @@ -78,6 +78,7 @@ fn generate_variations<W: std::io::Write>(file: &mut W) { let mut smallest = usize::MAX; let mut largest = usiz...
diff --git a/src/dict.rs b/src/dict.rs --- a/src/dict.rs +++ b/src/dict.rs @@ -296,7 +311,7 @@ mod test { typos::tokens::Case::Lower, 0, )); - assert_eq!(correction, Some(Status::Valid)); + assert_eq!(correction, None); } #[cfg(feature = "vars")]
Speed up varcom support When there are no hits, its only about a 10% cost. When there are hits, it can go up to 50% For "code" ``` check_file/FoundFiles/code time: [23.589 us 23.753 us 23.933 us] thrpt: [12.114 MiB/s 12.205 MiB/s 12.290 MiB/s] check_file/Ident...
I wonder if there is cost in doing two different hashings and lookups. We might be able to speed this up by merging the two dictionaries.
2021-05-19T10:09:40
0.3
e6c595c5851a55a461710ec63cf27b5f7c57f475
[ "dict::test::test_varcon_same_locale" ]
[ "config::test::test_update_from_defaults", "config::test::test_extend_glob_updates", "config::test::test_extend_glob_extends", "config::test::test_update_from_nothing", "dict::test::test_case_correct", "file::test::test_extract_line_end", "file::test::test_extract_line_middle", "file::test::test_fix_b...
[]
[]
292
crate-ci/typos
543
crate-ci__typos-543
[ "542" ]
7d2ad4148d33c6af9f7516112f3ea57eb1bb50bc
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -306,8 +306,12 @@ mod parser { + nom::InputTake + nom::InputIter + nom::InputLength + + nom::Offset + + nom::Slice<std::o...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -1351,12 +1355,12 @@ mod test { fn tokenize_color() { let parser = TokenizerBuilder::new().build(); - let input = "#[derive(Clone)] #aaa # #111 #AABBCC #hello ...
Hex colors still being picked up I saw #462 , but it seems colors are still being picked up version: `typos-cli 1.11.11 ``` error: `BA` should be `BY`, `BE` --> /local/home/deguzim/src/DeGuzim-Config/tampermonkey-scripts/Labunk-documents/presentations/1.better-build-with-brazil-gradle/remarkjs.css:12:17 ...
Our CSS color parser looks like ```rust preceded( char('#'), alt(( take_while_m_n(3, 8, is_lower_hex_digit), take_while_m_n(3, 8, is_upper_hex_digit), )), )(input) ``` The problem is with `#1175BA`, `#1175` matches as a low...
2022-08-26T05:06:12
1.11
7d2ad4148d33c6af9f7516112f3ea57eb1bb50bc
[ "tokens::test::tokenize_color" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_ignore_base64_case_1", "tokens::test::tokenize_ignore_base64_case_2", "tokens::test::to...
[]
[]
293
crate-ci/typos
486
crate-ci__typos-486
[ "481" ]
8cd9cef88ac00b9a94d03ec367a8f1564ebff31b
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -142,6 +142,7 @@ mod parser { + nom::Slice<std::ops::RangeTo<usize>> + nom::Offset + Clone + + Default + PartialEq ...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -1132,12 +1151,6 @@ mod test { ("D41D8CD98F00B204E9800998ECF8427E", true), // A 31-character hexadecimal string: too short to be a hash. ("D41D...
`/`, `_`, `.`, etc before or after natively ignored item (guid, hash, etc) causes it to be spell checked In part of our code base we had a set of comments referencing text from a backtrace, with lines like this that triggers as typos with this tool: ``` error: `ba` should be `by`, `be` --> ./src/panic.rs:94:45 ...
Created tests for various combinations in #483. Specifically the issue is having an ignored token next to another ignored token (escape sequences). We don't gracefully handle that. A workaround is to change the paths to use `/` exclusively until this is fixed. Thanks! Will try the workaround also. Also had some...
2022-05-11T03:02:43
1.7
8cd9cef88ac00b9a94d03ec367a8f1564ebff31b
[ "tokens::test::tokenize_hash_in_mixed_path", "tokens::test::tokenize_ignore_base64_case_3" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_color", "tokens::test::tokenize_ignore_base64_case_2", "tokens::test::tokenize_ignore_e...
[]
[]
294
crate-ci/typos
463
crate-ci__typos-463
[ "462" ]
74cb409ce77e2c47e7b703b7bc68b1245ee72bc5
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -189,6 +189,7 @@ mod parser { terminated(base64_literal, sep1), terminated(email_literal, sep1), terminated(url_literal, sep1), + te...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -1248,6 +1275,23 @@ mod test { assert_eq!(expected, actual); } + #[test] + fn tokenize_color() { + let parser = TokenizerBuilder::new().build(); + + ...
[question] Ignore hex color value Hello, when I use it, I found that there are some scenes that do not need to be corrected. For example, when expressing colors in hexadecimal in a stylesheet file, e.g. `color: #ba431b` error: `ba` should be `by`, `be` --> ./index.less:3:9 | | color:#ba431b How shoul...
2022-04-18T22:20:19
1.6
74cb409ce77e2c47e7b703b7bc68b1245ee72bc5
[ "tokens::test::tokenize_color" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_ignore_base64_case_1", "tokens::test::tokenize_ignore_base64_case_2", "tokens::test::to...
[]
[]
295
crate-ci/typos
434
crate-ci__typos-434
[ "433" ]
05773fe8157dcfbbe8e4d537590ce0792083b691
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -422,13 +422,33 @@ mod parser { tuple((char(':'), char('/'), char('/'))), )), tuple(( - opt(terminated(take_while1(is_localp...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -1113,10 +1160,11 @@ mod test { fn tokenize_ignore_max_url() { let parser = TokenizerBuilder::new().build(); - let input = "Good http://user@example.com:3142/h...
Typo detected in URL ``` error: `ba` should be `by`, `be` --> content/team/index.md:32:400 | 32 | <a href="https://xxx.service-now.com/nav_to.do?uri=%2F$oc.do%3Fsysparm_include_view%3Ddaily,weekly,monthly%26sysparm_timezone%3DUS%2FCentral%26sysparm_timeline_enabled%3Dfalse%26sysparm_current_view%3Dmont...
I've copied that line into a file and ran typos v1.4.0 against it and ma not seeing any problems. What version of typos are you using? If you isolate it into a single file and run typos against it, do you see the message? Hi, Just updated to 1.4.0 (was on 1.3.3) and I still see the same error. I noticed the erro...
2022-02-14T22:50:40
1.4
05773fe8157dcfbbe8e4d537590ce0792083b691
[ "tokens::test::tokenize_ignore_max_url" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_ignore_base64_case_1", "tokens::test::tokenize_ignore_email", "tokens::test::tokenize_i...
[]
[]
296
crate-ci/typos
412
crate-ci__typos-412
[ "411" ]
4b2e66487c0d94e0f0ab1765a9e74bfed663aa1e
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -152,7 +152,7 @@ mod parser { fn identifier<T>(input: T) -> IResult<T, T> where - T: nom::InputTakeAtPosition, + T: nom::InputTakeAtPosition + std::fmt::Deb...
diff --git a/crates/typos/src/tokens.rs b/crates/typos/src/tokens.rs --- a/crates/typos/src/tokens.rs +++ b/crates/typos/src/tokens.rs @@ -1159,6 +1184,22 @@ mod test { assert_eq!(expected, actual); } + #[test] + fn tokenize_template() { + let parser = TokenizerBuilder::new().build(); + + ...
Missed typo that is in the list In https://github.com/matrix-org/matrix-doc/pull/3658#discussion_r792092382 the misspelt word ("defintions" instead of "definitions") was not caught, but it *is* already in `words.csv`. CC @aaronraimist who added the CI workflow.
Thanks for reporting this! It looks like our tokenizer has a bug where its incorrectly ending at templates. In this case, its ending at: ``` Some API endpoints may allow or require the use of `POST` requests without a transaction ID. Where this is optional, the use of a `PUT` request is strongly recommended. ...
2022-01-26T23:40:54
1.3
4b2e66487c0d94e0f0ab1765a9e74bfed663aa1e
[ "tokens::test::tokenize_template" ]
[ "tokens::test::split_ident", "tokens::test::tokenize_c_escape", "tokens::test::tokenize_dot_separated_words", "tokens::test::tokenize_empty_is_empty", "tokens::test::tokenize_double_escape", "tokens::test::tokenize_ignore_base64", "tokens::test::tokenize_ignore_escape", "tokens::test::tokenize_ignore_...
[]
[]
297
crate-ci/typos
776
crate-ci__typos-776
[ "733" ]
2158ddd42cda41bf7d69c14ffe8114eec91e3f2e
diff --git a/crates/typos-dict/assets/words.csv b/crates/typos-dict/assets/words.csv --- a/crates/typos-dict/assets/words.csv +++ b/crates/typos-dict/assets/words.csv @@ -359,6 +359,7 @@ accapt,accept accapted,accepted accapts,accepts acccept,accept +accceptable,acceptable acccepted,accepted acccepting,accepting ...
diff --git a/crates/typos-dict/assets/words.csv b/crates/typos-dict/assets/words.csv --- a/crates/typos-dict/assets/words.csv +++ b/crates/typos-dict/assets/words.csv @@ -33785,6 +33822,7 @@ latitute,latitude latnern,lantern latops,laptops latset,latest +latst,latest lattitude,latitude lauch,launch lauched,launch...
Non-critical corrections - June 2023 Edition Please list any corrections you noticed `typos` doesn't fix and we'll roll these up into a single PR, making it lighterweight for adding new corrections.
Probably safe to include: ``` acculumating -> accumulating anualized -> annualized assset -> asset avialible -> available baises -> biases cliped -> clipped curature -> curvature depdencencies -> dependencies eveything -> everything formuala -> formula hense -> hence pararm -> param segmnet -> segment te...
2023-07-03T22:18:57
1.64
d4258b1aa03ddeb54b2c52fc85348745b7bd060f
[ "codegen" ]
[ "test_varcon_removal", "test_merge_duplicates", "test_preserve_correction_order", "test_duplicate_correction_removal", "test_varcon_best_match", "test_cycle_removal", "verify" ]
[]
[]
298
wez/wezterm
4,764
wez__wezterm-4764
[ "4730", "4730" ]
4921f139d35590ab35415021221a2a6f5cf10ab3
diff --git a/vtparse/src/lib.rs b/vtparse/src/lib.rs --- a/vtparse/src/lib.rs +++ b/vtparse/src/lib.rs @@ -444,6 +444,7 @@ impl VTParser { for src in &self.params[0..self.num_params] { if let CsiParam::Integer(value) = src { res[i] = *value; + } else if let CsiParam::P(...
diff --git a/vtparse/src/lib.rs b/vtparse/src/lib.rs --- a/vtparse/src/lib.rs +++ b/vtparse/src/lib.rs @@ -1103,4 +1104,26 @@ mod test { ] ); } + + #[test] + fn test_ommitted_dcs_param() { + assert_eq!( + parse_as_vec("\x1bP;1q\x1b\\".as_bytes()), + vec![ + ...
Sixel parser ignores `P2` parameter if `P1` is blank ### What Operating System(s) are you seeing this problem on? Linux Wayland ### Which Wayland compositor or X11 Window manager(s) are you using? kwin ### WezTerm version 20231228-084719-ff274374 ### Did you try the latest nightly build to see if the ...
It appears that the sixel parameter parser ignores any leading parameter deliminators. I would not expect the following to render an image with a transparent background: ![image](https://github.com/wez/wezterm/assets/12154190/c1455489-791d-4957-97c2-3c49c080f225) It looks like omitted parameters get added at th...
2024-01-08T23:37:59
0.18
4921f139d35590ab35415021221a2a6f5cf10ab3
[ "test::test_ommitted_dcs_param" ]
[ "test::kitty_img", "test::osc_fedora_vte", "test::osc_utf8", "test::print_utf8", "test::sixel", "test::test_colon_rgb", "test::test_csi_intermediates", "test::test_csi_omitted_param", "test::test_csi_too_many_params", "test::test_decset", "test::test_fancy_underline", "test::test_mixed", "te...
[]
[]
299
ducaale/xh
257
ducaale__xh-257
[ "253" ]
13185bd736795ac099c9b0bf2cb36d9825089b65
diff --git a/src/decoder.rs b/src/decoder.rs --- a/src/decoder.rs +++ b/src/decoder.rs @@ -51,6 +51,7 @@ pub fn get_compression_type(headers: &HeaderMap) -> Option<CompressionType> { struct InnerReader<R: Read> { reader: R, + has_read_data: bool, has_errored: bool, } diff --git a/src/decoder.rs b/src...
diff --git a/tests/cli.rs b/tests/cli.rs --- a/tests/cli.rs +++ b/tests/cli.rs @@ -2869,3 +2869,28 @@ fn empty_response_with_content_encoding() { "#}); } + +#[test] +fn empty_response_with_content_encoding_and_content_length() { + let server = server::http(|_req| async move { + hyper::Response::bu...
HEAD fails on compressed response ``` $ xh head httpbin.org/gzip [...] xh: error: error decoding gzip response body: failed to fill whole buffer ``` This didn't happen before #241, so reqwest deals with it correctly. I don't know how.
This comment from https://github.com/seanmonstar/reqwest/pull/83 might be relevant >// libflate does a read_exact([0; 2]), so its impossible to tell // if the stream was empty, or truly had an UnexpectedEof. // Therefore, we need to peek a byte to make check for EOF first. It took me a while to understand, but I t...
2022-05-15T02:36:52
0.16
905ec1191bee0bfe530129a0f7188fb338507e55
[ "empty_response_with_content_encoding_and_content_length" ]
[ "cli::tests::parse_encoding_label", "auth::tests::parsing", "cli::tests::executable_name_extension", "cli::tests::multiple_methods", "cli::tests::explicit_method", "cli::tests::executable_name", "cli::tests::implicit_method", "cli::tests::proxy_all", "cli::tests::missing_url", "cli::tests::proxy_h...
[ "successful_digest_auth", "http2", "good_tls_version_nativetls", "http1_1", "native_tls_works", "cert_without_key", "improved_https_ip_error_with_support", "http1_0", "good_tls_version", "unsuccessful_digest_auth", "verify_default_yes", "verify_no", "verify_valid_file", "verify_explicit_ye...
[]
300
ducaale/xh
209
ducaale__xh-209
[ "189" ]
75232aac49c5f1b8019096f54b928337f395daf0
diff --git a/src/request_items.rs b/src/request_items.rs --- a/src/request_items.rs +++ b/src/request_items.rs @@ -12,6 +12,7 @@ use reqwest::{blocking::multipart, Method}; use structopt::clap; use crate::cli::BodyType; +use crate::utils::expand_tilde; pub const FORM_CONTENT_TYPE: &str = "application/x-www-form-...
diff --git a/tests/cli.rs b/tests/cli.rs --- a/tests/cli.rs +++ b/tests/cli.rs @@ -12,7 +12,7 @@ use std::time::Duration; use assert_cmd::cmd::Command; use indoc::indoc; use predicates::str::contains; -use tempfile::{tempdir, NamedTempFile}; +use tempfile::{tempdir, NamedTempFile, TempDir}; pub trait RequestExt {...
Expand tilde to home directory On Linux, the following works in HTPPie: `http -f POST example.com/files @~/.profile` But when attempting `xh -f POST example.com/files @~/.profile`, I get "xh: error: No such file or directory (os error 2)". It turns out the tilde is not being interpreted, and it works if I expa...
Good catch. It seems HTTPie also expands paths to sessions (but not session names). To match HTTPie (`os.path.expanduser`) we should ideally have a solution that also expands `~username/...`. We could try using the [home_dir](https://docs.rs/home-dir/0.1.0/home_dir/) crate or any of the crates listed [here](https://...
2021-12-04T04:20:38
0.14
ba956b68ee068d1057ab3f6c5eba6f4967d84cb3
[ "tilde_expanded_in_request_items" ]
[ "cli::tests::implicit_method", "cli::tests::parse_encoding_label", "cli::tests::negating_check_status", "auth::tests::parsing", "cli::tests::explicit_method", "cli::tests::missing_url", "cli::tests::proxy_all", "cli::tests::proxy_http", "cli::tests::executable_name_extension", "cli::tests::proxy_h...
[ "http2", "http1_0", "http1_1", "successful_digest_auth", "good_tls_version", "cert_without_key", "improved_https_ip_error_with_support", "native_tls_works", "good_tls_version_nativetls", "unsuccessful_digest_auth", "verify_explicit_yes", "verify_valid_file", "verify_default_yes", "verify_n...
[]
301
zellij-org/zellij
1,689
zellij-org__zellij-1689
[ "1687" ]
c71e16916f3395c60a53a7fbbcd5a2ede6f913f9
diff --git a/zellij-server/src/panes/terminal_pane.rs b/zellij-server/src/panes/terminal_pane.rs --- a/zellij-server/src/panes/terminal_pane.rs +++ b/zellij-server/src/panes/terminal_pane.rs @@ -189,18 +189,20 @@ impl Pane for TerminalPane { END_KEY => { return AnsiEncoding::End.as...
diff --git a/zellij-server/src/tab/unit/tab_integration_tests.rs b/zellij-server/src/tab/unit/tab_integration_tests.rs --- a/zellij-server/src/tab/unit/tab_integration_tests.rs +++ b/zellij-server/src/tab/unit/tab_integration_tests.rs @@ -2044,3 +2044,51 @@ fn pane_in_utf8_normal_event_tracking_mouse_mode() { ...
Ctrl-Shift-v not working for git SSH key passphrase `zellij --version`: zellij 0.31.3 `stty size`: 36 160 `uname -av`: Linux jupiter 5.18.17-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Aug 11 14:36:06 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux `gnome-terminal`: Version 3.44.1 for GNOME 42 `bash`: GNU bash, version 5....
could it be that the key is not getting copied into the clipboard? Thanks for the suggestion @tlinford. Just to clarify then, that when I say 'when I quit zellij (Ctrl+q) and retry' I don't copy anything new to the clipboard—I use what was already there and that should have been pasted into the passphrase prompt within...
2022-08-24T22:22:52
0.32
46dd8d4473fc338effced03c00358107b65f05e0
[ "tab::tab_integration_tests::pane_bracketed_paste_ignored_when_not_in_bracketed_paste_mode" ]
[ "logging_pipe::logging_pipe_test::write_with_endl_in_the_middle_consumes_buffer_up_to_endl_after_flush", "logging_pipe::logging_pipe_test::write_with_many_endl_consumes_whole_buffer_after_flush", "logging_pipe::logging_pipe_test::write_with_many_endls_consumes_everything_after_flush", "logging_pipe::logging_p...
[]
[]
304
zellij-org/zellij
1,776
zellij-org__zellij-1776
[ "1773" ]
46dd8d4473fc338effced03c00358107b65f05e0
diff --git a/zellij-server/src/panes/tiled_panes/mod.rs b/zellij-server/src/panes/tiled_panes/mod.rs --- a/zellij-server/src/panes/tiled_panes/mod.rs +++ b/zellij-server/src/panes/tiled_panes/mod.rs @@ -982,9 +982,7 @@ impl TiledPanes { // successfully filled space over pane let closed_pane = ...
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * debugging: Improve error format in server/thread_bus (https://github.com/zellij-org/zellij/pull/1775) * feat: command pane - send commands ...
Pane doesn't fill free space after closed split (without pane_frames) **Basic information** `zellij --version`: 716f606b `stty size`: 47 191 `uname -av` or `ver`(Windows): Linux archlinux 5.19.12-arch1-1 `alacritty --version`: 0.10.1 **To reproduce:** `pane_frames: false` Open zellij Create new pane (e.g....
2022-10-05T21:11:35
0.32
46dd8d4473fc338effced03c00358107b65f05e0
[ "tab::tab_tests::correctly_resize_frameless_panes_on_pane_close" ]
[ "logging_pipe::logging_pipe_test::write_with_incorrect_byte_boundary_does_not_crash", "logging_pipe::logging_pipe_test::write_with_endl_in_the_middle_consumes_buffer_up_to_endl_after_flush", "logging_pipe::logging_pipe_test::write_with_many_endl_consumes_whole_buffer_after_flush", "logging_pipe::logging_pipe_...
[]
[]
305
zellij-org/zellij
1,749
zellij-org__zellij-1749
[ "1734" ]
480086e3d456cb4984c70f50f7290fc06ad5b60a
diff --git a/zellij-server/src/tab/mod.rs b/zellij-server/src/tab/mod.rs --- a/zellij-server/src/tab/mod.rs +++ b/zellij-server/src/tab/mod.rs @@ -1032,7 +1032,9 @@ impl Tab { let active_terminal = self .floating_panes .get(&pane_id) - .unwra...
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * debugging: Improve error handling in screen thread (https://github.com/zellij-org/zellij/pull/1670) * fix: Server exits when client panics ...
Crash in tab module **Basic information** `zellij --version`: 0.31.3 `stty size`: 50 196 `uname -av`: Linux fresh 5.15.0-46-generic # 49-Ubuntu SMP Thu Aug 4 18:03:25 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux alacritty 0.11.0-dev (ebc6922e) helix 22.08.1 (66276ce6) nushell: 0.68.1 ### Error ``` Error oc...
Thanks for reporting this issue! That clearly shouldn't have happened. Unfortunately the log you posted on its own doesn't help narrowing the problem down a lot (which is our fault, not yours). The error indicates that zellij couldn't find a terminal pane which it assumed to exist. Is this a reproducible issue? F...
2022-09-22T22:28:33
0.32
46dd8d4473fc338effced03c00358107b65f05e0
[ "tab::tab_tests::write_to_suppressed_pane" ]
[ "logging_pipe::logging_pipe_test::write_with_incorrect_byte_boundary_does_not_crash", "logging_pipe::logging_pipe_test::write_with_endl_in_the_middle_consumes_buffer_up_to_endl_after_flush", "logging_pipe::logging_pipe_test::write_with_many_endls_consumes_everything_after_flush", "logging_pipe::logging_pipe_t...
[]
[]
306
google/zerocopy
1,713
google__zerocopy-1713
[ "1708" ]
22303070be0dfe902bccdc33ae06b064ddf51fdb
diff --git a/src/util/macro_util.rs b/src/util/macro_util.rs --- a/src/util/macro_util.rs +++ b/src/util/macro_util.rs @@ -285,6 +285,32 @@ mod size_to_tag { #[doc(hidden)] pub type SizeToTag<const SIZE: usize> = <() as size_to_tag::SizeToTag<SIZE>>::Tag; +// We put `Sized` in its own module so it can have the same...
diff --git a/zerocopy-derive/tests/ui-msrv/struct.stderr b/zerocopy-derive/tests/ui-msrv/struct.stderr --- a/zerocopy-derive/tests/ui-msrv/struct.stderr +++ b/zerocopy-derive/tests/ui-msrv/struct.stderr @@ -1,37 +1,37 @@ error: cannot derive Unaligned with repr(align(N > 1)) - --> tests/ui-msrv/struct.rs:128:11 + ...
Improve ergonomics of `IntoBytes` on unsized types This source code: ```rust #[derive(IntoBytes)] #[repr(C)] struct IntoBytes4 { a: u8, b: [u8], } ``` ...results in this error: ```text error[E0277]: the size for values of type `[u8]` cannot be known at compilation time --> tests/ui-nightly/...
2024-09-21T07:29:27
1.56
8481e15774d86a6e1589456300531b598da77e97
[ "ui" ]
[ "tests::test_config_repr_no_overlap", "tests::test_config_repr_orderings", "output_tests::test_into_bytes", "output_tests::test_immutable", "output_tests::test_unaligned", "output_tests::test_from_bytes", "output_tests::test_try_from_bytes", "output_tests::test_from_zeros", "output_tests::test_known...
[]
[]
307
getzola/zola
2,547
getzola__zola-2547
[ "2538", "2563" ]
041da029eedbca30c195bc9cd8c1acf89b4f60c0
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,16 @@ # Changelog +## 0.19.2 (2024-08-15) + +- Fix some of YAML date parsing +- Fix feed generation for languages not working in some cases (it was taking the value from the root of the config for +feed_filenames) +- Ignore `.b...
diff --git a/components/config/src/config/mod.rs b/components/config/src/config/mod.rs --- a/components/config/src/config/mod.rs +++ b/components/config/src/config/mod.rs @@ -992,4 +1002,68 @@ feed_filename = "test.xml" Config::parse(config).unwrap(); } + + #[test] + fn parse_generate_sitemap_true...
Zola 0.19.0 doesn't accept all valid YAML dates # Bug Report With 0.19.0, Zola can now understand more date formats. However, I believe there is a bug in the implementation which makes the millisecond separator (but not the milliseconds) required ## Environment Zola version: 0.19.0 ## Expected Behavior `20...
Can you submit the change as a PR with some additional tests?
2024-06-25T05:05:26
0.19
bc00064731f8a0924d748e64c6ee75473de053ef
[ "fs_utils::tests::can_recognize_temp_files", "fs_utils::tests::test_get_relative_event_kind" ]
[ "file_info::tests::can_find_components_in_page_with_assets", "file_info::tests::can_find_valid_language_in_page", "file_info::tests::can_find_content_components", "file_info::tests::can_find_valid_language_in_section", "file_info::tests::can_find_valid_language_with_default_locale", "file_info::tests::can...
[]
[]
308
getzola/zola
2,535
getzola__zola-2535
[ "2537" ]
98843438c2f644c6cb9c3a00935abffb4c423bf8
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## 0.19.1 (2024-06-24) + +- Fix `config.generate_feeds` being still serialized as `config.generate_feed`. Both are available for now +- Fix `zola serve` not reacting to changes on some OSes + ## 0.19.0 (2024...
diff --git a/src/cmd/serve.rs b/src/cmd/serve.rs --- a/src/cmd/serve.rs +++ b/src/cmd/serve.rs @@ -921,6 +921,7 @@ mod tests { } #[test] + #[cfg(not(windows))] fn test_create_new_site_without_protocol_with_port_without_mounted_path() { let interface = IpAddr::from_str("127.0.0.1").unwrap();...
Zola 0.19 config.generate_feeds not accessible from template files. # Bug Report I believe this is related to https://github.com/getzola/zola/pull/2477 ## Environment Zola version: 0.19 ## Expected Behavior config.generate_feeds accessible via templates ## Current Behavior config.generate_feeds is not ...
2024-06-21T17:01:59
0.19
bc00064731f8a0924d748e64c6ee75473de053ef
[ "fs_utils::tests::test_get_relative_event_kind" ]
[ "cmd::init::tests::init_empty_directory", "cmd::serve::tests::test_construct_url_no_protocol", "cmd::init::tests::init_quasi_empty_directory", "cmd::serve::tests::test_construct_url_no_port_append", "cmd::serve::tests::test_construct_url_https_protocol", "cmd::serve::tests::test_construct_url_http_protoco...
[]
[]
309
sigoden/aichat
830
sigoden__aichat-830
[ "828" ]
d57f11445da31eb1183c34d78a93f8b601c2333e
diff --git a/src/config/mod.rs b/src/config/mod.rs --- a/src/config/mod.rs +++ b/src/config/mod.rs @@ -796,6 +796,9 @@ impl Config { }, None => bail!("No role"), }; + if role_name.contains('#') { + bail!("Unable to save role with arguments") + } if ro...
diff --git a/src/config/role.rs b/src/config/role.rs --- a/src/config/role.rs +++ b/src/config/role.rs @@ -407,11 +407,11 @@ mod tests { #[test] fn test_merge_prompt_name() { assert_eq!( - complete_prompt_args("convert __ARG1__", "convert:foo"), + complete_prompt_args("convert _...
`:` in `roles/convert:json:toml.md` is invalid file identifier On Windows and the finder app on macOS, `:` is not a valid name. Suggestion: use valid identifiers that can be used on both macOS and windows, for example `{}`
2024-09-04T06:14:13
0.21
d57f11445da31eb1183c34d78a93f8b601c2333e
[ "config::role::tests::test_merge_prompt_name", "config::role::tests::test_match_name" ]
[ "config::role::tests::test_parse_structure_prompt1", "config::role::tests::test_parse_structure_prompt2", "config::role::tests::test_parse_structure_prompt3", "rag::bm25::tests::test_tokenize", "client::stream::tests::test_json_stream_array", "client::stream::tests::test_json_stream_ndjson", "rag::split...
[]
[]
310
tikv/raft-rs
58
tikv__raft-rs-58
[ "57" ]
1beea8c3df2e44f6fa17b8f21ad57bf5a6e8b620
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -13,7 +13,7 @@ categories = ["algorithms", "database-implementations"] [dependencies] log = "0.4.1" -protobuf = "1.2" +protobuf = "~1.5" quick-error = "1.2.1" rand = "0.4" fxhash = "0.2.1" diff --git a/src/raft.rs b/src/raft.rs --- a/src/r...
diff --git a/tests/cases/test_raft.rs b/tests/cases/test_raft.rs --- a/tests/cases/test_raft.rs +++ b/tests/cases/test_raft.rs @@ -3784,21 +3784,6 @@ fn test_learner_promotion() { assert_eq!(network.peers[&2].state, StateRole::Leader); } -// TestLearnerCannotVote checks that a learner can't vote even it receive...
Learner should respond to request vote but don't accept votes Consider following case, a cluster has three nodes A, B, C, and A is Leader. And then add learner D, E to the cluster. D, E is promoted to voter then, but D is isolated from A, so D doesn't know himself is promoted. When A, B both crash, the cluster still ha...
PTAL @xiang90 @Hoverbear
2018-05-09T08:12:10Z
0.1
1beea8c3df2e44f6fa17b8f21ad57bf5a6e8b620
[ "cases::test_raft::test_learner_respond_vote" ]
[ "errors::tests::test_error_equal", "log_unstable::test::test_maybe_first_index", "log_unstable::test::test_maybe_last_index", "log_unstable::test::test_maybe_term", "errors::tests::test_storage_error_equal", "log_unstable::test::test_restore", "log_unstable::test::test_stable_to", "log_unstable::test:...
[]
[]
311
nical/lyon
503
nical__lyon-503
[ "501" ]
94f4ad731ffae32474ae4362c5f74507a86b564e
diff --git a/path/src/path.rs b/path/src/path.rs --- a/path/src/path.rs +++ b/path/src/path.rs @@ -140,10 +140,7 @@ impl Path { /// Reversed version of this path with edge loops are specified in the opposite /// order. pub fn reversed(&self) -> Self { - let mut builder = Path::builder(); - ...
diff --git a/path/src/path.rs b/path/src/path.rs --- a/path/src/path.rs +++ b/path/src/path.rs @@ -1041,49 +1059,60 @@ fn n_stored_points(verb: Verb, attrib_stride: usize) -> usize { #[test] fn test_reverse_path() { - let mut builder = Path::builder(); - builder.move_to(point(0.0, 0.0)); - builder.line_to(...
Path::reversed should preserve custom attributes Currently the custom attributes aren't in the output path.
2019-12-25T11:52:19Z
0.14
94f4ad731ffae32474ae4362c5f74507a86b564e
[ "path::test_reverse_path" ]
[ "commands::simple_path", "commands::next_event", "iterator::test_from_polyline_open", "path::test_merge_paths", "iterator::test_from_polyline_closed", "path::test_path_builder_empty", "path::test_path_builder_1", "path::test_reverse_empty_path", "path::test_reverse_path_no_close", "path::test_path...
[]
[]
312
nical/lyon
570
nical__lyon-570
[ "562" ]
525037751f50afd145131feded64156e79dfaaa9
diff --git a/tessellation/src/event_queue.rs b/tessellation/src/event_queue.rs --- a/tessellation/src/event_queue.rs +++ b/tessellation/src/event_queue.rs @@ -184,7 +184,7 @@ impl EventQueue { after: TessEventId, ) -> TessEventId { debug_assert!(self.sorted); - debug_assert!(is_after(data....
diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/src/fill_tests.rs +++ b/tessellation/src/fill_tests.rs @@ -135,7 +135,7 @@ fn test_path_with_rotations(path: Path, step: f32, expected_triangle_count: Opti let mut angle = Angle::radians(0.0); while angle.radians...
FillTessellator with non-zero fill rule panics with 'assertion failed: self.fill.spans.is_empty()' Hello, First of all, really sorry that the bug reproduction is not as minimal as it could be (see attached `Path`). I can spend some more time on this later, if it helps. Version: `0.15.6` The panic is a `debug_a...
Thanks for filing this, I'll have a look shortly. @yanchith I made a testcase from the one you provided, unfortunately it doesn't reproduce, which probably means the defaut formatting parameters arent printing enough decimals to represent the problematic case. could you copy-pase this code somehwere where you know t...
2020-04-23T21:45:52Z
0.15
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "earcut_tests::self_touching", "fill_tests::issue_562_1", "fill_tests::issue_562_5", "earcut_tests::eberly_6", "fill_tests::issue_562_6", "fill_tests::issue_481_reduced", "fill_tests::issue_481_original", "fill_tests::issue_562_7", "fuzz_tests::fuzzing_test_case_16", "fuzz_tests::fuzzing_test_case...
[ "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::empty_square", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::issue_16", "earcut_tests::hole_touching_outer", "earcut_tests::issue_17", "earcut_tests::issu...
[]
[]
313
nical/lyon
530
nical__lyon-530
[ "529" ]
122ee5f0077fcf363745cb6ab1c4641545029efc
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -432,7 +432,7 @@ name = "geom_bench" version = "0.0.1" dependencies = [ "bencher 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)", - "lyon 0.15.3", + "lyon 0.15.5", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Ca...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -882,7 +882,7 @@ dependencies = [ name = "lyon_wasm_test" version = "0.11.0" dependencies = [ - "lyon 0.15.3", + "lyon 0.15.5", ] [[package]] diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/s...
Fill tessellation failure in 0.15.3 I'm tesselating a svg file that I simply pass from usvg to lyon fill tesselator. The svg file can be found at [0], I used `CNTR_RG_03M_2016_4326.svg` which used to work with 0.14, (but `CNTR_RG_01M_2016_4326.svg` did not). The error is simply `Internal(IncorrectActiveEdgeOrder(3)...
Thanks for the report, unless the input data contains broken floats like NaNs or inifinity, and has fewer than u32::MAX vertices, it should definitely be considered as a bug in the tessellator which is the case here. I was able to reproduce this and reduce it to a small testcase. I'll look into it soon.
2020-01-12T20:48:35Z
0.15
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill_tests::issue_529" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::bad_hole", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::dude", "earcut_tests::eberly_3", "earcut_tests::empty_square", "earcut_tests::hole_touching_outer", "earcut_tests::issue_16", "earcut_tests::iss...
[]
[]
314
nical/lyon
579
nical__lyon-579
[ "545" ]
4429c2aad3f900fd33a8a64e62e8e9da97ffaf1e
diff --git a/tessellation/src/stroke.rs b/tessellation/src/stroke.rs --- a/tessellation/src/stroke.rs +++ b/tessellation/src/stroke.rs @@ -7,7 +7,7 @@ use crate::path::builder::{Build, PathBuilder}; use crate::path::private::DebugValidator; use crate::path::{AttributeStore, EndpointId, IdEvent, PathEvent, PathSlice, ...
diff --git a/tessellation/src/stroke.rs b/tessellation/src/stroke.rs --- a/tessellation/src/stroke.rs +++ b/tessellation/src/stroke.rs @@ -1665,12 +1711,14 @@ fn test_too_many_vertices() { } impl GeometryBuilder for Builder { fn begin_geometry(&mut self) {} - fn add_triangle(&mut self, _a: Ver...
The stroke tessellator does not propagate errors I cannot replicate this, but you might be interested in a panic that i found ``` thread 'main' panicked at 'assertion failed: b != c', tessellation/src/geometry_builder.rs:510:9 ```
I certainly am! Was it the stroke or fill tessellator? Pretty sure it was the stroke tesselator. It may be useful to know that there were only bezier curves imitating lines (i.e. the control points were identical to the corners) in the builder. There may however have been duplicate points in it. Some more info. I think...
2020-04-27T22:00:28Z
0.15
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "stroke::test_too_many_vertices" ]
[ "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::empty_square", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::issue_17", "earcut_tests::issue_16", "earcut_tests::hole_touching_outer", "earcut_tests::issu...
[]
[]
315
nical/lyon
520
nical__lyon-520
[ "517" ]
4651f1b20b508aeb3cd79e0d9252803e7325afa8
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -432,7 +432,7 @@ name = "geom_bench" version = "0.0.1" dependencies = [ "bencher 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)", - "lyon 0.15.1", + "lyon 0.15.3", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Ca...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -882,7 +882,7 @@ dependencies = [ name = "lyon_wasm_test" version = "0.11.0" dependencies = [ - "lyon 0.15.1", + "lyon 0.15.3", ] [[package]] diff --git a/tessellation/src/fill.rs b/tessellation/src/fill.rs --- a/tessellation/src/fill.rs +...
The vertex source iterator can visit the same endpoint twice in some cases. For start events for example, it can happen for the endpoint to be visited once for each of its edges.
2019-12-28T12:17:48Z
0.15
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill::fill_vertex_source_03" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::bad_hole", "earcut_tests::eberly_3", "earcut_tests::dude", "earcut_tests::empty_square", "earcut_tests::hole_touching_outer", "earcut_tests::issue_16", "earcut_tests::iss...
[]
[]
316
nical/lyon
519
nical__lyon-519
[ "518" ]
17b0ce8c74a2bb917de85f99428886ca8445ac3b
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -787,7 +787,7 @@ dependencies = [ "lyon_extra 0.15.0", "lyon_svg 0.15.0", "lyon_tess2 0.15.0", - "lyon_tessellation 0.15.1", + "lyon_tessellation 0.15.2", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.l...
diff --git a/tessellation/src/fill_tests.rs b/tessellation/src/fill_tests.rs --- a/tessellation/src/fill_tests.rs +++ b/tessellation/src/fill_tests.rs @@ -2055,6 +2055,70 @@ fn issue_500() { ).unwrap(); } +#[test] +fn issue_518_1() { + let mut builder = Path::builder(); + builder.move_to(point(-76.95, -46...
Path hits `is_after(to, self.current_position)` assert The following path hit an assert in the fill tessellator in both debug and release: ``` let mut builder = Path::builder(); builder.move_to(Point::new(-76.95f32, -461.8f32)); builder.quadratic_bezier_to( Point::new(-75.95f32, -462.6f32), ...
The above example will work successfully if I omit the last `line_to` and let it close via `close`, but here's another example where omitting it has no effect: ``` let mut builder = Path::builder(); builder.move_to(Point::new(-69.1f32, -465.5f32)); builder.line_to(Point::new(-69.1f32, -461.65f32)); ...
2019-12-27T22:28:12Z
0.15
08cd4c3d8c1ef53fbbb1b702f655e26c6bd5cc03
[ "fill_tests::issue_518_2", "fill_tests::issue_518_1" ]
[ "basic_shapes::issue_366", "earcut_tests::bad_diagonal", "earcut_tests::bad_hole", "earcut_tests::eberly_3", "earcut_tests::empty_square", "earcut_tests::dude", "earcut_tests::building", "earcut_tests::degenerate", "earcut_tests::issue_16", "earcut_tests::issue_17", "earcut_tests::hole_touching_...
[]
[]
317
metalbear-co/mirrord
2,165
metalbear-co__mirrord-2165
[ "2164" ]
2f78dd8e7c5746e0c4b6edcb9fbf59c1bc9f0067
diff --git /dev/null b/changelog.d/2164.internal.md new file mode 100644 --- /dev/null +++ b/changelog.d/2164.internal.md @@ -0,0 +1,1 @@ +Moved the docs from `CopyTargetFileConfig` to `CopyTargetConfig` so that medschool reads them. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b...
diff --git a/mirrord/config/src/feature/copy_target.rs b/mirrord/config/src/feature/copy_target.rs --- a/mirrord/config/src/feature/copy_target.rs +++ b/mirrord/config/src/feature/copy_target.rs @@ -10,40 +10,12 @@ use serde::Deserialize; use crate::config::{ConfigContext, FromMirrordConfig, MirrordConfig, Result}; ...
Fix copy_target config docs The docs from the code do not appear in the generated docs.
2024-01-10T10:40:35Z
3.82
2f78dd8e7c5746e0c4b6edcb9fbf59c1bc9f0067
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
323
metalbear-co/mirrord
2,273
metalbear-co__mirrord-2273
[ "2272" ]
879fd097bd5949bf694f8f6610900139323e1f33
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2698,8 +2698,7 @@ dependencies = [ [[package]] name = "iptables" version = "0.5.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d39f0d72d0feb83c9b7f4e1fbde2b4a629886f30841127b3f86383831dba2629" +source = "git...
diff --git a/mirrord/config/src/agent.rs b/mirrord/config/src/agent.rs --- a/mirrord/config/src/agent.rs +++ b/mirrord/config/src/agent.rs @@ -253,6 +253,15 @@ pub struct AgentConfig { #[config(default = false)] pub privileged: bool, + /// ### agent.nftables {#agent-nftables} + /// + /// Use iptabl...
Support for Istio Mesh + nft When users use Istio Mesh + nftables (not iptables legacy) our rules run before mesh, leading to undefined behavior. We probably should have a flag - iptables_mode which can be either legacy or nft then we use the appropriate and all should work the same (in theory). Need to manually test...
2024-02-26T15:50:26Z
3.89
879fd097bd5949bf694f8f6610900139323e1f33
[ "tests::schema_file_is_up_to_date", "api::container::job::test::targetless", "api::container::job::test::targeted" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
324
metalbear-co/mirrord
2,668
metalbear-co__mirrord-2668
[ "2641" ]
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
diff --git /dev/null b/changelog.d/2641.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/2641.fixed.md @@ -0,0 +1,1 @@ +Specify that `mirrord container` is an unstable feature. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -527,7 +527,7 @@ ...
diff --git a/mirrord/config/configuration.md b/mirrord/config/configuration.md --- a/mirrord/config/configuration.md +++ b/mirrord/config/configuration.md @@ -384,7 +384,7 @@ IP:PORT to connect to instead of using k8s api, for testing purposes. ## container {#root-container} -`mirrord container` command specific c...
Mark `mirrord container ...` as unstable 1. Mark `mirrord container ...` subcommand as unstable. 2. Maybe push this info to CLI progress as well? 3. ~~Add new session type field to analytics reports. Should allow for differentiating regular runs from container runs~~ done in #2643
2024-08-15T15:12:18Z
3.113
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_2__Some___30____Some_30__::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info_...
[]
[]
327
metalbear-co/mirrord
2,665
metalbear-co__mirrord-2665
[ "2662" ]
bf3c0297895b85d87993ff54b62806e90b59f318
diff --git /dev/null b/changelog.d/2662.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/2662.fixed.md @@ -0,0 +1,1 @@ +Fix IncomingConfig json schema regression. diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -1137,37 +1137,19 @@ "Incomin...
diff --git a/mirrord/config/src/feature/network/incoming.rs b/mirrord/config/src/feature/network/incoming.rs --- a/mirrord/config/src/feature/network/incoming.rs +++ b/mirrord/config/src/feature/network/incoming.rs @@ -67,6 +67,7 @@ use http_filter::*; /// ``` #[derive(Clone, Debug, JsonSchema)] #[cfg_attr(test, der...
schema issue on "incoming" (and probably others) <img width="570" alt="image" src="https://github.com/user-attachments/assets/b2232ec4-66e2-4670-85a2-c7d1b97c00f9"> I assume it's part of the refactor that @DmitryDodzin did
I need to take a closer look but I think it should be contained to incoming because of how schemars parses serde macro and I added manual parsing logic to it
2024-08-15T09:24:18Z
3.113
7a2dd1b8b246dfc700a38b8ddb7ba244babf1272
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
328
metalbear-co/mirrord
1,527
metalbear-co__mirrord-1527
[ "1479" ]
53c9db608c12f50fe5de647f7acfbc822d425d4c
diff --git /dev/null b/changelog.d/1479.fixed.md new file mode 100644 --- /dev/null +++ b/changelog.d/1479.fixed.md @@ -0,0 +1,1 @@ +Add new rule to the OUTPUT chain of iptables in agent to support kubectl port-forward diff --git a/mirrord/agent/src/main.rs b/mirrord/agent/src/main.rs --- a/mirrord/agent/src/main.rs ++...
diff --git a/mirrord/agent/src/steal/ip_tables.rs b/mirrord/agent/src/steal/ip_tables.rs --- a/mirrord/agent/src/steal/ip_tables.rs +++ b/mirrord/agent/src/steal/ip_tables.rs @@ -38,6 +40,16 @@ pub static IPTABLE_MESH: LazyLock<String> = LazyLock::new(|| { }) }); +pub static IPTABLE_STANDARD_ENV: &str = "MIRROR...
request through `kubectl port forward` doesn't get stolen When stealing pod requests, if one uses `kubectl port forward deploy/deploymentname 8080` those requests still get answered by the remote.
managed to reproduce it ill run wireshark/tcpdump in the pod to see where the forwarded traffic is actually going with steal on and sending request to the nodeport: ``` 15:38:32.077374 IP 192-168-65-4.kubernetes.default.svc.cluster.local.60460 > py-serv-deployment-ff89b5974-dhl2q.http: Flags [S], seq 439708412, win 6...
2023-06-09T03:29:59Z
3.47
dfab96e405bf4b195117700926bc15352d57f069
[ "steal::ip_tables::tests::default" ]
[ "env::tests::default", "env::tests::default_exclude", "env::tests::include", "util::indexallocator_tests::check_max", "steal::ip_tables::redirect::tests::add_redirect_twice", "steal::ip_tables::redirect::tests::add_redirect", "util::indexallocator_tests::sanity", "steal::ip_tables::redirect::tests::re...
[]
[ "tests::sanity" ]
329
metalbear-co/mirrord
1,623
metalbear-co__mirrord-1623
[ "744" ]
e9dd388116c77eba1cee287db2ba27a0d63487d7
diff --git /dev/null b/changelog.d/+remove-capture-error-trace.removed.md new file mode 100644 --- /dev/null +++ b/changelog.d/+remove-capture-error-trace.removed.md @@ -0,0 +1,1 @@ +Removed error capture error trace feature \ No newline at end of file diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirror...
diff --git a/mirrord-schema.json b/mirrord-schema.json --- a/mirrord-schema.json +++ b/mirrord-schema.json @@ -1,7 +1,7 @@ { "$schema": "http://json-schema.org/draft-07/schema#", "title": "LayerFileConfig", - "description": "mirrord allows for a high degree of customization when it comes to which features you w...
Capture log clashes with install script ### Bug Description The capture log feature creates a folder called /tmp/mirrord. The install.sh tries to create a file called /tmp/mirrord, and if the folder exists it crashes. Need to add a GUID to the filename. ### Steps to Reproduce Run mirrord with capture log, then run t...
2023-07-06T06:58:19Z
3.49
e9dd388116c77eba1cee287db2ba27a0d63487d7
[ "tests::schema_file_is_up_to_date" ]
[ "agent::tests::default::log_level_1__None___info___::namespace_1__None_None_::image_1__None_None_::image_pull_policy_1__None___IfNotPresent___::ttl_1__None_1_::ephemeral_1__None_false_::communication_timeout_1__None_None_::startup_timeout_1__None_60_", "agent::tests::default::log_level_1__None___info___::namespac...
[]
[]
330
roc-lang/roc
6,786
roc-lang__roc-6786
[ "6778" ]
db94b555ab1946ad6bfdb5314a11ba67d9b1d1da
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -576,6 +576,8 @@ pub fn unwrap_suffixed_expression_when_help<'a>( Err(..) => return Err(EUnwrapped::Malformed), ...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -865,6 +865,21 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-55], space_befor...
An internal compiler expectation was broken Code ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br" } import pf.Stdout import pf.Task import pf.Http main = request = { method: Get, headers:...
``` roc nightly pre-release, built from commit 33075285b72 on Wed May 22 09:12:12 UTC 2024 ``` Mac Silicon Thanks for the bug report! @Anton-4 please assign it to me
2024-06-03T21:04:43Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::deep_when" ]
[ "suffixed_tests::apply_argument_multiple", "suffixed_tests::apply_argument_single", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::defs_suffixed_middle", "suffixed_tests::apply_function_suffixed", "suffixed_tests::closure_with_defs", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::s...
[]
[]
332
roc-lang/roc
6,785
roc-lang__roc-6785
[ "6784" ]
674b9348215118a7c977d0685979d850d3a5f649
diff --git a/crates/compiler/can/src/expr.rs b/crates/compiler/can/src/expr.rs --- a/crates/compiler/can/src/expr.rs +++ b/crates/compiler/can/src/expr.rs @@ -1127,7 +1127,7 @@ pub fn canonicalize_expr<'a>( output, ) } - ast::Expr::TaskAwaitBang(..) => internal_error!("a Ex...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -853,6 +853,18 @@ mod suffixed_tests { r##"Defs { tags: [Index(2147483648)], regions: [@0-52], space_befo...
Expect statements breaks with "a Expr::TaskAwaitBang expression was not completed removed in desugar_value_def_suffixed" I'm just doing what the error told me and reporting the issue :smile: I added `expect 1 == 2` to the first line of the my main function and got the following error when running `roc dev` ```sh...
Thank you for logging this bug. @kdziamura Found the root cause. Please assign it to me
2024-06-03T15:07:40Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::expect_then_bang" ]
[ "suffixed_tests::dbg_simple", "suffixed_tests::closure_simple", "suffixed_tests::apply_argument_multiple", "suffixed_tests::multiple_def_first_suffixed", "suffixed_tests::multiple_suffix", "suffixed_tests::last_suffixed_multiple", "suffixed_tests::multi_defs_stmts", "suffixed_tests::nested_complex", ...
[]
[]
333
roc-lang/roc
6,712
roc-lang__roc-6712
[ "6672" ]
8818b37fa256ed7508f024761af595c7722e45fe
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -122,11 +122,52 @@ pub fn unwrap_suffixed_expression<'a>( Expr::SpaceBefore(..) | Expr::SpaceAfter(..) => { internal...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -775,6 +775,35 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-226], space_befo...
`!` and `dbg` statements interfere with each other Needs further investigation. When using multiple `dbg` and `!` statements in a def, they can interfere with each other.
2024-05-04T19:40:33Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_simple" ]
[ "suffixed_tests::body_parens_apply", "suffixed_tests::basic", "suffixed_tests::closure_simple", "suffixed_tests::if_simple", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::multiple_def_first_suffixed", "suffixed_tests::nested_complex", "suffixed_tests::defs_suffixed_middle", "suffixed_t...
[]
[]
334
roc-lang/roc
6,525
roc-lang__roc-6525
[ "6512" ]
05823cd1a03ac3ce0d39706dfd77b7a7b8a8c908
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -2196,6 +2196,7 @@ version = "0.0.1" dependencies = [ "bumpalo", "indoc", + "regex", "roc_build", "roc_cli", "roc_repl_cli", diff --git a/crates/cli/src/main.rs b/crates/cli/src/main.rs --- a/crates/cli/src/main.rs +++ b/crates/cli/src...
diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs --- a/crates/cli/src/lib.rs +++ b/crates/cli/src/lib.rs @@ -440,6 +440,7 @@ pub fn test(matches: &ArgMatches, triple: Triple) -> io::Result<i32> { use roc_build::program::report_problems_monomorphized; use roc_load::{ExecutionMode, FunctionKind, LoadC...
Improve repl contrast on (very) dark terminal background ![PXL_20240207_110908757.MP.jpg](https://github.com/roc-lang/roc/assets/17049058/91545af3-b1bd-44e8-b777-f738e6d52443) In real life the contrast is worse than in the photo. The blue text is unreadable and the pink colon's visibility is not good enough.
I would like to take a look at this. It looks like we can use brighter colors out of 256 colors if terminal supports them (otherwise fallbacks to ansi colors). Oh so we can't simply check environment variables as `STYLE_CODES` is a global variable. Let's change colors in the variable into something brighter from 256 co...
2024-02-14T17:05:12Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::report_value_color" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_non_signature_expression", "test_reporting::ability_specialization_is_unused", "test_reporting::apply_unary_negat...
[]
[]
335
roc-lang/roc
6,506
roc-lang__roc-6506
[ "6418" ]
b22f7939677de4e4e66dfc3b72afbbb7e16f1702
diff --git a/crates/compiler/load_internal/src/file.rs b/crates/compiler/load_internal/src/file.rs --- a/crates/compiler/load_internal/src/file.rs +++ b/crates/compiler/load_internal/src/file.rs @@ -3838,6 +3838,35 @@ struct HeaderOutput<'a> { opt_platform_shorthand: Option<&'a str>, } +fn ensure_roc_file<'a>(f...
diff --git a/crates/compiler/load_internal/tests/test_load.rs b/crates/compiler/load_internal/tests/test_load.rs --- a/crates/compiler/load_internal/tests/test_load.rs +++ b/crates/compiler/load_internal/tests/test_load.rs @@ -323,7 +323,7 @@ fn import_transitive_alias() { // with variables in the importee le...
Roc should error for non-roc files [zulip discussion](https://roc.zulipchat.com/#narrow/stream/304641-ideas/topic/Handle.20non.20roc.20files/near/417371854) ## Current Behaviour Currently `roc run` on an exectutable non-`.roc` file gives the following error. ``` $ roc run examples/movies.csv ── MISSING HEADER...
2024-02-05T19:44:01Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "non_roc_file_extension", "roc_file_no_extension" ]
[ "file_not_found - should panic", "ingested_file_not_found - should panic", "module_doesnt_match_file_path", "imported_file_not_found - should panic", "platform_parse_error", "test_load_and_typecheck", "app_quicksort", "imported_dep_regression", "load_principal_types", "import_alias", "ingested_f...
[]
[]
336
roc-lang/roc
5,287
roc-lang__roc-5287
[ "5264" ]
26846e14aa0a06baa8cd4017abfc60c15ff359df
diff --git a/crates/compiler/constrain/src/expr.rs b/crates/compiler/constrain/src/expr.rs --- a/crates/compiler/constrain/src/expr.rs +++ b/crates/compiler/constrain/src/expr.rs @@ -1782,7 +1782,7 @@ fn constrain_function_def( let signature_index = constraints.push_type(types, signature); - ...
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -2615,6 +2615,27 @@ mod test_reporting { I would have to crash if I saw one of those! So rather than pattern matchin...
roc build panics with Invalid InsertValueInst operands when importing an interface This is similar to my previous issue #5212 that was fixed, but I find I only get this error when I import LinkedList from another file. Putting all the definitions in a single file compiles and run successfully. Using MacOS 13.1 with Int...
ROC_CHECK_MONO_IR fails here, this is a layout bug.
2023-04-12T20:36:24Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::function_arity_mismatch_too_few", "test_reporting::function_arity_mismatch_too_many", "test_reporting::function_arity_mismatch_nested_too_few", "test_reporting::function_arity_mismatch_nested_too_many", "test_reporting::patterns_fn_not_exhaustive" ]
[ "test_reporting::ability_demand_value_has_args", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_non_signature_expression", "test_reporting::ability_member_does_not_bind_ability", "test_reporting::alias_using_a...
[]
[]
337
roc-lang/roc
5,284
roc-lang__roc-5284
[ "5131" ]
191d8a74086267b102bb2a388dbd37f5b814b6e8
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -5084,8 +5084,12 @@ dependencies = [ "pretty_assertions", "regex", "roc_builtins", + "roc_collections", "roc_derive", "roc_load", + "roc_module", + "roc_mono", + "roc_packaging", "roc_parse", "roc_problem", "roc_reporting", diff -...
diff --git a/crates/compiler/solve/tests/solve_expr.rs b/crates/compiler/solve/tests/solve_expr.rs --- a/crates/compiler/solve/tests/solve_expr.rs +++ b/crates/compiler/solve/tests/solve_expr.rs @@ -31,7 +31,7 @@ mod solve_expr { .. }, src, - ) = run_load_and_infer(src,...
Record update with `&` fails on imported record This is similar to https://github.com/roc-lang/roc/issues/3908 which has been resolved, I think the issue may be caused by the fact that `defaultRequest` is imported. ``` app "temptest" packages { pf: "cli-platform/main.roc" } imports [pf.Stdout, pf.Http.{de...
This issue was originally reported [here](https://github.com/roc-lang/basic-cli/issues/23).
2023-04-12T16:41:00Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "tests/lambda_set/disjoint_nested_lambdas_result_in_disjoint_parents_issue_4712.txt " ]
[ "solve_expr::annotated_using_i16", "solve_expr::annotation_f64", "solve_expr::annotated_f32", "solve_expr::annotated_using_i64", "solve_expr::ability_constrained_in_non_member_infer", "solve_expr::annotated_using_u8", "solve_expr::annotated_using_u16", "solve_expr::annotated_using_u64", "solve_expr:...
[]
[ "tests/specialize/record_update_between_modules.txt " ]
338
roc-lang/roc
5,280
roc-lang__roc-5280
[ "5094" ]
191d8a74086267b102bb2a388dbd37f5b814b6e8
diff --git a/crates/reporting/src/error/type.rs b/crates/reporting/src/error/type.rs --- a/crates/reporting/src/error/type.rs +++ b/crates/reporting/src/error/type.rs @@ -1138,8 +1138,8 @@ fn to_expr_report<'b>( ), } } - Reason::FnCall { name, arity } => mat...
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -13381,4 +13381,33 @@ I recommend using camelCase. It's the standard style in Roc code! "# ) ); + +...
Confusing error message when forgetting to unwrap function from opaque type The following code tries to apply a function wrapped in an opaque type without unwrapping it first: ``` interface Package exposes [] imports [] Parser a := Str -> a parser : Parser Str parser = @Parser \s -> Str.concat s "a...
2023-04-12T15:06:58Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::apply_opaque_as_function" ]
[ "test_reporting::ability_demand_value_has_args", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_non_signature_expression", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::backpassing_type_error", "test_reporting::ability_value_annotations_a...
[]
[]
339
roc-lang/roc
5,188
roc-lang__roc-5188
[ "5177" ]
41d7ade5a363f3c6d1512409b328404501e14940
diff --git a/crates/compiler/solve/src/solve.rs b/crates/compiler/solve/src/solve.rs --- a/crates/compiler/solve/src/solve.rs +++ b/crates/compiler/solve/src/solve.rs @@ -1847,6 +1847,11 @@ fn open_tag_union(subs: &mut Subs, var: Variable) { stack.extend(subs.get_subs_slice(fields.variables())); ...
diff --git a/crates/reporting/tests/test_reporting.rs b/crates/reporting/tests/test_reporting.rs --- a/crates/reporting/tests/test_reporting.rs +++ b/crates/reporting/tests/test_reporting.rs @@ -13170,4 +13170,17 @@ I recommend using camelCase. It's the standard style in Roc code! I would have to crash if I saw on...
Wildcard in when expression does not open tag unions inside tuples ``` interface B exposes [] imports [] expect x : [A, B, C] when (x, 1u8) is (A, _) -> Bool.true (B, _) -> Bool.true _ -> Bool.true ``` should not error but it does ``` ── TYPE MISMATCH ───────────────────────────────────...
2023-03-24T19:13:24Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::openness_constraint_opens_under_tuple" ]
[ "test_reporting::ability_specialization_is_unused", "test_reporting::ability_specialization_is_duplicated_with_type_mismatch", "test_reporting::anonymous_function_does_not_use_param", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_non_signature_expression", "test_repor...
[]
[]
340
roc-lang/roc
5,179
roc-lang__roc-5179
[ "5143" ]
bf41570648d99822a2f6591615c507038d3a26cc
diff --git a/crates/compiler/builtins/roc/Decode.roc b/crates/compiler/builtins/roc/Decode.roc --- a/crates/compiler/builtins/roc/Decode.roc +++ b/crates/compiler/builtins/roc/Decode.roc @@ -23,6 +23,7 @@ interface Decode string, list, record, + tuple, custom, decodeW...
diff --git a/crates/compiler/derive/src/util.rs b/crates/compiler/derive/src/util.rs --- a/crates/compiler/derive/src/util.rs +++ b/crates/compiler/derive/src/util.rs @@ -18,19 +18,20 @@ pub(crate) struct Env<'a> { } impl Env<'_> { - pub fn new_symbol(&mut self, name_hint: &str) -> Symbol { + pub fn new_symbo...
Tuples don't implement `Eq` even if all of their elements do The following code errors, however each of the elements implement the `Eq` abiliity. ```elixir interface Blah exposes [] imports [] expect (0.0, 2, "x") == (0.0, 2, "x") ``` ``` % roc test Blah.roc ── TYPE MISMATCH ─────────────────────...
Yes, they should - just like records! This is a bug.
2023-03-22T21:57:07Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "decoding::different_tuple_arities", "decoding::same_tuple", "decoding::same_tuple_fields_diff_types", "encoding::different_tuple_arities", "encoding::same_tuple_fields_diff_types", "encoding::same_tuple", "hash::different_tuple_arities", "hash::same_tuple", "hash::same_tuple_fields_diff_types", "...
[ "decoding::derivable_record_ext_flex_able_var", "decoding::derivable_record_ext_flex_var", "decoding::derivable_record_with_record_ext", "decoding::different_record_fields", "decoding::optional_record_field_derive_error", "decoding::same_record_fields_any_order", "decoding::explicit_empty_record_and_imp...
[]
[]
341
roc-lang/roc
6,926
roc-lang__roc-6926
[ "6896" ]
e10448e92caf53e136cf1ab8257cfb5bf0e11ec6
diff --git a/crates/compiler/can/src/def.rs b/crates/compiler/can/src/def.rs --- a/crates/compiler/can/src/def.rs +++ b/crates/compiler/can/src/def.rs @@ -2969,7 +2969,7 @@ fn to_pending_value_def<'a>( AnnotatedBody { ann_pattern, ann_type, - comment: _, + lines_...
diff --git a/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap b/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap --- a/crates/compiler/can/tests/snapshots/test_suffixed__suffixed_tests__basic.snap +++ b/crates/compiler/can/tests/snapshots/test_suffixed__suffixed...
Formatter deletes comments between annotation and body Roc formatter deletes comments that are between annotation and body Repro: `Bug.roc` ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", } import pf.T...
2024-07-27T21:32:48Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_fmt::preserve_annotated_body_blank_comment", "test_fmt::preserve_annotated_body_comments", "test_fmt::preserve_annotated_body_comments_without_newlines" ]
[ "test_fmt::basic_string", "test_fmt::basic_block_string", "test_fmt::apply_lambda", "test_fmt::backpassing_body_on_newline", "test_fmt::accessor", "test_fmt::binary_op_with_spaces", "test_fmt::backpassing_simple", "test_fmt::ability_member_doc_comments", "test_fmt::binary_op", "test_fmt::closure_m...
[ "test_fmt::test_fmt_examples" ]
[]
343
roc-lang/roc
6,851
roc-lang__roc-6851
[ "6656" ]
05ab0183805907c3042e9f946a08b793ea75c038
diff --git a/crates/compiler/can/src/desugar.rs b/crates/compiler/can/src/desugar.rs --- a/crates/compiler/can/src/desugar.rs +++ b/crates/compiler/can/src/desugar.rs @@ -755,28 +755,6 @@ pub fn desugar_expr<'a>( }) } - // Replace an empty final def with a `Task.ok {}` - EmptyDefsF...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -1,3 +1,6 @@ +#[macro_use] +extern crate indoc; + #[cfg(test)] mod suffixed_tests { diff --git a/crates/compiler/c...
Investigate `Task.await` behaviour in rocci-bird Investigate why the two below are not equal. The only change is the line `collided <- collidedTask |> Task.await` to `Task.await collidedTask \collided ->` ```roc List.walk collisionPoints (Task.ok Bool.false) \collidedTask, { x, y } -> collided <- co...
Update - as a workaround in bocci-bird I've pull the closure out into a helper and that has resolved the issue. But this still seems like an interesting edge case. I ran into what I think is this same issue, and came up with a simpler reproduction: ```roc app [main] { cli: platform "https://github.com/roc-lang...
2024-06-28T23:40:47Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_stmt_arg", "suffixed_tests::deep_when", "suffixed_tests::closure_with_annotations", "suffixed_tests::last_stmt_not_top_level_suffixed", "suffixed_tests::if_simple", "suffixed_tests::expect_then_bang", "suffixed_tests::deps_final_expr", "suffixed_tests::multiple_def_first_suffixed"...
[ "suffixed_tests::apply_argument_single", "suffixed_tests::basic", "suffixed_tests::apply_argument_multiple", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::apply_function_suffixed", "suffixed_tests::body_parens_apply", "suffixed_tests::closure_simple",...
[]
[]
344
roc-lang/roc
6,847
roc-lang__roc-6847
[ "6838" ]
44d76d78a13e6b6b4adea075a93b3b46989704f2
diff --git a/crates/compiler/can/src/suffixed.rs b/crates/compiler/can/src/suffixed.rs --- a/crates/compiler/can/src/suffixed.rs +++ b/crates/compiler/can/src/suffixed.rs @@ -129,46 +129,7 @@ pub fn unwrap_suffixed_expression<'a>( internal_error!("BinOps should have been desugared in desugar_expr"); ...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -900,6 +900,19 @@ mod suffixed_tests { r#"Defs { tags: [Index(2147483648)], regions: [@0-266], space_befo...
Crashed with Malformed Suffix ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", } import pf.Stdout import pf.Task import pf.Utc Option a : [Some a, None] main = start = Utc.toMillisSinceEpoch Utc.n...
Thanks for reporting this @fwgreen! In case it may help, this is a workaround: ```roc dbg List.len results end = Utc.toMillisSinceEpoch Utc.now! dbg end - start ``` Minimal reproduction for future debugging: ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/v...
2024-06-28T11:09:13Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::dbg_stmt_arg" ]
[ "suffixed_tests::apply_argument_suffixed", "suffixed_tests::apply_function_suffixed", "suffixed_tests::apply_argument_single", "suffixed_tests::basic", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_multiple", "suffixed_tests::closure_simple", "suffixed_tests::defs_suffixed_middl...
[]
[]
345
roc-lang/roc
6,837
roc-lang__roc-6837
[ "6800" ]
1b10772bcbbdb91f6b1b67d986c392caae7732b9
diff --git a/crates/compiler/parse/src/ast.rs b/crates/compiler/parse/src/ast.rs --- a/crates/compiler/parse/src/ast.rs +++ b/crates/compiler/parse/src/ast.rs @@ -575,8 +575,7 @@ pub fn is_expr_suffixed(expr: &Expr) -> bool { Expr::Closure(_, sub_loc_expr) => is_expr_suffixed(&sub_loc_expr.value), /...
diff --git a/crates/compiler/can/tests/test_suffixed.rs b/crates/compiler/can/tests/test_suffixed.rs --- a/crates/compiler/can/tests/test_suffixed.rs +++ b/crates/compiler/can/tests/test_suffixed.rs @@ -610,7 +610,7 @@ mod suffixed_tests { else line "fail" "#, - ...
Compiler panic from `Expr::TaskAwaitBang` desugaring ...or something like that. I built Roc from source with Nix at db94b555ab1946ad6bfdb5314a11ba67d9b1d1da. ```roc app [main] { pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.10.0/vNe6s9hWzoTZtFmNkvEICPErI9ptji_ySjicO6CkucY.tar.br", ...
@Anton-4 please assign to me Done, thanks for helping out @kdziamura :heart:
2024-06-25T12:57:37Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "suffixed_tests::deps_final_expr", "suffixed_tests::if_simple", "suffixed_tests::trailing_binops" ]
[ "suffixed_tests::basic", "suffixed_tests::bang_in_pipe_root", "suffixed_tests::apply_argument_multiple", "suffixed_tests::apply_argument_single", "suffixed_tests::body_parens_apply", "suffixed_tests::closure_simple", "suffixed_tests::apply_argument_suffixed", "suffixed_tests::dbg_simple", "suffixed_...
[]
[]
346
roc-lang/roc
6,057
roc-lang__roc-6057
[ "6056" ]
31b62e929c879a9c8b2b775642545a707a09bd0d
diff --git a/crates/reporting/src/error/canonicalize.rs b/crates/reporting/src/error/canonicalize.rs --- a/crates/reporting/src/error/canonicalize.rs +++ b/crates/reporting/src/error/canonicalize.rs @@ -1177,7 +1177,7 @@ fn to_bad_ident_expr_report<'b>( let region = LineColumnRegion::from_pos(lines.convert...
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -4269,7 +4269,7 @@ mod test_reporting { @r###" ── SYNTAX PROBLEM ───────────────────────────────...
Error message: SYNTAX PROBLEM trying to parse record error typo There is a typo in the error message when a record name is expected but not found, example: ```shell $ roc repl The rockin' roc repl ──────────────────────── Enter an expression, or :help, or :q to quit. » y. ── SYNTAX PROBLEM ────────────...
2023-11-21T22:38:50Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::record_access_ends_with_dot", "test_reporting::stray_dot_expr" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::argument_without_space", "test_reporting::annotation_newline_body_is_fine", "test_reporting::ability_shadows_ability", "test_reporting::ability_not_on_toplevel", "test_reporting::alias_using_alias", "test_reporting::ability_spe...
[]
[]
347
roc-lang/roc
6,054
roc-lang__roc-6054
[ "5939" ]
31b62e929c879a9c8b2b775642545a707a09bd0d
diff --git a/crates/compiler/parse/src/expr.rs b/crates/compiler/parse/src/expr.rs --- a/crates/compiler/parse/src/expr.rs +++ b/crates/compiler/parse/src/expr.rs @@ -549,6 +549,9 @@ pub fn parse_single_def<'a>( let spaces_before_current_start = state.pos(); let state = match space0_e(EExpr::IndentStart).pa...
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -4563,7 +4563,7 @@ mod test_reporting { comment_with_control_character, "# comment with a \x...
Parser bug with unicode characters in comment The code sample below will give a `MISSING FINAL EXPRESSION` error which is not correct. This is a bug in the parser which is caused by the presence of unicode characters in a comment somehow. ``` % roc test Broken.roc ── MISSING FINAL EXPRESSION ─────────────────────...
2023-11-21T21:16:43Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::comment_with_control_character" ]
[ "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_non_signature_expression", "test_reporting::applied_tag_function", "test_reporting::argument_without_space", "t...
[]
[]
348
roc-lang/roc
5,994
roc-lang__roc-5994
[ "1668" ]
a3e9f06241f397a907c8a2c81f0ad2800fcaedc5
diff --git a/crates/compiler/constrain/src/expr.rs b/crates/compiler/constrain/src/expr.rs --- a/crates/compiler/constrain/src/expr.rs +++ b/crates/compiler/constrain/src/expr.rs @@ -502,6 +502,7 @@ pub fn constrain_expr( let reason = Reason::FnArg { name: opt_symbol, ...
diff --git a/crates/compiler/load/tests/test_reporting.rs b/crates/compiler/load/tests/test_reporting.rs --- a/crates/compiler/load/tests/test_reporting.rs +++ b/crates/compiler/load/tests/test_reporting.rs @@ -2447,7 +2447,7 @@ mod test_reporting { @r###" ── TYPE MISMATCH ────────────────────────────────...
Mismatch involving == reported as "isEq" ``` ── TYPE MISMATCH ─────────────────────────────────────────────────────────────── The 2nd argument to isEq is not what I expect: 416│ if kristy.rightHand == Ok (Jan (@JanId (@EntityId entityId))) then ...
We now have the infrastructure in place to make this a relatively straightforward change! If you are interested and want some guidance, lmk smaller repro: ``` » A == A "" ── TYPE MISMATCH ─────────────────────────────────────────────────────────────── This 2nd argument to isEq has an unexpected type: 4│ ...
2023-11-16T16:06:08Z
0.0
e819c954d393eb3223dd5961556d07ce21b29831
[ "test_reporting::boolean_tag", "test_reporting::int_frac", "test_reporting::int_literals_cannot_fit_in_same_type", "test_reporting::integer_out_of_range", "test_reporting::num_literals_cannot_fit_in_same_type", "test_reporting::num_too_general_wildcard", "test_reporting::num_too_general_named", "test_...
[ "test_reporting::ability_non_signature_expression", "test_reporting::ability_demand_value_has_args", "test_reporting::ability_first_demand_not_indented_enough", "test_reporting::ability_demands_not_indented_with_first", "test_reporting::ability_member_binds_parent_twice", "test_reporting::argument_without...
[]
[]
349
maplibre/martin
1,355
maplibre__martin-1355
[ "1315" ]
73909f2e201824d730aa088e7e96820f6e951f0b
diff --git a/martin/src/srv/tiles.rs b/martin/src/srv/tiles.rs --- a/martin/src/srv/tiles.rs +++ b/martin/src/srv/tiles.rs @@ -1,5 +1,6 @@ +use actix_http::header::Quality; use actix_http::ContentEncoding; -use actix_web::error::{ErrorBadRequest, ErrorNotFound}; +use actix_web::error::{ErrorBadRequest, ErrorNotAccepta...
diff --git a/martin/src/srv/tiles.rs b/martin/src/srv/tiles.rs --- a/martin/src/srv/tiles.rs +++ b/martin/src/srv/tiles.rs @@ -270,6 +302,11 @@ mod tests { use super::*; use crate::srv::server::tests::TestSource; + #[actix_rt::test] + async fn test_deleteme() { + test_enc_preference(&["gzip", "...
very slow queries through martin Hi there, i am trying to find out why martin is so much slower then a direct query to the db. this: http://localhost:3000/query_tile/10/544/339 takes >13s to get the tile from the server via martin. the martin log looks like this: ``` [2024-04-24T07:43:12Z DEBUG marti...
Hi @pcace Have you run the `select query_tile(10,544,339)` (without explain) directly? How many seconds it takes? Hi @sharkAndshark, I am in a similar situation. In my case running the query directly (without _EXPLAIN ANALYZE_) from postgres takes **~400ms**: ` select tiles(14,8176,6234)` <img width="413" al...
2024-05-29T00:24:10Z
0.2
09535cf917708d2d8e60099c516f6ff45f9efdd8
[ "srv::tiles::tests::test_deleteme", "srv::tiles::tests::test_enc_preference::case_3", "srv::tiles::tests::test_enc_preference::case_4", "srv::tiles::tests::test_enc_preference::case_1", "mbt_get_raster", "mbt_get_raw_mvt", "mbt_get_tilejson", "mbt_get_mvt_gzip", "mbt_get_tilejson_gzip", "mbt_get_m...
[ "args::pg::tests::test_extract_conn_strings", "args::pg::tests::test_merge_into_config", "args::pg::tests::test_extract_conn_strings_from_env", "args::pg::tests::test_merge_into_config2", "args::pg::tests::test_merge_into_config3", "args::root::tests::cli_bad_parsed_arguments", "args::root::tests::cli_n...
[ "function_source_schemas", "function_source_tilejson", "function_source_tile", "pg_get_composite_source_tile_minmax_zoom_ok", "pg_get_function_source_tile_ok", "pg_get_function_source_tile_minmax_zoom_ok", "pg_get_function_source_ok", "pg_get_function_source_query_params_ok", "pg_get_function_source...
[]
350
skim-rs/skim
198
skim-rs__skim-198
[ "194" ]
2391bc915b556c7dd4230dc1e61585220d2d2075
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -2,6 +2,7 @@ use std::borrow::Cow; use std::default::Default; use std::mem; + use tuikit::prelude::*; use vte::Perform; diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -69,60 +70,88 @@ impl Perform for ANS...
diff --git a/src/ansi.rs b/src/ansi.rs --- a/src/ansi.rs +++ b/src/ansi.rs @@ -301,4 +330,20 @@ mod tests { assert_eq!("ab", ansistring.into_inner()) } + + #[test] + fn test_multiple_attributes() { + let input = "\x1B[1;31mhi"; + let ansistring = ANSIParser::default().parse_ansi(inpu...
Color not working with `ag` When using silver searcher, coloring of file path and line numbers aren't working. Used the following command: ``` $ sk --ansi -i -c 'ag --color "{}"' ```
Confirmed. Will fix when I got time.
2019-07-14T00:11:14Z
0.6
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "ansi::tests::test_multiple_attributes" ]
[ "ansi::tests::test_normal_string", "ansi::tests::test_ansi_iterator", "field::test::test_parse_field_range", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields", "field::test::test_get_string_by_field", "query::test::test_add_char", "query::test::test_backward_delete_...
[]
[]
351
skim-rs/skim
264
skim-rs__skim-264
[ "226" ]
1f723d31d965824fb50aea12a346bdceb032db7b
diff --git a/src/engine.rs b/src/engine.rs --- a/src/engine.rs +++ b/src/engine.rs @@ -10,15 +10,6 @@ lazy_static! { static ref RE_OR: Regex = Regex::new(r" +\| +").unwrap(); } -#[derive(Clone, Copy, Debug)] -enum Algorithm { - PrefixExact, - SuffixExact, - Exact, - InverseExact, - InverseSuffixE...
diff --git a/src/engine.rs b/src/engine.rs --- a/src/engine.rs +++ b/src/engine.rs @@ -453,22 +520,47 @@ mod test { #[test] fn test_engine_factory() { - let x1 = EngineFactory::build( + let x = EngineFactory::build("'abc", MatcherMode::Fuzzy, FuzzyAlgorithm::default()); + assert_eq!(x.d...
Exact exact match When matching a short string, the exact match can get lost in results. For example, I use `skim` to select packages to install on Arch. If the name is extremely short (`lf`), the wanted result gets lost beneath results which contain the searched string. `^` nor `$` were able to narrow the search to w...
2020-02-03T12:33:27Z
0.7
29239ba9276d5bd39bc84740374d66c1fe180981
[ "engine::test::test_engine_factory" ]
[ "ansi::tests::test_multiple_attributes", "ansi::tests::test_ansi_iterator", "ansi::tests::test_normal_string", "ansi::tests::test_reset", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "query::test::test_add_char", "field::t...
[]
[]
353
skim-rs/skim
199
skim-rs__skim-199
[ "196" ]
65aad287f5a2e96fd1bdec63a8cd4bf301112d2e
diff --git a/src/input.rs b/src/input.rs --- a/src/input.rs +++ b/src/input.rs @@ -82,7 +82,9 @@ impl Input { // key_action is comma separated: 'ctrl-j:accept,ctrl-k:kill-line' pub fn parse_keymap(&mut self, key_action: &str) { + debug!("got key_action: {:?}", key_action); for (key, action_c...
diff --git a/src/input.rs b/src/input.rs --- a/src/input.rs +++ b/src/input.rs @@ -224,6 +236,14 @@ mod test { ("ctrl-y", vec![("execute-silent", Some("echo {} | pbcopy".to_string()))]), key_action[1] ); + + // #196 + let key_action_str = "enter:execute($EDITOR +{2} {1})...
Passing an explicit + to execute() I'm trying to pass line number and filename to vim with: `sk --ansi -i -c 'rg --color=always --line-number "{}"' --preview 'preview.sh {}' -d':' --bind 'enter:execute($EDITOR +{2} {1})'` but the `+` gets swallowed by the skim parser instead of getting passed the command.
I tried escaping with `\` with no success
2019-07-14T00:59:12Z
0.6
11c80768e0664878fc6fada1a31e7c9d0dfa8590
[ "input::test::execute_should_be_parsed_correctly" ]
[ "ansi::tests::test_ansi_iterator", "ansi::tests::test_multiple_attributes", "ansi::tests::test_normal_string", "field::test::test_parse_field_range", "field::test::test_get_string_by_field", "field::test::test_parse_matching_fields", "field::test::test_parse_transform_fields", "query::test::test_add_c...
[]
[]
358
quadratichq/quadratic
1,939
quadratichq__quadratic-1939
[ "1916" ]
42b8ef23ee00ffdfdd01ce774e96033fea90c2f1
diff --git a/quadratic-core/src/formulas/functions/lookup.rs b/quadratic-core/src/formulas/functions/lookup.rs --- a/quadratic-core/src/formulas/functions/lookup.rs +++ b/quadratic-core/src/formulas/functions/lookup.rs @@ -461,21 +461,24 @@ fn lookup<V: ToString + AsRef<CellValue>>( LookupMatchMode::Exact => s...
diff --git a/quadratic-core/src/formulas/functions/lookup.rs b/quadratic-core/src/formulas/functions/lookup.rs --- a/quadratic-core/src/formulas/functions/lookup.rs +++ b/quadratic-core/src/formulas/functions/lookup.rs @@ -1297,6 +1300,15 @@ mod tests { ); assert_eq!("1", eval_to_string(&g, &make_matc...
Match formula not working Not sure cause, but replicating in other sheets returns results correctly. See sheet in Slack for recreation.
2024-10-01T20:58:11Z
0.5
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "formulas::functions::lookup::tests::test_match" ]
[ "color::tests::new", "color::tests::test_from_str", "color::tests::test_size", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_add_html_cell", "controller::active_transactions::p...
[]
[]
359
quadratichq/quadratic
1,923
quadratichq__quadratic-1923
[ "1924" ]
13b8f4201b41e1566bba1ec0e13c7c90d3da757a
diff --git a/quadratic-client/src/dashboard/components/DashboardSidebar.tsx b/quadratic-client/src/dashboard/components/DashboardSidebar.tsx --- a/quadratic-client/src/dashboard/components/DashboardSidebar.tsx +++ b/quadratic-client/src/dashboard/components/DashboardSidebar.tsx @@ -1,4 +1,3 @@ -import { colors } from '...
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -319,8 +319,7 @@ mod tests { #[test] #[parallel] fn test_parse_date() { - let date = "12/23/2024".to_string(); - let parsed_date = pa...
Spill error auto fix Being worked on in #1725
2024-09-26T16:10:30Z
0.5
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "date_time::tests::test_parse_date_time" ]
[ "color::tests::new", "color::tests::test_size", "color::tests::test_from_str", "controller::active_transactions::pending_transaction::tests::is_user", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::test_add_code_cell", "controller::active_transactions::p...
[]
[]
360
quadratichq/quadratic
1,883
quadratichq__quadratic-1883
[ "1881" ]
8dc49a8a4dd2108ba11291b68e1abb24d9fe42a7
diff --git a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts b/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts --- a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.ts +++ b/quadratic-client/src/app/web-...
diff --git a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts b/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts --- a/quadratic-client/src/app/web-workers/renderWebWorker/worker/cellsLabel/convertNumber.test.ts +++ b/quadratic-clie...
bug: decimal precision with percentages 1. Add =1/3 in a cell 2. Format as a percent truncate to fewer decimals so it fits ![CleanShot 2024-09-18 at 10 50 54@2x](https://github.com/user-attachments/assets/1830aa59-5929-4786-88eb-e880919dcd01)
2024-09-18T21:06:45Z
0.5
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "grid::sheet::test::test_current_decimal_places_value" ]
[ "color::tests::test_size", "color::tests::test_from_str", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_to_transaction", "controller::active_transactions::unsaved_transactions::t...
[]
[]
361
quadratichq/quadratic
2,012
quadratichq__quadratic-2012
[ "2011" ]
ccca1fa5b9c65bceecffdcae588c3f6afce3cb76
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -225,7 +225,7 @@ pub fn parse_date(value: &str) -> Option<NaiveDate> { "%d.%m.%Y", "%Y %m %d", "%m %d %Y", - "%d %m %Y", + ...
diff --git a/quadratic-core/src/date_time.rs b/quadratic-core/src/date_time.rs --- a/quadratic-core/src/date_time.rs +++ b/quadratic-core/src/date_time.rs @@ -319,8 +319,7 @@ mod tests { #[test] #[parallel] fn test_parse_date() { - let date = "12/23/2024".to_string(); - let parsed_date = pa...
Quadratic parses the dates in this CSV incorrectly [StnData.csv](https://github.com/user-attachments/files/17594099/StnData.csv) Quadratic ![CleanShot 2024-10-31 at 17 01 48@2x](https://github.com/user-attachments/assets/cfe11333-12c0-4b3d-8d82-ebda8b90fd61) Numbers Mac ![CleanShot 2024-10-31 at 17 02 30@2x](ht...
2024-11-01T11:57:03Z
0.5
ba07e0c13859c2f461ee2d528c59e58773df4f6c
[ "date_time::tests::test_parse_date_time" ]
[ "color::tests::new", "color::tests::test_size", "color::tests::test_from_str", "color::tests::test_from_css_str", "controller::active_transactions::pending_transaction::tests::is_user", "controller::active_transactions::pending_transaction::tests::test_add_code_cell", "controller::active_transactions::p...
[]
[]
362
tauri-apps/tauri
11,477
tauri-apps__tauri-11477
[ "11252" ]
058c0db72f43fbe1574d0db654560e693755cd7e
diff --git /dev/null b/.changes/use_https_windows-and-android-config.md new file mode 100644 --- /dev/null +++ b/.changes/use_https_windows-and-android-config.md @@ -0,0 +1,6 @@ +--- +"tauri": "minor:feat" +"tauri-utils": "minor:feat" +--- + +Add `app > windows > useHttpsScheme` config option to choose whether the cust...
diff --git a/crates/tauri-cli/src/migrate/migrations/v1/config.rs b/crates/tauri-cli/src/migrate/migrations/v1/config.rs --- a/crates/tauri-cli/src/migrate/migrations/v1/config.rs +++ b/crates/tauri-cli/src/migrate/migrations/v1/config.rs @@ -802,7 +824,8 @@ mod test { "pattern": { "use": "brownfield" }, ...
[bug] [v2] IndexedDB path changed after upgrading to tauri 2 ### Describe the bug After upgrading from tauri 1 to tauri 2, the IndexedDB directory changed from `https_tauri.localhost_0.indexeddb.leveldb` to `http_tauri.localhost_0.indexeddb.leveldb`. Since my app stores all data in IndexedDB, this will cause "data ...
2024-10-24T08:00:11Z
1.77
17bcec8abe827c8a9eaa9bebf01bf5da87e92ed2
[ "migrate::migrations::v1::config::test::migrate_dangerous_use_http_scheme", "migrate::migrations::v1::config::test::migrate_full" ]
[ "interface::rust::tests::parse_cargo_option", "interface::rust::tests::parse_profile_from_opts", "interface::rust::manifest::tests::inject_features_string", "interface::rust::manifest::tests::inject_features_table", "interface::rust::manifest::tests::inject_features_inline_table", "migrate::migrations::v1...
[]
[]
364
elkowar/eww
1,044
elkowar__eww-1044
[ "1039" ]
7bfd47eb8130f02f2a8f695c255df2f5302636b4
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ All notable changes to eww will be listed here, starting at changes since versio ### Fixes - The `shell-completions` subcommand is now run before anything is set up - Fix nix flake +- Fix `jq` (By: w-lfchen) ## [0.5.0] ...
diff --git a/crates/simplexpr/src/eval.rs b/crates/simplexpr/src/eval.rs --- a/crates/simplexpr/src/eval.rs +++ b/crates/simplexpr/src/eval.rs @@ -544,5 +545,6 @@ mod tests { lazy_evaluation_and(r#"false && "null".test"#) => Ok(DynVal::from(false)), lazy_evaluation_or(r#"true || "null".test"#) => Ok(D...
[BUG] jq broken in 5.0.0 ### Checklist before submitting an issue - [X] I have searched through the existing [closed and open issues](https://github.com/elkowar/eww/issues?q=is%3Aissue) for eww and made sure this is not a duplicate - [X] I have specifically verified that this bug is not a common [user error](https://g...
For an easy bisect it would be nice to know which version/commit you were previously on, would you mind adding that? Yeah, sorry about the bad bug report. I'm not sure exactly which version I was on before upgrading since it was built from git, but it was 0.4.0 something. I've now tested various revisions, and 4...
2024-03-02T22:40:51Z
0.1
8661abf2bf07f5a809fc995233d93810cc1ac871
[ "eval::tests::jq_basic_index" ]
[ "eval::tests::string_to_string", "eval::tests::lazy_evaluation_or", "eval::tests::lazy_evaluation_elvis", "eval::tests::safe_access_index_to_non_indexable", "eval::tests::safe_access_index_to_missing", "eval::tests::lazy_evaluation_and", "eval::tests::normal_access_to_existing", "eval::tests::safe_acc...
[]
[]
365
elkowar/eww
1,176
elkowar__eww-1176
[ "1209" ]
8801fa36a057b0c1d2d57585673496f0bc4240d2
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to eww will be listed here, starting at changes since versio ## Unreleased +### BREAKING CHANGES +- [#1176](https://github.com/elkowar/eww/pull/1176) changed safe access (`?.`) behavior: + Attemptin...
diff --git a/crates/simplexpr/src/eval.rs b/crates/simplexpr/src/eval.rs --- a/crates/simplexpr/src/eval.rs +++ b/crates/simplexpr/src/eval.rs @@ -564,6 +565,8 @@ mod tests { string_to_string(r#""Hello""#) => Ok(DynVal::from("Hello".to_string())), safe_access_to_existing(r#"{ "a": { "b": 2 } }.a?.b"#)...
[BUG] Incorrect handling of an empty string by the safe access operator ### Checklist before submitting an issue - [X] I have searched through the existing [closed and open issues](https://github.com/elkowar/eww/issues?q=is%3Aissue) for eww and made sure this is not a duplicate - [X] I have specifically verified that ...
2024-08-27T15:32:03Z
0.1
8661abf2bf07f5a809fc995233d93810cc1ac871
[ "eval::tests::safe_access_to_empty", "eval::tests::safe_access_to_empty_json_string" ]
[ "eval::tests::string_to_string", "eval::tests::safe_access_index_to_missing", "eval::tests::lazy_evaluation_elvis", "eval::tests::lazy_evaluation_and", "eval::tests::lazy_evaluation_or", "eval::tests::safe_access_index_to_non_indexable", "eval::tests::safe_access_index_to_existing", "eval::tests::safe...
[]
[]
366
algesten/ureq
578
algesten__ureq-578
[ "575" ]
78ec3a4d75075c8dff0cb543cd5fc797b7f15132
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +# 2.6.1 + +## Fixed + * gzip: examine Content-Length header before removing (#578) + # 2.6.0 ## Added diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ureq" -vers...
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -1183,4 +1184,37 @@ mod tests { .unwrap(); assert_eq!(agent2.state.pool.len(), 1); } + + #[test] + #[cfg(feature = "gzip")] + fn gzip_content_length() { + use std::io::Cursor; + le...
Reading a gzipped response hangs forever upon reaching the end of the response Hello, i use the actual git version (that solves a problem with the cookiestore for me) and rust compiles without an error but the code hang on every function call like: ``` let test = httpreq.into_string().unwrap(); or let json: s...
Please add `env_logger` to your Cargo.toml, add `env_logger::int()` to your `fn main`, and run your program with `RUST_LOG=debug cargo run`, then paste the full debug output here. Also, please post a full copy of your program and any parameters you are invoking it with (like URLs or hostnames). I'm running into the sam...
2023-01-03T02:49:21Z
2.6
905bf8f0b2d22f95b2d61884591197f24cea4218
[ "response::tests::gzip_content_length", "test::agent_test::connection_reuse_with_408" ]
[ "chunked::decoder::test::test_read_chunk_size", "chunked::decoder::test::invalid_input2", "header::tests::test_valid_value", "header::tests::test_iso8859_utf8_mixup", "error::tests::ensure_error_size", "pool::tests::pool_per_host_connections_limit", "pool::tests::poolkey_new", "header::tests::test_val...
[ "test::range::read_range_rustls", "tests::connect_http_google", "tests::connect_https_google_rustls", "test::range::read_range_native_tls", "tests::connect_https_google_native_tls" ]
[ "test::timeout::read_timeout_during_body" ]
367
algesten/ureq
408
algesten__ureq-408
[ "402" ]
641eb3df10decef45df1fcad9d985fdec484e429
diff --git a/src/proxy.rs b/src/proxy.rs --- a/src/proxy.rs +++ b/src/proxy.rs @@ -79,11 +79,13 @@ impl Proxy { /// * `john:smith@socks.google.com:8000` /// * `localhost` pub fn new<S: AsRef<str>>(proxy: S) -> Result<Self, Error> { - let mut proxy_parts = proxy - .as_ref() - ...
diff --git a/src/proxy.rs b/src/proxy.rs --- a/src/proxy.rs +++ b/src/proxy.rs @@ -196,6 +198,16 @@ mod tests { assert_eq!(proxy.proto, Proto::HTTPConnect); } + #[test] + fn parse_proxy_http_user_pass_server_port_trailing_slash() { + let proxy = Proxy::new("http://user:p@ssw0rd@localhost:99...
Parsing proxy with trailing slash results in wrong port When proxy url is set to `http://127.0.0.1:3128/` (with trailing slash), port is resolved to `8080`: ```plain with https_proxy (http://127.0.0.1:3128/): AgentBuilder { config: AgentConfig { proxy: Some( Proxy { serve...
2021-08-12T10:49:17Z
2.1
30f0ec01e74cc6dc2dd342616c16a1d735f0170d
[ "proxy::tests::parse_proxy_http_user_pass_server_port_trailing_slash", "test::timeout::read_timeout_during_body" ]
[ "proxy::tests::parse_proxy_socks4_user_pass_server_port", "proxy::tests::parse_proxy_socks4a_user_pass_server_port", "proxy::tests::parse_proxy_fakeproto", "header::tests::test_parse_invalid_name", "pool::tests::poolkey_new", "pool::tests::pool_per_host_connections_limit", "pool::tests::pool_connections...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_https_google", "tests::connect_http_google", "tls_client_certificate" ]
[]
368
algesten/ureq
327
algesten__ureq-327
[ "316" ]
c833acfe5cd8e6f6bb01bde4ca71681873e8bdf9
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -469,7 +469,12 @@ fn parse_status_line(line: &str) -> Result<(ResponseStatusIndex, u16), Error> { } // https://tools.ietf.org/html/rfc7230#section-3.1.2 // status-line = HTTP-version SP status-code SP reaso...
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -747,6 +752,13 @@ mod tests { assert_eq!(err.kind(), BadStatus); } + #[test] + fn parse_header_without_reason() { + let s = "HTTP/1.1 302\r\n\r\n".to_string(); + let resp = s.parse::<Respons...
"Bad Status: Wrong number of tokens in status line" error on some websites On some websites, e.g. http://hack.pl, ureq fails with the following error: > Bad Status: Wrong number of tokens in status line However, curl and Firefox work fine. There's 296 such websites in the top million (I'm using [Tranco list g...
Thanks for the report. We recently added some stricter parsing of the status line. Per spec, [reason-phrase can be empty](https://tools.ietf.org/html/rfc7230#section-3.1.2), but the space after the status code is mandatory. hack.pl omits the space. Still, perhaps this is a place to be a little lenient and allow an omit...
2021-02-21T10:23:31Z
2.0
9ec4e7192aa80d38d968e5989742ba10fbbbe575
[ "response::tests::parse_header_without_reason" ]
[ "agent::tests::agent_implements_send_and_sync", "proxy::tests::parse_proxy_socks_user_pass_server_port", "proxy::tests::parse_proxy_socks5_user_pass_server_port", "header::test_valid_name", "body::test_copy_chunked", "error::error_is_send_and_sync", "proxy::tests::parse_proxy_server", "pool::poolkey_n...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[ "test::timeout::read_timeout_during_body" ]
369
algesten/ureq
324
algesten__ureq-324
[ "321" ]
b246f0a9d2e6150b29b5504924edc090d2bf9168
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -537,14 +537,16 @@ fn read_next_line(reader: &mut impl BufRead) -> io::Result<String> { )); } - if !s.ends_with("\r\n") { + if !s.ends_with("\n") { return Err(io::Error::new( io::Err...
diff --git a/src/response.rs b/src/response.rs --- a/src/response.rs +++ b/src/response.rs @@ -644,6 +646,16 @@ mod tests { assert_eq!("application/json", resp.content_type()); } + #[test] + fn content_type_without_cr() { + let s = "HTTP/1.1 200 OK\r\n\ + Content-Type: appli...
"Header field didn't end with \r" error on some websites On some websites, e.g. etihad.com, ureq fails with the following error: > Header field didn't end with \r Firefox and curl work fine. There's 295 such websites in the top million (I'm using [Tranco list generated on the 3rd of February](https://tranco-li...
This is per spec: https://tools.ietf.org/html/rfc7230#section-3.1.2 > The first line of a response message is the status-line, consisting > of the protocol version, a space (SP), the status code, another > space, a possibly empty textual phrase describing the status code, > and ending with CRLF. > >...
2021-02-15T20:59:07Z
2.0
9ec4e7192aa80d38d968e5989742ba10fbbbe575
[ "response::tests::content_type_without_cr", "test::timeout::read_timeout_during_body" ]
[ "proxy::tests::parse_proxy_http_user_pass_server_port", "request::request_implements_send_and_sync", "proxy::tests::parse_proxy_server", "response::short_read", "response::tests::charset", "header::name_and_value", "error::error_is_send_and_sync", "proxy::tests::parse_proxy_socks_user_pass_server_port...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[]
370
algesten/ureq
238
algesten__ureq-238
[ "237" ]
96f6ed15d7d0d2d6e2fefe6b8ffc98b9efb20e71
diff --git a/src/error.rs b/src/error.rs --- a/src/error.rs +++ b/src/error.rs @@ -83,7 +83,7 @@ impl Error { Some(e) => e, None => return false, }; - let ioe: &Box<io::Error> = match source.downcast_ref() { + let ioe: &io::Error = match source.downcast_ref() { ...
diff --git a/src/error.rs b/src/error.rs --- a/src/error.rs +++ b/src/error.rs @@ -183,6 +183,17 @@ fn io_error() { assert_eq!(err.to_string(), "http://example.com/: Io: oops: too slow"); } +#[test] +fn connection_closed() { + let ioe = io::Error::new(io::ErrorKind::ConnectionReset, "connection reset"); + ...
Intermittent test error since #234 landed I'm getting this test error approximately 1 out of 2 test runs. I checked out the prior commit and ran the tests a bunch of time without reproducing, so it's probably something in #234. I'll investigate. ``` ---- test::agent_test::dirty_streams_not_returned stdout ---- Err...
2020-11-22T05:24:05Z
1.5
62cf25fd3575be0652a6766670e6dab2739d6c55
[ "error::connection_closed", "test::agent_test::dirty_streams_not_returned" ]
[ "response::tests::charset", "body::test_copy_chunked", "header::test_parse_invalid_name", "agent::tests::agent_implements_send_and_sync", "header::test_valid_name", "proxy::tests::parse_proxy_http_user_pass_server_port", "proxy::tests::parse_proxy_fakeproto", "header::test_valid_value", "proxy::test...
[ "test::timeout::overall_timeout_reading_json", "test::range::read_range", "tests::connect_http_google", "tests::connect_https_google", "tls_client_certificate" ]
[ "test::timeout::read_timeout_during_body" ]
371
algesten/ureq
50
algesten__ureq-50
[ "24" ]
652500f5a84461f793a05c4c1039cf7b279294b5
diff --git a/src/stream.rs b/src/stream.rs --- a/src/stream.rs +++ b/src/stream.rs @@ -147,7 +147,8 @@ pub(crate) fn connect_https(unit: &Unit) -> Result<Stream, Error> { let hostname = unit.url.host_str().unwrap(); let port = unit.url.port().unwrap_or(443); - let sni = webpki::DNSNameRef::try_from_ascii...
diff --git a/src/lib.rs b/src/lib.rs --- a/src/lib.rs +++ b/src/lib.rs @@ -202,4 +202,12 @@ mod tests { ); assert_eq!("text/html", resp.content_type()); } + + #[test] + #[cfg(feature = "tls")] + fn connect_https_invalid_name() { + let resp = get("https://example.com{REQUEST_URI}/"...
Panic in ureq::stream::connect_https on some websites I've tested `ureq` by downloading homepages of the [top million websites](https://blog.majestic.com/development/majestic-million-csv-daily/) with it. I've found [a panic](https://github.com/briansmith/ring/issues/929) in `ring`, and 13 out of 1,000,000 websites trig...
Thanks! I'll follow the bug in ring and update when I can. I'm not sure if I made it clear, so just in case: there are two distinct panics, one in ring (assertion failure) and another one in ureq (unwrap). Ah. Yes. The unwrap in ureq we should fix!
2020-04-12T02:04:22Z
0.12
652500f5a84461f793a05c4c1039cf7b279294b5
[ "tests::connect_https_invalid_name" ]
[ "agent::tests::agent_implements_send", "test::body_send::str_with_encoding", "test::body_send::user_set_content_length_on_str", "agent::tests::request_implements_send", "test::query_string::query_in_path_and_req", "test::redirect::redirect_get", "test::redirect::redirect_head", "test::redirect::redire...
[ "tests::connect_http_google", "tests::connect_https_google", "test::range::agent_pool", "test::range::read_range", "src/response.rs - response::Response::into_string (line 336)", "src/agent.rs - agent::Agent::cookie (line 173)", "src/response.rs - response::Response::content_type (line 217)", "src/res...
[]
372
RustPython/RustPython
4,711
RustPython__RustPython-4711
[ "4588", "4593", "4588" ]
38172469151f21bae1ec868c548f2ca537146dad
diff --git a/common/src/format.rs b/common/src/format.rs --- a/common/src/format.rs +++ b/common/src/format.rs @@ -335,10 +335,11 @@ impl FormatSpec { let offset = (disp_digit_cnt % (inter + 1) == 0) as i32; let disp_digit_cnt = disp_digit_cnt + offset; let pad_cnt = disp_digit_cnt - magnitud...
diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py --- a/Lib/test/test_types.py +++ b/Lib/test/test_types.py @@ -403,7 +403,6 @@ def test_float__format__locale(self): self.assertEqual(locale.format_string('%g', x, grouping=True), format(x, 'n')) self.assertEqual(locale.format_string(...
Format panic in test_int__format__locale ## Issues In `Lib/test/test_types.py``test_int__format__locale`, if you change from `format(x, 'n')` to `format(x, ',')` and run the test, RustPython will panic! It doesn't crash in CPython! See #4593 for test case broken test case of FormatSpec::format_int test case of ...
not reproducible not reproducible
2023-03-18T04:44:26Z
0.2
7e66db0d43b6fd93bc114773ac8e896b7eda62c9
[ "format::tests::test_format_int_sep" ]
[ "cformat::tests::test_fill_and_align", "cformat::tests::test_format_parse", "cformat::tests::test_format_parse_key_fail", "cformat::tests::test_format_parse_type_fail", "cformat::tests::test_incomplete_format_fail", "cformat::tests::test_parse_and_format_float", "cformat::tests::test_parse_and_format_nu...
[]
[]
374
JohnnyMorganz/StyLua
666
JohnnyMorganz__StyLua-666
[ "665" ]
46457ad4e4130d07ee0f9a5cf95ac10023c8ceeb
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Bumped internal parser dependency which should fix parsing problems for comments with Chinese characters, and multiline string escapes -...
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -127,3 +127,40 @@ fn test_sort_requires() { .unwrap()); }) } + +#[test] +fn test_crlf_in_multiline_comments() { + // We need to do this outside of insta since it normalises line endings to LF + let code = r###...
Line endings appear to not be converted when they occur in multiline comments (?) Heyo, we've run into an odd formatting glitch that causes huge git diffs in combination with VS Code's LF/CRLF setting. In this example file, we have CRLFs present in the comment but LFs everywhere else (as created by StyLua, using the...
Definitely unintended, let me take a look. Thanks for the report!
2023-03-30T15:38:41Z
0.17
5c6d59135f419274121349799a5227be467358b1
[ "test_crlf_in_multiline_strings", "test_crlf_in_multiline_comments" ]
[ "editorconfig::tests::test_call_parentheses_always", "editorconfig::tests::test_call_parentheses_no_single_string", "editorconfig::tests::test_call_parentheses_no_single_table", "editorconfig::tests::test_call_parentheses_none", "editorconfig::tests::test_collapse_simple_statement_conditional_only", "edit...
[]
[]
380
JohnnyMorganz/StyLua
631
JohnnyMorganz__StyLua-631
[ "618" ]
3699358f0ceebe6651789cff25f289d3ac84c937
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Unnecessary parentheses around Luau types will now be removed ([#611](https://github.com/JohnnyMorganz/StyLua/issues/611)) +- ...
diff --git a/tests/tests.rs b/tests/tests.rs --- a/tests/tests.rs +++ b/tests/tests.rs @@ -89,3 +89,25 @@ fn test_collapse_single_statement() { .unwrap()); }) } + +// Collapse simple statement for goto +#[test] +#[cfg(feature = "lua52")] +fn test_collapse_single_statement_lua_52() { + insta::assert_sn...
`collapse_simple_statement` for goto using `collapse_simple_statement = "Always"`: ```lua -- won't collapse if key == "s" then goto continue end -- on the other hand something like this does collapse local modes = { "n", "v" } if key == "p" then modes = { "n" } end -- ... ```
2022-12-18T14:08:23Z
0.15
540ecfb832e3bccf86e0e037b9c855aa464fc4e7
[ "test_collapse_single_statement_lua_52" ]
[ "formatters::trivia_util::tests::test_token_contains_no_singleline_comments_2", "formatters::trivia_util::tests::test_token_contains_no_singleline_comments", "formatters::trivia_util::tests::test_token_contains_singleline_comments", "tests::test_config_call_parentheses", "tests::test_config_column_width", ...
[]
[]
381
actix/actix-web
2,794
actix__actix-web-2794
[ "2767" ]
c6eba2da9b6ead6112433f7d2aaa1f2d19a22395
diff --git a/actix-http/CHANGES.md b/actix-http/CHANGES.md --- a/actix-http/CHANGES.md +++ b/actix-http/CHANGES.md @@ -1,6 +1,10 @@ # Changes ## Unreleased - 2022-xx-xx +### Fixed +- Fix parsing ambiguity in Transfer-Encoding and Content-Length headers for HTTP/1.0 requests. [#2794] + +[#2794]: https://github.com/a...
diff --git a/actix-http/src/h1/decoder.rs b/actix-http/src/h1/decoder.rs --- a/actix-http/src/h1/decoder.rs +++ b/actix-http/src/h1/decoder.rs @@ -606,14 +655,40 @@ mod tests { } #[test] - fn test_parse_post() { - let mut buf = BytesMut::from("POST /test2 HTTP/1.0\r\n\r\n"); + fn parse_h10_post...
Parsing ambiguity in transfer-encoding and content length headers ## Expected Behavior 1. There is no transfer-encoding: chunked header in HTTP/1.0 acccording to RFC spec , so the content-length header should get interpreted 2. According to [RFC message body length](https://datatracker.ietf.org/doc/html/rfc72...
yea `actix-http` is very bad at this. Instead of naively use boolean and options for tracking payload decoder spec it should just take a mutable referenced decoder type with fallible method on mutation. Would there be any fix for this , accepting multiple content-length headers and parsing the body might lead to HT...
2022-06-27T02:48:53Z
4.1
6408291ab00ed4244ceaa4081315691156d66011
[ "h1::decoder::tests::hrs_multiple_transfer_encoding", "h1::decoder::tests::parse_h10_post", "h1::decoder::tests::hrs_te_http10" ]
[ "body::body_stream::tests::read_to_bytes", "body::body_stream::tests::stream_boxed_error", "body::sized_stream::tests::read_to_bytes", "body::message_body::tests::complete_body_combinators", "body::message_body::tests::test_bytes_mut", "body::message_body::tests::test_vec", "body::body_stream::tests::st...
[]
[ "h1_service_error", "h1_body_chunked_explicit", "h1_head_binary", "h1_body_length", "h1_response_http_error_handling", "h1_body_chunked_implicit" ]
382
actix/actix-web
2,566
actix__actix-web-2566
[ "2248" ]
85c9b1a263366d279d544cddf407d00989372269
diff --git a/actix-router/CHANGES.md b/actix-router/CHANGES.md --- a/actix-router/CHANGES.md +++ b/actix-router/CHANGES.md @@ -1,8 +1,11 @@ # Changes ## Unreleased - 2021-xx-xx +- `PathDeserializer` now decodes all percent encoded characters in dynamic segments. [#2566] - Minimum supported Rust version (MSRV) is n...
diff --git a/actix-router/src/de.rs b/actix-router/src/de.rs --- a/actix-router/src/de.rs +++ b/actix-router/src/de.rs @@ -497,6 +489,7 @@ mod tests { use super::*; use crate::path::Path; use crate::router::Router; + use crate::ResourceDef; #[derive(Deserialize)] struct MyStruct { diff --g...
[RFC] percent-encoding in URL path paramters # The problem When extracting URL path parameters from `Path` extractor, the user is expected to be aware of percent-encoding because he would get some encoded characters. To date, all chars are decoded except for `/`, `+`, `%`. This behavior is quite surprising for the ...
2022-01-04T13:10:51Z
3.0
b3e84b5c4bf32fd8aeac8c938f9906ce730a7458
[ "de::tests::deserialize_path_decode_string", "de::tests::deserialize_path_decode_map", "de::tests::deserialize_path_decode_seq" ]
[ "de::tests::test_extract_enum_value", "de::tests::test_extract_enum", "resource::tests::build_path_tail", "resource::tests::duplicate_segment_name - should panic", "resource::tests::invalid_dynamic_segment_delimiter - should panic", "resource::tests::multi_pattern_capture_segment_values", "de::tests::te...
[ "app::tests::test_router_wrap_fn", "app::tests::test_external_resource", "app::tests::test_extension", "app::tests::test_router_wrap", "app::tests::test_wrap_fn", "app::tests::test_data_factory", "app::tests::test_default_resource", "app::tests::test_data_factory_errors", "app_service::tests::test_d...
[]
383
actix/actix-web
3,189
actix__actix-web-3189
[ "3187" ]
9d1f75d349dd6ad8451b8d2dbc619561868dba4d
diff --git a/actix-web/CHANGES.md b/actix-web/CHANGES.md --- a/actix-web/CHANGES.md +++ b/actix-web/CHANGES.md @@ -5,6 +5,7 @@ ### Changed - Updated `zstd` dependency to `0.13`. +- Compression middleware now prefers brotli over zstd over gzip. ### Fixed diff --git a/actix-web/src/http/header/accept_encoding.rs...
diff --git a/actix-web/src/http/header/accept_encoding.rs b/actix-web/src/http/header/accept_encoding.rs --- a/actix-web/src/http/header/accept_encoding.rs +++ b/actix-web/src/http/header/accept_encoding.rs @@ -377,11 +407,11 @@ mod tests { ); assert_eq!( test.negotiate([Encoding::gzip(),...
`.negotiate()` prefers `gzip` over `brotli` If I enable `actix_web::middleware::Compress` middleware, it's serving `gzip`, even though `brotli` feature is on. ## Expected Behavior I am expecting it to pick the best compression method supported by Browser, and between brotli and gzip, brotli is better (my site ...
Since equally weighted q-values are not discriminated according to order (it's left up to the origin), I do think we should preference brotli if it is enabled 👍🏻
2023-11-15T08:24:32Z
4.4
561cc440b2405746d3de01f6983c9c8616a370fb
[ "http::header::accept_encoding::tests::ranking_precedence", "http::header::accept_encoding::tests::preference_selection", "http::header::accept_encoding::tests::encoding_negotiation" ]
[ "error::response_error::tests::test_error_casting", "error::tests::test_urlencoded_error", "error::tests::test_readlines_error", "error::tests::test_json_payload_error", "error::tests::test_query_payload_error", "error::internal::tests::test_internal_error", "error::internal::tests::test_error_helpers",...
[ "data::tests::test_override_data", "data::tests::test_data_extractor", "config::tests::nested_service_configure", "data::tests::test_get_ref_from_dyn_data", "data::tests::test_dyn_data_into_arc", "data::tests::test_app_data_extractor", "app::tests::test_data_factory", "config::tests::registers_default...
[]
384
actix/actix-web
2,684
actix__actix-web-2684
[ "2102", "2514" ]
87f627cd5d33fe71833c24803174dcec5806fea2
diff --git a/actix-http/CHANGES.md b/actix-http/CHANGES.md --- a/actix-http/CHANGES.md +++ b/actix-http/CHANGES.md @@ -3,6 +3,13 @@ ## Unreleased - 2021-xx-xx +## 3.0.3 - 2022-03-08 +### Fixed +- Allow spaces between header name and colon when parsing responses. [#2684] + +[#2684]: https://github.com/actix/actix-w...
diff --git a/actix-http-test/Cargo.toml b/actix-http-test/Cargo.toml --- a/actix-http-test/Cargo.toml +++ b/actix-http-test/Cargo.toml @@ -29,13 +29,13 @@ default = [] openssl = ["tls-openssl", "awc/openssl"] [dependencies] -actix-service = "2.0.0" +actix-service = "2" actix-codec = "0.5" actix-tls = "3" -actix-u...
awc: "Invalid URL: URL parse error: invalid format" error on some websites ## Expected Behavior awc being able to successfully download the websites that work with curl and Firefox. ## Current Behavior On some websites, e.g. http://viralnugget.com, awc fails with the following error: > Invalid URL: URL parse er...
This issue is caused by redirect service does not proper fall through when Location header value does not contain full length uri. (with sheme and authority) I did not test all the 1700 websites provided by issue but from testing a couple of hundreds of it there is no `Invalid URL: URL parse error: invalid format` e...
2022-03-07T23:43:39Z
4.0
8e76a1c77588c4a8214838c7248e7167b13508b1
[ "middleware::redirect::tests::redirect_relative_without_leading_slash", "middleware::redirect::tests::redirect_without_location", "client_brotli_encoding", "client_gzip_encoding_large", "client_brotli_encoding_large_random", "client_gzip_encoding", "client_gzip_encoding_large_random" ]
[ "client::pool::test::test_pool_authority_key", "request::tests::client_query", "middleware::redirect::tests::test_remove_sensitive_headers", "responses::response_body::tests::read_body", "responses::json_body::tests::read_json_body", "builder::tests::client_bearer_auth", "client::pool::test::test_pool_l...
[]
[]
385