diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/hamlit/utils.rb b/lib/hamlit/utils.rb index abc1234..def5678 100644 --- a/lib/hamlit/utils.rb +++ b/lib/hamlit/utils.rb @@ -1,10 +1,16 @@ # frozen_string_literal: true -unless /java/ === RUBY_PLATFORM # exclude JRuby - require 'hamlit/hamlit' # depends on C-ext defines Hamlit::Utils first for now -end...
Support HTML escape for JRuby
diff --git a/spec/active_record_spec_helper.rb b/spec/active_record_spec_helper.rb index abc1234..def5678 100644 --- a/spec/active_record_spec_helper.rb +++ b/spec/active_record_spec_helper.rb @@ -12,6 +12,7 @@ config.include FactoryGirl::Syntax::Methods config.before(:suite) do + FactoryGirl.factories.clear ...
Clear out the FG definitions if they are already defined so there is no duplicate definition error
diff --git a/spec/features/pages/index_spec.rb b/spec/features/pages/index_spec.rb index abc1234..def5678 100644 --- a/spec/features/pages/index_spec.rb +++ b/spec/features/pages/index_spec.rb @@ -2,30 +2,31 @@ describe 'pages#index' do - before :each do - create_logged_in_user - visit georgia.search_pages_u...
Add specs for page creation
diff --git a/spec/integration/database_test.rb b/spec/integration/database_test.rb index abc1234..def5678 100644 --- a/spec/integration/database_test.rb +++ b/spec/integration/database_test.rb @@ -4,6 +4,12 @@ specify "should provide disconnect functionality" do INTEGRATION_DB.test_connection INTEGRATION_DB...
Add integration test for disconnecting after calling a prepared statement
diff --git a/lib/meetupanator.rb b/lib/meetupanator.rb index abc1234..def5678 100644 --- a/lib/meetupanator.rb +++ b/lib/meetupanator.rb @@ -1,4 +1,5 @@ require 'meetupanator/app' +require 'meetupanator/cli' require 'meetupanator/event_finder' require 'meetupanator/event_list_file_writer' require 'meetupanator/meetu...
Fix broken command line app.
diff --git a/lib/caulfield.rb b/lib/caulfield.rb index abc1234..def5678 100644 --- a/lib/caulfield.rb +++ b/lib/caulfield.rb @@ -9,6 +9,8 @@ end end -ActiveSupport.on_load(:before_initialize) do - Rails.configuration.middleware.use Caulfield::Middleware +if defined?(Rails) && Rails.version >= '3.0.0.beta4' + Act...
Check if Rails is being used and the right version before inserting the middleware.
diff --git a/lib/remindice.rb b/lib/remindice.rb index abc1234..def5678 100644 --- a/lib/remindice.rb +++ b/lib/remindice.rb @@ -2,6 +2,8 @@ require "thor" module Remindice + TASK_FILENAME = "~/.reamindice_tasks" + @@tasks = if File.exists?(TASK_FILENAME); File.readlines(TASK_FILENAME) else [] end class Command...
Load tasks from the constant file name
diff --git a/spec-tests/spec/localhost/tor_spec.rb b/spec-tests/spec/localhost/tor_spec.rb index abc1234..def5678 100644 --- a/spec-tests/spec/localhost/tor_spec.rb +++ b/spec-tests/spec/localhost/tor_spec.rb @@ -6,5 +6,10 @@ describe file('/etc/tor/torrc') do it { should be_file } - its(:content) { should match ...
Improve tor spect test slightly
diff --git a/spec/classes/repo_spec.rb b/spec/classes/repo_spec.rb index abc1234..def5678 100644 --- a/spec/classes/repo_spec.rb +++ b/spec/classes/repo_spec.rb @@ -8,6 +8,24 @@ end it { is_expected.to compile } + + describe 'with default parameters' do + it { is_expected.to contain_class('ap...
Add tests for repo class
diff --git a/spec/models/round_spec.rb b/spec/models/round_spec.rb index abc1234..def5678 100644 --- a/spec/models/round_spec.rb +++ b/spec/models/round_spec.rb @@ -1,5 +1,18 @@ require 'spec_helper' describe Round do - pending "add some examples to (or delete) #{__FILE__}" + describe "#recall" do + let(:compet...
Set up basic `round` factories.
diff --git a/db/migrate/20140529104412_create_popularity_function.rb b/db/migrate/20140529104412_create_popularity_function.rb index abc1234..def5678 100644 --- a/db/migrate/20140529104412_create_popularity_function.rb +++ b/db/migrate/20140529104412_create_popularity_function.rb @@ -5,7 +5,9 @@ CREATE OR REPLACE FUNCT...
Create two different execute fns for debugging
diff --git a/app/models/image.rb b/app/models/image.rb index abc1234..def5678 100644 --- a/app/models/image.rb +++ b/app/models/image.rb @@ -38,6 +38,6 @@ end # Remove nils and duplicates - images.compact.uniq { |image| image.repository } + images.compact.uniq(&:repository) end end
Simplify uniq call w/ symbol-to-proc
diff --git a/app/policies/application_policy.rb b/app/policies/application_policy.rb index abc1234..def5678 100644 --- a/app/policies/application_policy.rb +++ b/app/policies/application_policy.rb @@ -1,4 +1,9 @@ class ApplicationPolicy < ActionPolicy::Base # make :manage? a real catch-all - alias_rule :index?, :cr...
users: Modify catch-all policy to actually work
diff --git a/test/apps/rails3/app/controllers/other_controller.rb b/test/apps/rails3/app/controllers/other_controller.rb index abc1234..def5678 100644 --- a/test/apps/rails3/app/controllers/other_controller.rb +++ b/test/apps/rails3/app/controllers/other_controller.rb @@ -35,4 +35,8 @@ something end end +...
[CSC] Add test for render with nonsymbol keys
diff --git a/lib/real_world_rails/inspectors/view_specs_inspector.rb b/lib/real_world_rails/inspectors/view_specs_inspector.rb index abc1234..def5678 100644 --- a/lib/real_world_rails/inspectors/view_specs_inspector.rb +++ b/lib/real_world_rails/inspectors/view_specs_inspector.rb @@ -3,8 +3,11 @@ class ViewSpecsI...
Print out view spec filename
diff --git a/morpheus.gemspec b/morpheus.gemspec index abc1234..def5678 100644 --- a/morpheus.gemspec +++ b/morpheus.gemspec @@ -8,8 +8,8 @@ spec.version = Morpheus::VERSION spec.authors = ["Tomas D'Stefano"] spec.email = ["tomas_stefano@successoft.com"] - spec.description = %q{TODO: Writ...
Add full text search description for now in the gemspec
diff --git a/test/sqwish_test.rb b/test/sqwish_test.rb index abc1234..def5678 100644 --- a/test/sqwish_test.rb +++ b/test/sqwish_test.rb @@ -2,6 +2,7 @@ class SqwishTest < UnitTest setup do + app.set :reload_templates, true app.assets.css_compression :sqwish, :strict => true end @@ -20,10 +21,10 @@ ...
Update sqwish test (need to reload templates)
diff --git a/app/controllers/admin/quotas_controller.rb b/app/controllers/admin/quotas_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/quotas_controller.rb +++ b/app/controllers/admin/quotas_controller.rb @@ -2,6 +2,9 @@ def index @years = Quota.years_array + if params[:year] && !@ye...
Include year that is passed from params. (When quotas are duplicated for a new year, that year will not be in the array of years, until they have been copied. This way the interface shows it nevertheless, otherwise users might think it didn't work)
diff --git a/app/controllers/admin/venues_controller.rb b/app/controllers/admin/venues_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/venues_controller.rb +++ b/app/controllers/admin/venues_controller.rb @@ -7,8 +7,8 @@ @venues = Venue.non_duplicates # ransack-compatible param-based ...
Make venues index use params[:type], like events in admin view
diff --git a/app/controllers/api/v0/users_controller.rb b/app/controllers/api/v0/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v0/users_controller.rb +++ b/app/controllers/api/v0/users_controller.rb @@ -5,7 +5,7 @@ end def search - @users = User.where("first_name LIKE ? or userna...
Add safe operator & for capitalizing params
diff --git a/app/controllers/api/v1/users_controller.rb b/app/controllers/api/v1/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/users_controller.rb +++ b/app/controllers/api/v1/users_controller.rb @@ -43,8 +43,7 @@ private def set_user - @user = User.find_by(id: params[:id]) - ...
Implement friendly find in Api::V1::UsersController.
diff --git a/app/controllers/transactions_controller.rb b/app/controllers/transactions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/transactions_controller.rb +++ b/app/controllers/transactions_controller.rb @@ -14,4 +14,15 @@ render json: transactions end + def update + transaction =...
Update an individual transaction (e.g. description)
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -16,5 +16,11 @@ # Don't care if the mailer can't send config.action_mailer.raise_delivery_errors = false -# Uncomment...
Update the code that reloads plugin app directories to more robust code
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -38,4 +38,7 @@ # Raises error for missing translations # config.action_view.raise_on_missing_translations = true ...
Add default URL options for Devise mailer
diff --git a/config/initializers/clear_cache.rb b/config/initializers/clear_cache.rb index abc1234..def5678 100644 --- a/config/initializers/clear_cache.rb +++ b/config/initializers/clear_cache.rb @@ -1,3 +1,4 @@+`mkdir -p tmp/cache` # just in case this directory doesn't exist yet Rails.cache.clear Rails.logger.info ...
Fix Heroku deployment build error
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index abc1234..def5678 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -8,24 +8,3 @@ # inflect.irregular 'person', 'people' # inflect.uncountable %w( fish sheep ) # end - -# Mark "commi...
Remove inflector rule that makes commits uncountable Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/scripts/generate-coverage-report-index.rb b/scripts/generate-coverage-report-index.rb index abc1234..def5678 100644 --- a/scripts/generate-coverage-report-index.rb +++ b/scripts/generate-coverage-report-index.rb @@ -14,7 +14,11 @@ File.open(file, 'wb') { |f| f.write(content) } end -OUTPUT_FILE = ARGV....
Print usage on wrong parameters
diff --git a/sg_node_mapper.gemspec b/sg_node_mapper.gemspec index abc1234..def5678 100644 --- a/sg_node_mapper.gemspec +++ b/sg_node_mapper.gemspec @@ -19,4 +19,5 @@ gem.add_dependency 'activesupport', '>= 3.0' gem.add_development_dependency 'rake', '>= 0.9' + gem.add_development_dependency 'rspec', '>= 2.10' ...
Add rspec as a development dependency
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -32,6 +32,21 @@ end end + describe "When Unsuccessful" do + it "redirec...
Add user create unsuccessful path test
diff --git a/spec/core_ext/object/space_object_spec.rb b/spec/core_ext/object/space_object_spec.rb index abc1234..def5678 100644 --- a/spec/core_ext/object/space_object_spec.rb +++ b/spec/core_ext/object/space_object_spec.rb @@ -0,0 +1,74 @@+require 'spec_helper' + +shared_examples_for 'a convertable object' do |object...
Add tests for encodings of objects to Space keys, hashes, and objects.
diff --git a/beantool.gemspec b/beantool.gemspec index abc1234..def5678 100644 --- a/beantool.gemspec +++ b/beantool.gemspec @@ -20,7 +20,7 @@ gem.required_ruby_version = '~> 2.0' - gem.add_runtime_dependency 'beanstalk-client' + gem.add_runtime_dependency 'beaneater' gem.add_development_depe...
Replace beanstalk-client dependency with beaneater
diff --git a/spec/serializers/payment_depot_serializer_spec.rb b/spec/serializers/payment_depot_serializer_spec.rb index abc1234..def5678 100644 --- a/spec/serializers/payment_depot_serializer_spec.rb +++ b/spec/serializers/payment_depot_serializer_spec.rb @@ -4,7 +4,11 @@ describe PaymentDepotSerializer do le...
Set field to test that a string is returned
diff --git a/application.rb b/application.rb index abc1234..def5678 100644 --- a/application.rb +++ b/application.rb @@ -10,7 +10,6 @@ class Application < Sinatra::Base configure :production, :development do enable :logging - set :server, :puma end def initialize @@ -20,7 +19,14 @@ user: ENV['A...
Exit on PG connection failure
diff --git a/services/importer/spec/acceptance/acceptance_helpers.rb b/services/importer/spec/acceptance/acceptance_helpers.rb index abc1234..def5678 100644 --- a/services/importer/spec/acceptance/acceptance_helpers.rb +++ b/services/importer/spec/acceptance/acceptance_helpers.rb @@ -1,11 +1,11 @@ module AcceptanceHelp...
Check geometry type directly in user db
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -36,6 +36,17 @@ assert_redirected_to my_profile_path end + test "should update use...
Add test for failed password edit
diff --git a/test/tc_coverage.rb b/test/tc_coverage.rb index abc1234..def5678 100644 --- a/test/tc_coverage.rb +++ b/test/tc_coverage.rb @@ -17,9 +17,8 @@ class GratuitousBud < Test::Unit::TestCase def test_sigint pid = fork do - # XXX: There must be a better way to do this p = Nada.new - Threa...
Improve signal handling test case.
diff --git a/test/tc_live_cmn.rb b/test/tc_live_cmn.rb index abc1234..def5678 100644 --- a/test/tc_live_cmn.rb +++ b/test/tc_live_cmn.rb @@ -1,7 +1,12 @@ require 'rbconfig' module TestLiveCMN - unless Config::CONFIG['host_os'] =~ /mswin|mingw/ - def test_live_cmn + def test_live_cmn + # This test fails on wind...
Stop CMN test from failing on Windows.
diff --git a/test/test_consts.rb b/test/test_consts.rb index abc1234..def5678 100644 --- a/test/test_consts.rb +++ b/test/test_consts.rb @@ -9,6 +9,9 @@ end should "have the constants be the proper values" do + assert_equal Rutty::Consts::GENERAL_CONF_FILE, 'defaults.yaml' + assert_equal Rutty:...
Add new assertions to Rutty::Consts test for new constants
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -28,7 +28,7 @@ @app = Risu::CLI::Application.new @app.load_config(config, true) @app.db_connect - @app.migrate(:down) if File.exist?("test_data/test.db") == true + File.delete...
Delete test.db before the tests
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -2,3 +2,4 @@ require 'rex' require 'minitest/autorun' +require 'minitest/pride'
Add pride to minitest helper.
diff --git a/app/controllers/blog_controller.rb b/app/controllers/blog_controller.rb index abc1234..def5678 100644 --- a/app/controllers/blog_controller.rb +++ b/app/controllers/blog_controller.rb @@ -1,5 +1,4 @@ class BlogController < ApplicationController - layout 'application' before_filter :find_post, only: [:s...
Remove unneeded layout call in blog controller
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,7 +1,9 @@ class HomeController < ApplicationController def index @challenges = Challenge.opened - @posts =...
Order posts by updated date
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,19 +1,25 @@ class HomeController < ApplicationController + before_filter :load_asciicast + def show @title =...
Load homepage asciicast in before_filter
diff --git a/app/serializers/firm_serializer.rb b/app/serializers/firm_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/firm_serializer.rb +++ b/app/serializers/firm_serializer.rb @@ -9,6 +9,7 @@ :inheritance_tax_planning, :wills_and_probate, :other_advice_methods, + :advises_on_invest...
Index firms with a `advises_on_investments` flag.
diff --git a/test/integration/git_http_cloning_test.rb b/test/integration/git_http_cloning_test.rb index abc1234..def5678 100644 --- a/test/integration/git_http_cloning_test.rb +++ b/test/integration/git_http_cloning_test.rb @@ -2,20 +2,24 @@ class GitHttpCloningTest < ActionController::IntegrationTest context 'Re...
Make the git cloning metal test check that the actual filename returned is correct - not only that it is set
diff --git a/lib/caulfield.rb b/lib/caulfield.rb index abc1234..def5678 100644 --- a/lib/caulfield.rb +++ b/lib/caulfield.rb @@ -10,6 +10,6 @@ if defined?(Rails) && Rails.version >= '3.0.0' ActiveSupport.on_load :before_initialize do - Rails.configuration.middleware.use Caulfield::Middleware + Rails.configur...
Put Caulfield at the start of the middleware stack, so it can catch headers after they've been processed by ActionDispatch.
diff --git a/lib/datapipes.rb b/lib/datapipes.rb index abc1234..def5678 100644 --- a/lib/datapipes.rb +++ b/lib/datapipes.rb @@ -30,16 +30,16 @@ @source.pipe = @pipe runners = @source.run_all - consumer = run_comsumer + sink = run_sink runners.each(&:join) notify_resource_ending - consum...
Change internal name: consumer -> sink
diff --git a/lib/metar/raw.rb b/lib/metar/raw.rb index abc1234..def5678 100644 --- a/lib/metar/raw.rb +++ b/lib/metar/raw.rb @@ -18,6 +18,7 @@ connection = Net::FTP.new('tgftp.nws.noaa.gov') connection.login connection.chdir('data/observations/metar/stations') + connection.passive = tru...
Make sure FTP works behind firewalls.
diff --git a/apps/main/core/main/application.rb b/apps/main/core/main/application.rb index abc1234..def5678 100644 --- a/apps/main/core/main/application.rb +++ b/apps/main/core/main/application.rb @@ -1,6 +1,5 @@ require "rack/csrf" require "dry/web/application" -require "either_result_matcher/either_extensions" requ...
Remove old either_result_matcher monkey-patch require
diff --git a/lib/tdx/stock.rb b/lib/tdx/stock.rb index abc1234..def5678 100644 --- a/lib/tdx/stock.rb +++ b/lib/tdx/stock.rb @@ -1,20 +1,31 @@ module Tdx class Stock def initialize(symbol) - @symbol = symbol + @stock_code, @exchange = parse_symbol(symbol) end def quotes(time_step = 240) ...
Use Yahoo! Finance ticker symbol style
diff --git a/app/controllers/admin/financial_reports_controller.rb b/app/controllers/admin/financial_reports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/financial_reports_controller.rb +++ b/app/controllers/admin/financial_reports_controller.rb @@ -7,7 +7,7 @@ end def create - @fin...
Add strong params for financial reports
diff --git a/app/controllers/electronics/electronics_controller.rb b/app/controllers/electronics/electronics_controller.rb index abc1234..def5678 100644 --- a/app/controllers/electronics/electronics_controller.rb +++ b/app/controllers/electronics/electronics_controller.rb @@ -2,7 +2,7 @@ def index add_breadcru...
Change active computers listing in Index Electronics
diff --git a/db/seeds/modules/gobierto_plans/seeds.rb b/db/seeds/modules/gobierto_plans/seeds.rb index abc1234..def5678 100644 --- a/db/seeds/modules/gobierto_plans/seeds.rb +++ b/db/seeds/modules/gobierto_plans/seeds.rb @@ -4,9 +4,6 @@ class Recipe def self.run(site) - # Create sdg vocabulary - retu...
Change plans module seed to only import SDGs vocabulary but not create custom field
diff --git a/make-sponsors.rb b/make-sponsors.rb index abc1234..def5678 100644 --- a/make-sponsors.rb +++ b/make-sponsors.rb @@ -0,0 +1,19 @@+require "yaml" +print "Enter the event in YYYY-city format: " +cityname = gets.chomp +config = YAML.load_file("data/events/#{cityname}.yml") +sponsors = config['sponsors'] +spons...
Create script for generating sponsor files This ruby script basically reads in a city config file and creates the sponsor file associated with it. It will NOT create the images, naturally, but this will make it somewhat easier. Former-commit-id: 4c9503f6a12b3c0eac0eb1e4610acd20acce7c8c
diff --git a/app/models/qernel/merit_facade/curtailment_adapter.rb b/app/models/qernel/merit_facade/curtailment_adapter.rb index abc1234..def5678 100644 --- a/app/models/qernel/merit_facade/curtailment_adapter.rb +++ b/app/models/qernel/merit_facade/curtailment_adapter.rb @@ -9,11 +9,13 @@ super inpu...
Correct deficit of unused steam in merit order CurtailmentAdapter adjusts the demand assigned for electricity networks in order to prevent unwanted import from occurring. This compensation is now required with the heat network where there is no dispatchable import. Corrects an errenous demand assiged to the edge betw...
diff --git a/KSPAutomaticHeightCalculationTableCellView.podspec b/KSPAutomaticHeightCalculationTableCellView.podspec index abc1234..def5678 100644 --- a/KSPAutomaticHeightCalculationTableCellView.podspec +++ b/KSPAutomaticHeightCalculationTableCellView.podspec @@ -16,9 +16,9 @@ spec.summary = 'A useful superclass f...
Raise the deployment target to 10.8 because of a used NSNib method.
diff --git a/bin/geocode_cita.rb b/bin/geocode_cita.rb index abc1234..def5678 100644 --- a/bin/geocode_cita.rb +++ b/bin/geocode_cita.rb @@ -6,14 +6,15 @@ locations = [] -# "REGION","DELIVERY BUREAU","PRIMARY CONTACT","POSTAL ADDRESS","Phone number" +# "Pension Wise Delivery Centre ","Pension Wise Email ","Pension ...
Update CitA CSV parsing script
diff --git a/ohm-contrib.gemspec b/ohm-contrib.gemspec index abc1234..def5678 100644 --- a/ohm-contrib.gemspec +++ b/ohm-contrib.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "ohm-contrib" - s.version = "1.0.0.rc4" + s.version = "1.0.0.rc5" s.summary = %{A collection of decoupled drop-in module...
Bump to 1.0.0.rc5: Point to ohm 1.0.0.rc4.
diff --git a/sanitize-rails.gemspec b/sanitize-rails.gemspec index abc1234..def5678 100644 --- a/sanitize-rails.gemspec +++ b/sanitize-rails.gemspec @@ -8,8 +8,8 @@ s.name = "sanitize-rails" s.version = Sanitize::Rails::VERSION s.date = "2014-03-14" - s.authors = ["Marcello Barnab...
:star: Add @fabn to the authors list
diff --git a/sass-timestamp.gemspec b/sass-timestamp.gemspec index abc1234..def5678 100644 --- a/sass-timestamp.gemspec +++ b/sass-timestamp.gemspec @@ -1,13 +1,13 @@ Gem::Specification.new do |s| s.name = %q{sass-timestamp} - s.version = "0.0.1.alpha.1" + s.version = "0.0.1" s.date = %q{2014-08-12} s.license = '...
Change homepage link to github source
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -9,8 +9,11 @@ # since you don't have to restart the web server when you make code changes. config.cache_classes = f...
BAU: Fix for translations being on a separate thread In dev env the eager_load is set to false which causes the app the hang when it looses the reference to the TransactionTranslationResponse class. This is a quick fix.
diff --git a/app/helpers/user_impersonate/application_helper.rb b/app/helpers/user_impersonate/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/user_impersonate/application_helper.rb +++ b/app/helpers/user_impersonate/application_helper.rb @@ -5,7 +5,7 @@ staff_finder_method = config_value(Us...
Add unscoped call for users
diff --git a/config/initializers/load_resque.rb b/config/initializers/load_resque.rb index abc1234..def5678 100644 --- a/config/initializers/load_resque.rb +++ b/config/initializers/load_resque.rb @@ -7,4 +7,41 @@ Dir[Rails.root.join("lib/resque/*.rb")].each {|f| require f} Resque.redis = "#{Cartodb.config[:redis]['...
Use custom logger to extract metrics instead of statsd logger
diff --git a/config/initializers/door_status_manager.rb b/config/initializers/door_status_manager.rb index abc1234..def5678 100644 --- a/config/initializers/door_status_manager.rb +++ b/config/initializers/door_status_manager.rb @@ -1,6 +1,6 @@ # Pesho instance for door status updates Rails.application.config.door_sta...
Make the default door status manager URI a valid one
diff --git a/cookbooks/postgresql/attributes/default.rb b/cookbooks/postgresql/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/postgresql/attributes/default.rb +++ b/cookbooks/postgresql/attributes/default.rb @@ -1,7 +1,7 @@ include_attribute 'travis_build_environment' -default['postgresql']['defa...
Add 9.6 to postgresql alternate versions and bump the default from 9.1 => 9.3
diff --git a/cookbooks/lib/features/git_spec.rb b/cookbooks/lib/features/git_spec.rb index abc1234..def5678 100644 --- a/cookbooks/lib/features/git_spec.rb +++ b/cookbooks/lib/features/git_spec.rb @@ -10,11 +10,11 @@ its(:exit_status) { should eq 0 } end - describe command('git config user.name'), dev: true d...
Tag git config specs to be skipped on precise until the behavior can be backported
diff --git a/spec/functionality_spec.rb b/spec/functionality_spec.rb index abc1234..def5678 100644 --- a/spec/functionality_spec.rb +++ b/spec/functionality_spec.rb @@ -13,7 +13,7 @@ it 'raises an error for missing files' do expect { subject.inform('nonexist') - }.to raise_error(/failed to open...
Fix specs, do not output the metadata.
diff --git a/spec/lib/allen/dsl_spec.rb b/spec/lib/allen/dsl_spec.rb index abc1234..def5678 100644 --- a/spec/lib/allen/dsl_spec.rb +++ b/spec/lib/allen/dsl_spec.rb @@ -20,13 +20,18 @@ end it "can configure projects" do - proj = project "Rhino" do + proj1 = project "Rhino" do compile true cac...
Add an additional project as a sanity check
diff --git a/spec/sequel_spec_helper.rb b/spec/sequel_spec_helper.rb index abc1234..def5678 100644 --- a/spec/sequel_spec_helper.rb +++ b/spec/sequel_spec_helper.rb @@ -27,6 +27,7 @@ def self.model_setup(db, models) models.each do |name, (table, associations)| klass = Class.new(Sequel::Model(db[table])) +...
Set model top level constant earlier in spec, fixing association issues
diff --git a/compat/helper.rb b/compat/helper.rb index abc1234..def5678 100644 --- a/compat/helper.rb +++ b/compat/helper.rb @@ -24,6 +24,9 @@ class Test::Unit::TestCase include Sinatra::Test + + PASSTHROUGH_EXCEPTIONS = [] unless const_defined?(:PASSTHROUGH_EXCEPTIONS) + def setup @app = lambda { |env| S...
Fix mocha puking all over itself under 1.9
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -20,6 +20,6 @@ # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s] # config.i18n.default_locale = :de - config.assets.precompi...
Update ckeditor assets precompile directive CKEditor is not working, hoping this will fix it.
diff --git a/omniauth.gemspec b/omniauth.gemspec index abc1234..def5678 100644 --- a/omniauth.gemspec +++ b/omniauth.gemspec @@ -17,6 +17,7 @@ spec.name = 'omniauth' spec.require_paths = %w(lib) spec.required_rubygems_version = '>= 1.3.5' + spec.required_ruby_version = '>= 2.1.9' spec.summary ...
Update required Ruby version in gemspec
diff --git a/spec/models/ci/bridge_spec.rb b/spec/models/ci/bridge_spec.rb index abc1234..def5678 100644 --- a/spec/models/ci/bridge_spec.rb +++ b/spec/models/ci/bridge_spec.rb @@ -25,22 +25,16 @@ describe '#scoped_variables_hash' do it 'returns a hash representing variables' do - expect(bridge.scoped_var...
Fix CI/CD bridge variables unit test
diff --git a/spec/rdkafka/bindings_spec.rb b/spec/rdkafka/bindings_spec.rb index abc1234..def5678 100644 --- a/spec/rdkafka/bindings_spec.rb +++ b/spec/rdkafka/bindings_spec.rb @@ -5,9 +5,58 @@ expect(Rdkafka::Bindings.ffi_libraries.map(&:name).first).to include "librdkafka" end + describe ".lib_extension" do...
Add specs for extension and log callback in bindings
diff --git a/sprockets-redirect.gemspec b/sprockets-redirect.gemspec index abc1234..def5678 100644 --- a/sprockets-redirect.gemspec +++ b/sprockets-redirect.gemspec @@ -28,6 +28,7 @@ s.add_development_dependency 'bundler' s.add_development_dependency 'rake' s.add_development_dependency 'rack-test' + s.add_deve...
Add Rails as development dependency
diff --git a/lib/tasks/auto_annotate_models.rake b/lib/tasks/auto_annotate_models.rake index abc1234..def5678 100644 --- a/lib/tasks/auto_annotate_models.rake +++ b/lib/tasks/auto_annotate_models.rake @@ -19,7 +19,7 @@ 'exclude_tests' => 'false', 'exclude_fixtures' => 'false', 'exclude_fa...
Stop scanning subdirectories under app/models.
diff --git a/lib/zensana/models/asana/project.rb b/lib/zensana/models/asana/project.rb index abc1234..def5678 100644 --- a/lib/zensana/models/asana/project.rb +++ b/lib/zensana/models/asana/project.rb @@ -47,7 +47,7 @@ end def fetch_tasks(id) - task_list(id).map { |t| Zensana::Task.new(t['id']) } ...
Fix reference to task object
diff --git a/spec/cookie_spec.rb b/spec/cookie_spec.rb index abc1234..def5678 100644 --- a/spec/cookie_spec.rb +++ b/spec/cookie_spec.rb @@ -10,6 +10,8 @@ expect(data["cat"]).to eq("dog") end + # The "new" cookie string is being updated with additional criteria, thereby making a string comparison worthless, +...
Write comment explaining why test is probably failing
diff --git a/spec/sartre_spec.rb b/spec/sartre_spec.rb index abc1234..def5678 100644 --- a/spec/sartre_spec.rb +++ b/spec/sartre_spec.rb @@ -0,0 +1,36 @@+require 'bundler/setup' +require 'rspec' +require 'sartre' + +describe Sartre do + subject do + class MyObject + attr_accessor :property + + def attribu...
Write tests for extenssts for extension
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,8 +14,14 @@ # Omit warnings from output config.log_level = :fatal + + config.before(:suite) do + ChefSpec::Coverage.filters << File.join(config.cookbook_path, 'mesos...
Add chefspec coverage w/ fancy filter
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -22,9 +22,12 @@ options = Net::SSH::Config.for(host) -options[:user] ||= Etc.getlogin +set :host, options[:host_name] || host -set :host, options[:host_name] ||...
Enable setting of HostName and User via environment variables
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,6 @@+require 'coveralls' +Coveralls.wear! + require 'right_hook' require 'right_hook/app' require 'right_hook/authenticated_client' @@ -10,9 +13,6 @@ require 'webmock/rs...
Put `Coveralls.wear!` before app code is required That's what the docs say to do, anyway. https://coveralls.io/docs/ruby
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -27,7 +27,7 @@ # FakeWeb.register_uri( # :post, -# "https://api.channeladvisor.com/ChannelAdvisorAPI/v5/OrderService.asmx", +# "https://api.channeladvisor.com/Chan...
Update FakeWeb URI to ChannelAdvisor V6 API
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,6 +14,10 @@ require 'queueing_rabbit' RSpec.configure do |config| + config.before(:each) { + QueueingRabbit.drop_connection + } + QueueingRabbit.configure do |qr| ...
Drop connection before each example.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -44,7 +44,7 @@ if ::ActiveRecord::VERSION::STRING >= '4.1.0' require 'minitest' include Minitest::Assertions - def assertions; @assertions || 0; end + d...
Fix uninitialized instance variable warning
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,8 +8,6 @@ Dir[File.expand_path("../support/**/*.rb", __FILE__)].each {|f| require f} PROJECT_ROOT = File.expand_path(File.join(__FILE__, "../../")) SPEC_ROOT = File.expand_pat...
Remove missed require of pry-debugger
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,2 +1,4 @@ $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) require 'sncf_api' +require 'pry' +require 'pry-byebug'
Enable pry dbg binding into guard/rspec
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,19 @@ require 'bundler/setup' +require 'coveralls' +Coveralls.wear! + require 'space2underscore' +require 'simplecov' + +SimpleCov.formatter = SimpleCov::Formatter::MultiF...
Configure of gems for coverage
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,7 +2,6 @@ Coveralls.wear! RSpec.configure do |config| - config.treat_symbols_as_metadata_keys_with_true_values = true config.run_all_when_everything_filtered = true co...
Remove redundant RSpec config option treat_symbols_as_metadata_keys_with_true_values is now always true (and setting it to false has no effect).
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@ require File.dirname(__FILE__) + "/../lib/integrity" require "rubygems" require "spec" + +DataMapper.setup(:default, "sqlite3::memory:")
Use an in-memory sqlite3 database for testing
diff --git a/lib/spiderfw/controller/request.rb b/lib/spiderfw/controller/request.rb index abc1234..def5678 100644 --- a/lib/spiderfw/controller/request.rb +++ b/lib/spiderfw/controller/request.rb @@ -24,7 +24,7 @@ Spider::Logger.debug("REQUEST:") Spider::Logger.debug(env) @env = e...
Use Spider.locale instead of Locale.current[0] to avoid errors on Windows
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -5,7 +5,7 @@ set :repo_url, 'https://github.com/anniecodes/annie.codes.git' set :user, "deploy" -set :rbenv_ruby, "2.5.3" +set :rbenv_ruby, "2.6.0" # Default value for :linked_files is [...
Deploy to the correct ruby version 2.6.0
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,6 @@ Rails.application.routes.draw do + + root to: 'items#index' resources :schools, only: [:show]
Change root to be the items search view
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,7 +2,7 @@ scope module: 'sprangular' do root to: 'home#index' - scope defaults: {format: :json} do + scope '/api', defaults: {format: :json} do post 'facebook/fetch' ...
Add /api to controller path
diff --git a/lib/devise/models/strengthened.rb b/lib/devise/models/strengthened.rb index abc1234..def5678 100644 --- a/lib/devise/models/strengthened.rb +++ b/lib/devise/models/strengthened.rb @@ -11,8 +11,13 @@ protected + MINIMUM_ENTROPY = 20 + def strong_enough_password? - self.errors.ad...
Add feedback for password strength
diff --git a/lib/geocoder/lookups/pickpoint.rb b/lib/geocoder/lookups/pickpoint.rb index abc1234..def5678 100644 --- a/lib/geocoder/lookups/pickpoint.rb +++ b/lib/geocoder/lookups/pickpoint.rb @@ -7,8 +7,8 @@ "Pickpoint" end - def use_ssl? - true + def supported_protocols + [:https] en...
Implement supported_protocols rather than use_ssl?. This is a better way to force HTTPS.
diff --git a/lib/github/repository_importer.rb b/lib/github/repository_importer.rb index abc1234..def5678 100644 --- a/lib/github/repository_importer.rb +++ b/lib/github/repository_importer.rb @@ -1,7 +1,7 @@ module Github class RepositoryImporter - API_REQUEST_INTERVAL = 0.02 - MAX_IMPORT_COUNT = 30 + API_...
Decrease repository import frequency because it finished
diff --git a/lib/lobbyist/v2/scotty_setting.rb b/lib/lobbyist/v2/scotty_setting.rb index abc1234..def5678 100644 --- a/lib/lobbyist/v2/scotty_setting.rb +++ b/lib/lobbyist/v2/scotty_setting.rb @@ -5,7 +5,7 @@ attr_accessor :id, :company_id, :days, :time attr_accessor :upload_type, :system_enabled, :use_clo...
CA-4261: Add new field as accessor
diff --git a/app/controllers/observations_controller.rb b/app/controllers/observations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/observations_controller.rb +++ b/app/controllers/observations_controller.rb @@ -1,10 +1,6 @@ # frozen_string_literal: true class ObservationsController < Applicatio...
Delete requires for "find" and "set" in main Obs Ctrlr file
diff --git a/app/presenters/clockface/jobs_presenter.rb b/app/presenters/clockface/jobs_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/clockface/jobs_presenter.rb +++ b/app/presenters/clockface/jobs_presenter.rb @@ -33,7 +33,7 @@ def last_run_at if job.last_run_at job.last_run_at. -...
Validate time_zone before using it