diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -12,7 +12,6 @@ require 'active_record' require 'test/unit' -require 'rails' require File.join(File.dirname(__FILE__), '..', 'lib', 'setler.rb') @@ -37,4 +36,4 @@ t.st...
Remove unnecessary require that will be handled by Bundler
diff --git a/http-server.gemspec b/http-server.gemspec index abc1234..def5678 100644 --- a/http-server.gemspec +++ b/http-server.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'http-server' - s.version = '0.2.0' + s.version = '0.2.1' s.summary = 'Simple HTTP Server using http-...
Package version is incremented from 0.2.0 to 0.2.1
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -10,6 +10,6 @@ Rails.application.secrets.freeagent_id, Rails.application.secret...
Fix a bug in FreeAgent configuration when user is not logged in
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -4,6 +4,8 @@ protect_from_forgery with: :exception before_action :configure_permitted...
Switch to custom error pages, located in /public * Design can be changed in related template
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -4,7 +4,7 @@ # For APIs, you may want to use :null_session instead. protect_from_forger...
Fix provider key environment var
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,7 +1,7 @@ class ApplicationController < ActionController::Base # Prevent CSRF attacks ...
Fix for Rails 5 + devise
diff --git a/app/decorators/caffeine/page_decorator.rb b/app/decorators/caffeine/page_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/caffeine/page_decorator.rb +++ b/app/decorators/caffeine/page_decorator.rb @@ -33,16 +33,5 @@ def parents_path object.ancestry_path.tap(&:pop).join('/') e...
Remove useless junk from PageDecorator
diff --git a/app/helpers/wellspring/markdown_helper.rb b/app/helpers/wellspring/markdown_helper.rb index abc1234..def5678 100644 --- a/app/helpers/wellspring/markdown_helper.rb +++ b/app/helpers/wellspring/markdown_helper.rb @@ -4,10 +4,7 @@ include ::Redcarpet::Render::SmartyPants def block_code(code, l...
Remove cache from code blocks (for simplicity)
diff --git a/app/view_adapters/section_view_adapter.rb b/app/view_adapters/section_view_adapter.rb index abc1234..def5678 100644 --- a/app/view_adapters/section_view_adapter.rb +++ b/app/view_adapters/section_view_adapter.rb @@ -4,26 +4,26 @@ extend ActiveModel::Naming include ActiveModel::Conversion - def init...
Rename instance variable `document` -> `section`
diff --git a/lib/worms.rb b/lib/worms.rb index abc1234..def5678 100644 --- a/lib/worms.rb +++ b/lib/worms.rb @@ -3,7 +3,7 @@ require 'rmagick' require 'execjs' -WIDTH, HEIGHT = 1024, 720 +WIDTH, HEIGHT = 1024, 640 NULL_PIXEL = Magick::Pixel.from_color('none')
Change the width of window
diff --git a/lib/agendor/entity.rb b/lib/agendor/entity.rb index abc1234..def5678 100644 --- a/lib/agendor/entity.rb +++ b/lib/agendor/entity.rb @@ -2,23 +2,34 @@ class Entity < Agendor::Base + SUCCESS_RESPONSE_CODE = /2\d\d/ + def create(params) body = process_hash(params) - HTTParty.post(res...
Raise a default response when an error occurs
diff --git a/lib/alavetelitheme.rb b/lib/alavetelitheme.rb index abc1234..def5678 100644 --- a/lib/alavetelitheme.rb +++ b/lib/alavetelitheme.rb @@ -29,4 +29,4 @@ require File.expand_path "../#{patch}", __FILE__ end -$alaveteli_route_extensions << 'config/custom-routes.rb' +$alaveteli_route_extensions << 'custom...
Correct path for custom routes
diff --git a/lib/api-pagination.rb b/lib/api-pagination.rb index abc1234..def5678 100644 --- a/lib/api-pagination.rb +++ b/lib/api-pagination.rb @@ -11,6 +11,7 @@ case ApiPagination.paginator when :kaminari + collection = Kaminari.paginate_array(collection) if collection.is_a?(Array) coll...
Use Kaminari.paginate_array when the collection is an Array Signed-off-by: David Celis <b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@davidcel.is>
diff --git a/week-5/pad-array/my_solution.rb b/week-5/pad-array/my_solution.rb index abc1234..def5678 100644 --- a/week-5/pad-array/my_solution.rb +++ b/week-5/pad-array/my_solution.rb @@ -1,15 +1,12 @@ # Pad an Array -# I worked on this challenge [by myself, with: ] +# I worked on this challenge with Bernice Chua. ...
Add pad array to GitHub
diff --git a/lib/gir_ffi/builders/null_convertor.rb b/lib/gir_ffi/builders/null_convertor.rb index abc1234..def5678 100644 --- a/lib/gir_ffi/builders/null_convertor.rb +++ b/lib/gir_ffi/builders/null_convertor.rb @@ -1,3 +1,4 @@+# Argument convertor that does nothing class GirFFI::Builders::NullConvertor def initia...
Add descriptive comment to NullConvertor
diff --git a/lib/shopify_app/webhooks_controller.rb b/lib/shopify_app/webhooks_controller.rb index abc1234..def5678 100644 --- a/lib/shopify_app/webhooks_controller.rb +++ b/lib/shopify_app/webhooks_controller.rb @@ -19,7 +19,7 @@ def hmac_valid?(data) secret = ShopifyApp.configuration.secret digest =...
Use variable size secure compare
diff --git a/lib/tasks/copycopter_client_tasks.rake b/lib/tasks/copycopter_client_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/copycopter_client_tasks.rake +++ b/lib/tasks/copycopter_client_tasks.rake @@ -4,4 +4,17 @@ CopycopterClient.deploy puts "Successfully marked all blurbs as published." en...
Add rake task for exporting cache
diff --git a/sub_diff.gemspec b/sub_diff.gemspec index abc1234..def5678 100644 --- a/sub_diff.gemspec +++ b/sub_diff.gemspec @@ -1,28 +1,22 @@-# -*- encoding: utf-8 -*- - -lib = File.expand_path('../lib/', __FILE__) -$:.unshift lib unless $:.include?(lib) - -require 'sub_diff/version' -require 'date' +require File.expa...
Update gemspec based off abstract_class gem
diff --git a/lib/github_cli/api.rb b/lib/github_cli/api.rb index abc1234..def5678 100644 --- a/lib/github_cli/api.rb +++ b/lib/github_cli/api.rb @@ -24,14 +24,28 @@ config = GithubCLI.config.data api.oauth_token = config['user.token'] if config['user.token'] - if config['user.login'] && config...
Allow for basic auth setup.
diff --git a/lib/griddler/email.rb b/lib/griddler/email.rb index abc1234..def5678 100644 --- a/lib/griddler/email.rb +++ b/lib/griddler/email.rb @@ -7,9 +7,11 @@ if params[:to] @to = extract_address(params[:to], config.to) end + if params[:from] @from = extract_address(params[:from], :email)...
Add some whitespace for readability
diff --git a/lib/heroku_san/api.rb b/lib/heroku_san/api.rb index abc1234..def5678 100644 --- a/lib/heroku_san/api.rb +++ b/lib/heroku_san/api.rb @@ -9,7 +9,7 @@ def sh(app, *command) preflight_check_for_cli - cmd = (command + ['--app', app]).compact + cmd = (command + ['--app', app, "--exit-code"...
Add flag for exit code
diff --git a/lib/rohbau/runtime.rb b/lib/rohbau/runtime.rb index abc1234..def5678 100644 --- a/lib/rohbau/runtime.rb +++ b/lib/rohbau/runtime.rb @@ -42,6 +42,15 @@ end end + def notify_plugins(message, *args) + self.class.plugins.each do |name, _| + plugin = public_send(name) + if plu...
Implement a notifier method on Runtime
diff --git a/lib/visdiff/config.rb b/lib/visdiff/config.rb index abc1234..def5678 100644 --- a/lib/visdiff/config.rb +++ b/lib/visdiff/config.rb @@ -2,7 +2,7 @@ module Visdiff class Config - attr_accessor :base_url, :api_key + attr_accessor :base_url, :api_key, :debug def initialize end @@ -12,6 ...
Add debug flag to turn on faraday logging
diff --git a/test/integration/test_multibyte_queries.rb b/test/integration/test_multibyte_queries.rb index abc1234..def5678 100644 --- a/test/integration/test_multibyte_queries.rb +++ b/test/integration/test_multibyte_queries.rb @@ -10,6 +10,7 @@ def test_posts_multibyte_queries_properly ret = clients.map do |cl...
Work around Ox not parsing multibyte characters
diff --git a/libraries/matchers.rb b/libraries/matchers.rb index abc1234..def5678 100644 --- a/libraries/matchers.rb +++ b/libraries/matchers.rb @@ -32,4 +32,12 @@ def add_php_pear_channel(resource_name) ChefSpec::Matchers::ResourceMatcher.new(:php_pear_channel, :add, resource_name) end + + ChefSpec.define_m...
Add matcher for php_fpm_pool LWRP
diff --git a/lib/cannon/route.rb b/lib/cannon/route.rb index abc1234..def5678 100644 --- a/lib/cannon/route.rb +++ b/lib/cannon/route.rb @@ -44,17 +44,26 @@ def initialize(app, action:, callback:) @app, @action, @callback = app, action, callback + end - callback do - @callback.run(@request...
Fix bug with RouteAction so that RouteActions will run multiple times correctly
diff --git a/lib/forem/engine.rb b/lib/forem/engine.rb index abc1234..def5678 100644 --- a/lib/forem/engine.rb +++ b/lib/forem/engine.rb @@ -23,7 +23,7 @@ end require 'simple_form' -require 'emoji/railtie' +require 'emoji' require 'select2-rails' # We need one of the two pagination engines loaded by this point.
Remove deprecation warning for emoji
diff --git a/Casks/font-fira-mono.rb b/Casks/font-fira-mono.rb index abc1234..def5678 100644 --- a/Casks/font-fira-mono.rb +++ b/Casks/font-fira-mono.rb @@ -1,8 +1,8 @@ class FontFiraMono < Cask - url 'http://dev.carrois.com/wordpress/wp-content/uploads/downloads/fira_3105/FiraMono3105.zip' + url 'http://dev.carrois....
Update Fira Mono to 3.106
diff --git a/Casks/mysqlworkbench.rb b/Casks/mysqlworkbench.rb index abc1234..def5678 100644 --- a/Casks/mysqlworkbench.rb +++ b/Casks/mysqlworkbench.rb @@ -1,6 +1,6 @@ cask :v1 => 'mysqlworkbench' do - version '6.3.3' - sha256 '2ba28b163f88bd6d3a43df8236f351bc43d8fe3d21936424fcb395bb9d56e1a6' + version '6.3.4' + s...
Update MySQL Workbench to 6.3.4
diff --git a/recipes/_nginx.rb b/recipes/_nginx.rb index abc1234..def5678 100644 --- a/recipes/_nginx.rb +++ b/recipes/_nginx.rb @@ -1,7 +1,7 @@ include_recipe 'nginx_server::default' nginx_server_vhost 'yumserver' do - listen [{'ipaddress': '0.0.0.0'}] + listen [{'ipaddress' => '0.0.0.0'}] server_name [node['h...
Fix hash syntax in nginx syntax
diff --git a/lib/pycall/tuple.rb b/lib/pycall/tuple.rb index abc1234..def5678 100644 --- a/lib/pycall/tuple.rb +++ b/lib/pycall/tuple.rb @@ -38,5 +38,17 @@ value = Conversions.from_ruby(value) LibPython.PyTuple_SetItem(__pyobj__, index, value) end + + def to_a + [].tap do |ary| + i, n =...
Support to_a and to_ary in PyCall::Tuple
diff --git a/lib/netsuite/records/item_fulfillment_package_list.rb b/lib/netsuite/records/item_fulfillment_package_list.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/item_fulfillment_package_list.rb +++ b/lib/netsuite/records/item_fulfillment_package_list.rb @@ -5,23 +5,23 @@ include Support::Record...
Fix attributes :key name on ItemFulfillmentPackageList
diff --git a/lib/redimap/base.rb b/lib/redimap/base.rb index abc1234..def5678 100644 --- a/lib/redimap/base.rb +++ b/lib/redimap/base.rb @@ -5,7 +5,7 @@ end def self.configure - yield @config + yield self.config end def self.queue_new_mailboxes_uids
Fix .configure use of @config instead of .config. Otherwise, attempting to use `.configure` without having called `.config` first will fail, as `@config` won't exist.
diff --git a/config/initializers/tire.rb b/config/initializers/tire.rb index abc1234..def5678 100644 --- a/config/initializers/tire.rb +++ b/config/initializers/tire.rb @@ -1,11 +1,4 @@-if Rails.env.production? - Tire.configure { - url "http://support.cluster:9200" - logger Rails.root.join("log/tire_#{Rails.env}....
Remove reference to legacy support.cluster machine This initializer is now specified in alphagov-deployment, so it is only used here in development now. We are trying to encourage apps to move away from support.cluster.
diff --git a/db/migrate/20160815160730_create_functions.rb b/db/migrate/20160815160730_create_functions.rb index abc1234..def5678 100644 --- a/db/migrate/20160815160730_create_functions.rb +++ b/db/migrate/20160815160730_create_functions.rb @@ -3,8 +3,8 @@ create_table :functions do |t| t.belongs_to :user, f...
Change duration time for functions to date
diff --git a/resources/cask.rb b/resources/cask.rb index abc1234..def5678 100644 --- a/resources/cask.rb +++ b/resources/cask.rb @@ -24,7 +24,6 @@ alias_method :action_uncask, :action_uninstall def casked? - shell_out('/usr/local/bin/brew cask list 2>/dev/null').stdout.split.include?(name) - shell_out('/us...
Remove double shellout from a bad merge Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/ethos/entity.rb b/lib/ethos/entity.rb index abc1234..def5678 100644 --- a/lib/ethos/entity.rb +++ b/lib/ethos/entity.rb @@ -1,7 +1,7 @@ module Ethos module Entity module ClassMethods - def attribute(attr, options = {}) + def attribute(attr, default: nil) reader = :"#{attr}" ...
Use a keyword argument instead of an options hash.
diff --git a/lib/myhub/github.rb b/lib/myhub/github.rb index abc1234..def5678 100644 --- a/lib/myhub/github.rb +++ b/lib/myhub/github.rb @@ -4,5 +4,11 @@ base_uri "https://api.github.com" # Your code here too! + def initialize + @headers = { + "Authorization" => "token #{ENV["AUTH_TOKEN"]}", ...
Add initializer to pull auth token from ENV.
diff --git a/spec/integration/fog/login_spec.rb b/spec/integration/fog/login_spec.rb index abc1234..def5678 100644 --- a/spec/integration/fog/login_spec.rb +++ b/spec/integration/fog/login_spec.rb @@ -1,16 +1,13 @@ require 'spec_helper' describe Vcloud::Fog::Login do - let!(:mock_env) { ENV.clone } - before(:eac...
Replace ENV.clone mock with empty hash ENV.clone only performs a shallow-copy of the ENV object. Which means that `mock_env.clear` wipes the real ENV object and affects other tests that run after this. We didn't notice it because this is currently the last test picked up by `rake integration`, but when we attempted t...
diff --git a/build-scripts/emscripten/config.rb b/build-scripts/emscripten/config.rb index abc1234..def5678 100644 --- a/build-scripts/emscripten/config.rb +++ b/build-scripts/emscripten/config.rb @@ -1,23 +1,23 @@ #!/usr/bin/false NAME = "emscripten" -VERSION = "1.38.11" +VERSION = "1.38.19" RELEASE = "1" FILES...
Update build scripts for Emscripten 1.38.19
diff --git a/lib/buffet/slave.rb b/lib/buffet/slave.rb index abc1234..def5678 100644 --- a/lib/buffet/slave.rb +++ b/lib/buffet/slave.rb @@ -9,7 +9,8 @@ end def rsync src, dest - Buffet.run! 'rsync', '-aqz', '--delete', rsync_exclude_flags, + Buffet.run! 'rsync', '-aqz', '--delete', + ...
Delete excluded project files on remote While we weren't syncing files specified in the filter file, we were also not deleting any old copies of these files if they already existed on the remote. This could potentially have been bad if the log files grew to exceptionally large sizes over time. Adding the --delete-exc...
diff --git a/lib/quiet_opener.rb b/lib/quiet_opener.rb index abc1234..def5678 100644 --- a/lib/quiet_opener.rb +++ b/lib/quiet_opener.rb @@ -5,7 +5,7 @@ begin result = open(url).read.strip rescue OpenURI::HTTPError, SocketError, Errno::ETIMEDOUT, Errno::ECONNREFUSED, Errno::EHOSTUNREACH - logg...
Use explicit `Rails.logger` (as we're not inheriting from ActiveRecord)
diff --git a/lib/fog/openstack/requests/volume/list_snapshots.rb b/lib/fog/openstack/requests/volume/list_snapshots.rb index abc1234..def5678 100644 --- a/lib/fog/openstack/requests/volume/list_snapshots.rb +++ b/lib/fog/openstack/requests/volume/list_snapshots.rb @@ -2,18 +2,19 @@ module Volume class OpenStack ...
Allow passing query options to snapshots endpoint.
diff --git a/utils/wrapper.rb b/utils/wrapper.rb index abc1234..def5678 100644 --- a/utils/wrapper.rb +++ b/utils/wrapper.rb @@ -27,6 +27,12 @@ errors.each {|error| STDERR.puts " * #{error}"} STDERR.puts end + + def handle_invalid_json(line) + STDERR.puts + STDERR.puts "The following line is invalid ...
Handle invalid JSON produced by scraper
diff --git a/ComponentKit.podspec b/ComponentKit.podspec index abc1234..def5678 100644 --- a/ComponentKit.podspec +++ b/ComponentKit.podspec @@ -1,16 +1,14 @@ Pod::Spec.new do |s| - s.name = "ComponentKit" - s.version = "0.15" - s.summary = "A React-inspired view framework for iOS" - s.homepage = "https://component...
Add tvOS as a deployment target to the Podspec
diff --git a/lib/dotties-core.rb b/lib/dotties-core.rb index abc1234..def5678 100644 --- a/lib/dotties-core.rb +++ b/lib/dotties-core.rb @@ -8,6 +8,7 @@ require_relative './dotties-core/adapters/require' require_relative './dotties-core/adapters/symlink_first' +require_relative './dotties-core/formats/bin' require_...
Allow bin directory to be symlinked.
diff --git a/scientist.gemspec b/scientist.gemspec index abc1234..def5678 100644 --- a/scientist.gemspec +++ b/scientist.gemspec @@ -5,7 +5,7 @@ gem.description = "A Ruby library for carefully refactoring critical paths" gem.version = Scientist::VERSION gem.authors = ["GitHub Open Source", "John B...
Use a working email address for me Otherwise technoweenie will get my spam.
diff --git a/lib/what/monitor.rb b/lib/what/monitor.rb index abc1234..def5678 100644 --- a/lib/what/monitor.rb +++ b/lib/what/monitor.rb @@ -39,6 +39,8 @@ if status["error"] status["failures"] = mod[:failures] + puts "Error in module:\n#{YAML.dump(status)}" + if mod[:failures] <...
Add logging on module error
diff --git a/lib/window_rails.rb b/lib/window_rails.rb index abc1234..def5678 100644 --- a/lib/window_rails.rb +++ b/lib/window_rails.rb @@ -1,5 +1,5 @@ require 'window_rails/version' if(defined?(Rails)) - require File.join(File.dirname(__FILE__), '..', 'init') + require 'window_rails/engine' end
Load the engine if we are in Rails
diff --git a/nilify_blanks.gemspec b/nilify_blanks.gemspec index abc1234..def5678 100644 --- a/nilify_blanks.gemspec +++ b/nilify_blanks.gemspec @@ -5,6 +5,7 @@ Gem::Specification.new do |s| s.name = "nilify_blanks" s.version = NilifyBlanks::VERSION + s.license = 'MIT' s.author = "Ben Hugh...
Add MIT license to the gemspec.
diff --git a/command_line/dash_encoding_spec.rb b/command_line/dash_encoding_spec.rb index abc1234..def5678 100644 --- a/command_line/dash_encoding_spec.rb +++ b/command_line/dash_encoding_spec.rb @@ -1,29 +1,30 @@ require_relative '../spec_helper' -describe 'The --encoding command line option' do +describe "The --en...
Fix the --encoding spec to use an ASCII-compatible encoding * Patch based on @MSP-Greg fix in https://github.com/MSP-Greg/ruby/commit/91e8e2abab0576b5e04066a2d19962d241a3f080
diff --git a/simplecov.gemspec b/simplecov.gemspec index abc1234..def5678 100644 --- a/simplecov.gemspec +++ b/simplecov.gemspec @@ -1,4 +1,3 @@-# encoding: utf-8 $LOAD_PATH.push File.expand_path("../lib", __FILE__) require "simplecov/version" @@ -14,9 +13,12 @@ gem.license = "MIT" gem.required_ruby_vers...
Add bundler as a development dependency
diff --git a/UITableViewDataSource-RACExtensions.podspec b/UITableViewDataSource-RACExtensions.podspec index abc1234..def5678 100644 --- a/UITableViewDataSource-RACExtensions.podspec +++ b/UITableViewDataSource-RACExtensions.podspec @@ -21,9 +21,7 @@ s.author = { "Michael Avila" => "me@michaelavila.com" } ...
Configure platform to be iOS 5.0
diff --git a/rspec-composable_json_matchers.gemspec b/rspec-composable_json_matchers.gemspec index abc1234..def5678 100644 --- a/rspec-composable_json_matchers.gemspec +++ b/rspec-composable_json_matchers.gemspec @@ -18,6 +18,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.requir...
Add json ~> 2.0 dependency for conformance with RFC 7159
diff --git a/spec/feed_spec.rb b/spec/feed_spec.rb index abc1234..def5678 100644 --- a/spec/feed_spec.rb +++ b/spec/feed_spec.rb @@ -17,7 +17,7 @@ expect { Stream::Feed.new(nil, "feed-slug", "user_id", "") }.to raise_error Stream::StreamInputData end - it "should refuse feed_slug with underscores" do - exp...
Fix spec for underscore support for feed slugs
diff --git a/lib/contributors/servises/all_contributors.rb b/lib/contributors/servises/all_contributors.rb index abc1234..def5678 100644 --- a/lib/contributors/servises/all_contributors.rb +++ b/lib/contributors/servises/all_contributors.rb @@ -0,0 +1,33 @@+require_relative '../../http_request' + +class AllContributors...
Create simple service which get all hanami contributors
diff --git a/spec/controllers/course/assessment/controller_spec.rb b/spec/controllers/course/assessment/controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/course/assessment/controller_spec.rb +++ b/spec/controllers/course/assessment/controller_spec.rb @@ -4,7 +4,7 @@ RSpec.describe Course::Assessme...
Replace deprecated render nothing: true
diff --git a/parsedecision.gemspec b/parsedecision.gemspec index abc1234..def5678 100644 --- a/parsedecision.gemspec +++ b/parsedecision.gemspec @@ -21,6 +21,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" - #spec.add_runtime_dependency "win32ole" + spec.add_deve...
Add rspec-given and pry gems to dev list
diff --git a/recipes/_user.rb b/recipes/_user.rb index abc1234..def5678 100644 --- a/recipes/_user.rb +++ b/recipes/_user.rb @@ -26,7 +26,7 @@ end authorized_keys_file = "#{home_dir}/.ssh/authorized_keys" -if File.exist?(authorized_keys_file) +if File.size?(authorized_keys_file) ruby_block "Add Rolling Restart Us...
Switch to overriding the authorized_keys file if the file is missing or empty
diff --git a/app/models/concerns/meta_tags_parser.rb b/app/models/concerns/meta_tags_parser.rb index abc1234..def5678 100644 --- a/app/models/concerns/meta_tags_parser.rb +++ b/app/models/concerns/meta_tags_parser.rb @@ -6,6 +6,8 @@ self.description, self.title, self.image = read_content_from_page('description', 't...
Add another exception handling (even more frequent)
diff --git a/app/observers/merge_request_observer.rb b/app/observers/merge_request_observer.rb index abc1234..def5678 100644 --- a/app/observers/merge_request_observer.rb +++ b/app/observers/merge_request_observer.rb @@ -21,11 +21,11 @@ protected def send_reassigned_email(merge_request) - recipients_ids = m...
Clean up indenting in new observer.
diff --git a/Casks/speedtao.rb b/Casks/speedtao.rb index abc1234..def5678 100644 --- a/Casks/speedtao.rb +++ b/Casks/speedtao.rb @@ -2,6 +2,6 @@ url 'http://www.speedtao.net/download/SpeedTao_Beta26.dmg' homepage 'http://www.speedtao.net/' version 'Beta26' - sha256 'c8864775c92f2a92914cdba6b70d67998c484fa3f798...
Fix checksum in SpeedTao.app Cask
diff --git a/lib/msgr/binding.rb b/lib/msgr/binding.rb index abc1234..def5678 100644 --- a/lib/msgr/binding.rb +++ b/lib/msgr/binding.rb @@ -14,6 +14,9 @@ @subscription = queue.subscribe ack: true, &method(:call) end + # Called from Bunny Thread Pool. Will create message object from + # provided bunn...
Add short descriptions to Binding.
diff --git a/lib/nidyx/reader.rb b/lib/nidyx/reader.rb index abc1234..def5678 100644 --- a/lib/nidyx/reader.rb +++ b/lib/nidyx/reader.rb @@ -38,7 +38,8 @@ # @return [Boolean] true if the schema is empty def empty_schema?(schema) props = schema[PROPERTIES_KEY] - !props || props.empty? + items =...
Make empty schema error less strict The empty schema error was being thrown whenever there were no properties in the top level object. This changes the error to happen if there are no properties or items (in the case that the response is an array as the top level object).
diff --git a/lib/quality/flay.rb b/lib/quality/flay.rb index abc1234..def5678 100644 --- a/lib/quality/flay.rb +++ b/lib/quality/flay.rb @@ -1,8 +1,9 @@ module Quality module Flay + + private + def quality_flay - private - ratchet_quality_cmd('flay', args: "-m 75 -t 999...
Fix accidental line location swap of 'private'
diff --git a/test/integration/default/serverspec/default_spec.rb b/test/integration/default/serverspec/default_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/default_spec.rb +++ b/test/integration/default/serverspec/default_spec.rb @@ -0,0 +1,22 @@+require 'serverspec' +require 'pathnam...
Add integration test coverage for default suite Nothing fancy, this serverspec test verifies: * GCC is installed and available. * The GNU flavor of Make is installed and available.
diff --git a/app/controllers/presentations_controller.rb b/app/controllers/presentations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/presentations_controller.rb +++ b/app/controllers/presentations_controller.rb @@ -1,10 +1,6 @@ class PresentationsController < AssetsController def show - @p...
Remove the index action from the presentations controller
diff --git a/app/controllers/registrations_controller.rb b/app/controllers/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/registrations_controller.rb +++ b/app/controllers/registrations_controller.rb @@ -0,0 +1,13 @@+class RegistrationsController < Devise::RegistrationsController + + ...
Create a registration controller for customize devise permit parameters
diff --git a/lib/vagrant-list.rb b/lib/vagrant-list.rb index abc1234..def5678 100644 --- a/lib/vagrant-list.rb +++ b/lib/vagrant-list.rb @@ -7,9 +7,17 @@ module List class All < ::Vagrant::Command::Base def execute - names = Driver::VirtualBox.new(nil).read_vms + all = Driver::VirtualBox.new...
Extend vagrant list command to print both All vms, and running vms
diff --git a/qa/qa/scenario/gitlab/admin/hashed_storage.rb b/qa/qa/scenario/gitlab/admin/hashed_storage.rb index abc1234..def5678 100644 --- a/qa/qa/scenario/gitlab/admin/hashed_storage.rb +++ b/qa/qa/scenario/gitlab/admin/hashed_storage.rb @@ -6,7 +6,6 @@ def perform(*traits) raise ArgumentError...
Remove unused page from hashed storage QA scenario
diff --git a/spec/defines/homebrew__formula_spec.rb b/spec/defines/homebrew__formula_spec.rb index abc1234..def5678 100644 --- a/spec/defines/homebrew__formula_spec.rb +++ b/spec/defines/homebrew__formula_spec.rb @@ -4,7 +4,7 @@ let(:facts) { default_test_facts } let(:title) { "clojure" } - let(:tapdir) { "#{fa...
Fix spec path to include Homebrew path
diff --git a/spec/faraday/params_encoder_spec.rb b/spec/faraday/params_encoder_spec.rb index abc1234..def5678 100644 --- a/spec/faraday/params_encoder_spec.rb +++ b/spec/faraday/params_encoder_spec.rb @@ -0,0 +1,24 @@+describe Mrkt::Faraday::ParamsEncoder do + describe '.encode' do + let(:params) do + { + ...
Add tests for the ParamsEncoder
diff --git a/test/integration/default/serverspec/publisher_spec.rb b/test/integration/default/serverspec/publisher_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/serverspec/publisher_spec.rb +++ b/test/integration/default/serverspec/publisher_spec.rb @@ -5,7 +5,7 @@ # See recipes/test_publisher ...
Correct test fixtrue publisher name
diff --git a/log-courier.gemspec b/log-courier.gemspec index abc1234..def5678 100644 --- a/log-courier.gemspec +++ b/log-courier.gemspec @@ -11,7 +11,7 @@ gem.require_paths = ['lib'] gem.files = %w( lib/log-courier/server.rb - lib/log-courier/server_tls.rb + lib/log-courier/server_tcp.rb...
Use doctoc to produce tables of contents
diff --git a/akephalos.gemspec b/akephalos.gemspec index abc1234..def5678 100644 --- a/akephalos.gemspec +++ b/akephalos.gemspec @@ -24,7 +24,7 @@ end s.add_development_dependency "sinatra" - s.add_development_dependency "rspec", "1.30" + s.add_development_dependency "rspec", "1.3.0" s.files = Dir....
Fix rspec dependency in gemspec
diff --git a/spec/dummy/config/environments/development.rb b/spec/dummy/config/environments/development.rb index abc1234..def5678 100644 --- a/spec/dummy/config/environments/development.rb +++ b/spec/dummy/config/environments/development.rb @@ -27,4 +27,6 @@ # Expands the lines which load the assets config.asset...
Add test host to spec/dummy initializer
diff --git a/spec/support/pages/overlays/upload_figures.rb b/spec/support/pages/overlays/upload_figures.rb index abc1234..def5678 100644 --- a/spec/support/pages/overlays/upload_figures.rb +++ b/spec/support/pages/overlays/upload_figures.rb @@ -1,6 +1,6 @@ class UploadFiguresOverlay < CardOverlay def has_image? imag...
Make has_image? less brittle (dont check entire path)
diff --git a/em-websocket.gemspec b/em-websocket.gemspec index abc1234..def5678 100644 --- a/em-websocket.gemspec +++ b/em-websocket.gemspec @@ -19,5 +19,5 @@ s.require_paths = ["lib"] s.add_dependency("eventmachine", ">= 0.12.9") - s.add_dependency("http_parser.rb", '>= 0.6.1') + s.add_dependency("http_parser...
Allow newer versions of http_parser until v1.0.0
diff --git a/formatter/slow_hand_cuke.rb b/formatter/slow_hand_cuke.rb index abc1234..def5678 100644 --- a/formatter/slow_hand_cuke.rb +++ b/formatter/slow_hand_cuke.rb @@ -2,21 +2,13 @@ module Formatter class SlowHandCuke < Cucumber::Formatter::Pretty def before_step( step ) - print_ansi_code 's' # save ...
Replace fancy-pants ansi codes with simple carriage-return (doh!)
diff --git a/gems.gemspec b/gems.gemspec index abc1234..def5678 100644 --- a/gems.gemspec +++ b/gems.gemspec @@ -2,12 +2,12 @@ require File.expand_path('../lib/gems/version', __FILE__) Gem::Specification.new do |gem| - gem.add_development_dependency 'rake', '~> 0.9' - gem.add_development_dependency 'rdiscount', '~...
Use maruku instead of rdiscount for compatibility with JRuby and Rubinius in 1.9 mode
diff --git a/redic-cluster.gemspec b/redic-cluster.gemspec index abc1234..def5678 100644 --- a/redic-cluster.gemspec +++ b/redic-cluster.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = "redic-cluster" - s.version = "0.0.4" + s.version = "0.0.5" s.summary ...
Add dependency and bump version
diff --git a/request_store.gemspec b/request_store.gemspec index abc1234..def5678 100644 --- a/request_store.gemspec +++ b/request_store.gemspec @@ -16,4 +16,7 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_...
Add minitest so we work on all rubies.
diff --git a/mini_magick.gemspec b/mini_magick.gemspec index abc1234..def5678 100644 --- a/mini_magick.gemspec +++ b/mini_magick.gemspec @@ -8,11 +8,12 @@ s.version = MiniMagick::VERSION s.platform = Gem::Platform::RUBY s.summary = "Manipulate images with minimal use of memory via ImageMagick / Graph...
Add license to gemspec and update authors
diff --git a/lib/sinatra/dynamicmatic.rb b/lib/sinatra/dynamicmatic.rb index abc1234..def5678 100644 --- a/lib/sinatra/dynamicmatic.rb +++ b/lib/sinatra/dynamicmatic.rb @@ -5,6 +5,8 @@ module DynamicMatic def self.registered(app) app.set :compile_on_start, true + + app.set :lock, true app.set ...
Set the :lock option to true.
diff --git a/lib/spree_temando/engine.rb b/lib/spree_temando/engine.rb index abc1234..def5678 100644 --- a/lib/spree_temando/engine.rb +++ b/lib/spree_temando/engine.rb @@ -12,7 +12,7 @@ end initializer "spree_temando.register.shipping_calculators" do |app| - app.config.spree.calculators.add_class(Spree...
Fix incorrect call to register shipping calculator
diff --git a/test/integration/default/squid_spec.rb b/test/integration/default/squid_spec.rb index abc1234..def5678 100644 --- a/test/integration/default/squid_spec.rb +++ b/test/integration/default/squid_spec.rb @@ -1,5 +1,3 @@-describe 'Squid server' do - it 'is listening on port 3128' do - expect(port(3128)).to ...
Fix the spec to actually check the port Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/tests/test_mass_assign_disable.rb b/test/tests/test_mass_assign_disable.rb index abc1234..def5678 100644 --- a/test/tests/test_mass_assign_disable.rb +++ b/test/tests/test_mass_assign_disable.rb @@ -36,4 +36,30 @@ end RUBY end + + def test_strong_parameters_in_initializer + init = "c...
Add test for adding strong_parameters globally
diff --git a/spec/spec_helpers/fake_capture3.rb b/spec/spec_helpers/fake_capture3.rb index abc1234..def5678 100644 --- a/spec/spec_helpers/fake_capture3.rb +++ b/spec/spec_helpers/fake_capture3.rb @@ -27,7 +27,7 @@ private def return_values(command) - filename = command.gsub(' ', '_') + filename = command....
Support slashes in FakeCapture3 commands
diff --git a/lib/asset_manager/engine.rb b/lib/asset_manager/engine.rb index abc1234..def5678 100644 --- a/lib/asset_manager/engine.rb +++ b/lib/asset_manager/engine.rb @@ -16,8 +16,8 @@ include AssetManager::AssetInstancesHelper end ActiveSupport.on_load :active_record do - Formtastic::Inp...
Check if simple_form and formtastic is defined
diff --git a/lib/checks/check_mail_to.rb b/lib/checks/check_mail_to.rb index abc1234..def5678 100644 --- a/lib/checks/check_mail_to.rb +++ b/lib/checks/check_mail_to.rb @@ -0,0 +1,50 @@+require 'checks/base_check' +require 'processors/lib/find_call' + +#Check for cross site scripting vulnerability in mail_to :encode =>...
Add check for mail_to vulnerability
diff --git a/lib/google/places/client.rb b/lib/google/places/client.rb index abc1234..def5678 100644 --- a/lib/google/places/client.rb +++ b/lib/google/places/client.rb @@ -22,6 +22,14 @@ ) end + def query_autocomplete(input, options = {}) + options = options.with_indifferent_access + ...
Add Query Autocomplete API support
diff --git a/lib/hets/prove/evaluator.rb b/lib/hets/prove/evaluator.rb index abc1234..def5678 100644 --- a/lib/hets/prove/evaluator.rb +++ b/lib/hets/prove/evaluator.rb @@ -37,6 +37,8 @@ self.now = Time.now end + # The caller needs those methods to exists, but we don't need the + # functional...
Add comment on bad class structure.
diff --git a/lib/jstree_rails/viewers.rb b/lib/jstree_rails/viewers.rb index abc1234..def5678 100644 --- a/lib/jstree_rails/viewers.rb +++ b/lib/jstree_rails/viewers.rb @@ -21,7 +21,8 @@ :type => link_args.delete(:method) || 'post', :data => { :data => RawJS.new("jQuery(#{format_type_to_js(f...
Set type for ajax request
diff --git a/lib/shortcode_googledocs.rb b/lib/shortcode_googledocs.rb index abc1234..def5678 100644 --- a/lib/shortcode_googledocs.rb +++ b/lib/shortcode_googledocs.rb @@ -1,23 +1,23 @@ require 'shortcodes/handler' module Shortcodes - class DocumentCloud < Handler + class GoogleDocs < Handler def url ...
Fix class name of Google Docs shortcode, and fix dimension handling
diff --git a/lib/tasks/create_index.rake b/lib/tasks/create_index.rake index abc1234..def5678 100644 --- a/lib/tasks/create_index.rake +++ b/lib/tasks/create_index.rake @@ -6,8 +6,6 @@ index: Spree::ElasticsearchSettings.index, body: { settings: { - number_of_shards: 1, - ...
Use default settings for shards and replicas (5 shards)
diff --git a/lib/tasks/data_cleanup.rake b/lib/tasks/data_cleanup.rake index abc1234..def5678 100644 --- a/lib/tasks/data_cleanup.rake +++ b/lib/tasks/data_cleanup.rake @@ -0,0 +1,48 @@+namespace :data_cleanup do + desc "Removes drafts for specialist publisher documents if they're duplicates" + task remove_substituti...
Add rake task for cleaning up substitution data. In prep for https://github.com/alphagov/publishing-api/pull/405, we need to remove all unpublishings of type "substitution". This is due to some inconsistent data where some draft content items where unpublished and thus impossible to tell apart from previously live co...
diff --git a/lib/tasks/link_checker.rake b/lib/tasks/link_checker.rake index abc1234..def5678 100644 --- a/lib/tasks/link_checker.rake +++ b/lib/tasks/link_checker.rake @@ -0,0 +1,6 @@+namespace :link_checker do + task delete_old_report_links: :environment do + count = LinkCheckerApiReport::Link.deletable.delete_al...
Add a rake task for deleting old report links This table has the potential to grow indefinitely, so we will configure this task to run periodically so it remains a good size. It also always us to delete the links using Jenkins so we have better visibility on the job.
diff --git a/lib/travel_advice_alerts.rb b/lib/travel_advice_alerts.rb index abc1234..def5678 100644 --- a/lib/travel_advice_alerts.rb +++ b/lib/travel_advice_alerts.rb @@ -33,7 +33,7 @@ end def updated_recently? - Time.now - 172800 <= updated_at && updated_at <= Time.now - 3600 + Time.now - 172800...
Reduce threshold for recent travel advice The current behaviour is that the travel advice must be at least an hour old before we start alerting on it. 15 minutes is probably a more reasonable threshold. Users should have received emails within 15 minutes of the advice being published.
diff --git a/lib/webrat_headers_patch.rb b/lib/webrat_headers_patch.rb index abc1234..def5678 100644 --- a/lib/webrat_headers_patch.rb +++ b/lib/webrat_headers_patch.rb @@ -12,6 +12,31 @@ @response = mechanize.get({url: url, headers: headers}, data) end + # Replace Webrat version to allow headers (like #get)....
Add header support for POST method as well
diff --git a/ext/binyo/extconf.rb b/ext/binyo/extconf.rb index abc1234..def5678 100644 --- a/ext/binyo/extconf.rb +++ b/ext/binyo/extconf.rb @@ -50,7 +50,7 @@ message "=== Checking Ruby features ===\n" have_header("ruby/io.h") - +have_func("rb_io_check_byte_readable") create_header create_makefile("binyo")
Check for presence of rb_check_io_byte_readable