diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/week-6/die-2/my_solution.rb b/week-6/die-2/my_solution.rb index abc1234..def5678 100644 --- a/week-6/die-2/my_solution.rb +++ b/week-6/die-2/my_solution.rb @@ -6,33 +6,90 @@ # Pseudocode -# Input: -# Output: -# Steps: +# Input: array of strings representing sides of die + +# Output: sides should return...
Add refactored solution and reflection
diff --git a/spec/client_spec.rb b/spec/client_spec.rb index abc1234..def5678 100644 --- a/spec/client_spec.rb +++ b/spec/client_spec.rb @@ -22,12 +22,22 @@ faraday.use MiddlewareMiddle end - expect(connection.builder.handlers).to eq [ - MiddlewareStart, - MiddlewareMiddle, - ...
Fix tests so they pass on Faraday 1.0
diff --git a/app/controllers/admin/stats_controller.rb b/app/controllers/admin/stats_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/stats_controller.rb +++ b/app/controllers/admin/stats_controller.rb @@ -18,7 +18,7 @@ end def stats_for(klass) - period = 3.days.ago.beginning_of_day + ...
Load less data on the stats page plz
diff --git a/test/ts_bud.rb b/test/ts_bud.rb index abc1234..def5678 100644 --- a/test/ts_bud.rb +++ b/test/ts_bud.rb @@ -1,4 +1,9 @@ require 'test_common' + +# In "quick mode", don't bother running some of the more expensive tests +if ARGV.first and ARGV.first.downcase == "quick" + $quick_mode = true +end require '...
Add a "quick" mode to test suite. In quick mode, don't bother running some of the more expensive tests. On my machine, this reduces the test runtime from ~90 seconds to ~60 seconds. Still way too slow, but marginally better.
diff --git a/app/controllers/api/v1/base_controller.rb b/app/controllers/api/v1/base_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/base_controller.rb +++ b/app/controllers/api/v1/base_controller.rb @@ -35,7 +35,7 @@ end def return_error(exception) - render json: { message: "We are s...
Return status 500 when error happens
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -28,7 +28,12 @@ def exhibition_is_set set_exhibition #First try to set the exhibiti...
Change exhibition is set calculation
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,10 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want ...
Add redirection from gitcuss.com to gitcussion.com
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,8 +2,6 @@ require 'bundler/setup' require 'rspec' require_relative '../lib/doc_builder_testing.rb' - -RSpec.configure { |c| c.fail_fast = true } def builder @builder ||=...
Remove fail fast since problems It's not very usefull, it's better to get all failed test while executing parallel_rspec
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,18 +1,10 @@ require 'puppetlabs_spec_helper/module_spec_helper' require 'shared_examples' - -require 'puppet-openstack_spec_helper/defaults' -require 'rspec-puppet-facts' -incl...
Move rspec-puppet-facts to spec helper This change updates the module to use the rspec-puppet-facts as defined in the puppet-openstack_spec_helper. Change-Id: I6df0fb713772b68249eb38051f3a275e9d75336f
diff --git a/test_script.rb b/test_script.rb index abc1234..def5678 100644 --- a/test_script.rb +++ b/test_script.rb @@ -13,7 +13,7 @@ items = klass.find_all(query: 'rest-client', status: :complete) puts "Searching #{klass.to_s} on query => 'rest-client' returns #{items}" - media_id = YAML.load(File.open(FILENA...
Read media_id from Helix::Base::CREDENTIALS, rather than re-parsing YAML
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -14,8 +14,10 @@ def current_user=(user) if user + @current_user = user ...
Make sure that @current_user is also set and cleared
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,11 +2,16 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want...
Add Class IpAddressRejected and Forbidden
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,6 +13,9 @@ include BackendHelpers include ResponseHelpers include FileHelpers + + conf.filter_run focus: true + conf.run_all_when_everything_filtered = true end R...
Enable focussing of tests in rspec [#126851165] Signed-off-by: Steffen Uhlig <f82265073a33b8214db2ab356bc472f35869736c@de.ibm.com>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,13 @@+require "capybara" +require "capybara/rspec" # Required here instead of in rspec_spec to avoid RSpec deprecation warning +require "capybara/spec/test_app" +require "c...
Set up to use capybara spec support in tests.
diff --git a/app/controllers/transferred_controller.rb b/app/controllers/transferred_controller.rb index abc1234..def5678 100644 --- a/app/controllers/transferred_controller.rb +++ b/app/controllers/transferred_controller.rb @@ -9,7 +9,7 @@ @pq = PQ.new(pq_params) @pq.transferred = true @pq.raising_member...
Fix Progress id bug on New Transfers
diff --git a/spec/support/vcr.rb b/spec/support/vcr.rb index abc1234..def5678 100644 --- a/spec/support/vcr.rb +++ b/spec/support/vcr.rb @@ -1,4 +1,11 @@ require 'vcr' +require 'webmock/rspec' + +WebMock.disable_net_connect!(allow: [ + 'api.knapsackpro.com', + 'api-staging.knapsackpro.com', + 'api.knapsackpro.dev', ...
Move web mock above VCR config
diff --git a/app/serializers/application_serializer.rb b/app/serializers/application_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/application_serializer.rb +++ b/app/serializers/application_serializer.rb @@ -2,5 +2,6 @@ attributes :name, :shortname, :archived, :deploy_freeze attribute :status_...
Include default branch in the application JSON serialisation
diff --git a/app/services/admin_reservation_expirer.rb b/app/services/admin_reservation_expirer.rb index abc1234..def5678 100644 --- a/app/services/admin_reservation_expirer.rb +++ b/app/services/admin_reservation_expirer.rb @@ -10,7 +10,7 @@ def expired_reservations if NUCore::Database.oracle? - AdminRes...
Use TO_TIMESTAMP in Oracle comparison with Time.current
diff --git a/virtus.gemspec b/virtus.gemspec index abc1234..def5678 100644 --- a/virtus.gemspec +++ b/virtus.gemspec @@ -19,5 +19,5 @@ gem.add_development_dependency('rake', '~> 0.9.2') gem.add_development_dependency('backports', '~> 2.3.0') - gem.add_development_dependency('rspec', '~> 2.8.0') + gem....
Downgrade rspec to 2.7.0 (specs fail on jruby 1.9)
diff --git a/lib/ab_admin/concerns/validations.rb b/lib/ab_admin/concerns/validations.rb index abc1234..def5678 100644 --- a/lib/ab_admin/concerns/validations.rb +++ b/lib/ab_admin/concerns/validations.rb @@ -3,7 +3,7 @@ module Validations class UniqTranslationValidator < ActiveModel::EachValidator ...
Add locales option to UniqTranslationValidator
diff --git a/lib/haml_user_tags/rails/reloader.rb b/lib/haml_user_tags/rails/reloader.rb index abc1234..def5678 100644 --- a/lib/haml_user_tags/rails/reloader.rb +++ b/lib/haml_user_tags/rails/reloader.rb @@ -14,7 +14,7 @@ # Rails 5.0 says: # DEPRECATION WARNING: to_prepare is deprecated and will be remove...
Resolve to_prepare deprecation warning in Rails 5.0 use ActiveSupport::VERSION::MAJOR instead of ActiveSupport.version.release in order to maintain compatibility with Rails 3, which unfortunately doesn't provide ActiveSupport.version but instead ActiveSupport::VERSION
diff --git a/worker_host/rvm/recipes/default.rb b/worker_host/rvm/recipes/default.rb index abc1234..def5678 100644 --- a/worker_host/rvm/recipes/default.rb +++ b/worker_host/rvm/recipes/default.rb @@ -18,7 +18,7 @@ end bash "installing system-wide RVM stable" do - code "sudo bash -s < <(curl -s https://raw.github.c...
Use new rvm installation procedure. Also add a simple command so that a successful installation doesn't fail the Chef run.
diff --git a/lib/services/notification_service.rb b/lib/services/notification_service.rb index abc1234..def5678 100644 --- a/lib/services/notification_service.rb +++ b/lib/services/notification_service.rb @@ -1,5 +1,5 @@ # -# Copyright (C) 2014 Instructure, Inc. +# Copyright (C) 2014-2016 Instructure, Inc. # # This f...
Fix nil value loading notification service config Closes CNVS-27564 Avoids causing a crash when configuration for the notification service is absent but feature flags are enabled. Also removes the default config options, meaning that notification_service_queue_name is now required in the config. Test plan: - Remove...
diff --git a/lib/slack-notifier/link_formatter.rb b/lib/slack-notifier/link_formatter.rb index abc1234..def5678 100644 --- a/lib/slack-notifier/link_formatter.rb +++ b/lib/slack-notifier/link_formatter.rb @@ -29,11 +29,10 @@ private def fix_encoding string - transcoding_options = { + ...
Use unicode replacement character for invalid data http://en.wikipedia.org/wiki/Specials_(Unicode_block)#Replacement_character
diff --git a/app/controllers/blogs_controller.rb b/app/controllers/blogs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/blogs_controller.rb +++ b/app/controllers/blogs_controller.rb @@ -1,7 +1,11 @@ class BlogsController < ApplicationController before_filter :authenticate_user! before_filter :g...
Add show Action to Blogs Controller Update the Blogs controller to include the show action.
diff --git a/DRYNavigationManager.podspec b/DRYNavigationManager.podspec index abc1234..def5678 100644 --- a/DRYNavigationManager.podspec +++ b/DRYNavigationManager.podspec @@ -8,7 +8,7 @@ s.homepage = "https://github.com/appfoundry/DRYNavigationManager" s.license = 'MIT' s.author = {...
Set repo in podspec to https
diff --git a/app/presenters/courses_presenter.rb b/app/presenters/courses_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/courses_presenter.rb +++ b/app/presenters/courses_presenter.rb @@ -30,7 +30,8 @@ end def courses_by_recent_edits - courses.sort_by(&:recent_edit_count).reverse + # Sort ...
Sort courses secondarily by title
diff --git a/app/presenters/feature_presenter.rb b/app/presenters/feature_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/feature_presenter.rb +++ b/app/presenters/feature_presenter.rb @@ -2,8 +2,6 @@ include ActiveModel::Conversion include Rails.application.routes.url_helpers include PublicDocu...
Remove these as we no longer call image_tag in the presenter
diff --git a/nfl_live_update.gemspec b/nfl_live_update.gemspec index abc1234..def5678 100644 --- a/nfl_live_update.gemspec +++ b/nfl_live_update.gemspec @@ -9,9 +9,9 @@ s.version = NFLLiveUpdate::VERSION s.authors = ["Dave Nguyen"] s.email = ["Dave.Nguyen@inthenight.net"] - s.homepage = "TODO"...
Update homepage, summary, and description
diff --git a/kicker.gemspec b/kicker.gemspec index abc1234..def5678 100644 --- a/kicker.gemspec +++ b/kicker.gemspec @@ -8,6 +8,7 @@ s.name = "kicker" s.version = Kicker::VERSION s.date = Time.new + s.license = 'MIT' s.summary = "A lean, agnostic, flexible file-change watcher." s.description...
[gemspec] Add that this is available under the MIT license. Closes #46.
diff --git a/db/migrate/007_non_nullable_timestamps.rb b/db/migrate/007_non_nullable_timestamps.rb index abc1234..def5678 100644 --- a/db/migrate/007_non_nullable_timestamps.rb +++ b/db/migrate/007_non_nullable_timestamps.rb @@ -0,0 +1,8 @@+class NonNullableTimestamps < ActiveRecord::Migration[4.2] + def change + c...
Add migration: Timestamp properties are non-nullable
diff --git a/db/migrate/20081217001941_create_items.rb b/db/migrate/20081217001941_create_items.rb index abc1234..def5678 100644 --- a/db/migrate/20081217001941_create_items.rb +++ b/db/migrate/20081217001941_create_items.rb @@ -5,18 +5,13 @@ t.float :price, :default => 0.00 t.boolean :situational, :defaul...
Use t.references to associate raids and members to items
diff --git a/omniauth-oauth2.gemspec b/omniauth-oauth2.gemspec index abc1234..def5678 100644 --- a/omniauth-oauth2.gemspec +++ b/omniauth-oauth2.gemspec @@ -5,7 +5,7 @@ Gem::Specification.new do |gem| gem.add_dependency 'faraday', ['>= 0.8', '< 0.10'] gem.add_dependency 'multi_json', '~> 1.3' - gem.add_depende...
Update oauth2 dependency to ~> 0.9.3
diff --git a/lib/domainr.rb b/lib/domainr.rb index abc1234..def5678 100644 --- a/lib/domainr.rb +++ b/lib/domainr.rb @@ -6,7 +6,7 @@ include HTTParty format :json - base_uri 'domainr.com' + base_uri 'api.domainr.com' def self.client_id=(id) @client_id = id @@ -18,12 +18,12 @@ def search(term) ...
Update to new v1 API endpoint
diff --git a/db/migrations/003_create_orders.rb b/db/migrations/003_create_orders.rb index abc1234..def5678 100644 --- a/db/migrations/003_create_orders.rb +++ b/db/migrations/003_create_orders.rb @@ -0,0 +1,9 @@+# encoding: UTF-8 + +migration "Create orders" do + database.create_table :orders do + text :date, :pri...
Create orders table migration added
diff --git a/Casks/adobe-air.rb b/Casks/adobe-air.rb index abc1234..def5678 100644 --- a/Casks/adobe-air.rb +++ b/Casks/adobe-air.rb @@ -1,5 +1,5 @@ cask :v1 => 'adobe-air' do - version '19.0' + version '20.0' sha256 :no_check # required as upstream package is updated in-place url "http://airdownload.adobe.co...
Upgrade Adobe AIR to v20.0
diff --git a/lib/blimpy/engine.rb b/lib/blimpy/engine.rb index abc1234..def5678 100644 --- a/lib/blimpy/engine.rb +++ b/lib/blimpy/engine.rb @@ -17,9 +17,13 @@ begin @fleet = eval(file_content) + if @fleet and !(@fleet.instance_of? Blimpy::Fleet) + raise Exception, 'File does not create...
Make sure that our Blimpfile actually creates a Blimpy::Fleet
diff --git a/lib/garage/tracer.rb b/lib/garage/tracer.rb index abc1234..def5678 100644 --- a/lib/garage/tracer.rb +++ b/lib/garage/tracer.rb @@ -16,7 +16,7 @@ # Any tracers must have `.start` to start tracing context and: # - `#inject_trace_context` to add tracing context to the given request header. # ...
docs: Modify typo of Garage::Tracer::NullTracer's docs
diff --git a/lib/pluck_to_hash.rb b/lib/pluck_to_hash.rb index abc1234..def5678 100644 --- a/lib/pluck_to_hash.rb +++ b/lib/pluck_to_hash.rb @@ -5,7 +5,7 @@ module ClassMethods def pluck_to_hash(keys) - pluck(*keys).map{|row| Hash[*[Array(keys), Array(row)].transpose.flatten]} + pluck(*keys).map{|row...
Fix bug when we ask for a single column and nil is one of the returned values
diff --git a/test/admin_ui/test_page_title.rb b/test/admin_ui/test_page_title.rb index abc1234..def5678 100644 --- a/test/admin_ui/test_page_title.rb +++ b/test/admin_ui/test_page_title.rb @@ -11,6 +11,7 @@ end def test_rails_login_page_title + FactoryGirl.create(:admin) visit "/admin/" assert_text(...
Fix another test ordering issue with admin login changes.
diff --git a/lib/mellon.rb b/lib/mellon.rb index abc1234..def5678 100644 --- a/lib/mellon.rb +++ b/lib/mellon.rb @@ -4,6 +4,9 @@ module Mellon KEYCHAIN_REGEXP = /"(.+)"/ + + class Error < StandardError; end + class CommandError < Error; end class << self def security(*command, &block) @@ -24,7 +27,7 @@...
Raise CommandError on command failures instead of aborting
diff --git a/app/models/spree/gateway/paymill.rb b/app/models/spree/gateway/paymill.rb index abc1234..def5678 100644 --- a/app/models/spree/gateway/paymill.rb +++ b/app/models/spree/gateway/paymill.rb @@ -5,9 +5,6 @@ preference :private_key, :string preference :currency, :string, :default => 'GBP' - attr_...
Remove attr_accessible call from Paymill gateway
diff --git a/app/proposal_states/tabled_state.rb b/app/proposal_states/tabled_state.rb index abc1234..def5678 100644 --- a/app/proposal_states/tabled_state.rb +++ b/app/proposal_states/tabled_state.rb @@ -1,6 +1,6 @@ class TabledState < BaseState def is_open_for_comments? - false + true end def status_...
Allow comments on tabled proposals
diff --git a/lib/boom/color.rb b/lib/boom/color.rb index abc1234..def5678 100644 --- a/lib/boom/color.rb +++ b/lib/boom/color.rb @@ -3,6 +3,8 @@ module Boom # Color collects some methods for colorizing terminal output. module Color + extend self + CODES = { :reset => "\e[0m", :magenta => "...
Extend itself to ease test
diff --git a/pivotal-slacker.gemspec b/pivotal-slacker.gemspec index abc1234..def5678 100644 --- a/pivotal-slacker.gemspec +++ b/pivotal-slacker.gemspec @@ -11,6 +11,7 @@ s.add_dependency "actionpack", "3.2.13" s.add_dependency "launchy" s.add_dependency "commander" + s.add_dependency "active_resource" s.fi...
Add active_resource as a dependency Was missing
diff --git a/lib/fit-commit.rb b/lib/fit-commit.rb index abc1234..def5678 100644 --- a/lib/fit-commit.rb +++ b/lib/fit-commit.rb @@ -16,6 +16,6 @@ end def self.branch_name - `git branch | grep '^\*' | cut -b3-`.strip + `git name-rev --name-only HEAD`.strip end end
Simplify git command to get branch name
diff --git a/lib/html_press.rb b/lib/html_press.rb index abc1234..def5678 100644 --- a/lib/html_press.rb +++ b/lib/html_press.rb @@ -9,11 +9,11 @@ options.each_pair do |key, val| key = key.to_sym case key - when :secret_string: HTMLPress::IdentityParser.secret_string = val - when :...
Fix options declaration for plugin usage.
diff --git a/serverspec/spec/all/all_configure_spec.rb b/serverspec/spec/all/all_configure_spec.rb index abc1234..def5678 100644 --- a/serverspec/spec/all/all_configure_spec.rb +++ b/serverspec/spec/all/all_configure_spec.rb @@ -1,11 +1,13 @@ require_relative '../spec_helper.rb' -describe 'connect to each instance th...
Modify the not perform vertual network connection test in vna or vnmgr
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -8,7 +8,8 @@ 'sdgs:import', 'ndc_sdg_targets:import', 'historical_emissions:import', - 'cait_indc:import' + 'cait_indc:import', + 'adaptation:import' ] desc ...
Add adaptations import to global import task
diff --git a/libPusher.podspec b/libPusher.podspec index abc1234..def5678 100644 --- a/libPusher.podspec +++ b/libPusher.podspec @@ -1,14 +1,22 @@ Pod::Spec.new do |s| s.name = 'libPusher' - s.version = '1.4' + s.version = '1.5' s.license = 'MIT' s.summary = 'An Objective-C client...
Set the header dir and exclude private headers. Bump version.
diff --git a/stateoscope.gemspec b/stateoscope.gemspec index abc1234..def5678 100644 --- a/stateoscope.gemspec +++ b/stateoscope.gemspec @@ -9,8 +9,8 @@ spec.authors = ['Patrick Oscity'] spec.email = ['patrick.oscity@gmail.com'] - spec.summary = %q{State Machine Visualizer} - spec.descripti...
Use %q only for strings that contain both single quotes and double quotes
diff --git a/app/workers/stash_webhook_pinger.rb b/app/workers/stash_webhook_pinger.rb index abc1234..def5678 100644 --- a/app/workers/stash_webhook_pinger.rb +++ b/app/workers/stash_webhook_pinger.rb @@ -20,7 +20,7 @@ include Sidekiq::Worker include Rails.application.routes.url_helpers - sidekiq_options queue:...
Move StashWebhookPinger to high queue Add automatic retries as well. It is critical that this job be run quickly and reliably otherwise developers are blocked from merging their PRs.
diff --git a/db/migrate/20190724131538_create_trade_plus_static.rb b/db/migrate/20190724131538_create_trade_plus_static.rb index abc1234..def5678 100644 --- a/db/migrate/20190724131538_create_trade_plus_static.rb +++ b/db/migrate/20190724131538_create_trade_plus_static.rb @@ -1,7 +1,6 @@ class CreateTradePlusStatic < A...
Remove extra id column from trade_plus_static migration
diff --git a/spec/lib/vimwiki_markdown/options_spec.rb b/spec/lib/vimwiki_markdown/options_spec.rb index abc1234..def5678 100644 --- a/spec/lib/vimwiki_markdown/options_spec.rb +++ b/spec/lib/vimwiki_markdown/options_spec.rb @@ -14,6 +14,25 @@ its(:syntax) { should eq('markdown') } its(:output_fullpath) { ...
Add basic covering spec for extension
diff --git a/spec/services/application_service_spec.rb b/spec/services/application_service_spec.rb index abc1234..def5678 100644 --- a/spec/services/application_service_spec.rb +++ b/spec/services/application_service_spec.rb @@ -11,7 +11,7 @@ end it "returns the Rails application name if no dmproadmap.rb initi...
Fix Spec related to the previous commit
diff --git a/AlamofireImage.podspec b/AlamofireImage.podspec index abc1234..def5678 100644 --- a/AlamofireImage.podspec +++ b/AlamofireImage.podspec @@ -17,5 +17,5 @@ s.osx.deployment_target = '10.9' s.watchos.deployment_target = '2.0' - s.dependency 'Alamofire', '2.0.0' + s.dependency 'Alamofire', '2.0.1' en...
Update podspec to Alamofire 2.0.1
diff --git a/app/controllers/admin/sessions_controller.rb b/app/controllers/admin/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/sessions_controller.rb +++ b/app/controllers/admin/sessions_controller.rb @@ -12,7 +12,7 @@ def create admin = admins_repository.find(email: create_pa...
Fix correct_password? check in sessions controller
diff --git a/app/controllers/api/v1/changes_controller.rb b/app/controllers/api/v1/changes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/changes_controller.rb +++ b/app/controllers/api/v1/changes_controller.rb @@ -1,6 +1,10 @@+require 'xa/util/documents' + module Api module V1 class ...
Use extract_corresponding to build previous
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.29.0.11' + s.version = '0.29.0.12' s.summary = 'Common primitives fo...
Package version is increased from 0.29.0.11 to 0.29.0.12
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.16.0.0' + s.version = '0.16.0.1' s.summary = 'Common primitives for ...
Package version is increased from 0.16.0.0 to 0.16.0.1
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.7.2.0' + s.version = '0.7.2.1' s.summary = 'Messaging primitives for...
Package version is increased from 0.7.2.0 to 0.7.2.1
diff --git a/app/workers/schedulers/stale_issue_marker.rb b/app/workers/schedulers/stale_issue_marker.rb index abc1234..def5678 100644 --- a/app/workers/schedulers/stale_issue_marker.rb +++ b/app/workers/schedulers/stale_issue_marker.rb @@ -4,7 +4,7 @@ sidekiq_options :queue => :miq_bot_glacial, :retry => false ...
Change stale issue marker to Mondays This will activate at midnight (ET) on Sunday night, really.
diff --git a/test/lib/typus/i18n_test.rb b/test/lib/typus/i18n_test.rb index abc1234..def5678 100644 --- a/test/lib/typus/i18n_test.rb +++ b/test/lib/typus/i18n_test.rb @@ -5,6 +5,7 @@ test "t" do assert_equal "Hello", Typus::I18n.t("Hello") assert_equal "Hello", Typus::I18n.t(".hello", :default => "Hello")...
Test to verify Typus::I18n.t interpolation.
diff --git a/test/models/synonym_test.rb b/test/models/synonym_test.rb index abc1234..def5678 100644 --- a/test/models/synonym_test.rb +++ b/test/models/synonym_test.rb @@ -10,9 +10,7 @@ # Make sure there is at least one missing synonym. missing_id = names(:macrolepiota_rachodes).synonym_id - Name.connect...
Rewrite single SQL statement in SynonymTest to AR
diff --git a/activesupport/lib/active_support/descendants_tracker.rb b/activesupport/lib/active_support/descendants_tracker.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/descendants_tracker.rb +++ b/activesupport/lib/active_support/descendants_tracker.rb @@ -1,3 +1,5 @@+require 'active_support...
Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free." This reverts commit 46f6a2e3889bae420589f429b09722a37dbdf18d. Caused failures on CI. rake test:isolated on activesupport directory show them.
diff --git a/features/support/api_extensions.rb b/features/support/api_extensions.rb index abc1234..def5678 100644 --- a/features/support/api_extensions.rb +++ b/features/support/api_extensions.rb @@ -1,8 +1,8 @@ require 'gds_api/json_client' -class GdsApi::CoreApi < GdsApi::Base +class GdsApi::PanopticonApi < GdsApi...
Update example rake task / API extension
diff --git a/NPLumen.podspec b/NPLumen.podspec index abc1234..def5678 100644 --- a/NPLumen.podspec +++ b/NPLumen.podspec @@ -1,38 +1,23 @@-# -# Be sure to run `pod lib lint NPLumen.podspec' to ensure this is a -# valid spec and remove all comments before submitting the spec. -# -# Any lines starting with a # are option...
Update podspec with real data
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -1,2 +1,53 @@ class PagesController < ApplicationController + include IndexHelper + def index + your_values = c...
Add current user logic to pages controller.
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/posts_controller.rb +++ b/app/controllers/posts_controller.rb @@ -1,5 +1,5 @@ class PostsController < ApplicationController - before_action :set_post, only: [:show, :edit, :update,...
Fix to use slug to find posts. Remove unused routes.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -6,4 +6,24 @@ @questions_asked = @user.questions.page(params[:page]).per(3) @questions_answered = Question....
Add edit and update actions
diff --git a/app/presenters/request_presenter.rb b/app/presenters/request_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/request_presenter.rb +++ b/app/presenters/request_presenter.rb @@ -1,6 +1,6 @@ class RequestPresenter < SimpleDelegator def can_vote?(u) - self.user.id != u.id && !self.user.vo...
Use delegated object instead of self when checking vote permissions
diff --git a/Formula/bartycrouch.rb b/Formula/bartycrouch.rb index abc1234..def5678 100644 --- a/Formula/bartycrouch.rb +++ b/Formula/bartycrouch.rb @@ -1,7 +1,7 @@ class Bartycrouch < Formula desc "Incrementally update/translate your Strings files" homepage "https://github.com/Flinesoft/BartyCrouch" - url "http...
Update Homebrew formula to version 4.0.2
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -12,6 +12,12 @@ class ActiveSupport::TestCase self.test_order = :random + DATABASE_CONFIG_PATH = ::File.dirname(__FILE__) << '/database.yml' + + class SpatialModel < ::Activ...
Add a test SpatialModel class * With default database config
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -23,3 +23,7 @@ MiniTest::Reporters.use!(MiniTest::Reporters::SpecReporter.new) +puts "Webhookr #{Webhookr::VERSION}" +puts "Rails #{Rails::VERSION::STRING}" +puts "Ruby #{RUBY_...
Add version information to test output.
diff --git a/app/admin/delivery_update.rb b/app/admin/delivery_update.rb index abc1234..def5678 100644 --- a/app/admin/delivery_update.rb +++ b/app/admin/delivery_update.rb @@ -6,6 +6,14 @@ menu parent: "Delivery updates" filter :study + filter( + :study_study_stage, + as: :select, + collection: Study:...
Add filters to delivery updates for study stage and update statuses
diff --git a/test/test_reader.rb b/test/test_reader.rb index abc1234..def5678 100644 --- a/test/test_reader.rb +++ b/test/test_reader.rb @@ -0,0 +1,48 @@+require 'minitest/autorun' +require 'minitest/pride' +require_relative '../reader.rb' + +describe Feed do + let(:feed) { Feed.new('bbc_rss_feed.xml') } + + it 'shou...
Add test for Feed reader Add tests for Feed reader to ensure that the re-factoring doesn't break it.
diff --git a/adamantium.gemspec b/adamantium.gemspec index abc1234..def5678 100644 --- a/adamantium.gemspec +++ b/adamantium.gemspec @@ -13,7 +13,7 @@ gem.require_paths = %w[lib] gem.files = `git ls-files`.split($/) - gem.test_files = `git ls-files -- {spec}/*`.split($/) + gem.test_files ...
Fix test files in gemspec
diff --git a/SwiftyZeroMQ.podspec b/SwiftyZeroMQ.podspec index abc1234..def5678 100644 --- a/SwiftyZeroMQ.podspec +++ b/SwiftyZeroMQ.podspec @@ -19,8 +19,9 @@ :tag => "#{s.version}" } s.ios.deployment_target = "9.0" + s.macos.deployment_target = "10.11" + s.tvos.deployment_target = "9.0" s.watchos.deploy...
Add MacOS target to cocoapod
diff --git a/test/common_test.rb b/test/common_test.rb index abc1234..def5678 100644 --- a/test/common_test.rb +++ b/test/common_test.rb @@ -0,0 +1,33 @@+require 'minitest/autorun' +require 'shoulda' +require 'pp' + +require 'flappi' + +class ::Flappi::ResponseBuilderTest < MiniTest::Test + + context 'extract_definiti...
Add a test of common
diff --git a/spec/matcher_spec.rb b/spec/matcher_spec.rb index abc1234..def5678 100644 --- a/spec/matcher_spec.rb +++ b/spec/matcher_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +describe Winnow::Matcher do + describe '#find_matches' do + fprint1 = [ + Winnow::Fingerprint.new(0, Winnow::Location.new(0, 0))...
Add some tests for the two-file matcher.
diff --git a/Casks/intellij-idea-ce-eap.rb b/Casks/intellij-idea-ce-eap.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce-eap.rb +++ b/Casks/intellij-idea-ce-eap.rb @@ -1,6 +1,6 @@ cask 'intellij-idea-ce-eap' do - version '144.2925.2' - sha256 '2dacc14f5c1854ba830205624c56c32f53ba6dc200b02e0dddf04133fed1a...
Upgrade IntelliJ IDEA CE EAP to v144.3143.6
diff --git a/Casks/mplayer-osx-extended.rb b/Casks/mplayer-osx-extended.rb index abc1234..def5678 100644 --- a/Casks/mplayer-osx-extended.rb +++ b/Casks/mplayer-osx-extended.rb @@ -1,8 +1,8 @@ class MplayerOsxExtended < Cask - version 'rev15-test3' - sha256 '1543feec27fcc911e35b20a51a00957145f35b1b970b0cb35004c86727e...
Update MPlayer OSX Extended to rev15
diff --git a/periscope.gemspec b/periscope.gemspec index abc1234..def5678 100644 --- a/periscope.gemspec +++ b/periscope.gemspec @@ -22,4 +22,5 @@ s.add_dependency 'activesupport', '~> 3.0.0' s.add_development_dependency 'rspec' + s.add_development_dependency 'activerecord', '>= 3.0.0' end
Add the activerecord 3 development dependency.
diff --git a/api_sketch.gemspec b/api_sketch.gemspec index abc1234..def5678 100644 --- a/api_sketch.gemspec +++ b/api_sketch.gemspec @@ -1,8 +1,5 @@ # coding: utf-8 -# lib = File.expand_path('../lib', __FILE__) -# $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require File.expand_path('../lib/api_sketch/versi...
Add github homepage link at gemspec
diff --git a/db/migrate/20120920213816_remove_products.rb b/db/migrate/20120920213816_remove_products.rb index abc1234..def5678 100644 --- a/db/migrate/20120920213816_remove_products.rb +++ b/db/migrate/20120920213816_remove_products.rb @@ -5,5 +5,27 @@ end def down + create_table "ordered_products", :force =...
Migrate remove_products: no down defined
diff --git a/mogli.gemspec b/mogli.gemspec index abc1234..def5678 100644 --- a/mogli.gemspec +++ b/mogli.gemspec @@ -1,15 +1,15 @@ spec = Gem::Specification.new do |s| s.name = 'mogli' s.version = '0.0.28' - s.summary = "Open Graph Library for Ruby" - s.description = %{Simple library for accessing the facebook ...
Make quotes, parentheses, and spacing more consistent
diff --git a/app/models/post.rb b/app/models/post.rb index abc1234..def5678 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -1,4 +1,6 @@ class Post < ActiveRecord::Base + + validates :title, :body, :user_id, presence: true belongs_to :user
Add validations to Post model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,6 +1,6 @@ class User < ActiveRecord::Base validates :email, presence: true, uniqueness: true, format: /@/ - has_many :actions - has_many :activities + has_many :actions, dep...
Destroy dependent items upon deletion.
diff --git a/lib/dough/helpers/inset_block.rb b/lib/dough/helpers/inset_block.rb index abc1234..def5678 100644 --- a/lib/dough/helpers/inset_block.rb +++ b/lib/dough/helpers/inset_block.rb @@ -13,6 +13,8 @@ renderer.render lookup_context, partial: 'inset_block', locals: { text: text } end + privat...
Revert "Revert "make methods private"" This reverts commit 0932d09b42e8b04ea9accaf1323b21ba7aa0385a.
diff --git a/app/store_image.rb b/app/store_image.rb index abc1234..def5678 100644 --- a/app/store_image.rb +++ b/app/store_image.rb @@ -10,7 +10,7 @@ end def store! - s3_object.put(body: image_binary_data) + s3_object.put(body: image_binary_data, content_type: 'image/jpeg'.freeze) s3_object...
Set file's content-type to image/jpeg Files on s3 are missing a content type. We have to set it on upload.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,5 +1,22 @@ require 'shoulda' +require 'ffi' $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) + +# Since the tests will call Gtk+ functions, Gtk+ must be initi...
Initialize Gtk at test start.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,11 +1,5 @@-# Trying is knowing -if ENV["CODECLIMATE_REPO_TOKEN"] - require "codeclimate-test-reporter" - CodeClimate::TestReporter.start -else - require "simplecov" - Simple...
Fix SimpleCov runner for Travis
diff --git a/lib/react/jsx/jsx_transformer.rb b/lib/react/jsx/jsx_transformer.rb index abc1234..def5678 100644 --- a/lib/react/jsx/jsx_transformer.rb +++ b/lib/react/jsx/jsx_transformer.rb @@ -24,7 +24,7 @@ end # search for transformer file using sprockets - allows user to override - # this file in ...
:memo: Remove male pronoun in comment [ci skip]
diff --git a/lib/gimei.rb b/lib/gimei.rb index abc1234..def5678 100644 --- a/lib/gimei.rb +++ b/lib/gimei.rb @@ -31,6 +31,18 @@ def address Address.new end + + def config + @_config ||= Config.new + end + end + + class Config + attr_accessor :rng + + def initialize + @rng = Rando...
Add Gimei::Config for fixed RNG
diff --git a/lib/pload.rb b/lib/pload.rb index abc1234..def5678 100644 --- a/lib/pload.rb +++ b/lib/pload.rb @@ -57,15 +57,13 @@ module Association def reader(pload: true) - if pload && owner.pload? && !loaded? + return super() unless pload && owner.pload? + + unless loaded? raise Pload...
Make it a little less ugly
diff --git a/lib/worms.rb b/lib/worms.rb index abc1234..def5678 100644 --- a/lib/worms.rb +++ b/lib/worms.rb @@ -3,7 +3,7 @@ require 'rmagick' require 'execjs' -WIDTH, HEIGHT = 600, 600 +WIDTH, HEIGHT = 768, 600 NULL_PIXEL = Magick::Pixel.from_color('none')
Update the WIDTH size of window
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -9,4 +9,5 @@ # Make sure your secret_key_base is kept private # if you're sharing your code publicly. -Shreds::Ap...
Set back secret from env
diff --git a/statsd-ruby.gemspec b/statsd-ruby.gemspec index abc1234..def5678 100644 --- a/statsd-ruby.gemspec +++ b/statsd-ruby.gemspec @@ -17,9 +17,9 @@ s.test_files = s.files.grep(%r{^(test|spec|features)/}) end - s.add_development_dependency "minitest" + s.add_development_dependency "minitest", ">= 3....
Add specific versions for minitest and simplecov * Should fix false failures on CI
diff --git a/app/controllers/activities_controller.rb b/app/controllers/activities_controller.rb index abc1234..def5678 100644 --- a/app/controllers/activities_controller.rb +++ b/app/controllers/activities_controller.rb @@ -15,6 +15,7 @@ end # Educated guessing of person + @activity.person ||= Person.fin...
Use person from parent resource if available in new activity action.
diff --git a/tinyembedly.gemspec b/tinyembedly.gemspec index abc1234..def5678 100644 --- a/tinyembedly.gemspec +++ b/tinyembedly.gemspec @@ -7,7 +7,7 @@ s.version = Tinyembedly::VERSION s.authors = ["Andrew Donaldson"] s.email = ["andrew@desto.net"] - s.homepage = "https://github.com/dies-el/t...
Fix broken url in gemspec